- Devel - libvirt List Archives

[libvirt] debug output?
by Fred Leeflang 28 Sep '09

28 Sep '09

I compiled libvirtd --enable-debug=yes so I can see what's going on, because I'm getting an error libvir: QEMU error : internal error unable to start guest: qemu: could not open disk image. How do I see any debugging output from libvirtd?

2 1

[libvirt] libvirt.py
by Fred Leeflang 27 Sep '09

27 Sep '09

Hello, Just getting started on this and checked out the source from git. Ran autogen.sh, configure, make, make install and it doesn't seem to automatically install libvirt.py. The generated Makefile in python/ has these lines commented out: #GENERATED = libvirt-export.c \ # libvirt.c \ # libvirt.h \ # libvirt.py Am I perhaps missing some python_includes? From what I can tell, WITH_PYTHON_TRUE only gets set to # if some includes are not there. I'm trying to build this on Debian Lenny with Python 2.5.2

2 1

[libvirt] [PATCH] Remove hand-crafted UUID parsers
by Daniel P. Berrange 25 Sep '09

25 Sep '09

* src/libvirt.c: Remove hand-crafted UUID parsers in favour of calling virParseUUID --- src/libvirt.c | 56 +++++--------------------------------------------------- 1 files changed, 5 insertions(+), 51 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 9fb0617..74d62a4 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1839,26 +1839,11 @@ virDomainLookupByUUIDString(virConnectPtr conn, const char *uuidstr) virLibConnError(conn, VIR_ERR_INVALID_ARG, __FUNCTION__); goto error; } - /* XXX: sexpr_uuid() also supports 'xxxx-xxxx-xxxx-xxxx' format. - * We needn't it here. Right? - */ - ret = sscanf(uuidstr, - "%02x%02x%02x%02x-" - "%02x%02x-" - "%02x%02x-" - "%02x%02x-" - "%02x%02x%02x%02x%02x%02x", - raw + 0, raw + 1, raw + 2, raw + 3, - raw + 4, raw + 5, raw + 6, raw + 7, - raw + 8, raw + 9, raw + 10, raw + 11, - raw + 12, raw + 13, raw + 14, raw + 15); - - if (ret!=VIR_UUID_BUFLEN) { + + if (virUUIDParse(uuidstr, uuid) < 0) { virLibConnError(conn, VIR_ERR_INVALID_ARG, __FUNCTION__); goto error; } - for (i = 0; i < VIR_UUID_BUFLEN; i++) - uuid[i] = raw[i] & 0xFF; return virDomainLookupByUUID(conn, &uuid[0]); @@ -5038,26 +5023,10 @@ virNetworkLookupByUUIDString(virConnectPtr conn, const char *uuidstr) goto error; } - /* XXX: sexpr_uuid() also supports 'xxxx-xxxx-xxxx-xxxx' format. - * We needn't it here. Right? - */ - ret = sscanf(uuidstr, - "%02x%02x%02x%02x-" - "%02x%02x-" - "%02x%02x-" - "%02x%02x-" - "%02x%02x%02x%02x%02x%02x", - raw + 0, raw + 1, raw + 2, raw + 3, - raw + 4, raw + 5, raw + 6, raw + 7, - raw + 8, raw + 9, raw + 10, raw + 11, - raw + 12, raw + 13, raw + 14, raw + 15); - - if (ret!=VIR_UUID_BUFLEN) { + if (virUUIDParse(uuidstr, uuid) < 0) { virLibConnError(conn, VIR_ERR_INVALID_ARG, __FUNCTION__); goto error; } - for (i = 0; i < VIR_UUID_BUFLEN; i++) - uuid[i] = raw[i] & 0xFF; return virNetworkLookupByUUID(conn, &uuid[0]); @@ -8887,26 +8856,11 @@ virSecretLookupByUUIDString(virConnectPtr conn, const char *uuidstr) virLibConnError(conn, VIR_ERR_INVALID_ARG, __FUNCTION__); goto error; } - /* XXX: sexpr_uuid() also supports 'xxxx-xxxx-xxxx-xxxx' format. - * We needn't it here. Right? - */ - ret = sscanf(uuidstr, - "%02x%02x%02x%02x-" - "%02x%02x-" - "%02x%02x-" - "%02x%02x-" - "%02x%02x%02x%02x%02x%02x", - raw + 0, raw + 1, raw + 2, raw + 3, - raw + 4, raw + 5, raw + 6, raw + 7, - raw + 8, raw + 9, raw + 10, raw + 11, - raw + 12, raw + 13, raw + 14, raw + 15); - - if (ret!=VIR_UUID_BUFLEN) { + + if (virUUIDParse(uuidstr, uuid) < 0) { virLibConnError(conn, VIR_ERR_INVALID_ARG, __FUNCTION__); goto error; } - for (i = 0; i < VIR_UUID_BUFLEN; i++) - uuid[i] = raw[i] & 0xFF; return virSecretLookupByUUID(conn, &uuid[0]); -- 1.6.2.5

3 3

[libvirt] Virsh migrate --live fails
by Subba Rao, Sandeep M (STSD) 25 Sep '09

25 Sep '09

Hi, I'm trying to live move a domU using virsh migrate command: [root@RHEL53Xen1 ~]# xm list Name ID Mem(MiB) VCPUs State Time(s) Copy_RHELVM3 1 511 1 -b---- 898.3 Domain-0 0 1507 4 r----- 133702.5 [root@RHEL53Xen1 ~]# virsh migrate --live Copy_RHELVM3 xen+ssh://15.154.102.20 error: server closed connection [root@RHEL53Xen1 ~]# However the same works using xm migrate --live. The source and the destination are RHEL 5.3 Xen hosts. Libvirt: [root@RHEL53Xen1 ~]# rpm -qa | grep libvirt libvirt-0.3.3-14.el5 libvirt-devel-0.3.3-14.el5 libvirt-cim-0.5.1-4.el5 libvirt-python-0.3.3-14.el5 Xen: [root@RHEL53Xen1 ~]# rpm -qa | grep xen xen-3.0.3-80.el5 xen-libs-3.0.3-80.el5 xen-devel-3.0.3-80.el5 kernel-xen-2.6.18-128.el5 I was earlier getting the error - "can't connect: Name or service not known". So, installed libvirt-0.6.4 as mentioned in the following link: https://bugzilla.redhat.com/show_bug.cgi?id=348861 After installing libvirt-0.6.4, I'm getting "server closed connection" error. Any help is much appreciated. Thanks, Sandeep

2 2

[libvirt] node device devicekit backend
by Dave Allan 25 Sep '09

25 Sep '09

I've been looking at implementing a libudev backed node device, and I noticed that the devicekit node device backend doesn't build. Since I believe DeviceKit is deprecated for this sort of use, and AFAIK the DeviceKit support was never functionally equivalent to the HAL support, I'm wondering if we can just drop DeviceKit support. It also drags in glib, which is a separate problem. Opinions? Dave

2 1

[libvirt] Miscellaneous fixes to build with -Werror
by Charles Duffy 25 Sep '09

25 Sep '09

HACKING suggests compiling with --enable-compile-warnings=error before submitting any patches; however, current master fails for me on this account (CentOS 5.3; gcc 4.1.2). Please see attached. I suspect most of these should be uncontroversial -- but wonder if perhaps virStrcpy uses would be better converted to virStrcpyStatic rather than adding virStrcpy to the symbol list as done here, and am curious about whether the need for explicit initialization to silence a warning regarding qemudSetLogging's log_level indicates a bug in the macro later used to assign that value.

4 6

[libvirt] Some problem with the save function
by Daniel Berteaud 25 Sep '09

25 Sep '09

Hi everyone. This is my first post to this list, so excuse me if it's not the right place to poste info like this. I've found some problems in qemu_driver.c in the latest versions of libvirt: - the first problem was also present in 0.7.0. If we run qemu guests unprivileged, we cannot use the save function (virsh save guestname /path/to/file). The reason seems to be that libvirt first create the destination file to write the header and the XML definition. The file is owned by root with 600 permission. Then, we ask qemu to append the dump of the memory (via the migrate exec: call) to this file. This part doesn't work because the qemu user cannot write to this file. So we endup with a file which only contains the header and the XML, and the guest is stoped :/ - the second problem is present since libvirt 0.7.1. Now that the saved file can be compressed, it seems we cannot save in a raw format any more. This is due to this part in the code (qemu_driver.c): if (STREQ (prog, "raw")) prog = "cat"; internalret = virAsprintf(&command, "migrate \"exec:" "%s -c >> '%s' 2>/dev/null\"", prog, safe_path); which result in "migrate \"exec cat -c >> safe_path 2>/dev/null\"" But cat doesn't support the -c argument, so once again, the save fails, as we end up with a save file which only contains the header and the XML definition. Unfortunately, my C knowledge is near 0, so I cannot correct this myself. - the third problem, is that restore doesn't work any more. I haven't dig it yet, but when I try to restore a guest using a saved file (uncompressed produced under libvirt 0.7.0), I've this error: virsh restore /tmp/guest.state error: Failed to restore domain from /tmp/guest.state error: internal error unable to start guest: Nothing interesting in /var/log/libvirt/qemu/guest.log: LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin HOME=/root USER=root LOGNAME=root /usr/bin/qemu-kvm -S -M pc -m 2048 -smp 4 -name guest -uuid 37b5937b-eacf-fda6-f4d0-33537d61b414 -monitor unix:/var/lib/libvirt/qemu/guest.monitor,server,nowait -localtime -no-reboot -boot c -drive file=/dev/data/guest,if=ide,index=0,boot=on -drive file=/var/lib/libvirt/iso/boot.iso,if=ide,media=cdrom,index=2 -net nic,macaddr=52:54:00:48:c4:ca,vlan=0,name=nic.0 -net tap,fd=25,vlan=0,name=tap.0 -serial pty -parallel none -usb -usbdevice tablet -vnc 127.0.0.1:0 -k fr -vga cirrus -incoming exec:cat The qemu process eats 100% of CPU during a few seconds, then stops (if I strace it during this time, I see a lot of error like bad file descriptor). Anyone have save/restore functions working with 0.7.1 ? Cheers, Daniel -- Daniel Berteaud FIREWALL-SERVICES SARL. Société de Services en Logiciels Libres Technopôle Montesquieu 33650 MARTILLAC Tel : 05 56 64 15 32 Fax : 05 56 64 15 32 Mail: daniel(a)firewall-services.com Web : http://www.firewall-services.com

5 14

[libvirt] qemu_driver migrateuri handling broken?
by Gregor Schaffrath 24 Sep '09

24 Sep '09

Hi all. Short summary on DV's request ;) I ran into a problem migrating kvm machines with libvirt-0.6.5: 1) At first, using the same syntax for the migrateuri as with xen (just the IP) did not work... looking into the source code (! ;) ), I found a different syntax for qemu. 2) using tcp://<ip>:<port> just produced an 'unknown failure' on the receiving side: root@loadgen137:~> virsh -c qemu:///system migrate --live kvm-testnode-vnode3 qemu+tcp://10.192.11.136/system?no_verify=1 tcp://10.192.11.136:12345 error: Unknown failure (Note: it was working like a charm when I eliminated the migrateuri altogether, but this was not an option in all my work environments, since one of them doesn't feature DNS, breaking migration on the hostname alone (and keeping /etc/hosts in sync on n machines is something I'd like to avoid, if possible ;) )) 3) removing the case distinction and the handling of the migrateuri in the qemudDomainMigratePrepare2 function in qemu_driver.c entirely (if-statement, and full else-part) solved both my issues. --- The issue seems to be current with 0.7.1 as well (at least I did receive the same error message - I did not investigate further) --- My 2ct: ;) I think that a wrapper like libvirt should consequently abstract lower level details (such as 'qemu', or 'xen') as much as possible (that's what libvirt is for, I guess :) ). Since the removal of the URI handling solves both the issue _and_ eliminates a case distinction between xen and qemu (painlessly, as far as I can see), I'd suggest perhaps considering the removal. :) As to the sending side specification of transfer ports: I think there should always be a possiblity to leave port selection up to libvirt, as the sending side does not necessarily an oversight over the free ports on the receiving side. (I feel that the reason for the different syntax including mandatory :port part was motivated by the wish to allow users to specify ports on the sending side) Cheers, Gregor Schaffrath.

3 5

[libvirt] [PATCH] Fix a typo in virDiskHasValidPciAddr()
by Jiri Denemark 24 Sep '09

24 Sep '09

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/conf/domain_conf.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 09368d9..d494e54 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -125,7 +125,7 @@ struct _virDomainDiskDef { static inline int virDiskHasValidPciAddr(virDomainDiskDefPtr def) { - return def->pci_addr.domain || def->pci_addr.domain || def->pci_addr.slot; + return def->pci_addr.domain || def->pci_addr.bus || def->pci_addr.slot; } -- 1.6.5.rc1

3 2

[libvirt] "Unable to read QEMU help output: Interrupted system call" doing virDomainRestore() on current master
by Charles Duffy 24 Sep '09

24 Sep '09

Howdy. I've had this issue since yesterday, but avoided reporting it until determining today that it occurs on an unmodified upstream tree as well as my own local branch: $ virsh restore ramsave error: Failed to restore domain from ramsave error: Unable to read QEMU help output: Interrupted system call This happens immediately (no delay) and only on restore; "virsh start" behaves as usual. When running libvirtd under gdb, the failure mode is different: $ virsh restore ramsave error: Failed to restore domain from ramsave error: internal error Timed out while reading monitor startup output When running libvirtd under strace, this shows the binary being run (["/usr/bin/qemu-kvm", "-help"]) failing with a SIGPIPE while attempting to write to stdout. strace also shows a SIGSEGV being delivered to a libvirtd thread (a few clone()s removed from the parent) after that thread attempts to close all its open file descriptors above 0-2, but without being able to run gdb I'm at a bit of a loss as to what that thread is doing. Any suggestions?

2 1

[libvirt] [PATCH 0/5] Python fixes
by Cole Robinson 23 Sep '09

23 Sep '09

The following series fixes some functional (and cosmetic) issues with the python bindings. Thanks, Cole Cole Robinson (5): python: Don't generate conflicting conn.createXML functions. python: Add a newline between virConnect and virNode for readability. python: Don't generate bindings for vir*Ref python: Use a pure python implementation of 'vir*GetConnect' python: Fix generated virInterface method names python/generator.py | 40 +++++++++++++++++++++++++++++++++++++--- python/virConnect.py | 1 + 2 files changed, 38 insertions(+), 3 deletions(-)

2 8

[libvirt] building libvirtd fails on libxml-2
by Dan Bar Dov 23 Sep '09

23 Sep '09

I'm running on Centos5.3 Building using: ./autogen.sh --prefix=/usr configure fails with checking libxml2 xml2-config >= 2.6.0 ... configure: error: Could not find libxml2 anywhere (see config.log for details). but rpm -qa | grep libxml2 libxml2-python-2.6.26-2.1.2.7 libxml2-2.6.26-2.1.2.7 libxml2-2.6.26-2.1.2.7 So what's the problem, or better yet, how to fix it? Thanks, Dan

3 4

[libvirt] RFC: Rename / move / delete files in GIT
by Daniel P. Berrange 23 Sep '09

23 Sep '09

With the 0.7.1 relesae out of the way I'd like to suggest that we take this time to move around some files in GIT to correct some long standing wierd/bad naming decisions :-) The qemud/ directory is better named 'daemon', and some of the things in there should really have been in the src/ directory. So... * qemud/ -> daemon/ * qemud/qemud.{h,c} daemon/main.{h,c} * qemud/default-network.xml -> src/network/default.xml * qemud/libvirtd_qemu.aug src/qemu/qemu.aug * qemud/test_libvirtd_qemu.aug src/qemu/test_qemu.aug * qemud/remote_protocol.x -> src/remote/remote_protocol.x In the src/ directory we should move the rest of the drivers into their own sub-directories. Basically want one sub directory for each of the 'mod_LTLIBRARIES' declared in the src/Makefile.am. This will ensure we keep separate build dependancies, not accidentally including files that we shouldn't. * src/qemu_*.{c,h} -> src/qemu/ * src/xen_unified.{c,h} -> src/xen/xen_driver.{c,h} * src/xend_*, src/xm_* src/xen_* -> src/xen/ * src/test.{c,h} -> src/test/test_driver.{c,h} * src/storage*.{c,h} -> src/storage/ * src/security*.{c,h} -> src/security/ * src/remote_internal.{c,h} -> src/remote/remote_driver.{c,h} * src/interface_driver.c -> src/interface/netcf_driver.c * src/network_driver.c -> src/network/network_driver.c * src/lxc_* -> src/lxc/ * src/openvz_* -> src/openvz/ * src/node_device* -> src/nodedev/ That would just leave all the shared source files in src/. We could leave them there, or create a src/util/ directory for that stuff. Move virsh into the tools directory * src/virsh.c -> tools/virsh.c * docs/virsh.pod -> tools/virsh.pod * virsh.1: delete from GIT Sanitise naming in python/ directory, to make it clear which are the manually overriden methods. * python/libvir.c -> python/override-api.c * python/libvir.py -> python/override-api.py * python/libvirt-python-api.xml python/override-api.xml * python/libvirt_wrap.h -> python/types.h * python/virConnect.py -> python/override-virConnect.py Cleanup the docs/ directory * docs/*.html.in -> docs/website/ * docs/*.html: delete from GIT * docs/devhelp: delete from GIT * docs/html: delete from GIT * docs/libvirt-{api,refs}.xml: delete from GIT * docs/examples/ -> examples/ * docs/test*xml -> examples/xml/test/ * docs/storage -> examples/xml/storage/ Remove include/libvirt/libvirt.h from GIT For there places where I list 'delete from GIT', we would ensure that when you run 'make dist' the files are still included in the tar.gz NB, we would also update the cron job that deploys the website on libvirt.org soo that it runs 'make' in the docs/website directory to generate the .html files. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

4 8

[libvirt] [PATCH] Allow control over QEMU audio backend
by Daniel P. Berrange 23 Sep '09

23 Sep '09

When using VNC for graphics + keyboard + mouse, we shouldn't then use the host OS for audio. Audio should go back over VNC. When using SDL for graphics, we should use the host OS for audio since that's where the display is. We need to allow certain QEMU env variables to be passed through to guest too to allow choice of QEMU audio backend. * qemud/libvirtd.sysconf: Mention QEMU/SDL audio env vars * src/qemu_conf.c: Passthrough QEMU/SDL audio env for SDL display, disable host audio for VNC display --- daemon/libvirtd.sysconf | 8 ++++++++ src/qemu/qemu_conf.c | 14 ++++++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/daemon/libvirtd.sysconf b/daemon/libvirtd.sysconf index fe4596a..28080a0 100644 --- a/daemon/libvirtd.sysconf +++ b/daemon/libvirtd.sysconf @@ -7,3 +7,11 @@ # Override Kerberos service keytab for SASL/GSSAPI #KRB5_KTNAME=/etc/libvirt/krb5.tab + +# Override the QEMU/SDL default audio driver probing when +# starting virtual machines using SDL graphics +# +# NB these have no effect for VMs using VNC +#QEMU_AUDIO_DRV=sdl +# +#SDL_AUDIODRIVER=pulse diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 273aeca..74ca52b 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -2109,6 +2109,13 @@ int qemudBuildCommandLine(virConnectPtr conn, ADD_ARG_LIT("-k"); ADD_ARG_LIT(def->graphics[0]->data.vnc.keymap); } + + /* QEMU implements a VNC extension for providing audio, so we + * set the audio backend to none, to prevent it opening the + * host OS audio devices since that causes security issues + * and is non-sensical when using VNC. + */ + ADD_ENV_LIT("QEMU_AUDIO_DRV=none"); } else if ((def->ngraphics == 1) && def->graphics[0]->type == VIR_DOMAIN_GRAPHICS_TYPE_SDL) { char *xauth = NULL; @@ -2131,6 +2138,13 @@ int qemudBuildCommandLine(virConnectPtr conn, ADD_ENV(display); if (def->graphics[0]->data.sdl.fullscreen) ADD_ARG_LIT("-full-screen"); + + /* If using SDL for video, then we should just let it + * use QEMU's host audio drivers, possibly SDL too + * User can set these two before starting libvirtd + */ + ADD_ENV_COPY("QEMU_AUDIO_DRV"); + ADD_ENV_COPY("SDL_AUDIODRIVER"); } if (def->nvideos) { -- 1.6.2.5

2 2

[libvirt] ESX: Check if a datastore is accessible before accessing its URL property
by Matthias Bolte 23 Sep '09

23 Sep '09

An inaccessible datastore has no valid URL property. * src/esx/esx_vi.c: esxVI_LookupDatastoreByName(): check if datastore is accessible before accessing its URL property * src/esx/esx_vmx.c: update to changed datastore properties PS: This patch has to be applied after the 12er patch series. Matthias

3 2

[libvirt] ESX [01/12]: Add esxNodeGetFreeMemory()
by Matthias Bolte 23 Sep '09

23 Sep '09

* src/esx/esx_driver.c: add esxNodeGetFreeMemory(), cache IP address * src/esx/esx_vi.[ch]: refactor resource pool query into esxVI_GetResourcePool() * src/esx/esx_vi_types.[ch]: bind VI type ResourcePoolResourceUsage

3 2

[libvirt] [PATCH] Fix up "make check"
by Chris Lalancette 23 Sep '09

23 Sep '09

While running make check, I noticed that it was actually using the virsh binary from my system, in /usr/bin/virsh, and not the one that was just compiled. This doesn't seem to be the intent, so I changed all of the test scripts to point to the one built in-tree, not the system one. Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- tests/cpuset | 6 +++--- tests/define-dev-segfault | 4 ++-- tests/libvirtd-pool | 4 ++-- tests/read-bufsiz | 6 +++--- tests/read-non-seekable | 6 +++--- tests/start | 4 ++-- tests/test_conf.sh | 2 +- tests/undefine | 8 ++++---- tests/vcpupin | 6 +++--- tests/virsh-all | 6 +++--- tests/virsh-synopsis | 6 +++--- 11 files changed, 29 insertions(+), 29 deletions(-) diff --git a/tests/cpuset b/tests/cpuset index eeb0ee2..a3abe14 100755 --- a/tests/cpuset +++ b/tests/cpuset @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi . $srcdir/test-lib.sh @@ -26,7 +26,7 @@ fi fail=0 # generate input -virsh --connect test:///default dumpxml 1 > xml || fail=1 +$abs_top_builddir/tools/virsh --connect test:///default dumpxml 1 > xml || fail=1 # require the presence of the string we'll transform grep '<vcpu>' xml > /dev/null || fail=1 @@ -34,7 +34,7 @@ grep '<vcpu>' xml > /dev/null || fail=1 sed "s/vcpu>/vcpu cpuset='aaa'>/" xml > xml-invalid || fail=1 # Require failure and a diagnostic. -virsh --connect test:///default define xml-invalid > out 2>&1 && fail=1 +$abs_top_builddir/tools/virsh --connect test:///default define xml-invalid > out 2>&1 && fail=1 cat <<\EOF > exp || fail=1 error: Failed to define domain from xml-invalid error: failed Xen syscall topology cpuset syntax error diff --git a/tests/define-dev-segfault b/tests/define-dev-segfault index 4ae286f..cce1c07 100755 --- a/tests/define-dev-segfault +++ b/tests/define-dev-segfault @@ -4,7 +4,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi test -z "$srcdir" && srcdir=$(pwd) @@ -62,7 +62,7 @@ cat <<\EOF > D.xml || fail=1 EOF url=test:///default -virsh --connect "$url" 'define D.xml; dumpxml D' > out 2>&1 || fail=1 +$abs_top_builddir/tools/virsh --connect "$url" 'define D.xml; dumpxml D' > out 2>&1 || fail=1 cat > exp <<EOF || fail=1 Domain D defined from D.xml diff --git a/tests/libvirtd-pool b/tests/libvirtd-pool index 59da5a6..96da111 100755 --- a/tests/libvirtd-pool +++ b/tests/libvirtd-pool @@ -3,7 +3,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi test -z "$srcdir" && srcdir=$(pwd) @@ -14,7 +14,7 @@ fail=0 pwd=$(pwd) || fail=1 -virsh --connect test:///default \ +$abs_top_builddir/tools/virsh --connect test:///default \ pool-define-as --print-xml \ P dir src-host /src/path /src/dev S /target-path \ 1>out 2>&1 diff --git a/tests/read-bufsiz b/tests/read-bufsiz index 7d53735..9652817 100755 --- a/tests/read-bufsiz +++ b/tests/read-bufsiz @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi test -z "$srcdir" && srcdir=`pwd` @@ -29,7 +29,7 @@ test -z "$abs_top_srcdir" && abs_top_srcdir=`pwd`/.. fail=0 # Output a valid definition, to be used as input. -virsh -c test:///default dumpxml 1 > xml || fail=1 +$abs_top_builddir/tools/virsh -c test:///default dumpxml 1 > xml || fail=1 for i in before after; do # The largest BUFSIZ I've seen is 128K. This is slightly larger. @@ -38,7 +38,7 @@ for i in before after; do # Append or prepend enough spaces to push the size over the limit: ( test $i = before && cat sp xml || cat xml sp ) > $in || fail=1 - virsh --connect test:///default define $in > out || fail=1 + $abs_top_builddir/tools/virsh --connect test:///default define $in > out || fail=1 printf "Domain test defined from $in\n\n" > exp || fail=1 compare exp out || fail=1 done diff --git a/tests/read-non-seekable b/tests/read-non-seekable index 8a7bdcd..648def6 100755 --- a/tests/read-non-seekable +++ b/tests/read-non-seekable @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi . $srcdir/test-lib.sh @@ -40,11 +40,11 @@ cat <<\EOF > dom </domain> EOF -virsh -c test:///default define dom > /dev/null || fail=1 +$abs_top_builddir/tools/virsh -c test:///default define dom > /dev/null || fail=1 mkfifo_or_skip_ fifo cat dom > fifo & -virsh -c test:///default define fifo > /dev/null || fail=1 +$abs_top_builddir/tools/virsh -c test:///default define fifo > /dev/null || fail=1 (exit $fail); exit $fail diff --git a/tests/start b/tests/start index f457d59..6f7815a 100755 --- a/tests/start +++ b/tests/start @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi test -z "$srcdir" && srcdir=$(pwd) @@ -30,7 +30,7 @@ fail=0 test_url=test:///default # expect this to fail -virsh -c $test_url start test > out 2> err && fail=1 +$abs_top_builddir/tools/virsh -c $test_url start test > out 2> err && fail=1 # stdout gets a newline echo > exp || fail=1 diff --git a/tests/test_conf.sh b/tests/test_conf.sh index 62c2324..2754765 100755 --- a/tests/test_conf.sh +++ b/tests/test_conf.sh @@ -2,7 +2,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi . $srcdir/test-lib.sh diff --git a/tests/undefine b/tests/undefine index fafdae7..048a98b 100755 --- a/tests/undefine +++ b/tests/undefine @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi . $srcdir/test-lib.sh @@ -26,7 +26,7 @@ fi fail=0 # Attempt to undefine a running domain, by domain name. -virsh -q -c test:///default undefine test > out 2>&1 +$abs_top_builddir/tools/virsh -q -c test:///default undefine test > out 2>&1 test $? = 1 || fail=1 cat <<\EOF > exp || fail=1 error: Failed to undefine domain test @@ -35,7 +35,7 @@ EOF compare exp out || fail=1 # A different diagnostic when specifying a domain ID -virsh -q -c test:///default undefine 1 > out 2>&1 +$abs_top_builddir/tools/virsh -q -c test:///default undefine 1 > out 2>&1 test $? = 1 || fail=1 cat <<\EOF > exp || fail=1 error: a running domain like 1 cannot be undefined; @@ -44,7 +44,7 @@ EOF compare exp out || fail=1 # Succeed, now: first shut down, then undefine, both via name. -virsh -q -c test:///default 'shutdown test; undefine test' > out 2>&1 +$abs_top_builddir/tools/virsh -q -c test:///default 'shutdown test; undefine test' > out 2>&1 test $? = 0 || fail=1 cat <<\EOF > exp || fail=1 Domain test is being shutdown diff --git a/tests/vcpupin b/tests/vcpupin index 79b02dc..c243d80 100755 --- a/tests/vcpupin +++ b/tests/vcpupin @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi . $srcdir/test-lib.sh @@ -26,7 +26,7 @@ fi fail=0 # Invalid syntax. -virsh --connect test:///default vcpupin test a 0,1 > out 2>&1 +$abs_top_builddir/tools/virsh --connect test:///default vcpupin test a 0,1 > out 2>&1 test $? = 1 || fail=1 cat <<\EOF > exp || fail=1 error: vcpupin: Invalid or missing vCPU number. @@ -35,7 +35,7 @@ EOF compare exp out || fail=1 # An out-of-range vCPU number deserves a diagnostic, too. -virsh --connect test:///default vcpupin test 100 0,1 > out 2>&1 +$abs_top_builddir/tools/virsh --connect test:///default vcpupin test 100 0,1 > out 2>&1 test $? = 1 || fail=1 cat <<\EOF > exp || fail=1 error: vcpupin: Invalid vCPU number. diff --git a/tests/virsh-all b/tests/virsh-all index 03ea466..6accf44 100755 --- a/tests/virsh-all +++ b/tests/virsh-all @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi test -z "$srcdir" && srcdir=$(pwd) @@ -29,14 +29,14 @@ fail=0 test_url=test:///default -virsh -c $test_url help > cmds || framework_failure +$abs_top_builddir/tools/virsh -c $test_url help > cmds || framework_failure cmds=$(sed -n 's/^ $[^ ][^ ]*$ .*/\1/p' cmds) || framework_failure test -n "$cmds" || framework_failure for i in $cmds; do echo testing $i... 1>&2 # For now, just run the command and ignore output and exit status. - virsh -c $test_url $i < /dev/null > /dev/null 2>&1 + $abs_top_builddir/tools/virsh -c $test_url $i < /dev/null > /dev/null 2>&1 done (exit $fail); exit $fail diff --git a/tests/virsh-synopsis b/tests/virsh-synopsis index 24038dd..e700993 100755 --- a/tests/virsh-synopsis +++ b/tests/virsh-synopsis @@ -18,7 +18,7 @@ if test "$VERBOSE" = yes; then set -x - virsh --version + $abs_top_builddir/tools/virsh --version fi test -z "$srcdir" && srcdir=$(pwd) @@ -28,12 +28,12 @@ fail=0 test_url=test:///default -virsh -c $test_url help > cmds || framework_failure +$abs_top_builddir/tools/virsh -c $test_url help > cmds || framework_failure cmds=$(sed -n 's/^ $[^ ][^ ]*$ .*/\1/p' cmds) || framework_failure test -n "$cmds" || framework_failure for i in $cmds; do - virsh -c $test_url help $i > help || fail=1 + $abs_top_builddir/tools/virsh -c $test_url help $i > help || fail=1 grep -A1 '^ SYNOPSIS$' help > synopsis \ || { echo 1>&2 missing or invalid help SYNOPSIS for $i; fail=1; } sed -n 2p synopsis > s2 || framework_failure -- 1.6.0.6

2 2

[libvirt] virsh capabilities, kvm with apic and toggle
by Garry Dolley 23 Sep '09

23 Sep '09

When I run 'virsh capabilities' on a libvirt 0.6.4 system with qemu 0.10 and kvm-84, one of the results I get is: <guest> <os_type>hvm</os_type> <arch name='x86_64'> <wordsize>64</wordsize> <emulator>/usr/bin/qemu-system-x86_64</emulator> <machine>pc</machine> <machine>isapc</machine> <domain type='qemu'> </domain> <domain type='kvm'> <emulator>/usr/bin/kvm</emulator> </domain> </arch> <features> <acpi default='on' toggle='yes'/> <apic default='on' toggle='no'/> </features> </guest> I'm wondering why the "apic" feature can't be toggled. Passing -no-kvm-irqchip to kvm would turn off "PIC/IOAPIC/LAPIC" -- Garry Dolley ARP Networks, Inc. | http://www.arpnetworks.com | (818) 206-0181 Data center, VPS, and IP Transit solutions Member Los Angeles County REACT, Unit 336 | WQGK336 Blog http://scie.nti.st

2 1

[libvirt] [RFC,PATCH] network: add 'netboot' option to dhcp config
by Jeremy Kerr 23 Sep '09

23 Sep '09

Currently, libvirtd will start a dnsmasq process for the virtual network, but (aside from killing the dnsmasq process and replacing it), there's no way to define tftp boot options. This change introduces a 'netboot' tag to the dhcp configuration: <network> <name>default</name> <bridge name="virbr%d" /> <forward/> <ip address="192.168.122.1" netmask="255.255.255.0"> <dhcp> <range start="192.168.122.2" end="192.168.122.254" /> <netboot root="/srv/tftp" file="pxeboot.img"/> </dhcp> </ip> </network> When root= and file= attributes are present, these are passed to the arguments to dnsmasq: dnsmasq [...] --enable-tftp --tftp-root /srv/tftp --dhcp-boot pxeboot.img At present, only local tftp servers are supported (ie, dnsmasq runs as the tftp server), but we could improve this in future by adding a server= attribute. Signed-off-by: Jeremy Kerr <jk(a)ozlabs.org> --- docs/formatnetwork.html.in | 6 ++++++ docs/schemas/network.rng | 6 ++++++ src/network_conf.c | 28 ++++++++++++++++++++++++++++ src/network_conf.h | 9 +++++++++ src/network_driver.c | 10 ++++++++++ 5 files changed, 59 insertions(+) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index fd68430..3186498 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -138,6 +138,12 @@ name to be given that host by the DHCP server (via the <code>name</code> attribute). <span class="since">Since 0.4.5</span> </dd> + <dt><code>netboot</code></dt> + <dd>The optional <code>netboot</code> element specified network boot + options to be provided by the DHCP server. Two attributes are + required: <code>root</code> (the root path of the TFTP server), and + <code>file</code> (the file to be used for the boot image). + </dd> </dl> <h2><a name="examples">Example configuration</a></h2> diff --git a/docs/schemas/network.rng b/docs/schemas/network.rng index a4281a5..571e916 100644 --- a/docs/schemas/network.rng +++ b/docs/schemas/network.rng @@ -76,6 +76,12 @@ <attribute name="ip"><text/></attribute> </element> </zeroOrMore> + <optional> + <element name="netboot"> + <attribute name="root"><text/></attribute> + <attribute name="file"><text/></attribute> + </element> + </optional> </element> </element> </optional> diff --git a/src/network_conf.c b/src/network_conf.c index 3764bb4..87bb5e4 100644 --- a/src/network_conf.c +++ b/src/network_conf.c @@ -115,6 +115,9 @@ void virNetworkDefFree(virNetworkDefPtr def) } VIR_FREE(def->hosts); + VIR_FREE(def->tftproot); + VIR_FREE(def->bootfile); + VIR_FREE(def); } @@ -299,6 +302,24 @@ virNetworkDHCPRangeDefParseXML(virConnectPtr conn, def->hosts[def->nhosts].name = (char *)name; def->hosts[def->nhosts].ip = (char *)ip; def->nhosts++; + + } else if (cur->type == XML_ELEMENT_NODE && + xmlStrEqual(cur->name, BAD_CAST "netboot")) { + xmlChar *root, *file; + + if (!(root = xmlGetProp(cur, BAD_CAST "root"))) { + cur = cur->next; + continue; + } + + if (!(file = xmlGetProp(cur, BAD_CAST "file"))) { + cur = cur->next; + xmlFree(root); + continue; + } + + def->tftproot = (char *)root; + def->bootfile = (char *)file; } cur = cur->next; @@ -621,6 +642,13 @@ char *virNetworkDefFormat(virConnectPtr conn, virBufferVSprintf(&buf, "ip='%s' ", def->hosts[i].ip); virBufferAddLit(&buf, "/>\n"); } + if (virNetworkDefProvidesNetboot(def)) { + virBufferAddLit(&buf, " <netboot"); + virBufferEscapeString(&buf, " root='%s'", def->tftproot); + virBufferEscapeString(&buf, " file='%s'", def->bootfile); + virBufferAddLit(&buf, " />\n"); + } + virBufferAddLit(&buf, " </dhcp>\n"); } diff --git a/src/network_conf.h b/src/network_conf.h index 4076f9a..f6f7c1e 100644 --- a/src/network_conf.h +++ b/src/network_conf.h @@ -78,8 +78,17 @@ struct _virNetworkDef { unsigned int nhosts; /* Zero or more dhcp hosts */ virNetworkDHCPHostDefPtr hosts; + + char *tftproot; + char *bootfile; }; +static inline int +virNetworkDefProvidesNetboot(const virNetworkDefPtr def) +{ + return def->tftproot && def->bootfile; +} + typedef struct _virNetworkObj virNetworkObj; typedef virNetworkObj *virNetworkObjPtr; struct _virNetworkObj { diff --git a/src/network_driver.c b/src/network_driver.c index 49855bf..cf462f2 100644 --- a/src/network_driver.c +++ b/src/network_driver.c @@ -400,6 +400,8 @@ networkBuildDnsmasqArgv(virConnectPtr conn, (2 * network->def->nranges) + /* --dhcp-range 10.0.0.2,10.0.0.254 */ /* --dhcp-host 01:23:45:67:89:0a,hostname,10.0.0.3 */ (2 * network->def->nhosts) + + /* --enable-tftp --tftp-root /srv/tftp --dhcp-boot pxeboot.img */ + (virNetworkDefProvidesNetboot(network->def) ? 5 : 0) + 1; /* NULL */ if (VIR_ALLOC_N(*argv, len) < 0) @@ -478,6 +480,14 @@ networkBuildDnsmasqArgv(virConnectPtr conn, APPEND_ARG(*argv, i++, buf); } + if (virNetworkDefProvidesNetboot(network->def)) { + APPEND_ARG(*argv, i++, "--enable-tftp"); + APPEND_ARG(*argv, i++, "--tftp-root"); + APPEND_ARG(*argv, i++, network->def->tftproot); + APPEND_ARG(*argv, i++, "--dhcp-boot"); + APPEND_ARG(*argv, i++, network->def->bootfile); + } + #undef APPEND_ARG return 0;

8 17

[libvirt] [PATCH] virStrncpy
by Chris Lalancette 22 Sep '09

22 Sep '09

Next revision of the virStrncpy patch. This one has the feedback from Mattias Bolte incorporated in, and passes all of the "make check" tests. I've also done basic testing on the hypervisors I have access to, (xen and kvm) and it seems to work there. That doesn't guarantee that it is bug-free, but most of the problems have been ironed out.

3 6

[libvirt] [RFC] Support for CPUID masking v2
by Jiri Denemark 22 Sep '09

22 Sep '09

Hi, This is an attempt to provide similar flexibility to CPU ID masking without being x86-specific and unfriendly to users. As suggested by Dan, we need a way to specify both CPU flags and topology to achieve this goal. Firstly, CPU topology and all (actually all that libvirt knows about) CPU features have to be advertised in host capabilities: <host> <cpu> ... <features> <feature>NAME</feature> </features> <topology> <sockets>NUMBER_OF_SOCKETS</sockets> <cores>CORES_PER_SOCKET</cores> <threads>THREADS_PER_CORE</threads> </topology> </cpu> ... </host> I'm not 100% sure we should represent CPU features as <feature>NAME</feature> especially because some features are currently advertised as <NAME/>. However, extending XML schema every time a new feature is introduced doesn't look like a good idea at all. The problem is we can't get rid of <NAME/>-style features, which would result in redundancy: <features> <vmx/> <feature>vmx</feature> </features> But I think it's better than changing the schema to add new features. Secondly, drivers which support detailed CPU specification have to advertise it in guest capabilities. In case <features> are meant to be hypervisor features, than it could look like: <guest> ... <features> <cpu/> </features> </guest> But if they are meant to be CPU features, we need to come up with something else: <guest> ... <cpu_selection/> </guest> I'm not sure how to deal with named CPUs suggested by Dan. Either we need to come up with global set of named CPUs and document what they mean or let drivers specify their own named CPUs and advertise them through guest capabilities: <guest> ... <cpu model="NAME"> <feature>NAME</feature> ... </cpu> </guest> The former approach would make matching named CPUs with those defined by a hypervisor (such as qemu) quite hard. The latter could bring the need for hardcoding features provided by specific CPU models or, in case we decide not to provide a list of features for each CPU model, it can complicate transferring a domain from one hypervisor to another. And finally, CPU may be configured in domain XML configuration: <domain> ... <cpu model="NAME"> <topology> <sockets>NUMBER_OF_SOCKETS</sockets> <cores>CORES_PER_SOCKET</cores> <threads>THREADS_PER_CORE</threads> </topology> <feature name="NAME" mode="set|check" value="on|off"/> </cpu> </domain> Mode 'check' checks physical CPU for the feature and refuses the domain to start if it doesn't match. VCPU feature is set to the same value. Mode 'set' just sets the VCPU feature. Final note: <topology> could also be called <cpu_topology> to avoid confusion with NUMA <topology>, which is used in host capabilities. However, I prefer <cpu><topology>...</topology></cpu> over <cpu><cpu_topology>...</cpu_topology></cpu>. Thanks for your comments. Jirka

5 10

[libvirt] Fix Xen virConnectPtr leak
by Matthias Bolte 22 Sep '09

22 Sep '09

The commit cb51aa48a777ddae6997faa9f28350cb62655ffd "Fix up connection reference counting." changed the driver closing and virConnectPtr unref-logic in virConnectClose(). Before this commit virConnectClose() closed all drivers of the given virConnectPtr and virUnrefConnect()'ed it afterwards. After this commit the driver-closing is done in virUnrefConnect() if and only if the ref-count of the virConnectPtr dropped to zero. This change in execution order leads to a virConnectPtr leak, at least for connections to Xen. The relevant call sequences: virConnectOpen() -> xenUnifiedOpen() ... ... xenInotifyOpen() -> virConnectRef(conn) ... xenStoreOpen() -> xenStoreAddWatch() -> conn->refs++ virConnectClose() -> xenUnifiedClose() ... ... xenInotifyClose() -> virUnrefConnect(conn) ... xenStoreClose() -> xenStoreRemoveWatch() -> virUnrefConnect(conn) Before the commit this additional virConnectRef/virUnrefConnect calls where no problem, because virConnectClose() closed the drivers explicitly and the additional refs added by the Xen subdrivers were removed properly. After the commit this additional refs result in a virConnectPtr leak (including a leak of the hypercall file handle; that's how I noticed this problem), because now the drivers are only close if and only if the ref-count drops to zero, but this cannot happen anymore, because the additional refs from the Xen subdrivers would only be removed if the drivers get closed, but that doesn't happen because the ref-count cannot drop to zero. The fix for this problem is simple: remove the virConnectRef/virUnrefConnect calls from the Xen subdrivers (see attached patch). Maybe someone could explain why the Xen Inotify and Xen Store driver do this extra ref-counting, but none of the other Xen subdrivers. It seems unnecessary to me and can be removed without problems. Matthias

3 3

[libvirt] kvm networking () on debian unstable
by Thomas Koch 22 Sep '09

22 Sep '09

Hi, I'm trying to get NAT networking running as described in http://libvirt.org/formatnetwork.html#examplesNAT But in the guest, ifconfig shows only the lo interface. I created the kvm image (debian lenny 5.0.3) directly with qemu-img and kvm, because virt- install also didn't work. Afterwards I created the XML file for libvirt: <domain type='kvm'> <name>hadoop1</name> <uuid>c40b6644-362a-e5ab-8825-cd1a7fbe24eb</uuid> <memory>524288</memory> <currentMemory>524288</currentMemory> <vcpu>1</vcpu> <os> <type arch='x86_64' machine='pc'>hvm</type> <boot dev='hd'/> </os> <features> <acpi/> <apic/> <pae/> </features> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <emulator>/usr/bin/kvm</emulator> <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/var/lib/libvirt/images/hadoop1.qcow2'/> <target dev='hda' bus='ide'/> </disk> <interface type='network'> <mac address='52:54:00:05:74:bb'/> <source network='default'/> <model type='virtio'/> </interface>  <input type='mouse' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' keymap='de-ch'/> <video> <model type='cirrus' vram='9216' heads='1'/> </video> </devices> </domain> The network config is: <network> <name>default</name> <bridge name="virbr0" /> <forward/> <ip address="192.168.122.1" netmask="255.255.255.0"> <dhcp> <range start="192.168.122.2" end="192.168.122.254" /> </dhcp> </ip> </network> ifconfig of the host (needs cleanup, I know): eth1 Link encap:Ethernet Hardware Adresse 00:1c:25:18:4d:e6 UP BROADCAST RUNNING MULTICAST MTU:1500 Metrik:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 Kollisionen:0 Sendewarteschlangenlänge:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) Speicher:fe200000-fe220000 eth1:avahi Link encap:Ethernet Hardware Adresse 00:1c:25:18:4d:e6 inet Adresse:169.254.6.97 Bcast:169.254.255.255 Maske:255.255.0.0 UP BROADCAST RUNNING MULTICAST MTU:1500 Metrik:1 Speicher:fe200000-fe220000 lo Link encap:Lokale Schleife inet Adresse:127.0.0.1 Maske:255.0.0.0 inet6-Adresse: ::1/128 Gültigkeitsbereich:Maschine UP LOOPBACK RUNNING MTU:16436 Metrik:1 RX packets:160751 errors:0 dropped:0 overruns:0 frame:0 TX packets:160751 errors:0 dropped:0 overruns:0 carrier:0 Kollisionen:0 Sendewarteschlangenlänge:0 RX bytes:27262569 (25.9 MiB) TX bytes:27262569 (25.9 MiB) virbr0 Link encap:Ethernet Hardware Adresse 4a:30:15:4d:b5:0d inet Adresse:192.168.122.1 Bcast:192.168.122.255 Maske:255.255.255.0 inet6-Adresse: fe80::8804:ecff:febc:fa54/64 Gültigkeitsbereich:Verbindung UP BROADCAST RUNNING MULTICAST MTU:1500 Metrik:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:299 errors:0 dropped:0 overruns:0 carrier:0 Kollisionen:0 Sendewarteschlangenlänge:0 RX bytes:0 (0.0 B) TX bytes:47842 (46.7 KiB) vnet0 Link encap:Ethernet Hardware Adresse 4a:30:15:4d:b5:0d inet6-Adresse: fe80::4830:15ff:fe4d:b50d/64 Gültigkeitsbereich:Verbindung UP BROADCAST RUNNING MULTICAST MTU:1500 Metrik:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:128 errors:0 dropped:0 overruns:0 carrier:0 Kollisionen:0 Sendewarteschlangenlänge:500 RX bytes:0 (0.0 B) TX bytes:16426 (16.0 KiB) wlan0 Link encap:Ethernet Hardware Adresse 00:1d:e0:08:89:21 inet Adresse:192.168.178.23 Bcast:192.168.178.255 Maske:255.255.255.0 inet6-Adresse: fe80::21d:e0ff:fe08:8921/64 Gültigkeitsbereich:Verbindung UP BROADCAST RUNNING MULTICAST MTU:1500 Metrik:1 RX packets:10608 errors:0 dropped:0 overruns:0 frame:0 TX packets:10358 errors:0 dropped:0 overruns:0 carrier:0 Kollisionen:0 Sendewarteschlangenlänge:1000 RX bytes:7515487 (7.1 MiB) TX bytes:1367200 (1.3 MiB) wmaster0 Link encap:UNSPEC Hardware Adresse 00-1D- E0-08-89-21-00-00-00-00-00-00-00-00-00-00 UP BROADCAST RUNNING MULTICAST MTU:1500 Metrik:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 Kollisionen:0 Sendewarteschlangenlänge:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) Thanks for any help, Thomas Koch, http://www.koch.ro

2 2

[libvirt] [PATCH] tiny tiny typos
by Dan Kenigsberg 22 Sep '09

22 Sep '09

--- docs/auth.html.in | 2 +- docs/downloads.html.in | 2 +- docs/errors.html | 2 +- docs/errors.html.in | 2 +- docs/formatdomain.html.in | 2 +- docs/java.html.in | 2 +- docs/news.html.in | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/auth.html.in b/docs/auth.html.in index 04b1210..5e5497e 100644 --- a/docs/auth.html.in +++ b/docs/auth.html.in @@ -151,7 +151,7 @@ Plugin "gssapiv2" [loaded], API version: 4 features: WANT_CLIENT_FIRST|PROXY_AUTHENTICATION|NEED_SERVER_FQDN </pre> <p> -Next is is necessary for the administrator of the Kerberos realm to issue a principle +Next is necessary for the administrator of the Kerberos realm to issue a principle for the libvirt server. There needs to be one principle per host running the libvirt daemon. The principle should be named <code>libvirt/full.hostname(a)KERBEROS.REALM</code>. This is typically done by running the <code>kadmin.local</code> command on the Kerberos diff --git a/docs/downloads.html.in b/docs/downloads.html.in index a34ddd1..493923c 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -60,7 +60,7 @@ <p> The libvirt build process uses GNU autotools, so after obtaining a checkout it is necessary to generate the configure script and Makefile.in templates using the <code>autogen.sh</code> command, passing the extra - arguments as as for configure. As an example, to do a complete build and + arguments as for configure. As an example, to do a complete build and install it into your home directory run:</p> <pre> diff --git a/docs/errors.html b/docs/errors.html index dad8c69..c34bcd8 100644 --- a/docs/errors.html +++ b/docs/errors.html @@ -107,7 +107,7 @@ to 0 or NULL if unused</p> <ul><li>str1, str2, str3: string information, usually str1 is the error message format</li><li>int1, int2: integer information</li></ul> <p>So usually, setting up specific error handling with libvirt consist of -registering an handler with with <a href="html/libvirt-virterror.html#virSetErrorFunc">virSetErrorFunc</a> or +registering a handler with <a href="html/libvirt-virterror.html#virSetErrorFunc">virSetErrorFunc</a> or with <a href="html/libvirt-virterror.html#virConnSetErrorFunc">virConnSetErrorFunc</a>, check the value of the code value, take appropriate action, if needed let libvirt print the error on stderr by calling <a href="html/libvirt-virterror.html#virDefaultErrorFunc">virDefaultErrorFunc</a>. diff --git a/docs/errors.html.in b/docs/errors.html.in index 57cbe6f..cbd6e4b 100644 --- a/docs/errors.html.in +++ b/docs/errors.html.in @@ -58,7 +58,7 @@ to 0 or NULL if unused</p> <li>int1, int2: integer information</li> </ul> <p>So usually, setting up specific error handling with libvirt consist of -registering an handler with with <a href="html/libvirt-virterror.html#virSetErrorFunc">virSetErrorFunc</a> or +registering a handler with <a href="html/libvirt-virterror.html#virSetErrorFunc">virSetErrorFunc</a> or with <a href="html/libvirt-virterror.html#virConnSetErrorFunc">virConnSetErrorFunc</a>, check the value of the code value, take appropriate action, if needed let libvirt print the error on stderr by calling <a href="html/libvirt-virterror.html#virDefaultErrorFunc">virDefaultErrorFunc</a>. diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 915814d..49b212e 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -500,7 +500,7 @@ </interface> ...</pre> - <h5><a name="elementsNICSBridge">Bridge to to LAN</a></h5> + <h5><a name="elementsNICSBridge">Bridge to LAN</a></h5> <p> <strong><em> diff --git a/docs/java.html.in b/docs/java.html.in index 5c659bb..d3e3ebc 100644 --- a/docs/java.html.in +++ b/docs/java.html.in @@ -5,7 +5,7 @@ <h2>Presentation</h2> <p>The Java bindings make use of <a href="https://jna.dev.java.net/">JNA</a> - to expose the C API in a Java friendly way. The bindings are are based on + to expose the C API in a Java friendly way. The bindings are based on work initiated by Toth Istvan.</p> <h2>Getting it</h2> diff --git a/docs/news.html.in b/docs/news.html.in index faba773..31f4aea 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -1375,7 +1375,7 @@ and check the <a href="ChangeLog.html">ChangeLog</a> to gauge progress.</p> </ul> <h3>0.0.3: Feb 9 2006</h3> <ul> - <li>Switch name from from 'libvir' to libvirt</li> + <li>Switch name from 'libvir' to libvirt</li> <li>Starting infrastructure to add code examples</li> <li>Update of python bindings for completeness</li> </ul> -- 1.6.2.5

4 3

[libvirt] [PATCH] add doc for graphic and video elements
by Florian Vichot 22 Sep '09

22 Sep '09

Hello The title says it all. Here's some doc explaining the new syntax of the video and graphic elements in the domain XML. It (probably) won't get me any literary awards but, eh, it's a start :) Florian

3 2

[libvirt] [PATCH: 0/MANY] Re-arrange files in the source tree
by Daniel P. Berrange 22 Sep '09

22 Sep '09

This is a followup to http://www.redhat.com/archives/libvir-list/2009-September/msg00477.html I am not actually going to spam the list with all the patches, since it'd generate a HUGE series of mails. Instead I have published a branch containing all the patches which you can directly pull into your GIT checkout. I recommend you do the following set of steps. - make maintainer-clean - git checkout master - git pull - git remote add -f danb git://gitorious.org/~berrange/libvirt/staging.git - git checkout -b rearrange danb/rearrange You will now have a checkout on a branch called 'rearrange' containing all my patches applied. If you want to go straight into building it, the normal build process still applies eg ./autogen && make I've committed the changes in a large series of steps to make it easier to see what's going on at each point. To see the list of changes run the following git log -b berrange/rearrange master.. The changes basically follow everything we discussed in the previous thread I've added a src/README file which describes the split of sub-directories. I'll reproduce the content here for convenience libvirt library code README =========================== The directory provides the bulk of the libvirt codebase. Everything except for the libvirtd daemon and client tools. The build uses a large number of libtool convenience libraries - one for each child directory, and then links them together for the final libvirt.so, although some bits get linked directly to libvirtd daemon instead. The files directly in this directory are supporting the public API entry points & data structures. There are two core shared modules to be aware of: * util/ - a collection of shared APIs that can be used by any code. This directory is always in the include path for all things built * conf/ - APIs for parsing / manipulating all the official XML files used by the public API. This directory is only in the include path for driver implementation modules Then there are the hypervisor implementations: * esx/ - VMWare ESX and GSX support using XMLRPC * lxc/ - Linux Native Containers * opennebula/ - Open Nebula using XMLRPC * openvz/ - OpenVZ containers using cli tools * phyp/ - IBM Power Hypervisor using CLI tools over SSH * qemu/ - QEMU / KVM using qemu CLI/monitor * remote/ - Generic libvirt native RPC client * test/ - A "mock" driver for testing * uml/ - User Mode Linux * vbox/ - Virtual Box using native API * xen/ - Xen using hypercalls, XenD SEXPR & XenStore Finally some secondary drivers that are shared for several HVs. Currently these are used by LXC, OpenVZ, QEMU, UML and Xen drivers. The ESX, OpenNebula, Power Hypervisor, Remote, Test & VirtualBox drivers all implement the secondary drivers directly * interface/ - Host network interface management * network/ - Virtual NAT networking * node_device/ - Host device enumeration * secret/ - Secret management * security/ - Mandatory access control drivers * storage/ - Storage management drivers Since both the hypervisor and secondary drivers can be built as dlopen()able modules, it is *FORBIDDEN* to have build dependancies between these directories. Drivers are only allowed to depend on the public API, and the internal APIs in the util/ and conf/ directories For the docs directory, I left the docs/libvirt-{api,refs}.xml files in GIT as Daniel requested. I have removed the *.html, devhelp/*.html and html/*.html files though. These are all re-generated when doing make in the docs directory, and the generated HTML is included in the tar.gz when doing make dist. So end users won't have to rebuild them, only libvirt developers The example programs & XML is now all under examples/ with various sub-directories. The qemud/ directory is renamed to daemon/ The python/ directory has its file nameing changed and the genrator tweaked so that its more obvious which are generated files and which are manually written. virsh has moved to the tools/ directory, and the docs/pki_check.sh file has been turned into a real installed tool, tools/virt-pki-validate along with man page. A few minor bugs were fixed along the way (eg bogus include files discovered when files were moved) & unused png/gif images in docs/ There should be no FUNCTIONAL change in any of this work though. It is a pure re-arrangement of files. Please try out a build using this 'rearrange' branch from gitorious. Since this is a huge change I'd like to apply this to the master repo as soon as people can verify its doing the right thing for them. FWIW, I checked an RPM build and 'make distcheck' too with no issues. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

3 3

[libvirt] [PATCH] lxc: suspend/resume support
by Ryota Ozaki 22 Sep '09

22 Sep '09

Hi, This patch implements suspend/resume functions for LXC using cgroups freezer subsystem. The use of freezer is quite simple and well documented in Documentation/cgroups/freezer-subsystem.txt. The patch just uses it as it is. That is like: # freeze the container echo FROZEN > /target/container/freezer.state # unfreeze the container echo THAWED > /target/container/freezer.state However, freezer sometimes looks behaving different from the document. The document is saying "It's important to note that freezing can be incomplete. In that case we return EBUSY.", but in the case returning 0, freezing can be incomplete under load. So the code doesn't believe the return value and always check the content of freezer.state to identify whether the freezing is finished. Please refer to the comments in the code for more details. And the patch modifies domain_conf.c that assumes obj->monitor_chr != NULL but that is true only when qemu. Thanks, ozaki-r >From 50d273941eaf764f3ac3458ff10e618c771b77ef Mon Sep 17 00:00:00 2001 From: Ryota Ozaki <ozaki.ryota(a)gmail.com> Date: Wed, 16 Sep 2009 17:59:54 +0900 Subject: [PATCH] lxc: suspend/resume support --- src/cgroup.c | 23 ++++++- src/cgroup.h | 4 + src/domain_conf.c | 27 ++++---- src/lxc_driver.c | 186 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 225 insertions(+), 15 deletions(-) diff --git a/src/cgroup.c b/src/cgroup.c index 111601d..2e646fd 100644 --- a/src/cgroup.c +++ b/src/cgroup.c @@ -32,7 +32,8 @@ #define CGROUP_MAX_VAL 512 VIR_ENUM_IMPL(virCgroupController, VIR_CGROUP_CONTROLLER_LAST, - "cpu", "cpuacct", "cpuset", "memory", "devices"); + "cpu", "cpuacct", "cpuset", "memory", "devices", + "freezer"); struct virCgroupController { int type; @@ -896,3 +897,23 @@ int virCgroupGetCpuacctUsage(virCgroupPtr group, unsigned long long *usage) VIR_CGROUP_CONTROLLER_CPUACCT, "cpuacct.usage", (uint64_t *)usage); } + +int virCgroupSetFreezerState(virCgroupPtr group, const char *state) +{ + return virCgroupSetValueStr(group, + VIR_CGROUP_CONTROLLER_CPU, + "freezer.state", state); +} + +int virCgroupGetFreezerState(virCgroupPtr group, char **state) +{ + int ret; + ret = virCgroupGetValueStr(group, + VIR_CGROUP_CONTROLLER_CPU, + "freezer.state", state); + if (ret == 0) { + char *p = strchr(*state, '¥n'); + if (p) *p = '¥0'; + } + return ret; +} diff --git a/src/cgroup.h b/src/cgroup.h index 6d43b14..aba56c6 100644 --- a/src/cgroup.h +++ b/src/cgroup.h @@ -21,6 +21,7 @@ enum { VIR_CGROUP_CONTROLLER_CPUSET, VIR_CGROUP_CONTROLLER_MEMORY, VIR_CGROUP_CONTROLLER_DEVICES, + VIR_CGROUP_CONTROLLER_FREEZER, VIR_CGROUP_CONTROLLER_LAST }; @@ -68,6 +69,9 @@ int virCgroupGetCpuShares(virCgroupPtr group, unsigned long long *shares); int virCgroupGetCpuacctUsage(virCgroupPtr group, unsigned long long *usage); +int virCgroupSetFreezerState(virCgroupPtr group, const char *state); +int virCgroupGetFreezerState(virCgroupPtr group, char **state); + int virCgroupRemove(virCgroupPtr group); void virCgroupFree(virCgroupPtr *group); diff --git a/src/domain_conf.c b/src/domain_conf.c index 5ae0775..5e37d96 100644 --- a/src/domain_conf.c +++ b/src/domain_conf.c @@ -4433,19 +4433,22 @@ char *virDomainObjFormat(virConnectPtr conn, virDomainStateTypeToString(obj->state), obj->pid); - switch (obj->monitor_chr->type) { - case VIR_DOMAIN_CHR_TYPE_UNIX: - monitorpath = obj->monitor_chr->data.nix.path; - break; - default: - case VIR_DOMAIN_CHR_TYPE_PTY: - monitorpath = obj->monitor_chr->data.file.path; - break; - } + /* obj->monitor_chr is set only for qemu */ + if (obj->monitor_chr) { + switch (obj->monitor_chr->type) { + case VIR_DOMAIN_CHR_TYPE_UNIX: + monitorpath = obj->monitor_chr->data.nix.path; + break; + default: + case VIR_DOMAIN_CHR_TYPE_PTY: + monitorpath = obj->monitor_chr->data.file.path; + break; + } - virBufferEscapeString(&buf, " <monitor path='%s'", monitorpath); - virBufferVSprintf(&buf, " type='%s'/>¥n", - virDomainChrTypeToString(obj->monitor_chr->type)); + virBufferEscapeString(&buf, " <monitor path='%s'", monitorpath); + virBufferVSprintf(&buf, " type='%s'/>¥n", + virDomainChrTypeToString(obj->monitor_chr->type)); + } if (obj->nvcpupids) { diff --git a/src/lxc_driver.c b/src/lxc_driver.c index 0ec1e92..2399d98 100644 --- a/src/lxc_driver.c +++ b/src/lxc_driver.c @@ -1862,6 +1862,188 @@ static char *lxcGetHostname (virConnectPtr conn) return result; } +static int lxcFreezeContainer(lxc_driver_t *driver, virDomainObjPtr vm) +{ + int timeout = 3; /* In seconds */ + int check_interval = 500; /* In milliseconds */ + int n_try = (timeout * (1000 / check_interval)); + int i = 0; + int ret = -1; + char *state = NULL; + virCgroupPtr cgroup = NULL; + + if (!(driver->cgroup && + virCgroupForDomain(driver->cgroup, vm->def->name, &cgroup, 0) == 0)) + return -1; + + while (++i <= n_try) { + int r; + /* + * Writing "FROZEN" to the "freezer.state" freezes the group, + * i.e., the container, temporarily transiting "FREEZING" state. + * Once the freezing is completed, the state of the group transits + * to "FROZEN". + * (see linux-2.6/Documentation/cgroups/freezer-subsystem.txt) + */ + r = virCgroupSetFreezerState(cgroup, "FROZEN"); + + /* + * Returning EBUSY explicitly indicates that the group is + * being freezed but incomplete and other errors are true + * errors. + */ + if (r < 0 && r != -EBUSY) { + VIR_DEBUG("Writing freezer.state failed with errno: %d", r); + goto error; + } + + /* + * Unfortunately, returning 0 (success) is likely to happen + * even when the freezing has not been completed. Sometimes + * the state of the group remains "FREEZING" like when + * returning -EBUSY and even worse may never transit to + * "FROZEN" even if writing "FROZEN" again. + * + * So we don't trust the return value anyway and always + * decide that the freezing has been complete only with + * the state actually transit to "FROZEN". + */ + usleep(check_interval * 1000); + + r = virCgroupGetFreezerState(cgroup, &state); + + if (r < 0) { + VIR_DEBUG("Reading freezer.state failed with errno: %d", r); + goto error; + } + VIR_DEBUG("Read freezer.state: %s", state); + + if (STREQ(state, "FROZEN")) { + ret = 0; + goto cleanup; + } + + VIR_FREE(state); + } + VIR_DEBUG0("lxcFreezeContainer timeout"); +error: + /* + * If timeout or an error on reading the state occurs, + * activate the group again and return an error. + * This is likely to fall the group back again gracefully. + */ + virCgroupSetFreezerState(cgroup, "THAWED"); + ret = -1; + +cleanup: + if (cgroup) + virCgroupFree(&cgroup); + VIR_FREE(state); + return ret; +} + +static int lxcDomainSuspend(virDomainPtr dom) +{ + lxc_driver_t *driver = dom->conn->privateData; + virDomainObjPtr vm; + int ret = -1; + + lxcDriverLock(driver); + vm = virDomainFindByUUID(&driver->domains, dom->uuid); + + if (!vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + lxcError(dom->conn, dom, VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); + goto cleanup; + } + + if (!virDomainIsActive(vm)) { + lxcError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + + if (vm->state != VIR_DOMAIN_PAUSED) { + if (lxcFreezeContainer(driver, vm) < 0) { + lxcError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + "%s", _("suspend operation failed")); + goto cleanup; + } + vm->state = VIR_DOMAIN_PAUSED; + } + + if (virDomainSaveStatus(dom->conn, driver->stateDir, vm) < 0) + goto cleanup; + ret = 0; + +cleanup: + if (vm) + virDomainObjUnlock(vm); + lxcDriverUnlock(driver); + return ret; +} + +static int lxcUnfreezeContainer(lxc_driver_t *driver, virDomainObjPtr vm) +{ + int ret; + virCgroupPtr cgroup = NULL; + + if (!(driver->cgroup && + virCgroupForDomain(driver->cgroup, vm->def->name, &cgroup, 0) == 0)) + return -1; + + ret = virCgroupSetFreezerState(cgroup, "THAWED"); + + virCgroupFree(&cgroup); + return ret; +} + +static int lxcDomainResume(virDomainPtr dom) +{ + lxc_driver_t *driver = dom->conn->privateData; + virDomainObjPtr vm; + int ret = -1; + + lxcDriverLock(driver); + vm = virDomainFindByUUID(&driver->domains, dom->uuid); + + if (!vm) { + char uuidstr[VIR_UUID_STRING_BUFLEN]; + virUUIDFormat(dom->uuid, uuidstr); + lxcError(dom->conn, dom, VIR_ERR_NO_DOMAIN, + _("no domain with matching uuid '%s'"), uuidstr); + goto cleanup; + } + + if (!virDomainIsActive(vm)) { + lxcError(dom->conn, dom, VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + + if (vm->state == VIR_DOMAIN_PAUSED) { + if (lxcUnfreezeContainer(driver, vm) < 0) { + lxcError(dom->conn, dom, VIR_ERR_OPERATION_FAILED, + "%s", _("resume operation failed")); + goto cleanup; + } + vm->state = VIR_DOMAIN_RUNNING; + } + + if (virDomainSaveStatus(dom->conn, driver->stateDir, vm) < 0) + goto cleanup; + ret = 0; + +cleanup: + if (vm) + virDomainObjUnlock(vm); + lxcDriverUnlock(driver); + return ret; +} + + /* Function Tables */ static virDriver lxcDriver = { VIR_DRV_LXC, /* the number virDrvNo */ @@ -1881,8 +2063,8 @@ static virDriver lxcDriver = { lxcDomainLookupByID, /* domainLookupByID */ lxcDomainLookupByUUID, /* domainLookupByUUID */ lxcDomainLookupByName, /* domainLookupByName */ - NULL, /* domainSuspend */ - NULL, /* domainResume */ + lxcDomainSuspend, /* domainSuspend */ + lxcDomainResume, /* domainResume */ lxcDomainShutdown, /* domainShutdown */ NULL, /* domainReboot */ lxcDomainDestroy, /* domainDestroy */ -- 1.6.0.6

3 7

[libvirt] [PATCH] Power Hypervisor now with libssh2
by Eduardo Otubo 21 Sep '09

21 Sep '09

Hello friends, This is the new version of phyp driver now using libssh2. I also did some other changes: * Added some debug information. Sometimes its worth to know which command is being executed and where. So I added the PHYP_CMD_DEBUG macro. * All the connection startup is now "hard coded" in libssh2. For example, I need to open the socket and start the connection all by myself. Not a big deal, but in a near future I am planning to send a patch to libssh2 to encapsulate all these procedures into functions, hence, less code, probably less bugs :) * There is a lot of "out of scope" functions in the bottom of the file. In the next patch I may put all those together in a phyp_config.[ch] in order to get things clearer. What's up next: * The problem of handling the UUID in a centralized way still remains. I started to handle this by opening a sftp connection to the HMC system and transfer my UUID database. But there is an odd behavior that makes the driver connect OR NOT to some HMC systems. * CPU management: this feature planned to be released in this version is not ready yet due to the issue above. * Storage management. Vacations: I'll be on vacations from 26th/august to 14th/september. I'll check my emails in the meanwhile, but no so often. Anyway, any comments on this patch are always welcome :) []'s -- Eduardo Otubo Software Engineer Linux Technology Center IBM Systems & Technology Group Mobile: +55 19 8135 0885 otubo(a)linux.vnet.ibm.com

2 3

[libvirt] [PATCH] Remove an unnecessary variable from remoteIOReadMessage().
by Chris Lalancette 21 Sep '09

21 Sep '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/remote_internal.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/remote_internal.c b/src/remote_internal.c index dd7b31e..b89d45d 100644 --- a/src/remote_internal.c +++ b/src/remote_internal.c @@ -6942,10 +6942,9 @@ remoteIOReadMessage(virConnectPtr conn, struct private_data *priv, if (priv->saslconn) { if (priv->saslDecoded == NULL) { char encoded[8192]; - unsigned int encodedLen = sizeof(encoded); int ret, err; ret = remoteIOReadBuffer(conn, priv, in_open, - encoded, encodedLen); + encoded, sizeof(encoded)); if (ret < 0) return -1; if (ret == 0) -- 1.6.0.6

2 3

[libvirt] [PATCH] Simple fix of a comment in qemuStringToArgvEnv.
by Chris Lalancette 21 Sep '09

21 Sep '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/qemu_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu_conf.c b/src/qemu_conf.c index f92bcef..273aeca 100644 --- a/src/qemu_conf.c +++ b/src/qemu_conf.c @@ -2363,7 +2363,7 @@ static int qemuStringToArgvEnv(const char *args, curr = next; } - /* Iterate over list of args, finding first arg not containining + /* Iterate over list of args, finding first arg not containing * the '=' character (eg, skip over env vars FOO=bar) */ for (envend = 0 ; ((envend < argcount) && (strchr(arglist[envend], '=') != NULL)); -- 1.6.0.6

2 1

[libvirt] [PATCH] Fix up comments for domainXML{To,From}Native.
by Chris Lalancette 21 Sep '09

21 Sep '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/esx/esx_driver.c | 4 ++-- src/lxc_driver.c | 4 ++-- src/phyp/phyp_driver.c | 4 ++-- src/test.c | 4 ++-- src/uml_driver.c | 4 ++-- src/vbox/vbox_tmpl.c | 4 ++-- src/xen_unified.c | 4 ++-- 7 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 07afc10..8fad457 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -3061,8 +3061,8 @@ static virDriver esxDriver = { NULL, /* domainGetSecurityLabel */ NULL, /* nodeGetSecurityModel */ esxDomainDumpXML, /* domainDumpXML */ - esxDomainXMLFromNative, /* domainXmlFromNative */ - NULL, /* domainXmlToNative */ + esxDomainXMLFromNative, /* domainXMLFromNative */ + NULL, /* domainXMLToNative */ esxListDefinedDomains, /* listDefinedDomains */ esxNumberOfDefinedDomains, /* numOfDefinedDomains */ esxDomainCreate, /* domainCreate */ diff --git a/src/lxc_driver.c b/src/lxc_driver.c index 0ec1e92..eafd8ba 100644 --- a/src/lxc_driver.c +++ b/src/lxc_driver.c @@ -1901,8 +1901,8 @@ static virDriver lxcDriver = { NULL, /* domainGetSecurityLabel */ NULL, /* nodeGetSecurityModel */ lxcDomainDumpXML, /* domainDumpXML */ - NULL, /* domainXmlFromNative */ - NULL, /* domainXmlToNative */ + NULL, /* domainXMLFromNative */ + NULL, /* domainXMLToNative */ lxcListDefinedDomains, /* listDefinedDomains */ lxcNumDefinedDomains, /* numOfDefinedDomains */ lxcDomainStart, /* domainCreate */ diff --git a/src/phyp/phyp_driver.c b/src/phyp/phyp_driver.c index 2f8a314..e2a2caf 100644 --- a/src/phyp/phyp_driver.c +++ b/src/phyp/phyp_driver.c @@ -1347,8 +1347,8 @@ virDriver phypDriver = { NULL, /* domainGetSecurityLabel */ NULL, /* nodeGetSecurityModel */ phypDomainDumpXML, /* domainDumpXML */ - NULL, /* domainXmlFromNative */ - NULL, /* domainXmlToNative */ + NULL, /* domainXMLFromNative */ + NULL, /* domainXMLToNative */ phypListDefinedDomains, /* listDefinedDomains */ phypNumDefinedDomains, /* numOfDefinedDomains */ NULL, /* domainCreate */ diff --git a/src/test.c b/src/test.c index 368a3cb..5f1ba62 100644 --- a/src/test.c +++ b/src/test.c @@ -4227,8 +4227,8 @@ static virDriver testDriver = { NULL, /* domainGetSecurityLabel */ NULL, /* nodeGetSecurityModel */ testDomainDumpXML, /* domainDumpXML */ - NULL, /* domainXmlFromNative */ - NULL, /* domainXmlToNative */ + NULL, /* domainXMLFromNative */ + NULL, /* domainXMLToNative */ testListDefinedDomains, /* listDefinedDomains */ testNumOfDefinedDomains, /* numOfDefinedDomains */ testDomainCreate, /* domainCreate */ diff --git a/src/uml_driver.c b/src/uml_driver.c index a2b9495..d28cc30 100644 --- a/src/uml_driver.c +++ b/src/uml_driver.c @@ -1823,8 +1823,8 @@ static virDriver umlDriver = { NULL, /* domainGetSecurityLabel */ NULL, /* nodeGetSecurityModel */ umlDomainDumpXML, /* domainDumpXML */ - NULL, /* domainXmlFromNative */ - NULL, /* domainXmlToNative */ + NULL, /* domainXMLFromNative */ + NULL, /* domainXMLToNative */ umlListDefinedDomains, /* listDefinedDomains */ umlNumDefinedDomains, /* numOfDefinedDomains */ umlDomainStart, /* domainCreate */ diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 7270710..c02b18c 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -6426,8 +6426,8 @@ virDriver NAME(Driver) = { NULL, /* domainGetSecurityLabel */ NULL, /* nodeGetSecurityModel */ vboxDomainDumpXML, /* domainDumpXML */ - NULL, /* domainXmlFromNative */ - NULL, /* domainXmlToNative */ + NULL, /* domainXMLFromNative */ + NULL, /* domainXMLToNative */ vboxListDefinedDomains, /* listDefinedDomains */ vboxNumOfDefinedDomains, /* numOfDefinedDomains */ vboxDomainCreate, /* domainCreate */ diff --git a/src/xen_unified.c b/src/xen_unified.c index dfa9ca5..b826198 100644 --- a/src/xen_unified.c +++ b/src/xen_unified.c @@ -1692,8 +1692,8 @@ static virDriver xenUnifiedDriver = { NULL, /* domainGetSecurityLabel */ NULL, /* nodeGetSecurityModel */ xenUnifiedDomainDumpXML, /* domainDumpXML */ - xenUnifiedDomainXMLFromNative, /* domainXmlFromNative */ - xenUnifiedDomainXMLToNative, /* domainXmlToNative */ + xenUnifiedDomainXMLFromNative, /* domainXMLFromNative */ + xenUnifiedDomainXMLToNative, /* domainXMLToNative */ xenUnifiedListDefinedDomains, /* listDefinedDomains */ xenUnifiedNumOfDefinedDomains, /* numOfDefinedDomains */ xenUnifiedDomainCreate, /* domainCreate */ -- 1.6.0.6

2 1

[libvirt] [PATCH] Fix a double-free in qemudRunLoop()
by Chris Lalancette 21 Sep '09

21 Sep '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- qemud/qemud.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/qemud/qemud.c b/qemud/qemud.c index 00b9859..087f5da 100644 --- a/qemud/qemud.c +++ b/qemud/qemud.c @@ -2270,7 +2270,6 @@ cleanup: } VIR_FREE(server->workers); - free(server->workers); virMutexUnlock(&server->lock); return ret; } -- 1.6.0.6

2 1

[libvirt] [PATCH] Don't do virSetConnError when virDrvSupportsFeature is successful.
by Chris Lalancette 21 Sep '09

21 Sep '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/libvirt.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 4a11688..fa59dc7 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -1349,8 +1349,11 @@ virDrvSupportsFeature (virConnectPtr conn, int feature) } ret = VIR_DRV_SUPPORTS_FEATURE (conn->driver, conn, feature); - /* Copy to connection error object for back compatability */ - virSetConnError(conn); + + if (ret < 0) + /* Copy to connection error object for back compatability */ + virSetConnError(conn); + return ret; } -- 1.6.0.6

2 1

[libvirt] [PATCH] Fix up 'neccessary -> necessary' in a comment.
by Chris Lalancette 21 Sep '09

21 Sep '09

Signed-off-by: Chris Lalancette <clalance(a)redhat.com> --- src/virterror.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/virterror.c b/src/virterror.c index 77b295c..e421ab7 100644 --- a/src/virterror.c +++ b/src/virterror.c @@ -641,7 +641,7 @@ virRaiseErrorFull(virConnectPtr conn, /* * All errors are recorded in thread local storage * For compatability, public API calls will copy them - * to the per-connection error object when neccessary + * to the per-connection error object when necessary */ to = virLastErrorObject(); if (!to) -- 1.6.0.6

2 1

[libvirt] [PATCH 2/2] Fix leak in PCI hostdev hot-unplug
by Mark McLoughlin 21 Sep '09

21 Sep '09

* src/qemu_driver.c: sync the hostdev hot-unplug code with the disk/net code. --- src/qemu_driver.c | 20 +++++++++++++------- 1 files changed, 13 insertions(+), 7 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index de31581..2ddcdc0 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -6206,14 +6206,20 @@ static int qemudDomainDetachHostPciDevice(virConnectPtr conn, pciFreeDevice(conn, pci); } - if (i != --vm->def->nhostdevs) - memmove(&vm->def->hostdevs[i], - &vm->def->hostdevs[i+1], - sizeof(*vm->def->hostdevs) * (vm->def->nhostdevs-i)); - if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs) < 0) { - virReportOOMError(conn); - ret = -1; + if (vm->def->nhostdevs > 1) { + memmove(vm->def->hostdevs + i, + vm->def->hostdevs + i + 1, + sizeof(*vm->def->hostdevs) * + (vm->def->nhostdevs - (i + 1))); + vm->def->nhostdevs--; + if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs) < 0) { + /* ignore, harmless */ + } + } else { + VIR_FREE(vm->def->hostdevs); + vm->def->nhostdevs = 0; } + virDomainHostdevDefFree(detach); return ret; } -- 1.6.2.5

2 1

[libvirt] [PATCH 1/2] Fix net/disk hot-unplug segfault
by Mark McLoughlin 21 Sep '09

21 Sep '09

When we hot-unplug the last device, we're currently double-freeing the device definition. Reported by Michal Nowak here: https://bugzilla.redhat.com/523953 * src/qemu_driver.c: fix double free --- src/qemu_driver.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu_driver.c b/src/qemu_driver.c index a65334f..de31581 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -5998,7 +5998,7 @@ try_command: /* ignore, harmless */ } } else { - VIR_FREE(vm->def->disks[0]); + VIR_FREE(vm->def->disks); vm->def->ndisks = 0; } virDomainDiskDefFree(detach); @@ -6100,7 +6100,7 @@ qemudDomainDetachNetDevice(virConnectPtr conn, /* ignore, harmless */ } } else { - VIR_FREE(vm->def->nets[0]); + VIR_FREE(vm->def->nets); vm->def->nnets = 0; } virDomainNetDefFree(detach); -- 1.6.2.5

2 2

[libvirt] virsh migrate with libvirt-0.6.2: failed to start listening VM
by David Wilcox 21 Sep '09

21 Sep '09

Hello, I'm trying to migrate a vm from a fedora 11 host to another fedora 11 host. Both hosts are on the same subnet. Both machines have identical architectures. We use an nfs shared storage mounted, but both machines also have their own hard drives. I get the machines up and running alright. Here's the printout of virsh when I try to do the migration. # virsh list Id Name State ---------------------------------- 1 windowsxp running 2 potato running # virsh migrate 1 qemu+ssh://prodigy/system Password: error: operation failed: failed to start listening VM On the other machine, the log file that gets created under /var/log/libvirt/qemo/windowsxp.log LC_ALL=C PATH=/sbin:/usr/sbin:/bin:/usr/bin /usr/bin/qemu-kvm -S -M pc -m 512 -smp 1 -name windowsxp -uuid 24d2fd62-ed4f-a321-e264-200b347cfa6c -monitor pty -pidfile /var/run/libvirt/qemu//windowsxp.pid -localtime -no-acpi -boot c -drive file=/var/lib/libvirt/images/windowsxp.img,if=ide,index=0,boot=on -drive file=/aml/iso/windows_xp_sp3.iso,if=ide,media=cdrom,index=2 -net nic,macaddr=54:52:00:01:f1:06,vlan=0 -net tap,fd=19,vlan=0 -serial pty -parallel none -usb -usbdevice tablet -vnc 127.0.0.1:0 -soundhw es1370 -incoming tcp:0.0.0.0:49159 qemu: could not open disk image /var/lib/libvirt/images/windowsxp.img I would think that the virtual machine should copy from the one machine to the other. Isn't libvirt supposed to copy the image file? What's even stranger, I've been trying this for awhile. It's failed every time, except once when it succeded. I don't know what made it succeed in that case and fail in all the other cases. Thanks.

2 1

[libvirt] regarding the network information for Domain
by anuj rampal 18 Sep '09

18 Sep '09

Hi all, im trying to call libvirt api from windows. I have created a guest OS(windows) using the libvirt api from my windows machine. It gets created fine it also gets the the IP address from the DHCP also. So all works fine. Now to RDP into the machine what I have to do is 1. logon to my host machine. 2. open the guest OS using either "virt-viewer" or "virt-manager". 3. check out the IP address of the machine. 4. then RDP into the guest OS. My Question: Is there a way to find The IP address of the Guest OS.??? ---------------------------------------------------------------------------------------------------------------------------- im also trying to cross compile "virt-viewer 0.0.3" but this is what i get when i do make: [root@FC-11 virt-viewer-0.0.3]# make make all-recursive make[1]: Entering directory `/root/virt-viewer-0.0.3' Making all in src make[2]: Entering directory `/root/virt-viewer-0.0.3/src' /bin/sh ../libtool --tag=CC --mode=link i686-pc-mingw32-gcc -mms-bitfields -I/usr/i686-pc-mingw32/sys-root/mingw/include/gtk-vnc-1.0 -I/usr/i686-pc-mingw32/sys-root/mingw/include/gtk-2.0 -I/usr/i686-pc-mingw32/sys-root/mingw/include -I/usr/i686-pc-mingw32/sys-root/mingw/lib/gtk-2.0/include -I/usr/i686-pc-mingw32/sys-root/mingw/include/atk-1.0 -I/usr/i686-pc-mingw32/sys-root/mingw/include/cairo -I/usr/i686-pc-mingw32/sys-root/mingw/include/pango-1.0 -I/usr/i686-pc-mingw32/sys-root/mingw/include/glib-2.0 -I/usr/i686-pc-mingw32/sys-root/mingw/lib/glib-2.0/include -I/usr/i686-pc-mingw32/sys-root/mingw/include/pixman-1 -I/usr/i686-pc-mingw32/sys-root/mingw/include/libpng12 -mms-bitfields -I/usr/i686-pc-mingw32/sys-root/mingw/include/gtk-2.0 -I/usr/i686-pc-mingw32/sys-root/mingw/lib/gtk-2.0/include -I/usr/i686-pc-mingw32/sys-root/mingw/include/atk-1.0 -I/usr/i686-pc-mingw32/sys-root/mingw/include/cairo -I/usr/i686-pc-mingw32/sys-root/mingw/include/pango-1.0 -I/usr/i686-pc-mingw32/sys-root/mingw/include/glib-2.0 -I/usr/i686-pc-mingw32/sys-root/mingw/lib/glib-2.0/include -I/usr/i686-pc-mingw32/sys-root/mingw/include/pixman-1 -I/usr/i686-pc-mingw32/sys-root/mingw/include/libpng12 -I/usr/i686-pc-mingw32/sys-root/mingw/include/libxml2 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -fasynchronous-unwind-tables -Wall -Wmissing-prototypes -std=c99 -Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings -Waggregate-return -Winline -Wredundant-decls -Wno-sign-compare -g -O2 -o virt-viewer.exe virt_viewer-main.o -Wl,-luuid -L/usr/i686-pc-mingw32/sys-root/mingw/lib -lgtk-vnc-1.0 -lgtk-win32-2.0 -lgnutls -lgdk-win32-2.0 -limm32 -lshell32 -lole32 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lgio-2.0 -lcairo -lpangowin32-1.0 -lgdi32 -lpango-1.0 -lm -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -Wl,-luuid -L/usr/i686-pc-mingw32/sys-root/mingw/lib -lgtk-win32-2.0 -lgdk-win32-2.0 -limm32 -lshell32 -lole32 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lgio-2.0 -lcairo -lpangowin32-1.0 -lgdi32 -lpango-1.0 -lm -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -L/usr/i686-pc-mingw32/sys-root/mingw/lib -lxml2 -lvirt -lpthread ../libtool: line 834: X--tag=CC: command not found ../libtool: line 867: libtool: ignoring unknown tag : command not found ../libtool: line 834: X--mode=link: command not found ../libtool: line 1001: *** Warning: inferring the mode of operation is deprecated.: command not found ../libtool: line 1002: *** Future versions of Libtool will require --mode=MODE be specified.: command not found ../libtool: line 2074: X-mms-bitfields: command not found ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/gtk-vnc-1.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/gtk-2.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/lib/gtk-2.0/include: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/atk-1.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/cairo: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/pango-1.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/glib-2.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/lib/glib-2.0/include: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/pixman-1: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/libpng12: No such file or directory ../libtool: line 2074: X-mms-bitfields: command not found ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/gtk-2.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/lib/gtk-2.0/include: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/atk-1.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/cairo: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/pango-1.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/glib-2.0: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/lib/glib-2.0/include: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/pixman-1: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/libpng12: No such file or directory ../libtool: line 2239: X-I/usr/i686-pc-mingw32/sys-root/mingw/include/libxml2: No such file or directory ../libtool: line 2239: X-Wp,-D_FORTIFY_SOURCE=2: command not found ../libtool: line 2239: X-fexceptions: command not found ../libtool: line 2239: X-fstack-protector: command not found ../libtool: line 2239: X--param=ssp-buffer-size=4: command not found ../libtool: line 2239: X-fasynchronous-unwind-tables: command not found ../libtool: line 2239: X-Wall: command not found ../libtool: line 2239: X-Wmissing-prototypes: command not found ../libtool: line 2239: X-std=c99: command not found ../libtool: line 2239: X-Wnested-externs: command not found ../libtool: line 2239: X-Wpointer-arith: command not found ../libtool: line 2239: X-Wextra: command not found ../libtool: line 2239: X-Wshadow: command not found ../libtool: line 2239: X-Wcast-align: command not found ../libtool: line 2239: X-Wwrite-strings: command not found ../libtool: line 2239: X-Waggregate-return: command not found ../libtool: line 2239: X-Winline: command not found ../libtool: line 2239: X-Wredundant-decls: command not found ../libtool: line 2239: X-Wno-sign-compare: command not found ../libtool: line 2239: X-g: command not found ../libtool: line 2239: X-O2: command not found ../libtool: line 2202: X-Wl,-luuid: command not found Fatal server error: Server is already active for display 0 If this server is no longer running, remove /tmp/.X0-lock and start again. Please consult the The X.Org Foundation support at http://wiki.x.org for help. ../libtool: line 1958: X-L/usr/i686-pc-mingw32/sys-root/mingw/lib: No such file or directory ../libtool: line 1981: X/root/virt-viewer-0.0.3/src: No such file or directory ../libtool: line 2202: X-Wl,-luuid: command not found Fatal server error: Server is already active for display 0 If this server is no longer running, remove /tmp/.X0-lock and start again. Please consult the The X.Org Foundation support at http://wiki.x.org for help. ../libtool: line 1958: X-L/usr/i686-pc-mingw32/sys-root/mingw/lib: No such file or directory ../libtool: line 1981: X/root/virt-viewer-0.0.3/src: No such file or directory ../libtool: line 1958: X-L/usr/i686-pc-mingw32/sys-root/mingw/lib: No such file or directory ../libtool: line 1981: X/root/virt-viewer-0.0.3/src: No such file or directory ../libtool: line 2408: Xvirt-viewer.exe: command not found ../libtool: line 2413: X/usr/lib/qt-3.3/bin:/usr/kerberos/sbin:/usr/kerberos/bin:/usr/lib/ccache:/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin:/root/bin: No such file or directory ../libtool: line 2420: Xvirt-viewer.exe: command not found ../libtool: line 2555: X-lgtk-vnc-1.0: command not found ../libtool: line 2555: X-lgtk-win32-2.0: command not found ../libtool: line 2555: X-lgnutls: command not found ../libtool: line 2555: X-lgdk-win32-2.0: command not found ../libtool: line 2555: X-limm32: command not found ../libtool: line 2555: X-lshell32: command not found ../libtool: line 2555: X-lole32: command not found ../libtool: line 2555: X-latk-1.0: command not found ../libtool: line 2555: X-lgdk_pixbuf-2.0: command not found ../libtool: line 2555: X-lpangocairo-1.0: command not found ../libtool: line 2555: X-lgio-2.0: command not found ../libtool: line 2555: X-lcairo: command not found ../libtool: line 2555: X-lpangowin32-1.0: command not found ../libtool: line 2555: X-lgdi32: command not found ../libtool: line 2555: X-lpango-1.0: command not found ../libtool: line 2555: X-lgobject-2.0: command not found ../libtool: line 2555: X-lgmodule-2.0: command not found ../libtool: line 2555: X-lglib-2.0: command not found ../libtool: line 2555: X-lintl: command not found ../libtool: line 2555: X-lgtk-win32-2.0: command not found ../libtool: line 2555: X-lgdk-win32-2.0: command not found ../libtool: line 2555: X-limm32: command not found ../libtool: line 2555: X-lshell32: command not found ../libtool: line 2555: X-lole32: command not found ../libtool: line 2555: X-latk-1.0: command not found ../libtool: line 2555: X-lgdk_pixbuf-2.0: command not found ../libtool: line 2555: X-lpangocairo-1.0: command not found ../libtool: line 2555: X-lgio-2.0: command not found ../libtool: line 2555: X-lcairo: command not found ../libtool: line 2555: X-lpangowin32-1.0: command not found ../libtool: line 2555: X-lgdi32: command not found ../libtool: line 2555: X-lpango-1.0: command not found ../libtool: line 2555: X-lgobject-2.0: command not found ../libtool: line 2555: X-lgmodule-2.0: command not found ../libtool: line 2555: X-lglib-2.0: command not found ../libtool: line 2555: X-lintl: command not found ../libtool: line 2555: X-lxml2: command not found ../libtool: line 2555: X-lvirt: command not found ../libtool: line 2555: X-lpthread: command not found ../libtool: line 2637: X-L/root/virt-viewer-0.0.3/src: No such file or directory ../libtool: line 2555: X-lgtk-vnc-1.0: command not found ../libtool: line 2555: X-lgnutls: command not found ../libtool: line 2555: X-lgtk-win32-2.0: command not found ../libtool: line 2555: X-lgdk-win32-2.0: command not found ../libtool: line 2555: X-limm32: command not found ../libtool: line 2555: X-lshell32: command not found ../libtool: line 2555: X-lole32: command not found ../libtool: line 2555: X-latk-1.0: command not found ../libtool: line 2555: X-lgdk_pixbuf-2.0: command not found ../libtool: line 2555: X-lpangocairo-1.0: command not found ../libtool: line 2555: X-lgio-2.0: command not found ../libtool: line 2555: X-lcairo: command not found ../libtool: line 2555: X-lpangowin32-1.0: command not found ../libtool: line 2555: X-lgdi32: command not found ../libtool: line 2555: X-lpango-1.0: command not found ../libtool: line 2555: X-lgobject-2.0: command not found ../libtool: line 2555: X-lgmodule-2.0: command not found ../libtool: line 2555: X-lglib-2.0: command not found ../libtool: line 2555: X-lintl: command not found ../libtool: line 2555: X-lxml2: command not found ../libtool: line 2555: X-lvirt: command not found ../libtool: line 2555: X-lpthread: command not found ../libtool: line 2637: X-L/root/virt-viewer-0.0.3/src: No such file or directory ../libtool: line 2555: X-lgtk-vnc-1.0: command not found ../libtool: line 2555: X-lgnutls: command not found ../libtool: line 2555: X-lgtk-win32-2.0: command not found ../libtool: line 2555: X-lgdk-win32-2.0: command not found ../libtool: line 2555: X-limm32: command not found ../libtool: line 2555: X-lshell32: command not found ../libtool: line 2555: X-lole32: command not found ../libtool: line 2555: X-latk-1.0: command not found ../libtool: line 2555: X-lgdk_pixbuf-2.0: command not found ../libtool: line 2555: X-lpangocairo-1.0: command not found ../libtool: line 2555: X-lgio-2.0: command not found ../libtool: line 2555: X-lcairo: command not found ../libtool: line 2555: X-lpangowin32-1.0: command not found ../libtool: line 2555: X-lgdi32: command not found ../libtool: line 2555: X-lpango-1.0: command not found ../libtool: line 2555: X-lgobject-2.0: command not found ../libtool: line 2555: X-lgmodule-2.0: command not found ../libtool: line 2555: X-lglib-2.0: command not found ../libtool: line 2555: X-lintl: command not found ../libtool: line 2555: X-lxml2: command not found ../libtool: line 2555: X-lvirt: command not found ../libtool: line 2555: X-lpthread: command not found ../libtool: line 5172: Xi686-pc-mingw32-gcc "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" -o @OUTPUT@ virt_viewer-main.o -L/root/virt-viewer-0.0.3/src -lgtk-vnc-1.0 -lgnutls -lgtk-win32-2.0 -lgdk-win32-2.0 -limm32 -lshell32 -lole32 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lgio-2.0 -lcairo -lpangowin32-1.0 -lgdi32 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -lxml2 -lvirt -lpthread: No such file or directory ../libtool: line 5173: Xi686-pc-mingw32-gcc "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" "" -o @OUTPUT@ virt_viewer-main.o -L/root/virt-viewer-0.0.3/src -lgtk-vnc-1.0 -lgnutls -lgtk-win32-2.0 -lgdk-win32-2.0 -limm32 -lshell32 -lole32 -latk-1.0 -lgdk_pixbuf-2.0 -lpangocairo-1.0 -lgio-2.0 -lcairo -lpangowin32-1.0 -lgdi32 -lpango-1.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -lxml2 -lvirt -lpthread: No such file or directory Fatal server error: Server is already active for display 0 If this server is no longer running, remove /tmp/.X0-lock and start again. Please consult the The X.Org Foundation support at http://wiki.x.org for help. ../libtool: line 5182: : command not found make[2]: Leaving directory `/root/virt-viewer-0.0.3/src' Making all in man make[2]: Entering directory `/root/virt-viewer-0.0.3/man' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/root/virt-viewer-0.0.3/man' Making all in plugin make[2]: Entering directory `/root/virt-viewer-0.0.3/plugin' make[2]: Nothing to be done for `all'. make[2]: Leaving directory `/root/virt-viewer-0.0.3/plugin' make[2]: Entering directory `/root/virt-viewer-0.0.3' make[2]: Leaving directory `/root/virt-viewer-0.0.3' make[1]: Leaving directory `/root/virt-viewer-0.0.3' could any1 help me out with this. Thanks in advance. Regards Anuj

2 1

[libvirt] guests and pulseaudio fighting over audio devices
by Dave Allan 17 Sep '09

17 Sep '09

I noticed that when a KVM guest created with virt-manager is running on F10, sound on the physical host stops working. When all VMs are shutdown, sound starts working again. Removing the <sound> tag from the VM XML allows sound to work while the VM is booted. To further complicate troubleshooting, if audio is already playing when the guest is started it keeps playing, since pulse already has the device open. The message in /var/log/messages when I try to play audio is: pulseaudio[6492]: module-alsa-sink.c: Error opening PCM device front:0: Device or resource busy strace of pulseaudio shows: open("/dev/snd/pcmC0D0p", O_RDWR|O_NONBLOCK) = -1 EBUSY (Device or resource busy) but fuser and lsof show nothing. A trivial test program also sees Device or resource busy when trying to open /dev/snd/pcmC0D0p I am in favor of removing the <sound> tag from the default configuration, since I don't use sound from within guests and I do use sound on my desktop, but perhaps this behavior is specific to my configuration. I haven't investigated it exhaustively. What does everybody else think? Dave

2 2

[libvirt] Resubmission: [PATCH 0/6] sVirt AppArmor security driver
by Jamie Strandboge 16 Sep '09

16 Sep '09

Resubmitting based on feedback from this list. Notably, *alloc calls have been removed and syntax-check completes without error for all files. Jamie On Fri, 04 Sep 2009, Jamie Strandboge wrote: > This patch series implements the AppArmor security driver for sVirt. > This implementation was developed for the Ubuntu AppArmorLibvirtProfile > specification[1], but is general enough for any AppArmor deployment > (such as Ubuntu, *SUSE and Mandriva). > > This patch has seen quite a bit of real world testing in Ubuntu 9.10 > (our development release) in our 0.7.0-1ubuntu3 package. I did make a > few small changes after going through HACKING, but mostly I got the > tests going and added documentation. > > DESIGN > ------ > When a virtual machine is started, determine if a profile is currently > defined for the machine, and use it if available. If not, generate a new > profile for the machine based on a template, which is by default a very > restrictive profile allowing access to disk files, and anything else > needed to run, such as the pid, monitor and log files. > > Virtual machines should have a unique profile specific to that machine. > To ensure uniqueness, the profile name will be derived from the UUID of > the virtual machine. These profiles should be configurable, either by > adjusting the profile template for new machines, creating/modifying the > VM profile directly or through the use of AppArmor abstractions. This > will allow for administrators to fine-tune confinement for individual > machines if desired. > > If enabled at compile time, the sVirt security model will be activated > if AppArmor is available on the host OS and a profile for the libvirtd > daemon is loaded when libvirtd is started. > > libvirtd should not be allowed to create arbitrary profiles or modify > profiles directly, so as to not allow libvirtd to potentially (ie via a > security bug in libvirtd itself) bootstrap out of AppArmor confinement. > > Because root privileges are needed to manipulate AppArmor profiles, > qemu:///session will not be supported at this time, but the > implementation must allow for a confined libvirtd with qemu:///session > guests running unconfined. This can be revisited when AppArmor supports > per-user profiles. > > Please see the specification[1] for more details. > > > PATCHES > ------- > The patches are all against trunk as of yesterday. Testing was done on > trunk and there seem to be no regressions over the the 0.7.0-1ubuntu3 > package in Ubuntu. > > > [PATCH 1*] > patch_1a_reenable-nonfile-labels.patch: > When James Morris originally submitted his sVirt patches (as seen in > libvirt 0.6.1), he did not require on disk labelling for > virSecurityDomainRestoreImageLabel. A later commit[2] changed this > behavior to assume on disk labelling, which halts implementations for > path-based MAC systems such as AppArmor and TOMOYO where > vm->def->seclabel is required to obtain the label. This patch simply > adds the 'virDomainObjPtr vm' argument back to *RestoreImageLabel. > > patch_1b_optional.patch: > Due to the above change, 'make syntax-check' fails because > SELinuxRestoreSecurityImageLabel() does not use the 'virDomainObjPtr > vm'. patch_1b_optional.patch is a simple patch to fix this by checking > if vm->def->seclabel == NULL and returns with error if it does. I > realize this may not be desired in the long term, but it should be > harmless enough to include. > > > [PATCH 2] > patch_2_security_c.patch: > Updates src/security.c for AppArmor > > > [PATCH 3] > patch_3_security_apparmor.patch: > Adds security_apparmor.c, security_apparmor.h, virt-aa-helper.c and > updates po/POTFILES.in. virt-aa-helper.c is a new binary which is used > exclusively by the AppArmor security driver to manipulate AppArmor. > These files compile without warning and pass syntax-check. > > > [PATCH 4] > patch_4_tests.patch: > Adds tests for virt-aa-helper and the security driver. secaatest.c is > identical to seclabeltest.c except it initializes the 'apparmor' driver > instead of 'selinux'. These tests are integrated into 'make check' and > pass. > > > [PATCH 5] > patch_5_docs.patch: > Updates docs/drvqemu.html.in for AppArmor and adds profile examples to > examples/apparmor. > > > [PATCH 6] > patch_6_autoconf.patch: > Updates Makefile.am and configure.in for AppArmor. It is based on and > should operate the same as the SELinux configuration. > > > Caveats and known issues: > 1. it does not take advantage of the recent host device labelling > functionality yet > 2. it does not properly handle hot-plugging of devices yet > 3. qemu:///session runs unconfined (see above) > > > Thanks! > > Jamie (jdstrand on Freenode and OFTC) > > [1] https://wiki.ubuntu.com/SecurityTeam/Specifications/AppArmorLibvirtProfile > [2] http://libvirt.org/git/?p=libvirt.git;a=commit;h=c86afc85ee0d1ec6d76c2d254b… > -- Jamie Strandboge | http://www.canonical.com

4 14

[libvirt] Passing -no-kvm-irqchip to KVM/QEMU guests
by Garry Dolley 16 Sep '09

16 Sep '09

Dear libvirt, Is there a way to tell a KVM/QEMU guest managed by libvirt to start with the "-no-kvm-irqchip" argument? I have some FreeBSD 7 guests with timing issues, and if I try to start the VMs manually with -no-kvm-irqchip, the timing issues go away (the only known workaround right now). However, if the guest is managed by libvirt, I have found no way to pass this command line option. I'm running libvirt 0.6.4 on Ubuntu 9.04 Thoughts? -- Garry Dolley ARP Networks, Inc. | http://www.arpnetworks.com | (818) 206-0181 Data center, VPS, and IP Transit solutions Member Los Angeles County REACT, Unit 336 | WQGK336 Blog http://scie.nti.st

3 3

[libvirt] Python binding to virConnectListInterfaces
by Shahar Klein 16 Sep '09

16 Sep '09

Hi I'm trying to implement virConnectListInterfaces for the ESX driver (actually the esx_interface driver) but the python generator does not write the code for this function in generator.py this function is in a special table called: skip_impl and there is a comment saying: # Class methods which are written by hand in libvir.c but the Python-level # code is still automatically generated (so they are not in skip_function()) I'm not sure what does it mean should I implement in libvir.c? and I'm done? thanks ahead Shahar

4 8

[libvirt] ESX driver does not support vmxnet3
by Shahar Klein 16 Sep '09

16 Sep '09

diff --git a/src/esx/esx_vmx.c b/src/esx/esx_vmx.c index 70e9305..6bd6b93 100644 --- a/src/esx/esx_vmx.c +++ b/src/esx/esx_vmx.c @@ -1409,10 +1409,11 @@ esxVMX_ParseEthernet(virConnectPtr conn, virConfPtr conf, int controller, if (virtualDev != NULL && STRCASENEQ(virtualDev, "vlance") && STRCASENEQ(virtualDev, "vmxnet") && + STRCASENEQ(virtualDev, "vmxnet3") && STRCASENEQ(virtualDev, "e1000")) { ESX_ERROR(conn, VIR_ERR_INTERNAL_ERROR, "Expecting VMX entry '%s' to be 'vlance' or 'vmxnet' or " - "'e1000' but found '%s'", virtualDev_name, virtualDev); + "'vmxnet3' or 'e1000' but found '%s'", virtualDev_name, virtualDev); goto failure; }

3 2

[libvirt] [PATCH] doc: don't emit trailing blanks into generated and VC'd NEWS file
by Jim Meyering 15 Sep '09

15 Sep '09

Daniel Veillard reported that the generated and VC'd NEWS file was causing trouble because the latest version contains trailing spaces, which conflicts with our server-side hook to prevent that. Here's the fix to avoid emitting those trailing spaces: >From 8110d304f49a217021371321ade0026ccd2627e1 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Tue, 15 Sep 2009 15:01:26 +0200 Subject: [PATCH] doc: don't emit trailing blanks into generated and VC'd NEWS file * docs/Makefile.am ($(top_builddir)/NEWS): Filter out trailing white space. --- docs/Makefile.am | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 9ac2f6d..1125931 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -131,6 +131,7 @@ $(top_builddir)/NEWS: $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.i $(XSLTPROC) --nonet $(top_srcdir)/docs/news.xsl \ $(top_srcdir)/docs/news.html.in \ | perl -0777 -pe 's/\n\n+$$/\n/' \ + | perl -pe 's/[ \t]+$//' \ > $@-t && mv $@-t $@ ; fi ); clean-local: -- 1.6.5.rc1.171.g3f463

2 1

[libvirt] Release of libvirt-0.7.1
by Daniel Veillard 15 Sep '09

15 Sep '09

Okay, it's finally out of the box and available as usual at ftp://libvirt.org/libvirt/ There is a fair amount of new features and improvement, not surprizing considering 0.7.0 was 1.5 months ago. And of course many bug fixes and cleanups: * New Features: - Add an internal <secret> XML handling API (Miloslav Trmač) - VBox 3.0.6 API change support (Pritesh Kothari) - also allow use of XZ for Qemu image compression (Jim Meyering) - Multipath storage support module (Dave Allan) - VBox add Storage Volume support (Pritesh Kothari) - Support configuration of huge pages in guests (Daniel P. Berrange) - Add support for encrypted (qcow) volume creation. (Miloslav Trmač) - Secret manipulation public API (Miloslav Trmač) - support lzop save compression for qemu (Charles Duffy) - Support new PolicyKit 1.0 API (Daniel P. Berrange) - Compressed save image format for Qemu. (Chris Lalancette) - QEmu add host PCI device hotplug support (Mark McLoughlin) * Portability: - Fix win32 platform build (Daniel P. Berrange) * Documentation: - Minor comment changes (Laine Stump) - Fix up virNodeGetCellsFreeMemory (Chris Lalancette) - Fix some typos & remove unhelpful acronyms in QEMU docs (Daniel P. Berrange) - Add documentation about the QEMU driver security features (Daniel P. Berrange) - Remove 'the the' typo in docs (Daniel P. Berrange) - Fix some URLs in virsh manpage (Mark McLoughlin) - Add link to AbiCloud web management system (Daniel P. Berrange) - Update logging documentation (Amy Griffis) * Bug Fixes: - VBox bug when starting machine from old versions (Pritesh Kothari) - ESX avoid potential leaks (Matthias Bolte) - Fix more OOM handling bugs (Daniel P. Berrange) - Fix logging buffer overrun read (Daniel P. Berrange) - Fix misc thread locking bugs / bogus warnings (Daniel P. Berrange) - Fix regression from "Avoid polling on FDs with no events" (Chris Lalancette) - Close logfile fd after spawning qemu (Ryota Ozaki) - Check for libssh2 >= 1.0 for phy driver (Maximilian Wilhelm) - Avoid another leak in src/xend_internal.c (Matthias Bolte) - Avoid a leak in xenDaemonLookupByID (Matthias Bolte) - VBox fix minor bugs in display and added OOM checks (Pritesh Kothari) - Some close/fclose/closedir calls are missing (Matthias Bolte) - lxc_container.c: avoid a leak on error paths (Jim Meyering) - Fix several memory leaks (Ryota Ozaki) - Fix a memory leak in virsh (Laine Stump) - Fix ID field in virDomainPtr after starting Xen VM (Daniel P. Berrange) - Fix memory leak of monitor character device (Daniel P. Berrange) - Automatically set correct ownership of QEMU state directories (Daniel P. Berrange) - Avoid polling on FDs with no events enabled (Daniel P. Berrange) - esx_vi: return -1 upon failure, as intended (Matthias Bolte) - python: let libvirt_virConnectDomainEventCallback indicate success (Jim Meyering) - uml_conf.c: don't return an uninitialized pointer (Jim Meyering) - storage_backend.c: assure clang that inputvol can't be NULL (Jim Meyering) - libvir.c: avoid NULL dereference in virStoragePoolSetAutostart (Jim Meyering) - lxc: avoid NULL dereference upon getmntent failure (Jim Meyering) - storage_backend_fs: avoid NULL dereference on opendir failure (Jim Meyering) - Fix bugs in virDomainMigrate v2 code. (Chris Lalancette) - VMware ESX: Don't warn on some query parameter (Matthias Bolte) - Don't blindly reorder disk drives (Daniel P. Berrange) - Fix sexpr2string() to handle empty list. (Jim Fehlig) - Fix driver entry table for UML numa APIs (Daniel P. Berrange) - Fix crash in virsh vol-key command (Pritesh Kothari) - 517157 fix selinux problem with images on NFS (Darryl L. Pierce) - Fix phypOpen() escape_specialcharacters (Mattias Bolte) - Power Hypervisor: fix potential segfault (Mattias Bolte) - Fix bridge/tap system error reporting (Mark McLoughlin) - Reset PCI host devices after hot-unplug (Mark McLoughlin) - Reset unmanaged PCI host devices before hotplug (Mark McLoughlin) - Fix up connection reference counting. (Chris Lalancette) - Fix LXC driver crash when kernel doesn't support clone (Daniel P. Berrange) - Make LXC / UML drivers robust against NUMA topology brokenness (Daniel P. Berrange) - Run 'cont' on successful migration finish. (Chris Lalancette) - Fix QEMU domain status after restore. (Chris Lalancette) - Handle kernels with no ipv6 support (Mark McLoughlin) - Set perms on /var/lib/libvirt/boot to 0711 (Mark McLoughlin) - chown kernel/initrd before spawning qemu (Mark McLoughlin) - Several fixes to libvirtd's log setup (Amy Griffis) - Fix memleak if esxOpen fails (Matthias Bolte) * Improvements: - Add UUID definition required by storage encryption import (Daniel P. Berrange) - Make secrets RNG more strict (Daniel P. Berrange) - Fill in secret UUID for qcow encryption (Daniel P. Berrange) - Add usage type/id as a public API property of virSecret (Daniel P. Berrange) - Fix UUID handling in secrets/storage encryption APIs (Daniel P. Berrange) - Save vcpuinfo in status file (Daniel P. Berrange) - Restart libvirtd upon RPM upgrade (Daniel P. Berrange) - Add support for qcow encrypted volumes to qemu. (Miloslav Trmač) - Provide missing passphrase when creating a volume. (Miloslav Trmač) - Add virsh commands for secrets APIs (Miloslav Trmač) - Local file implementation of secret driver API (Miloslav Trmač) - Mask out flags used internally for virSecretGetValue (Miloslav Trmač) - Add <usage> to <secret> docs (Miloslav Trmač) - Support relabelling of USB and PCI devices (Daniel P. Berrange) - Add helper APIs for iterating over PCI device resource files (Daniel P. Berrange) - Add helper module for dealing with USB host devices (Daniel P. Berrange) - Test that domain-specific qemu machine types are used correctly (Mark McLoughlin) - Probe machine types from kvm binary too (Mark McLoughlin) - Look up machine types from all domains in qemudGetOldMachines() (Mark McLoughlin) - Test qemu machine aliases (Mark McLoughlin) - Add qemu -help test data for qemu-kvm-0.11.0-rc2 (Mark McLoughlin) - Add a more featureful qemu capabilities test data (Mark McLoughlin) - Add arm arch to capabilities schema (Mark McLoughlin) - Update capabilities schema to allow multiple machines per domain (Mark McLoughlin) - Add esx and tcp migration uri transports to capabilities schema (Mark McLoughlin) - Reintroduce support for lzop compression (Charles Duffy) - build: update gnulib submodule to latest (Jim Meyering) - Add flags and requires for Multipath storage (Daniel Veillard) - ESX raise error if UUID parse failed (Matthias Bolte) - ESX add domain undefine based on esxVI_UnregisterVM (Matthias Bolte) - ESX add esxGetCapabilities() with basic defaults (Matthias Bolte) - Switch Power Hypervisor to libssh2 (Eduardo Otubo) - Allow libvirtd to RPC to external libvirtd (Chris Lalancette) - Add support for setting disk drive serial numbers (Daniel P. Berrange) - VBox support for defining/dumping video devices (Pritesh Kothari) - Generic parsing support for video acceleration (Pritesh Kothari) - VMware ESX: Allow ethernet address type 'vpx' (Matthias Bolte) - Support for getting/setting number of cpus in VBox (Pritesh Kothari) - Make handling of monitor prompts more general. (Miloslav Trmač) - Attach encryption information to virDomainDiskDef. (Miloslav Trmač) - Recognize encryption format of qcow volumes. (Miloslav Trmač) - Attach encryption information to virStorageVolDef. (Miloslav Trmač) - Add volume encryption information handling. (Miloslav Trmač) - Secret manipulation API docs refresh & wire up python generator (Miloslav Trmač) - Secret manipulation remote client (Miloslav Trmač) - Secret manipulation libvirtd wire protocol & remote dispatcher (Miloslav Trmač) - Secret manipulation public API implementation (Miloslav Trmač) - Secret manipulation internal API (Miloslav Trmač) - Add test for recently fixed crash with latest XenD (Daniel P. Berrange) - Don't expose 'vnet%d' to the user (Mark McLoughlin) - Maintain a list of active PCI hostdevs and use it in pciResetDevice() (Mark McLoughlin) - Simplify PCI hostdev prepare/re-attach using a pciDeviceList type (Mark McLoughlin) - Use pci_addr=auto with QEMU's pci_add monitor command (Mark McLoughlin) - Check active domain hostdevs before allowing PCI reset (Mark McLoughlin) - Allow pciResetDevice() to reset multiple devices (Mark McLoughlin) - Improve PCI host device reset error message (Mark McLoughlin) - Reset and re-attach PCI host devices on guest shutdown (Mark McLoughlin) - Allow PM reset on multi-function PCI devices (Mark McLoughlin) - Detect KVM's PCI device assignment support (Mark McLoughlin) - Split virDomainMigrate into functions. (Chris Lalancette) - Consolidate code for parsing the logging env (Amy Griffis) * Cleanups: - Remove accidentally added UUID re-definition in storage schema (Daniel P. Berrange) - ESX cleanup of CPU model strings (Matthias Bolte) - Fix use of dlopen modules (Daniel P. Berrange) - Consolidate "cont" into qemudMonitorSendCont() (Miloslav Trmač) - Cleanup sec driver error reporting to use virReportSystemError (Daniel P. Berrange) - Port QEMU driver to use USB/PCI device helpers (Daniel P. Berrange) - Simplify and fix qemudCanonicalizeMachine() (Mark McLoughlin) - Split up qemudGetOldMachines() (Mark McLoughlin) - Re-factor qemu test machine allocation code (Mark McLoughlin) - Canonicalize the qemu machine type in qemuxml2argvtest (Mark McLoughlin) - Dump qemu driver capabilities if test debugging enabled (Mark McLoughlin) - Fix formatting of machine types in capabilities XML (Mark McLoughlin) - qemu_driver.c: factor out more duplication (Jim Meyering) - Deprecate lzma and lzop in favor of xz, add dep (Daniel Veillard) - qemu_driver.c: factor out duplication in compression-type handling (Jim Meyering) - openvz_conf.c: remove dead store to "p"; use strchrnul (Jim Meyering) - Remove some tabs used for indent (Daniel Veillard) - Updated a number of localizations and regenerated (Daniel Veillard) - Add a missing comment (Miloslav Trmač) - Fix a pasto in storage_encryption_conf.c (Miloslav Trmač) - xm_internal.c: remove four useless comparisons after strchr (Jim Meyering) - xm_internal.c: remove dead increment of "data" (Jim Meyering) - network_driver.c: remove dead store to "err" (Jim Meyering) - iptables.c: remove dead store to "s" (Jim Meyering) - util.c: avoid dead store to "flag" (Jim Meyering) - domain_conf.c: remove two dead stores (Jim Meyering) - xm_internal.c: remove two ret=... dead stores (Jim Meyering) - xm_internal.c: remove dead stores of local, "type" (Jim Meyering) - network_conf.c: remove dead store to "err" (Jim Meyering) - openvz_driver.c: avoid dead store to "err" (Jim Meyering) - xend_internal.c: Remove two dead stores to "ret" (Jim Meyering) - storage_driver.c: remove two dead stores to "backend" (Jim Meyering) - qemu_conf.c: add a comment suggesting why we leave a dead-store (Jim Meyering) - hash.c: remove a dead store (Jim Meyering) - interface_conf.c: remove a dead-store and declaration (Jim Meyering) - eventtest.c: detect write failure and avoid dead stores (Jim Meyering) - openvz_conf.c: Remove dead store to copy_fd (Jim Meyering) - storage_backend_logical.c: appease clang: remove useless increment (Jim Meyering) - ESX simplify SOAP request and response handling (Matthias Bolte) - ESX use virXPathNode*() to simplify XPath handling (Matthias Bolte) - ESX: make esxVI_GetVirtualMachineIdentity() robust (Matthias Bolte) - ESX: Fix VMX path parsing and URL encoding (Matthias Bolte) - VBox driver cleanups (Pritesh Kothari) - PHYP driver cleanups (Daniel Veillard) - Move QEMU monitor socket in /var/lib/libvirt/qemu (Daniel P. Berrange) - xen_internal.c: remove two unused local variables (Jim Meyering) - mdns.c: remove dead initialization (Jim Meyering) - node_device_conf.c: remove dead initialization (Jim Meyering) - openvz_conf.c: don't use undefined local, "net" (Jim Meyering) - test.c: don't use undefined local, "def" (Jim Meyering) - remote_internal.c: appease clang (Jim Meyering) - infra: define ATTRIBUTE_NONNULL to mark non-NULL parameters (Jim Meyering) - lxc: don't unlink(NULL) in main (Jim Meyering) - storage_conf.c: avoid overflow upon use of "z" or "Z" (zebi) suffix (Jim Meyering) - VBox cleanup and update of networking shutdown (Pritesh Kothari) - Box cleanup and update of networking XML functions (Pritesh Kothari) - Fix misc OOM bugs (Daniel P. Berrange) - Misc fixes to secrets API code (Daniel P. Berrange) - Only add glusterfs dep for Fedora >= 11 (Daniel P. Berrange) - Remove redundant base64 include file (Daniel P. Berrange) - Don't assume buffered output echoes the command. (Miloslav Trmač) - Update chinese, polish and spanish localizations (Daniel Veillard) - OpenVZ: accept NULL as type for GetMaxVCPUs. (Chris Lalancette) - Remove use of strncpy in qemudExtractMonitorPath. (Chris Lalancette) - Refactor policycode auth code to avoid compiler warnings (Daniel P. Berrange) - spec file: add URL to Source tag (Mark McLoughlin) - Small fixes for qemu save compression. (Chris Lalancette) - Fix thinko in PCI hostdev detach (Mark McLoughlin) - Revert changes to allow pciResetDevice() reset multiple devices (Mark McLoughlin) - Fix list updating after disk/network/hostdev hot-unplug (Mark McLoughlin) - Re-name remote_internal.c:driver to remote_driver (Mark McLoughlin) - Cosmetic change to 'virsh nodedev-list --tree' output (Mark McLoughlin) - Re-factor hostdev hotplug (Mark McLoughlin) - Remove a duplicated assignment in Xen PCI parsing. (Chris Lalancette) - Fix up a few minor indentation issues. (Chris Lalancette) - Fix phyp escape_specialcharacters. (Chris Lalancette) - Make openvzGetVPSUUID take a len. (Chris Lalancette) - Minor cleanup of error path for c_oneVmInfo. (Chris Lalancette) - Fix up a whitespace in comments in src/console.c (Chris Lalancette) - Fix up a stray whitespace in virHashGrow. (Chris Lalancette) - Remove unsafe strncpy from esx_vmx.c (Chris Lalancette) - Cleanup VIR_LOG_DEBUG parsing in eventtest (Amy Griffis) - Tighten libvirt's parsing of logging env (Amy Griffis) - Cleanup structure name naming (Matthias Bolte) - Add proper OOM reporting for esxDomainGetOSType (Matthias Bolte) Thanks to everybody who contributed one way or another, this list is getting longuer every release :-) Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] Trouble booting Xen VM with NFS root file system
by Matthias Schmidt 15 Sep '09

15 Sep '09

Hi, I'm currently trying to boot a Xen VM with the root file system on NFS via libvirt. Previously we used a small python script and "xm create" to boot a number of VMs (which worked fine). Now I'm trying to integrate that functionality in a python project which uses libvirt, but sadly booting the VMs fail. The small script constructs a Xen command line which looks like the following: create =("/usr/sbin/xm create /foo.cfg \ kernel=%s ramdisk=%s memory=64\ root=/dev/nfs nfs_server=%s nfs_root=%s name=%s vif='mac=%s'\ dhcp='dhcp' vcpus=1 extra='init=/stateless.sh xencons=tty1'\ ")%(vm_kernel, vm_ramdisk, vm_nfs_server, vm_nfs_root, hostname, vif) kernel and ramdisk are the path to the installed version, vm_nfs_server is the IP address of the NFS server and vm_nfs_root the path to the operating system installation (which is a Debian Linux). Firing up the script brings up all VMs with a read-only NFS root file system. Now I tried to do this with libvirt, but all attempts failed with the following error popping up after the VM boots (after a certain time(out)): Gave up waiting for root device. Common problems: - Boot args (cat /proc/cmdline) - Check rootdelay= (did the system wait long enough?) - Check root= (did the system wait for the right device?) - Missing modules (cat /proc/modules; ls /dev) ALERT! /dev/nfs does not exist. Dropping to a shell! BusyBox v1.10.2 (Debian 1:1.10.2-2) built-in shell (ash) Enter 'help' for a list of built-in commands. /bin/sh: can't access tty; job control turned off (initramfs) cat /proc/cmdline root=/dev/nfs nfs_server=10.0.0.150 nfs_root=/opt/xge/util/ph vif="mac=1A:00:00:00:00:64" dhcp=dhcp extra="init=./stateless.sh xencons=tty" The cmdline looks the same as in the script, but booting won't work. I can provide the libvirt XML used to boot the VM and further information if that is necessary. Cheers Matthias PS: I'm using Xen 3.2.1, Kernel 2.6.26 and libvirt 0.6.3 from Debian here.

2 1

[libvirt] RFE storage cloning across connections.
by "Jóhann B. Guðmundsson" 15 Sep '09

15 Sep '09

Virt-manager now supports migration and VM cloning however cloning only works within a connection though so you can't clone to another machine. It certainly would be a nice addition if supports storage cloning across connections. Best regards. Jóhann B.

2 1

[libvirt] ANNOUNCE: perl bindings Sys-Virt release 0.2.2
by Daniel P. Berrange 14 Sep '09

14 Sep '09

FYI I have just uploaded a new release 0.2.2 of the libvirt perl bindings, Sys-Virt, to CPAN. http://search.cpan.org/dist/Sys-Virt/ Direct download link http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-0.2.2.tar.gz Changes since 0.2.1: - Add all new APIs upto libvirt 0.7.0 APIs (listing defined network interfaces) - Add missing APIs for looking up storage volumes based on path and key - Fix lookup of network interfaces based on MAC address - Add missing APIs for defining network interfaces and starting defined interfaces There will of course shortly be another release to cover the soon to be released APIs in libvirt 0.7.1 Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

Re: [libvirt] Interface driver and ESX support
by Matthias Bolte 14 Sep '09

14 Sep '09

Okay, I finally got the patches cleaned up. I just posted this 12 patches series to the mailing list. Apply them all to an up to date git clone and apply the attached, updated ESX interface driver stub patch in the end. Patch 6 of 12 adds the binding for HostCpuIdInfo and contains the functions to handle ArrayOf* types. Matthias 2009/9/13 Shahar Klein <shaharklein(a)yahoo.com>: > I see > You are making my (coding) life easier : ) > thanks > ________________________________ > From: Matthias Bolte <matthias.bolte(a)googlemail.com> > To: Shahar Klein <shaharklein(a)yahoo.com> > Cc: libvir-list(a)redhat.com > Sent: Sunday, September 13, 2009 4:39:22 PM > Subject: Re: [libvirt] Interface driver and ESX support > > No, as I said before you should wait until you can use the unpublished > binding of HostCpuIdInfo as an example. This also includes the code to > handle ArrayOf* types. I'm currently cleaning up this patches (didn't > have time on thursday for that) and will post them today, just wait > for this patches, because they will help you. > > Matthias > > 2009/9/13 Shahar Klein <shaharklein(a)yahoo.com>: >> I've defined (among others): >> int esxVI_PhysicalNic_CastListFromAnyType(virConnectPtr conn, >> esxVI_AnyType >> *anyType, esxVI_PhysicalNic **pNicList); >> but runing it returns somthing like: >> Expecting type 'PhysicalNic' but found 'ArrayOfPhysicalNic' >> Does it mean I should also implement: >> esxVI_ArrayOfPhysicalNic_CastListFromAnyType() >> and all the funcs/type definition coming with it? >> thanks >> Shahar >> ________________________________ >> From: Matthias Bolte <matthias.bolte(a)googlemail.com> >> To: Shahar Klein <shaharklein(a)yahoo.com> >> Cc: libvir-list(a)redhat.com >> Sent: Thursday, September 10, 2009 6:24:25 PM >> Subject: Re: [libvirt] Interface driver and ESX support >> >> 2009/9/10 Shahar Klein <shaharklein(a)yahoo.com>: >>> I'm not sure what you mean about mapping >>> lets take the pnics as a study case for me >>> do I need to define a structure similar to this: >>> >>> >>> http://www.vmware.com/support/developer/vc-sdk/visdk400pubs/ReferenceGuide/… >>> and also take care for it's allocation? >>> >> >> Yes, you need to implement the mapping (a better word may be >> 'binding') of this VI API type to a C type, that also includes to care >> about its allocation. You'll need to implement at least this set of >> function in esx_vi_types.[ch]: >> >> esxVI_PhysicalNic_Alloc() >> esxVI_PhysicalNic_Free() >> esxVI_PhysicalNic_CastFromAnyType() >> esxVI_PhysicalNic_CastListFromAnyType() >> esxVI_PhysicalNic_Deserialize() >> esxVI_PhysicalNic_DeserializeList() >> >> You could use the binding for the HostCpuIdInfo type, but >> unfortunately I haven't published the code for it yet. This code also >> includes some essential helper functions for >> esxVI_PhysicalNic_CastListFromAnyType(). >> >> Beside the PhysicalNic type, you may also have to bind the types of >> its members like PhysicalNicLinkInfo, PhysicalNicSpec and >> HostIpConfig, if you need or care about the information provided by >> them. >> >> The binding for HostCpuIdInfo is part of a larger set of patches that >> add some new features to ESX driver, but the patches needs some >> cleanup first. I may have some time later this evening to clean them >> up and post them. >> >> PS: You should refer to version 2.5 of the VI API [1] and not 4.0, >> because the complete VI API mapping is currently based on version 2.5. >> At some point I'll have to properly distinguish between version 2.5 >> and 4.0, but currently I would like to stick to version 2.5 only. >> >> [1] >> http://www.vmware.com/support/developer/vc-sdk/visdk25pubs/ReferenceGuide/ >> >> Matthias >> >> > >

3 3

[libvirt] [PATCH]: Bug when you try to start machines made will older VBox versions
by Pritesh Kothari 14 Sep '09

14 Sep '09

Hi All, Thanks to Florian, who pointed out the bug, due to which you can't start domains defined with older builds or with empty "FRONTEND/Type" tag in their xml files. Fixed it in the following patch. Regards, Pritesh

2 1