- Devel - libvirt List Archives

[libvirt] Visualizing the first four years of libvirt development
by Daniel P. Berrange 17 Jan '10

17 Jan '10

>From the 'just a bit of fun' category, I've published a couple of videos visualizing the first four years of libvirt development The first, created using 'gource' [1]: http://www.youtube.com/watch?v=sEN4gxmCOuw The second, creating using 'code_swarm' [2]: http://www.youtube.com/watch?v=ptvATk1xPIw In both of these you can clearly tell when we started using GIT, since the improved patch author attribution results in an explosion of participants in the visualizations :-) Of course some of that is also due to the expanding libvirt development from the introduction of new drivers like VMWare and VirtualBox... Regards, Daniel [1] http://code.google.com/p/gource/ [2] http://code.google.com/p/codeswarm/ -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] Supressing error messages
by Bryan Kearney 15 Jan '10

15 Jan '10

When using the java library, we are seeing libvirt error messages spit out.. such as: libvir: Remote error : unable to connect to '/var/run/libvirt/libvirt-sock': No such file or directory Is there a means of supressing that logging via the api? -- bk

2 1

[libvirt] [PATCH] Fix validation of news.html
by Matthias Bolte 15 Jan '10

15 Jan '10

FYI, I pushed this simple fix. Matthias --- docs/news.html.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/docs/news.html.in b/docs/news.html.in index 7e06096..83b394f 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -26,7 +26,7 @@ and check the <a href="ChangeLog.html">ChangeLog</a> to gauge progress. esx: Extend documentation about 'vcenter' and add some about 'auto_answer' (Matthias Bolte), Fix and improve domain xml video element description (Matthias Bolte), Fix owner and group in example volume XML (Matthew Booth), - add missing doc for device <shareable/> option (Daniel Veillard), + add missing doc for device <shareable/> option (Daniel Veillard), add AppArmor test and examples to dist (Jamie Strandboge), Update location of C# bindings. (Richard Jones), Fix typo in QEMU driver webpage (Daniel P. Berrange), -- 1.6.3.3

1 0

[libvirt] [PATCH] gnulib added a new syntax-check test: use $(VAR), not @VAR@
by Jim Meyering 15 Jan '10

15 Jan '10

Updating to newer gnulib also pulled in a new sytnax-check test that evoked new warnings. No big deal, but I addressed them. The only trick was to see that the warnings about @SCHEMADIR@ and @SYSCONFDIR@ were false positives. To allow them, I defined the variable in cfg.mk. See below. >From 6e76cfe38ba0ccafa7c4e81dcc0af04e31f8f447 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 11:09:01 +0100 Subject: [PATCH] gnulib added a new syntax-check test: use $(VAR), not @VAR@ The latter is not officially "wrong", but *is* terribly anachronistic. I think automake documentation or comments call that syntax obsolescent. * cfg.mk (_makefile_at_at_check_exceptions): Exempt @SCHEMADIR@ and @SYSCONFDIR@ uses -- there are no Makefile variables for those. * docs/Makefile.am: Use $(INSTALL), not @INSTALL@. * examples/dominfo/Makefile.am: Similar. * examples/domsuspend/Makefile.am: Similar. * proxy/Makefile.am: Similar. * python/Makefile.am: Similar. * python/tests/Makefile.am: Similar. * src/Makefile.am: Similar. * tests/Makefile.am: Similar. --- cfg.mk | 5 ++++- docs/Makefile.am | 4 ++-- examples/dominfo/Makefile.am | 2 +- examples/domsuspend/Makefile.am | 2 +- proxy/Makefile.am | 2 +- python/Makefile.am | 10 +++++----- python/tests/Makefile.am | 2 +- src/Makefile.am | 10 +++++----- tests/Makefile.am | 2 +- 9 files changed, 21 insertions(+), 18 deletions(-) diff --git a/cfg.mk b/cfg.mk index 45d6531..0f2d2a6 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1,5 +1,5 @@ # Customize Makefile.maint. -*- makefile -*- -# Copyright (C) 2003-2009 Free Software Foundation, Inc. +# Copyright (C) 2003-2010 Free Software Foundation, Inc. # This program is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -265,3 +265,6 @@ ifeq (0,$(MAKELEVEL)) $(error gnulib update required; run ./autogen.sh first) endif endif + +# Exempt @...@ uses of these symbols. +_makefile_at_at_check_exceptions = ' && !/(SCHEMA|SYSCONF)DIR/' diff --git a/docs/Makefile.am b/docs/Makefile.am index c19e963..eaac627 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -143,7 +143,7 @@ rebuild: api all install-data-local: $(mkinstalldirs) $(DESTDIR)$(HTML_DIR) - -@INSTALL@ -m 0644 $(srcdir)/FAQ.html \ + -$(INSTALL) -m 0644 $(srcdir)/FAQ.html \ $(srcdir)/Libxml2-Logo-90x34.gif $(DESTDIR)$(HTML_DIR) $(mkinstalldirs) $(DESTDIR)$(HTML_DIR)/html for h in $(apihtml); do \ @@ -152,7 +152,7 @@ install-data-local: $(INSTALL) -m 0644 $(srcdir)/$$p $(DESTDIR)$(HTML_DIR)/html; done $(mkinstalldirs) $(DESTDIR)$(DEVHELP_DIR) for file in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ - @INSTALL@ -m 0644 $(srcdir)/$${file} $(DESTDIR)$(DEVHELP_DIR) ; \ + $(INSTALL) -m 0644 $(srcdir)/$${file} $(DESTDIR)$(DEVHELP_DIR) ; \ done uninstall-local: diff --git a/examples/dominfo/Makefile.am b/examples/dominfo/Makefile.am index a1694b8..2913e5b 100644 --- a/examples/dominfo/Makefile.am +++ b/examples/dominfo/Makefile.am @@ -1,6 +1,6 @@ INCLUDES = -I$(top_builddir)/include -I$(top_srcdir)/include -I@srcdir@/include -LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la $(COVERAGE_LDFLAGS) +LDADDS = $(STATIC_BINARIES) $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la $(COVERAGE_LDFLAGS) noinst_PROGRAMS=info1 diff --git a/examples/domsuspend/Makefile.am b/examples/domsuspend/Makefile.am index 41e9fdb..14b4205 100644 --- a/examples/domsuspend/Makefile.am +++ b/examples/domsuspend/Makefile.am @@ -1,6 +1,6 @@ INCLUDES = -I$(top_builddir)/include -I$(top_srcdir)/include -I@srcdir@/include -LDADDS = @STATIC_BINARIES@ $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la $(COVERAGE_LDFLAGS) +LDADDS = $(STATIC_BINARIES) $(WARN_CFLAGS) $(top_builddir)/src/libvirt.la $(COVERAGE_LDFLAGS) noinst_PROGRAMS=suspend diff --git a/proxy/Makefile.am b/proxy/Makefile.am index 97d6e5a..aef11ca 100644 --- a/proxy/Makefile.am +++ b/proxy/Makefile.am @@ -7,7 +7,7 @@ INCLUDES = -I$(top_srcdir)/gnulib/lib -I../gnulib/lib \ -I@top_srcdir@/src/util \ -I@top_srcdir@/src/conf \ -I@top_srcdir@/src/xen \ - @LIBXML_CFLAGS@ \ + $(LIBXML_CFLAGS) \ -DPROXY -DLOCALEBASEDIR=\""$(datadir)/locale"\" \ -DGETTEXT_PACKAGE=\"$(PACKAGE)\" $(WARN_CFLAGS) $(XEN_CFLAGS) diff --git a/python/Makefile.am b/python/Makefile.am index 58c6729..6b67e38 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -37,12 +37,12 @@ pyexec_LTLIBRARIES = libvirtmod.la libvirtmod_la_SOURCES = libvirt-override.c typewrappers.c libvirt.c libvirt.h # Python <= 2.4 header files contain a redundant decl, hence we # need extra flags here -libvirtmod_la_CFLAGS = @WARN_PYTHON_CFLAGS@ +libvirtmod_la_CFLAGS = $(WARN_PYTHON_CFLAGS) libvirtmod_la_LDFLAGS = -module -avoid-version -shared -L$(top_builddir)/src/.libs \ - @CYGWIN_EXTRA_LDFLAGS@ + $(CYGWIN_EXTRA_LDFLAGS) libvirtmod_la_LIBADD = $(mylibs) \ - @CYGWIN_EXTRA_LIBADD@ @CYGWIN_EXTRA_PYTHON_LIBADD@ + $(CYGWIN_EXTRA_LIBADD) $(CYGWIN_EXTRA_PYTHON_LIBADD) GENERATE = generator.py API_DESC = $(top_srcdir)/docs/libvirt-api.xml $(srcdir)/libvirt-override-api.xml @@ -61,10 +61,10 @@ $(libvirtmod_la_OBJECTS): $(GENERATED) install-data-local: $(mkinstalldirs) $(DESTDIR)$(pyexecdir) - @INSTALL@ -m 0644 libvirt.py $(DESTDIR)$(pyexecdir) + $(INSTALL) -m 0644 libvirt.py $(DESTDIR)$(pyexecdir) $(mkinstalldirs) $(DESTDIR)$(DOCS_DIR) @(for doc in $(DOCS) ; \ - do @INSTALL@ -m 0644 $$doc $(DESTDIR)$(DOCS_DIR) ; done) + do $(INSTALL) -m 0644 $$doc $(DESTDIR)$(DOCS_DIR) ; done) uninstall-local: rm -f $(DESTDIR)$(pyexecdir)/libvirt.py diff --git a/python/tests/Makefile.am b/python/tests/Makefile.am index 6011fef..28e24ba 100644 --- a/python/tests/Makefile.am +++ b/python/tests/Makefile.am @@ -30,7 +30,7 @@ clean: install-data-local: $(mkinstalldirs) $(DESTDIR)$(EXAMPLE_DIR) -(for test in $(PYTESTS); \ - do @INSTALL@ -m 0644 $(srcdir)/$$test $(DESTDIR)$(EXAMPLE_DIR) ; done) + do $(INSTALL) -m 0644 $(srcdir)/$$test $(DESTDIR)$(EXAMPLE_DIR) ; done) uninstall-local: for test in $(PYTESTS); do rm -f $(DESTDIR)$(EXAMPLE_DIR)/$$test; done diff --git a/src/Makefile.am b/src/Makefile.am index 324030b..af97938 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -800,13 +800,13 @@ libvirt.syms: libvirt_public.syms $(USED_SYM_FILES) # Empty source list - it merely links a bunch of convenience libs together libvirt_la_SOURCES = libvirt_la_LIBADD += \ - @CYGWIN_EXTRA_LIBADD@ ../gnulib/lib/libgnu.la + $(CYGWIN_EXTRA_LIBADD) ../gnulib/lib/libgnu.la libvirt_la_LDFLAGS = $(VERSION_SCRIPT_FLAGS)libvirt.syms \ - -version-info @LIBVIRT_VERSION_INFO@ \ + -version-info $(LIBVIRT_VERSION_INFO) \ $(COVERAGE_CFLAGS:-f%=-Wc,-f%) \ $(LIBXML_LIBS) \ $(DRIVER_MODULE_LIBS) \ - @CYGWIN_EXTRA_LDFLAGS@ @MINGW_EXTRA_LDFLAGS@ + $(CYGWIN_EXTRA_LDFLAGS) $(MINGW_EXTRA_LDFLAGS) libvirt_la_CFLAGS = $(COVERAGE_CFLAGS) -DIN_LIBVIRT libvirt_la_DEPENDENCIES = $(libvirt_la_LIBADD) libvirt.syms @@ -818,8 +818,8 @@ noinst_LTLIBRARIES += libvirt_test.la # Remove version script from convenience library test_LDFLAGS = \ $$(echo '$(libvirt_la_LDFLAGS)' \ - |sed 's!@VERSION_SCRIPT_FLAGS@libvirt.syms!!' \ - |sed 's!-version-info @LIBVIRT_VERSION_INFO@!!') + |sed 's!$(VERSION_SCRIPT_FLAGS)libvirt.syms!!' \ + |sed 's!-version-info $(LIBVIRT_VERSION_INFO)!!') # Just like the above, but with a slightly different set of public symbols. libvirt_test_la_SOURCES = $(libvirt_la_SOURCES) diff --git a/tests/Makefile.am b/tests/Makefile.am index a20d7ce..584bdb3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -27,7 +27,7 @@ INCLUDES += \ endif LDADDS = \ - @STATIC_BINARIES@ \ + $(STATIC_BINARIES) \ $(LIBXML_LIBS) \ $(GNUTLS_LIBS) \ $(SASL_LIBS) \ -- 1.6.6.556.gd6679

2 1

[libvirt] Using ESX domain XML for V2V
by Matthew Booth 15 Jan '10

15 Jan '10

I'm trying to use the ESX driver to extract metadata from ESX in an easily digestible form for driving V2V. I've noticed the domain XML seems to be missing a few bits: <features/> <graphics/> <input/> <serial/> and <console/> are also missing, but that could well be because they aren't present. Is this intentional? Should I be assuming some of the above because it's ESX, or is this an omission? Thanks, Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team M: +44 (0)7977 267231 GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490

3 6

[libvirt] [PATCH] Fix compilation of virt-aa-helper.c
by Matthias Bolte 15 Jan '10

15 Jan '10

Commit 5073aa994af460e775cb3e548528e28d7660fcc8 added an additional '}' to a case block that messed up the block structure of the get_files function. --- src/security/virt-aa-helper.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 3c8b49a..1b0b2cd 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -851,7 +851,6 @@ get_files(vahControl * ctl) if (rc != 0) goto clean; break; - } } /* TODO: update so files in /sys are readonly case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: { -- 1.6.3.3

2 2

[libvirt] newer gnulib: requires several header-include fixes
by Jim Meyering 15 Jan '10

15 Jan '10

A week or two ago, upstream gnulib was fixed to be more namespace friendly in how it creates replacement headers. For some of its replacements (e.g., <stdio.h>, used via gnulib/lib/stdio.h), it would unnecessarily include another header, e.g., <stdlib.h>. That would make it so that an application using gnulib's <stdio.h> could think it's fine *not* to include stdlib.h, even though it uses a function like exit whose declaration usually requires an explicit inclusion of <stdlib.h>. [the example above is made up -- in reality it was more subtle] Well, now, those excess inclusions have been removed, and when I upgraded libvirt to use the latest gnulib, I saw many compilation failures due to missing #include directives. This series fixes the problems, then adds a change-set to update to the latest gnulib. Here are the one-line summaries: util.c: include required header, no longer masked by gnulib cpu_x86_data.h: include required header vbox: include required headers esx_vi_types.c: include required headers storage_backend.h: include required headers build: update gnulib submodule to latest >From ed2e5140a5a5529ca19e730d061f6d5b3872bb7f Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 10:31:23 +0100 Subject: [PATCH 1/6] util.c: include required header, no longer masked by gnulib Until recently, some gnulib-generated replacement headers included *other* headers that were not strictly necessary, thus masking the need in this file for an explicit <stdlib.h>. * src/util/util.c: Include <stdlib.h> for declarations of e.g., strtol, random_r, getenv, etc. --- src/util/util.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 45ca657..67fae00 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1,7 +1,7 @@ /* * utils.c: common, generic utility functions * - * Copyright (C) 2006, 2007, 2008, 2009 Red Hat, Inc. + * Copyright (C) 2006-2010 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * Copyright (C) 2006, 2007 Binary Karma * Copyright (C) 2006 Shuveb Hussain @@ -28,6 +28,7 @@ #include <stdio.h> #include <stdarg.h> +#include <stdlib.h> #include <unistd.h> #include <fcntl.h> #include <errno.h> -- 1.6.6.556.gd6679 >From c920cd6ae55e4b89aa32c7303ed206a83071f5c0 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 10:33:32 +0100 Subject: [PATCH 2/6] cpu_x86_data.h: include required header * src/cpu/cpu_x86_data.h: Include <stdint.h>. --- src/cpu/cpu_x86_data.h | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/cpu/cpu_x86_data.h b/src/cpu/cpu_x86_data.h index 8b09d23..25ee2a5 100644 --- a/src/cpu/cpu_x86_data.h +++ b/src/cpu/cpu_x86_data.h @@ -1,7 +1,7 @@ /* * cpu_x86_data.h: x86 specific CPU data * - * Copyright (C) 2009 Red Hat, Inc. + * Copyright (C) 2009-2010 Red Hat, Inc. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -24,6 +24,8 @@ #ifndef __VIR_CPU_X86_DATA_H__ #define __VIR_CPU_X86_DATA_H__ +#include <stdint.h> + struct cpuX86cpuid { uint32_t function; uint32_t eax; -- 1.6.6.556.gd6679 >From 5efa5755bd38f0e7fb0f802c21dbd798e49ba5a3 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 10:35:41 +0100 Subject: [PATCH 3/6] vbox: include required headers * src/vbox/vbox_driver.c: Include <stdint.h> <unistd.h> <sys/types.h>. --- src/vbox/vbox_driver.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/vbox/vbox_driver.c b/src/vbox/vbox_driver.c index ad5f239..ef3eb4b 100644 --- a/src/vbox/vbox_driver.c +++ b/src/vbox/vbox_driver.c @@ -28,6 +28,10 @@ #include <config.h> +#include <stdint.h> +#include <unistd.h> +#include <sys/types.h> + #include "internal.h" #include "datatypes.h" -- 1.6.6.556.gd6679 >From b860fa5ed20cb54c56f50e25b40a9864b9ff4b60 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 10:37:03 +0100 Subject: [PATCH 4/6] esx_vi_types.c: include required headers * src/esx/esx_vi_types.c: Include <stdint.h>. --- src/esx/esx_vi_types.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_vi_types.c b/src/esx/esx_vi_types.c index 8c5b17b..c042e89 100644 --- a/src/esx/esx_vi_types.c +++ b/src/esx/esx_vi_types.c @@ -22,6 +22,7 @@ #include <config.h> +#include <stdint.h> #include <libxml/parser.h> #include <libxml/xpathInternals.h> -- 1.6.6.556.gd6679 >From b57e46d562501d449f5e56bdf780496899494bf4 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 10:38:36 +0100 Subject: [PATCH 5/6] storage_backend.h: include required headers * src/storage/storage_backend.h: Include <stdint.h>. --- src/storage/storage_backend.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend.h b/src/storage/storage_backend.h index 88c6161..1c38eeb 100644 --- a/src/storage/storage_backend.h +++ b/src/storage/storage_backend.h @@ -1,7 +1,7 @@ /* * storage_backend.h: internal storage driver backend contract * - * Copyright (C) 2007-2008 Red Hat, Inc. + * Copyright (C) 2007-2010 Red Hat, Inc. * Copyright (C) 2007-2008 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -24,6 +24,7 @@ #ifndef __VIR_STORAGE_BACKEND_H__ #define __VIR_STORAGE_BACKEND_H__ +#include <stdint.h> #include "internal.h" #include "storage_conf.h" -- 1.6.6.556.gd6679 >From e2617c6132f1da930f3c52926e71ec79a80dde1f Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 10:23:22 +0100 Subject: [PATCH 6/6] build: update gnulib submodule to latest --- .gnulib | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.gnulib b/.gnulib index 3fd9a2d..4c52807 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 3fd9a2df88c558b27be3a585ca2978dbf9b5da53 +Subproject commit 4c52807f41f238cf0e352317b2dc54f9ba0f0c4f -- 1.6.6.556.gd6679

2 1

[libvirt] [PATCH] xen: do not report a write-to-Xen-daemon failure as a read failure
by Jim Meyering 15 Jan '10

15 Jan '10

FYI, pushed as obvious... >From 02765872876ba8a820a5047f664da8a7b870b7b9 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Fri, 15 Jan 2010 10:22:08 +0100 Subject: [PATCH] xen: do not report a write-to-Xen-daemon failure as a read failure * src/xen/xend_internal.c (wr_sync): Correct the diagnostic. --- src/xen/xend_internal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index d9bfa15..9c5127f 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -196,11 +196,11 @@ wr_sync(virConnectPtr xend, int fd, void *buffer, size_t size, int do_read) if (do_read) virXendError(xend, VIR_ERR_INTERNAL_ERROR, "%s", _("failed to read from Xen Daemon")); else virXendError(xend, VIR_ERR_INTERNAL_ERROR, - "%s", _("failed to read from Xen Daemon")); + "%s", _("failed to write to Xen Daemon")); return (-1); } offset += len; -- 1.6.6.556.gd6679

2 1

[libvirt] ANNOUNCE: A new mailing list for users / admins / app developers
by Daniel P. Berrange 14 Jan '10

14 Jan '10

Hi Folks, We have now created the new mailing list libvirt-users(a)redhat.com If you are primarily an end user / admin / application developer of libvirt then this new list will offer a better signal-2-noise ratio for your questions & discussions relating to libvirt. ie you won't get patchbombed every day :-) The form to subscribe to the new list is here: http://www.redhat.com/mailman/listinfo/libvirt-users libvirt development discussions & patch submission should continue to take place on this list. I would encourage any developers who like helping out users to also join the new mailing list so we have knowledgable people to answer questions that arise there.... Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

1 0

[libvirt] [PATCH v2] Implement path lookup for USB by vendor:product
by Cole Robinson 14 Jan '10

14 Jan '10

Based off how QEMU does it, look through /sys/bus/usb/devices/* for matching vendor:product info, and if found, use info from the surrounding files to build the device's /dev/bus/usb path. This fixes USB device assignment by vendor:product when running qemu as non-root (well, it should, but for some reason I couldn't reproduce the failure people are seeing in [1], but it appears to work properly) [1] https://bugzilla.redhat.com/show_bug.cgi?id=542450 v2: Drop 'bus.addr only' checks in security drivers Use various util helpers Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- po/POTFILES.in | 1 + src/qemu/qemu_driver.c | 9 +-- src/security/security_selinux.c | 25 ++++----- src/security/virt-aa-helper.c | 32 +++++------ src/util/hostusb.c | 110 +++++++++++++++++++++++++++++++++++++- src/util/hostusb.h | 4 +- 6 files changed, 141 insertions(+), 40 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index c9c78b6..3b82a74 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -55,6 +55,7 @@ src/uml/uml_conf.c src/uml/uml_driver.c src/util/bridge.c src/util/conf.c +src/util/hostusb.c src/util/json.c src/util/logging.c src/util/pci.c diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index deb8adc..f03ce91 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2105,14 +2105,11 @@ static int qemuDomainSetHostdevUSBOwnership(virConnectPtr conn, struct qemuFileOwner owner = { uid, gid }; int ret = -1; - /* XXX what todo for USB devs assigned based on product/vendor ? Doom :-( */ - if (!def->source.subsys.u.usb.bus || - !def->source.subsys.u.usb.device) - return 0; - usbDevice *dev = usbGetDevice(conn, def->source.subsys.u.usb.bus, - def->source.subsys.u.usb.device); + def->source.subsys.u.usb.device, + def->source.subsys.u.usb.vendor, + def->source.subsys.u.usb.product); if (!dev) goto cleanup; diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 000bc8a..cb585ed 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -481,20 +481,17 @@ SELinuxSetSecurityHostdevLabel(virConnectPtr conn, switch (dev->source.subsys.type) { case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: { - if (dev->source.subsys.u.usb.bus && dev->source.subsys.u.usb.device) { - usbDevice *usb = usbGetDevice(conn, - dev->source.subsys.u.usb.bus, - dev->source.subsys.u.usb.device); + usbDevice *usb = usbGetDevice(conn, + dev->source.subsys.u.usb.bus, + dev->source.subsys.u.usb.device, + dev->source.subsys.u.usb.vendor, + dev->source.subsys.u.usb.product); - if (!usb) - goto done; + if (!usb) + goto done; - ret = usbDeviceFileIterate(conn, usb, SELinuxSetSecurityUSBLabel, vm); - usbFreeDevice(conn, usb); - } else { - /* XXX deal with product/vendor better */ - ret = 0; - } + ret = usbDeviceFileIterate(conn, usb, SELinuxSetSecurityUSBLabel, vm); + usbFreeDevice(conn, usb); break; } @@ -556,7 +553,9 @@ SELinuxRestoreSecurityHostdevLabel(virConnectPtr conn, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: { usbDevice *usb = usbGetDevice(conn, dev->source.subsys.u.usb.bus, - dev->source.subsys.u.usb.device); + dev->source.subsys.u.usb.device, + dev->source.subsys.u.usb.vendor, + dev->source.subsys.u.usb.product); if (!usb) goto done; diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 35b29ad..3c8b49a 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -836,24 +836,22 @@ get_files(vahControl * ctl) virDomainHostdevDefPtr dev = ctl->def->hostdevs[i]; switch (dev->source.subsys.type) { case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: { - if (dev->source.subsys.u.usb.bus && - dev->source.subsys.u.usb.device) { - usbDevice *usb = usbGetDevice(NULL, - dev->source.subsys.u.usb.bus, - dev->source.subsys.u.usb.device); - if (usb == NULL) - continue; - rc = usbDeviceFileIterate(NULL, usb, - file_iterate_cb, &buf); - usbFreeDevice(NULL, usb); - if (rc != 0) - goto clean; - else { - /* TODO: deal with product/vendor better */ - rc = 0; - } - } + usbDevice *usb = usbGetDevice(NULL, + dev->source.subsys.u.usb.bus, + dev->source.subsys.u.usb.device, + dev->source.subsys.u.usb.vendor, + dev->source.subsys.u.usb.product); + + if (usb == NULL) + continue; + + rc = usbDeviceFileIterate(NULL, usb, + file_iterate_cb, &buf); + usbFreeDevice(NULL, usb); + if (rc != 0) + goto clean; break; + } } /* TODO: update so files in /sys are readonly case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI: { diff --git a/src/util/hostusb.c b/src/util/hostusb.c index 07e10b1..8fbb486 100644 --- a/src/util/hostusb.c +++ b/src/util/hostusb.c @@ -37,9 +37,10 @@ #include "util.h" #include "virterror_internal.h" +#define USB_SYSFS "/sys/bus/usb" #define USB_DEVFS "/dev/bus/usb/" -#define USB_ID_LEN 10 /* "XXXX XXXX" */ -#define USB_ADDR_LEN 8 /* "XXX:XXX" */ +#define USB_ID_LEN 10 /* "1234 5678" */ +#define USB_ADDR_LEN 8 /* "123:456" */ struct _usbDevice { unsigned bus; @@ -57,11 +58,108 @@ struct _usbDevice { virReportErrorHelper(conn, VIR_FROM_NONE, code, __FILE__, \ __FUNCTION__, __LINE__, fmt) +static int usbSysReadFile(virConnectPtr conn, + const char *f_name, const char *d_name, + int base, unsigned *value) +{ + int ret = -1, tmp; + char *buf = NULL; + char *filename = NULL; + char *ignore = NULL; + + tmp = virAsprintf(&filename, USB_SYSFS "/devices/%s/%s", d_name, f_name); + if (tmp < 0) { + virReportOOMError(conn); + goto error; + } + + if (virFileReadAll(filename, 1024, &buf) < 0) + goto error; + + if (virStrToLong_ui(buf, &ignore, base, value) < 0) { + usbReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Could not parse usb file %s"), filename); + goto error; + } + + ret = 0; +error: + VIR_FREE(filename); + VIR_FREE(buf); + return ret; +} + +static int usbFindBusByVendor(virConnectPtr conn, + unsigned vendor, unsigned product, + unsigned *bus, unsigned *devno) +{ + DIR *dir = NULL; + int ret = -1, found = 0; + char *ignore = NULL; + struct dirent *de; + + dir = opendir(USB_SYSFS "/devices"); + if (!dir) { + virReportSystemError(conn, errno, + _("Could not open directory %s"), + USB_SYSFS "/devices"); + goto error; + } + + while ((de = readdir(dir))) { + unsigned found_prod, found_vend; + if (de->d_name[0] == '.' || strchr(de->d_name, ':')) + continue; + + if (usbSysReadFile(conn, "idVendor", de->d_name, + 16, &found_vend) < 0) + goto error; + if (usbSysReadFile(conn, "idProduct", de->d_name, + 16, &found_prod) < 0) + goto error; + + if (found_prod == product && found_vend == vendor) { + /* Lookup bus.addr info */ + char *tmpstr = de->d_name; + unsigned found_bus, found_addr; + + if (STREQ(de->d_name, "usb")) + tmpstr += 3; + + if (virStrToLong_ui(tmpstr, &ignore, 10, &found_bus) < 0) { + usbReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Failed to parse dir name '%s'"), + de->d_name); + goto error; + } + + if (usbSysReadFile(conn, "devnum", de->d_name, + 10, &found_addr) < 0) + goto error; + + *bus = found_bus; + *devno = found_addr; + found = 1; + break; + } + } + + if (!found) + usbReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Did not find USB device %x:%x"), vendor, product); + else + ret = 0; + +error: + return ret; +} usbDevice * usbGetDevice(virConnectPtr conn, unsigned bus, - unsigned devno) + unsigned devno, + unsigned vendor, + unsigned product) { usbDevice *dev; @@ -70,6 +168,12 @@ usbGetDevice(virConnectPtr conn, return NULL; } + if (vendor) { + /* Look up bus.dev by vendor:product */ + if (usbFindBusByVendor(conn, vendor, product, &bus, &devno) < 0) + return NULL; + } + dev->bus = bus; dev->dev = devno; diff --git a/src/util/hostusb.h b/src/util/hostusb.h index 7f75c8b..739a4aa 100644 --- a/src/util/hostusb.h +++ b/src/util/hostusb.h @@ -28,7 +28,9 @@ typedef struct _usbDevice usbDevice; usbDevice *usbGetDevice (virConnectPtr conn, unsigned bus, - unsigned devno); + unsigned devno, + unsigned vendor, + unsigned product); void usbFreeDevice (virConnectPtr conn, usbDevice *dev); -- 1.6.5.2

2 2

[libvirt] attach_device incompatibility between libvirt and qemu 0.12
by Gerhard Stenzel 14 Jan '10

14 Jan '10

Hi, I have a small libvirt-tck test script, in which I create a domain without a NIC, then use attach_device to add a NIC. And then I do a ping test to the domain. This stopped working after updating to latest fedora and libvirt levels. After some hours, I now discovered that downgrading to qemu 0.11 fixes it. So there seems to be some incompatibility with qemu 0.12 and latest libvirt. The expected output with qemu-system-x86-0.11.0-12.fc12.x86_64: /usr/share/libvirt-tck/tests/scripts/network/100-ping-still-working.t .. 1..5 # Trying domain lookup by name ok 1 - the running domain object # Attaching the new interface d0:f:d0:f:2:1 ok 2 - interface has been attached # xml contains mac address element (should be 1) # 1 ok 3 - running domain has an ID > 0 # waiting for guests to boot # PING 192.168.1.101 (192.168.1.101) 56(84) bytes of data. # 64 bytes from 192.168.1.101: icmp_seq=1 ttl=64 time=2.17 ms # 64 bytes from 192.168.1.101: icmp_seq=2 ttl=64 time=0.554 ms # 64 bytes from 192.168.1.101: icmp_seq=3 ttl=64 time=0.510 ms # 64 bytes from 192.168.1.101: icmp_seq=4 ttl=64 time=0.508 ms # 64 bytes from 192.168.1.101: icmp_seq=5 ttl=64 time=0.505 ms # 64 bytes from 192.168.1.101: icmp_seq=6 ttl=64 time=0.673 ms # 64 bytes from 192.168.1.101: icmp_seq=7 ttl=64 time=0.528 ms # 64 bytes from 192.168.1.101: icmp_seq=8 ttl=64 time=0.522 ms # 64 bytes from 192.168.1.101: icmp_seq=9 ttl=64 time=0.506 ms # 64 bytes from 192.168.1.101: icmp_seq=10 ttl=64 time=0.546 ms # # --- 192.168.1.101 ping statistics --- # 10 packets transmitted, 10 received, 0% pacFor the working I see the following lines in the log: ket loss, time 9002ms # rtt min/avg/max/mdev = 0.505/0.703/2.178/0.493 ms ok 4 - ping 192.168.1.101 test # cleaning up # Detaching the 1st interface d0:f:d0:f:2:1 ok 5 - interface has been detached ok All tests successful. Files=1, Tests=5, 20 wallclock secs ( 0.02 usr 0.01 sys + 0.22 cusr 0.15 csys = 0.40 CPU) Result: PASS The failing output with qemu-system-x86-0.11.0-12.fc12.x86_64: /usr/share/libvirt-tck/tests/scripts/network/100-ping-still-working.t .. 1..5 # Trying domain lookup by name ok 1 - the running domain object # Attaching the new interface d0:f:d0:f:2:1 ok 2 - interface has been attached # xml contains mac address element (should be 1) # 1 ok 3 - running domain has an ID > 0 # waiting for guests to boot # PING 192.168.1.101 (192.168.1.101) 56(84) bytes of data. # From 192.168.1.1 icmp_seq=2 Destination Host Unreachable # From 192.168.1.1 icmp_seq=3 Destination Host Unreachable # From 192.168.1.1 icmp_seq=4 Destination Host Unreachable # From 192.168.1.1 icmp_seq=6 Destination Host Unreachable # From 192.168.1.1 icmp_seq=7 Destination Host Unreachable # From 192.168.1.1 icmp_seq=8 Destination Host Unreachable # From 192.168.1.1 icmp_seq=9 Destination Host Unreachable # From 192.168.1.1 icmp_seq=10 Destination Host Unreachable # # --- 192.168.1.101 ping statistics --- # 10 packets transmitted, 0 received, +8 errors, 100% packet loss, time 19000ms # pipe 3 not ok 4 - ping 192.168.1.101 test # Failed test 'ping 192.168.1.101 test' # at /usr/share/libvirt-tck/tests/scripts/network/100-ping-still-working.t line 82. # cleaning up # Detaching the 1st interface d0:f:d0:f:2:1 ok 5 - interface has been detached # Looks like you failed 1 test of 5. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests Test Summary Report ------------------- /usr/share/libvirt-tck/tests/scripts/network/100-ping-still-working.t (Wstat: 256 Tests: 5 Failed: 1) Failed test: 4 Non-zero exit status: 1 Files=1, Tests=5, 30 wallclock secs ( 0.02 usr 0.02 sys + 0.24 cusr 0.13 csys = 0.41 CPU) Result: FAIL I see the following in the debug log: ... qemuMonitorCommandWithHandler:216 : Send command 'getfd fd-tap.0' for write with FD 18 ... For the working qemu: qemuMonitorCommandWithHandler:221 : Receive command reply ret=0 errno=0 0 bytes '(null)' For the failing qemu: qemuMonitorCommandWithHandler:221 : Receive command reply ret=0 errno=0 44 bytes 'No file descriptor supplied via SCM_RIGHTS^M ' Any ideas? -- Best regards, Gerhard Stenzel, ----------------------------------------------------------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

1 0

[libvirt] [PATCH] events: Report errors on failure
by Cole Robinson 14 Jan '10

14 Jan '10

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- po/POTFILES.in | 1 + src/conf/domain_event.c | 36 +++++++++++++++++++++++++++++------- 2 files changed, 30 insertions(+), 7 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index 1ab0859..c9c78b6 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -4,6 +4,7 @@ daemon/remote.c daemon/stream.c src/conf/cpu_conf.c src/conf/domain_conf.c +src/conf/domain_event.c src/conf/interface_conf.c src/conf/network_conf.c src/conf/node_device_conf.c diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 0fa2822..72f499c 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -26,6 +26,13 @@ #include "logging.h" #include "datatypes.h" #include "memory.h" +#include "virterror_internal.h" + +#define VIR_FROM_THIS VIR_FROM_NONE + +#define eventReportError(conn, code, fmt...) \ + virReportErrorHelper(conn, VIR_FROM_THIS, code, __FILE__, \ + __FUNCTION__, __LINE__, fmt) /** @@ -87,6 +94,9 @@ virDomainEventCallbackListRemove(virConnectPtr conn, return 0; } } + + eventReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("could not find event callback for removal")); return -1; } @@ -140,6 +150,9 @@ int virDomainEventCallbackListMarkDelete(virConnectPtr conn, return 0; } } + + eventReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("could not find event callback for deletion")); return -1; } @@ -199,13 +212,14 @@ virDomainEventCallbackListAdd(virConnectPtr conn, for (n=0; n < cbList->count; n++) { if(cbList->callbacks[n]->cb == callback && conn == cbList->callbacks[n]->conn) { - DEBUG0("WARNING: Callback already tracked"); + eventReportError(conn, VIR_ERR_INTERNAL_ERROR, "%s", + _("event callback already tracked")); return -1; } } /* Allocate new event */ if (VIR_ALLOC(event) < 0) { - DEBUG0("Error allocating event"); + virReportOOMError(conn); return -1; } event->conn = conn; @@ -216,7 +230,7 @@ virDomainEventCallbackListAdd(virConnectPtr conn, /* Make space on list */ n = cbList->count; if (VIR_REALLOC_N(cbList->callbacks, n + 1) < 0) { - DEBUG0("Error reallocating list"); + virReportOOMError(conn); VIR_FREE(event); return -1; } @@ -242,8 +256,10 @@ virDomainEventQueuePtr virDomainEventQueueNew(void) { virDomainEventQueuePtr ret; - if (VIR_ALLOC(ret) < 0) + if (VIR_ALLOC(ret) < 0) { + virReportOOMError(NULL); return NULL; + } return ret; } @@ -254,12 +270,15 @@ virDomainEventPtr virDomainEventNew(int id, const char *name, { virDomainEventPtr event; - if (VIR_ALLOC(event) < 0) + if (VIR_ALLOC(event) < 0) { + virReportOOMError(NULL); return NULL; + } event->type = type; event->detail = detail; if (!(event->name = strdup(name))) { + virReportOOMError(NULL); VIR_FREE(event); return NULL; } @@ -318,8 +337,11 @@ virDomainEventQueuePop(virDomainEventQueuePtr evtQueue) { virDomainEventPtr ret; - if(!evtQueue || evtQueue->count == 0 ) + if (!evtQueue || evtQueue->count == 0 ) { + eventReportError(NULL, VIR_ERR_INTERNAL_ERROR, "%s", + _("event queue is empty, nothing to pop")); return NULL; + } ret = evtQueue->events[0]; @@ -357,7 +379,7 @@ virDomainEventQueuePush(virDomainEventQueuePtr evtQueue, /* Make space on queue */ if (VIR_REALLOC_N(evtQueue->events, evtQueue->count + 1) < 0) { - DEBUG0("Error reallocating queue"); + virReportOOMError(NULL); return -1; } -- 1.6.5.2

2 1

[libvirt] [PATCH] daemon: Fix various error reporting issues
by Cole Robinson 14 Jan '10

14 Jan '10

Many node device calls weren't properly relaying error messages, and domain event registeration was not checking for error. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- daemon/remote.c | 38 +++++++++++++++++++++----------------- 1 files changed, 21 insertions(+), 17 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 0b30131..41b9974 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -231,7 +231,7 @@ remoteDispatchGetType (struct qemud_server *server ATTRIBUTE_UNUSED, */ ret->type = strdup (type); if (!ret->type) { - remoteDispatchFormatError (rerr, "%s", _("out of memory in strdup")); + remoteDispatchOOMError(rerr); return -1; } @@ -4489,7 +4489,7 @@ remoteDispatchNodeDeviceDumpXml (struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4520,7 +4520,7 @@ remoteDispatchNodeDeviceGetParent (struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4562,7 +4562,7 @@ remoteDispatchNodeDeviceNumOfCaps (struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4591,7 +4591,7 @@ remoteDispatchNodeDeviceListCaps (struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4634,7 +4634,7 @@ remoteDispatchNodeDeviceDettach (struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4661,7 +4661,7 @@ remoteDispatchNodeDeviceReAttach (struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4688,7 +4688,7 @@ remoteDispatchNodeDeviceReset (struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4738,7 +4738,7 @@ remoteDispatchNodeDeviceDestroy(struct qemud_server *server ATTRIBUTE_UNUSED, dev = virNodeDeviceLookupByName(conn, args->name); if (dev == NULL) { - remoteDispatchFormatError(rerr, "%s", _("node_device not found")); + remoteDispatchConnError(rerr, conn); return -1; } @@ -4766,11 +4766,14 @@ remoteDispatchDomainEventsRegister (struct qemud_server *server ATTRIBUTE_UNUSED { CHECK_CONN(client); - /* Register event delivery callback */ - REMOTE_DEBUG("%s","Registering to relay remote events"); - virConnectDomainEventRegister(conn, remoteRelayDomainEvent, client, NULL); + if (virConnectDomainEventRegister(conn, + remoteRelayDomainEvent, + client, NULL) < 0) { + remoteDispatchConnError(rerr, conn); + return -1; + } - if(ret) + if (ret) ret->cb_registered = 1; return 0; } @@ -4786,11 +4789,12 @@ remoteDispatchDomainEventsDeregister (struct qemud_server *server ATTRIBUTE_UNUS { CHECK_CONN(client); - /* Deregister event delivery callback */ - REMOTE_DEBUG("%s","Deregistering to relay remote events"); - virConnectDomainEventDeregister(conn, remoteRelayDomainEvent); + if (virConnectDomainEventDeregister(conn, remoteRelayDomainEvent) < 0) { + remoteDispatchConnError(rerr, conn); + return -1; + } - if(ret) + if (ret) ret->cb_registered = 0; return 0; } -- 1.6.5.2

2 1

[libvirt] [PATCH] daemon: Don't blindly unregister domain events
by Cole Robinson 14 Jan '10

14 Jan '10

The daemon will attempt to unregister domain events on client disconnect, even if no events were ever registered. This raises an unneeded error. Track in the qemu_client structure if events have been registered, and check this when performing cleanup. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- daemon/libvirtd.c | 2 +- daemon/libvirtd.h | 1 + daemon/remote.c | 4 ++++ 3 files changed, 6 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index c53ef0a..61a9728 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1447,7 +1447,7 @@ void qemudDispatchClientFailure(struct qemud_client *client) { } /* Deregister event delivery callback */ - if(client->conn) { + if (client->conn && client->domain_events_registered) { DEBUG0("Deregistering to relay remote events"); virConnectDomainEventDeregister(client->conn, remoteRelayDomainEvent); } diff --git a/daemon/libvirtd.h b/daemon/libvirtd.h index e3624c6..2f647f3 100644 --- a/daemon/libvirtd.h +++ b/daemon/libvirtd.h @@ -177,6 +177,7 @@ struct qemud_client { int watch; int readonly:1; int closing:1; + int domain_events_registered:1; struct sockaddr_storage addr; socklen_t addrlen; diff --git a/daemon/remote.c b/daemon/remote.c index 41b9974..e39d6d1 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -4775,6 +4775,8 @@ remoteDispatchDomainEventsRegister (struct qemud_server *server ATTRIBUTE_UNUSED if (ret) ret->cb_registered = 1; + + client->domain_events_registered = 1; return 0; } @@ -4796,6 +4798,8 @@ remoteDispatchDomainEventsDeregister (struct qemud_server *server ATTRIBUTE_UNUS if (ret) ret->cb_registered = 0; + + client->domain_events_registered = 0; return 0; } -- 1.6.5.2

2 1

[libvirt] [PATCH] qemu: Check for ia64 kvm
by Cole Robinson 14 Jan '10

14 Jan '10

From: Dustin Xiong <x_k_123(a)hotmail.com> Ported to current code. Untested, but builds fine. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/qemu/qemu_conf.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index d3da776..0d970d6 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -373,12 +373,19 @@ static const struct qemu_feature_flags const arch_info_x86_64_flags [] = { { "apic", 1, 0 }, }; +static const struct qemu_feature_flags const arch_info_ia64_flags [] = { + { "acpi", 1, 1 }, + { "apic", 1, 0 }, +}; + /* The archicture tables for supported QEMU archs */ static const struct qemu_arch_info const arch_info_hvm[] = { { "i686", 32, NULL, "/usr/bin/qemu", "/usr/bin/qemu-system-x86_64", arch_info_i686_flags, 4 }, { "x86_64", 64, NULL, "/usr/bin/qemu-system-x86_64", NULL, arch_info_x86_64_flags, 2 }, + { "itanium", 64, NULL, "/usr/bin/qemu-system-ia64", + NULL, arch_info_ia64_flags, 2}, { "arm", 32, NULL, "/usr/bin/qemu-system-arm", NULL, NULL, 0 }, { "mips", 32, NULL, "/usr/bin/qemu-system-mips", NULL, NULL, 0 }, { "mipsel", 32, NULL, "/usr/bin/qemu-system-mipsel", NULL, NULL, 0 }, -- 1.6.5.2

3 3

[libvirt] [PATCH] util: Make sure virExec hook failures are raised
by Cole Robinson 14 Jan '10

14 Jan '10

With the introduction virDispatchError, hook function errors are never sent through the error callback, so users will never see these messages. Fix this by calling virDispatchError after hook failure. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/util/util.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index ba6b0db..45ca657 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -557,8 +557,11 @@ __virExec(virConnectPtr conn, } if (hook) - if ((hook)(data) != 0) + if ((hook)(data) != 0) { + VIR_DEBUG0("Hook function failed."); + virDispatchError(NULL); _exit(1); + } /* The steps above may need todo something privileged, so * we delay clearing capabilities until the last minute */ -- 1.6.5.2

3 3

[libvirt] [PATCH] Fix linkage of virt-aa-helper to libgnu.a
by Matthias Bolte 14 Jan '10

14 Jan '10

--- src/Makefile.am | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index dbf708b..324030b 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -876,9 +876,9 @@ virt_aa_helper_LDFLAGS = $(WARN_CFLAGS) virt_aa_helper_LDADD = \ $(WARN_CFLAGS) \ $(LIBXML_LIBS) \ - @top_srcdir@/gnulib/lib/libgnu.la \ @top_srcdir@/src/libvirt_conf.la \ - @top_srcdir@/src/libvirt_util.la + @top_srcdir@/src/libvirt_util.la \ + @top_srcdir@/gnulib/lib/libgnu.la virt_aa_helper_CFLAGS = \ -I@top_srcdir@/src/conf \ -I@top_srcdir@/src/security -- 1.6.3.3

2 1

[libvirt] [PATCH] Fix event-test segfault for mixed remote/local driver usage
by Matthias Bolte 14 Jan '10

14 Jan '10

If examples/domain-events/events-c/event-test.c uses a local driver for the hyperviror and a remote driver for storage then the segfault occurs in remoteDomainEventDispatchFunc because conn->privateData is used. The problem is as follows. The doRemoteOpen function registers remoteDomainEventFired as event handle and remoteDomainEventQueueFlush as event timeout. The doRemoteOpen function is used in remoteOpen and remoteOpenSecondaryDriver. So both handlers are registered for all types of remote drivers, but remoteDomainEventQueueFlush always uses conn->privateData. That's wrong when remoteDomainEventQueueFlush is called for any other driver than the hypervisor driver, it should use conn->storagePrivateData for the storage driver for example. In the common case this doesn't result in a segfault because in the common case all drivers for a connection are either all remote or all local and conn->privateData and conn->storagePrivateData are the same. But in the local Xen case ('event-test xen:///' executed in Domain-0, with a libvirtd running in Domain-0) the hypervisor driver is local and the storage driver is remote. This results in a mismatch between conn->privateData and conn->storagePrivateData. Now the call to remoteDomainEventQueueFlush in the context of the storage driver results in a segfault, because it assumes that conn->privateData points to remote driver private data, but it points to Xen driver private data. To fix this, the pointer to the private driver data gets passed as opaque parameter instead of the connection pointer. Because some functions called by the event handler functions need the connection pointer for other purposes than error reporting the connection pointer is passed as member of the private remote driver data struct. Now remoteDomainEventFired and remoteDomainEventQueueFlush have the correct private data pointer for the respective calling context. --- src/remote/remote_driver.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index d6f5fce..582b85c 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -152,6 +152,7 @@ struct private_stream_data { struct private_data { virMutex lock; + virConnectPtr conn; int sock; /* Socket. */ int watch; /* File handle watch */ @@ -893,7 +894,7 @@ doRemoteOpen (virConnectPtr conn, if ((priv->watch = virEventAddHandle(priv->sock, VIR_EVENT_HANDLE_READABLE, remoteDomainEventFired, - conn, NULL)) < 0) { + priv, NULL)) < 0) { DEBUG0("virEventAddHandle failed: No addHandleImpl defined." " continuing without events."); } else { @@ -901,7 +902,7 @@ doRemoteOpen (virConnectPtr conn, DEBUG0("Adding Timeout for remote event queue flushing"); if ( (priv->eventFlushTimer = virEventAddTimeout(-1, remoteDomainEventQueueFlush, - conn, NULL)) < 0) { + priv, NULL)) < 0) { DEBUG0("virEventAddTimeout failed: No addTimeoutImpl defined. " "continuing without events."); virEventRemoveHandle(priv->watch); @@ -980,6 +981,7 @@ remoteAllocPrivateData(virConnectPtr conn) return NULL; } remoteDriverLock(priv); + priv->conn = conn; priv->localUses = 1; priv->watch = -1; priv->sock = -1; @@ -8659,8 +8661,7 @@ remoteDomainEventFired(int watch, int event, void *opaque) { - virConnectPtr conn = opaque; - struct private_data *priv = conn->privateData; + struct private_data *priv = opaque; remoteDriverLock(priv); @@ -8684,7 +8685,7 @@ remoteDomainEventFired(int watch, goto done; } - if (remoteIOHandleInput(conn, priv, 0) < 0) + if (remoteIOHandleInput(priv->conn, priv, 0) < 0) DEBUG0("Something went wrong during async message processing"); done: @@ -8708,8 +8709,7 @@ static void remoteDomainEventDispatchFunc(virConnectPtr conn, void remoteDomainEventQueueFlush(int timer ATTRIBUTE_UNUSED, void *opaque) { - virConnectPtr conn = opaque; - struct private_data *priv = conn->privateData; + struct private_data *priv = opaque; virDomainEventQueue tempQueue; remoteDriverLock(priv); @@ -8731,7 +8731,7 @@ remoteDomainEventQueueFlush(int timer ATTRIBUTE_UNUSED, void *opaque) if ( priv->callbackList->count == 0 ) { /* Tell the server when we are the last callback deregistering */ - if (call (conn, priv, 0, REMOTE_PROC_DOMAIN_EVENTS_DEREGISTER, + if (call (priv->conn, priv, 0, REMOTE_PROC_DOMAIN_EVENTS_DEREGISTER, (xdrproc_t) xdr_void, (char *) NULL, (xdrproc_t) xdr_void, (char *) NULL) == -1) VIR_WARN0("Failed to de-register events"); -- 1.6.3.3

2 1

[libvirt] Set MAC address for host virtual interface?
by Neil Aggarwal 14 Jan '10

14 Jan '10

Hello: Is there a way to set the MAC address for the virtual interface on the host? I have this in my guests's XML file: <interface type='bridge'> <mac address='54:52:00:7d:f8:fc'/> <source bridge='br0'/> <target dev='tkl-joomla'/> </interface> the mac address line controls the guest interface but the host interface seems to get a random MAC address. This is causing a problem for me since I use Cacti to monitor the bandwidth usage of the guest machines. Every time I stop and start a guest, Cacti creates a new interface and I have to reset the graphs to use the new interfaces. Thanks, Neil -- Neil Aggarwal, (281)846-8957, http://UnmeteredVPS.net Host Joomla!, Wordpress, phpBB, or vBulletin for $25/mo Unmetered bandwidth = no overage charges, 7 day free trial

2 1

[libvirt] Man page patch for BZ 548485
by David Jorm 14 Jan '10

14 Jan '10

See https://bugzilla.redhat.com/show_bug.cgi?id=548485 git diff for the patch: ---SNIP--- --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -342,7 +342,9 @@ severed upon restore, as TCP timeouts may have expired. =item B<schedinfo> optional I<--weight> B<number> optional I<--cap> B<number> I<domain-id> -Allows to show (and set) the domain scheduler parameters. +Allows you to show (and set) the domain scheduler parameters. + +B<Note>: The only parameter currently available for all schedulers is cpu_shares. It has a valid value range of 0-262144. B<Note>: The weight and cap parameters are defined only for the XEN_CREDIT scheduler and are now I<DEPRECATED>. ---SNIP--- I hope that's right, I found that BZ a bit confusing to comprehend. Learning curve. David

2 2

[libvirt] [BUG?] "no domain with matching uuid" error, when vm restarts
by su disheng 14 Jan '10

14 Jan '10

Hi, In the following libvirt API calling sequence, I always get an error "no domain with matching uuid" Connect _conn = new Connect("qemu:///system", false); _conn.domainDefineXML(kvm_guest_xml); Domain dm = _conn.domainLookupByName(kvm_guest_name); dm.create(); /* stop, undefine, and re-start the vm*/ dm.shutdown(); dm.undefine(); dm.domainDefineXML(kvm_guest_xml); /****A****/ Domain dm = _conn.domainLookupByName(kvm_guest_name); dm.create() /********Error!!!!**/ if I close the connection, and re-connect qemu at the end of /****A****/, then everything is OK. From the log, seems that uuid is not updated immediately, for this connection, the uuid is in the stale state? I am using libvirt 0.6.3, if it's a bug, does it fixed in the latest code? or Have I need to close the connection for each vm shutdown/re-define? I am a newbie in this API, any help are appreciated.

2 2

[libvirt] [PATCH] virterror: Don't invoke error callback for ERR_OK
by Cole Robinson 13 Jan '10

13 Jan '10

Since virDispatchError is now responsible for invoking the error callback, give it the same semantics as ReportError, which will skip VIR_ERR_OK (which is encountered when no error was raised). This fixes invoking the error callback after every non-erroring API call. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/util/virterror.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/util/virterror.c b/src/util/virterror.c index e2128b9..78974ee 100644 --- a/src/util/virterror.c +++ b/src/util/virterror.c @@ -603,8 +603,12 @@ virDispatchError(virConnectPtr conn) if (!err) return; - /* Set a generic error message if none is already set */ + /* We never used to raise ERR_OK, so maintain existing behavior */ if (err->code == VIR_ERR_OK) + return; + + /* Set a generic error message if none is already set */ + if (!err->message) virErrorGenericFailure(err); /* Copy the global error to per-connection error if needed */ -- 1.6.5.2

2 5

[libvirt] [PATCH 0/2] Some new utility functions
by Laine Stump 13 Jan '10

13 Jan '10

I'm planning to use these to fix the problems with creating storage volumes on root-squashing NFS servers, but since they may be of general utility I thought I'd throw them out for comments beforehand - it something different would make them more generally useful, better to change it now than after I've already finished code to use them. My plan is to use virRunWithHook() to call setuid (or possibly some sort of capng calisthenics) prior to execing qemu-img and qcow-create. virFileCreate and virDirCreate will be used when creating raw volumes. I have written test code to verify that virFileCreate works in several different scenarios. Haven't done so with virRun yet, but it's a fairly simple change, just exposing __virExec arguments that were already there. (I'd previously written test code (yes, it worked ;-)) that used a virRun with uid/gid args added on, but have decided against that approach, since this seems more flexible)

4 19

[libvirt] [PATCH] node_device: udev: Fix memory leak
by Cole Robinson 13 Jan '10

13 Jan '10

We are setting the same property two different ways without free'ing in between. Just drop the second assignment. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/node_device/node_device_udev.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index a9e196d..ff6bd46 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -997,11 +997,7 @@ static int udevProcessStorage(struct udev_device *device, goto out; } data->storage.block = strdup(devnode); - if (udevGetStringProperty(device, - "DEVNAME", - &data->storage.block) == PROPERTY_ERROR) { - goto out; - } + if (udevGetStringProperty(device, "ID_BUS", &data->storage.bus) == PROPERTY_ERROR) { -- 1.6.5.2

3 3

[libvirt] [PATCH] node_device: udev: Enumerate floppy devices
by Cole Robinson 13 Jan '10

13 Jan '10

There are quite a few differences between how udev exposes legacy and USB floppy devs, but this patch takes care of both variants. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/node_device/node_device_udev.c | 88 ++++++++++++++++++++++++++++------- 1 files changed, 70 insertions(+), 18 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 55cfee2..a9e196d 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -840,30 +840,19 @@ out: } -static int udevProcessCDROM(struct udev_device *device, - virNodeDeviceDefPtr def) +static int udevProcessRemoveableMedia(struct udev_device *device, + virNodeDeviceDefPtr def, + int has_media) { union _virNodeDevCapData *data = &def->caps->data; int tmp_int = 0, ret = 0; - /* NB: the drive_type string provided by udev is different from - * that provided by HAL; now it's "cd" instead of "cdrom" We - * change it to cdrom to preserve compatibility with earlier - * versions of libvirt. */ - VIR_FREE(def->caps->data.storage.drive_type); - def->caps->data.storage.drive_type = strdup("cdrom"); - if (def->caps->data.storage.drive_type == NULL) { - virReportOOMError(NULL); - goto out; - } - if ((udevGetIntSysfsAttr(device, "removable", &tmp_int, 0) == PROPERTY_FOUND) && (tmp_int == 1)) { def->caps->data.storage.flags |= VIR_NODE_DEV_CAP_STORAGE_REMOVABLE; } - if ((udevGetIntProperty(device, "ID_CDROM_MEDIA", &tmp_int, 0) - == PROPERTY_FOUND) && (tmp_int == 1)) { + if (has_media) { def->caps->data.storage.flags |= VIR_NODE_DEV_CAP_STORAGE_REMOVABLE_MEDIA_AVAILABLE; @@ -898,6 +887,53 @@ out: return ret; } +static int udevProcessCDROM(struct udev_device *device, + virNodeDeviceDefPtr def) +{ + int ret = -1; + int tmp_int = 0; + int has_media = 0; + + /* NB: the drive_type string provided by udev is different from + * that provided by HAL; now it's "cd" instead of "cdrom" We + * change it to cdrom to preserve compatibility with earlier + * versions of libvirt. */ + VIR_FREE(def->caps->data.storage.drive_type); + def->caps->data.storage.drive_type = strdup("cdrom"); + if (def->caps->data.storage.drive_type == NULL) { + virReportOOMError(NULL); + goto out; + } + + if ((udevGetIntProperty(device, "ID_CDROM_MEDIA", + &tmp_int, 0) == PROPERTY_FOUND)) + has_media = tmp_int; + + ret = udevProcessRemoveableMedia(device, def, has_media); +out: + return ret; +} + +static int udevProcessFloppy(struct udev_device *device, + virNodeDeviceDefPtr def) +{ + int tmp_int = 0; + int has_media = 0; + char *tmp_str = NULL; + + if ((udevGetIntProperty(device, "DKD_MEDIA_AVAILABLE", + &tmp_int, 0) == PROPERTY_FOUND)) + /* USB floppy */ + has_media = tmp_int; + else if (udevGetStringProperty(device, "ID_FS_LABEL", + &tmp_str) == PROPERTY_FOUND) { + /* Legacy floppy */ + has_media = 1; + VIR_FREE(tmp_str); + } + + return udevProcessRemoveableMedia(device, def, has_media); +} /* This function exists to deal with the case in which a driver does * not provide a device type in the usual place, but udev told us it's @@ -996,9 +1032,23 @@ static int udevProcessStorage(struct udev_device *device, if (udevGetStringProperty(device, "ID_TYPE", &data->storage.drive_type) != PROPERTY_FOUND) { - /* If udev doesn't have it, perhaps we can guess it. */ - if (udevKludgeStorageType(def) != 0) { - goto out; + int tmp_int = 0; + + /* All floppy drives have the ID_DRIVE_FLOPPY prop. This is + * needed since legacy floppies don't have a drive_type */ + if ((udevGetIntProperty(device, "ID_DRIVE_FLOPPY", + &tmp_int, 0) == PROPERTY_FOUND) && + (tmp_int == 1)) { + + data->storage.drive_type = strdup("floppy"); + if (!data->storage.drive_type) + goto out; + } else { + + /* If udev doesn't have it, perhaps we can guess it. */ + if (udevKludgeStorageType(def) != 0) { + goto out; + } } } @@ -1006,6 +1056,8 @@ static int udevProcessStorage(struct udev_device *device, ret = udevProcessCDROM(device, def); } else if (STREQ(def->caps->data.storage.drive_type, "disk")) { ret = udevProcessDisk(device, def); + } else if (STREQ(def->caps->data.storage.drive_type, "floppy")) { + ret = udevProcessFloppy(device, def); } else { VIR_INFO("Unsupported storage type '%s'\n", def->caps->data.storage.drive_type); -- 1.6.5.2

3 3

[libvirt] [PATCH] node_device: udev: Use base 16 for product/vendor
by Cole Robinson 13 Jan '10

13 Jan '10

udev doesn't prefix USB product/vendor info with '0x', so the strtol conversions were wrong for the product field (vendor already set the correct base). Make the change for PCI product/vendor as well to be safe. This fixes USB device assignment via virt-manager. Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- src/node_device/node_device_udev.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 7a9c1e5..55cfee2 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -457,14 +457,14 @@ static int udevProcessPCI(struct udev_device *device, if (udevGetUintSysfsAttr(device, "vendor", &data->pci_dev.vendor, - 0) == PROPERTY_ERROR) { + 16) == PROPERTY_ERROR) { goto out; } if (udevGetUintSysfsAttr(device, "device", &data->pci_dev.product, - 0) == PROPERTY_ERROR) { + 16) == PROPERTY_ERROR) { goto out; } @@ -522,7 +522,7 @@ static int udevProcessUSBDevice(struct udev_device *device, if (udevGetUintProperty(device, "ID_MODEL_ID", &data->usb_dev.product, - 0) == PROPERTY_ERROR) { + 16) == PROPERTY_ERROR) { goto out; } -- 1.6.5.2

3 3

[libvirt] VMware vCenter support
by Fulop, Balazs 13 Jan '10

13 Jan '10

Dear List, I find the ESX driver in libvirt quite useful to perform powercycle operations on a VM. However, I need to connect to an ESX server even when the VM is managed on the VMware 4.0 platform. Reading this mail: http://www.mail-archive.com/libvir-list@redhat.com/msg18259.html makes me think that support to connect directly to a vCenter using the scheme vpx:// is not far from becoming a reality. Could you please provide an estimated timeline for this and notes on possible further enhancements in the ESX driver code? Thank you very much in advance. Regards, Balazs Fulop -------------------------------------------------------------------------- NOTICE: If received in error, please destroy, and notify sender. Sender does not intend to waive confidentiality or privilege. Use of this email is prohibited when received in error. We may monitor and store emails to the extent permitted by applicable law.

2 1

[libvirt] Problem with libvirt-0.7.5 windows port
by anuj rampal 13 Jan '10

13 Jan '10

Hi, I'm trying to cross compile the libvirt-0.7.5 for windows. This is the error I'm getting: # make make all-recursive make[1]: Entering directory `/root/libvirt-0.7.5' Making all in gnulib/lib make[2]: Entering directory `/root/libvirt-0.7.5/gnulib/lib' [...] Making all in tools make[2]: Entering directory `/root/libvirt-0.7.5/tools' make all-am make[3]: Entering directory `/root/libvirt-0.7.5/tools' CC virsh-console.o CC virsh-virsh.o CCLD virsh.exe ../src/.libs/libvirt.a: could not read symbols: Archive has no index; run ranlib to add one collect2: ld returned 1 exit status make[3]: *** [virsh.exe] Error 1 make[3]: Leaving directory `/root/libvirt-0.7.5/tools' make[2]: *** [all] Error 2 make[2]: Leaving directory `/root/libvirt-0.7.5/tools' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/root/libvirt-0.7.5' make: *** [all] Error 2 Does any1 has any idea. Thanks in advance. Regards Anuj

1 0

[libvirt] [PATCH] Implement path lookup for USB by vendor:product
by Cole Robinson 13 Jan '10

13 Jan '10

Based off how QEMU does it, look through /sys/bus/usb/devices/* for matching vendor:product info, and if found, use info from the surrounding files to build the device's /dev/bus/usb path. This fixes USB device assignment by vendor:product when running qemu as non-root (well, it should, but for some reason I couldn't reproduce the failure people are seeing in [1], but it appears to work properly) [1] https://bugzilla.redhat.com/show_bug.cgi?id=542450 Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- po/POTFILES.in | 1 + src/qemu/qemu_driver.c | 9 +-- src/security/security_selinux.c | 8 ++- src/security/virt-aa-helper.c | 7 ++- src/util/hostusb.c | 97 +++++++++++++++++++++++++++++++++++++- src/util/hostusb.h | 4 +- 6 files changed, 112 insertions(+), 14 deletions(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index 1ab0859..22e9c3c 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -54,6 +54,7 @@ src/uml/uml_conf.c src/uml/uml_driver.c src/util/bridge.c src/util/conf.c +src/util/hostusb.c src/util/json.c src/util/logging.c src/util/pci.c diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index deb8adc..f03ce91 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2105,14 +2105,11 @@ static int qemuDomainSetHostdevUSBOwnership(virConnectPtr conn, struct qemuFileOwner owner = { uid, gid }; int ret = -1; - /* XXX what todo for USB devs assigned based on product/vendor ? Doom :-( */ - if (!def->source.subsys.u.usb.bus || - !def->source.subsys.u.usb.device) - return 0; - usbDevice *dev = usbGetDevice(conn, def->source.subsys.u.usb.bus, - def->source.subsys.u.usb.device); + def->source.subsys.u.usb.device, + def->source.subsys.u.usb.vendor, + def->source.subsys.u.usb.product); if (!dev) goto cleanup; diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 000bc8a..e015c06 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -484,7 +484,9 @@ SELinuxSetSecurityHostdevLabel(virConnectPtr conn, if (dev->source.subsys.u.usb.bus && dev->source.subsys.u.usb.device) { usbDevice *usb = usbGetDevice(conn, dev->source.subsys.u.usb.bus, - dev->source.subsys.u.usb.device); + dev->source.subsys.u.usb.device, + dev->source.subsys.u.usb.vendor, + dev->source.subsys.u.usb.product); if (!usb) goto done; @@ -556,7 +558,9 @@ SELinuxRestoreSecurityHostdevLabel(virConnectPtr conn, case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB: { usbDevice *usb = usbGetDevice(conn, dev->source.subsys.u.usb.bus, - dev->source.subsys.u.usb.device); + dev->source.subsys.u.usb.device, + dev->source.subsys.u.usb.vendor, + dev->source.subsys.u.usb.product); if (!usb) goto done; diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 35b29ad..6a52d4c 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -839,8 +839,11 @@ get_files(vahControl * ctl) if (dev->source.subsys.u.usb.bus && dev->source.subsys.u.usb.device) { usbDevice *usb = usbGetDevice(NULL, - dev->source.subsys.u.usb.bus, - dev->source.subsys.u.usb.device); + dev->source.subsys.u.usb.bus, + dev->source.subsys.u.usb.device, + dev->source.subsys.u.usb.vendor, + dev->source.subsys.u.usb.product); + if (usb == NULL) continue; rc = usbDeviceFileIterate(NULL, usb, diff --git a/src/util/hostusb.c b/src/util/hostusb.c index 07e10b1..3e9ac83 100644 --- a/src/util/hostusb.c +++ b/src/util/hostusb.c @@ -37,9 +37,10 @@ #include "util.h" #include "virterror_internal.h" +#define USB_SYSFS "/sys/bus/usb" #define USB_DEVFS "/dev/bus/usb/" -#define USB_ID_LEN 10 /* "XXXX XXXX" */ -#define USB_ADDR_LEN 8 /* "XXX:XXX" */ +#define USB_ID_LEN 10 /* "1234 5678" */ +#define USB_ADDR_LEN 8 /* "123:456" */ struct _usbDevice { unsigned bus; @@ -57,11 +58,95 @@ struct _usbDevice { virReportErrorHelper(conn, VIR_FROM_NONE, code, __FILE__, \ __FUNCTION__, __LINE__, fmt) +static int usbSysReadFile(virConnectPtr conn, + const char *f_name, const char *d_name, + const char *fmt, unsigned *value) +{ + int ret = -1; + char *buf = NULL; + char filename[PATH_MAX]; + + snprintf(filename, PATH_MAX, USB_SYSFS "/devices/%s/%s", d_name, f_name); + + if (virFileReadAll(filename, 1024, &buf) < 0) + goto error; + + if (sscanf(buf, fmt, value) != 1) { + virReportSystemError(conn, errno, + _("Could not parse usb file %s"), filename); + goto error; + } + + ret = 0; +error: + VIR_FREE(buf); + return ret; +} + +static int usbFindBusByVendor(virConnectPtr conn, + unsigned vendor, unsigned product, + unsigned *bus, unsigned *devno) +{ + DIR *dir = NULL; + int ret = -1, found = 0; + struct dirent *de; + + dir = opendir(USB_SYSFS "/devices"); + if (!dir) { + virReportSystemError(conn, errno, + _("Could not open directory %s"), + USB_SYSFS "/devices"); + goto error; + } + + while ((de = readdir(dir))) { + unsigned found_prod, found_vend; + if (de->d_name[0] == '.' || strchr(de->d_name, ':')) + continue; + + if (usbSysReadFile(conn, "idVendor", de->d_name, + "%x", &found_vend) < 0) + goto error; + if (usbSysReadFile(conn, "idProduct", de->d_name, + "%x", &found_prod) < 0) + goto error; + + if (found_prod == product && found_vend == vendor) { + /* Lookup bus.addr info */ + char *tmpstr = de->d_name; + unsigned found_bus, found_addr; + + if (STREQ(de->d_name, "usb")) + tmpstr += 3; + found_bus = atoi(tmpstr); + + if (usbSysReadFile(conn, "devnum", de->d_name, + "%d", &found_addr) < 0) + goto error; + + *bus = found_bus; + *devno = found_addr; + found = 1; + break; + } + } + + if (!found) + usbReportError(conn, VIR_ERR_INTERNAL_ERROR, + _("Did not find USB device %x:%x"), vendor, product); + else + ret = 0; + +error: + return ret; +} usbDevice * usbGetDevice(virConnectPtr conn, unsigned bus, - unsigned devno) + unsigned devno, + unsigned vendor, + unsigned product) { usbDevice *dev; @@ -70,6 +155,12 @@ usbGetDevice(virConnectPtr conn, return NULL; } + if (vendor) { + /* Look up bus.dev by vendor:product */ + if (usbFindBusByVendor(conn, vendor, product, &bus, &devno) < 0) + return NULL; + } + dev->bus = bus; dev->dev = devno; diff --git a/src/util/hostusb.h b/src/util/hostusb.h index 7f75c8b..739a4aa 100644 --- a/src/util/hostusb.h +++ b/src/util/hostusb.h @@ -28,7 +28,9 @@ typedef struct _usbDevice usbDevice; usbDevice *usbGetDevice (virConnectPtr conn, unsigned bus, - unsigned devno); + unsigned devno, + unsigned vendor, + unsigned product); void usbFreeDevice (virConnectPtr conn, usbDevice *dev); -- 1.6.5.2

2 1

[libvirt] [PATCH] Implement CPU topology support for QEMU driver
by Jiri Denemark 13 Jan '10

13 Jan '10

QEMU's command line equivalent for the following domain XML fragment <vcpus>2</vcpus> <cpu ...> ... <topology sockets='1' cores='2', threads='1'/> </cpu> is -smp 2,sockets=1,cores=2,threads=1 This syntax was introduced in QEMU-0.12. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_conf.c | 137 ++++++++++++++++++++++++++++++++++++++++++++------ src/qemu/qemu_conf.h | 3 +- 2 files changed, 123 insertions(+), 17 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index d3da776..bc4736a 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -1,7 +1,7 @@ /* * qemu_conf.c: QEMU configuration management * - * Copyright (C) 2006, 2007, 2008, 2009 Red Hat, Inc. + * Copyright (C) 2006, 2007, 2008, 2009, 2010 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -1115,6 +1115,10 @@ static unsigned int qemudComputeCmdFlags(const char *help, flags |= QEMUD_CMD_FLAG_CHARDEV; if (strstr(help, "-balloon")) flags |= QEMUD_CMD_FLAG_BALLOON; + if (strstr(help, "cores=") && + strstr(help, "threads=") && + strstr(help, "sockets=")) + flags |= QEMUD_CMD_FLAG_SMP_TOPOLOGY; if (version >= 9000) flags |= QEMUD_CMD_FLAG_VNC_COLON; @@ -1900,7 +1904,6 @@ int qemudBuildCommandLine(virConnectPtr conn, const char *migrateFrom) { int i; char memory[50]; - char vcpus[50]; char boot[VIR_DOMAIN_BOOT_LAST]; struct utsname ut; int disableKQEMU = 0; @@ -2049,7 +2052,6 @@ int qemudBuildCommandLine(virConnectPtr conn, * is not supported, then they're out of luck anyway */ snprintf(memory, sizeof(memory), "%lu", def->maxmem/1024); - snprintf(vcpus, sizeof(vcpus), "%lu", def->vcpus); snprintf(domid, sizeof(domid), "%d", def->id); ADD_ENV_LIT("LC_ALL=C"); @@ -2112,8 +2114,34 @@ int qemudBuildCommandLine(virConnectPtr conn, ADD_ARG_LIT("-mem-path"); ADD_ARG_LIT(driver->hugepage_path); } + ADD_ARG_LIT("-smp"); - ADD_ARG_LIT(vcpus); + if ((qemuCmdFlags & QEMUD_CMD_FLAG_SMP_TOPOLOGY) && def->cpu) { + virBuffer buf = VIR_BUFFER_INITIALIZER; + + virBufferVSprintf(&buf, "%lu", def->vcpus); + + if (def->cpu->sockets > 0) + virBufferVSprintf(&buf, ",sockets=%u", def->cpu->sockets); + + if (def->cpu->cores > 0) + virBufferVSprintf(&buf, ",cores=%u", def->cpu->cores); + + if (def->cpu->threads > 0) + virBufferVSprintf(&buf, ",threads=%u", def->cpu->threads); + + if (virBufferError(&buf)) { + virBufferFreeAndReset(&buf); + goto no_memory; + } + + ADD_ARG(virBufferContentAndReset(&buf)); + } + else { + char vcpus[50]; + snprintf(vcpus, sizeof(vcpus), "%lu", def->vcpus); + ADD_ARG_LIT(vcpus); + } if (qemuCmdFlags & QEMUD_CMD_FLAG_NAME) { ADD_ARG_LIT("-name"); @@ -3729,6 +3757,27 @@ error: } +static virCPUDefPtr +qemuInitGuestCPU(virConnectPtr conn, + virDomainDefPtr dom) +{ + if (!dom->cpu) { + virCPUDefPtr cpu; + + if (VIR_ALLOC(cpu) < 0) { + virReportOOMError(conn); + return NULL; + } + + cpu->type = VIR_CPU_TYPE_GUEST; + cpu->match = VIR_CPU_MATCH_EXACT; + dom->cpu = cpu; + } + + return dom->cpu; +} + + static int qemuParseCommandLineCPU(virConnectPtr conn, virDomainDefPtr dom, @@ -3738,10 +3787,8 @@ qemuParseCommandLineCPU(virConnectPtr conn, const char *p = val; const char *next; - if (VIR_ALLOC(cpu) < 0) - goto no_memory; - - cpu->type = VIR_CPU_TYPE_GUEST; + if (!(cpu = qemuInitGuestCPU(conn, dom))) + goto error; do { if (*p == '\0' || *p == ',') @@ -3785,7 +3832,6 @@ qemuParseCommandLineCPU(virConnectPtr conn, } } while ((p = next)); - dom->cpu = cpu; return 0; syntax: @@ -3796,7 +3842,71 @@ syntax: no_memory: virReportOOMError(conn); error: - virCPUDefFree(cpu); + return -1; +} + + +static int +qemuParseCommandLineSmp(virConnectPtr conn, + virDomainDefPtr dom, + const char *val) +{ + const char *p = val; + const char *next; + const char *const options[] = { "sockets=", "cores=", "threads=" }; + unsigned int topology[] = { 0, 0, 0 }; + char *end; + + do { + if (*p == '\0' || *p == ',') + goto syntax; + + if ((next = strchr(p, ','))) + next++; + + if (c_isdigit(*p)) { + int n; + if (virStrToLong_i(p, &end, 10, &n) < 0 || + !end || (*end != ',' && *end != '\0')) + goto syntax; + dom->vcpus = n; + } else { + int i; + int n = -1; + for (i = 0; i < ARRAY_CARDINALITY(options); i++) { + if (STRPREFIX(p, options[i])) { + p += strlen(options[i]); + if (virStrToLong_i(p, &end, 10, &n) < 0 || + !end || (*end != ',' && *end != '\0')) + goto syntax; + topology[i] = n; + break; + } + } + + if (n < 0) + goto syntax; + } + } while ((p = next)); + + if (topology[0] && topology[1] && topology[2]) { + virCPUDefPtr cpu; + + if (!(cpu = qemuInitGuestCPU(conn, dom))) + goto error; + + cpu->sockets = topology[0]; + cpu->cores = topology[1]; + cpu->threads = topology[2]; + } else if (topology[0] || topology[1] || topology[2]) + goto syntax; + + return 0; + +syntax: + qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, + _("cannot parse CPU topology '%s'"), val); +error: return -1; } @@ -3948,14 +4058,9 @@ virDomainDefPtr qemuParseCommandLine(virConnectPtr conn, } def->memory = def->maxmem = mem * 1024; } else if (STREQ(arg, "-smp")) { - int vcpus; WANT_VALUE(); - if (virStrToLong_i(val, NULL, 10, &vcpus) < 0) { - qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR, \ - _("cannot parse CPU count '%s'"), val); + if (qemuParseCommandLineSmp(conn, def, val) < 0) goto error; - } - def->vcpus = vcpus; } else if (STREQ(arg, "-uuid")) { WANT_VALUE(); if (virUUIDParse(val, def->uuid) < 0) { diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 82254ca..3f74cc9 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -1,7 +1,7 @@ /* * qemu_conf.h: QEMU configuration management * - * Copyright (C) 2006, 2007, 2009 Red Hat, Inc. + * Copyright (C) 2006, 2007, 2009, 2010 Red Hat, Inc. * Copyright (C) 2006 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -78,6 +78,7 @@ enum qemud_cmd_flags { QEMUD_CMD_FLAG_ENABLE_KVM = (1 << 23), /* Is the -enable-kvm flag available to "enable KVM full virtualization support" */ QEMUD_CMD_FLAG_MONITOR_JSON = (1 << 24), /* JSON mode for monitor */ QEMUD_CMD_FLAG_BALLOON = (1 << 25), /* -balloon available */ + QEMUD_CMD_FLAG_SMP_TOPOLOGY = (1 << 26), /* Is sockets=s,cores=c,threads=t available for -smp? */ }; /* Main driver state */ -- 1.6.6

2 3

[libvirt] [PATCH] Fix migration in xend driver
by Jim Fehlig 12 Jan '10

12 Jan '10

Upstream xen has changed parameters to the migration operation several times over the past 18 months. Changeset 17553 removed the resouce parameter, Changesets 17709, 17753, and 20326 added ssl, node, and change_home_server parameters respectively. Fortunately, testing has revealed that xend will fail the operation if a parameter is missing but happily honor it if unknown parameters are provided. Thus all currently supported parameters can be provided, satisfying current xend but not regressing older versions. --- src/xen/xend_internal.c | 14 ++++++++++---- 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index be033f5..d9bfa15 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -4553,15 +4553,21 @@ xenDaemonDomainMigratePerform (virDomainPtr domain, DEBUG("hostname = %s, port = %s", hostname, port); - /* Make the call. */ + /* Make the call. + * NB: xend will fail the operation if any parameters are + * missing but happily accept unknown parameters. This works + * to our advantage since all parameters supported and required + * by current xend can be included without breaking older xend. + */ ret = xend_op (domain->conn, domain->name, "op", "migrate", "destination", hostname, "live", live, "port", port, - "node", "-1", - "ssl", "0", - "resource", "0", /* required, xend ignores it */ + "node", "-1", /* xen-unstable c/s 17753 */ + "ssl", "0", /* xen-unstable c/s 17709 */ + "change_home_server", "0", /* xen-unstable c/s 20326 */ + "resource", "0", /* removed by xen-unstable c/s 17553 */ NULL); VIR_FREE (hostname); -- 1.6.0.2

2 1

[libvirt] Start external programm on network-setup
by Dominik Bruhn 12 Jan '10

12 Jan '10

Hy, im using libvirt-bin on debian and configured the network of libvirt to be a standalone bridge. Is there a possibility to run a program after the bridge has successfully and completly set up by libvirtd? I would like to restart shorewall (a firewall) when the bridge is set up to activate MASQ and DNAT and other policies which I need. I would also like to start my own configured dnsmasq when the interface is up (can't start it realier because it has to bind to the interface). I hope thats the right place to ask such a question, if not, please direct me. Thanks for the help -- Dominik mailto: dominik(a)dbruhn.de

2 1

[libvirt] Problem: cannot make libvirtd listen to TCP sockets
by Motiejus Jakštys 12 Jan '10

12 Jan '10

Hello, I don't know if I am writing to the proper place, but I've been struggling quite a long time with connecting to libvirtd. Any information would help. My goal is to start remote tcp connection (afterwards - tls, but later) and connect to the libvirtd. http://libvirt.org/uri.html#URI_remote There are some nitoces when starting libvirtd: -~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~- xen:/usr/local/etc# libvirtd 17:53:42.153: error : virRun:847 : internal error '/sbin/iptables --table filter --insert FORWARD --destination 192.168.122.0/255.255.255.0 --out-interface virbr0 --match state --state ESTABLISHED,RELATED --jump ACCEPT' exited with non-zero status 1 and signal 0: iptables: No chain/target/match by that name 17:53:42.153: error : networkAddMasqueradingIptablesRules:615 : failed to add iptables rule to allow forwarding to 'virbr0': Invalid argument 17:53:42.354: warning : qemudStartup:1067 : Unable to create cgroup for driver: No such device or address 17:53:42.372: warning : lxcStartup:1755 : Unable to create cgroup for driver: No such device or address 17:53:43.259: warning : qemudDispatchSignalEvent:385 : Shutting down on signal 2 -~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~- libvirtd keeps running, however it does not open ANY new ports to listening state. Extract from /usr/local/etc/libvirt/libvirtd.conf : (full conf here: http://pastebin.com/f6e0f572) listen_tls = 1 listen_tcp = 1 /usr/local/var/log/libvirt has 3 empty directories: {lxc,qemu,uml}, so nothing logged. xen:/# virsh list shows my current running domains, so looks like libvirt is fine. I have compiled XEN and libvirt from source (0.7.4, then upgraded 0.7.5, got same errors on both versions). Additional information: I am running three guest domains, all bridged to eth0 (peth0 ethernet card -> eth0 bridge -> vifs), from xend-config.sxp: (network-script network-bridge) Debian lenny Linux xen 2.6.18.8-xen0 #1 SMP Fri Nov 27 18:17:01 EET 2009 x86_64 GNU/Linux (here is kernel config: http://pastebin.com/f393c78f0) Note: I compiled iptables as a module manually, however without IMQ support, since it failed to compile. I have installed Xen 3.4.2, however virsh thinks it's 3.4.0 -~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~- virsh # version Compiled against library: libvir 0.7.5 Using library: libvir 0.7.5 Using API: Xen 3.0.1 Running hypervisor: Xen 3.4.0 -~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~--~*~- Any suggestions how to properly start libvirtd, pointers to other related mailing-lists or forums are very welcome. Thank you! Motiejus Jakštys

2 2

[libvirt] [PATCH 0/5] Fix various error squashing issues
by Cole Robinson 12 Jan '10

12 Jan '10

The following series adds internal APIs that help prevent legitimate errors from being overwritten by other errors (for example in cleanup routines). The majority of this series is a patch from Dan[1] which makes error callbacks explictly triggered when exiting an API call, rather than when an error is raised (I've updated this to cover the current codebase) [1] http://gitorious.org/~berrange/libvirt/staging/commits/error-callbacks Cole Robinson (4): virterror: Add virSetError qemu: migrate: Save MigratePerform error in MigrateFinish. libvirt.c: Preserve MigratePerform failure qemu: Disable errors in qemudShutdownVMDaemon Daniel P. Berrange (1): Ensure error handling callback functions are called from safe context src/libvirt.c | 849 +++++++++++++++++++++++------------------ src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 18 + src/util/virterror.c | 102 +++--- src/util/virterror_internal.h | 4 +- 5 files changed, 548 insertions(+), 426 deletions(-)

3 12

[libvirt] Nice libvirt article on IBM developer works
by Hugh O. Brock 12 Jan '10

12 Jan '10

http://www.ibm.com/developerworks/linux/library/l-libvirt/index.html?ca=dgr… Maybe we can get more like this (despite the factual errors...) --H -- ======================================================== Hugh Brock, hbrock(a)redhat.com, +1-215-564-3232 Deltacloud API + Portal http://deltacloud.org Libvirt virtualization library http://libvirt.org ========================================================

1 0

Re: [libvirt] Segfault in event-test.c example
by pspreadborough＠comcast.net 12 Jan '10

12 Jan '10

----- pspreadborough(a)comcast.net wrote: > ----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > > > 2010/1/11 <pspreadborough(a)comcast.net>: > > > > > > ----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > > > > > >> 2010/1/10 <pspreadborough(a)comcast.net>: > > >> > > > >> > ----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > > >> > > > >> >> 2010/1/10 <pspreadborough(a)comcast.net>: > > >> >> > > > >> >> > Hello, > > >> >> > > > >> >> > I have been trying to use the domain event C code example > but > > >> >> > unfortunately it segfaults (signal 11) every time I run it: > > >> >> > > > >> >> > [root@Spring events-c]# ./event-test > > >> >> > myEventAddHandleFunc:221: Add handle 5 1 0xf081a0 0x8f727f8 > > >> >> > myEventAddHandleFunc:221: Add handle 7 1 0xf09990 0x8f727f8 > > >> >> > myEventAddHandleFunc:221: Add handle 8 1 0xed7940 0x8f727f8 > > >> >> > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 > > 0x8f727f8 > > >> >> > myEventAddHandleFunc:221: Add handle 11 1 0xed7940 0x8f727f8 > > >> >> > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 > > 0x8f727f8 > > >> >> > main:322 :: Registering domain event cbs > > >> >> > Segmentation fault (core dumped) > > >> >> > > > >> >> > Core was generated by > > >> >> > > > >> >> > > >> > > > `/root/libvirt-0.7.5/examples/domain-events/events-c/.libs/lt-event-test'. > > >> >> > Program terminated with signal 11, Segmentation fault. > > >> >> > [New process 21806] > > >> >> > [New process 21822] > > >> >> > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) > > at > > >> >> > remote/remote_driver.c:8720 > > >> >> > 8720 tempQueue.count = priv->domainEvents->count; > > >> >> > (gdb) bt > > >> >> > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) > > at > > >> >> > remote/remote_driver.c:8720 > > >> >> > #1 0x080490d3 in main (argc=Cannot access memory at address > > 0x1 > > >> >> > ) at event-test.c:347 > > >> >> > > > >> >> > The stack looks corrupted so I'm doubtful that this trace if > > of > > >> much > > >> >> value. > > >> >> > I have built > > >> >> > and installed libvirt-0.7.5 and it and it's tools seem to be > > >> >> operating > > >> >> > correctly. > > >> >> > > >> >> I tried the event-test with libvirt-0.7.5 and QEMU/Xen and > both > > >> are > > >> >> working as expected. No segfaults. > > >> >> > > >> >> Could you inspect the values of priv and priv->domainEvents in > > GDB > > >> >> using 'p priv' to see if they are NULL and try to dereference > > them > > >> in > > >> >> GDB using 'p *priv' to see if they point to valid memory > areas? > > >> >> > > >> >> Yes the backtrace looks corrupted. If there is stack/heap > > >> corruption > > >> >> involved valgrind may reveal it, so try to run the event-test > > in > > >> >> valgrind and see if that gives any hints. > > >> >> > > >> >> You can also try the GIT version of libvirt. There was a > > invalid > > >> free > > >> >> call (resulting in heap corruption) in the node device code > > fixed > > >> >> after the 0.7.5 release. But that should have no effect on the > > >> >> event-test. > > >> >> > > >> >> Matthias > > >> > > > >> > Matthias, > > >> > > > >> > priv->domainEvents is NULL, here's the gdb output: > > >> > > >> This explains the segfault. The next question is, why is it NULL? > > >> > > >> > (gdb) p *priv > > >> > $1 = {lock = {lock = {__data = {__lock = 1, __count = 0, > __owner > > = > > >> 21806, __kind = 0, __nusers = 1, {__spins = 0, __list = { > > >> > __next = 0x0}}}, __size = > > >> > > > "\001\000\000\000\000\000\000\000.U\000\000\000\000\000\000\001\000\000\000\000\000\000", > > >> > __align = 1}}, sock = 150469168, watch = 3, pid = 4, > > uses_tls = > > >> 1982791681, is_secure = 1815048801, session = 0x782f6269, > > >> > > >> Seeing uses_tls and is_secure being large numbers and knowing > that > > >> both are used as boolean values in the code and should have > values > > of > > >> 0 or 1 make me think that priv points to already freed memory > > here. > > >> > > >> > type = 0x2f646e65 <Address 0x2f646e65 out of bounds>, counter > = > > >> 1684956536, localUses = 1668248365, > > >> > hostname = 0x74656b <Address 0x74656b out of bounds>, debugLog > > = > > >> 0x0, saslconn = 0x0, saslDecoded = 0x0, saslDecodedLength = 0, > > >> > > >> type and hostname are char pointers, but the seem to point into > > >> nowhere, confirms that this is either freed memory or priv itself > > got > > >> overwritten due to heap corruption. > > >> > > >> > saslDecodedOffset = 0, saslEncoded = 0x0, saslEncodedLength = > > 0, > > >> saslEncodedOffset = 0, > > >> > buffer = '\0' <repeats 68 times>, > > >> > > > "n\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\bQ�\b��\030\034�\b\000\000\000\000�\033�\b\001\000\000\000\002\000\000\000�\033�\b\000\000\000\000\025|�\000\a", > > >> '\0' <repeats 11 times>, "X\000�\b", '\0' <repeats 12 times>, > > >> "\021\000\000\000\002\000\000\000P��\b\000\000\000\000\021", '\0' > > >> <repeats 15 times>, > > >> > > > "\021\000\000\0008\036�\b\f\000\000\000\020\000\000\000\021\000\000\000\a\000\000\000\b\000\000\000\t\000\000\000\021\000\000\000\002\000\000\000\230\034�\b\000\000\000\000A\000\000\000\003\000\000\000\001\000\000\000\001\000"..., > > >> bufferLength = 0, > > >> > bufferOffset = 0, callbackList = 0x0, domainEvents = 0x0, > > >> eventFlushTimer = 0, domainEventDispatching = 1, wakeupSendFD = > 0, > > >> > wakeupReadFD = 0, waitDispatch = 0x0, streams = 0x0} > > >> > > > >> > I'll try a run with valgrind and post the results. > > >> > > > >> > Pete > > >> > > > >> > > >> Could you test the Python version of this example found in > > >> examples/domain-events/events-python/event-test.py? Does this > > work? > > >> > > >> Otherwise lets see if valgrind gives any hints. > > >> > > >> Matthias > > > > > > > > > During initialization I notice that the myEventAddHandleFunc() > > method is > > > called multiple times, each time with a different fd value (5,7,8 > > and 11). > > > The way the code is written only the last fd value is recorded and > > then > > > used in the poll() call. Is this the intended? if so why are the > > preceding > > > fds ignored? > > > > > > myEventAddHandleFunc:223: Add handle 5 1 0xf13480 0x97b97d8 > > > myEventAddHandleFunc:223: Add handle 7 1 0xf14c70 0x97b97d8 > > > Allocating domainEvents:0x97c6b10 > > > myEventAddHandleFunc:223: Add handle 8 1 0xee2940 0x97b97d8 > > > myEventAddTimeoutFunc:260: Adding Timeout -1 0xee9fc0 0x97b97d8 > > > Allocating domainEvents:0x97c5780 > > > myEventAddHandleFunc:223: Add handle 11 1 0xee2940 0x97b97d8 > > > myEventAddTimeoutFunc:260: Adding Timeout -1 0xee9fc0 0x97b97d8 > > > main:333 :: Registering domain event cbs > > > > > > > > > Regards, > > > > > > Pete > > > > > > > That's strange. I can't reproduce this neither. I always get exactly > > one call to myEventAddHandleFunc: > > > > myEventAddHandleFunc:221: Add handle 3 1 0x7ff116f68b00 0x1d97f00 > > myEventAddTimeoutFunc:251: Adding Timeout -1 0x7ff116f68750 > 0x1d97f00 > > main:322 :: Registering domain event cbs > > myEventUpdateHandleFunc:232: Updated Handle 0 0 > > myEventUpdateHandleFunc:232: Updated Handle 0 1 > > > > You could try to run the event-test in GDB and set a breakpoint on > > myEventAddHandleFunc to see where 4 additional calls to > > myEventAddHandleFunc come from. > > > > In my case I get this backtrace when setting a breakpoint on > > myEventAddHandleFunc: > > > > (gdb) bt > > #0 myEventAddHandleFunc (fd=6, event=1, cb=0x7f1be6ec3b00 > > <remoteDomainEventFired>, opaque=0xc68f00, ff=0) at event-test.c:220 > > #1 0x00007f1be6ecbaaf in doRemoteOpen (conn=0xc68f00, > > priv=0x7f1be7350010, auth=0x0, flags=0) at > remote/remote_driver.c:893 > > #2 0x00007f1be6ece053 in remoteOpen (conn=0xc68f00, auth=0x0, > > flags=13007744) at remote/remote_driver.c:1076 > > #3 0x00007f1be6eb155d in do_open (name=0x7fff48400968 > > "qemu:///system", auth=0x0, flags=0) at libvirt.c:1117 > > #4 0x0000000000400eb3 in main (argc=<value optimized out>, > > argv=<value optimized out>) at event-test.c:313 > > > > Matthias > > > Matthias > > Here are the four stack traces, one for each time > myEventAddHandleFunc() was > called. > > #0 myEventAddHandleFunc (fd=8, event=1, cb=0x85b480 > <xenStoreWatchEvent>, opaque=0x824a7d8, ff=0) at event-test.c:223 > #1 0x007ccf55 in virEventAddHandle (fd=8, events=1, cb=0x85b480 > <xenStoreWatchEvent>, opaque=0x824a7d8, ff=0) > at util/event.c:45 > #2 0x0085b291 in xenStoreOpen (conn=0x824a7d8, auth=0x0, flags=<value > optimized out>) at xen/xs_internal.c:339 > #3 0x00844287 in xenUnifiedOpen (conn=0x824a7d8, auth=0x0, flags=0) > at xen/xen_driver.c:352 > #4 0x00811d05 in do_open (name=0xbf8c49d4 "xen:///", auth=0x0, > flags=0) at libvirt.c:1117 > #5 0x08048e92 in main (argc=Cannot access memory at address 0x2 > ) at event-test.c:325 > (gdb) c > Continuing. > (gdb) b > Note: breakpoint 1 also set at pc 0x8048bc9. > Breakpoint 2 at 0x8048bc9: file event-test.c, line 223. > (gdb) bt > #0 myEventAddHandleFunc (fd=10, event=1, cb=0x85cc70 > <xenInotifyEvent>, opaque=0x824a7d8, ff=0) at event-test.c:223 > #1 0x007ccf55 in virEventAddHandle (fd=10, events=1, cb=0x85cc70 > <xenInotifyEvent>, opaque=0x824a7d8, ff=0) at util/event.c:45 > #2 0x0085c827 in xenInotifyOpen (conn=0x824a7d8, auth=0x0, flags=0) > at xen/xen_inotify.c:460 > #3 0x008444f1 in xenUnifiedOpen (conn=0x824a7d8, auth=0x0, flags=0) > at xen/xen_driver.c:391 > #4 0x00811d05 in do_open (name=0xbf8c49d4 "xen:///", auth=0x0, > flags=0) at libvirt.c:1117 > #5 0x08048e92 in main (argc=Cannot access memory at address 0x1 > ) at event-test.c:325 > (gdb) c > Continuing. > (gdb) bt > #0 myEventAddHandleFunc (fd=11, event=1, cb=0x82a940 > <remoteDomainEventFired>, opaque=0x824a7d8, ff=0) at event-test.c:223 > #1 0x007ccf55 in virEventAddHandle (fd=11, events=1, cb=0x82a940 > <remoteDomainEventFired>, opaque=0x824a7d8, ff=0) > at util/event.c:45 > #2 0x0082c478 in doRemoteOpen (conn=0x824a7d8, priv=0xb7534008, > auth=0x0, flags=0) at remote/remote_driver.c:894 > #3 0x00830448 in remoteOpenSecondaryDriver (conn=0x824a7d8, auth=0x0, > flags=0, priv=0xbf8c2668) at remote/remote_driver.c:1006 > #4 0x0083082a in remoteNetworkOpen (conn=0x824a7d8, auth=0x0, > flags=0) at remote/remote_driver.c:3549 > #5 0x00811e2f in do_open (name=0xbf8c49d4 "xen:///", auth=0x0, > flags=0) at libvirt.c:1137 > #6 0x08048e92 in main (argc=1, argv=0xbf8c28b4) at event-test.c:325 > (gdb) c > Continuing. > (gdb) bt > #0 myEventAddHandleFunc (fd=14, event=1, cb=0x82a940 > <remoteDomainEventFired>, opaque=0x824a7d8, ff=0) at event-test.c:223 > #1 0x007ccf55 in virEventAddHandle (fd=14, events=1, cb=0x82a940 > <remoteDomainEventFired>, opaque=0x824a7d8, ff=0) > at util/event.c:45 > #2 0x0082c478 in doRemoteOpen (conn=0x824a7d8, priv=0x8258ab0, > auth=0x0, flags=0) at remote/remote_driver.c:894 > #3 0x00830448 in remoteOpenSecondaryDriver (conn=0x824a7d8, auth=0x0, > flags=0, priv=0xbf8c2668) at remote/remote_driver.c:1006 > #4 0x0083078a in remoteInterfaceOpen (conn=0x824a7d8, auth=0x0, > flags=0) at remote/remote_driver.c:4104 > #5 0x00811f4e in do_open (name=0xbf8c49d4 "xen:///", auth=0x0, > flags=0) at libvirt.c:1156 > #6 0x08048e92 in main (argc=1, argv=0xbf8c28b4) at event-test.c:325 > > Regards, > > Pete > > > -- > Libvir-list mailing list > Libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list Matthias, Using the UIR xen+unix:/// works! I'm curious to know why when using the UIR xen:/// multiple myEventAddHandleFunc() calls occurred. Are there and fields I could use to identify and ignore the spurious calls? I'd like to use the event monitoring for several remote Xen hosts. I assume I'll have to modify the code to connect remotely to each host and hope for just one myEventAddHandleFunc() call per host. Thanks for your assistance it's much apprecied, Regards, Pete

2 2

[libvirt] [PATCH] remote_driver.c: fix a NULL dereference in remoteDomainEventQueueFlush().
by kakuma 12 Jan '10

12 Jan '10

Hi, all. There is a case of a NULL dereference in function remoteDomainEventQueueFlush() in remote_driver.c In the case of local connection conn->privateData->domainEvents isn't reserved. In this case it will occurs segment fault. (for example examples/domain-events/events-c/event-test.c) I think the following patch will be available. Thanks. --- src/remote/remote_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index d6f5fce..b112fd3 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -8709,7 +8709,7 @@ void remoteDomainEventQueueFlush(int timer ATTRIBUTE_UNUSED, void *opaque) { virConnectPtr conn = opaque; - struct private_data *priv = conn->privateData; + struct private_data *priv = conn->networkPrivateData; virDomainEventQueue tempQueue; remoteDriverLock(priv); -- 1.5.6.1 -- kakuma <f-kak(a)ksh.biglobe.ne.jp>

2 2

Re: [libvirt] Segfault in event-test.c example
by pspreadborough＠comcast.net 12 Jan '10

12 Jan '10

----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > 2010/1/10 <pspreadborough(a)comcast.net>: > > > > ----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > > > >> 2010/1/10 <pspreadborough(a)comcast.net>: > >> > > >> > Hello, > >> > > >> > I have been trying to use the domain event C code example but > >> > unfortunately it segfaults (signal 11) every time I run it: > >> > > >> > [root@Spring events-c]# ./event-test > >> > myEventAddHandleFunc:221: Add handle 5 1 0xf081a0 0x8f727f8 > >> > myEventAddHandleFunc:221: Add handle 7 1 0xf09990 0x8f727f8 > >> > myEventAddHandleFunc:221: Add handle 8 1 0xed7940 0x8f727f8 > >> > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 > >> > myEventAddHandleFunc:221: Add handle 11 1 0xed7940 0x8f727f8 > >> > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 > >> > main:322 :: Registering domain event cbs > >> > Segmentation fault (core dumped) > >> > > >> > Core was generated by > >> > > >> > `/root/libvirt-0.7.5/examples/domain-events/events-c/.libs/lt-event-test'. > >> > Program terminated with signal 11, Segmentation fault. > >> > [New process 21806] > >> > [New process 21822] > >> > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at > >> > remote/remote_driver.c:8720 > >> > 8720 tempQueue.count = priv->domainEvents->count; > >> > (gdb) bt > >> > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at > >> > remote/remote_driver.c:8720 > >> > #1 0x080490d3 in main (argc=Cannot access memory at address 0x1 > >> > ) at event-test.c:347 > >> > > >> > The stack looks corrupted so I'm doubtful that this trace if of > much > >> value. > >> > I have built > >> > and installed libvirt-0.7.5 and it and it's tools seem to be > >> operating > >> > correctly. > >> > >> I tried the event-test with libvirt-0.7.5 and QEMU/Xen and both > are > >> working as expected. No segfaults. > >> > >> Could you inspect the values of priv and priv->domainEvents in GDB > >> using 'p priv' to see if they are NULL and try to dereference them > in > >> GDB using 'p *priv' to see if they point to valid memory areas? > >> > >> Yes the backtrace looks corrupted. If there is stack/heap > corruption > >> involved valgrind may reveal it, so try to run the event-test in > >> valgrind and see if that gives any hints. > >> > >> You can also try the GIT version of libvirt. There was a invalid > free > >> call (resulting in heap corruption) in the node device code fixed > >> after the 0.7.5 release. But that should have no effect on the > >> event-test. > >> > >> Matthias > > > > Matthias, > > > > priv->domainEvents is NULL, here's the gdb output: > > This explains the segfault. The next question is, why is it NULL? > > > (gdb) p *priv > > $1 = {lock = {lock = {__data = {__lock = 1, __count = 0, __owner = > 21806, __kind = 0, __nusers = 1, {__spins = 0, __list = { > > __next = 0x0}}}, __size = > "\001\000\000\000\000\000\000\000.U\000\000\000\000\000\000\001\000\000\000\000\000\000", > > __align = 1}}, sock = 150469168, watch = 3, pid = 4, uses_tls = > 1982791681, is_secure = 1815048801, session = 0x782f6269, > > Seeing uses_tls and is_secure being large numbers and knowing that > both are used as boolean values in the code and should have values of > 0 or 1 make me think that priv points to already freed memory here. > > > type = 0x2f646e65 <Address 0x2f646e65 out of bounds>, counter = > 1684956536, localUses = 1668248365, > > hostname = 0x74656b <Address 0x74656b out of bounds>, debugLog = > 0x0, saslconn = 0x0, saslDecoded = 0x0, saslDecodedLength = 0, > > type and hostname are char pointers, but the seem to point into > nowhere, confirms that this is either freed memory or priv itself got > overwritten due to heap corruption. > > > saslDecodedOffset = 0, saslEncoded = 0x0, saslEncodedLength = 0, > saslEncodedOffset = 0, > > buffer = '\0' <repeats 68 times>, > "n\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\bQ�\b��\030\034�\b\000\000\000\000�\033�\b\001\000\000\000\002\000\000\000�\033�\b\000\000\000\000\025|�\000\a", > '\0' <repeats 11 times>, "X\000�\b", '\0' <repeats 12 times>, > "\021\000\000\000\002\000\000\000P��\b\000\000\000\000\021", '\0' > <repeats 15 times>, > "\021\000\000\0008\036�\b\f\000\000\000\020\000\000\000\021\000\000\000\a\000\000\000\b\000\000\000\t\000\000\000\021\000\000\000\002\000\000\000\230\034�\b\000\000\000\000A\000\000\000\003\000\000\000\001\000\000\000\001\000"..., > bufferLength = 0, > > bufferOffset = 0, callbackList = 0x0, domainEvents = 0x0, > eventFlushTimer = 0, domainEventDispatching = 1, wakeupSendFD = 0, > > wakeupReadFD = 0, waitDispatch = 0x0, streams = 0x0} > > > > I'll try a run with valgrind and post the results. > > > > Pete > > > > Could you test the Python version of this example found in > examples/domain-events/events-python/event-test.py? Does this work? > > Otherwise lets see if valgrind gives any hints. > > Matthias During initialization I notice that the myEventAddHandleFunc() method is called multiple times, each time with a different fd value (5,7,8 and 11). The way the code is written only the last fd value is recorded and then used in the poll() call. Is this the intended? if so why are the preceding fds ignored? myEventAddHandleFunc:223: Add handle 5 1 0xf13480 0x97b97d8 myEventAddHandleFunc:223: Add handle 7 1 0xf14c70 0x97b97d8 Allocating domainEvents:0x97c6b10 myEventAddHandleFunc:223: Add handle 8 1 0xee2940 0x97b97d8 myEventAddTimeoutFunc:260: Adding Timeout -1 0xee9fc0 0x97b97d8 Allocating domainEvents:0x97c5780 myEventAddHandleFunc:223: Add handle 11 1 0xee2940 0x97b97d8 myEventAddTimeoutFunc:260: Adding Timeout -1 0xee9fc0 0x97b97d8 main:333 :: Registering domain event cbs Regards, Pete

3 3

[libvirt] [PATCH] Document the domain XML cache attribute for disk devices
by Matthias Bolte 12 Jan '10

12 Jan '10

--- docs/formatdomain.html.in | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 46ab0ac..af31699 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -343,7 +343,7 @@ <pre> ... <disk type='file'> - <driver name="tap" type="aio"> + <driver name="tap" type="aio" cache="default"> <source file='/var/lib/xen/images/fv0'/> <target dev='hda' bus='ide'/> <encryption type='...'> @@ -383,7 +383,9 @@ <dd>If the hypervisor supports multiple backend drivers, then the optional <code>driver</code> element allows them to be selected. The <code>name</code> attribute is the primary backend driver name, while the optional <code>type</code> - attribute provides the sub-type. Since 0.1.8 + attribute provides the sub-type. The optional <code>cache</code> attribute + controls the cache mechanism, possible values are "default", "none", + "writethrough" and "writeback". Since 0.1.8 </dd> <dt><code>encryption</code></dt> <dd>If present, specifies how the volume is encrypted. See -- 1.6.0.4

2 2

[libvirt] [PATCH] qemu: Fix a memory leak in qemudExtractTTYPath
by Matthias Bolte 12 Jan '10

12 Jan '10

qemudWaitForMonitor calls qemudReadLogOutput with qemudFindCharDevicePTYs as callback. qemudFindCharDevicePTYs calls qemudExtractTTYPath to assign a string to chr->data.file.path. Afterwards qemudWaitForMonitor may call qemudFindCharDevicePTYsMonitor that overwrites chr->data.file.path without freeing the old value. This results in leaking the memory allocated by qemudExtractTTYPath. Report an OOM error if the strdup in qemudFindCharDevicePTYsMonitor fails. --- src/qemu/qemu_driver.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index daa6f94..8817565 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1433,7 +1433,13 @@ qemudFindCharDevicePTYsMonitor(virConnectPtr conn, return -1; \ } \ \ + VIR_FREE(chr->data.file.path); \ chr->data.file.path = strdup(path); \ + \ + if (chr->data.file.path == NULL) { \ + virReportOOMError(conn); \ + return -1; \ + } \ } \ } -- 1.6.0.4

2 2

[libvirt] Just to make sure I understand the API
by Bryan Kearney 11 Jan '10

11 Jan '10

To make sure I understand the API. If I have a domain defined, but not started.. it will show up in the list returned by: virConnectListDefinedDomains but not in the list virConnectListDomains Conversely, if it is started... it will only be in the list: virConnectListDomains not in the list virConnectListDefinedDomains Is that correct? -- bk

4 3

Re: [libvirt] Segfault in event-test.c example
by pspreadborough＠comcast.net 11 Jan '10

11 Jan '10

----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > 2010/1/10 <pspreadborough(a)comcast.net>: > > > > ----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > > > >> 2010/1/10 <pspreadborough(a)comcast.net>: > >> > > >> > Hello, > >> > > >> > I have been trying to use the domain event C code example but > >> > unfortunately it segfaults (signal 11) every time I run it: > >> > > >> > [root@Spring events-c]# ./event-test > >> > myEventAddHandleFunc:221: Add handle 5 1 0xf081a0 0x8f727f8 > >> > myEventAddHandleFunc:221: Add handle 7 1 0xf09990 0x8f727f8 > >> > myEventAddHandleFunc:221: Add handle 8 1 0xed7940 0x8f727f8 > >> > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 > >> > myEventAddHandleFunc:221: Add handle 11 1 0xed7940 0x8f727f8 > >> > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 > >> > main:322 :: Registering domain event cbs > >> > Segmentation fault (core dumped) > >> > > >> > Core was generated by > >> > > >> `/root/libvirt-0.7.5/examples/domain-events/events-c/.libs/lt-event-test'. > >> > Program terminated with signal 11, Segmentation fault. > >> > [New process 21806] > >> > [New process 21822] > >> > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at > >> > remote/remote_driver.c:8720 > >> > 8720 tempQueue.count = priv->domainEvents->count; > >> > (gdb) bt > >> > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at > >> > remote/remote_driver.c:8720 > >> > #1 0x080490d3 in main (argc=Cannot access memory at address 0x1 > >> > ) at event-test.c:347 > >> > > >> > The stack looks corrupted so I'm doubtful that this trace if of much > >> value. > >> > I have built > >> > and installed libvirt-0.7.5 and it and it's tools seem to be > >> operating > >> > correctly. > >> > >> I tried the event-test with libvirt-0.7.5 and QEMU/Xen and both are > >> working as expected. No segfaults. > >> > >> Could you inspect the values of priv and priv->domainEvents in GDB > >> using 'p priv' to see if they are NULL and try to dereference them in > >> GDB using 'p *priv' to see if they point to valid memory areas? > >> > >> Yes the backtrace looks corrupted. If there is stack/heap corruption > >> involved valgrind may reveal it, so try to run the event-test in > >> valgrind and see if that gives any hints. > >> > >> You can also try the GIT version of libvirt. There was a invalid free > >> call (resulting in heap corruption) in the node device code fixed > >> after the 0.7.5 release. But that should have no effect on the > >> event-test. > >> > >> Matthias > > > > Matthias, > > > > priv->domainEvents is NULL, here's the gdb output: > > This explains the segfault. The next question is, why is it NULL? > > > (gdb) p *priv > > $1 = {lock = {lock = {__data = {__lock = 1, __count = 0, __owner = 21806, __kind = 0, __nusers = 1, {__spins = 0, __list = { > > __next = 0x0}}}, __size = "\001\000\000\000\000\000\000\000.U\000\000\000\000\000\000\001\000\000\000\000\000\000", > > __align = 1}}, sock = 150469168, watch = 3, pid = 4, uses_tls = 1982791681, is_secure = 1815048801, session = 0x782f6269, > > Seeing uses_tls and is_secure being large numbers and knowing that > both are used as boolean values in the code and should have values of > 0 or 1 make me think that priv points to already freed memory here. > > > type = 0x2f646e65 <Address 0x2f646e65 out of bounds>, counter = 1684956536, localUses = 1668248365, > > hostname = 0x74656b <Address 0x74656b out of bounds>, debugLog = 0x0, saslconn = 0x0, saslDecoded = 0x0, saslDecodedLength = 0, > > type and hostname are char pointers, but the seem to point into > nowhere, confirms that this is either freed memory or priv itself got > overwritten due to heap corruption. > > > saslDecodedOffset = 0, saslEncoded = 0x0, saslEncodedLength = 0, saslEncodedOffset = 0, > > buffer = '\0' <repeats 68 times>, "n\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\bQ�\b��\030\034�\b\000\000\000\000�\033�\b\001\000\000\000\002\000\000\000�\033�\b\000\000\000\000\025|�\000\a", '\0' <repeats 11 times>, "X\000�\b", '\0' <repeats 12 times>, "\021\000\000\000\002\000\000\000P��\b\000\000\000\000\021", '\0' <repeats 15 times>, "\021\000\000\0008\036�\b\f\000\000\000\020\000\000\000\021\000\000\000\a\000\000\000\b\000\000\000\t\000\000\000\021\000\000\000\002\000\000\000\230\034�\b\000\000\000\000A\000\000\000\003\000\000\000\001\000\000\000\001\000"..., bufferLength = 0, > > bufferOffset = 0, callbackList = 0x0, domainEvents = 0x0, eventFlushTimer = 0, domainEventDispatching = 1, wakeupSendFD = 0, > > wakeupReadFD = 0, waitDispatch = 0x0, streams = 0x0} > > > > I'll try a run with valgrind and post the results. > > > > Pete > > > > Could you test the Python version of this example found in > examples/domain-events/events-python/event-test.py? Does this work? > > Otherwise lets see if valgrind gives any hints. > > Matthias > Matthias, I have built the latest git image and run it through valgrind, here's the valgrind output: [root@Spring .libs]# valgrind -v ./event-test xen:/// ==19881== Memcheck, a memory error detector. ==19881== Copyright (C) 2002-2006, and GNU GPL'd, by Julian Seward et al. ==19881== Using LibVEX rev 1658, a library for dynamic binary translation. ==19881== Copyright (C) 2004-2006, and GNU GPL'd, by OpenWorks LLP. ==19881== Using valgrind-3.2.1, a dynamic binary instrumentation framework. ==19881== Copyright (C) 2000-2006, and GNU GPL'd, by Julian Seward et al. ==19881== --19881-- Command line --19881-- ./event-test --19881-- xen:/// --19881-- Startup, with flags: --19881-- -v --19881-- Contents of /proc/version: --19881-- Linux version 2.6.18-164.10.1.el5xen (mockbuild(a)builder16.centos.org) (gcc version 4.1.2 20080704 (Red Hat 4.1.2-46)) #1 SMP Thu Jan 7 21:14:48 EST 2010 --19881-- Arch and hwcaps: X86, x86-sse1-sse2 --19881-- Valgrind library directory: /usr/lib/valgrind --19881-- Reading syms from /lib/ld-2.5.so (0x163000) --19881-- Reading syms from /root/libvirt/libvirt/examples/domain-events/events-c/.libs/event-test (0x8048000) --19881-- Reading syms from /usr/lib/valgrind/x86-linux/memcheck (0x38000000) --19881-- object doesn't have a dynamic symbol table --19881-- Reading suppressions file: /usr/lib/valgrind/default.supp --19881-- REDIR: 0x178790 (index) redirected to 0x38027D0F (vgPlain_x86_linux_REDIR_FOR_index) --19881-- Reading syms from /usr/lib/valgrind/x86-linux/vgpreload_core.so (0x4001000) --19881-- Reading syms from /usr/lib/valgrind/x86-linux/vgpreload_memcheck.so (0x4003000) ==19881== WARNING: new redirection conflicts with existing -- ignoring it --19881-- new: 0x00178790 (index ) R-> 0x04006080 index --19881-- REDIR: 0x178930 (strlen) redirected to 0x4006250 (strlen) --19881-- Reading syms from /usr/local/lib/libvirt.so.0.7.5 (0x4009000) --19881-- Reading syms from /usr/lib/libxml2.so.2.6.26 (0x6254000) --19881-- object doesn't have a symbol table --19881-- Reading syms from /usr/lib/libz.so.1.2.3 (0xCD2000) --19881-- object doesn't have a symbol table --19881-- Reading syms from /lib/libm-2.5.so (0x413B000) --19881-- Reading syms from /usr/lib/libgnutls.so.13.0.6 (0x670D000) --19881-- object doesn't have a symbol table --19881-- Reading syms from /usr/lib/libgcrypt.so.11.5.2 (0x6590000) --19881-- object doesn't have a symbol table --19881-- Reading syms from /usr/lib/libsasl2.so.2.0.22 (0x6536000) --19881-- object doesn't have a symbol table --19881-- Reading syms from /usr/lib/libxenstore.so.3.0.0 (0x4162000) --19881-- object doesn't have a symbol table --19881-- Reading syms from /lib/libpthread-2.5.so (0x416A000) --19881-- Reading syms from /lib/libc-2.5.so (0x4183000) --19881-- Reading syms from /lib/libdl-2.5.so (0xCA7000) --19881-- Reading syms from /usr/lib/libgpg-error.so.0.3.0 (0xB28000) --19881-- object doesn't have a symbol table --19881-- Reading syms from /lib/libresolv-2.5.so (0x26E000) --19881-- Reading syms from /lib/libcrypt-2.5.so (0x64CE000) --19881-- REDIR: 0x41F42D0 (memset) redirected to 0x4006540 (memset) --19881-- REDIR: 0x41F47C0 (memcpy) redirected to 0x4006C20 (memcpy) --19881-- REDIR: 0x41F3430 (rindex) redirected to 0x4005F60 (rindex) --19881-- REDIR: 0x41F3090 (strlen) redirected to 0x4006230 (strlen) --19881-- REDIR: 0x41EED20 (malloc) redirected to 0x400533B (malloc) --19881-- REDIR: 0x41F2B30 (strcmp) redirected to 0x4006300 (strcmp) --19881-- REDIR: 0x41EE9E0 (calloc) redirected to 0x4004668 (calloc) --19881-- REDIR: 0x41F3DD0 (memchr) redirected to 0x4006420 (memchr) --19881-- REDIR: 0x41EC980 (free) redirected to 0x4004F55 (free) --19881-- REDIR: 0x41EF190 (realloc) redirected to 0x40053EA (realloc) ==19881== Warning: noted but unhandled ioctl 0x305000 with no size/direction hints ==19881== This could cause spurious value errors to appear. ==19881== See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing a proper wrapper. ==19881== Warning: noted but unhandled ioctl 0x305000 with no size/direction hints ==19881== This could cause spurious value errors to appear. ==19881== See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing a proper wrapper. ==19881== Warning: noted but unhandled ioctl 0x305000 with no size/direction hints ==19881== This could cause spurious value errors to appear. ==19881== See README_MISSING_SYSCALL_OR_IOCTL for guidance on writing a proper wrapper. --19881-- REDIR: 0x41F29C0 (index) redirected to 0x4006050 (index) --19881-- REDIR: 0x41F3280 (strncmp) redirected to 0x4006290 (strncmp) --19881-- REDIR: 0x41F44C0 (stpcpy) redirected to 0x40068D0 (stpcpy) --19881-- REDIR: 0x41F3140 (strnlen) redirected to 0x4006200 (strnlen) --19881-- REDIR: 0x41F3380 (strncpy) redirected to 0x4006DA0 (strncpy) --19881-- REDIR: 0x41F2BA0 (strcpy) redirected to 0x40069B0 (strcpy) myEventAddHandleFunc:221: Add handle 5 1 0x40ad4a0 0x42d6188 myEventAddHandleFunc:221: Add handle 7 1 0x40aec90 0x42d6188 Allocating domainEvents:0x43bea68 myEventAddHandleFunc:221: Add handle 8 1 0x407c940 0x42d6188 myEventAddTimeoutFunc:251: Adding Timeout -1 0x4083fe0 0x42d6188 Allocating domainEvents:0x4e8c320 myEventAddHandleFunc:221: Add handle 11 1 0x407c940 0x42d6188 myEventAddTimeoutFunc:251: Adding Timeout -1 0x4083fe0 0x42d6188 main:322 :: Registering domain event cbs poll ==19881== Invalid read of size 4 ==19881== at 0x4084011: remoteDomainEventQueueFlush (remote_driver.c:8722) ==19881== by 0x80490C2: main (event-test.c:341) ==19881== Address 0x0 is not stack'd, malloc'd or (recently) free'd ==19881== ==19881== Process terminating with default action of signal 11 (SIGSEGV) ==19881== Access not within mapped region at address 0x0 ==19881== at 0x4084011: remoteDomainEventQueueFlush (remote_driver.c:8722) ==19881== by 0x80490C2: main (event-test.c:341) ==19881== ==19881== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 30 from 1) ==19881== ==19881== 1 errors in context 1 of 1: ==19881== Invalid read of size 4 ==19881== at 0x4084011: remoteDomainEventQueueFlush (remote_driver.c:8722) ==19881== by 0x80490C2: main (event-test.c:341) ==19881== Address 0x0 is not stack'd, malloc'd or (recently) free'd --19881-- --19881-- supp: 30 Fedora-Core-6-hack3-ld25 ==19881== ==19881== IN SUMMARY: 1 errors from 1 contexts (suppressed: 30 from 1) ==19881== ==19881== malloc/free: in use at exit: 590,340 bytes in 686 blocks. ==19881== malloc/free: 1,695 allocs, 1,009 frees, 1,700,423 bytes allocated. ==19881== ==19881== searching for pointers to 686 not-freed blocks. ==19881== checked 11,495,892 bytes. ==19881== ==19881== LEAK SUMMARY: ==19881== definitely lost: 0 bytes in 0 blocks. ==19881== possibly lost: 136 bytes in 1 blocks. ==19881== still reachable: 590,204 bytes in 685 blocks. ==19881== suppressed: 0 bytes in 0 blocks. ==19881== Reachable blocks (those to which a pointer was found) are not shown. ==19881== To see them, rerun with: --show-reachable=yes --19881-- memcheck: sanity checks: 3 cheap, 1 expensive --19881-- memcheck: auxmaps: 0 auxmap entries (0k, 0M) in use --19881-- memcheck: auxmaps: 0 searches, 0 comparisons --19881-- memcheck: SMs: n_issued = 36 (576k, 0M) --19881-- memcheck: SMs: n_deissued = 0 (0k, 0M) --19881-- memcheck: SMs: max_noaccess = 65535 (1048560k, 1023M) --19881-- memcheck: SMs: max_undefined = 0 (0k, 0M) --19881-- memcheck: SMs: max_defined = 244 (3904k, 3M) --19881-- memcheck: SMs: max_non_DSM = 36 (576k, 0M) --19881-- memcheck: max sec V bit nodes: 115 (5k, 0M) --19881-- memcheck: set_sec_vbits8 calls: 679 (new: 115, updates: 564) --19881-- memcheck: max shadow mem size: 885k, 0M --19881-- translate: fast SP updates identified: 7,064 ( 89.2%) --19881-- translate: generic_known SP updates identified: 543 ( 6.8%) --19881-- translate: generic_unknown SP updates identified: 304 ( 3.8%) --19881-- tt/tc: 13,590 tt lookups requiring 14,331 probes --19881-- tt/tc: 13,590 fast-cache updates, 3 flushes --19881-- transtab: new 6,511 (139,232 -> 2,275,366; ratio 163:10) [0 scs] --19881-- transtab: dumped 0 (0 -> ??) --19881-- transtab: discarded 8 (187 -> ??) --19881-- scheduler: 374,982 jumps (bb entries). --19881-- scheduler: 3/10,454 major/minor sched events. --19881-- sanity: 4 cheap, 1 expensive checks. --19881-- exectx: 30,011 lists, 566 contexts (avg 0 per list) --19881-- exectx: 2,732 searches, 2,171 full compares (794 per 1000) --19881-- exectx: 0 cmp2, 67 cmp4, 0 cmpAll Killed [root@Spring .libs]# I tried the python version and did have some success, but not 100% since I didn't see events for pausing the VM: [root@Spring events-python]# python event-test.py xen:/// Using uri:xen:/// myDomainEventCallback2 EVENT: Domain vm-full-1(1) Started 0 myDomainEventCallback1 EVENT: Domain vm-full-1(1) Started 0 I noticed that the the C version looks in one place for the libvirt socket and the python version in a different place, I don't know if this is significant or not? I tweaked the /etc/libvirt/libvirtd.conf file to alter the location. C: /usr/local/var/run/libvirt python: /var/run/libvirt/ Regards, Pete

2 2

[libvirt] [PATCH] Only use pseudo-random generator for uuid if using /dev/random fails.
by Laine Stump 11 Jan '10

11 Jan '10

The original code. would only print the warning message if using /dev/random failed, but would still go ahead and call virUUIDGeneratePseudoRandomBytes in all cases anyway. --- src/util/uuid.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/uuid.c b/src/util/uuid.c index 002a64d..846581c 100644 --- a/src/util/uuid.c +++ b/src/util/uuid.c @@ -104,9 +104,9 @@ virUUIDGenerate(unsigned char *uuid) VIR_WARN(_("Falling back to pseudorandom UUID," " failed to generate random bytes: %s"), virStrerror(err, ebuf, sizeof ebuf)); + err = virUUIDGeneratePseudoRandomBytes(uuid, VIR_UUID_BUFLEN); } - - return virUUIDGeneratePseudoRandomBytes(uuid, VIR_UUID_BUFLEN); + return err; } /* Convert C from hexadecimal character to integer. */ -- 1.6.6

2 1

[libvirt] LXC: init problem
by Robin Green 11 Jan '10

11 Jan '10

I'm trying to install Exherbo Linux in an LXC container using libvirt. I've basically succeeded, in that I can "virsh console" in and start sshd, but I haven't managed to boot it starting from /sbin/init rather than /bin/bash. If I have the following (I probably should have modified the uuid and the mac address from the standard example, but that's not relevant): <domain type='lxc'> <name>exherbo</name> <uuid>a4047015-171c-ae56-bc1e-57102d4b86bf</uuid> <memory>1000000</memory> <currentMemory>1000000</currentMemory> <vcpu>2</vcpu> <os> <type arch='i686'>exe</type> <init>/sbin/init</init> </os> <clock offset='utc'/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/libexec/libvirt_lxc</emulator> <filesystem type='mount'> <source dir='/home/greenrd/exherbo'/> <target dir='/'/> </filesystem> <interface type='network'> <mac address='52:54:00:56:64:42'/> <source network='default'/> <target dev='veth0'/> </interface> <console type='pty'> <target port='0'/> </console> </devices> </domain> and do virsh --connect lxc:/// start exherbo && virsh --connect lxc:/// console exherbo nothing appears - then if I press Enter, the container dies. In pstree all I see that's relevant is: ├─libvirt_lxc───libvirt_lxc so it looks like init dies. If I run init in gdb in the container I just get: Starting program: /sbin/init Usage: init 0123456SsQqAaBbCcUu Program exited with code 01. so I suppose it could be wanting a runlevel as argument. I'm guessing though that /sbin/init is running in a different mode - telinit mode - as its PID is not 1. Is there any way to get an instant console from the virsh start command, so I can see what's going on? -- Robin

1 0

[libvirt] Re: [virt-tools-list] Questions about virt-manager running on Arch of Itanium 64
by Cole Robinson 11 Jan '10

11 Jan '10

cc-ing libvirt-list On 11/19/2009 10:35 PM, Dustin Xiong wrote: > > >>> Hi everyone! >>> I am a newer to the virt-manager and maillist. I sent the mail just want >>> to ask some questions about virt-manager running on Arch of Itanium 64. >>> My itanium 64 cpu actualy support the VT. I compiled the kvm85 >>> successful. Then I can use the binary /usr/local/bin/qemu-system-ia64 to >>> create a vm and running. But in my /proc/cpuinfo , there doesn't have >>> flags such as vmx or svm. So when I use the virt-manager to install a >>> vm, the virt-manager will tell me my cpu doesn't support fully >>> virtualization, then I can't install vm. In fact I can't get understand >>> how the virt-manager find my cpu support the fully virtualization or >>> not.In src, which file implements this. >>> >> >> Just because qemu-kvm works doesn't mean virt is working on your box, since it >> can fall back to full emulation mode. If you are trying to use kvm, is the kvm >> module actually loaded? lsmod | grep kvm > > My kvm mod actually loaded. > > [root@kvm bin]# lsmod | grep kvm > > kvm_intel 306104 4294967281 > > kvm 327544 1 kvm_intel > > > > [root@kvm bin]# modinfo kvm > > filename: /lib/modules/2.6.28.9hzp/extra/kvm.ko > > license: GPL > > author: Qumranet > > version: kvm-85 > > srcversion: C399DD2D9B40BAAC05CD509 > > depends: > > vermagic: 2.6.28.9hzp SMP mod_unload modversions ia64gcc-4.1 > >> If so, libvirt may need to be fixed. What's the output of 'virsh --connect >> qemu:///system capabilities' > > [root@kvm bin]# virsh --connect qemu:///system capabilities > <capabilities> > > <host> > <cpu> > <arch>ia64</arch> > </cpu> > <topology> > <cells num='1'> > <cell id='0'> > <cpus num='16'> > <cpu id='0'/> > <cpu id='1'/> > <cpu id='2'/> > <cpu id='3'/> > <cpu id='4'/> > <cpu id='5'/> > <cpu id='6'/> > <cpu id='7'/> > <cpu id='8'/> > <cpu id='9'/> > <cpu id='10'/> > <cpu id='11'/> > <cpu id='12'/> > <cpu id='13'/> > <cpu id='14'/> > <cpu id='15'/> > </cpus> > </cell> > </cells> > </topology> > </host> > > >>> My cpu is itanium 64, the OS is RHEL.The libvirt is 0.6.3, virt-manager >>> is 0.6.1. Ah, are you using the version of libvirt that comes with RHEL 5.4? That version has been patched to only look for the qemu-kvm binary in one spot: /usr/libexec/qemu-kvm IIRC. You could try to work with that, but since you are already building upstream KVM, virt-manager, and virtinst, might not be a bad idea to pull upstream libvirt as well. >>> Once i tried to compile the virt-manager-0.8.0, but when i make check, >>> it returns: >>> >>> PYTHONPATH=./..:../graphWidgets/.libs python addhardware.py && touch >>> .tstamp.addhardware.py >>> Traceback (mos! t recent call last): >>> File "addhardware.py", line 32, in ? >>> from virtinst import VirtualCharDevice, VirtualDevice, >>> VirtualVideoDevice >>> >>> when i rpm -ivh virt-manager-0.6.1-8.el5.ia64.rpm, it could work. >>> >>> I don't know why this error occur. Can anyone be kind to tell me how? >>> thanks a lot. >>> >> >> You will also need to install the latest version of virtinst, found at: >> >> http://virt-manager.org/download.html > > I downloaded and compiled the latest version of virtinst: virtinst-0.500.0.tar.gz. > then compile the virt-manager-0.8.0, error changed as below: > > [root@kvm virt-manager-0.8.0]# make check > Making check in src > make[1]: Entering directory `/home/dustin/virt-manager/virt-manager-0.8.0/src' > Making check in virtManager > make[2]: Entering directory `/home/dustin/virt-manager/virt-manager-0.8.0/src/virtManager' > make check-local > make[3]: Entering directory `/home/dustin/virt-manager/virt-manager-0.8.0/src/virtManager' > PYTHONPATH=./..:../graphWidgets/.libs python about.py && touch .tstamp.about.py > PYTHONPATH=./..:../graphWidgets/.libs python addhardware.py && touch .tstamp.addhardware.py > Traceback (most recent call last): > File "addhardware.py", line 35, in ? > from virtManager.asyncjob import vmmAsyncJob > File "/home/dustin/virt-manager/virt-manager-0.8.0/src/virtManager/asyncjob.py", line 30, in ? > class vmmAsyncJob(gobject.GObject): > File "/home/dustin/virt-manager/virt-manager-0.8.0/src/virtManager/asyncjob.py", line 40, in vmmAsyncJob > def __init__(self, config, callback, args=None, > NameError: name '_' is not defined > > Thanks for help.If you need any further infos please dont't hesitate to tell me. > Ah, didn't notice the make check in the first mail. 'make check' doesn't work in the virt-manager code base, never taken the time to fix it. You should just be able to 'make && make install', or 'make' and python src/virt-manager.py to run from the source dir. If running virt-manager then throws an error, report here and Ill try to help. - Cole

3 15

Re: [libvirt] Segfault in event-test.c example
by pspreadborough＠comcast.net 11 Jan '10

11 Jan '10

----- "Matthias Bolte" <matthias.bolte(a)googlemail.com> wrote: > 2010/1/10 <pspreadborough(a)comcast.net>: > > > > Hello, > > > > I have been trying to use the domain event C code example but > > unfortunately it segfaults (signal 11) every time I run it: > > > > [root@Spring events-c]# ./event-test > > myEventAddHandleFunc:221: Add handle 5 1 0xf081a0 0x8f727f8 > > myEventAddHandleFunc:221: Add handle 7 1 0xf09990 0x8f727f8 > > myEventAddHandleFunc:221: Add handle 8 1 0xed7940 0x8f727f8 > > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 > > myEventAddHandleFunc:221: Add handle 11 1 0xed7940 0x8f727f8 > > myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 > > main:322 :: Registering domain event cbs > > Segmentation fault (core dumped) > > > > Core was generated by > > > `/root/libvirt-0.7.5/examples/domain-events/events-c/.libs/lt-event-test'. > > Program terminated with signal 11, Segmentation fault. > > [New process 21806] > > [New process 21822] > > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at > > remote/remote_driver.c:8720 > > 8720 tempQueue.count = priv->domainEvents->count; > > (gdb) bt > > #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at > > remote/remote_driver.c:8720 > > #1 0x080490d3 in main (argc=Cannot access memory at address 0x1 > > ) at event-test.c:347 > > > > The stack looks corrupted so I'm doubtful that this trace if of much > value. > > I have built > > and installed libvirt-0.7.5 and it and it's tools seem to be > operating > > correctly. > > I tried the event-test with libvirt-0.7.5 and QEMU/Xen and both are > working as expected. No segfaults. > > Could you inspect the values of priv and priv->domainEvents in GDB > using 'p priv' to see if they are NULL and try to dereference them in > GDB using 'p *priv' to see if they point to valid memory areas? > > Yes the backtrace looks corrupted. If there is stack/heap corruption > involved valgrind may reveal it, so try to run the event-test in > valgrind and see if that gives any hints. > > You can also try the GIT version of libvirt. There was a invalid free > call (resulting in heap corruption) in the node device code fixed > after the 0.7.5 release. But that should have no effect on the > event-test. > > Matthias Matthias, priv->domainEvents is NULL, here's the gdb output: (gdb) p *priv $1 = {lock = {lock = {__data = {__lock = 1, __count = 0, __owner = 21806, __kind = 0, __nusers = 1, {__spins = 0, __list = { __next = 0x0}}}, __size = "\001\000\000\000\000\000\000\000.U\000\000\000\000\000\000\001\000\000\000\000\000\000", __align = 1}}, sock = 150469168, watch = 3, pid = 4, uses_tls = 1982791681, is_secure = 1815048801, session = 0x782f6269, type = 0x2f646e65 <Address 0x2f646e65 out of bounds>, counter = 1684956536, localUses = 1668248365, hostname = 0x74656b <Address 0x74656b out of bounds>, debugLog = 0x0, saslconn = 0x0, saslDecoded = 0x0, saslDecodedLength = 0, saslDecodedOffset = 0, saslEncoded = 0x0, saslEncodedLength = 0, saslEncodedOffset = 0, buffer = '\0' <repeats 68 times>, "n\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\001\000\000\000\000\000\000\000\001\000\000\000\bQ�\b��\030\034�\b\000\000\000\000�\033�\b\001\000\000\000\002\000\000\000�\033�\b\000\000\000\000\025|�\000\a", '\0' <repeats 11 times>, "X\000�\b", '\0' <repeats 12 times>, "\021\000\000\000\002\000\000\000P��\b\000\000\000\000\021", '\0' <repeats 15 times>, "\021\000\000\0008\036�\b\f\000\000\000\020\000\000\000\021\000\000\000\a\000\000\000\b\000\000\000\t\000\000\000\021\000\000\000\002\000\000\000\230\034�\b\000\000\000\000A\000\000\000\003\000\000\000\001\000\000\000\001\000"..., bufferLength = 0, bufferOffset = 0, callbackList = 0x0, domainEvents = 0x0, eventFlushTimer = 0, domainEventDispatching = 1, wakeupSendFD = 0, wakeupReadFD = 0, waitDispatch = 0x0, streams = 0x0} I'll try a run with valgrind and post the results. Pete

2 1

[libvirt] Segfault in event-test.c example
by pspreadborough＠comcast.net 10 Jan '10

10 Jan '10

Hello, I have been trying to use the domain event C code example but unfortunately it segfaults (signal 11) every time I run it: [root@Spring events-c]# ./event-test myEventAddHandleFunc:221: Add handle 5 1 0xf081a0 0x8f727f8 myEventAddHandleFunc:221: Add handle 7 1 0xf09990 0x8f727f8 myEventAddHandleFunc:221: Add handle 8 1 0xed7940 0x8f727f8 myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 myEventAddHandleFunc:221: Add handle 11 1 0xed7940 0x8f727f8 myEventAddTimeoutFunc:251: Adding Timeout -1 0xedefa0 0x8f727f8 main:322 :: Registering domain event cbs Segmentation fault (core dumped) Core was generated by `/root/libvirt-0.7.5/examples/domain-events/events-c/.libs/lt-event-test'. Program terminated with signal 11, Segmentation fault. [New process 21806] [New process 21822] #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at remote/remote_driver.c:8720 8720 tempQueue.count = priv->domainEvents->count; (gdb) bt #0 remoteDomainEventQueueFlush (timer=-1, opaque=0x8f727f8) at remote/remote_driver.c:8720 #1 0x080490d3 in main (argc=Cannot access memory at address 0x1 ) at event-test.c:347 The stack looks corrupted so I'm doubtful that this trace if of much value. I have built and installed libvirt-0.7.5 and it and it's tools seem to be operating correctly. My setup is: Intel(R) Pentium(R) 4 CPU 3.00GHz Linux 2.6.18-164.10.1.el5xen #1 SMP Thu Jan 7 21:14:48 EST 2010 i686 i686 i386 GNU/Linux virsh # version Compiled against library: libvir 0.7.5 Using library: libvir 0.7.5 Using API: Xen 3.0.1 Running hypervisor: Xen 3.4.0 I have a project that requires Domain events so I'd very much like to use this code so any help would be appreciated. Regards, Pete

2 1

[libvirt] [PATCH] avoid another "make distcheck" failure
by Jim Meyering 09 Jan '10

09 Jan '10

"make uninstall" would fail rm: cannot remove `/home/j/w/co/libvirt/libvirt-0.7.5/_inst/share/gtk-doc/html\ /libvirtdevhelp/libvirt.devhelp': No such file or directory rm: cannot remove `/home/j/w/co/libvirt/libvirt-0.7.5/_inst/share/gtk-doc/html\ /libvirtdevhelp/index.html': No such file or directory There are two problems: first, "libvirtdevhelp" is not a valid dir name. Inserting a slash fixes that. Second, that "devhelp/" does not belong at all. It comes from each value of $$f. Using basename fixes that: With this, "make distcheck" passes once again. Pushed. >From 0418fa2e7265d6cf938f2172a0aeb9f9d7a93022 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Sat, 9 Jan 2010 09:56:20 +0100 Subject: [PATCH] avoid another "make distcheck" failure * docs/Makefile.am (uninstall-local): Separate $$f from preceding dir name with a "/" and use $$(basename $$f) rather than $$f, since some values of $$f are prefixed with devhelp/. --- docs/Makefile.am | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index d53f305..c19e963 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -159,4 +159,5 @@ uninstall-local: for h in $(apihtml); do rm $(DESTDIR)$(HTML_DIR)/$$h; done for p in $(apipng); do rm $(DESTDIR)$(HTML_DIR)/$$p; done for f in $(devhelphtml) $(devhelppng) $(devhelpcss); do \ - rm $(DESTDIR)$(DEVHELP_DIR)$$f ; done + rm $(DESTDIR)$(DEVHELP_DIR)/$$(basename $$f); \ + done -- 1.6.6.439.gaf68f

1 0

[libvirt] [PATCH] fix 7 "make check" test failures in non-srcdir build
by Jim Meyering 09 Jan '10

09 Jan '10

FYI, I've already pushed this. When I ran "make distcheck" (or just a non-srcdir "make check"), I'd get 7 failures. These were introduced by a change back in October. >From e6abf3d8f2a60249955c4d59e7b994a99faf8ace Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Sat, 9 Jan 2010 08:37:22 +0100 Subject: [PATCH] fix 7 "make check" test failures in non-srcdir build * tests/capabilityschematest: Define and use $srcdir. * tests/domainschematest: Likewise. * tests/interfaceschematest: Likewise. * tests/networkschematest: Likewise. * tests/nodedevschematest: Likewise. * tests/storagepoolschematest: Likewise. * tests/storagevolschematest: Likewise. --- tests/capabilityschematest | 3 ++- tests/domainschematest | 3 ++- tests/interfaceschematest | 3 ++- tests/networkschematest | 3 ++- tests/nodedevschematest | 3 ++- tests/storagepoolschematest | 3 ++- tests/storagevolschematest | 3 ++- 7 files changed, 14 insertions(+), 7 deletions(-) diff --git a/tests/capabilityschematest b/tests/capabilityschematest index 3a1acc5..482dfe3 100755 --- a/tests/capabilityschematest +++ b/tests/capabilityschematest @@ -1,6 +1,7 @@ #!/bin/sh -. ./schematestutils.sh +: ${srcdir=.} +. $srcdir/schematestutils.sh DIRS="capabilityschemadata xencapsdata" SCHEMA="capability.rng" diff --git a/tests/domainschematest b/tests/domainschematest index 28ee69a..27a93cf 100755 --- a/tests/domainschematest +++ b/tests/domainschematest @@ -1,6 +1,7 @@ #!/bin/sh -. ./schematestutils.sh +: ${srcdir=.} +. $srcdir/schematestutils.sh DIRS="domainschemadata qemuxml2argvdata sexpr2xmldata xmconfigdata xml2sexprdata" SCHEMA="domain.rng" diff --git a/tests/interfaceschematest b/tests/interfaceschematest index e9ec2a4..8e9f6ee 100755 --- a/tests/interfaceschematest +++ b/tests/interfaceschematest @@ -1,6 +1,7 @@ #!/bin/sh -. ./schematestutils.sh +: ${srcdir=.} +. $srcdir/schematestutils.sh DIRS="interfaceschemadata" SCHEMA="interface.rng" diff --git a/tests/networkschematest b/tests/networkschematest index 01b2e6f..7210055 100755 --- a/tests/networkschematest +++ b/tests/networkschematest @@ -1,6 +1,7 @@ #!/bin/sh -. ./schematestutils.sh +: ${srcdir=.} +. $srcdir/schematestutils.sh DIRS="../src/network networkxml2xmlin networkxml2xmlout" SCHEMA="network.rng" diff --git a/tests/nodedevschematest b/tests/nodedevschematest index 2f0e2b9..3f0f03f 100755 --- a/tests/nodedevschematest +++ b/tests/nodedevschematest @@ -1,6 +1,7 @@ #!/bin/sh -. ./schematestutils.sh +: ${srcdir=.} +. $srcdir/schematestutils.sh DIRS="nodedevschemadata" SCHEMA="nodedev.rng" diff --git a/tests/storagepoolschematest b/tests/storagepoolschematest index 57b2f7b..9aef382 100755 --- a/tests/storagepoolschematest +++ b/tests/storagepoolschematest @@ -1,6 +1,7 @@ #!/bin/sh -. ./schematestutils.sh +: ${srcdir=.} +. $srcdir/schematestutils.sh DIRS="storagepoolxml2xmlin storagepoolxml2xmlout" SCHEMA="storagepool.rng" diff --git a/tests/storagevolschematest b/tests/storagevolschematest index 32a8657..74b6203 100755 --- a/tests/storagevolschematest +++ b/tests/storagevolschematest @@ -1,6 +1,7 @@ #!/bin/sh -. ./schematestutils.sh +: ${srcdir=.} +. $srcdir/schematestutils.sh DIRS="storagevolxml2xmlin storagevolxml2xmlout" SCHEMA="storagevol.rng" -- 1.6.6.439.gaf68f

1 0

[libvirt] [PATCH] avoid newly-introduced test failure
by Jim Meyering 09 Jan '10

09 Jan '10

I ran "make check" and was surprised to see a failure: 10) QEMU XML-2-ARGV hugepages ... FAILED ... FAIL: qemuxml2argvtest Introduced just a couple days ago. Here's the fix: >From a4e9edbd77f428782293b9672098b6d3c80b2879 Mon Sep 17 00:00:00 2001 From: Jim Meyering <meyering(a)redhat.com> Date: Sat, 9 Jan 2010 09:25:04 +0100 Subject: [PATCH] avoid newly-introduced test failure * tests/qemuxml2argvdata/qemuxml2argv-hugepages.args: Update expected output to match, now that we use -mem-prealloc. --- tests/qemuxml2argvdata/qemuxml2argv-hugepages.args | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args b/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args index f10a40e..1e2632a 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-hugepages.args @@ -1 +1 @@ -LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -mem-path /dev/hugepages/libvirt/qemu -smp 1 -nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb +LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test /usr/bin/qemu -S -M pc -m 214 -mem-prealloc -mem-path /dev/hugepages/libvirt/qemu -smp 1 -nographic -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -hda /dev/HostVG/QEMUGuest1 -net none -serial none -parallel none -usb -- 1.6.6.439.gaf68f In case you can't read the above, note that all the change does is to insert "-mem-prealloc " before "-mem-path" I'm about to push this, now.

1 0