- Devel - libvirt List Archives

[libvirt] [PATCH 0/4] support for changing cpu.shares for inactive domains from virsh cmd
by Hu Tao 06 May '11

06 May '11

Currently cpu.shares can only be configured by editing domains' xmls. this series enables us to change cpu.shares from virsh cmd schedinfo even when domain is inactive. Hu Tao (4): introduce virDomainSetSchedulerParametersFlags qemu: introduce qemuSetSchedulerParametersFlags remote: introduce remoteSetSchedulerParametersFlags virsh: add --persistent to cmd schedinfo daemon/remote.c | 71 +++++++++++++++++++++++++++++++++++ daemon/remote_dispatch_args.h | 1 + daemon/remote_dispatch_prototypes.h | 8 ++++ daemon/remote_dispatch_table.h | 5 ++ include/libvirt/libvirt.h.in | 13 ++++++ python/generator.py | 1 + src/driver.h | 8 ++++ src/esx/esx_driver.c | 1 + src/libvirt.c | 62 ++++++++++++++++++++++++++++++ src/libvirt_public.syms | 5 ++ src/libxl/libxl_driver.c | 1 + src/lxc/lxc_driver.c | 1 + src/openvz/openvz_driver.c | 1 + src/phyp/phyp_driver.c | 1 + src/qemu/qemu_driver.c | 66 +++++++++++++++++++++++++------- src/remote/remote_driver.c | 69 ++++++++++++++++++++++++++++++++++ src/remote/remote_protocol.c | 15 +++++++ src/remote/remote_protocol.h | 12 ++++++ src/remote/remote_protocol.x | 10 ++++- src/test/test_driver.c | 1 + src/uml/uml_driver.c | 1 + src/vbox/vbox_tmpl.c | 1 + src/vmware/vmware_driver.c | 1 + src/xen/xen_driver.c | 1 + src/xenapi/xenapi_driver.c | 1 + tools/virsh.c | 14 ++++++- 26 files changed, 354 insertions(+), 17 deletions(-) -- 1.7.3.1 -- Thanks, Hu Tao

1 4

[libvirt] [PATCH] virsh: improve TLS certificate error messages
by Doug Goldstein 05 May '11

05 May '11

Print the name of the CA cert, certificate, and key file that resulted in the failure so that the user has an idea what to troubleshoot. Signed-off-by: Doug Goldstein <cardoe(a)gentoo.org> --- src/remote/remote_driver.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index e30780c..4c3bdf3 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -1268,8 +1268,8 @@ initialize_gnutls(char *pkipath, int flags) GNUTLS_X509_FMT_PEM); if (err < 0) { remoteError(VIR_ERR_GNUTLS_ERROR, - _("unable to load CA certificate: %s"), - gnutls_strerror (err)); + _("unable to load CA certificate '%s': %s"), + libvirt_cacert, gnutls_strerror (err)); goto error; } @@ -1283,8 +1283,9 @@ initialize_gnutls(char *pkipath, int flags) GNUTLS_X509_FMT_PEM); if (err < 0) { remoteError(VIR_ERR_GNUTLS_ERROR, - _("unable to load private key/certificate: %s"), - gnutls_strerror (err)); + _("unable to load private key '%s' and/or " + "certificate '%s': %s"), libvirt_clientkey, + libvirt_clientcert, gnutls_strerror (err)); goto error; } -- 1.7.5.rc3

2 1

[libvirt] [PATCH v2] Add warning message to XML definition files stored on disk
by Michal Privoznik 05 May '11

05 May '11

Users often edit XML file stored in configuration directory thinking of modifying a domain/network/pool/etc. Thus it is wise to let them know they are using the wrong way and give them hint. --- diff to v1: - instead of pointing users to web, write down the actual virsh command - write to passed FD instead of buffer src/conf/domain_conf.c | 10 +++++-- src/conf/domain_conf.h | 3 +- src/conf/network_conf.c | 8 ++++- src/conf/network_conf.h | 3 +- src/conf/nwfilter_conf.c | 14 ++++++++-- src/conf/nwfilter_conf.h | 6 +++- src/conf/storage_conf.c | 6 ++++- src/conf/storage_conf.h | 3 +- src/libvirt_private.syms | 1 + src/nwfilter/nwfilter_driver.c | 3 +- src/storage/storage_driver.c | 3 +- src/util/util.c | 50 ++++++++++++++++++++++++++++++++++++++++ src/util/util.h | 20 ++++++++++++++++ 13 files changed, 114 insertions(+), 16 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2a681d9..a4be770 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8485,7 +8485,8 @@ error: int virDomainSaveXML(const char *configDir, virDomainDefPtr def, - const char *xml) + const char *xml, + unsigned int flags) { char *configFile = NULL; int fd = -1, ret = -1; @@ -8510,6 +8511,9 @@ int virDomainSaveXML(const char *configDir, goto cleanup; } + if (flags & VIR_XML_EMIT_WARNING) + virEmitXMLWarning(fd, def->name, VIR_XML_EDIT_COMMAND_DOMAIN); + towrite = strlen(xml); if (safewrite(fd, xml, towrite) < 0) { virReportSystemError(errno, @@ -8543,7 +8547,7 @@ int virDomainSaveConfig(const char *configDir, VIR_DOMAIN_XML_WRITE_FLAGS))) goto cleanup; - if (virDomainSaveXML(configDir, def, xml)) + if (virDomainSaveXML(configDir, def, xml, VIR_XML_EMIT_WARNING)) goto cleanup; ret = 0; @@ -8563,7 +8567,7 @@ int virDomainSaveStatus(virCapsPtr caps, if (!(xml = virDomainObjFormat(caps, obj, flags))) goto cleanup; - if (virDomainSaveXML(statusDir, obj->def, xml)) + if (virDomainSaveXML(statusDir, obj->def, xml, VIR_XML_EMIT_WARNING)) goto cleanup; ret = 0; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1dadf98..3841f1b 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1346,7 +1346,8 @@ void virDomainControllerInsertPreAlloced(virDomainDefPtr def, int virDomainSaveXML(const char *configDir, virDomainDefPtr def, - const char *xml); + const char *xml, + unsigned int flags); int virDomainSaveConfig(const char *configDir, virDomainDefPtr def); diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 5738757..012caa8 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -899,7 +899,8 @@ char *virNetworkDefFormat(const virNetworkDefPtr def) int virNetworkSaveXML(const char *configDir, virNetworkDefPtr def, - const char *xml) + const char *xml, + unsigned int flags) { char *configFile = NULL; int fd = -1, ret = -1; @@ -925,6 +926,9 @@ int virNetworkSaveXML(const char *configDir, goto cleanup; } + if (flags & VIR_XML_EMIT_WARNING) + virEmitXMLWarning(fd, def->name, VIR_XML_EDIT_COMMAND_NETWORK); + towrite = strlen(xml); if (safewrite(fd, xml, towrite) < 0) { virReportSystemError(errno, @@ -959,7 +963,7 @@ int virNetworkSaveConfig(const char *configDir, if (!(xml = virNetworkDefFormat(def))) goto cleanup; - if (virNetworkSaveXML(configDir, def, xml)) + if (virNetworkSaveXML(configDir, def, xml, VIR_XML_EMIT_WARNING)) goto cleanup; ret = 0; diff --git a/src/conf/network_conf.h b/src/conf/network_conf.h index 281124b..6e39234 100644 --- a/src/conf/network_conf.h +++ b/src/conf/network_conf.h @@ -162,7 +162,8 @@ int virNetworkIpDefNetmask(const virNetworkIpDefPtr def, int virNetworkSaveXML(const char *configDir, virNetworkDefPtr def, - const char *xml); + const char *xml, + unsigned int flags); int virNetworkSaveConfig(const char *configDir, virNetworkDefPtr def); diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 615c0f1..66a31d1 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -2223,7 +2223,8 @@ virNWFilterObjFindByName(virNWFilterObjListPtr nwfilters, const char *name) int virNWFilterSaveXML(const char *configDir, virNWFilterDefPtr def, - const char *xml) + const char *xml, + unsigned int flags) { char *configFile = NULL; int fd = -1, ret = -1; @@ -2249,6 +2250,9 @@ int virNWFilterSaveXML(const char *configDir, goto cleanup; } + if (flags & VIR_XML_EMIT_WARNING) + virEmitXMLWarning(fd, def->name, VIR_XML_EDIT_COMMAND_NWFILTER); + towrite = strlen(xml); if (safewrite(fd, xml, towrite) < 0) { virReportSystemError(errno, @@ -2283,7 +2287,7 @@ int virNWFilterSaveConfig(const char *configDir, if (!(xml = virNWFilterDefFormat(def))) goto cleanup; - if (virNWFilterSaveXML(configDir, def, xml)) + if (virNWFilterSaveXML(configDir, def, xml, VIR_XML_EMIT_WARNING)) goto cleanup; ret = 0; @@ -2608,7 +2612,8 @@ virNWFilterLoadAllConfigs(virConnectPtr conn, int virNWFilterObjSaveDef(virNWFilterDriverStatePtr driver, virNWFilterObjPtr nwfilter, - virNWFilterDefPtr def) + virNWFilterDefPtr def, + unsigned int flags) { char *xml; int fd = -1, ret = -1; @@ -2645,6 +2650,9 @@ virNWFilterObjSaveDef(virNWFilterDriverStatePtr driver, goto cleanup; } + if (flags & VIR_XML_EMIT_WARNING) + virEmitXMLWarning(fd, def->name, VIR_XML_EDIT_COMMAND_NWFILTER); + towrite = strlen(xml); if (safewrite(fd, xml, towrite) != towrite) { virReportSystemError(errno, diff --git a/src/conf/nwfilter_conf.h b/src/conf/nwfilter_conf.h index 12e2a5c..219bf7e 100644 --- a/src/conf/nwfilter_conf.h +++ b/src/conf/nwfilter_conf.h @@ -603,7 +603,8 @@ virNWFilterObjPtr virNWFilterObjFindByName(virNWFilterObjListPtr nwfilters, int virNWFilterObjSaveDef(virNWFilterDriverStatePtr driver, virNWFilterObjPtr nwfilter, - virNWFilterDefPtr def); + virNWFilterDefPtr def, + unsigned int flags); int virNWFilterObjDeleteDef(virNWFilterObjPtr nwfilter); @@ -621,7 +622,8 @@ char *virNWFilterDefFormat(virNWFilterDefPtr def); int virNWFilterSaveXML(const char *configDir, virNWFilterDefPtr def, - const char *xml); + const char *xml, + unsigned int flags); int virNWFilterSaveConfig(const char *configDir, virNWFilterDefPtr def); diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 116898d..b729bbe 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1509,7 +1509,8 @@ virStoragePoolLoadAllConfigs(virStoragePoolObjListPtr pools, int virStoragePoolObjSaveDef(virStorageDriverStatePtr driver, virStoragePoolObjPtr pool, - virStoragePoolDefPtr def) { + virStoragePoolDefPtr def, + unsigned int flags) { char *xml; int fd = -1, ret = -1; ssize_t towrite; @@ -1551,6 +1552,9 @@ virStoragePoolObjSaveDef(virStorageDriverStatePtr driver, goto cleanup; } + if (flags & VIR_XML_EMIT_WARNING) + virEmitXMLWarning(fd, def->name, VIR_XML_EDIT_COMMAND_STORAGE_POOL); + towrite = strlen(xml); if (safewrite(fd, xml, towrite) != towrite) { virReportSystemError(errno, diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index 271441a..9bbc25d 100644 --- a/src/conf/storage_conf.h +++ b/src/conf/storage_conf.h @@ -366,7 +366,8 @@ virStoragePoolObjPtr virStoragePoolObjAssignDef(virStoragePoolObjListPtr pools, int virStoragePoolObjSaveDef(virStorageDriverStatePtr driver, virStoragePoolObjPtr pool, - virStoragePoolDefPtr def); + virStoragePoolDefPtr def, + unsigned int flags); int virStoragePoolObjDeleteDef(virStoragePoolObjPtr pool); void virStorageVolDefFree(virStorageVolDefPtr def); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1b22be6..2cbec44 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -897,6 +897,7 @@ virArgvToString; virAsprintf; virBuildPathInternal; virDirCreate; +virEmitXMLWarning; virEnumFromString; virEnumToString; virEventAddHandle; diff --git a/src/nwfilter/nwfilter_driver.c b/src/nwfilter/nwfilter_driver.c index 8af3f8a..2d0db73 100644 --- a/src/nwfilter/nwfilter_driver.c +++ b/src/nwfilter/nwfilter_driver.c @@ -343,7 +343,8 @@ nwfilterDefine(virConnectPtr conn, if (!(nwfilter = virNWFilterObjAssignDef(conn, &driver->nwfilters, def))) goto cleanup; - if (virNWFilterObjSaveDef(driver, nwfilter, def) < 0) { + if (virNWFilterObjSaveDef(driver, nwfilter, def, + VIR_XML_EMIT_WARNING) < 0) { virNWFilterObjRemove(&driver->nwfilters, nwfilter); def = NULL; goto cleanup; diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 5118ffb..acfc791 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -586,7 +586,8 @@ storagePoolDefine(virConnectPtr conn, if (!(pool = virStoragePoolObjAssignDef(&driver->pools, def))) goto cleanup; - if (virStoragePoolObjSaveDef(driver, pool, def) < 0) { + if (virStoragePoolObjSaveDef(driver, pool, def, + VIR_XML_EMIT_WARNING) < 0) { virStoragePoolObjRemove(&driver->pools, pool); def = NULL; goto cleanup; diff --git a/src/util/util.c b/src/util/util.c index 9041ab6..a622e08 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -3207,3 +3207,53 @@ bool virIsDevMapperDevice(const char *devname ATTRIBUTE_UNUSED) return false; } #endif + +VIR_ENUM_IMPL(virXMLEditCommand, VIR_XML_EDIT_COMMAND_LAST, + "", + "edit", + "net-edit", + "nwfilter-edit", + "pool-edit") + +int virEmitXMLWarning(int fd, + const char *name, + unsigned int cmd) { + size_t len; + const char *cmd_str = virXMLEditCommandTypeToString(cmd); + const char *prologue = _("\n\n"); + + if (fd < 0 || !name) + return -1; + + if (!cmd_str || STREQ(cmd_str, "")) { + VIR_WARN("unknown command code %d", cmd); + return -1; + } + + len = strlen(prologue); + if (safewrite(fd, prologue, len) != len) + return -1; + + len = strlen(cmd_str); + if (safewrite(fd, cmd_str, len) != len) + return -1; + + if (safewrite(fd, " ", 1) != 1) + return -1; + + len = strlen(name); + if (safewrite(fd, name, len) != len) + return -1; + + len = strlen(epilogue); + if (safewrite(fd, epilogue, len) != len) + return -1; + + return 0; +} diff --git a/src/util/util.h b/src/util/util.h index d320c40..c0ca5f4 100644 --- a/src/util/util.h +++ b/src/util/util.h @@ -299,4 +299,24 @@ int virBuildPathInternal(char **path, ...) ATTRIBUTE_SENTINEL; char *virTimestamp(void); bool virIsDevMapperDevice(const char *devname) ATTRIBUTE_NONNULL(1); + +enum { + VIR_XML_EMIT_WARNING = (1 << 0), +}; + +enum virXMLEditCommand { + VIR_XML_EDIT_COMMAND_UNKNOWN = 0, + VIR_XML_EDIT_COMMAND_DOMAIN, + VIR_XML_EDIT_COMMAND_NETWORK, + VIR_XML_EDIT_COMMAND_NWFILTER, + VIR_XML_EDIT_COMMAND_STORAGE_POOL, + + VIR_XML_EDIT_COMMAND_LAST +}; + +VIR_ENUM_DECL(virXMLEditCommand) + +int virEmitXMLWarning(int fd, + const char *name, + unsigned int cmd) ATTRIBUTE_NONNULL(2); #endif /* __VIR_UTIL_H__ */ -- 1.7.4.4

2 1

[libvirt] [PATCH] virsh: fix regression in log to file
by Supriya Kannery 05 May '11

05 May '11

Commit 36deff04 introduced a regression due to which virsh is not able to log to a file - msg_buf was changed from an array to a pointer without corresponding change to usage of "sizeof()". Fix regression in virsh logging Signed-off-by: Supriya Kannery <supriyak(a)in.ibm.com> --- tools/virsh.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) Index: libvirt/tools/virsh.c =================================================================== --- libvirt.orig/tools/virsh.c +++ libvirt/tools/virsh.c @@ -12257,7 +12257,7 @@ vshOutputLogFile(vshControl *ctl, int lo */ gettimeofday(&stTimeval, NULL); stTm = localtime(&stTimeval.tv_sec); - snprintf(msg_buf, sizeof(msg_buf), + snprintf(msg_buf, MSG_BUFFER, "[%d.%02d.%02d %02d:%02d:%02d ", (1900 + stTm->tm_year), (1 + stTm->tm_mon), @@ -12265,7 +12265,7 @@ vshOutputLogFile(vshControl *ctl, int lo (stTm->tm_hour), (stTm->tm_min), (stTm->tm_sec)); - snprintf(msg_buf + strlen(msg_buf), sizeof(msg_buf) - strlen(msg_buf), + snprintf(msg_buf + strlen(msg_buf), MSG_BUFFER - strlen(msg_buf), "%s] ", SIGN_NAME); switch (log_level) { case VSH_ERR_DEBUG: @@ -12287,13 +12287,13 @@ vshOutputLogFile(vshControl *ctl, int lo lvl = LVL_DEBUG; break; } - snprintf(msg_buf + strlen(msg_buf), sizeof(msg_buf) - strlen(msg_buf), + snprintf(msg_buf + strlen(msg_buf), MSG_BUFFER - strlen(msg_buf), "%s ", lvl); - vsnprintf(msg_buf + strlen(msg_buf), sizeof(msg_buf) - strlen(msg_buf), + vsnprintf(msg_buf + strlen(msg_buf), MSG_BUFFER - strlen(msg_buf), msg_format, ap); if (msg_buf[strlen(msg_buf) - 1] != '\n') - snprintf(msg_buf + strlen(msg_buf), sizeof(msg_buf) - strlen(msg_buf), "\n"); + snprintf(msg_buf + strlen(msg_buf), MSG_BUFFER - strlen(msg_buf), "\n"); /* write log */ if (safewrite(ctl->log_fd, msg_buf, strlen(msg_buf)) < 0) {

3 9

[libvirt] [PATCH] docs: <filesystem> attr is 'accessmode', not 'mode'
by Cole Robinson 05 May '11

05 May '11

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/formatdomain.html.in | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 5013c48..dcfcd94 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -917,7 +917,7 @@ <source name='my-vm-template'/> <target dir='/'/> </filesystem> - <filesystem type='mount' > + <filesystem type='mount' accessmode='passthrough'> <source dir='/export/to/guest'/> <target dir='/import/from/host'/> <readonly/> @@ -939,7 +939,7 @@ A host directory to mount in the guest. Used by LXC, OpenVZ <span class="since">(since 0.6.2)</span> and QEMU/KVM <span class="since">(since 0.8.5)</span>. - This is the default <code>mode</code> if one is not specified. + This is the default <code>type</code> if one is not specified. </dd> <dt><code>type='template'</code></dt> <dd> @@ -955,27 +955,27 @@ </dd> </dl> - The filesystem block has an optional attribute <code>mode</code> + The filesystem block has an optional attribute <code>accessmode</code> which specifies the security mode for accessing the source <span class="since">(since 0.8.5)</span>. Currently this only works with <code>type='mount'</code> for the QEMU/KVM driver. The possible values are: <dl> - <dt><code>mode='passthrough'</code></dt> + <dt><code>accessmode='passthrough'</code></dt> <dd> The <code>source</code> is accessed with the permissions of the - user inside the guest. This is the default <code>mode</code> if + user inside the guest. This is the default <code>accessmode</code> if one is not specified. <a href="http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02673.html">More info</a> </dd> - <dt><code>mode='mapped'</code></dt> + <dt><code>accessmode='mapped'</code></dt> <dd> The <code>source</code> is accessed with the permissions of the hypervisor (QEMU process). <a href="http://lists.gnu.org/archive/html/qemu-devel/2010-05/msg02673.html">More info</a> </dd> - <dt><code>mode='squash'</code></dt> + <dt><code>accessmode='squash'</code></dt> <dd> Similar to 'passthrough', the exception is that failure of privileged operations like 'chown' are ignored. This makes a -- 1.7.4.4

2 2

[libvirt] [PATCH 0/6] Introduce a new migration protocol to QEMU driver
by Daniel P. Berrange 05 May '11

05 May '11

The current migration protocol has several flaws - No initial hook on the source host to do work before the dst VM is launched - No ability to restart src VM if dst fails to recv all migration data, but src successfully sent it all This introduces a new 5 step migration process to address this limitation. To support features such as seemless migration of SPICE clients, and lock driver state passing this now makes use of the migration cookie feature too

4 31

Re: [libvirt] [virt-tools-list] virt-manger: KVM is not available.
by Cole Robinson 05 May '11

05 May '11

On 05/04/2011 01:38 PM, Florian Lindner wrote: > Am Dienstag 03 Mai 2011, 17:19:48 schrieb Cole Robinson: >> On 05/02/2011 03:25 PM, Florian Lindner wrote: >>> Am Montag 02 Mai 2011, 16:23:10 schrieb Cole Robinson: >>>> On 05/01/2011 05:26 PM, Florian Lindner wrote: >>>>> Hello! >>>>> >>>>> I have a problem with virt-manage saying my KVM wasn't available. >>>>> >>>>> System is Archlinux, libvirtd 0.9.0, Kernel 2.6.38. >>>>> CPU is a Phenom X4, supports virtualization. >>>>> >>>>> modprobe kvm and kvm-amd works fine: >>>>> >>>>> May 1 23:19:48 localhost kernel: [ 750.262215] kvm: Nested >>>>> Virtualization enabled >>>>> May 1 23:19:48 localhost kernel: [ 750.262218] kvm: Nested Paging >>>>> enabled >>>>> >>>>> starting up libvirtd: >>>>> >>>>> May 1 23:21:23 localhost kernel: [ 844.527695] Bridge firewalling >>>>> registered May 1 23:21:23 localhost kernel: [ 844.537781] tun: >>>>> Universal TUN/TAP device driver, 1.6 >>>>> May 1 23:21:23 localhost kernel: [ 844.537784] tun: (C) 1999-2004 Max >>>>> Krasnyansky <maxk(a)qualcomm.com> >>>>> May 1 23:21:23 localhost avahi-daemon[1370]: Withdrawing workstation >>>>> service for . >>>>> May 1 23:21:23 localhost avahi-daemon[1370]: Withdrawing workstation >>>>> service for virbr0. >>>>> May 1 23:21:23 localhost kernel: [ 844.737116] ip_tables: (C) >>>>> 2000-2006 Netfilter Core Team >>>>> May 1 23:21:23 localhost kernel: [ 844.752760] ip6_tables: (C) >>>>> 2000-2006 Netfilter Core Team >>>>> >>>>> >>>>> start virt-manager as user but granting root priviliges when asked on >>>>> startup. When creating a new VM it says that KVM is not available. >>>>> >>>>> qemu -enable-kvm has worked fine so far. >>>>> >>>>> Why is that error message? >>>>> >>>>> Thanks, >>>>> >>>>> Florian >>>> >>>> That error means that libvirt did not detect KVM support. Libvirt checks >>>> for a /usr/bin/qemu* binary, /dev/kvm, and proper permissions to run >>>> both. >>> >>> Permissions should be fine: >>> >>> florian@horus ~ % groups >>> sys kvm scanner florian >>> >>> florian@horus ~ % ll /dev/kvm >>> crw-rw----+ 1 root kvm 10, 232 2. Mai 21:04 /dev/kvm >>> >>> florian@horus ~ % ll /usr/bin/qemu* >>> -rwxr-xr-x 1 root root 2961888 21. Feb 21:10 /usr/bin/qemu* >>> [...] >>> -rwxr-xr-x 1 root root 3033280 21. Feb 21:10 /usr/bin/qemu-system-x86_64* >>> -rwxr-xr-x 1 root root 2055048 21. Feb 21:10 /usr/bin/qemu-x86_64* >>> >>>> What's the output of virsh --connect qemu:///session capabilities | grep >>>> kvm and virsh --connect qemu:///system capabilities | grep kvm ? >>> >>> They both return nothing, run as user as well as being run as root. When >>> run as user the second commands asks for root priviliges which are >>> granted. >> >> Hmm, full output of virsh --connect qemu:///system capabilities (as >> root) and qemu-system-x86_64 -help would be interesting. > > Hey! > > both commands outputs are below. > > Thanks! > > Florian > Ah okay. The issue is that libvirt only advertises KVM if it finds a file named qemu-kvm or kvm, so it won't by default allow using kvm with a stock qemu release. You can probably work around this by symlinking /usr/bin/qemu-kvm to /usr/bin/qemu-system-x86_64. Might want to file a bug with your distro to do the same (or have them actually ship the forked qemu that is distributed with KVM upstream, since it's generally what receives the most testing). The proper fix though is to have libvirt advertise KVM for upstream qemu binaries if it finds the correct CLI arguments. We will probably need to do this anyways when the KVM qemu fork is fully merged upstream. - Cole > root@horus /home/florian # virsh --connect qemu:///system capabilities > <capabilities> > > <host> > <uuid>30303234-3144-4437-3039-3942ffffffff</uuid> > <cpu> > <arch>x86_64</arch> > <model>Opteron_G3</model> > <vendor>AMD</vendor> > <topology sockets='1' cores='4' threads='1'/> > <feature name='wdt'/> > <feature name='skinit'/> > <feature name='osvw'/> > <feature name='3dnowprefetch'/> > <feature name='cr8legacy'/> > <feature name='extapic'/> > <feature name='cmp_legacy'/> > <feature name='3dnow'/> > <feature name='3dnowext'/> > <feature name='pdpe1gb'/> > <feature name='fxsr_opt'/> > <feature name='mmxext'/> > <feature name='ht'/> > <feature name='vme'/> > </cpu> > <migration_features> > <live/> > <uri_transports> > <uri_transport>tcp</uri_transport> > </uri_transports> > </migration_features> > </host> > > <guest> > <os_type>hvm</os_type> > <arch name='i686'> > <wordsize>32</wordsize> > <emulator>/usr/bin/qemu</emulator> > <machine>pc-0.14</machine> > <machine canonical='pc-0.14'>pc</machine> > <machine>pc-0.13</machine> > <machine>pc-0.12</machine> > <machine>pc-0.11</machine> > <machine>pc-0.10</machine> > <machine>isapc</machine> > <domain type='qemu'> > </domain> > </arch> > <features> > <cpuselection/> > <deviceboot/> > <pae/> > <nonpae/> > <acpi default='on' toggle='yes'/> > <apic default='on' toggle='no'/> > </features> > </guest> > > <guest> > <os_type>hvm</os_type> > <arch name='x86_64'> > <wordsize>64</wordsize> > <emulator>/usr/bin/qemu-system-x86_64</emulator> > <machine>pc-0.14</machine> > <machine canonical='pc-0.14'>pc</machine> > <machine>pc-0.13</machine> > <machine>pc-0.12</machine> > <machine>pc-0.11</machine> > <machine>pc-0.10</machine> > <machine>isapc</machine> > <domain type='qemu'> > </domain> > </arch> > <features> > <cpuselection/> > <deviceboot/> > <acpi default='on' toggle='yes'/> > <apic default='on' toggle='no'/> > </features> > </guest> > > <guest> > <os_type>hvm</os_type> > <arch name='arm'> > <wordsize>32</wordsize> > <emulator>/usr/bin/qemu-system-arm</emulator> > <machine>integratorcp</machine> > <machine>syborg</machine> > <machine>musicpal</machine> > <machine>mainstone</machine> > <machine>n800</machine> > <machine>n810</machine> > <machine>cheetah</machine> > <machine>sx1</machine> > <machine>sx1-v1</machine> > <machine>tosa</machine> > <machine>akita</machine> > <machine>spitz</machine> > <machine>borzoi</machine> > <machine>terrier</machine> > <machine>connex</machine> > <machine>verdex</machine> > <machine>lm3s811evb</machine> > <machine>lm3s6965evb</machine> > <machine>realview-eb</machine> > <machine>realview-eb-mpcore</machine> > <machine>realview-pb-a8</machine> > <machine>realview-pbx-a9</machine> > <machine>versatilepb</machine> > <machine>versatileab</machine> > <domain type='qemu'> > </domain> > </arch> > <features> > <deviceboot/> > </features> > </guest> > > <guest> > <os_type>hvm</os_type> > <arch name='mips'> > <wordsize>32</wordsize> > <emulator>/usr/bin/qemu-system-mips</emulator> > <machine>malta</machine> > <machine>mipssim</machine> > <machine>magnum</machine> > <machine>pica61</machine> > <machine>mips</machine> > <domain type='qemu'> > </domain> > </arch> > <features> > <deviceboot/> > </features> > </guest> > > <guest> > <os_type>hvm</os_type> > <arch name='mipsel'> > <wordsize>32</wordsize> > <emulator>/usr/bin/qemu-system-mipsel</emulator> > <machine>malta</machine> > <machine>mipssim</machine> > <machine>magnum</machine> > <machine>pica61</machine> > <machine>mips</machine> > <domain type='qemu'> > </domain> > </arch> > <features> > <deviceboot/> > </features> > </guest> > > <guest> > <os_type>hvm</os_type> > <arch name='sparc'> > <wordsize>32</wordsize> > <emulator>/usr/bin/qemu-system-sparc</emulator> > <machine>SS-5</machine> > <machine>leon3_generic</machine> > <machine>SS-10</machine> > <machine>SS-600MP</machine> > <machine>SS-20</machine> > <machine>Voyager</machine> > <machine>LX</machine> > <machine>SS-4</machine> > <machine>SPARCClassic</machine> > <machine>SPARCbook</machine> > <machine>SS-1000</machine> > <machine>SS-2000</machine> > <machine>SS-2</machine> > <domain type='qemu'> > </domain> > </arch> > </guest> > > <guest> > <os_type>hvm</os_type> > <arch name='ppc'> > <wordsize>32</wordsize> > <emulator>/usr/bin/qemu-system-ppc</emulator> > <machine>g3beige</machine> > <machine>virtex-ml507</machine> > <machine>mpc8544ds</machine> > <machine canonical='bamboo-0.13'>bamboo</machine> > <machine>bamboo-0.13</machine> > <machine>bamboo-0.12</machine> > <machine>ref405ep</machine> > <machine>taihu</machine> > <machine>mac99</machine> > <machine>prep</machine> > <domain type='qemu'> > </domain> > </arch> > <features> > <deviceboot/> > </features> > </guest> > > </capabilities> > > > ---------------------------------------------------- > > root@horus /home/florian # qemu-system-x86_64 -help > QEMU emulator version 0.14.0, Copyright (c) 2003-2008 Fabrice Bellard > usage: qemu [options] [disk_image] > > 'disk_image' is a raw hard disk image for IDE hard disk 0 > > Standard options: > -h or -help display this help and exit > -version display version information and exit > -M machine select emulated machine (-M ? for list) > -cpu cpu select CPU (-cpu ? for list) > -smp n[,maxcpus=cpus][,cores=cores][,threads=threads][,sockets=sockets] > set the number of CPUs to 'n' [default=1] > maxcpus= maximum number of total cpus, including > offline CPUs for hotplug, etc > cores= number of CPU cores on one socket > threads= number of threads on one CPU core > sockets= number of discrete sockets in the system > -numa node[,mem=size][,cpus=cpu[-cpu]][,nodeid=node] > -fda/-fdb file use 'file' as floppy disk 0/1 image > -hda/-hdb file use 'file' as IDE hard disk 0/1 image > -hdc/-hdd file use 'file' as IDE hard disk 2/3 image > -cdrom file use 'file' as IDE cdrom image (cdrom is ide1 master) > -drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i] > [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off] > [,cache=writethrough|writeback|none|unsafe][,format=f] > [,serial=s][,addr=A][,id=name][,aio=threads|native] > [,readonly=on|off] > use 'file' as a drive image > -set group.id.arg=value > set <arg> parameter for item <id> of type <group> > i.e. -set drive.$id.file=/path/to/image > -global driver.property=value > set a global default for a driver property > -mtdblock file use 'file' as on-board Flash memory image > -sd file use 'file' as SecureDigital card image > -pflash file use 'file' as a parallel flash image > -boot [order=drives][,once=drives][,menu=on|off] > 'drives': floppy (a), hard disk (c), CD-ROM (d), network (n) > -snapshot write to temporary files instead of disk image files > -m megs set virtual RAM size to megs MB [default=128] > -mem-path FILE provide backing storage for guest RAM > -mem-prealloc preallocate guest memory (use with -mem-path) > -k language use keyboard layout (for example 'fr' for French) > -audio-help print list of audio drivers and their options > -soundhw c1,... enable audio support > and only specified sound cards (comma separated list) > use -soundhw ? to get the list of supported cards > use -soundhw all to enable all of them > -usb enable the USB driver (will be the default soon) > -usbdevice name add the host or guest USB device 'name' > -device driver[,prop[=value][,...]] > add device (based on driver) > prop=value,... sets driver properties > use -device ? to print all possible drivers > use -device driver,? to print all possible properties > File system options: > -fsdev local,id=id,path=path,security_model=[mapped|passthrough|none] > Virtual File system pass-through options: > -virtfs local,path=path,mount_tag=tag,security_model=[mapped|passthrough|none] > > -name string1[,process=string2] > set the name of the guest > string1 sets the window title and string2 the process name (on > Linux) > -uuid %08x-%04x-%04x-%04x-%012x > specify machine UUID > > Display options: > -nographic disable graphical output and redirect serial I/Os to console > -curses use a curses/ncurses interface instead of SDL > -no-frame open SDL window without a frame and window decorations > -alt-grab use Ctrl-Alt-Shift to grab mouse (instead of Ctrl-Alt) > -ctrl-grab use Right-Ctrl to grab mouse (instead of Ctrl-Alt) > -no-quit disable SDL window close capability > -sdl enable SDL > -spice <args> enable spice > -portrait rotate graphical output 90 deg left (only PXA LCD) > -vga [std|cirrus|vmware|qxl|xenfb|none] > select video card type > -full-screen start in full screen > -g WxH[xDEPTH] Set the initial graphical resolution and depth > -vnc display start a VNC server on display > > i386 target only: > -win2k-hack use it when installing Windows 2000 to avoid a disk full bug > -no-fd-bootchk disable boot signature checking for floppy disks > -no-acpi disable ACPI > -no-hpet disable HPET > -balloon none disable balloon device > -balloon virtio[,addr=str] > enable virtio balloon device (default) > -acpitable [sig=str][,rev=n][,oem_id=str][,oem_table_id=str][,oem_rev=n] > [,asl_compiler_id=str][,asl_compiler_rev=n][,data=file1[:file2]...] > ACPI table description > -smbios file=binary > load SMBIOS entry from binary file > -smbios type=0[,vendor=str][,version=str][,date=str][,release=%d.%d] > specify SMBIOS type 0 fields > -smbios type=1[,manufacturer=str][,product=str][,version=str][,serial=str] > [,uuid=uuid][,sku=str][,family=str] > specify SMBIOS type 1 fields > > Network options: > -net nic[,vlan=n][,macaddr=mac][,model=type][,name=str][,addr=str][,vectors=v] > create a new Network Interface Card and connect it to VLAN 'n' > -net user[,vlan=n][,name=str][,net=addr[/mask]][,host=addr][,restrict=y|n] > [,hostname=host][,dhcpstart=addr][,dns=addr][,tftp=dir][,bootfile=f] > [,hostfwd=rule][,guestfwd=rule][,smb=dir[,smbserver=addr]] > connect the user mode network stack to VLAN 'n', configure its > DHCP server and enabled optional services > -net tap[,vlan=n][,name=str][,fd=h][,ifname=name][,script=file] > [,downscript=dfile][,sndbuf=nbytes][,vnet_hdr=on|off][,vhost=on|off][,vhostfd=h] > [,vhostforce=on|off] > connect the host TAP network interface to VLAN 'n' and use the > network scripts 'file' (default=/etc/qemu-ifup) > and 'dfile' (default=/etc/qemu-ifdown) > use '[down]script=no' to disable script execution > use 'fd=h' to connect to an already opened TAP interface > use 'sndbuf=nbytes' to limit the size of the send buffer (the > default is disabled 'sndbuf=0' to enable flow control set > 'sndbuf=1048576') > use vnet_hdr=off to avoid enabling the IFF_VNET_HDR tap flag > use vnet_hdr=on to make the lack of IFF_VNET_HDR support an > error condition > use vhost=on to enable experimental in kernel accelerator > (only has effect for virtio guests which use MSIX) > use vhostforce=on to force vhost on for non-MSIX virtio guests > use 'vhostfd=h' to connect to an already opened vhost net > device > -net socket[,vlan=n][,name=str][,fd=h][,listen=[host]:port] > [,connect=host:port] > connect the vlan 'n' to another VLAN using a socket connection > -net socket[,vlan=n][,name=str][,fd=h][,mcast=maddr:port[,localaddr=addr]] > connect the vlan 'n' to multicast maddr and port > use 'localaddr=addr' to specify the host address to send > packets from > -net vde[,vlan=n][,name=str][,sock=socketpath][,port=n][,group=groupname] > [,mode=octalmode] > connect the vlan 'n' to port 'n' of a vde switch running > on host and listening for incoming connections on > 'socketpath'. > Use group 'groupname' and mode 'octalmode' to change default > ownership and permissions for communication port. > -net dump[,vlan=n][,file=f][,len=n] > dump traffic on vlan 'n' to file 'f' (max n bytes per packet) > -net none use it alone to have zero network devices. If no -net option > is provided, the default is '-net nic -net user' > -netdev [user|tap|vde|socket],id=str[,option][,option][,...] > > Character device options: > -chardev null,id=id[,mux=on|off] > -chardev socket,id=id[,host=host],port=host[,to=to][,ipv4][,ipv6][,nodelay] > [,server][,nowait][,telnet][,mux=on|off] (tcp) > -chardev socket,id=id,path=path[,server][,nowait][,telnet],[mux=on|off] (unix) > -chardev udp,id=id[,host=host],port=port[,localaddr=localaddr] > [,localport=localport][,ipv4][,ipv6][,mux=on|off] > -chardev msmouse,id=id[,mux=on|off] > -chardev vc,id=id[[,width=width][,height=height]][[,cols=cols][,rows=rows]] > [,mux=on|off] > -chardev file,id=id,path=path[,mux=on|off] > -chardev pipe,id=id,path=path[,mux=on|off] > -chardev pty,id=id[,mux=on|off] > -chardev stdio,id=id[,mux=on|off][,signal=on|off] > -chardev tty,id=id,path=path[,mux=on|off] > -chardev parport,id=id,path=path[,mux=on|off] > > Bluetooth(R) options: > -bt hci,null dumb bluetooth HCI - doesn't respond to commands > -bt hci,host[:id] > use host's HCI with the given name > -bt hci[,vlan=n] > emulate a standard HCI in virtual scatternet 'n' > -bt vhci[,vlan=n] > add host computer to virtual scatternet 'n' using VHCI > -bt device:dev[,vlan=n] > emulate a bluetooth device 'dev' in scatternet 'n' > > Linux/Multiboot boot specific: > -kernel bzImage use 'bzImage' as kernel image > -append cmdline use 'cmdline' as kernel command line > -initrd file use 'file' as initial ram disk > > Debug/Expert options: > -serial dev redirect the serial port to char device 'dev' > -parallel dev redirect the parallel port to char device 'dev' > -monitor dev redirect the monitor to char device 'dev' > -qmp dev like -monitor but opens in 'control' mode > -mon chardev=[name][,mode=readline|control][,default] > -debugcon dev redirect the debug console to char device 'dev' > -pidfile file write PID to 'file' > -singlestep always run in singlestep mode > -S freeze CPU at startup (use 'c' to start execution) > -gdb dev wait for gdb connection on 'dev' > -s shorthand for -gdb tcp::1234 > -d item1,... output log to /tmp/qemu.log (use -d ? for a list of log items) > -hdachs c,h,s[,t] > force hard disk 0 physical geometry and the optional BIOS > translation (t=none or lba) (usually qemu can guess them) > -L path set the directory for the BIOS, VGA BIOS and keymaps > -bios file set the filename for the BIOS > -enable-kvm enable KVM full virtualization support > -xen-domid id specify xen guest domain id > -xen-create create domain using xen hypercalls, bypassing xend > warning: should not be used when xend is in use > -xen-attach attach to existing xen domain > xend will use this when starting qemu > -no-reboot exit instead of rebooting > -no-shutdown stop before shutdown > -loadvm [tag|id] > start right away with a saved state (loadvm in monitor) > -daemonize daemonize QEMU after initializing > -option-rom rom load a file, rom, into the option ROM space > -clock force the use of the given methods for timer alarm. > To see what timers are available use -clock ? > -rtc [base=utc|localtime|date][,clock=host|vm][,driftfix=none|slew] > set the RTC base and clock, enable drift fix for clock ticks > (x86 only) > -icount [N|auto] > enable virtual instruction counter with 2^N clock ticks per > instruction > -watchdog i6300esb|ib700 > enable virtual hardware watchdog [default=none] > -watchdog-action reset|shutdown|poweroff|pause|debug|none > action when watchdog fires [default=reset] > -echr chr set terminal escape character instead of ctrl-a > -virtioconsole c > set virtio console > -show-cursor show cursor > -tb-size n set TB size > -incoming p prepare for incoming migration, listen on port p > -nodefaults don't create default devices > -chroot dir chroot to dir just before starting the VM > -runas user change to user id user just before starting the VM > -prom-env variable=value > set OpenBIOS nvram variables > -semihosting semihosting mode > -old-param old param mode > -readconfig <file> > -writeconfig <file> > read/write config file > -nodefconfig > do not load default config files at startup > > During emulation, the following keys are useful: > ctrl-alt-f toggle full screen > ctrl-alt-n switch to virtual console 'n' > ctrl-alt toggle mouse and keyboard grab > > When using -nographic, press 'ctrl-a h' to get some help. > > > >

2 2

[libvirt] [PATCH 0/3] Support for marking domains as "tainted"
by Daniel P. Berrange 05 May '11

05 May '11

There are various configurations for virtual domains that we allow, but do not wish to actively support in production environments. The support situation is similar to that of binary only or non-GPL kernel modules, so borrow the kernel's idea of "tainting". When an undesirable configuration is used on a running VM, set a suitable taint flag and log a warning. OS distro bug triagers can see these warnings and decide whether to support users filing bugs in this scenarios

4 7

[libvirt] Error: unable to connect to '/var/run/libvirt/libvirt-sock'
by guan qin 05 May '11

05 May '11

Hi, I meet with the problem that "Error: unable to connect to '/var/run/libvirt/libvirt-sock' ". I do as Error: unable to connect to '/var/run/libvirt/libvirt-sock' <http://wiki.libvirt.org/page/FAQ#Error:_unable_to_connect_to_.27.2Fvar.2Fru…>said but never worked: root@shahe26:~# virsh error: unable to connect to '/var/run/libvirt/libvirt-sock', libvirtd may need to be started: No such file or directory error: failed to connect to the hypervisor root@shahe26:~# ls /usr/lib64 | grep libvirt libvirt libvirt.a libvirt.la libvirt-qemu.a libvirt-qemu.la libvirt-qemu.so libvirt-qemu.so.0 libvirt-qemu.so.0.8.3 libvirt-qemu.so.0.9.0 libvirt.so libvirt.so.0 libvirt.so.0.8.3 libvirt.so.0.9.0 root@shahe26:~# ls /usr/lib32 | grep libvirt root@shahe26:~# /etc/init.d/libvirt-bin restart Restarting libvirt management daemon: /usr/sbin/libvirtd. root@shahe26:~# virsh error: unable to connect to '/var/run/libvirt/libvirt-sock', libvirtd may need to be started: No such file or directory error: failed to connect to the hypervisor root@shahe26:~# I install the libvirt as follows: #./configure --prefix=/usr --libdir=/usr/lib64 #make #make install my OS is debian6.0.1a: root@shahe26:~# uname -a Linux shahe26 2.6.32 #1 SMP Wed Apr 27 21:52:04 PDT 2011 x86_64 GNU/Linux root@shahe26:~# How to solve this problem?thanks. best regards, qinguan

2 2

[libvirt] [PATCH] Fix qemuMigrationToFile nonull annotation
by Daniel P. Berrange 05 May '11

05 May '11

The qemuMigrationToFile method was accidentally annotated for the 'compressor' parameter to be non-null, instead of the 'path' parameter. Thus GCC with -O2, unhelpfully deleted the entire 'if (compressor == NULL)' block of code during optimization. Thus NULL was passed to virCommandNew() with predictably bad results. * src/qemu/qemu_migration.h: Fix non-null annotation to be against path instead of compressor --- src/qemu/qemu_migration.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) This shows that the 'ATTRIBUTE_NONNULL' annotation is actually really very dangerous to use. GCC is incapable of issuing any warnings about callers passing NULL, unless they pass a literal "NULL". If the caller does 'void *p = NULL; foo(p)' it will not warn. GCC is also not warning about the fact that there is a huge block of code for 'if (compressor == NULL)' that is "dead" code and being deleted. While it is perhaps nice to have ATTRIBUTE_NONNULL for static analysis tools like clang, IMHO, it is too dangerous for us to continue to have it enabled in builds. I think we should define it to a no-op macro, unless explicitly enabled with configure. diff --git a/src/qemu/qemu_migration.h b/src/qemu/qemu_migration.h index f4e86c8..c0f3aa2 100644 --- a/src/qemu/qemu_migration.h +++ b/src/qemu/qemu_migration.h @@ -64,7 +64,7 @@ int qemuMigrationToFile(struct qemud_driver *driver, virDomainObjPtr vm, int fd, off_t offset, const char *path, const char *compressor, bool is_reg, bool bypassSecurityDriver) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(6) + ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(5) ATTRIBUTE_RETURN_CHECK; #endif /* __QEMU_MIGRATION_H__ */ -- 1.7.4.4

2 1

[libvirt] Keep qemu capability data for each VM from startup
by Daniel P. Berrange 05 May '11

05 May '11

Currently, whenever we require QEMU capabilities data, we rerun QEMU to extract the info. This isn't desirable because it is inefficient and the QEMU binary may have changed since we started the guest. This series makes us keep a copy of the capability data around for lifetime of the VM process

2 8

Re: [libvirt] the guest killed itself
by Daniel P. Berrange 05 May '11

05 May '11

On Thu, May 05, 2011 at 05:35:37PM +0800, guan qin wrote: > Hi, > Thanks a lot for your reply sincerely! > > some version infoemation: > root@shahe26:~# libvirtd --version > libvirtd (libvirt) 0.9.0 > root@shahe26:~# kvm --version > QEMU PC emulator version 0.12.5 (qemu-kvm-0.12.5), Copyright (c) 2003-2008 > Fabrice Bellard > root@shahe26:~# Ok, I think the problem is your KVM version. You probably need to make the /etc/libvirt/qemu.conf changes I mentioned, to get it to work. > > > > If you have oldish versions, you might need to edit /etc/libvirt/qemu.conf > > and set 'clear_emulator_capabilities = 0', and user=0, group=0 to make QEMU > > run as root with full privileges. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

2 5

[libvirt] the guest killed itself
by guan qin 05 May '11

05 May '11

Hi, I try to use VT-d, but meet with a strange problem . I create a VM through "virsh create ***.xml",as follows: root@shahe26:~# virsh create vt_d_debian.xml Domain vt_d_debian created from vt_d_debian.xml root@shahe26:~# virsh list Id Name State ---------------------------------- 4 vt_d_debian running root@shahe26:~# virsh list Id Name State ---------------------------------- 4 vt_d_debian running root@shahe26:~# virsh list Id Name State ---------------------------------- 4 vt_d_debian running root@shahe26:~# virsh list Id Name State ---------------------------------- 4 vt_d_debian no state root@shahe26:~# virsh list Id Name State ---------------------------------- root@shahe26:~# vim vt_d_debian.xml The VM has already killed itself. user.log: May 4 06:53:30 shahe26 libvirtd: 06:53:30.649: warning : qemudParsePCIDeviceStrs:1422 : Unexpected exit status '1', qemu probably failed May 4 06:53:30 shahe26 libvirtd: 06:53:30.805: warning : qemudParsePCIDeviceStrs:1422 : Unexpected exit status '1', qemu probably failed May 4 06:53:38 shahe26 libvirtd: 06:53:38.393: error : qemuMonitorCommandWithHandler:255 : cannot send monitor command 'info balloon': Connection reset by peer May 4 06:53:38 shahe26 libvirtd: 06:53:38.393: error : qemuMonitorTextGetBalloonInfo:555 : operation failed: could not query memory balloon allocation kern.log: May 4 06:53:30 shahe26 kernel: [ 2249.587662] ixgbe: eth2: ixgbe_remove: complete May 4 06:53:30 shahe26 kernel: [ 2249.587680] ixgbe 0000:02:00.1: PCI INT B disabled May 4 06:53:30 shahe26 kernel: [ 2249.587718] pci-stub 0000:02:00.1: claimed by stub May 4 06:53:30 shahe26 kernel: [ 2249.697347] pci-stub 0000:02:00.1: PCI INT B -> GSI 34 (level, low) -> IRQ 34 May 4 06:53:30 shahe26 kernel: [ 2249.797730] pci-stub 0000:02:00.1: restoring config space at offset 0xf (was 0x200, writing 0x205) May 4 06:53:30 shahe26 kernel: [ 2249.797737] pci-stub 0000:02:00.1: restoring config space at offset 0xc (was 0x0, writing 0xfbd20000) May 4 06:53:30 shahe26 kernel: [ 2249.797745] pci-stub 0000:02:00.1: restoring config space at offset 0x8 (was 0x4, writing 0xfbd1c004) May 4 06:53:30 shahe26 kernel: [ 2249.797751] pci-stub 0000:02:00.1: restoring config space at offset 0x6 (was 0x1, writing 0xd881) May 4 06:53:30 shahe26 kernel: [ 2249.797756] pci-stub 0000:02:00.1: restoring config space at offset 0x4 (was 0x4, writing 0xfbd40004) May 4 06:53:30 shahe26 kernel: [ 2249.797761] pci-stub 0000:02:00.1: restoring config space at offset 0x3 (was 0x800010, writing 0x800040) May 4 06:53:30 shahe26 kernel: [ 2249.797767] pci-stub 0000:02:00.1: restoring config space at offset 0x1 (was 0x100000, writing 0x100143) May 4 06:53:31 shahe26 kernel: [ 2250.050962] assign device: host bdf = 2:0:1 May 4 06:53:37 shahe26 kernel: [ 2256.759165] pci-stub 0000:02:00.1: restoring config space at offset 0xf (was 0x200, writing 0x205) May 4 06:53:37 shahe26 kernel: [ 2256.759173] pci-stub 0000:02:00.1: restoring config space at offset 0xc (was 0x0, writing 0xfbd20000) May 4 06:53:37 shahe26 kernel: [ 2256.759183] pci-stub 0000:02:00.1: restoring config space at offset 0x8 (was 0x4, writing 0xfbd1c004) May 4 06:53:37 shahe26 kernel: [ 2256.759188] pci-stub 0000:02:00.1: restoring config space at offset 0x6 (was 0x1, writing 0xd881) May 4 06:53:37 shahe26 kernel: [ 2256.759192] pci-stub 0000:02:00.1: restoring config space at offset 0x4 (was 0x4, writing 0xfbd40004) May 4 06:53:37 shahe26 kernel: [ 2256.759195] pci-stub 0000:02:00.1: restoring config space at offset 0x3 (was 0x800010, writing 0x800040) May 4 06:53:37 shahe26 kernel: [ 2256.759200] pci-stub 0000:02:00.1: restoring config space at offset 0x1 (was 0x100000, writing 0x100147) May 4 06:53:37 shahe26 kernel: [ 2256.759230] pci-stub 0000:02:00.1: PCI INT B disabled May 4 06:53:38 shahe26 kernel: [ 2257.259706] ixgbe 0000:02:00.1: PCI INT B -> GSI 34 (level, low) -> IRQ 34 May 4 06:53:38 shahe26 kernel: [ 2257.259722] ixgbe 0000:02:00.1: setting latency timer to 64 May 4 06:53:38 shahe26 kernel: [ 2257.382635] ixgbe 0000:02:00.1: irq 105 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382638] ixgbe 0000:02:00.1: irq 106 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382689] ixgbe 0000:02:00.1: irq 128 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382691] ixgbe 0000:02:00.1: irq 129 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382694] ixgbe 0000:02:00.1: irq 130 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382696] ixgbe 0000:02:00.1: irq 131 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382698] ixgbe 0000:02:00.1: irq 132 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382700] ixgbe 0000:02:00.1: irq 133 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382703] ixgbe 0000:02:00.1: irq 134 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382705] ixgbe 0000:02:00.1: irq 135 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382707] ixgbe 0000:02:00.1: irq 136 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382709] ixgbe 0000:02:00.1: irq 137 for MSI/MSI-X May 4 06:53:38 shahe26 kernel: [ 2257.382744] ixgbe: 0000:02:00.1: ixgbe_init_interrupt_scheme: Multiqueue Enabled: Rx Queue count = 16, Tx Queue count = 16 May 4 06:53:38 shahe26 kernel: [ 2257.382749] ixgbe 0000:02:00.1: (PCI Express:5.0Gb/s:Width x8) 00:a0:d1:ec:dc:49 May 4 06:53:38 shahe26 kernel: [ 2257.382834] ixgbe 0000:02:00.1: MAC: 2, PHY: 7, SFP+: 3, PBA No: ffffff-0ff May 4 06:53:38 shahe26 kernel: [ 2257.383724] ixgbe 0000:02:00.1: Intel(R) 10 Gigabit Network Connection libvirt/qemu/vt_d_debian.log LC_ALL=C PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin HOME=/ QEMU_AUDIO_DRV=none /usr/bin/kvm -S -M pc-0.12 -enable-kvm -m 512 -smp 1,sockets=1,cores=1,threads=1 -name vt_d_debian -uuid 5ed196df-319b-7be2-28f4-a070e0ca9d77 -nodefaults -chardev socket,id=monitor,path=/var/lib/libvirt/qemu/vt_d_debian.monitor,server,nowait -mon chardev=monitor,mode=readline -rtc base=utc -boot c -drive file=/root/debian_dev.img,if=none,id=drive-virtio-disk0,boot=on,format=raw -device virtio-blk-pci,bus=pci.0,addr=0x3,drive=drive-virtio-disk0,id=virtio-disk0 -usb -device usb-mouse,id=input0 -vnc 127.0.0.1:0 -vga cirrus -device pci-assign,host=02:00.1,id=hostdev0,bus=pci.0,addr=0x4 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? assigned_dev_pci_read_config: pread failed, ret = 0 errno = 1 I don't know how to solve this problem ,can anyone help me ? best regards, qinguan dmesg information is in the attached file dmesg. <domain type='kvm'> <name>vt_d_debian</name> <description>just test using sriov!</description> <os> <type>hvm</type> <boot dev='hd'/> </os> <memory>524288</memory> <currentMemory>524288</currentMemory> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <features><pae/><acpi/><apic/></features> <clock offset='utc'/> <devices> <input type='mouse' bus='usb'/> <disk type='file' device='disk'> <source file='/root/debian_dev.img'/>  <target dev='hda' bus='virtio'/> </disk> <emulator>/usr/bin/kvm</emulator> <graphics type='vnc' port='-1'/>  <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address bus='0x2' slot='0x0' function='0x1'/> </source> </hostdev>  </devices> </domain>

2 1

[libvirt] Release of libvirt-0.9.1
by Daniel Veillard 05 May '11

05 May '11

As planned and after most of the clang detected problems got fixed (thanks Eric !) the new release is available at: ftp://libvirt.org/libvirt/ It's a mixed release, it includes a number of improvements as well as many bug fixes and a few new features: Features: - support various persistent domain updates (KAMEZAWA Hiroyuki) - improvements on memory APIs (Taku Izumi) - Add virDomainEventRebootNew (Matthias Bolte) - various improvements to libxl driver (Markus Groß) - Spice: support audio, images and stream compression (Michal Privoznik) Documentation: - fix missing VLAN id for Qbg example (Gerhard Stenzel) - docs: Document filesystem tag device (Cole Robinson) - maint: fix comment typos (Eric Blake) - Fix two out-of-date comments in LVM backend (Richard Laager) - docs: Serial and parallel device target ports actually start from 0 (Matthias Bolte) - maint: fix grammar errors (Eric Blake) - docs: document freecell --all (Eric Blake) - docs: remove "returns" word from beginning of lines (Jean-Baptiste Rouault) - docs: add an IPv6 address to network XML examples (Laine Stump) Portability: - build: fix getcwd portability problems (Eric Blake) - build: avoid test warnings on mingw (Eric Blake) - virsh: avoid compiler warning on mingw (Eric Blake) - build: Use pkg-config for libssh2 check (Jiri Denemark) - build: Ignore old audit library (Jiri Denemark) - build: fix 32-bit test failure (Eric Blake) - build: Fix problem of building Python bindings (Osier Yang) - build: fix 32-bit test failure (Eric Blake) - ppc: Enable starting of Qemu VMs on ppc host (Stefan Berger) - Migrate VMs between different-endianess hosts (Stefan Berger) - build: really fix mingw startup (Eric Blake) - build: fix mingw build (Eric Blake) - do not build libvirt_iohelper when building without libvirtd (Wen Congyang) - virsh: fix mingw startup (Eric Blake) - build: avoid compiler warning on cygwin (Eric Blake) - Fix build for older gcc (Jim Fehlig) - Don't try to enable stack protector on Win32 (Daniel P. Berrange) Bug Fixes: - storage: avoid null deref and leak on failure (Eric Blake) - esx: Avoid null dereference on error in esxDomainGetInfo (Matthias Bolte) - remote: avoid null dereference on error (Eric Blake) - cgroup: avoid leaking a file (Eric Blake) - virsh: avoid null pointer dereference (Eric Blake) - pci: fix null pointer dereference (Eric Blake) - qemu: avoid null pointer dereference (Eric Blake) - tests: avoid null pointer dereference (Eric Blake) - Fix disability to run on systems with no PCI bus (Michal Privoznik) - virsh: fix regression in log to file (Supriya Kannery) - nwfilter: Fix memory leak in the ebtables subdriver (Matthias Bolte) - qemu: Fix qemuDomainModifyDeviceFlags leaking the caps bitmap (Matthias Bolte) - Fix memory leak in __virExec (Matthias Bolte) - hash: fix memory leak regression (Eric Blake) - Xen: Do not generate net ifname if domain is inactive (Jim Fehlig) - xen: check if device is assigned to guest before reattaching (Yufang Zhang) - util: Initialize hooks at daemon shutdown if no hooks defined (Osier Yang) - fix virsh's regression (Wen Congyang) - release PCI address only when we have ensured it successfully (Wen Congyang) - free memory properly in cleanup patch (Hu Tao) - free buf content when vsnprintf() failed (Wen Congyang) - esx: Fix dynamic dispatch for CastFromAnyType functions (Matthias Bolte) - Make crash and live flags mutually exclusive in virDomainCoreDump (Mark Wu) - Fix small memory leaks in config parsing related functions (Matthias Bolte) - daemon: Don't try to free an unsigned int in error paths (Matthias Bolte) - Fix QEMU tunnelled migration FD handling (Daniel P. Berrange) - Remove artificial minimum limit for guest memory (Jiri Denemark) - fix tunnelled migration's regression (Wen Congyang) - qemu: fix the check of virDomainObjUnref()'s return value (Wen Congyang) - Fix checking of return codes in dispatcher (Daniel P. Berrange) - qemu: avoid qemu_driver being unlocked twice when virThreadPoolNew() failed (Wen Congyang) - virsh: fix regression in parsing optional integer (Eric Blake) - phyp: avoid memory leaks in command values (Eric Blake) - phyp: avoid memory leak on failure (Eric Blake) - phyp: avoid a logic bug (Eric Blake) - free cpumask of vcpupinDef (Hu Tao) - network: Fix NULL dereference during error recovery (Michal Privoznik) - Add missing checks for QEMU domain state in tunables APIs (Daniel P. Berrange) - phyp: Fix too small buffer allocation in phypAttachDevice (Matthias Bolte) - phyp: Don't overwrite error from virDomainDeviceDefParse by OOM error (Matthias Bolte) - phyp: Don't try to use a string from a failed virAsprintf (Matthias Bolte) - phyp: Remove stack allocating a 4kb volume key and fix related memory leaks (Matthias Bolte) - qemu: fix a dead-lock problem (Hu Tao) - util: Fix crash when removing entries during hash iteration (Jiri Denemark) - Fix possible infinite loop in remote driver (Michal Privoznik) - qemu: Remove the managed state file only if restoring succeeded (Osier Yang) - reattach pci devices when qemuPrepareHostdevPCIDevices() failed (Wen Congyang) - reattach pci device when pciBindDeviceToStub() failed (Wen Congyang) - remove devices from driver activePciHostdevs when qemuPrepareHostdevPCIDevices() failed (Wen Congyang) - pci: avoid invalid free, init path to NULL (Wen Congyang) - qemu: Support for overriding NPROC limit (Jiri Denemark) - qemu: Always reserves slot 0x02 for primary VGA. (Osier Yang) - Fix typo in systemtap tapset directory name (Daniel P. Berrange) - qemu: Ignore unusable binaries (Jiri Denemark) Improvements: - maint: detect clang 2.9 (Eric Blake) - qemu: update qemuCgroupControllerActive signature (Eric Blake) - lxc: report correct error (Eric Blake) - libxl: avoid compiler warning (Eric Blake) - storage: use virCommand to avoid compiler warning (Eric Blake) - tests: Lower stack usage below 4096 bytes (Matthias Bolte) - tests: Update valgrind suppressions file (Matthias Bolte) - tests: simplify common setup (Eric Blake) - network: fix return value of hostsFileWrite (Laine Stump) - libvirt/qemu - support persistent attach/detach disks (KAMEZAWA Hiroyuki) - libvirt/qemu - support persistent modification of devices (KAMEZAWA Hiroyuki) - util: Simplify hash implementation (Jiri Denemark) - tests: More unit tests for internal hash APIs (Jiri Denemark) - Move call to virReportOOMError into virFileBuildPath (Matthias Bolte) - build: use gnulib passfd for simpler SCM_RIGHTS code (Eric Blake) - qemu: Add flags checking in DomainCoreDump (Jiri Denemark) - Make sure DNSMASQ_STATE_DIR exists (Guido Günther) - build: make VIR_FREE do some type checking (Eric Blake) - threads: add one-time initialization support (Eric Blake) - esx: Add a wrapper for shared CURL handles (Matthias Bolte) - esx: Move CURL handling code to it's own type (Matthias Bolte) - daemon: Honor error variable name change in the generator (Matthias Bolte) - libvirt/qemu - clean up UpdateDevice for consolidation. (KAMEZAWA Hiroyuki) - libvirt/qemu - clean up At(De)tachDeviceFlags() for consolidation. (KAMEZAWA Hiroyuki) - libvirt/qemu - Centralize device modification in the more flexible APIs (KAMEZAWA Hiroyuki) - Add support for s390(x) cpu options parsing (Michal Privoznik) - PHYP: Adding reboot domain function (Eduardo Otubo) - nwfilter: no support for direct type of interface (Stefan Berger) - Add cputune support to libxl driver (Markus Groß) - Update and sort msg_gen_function list and mark unmarked messages (Matthias Bolte) - Write error check conditionals in more compact form for dispatcher (Daniel P. Berrange) - Merge all returns paths from dispatcher into single path (Daniel P. Berrange) - Experimental libvirtd upstart job (Alan Pevec) - enhance processWatchdogEvent() (Wen Congyang) - xen: Replace statsErrorFunc with a macro (Matthias Bolte) - tests: Unit tests for internal hash APIs (Jiri Denemark) - build: include esx_vi.generated.* into dist file (Wen Congyang) - tests: test recent virsh option parsing changes (Eric Blake) - virsh: list required options first (Eric Blake) - phyp: use consistent return string handling (Eric Blake) - maint: use lighter-weight function for straight appends (Eric Blake) - libvirt-guests: implement START_DELAY (Alexander Todorov) - network: truncate bridges' dummy tap device names to IFNAMSIZ (15) chars (Laine Stump) - Introduce virDomainChrDefNew() (Michal Novotny) - esx: Make the parsed URI part of the private connection data (Matthias Bolte) - esx: Mark error message in macros for translation (Matthias Bolte) - esx: Extend VI generator to cover managed object types (Matthias Bolte) - esx: Cleanup and refactor CastFromAnyType macros (Matthias Bolte) - esx: Cleanup VI generator code (Matthias Bolte) - phyp: Reduce code duplication in error and success paths (Matthias Bolte) - Replace REMOTE_DEBUG with VIR_DEBUG in daemon dispatcher (Daniel P. Berrange) - Add missing checks for whether the connection is open in dispatcher (Daniel P. Berrange) - PHYP: Adding network interface (Eduardo Otubo) - xen: Remove PATH_MAX sized stack allocation from block stats code (Matthias Bolte) - setmaxmem: add the new options to "virsh setmaxmem" command (Taku Izumi) - maxmem: implement virDomainSetMaxMemory API of the qemu driver (Taku Izumi) - maxmem: introduces VIR_DOMAIN_MEM_MAXIMUM flag (Taku Izumi) - nwfilters: support for TCP flags evaluation (Stefan Berger) - setmem: add --current option to virsh setmem command (Taku Izumi) - setmem: add VIR_DOMAIN_MEM_CURRENT support to qemu (Taku Izumi) - setmem: introduce VIR_DOMAIN_MEM_CURRENT flag (Taku Izumi) - build: Install libxenlight log dir (Jim Fehlig) - Add domainSet/GetSchedulerParameters to libxl driver (Markus Groß) - rename pciUnBindDeviceFromStub() to pciUnbindDeviceFromStub() and float it up (Wen Congyang) - Add domainIsUpdated to libxl driver (Markus Groß) - Change locking for udev monitor and callbacks (Serge Hallyn) - Improve SCSI volume key generation (Daniel P. Berrange) - qemu: Rewrite LOOKUP_PTYS macro into a function (Jiri Denemark) - Enable use of -Wold-style-definition compiler flag (Daniel P. Berrange) - Enable use of -Wmissing-noreturn (Daniel P. Berrange) - Enable -Wmissing-format-attribute warning (Daniel P. Berrange) - Use gnulib's manywarnings and warnings modules (Daniel P. Berrange) - Use virBufferPtr for sexpr2string instead of manual buffer handling (Matthias Bolte) - xend: Remove 4kb stack allocation (Matthias Bolte) - uml: Remove PATH_MAX sized stack allocation from /proc parsing code (Matthias Bolte) - storage: Remove PATH_MAX sized stack allocation from iSCSI backend (Matthias Bolte) - qemu: Remove PATH_MAX sized stack allocation used in commandline building (Matthias Bolte) - Remove PATH_MAX sized stack allocation from virFileOpenTtyAt (Matthias Bolte) - openvz: Remove several larger stack allocations (Matthias Bolte) - daemon: Remove 4kb stack allocation of security label (Matthias Bolte) - virsh: Remove two 4kb stack allocations (Matthias Bolte) - Use virFileAbsPath instead of manually creating the absolute path (Matthias Bolte) - xenxs: Remove PATH_MAX sized stack allocation in XM script parsing (Matthias Bolte) - sasl: Remove stack allocated 8kb temporary buffers (Matthias Bolte) - qemu: Use heap allocated memory to read the monitor greeting (Matthias Bolte) - phyp: Remove 16kb stack allocation (Matthias Bolte) - virt-aa-helper: Remove PATH_MAX sized stack allocations (Matthias Bolte) - ebtables: Remove PATH_MAX sized stack allocation (Matthias Bolte) - pci: Remove PATH_MAX sized stack allocations (Matthias Bolte) - Remove PATH_MAX sized stack allocations related to virFileBuildPath (Matthias Bolte) - vmx: Use case-insensitive compare functions for all content (Matthias Bolte) - vmx: Support persistent CPU shares (Matthias Bolte) - Add autostart support to libxl driver (Markus Groß) - Allow relative path for qemu backing file (Jesse Cook) - build: detect potentential uninitialized variables (Eric Blake) Cleanups: - esx: Disable performance counter queries in esxDomainGetInfo (Matthias Bolte) - esx: Remove dead store in esxUtil_ParseDatastorePath (Matthias Bolte) - util: remove dead assignment (Eric Blake) - qemu: remove dead assignment (Eric Blake) - qemu: silence clang false positives (Eric Blake) - tests: suppress more valgrind situations (Eric Blake) - tests: avoid compiler warning (Eric Blake) - qemu: fix uninitialized variable warning (Christophe Fergeau) - build: fix syntax-check failure (Eric Blake) - virsh: nuke use of TRUE and FALSE (Eric Blake) - phyp: another simplification (Eric Blake) - maint: ignore built file (Eric Blake) - Change some variable names to follow standard in daemon dispatcher (Daniel P. Berrange) - Remove curly braces on all single-line conditional jumps in dispatcher (Daniel P. Berrange) - Remove virConnectPtr from virRaiseErrorFull (Matthias Bolte) - phyp: prefer memcpy over memmove when legal (Eric Blake) - phyp: use consistent style for labels (Eric Blake) - phyp: more return handling cleanup (Eric Blake) - esx: Fix gcc 4.6 warning about initialized but unused variables (Matthias Bolte) - maint: silence cppi warnings (Eric Blake) - Fix gcc 4.6 warnings in vbox_tmpl.c (Christophe Fergeau) - Fix gcc 4.6 warnings (Christophe Fergeau) - Remove C99 variable declare in PHYP network driver (Daniel P. Berrange) - Standard on error variable name in libvirtd dispatcher (Daniel P. Berrange) - Remove all whitespace before function brackets in daemon dispatcher (Daniel P. Berrange) - docs: tweak virsh restore warning (Eric Blake) - setmaxmem: remove the code to invoke virDomainSetMemory in cmdSetmaxmem (Taku Izumi) - build: fix gitignore sorting (Eric Blake) - tests: fix recent test failures (Eric Blake) - libxl: avoid compiler warning (Eric Blake) - Avoid compiler warnings about int to void * casts (Daniel P. Berrange) - Remove acinclude.m4 file (Daniel P. Berrange) - Remove possible uninitialized variable in openvz driver (Daniel P. Berrange) Thanks to everybody who helped with this release in any way, bug reports, documentation, patches or features ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] maint: detect clang 2.9
by Eric Blake 04 May '11

04 May '11

In Fedora 15, with clang 2.8, 'scan-build env' shows: CCC_ANALYZER_ANALYSIS=-analyzer-check-objc-mem -analyzer-check-security-syntactic -analyzer-check-dead-stores -analyzer-check-objc-unused-ivars -analyzer-check-objc-methodsigs But in rawhide, with clang 2.9, the same variable is set but empty, implying the default set of analysis. We still want sa_assert defined in that case, to stop clang from hitting false positives. * configure.ac (STATIC_ANALYSIS): Detect clang even when the set of analyses is the default. --- I'm pushing this under the trivial rule. It has no effect on a real build, but makes it easier for me to repeat my clang testing on rawhide. configure.ac | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure.ac b/configure.ac index 7c68bca..314a594 100644 --- a/configure.ac +++ b/configure.ac @@ -2297,7 +2297,7 @@ cp -f COPYING.LIB COPYING # Detect when running under the clang static analyzer's scan-build driver # or Coverity-prevent's cov-build. Define STATIC_ANALYSIS accordingly. -test -n "$CCC_ANALYZER_ANALYSIS$COVERITY_BUILD_COMMAND" && t=1 || t=0 +test -n "${CCC_ANALYZER_ANALYSIS+set}$COVERITY_BUILD_COMMAND" && t=1 || t=0 AC_DEFINE_UNQUOTED([STATIC_ANALYSIS], [$t], [Define to 1 when performing static analysis.]) -- 1.7.4.4

1 0

[libvirt] [PATCH] storage: avoid null deref and leak on failure
by Eric Blake 04 May '11

04 May '11

Detected by clang. NULL deref added in commit 343a27a (Mar 11), but leak of voldef present since commit 2cd9b2d (Apr 09). * src/storage/storage_driver.c (storageVolumeCreateXML): Don't leak voldef or dereference null volobj. --- src/storage/storage_driver.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 1ea5d12..19c7d63 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1319,8 +1319,10 @@ storageVolumeCreateXML(virStoragePoolPtr obj, pool->volumes.objs[pool->volumes.count++] = voldef; volobj = virGetStorageVol(obj->conn, pool->def->name, voldef->name, voldef->key); + if (!volobj) + goto cleanup; - if (volobj && backend->buildVol) { + if (backend->buildVol) { int buildret; virStorageVolDefPtr buildvoldef = NULL; -- 1.7.4.4

2 5

[libvirt] qemu qxl video memory parameter - windows bsod with spice
by Emre Erenoglu 04 May '11

04 May '11

Hi, Please see the below discussion with the spice community. libvirt is adding a parameter about video ram to qemu process and this parameter might be responsible of a crash in the qxl at higher resolutions. Spice people tell me that their default ram should be 64 Mbytes. I'm using libvirt 0.9.0 and qemu 0.14, virt-manager 0.8.7. When configuring a guest in virt-manager, cirrus driver is added as default, then you can change it to qxl, but the 9 MB videoram parameter can't be adjusted and it does not automatically change to 64 MB. If you add a 2nd qxl video card, then it has 64 MB memory. The parameter that qemu gets with one qxl device is: -vga qxl -global qxl-vga.vram_size=9437184 The parameter that qemu gets with a second qxl device is: -vga qxl -global qxl-vga.vram_size=9437184 -device qxl,id=video1,vram_size=67108864,bus=pci.0,addr=0x8 Is this a bug in libvirt or other related tools? Thanks, Br, Emre ---------- Forwarded message ---------- From: Emre Erenoglu <erenoglu(a)gmail.com> Date: Wed, May 4, 2011 at 7:42 PM Subject: Re: [Spice-devel] windows bsod with spice 0.8.1 To: Emre Erenoglu <erenoglu(a)gmail.com>, spice-devel(a)freedesktop.org On Wed, May 4, 2011 at 6:00 PM, Alon Levy <alevy(a)redhat.com> wrote: > On Wed, May 04, 2011 at 05:10:31PM +0400, Emre Erenoglu wrote: > > On Wed, May 4, 2011 at 2:12 PM, Alon Levy <alevy(a)redhat.com> wrote: > > > > > On Wed, May 04, 2011 at 01:45:39PM +0400, Emre Erenoglu wrote: > > > > On Wed, Apr 27, 2011 at 1:16 AM, Emre Erenoglu <erenoglu(a)gmail.com> > > > wrote: > > > > > > > > > Hi, > > > > > > > > > > I started to see frequent crashes with my guests running windows xp > and > > > > > windows server 2003 x86. The bsod appears on qxldd.dll. I can give > > > further > > > > > info if needed. > > > > > > > > > > The host is Linux x86_64, qemu 0.14, spice 0.8.1. Guest has qxl > 0.6.1 > > > > > drivers loaded. I may revert back to 0.8.0 since it was not > crashing. > > > > > Nothing changed in the guests when I upgraded spice from 0.8.0 to > > > 0.8.1. > > > > > > > > > > > > > > Some updates on the original issue. I checked a lot and I found out > that > > > the > > > > issue continued with any version of spice and guest qxl drivers. > > > > > > > > I finally digged down to the point that, the qemu comment line which > > > states > > > > " -global qxl-vga.vram_size=9xxxxxx " parameter is the problem. > When > > > the > > > > guest is started with 9 MB of video memory given as comment line > > > parameter > > > > to qemu, the guest qxldd driver crashes with BSOD. > > > > > > Why was it started with 9MB? anyway, good catch, we should add a check > for > > > this > > > in the driver (and probably just refuse to load). Could you open a bug > on > > > this > > > in bugzilla.freedesktop.org? > > > > > > > This is added by libvirt (virt-manager) when launching qemu. Do we need > to > > file it against libvirt or against spice? I will post this to the > libvirt > > list also. > > > > Btw, rather than refusing to load, I think we should just limit the > possible > > resolutions. I'm not sure if the resolutions are the issue though. The > crash > > was not happening immediately and it was working OK with that 9 MB > memory. > > When I launched outlook, or IE8, or just in the middle of an application, > it > > could crash and bsod. > > But that number doesn't make any sense - the spice default is 64MB, we > never tested > with less then that. It is probably fixable like you say, but until that's > fixed why > not stick to the spice default? Well, this parameter is not configurable from the virt-manager UI and it configures 9 MB to the command line of qemu by libvirt (even latest 0.9.0) version. When you add a 2nd VGA adapter, it adds 64 MB to that adapter correctly (-device qxl,id=video1,vram_size=67108864,bus=pci.0,addr=0x8) I guess i need to file a bug report to libvirt too. Emre

4 5

[libvirt] [PATCH] esx: avoid null dereference on error
by Eric Blake 04 May '11

04 May '11

Detected by clang. * src/esx/esx_driver.c (esxDomainGetInfo): Fail early on error. --- src/esx/esx_driver.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 1f8f90b..e929208 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -2372,8 +2372,9 @@ esxDomainGetInfo(virDomainPtr domain, virDomainInfoPtr info) if (perfEntityMetric == NULL) { VIR_ERROR(_("QueryPerf returned object with unexpected type '%s'"), esxVI_Type_ToString(perfEntityMetricBase->_type)); + goto cleanup; } perfMetricIntSeries = esxVI_PerfMetricIntSeries_DynamicCast(perfEntityMetric->value); -- 1.7.4.4

4 4

[libvirt] [PATCH] remote: avoid null dereference on error
by Eric Blake 04 May '11

04 May '11

Clang found three instances of uninitialized use of nparams in the cleanup path. Unfortunately, one is a false positive: clang couldn't see that ret->params.params_val is guaranteed to be NULL unless allocated within a function, and that nparams is guaranteed to be assigned prior to the allocation; hoisting the assignment to nparams to be earlier in the function shuts up that false positive. But two of the reports also happened to highlight a real bug - the error path can dereference NULL. * daemon/remote.c (remoteDispatchDomainGetMemoryParameters) (remoteDispatchDomainGetBlkioParameters): Don't clear fields if array was not allocated. (remoteDispatchDomainGetSchedulerParameters): Initialize nparams earlier. --- daemon/remote.c | 29 ++++++++++++++++------------- 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index eedbc77..214f7a4 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -886,7 +886,8 @@ remoteDispatchDomainGetSchedulerParameters(struct qemud_server *server ATTRIBUTE { virDomainPtr dom = NULL; virSchedParameterPtr params = NULL; - int i, nparams; + int i; + int nparams = args->nparams; int rv = -1; if (!conn) { @@ -894,8 +895,6 @@ remoteDispatchDomainGetSchedulerParameters(struct qemud_server *server ATTRIBUTE goto cleanup; } - nparams = args->nparams; - if (nparams > REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX) { virNetError(VIR_ERR_INTERNAL_ERROR, "%s", _("nparams too large")); goto cleanup; @@ -2970,7 +2969,8 @@ remoteDispatchDomainGetMemoryParameters(struct qemud_server *server { virDomainPtr dom = NULL; virMemoryParameterPtr params = NULL; - int i, nparams; + int i; + int nparams = args->nparams; unsigned int flags; int rv = -1; @@ -2979,7 +2979,6 @@ remoteDispatchDomainGetMemoryParameters(struct qemud_server *server goto cleanup; } - nparams = args->nparams; flags = args->flags; if (nparams > REMOTE_DOMAIN_MEMORY_PARAMETERS_MAX) { @@ -3060,9 +3059,11 @@ success: cleanup: if (rv < 0) { remoteDispatchError(rerr); - for (i = 0; i < nparams; i++) - VIR_FREE(ret->params.params_val[i].field); - VIR_FREE(ret->params.params_val); + if (ret->params.params_val) { + for (i = 0; i < nparams; i++) + VIR_FREE(ret->params.params_val[i].field); + VIR_FREE(ret->params.params_val); + } } if (dom) virDomainFree(dom); @@ -3186,7 +3187,8 @@ remoteDispatchDomainGetBlkioParameters(struct qemud_server *server { virDomainPtr dom = NULL; virBlkioParameterPtr params = NULL; - int i, nparams; + int i; + int nparams = args->nparams; unsigned int flags; int rv = -1; @@ -3195,7 +3197,6 @@ remoteDispatchDomainGetBlkioParameters(struct qemud_server *server goto cleanup; } - nparams = args->nparams; flags = args->flags; if (nparams > REMOTE_DOMAIN_BLKIO_PARAMETERS_MAX) { @@ -3276,9 +3277,11 @@ success: cleanup: if (rv < 0) { remoteDispatchError(rerr); - for (i = 0; i < nparams; i++) - VIR_FREE(ret->params.params_val[i].field); - VIR_FREE(ret->params.params_val); + if (ret->params.params_val) { + for (i = 0; i < nparams; i++) + VIR_FREE(ret->params.params_val[i].field); + VIR_FREE(ret->params.params_val); + } } VIR_FREE(params); if (dom) -- 1.7.4.4

2 3

[libvirt] [PATCH] esx: remove dead store
by Eric Blake 04 May '11

04 May '11

Detected by clang. * src/esx/esx_util.c (esxUtil_ParseDatastorePath): No need to increment. --- src/esx/esx_util.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c index 9ef947c..640e984 100644 --- a/src/esx/esx_util.c +++ b/src/esx/esx_util.c @@ -2,7 +2,7 @@ /* * esx_util.c: utility functions for the VMware ESX driver * - * Copyright (C) 2010 Red Hat, Inc. + * Copyright (C) 2010-2011 Red Hat, Inc. * Copyright (C) 2009 Matthias Bolte <matthias.bolte(a)googlemail.com> * Copyright (C) 2009 Maximilian Wilhelm <max(a)rfc2324.org> * @@ -332,7 +332,7 @@ esxUtil_ParseDatastorePath(const char *datastorePath, char **datastoreName, preliminaryFileName = strrchr(preliminaryDirectoryAndFileName, '/'); if (preliminaryFileName != NULL) { - *preliminaryFileName++ = '\0'; + *preliminaryFileName = '\0'; } if (esxVI_String_DeepCopyValue(directoryName, -- 1.7.4.4

3 4

[libvirt] [PATCH] cgroup: avoid leaking a file
by Eric Blake 04 May '11

04 May '11

Clang detected a dead store to rc. It turns out that in fixing this, I also found a FILE* leak. * src/util/cgroup.c (virCgroupKillInternal): Abort rather than resuming loop on fscanf failure, and cleanup file on error. --- As a bonus, this also fixes a decl-after-statement for fp. src/util/cgroup.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/util/cgroup.c b/src/util/cgroup.c index afe8731..62b371d 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -1351,7 +1351,9 @@ static int virCgroupKillInternal(virCgroupPtr group, int signum, virHashTablePtr int killedAny = 0; char *keypath = NULL; bool done = false; - VIR_DEBUG("group=%p path=%s signum=%d pids=%p", group, group->path, signum, pids); + FILE *fp = NULL; + VIR_DEBUG("group=%p path=%s signum=%d pids=%p", + group, group->path, signum, pids); rc = virCgroupPathOfController(group, -1, "tasks", &keypath); if (rc != 0) { @@ -1364,7 +1366,6 @@ static int virCgroupKillInternal(virCgroupPtr group, int signum, virHashTablePtr */ while (!done) { done = true; - FILE *fp; if (!(fp = fopen(keypath, "r"))) { rc = -errno; VIR_DEBUG("Failed to read %s: %m\n", keypath); @@ -1376,7 +1377,8 @@ static int virCgroupKillInternal(virCgroupPtr group, int signum, virHashTablePtr if (feof(fp)) break; rc = -errno; - break; + VIR_DEBUG("Failed to read %s: %m\n", keypath); + goto cleanup; } if (virHashLookup(pids, (void*)pid)) continue; @@ -1403,6 +1405,7 @@ static int virCgroupKillInternal(virCgroupPtr group, int signum, virHashTablePtr cleanup: VIR_FREE(keypath); + VIR_FORCE_FCLOSE(fp); return rc; } -- 1.7.4.4

3 5

[libvirt] [PATCH] qemu: update qemuCgroupControllerActive signature
by Eric Blake 04 May '11

04 May '11

Clang warned about a dead assignment. In the process, I noticed that we are only using the function for a bool value. I audited all other callers in qemu_{migration,cgroup,driver,hotplug), and all were making the call in a bool context. * src/qemu/qemu_cgroup.c (qemuSetupCgroup): Delete dead assignment. (qemuCgroupControllerActive): Change return type to bool. * src/qemu/qemu_cgroup.h (qemuCgroupControllerActive): Likewise. --- src/qemu/qemu_cgroup.c | 14 +++++++------- src/qemu/qemu_cgroup.h | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 7e88a67..ac1c016 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -43,16 +43,16 @@ static const char *const defaultDeviceACL[] = { #define DEVICE_PTY_MAJOR 136 #define DEVICE_SND_MAJOR 116 -int qemuCgroupControllerActive(struct qemud_driver *driver, - int controller) +bool qemuCgroupControllerActive(struct qemud_driver *driver, + int controller) { if (driver->cgroup == NULL) - return 0; + return false; if (!virCgroupMounted(driver->cgroup, controller)) - return 0; + return false; if (driver->cgroupControllers & (1 << controller)) - return 1; - return 0; + return true; + return false; } static int @@ -312,7 +312,7 @@ int qemuSetupCgroup(struct qemud_driver *driver, if (vm->def->mem.hard_limit != 0 || vm->def->mem.soft_limit != 0 || vm->def->mem.swap_hard_limit != 0) { - if ((rc = qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_MEMORY))) { + if (qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_MEMORY)) { if (vm->def->mem.hard_limit != 0) { rc = virCgroupSetMemoryHardLimit(cgroup, vm->def->mem.hard_limit); if (rc != 0) { diff --git a/src/qemu/qemu_cgroup.h b/src/qemu/qemu_cgroup.h index 299bd2d..e8abfb4 100644 --- a/src/qemu/qemu_cgroup.h +++ b/src/qemu/qemu_cgroup.h @@ -34,8 +34,8 @@ struct _qemuCgroupData { }; typedef struct _qemuCgroupData qemuCgroupData; -int qemuCgroupControllerActive(struct qemud_driver *driver, - int controller); +bool qemuCgroupControllerActive(struct qemud_driver *driver, + int controller); int qemuSetupDiskCgroup(struct qemud_driver *driver, virDomainObjPtr vm, virCgroupPtr cgroup, -- 1.7.4.4

2 2

[libvirt] [PATCH] lxc: report correct error
by Eric Blake 04 May '11

04 May '11

Clang noticed a dead assignment, which turned out to be the use of the wrong variable. rc starts life as -1, and is only ever assigned to 0 just before a successful cleanup. * src/lxc/lxc_driver.c (lxcSetupInterfaces): Don't call virReportSystemError(-1). --- src/lxc/lxc_driver.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index e905302..b94941d 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1100,10 +1100,9 @@ static int lxcSetupInterfaces(virConnectPtr conn, } if ((ret = brAddInterface(brctl, bridge, parentVeth)) != 0) { - virReportSystemError(rc, + virReportSystemError(ret, _("Failed to add %s device to %s"), parentVeth, bridge); - rc = -1; goto error_exit; } -- 1.7.4.4

2 2

[libvirt] [PATCH] util: remove dead assignment
by Eric Blake 04 May '11

04 May '11

Clang complained about this, and it was easy enough to fix. * src/util/util.c (virFileOpenAs): Drop dead assignment. --- src/util/util.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 37472bb..9041ab6 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1523,8 +1523,7 @@ virFileOpenAs(const char *path, int openflags, mode_t mode, if (ret < 0 && errno != EACCES) { ret = -errno; VIR_FORCE_CLOSE(pair[0]); - while ((waitret = waitpid(pid, NULL, 0) == -1) - && (errno == EINTR)); + while (waitpid(pid, NULL, 0) == -1 && errno == EINTR); goto parenterror; } else { fd = ret; -- 1.7.4.4

2 2

[libvirt] [PATCH] libxl: avoid compiler warning
by Eric Blake 04 May '11

04 May '11

Detected by gcc: libxl/libxl_driver.c: In function 'libxlDomainDestroy': libxl/libxl_drier.c:1351:30: error: variable 'priv' set but not used [-Werror=unused-but-set-variable] * src/libxl/libxl_driver.c (libxlDomainDestroy): Delete unused variable. --- Trivial, so pushing under the build-breaker rule. src/libxl/libxl_driver.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 247d78e..dec4f43 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -1348,7 +1348,6 @@ libxlDomainDestroy(virDomainPtr dom) libxlDriverPrivatePtr driver = dom->conn->privateData; virDomainObjPtr vm; int ret = -1; - libxlDomainObjPrivatePtr priv; virDomainEventPtr event = NULL; libxlDriverLock(driver); @@ -1370,7 +1369,6 @@ libxlDomainDestroy(virDomainPtr dom) event = virDomainEventNewFromObj(vm,VIR_DOMAIN_EVENT_STOPPED, VIR_DOMAIN_EVENT_STOPPED_DESTROYED); - priv = vm->privateData; if (libxlVmReap(driver, vm, 1) != 0) { libxlError(VIR_ERR_INTERNAL_ERROR, _("Failed to destroy domain '%d'"), dom->id); -- 1.7.4.4

1 0

[libvirt] [PATCH] qemu: remove dead assignment
by Eric Blake 04 May '11

04 May '11

Detected by clang. * src/qemu/qemu_migration.c (qemuMigrationToFile): Nothing later uses is_reg. --- src/qemu/qemu_migration.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 7f4b111..6c5bf66 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1311,7 +1311,6 @@ qemuMigrationToFile(struct qemud_driver *driver, virDomainObjPtr vm, if (virSecurityManagerSetFDLabel(driver->securityManager, vm, compressor ? pipeFD[1] : fd) < 0) goto cleanup; - is_reg = true; bypassSecurityDriver = true; } else { /* Phooey - we have to fall back on exec migration, where qemu -- 1.7.4.4

2 2

[libvirt] [PATCH] storage: use virCommand to avoid compiler warning
by Eric Blake 04 May '11

04 May '11

clang didn't like the last increment to nargs. But why even track nargs ourselves, when virCommand does it for us? * src/storage/storage_backend_iscsi.c (virStorageBackendISCSIConnection): Switch to virCommand to avoid a dead-store warning on nargs. --- src/storage/storage_backend_iscsi.c | 36 ++++++++-------------------------- 1 files changed, 9 insertions(+), 27 deletions(-) diff --git a/src/storage/storage_backend_iscsi.c b/src/storage/storage_backend_iscsi.c index d86f077..ec52dbc 100644 --- a/src/storage/storage_backend_iscsi.c +++ b/src/storage/storage_backend_iscsi.c @@ -42,6 +42,7 @@ #include "memory.h" #include "logging.h" #include "files.h" +#include "command.h" #define VIR_FROM_THIS VIR_FROM_STORAGE @@ -348,28 +349,11 @@ virStorageBackendISCSIConnection(const char *portal, "--targetname", target, NULL }; - int i; - int nargs = 0; + virCommandPtr cmd; char *ifacename = NULL; - const char **cmdargv; - - for (i = 0 ; baseargv[i] != NULL ; i++) - nargs++; - for (i = 0 ; extraargv[i] != NULL ; i++) - nargs++; - if (initiatoriqn) - nargs += 2; - - if (VIR_ALLOC_N(cmdargv, nargs+1) < 0) { - virReportOOMError(); - return -1; - } - nargs = 0; - for (i = 0 ; baseargv[i] != NULL ; i++) - cmdargv[nargs++] = baseargv[i]; - for (i = 0 ; extraargv[i] != NULL ; i++) - cmdargv[nargs++] = extraargv[i]; + cmd = virCommandNewArgs(baseargv); + virCommandAddArgSet(cmd, extraargv); if (initiatoriqn) { switch (virStorageBackendIQNFound(initiatoriqn, &ifacename)) { @@ -377,7 +361,8 @@ virStorageBackendISCSIConnection(const char *portal, VIR_DEBUG("ifacename: '%s'", ifacename); break; case IQN_MISSING: - if (virStorageBackendCreateIfaceIQN(initiatoriqn, &ifacename) != 0) { + if (virStorageBackendCreateIfaceIQN(initiatoriqn, + &ifacename) != 0) { goto cleanup; } break; @@ -385,19 +370,16 @@ virStorageBackendISCSIConnection(const char *portal, default: goto cleanup; } - - cmdargv[nargs++] = "--interface"; - cmdargv[nargs++] = ifacename; + virCommandAddArgList(cmd, "--interface", ifacename, NULL); } - cmdargv[nargs++] = NULL; - if (virRun(cmdargv, NULL) < 0) + if (virCommandRun(cmd, NULL) < 0) goto cleanup; ret = 0; cleanup: - VIR_FREE(cmdargv); + virCommandFree(cmd); VIR_FREE(ifacename); return ret; -- 1.7.4.4

2 2

[libvirt] pci device passthrough: Failed to assign irq
by guan qin 04 May '11

04 May '11

Hi, I encounter a problem that the eth can't be up in the VM by using VT-d. I boot the VM using "virsh create vt_d.xml". The VM could recongize the NIC which was assigned .then I do in VM as follows: #cat /sys/class/net/eth0/operstate down #ifconfig eth0 up #cat /sys/class/net/eth0/operstate down #ficonfig eth 10.100.0.5 #cat /sys/class/net/eth0/operstate down I look into the qemu log file ,find that : LC_ALL=C PATH=/usr/local/sbin:/usr/ local/bin:/sbin:/bin:/usr/sbin:/usr/bin HOME=/ QEMU_AUDIO_DRV=none /usr/bin/kvm -S -M pc-0.12 -enable-kvm -m 512 -smp 1,sockets=1,cores=1,threads=1 -name vt_d_5 -uuid 05f608a3-f64f-2418-a90a-d611982c8336 -nodefaults -chardev socket,id=monitor,path=/var/lib/libvirt/qemu/vt_d_5.monitor,server,nowait -mon chardev=monitor,mode=readline -rtc base=utc -boot c -drive file=/home/qinguan/exp/kvm_vtd/ubuntu_1.img,if=none,id=drive-virtio-disk0,boot=on,format=raw -device virtio-blk-pci,bus=pci.0,addr=0x3,drive=drive-virtio-disk0,id=virtio-disk0 -usb -device usb-mouse,id=input0 -vnc 127.0.0.1:0 -vga cirrus -device pci-assign,host=00:19.0,id=hostdev0,bus=pci.0,addr=0x4 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x5 Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted Perhaps you are assigning a device that shares an IRQ with another device? Failed to assign irq for "hostdev0": Operation not permitted maybe the VM can't access to the network because of Failed to assign irg for "hostdev0"? in kern.log : May 1 12:40:07 Optiplex-780 kernel: [ 3172.784803] e1000e 0000:00:19.0: PCI INT A disabled May 1 12:40:07 Optiplex-780 kernel: [ 3172.784863] pci-stub 0000:00:19.0: claimed by stub May 1 12:40:07 Optiplex-780 kernel: [ 3173.103965] pci-stub 0000:00:19.0: PCI INT A -> GSI 21 (level, low) -> IRQ 21 May 1 12:40:07 Optiplex-780 kernel: [ 3173.204030] pci-stub 0000:00:19.0: restoring config space at offset 0x6 (was 0x1, writing 0xece1) May 1 12:40:07 Optiplex-780 kernel: [ 3173.204035] pci-stub 0000:00:19.0: restoring config space at offset 0x5 (was 0x0, writing 0xf7ad9000) May 1 12:40:07 Optiplex-780 kernel: [ 3173.204039] pci-stub 0000:00:19.0: restoring config space at offset 0x4 (was 0x0, writing 0xf7ae0000) May 1 12:40:07 Optiplex-780 kernel: [ 3173.204045] pci-stub 0000:00:19.0: restoring config space at offset 0x1 (was 0x100000, writing 0x100103) May 1 12:40:07 Optiplex-780 kernel: [ 3173.435751] assign device 0:0:19.0 May 1 12:44:24 Optiplex-780 kernel: [ 3430.568526] pci-stub 0000:00:19.0: restoring config space at offset 0x6 (was 0x1, writing 0xece1) May 1 12:44:24 Optiplex-780 kernel: [ 3430.568532] pci-stub 0000:00:19.0: restoring config space at offset 0x5 (was 0x0, writing 0xf7ad9000) May 1 12:44:24 Optiplex-780 kernel: [ 3430.568537] pci-stub 0000:00:19.0: restoring config space at offset 0x4 (was 0x0, writing 0xf7ae0000) May 1 12:44:24 Optiplex-780 kernel: [ 3430.568543] pci-stub 0000:00:19.0: restoring config space at offset 0x1 (was 0x100000, writing 0x100103) May 1 12:44:24 Optiplex-780 kernel: [ 3430.568561] pci-stub 0000:00:19.0: PCI INT A disabled root@Optiplex-780:/var/log/libvirt/qemu# cat /proc/interrupts CPU0 CPU1 CPU2 CPU3 0: 97 1 2 1 IO-APIC-edge timer 1: 2 0 0 0 IO-APIC-edge i8042 7: 0 0 0 0 IO-APIC-edge parport0 8: 1 0 0 0 IO-APIC-edge rtc0 9: 0 0 0 0 IO-APIC-fasteoi acpi 12: 1 2 1 0 IO-APIC-edge i8042 16: 0 0 0 0 IO-APIC-fasteoi uhci_hcd:usb2 17: 5822 1952 3614 2233 IO-APIC-fasteoi uhci_hcd:usb4, uhci_hcd:usb7 18: 0 0 0 0 IO-APIC-fasteoi uhci_hcd:usb8 22: 1 1 1 0 IO-APIC-fasteoi ehci_hcd:usb1, uhci_hcd:usb5 23: 1461 1299 1153 912 IO-APIC-fasteoi ehci_hcd:usb3, uhci_hcd:usb6 24: 268579 0 0 0 HPET_MSI-edge hpet2 25: 0 286310 0 0 HPET_MSI-edge hpet3 26: 0 0 210675 0 HPET_MSI-edge hpet4 27: 0 0 0 256688 HPET_MSI-edge hpet5 29: 1 0 0 0 DMAR_MSI-edge dmar1 30: 0 0 0 0 DMAR_MSI-edge dmar0 31: 0 0 0 0 DMAR_MSI-edge dmar2 35: 0 0 0 1 PCI-MSI-edge eth1 36: 1456 916 1323 1657 PCI-MSI-edge eth1-rx-0 37: 1031 772 1459 895 PCI-MSI-edge eth1-rx-1 38: 958 965 785 470 PCI-MSI-edge eth1-rx-2 39: 1319 557 1007 714 PCI-MSI-edge eth1-rx-3 40: 892 864 417 1134 PCI-MSI-edge eth1-tx-0 41: 414 749 998 606 PCI-MSI-edge eth1-tx-1 42: 307 921 375 332 PCI-MSI-edge eth1-tx-2 43: 966 693 396 502 PCI-MSI-edge eth1-tx-3 54: 7109 5755 5683 5609 PCI-MSI-edge ahci 55: 74 105 73 84 PCI-MSI-edge hda_intel 56: 1446 927 1108 870 PCI-MSI-edge i915 NMI: 0 0 0 0 Non-maskable interrupts LOC: 740 725 703 677 Local timer interrupts SPU: 0 0 0 0 Spurious interrupts PMI: 0 0 0 0 Performance monitoring interrupts PND: 0 0 0 0 Performance pending work RES: 665 679 714 547 Rescheduling interrupts CAL: 5332 408 5619 539 Function call interrupts TLB: 1880 2843 1788 3202 TLB shootdowns TRM: 0 0 0 0 Thermal event interrupts THR: 0 0 0 0 Threshold APIC interrupts MCE: 0 0 0 0 Machine check exceptions MCP: 5 5 5 5 Machine check polls ERR: 3 MIS: 0 root@Optiplex-780:/var/log/libvirt/qemu# I search the similarly problems that sharing the irg but never find a answer , and now I have no idea. How to solve the problem ,can you help me ? thanks. best regards, qinguan vt_d.xml: <domain type='kvm'> <name>test</name> <description>just test using sriov!</description> <os> <type>hvm</type> <boot dev='hd'/> </os> <memory>524288</memory> <currentMemory>524288</ currentMemory> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <features><pae/><acpi/><apic/></features> <clock offset='utc'/> <devices> <input type='mouse' bus='usb'/> <disk type='file' device='disk'> <source file='/home/qinguan/exp/ubuntu_1.img'/> <target dev='hda' bus='virtio'/> </disk> <emulator>/usr/bin/kvm</emulator> <graphics type='vnc' port='-1'/> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address bus='0x0' slot='0x19' function='0x0'/> </source> </hostdev> </devices> </domain>

1 1

[libvirt] Support for more than 32 virtio devices
by Badari Pulavarty 04 May '11

04 May '11

Hi, How can I make use of "multifunction" functionality to support more than 32 virtio devices in QEMU through libvirt ? Are there corresponding changes in libvirt ? Please let me know. Thanks, Badari

3 3

[libvirt] failure to build on rawhide
by Eric Blake 04 May '11

04 May '11

I'm getting this when trying to build libvirt on rawhide (using the package gnutls-devel-2.12.3-1.fc16.x86_64): remote/remote_driver.c: In function 'negotiate_gnutls_on_connection': remote/remote_driver.c:1361:9: error: 'gnutls_certificate_type_set_priority' is deprecated (declared at /usr/include/gnutls/compat.h:347) [-Werror=deprecated-declarations] but I can't find anything in the gnutls man pages that says why it is deprecated or what to use in its place. Any ideas? -- Eric Blake eblake(a)redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

2 1

[libvirt] [PATCH] lxc: Do not try to reconnect inactive domain when do lxcStartup
by Osier Yang 04 May '11

04 May '11

Otherwise if there are inactive lxc domains, lxcStartup will try to reconnect to sockets of these domains, which results in errors in libvirtd log. --- src/lxc/lxc_driver.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index e905302..ef7827b 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1992,6 +1992,9 @@ lxcReconnectVM(void *payload, const void *name ATTRIBUTE_UNUSED, void *opaque) virDomainObjLock(vm); + if (!virDomainObjIsActive(vm)) + goto cleanup; + priv = vm->privateData; if ((priv->monitor = lxcMonitorClient(driver, vm)) < 0) { goto cleanup; -- 1.7.4

3 7

[libvirt] libvirt tracking of hung/stopped QEMU VMs
by Ryan Harper 04 May '11

04 May '11

I've encountered an interesting scenario: 1. define a guest via virsh define <xml> 2 start this guest via virsh 3. one of the disk elements is a multipath device that is currently misconfigured such that any io to the device hangs the calling process 4. libvirt times out when attemping to communicate via the monitor to the guest (btw, this timeout isn't configurable AFAICT) 5. returns an error from create indicating that we failed to create the VM At this point: 1) libvirt reports that the VM is stopped (and this is true, the qemu process has never been issued the 'cont' command and thus won't ever execute gues tcode) 2) the qemu process for this VM is still running (just blocked on IO) 3) it is possible that if the process becomes unblocked that the QEMU process will be functional again, but won't be started, and the process won't be terminated since libvirt isn't tracking this any more, and is consuming some amount of resources that are allocated on start up. How can we clean up from this failure scenario? Would it make sense for libvirt to send a SIGTERM to a qemu if it failed to create? In the above scenario, this would allow us to reap the process if it ever became unblocked. -- Ryan Harper Software Engineer; Linux Technology Center IBM Corp., Austin, Tx ryanh(a)us.ibm.com

1 1

Re: [libvirt] Problem with libvirt on Fedora 14 with virt-preview repo
by Laine Stump 03 May '11

03 May '11

On 05/03/2011 04:16 PM, Scott Dowdle wrote: > Greetings, > > I wasn't sure who to report this to... and I did a bugzilla search and didn't find anything... and I'm not sure where to report this to... since it isn't Fedora 14 exactly since I'm using the virt-preview repo. I *think* the best place to report these bugs is at bugzilla.redhat.com, Classification "Other", Product "Virtualization Tools", component "libvirt". You could first try sending a message to libvirt-users(a)redhat.com or libvir-list(a)redhat.com (the developers' list) to see if it's a known problem though. > I just did a bunch of updates on a Fedora 14 x86_64 box that has the virt-preview repo. I was using all of the new features with SPICE... but after updating I can't get libvirtd to start anymore. I get the following error message in /var/log/messages: > > May 3 14:20:04 virt-desk libvirtd: Could not find keytab file: /etc/libvirt/krb5.tab: No such file or directory > May 3 14:20:04 virt-desk libvirtd: 14:20:04.854: 2746: info : libvirt version: 0.8.8, package: 4.fc14 (Unknown, 2011-04-07-15:51:18, fedora64.linuxtx.org) > May 3 14:20:04 virt-desk libvirtd: 14:20:04.854: 2746: error : remoteCheckCertFile:288 : Cannot access CA certificate '/etc/pki/CA/cacert.pem': No such file or directory > > I look at the config files in /etc/libvirt/ and everything is commented out... so I'm not sure how to fix this via a config. I'm not familiar with that part of the code, but it looks like the cert check happens if listen_tls = 1, which is its default value. You can disable it by uncommenting listen_tls=0 in /etc/libvirt/libvirtd.conf. I'm not sure what undesired effects that will have on your system's operation. > Any help? Can anyone else reproduce this? As a result, I can't get libvirtd to start and my VMs are hosed. :( Shall I report the bug? I'm Cc'ing this response to libvir-list. It's very likely a known problem that I just didn't notice, and someone there will know about it. > Scott Dowdle > [address redacted :-)] > Belgrade, MT 59714 Seriously? I was at MSU from 1981-1985. I'm guessing a lot has changed since then...

2 1

[libvirt] [PATCH] qemu: silence clang false positives
by Eric Blake 03 May '11

03 May '11

Clang 2.8 wasn't quite able to follow that persistentDef was assigned earlier if (flags & VIR_DOMAIN_MEM_CONFIG) is true. Silence this false positive, to make clang analysis easier to use. * src/qemu/qemu_driver.c (qemudDomainSetMemoryFlags): Add an annotation to silence clang's claim of a NULL dereference. --- I'm pushing this under the trivial rule - sa_assert is a no-op in normal compilation, so this can't have any effect on the end executable, but makes the rest of my clang analysis easier. src/qemu/qemu_driver.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0919503..7132837 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1640,6 +1640,8 @@ static int qemudDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem, } if (flags & VIR_DOMAIN_MEM_CONFIG) { + /* Help clang 2.8 decipher the logic flow. */ + sa_assert(persistentDef); persistentDef->mem.max_balloon = newmem; if (persistentDef->mem.cur_balloon > newmem) persistentDef->mem.cur_balloon = newmem; @@ -1675,6 +1677,7 @@ static int qemudDomainSetMemoryFlags(virDomainPtr dom, unsigned long newmem, } if (flags & VIR_DOMAIN_MEM_CONFIG) { + sa_assert(persistentDef); persistentDef->mem.cur_balloon = newmem; ret = virDomainSaveConfig(driver->configDir, persistentDef); goto endjob; -- 1.7.4.4

1 0

[libvirt] [PATCH] Add support for YAJL version 2 API/ABI
by Daniel P. Berrange 03 May '11

03 May '11

Version 2.0.0 or yajl changed API. It is fairly trivial for us to cope with both APIs in libvirt, so adapt. * configure.ac: Probe for yajl2 API * src/util/json.c: Conditional support for yajl2 API --- configure.ac | 8 ++++++++ src/util/json.c | 44 +++++++++++++++++++++++++++++++++++++++----- 2 files changed, 47 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 7c68bca..dc87347 100644 --- a/configure.ac +++ b/configure.ac @@ -878,6 +878,7 @@ AC_ARG_WITH([yajl], YAJL_CFLAGS= YAJL_LIBS= +with_yajl2=no if test "x$with_yajl" != "xno"; then if test "x$with_yajl" != "xyes" && test "x$with_yajl" != "xcheck"; then YAJL_CFLAGS="-I$with_yajl/include" @@ -898,6 +899,9 @@ if test "x$with_yajl" != "xno"; then AC_CHECK_LIB([yajl], [yajl_parse],[ YAJL_LIBS="$YAJL_LIBS -lyajl" with_yajl=yes + AC_CHECK_LIB([yajl], [yajl_tree_parse],[ + with_yajl2=yes + ],[]) ],[ if test "x$with_yajl" = "xcheck" ; then with_yajl=no @@ -914,6 +918,10 @@ if test "x$with_yajl" != "xno"; then AC_DEFINE_UNQUOTED([HAVE_YAJL], 1, [whether YAJL is available for JSON parsing/formatting]) fi + if test "x$with_yajl2" = "xyes" ; then + AC_DEFINE_UNQUOTED([HAVE_YAJL2], 1, + [whether YAJL has API version 2]) + fi fi AM_CONDITIONAL([HAVE_YAJL], [test "x$with_yajl" = "xyes"]) AC_SUBST([YAJL_CFLAGS]) diff --git a/src/util/json.c b/src/util/json.c index 0daeae9..80dbca4 100644 --- a/src/util/json.c +++ b/src/util/json.c @@ -709,7 +709,12 @@ static int virJSONParserHandleBoolean(void * ctx, int boolean_) static int virJSONParserHandleNumber(void * ctx, const char * s, - unsigned int l) +#ifdef HAVE_YAJL2 + size_t l +#else + unsigned int l +#endif + ) { virJSONParserPtr parser = ctx; char *str = strndup(s, l); @@ -735,7 +740,12 @@ static int virJSONParserHandleNumber(void * ctx, static int virJSONParserHandleString(void * ctx, const unsigned char * stringVal, - unsigned int stringLen) +#ifdef HAVE_YAJL2 + size_t stringLen +#else + unsigned int stringLen +#endif + ) { virJSONParserPtr parser = ctx; virJSONValuePtr value = virJSONValueNewStringLen((const char *)stringVal, @@ -756,7 +766,12 @@ static int virJSONParserHandleString(void * ctx, static int virJSONParserHandleMapKey(void * ctx, const unsigned char * stringVal, - unsigned int stringLen) +#ifdef HAVE_YAJL2 + size_t stringLen +#else + unsigned int stringLen +#endif + ) { virJSONParserPtr parser = ctx; virJSONParserStatePtr state; @@ -894,14 +909,22 @@ static const yajl_callbacks parserCallbacks = { /* XXX add an incremental streaming parser - yajl trivially supports it */ virJSONValuePtr virJSONValueFromString(const char *jsonstring) { - yajl_parser_config cfg = { 1, 1 }; yajl_handle hand; virJSONParser parser = { NULL, NULL, 0 }; virJSONValuePtr ret = NULL; +#ifndef HAVE_YAJL2 + yajl_parser_config cfg = { 1, 1 }; +#endif VIR_DEBUG("string=%s", jsonstring); +#ifdef HAVE_YAJL2 + hand = yajl_alloc(&parserCallbacks, NULL, &parser); + yajl_config(hand, yajl_allow_comments, 1); + yajl_config(hand, yajl_dont_validate_strings, 0); +#else hand = yajl_alloc(&parserCallbacks, &cfg, NULL, &parser); +#endif if (yajl_parse(hand, (const unsigned char *)jsonstring, @@ -1002,15 +1025,26 @@ static int virJSONValueToStringOne(virJSONValuePtr object, char *virJSONValueToString(virJSONValuePtr object) { - yajl_gen_config conf = { 0, " " }; /* Turns off pretty printing since QEMU can't cope */ yajl_gen g; const unsigned char *str; char *ret = NULL; +#ifdef HAVE_YAJL2 + size_t len; +#else unsigned int len; + yajl_gen_config conf = { 0, " " }; /* Turns off pretty printing since QEMU can't cope */ +#endif VIR_DEBUG("object=%p", object); +#ifdef HAVE_YAJL2 + g = yajl_gen_alloc(NULL); + yajl_gen_config(g, yajl_gen_beautify, 0); + yajl_gen_config(g, yajl_gen_indent_string, " "); + yajl_gen_config(g, yajl_gen_validate_utf8, 1); +#else g = yajl_gen_alloc(&conf, NULL); +#endif if (virJSONValueToStringOne(object, g) < 0) { virReportOOMError(); -- 1.7.4.4

2 1

[libvirt] [PATCH] virsh: avoid null pointer dereference
by Eric Blake 03 May '11

03 May '11

Clang detected that vol-download will call unlink(NULL) if there is a parse error during option parsing. Also, mingw doesn't like unlinking an open file. * tools/virsh.c (cmdVolDownload): Only unlink file if created. --- tools/virsh.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 3d4ed2f..5d8b025 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -7259,10 +7259,10 @@ cmdVolDownload (vshControl *ctl, const vshCmd *cmd) virStreamPtr st = NULL; const char *name = NULL; unsigned long long offset = 0, length = 0; - bool created = true; + bool created = false; if (!vshConnectionUsability(ctl, ctl->conn)) - goto cleanup; + return false; if (vshCommandOptULongLong(cmd, "offset", &offset) < 0) { vshError(ctl, _("Unable to parse integer")); @@ -7283,12 +7283,13 @@ cmdVolDownload (vshControl *ctl, const vshCmd *cmd) } if ((fd = open(file, O_WRONLY|O_CREAT|O_EXCL, 0666)) < 0) { - created = false; if (errno != EEXIST || (fd = open(file, O_WRONLY|O_TRUNC, 0666)) < 0) { vshError(ctl, _("cannot create %s"), file); goto cleanup; } + } else { + created = true; } st = virStreamNew(ctl->conn, 0); @@ -7316,13 +7317,13 @@ cmdVolDownload (vshControl *ctl, const vshCmd *cmd) ret = true; cleanup: + VIR_FORCE_CLOSE(fd); if (ret == false && created) unlink(file); if (vol) virStorageVolFree(vol); if (st) virStreamFree(st); - VIR_FORCE_CLOSE(fd); return ret; } -- 1.7.4.4

2 2

[libvirt] [PATCH] pci: fix null pointer dereference
by Eric Blake 03 May '11

03 May '11

Clang detected a null-pointer dereference regression, introduced in commit 4e8969eb. Without this patch, a device with unbind_from_stub set to false would eventually try to call virFileExists on uncomputed drvdir. * src/util/pci.c (pciUnbindDeviceFromStub): Ensure drvdir is set before use. --- src/util/pci.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/util/pci.c b/src/util/pci.c index 945f32a..d7f74f9 100644 --- a/src/util/pci.c +++ b/src/util/pci.c @@ -879,15 +879,16 @@ pciUnbindDeviceFromStub(pciDevice *dev, const char *driver) char *drvdir = NULL; char *path = NULL; + if (pciDriverDir(&drvdir, driver) < 0) + goto cleanup; + if (!dev->unbind_from_stub) goto remove_slot; /* If the device is bound to stub, unbind it. */ - if (pciDriverDir(&drvdir, driver) < 0 || - pciDeviceFile(&path, dev->name, "driver") < 0) { + if (pciDeviceFile(&path, dev->name, "driver") < 0) goto cleanup; - } if (virFileExists(drvdir) && virFileLinkPointsTo(path, drvdir)) { if (pciDriverFile(&path, driver, "unbind") < 0) { -- 1.7.4.4

2 2

[libvirt] [PATCH] qemu: avoid null pointer dereference
by Eric Blake 03 May '11

03 May '11

This code has had problems historically. As originally written, in commit 6bcf2501 (Jun 08), it could call unlink on a random string, nuking an unrelated file. Then commit 182a80b9 (Sep 09), the code was rewritten to allocate tmp, with both a use-after-free bug and a chance to call unlink(NULL). Commit e206946 (Mar 11) fixed the use-after-free, but not the NULL dereference. Thanks to clang for catching this! * src/qemu/qemu_driver.c (qemudDomainMemoryPeek): Don't call unlink on NULL. --- src/qemu/qemu_driver.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 16d869d..3ee4720 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5355,7 +5355,8 @@ endjob: cleanup: VIR_FORCE_CLOSE(fd); - unlink (tmp); + if (tmp) + unlink (tmp); VIR_FREE(tmp); if (vm) virDomainObjUnlock(vm); -- 1.7.4.4

2 2

[libvirt] [PATCH] tests: avoid null pointer dereference
by Eric Blake 03 May '11

03 May '11

Unlikely to hit in real life, but clang noticed it. * tests/commandtest.c (test4): Avoid unlink(NULL) on OOM. --- Much like a similar patch I sent for qemu_driver, but this time the unlink(NULL) is much harder to trigger. tests/commandtest.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index fa0061c..e8d8858 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -240,7 +240,8 @@ static int test4(const void *unused ATTRIBUTE_UNUSED) cleanup: virCommandFree(cmd); - unlink(pidfile); + if (pidfile) + unlink(pidfile); VIR_FREE(pidfile); return ret; } -- 1.7.4.4

2 2

[libvirt] [PATCH] Fix security driver handling of FIFOs with QEMU
by Daniel P. Berrange 03 May '11

03 May '11

When setting up a FIFO for QEMU, it allows either a pair of fifos used unidirectionally, or a single fifo used bidirectionally. Look for the bidirectional fifo first when labelling since that is more useful * src/security/security_dac.c, src/security/security_selinux.c: Fix fifo handling --- src/security/security_dac.c | 19 ++++++++++++------- src/security/security_selinux.c | 19 ++++++++++++------- 2 files changed, 24 insertions(+), 14 deletions(-) diff --git a/src/security/security_dac.c b/src/security/security_dac.c index fba2d1d..b8642d2 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -406,14 +406,19 @@ virSecurityDACSetChardevLabel(virSecurityManagerPtr mgr, break; case VIR_DOMAIN_CHR_TYPE_PIPE: - if ((virAsprintf(&in, "%s.in", dev->data.file.path) < 0) || - (virAsprintf(&out, "%s.out", dev->data.file.path) < 0)) { - virReportOOMError(); - goto done; + if (virFileExists(dev->data.file.path)) { + if (virSecurityDACSetOwnership(dev->data.file.path, priv->user, priv->group) < 0) + goto done; + } else { + if ((virAsprintf(&in, "%s.in", dev->data.file.path) < 0) || + (virAsprintf(&out, "%s.out", dev->data.file.path) < 0)) { + virReportOOMError(); + goto done; + } + if ((virSecurityDACSetOwnership(in, priv->user, priv->group) < 0) || + (virSecurityDACSetOwnership(out, priv->user, priv->group) < 0)) + goto done; } - if ((virSecurityDACSetOwnership(in, priv->user, priv->group) < 0) || - (virSecurityDACSetOwnership(out, priv->user, priv->group) < 0)) - goto done; ret = 0; break; diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 216208e..476bbbf 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -733,14 +733,19 @@ SELinuxSetSecurityChardevLabel(virDomainObjPtr vm, break; case VIR_DOMAIN_CHR_TYPE_PIPE: - if ((virAsprintf(&in, "%s.in", dev->data.file.path) < 0) || - (virAsprintf(&out, "%s.out", dev->data.file.path) < 0)) { - virReportOOMError(); - goto done; + if (virFileExists(dev->data.file.path)) { + if (SELinuxSetFilecon(dev->data.file.path, secdef->imagelabel) < 0) + goto done; + } else { + if ((virAsprintf(&in, "%s.in", dev->data.file.path) < 0) || + (virAsprintf(&out, "%s.out", dev->data.file.path) < 0)) { + virReportOOMError(); + goto done; + } + if ((SELinuxSetFilecon(in, secdef->imagelabel) < 0) || + (SELinuxSetFilecon(out, secdef->imagelabel) < 0)) + goto done; } - if ((SELinuxSetFilecon(in, secdef->imagelabel) < 0) || - (SELinuxSetFilecon(out, secdef->imagelabel) < 0)) - goto done; ret = 0; break; -- 1.7.4.4

2 1

[libvirt] [PATCH] tests: Update valgrind suppressions file
by Matthias Bolte 03 May '11

03 May '11

--- tests/.valgrind.supp | 58 +++++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 51 insertions(+), 7 deletions(-) diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index 4af10b1..68cfa0c 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -258,14 +258,58 @@ Memcheck:Param capget(data) fun:capget + fun:* fun:capng_clear + fun:virClearCapabilities fun:__virExec fun:virExecWithHook - fun:virExec - fun:qemudProbeMachineTypes - fun:qemudCapsInitGuest - fun:qemudCapsInit - fun:qemudStartup - fun:virStateInitialize - fun:main +} +{ + libnlMemoryLeak1 + Memcheck:Leak + fun:malloc + fun:strdup + obj:/usr/lib/libnl.so.1.1 +} +{ + libnlMemoryLeak2 + Memcheck:Leak + fun:calloc + obj:/usr/lib/libnl.so.1.1 +} +{ + libselinuxMemoryLeak1 + Memcheck:Leak + fun:malloc + fun:getdelim + obj:/lib/libselinux.so.1 +} +{ + dashMemoryLeak1 + Memcheck:Leak + fun:malloc + obj:/bin/dash +} +{ + dashMemoryLeak2 + Memcheck:Leak + fun:malloc + fun:strdup + obj:/bin/dash +} +{ + vboxMemoryLeak1 + Memcheck:Leak + ... + fun:VBoxNsxpNS_InitXPCOM2 +} +{ + libnetcfMemoryLeak1 + fun:malloc + fun:xmlStrndup + fun:xmlHashUpdateEntry3 + fun:* + fun:xsltRegisterAllExtras + fun:drv_init + fun:interfaceOpenInterface } -- 1.7.0.4

3 5

[libvirt] [PATCH] spice: support streaming-video parameter
by Alon Levy 03 May '11

03 May '11

This adds a streaming-video=filter|all|off attribute. It is used to change the behavior of video stream detection in spice, the default is filter (the default for libvirt is not to specify it - the actual default is defined in libspice-server.so). Usage: <graphics type='spice' autoport='yes'> <streaming mode='off'/> </graphics> Tested with the above and with tests/qemuxml2argvtest. Signed-off-by: Alon Levy <alevy(a)redhat.com> bla --- docs/schemas/domain.rng | 12 ++++++++ src/conf/domain_conf.c | 30 ++++++++++++++++++++ src/conf/domain_conf.h | 11 +++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_command.c | 3 ++ .../qemuxml2argv-graphics-spice.args | 2 +- .../qemuxml2argv-graphics-spice.xml | 1 + 7 files changed, 60 insertions(+), 1 deletions(-) diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 7163c6e..9083ff9 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -1334,6 +1334,18 @@ <empty/> </element> </optional> + <optional> + <element name="streaming"> + <attribute name="mode"> + <choice> + <value>filter</value> + <value>all</value> + <value>off</value> + </choice> + </attribute> + <empty/> + </element> + </optional> </interleave> </group> <group> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2a681d9..eb9f587 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -352,6 +352,13 @@ VIR_ENUM_IMPL(virDomainGraphicsSpicePlaybackCompression, "on", "off"); +VIR_ENUM_IMPL(virDomainGraphicsSpiceStreamingMode, + VIR_DOMAIN_GRAPHICS_SPICE_STREAMING_MODE_LAST, + "default", + "filter", + "all", + "off"); + VIR_ENUM_IMPL(virDomainHostdevMode, VIR_DOMAIN_HOSTDEV_MODE_LAST, "subsystem", "capabilities") @@ -4082,6 +4089,26 @@ virDomainGraphicsDefParseXML(xmlNodePtr node, int flags) { VIR_FREE(compression); def->data.spice.playback = compressionVal; + } else if (xmlStrEqual(cur->name, BAD_CAST "streaming")) { + const char *mode = virXMLPropString(cur, "mode"); + int modeVal; + + if (!mode) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("spice streaming missing mode")); + goto error; + } + if ((modeVal = + virDomainGraphicsSpiceStreamingModeTypeFromString(mode)) <= 0) { + virDomainReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("unknown spice streaming mode")); + VIR_FREE(mode); + goto error; + + } + VIR_FREE(mode); + + def->data.spice.streaming = modeVal; } } cur = cur->next; @@ -7979,6 +8006,9 @@ virDomainGraphicsDefFormat(virBufferPtr buf, if (def->data.spice.playback) virBufferVSprintf(buf, " <playback compression='%s'/>\n", virDomainGraphicsSpicePlaybackCompressionTypeToString(def->data.spice.playback)); + if (def->data.spice.streaming) + virBufferVSprintf(buf, " <streaming mode='%s'/>\n", + virDomainGraphicsSpiceStreamingModeTypeToString(def->data.spice.streaming)); } if (children) { diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1dadf98..7a1f29a 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -696,6 +696,15 @@ enum virDomainGraphicsSpicePlaybackCompression { VIR_DOMAIN_GRAPHICS_SPICE_PLAYBACK_COMPRESSION_LAST }; +enum virDomainGraphicsSpiceStreamingMode { + VIR_DOMAIN_GRAPHICS_SPICE_STREAMING_MODE_DEFAULT = 0, + VIR_DOMAIN_GRAPHICS_SPICE_STREAMING_MODE_FILTER, + VIR_DOMAIN_GRAPHICS_SPICE_STREAMING_MODE_ALL, + VIR_DOMAIN_GRAPHICS_SPICE_STREAMING_MODE_OFF, + + VIR_DOMAIN_GRAPHICS_SPICE_STREAMING_MODE_LAST +}; + typedef struct _virDomainGraphicsDef virDomainGraphicsDef; typedef virDomainGraphicsDef *virDomainGraphicsDefPtr; struct _virDomainGraphicsDef { @@ -737,6 +746,7 @@ struct _virDomainGraphicsDef { int jpeg; int zlib; int playback; + int streaming; } spice; } data; }; @@ -1476,6 +1486,7 @@ VIR_ENUM_DECL(virDomainGraphicsSpiceImageCompression) VIR_ENUM_DECL(virDomainGraphicsSpiceJpegCompression) VIR_ENUM_DECL(virDomainGraphicsSpiceZlibCompression) VIR_ENUM_DECL(virDomainGraphicsSpicePlaybackCompression) +VIR_ENUM_DECL(virDomainGraphicsSpiceStreamingMode) /* from libvirt.h */ VIR_ENUM_DECL(virDomainState) VIR_ENUM_DECL(virDomainSeclabel) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1b22be6..2e25202 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -273,6 +273,8 @@ virDomainGraphicsSpicePlaybackCompressionTypeFromString; virDomainGraphicsSpicePlaybackCompressionTypeToString; virDomainGraphicsSpiceZlibCompressionTypeFromString; virDomainGraphicsSpiceZlibCompressionTypeToString; +virDomainGraphicsSpiceStreamingModeTypeFromString; +virDomainGraphicsSpiceStreamingModeTypeToString; virDomainGraphicsTypeFromString; virDomainGraphicsTypeToString; virDomainHostdevDefFree; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 2205ed1..8036f0c 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4037,6 +4037,9 @@ qemuBuildCommandLine(virConnectPtr conn, if (def->graphics[0]->data.spice.playback) virBufferVSprintf(&opt, ",playback-compression=%s", virDomainGraphicsSpicePlaybackCompressionTypeToString(def->graphics[0]->data.spice.playback)); + if (def->graphics[0]->data.spice.streaming) + virBufferVSprintf(&opt, ",streaming-video=%s", + virDomainGraphicsSpiceStreamingModeTypeToString(def->graphics[0]->data.spice.streaming)); virCommandAddArg(cmd, "-spice"); virCommandAddArgBuffer(cmd, &opt); diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.args b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.args index 70cd35b..084a100 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.args @@ -4,6 +4,6 @@ unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -hda \ /dev/HostVG/QEMUGuest1 -usb -spice port=5903,tls-port=5904,addr=127.0.0.1,\ x509-dir=/etc/pki/libvirt-spice,tls-channel=main,plaintext-channel=inputs,\ image-compression=auto_glz,jpeg-wan-compression=auto,zlib-glz-wan-compression=auto,\ -playback-compression=on -vga \ +playback-compression=on,streaming-video=filter -vga \ qxl -global qxl.vram_size=18874368 -device qxl,id=video1,vram_size=33554432,bus=pci.0,addr=0x4 \ -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml index a29f50d..0d3dd48 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml @@ -28,6 +28,7 @@ <jpeg compression='auto'/> <zlib compression='auto'/> <playback compression='on'/> + <streaming mode='filter'/> </graphics> <video> <model type='qxl' vram='18432' heads='1'/> -- 1.7.5

2 1

[libvirt] [PATCH v2] Fix disability to run on systems with no PCI bus
by Michal Privoznik 03 May '11

03 May '11

The patch which moved libpciaccess initialization to one place caused regression - we were not able to run on system with no PCI bus, like s390(x). --- src/node_device/node_device_udev.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 2139ef3..fcff252 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -1421,8 +1421,12 @@ static int udevDeviceMonitorShutdown(void) ret = -1; } +#if defined __s390__ || defined __s390x_ + /* Nothing was initialized, nothing needs to be cleaned up */ +#else /* pci_system_cleanup returns void */ pci_system_cleanup(); +#endif return ret; } @@ -1595,6 +1599,10 @@ static int udevDeviceMonitorStartup(int privileged) int ret = 0; int pciret; +#if defined __s390__ || defined __s390x_ + /* On x390(x) system there is no PCI bus. + * Therefore there is nothing to initialize here. */ +#else if ((pciret = pci_system_init()) != 0) { /* Ignore failure as non-root; udev is not as helpful in that * situation, but a non-privileged user won't benefit much @@ -1607,6 +1615,7 @@ static int udevDeviceMonitorStartup(int privileged) goto out; } } +#endif if (VIR_ALLOC(priv) < 0) { virReportOOMError(); -- 1.7.4.4

3 2

[libvirt] [PATCH] fix missing VLAN id for Qbg example
by Gerhard Stenzel 03 May '11

03 May '11

For IEEE 802.1Qbg, it is necessary to use a VLAN interface. vepa itself does not require a VLAN interface. Signed-off-by: Gerhard Stenzel <stenzel at de.ibm.com> =================================================================== --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1440,6 +1440,10 @@ the Virtual Station Interface (VSI) represents the virtual interface of a virtual machine. </p> + <p> + Please note, that IEEE 802.1Qbg requires a non-zero value for the + VLAN ID. + </p> <dl> <dt><code>managerid</code></dt> <dd>The VSI Manager ID identifies the database containing the VSI type @@ -1466,7 +1470,7 @@ <interface type='direct'/> ... <interface type='direct'> - <source dev='eth0' mode='vepa'/> + <source dev='eth0.2' mode='vepa'/> <virtualport type="802.1Qbg"> <parameters managerid="11" typeid="1193047" typeidversion="2" instanceid="09b11c53-8b5c-4eeb-8f00-d84eaa0aaa4f"/> </virtualport> =================================================================== Best regards, Gerhard Stenzel ------------------------------------------------------------------------------------- IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschaeftsfuehrung: Dirk Wittkopp Sitz der Gesellschaft: Boeblingen Registergericht: Amtsgericht Stuttgart, HRB 243294

4 5

[libvirt] [PATCH] tests: avoid compiler warning
by Eric Blake 02 May '11

02 May '11

../../tests/xmconfigtest.c: In function 'testCompareParseXML': ../../tests/xmconfigtest.c:49:19: error: 'conn' may be used uninitialized in this function [-Wuninitialized] * tests/xmconfigtest.c (testCompareParseXML): Initialize variable. --- Pushing under the build-breaker rule. tests/xmconfigtest.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/xmconfigtest.c b/tests/xmconfigtest.c index 02a8900..6022621 100644 --- a/tests/xmconfigtest.c +++ b/tests/xmconfigtest.c @@ -46,7 +46,7 @@ testCompareParseXML(const char *xmcfg, const char *xml, int xendConfigVersion) char *gotxmcfgData = NULL; virConfPtr conf = NULL; int ret = -1; - virConnectPtr conn; + virConnectPtr conn = NULL; int wrote = 4096; struct _xenUnifiedPrivate priv; virDomainDefPtr def = NULL; -- 1.7.4.4

1 0

[libvirt] Libvirt 0.9.1 week freeze, RC1 version to test
by Daniel Veillard 02 May '11

02 May '11

So we are entering the week freeze for the new version. I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.1-rc1.tar.gz I have tried it locally and basic operations seems to work fine, please give it a try too, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

4 7

[libvirt] [PATCH] qemu: fix uninitialized variable warning
by Christophe Fergeau 02 May '11

02 May '11

This commit fixes qemu/qemu_driver.c: In function 'qemuDomainModifyDeviceFlags': qemu/qemu_driver.c:4041:8: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] qemu/qemu_driver.c:4013:9: note: 'ret' was declared here The variable is set to -1 so that the error paths are taken when the code to set it didn't get a chance to run. Without initializing it, we could return some an undefined value from this function. While I was at it, I made a trivial whitespace change in the same function to improve readability. --- src/qemu/qemu_driver.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a19c4a7..16d869d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4010,11 +4010,11 @@ qemuDomainChangeDiskMediaLive(virDomainObjPtr vm, { virDomainDiskDefPtr disk = dev->data.disk; virCgroupPtr cgroup = NULL; - int ret; + int ret = -1; if (qemuCgroupControllerActive(driver, VIR_CGROUP_CONTROLLER_DEVICES)) { if (virCgroupForDomain(driver->cgroup, - vm->def->name, &cgroup, 0) !=0 ) { + vm->def->name, &cgroup, 0) != 0) { qemuReportError(VIR_ERR_INTERNAL_ERROR, _("Unable to find cgroup for %s"), vm->def->name); -- 1.7.5

2 1

[libvirt] Libvirt and IPSec (was: What about Trusted Virtual Domains???)
by Paolo Smiraglia 02 May '11

02 May '11

Hi to everyone! First of all, sorry for the thread subject change. Due to the several issues of the Libvirt implementation of the Trusted Virtual Domains (TVD), I decided to approach the topic in a modular manner. I think that the first step should be to define the IPSec support or, more in general, the secure tunnel support for Libvirt. I see the implementation divided in two step: 1. define a new driver called 'sectunnel' which describes a generic secure tunnel that will be established using several technologies (for now using only ipsec) 2. modify the existing 'network' driver by adding the possibility to specify the 'sectunnel' that the network have to use in the virtual network definition As an example, you can see below a possible XML definition of the network which use a secure tunnel and the corresponding 'sectunnel' XML definition: NETWORK DEFINITION ================== <network> <name>sec-net</name> <uuid>3e3fce45-4f53-4fa7-bb32-11f34168b82b</uuid> <bridge name='virbr0' /> <domain name='example' /> ... <sectunnel name='sec-tun' /> <--(specify the 'sectunnel' to use) </network> SECTUNNEL DEFINITION ==================== <sectunnel type='ipsec'> <name>sec-tun</name> <uuid>8b7fd1b0-4463-43b7-8b6e-8006344aeb66</uuid>  <sa> <secret uuid='...' /> <--(specify the 'secret' which contains the pre-shared key) </sa>  <sp> <src_range address='10.0.0.1' prefixlen='30' port='5000' /> <dst_range address='10.0.0.2' prefixlen='30' port='5000' /> <upperspec protocol='any' /> <policy direction='out' action='ipsec'> <rule protocol='esp' mode='tunnel' level='require'> <src address='192.168.0.1' port='55055' /> <dst address='192.168.0.2' port='55055' /> </rule> </policy> </sp> <sp> <src_range address='10.0.0.2' prefixlen='30' port='5000' /> <dst_range address='10.0.0.1' prefixlen='30' port='5000' /> <upperspec protocol='any' /> <policy direction='in' action='ipsec'> <rule protocol='esp' mode='tunnel' level='require'> <src address='192.168.0.2' port='55055' /> <dst address='192.168.0.1' port='55055' /> </rule> </policy> </sp> </sectunnel> As you can see in the 'sectunnel' XML definition, I use a 'secret' element. This element is a Libvirt secret [1] and it stores the pre-shared key used by IPSec to establish the Security Associations (SA). Obviously this feature requires to define a new usage category in the 'secret' driver definition. Another possible way to establish the SA is to use the X.509 certificates. To this purpose, I think that the certificates already used by Libvirt to setup SSL/TLS remote connections, might be used. That's all! :-) What do you think about this possible IPSec implementation? Thanks in advance for the replies! Best regards, PAOLO LINK LIST --------- [1] http://libvirt.org/formatsecret.html -- PAOLO SMIRAGLIA Department of Control and Computer Engineering Mobile: +39 (333) 527 3593 Email: paolo.smiraglia(a)polito.it

3 12

[libvirt] RFC: virInterface change transaction API
by Laine Stump 02 May '11

02 May '11

I've been asked to implement what some people have termed as a "transaction-oriented" API for host interface configuration (ie virInterface*()). The basic intent is to allow rollback to a known-good config if anything goes wrong when changing around the host network config with virInterface*() functions. The most straightforward way to achieve this is that prior to calling virInterfaceDefine/virInterfaceUndefine, the current state of the host's network configuration (ie the /etc/sysconfig/network-scripts/ifcfg-* files in the case of Fedora and RHEL) would be saved off somewhere, and kept around until we're sure the new config is good; once we know that, we can just eliminate the backup. If, however, the user of virInterface*() explicitly requests, we could copy the files back; alternately if the system is rebooted without these known-good files being erased, we would assume that something went wrong and restore the original config. As with all other virInterface functions, the details of all this will be handled by netcf (and below), but since libvirt is the main consumer of netcf, I figure this is the appropriate place to discuss how it gets done, so please let me know any opinions on any piece of this. I plan to start the implementation "soon", as I want to be finished before the end of May. I see 3 layers to this: 1) libvirt At the libvirt layer, this feature just requires 3 new APIs, which are directly passed through to netcf: virInterfaceChangeStart(virConnectPtr conn, unsigned int flags); virInterfaceChangeCommit(virConnectPtr conn, unsigned int flags); virInterfaceChangeRollback(virConnectPtr conn, unsigned int flags); For the initial implementation, these will be simple passthroughs to similarly named netcf functions. (in the future, it would be useful for the server side of libvirt to determine if client<->server connectivity was lost due to the network changes, and automatically tell netcf to do a rollback). 2) netcf The netcf api will have these same three APIs, just named slightly differently: ncf_change_start(struct netcf *ncf, unsigned int flags); There are two possibilities for this. Either: A) call the initscript described below to save all config files that might possibly be changed (snapshot_config) or B) set a flag in *ncf indicating that all future calls to netcf that would end up modifying a particular config file should save off that file *if it hasn't already been saved*. (A) is simpler, but relies on the initscript having exact/complete matching knowledge of what files netcf may change. Should we worry about that and deal with the complexities of (B), or is (A) good enough for now? ncf_change_rollback(struct netcf *ncf, unsigned int flags); Again, two possbilities: A) a) save the config of all current interfaces (in memory) b) call the initscript below to restore the config to its original state. c) compare the new config to the old, and: * bring down any interfaces that no longer exist (PROBLEM: once an interface has no config files, you can no longer operate on it with "ifdown") * bounce any interfaces that have changed * bring up any interfaces that have been re-added or B) a) ifdown all interfaces b) call initscript to restore previous config (rollback_config) c) ifup all interfaces. (A) is much simpler, but may lead to unnecessary difficulties when we bounce interfaces that didn't really need it. So, the same question oas for ncf_change_start() - is the more exact operation worth the extra complexity? ncf_change_commit(struct netcf *ncf, unsigned int flags); The simplest function - this will just call the initscript to erase the backup (commit_config). 3) initscript This initscript will at first live in (be installed by) netcf (called /etc/init.d/networking-config?), but hopefully it will eventually be accepted by the initscripts package (which includes the networking-related initscripts), as it is of general use. (Dan Kenigsberg already already took a stab at this script last year, but received no reply from the initscripts maintainers, implying they may not be too keen on the idea right now - it might take some convincing ;-) https://fedorahosted.org/pipermail/initscripts-devel/2010-February/000025.h… It will have three commands, one of which will be called automatically by "start" (the command called automatically at boot time): snapshot_config This will save a copy of (what the script believes are - is this problematic?) all network-config related files. It may or may not be called by netcf (see the notes in ncf_start_change() above. If this function finds that a snapshot has already been taken, it should fail. rollback_config (automatically called from "start" at boottime) This will move back (from the saved copies) all files that were changed/removed since snapshot, *and delete any files that have been added*. Note that this command doesn't need to worry about ifup/ifdown, because it will be called prior to any other networking startup (part of the reason that netcf will need to deal with that). I notice that Dan K's version saves the modified files to a "rollback-${date}" directory. Does this seem like a good idea? It's nice to not lose anything, but there is no provision for eliminating old versions, so it could grow without bound. commit_config This will just remove all the files in the save directory. So, the two problems I have right now: 1) Do we accept the inexact method of just saving all files that match a list of patterns during *start(), then in *rollback() erasing all files matching that pattern and copying the old file back? Or do we need to keep track of what files have been changed/removed and added, and copy back / delete only those files during rollback? (A version control system would keep track of this rather nicely, but that's too complex for something that's intended to be a failsafe (and that we would also like to eventually be in the base OS install). Dan B. at one point suggested using patchfiles if I wanted the save info to keep exact track of which files would need to be replaced/deleted on rollback, but on further thought this turns out to not be workable, since we would need to run diff (to create the patchfile) after all changes had been made, and any outside changes to any of the files would leave the patchfile un-appliable, thus causing our "failsafe" to fail :-( ). Therefore, we will need to rely on the list of globs to tell us what files need to be deleted, or keep our own list in a separate file.) 2) Is it going to be okay to ifdown all interfaces prior to the rollback, and ifup all interfaces afterwards? Or must we compare the new config to the original, and ifdown only those interfaces that had been previously added/changed, then ifup only those interfaces that had been previously removed/changed? 3) If anyone has ideas on making the initscript more palatable to the initscripts people, please speak up! :-) (one comment from an initscripts person was that 1) for the general case it would be difficult to draw the line on what parts of network connectivity should be included in this rollback functionality, and 2) at some point this becomes a general system config problem, and would really be better addressed by a general system wide config management system. These are both concerns that need well qualified answers. (I tend to think that this is intended as a failsafe to prevent unreachable systems, so it should be as simple as possible, and thus shouldn't be burdened with the complexity of a full system config management system (which could also co-exist at a higher level), but better answers are welcome.)

4 10

[libvirt] [PATCH v3 0/5] Add TXT record and hosts support for DNS service and dnsmasq command-line regression testing
by Michal Novotny 02 May '11

02 May '11

Hi, this is the patch to introduce the TXT record and DNS hosts support for the DNS service on the virtual network. This can be defined using the txt-record subelement in the dns element of the network XML description. The definition of TXT record names containing spaces is rejected with the error message that TXT record names in DNS doesn't support spaces. Also, regression testing for the dnsmasq command line has been added to test whether the dnsmasq command-line is correct or not. The new XML definition syntax is: <dns> <txt name="example" value="example value" /> <host ip='192.168.122.1'> <hostname>gateway</hostname> <hostname>host</hostname> </host> </dns> Where multiple host elements can be defined to put the aliases. The <dns> element have to be present on the <ip> level, i.e. one level upper than it was in version 2 of the patch since the definition affects all the IP addresses on the network. The patch series has been tested for the configuration and it was working fine and also RelaxNG schema with the tests have been both altered to add test cases to test those patches. All of the patches passed the all the tests and everything was working fine. Michal Signed-off-by: Michal Novotny <minovotn(a)redhat.com> Michal Novotny (5): Add TXT record support for virtual DNS service Network: Add regression tests for the command-line arguments Network: Move dnsmasqContext creation to networkSaveDnsmasqHostsfile() and pass to dnsmasq only if applicable Network: Add additional hosts internal infrastructure Network: Add support for DNS hosts definition to the network XML .gnulib | 2 +- docs/formatnetwork.html.in | 31 +++ docs/schemas/network.rng | 21 ++ src/Makefile.am | 7 +- src/conf/network_conf.c | 212 +++++++++++++++ src/conf/network_conf.h | 25 ++ src/libvirt_network.syms | 6 + src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 118 ++++++--- src/network/bridge_driver.h | 3 + src/util/dnsmasq.c | 285 ++++++++++++++++++-- src/util/dnsmasq.h | 22 ++- tests/Makefile.am | 10 + tests/networkxml2argvdata/isolated-network.argv | 1 + tests/networkxml2argvdata/isolated-network.xml | 11 + .../networkxml2argvdata/nat-network-dns-hosts.argv | 1 + .../networkxml2argvdata/nat-network-dns-hosts.xml | 13 + .../nat-network-dns-txt-record.argv | 1 + .../nat-network-dns-txt-record.xml | 24 ++ tests/networkxml2argvdata/nat-network.argv | 1 + tests/networkxml2argvdata/nat-network.xml | 21 ++ tests/networkxml2argvdata/netboot-network.argv | 1 + tests/networkxml2argvdata/netboot-network.xml | 14 + .../networkxml2argvdata/netboot-proxy-network.argv | 1 + .../networkxml2argvdata/netboot-proxy-network.xml | 13 + tests/networkxml2argvdata/routed-network.argv | 1 + tests/networkxml2argvdata/routed-network.xml | 9 + tests/networkxml2argvtest.c | 115 ++++++++ .../nat-network-dns-txt-record.xml | 24 ++ .../nat-network-dns-txt-record.xml | 24 ++ tests/networkxml2xmltest.c | 2 + 31 files changed, 967 insertions(+), 53 deletions(-) create mode 100644 src/libvirt_network.syms create mode 100644 tests/networkxml2argvdata/isolated-network.argv create mode 100644 tests/networkxml2argvdata/isolated-network.xml create mode 100644 tests/networkxml2argvdata/nat-network-dns-hosts.argv create mode 100644 tests/networkxml2argvdata/nat-network-dns-hosts.xml create mode 100644 tests/networkxml2argvdata/nat-network-dns-txt-record.argv create mode 100644 tests/networkxml2argvdata/nat-network-dns-txt-record.xml create mode 100644 tests/networkxml2argvdata/nat-network.argv create mode 100644 tests/networkxml2argvdata/nat-network.xml create mode 100644 tests/networkxml2argvdata/netboot-network.argv create mode 100644 tests/networkxml2argvdata/netboot-network.xml create mode 100644 tests/networkxml2argvdata/netboot-proxy-network.argv create mode 100644 tests/networkxml2argvdata/netboot-proxy-network.xml create mode 100644 tests/networkxml2argvdata/routed-network.argv create mode 100644 tests/networkxml2argvdata/routed-network.xml create mode 100644 tests/networkxml2argvtest.c create mode 100644 tests/networkxml2xmlin/nat-network-dns-txt-record.xml create mode 100644 tests/networkxml2xmlout/nat-network-dns-txt-record.xml -- 1.7.3.2

1 5