- Devel - libvirt List Archives

[PATCH 0/2] logging: add log cleanup for obsolete domains
by Oleg Vasilev 30 Nov '22

30 Nov '22

Motivation comes from the case when libguestfs has repeatedly created transient VMs, which in turn created lots of logs without any mechanism to delete it afterwards. More motivation in [1]. Previous attempt in [2]. [1]: https://listman.redhat.com/archives/libvir-list/2022-February/msg00425.html [2]: https://listman.redhat.com/archives/libvir-list/2022-February/msg00865.html Oleg Vasilev (2): logging: refactor to store config inside log handler logging: add log cleanup for obsolete domains src/logging/log_daemon.c | 6 +- src/logging/log_daemon_config.c | 9 ++ src/logging/log_daemon_config.h | 3 + src/logging/log_handler.c | 137 +++++++++++++++++++++++++++---- src/logging/log_handler.h | 17 ++-- src/logging/test_virtlogd.aug.in | 2 + src/logging/virtlogd.aug | 2 + src/logging/virtlogd.conf | 7 ++ 8 files changed, 153 insertions(+), 30 deletions(-) -- 2.38.1

2 5

[PATCH] Fix couple of comment typos
by Martin Kletzander 30 Nov '22

30 Nov '22

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial. examples/c/admin/list_clients.c | 2 +- examples/c/admin/logging.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/c/admin/list_clients.c b/examples/c/admin/list_clients.c index 70907b4fba2f..169c9a7ec814 100644 --- a/examples/c/admin/list_clients.c +++ b/examples/c/admin/list_clients.c @@ -53,7 +53,7 @@ int main(int argc, char **argv) { int ret = -1; virAdmConnectPtr conn = NULL; - virAdmServerPtr srv = NULL; /* which server list the clients from */ + virAdmServerPtr srv = NULL; /* which server to list the clients from */ virAdmClientPtr *clients = NULL; /* where to store the servers */ ssize_t i = 0; int count = 0; diff --git a/examples/c/admin/logging.c b/examples/c/admin/logging.c index 730ae40d9d53..575d15a3a67c 100644 --- a/examples/c/admin/logging.c +++ b/examples/c/admin/logging.c @@ -77,7 +77,7 @@ int main(int argc, char **argv) goto cleanup; } - /* now, try to change the redefine the current log output and filters */ + /* now, try to change the current log output and filters */ if (virAdmConnectSetLoggingOutputs(conn, set_outputs, 0) < 0) goto cleanup; -- 2.38.1

1 0

[PATCH] selinux: Reflect context_str() type change
by Michal Privoznik 29 Nov '22

29 Nov '22

As of [1]. libselinux changed the type of context_str() - it now returns a const string. Follow this change in our code base. 1: https://github.com/SELinuxProject/selinux/commit/dd98fa322766760c4e1f029cf1… Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/security/security_selinux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 1f72f61cac..92e85c92e0 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -526,7 +526,7 @@ static char * virSecuritySELinuxContextAddRange(char *src, char *dst) { - char *str = NULL; + const char *str = NULL; char *ret = NULL; context_t srccon = NULL; context_t dstcon = NULL; @@ -567,7 +567,7 @@ virSecuritySELinuxGenNewContext(const char *basecontext, { context_t context = NULL; char *ret = NULL; - char *str; + const char *str; char *ourSecContext = NULL; context_t ourContext = NULL; -- 2.37.4

2 1

Entering freeze for libvirt-8.10.0
by Jiri Denemark 29 Nov '22

29 Nov '22

I have just tagged v8.10.0-rc1 in the repository and pushed signed tarballs and source RPMs to https://libvirt.org/sources/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH 0/2] qemu: refresh state after reset
by Kristina Hanicova 29 Nov '22

29 Nov '22

This series implements domain state refreshing after reset from libvirt API and reboot from the guest OS. Kristina Hanicova (2): qemu: refresh state after reset qemu: refresh state after reboot initiated from the guest src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 22 +++++++++++++++++++++- src/qemu/qemu_process.c | 2 ++ 4 files changed, 25 insertions(+), 1 deletion(-) -- 2.38.1

2 3

[PATCH v2] qemu_tpm: Check for qemuTPMSetupEncryption() errors
by Michal Privoznik 29 Nov '22

29 Nov '22

Inside of qemuTPMEmulatorBuildCommand() there are two calls to qemuTPMSetupEncryption() which simply ignore returned error. This is suboptimal because then we rely on swtpm binary reporting a generic error (something among invalid command line arguments) while an error reported by qemuTPMSetupEncryption() is more specific. However, since virCommandSetSendBuffer() only sets an error inside of virCommand structure (the error is then reported in virCommandRun()), we need to exempt its retval from error checking. Thus, the signature of qemuTPMSetupEncryption() is changed a bit so that -1/0 can be returned to indicate error. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- v2 of: https://listman.redhat.com/archives/libvir-list/2022-November/235866.html diff to v1: - Ignore error from virCommandSetSendBuffer() as it'll be reported later. Don't actually jump onto error label as it would defeat the purpose. src/qemu/qemu_tpm.c | 29 ++++++++++++++++++++--------- 1 file changed, 20 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index 15ee7db757..bdce060db8 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -224,20 +224,25 @@ qemuTPMEmulatorDeleteStorage(virDomainTPMDef *tpm) * * @secretuuid: The UUID with the secret holding passphrase * @cmd: the virCommand to transfer the secret to + * @fd: returned read-end of the pipe * - * Returns file descriptor representing the read-end of a pipe. - * The passphrase can be read from this pipe. Returns < 0 in case - * of error. + * Sets @fd to a file descriptor representing the read-end of a + * pipe. The passphrase can be read from this pipe. * * This function reads the passphrase and writes it into the * write-end of a pipe so that the read-end of the pipe can be * passed to the emulator for reading the passphrase from. * - * Note that the returned FD is owned by @cmd. + * Note that the returned @fd is owned by @cmd and thus should + * only be used to append an argument onto emulator cmdline. + * + * Returns: 0 on success, + * -1 otherwise (with proper error reported). */ static int qemuTPMSetupEncryption(const unsigned char *secretuuid, - virCommand *cmd) + virCommand *cmd, + int *fd) { g_autoptr(virConnect) conn = NULL; g_autofree uint8_t *secret = NULL; @@ -260,7 +265,8 @@ qemuTPMSetupEncryption(const unsigned char *secretuuid, &secret, &secret_len) < 0) return -1; - return virCommandSetSendBuffer(cmd, g_steal_pointer(&secret), secret_len); + *fd = virCommandSetSendBuffer(cmd, g_steal_pointer(&secret), secret_len); + return 0; } @@ -322,7 +328,7 @@ qemuTPMVirCommandAddEncryption(virCommand *cmd, return -1; } - if ((pwdfile_fd = qemuTPMSetupEncryption(secretuuid, cmd)) < 0) + if (qemuTPMSetupEncryption(secretuuid, cmd, &pwdfile_fd) < 0) return -1; virCommandAddArg(cmd, "--pwdfile-fd"); @@ -634,8 +640,13 @@ qemuTPMEmulatorBuildCommand(virDomainTPMDef *tpm, goto error; } - pwdfile_fd = qemuTPMSetupEncryption(tpm->data.emulator.secretuuid, cmd); - migpwdfile_fd = qemuTPMSetupEncryption(tpm->data.emulator.secretuuid, cmd); + if (qemuTPMSetupEncryption(tpm->data.emulator.secretuuid, + cmd, &pwdfile_fd) < 0) + goto error; + + if (qemuTPMSetupEncryption(tpm->data.emulator.secretuuid, + cmd, &migpwdfile_fd) < 0) + goto error; virCommandAddArg(cmd, "--key"); virCommandAddArgFormat(cmd, "pwdfd=%d,mode=aes-256-cbc", pwdfile_fd); -- 2.37.4

2 1

[PATCH] Document caveats of hypervisor-specific stats in 'VIR_DOMAIN_STATS_VCPU' group
by Peter Krempa 29 Nov '22

29 Nov '22

In commit c43718ef67944 I've added a disclaimer that the new stats which are fetched from qemu and passed directly to the user are not guaranteed by libvirt. I didn't notice that per-vcpu hypervisor specific stats are also snuck into the VIR_DOMAIN_STATS_VCPU group along with other pre-existing stats we do guarantee. Extend the disclaimer for VIR_DOMAIN_STATS_VCPU too. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/virsh.rst | 22 ++++++++++++++++++++++ src/libvirt-domain.c | 17 +++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 5f5f48f83e..1e8a43bc55 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -2399,6 +2399,28 @@ When selecting the *--state* group the following fields are returned: host scheduler, but was waiting in the queue instead of running. Exposed to the VM as a steal time. +This group of statistics also reports additional hypervisor-originating per-vCPU +stats. The hypervisor-specific statistics in this group have the following +naming scheme: + + ``vcpu.<num>.$NAME.$TYPE`` + + ``$NAME`` + name of the statistics field provided by the hypervisor + + ``$TYPE`` + Type of the value. The following types are returned: + + ``cur`` + current instant value + ``sum`` + aggregate value + ``max`` + peak value + + The returned value may be either an unsigned long long or a boolean. Meaning + is hypervisor specific. Please see the disclaimer for the *--vm* group which + also consists of hypervisor-specific stats. *--interface* returns: diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 56c2abf3fa..78c26b2219 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12270,6 +12270,23 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * instead of running. Exposed to the VM as a steal * time. * + * This group of statistics also reports additional hypervisor-originating + * per-vCPU stats. The hypervisor-specific statistics in this group have the + * following naming scheme: + * + * "vcpu.<num>.$NAME.$TYPE" + * + * $NAME - name of the statistics field provided by the hypervisor + * + * $TYPE - Type of the value. The following types are returned: + * 'cur' - current instant value + * 'sum' - aggregate value + * 'max' - peak value + * + * The returned value may be either an unsigned long long or a boolean. + * Meaning is hypervisor specific. Please see the disclaimer for the + * VIR_DOMAIN_STATS_VM group below. + * * VIR_DOMAIN_STATS_INTERFACE: * Return network interface statistics (from domain point of view). * The typed parameter keys are in this format: -- 2.38.1

2 1

[PATCH v3] virsh: Add message to terminal when running snapshot-revert
by Haruka Ohata 29 Nov '22

29 Nov '22

When running virsh snapshot-* command, such as snapshot-create-as / snapshot-delete, it prints a result message. On the other hand virsh snapshot-revert command doesn't print a result message. So, This patch fixes to add message when running virsh snapshot-revert command. --- # virsh snapshot-create-as vm1 test1 Domain snapshot test01 created # virsh snapshot-revert vm1 test1 # virsh snapshot-delete vm1 test1 Domain snapshot test01 deleted # --- Signed-off-by: Haruka Ohata <ohata.haruka(a)fujitsu.com> --- tests/virsh-snapshot | 3 +++ tools/virsh-snapshot.c | 6 +++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/virsh-snapshot b/tests/virsh-snapshot index 4c64bb537b..b09273917b 100755 --- a/tests/virsh-snapshot +++ b/tests/virsh-snapshot @@ -100,11 +100,14 @@ Domain snapshot s1 created Domain snapshot s3 created Domain snapshot s2 created +Domain snapshot s3 reverted Domain snapshot s6 created Domain snapshot s5 created +Domain snapshot s6 reverted Domain snapshot s4 created +Domain snapshot s1 reverted Domain snapshot s7 created Domain snapshot s8 created diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 8fa64ba903..b7ec675e61 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1783,7 +1783,11 @@ cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd) result = virDomainRevertToSnapshot(snapshot, flags); } - return result >= 0; + if (result < 0) + vshError(ctl, _("Failed to revert snapshot %s"), name); + else + vshPrintExtra(ctl, _("Domain snapshot %s reverted\n"), name); + return result; } /* -- 2.38.1

2 1

[libvirt PATCH v2] Add basically RISC-V support
by Yu Gu 29 Nov '22

29 Nov '22

This patch provides basic support for the RISC-V architecture, so libvirt can run in RISC-V machine. Signed-off-by: Yu Gu <guyu2876(a)gmail.com> --- po/POTFILES | 1 + src/cpu/cpu.c | 2 + src/cpu/cpu.h | 2 + src/cpu/cpu_riscv64.c | 118 +++++++++++++++++++++++++++++++ src/cpu/cpu_riscv64.h | 28 ++++++++ src/cpu/cpu_riscv64_data.h | 40 +++++++++++ src/cpu/meson.build | 1 + src/cpu_map/index.xml | 4 ++ src/cpu_map/meson.build | 1 + src/cpu_map/riscv64_vendors.xml | 3 + src/util/virarch.c | 2 + src/util/virhostcpu.c | 2 +- src/util/virsysinfo.c | 121 ++++++++++++++++++++++++++++++++ 13 files changed, 324 insertions(+), 1 deletion(-) create mode 100644 src/cpu/cpu_riscv64.c create mode 100644 src/cpu/cpu_riscv64.h create mode 100644 src/cpu/cpu_riscv64_data.h create mode 100644 src/cpu_map/riscv64_vendors.xml diff --git a/po/POTFILES b/po/POTFILES index 169e2a41dc..a52795e7c1 100644 --- a/po/POTFILES +++ b/po/POTFILES @@ -72,6 +72,7 @@ src/cpu/cpu_map.c src/cpu/cpu_ppc64.c src/cpu/cpu_s390.c src/cpu/cpu_x86.c +src/cpu/cpu_riscv64.c src/datatypes.c src/driver.c src/esx/esx_driver.c diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index d97ef5e873..8fdc42e719 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -27,6 +27,7 @@ #include "cpu_ppc64.h" #include "cpu_s390.h" #include "cpu_arm.h" +#include "cpu_riscv64.h" #include "capabilities.h" @@ -39,6 +40,7 @@ static struct cpuArchDriver *drivers[] = { &cpuDriverPPC64, &cpuDriverS390, &cpuDriverArm, + &cpuDriverRISCV64, }; diff --git a/src/cpu/cpu.h b/src/cpu/cpu.h index 41a62ce486..6e0a06fce4 100644 --- a/src/cpu/cpu.h +++ b/src/cpu/cpu.h @@ -27,6 +27,7 @@ #include "cpu_x86_data.h" #include "cpu_ppc64_data.h" #include "cpu_arm_data.h" +#include "cpu_riscv64_data.h" typedef struct _virCPUData virCPUData; @@ -36,6 +37,7 @@ struct _virCPUData { virCPUx86Data x86; virCPUppc64Data ppc64; virCPUarmData arm; + virCPUriscv64Data riscv64; /* generic driver needs no data */ } data; }; diff --git a/src/cpu/cpu_riscv64.c b/src/cpu/cpu_riscv64.c new file mode 100644 index 0000000000..21f7178cc2 --- /dev/null +++ b/src/cpu/cpu_riscv64.c @@ -0,0 +1,118 @@ +/* + * cpu_riscv64.c: CPU driver for riscv64(x) CPUs + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + */ + +#include <config.h> + +#include "cpu.h" + + +#define VIR_FROM_THIS VIR_FROM_CPU + +static const virArch archs[] = { VIR_ARCH_RISCV64 }; + +static virCPUCompareResult +virCPUriscv64Compare(virCPUDef *host G_GNUC_UNUSED, + virCPUDef *cpu G_GNUC_UNUSED, + bool failMessages G_GNUC_UNUSED) +{ + /* riscv64 relies on QEMU to perform all runability checking. Return + * VIR_CPU_COMPARE_IDENTICAL to bypass Libvirt checking. + */ + return VIR_CPU_COMPARE_IDENTICAL; +} + +static int +virCPUriscv64Update(virCPUDef *guest, + const virCPUDef *host, + bool relative) +{ + g_autoptr(virCPUDef) updated = NULL; + size_t i; + + if (!relative) + return 0; + + if (guest->mode == VIR_CPU_MODE_CUSTOM) { + if (guest->match == VIR_CPU_MATCH_MINIMUM) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("match mode %s not supported"), + virCPUMatchTypeToString(guest->match)); + } else { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("optional CPU features are not supported")); + } + return -1; + } + + if (!host) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("unknown host CPU model")); + return -1; + } + + if (!(updated = virCPUDefCopyWithoutModel(guest))) + return -1; + + updated->mode = VIR_CPU_MODE_CUSTOM; + if (virCPUDefCopyModel(updated, host, true) < 0) + return -1; + + for (i = 0; i < guest->nfeatures; i++) { + if (virCPUDefUpdateFeature(updated, + guest->features[i].name, + guest->features[i].policy) < 0) + return -1; + } + + virCPUDefStealModel(guest, updated, false); + guest->mode = VIR_CPU_MODE_CUSTOM; + guest->match = VIR_CPU_MATCH_EXACT; + + return 0; +} + + +static int +virCPUriscv64ValidateFeatures(virCPUDef *cpu) +{ + size_t i; + + for (i = 0; i < cpu->nfeatures; i++) { + if (cpu->features[i].policy == VIR_CPU_FEATURE_OPTIONAL) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("only cpu feature policies 'require' and " + "'disable' are supported for %s"), + cpu->features[i].name); + return -1; + } + } + + return 0; +} + +struct cpuArchDriver cpuDriverRISCV64 = { + .name = "riscv64", + .arch = archs, + .narch = G_N_ELEMENTS(archs), + .compare = virCPUriscv64Compare, + .decode = NULL, + .encode = NULL, + .baseline = NULL, + .update = virCPUriscv64Update, + .validateFeatures = virCPUriscv64ValidateFeatures, +}; diff --git a/src/cpu/cpu_riscv64.h b/src/cpu/cpu_riscv64.h new file mode 100644 index 0000000000..67528415fe --- /dev/null +++ b/src/cpu/cpu_riscv64.h @@ -0,0 +1,28 @@ +/* + * cpu_riscv64.h: CPU driver for 64-bit RISC-V CPUs + * + * Copyright (C) Copyright (C) IBM Corporation, 2010 + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + */ + +#ifndef __VIR_CPU_RISCV64_H__ +# define __VIR_CPU_RISCV64_H__ + +# include "cpu.h" + +extern struct cpuArchDriver cpuDriverRISCV64; + +#endif diff --git a/src/cpu/cpu_riscv64_data.h b/src/cpu/cpu_riscv64_data.h new file mode 100644 index 0000000000..819b9e8fde --- /dev/null +++ b/src/cpu/cpu_riscv64_data.h @@ -0,0 +1,40 @@ +/* + * cpu_riscv64_data.h: 64-bit riscv64 CPU specific data + * + * Copyright (C) 2012 IBM Corporation. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see + * <http://www.gnu.org/licenses/>. + */ + +#ifndef __VIR_CPU_RISCV64_DATA_H__ +# define __VIR_CPU_RISCV64_DATA_H__ + +# include <stdint.h> + +typedef struct _virCPUriscv64Prid virCPUriscv64Prid; +struct _virCPUriscv64Prid { + uint32_t value; + uint32_t mask; +}; + +# define VIR_CPU_riscv64_DATA_INIT { 0 } + +typedef struct _virCPUriscv64Data virCPUriscv64Data; +struct _virCPUriscv64Data { + size_t len; + virCPUriscv64Prid *prid; +}; + +#endif diff --git a/src/cpu/meson.build b/src/cpu/meson.build index b4ad95e46d..eba1d45743 100644 --- a/src/cpu/meson.build +++ b/src/cpu/meson.build @@ -5,6 +5,7 @@ cpu_sources = [ 'cpu_ppc64.c', 'cpu_s390.c', 'cpu_x86.c', + 'cpu_riscv64.c', ] cpu_lib = static_library( diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml index d533a28865..f2c4b1c62a 100644 --- a/src/cpu_map/index.xml +++ b/src/cpu_map/index.xml @@ -89,6 +89,10 @@ <include filename='ppc64_POWERPC_e6500.xml'/> </arch> + <arch name='riscv64'> + <include filename='riscv64_vendors.xml'/> + </arch> + <arch name='arm'> <include filename='arm_vendors.xml'/> <include filename='arm_features.xml'/> diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build index 99264289e2..1a02df8268 100644 --- a/src/cpu_map/meson.build +++ b/src/cpu_map/meson.build @@ -19,6 +19,7 @@ cpumap_data = [ 'ppc64_POWERPC_e5500.xml', 'ppc64_POWERPC_e6500.xml', 'ppc64_vendors.xml', + 'riscv64_vendors.xml', 'x86_486.xml', 'x86_athlon.xml', 'x86_Broadwell-IBRS.xml', diff --git a/src/cpu_map/riscv64_vendors.xml b/src/cpu_map/riscv64_vendors.xml new file mode 100644 index 0000000000..478a23a467 --- /dev/null +++ b/src/cpu_map/riscv64_vendors.xml @@ -0,0 +1,3 @@ +<cpus> + <vendor name='RISC-V'/> +</cpus> \ No newline at end of file diff --git a/src/util/virarch.c b/src/util/virarch.c index 2134dd6a9d..3d14ecd193 100644 --- a/src/util/virarch.c +++ b/src/util/virarch.c @@ -190,6 +190,8 @@ virArch virArchFromHost(void) return VIR_ARCH_ALPHA; case PROCESSOR_ARCHITECTURE_PPC: return VIR_ARCH_PPC; + case PROCESSOR_ARCHITECTURE_RISCV: + return VIR_ARCH_RISCV64; case PROCESSOR_ARCHITECTURE_SHX: return VIR_ARCH_SH4; case PROCESSOR_ARCHITECTURE_ARM: diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index c1e8dc8078..08c2290f00 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -544,7 +544,7 @@ virHostCPUParseFrequency(FILE *cpuinfo, char line[1024]; /* No sensible way to retrieve CPU frequency */ - if (ARCH_IS_ARM(arch)) + if (ARCH_IS_ARM(arch) || ARCH_IS_RISCV(arch)) return 0; if (ARCH_IS_X86(arch)) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 376d5d4816..e281d928c7 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -623,6 +623,125 @@ virSysinfoReadS390(void) return g_steal_pointer(&ret); } +#if 0 +static int +virSysinfoParseRISCVSystem(const char *base, virSysinfoSystemDef **sysdef) +{ + int ret = -1; + virSysinfoSystemDef *def; + + def = g_new0(virSysinfoSystemDef, 1); + +#if 0 + if (!virSysinfoParseS390Line(base, "Manufacturer", &def->manufacturer)) + goto cleanup; + + if (!virSysinfoParseS390Line(base, "Type", &def->family)) + goto cleanup; +#endif + def->manufacturer = g_strndup("Virt-RISC-V", sizeof("Virt RISC-V")); + + if (!def->manufacturer && !def->product && !def->version && + !def->serial && !def->uuid && !def->sku && !def->family) { + g_clear_pointer(&def, virSysinfoSystemDefFree); + } + + *sysdef = g_steal_pointer(&def); + ret = 0; + cleanup: + virSysinfoSystemDefFree(def); + return ret; +} +#endif + +static int +virSysinfoParseRISCVProcessor(const char *base, virSysinfoDef *ret) +{ + const char *tmp_base; + char *manufacturer = NULL; + char *procline = NULL; + char *ncpu = NULL; + int result = -1; + virSysinfoProcessorDef *processor; + + if (!(tmp_base = virSysinfoParseS390Line(base, "uarch", &manufacturer))) + goto error; + + /* Find processor N: line and gather the processor manufacturer, + version, serial number, and family */ + while ((tmp_base = strstr(tmp_base, "processor ")) + && (tmp_base = virSysinfoParseS390Line(tmp_base, "processor ", + &procline))) { + VIR_EXPAND_N(ret->processor, ret->nprocessor, 1); + processor = &ret->processor[ret->nprocessor - 1]; + processor->processor_manufacturer = g_strdup(manufacturer); + + VIR_FREE(procline); + } + + /* now, for each processor found, extract the frequency information */ + tmp_base = base; + + while ((tmp_base = strstr(tmp_base, "hart")) && + (tmp_base = virSysinfoParseS390Line(tmp_base, "hart", &ncpu))) { + unsigned int n; + char *mhz = NULL; + + if (virStrToLong_uip(ncpu, NULL, 10, &n) < 0) + goto error; + + if (n >= ret->nprocessor) { + VIR_DEBUG("CPU number '%u' out of range", n); + goto cleanup; + } + + VIR_FREE(ncpu); + } + + cleanup: + result = 0; + + error: + VIR_FREE(manufacturer); + VIR_FREE(procline); + VIR_FREE(ncpu); + return result; +} + +virSysinfoDef * +virSysinfoReadRISCV(void) +{ + g_autoptr(virSysinfoDef) ret = NULL; + g_autofree char *outbuf = NULL; + + ret = g_new0(virSysinfoDef, 1); + + /* Gather info from /proc/cpuinfo */ + if (virFileReadAll(CPUINFO, CPUINFO_FILE_LEN, &outbuf) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to open %s"), CPUINFO); + return NULL; + } + + if (virSysinfoParseRISCVProcessor(outbuf, ret) < 0) + return NULL; + + /* Free buffer before reading next file */ + VIR_FREE(outbuf); + +#if 0 + /* Gather info from /proc/sysinfo */ + if (virFileReadAll(SYSINFO, 8192, &outbuf) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Failed to open %s"), SYSINFO); + return NULL; + } + + if (virSysinfoParseRISCVSystem(outbuf, &ret->system) < 0) + return NULL; +#endif + return g_steal_pointer(&ret); +} static int virSysinfoParseBIOS(const char *base, virSysinfoBIOSDef **bios) @@ -1243,6 +1362,8 @@ virSysinfoRead(void) return virSysinfoReadPPC(); #elif defined(__arm__) || defined(__aarch64__) return virSysinfoReadARM(); +#elif defined(__riscv) && __riscv_xlen == 64 + return virSysinfoReadRISCV(); #elif defined(__s390__) || defined(__s390x__) return virSysinfoReadS390(); #elif !defined(WIN32) && \ -- 2.37.3

2 2

[PATCH 0/2] Couple of domain <interface/> fixes
by Michal Privoznik 28 Nov '22

28 Nov '22

The first one fixes a bug that was reported on the list: https://listman.redhat.com/archives/libvir-list/2022-November/235922.html The second one - I've noticed while investigating the first one. Michal Prívozník (2): conf: Make VIR_DOMAIN_NET_TYPE_ETHERNET not share 'host view' virnetdevbandwidth: Unbreak tc filter update on Linux-4.20+ src/conf/domain_conf.c | 2 +- src/util/virnetdevbandwidth.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) -- 2.37.4

3 4

[PATCH] NEWS: Update for 8.10.0
by Peter Krempa 28 Nov '22

28 Nov '22

Mention 'virt-qemu-sev-validate', SGX EPC, vTPM migration, cpu flag additions and other notable changes in this release. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2ce8ef4b6a..c119d68da6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,10 +17,85 @@ v8.10.0 (unreleased) * **New features** + * Tool for validating SEV firmware boot measurement of QEMU VMs + + The ``virt-qemu-sev-validate`` program will compare a reported SEV/SEV-ES + domain launch measurement, to a computed launch measurement. This + determines whether the domain has been tampered with during launch. + + * Support for SGX EPC (enclave page cache) + + Users can add a ``<memory model='sgx-epc'>`` device to lauch a VM with + ``Intel Software Guard Extensions``. + + * Support migration of vTPM state of QEMU vms on shared storage + + Pass ``--migration`` option if appropriate in order for ``swtpm`` to + properly migrate on shared storage. + * **Improvements** + * Mark close callback (un-)register API as high priority + + High priority APIs use a separate thread pool thus can help in eliminating + problems with stuck VMs. Marking the close callback API as high priority + allows ``virsh`` to properly connect to the daemon in case the normal + priority workers are stuck allowing other high priority API usage. + + * Updated x86 CPU features + + The following features for the x86 platform were added: + ``v-vmsave-vmload``, ``vgif``, ``avx512-vp2intersect``, ``avx512-fp16``, + ``serialize``, ``tsx-ldtrk``, ``arch-lbr``, ``xfd``, ``intel-pt-lip``, + ``avic``, ``sgx``, ``sgxlc``, ``sgx-exinfo``, ``sgx1``, ``sgx2``, + ``sgx-debug``, ``sgx-mode64``, ``sgx-provisionkey``, ``sgx-tokenkey``, + ``sgx-kss``, ``bus-lock-detect``, ``pks``, ``amx``. + + * Add support for ``hv-avic`` Hyper-V enlightenment + + ``qemu-6.2`` introduced support for the ``hv-avic`` enlightenment which + allows to use Hyper-V SynIC with hardware APICv/AVIC enabled. + + * qemu: Run memory preallocation with numa-pinned threads + + Run the thread allocating memory in the proper NUMA node to reduce overhead. + + * RPM packaging changes + + - add optional dependancy of ``libvirt-daemon`` on ``libvirt-client`` + + The ``libvirt-guests.`` tool requires the ``virsh`` client to work + properly, but we don't want to require the installation of the daemon + if the tool is not used. + + - relax required ``python3-libvirt`` version for ``libvirt-client-qemu`` + + The ``virt-qemu-qmp-proxy`` tool requires python but doesn't strictly + need the newest version. Remove the strict versioning requirement in + order to prevent cyclic dependency when building. + * **Bug fixes** + * Skip initialization of ``cache`` capabilities if host doesn't support them + + Hypervisor drivers would fail to initialize on ``aarch64`` hosts with + following error :: + + virStateInitialize:657 : Initialisation of cloud-hypervisor state driver failed: no error + + which prevented the startup of the daemon. + + * Allow incoming connections to guests on routed networks w/firewalld + + A change in handling of implicit rules in ``firewalld 1.0.0`` broke + incomming connections to VMs when using ``routed`` network. This is fixed + by adding a new ``libvirt-routed`` zone configured to once again allow + incoming sessions to guests on routed networks. + + * Fix infinite loop in nodedev driver + + Certain udev entries might be of a size that makes libudev emit EINVAL + which caused a busy loop burning CPU. Fix it by ignoring the return code. v8.9.0 (2022-11-01) =================== -- 2.38.1

2 1

[PATCH v2] virsh: Add message to terminal when running snapshot-revert
by Haruka Ohata 28 Nov '22

28 Nov '22

When running virsh snapshot-* command, such as snapshot-create-as / snapshot-delete, it prints a result message. On the other hand virsh snapshot-revert command doesn't print a result message. So, This patch fixes to add message when running virsh snapshot-revert command. --- # virsh snapshot-create-as vm1 test1 Domain snapshot test01 created # virsh snapshot-revert vm1 test1 # virsh snapshot-delete vm1 test1 Domain snapshot test01 deleted # --- Signed-off-by: Haruka Ohata <ohata.haruka(a)fujitsu.com> --- tests/virsh-snapshot | 3 +++ tools/virsh-snapshot.c | 10 +++++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tests/virsh-snapshot b/tests/virsh-snapshot index 4c64bb537b..b09273917b 100755 --- a/tests/virsh-snapshot +++ b/tests/virsh-snapshot @@ -100,11 +100,14 @@ Domain snapshot s1 created Domain snapshot s3 created Domain snapshot s2 created +Domain snapshot s3 reverted Domain snapshot s6 created Domain snapshot s5 created +Domain snapshot s6 reverted Domain snapshot s4 created +Domain snapshot s1 reverted Domain snapshot s7 created Domain snapshot s8 created diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 8fa64ba903..4576bf1020 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1745,7 +1745,7 @@ static const vshCmdOptDef opts_snapshot_revert[] = { }; static bool -cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd) +cmdSnapshotRevert(vshControl *ctl, const vshCmd *cmd) { g_autoptr(virshDomain) dom = NULL; const char *name = NULL; @@ -1783,7 +1783,11 @@ cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd) result = virDomainRevertToSnapshot(snapshot, flags); } - return result >= 0; + if (virDomainRevertToSnapshot(snapshot, flags) < 0) + vshError(ctl, _("Failed to revert snapshot %s"), name); + else + vshPrintExtra(ctl, _("Domain snapshot %s reverted\n"), name); + return result; } /* @@ -1916,7 +1920,7 @@ const vshCmdDef snapshotCmds[] = { .flags = 0 }, {.name = "snapshot-revert", - .handler = cmdDomainSnapshotRevert, + .handler = cmdSnapshotRevert, .opts = opts_snapshot_revert, .info = info_snapshot_revert, .flags = 0 -- 2.38.1

2 1

[PATCH] conf: report no NUMA nodes when attaching memory device
by Kristina Hanicova 25 Nov '22

25 Nov '22

Error message reports that the guest has '0' NUMA nodes configured when trying to attach a memory device to a guest with no NUMA nodes. This may be a little misleading because '0' can also be node's id. A more friendly way is to directly report that the guest has no NUMA nodes. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2142519 Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/conf/domain_validate.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 5bc7ea10aa..95b8d9b419 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2257,6 +2257,12 @@ virDomainMemoryDefValidate(const virDomainMemoryDef *mem, if (mem->targetNode != -1) { const size_t nodeCount = virDomainNumaGetNodeCount(def->numa); + if (nodeCount == 0) { + virReportError(VIR_ERR_XML_DETAIL, "%s", + _("can't add memory backend as guest has no NUMA nodes configured")); + return -1; + } + if (mem->targetNode >= nodeCount) { virReportError(VIR_ERR_XML_DETAIL, _("can't add memory backend for guest node '%d' as the guest has only '%zu' NUMA nodes configured"), -- 2.38.1

2 1

[PATCH v2] cpu_s390: Implement getVendorForModel for IBM Z
by Thomas Huth 25 Nov '22

25 Nov '22

When running "virsh domcapabilities" on a s390x host, all the CPU models show up with vendor='unknown' - which sounds kind of weird since the vendor of these mainframe CPUs is well known: IBM. All CPUs starting with either "z" or "gen" match a real mainframe CPU by IBM, so let's return the string "IBM" for those now. The only remaining ones are now the artifical "qemu" and "max" models from QEMU itself, so it should be OK to get an "unknown" vendor for those two. Thanks to Boris Fiuczynski for helping with the domaincapsdata! Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- src/cpu/cpu_s390.c | 11 ++ tests/domaincapsdata/qemu_4.2.0.s390x.xml | 144 +++++++++++----------- tests/domaincapsdata/qemu_5.2.0.s390x.xml | 144 +++++++++++----------- tests/domaincapsdata/qemu_6.0.0.s390x.xml | 144 +++++++++++----------- 4 files changed, 227 insertions(+), 216 deletions(-) diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c index d908a83928..7416ec6dc5 100644 --- a/src/cpu/cpu_s390.c +++ b/src/cpu/cpu_s390.c @@ -109,6 +109,16 @@ virCPUs390ValidateFeatures(virCPUDef *cpu) } +static const char * +virCPUs390GetVendorForModel(const char *modelName) +{ + if (modelName[0] == 'z' || STREQLEN(modelName, "gen", 3)) + return "IBM"; + + return NULL; +} + + struct cpuArchDriver cpuDriverS390 = { .name = "s390", .arch = archs, @@ -119,4 +129,5 @@ struct cpuArchDriver cpuDriverS390 = { .baseline = NULL, .update = virCPUs390Update, .validateFeatures = virCPUs390ValidateFeatures, + .getVendorForModel = virCPUs390GetVendorForModel, }; diff --git a/tests/domaincapsdata/qemu_4.2.0.s390x.xml b/tests/domaincapsdata/qemu_4.2.0.s390x.xml index 4f176e2d37..66841881a1 100644 --- a/tests/domaincapsdata/qemu_4.2.0.s390x.xml +++ b/tests/domaincapsdata/qemu_4.2.0.s390x.xml @@ -83,79 +83,79 @@ <feature policy='require' name='cmm'/> </mode> <mode name='custom' supported='yes'> - <model usable='yes' vendor='unknown'>z800-base</model> - <model usable='yes' vendor='unknown'>z890.2-base</model> - <model usable='yes' vendor='unknown'>z9EC.2</model> - <model usable='yes' vendor='unknown'>z13.2</model> - <model usable='yes' vendor='unknown'>z9BC-base</model> - <model usable='yes' vendor='unknown'>z990.5-base</model> - <model usable='yes' vendor='unknown'>z890.2</model> - <model usable='yes' vendor='unknown'>z890</model> - <model usable='yes' vendor='unknown'>z9BC</model> - <model usable='yes' vendor='unknown'>z13</model> - <model usable='yes' vendor='unknown'>z196</model> - <model usable='yes' vendor='unknown'>z13s</model> - <model usable='yes' vendor='unknown'>z990.3</model> - <model usable='yes' vendor='unknown'>z13s-base</model> - <model usable='yes' vendor='unknown'>z9EC</model> - <model usable='yes' vendor='unknown'>gen15a</model> - <model usable='yes' vendor='unknown'>z14ZR1-base</model> - <model usable='yes' vendor='unknown'>z14.2-base</model> - <model usable='yes' vendor='unknown'>z900.3-base</model> - <model usable='yes' vendor='unknown'>z13.2-base</model> - <model usable='yes' vendor='unknown'>z196.2-base</model> - <model usable='yes' vendor='unknown'>zBC12-base</model> - <model usable='yes' vendor='unknown'>z9BC.2-base</model> - <model usable='yes' vendor='unknown'>z900.2-base</model> - <model usable='yes' vendor='unknown'>z9EC.3</model> - <model usable='yes' vendor='unknown'>zEC12</model> - <model usable='yes' vendor='unknown'>z900</model> - <model usable='yes' vendor='unknown'>z114-base</model> - <model usable='yes' vendor='unknown'>zEC12-base</model> - <model usable='yes' vendor='unknown'>z10EC.2</model> - <model usable='yes' vendor='unknown'>z10EC-base</model> - <model usable='yes' vendor='unknown'>z900.3</model> - <model usable='yes' vendor='unknown'>z14ZR1</model> - <model usable='yes' vendor='unknown'>z10BC</model> - <model usable='yes' vendor='unknown'>z10BC.2-base</model> - <model usable='yes' vendor='unknown'>z990.2</model> - <model usable='yes' vendor='unknown'>z9BC.2</model> - <model usable='yes' vendor='unknown'>z990</model> - <model usable='yes' vendor='unknown'>z14</model> - <model usable='yes' vendor='unknown'>gen15b-base</model> - <model usable='yes' vendor='unknown'>z990.4</model> + <model usable='yes' vendor='IBM'>z800-base</model> + <model usable='yes' vendor='IBM'>z890.2-base</model> + <model usable='yes' vendor='IBM'>z9EC.2</model> + <model usable='yes' vendor='IBM'>z13.2</model> + <model usable='yes' vendor='IBM'>z9BC-base</model> + <model usable='yes' vendor='IBM'>z990.5-base</model> + <model usable='yes' vendor='IBM'>z890.2</model> + <model usable='yes' vendor='IBM'>z890</model> + <model usable='yes' vendor='IBM'>z9BC</model> + <model usable='yes' vendor='IBM'>z13</model> + <model usable='yes' vendor='IBM'>z196</model> + <model usable='yes' vendor='IBM'>z13s</model> + <model usable='yes' vendor='IBM'>z990.3</model> + <model usable='yes' vendor='IBM'>z13s-base</model> + <model usable='yes' vendor='IBM'>z9EC</model> + <model usable='yes' vendor='IBM'>gen15a</model> + <model usable='yes' vendor='IBM'>z14ZR1-base</model> + <model usable='yes' vendor='IBM'>z14.2-base</model> + <model usable='yes' vendor='IBM'>z900.3-base</model> + <model usable='yes' vendor='IBM'>z13.2-base</model> + <model usable='yes' vendor='IBM'>z196.2-base</model> + <model usable='yes' vendor='IBM'>zBC12-base</model> + <model usable='yes' vendor='IBM'>z9BC.2-base</model> + <model usable='yes' vendor='IBM'>z900.2-base</model> + <model usable='yes' vendor='IBM'>z9EC.3</model> + <model usable='yes' vendor='IBM'>zEC12</model> + <model usable='yes' vendor='IBM'>z900</model> + <model usable='yes' vendor='IBM'>z114-base</model> + <model usable='yes' vendor='IBM'>zEC12-base</model> + <model usable='yes' vendor='IBM'>z10EC.2</model> + <model usable='yes' vendor='IBM'>z10EC-base</model> + <model usable='yes' vendor='IBM'>z900.3</model> + <model usable='yes' vendor='IBM'>z14ZR1</model> + <model usable='yes' vendor='IBM'>z10BC</model> + <model usable='yes' vendor='IBM'>z10BC.2-base</model> + <model usable='yes' vendor='IBM'>z990.2</model> + <model usable='yes' vendor='IBM'>z9BC.2</model> + <model usable='yes' vendor='IBM'>z990</model> + <model usable='yes' vendor='IBM'>z14</model> + <model usable='yes' vendor='IBM'>gen15b-base</model> + <model usable='yes' vendor='IBM'>z990.4</model> <model usable='yes' vendor='unknown'>max</model> - <model usable='yes' vendor='unknown'>z10EC.2-base</model> - <model usable='yes' vendor='unknown'>gen15a-base</model> - <model usable='yes' vendor='unknown'>z800</model> - <model usable='yes' vendor='unknown'>zEC12.2</model> - <model usable='yes' vendor='unknown'>z10EC</model> - <model usable='yes' vendor='unknown'>z990.2-base</model> - <model usable='yes' vendor='unknown'>z900-base</model> - <model usable='yes' vendor='unknown'>z10BC.2</model> - <model usable='yes' vendor='unknown'>z9EC-base</model> - <model usable='yes' vendor='unknown'>z9EC.3-base</model> - <model usable='yes' vendor='unknown'>z114</model> - <model usable='yes' vendor='unknown'>z890.3</model> - <model usable='yes' vendor='unknown'>z196-base</model> - <model usable='yes' vendor='unknown'>z9EC.2-base</model> - <model usable='yes' vendor='unknown'>z196.2</model> - <model usable='yes' vendor='unknown'>z14.2</model> - <model usable='yes' vendor='unknown'>z990-base</model> - <model usable='yes' vendor='unknown'>z900.2</model> - <model usable='yes' vendor='unknown'>z890-base</model> - <model usable='yes' vendor='unknown'>z10EC.3</model> - <model usable='yes' vendor='unknown'>z14-base</model> - <model usable='yes' vendor='unknown'>z990.4-base</model> - <model usable='yes' vendor='unknown'>z10EC.3-base</model> - <model usable='yes' vendor='unknown'>z10BC-base</model> - <model usable='yes' vendor='unknown'>z13-base</model> - <model usable='yes' vendor='unknown'>z990.3-base</model> - <model usable='yes' vendor='unknown'>zEC12.2-base</model> - <model usable='yes' vendor='unknown'>zBC12</model> - <model usable='yes' vendor='unknown'>z890.3-base</model> - <model usable='yes' vendor='unknown'>z990.5</model> - <model usable='yes' vendor='unknown'>gen15b</model> + <model usable='yes' vendor='IBM'>z10EC.2-base</model> + <model usable='yes' vendor='IBM'>gen15a-base</model> + <model usable='yes' vendor='IBM'>z800</model> + <model usable='yes' vendor='IBM'>zEC12.2</model> + <model usable='yes' vendor='IBM'>z10EC</model> + <model usable='yes' vendor='IBM'>z990.2-base</model> + <model usable='yes' vendor='IBM'>z900-base</model> + <model usable='yes' vendor='IBM'>z10BC.2</model> + <model usable='yes' vendor='IBM'>z9EC-base</model> + <model usable='yes' vendor='IBM'>z9EC.3-base</model> + <model usable='yes' vendor='IBM'>z114</model> + <model usable='yes' vendor='IBM'>z890.3</model> + <model usable='yes' vendor='IBM'>z196-base</model> + <model usable='yes' vendor='IBM'>z9EC.2-base</model> + <model usable='yes' vendor='IBM'>z196.2</model> + <model usable='yes' vendor='IBM'>z14.2</model> + <model usable='yes' vendor='IBM'>z990-base</model> + <model usable='yes' vendor='IBM'>z900.2</model> + <model usable='yes' vendor='IBM'>z890-base</model> + <model usable='yes' vendor='IBM'>z10EC.3</model> + <model usable='yes' vendor='IBM'>z14-base</model> + <model usable='yes' vendor='IBM'>z990.4-base</model> + <model usable='yes' vendor='IBM'>z10EC.3-base</model> + <model usable='yes' vendor='IBM'>z10BC-base</model> + <model usable='yes' vendor='IBM'>z13-base</model> + <model usable='yes' vendor='IBM'>z990.3-base</model> + <model usable='yes' vendor='IBM'>zEC12.2-base</model> + <model usable='yes' vendor='IBM'>zBC12</model> + <model usable='yes' vendor='IBM'>z890.3-base</model> + <model usable='yes' vendor='IBM'>z990.5</model> + <model usable='yes' vendor='IBM'>gen15b</model> <model usable='no' vendor='unknown'>qemu</model> </mode> </cpu> diff --git a/tests/domaincapsdata/qemu_5.2.0.s390x.xml b/tests/domaincapsdata/qemu_5.2.0.s390x.xml index 760f514d7b..31ddbfbc75 100644 --- a/tests/domaincapsdata/qemu_5.2.0.s390x.xml +++ b/tests/domaincapsdata/qemu_5.2.0.s390x.xml @@ -85,79 +85,79 @@ <feature policy='require' name='cmm'/> </mode> <mode name='custom' supported='yes'> - <model usable='yes' vendor='unknown'>z800-base</model> - <model usable='yes' vendor='unknown'>z890.2-base</model> - <model usable='yes' vendor='unknown'>z9EC.2</model> - <model usable='yes' vendor='unknown'>z13.2</model> - <model usable='yes' vendor='unknown'>z990.5-base</model> - <model usable='yes' vendor='unknown'>z9BC-base</model> - <model usable='yes' vendor='unknown'>z890.2</model> - <model usable='yes' vendor='unknown'>z890</model> - <model usable='yes' vendor='unknown'>z9BC</model> - <model usable='yes' vendor='unknown'>z13</model> - <model usable='yes' vendor='unknown'>z196</model> - <model usable='yes' vendor='unknown'>z13s</model> - <model usable='yes' vendor='unknown'>z990.3</model> - <model usable='yes' vendor='unknown'>z13s-base</model> - <model usable='yes' vendor='unknown'>z9EC</model> - <model usable='yes' vendor='unknown'>gen15a</model> - <model usable='yes' vendor='unknown'>z14ZR1-base</model> - <model usable='yes' vendor='unknown'>z14.2-base</model> - <model usable='yes' vendor='unknown'>z900.3-base</model> - <model usable='yes' vendor='unknown'>z13.2-base</model> - <model usable='yes' vendor='unknown'>z196.2-base</model> - <model usable='yes' vendor='unknown'>zBC12-base</model> - <model usable='yes' vendor='unknown'>z9BC.2-base</model> - <model usable='yes' vendor='unknown'>z900.2-base</model> - <model usable='yes' vendor='unknown'>z9EC.3</model> - <model usable='yes' vendor='unknown'>zEC12</model> - <model usable='yes' vendor='unknown'>z900</model> - <model usable='yes' vendor='unknown'>z114-base</model> - <model usable='yes' vendor='unknown'>zEC12-base</model> - <model usable='yes' vendor='unknown'>z10EC.2</model> - <model usable='yes' vendor='unknown'>z10EC-base</model> - <model usable='yes' vendor='unknown'>z900.3</model> - <model usable='yes' vendor='unknown'>z14ZR1</model> - <model usable='yes' vendor='unknown'>z10BC</model> - <model usable='yes' vendor='unknown'>z10BC.2-base</model> - <model usable='yes' vendor='unknown'>z9BC.2</model> - <model usable='yes' vendor='unknown'>z990</model> - <model usable='yes' vendor='unknown'>z990.2</model> - <model usable='yes' vendor='unknown'>z14</model> - <model usable='yes' vendor='unknown'>gen15b-base</model> - <model usable='yes' vendor='unknown'>z990.4</model> + <model usable='yes' vendor='IBM'>z800-base</model> + <model usable='yes' vendor='IBM'>z890.2-base</model> + <model usable='yes' vendor='IBM'>z9EC.2</model> + <model usable='yes' vendor='IBM'>z13.2</model> + <model usable='yes' vendor='IBM'>z990.5-base</model> + <model usable='yes' vendor='IBM'>z9BC-base</model> + <model usable='yes' vendor='IBM'>z890.2</model> + <model usable='yes' vendor='IBM'>z890</model> + <model usable='yes' vendor='IBM'>z9BC</model> + <model usable='yes' vendor='IBM'>z13</model> + <model usable='yes' vendor='IBM'>z196</model> + <model usable='yes' vendor='IBM'>z13s</model> + <model usable='yes' vendor='IBM'>z990.3</model> + <model usable='yes' vendor='IBM'>z13s-base</model> + <model usable='yes' vendor='IBM'>z9EC</model> + <model usable='yes' vendor='IBM'>gen15a</model> + <model usable='yes' vendor='IBM'>z14ZR1-base</model> + <model usable='yes' vendor='IBM'>z14.2-base</model> + <model usable='yes' vendor='IBM'>z900.3-base</model> + <model usable='yes' vendor='IBM'>z13.2-base</model> + <model usable='yes' vendor='IBM'>z196.2-base</model> + <model usable='yes' vendor='IBM'>zBC12-base</model> + <model usable='yes' vendor='IBM'>z9BC.2-base</model> + <model usable='yes' vendor='IBM'>z900.2-base</model> + <model usable='yes' vendor='IBM'>z9EC.3</model> + <model usable='yes' vendor='IBM'>zEC12</model> + <model usable='yes' vendor='IBM'>z900</model> + <model usable='yes' vendor='IBM'>z114-base</model> + <model usable='yes' vendor='IBM'>zEC12-base</model> + <model usable='yes' vendor='IBM'>z10EC.2</model> + <model usable='yes' vendor='IBM'>z10EC-base</model> + <model usable='yes' vendor='IBM'>z900.3</model> + <model usable='yes' vendor='IBM'>z14ZR1</model> + <model usable='yes' vendor='IBM'>z10BC</model> + <model usable='yes' vendor='IBM'>z10BC.2-base</model> + <model usable='yes' vendor='IBM'>z9BC.2</model> + <model usable='yes' vendor='IBM'>z990</model> + <model usable='yes' vendor='IBM'>z990.2</model> + <model usable='yes' vendor='IBM'>z14</model> + <model usable='yes' vendor='IBM'>gen15b-base</model> + <model usable='yes' vendor='IBM'>z990.4</model> <model usable='yes' vendor='unknown'>max</model> - <model usable='yes' vendor='unknown'>z990.2-base</model> - <model usable='yes' vendor='unknown'>z10EC.2-base</model> - <model usable='yes' vendor='unknown'>gen15a-base</model> - <model usable='yes' vendor='unknown'>z800</model> - <model usable='yes' vendor='unknown'>z10EC</model> - <model usable='yes' vendor='unknown'>zEC12.2</model> - <model usable='yes' vendor='unknown'>z900-base</model> - <model usable='yes' vendor='unknown'>z10BC.2</model> - <model usable='yes' vendor='unknown'>z9EC-base</model> - <model usable='yes' vendor='unknown'>z9EC.3-base</model> - <model usable='yes' vendor='unknown'>z114</model> - <model usable='yes' vendor='unknown'>z890.3</model> - <model usable='yes' vendor='unknown'>z196-base</model> - <model usable='yes' vendor='unknown'>z9EC.2-base</model> - <model usable='yes' vendor='unknown'>z196.2</model> - <model usable='yes' vendor='unknown'>z14.2</model> - <model usable='yes' vendor='unknown'>z990-base</model> - <model usable='yes' vendor='unknown'>z900.2</model> - <model usable='yes' vendor='unknown'>z10EC.3</model> - <model usable='yes' vendor='unknown'>z890-base</model> - <model usable='yes' vendor='unknown'>z14-base</model> - <model usable='yes' vendor='unknown'>z990.4-base</model> - <model usable='yes' vendor='unknown'>z10EC.3-base</model> - <model usable='yes' vendor='unknown'>z10BC-base</model> - <model usable='yes' vendor='unknown'>z13-base</model> - <model usable='yes' vendor='unknown'>z990.3-base</model> - <model usable='yes' vendor='unknown'>zEC12.2-base</model> - <model usable='yes' vendor='unknown'>zBC12</model> - <model usable='yes' vendor='unknown'>z890.3-base</model> - <model usable='yes' vendor='unknown'>z990.5</model> - <model usable='yes' vendor='unknown'>gen15b</model> + <model usable='yes' vendor='IBM'>z990.2-base</model> + <model usable='yes' vendor='IBM'>z10EC.2-base</model> + <model usable='yes' vendor='IBM'>gen15a-base</model> + <model usable='yes' vendor='IBM'>z800</model> + <model usable='yes' vendor='IBM'>z10EC</model> + <model usable='yes' vendor='IBM'>zEC12.2</model> + <model usable='yes' vendor='IBM'>z900-base</model> + <model usable='yes' vendor='IBM'>z10BC.2</model> + <model usable='yes' vendor='IBM'>z9EC-base</model> + <model usable='yes' vendor='IBM'>z9EC.3-base</model> + <model usable='yes' vendor='IBM'>z114</model> + <model usable='yes' vendor='IBM'>z890.3</model> + <model usable='yes' vendor='IBM'>z196-base</model> + <model usable='yes' vendor='IBM'>z9EC.2-base</model> + <model usable='yes' vendor='IBM'>z196.2</model> + <model usable='yes' vendor='IBM'>z14.2</model> + <model usable='yes' vendor='IBM'>z990-base</model> + <model usable='yes' vendor='IBM'>z900.2</model> + <model usable='yes' vendor='IBM'>z10EC.3</model> + <model usable='yes' vendor='IBM'>z890-base</model> + <model usable='yes' vendor='IBM'>z14-base</model> + <model usable='yes' vendor='IBM'>z990.4-base</model> + <model usable='yes' vendor='IBM'>z10EC.3-base</model> + <model usable='yes' vendor='IBM'>z10BC-base</model> + <model usable='yes' vendor='IBM'>z13-base</model> + <model usable='yes' vendor='IBM'>z990.3-base</model> + <model usable='yes' vendor='IBM'>zEC12.2-base</model> + <model usable='yes' vendor='IBM'>zBC12</model> + <model usable='yes' vendor='IBM'>z890.3-base</model> + <model usable='yes' vendor='IBM'>z990.5</model> + <model usable='yes' vendor='IBM'>gen15b</model> <model usable='yes' vendor='unknown'>qemu</model> </mode> </cpu> diff --git a/tests/domaincapsdata/qemu_6.0.0.s390x.xml b/tests/domaincapsdata/qemu_6.0.0.s390x.xml index b1968668db..1cb19e051b 100644 --- a/tests/domaincapsdata/qemu_6.0.0.s390x.xml +++ b/tests/domaincapsdata/qemu_6.0.0.s390x.xml @@ -86,79 +86,79 @@ <feature policy='require' name='cmm'/> </mode> <mode name='custom' supported='yes'> - <model usable='yes' vendor='unknown'>z800-base</model> - <model usable='yes' vendor='unknown'>z890.2-base</model> - <model usable='yes' vendor='unknown'>z9EC.2</model> - <model usable='yes' vendor='unknown'>z13.2</model> - <model usable='yes' vendor='unknown'>z990.5-base</model> - <model usable='yes' vendor='unknown'>z9BC-base</model> - <model usable='yes' vendor='unknown'>z890.2</model> - <model usable='yes' vendor='unknown'>z890</model> - <model usable='yes' vendor='unknown'>z9BC</model> - <model usable='yes' vendor='unknown'>z13</model> - <model usable='yes' vendor='unknown'>z196</model> - <model usable='yes' vendor='unknown'>z13s</model> - <model usable='yes' vendor='unknown'>z990.3</model> - <model usable='yes' vendor='unknown'>z13s-base</model> - <model usable='yes' vendor='unknown'>z9EC</model> - <model usable='yes' vendor='unknown'>gen15a</model> - <model usable='yes' vendor='unknown'>z14ZR1-base</model> - <model usable='yes' vendor='unknown'>z14.2-base</model> - <model usable='yes' vendor='unknown'>z900.3-base</model> - <model usable='yes' vendor='unknown'>z13.2-base</model> - <model usable='yes' vendor='unknown'>z196.2-base</model> - <model usable='yes' vendor='unknown'>zBC12-base</model> - <model usable='yes' vendor='unknown'>z9BC.2-base</model> - <model usable='yes' vendor='unknown'>z900.2-base</model> - <model usable='yes' vendor='unknown'>z9EC.3</model> - <model usable='yes' vendor='unknown'>zEC12</model> - <model usable='yes' vendor='unknown'>z900</model> - <model usable='yes' vendor='unknown'>z114-base</model> - <model usable='yes' vendor='unknown'>zEC12-base</model> - <model usable='yes' vendor='unknown'>z10EC.2</model> - <model usable='yes' vendor='unknown'>z10EC-base</model> - <model usable='yes' vendor='unknown'>z900.3</model> - <model usable='yes' vendor='unknown'>z14ZR1</model> - <model usable='yes' vendor='unknown'>z10BC</model> - <model usable='yes' vendor='unknown'>z10BC.2-base</model> - <model usable='yes' vendor='unknown'>z9BC.2</model> - <model usable='yes' vendor='unknown'>z990</model> - <model usable='yes' vendor='unknown'>z990.2</model> - <model usable='yes' vendor='unknown'>z14</model> - <model usable='yes' vendor='unknown'>gen15b-base</model> - <model usable='yes' vendor='unknown'>z990.4</model> + <model usable='yes' vendor='IBM'>z800-base</model> + <model usable='yes' vendor='IBM'>z890.2-base</model> + <model usable='yes' vendor='IBM'>z9EC.2</model> + <model usable='yes' vendor='IBM'>z13.2</model> + <model usable='yes' vendor='IBM'>z990.5-base</model> + <model usable='yes' vendor='IBM'>z9BC-base</model> + <model usable='yes' vendor='IBM'>z890.2</model> + <model usable='yes' vendor='IBM'>z890</model> + <model usable='yes' vendor='IBM'>z9BC</model> + <model usable='yes' vendor='IBM'>z13</model> + <model usable='yes' vendor='IBM'>z196</model> + <model usable='yes' vendor='IBM'>z13s</model> + <model usable='yes' vendor='IBM'>z990.3</model> + <model usable='yes' vendor='IBM'>z13s-base</model> + <model usable='yes' vendor='IBM'>z9EC</model> + <model usable='yes' vendor='IBM'>gen15a</model> + <model usable='yes' vendor='IBM'>z14ZR1-base</model> + <model usable='yes' vendor='IBM'>z14.2-base</model> + <model usable='yes' vendor='IBM'>z900.3-base</model> + <model usable='yes' vendor='IBM'>z13.2-base</model> + <model usable='yes' vendor='IBM'>z196.2-base</model> + <model usable='yes' vendor='IBM'>zBC12-base</model> + <model usable='yes' vendor='IBM'>z9BC.2-base</model> + <model usable='yes' vendor='IBM'>z900.2-base</model> + <model usable='yes' vendor='IBM'>z9EC.3</model> + <model usable='yes' vendor='IBM'>zEC12</model> + <model usable='yes' vendor='IBM'>z900</model> + <model usable='yes' vendor='IBM'>z114-base</model> + <model usable='yes' vendor='IBM'>zEC12-base</model> + <model usable='yes' vendor='IBM'>z10EC.2</model> + <model usable='yes' vendor='IBM'>z10EC-base</model> + <model usable='yes' vendor='IBM'>z900.3</model> + <model usable='yes' vendor='IBM'>z14ZR1</model> + <model usable='yes' vendor='IBM'>z10BC</model> + <model usable='yes' vendor='IBM'>z10BC.2-base</model> + <model usable='yes' vendor='IBM'>z9BC.2</model> + <model usable='yes' vendor='IBM'>z990</model> + <model usable='yes' vendor='IBM'>z990.2</model> + <model usable='yes' vendor='IBM'>z14</model> + <model usable='yes' vendor='IBM'>gen15b-base</model> + <model usable='yes' vendor='IBM'>z990.4</model> <model usable='yes' vendor='unknown'>max</model> - <model usable='yes' vendor='unknown'>z10EC.2-base</model> - <model usable='yes' vendor='unknown'>gen15a-base</model> - <model usable='yes' vendor='unknown'>z800</model> - <model usable='yes' vendor='unknown'>z10EC</model> - <model usable='yes' vendor='unknown'>zEC12.2</model> - <model usable='yes' vendor='unknown'>z990.2-base</model> - <model usable='yes' vendor='unknown'>z900-base</model> - <model usable='yes' vendor='unknown'>z10BC.2</model> - <model usable='yes' vendor='unknown'>z9EC-base</model> - <model usable='yes' vendor='unknown'>z9EC.3-base</model> - <model usable='yes' vendor='unknown'>z114</model> - <model usable='yes' vendor='unknown'>z890.3</model> - <model usable='yes' vendor='unknown'>z196-base</model> - <model usable='yes' vendor='unknown'>z9EC.2-base</model> - <model usable='yes' vendor='unknown'>z196.2</model> - <model usable='yes' vendor='unknown'>z14.2</model> - <model usable='yes' vendor='unknown'>z990-base</model> - <model usable='yes' vendor='unknown'>z900.2</model> - <model usable='yes' vendor='unknown'>z890-base</model> - <model usable='yes' vendor='unknown'>z10EC.3</model> - <model usable='yes' vendor='unknown'>z14-base</model> - <model usable='yes' vendor='unknown'>z990.4-base</model> - <model usable='yes' vendor='unknown'>z10EC.3-base</model> - <model usable='yes' vendor='unknown'>z10BC-base</model> - <model usable='yes' vendor='unknown'>z13-base</model> - <model usable='yes' vendor='unknown'>z990.3-base</model> - <model usable='yes' vendor='unknown'>zEC12.2-base</model> - <model usable='yes' vendor='unknown'>zBC12</model> - <model usable='yes' vendor='unknown'>z890.3-base</model> - <model usable='yes' vendor='unknown'>z990.5</model> - <model usable='yes' vendor='unknown'>gen15b</model> + <model usable='yes' vendor='IBM'>z10EC.2-base</model> + <model usable='yes' vendor='IBM'>gen15a-base</model> + <model usable='yes' vendor='IBM'>z800</model> + <model usable='yes' vendor='IBM'>z10EC</model> + <model usable='yes' vendor='IBM'>zEC12.2</model> + <model usable='yes' vendor='IBM'>z990.2-base</model> + <model usable='yes' vendor='IBM'>z900-base</model> + <model usable='yes' vendor='IBM'>z10BC.2</model> + <model usable='yes' vendor='IBM'>z9EC-base</model> + <model usable='yes' vendor='IBM'>z9EC.3-base</model> + <model usable='yes' vendor='IBM'>z114</model> + <model usable='yes' vendor='IBM'>z890.3</model> + <model usable='yes' vendor='IBM'>z196-base</model> + <model usable='yes' vendor='IBM'>z9EC.2-base</model> + <model usable='yes' vendor='IBM'>z196.2</model> + <model usable='yes' vendor='IBM'>z14.2</model> + <model usable='yes' vendor='IBM'>z990-base</model> + <model usable='yes' vendor='IBM'>z900.2</model> + <model usable='yes' vendor='IBM'>z890-base</model> + <model usable='yes' vendor='IBM'>z10EC.3</model> + <model usable='yes' vendor='IBM'>z14-base</model> + <model usable='yes' vendor='IBM'>z990.4-base</model> + <model usable='yes' vendor='IBM'>z10EC.3-base</model> + <model usable='yes' vendor='IBM'>z10BC-base</model> + <model usable='yes' vendor='IBM'>z13-base</model> + <model usable='yes' vendor='IBM'>z990.3-base</model> + <model usable='yes' vendor='IBM'>zEC12.2-base</model> + <model usable='yes' vendor='IBM'>zBC12</model> + <model usable='yes' vendor='IBM'>z890.3-base</model> + <model usable='yes' vendor='IBM'>z990.5</model> + <model usable='yes' vendor='IBM'>gen15b</model> <model usable='yes' vendor='unknown'>qemu</model> </mode> </cpu> -- 2.31.1

3 3

[PATCH] cpu_s390: Implement getVendorForModel for IBM Z
by Thomas Huth 25 Nov '22

25 Nov '22

When running "virsh domcapabilities" on a s390x host, all the CPU models show up with vendor='unknown' - which sounds kind of weird since the vendor of these mainframe CPUs is well known: IBM. All CPUs starting with either "z" or "gen" match a real mainframe CPU by IBM, so let's return the string "IBM" for those now. The only remaining ones are now the artifical "qemu" and "max" models from QEMU itself, so it should be OK to get an "unknown" vendor for those two. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- src/cpu/cpu_s390.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/cpu/cpu_s390.c b/src/cpu/cpu_s390.c index d908a83928..7416ec6dc5 100644 --- a/src/cpu/cpu_s390.c +++ b/src/cpu/cpu_s390.c @@ -109,6 +109,16 @@ virCPUs390ValidateFeatures(virCPUDef *cpu) } +static const char * +virCPUs390GetVendorForModel(const char *modelName) +{ + if (modelName[0] == 'z' || STREQLEN(modelName, "gen", 3)) + return "IBM"; + + return NULL; +} + + struct cpuArchDriver cpuDriverS390 = { .name = "s390", .arch = archs, @@ -119,4 +129,5 @@ struct cpuArchDriver cpuDriverS390 = { .baseline = NULL, .update = virCPUs390Update, .validateFeatures = virCPUs390ValidateFeatures, + .getVendorForModel = virCPUs390GetVendorForModel, }; -- 2.31.1

2 2

[PATCH 0/2] virsh: Two simple long version output fixes
by Michal Privoznik 24 Nov '22

24 Nov '22

*** BLURB HERE *** Michal Prívozník (2): virsh: Format -V output properly virsh: Report iSCSI-direct backend in long version tools/virsh.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) -- 2.37.4

2 3

Add option to skip cpu feature and model verification in libvirt and rely on qemu 'enforce' option
by manish.mishra 24 Nov '22

24 Nov '22

Hi Everyone, We had a requirement to skip all CPU feature validations from libvirt and totally rely on Qemu for following reasons. * As libvirt always lies behind in term of cpu feature management compare to qemu, so we may not be able to use all of the latest support provided by qemu till it is updated in libvirt too. For example like if new cpu features are added in qemu but not yet updated in libvirt. * Libvirt does not support cpu model versioning as Qemu. * Libvirt checks if a features is supported or not based on cpuid, a feature supported by host may not be supported by qemu or there can be some features which are emulated by Qemu so libvirt level checking does not make sense in those cases. * Qemu already provide an option 'enforce' to validate if features with which vm is started is exactly same as one provided and nothing is silently dropped. Basically we want another check option like 'qemu-enforce' which will skip all feature and cpu model verfications in libvirt and pass 'enforce' option to qemu. It will work similar to check 'none' i mean no check to verify if provide features are supported by host, also on top of that skip things like virCPUValidateFeatures where ever required. I understand this is specific to just Qemu and libvirt has to take care for many other emulator, so wanted to check if something like that makes sense as it will be very useful for Qemu atleast. If so we can send a patch. Thanks Manish Mishra

4 31

TX/RX statistics need to be swapped
by Oleg Vasilev 24 Nov '22

24 Nov '22

Hi, virDomainNetTypeSharesHostView[1] contains the logic where for some interface types it swaps TX and RX values, because what TX from the inside is RX on the outside and vice versa. We observe a configuration where <interface type='ethernet' /> shows swapped values in statistics, because, apparently, the values are swapped once inside the kernel when going from the inside to the outside, but not swapped second time because of the mentioned logic. Is this a bug? Why in the virDomainNetTypeSharesHostView[1] ethernet is marked as 'non-swapped'? Maybe we need some more fine-grained way of determining whether to swap value a second time? Thanks, Oleg [1]: https://gitlab.com/libvirt/libvirt/-/blob/master/src/conf/domain_conf.c#L29…

2 2

[libvirt PATCH] spec: libvirt-daemon: Add optional dependency on *-client
by Jiri Denemark 24 Nov '22

24 Nov '22

The libvirt-daemon subpackage contains libvirt-guests.sh script (used by libvirt-guests service), which requires virsh to actually work. But since dynamic libraries were separated from libvirt-client to libvirt-libs more than 6 years ago, libvirt-daemon no longer requires virsh to be installed. So unless libvirt-client is explicitly installed (either manually or by installing the libvirt meta package), libvirt-guests will not work. Just adding libvirt-client as a dependency of libvirt-daemon would go against the original idea behind splitting libvirt-client: users may not want to install or use any client binaries on the host where the daemon runs (either they just use various language bindings or access the daemon remotely). To solve this we could possibly turn libvirt-daemon into an empty package and separate the daemons and libvirt-guests into subpackages to make sure we support both use cases, but marking libvirt-client as Recommended for libvirt-daemon does the same job in a much simpler way. https://bugzilla.redhat.com/show_bug.cgi?id=2136591 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 0bbcdb8956..450f50f5b5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -441,6 +441,12 @@ Summary: Server side daemon and supporting files for libvirt library # The client side, i.e. shared libs are in a subpackage Requires: %{name}-libs = %{version}-%{release} +# The libvirt-guests.sh script requires virsh from libvirt-client subpackage, +# but not every deployment wants to use libvirt-guests service. Using +# Recommends here will install libvirt-client by default (if available), but +# RPM won't complain if the package is unavailable, masked, or removed later. +Recommends: %{name}-client = %{version}-%{release} + # netcat is needed on the server side so that clients that have # libvirt < 6.9.0 can connect, but newer versions will prefer # virt-ssh-helper. Making this a Recommends means that it gets -- 2.38.1

4 6

questions regarding modular daemons
by Jim Fehlig 24 Nov '22

24 Nov '22

Hi All, I've procrastinated long enough and finally decided to switch to modular daemons in openSUSE Factory libvirt package. For the most part, the Factory spec file mimics the upstream one. I enabled with_modular_daemons and would like to confirm the results of my testing. When upgrading an existing installation running the monolithic daemon, the monolithic daemon is still enabled after the upgrade. I suppose this behavior is expected, and fine IMO. However, when installing the "modularized" packages on a system with no prior installation, the monolithic daemon is still installed and potentially enabled in posttrans. Having both the monolithic and modular daemons installed, along with all associated systemd socket and service files, is a bit confusing to users IMO. E.g. should one enable libvirtd sockets, virtqemud sockets, both? Is the intention, over time, to remove the monolithic daemon? Perhaps we could start by isolating the monolithic daemon in the libvirt-daemon subpackage and moving the other daemons (virtproxyd, virtlogd, virtlockd, etc) to a new subpackage? The modular daemons could then drop the libvirt-daemon dependency, allowing installation without the monolithic daemon. TIA for your comments. Regards, Jim

2 2

[PATCH] rpc: Mark close callback (un-)register as high priority
by Michal Privoznik 23 Nov '22

23 Nov '22

Our RPC calls can be divided into two groups: regular and high priority. The latter can be then processed by so called high priority worker threads. This is our way of defeating a 'deadlock' and allowing some RPCs to be processed even when all (regular) worker threads are stuck. For instance: if all regular worker threads get stuck when talking to QEMU on monitor, the virDomainDestroy() can be processed by a high priority worker thread(s) and thus unstuck those threads. Now, this is all fine, except if users want to use virsh non interactively: virsh destroy $dom This does a bit more - it needs to open a connection. And that consists of multiple RPC calls: AUTH_LIST, CONNECT_SUPPORTS_FEATURE, CONNECT_OPEN, and finally CONNECT_REGISTER_CLOSE_CALLBACK. All of them are marked as high priority except the last one. Therefore, virsh just sits there with a partially open connection. There's one requirement for high priority calls though: they can not get stuck. Hopefully, the reason is obvious by now. And looking into the server side implementation the CONNECT_REGISTER_CLOSE_CALLBACK processing can't ever get stuck. The only driver that implements the callback for public API is Parallels (vz). And that can't block really. And for virConnectUnregisterCloseCallback() it's the same story. Therefore, both can be marked as high priority. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2143840 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/remote/remote_protocol.x | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index 79ffc63f03..7dfb4548f4 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -6416,12 +6416,14 @@ enum remote_procedure { /** * @generate: none + * @priority: high * @acl: connect:getattr */ REMOTE_PROC_CONNECT_REGISTER_CLOSE_CALLBACK = 360, /** * @generate: none + * @priority: high * @acl: connect:getattr */ REMOTE_PROC_CONNECT_UNREGISTER_CLOSE_CALLBACK = 361, -- 2.37.4

2 1

[libvirt PATCH v2 1/1] qemu: fix vcpu clearing when multiple vcpu hotunplugs timeout
by Shaleen Bathla 22 Nov '22

22 Nov '22

Problem: libvirt has a 5 second timeout (generally) for hotplug/unplug operations which can time out due to heavy load in guest. vcpu hotunplug occurs one vcpu at a time. But, if we perform hotplug-unplug repeatedly, Case 1: qemu sends multiple timedout vcpu unplug notification before libvirt processed first one. Case 2: when attempting a hotplug, qemu finishes unplug of another cpu libvirt waits for an async event notification from qemu regarding successful vcpu delete. qemu deletes its vcpu, vcpuinfo and sends notification to libvirt. libvirt handles vcpu delete notification, and updates vcpuinfo received from qemu in qemuDomainRefreshVcpuInfo(). qemu's vcpuinfo during refresh will not contain other deleted, sent vcpu qemu's vcpuinfo will overwrite libvirt's vcpuinfo of the other pending timedout vcpu(s) which qemu has deleted and notified libvirt. The overwrite resets other timedout vcpu's alias to NULL and tid to 0. The error is then seen when validating tid of vcpus. Example error log: "internal error: qemu didn't report thread id for vcpu 'XX'" Solution: Clear vcpu alias of only the vcpu that hotplug API calls. Other vcpu-alias won't get reset when vcpuinfo refresh occurs. Validation is also done for corresponding vcpus only, not all. Co-authored-by: Partha Satapathy <partha.satapathy(a)oracle.com> Signed-off-by: Shaleen Bathla <shaleen.bathla(a)oracle.com> --- src/qemu/qemu_domain.c | 6 ++++-- src/qemu/qemu_hotplug.c | 39 +++++++++++++++++++++++++++++++-------- 2 files changed, 35 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 3435da5bdc4c..6ae842d0e32f 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9773,8 +9773,10 @@ qemuDomainRefreshVcpuInfo(virDomainObj *vm, vcpupriv->vcpus = info[i].vcpus; VIR_FREE(vcpupriv->type); vcpupriv->type = g_steal_pointer(&info[i].type); - VIR_FREE(vcpupriv->alias); - vcpupriv->alias = g_steal_pointer(&info[i].alias); + if (info[i].alias) { + VIR_FREE(vcpupriv->alias); + vcpupriv->alias = g_steal_pointer(&info[i].alias); + } virJSONValueFree(vcpupriv->props); vcpupriv->props = g_steal_pointer(&info[i].props); vcpupriv->enable_id = info[i].id; diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index da92ced2f444..f11b90a220ac 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -6090,6 +6090,8 @@ qemuDomainRemoveVcpu(virDomainObj *vm, unsigned int nvcpus = vcpupriv->vcpus; virErrorPtr save_error = NULL; size_t i; + bool hasVcpuPids = qemuDomainHasVcpuPids(vm); + bool rollback = false; if (qemuDomainRefreshVcpuInfo(vm, VIR_ASYNC_JOB_NONE, false) < 0) return -1; @@ -6097,14 +6099,26 @@ qemuDomainRemoveVcpu(virDomainObj *vm, /* validation requires us to set the expected state prior to calling it */ for (i = vcpu; i < vcpu + nvcpus; i++) { vcpuinfo = virDomainDefGetVcpu(vm->def, i); + vcpupriv = QEMU_DOMAIN_VCPU_PRIVATE(vcpuinfo); + vcpuinfo->online = false; + VIR_FREE(vcpupriv->alias); /* clear vcpu alias of only this vcpu */ + + if (vcpupriv->tid != 0) { + if (hasVcpuPids) + virReportError(VIR_ERR_INTERNAL_ERROR, + _("qemu reported thread id for inactive vcpu '%zu'"), i); + + rollback = true; + break; + } } - if (qemuDomainValidateVcpuInfo(vm) < 0) { + if (rollback) { /* rollback vcpu count if the setting has failed */ virDomainAuditVcpu(vm, oldvcpus, oldvcpus - nvcpus, "update", false); - for (i = vcpu; i < vcpu + nvcpus; i++) { + for (; i >= vcpu; i--) { vcpuinfo = virDomainDefGetVcpu(vm->def, i); vcpuinfo->online = true; } @@ -6141,6 +6155,9 @@ qemuDomainRemoveVcpuAlias(virDomainObj *vm, return; } } + + VIR_DEBUG("%s not found in vcpulist of domain %s ", + alias, vm->def->name); } @@ -6209,6 +6226,7 @@ qemuDomainHotplugAddVcpu(virQEMUDriver *driver, int rc; int oldvcpus = virDomainDefGetVcpus(vm->def); size_t i; + bool hasVcpuPids = qemuDomainHasVcpuPids(vm); if (!qemuDomainSupportsNewVcpuHotplug(vm)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", @@ -6245,14 +6263,19 @@ qemuDomainHotplugAddVcpu(virQEMUDriver *driver, vcpuinfo->online = true; - if (vcpupriv->tid > 0 && - qemuProcessSetupVcpu(vm, i, true) < 0) - return -1; + if (vcpupriv->tid > 0) { + if (qemuProcessSetupVcpu(vm, i, true) < 0) { + return -1; + } + } else { + if (hasVcpuPids) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("qemu didn't report thread id for vcpu '%zu'"), i); + return -1; + } + } } - if (qemuDomainValidateVcpuInfo(vm) < 0) - return -1; - qemuDomainVcpuPersistOrder(vm->def); if (virDomainObjSave(vm, driver->xmlopt, cfg->stateDir) < 0) -- 2.31.1 V1 Patch : https://listman.redhat.com/archives/libvir-list/2022-November/235470.html V1 Patch Review comments : https://listman.redhat.com/archives/libvir-list/2022-November/235534.html Changes in V2 since V1: - Patch addresses review comments from Peter Krempa. - Validation is done for per cpu hotplug entity instead of all

2 2

[PATCH 0/5] Avoid 'unsigned long flags'
by Peter Krempa 22 Nov '22

22 Nov '22

Peter Krempa (5): internal: Refuse values exceeding range of 'unsigned int' in virCheckFlags virsh: vol-create-as: Use 'unsigned int' for flags qemu: processGuestPanicEvent: Use 'unsigned int' for flags qemu: migration: Use 'unsigned int' for flags libxl: migration: Use 'unsigned int' for flags src/internal.h | 22 +++++++-- src/libxl/libxl_migration.c | 4 +- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_migration.c | 82 ++++++++++++++++---------------- src/qemu/qemu_migration.h | 10 ++-- src/qemu/qemu_migration_params.c | 6 +-- src/qemu/qemu_migration_params.h | 4 +- tools/virsh-volume.c | 2 +- 8 files changed, 73 insertions(+), 59 deletions(-) -- 2.37.3

2 6

[PATCH] qemu_tpm: Check for qemuTPMSetupEncryption() errors
by Michal Privoznik 22 Nov '22

22 Nov '22

Inside of qemuTPMEmulatorBuildCommand() there are two calls to qemuTPMSetupEncryption() which simply ignore returned error. This is suboptimal because then we rely on swtpm binary reporting a generic error (something among invalid arguments) while an error reported by qemuTPMSetupEncryption() is more specific. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_tpm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_tpm.c b/src/qemu/qemu_tpm.c index 15ee7db757..502a77b5b3 100644 --- a/src/qemu/qemu_tpm.c +++ b/src/qemu/qemu_tpm.c @@ -635,7 +635,12 @@ qemuTPMEmulatorBuildCommand(virDomainTPMDef *tpm, } pwdfile_fd = qemuTPMSetupEncryption(tpm->data.emulator.secretuuid, cmd); + if (pwdfile_fd < 0) + goto error; + migpwdfile_fd = qemuTPMSetupEncryption(tpm->data.emulator.secretuuid, cmd); + if (migpwdfile_fd < 0) + goto error; virCommandAddArg(cmd, "--key"); virCommandAddArgFormat(cmd, "pwdfd=%d,mode=aes-256-cbc", pwdfile_fd); -- 2.37.4

2 1

[PATCH] apparmor: allow getattr on usb devices
by christian.ehrhardt＠canonical.com 22 Nov '22

22 Nov '22

From: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> For the handling of usb we already allow plenty of read access, but so far /sys/bus/usb/devices only needed read access to the directory to enumerate the symlinks in there that point to the actual entries via relative links to ../../../devices/. But in more recent systemd with updated libraries a program might do getattr calls on those symlinks. And while symlinks in apparmor usually do not matter, as it is the effective target of an access that has to be allowed, here the getattr calls are on the links themselves. On USB hostdev usage that causes a set of denials like: apparmor="DENIED" operation="getattr" class="file" name="/sys/bus/usb/devices/usb1" comm="qemu-system-x86" requested_mask="r" denied_mask="r" ... It is safe to read the links, therefore add a rule to allow it to the block of rules that covers the usb related access. Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/apparmor/libvirt-qemu | 1 + 1 file changed, 1 insertion(+) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index 02ee273e7e..d0289b8943 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -42,6 +42,7 @@ # For hostdev access. The actual devices will be added dynamically /sys/bus/usb/devices/ r, + /sys/bus/usb/devices/* r, /sys/devices/**/usb[0-9]*/** r, # libusb needs udev data about usb devices (~equal to content of lsusb -v) /run/udev/data/+usb* r, -- 2.38.1

3 4

[PATCH v2] coding-style: Use the same style in the 'struct option'
by Jiang Jiacheng 22 Nov '22

22 Nov '22

Use same style in the 'struct option' as: struct option opt[] = { { a, b }, { a, b }, ... { a, b }, }; diff to v1: * use the same style in all the 'struct option' Signed-off-by: Jiang Jiacheng <jiangjiacheng(a)huawei.com> --- examples/c/domain/domtop.c | 10 +++++----- examples/c/domain/suspend.c | 10 +++++----- src/locking/lock_daemon.c | 12 ++++++------ src/logging/log_daemon.c | 12 ++++++------ src/remote/remote_daemon.c | 14 +++++++------- src/security/virt-aa-helper.c | 22 +++++++++++----------- tools/virsh.c | 24 ++++++++++++------------ tools/virt-admin.c | 14 +++++++------- tools/virt-host-validate.c | 8 ++++---- tools/virt-login-shell-helper.c | 6 +++--- tools/virt-pki-query-dn.c | 6 +++--- 11 files changed, 69 insertions(+), 69 deletions(-) diff --git a/examples/c/domain/domtop.c b/examples/c/domain/domtop.c index 5228445b7c..dd35ec8661 100644 --- a/examples/c/domain/domtop.c +++ b/examples/c/domain/domtop.c @@ -86,11 +86,11 @@ parse_argv(int argc, char *argv[], unsigned long val; char *p; struct option opt[] = { - {"debug", no_argument, NULL, 'd'}, - {"help", no_argument, NULL, 'h'}, - {"connect", required_argument, NULL, 'c'}, - {"delay", required_argument, NULL, 'D'}, - {NULL, 0, NULL, 0} + { "debug", no_argument, NULL, 'd' }, + { "help", no_argument, NULL, 'h' }, + { "connect", required_argument, NULL, 'c' }, + { "delay", required_argument, NULL, 'D' }, + { NULL, 0, NULL, 0 }, }; while ((arg = getopt_long(argc, argv, "+:dhc:D:", opt, NULL)) != -1) { diff --git a/examples/c/domain/suspend.c b/examples/c/domain/suspend.c index 3ff24f6861..6e0bbd5597 100644 --- a/examples/c/domain/suspend.c +++ b/examples/c/domain/suspend.c @@ -76,11 +76,11 @@ parse_argv(int argc, char *argv[], unsigned long val; char *p; struct option opt[] = { - {"debug", no_argument, NULL, 'd'}, - {"help", no_argument, NULL, 'h'}, - {"connect", required_argument, NULL, 'c'}, - {"seconds", required_argument, NULL, 's'}, - {NULL, 0, NULL, 0} + { "debug", no_argument, NULL, 'd' }, + { "help", no_argument, NULL, 'h' }, + { "connect", required_argument, NULL, 'c' }, + { "seconds", required_argument, NULL, 's' }, + { NULL, 0, NULL, 0 }, }; while ((arg = getopt_long(argc, argv, "+:dhc:s:", opt, NULL)) != -1) { diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index c997d327c4..5eed6b7c26 100644 --- a/src/locking/lock_daemon.c +++ b/src/locking/lock_daemon.c @@ -809,14 +809,14 @@ int main(int argc, char **argv) { int rv; struct option opts[] = { - { "verbose", no_argument, &verbose, 'v'}, - { "daemon", no_argument, &godaemon, 'd'}, - { "config", required_argument, NULL, 'f'}, - { "timeout", required_argument, NULL, 't'}, - { "pid-file", required_argument, NULL, 'p'}, + { "verbose", no_argument, &verbose, 'v' }, + { "daemon", no_argument, &godaemon, 'd' }, + { "config", required_argument, NULL, 'f' }, + { "timeout", required_argument, NULL, 't' }, + { "pid-file", required_argument, NULL, 'p' }, { "version", no_argument, NULL, 'V' }, { "help", no_argument, NULL, 'h' }, - {0, 0, 0, 0} + { 0, 0, 0, 0 }, }; privileged = geteuid() == 0; diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index 00fc4148fd..9b70ffad2f 100644 --- a/src/logging/log_daemon.c +++ b/src/logging/log_daemon.c @@ -613,14 +613,14 @@ int main(int argc, char **argv) { int rv; struct option opts[] = { - { "verbose", no_argument, &verbose, 'v'}, - { "daemon", no_argument, &godaemon, 'd'}, - { "config", required_argument, NULL, 'f'}, - { "timeout", required_argument, NULL, 't'}, - { "pid-file", required_argument, NULL, 'p'}, + { "verbose", no_argument, &verbose, 'v' }, + { "daemon", no_argument, &godaemon, 'd' }, + { "config", required_argument, NULL, 'f' }, + { "timeout", required_argument, NULL, 't' }, + { "pid-file", required_argument, NULL, 'p' }, { "version", no_argument, NULL, 'V' }, { "help", no_argument, NULL, 'h' }, - {0, 0, 0, 0} + { 0, 0, 0, 0 }, }; privileged = geteuid() == 0; diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c index f369d09d35..dd9344168b 100644 --- a/src/remote/remote_daemon.c +++ b/src/remote/remote_daemon.c @@ -807,17 +807,17 @@ int main(int argc, char **argv) { mode_t old_umask; struct option opts[] = { - { "verbose", no_argument, &verbose, 'v'}, - { "daemon", no_argument, &godaemon, 'd'}, + { "verbose", no_argument, &verbose, 'v' }, + { "daemon", no_argument, &godaemon, 'd' }, #if defined(WITH_IP) && defined(LIBVIRTD) - { "listen", no_argument, &ipsock, 'l'}, + { "listen", no_argument, &ipsock, 'l' }, #endif /* !(WITH_IP && LIBVIRTD) */ - { "config", required_argument, NULL, 'f'}, - { "timeout", required_argument, NULL, 't'}, - { "pid-file", required_argument, NULL, 'p'}, + { "config", required_argument, NULL, 'f' }, + { "timeout", required_argument, NULL, 't' }, + { "pid-file", required_argument, NULL, 'p' }, { "version", no_argument, NULL, 'V' }, { "help", no_argument, NULL, 'h' }, - {0, 0, 0, 0} + { 0, 0, 0, 0 }, }; if (virGettextInitialize() < 0 || diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index a15971b9bb..53a1cd1048 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1337,17 +1337,17 @@ vahParseArgv(vahControl * ctl, int argc, char **argv) { int arg, idx = 0; struct option opt[] = { - {"add", 0, 0, 'a'}, - {"create", 0, 0, 'c'}, - {"dryrun", 0, 0, 'd'}, - {"delete", 0, 0, 'D'}, - {"add-file", 0, 0, 'f'}, - {"append-file", 0, 0, 'F'}, - {"help", 0, 0, 'h'}, - {"replace", 0, 0, 'r'}, - {"remove", 0, 0, 'R'}, - {"uuid", 1, 0, 'u'}, - {0, 0, 0, 0} + { "add", 0, 0, 'a' }, + { "create", 0, 0, 'c' }, + { "dryrun", 0, 0, 'd' }, + { "delete", 0, 0, 'D' }, + { "add-file", 0, 0, 'f' }, + { "append-file", 0, 0, 'F' }, + { "help", 0, 0, 'h' }, + { "replace", 0, 0, 'r' }, + { "remove", 0, 0, 'R' }, + { "uuid", 1, 0, 'u' }, + { 0, 0, 0, 0 }, }; while ((arg = getopt_long(argc, argv, "acdDhrRH:b:u:p:f:F:", opt, diff --git a/tools/virsh.c b/tools/virsh.c index b37d2ce12f..5696941550 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -638,18 +638,18 @@ virshParseArgv(vshControl *ctl, int argc, char **argv) int longindex = -1; virshControl *priv = ctl->privData; struct option opt[] = { - {"connect", required_argument, NULL, 'c'}, - {"debug", required_argument, NULL, 'd'}, - {"escape", required_argument, NULL, 'e'}, - {"help", no_argument, NULL, 'h'}, - {"keepalive-interval", required_argument, NULL, 'k'}, - {"keepalive-count", required_argument, NULL, 'K'}, - {"log", required_argument, NULL, 'l'}, - {"quiet", no_argument, NULL, 'q'}, - {"readonly", no_argument, NULL, 'r'}, - {"timing", no_argument, NULL, 't'}, - {"version", optional_argument, NULL, 'v'}, - {NULL, 0, NULL, 0} + { "connect", required_argument, NULL, 'c' }, + { "debug", required_argument, NULL, 'd' }, + { "escape", required_argument, NULL, 'e' }, + { "help", no_argument, NULL, 'h' }, + { "keepalive-interval", required_argument, NULL, 'k' }, + { "keepalive-count", required_argument, NULL, 'K' }, + { "log", required_argument, NULL, 'l' }, + { "quiet", no_argument, NULL, 'q' }, + { "readonly", no_argument, NULL, 'r' }, + { "timing", no_argument, NULL, 't' }, + { "version", optional_argument, NULL, 'v' }, + { NULL, 0, NULL, 0 }, }; /* Standard (non-command) options. The leading + ensures that no diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 11ba242742..85b010b95f 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -1318,13 +1318,13 @@ vshAdmParseArgv(vshControl *ctl, int argc, char **argv) size_t i; int longindex = -1; struct option opt[] = { - {"connect", required_argument, NULL, 'c'}, - {"debug", required_argument, NULL, 'd'}, - {"help", no_argument, NULL, 'h'}, - {"log", required_argument, NULL, 'l'}, - {"quiet", no_argument, NULL, 'q'}, - {"version", optional_argument, NULL, 'v'}, - {NULL, 0, NULL, 0} + { "connect", required_argument, NULL, 'c' }, + { "debug", required_argument, NULL, 'd' }, + { "help", no_argument, NULL, 'h' }, + { "log", required_argument, NULL, 'l' }, + { "quiet", no_argument, NULL, 'q' }, + { "version", optional_argument, NULL, 'v' }, + { NULL, 0, NULL, 0 }, }; /* Standard (non-command) options. The leading + ensures that no diff --git a/tools/virt-host-validate.c b/tools/virt-host-validate.c index 4dae97910a..52ca729f85 100644 --- a/tools/virt-host-validate.c +++ b/tools/virt-host-validate.c @@ -73,10 +73,10 @@ show_version(FILE *out, const char *argv0) } static const struct option argOptions[] = { - { "help", 0, NULL, 'h', }, - { "version", 0, NULL, 'v', }, - { "quiet", 0, NULL, 'q', }, - { NULL, 0, NULL, '\0', } + { "help", 0, NULL, 'h' }, + { "version", 0, NULL, 'v' }, + { "quiet", 0, NULL, 'q' }, + { NULL, 0, NULL, '\0' }, }; int diff --git a/tools/virt-login-shell-helper.c b/tools/virt-login-shell-helper.c index 3f8757e496..8feeb8f0fe 100644 --- a/tools/virt-login-shell-helper.c +++ b/tools/virt-login-shell-helper.c @@ -179,9 +179,9 @@ main(int argc, char **argv) bool autoshell = false; struct option opt[] = { - {"help", no_argument, NULL, 'h'}, - {"version", optional_argument, NULL, 'V'}, - {NULL, 0, NULL, 0} + { "help", no_argument, NULL, 'h' }, + { "version", optional_argument, NULL, 'V' }, + { NULL, 0, NULL, 0 }, }; if (virInitialize() < 0) { fprintf(stderr, _("Failed to initialize libvirt error handling")); diff --git a/tools/virt-pki-query-dn.c b/tools/virt-pki-query-dn.c index ee3783c1b2..2d7849feb7 100644 --- a/tools/virt-pki-query-dn.c +++ b/tools/virt-pki-query-dn.c @@ -61,9 +61,9 @@ main(int argc, int rv = 0; struct option opt[] = { - {"help", no_argument, NULL, 'h'}, - {"version", optional_argument, NULL, 'v'}, - {NULL, 0, NULL, 0} + { "help", no_argument, NULL, 'h' }, + { "version", optional_argument, NULL, 'v' }, + { NULL, 0, NULL, 0 }, }; if (virGettextInitialize() < 0) -- 2.33.0

2 1

[PATCH] virsh: Add message to terminal when running snapshot-revert
by Haruka Ohata 22 Nov '22

22 Nov '22

When running virsh snapshot-* command, such as snapshot-create-as / snapshot-delete, it prints a result message. On the other hand virsh snapshot-revert command doesn't print a result message. So, This patch fixes to add message when running virsh snapshot-revert command. --- # virsh snapshot-create-as vm1 test1 Domain snapshot test01 created # virsh snapshot-revert vm1 test1 # virsh snapshot-delete vm1 test1 Domain snapshot test01 deleted # --- Signed-off-by: Haruka Ohata <ohata.haruka(a)fujitsu.com> --- tests/virsh-snapshot | 3 +++ tools/virsh-snapshot.c | 1 + 2 files changed, 4 insertions(+) diff --git a/tests/virsh-snapshot b/tests/virsh-snapshot index 4c64bb537b..b09273917b 100755 --- a/tests/virsh-snapshot +++ b/tests/virsh-snapshot @@ -100,11 +100,14 @@ Domain snapshot s1 created Domain snapshot s3 created Domain snapshot s2 created +Domain snapshot s3 reverted Domain snapshot s6 created Domain snapshot s5 created +Domain snapshot s6 reverted Domain snapshot s4 created +Domain snapshot s1 reverted Domain snapshot s7 created Domain snapshot s8 created diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 8fa64ba903..6a6c92d0a3 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1783,6 +1783,7 @@ cmdDomainSnapshotRevert(vshControl *ctl, const vshCmd *cmd) result = virDomainRevertToSnapshot(snapshot, flags); } + vshPrintExtra(ctl, _("Domain snapshot %s reverted\n"), name); return result >= 0; } -- 2.38.1

2 1

[libvirt PATCH 0/1] DO NOT MERGE: RFC: targetted usage of clang-format
by Daniel P. Berrangé 21 Nov '22

21 Nov '22

While we have a code style, it is not perfectly applied across the code base because its impossible for humans to manage that without using automated tooling. clang-format is the closest we'll get to a code formatter we could use, but still it would reformat quite alot of our code. I discovered that '/* clang-format off */' can be used to stop it from reformatting sections of code. It is not practical to add that comment around all places we don't want touched. I thought we could perhaps use it as a way to limit clang-format to merely do sorting & regrouping of #include statements though. This change illustrates what that would look like for the src/util directory, so we can consider whuether it is worth it. I've included a mark.pl script that I usd to auto-add the magic comment. It gets it wrong sometimes, so needs inspection. If we did decide to use this, we would need the magic comment in every existing source file. Then there is the question about new source files. If a contributor forgets to add the comment, then entire new source file will be processed by clang-format. This might be desirable. If so, we will need to fully expand the .clang-format config file to match ou4r desired style. Right now I only recorded include file rules. Or we could just wrong a dumb script to do #include sorting ourselves and carry on ignoring clang-format. I'm pretty undecided myself. Daniel P. Berrangé (1): DO NOT MERGE: use clang-format for sorting #include statement .clang-format | 32 +++++++++++++++++++++++++ mark.pl | 41 ++++++++++++++++++++++++++++++++ src/util/glibcompat.c | 2 ++ src/util/glibcompat.h | 4 +++- src/util/iohelper.c | 10 ++++---- src/util/viralloc.c | 5 +++- src/util/viralloc.h | 2 ++ src/util/virarch.c | 4 +++- src/util/virarch.h | 2 ++ src/util/virarptable.c | 2 ++ src/util/virarptable.h | 2 ++ src/util/viraudit.c | 6 +++-- src/util/viraudit.h | 2 ++ src/util/virauth.c | 13 ++++++---- src/util/virauth.h | 2 ++ src/util/virauthconfig.c | 6 +++-- src/util/virauthconfig.h | 2 ++ src/util/virbitmap.c | 5 +++- src/util/virbitmap.h | 5 ++-- src/util/virbpf.c | 5 +++- src/util/virbpf.h | 2 ++ src/util/virbuffer.c | 2 ++ src/util/virbuffer.h | 3 ++- src/util/virccw.c | 4 ++++ src/util/virccw.h | 2 ++ src/util/vircgroup.c | 15 ++++++------ src/util/vircgroup.h | 2 ++ src/util/vircgroupbackend.c | 2 ++ src/util/vircgroupbackend.h | 3 ++- src/util/vircgrouppriv.h | 2 ++ src/util/vircgroupv1.c | 11 +++++---- src/util/vircgroupv1.h | 2 ++ src/util/vircgroupv2.c | 5 ++-- src/util/vircgroupv2.h | 2 ++ src/util/vircgroupv2devices.c | 5 ++-- src/util/vircgroupv2devices.h | 3 ++- src/util/vircommand.c | 10 ++++---- src/util/vircommand.h | 2 ++ src/util/vircommandpriv.h | 2 ++ src/util/virconf.c | 20 +++++++++------- src/util/virconf.h | 3 +++ src/util/vircrypto.c | 9 ++++--- src/util/vircrypto.h | 2 ++ src/util/virdaemon.c | 14 ++++++----- src/util/virdaemon.h | 2 ++ src/util/virdevmapper.c | 15 +++++++----- src/util/virdevmapper.h | 2 ++ src/util/virdnsmasq.c | 17 +++++++------ src/util/virdnsmasq.h | 2 ++ src/util/virebtables.c | 7 ++++-- src/util/virebtables.h | 2 ++ src/util/virendian.h | 3 +++ src/util/virenum.c | 2 ++ src/util/virenum.h | 2 ++ src/util/virerror.c | 5 +++- src/util/virerror.h | 2 ++ src/util/virerrorpriv.h | 2 ++ src/util/virevent.c | 5 +++- src/util/virevent.h | 2 ++ src/util/vireventglib.c | 5 +++- src/util/vireventglib.h | 2 ++ src/util/vireventglibwatch.c | 3 +++ src/util/vireventglibwatch.h | 2 ++ src/util/vireventthread.c | 5 +++- src/util/vireventthread.h | 5 +++- src/util/virfcp.c | 7 +++--- src/util/virfcp.h | 2 ++ src/util/virfdstream.c | 19 ++++++++------- src/util/virfdstream.h | 3 +++ src/util/virfile.c | 13 ++++++---- src/util/virfile.h | 2 ++ src/util/virfilecache.c | 13 +++++----- src/util/virfilecache.h | 5 ++-- src/util/virfirewall.c | 9 ++++--- src/util/virfirewall.h | 4 +++- src/util/virfirewalld.c | 11 +++++---- src/util/virfirewalld.h | 2 ++ src/util/virfirewalldpriv.h | 2 ++ src/util/virfirmware.c | 5 +++- src/util/virfirmware.h | 2 ++ src/util/virgdbus.c | 4 +++- src/util/virgdbus.h | 2 ++ src/util/virgettext.c | 4 +++- src/util/virgettext.h | 2 ++ src/util/virgic.c | 6 ++++- src/util/virgic.h | 2 ++ src/util/virglibutil.c | 2 ++ src/util/virglibutil.h | 2 ++ src/util/virhash.c | 8 ++++--- src/util/virhash.h | 2 ++ src/util/virhashcode.c | 5 +++- src/util/virhashcode.h | 5 +++- src/util/virhook.c | 16 ++++++++----- src/util/virhook.h | 2 ++ src/util/virhostcpu.c | 12 ++++++---- src/util/virhostcpu.h | 1 + src/util/virhostcpupriv.h | 2 ++ src/util/virhostmem.c | 14 ++++++----- src/util/virhostmem.h | 2 ++ src/util/virhostuptime.c | 8 ++++--- src/util/virhostuptime.h | 2 ++ src/util/viridentity.c | 13 ++++++---- src/util/viridentity.h | 5 +++- src/util/viridentitypriv.h | 2 ++ src/util/virinitctl.c | 7 ++++-- src/util/virinitctl.h | 2 ++ src/util/viriptables.c | 15 +++++++----- src/util/viriptables.h | 4 +++- src/util/viriscsi.c | 2 ++ src/util/viriscsi.h | 2 ++ src/util/virjson.c | 10 ++++---- src/util/virjson.h | 5 ++-- src/util/virkeycode.c | 6 ++++- src/util/virkeycode.h | 2 ++ src/util/virkmod.c | 6 ++++- src/util/virkmod.h | 2 ++ src/util/virlease.c | 8 ++++--- src/util/virlease.h | 2 ++ src/util/virlockspace.c | 13 ++++++---- src/util/virlockspace.h | 2 ++ src/util/virlog.c | 24 +++++++++++-------- src/util/virlog.h | 2 ++ src/util/virmacaddr.c | 4 +++- src/util/virmacaddr.h | 2 ++ src/util/virmacmap.c | 9 ++++--- src/util/virmacmap.h | 2 ++ src/util/virmdev.c | 7 ++++-- src/util/virmdev.h | 4 +++- src/util/virmodule.c | 5 +++- src/util/virmodule.h | 2 ++ src/util/virnetdev.c | 24 +++++++++++-------- src/util/virnetdev.h | 9 ++++--- src/util/virnetdevbandwidth.c | 6 ++++- src/util/virnetdevbandwidth.h | 2 ++ src/util/virnetdevbridge.c | 15 +++++++----- src/util/virnetdevbridge.h | 2 ++ src/util/virnetdevip.c | 15 +++++++----- src/util/virnetdevip.h | 2 ++ src/util/virnetdevmacvlan.c | 5 +++- src/util/virnetdevmacvlan.h | 6 +++-- src/util/virnetdevmidonet.c | 3 +++ src/util/virnetdevmidonet.h | 1 + src/util/virnetdevopenvswitch.c | 12 ++++++---- src/util/virnetdevopenvswitch.h | 4 +++- src/util/virnetdevpriv.h | 2 ++ src/util/virnetdevtap.c | 22 ++++++++++------- src/util/virnetdevtap.h | 4 +++- src/util/virnetdevveth.c | 5 +++- src/util/virnetdevveth.h | 2 ++ src/util/virnetdevvlan.c | 5 +++- src/util/virnetdevvlan.h | 2 ++ src/util/virnetdevvportprofile.c | 5 +++- src/util/virnetdevvportprofile.h | 6 +++-- src/util/virnetlink.c | 11 +++++---- src/util/virnetlink.h | 2 ++ src/util/virnodesuspend.c | 12 ++++++---- src/util/virnodesuspend.h | 2 ++ src/util/virnuma.c | 14 ++++++----- src/util/virnuma.h | 1 + src/util/virnvme.c | 7 ++++-- src/util/virnvme.h | 2 ++ src/util/virobject.c | 6 +++-- src/util/virobject.h | 4 +++- src/util/virpci.c | 16 +++++++------ src/util/virpci.h | 4 +++- src/util/virpcivpd.c | 8 ++++--- src/util/virpcivpd.h | 2 ++ src/util/virpcivpdpriv.h | 2 ++ src/util/virperf.c | 6 +++-- src/util/virperf.h | 2 ++ src/util/virpidfile.c | 11 +++++---- src/util/virpidfile.h | 3 +++ src/util/virpolkit.c | 10 +++++--- src/util/virpolkit.h | 2 ++ src/util/virportallocator.c | 9 ++++--- src/util/virportallocator.h | 2 ++ src/util/virprobe.h | 2 ++ src/util/virprocess.c | 13 +++++----- src/util/virprocess.h | 2 ++ src/util/virqemu.c | 8 ++++--- src/util/virqemu.h | 2 ++ src/util/virrandom.c | 11 +++++---- src/util/virrandom.h | 2 ++ src/util/virresctrl.c | 8 ++++--- src/util/virresctrl.h | 5 ++-- src/util/virresctrlpriv.h | 2 ++ src/util/virrotatingfile.c | 3 +++ src/util/virrotatingfile.h | 2 ++ src/util/virscsi.c | 11 +++++---- src/util/virscsi.h | 2 ++ src/util/virscsihost.c | 6 ++++- src/util/virscsihost.h | 2 ++ src/util/virscsivhost.c | 8 +++++-- src/util/virscsivhost.h | 2 ++ src/util/virseclabel.c | 5 +++- src/util/virseclabel.h | 2 ++ src/util/virsecret.c | 5 +++- src/util/virsecret.h | 5 ++-- src/util/virsecureerase.c | 2 ++ src/util/virsecureerase.h | 2 ++ src/util/virsocket.c | 9 ++++--- src/util/virsocket.h | 2 ++ src/util/virsocketaddr.c | 5 +++- src/util/virsocketaddr.h | 2 ++ src/util/virstoragefile.c | 5 +++- src/util/virstoragefile.h | 2 ++ src/util/virstring.c | 6 +++-- src/util/virstring.h | 2 ++ src/util/virsysinfo.c | 9 ++++--- src/util/virsysinfo.h | 2 ++ src/util/virsysinfopriv.h | 2 ++ src/util/virsystemd.c | 17 ++++++------- src/util/virsystemd.h | 2 ++ src/util/virsystemdpriv.h | 2 ++ src/util/virthread.c | 3 ++- src/util/virthread.h | 4 +++- src/util/virthreadjob.c | 5 +++- src/util/virthreadjob.h | 2 ++ src/util/virthreadpool.c | 5 +++- src/util/virthreadpool.h | 2 ++ src/util/virtime.c | 5 +++- src/util/virtime.h | 2 ++ src/util/virtpm.c | 11 +++++---- src/util/virtpm.h | 2 ++ src/util/virtypedparam-public.c | 4 +++- src/util/virtypedparam.c | 5 +++- src/util/virtypedparam.h | 2 ++ src/util/viruri.c | 4 +++- src/util/viruri.h | 2 ++ src/util/virusb.c | 9 ++++--- src/util/virusb.h | 2 ++ src/util/virutil.c | 14 ++++++----- src/util/virutil.h | 6 +++-- src/util/viruuid.c | 10 ++++---- src/util/viruuid.h | 1 + src/util/virvhba.c | 5 +++- src/util/virvhba.h | 2 ++ src/util/virvsock.c | 4 ++-- src/util/virvsock.h | 2 ++ src/util/virxdrdefs.h | 2 ++ src/util/virxml.c | 13 ++++++---- src/util/virxml.h | 7 +++--- 242 files changed, 986 insertions(+), 367 deletions(-) create mode 100644 .clang-format create mode 100644 mark.pl -- 2.37.3

3 3

[PATCH 0/2] Fix some coding issues
by Jiang Jiacheng 21 Nov '22

21 Nov '22

*** BLURB HERE *** Jiang Jiacheng (2): qemu: convert the flags type to unsigned long coding-style: Use the same style in the same structure src/locking/lock_daemon.c | 12 ++++++------ src/logging/log_daemon.c | 12 ++++++------ src/qemu/qemu_migration.c | 4 ++-- src/remote/remote_daemon.c | 14 +++++++------- 4 files changed, 21 insertions(+), 21 deletions(-) -- 2.33.0

3 4

[PATCH] virmockstathelpers: Load aliases for 64-bit time
by Michal Privoznik 21 Nov '22

21 Nov '22

On 32-bit arches, it's possible not only to request -D_FILE_OFFSET_BITS=64 (which is always done with meson) but also -D_TIME_BITS=64. With glibc, both of these affect what variant of stat() or lstat() is called. With 64 bit time it's: __stat64_time64() or __lstat64_time64(), respectively. Fortunately, no other variant (__xstat(), __xstat64()) has _time64 alternative and thus does not need similar treatment. Similarly, musl is not affected by this. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/404 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Mind you, after this I still see two tests failing: 1) virnettlscontexttest 2) virnettlssessiontest But I believe the problem is that GnuTLS on my 32bit RPi was not built with -D_TIME_BITS=64 and thus when generating certificates and setting their activation/expiry times I get the following errors: TEST: virnettlscontexttest 1) TLS Context cacertreq.filename + servercertreq.filename ... libvirt: XML-RPC error : The server certificate servercertreq-ctx.pem is not yet active FAILED TEST: virnettlssessiontest 1) TLS Session servercertreq.filename + clientcertreq.filename ... libvirt: XML-RPC error : authentication failed: Failed to verify peer's certificate FAILED Setting of activation/expiry times is done by calling: 1) gnutls_x509_crt_set_activation_time(..., time_t act_time) 2) gnutls_x509_crt_set_expiration_time(..., time_t exp_time) And this is how calling the first looks under disassembly: 7428: e51b1128 ldr r1, [fp, #-296] ; 0xfffffed8 742c: e14b2dd4 ldrd r2, [fp, #-212] ; 0xffffff2c 7430: e1a00001 mov r0, r1 7434: ebfff23d bl 3d30 <gnutls_x509_crt_set_activation_time@plt> Now, ldrd instruction modifies both r2 and r3 by loading 4+4 bytes from a memory address [1]. But the first thing that gnutls_x509_crt_set_activation_time() does is overwriting r3 register: 000fb4a0 <gnutls_x509_crt_set_activation_time>: fb4a0: e52de004 push {lr} ; (str lr, [sp, #-4]!) fb4a4: e250c000 subs ip, r0, #0 fb4a8: e59f3080 ldr r3, [pc, #128] ; fb530 <gnutls_x509_crt_set_activation_time+0x90> fb4ac: e24dd00c sub sp, sp, #12 fb4b0: e08f3003 add r3, pc, r3 fb4b4: 0a000009 beq fb4e0 <gnutls_x509_crt_set_activation_time+0x40> With 32-bit time_t the disassembly looks a bit different: 73e4: e51b3114 ldr r3, [fp, #-276] ; 0xfffffeec 73e8: e51b10f4 ldr r1, [fp, #-244] ; 0xffffff0c 73ec: e1a00003 mov r0, r3 73f0: ebfff250 bl 3d38 <gnutls_x509_crt_set_activation_time@plt> 1: It should be 'ldrd r2, r3, $memAddr' but the second register is implied by the first one, so it can be shortened: https://developer.arm.com/documentation/ddi0406/c/Application-Level-Archite… tests/virmockstathelpers.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tests/virmockstathelpers.c b/tests/virmockstathelpers.c index 39e270eaac..5b1f3b08a7 100644 --- a/tests/virmockstathelpers.c +++ b/tests/virmockstathelpers.c @@ -54,6 +54,10 @@ * Unfortunately, because we are trying to mock replace the C library, * we need to know about this internal impl detail. * + * Furthermore, support for 64-bit time can be enabled, which on 32-bit + * systems with glibc overwrites stat64() to __stat64_time64() and lstat64() + * to __lstat64_time64(). + * * On macOS stat() and lstat() are resolved to _stat$INODE64 and * _lstat$INODE64, respectively. stat(2) man page also declares that * stat64(), lstat64() and fstat64() are deprecated, and when @@ -168,7 +172,11 @@ static void virMockStatInit(void) fdebug("real stat %p\n", real_stat); #endif #ifdef MOCK_STAT64 +# if defined(__GLIBC__) && defined(_TIME_BITS) && _TIME_BITS == 64 + VIR_MOCK_REAL_INIT_ALIASED(stat64, "__stat64_time64"); +# else VIR_MOCK_REAL_INIT(stat64); +# endif fdebug("real stat64 %p\n", real_stat64); #endif #ifdef MOCK___XSTAT @@ -188,7 +196,11 @@ static void virMockStatInit(void) fdebug("real lstat %p\n", real_lstat); #endif #ifdef MOCK_LSTAT64 +# if defined(__GLIBC__) && defined(_TIME_BITS) && _TIME_BITS == 64 + VIR_MOCK_REAL_INIT_ALIASED(lstat64, "__lstat64_time64"); +# else VIR_MOCK_REAL_INIT(lstat64); +# endif fdebug("real lstat64 %p\n", real_lstat64); #endif #ifdef MOCK___LXSTAT -- 2.37.4

2 1

[PATCH 0/3] docs: drvqemu: Fixes for device property overriding docs
by Peter Krempa 21 Nov '22

21 Nov '22

Peter Krempa (3): docs: drvqemu: Fix and improve docs about device override types docs: drvqemu: Give example how to query device properties for overriding docs: drvqemu: Remove inaccuate limitations statement docs/drvqemu.rst | 41 ++++++++++++++++++++++++++++++++++------- 1 file changed, 34 insertions(+), 7 deletions(-) -- 2.37.3

2 5

[PATCH] tests: Drop needless virrandom mock from two tests
by Michal Privoznik 21 Nov '22

21 Nov '22

Nothing in virnettlscontexttest nor virnettlssessiontest calls any of random number generator functions overridden virrandommock. GnuTLS handles RNG within itself. Therefore, there's no need to preload the mock. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/virnettlscontexttest.c | 2 +- tests/virnettlssessiontest.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index 403cd8d0ac..2311524db8 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -627,7 +627,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virrandom")) +VIR_TEST_MAIN(mymain); #else diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c index 5b98a6de3e..285cde57d8 100644 --- a/tests/virnettlssessiontest.c +++ b/tests/virnettlssessiontest.c @@ -482,7 +482,7 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virrandom")) +VIR_TEST_MAIN(mymain); #else -- 2.37.4

2 1

[libvirt PATCH 0/2] A few post-copy related fixes
by Jiri Denemark 21 Nov '22

21 Nov '22

*** BLURB EVERYWHERE *** Jiri Denemark (2): qemu: Always restore post-copy migration job on reconnect qemu: Ignore failure in post-copy migration when QEMU says completed src/qemu/qemu_migration.c | 8 ++++++++ src/qemu/qemu_process.c | 15 ++++++++++----- 2 files changed, 18 insertions(+), 5 deletions(-) -- 2.38.1

2 4

Plans for the next release
by Jiri Denemark 21 Nov '22

21 Nov '22

We are getting close to the last release of libvirt in 2022. To aim for the release on Dec 01 I suggest entering the freeze on Thursday Nov 24 and tagging RC2 on Tuesday Nov 29. I hope this works for everyone. Jirka

1 0

[libvirt PATCH] qemu: fix memlock without vIOMMU
by Jonathon Jongsma 18 Nov '22

18 Nov '22

When there is no vIOMMU, vfio devices don't need to lock the entire guest memory per-device, but they still need to lock the entire guest memory to share between all vfio devices. This memory accounting is not shared with vDPA devices, so it should be added to the memlock limit separately. Commit 8d5704e2 added support for multiple vfio/vdpa devices but calculated the limits incorrectly when there were both vdpa and vfio devices and no vIOMMU. In this case, the memory lock limit was not increased separately for the vfio devices. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2111317 Signed-off-by: Jonathon Jongsma <jjongsma(a)redhat.com> --- src/qemu/qemu_domain.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ef1a9c8c74..8ae458ae45 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9470,10 +9470,14 @@ qemuDomainGetMemLockLimitBytes(virDomainDef *def, */ int factor = nvdpa; - if (def->iommu) - factor += nvfio; + if (nvfio || forceVFIO) { + if (nvfio && def->iommu) + factor += nvfio; + else + factor += 1; + } - memKB = MAX(factor, 1) * virDomainDefGetMemoryTotal(def) + 1024 * 1024; + memKB = factor * virDomainDefGetMemoryTotal(def) + 1024 * 1024; } return memKB << 10; -- 2.38.1

2 1

[PATCH] cpu_arm: fix the compile warning of unexpected format
by Jiang Jiacheng 18 Nov '22

18 Nov '22

These format are left unchanged when convert 'unsigned long' to 'unsigned long long', which caused compile warning. Signed-off-by: Jiang Jiacheng <jiangjiacheng(a)huawei.com> --- src/cpu/cpu_arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index ef72d6dceb..3ec06edef4 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -639,7 +639,7 @@ virCPUarmDecode(virCPUDef *cpu, if (!(model = virCPUarmModelFindByPVR(map, cpuData->pvr))) { virReportError(VIR_ERR_OPERATION_FAILED, - _("Cannot find CPU model with PVR 0x%03lx"), + _("Cannot find CPU model with PVR 0x%03llx"), cpuData->pvr); return -1; } @@ -656,7 +656,7 @@ virCPUarmDecode(virCPUDef *cpu, if (cpuData->vendor_id && !(vendor = virCPUarmVendorFindByID(map, cpuData->vendor_id))) { virReportError(VIR_ERR_OPERATION_FAILED, - _("Cannot find CPU vendor with vendor id 0x%02lx"), + _("Cannot find CPU vendor with vendor id 0x%02llx"), cpuData->vendor_id); return -1; } -- 2.33.0

2 1

[PATCH] Add vms cli tool to the list of applications using libvirt
by Cédric Bosdonnat 17 Nov '22

17 Nov '22

Just adds a tool to the applications list. This tool helps managing multiple VMs at once using the python binding. Signed-off-by: Cédric Bosdonnat <cbosdonnat(a)suse.com> --- docs/apps.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/apps.rst b/docs/apps.rst index 1a25c0a21e..57a3d00dca 100644 --- a/docs/apps.rst +++ b/docs/apps.rst @@ -70,6 +70,9 @@ virsh Virt-Lightning uses libvirt, cloud-init and libguestfs to allow anyone to quickly start a new VM. Very much like a container CLI, but with a virtual machine. +`vms <https://github.com/cbosdo/vms>`__ + vms is a tool wrapping around the libvirt API to manage multiple virtual + machines at once with name patterns. Configuration Management ------------------------ -- 2.37.1

3 2

[PATCH 0/8] network: firewalld: native support for NAT/routed
by Eric Garver 16 Nov '22

16 Nov '22

This series further improves the firewalld backend by converting to a fully native implementation for NAT and routed networks. That is, there are no iptables rules added by libvirt when the running firewalld is 0.9.0 or later. The major advantage is that firewalld users can use firewall-cmd to filter the VM traffic and apply their own policies. When firewalld < 0.9.0 is present only the "libvirt" zone will be used. The new "libvirt-nat" and "libvirt-routed" zones are not used. This maintains compatibility for older distributions (e.g. Ubuntu 20.04). Patch 1 is a bug fix for my previous series to avoid a bogus error log. Patches 2-3 converts the routed network to native firewalld. Patches 4-8 converts the NAT network to native firewalld. It also introduces the "libvirt-nat" zone. Eric Garver (8): util: virFirewallDGetPolicies: gracefully handle older firewalld network: firewalld: add networkAddHybridFirewallDRules() network: firewalld: use native routed networks util: add virFirewallDSourceSetZone() util: add virFirewallDApplyPolicyRichRules() network: firewalld: add zone for NAT networks network: firewalld: add policies for NAT networks network: firewalld: use native NAT networks libvirt.spec.in | 2 + src/libvirt_private.syms | 2 + src/network/bridge_driver_linux.c | 193 ++++++++++++++++++++--------- src/network/libvirt-nat-out.policy | 13 ++ src/network/libvirt-nat.zone | 10 ++ src/network/libvirt-to-host.policy | 1 + src/network/meson.build | 10 ++ src/util/virfirewalld.c | 79 +++++++++++- src/util/virfirewalld.h | 6 + 9 files changed, 258 insertions(+), 58 deletions(-) create mode 100644 src/network/libvirt-nat-out.policy create mode 100644 src/network/libvirt-nat.zone -- 2.37.3

5 22

[PATCH 0/7] Couple of miscellaneous cleanups
by Michal Privoznik 16 Nov '22

16 Nov '22

There's this request for us to parse NVDIMMs from .vmx files. Well, we're not there yet - firstly we'd need to deduce NUMA configuration so that we know to which guest NUMA node is the NVDIMM attached. But that is very dynamic and in fact computed on virtual machine startup [1]. Nevertheless, I've accumulated couple of cleanups that are independent of the feature and can be merged separately. 1: https://frankdenneman.nl/2016/08/22/numa-deep-dive-part-5-esxi-vmkernel-num… Michal Prívozník (7): coding-style: Follow our own recommendation wrt spacing around commas docs: Fill missing docs on STRCASEPREFIX() and STRSKIP() internal: Introduce STRCASESKIP() vmx: Convert virVMXConfigScanResultsCollector() to use STRCASESKIP() vmx: Rework virVMXConfigScanResultsCollector slightly conf: Introduce virDomainMemoryDefNew() conf: Declare and use autoptr for virDomainMemoryDef docs/coding-style.rst | 42 ++++++++++++++++++++++++++++-------- src/conf/domain_conf.c | 48 ++++++++++++++++++++++++------------------ src/conf/domain_conf.h | 2 ++ src/internal.h | 2 ++ src/vmx/vmx.c | 11 +++++----- 5 files changed, 71 insertions(+), 34 deletions(-) -- 2.37.4

4 11

[PATCH] qemucapabilitiesdata: Update caps for qemu-7.2.0 rc1 on x86_64
by Peter Krempa 16 Nov '22

16 Nov '22

Update to v7.2.0-rc1 Notable changes: - 'virtio-blk-vfio-pci' blockdev backend added - 'cryptodev-backend-lkcf' object added - new options/parameters for virtio-*-pci, virtio-*-device, and vhost-user-* devices: - 'queue_reset' - use-started - use-disabled-flags - 'dma-translation' option for 'intel-iommu' device - 'zpcii-disable' commandline parameter removed (not applicable on x86) Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_7.2.0.x86_64.replies | 2124 +++++++++-------- .../caps_7.2.0.x86_64.xml | 4 +- 2 files changed, 1115 insertions(+), 1013 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.replies index b7eb0356c4..47203b8923 100644 --- a/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.replies @@ -17,11 +17,11 @@ { "return": { "qemu": { - "micro": 50, + "micro": 91, "minor": 1, "major": 7 }, - "package": "v7.1.0-1579-g5107fd3eff" + "package": "v7.2.0-rc1" }, "id": "libvirt-2" } @@ -3367,13 +3367,17 @@ "type": "298" }, { - "case": "virtio-blk-vhost-user", + "case": "virtio-blk-vfio-pci", "type": "325" }, { - "case": "virtio-blk-vhost-vdpa", + "case": "virtio-blk-vhost-user", "type": "326" }, + { + "case": "virtio-blk-vhost-vdpa", + "type": "327" + }, { "case": "vmdk", "type": "318" @@ -3384,7 +3388,7 @@ }, { "case": "vvfat", - "type": "327" + "type": "328" } ], "members": [ @@ -3459,7 +3463,7 @@ }, { "name": "options", - "type": "328" + "type": "329" } ], "meta-type": "object" @@ -3477,7 +3481,7 @@ }, { "name": "options", - "type": "329" + "type": "330" }, { "name": "force", @@ -3534,11 +3538,11 @@ }, { "name": "operation", - "type": "330" + "type": "331" }, { "name": "action", - "type": "331" + "type": "332" }, { "name": "nospace", @@ -3557,7 +3561,7 @@ "members": [ { "name": "type", - "type": "332" + "type": "333" }, { "name": "device", @@ -3588,7 +3592,7 @@ "members": [ { "name": "type", - "type": "332" + "type": "333" }, { "name": "device", @@ -3618,11 +3622,11 @@ }, { "name": "operation", - "type": "330" + "type": "331" }, { "name": "action", - "type": "331" + "type": "332" } ], "meta-type": "object" @@ -3632,7 +3636,7 @@ "members": [ { "name": "type", - "type": "332" + "type": "333" }, { "name": "device", @@ -3658,7 +3662,7 @@ "members": [ { "name": "type", - "type": "332" + "type": "333" }, { "name": "id", @@ -3728,7 +3732,7 @@ }, { "name": "iothread", - "type": "333" + "type": "334" }, { "name": "force", @@ -3761,7 +3765,7 @@ "members": [ { "name": "type", - "type": "334" + "type": "335" }, { "name": "error", @@ -3944,7 +3948,7 @@ }, { "name": "type", - "type": "332" + "type": "333" }, { "name": "status", @@ -3971,7 +3975,7 @@ "members": [ { "name": "addr", - "type": "335" + "type": "336" }, { "name": "tls-creds", @@ -4031,7 +4035,7 @@ { "name": "mode", "default": null, - "type": "336" + "type": "337" } ], "meta-type": "object" @@ -4042,25 +4046,25 @@ "variants": [ { "case": "nbd", - "type": "338" + "type": "339" }, { "case": "vhost-user-blk", - "type": "339" + "type": "340" }, { "case": "fuse", - "type": "340" + "type": "341" }, { "case": "vduse-blk", - "type": "341" + "type": "342" } ], "members": [ { "name": "type", - "type": "337" + "type": "338" }, { "name": "id", @@ -4103,7 +4107,7 @@ { "name": "mode", "default": null, - "type": "336" + "type": "337" } ], "meta-type": "object" @@ -4132,7 +4136,7 @@ }, { "name": "type", - "type": "337" + "type": "338" }, { "name": "node-name", @@ -4197,7 +4201,7 @@ { "name": "format", "default": null, - "type": "342" + "type": "343" } ], "meta-type": "object" @@ -4216,7 +4220,7 @@ { "name": "format", "default": null, - "type": "342" + "type": "343" } ], "meta-type": "object" @@ -4235,7 +4239,7 @@ }, { "name": "backend", - "type": "343" + "type": "344" } ], "meta-type": "object" @@ -4260,7 +4264,7 @@ }, { "name": "backend", - "type": "343" + "type": "344" } ], "meta-type": "object" @@ -4328,7 +4332,7 @@ { "name": "format", "default": null, - "type": "344" + "type": "345" } ], "meta-type": "object" @@ -4338,7 +4342,7 @@ "members": [ { "name": "status", - "type": "345" + "type": "346" }, { "name": "completed", @@ -4371,7 +4375,7 @@ "members": [ { "name": "formats", - "type": "[344]" + "type": "[345]" } ], "meta-type": "object" @@ -4396,55 +4400,55 @@ "variants": [ { "case": "nic", - "type": "347" + "type": "348" }, { "case": "user", - "type": "348" + "type": "349" }, { "case": "tap", - "type": "349" + "type": "350" }, { "case": "l2tpv3", - "type": "350" + "type": "351" }, { "case": "socket", - "type": "351" + "type": "352" }, { "case": "stream", - "type": "352" + "type": "353" }, { "case": "dgram", - "type": "353" + "type": "354" }, { "case": "vde", - "type": "354" + "type": "355" }, { "case": "bridge", - "type": "355" + "type": "356" }, { "case": "hubport", - "type": "356" + "type": "357" }, { "case": "netmap", - "type": "357" + "type": "358" }, { "case": "vhost-user", - "type": "358" + "type": "359" }, { "case": "vhost-vdpa", - "type": "359" + "type": "360" }, { "case": "none", @@ -4458,7 +4462,7 @@ }, { "name": "type", - "type": "346" + "type": "347" } ], "meta-type": "object" @@ -4502,15 +4506,15 @@ }, { "name": "multicast", - "type": "363" + "type": "364" }, { "name": "unicast", - "type": "363" + "type": "364" }, { "name": "vlan", - "type": "363" + "type": "364" }, { "name": "broadcast-allowed", @@ -4609,7 +4613,7 @@ }, { "name": "addr", - "type": "364" + "type": "365" } ], "meta-type": "object" @@ -4710,11 +4714,11 @@ }, { "name": "duplex", - "type": "365" + "type": "366" }, { "name": "autoneg", - "type": "366" + "type": "367" } ], "meta-type": "object" @@ -4752,15 +4756,15 @@ }, { "name": "key", - "type": "367" + "type": "368" }, { "name": "mask", - "type": "368" + "type": "369" }, { "name": "action", - "type": "369" + "type": "370" } ], "meta-type": "object" @@ -4918,7 +4922,7 @@ }, { "name": "options", - "type": "370" + "type": "371" } ], "meta-type": "object" @@ -4929,7 +4933,7 @@ "variants": [ { "case": "vnc", - "type": "373" + "type": "374" }, { "case": "spice", @@ -4939,7 +4943,7 @@ "members": [ { "name": "protocol", - "type": "371" + "type": "372" }, { "name": "password", @@ -4948,7 +4952,7 @@ { "name": "connected", "default": null, - "type": "372" + "type": "373" } ], "meta-type": "object" @@ -4959,7 +4963,7 @@ "variants": [ { "case": "vnc", - "type": "374" + "type": "375" }, { "case": "spice", @@ -4969,7 +4973,7 @@ "members": [ { "name": "protocol", - "type": "371" + "type": "372" }, { "name": "time", @@ -4998,7 +5002,7 @@ { "name": "format", "default": null, - "type": "375" + "type": "376" } ], "meta-type": "object" @@ -5041,12 +5045,12 @@ }, { "name": "mouse-mode", - "type": "376" + "type": "377" }, { "name": "channels", "default": null, - "type": "[377]" + "type": "[378]" } ], "meta-type": "object" @@ -5056,11 +5060,11 @@ "members": [ { "name": "server", - "type": "378" + "type": "379" }, { "name": "client", - "type": "378" + "type": "379" } ], "meta-type": "object" @@ -5070,11 +5074,11 @@ "members": [ { "name": "server", - "type": "379" + "type": "380" }, { "name": "client", - "type": "377" + "type": "378" } ], "meta-type": "object" @@ -5084,11 +5088,11 @@ "members": [ { "name": "server", - "type": "378" + "type": "379" }, { "name": "client", - "type": "378" + "type": "379" } ], "meta-type": "object" @@ -5108,7 +5112,7 @@ { "name": "family", "default": null, - "type": "380" + "type": "381" }, { "name": "service", @@ -5123,7 +5127,7 @@ { "name": "clients", "default": null, - "type": "[381]" + "type": "[382]" } ], "meta-type": "object" @@ -5142,20 +5146,20 @@ }, { "name": "server", - "type": "[382]" + "type": "[383]" }, { "name": "clients", - "type": "[381]" + "type": "[382]" }, { "name": "auth", - "type": "383" + "type": "384" }, { "name": "vencrypt", "default": null, - "type": "384" + "type": "385" }, { "name": "display", @@ -5180,11 +5184,11 @@ "members": [ { "name": "server", - "type": "385" + "type": "386" }, { "name": "client", - "type": "386" + "type": "387" } ], "meta-type": "object" @@ -5194,11 +5198,11 @@ "members": [ { "name": "server", - "type": "385" + "type": "386" }, { "name": "client", - "type": "381" + "type": "382" } ], "meta-type": "object" @@ -5208,11 +5212,11 @@ "members": [ { "name": "server", - "type": "385" + "type": "386" }, { "name": "client", - "type": "381" + "type": "382" } ], "meta-type": "object" @@ -5249,7 +5253,7 @@ "members": [ { "name": "keys", - "type": "[387]" + "type": "[388]" }, { "name": "hold-time", @@ -5274,7 +5278,7 @@ }, { "name": "events", - "type": "[388]" + "type": "[389]" } ], "meta-type": "object" @@ -5285,19 +5289,19 @@ "variants": [ { "case": "curses", - "type": "393" + "type": "394" }, { "case": "egl-headless", - "type": "394" + "type": "395" }, { "case": "dbus", - "type": "395" + "type": "396" }, { "case": "sdl", - "type": "396" + "type": "397" }, { "case": "default", @@ -5315,7 +5319,7 @@ "members": [ { "name": "type", - "type": "389" + "type": "390" }, { "name": "full-screen", @@ -5335,7 +5339,7 @@ { "name": "gl", "default": null, - "type": "390" + "type": "391" } ], "meta-type": "object" @@ -5346,13 +5350,13 @@ "variants": [ { "case": "vnc", - "type": "398" + "type": "399" } ], "members": [ { "name": "type", - "type": "397" + "type": "398" } ], "meta-type": "object" @@ -5363,13 +5367,13 @@ "variants": [ { "case": "vnc", - "type": "400" + "type": "401" } ], "members": [ { "name": "type", - "type": "399" + "type": "400" } ], "meta-type": "object" @@ -5380,27 +5384,27 @@ { "name": "status", "default": null, - "type": "401" + "type": "402" }, { "name": "ram", "default": null, - "type": "402" + "type": "403" }, { "name": "disk", "default": null, - "type": "402" + "type": "403" }, { "name": "vfio", "default": null, - "type": "403" + "type": "404" }, { "name": "xbzrle-cache", "default": null, - "type": "404" + "type": "405" }, { "name": "total-time", @@ -5450,12 +5454,12 @@ { "name": "compression", "default": null, - "type": "405" + "type": "406" }, { "name": "socket-address", "default": null, - "type": "[364]" + "type": "[365]" } ], "meta-type": "object" @@ -5480,7 +5484,7 @@ "members": [ { "name": "capability", - "type": "406" + "type": "407" }, { "name": "state", @@ -5555,17 +5559,17 @@ { "name": "tls-creds", "default": null, - "type": "333" + "type": "334" }, { "name": "tls-hostname", "default": null, - "type": "333" + "type": "334" }, { "name": "tls-authz", "default": null, - "type": "333" + "type": "334" }, { "name": "max-bandwidth", @@ -5613,7 +5617,7 @@ { "name": "multifd-compression", "default": null, - "type": "407" + "type": "408" }, { "name": "multifd-zlib-level", @@ -5628,7 +5632,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[408]" + "type": "[409]" } ], "meta-type": "object" @@ -5757,7 +5761,7 @@ { "name": "multifd-compression", "default": null, - "type": "407" + "type": "408" }, { "name": "multifd-zlib-level", @@ -5772,7 +5776,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[408]" + "type": "[409]" } ], "meta-type": "object" @@ -5811,7 +5815,7 @@ "members": [ { "name": "status", - "type": "401" + "type": "402" } ], "meta-type": "object" @@ -5831,11 +5835,11 @@ "members": [ { "name": "mode", - "type": "409" + "type": "410" }, { "name": "reason", - "type": "410" + "type": "411" } ], "meta-type": "object" @@ -5845,7 +5849,7 @@ "members": [ { "name": "state", - "type": "401" + "type": "402" } ], "meta-type": "object" @@ -5964,15 +5968,15 @@ "members": [ { "name": "mode", - "type": "409" + "type": "410" }, { "name": "last-mode", - "type": "409" + "type": "410" }, { "name": "reason", - "type": "410" + "type": "411" } ], "meta-type": "object" @@ -6012,7 +6016,7 @@ { "name": "mode", "default": null, - "type": "411" + "type": "412" } ], "meta-type": "object" @@ -6027,7 +6031,7 @@ }, { "name": "status", - "type": "412" + "type": "413" }, { "name": "start-time", @@ -6043,12 +6047,12 @@ }, { "name": "mode", - "type": "411" + "type": "412" }, { "name": "vcpu-dirty-rate", "default": null, - "type": "[413]" + "type": "[414]" } ], "meta-type": "object" @@ -6169,12 +6173,12 @@ "members": [ { "name": "actions", - "type": "[414]" + "type": "[415]" }, { "name": "properties", "default": null, - "type": "415" + "type": "416" } ], "meta-type": "object" @@ -6208,7 +6212,7 @@ }, { "name": "state", - "type": "416" + "type": "417" }, { "name": "vcpu", @@ -6247,7 +6251,7 @@ { "name": "enable", "default": null, - "type": "[417]" + "type": "[418]" } ], "meta-type": "object" @@ -6257,7 +6261,7 @@ "members": [ { "name": "qemu", - "type": "418" + "type": "419" }, { "name": "package", @@ -6292,31 +6296,31 @@ "variants": [ { "case": "builtin", - "type": "420" + "type": "421" }, { "case": "enum", - "type": "421" + "type": "422" }, { "case": "array", - "type": "422" + "type": "423" }, { "case": "object", - "type": "423" + "type": "424" }, { "case": "alternate", - "type": "424" + "type": "425" }, { "case": "command", - "type": "425" + "type": "426" }, { "case": "event", - "type": "426" + "type": "427" } ], "members": [ @@ -6326,7 +6330,7 @@ }, { "name": "meta-type", - "type": "419" + "type": "420" }, { "name": "features", @@ -6469,164 +6473,168 @@ "variants": [ { "case": "authz-list", - "type": "428" + "type": "429" }, { "case": "authz-listfile", - "type": "429" + "type": "430" }, { "case": "authz-pam", - "type": "430" + "type": "431" }, { "case": "authz-simple", - "type": "431" + "type": "432" }, { "case": "can-host-socketcan", - "type": "432" + "type": "433" }, { "case": "colo-compare", - "type": "433" + "type": "434" }, { "case": "cryptodev-backend", - "type": "434" + "type": "435" }, { "case": "cryptodev-backend-builtin", - "type": "434" + "type": "435" }, { - "case": "cryptodev-vhost-user", + "case": "cryptodev-backend-lkcf", "type": "435" }, { - "case": "dbus-vmstate", + "case": "cryptodev-vhost-user", "type": "436" }, { - "case": "filter-buffer", + "case": "dbus-vmstate", "type": "437" }, { - "case": "filter-dump", + "case": "filter-buffer", "type": "438" }, { - "case": "filter-mirror", + "case": "filter-dump", "type": "439" }, { - "case": "filter-redirector", + "case": "filter-mirror", "type": "440" }, { - "case": "filter-replay", + "case": "filter-redirector", "type": "441" }, { - "case": "filter-rewriter", + "case": "filter-replay", "type": "442" }, { - "case": "input-barrier", + "case": "filter-rewriter", "type": "443" }, { - "case": "input-linux", + "case": "input-barrier", "type": "444" }, { - "case": "iothread", + "case": "input-linux", "type": "445" }, { - "case": "main-loop", + "case": "iothread", "type": "446" }, { - "case": "memory-backend-epc", + "case": "main-loop", "type": "447" }, { - "case": "memory-backend-file", + "case": "memory-backend-epc", "type": "448" }, { - "case": "memory-backend-memfd", + "case": "memory-backend-file", "type": "449" }, { - "case": "memory-backend-ram", + "case": "memory-backend-memfd", "type": "450" }, { - "case": "pr-manager-helper", + "case": "memory-backend-ram", "type": "451" }, { - "case": "qtest", + "case": "pr-manager-helper", "type": "452" }, { - "case": "rng-builtin", + "case": "qtest", "type": "453" }, { - "case": "rng-egd", + "case": "rng-builtin", "type": "454" }, { - "case": "rng-random", + "case": "rng-egd", "type": "455" }, { - "case": "secret", + "case": "rng-random", "type": "456" }, { - "case": "secret_keyring", + "case": "secret", "type": "457" }, { - "case": "sev-guest", + "case": "secret_keyring", "type": "458" }, { - "case": "thread-context", + "case": "sev-guest", "type": "459" }, { - "case": "throttle-group", + "case": "thread-context", "type": "460" }, { - "case": "tls-creds-anon", + "case": "throttle-group", "type": "461" }, { - "case": "tls-creds-psk", + "case": "tls-creds-anon", "type": "462" }, { - "case": "tls-creds-x509", + "case": "tls-creds-psk", "type": "463" }, { - "case": "tls-cipher-suites", + "case": "tls-creds-x509", "type": "464" }, { - "case": "x-remote-object", + "case": "tls-cipher-suites", "type": "465" }, { - "case": "x-vfio-user-server", + "case": "x-remote-object", "type": "466" }, + { + "case": "x-vfio-user-server", + "type": "467" + }, { "case": "can-bus", "type": "0" @@ -6643,7 +6651,7 @@ "members": [ { "name": "qom-type", - "type": "427" + "type": "428" }, { "name": "id", @@ -6743,7 +6751,7 @@ "variants": [ { "case": "s390x", - "type": "469" + "type": "470" }, { "case": "aarch64", @@ -6882,11 +6890,11 @@ { "name": "props", "default": null, - "type": "467" + "type": "468" }, { "name": "target", - "type": "468" + "type": "469" } ], "meta-type": "object" @@ -6957,7 +6965,7 @@ "members": [ { "name": "arch", - "type": "468" + "type": "469" } ], "meta-type": "object" @@ -7081,7 +7089,7 @@ }, { "name": "policy", - "type": "470" + "type": "471" } ], "meta-type": "object" @@ -7104,7 +7112,7 @@ }, { "name": "props", - "type": "467" + "type": "468" }, { "name": "qom-path", @@ -7120,29 +7128,29 @@ "variants": [ { "case": "node", - "type": "472" + "type": "473" }, { "case": "dist", - "type": "473" + "type": "474" }, { "case": "cpu", - "type": "474" + "type": "475" }, { "case": "hmat-lb", - "type": "475" + "type": "476" }, { "case": "hmat-cache", - "type": "476" + "type": "477" } ], "members": [ { "name": "type", - "type": "471" + "type": "472" } ], "meta-type": "object" @@ -7203,29 +7211,29 @@ "variants": [ { "case": "dimm", - "type": "478" + "type": "479" }, { "case": "nvdimm", - "type": "478" + "type": "479" }, { "case": "virtio-pmem", - "type": "479" + "type": "480" }, { "case": "virtio-mem", - "type": "480" + "type": "481" }, { "case": "sgx-epc", - "type": "481" + "type": "482" } ], "members": [ { "name": "type", - "type": "477" + "type": "478" } ], "meta-type": "object" @@ -7288,11 +7296,11 @@ "members": [ { "name": "type", - "type": "484" + "type": "485" }, { "name": "model", - "type": "482" + "type": "483" } ], "meta-type": "object" @@ -7302,7 +7310,7 @@ "members": [ { "name": "model", - "type": "482" + "type": "483" } ], "meta-type": "object" @@ -7354,7 +7362,7 @@ "members": [ { "name": "mode", - "type": "485" + "type": "486" }, { "name": "filename", @@ -7409,11 +7417,11 @@ "variants": [ { "case": "block-node", - "type": "487" + "type": "488" }, { "case": "chardev", - "type": "488" + "type": "489" }, { "case": "migration", @@ -7423,7 +7431,7 @@ "members": [ { "name": "type", - "type": "486" + "type": "487" } ], "meta-type": "object" @@ -7592,7 +7600,7 @@ }, { "name": "fds", - "type": "[489]" + "type": "[490]" } ], "meta-type": "object" @@ -7622,7 +7630,7 @@ }, { "name": "parameters", - "type": "[490]" + "type": "[491]" } ], "meta-type": "object" @@ -7688,7 +7696,7 @@ }, { "name": "state", - "type": "491" + "type": "492" }, { "name": "handle", @@ -7800,7 +7808,7 @@ }, { "name": "sections", - "type": "[492]" + "type": "[493]" } ], "meta-type": "object" @@ -7824,7 +7832,7 @@ }, { "name": "slot-type", - "type": "493" + "type": "494" }, { "name": "source", @@ -7861,7 +7869,7 @@ }, { "name": "devices", - "type": "[494]" + "type": "[495]" } ], "meta-type": "object" @@ -7872,7 +7880,7 @@ "variants": [ { "case": "vcpu", - "type": "497" + "type": "498" }, { "case": "vm", @@ -7882,12 +7890,12 @@ "members": [ { "name": "target", - "type": "495" + "type": "496" }, { "name": "providers", "default": null, - "type": "[496]" + "type": "[497]" } ], "meta-type": "object" @@ -7902,7 +7910,7 @@ "members": [ { "name": "provider", - "type": "498" + "type": "499" }, { "name": "qom-path", @@ -7911,7 +7919,7 @@ }, { "name": "stats", - "type": "[499]" + "type": "[500]" } ], "meta-type": "object" @@ -7922,7 +7930,7 @@ { "name": "provider", "default": null, - "type": "498" + "type": "499" } ], "meta-type": "object" @@ -7937,15 +7945,15 @@ "members": [ { "name": "provider", - "type": "498" + "type": "499" }, { "name": "target", - "type": "495" + "type": "496" }, { "name": "stats", - "type": "[500]" + "type": "[501]" } ], "meta-type": "object" @@ -8000,15 +8008,15 @@ }, { "name": "guest-features", - "type": "501" + "type": "502" }, { "name": "host-features", - "type": "501" + "type": "502" }, { "name": "backend-features", - "type": "501" + "type": "502" }, { "name": "num-vqs", @@ -8016,7 +8024,7 @@ }, { "name": "status", - "type": "502" + "type": "503" }, { "name": "isr", @@ -8065,7 +8073,7 @@ { "name": "vhost-dev", "default": null, - "type": "503" + "type": "504" } ], "meta-type": "object" @@ -8252,15 +8260,15 @@ }, { "name": "descs", - "type": "[504]" + "type": "[505]" }, { "name": "avail", - "type": "505" + "type": "506" }, { "name": "used", - "type": "506" + "type": "507" } ], "meta-type": "object" @@ -8512,17 +8520,17 @@ "variants": [ { "case": "hyper-v", - "type": "508" + "type": "509" }, { "case": "s390", - "type": "509" + "type": "510" } ], "members": [ { "name": "type", - "type": "507" + "type": "508" } ], "meta-type": "object" @@ -8741,22 +8749,22 @@ }, { "name": "timed_stats", - "type": "[510]" + "type": "[511]" }, { "name": "rd_latency_histogram", "default": null, - "type": "511" + "type": "512" }, { "name": "wr_latency_histogram", "default": null, - "type": "511" + "type": "512" }, { "name": "flush_latency_histogram", "default": null, - "type": "511" + "type": "512" } ], "meta-type": "object" @@ -8767,15 +8775,15 @@ "variants": [ { "case": "file", - "type": "512" + "type": "513" }, { "case": "host_device", - "type": "512" + "type": "513" }, { "case": "nvme", - "type": "513" + "type": "514" }, { "case": "blkdebug", @@ -8929,6 +8937,10 @@ "case": "vhdx", "type": "0" }, + { + "case": "virtio-blk-vfio-pci", + "type": "0" + }, { "case": "virtio-blk-vhost-user", "type": "0" @@ -9211,7 +9223,7 @@ { "name": "format-specific", "default": null, - "type": "514" + "type": "515" } ], "meta-type": "object" @@ -9289,7 +9301,7 @@ }, { "name": "type", - "type": "515" + "type": "516" }, { "name": "name", @@ -9320,11 +9332,11 @@ }, { "name": "perm", - "type": "[516]" + "type": "[517]" }, { "name": "shared-perm", - "type": "[516]" + "type": "[517]" } ], "meta-type": "object" @@ -9488,6 +9500,9 @@ { "name": "vhdx" }, + { + "name": "virtio-blk-vfio-pci" + }, { "name": "virtio-blk-vhost-user" }, @@ -9547,6 +9562,7 @@ "throttle", "vdi", "vhdx", + "virtio-blk-vfio-pci", "virtio-blk-vhost-user", "virtio-blk-vhost-vdpa", "vmdk", @@ -9591,7 +9607,7 @@ "members": [ { "name": "image", - "type": "517" + "type": "518" }, { "name": "config", @@ -9631,22 +9647,22 @@ { "name": "inject-error", "default": null, - "type": "[518]" + "type": "[519]" }, { "name": "set-state", "default": null, - "type": "[519]" + "type": "[520]" }, { "name": "take-child-perms", "default": null, - "type": "[516]" + "type": "[517]" }, { "name": "unshare-child-perms", "default": null, - "type": "[516]" + "type": "[517]" } ], "meta-type": "object" @@ -9656,11 +9672,11 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "log", - "type": "517" + "type": "518" }, { "name": "log-sector-size", @@ -9685,11 +9701,11 @@ "members": [ { "name": "test", - "type": "517" + "type": "518" }, { "name": "raw", - "type": "517" + "type": "518" } ], "meta-type": "object" @@ -9699,7 +9715,7 @@ "members": [ { "name": "image", - "type": "517" + "type": "518" } ], "meta-type": "object" @@ -9709,7 +9725,7 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" } ], "meta-type": "object" @@ -9719,11 +9735,11 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "target", - "type": "517" + "type": "518" }, { "name": "bitmap", @@ -9733,7 +9749,7 @@ { "name": "on-cbw-error", "default": null, - "type": "520" + "type": "521" }, { "name": "cbw-timeout", @@ -9748,7 +9764,7 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "bottom", @@ -9773,12 +9789,12 @@ { "name": "locking", "default": null, - "type": "521" + "type": "522" }, { "name": "aio", "default": null, - "type": "522" + "type": "523" }, { "name": "aio-max-batch", @@ -9902,7 +9918,7 @@ }, { "name": "server", - "type": "[364]" + "type": "[365]" }, { "name": "debug", @@ -10037,7 +10053,7 @@ "members": [ { "name": "transport", - "type": "523" + "type": "524" }, { "name": "portal", @@ -10070,7 +10086,7 @@ { "name": "header-digest", "default": null, - "type": "524" + "type": "525" }, { "name": "timeout", @@ -10085,7 +10101,7 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "key-secret", @@ -10100,7 +10116,7 @@ "members": [ { "name": "server", - "type": "364" + "type": "365" }, { "name": "export", @@ -10143,7 +10159,7 @@ "members": [ { "name": "server", - "type": "525" + "type": "526" }, { "name": "path", @@ -10221,7 +10237,7 @@ "name": "314", "members": [ { - "name": "filename", + "name": "path", "type": "str" } ], @@ -10232,7 +10248,7 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "prealloc-align", @@ -10252,12 +10268,12 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "backing", "default": null, - "type": "526" + "type": "527" }, { "name": "lazy-refcounts", @@ -10282,7 +10298,7 @@ { "name": "overlap-check", "default": null, - "type": "527" + "type": "528" }, { "name": "cache-size", @@ -10312,12 +10328,12 @@ { "name": "encrypt", "default": null, - "type": "528" + "type": "529" }, { "name": "data-file", "default": null, - "type": "517" + "type": "518" } ], "meta-type": "object" @@ -10327,17 +10343,17 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "backing", "default": null, - "type": "526" + "type": "527" }, { "name": "encrypt", "default": null, - "type": "529" + "type": "530" } ], "meta-type": "object" @@ -10347,12 +10363,12 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "backing", "default": null, - "type": "526" + "type": "527" } ], "meta-type": "object" @@ -10367,7 +10383,7 @@ }, { "name": "children", - "type": "[517]" + "type": "[518]" }, { "name": "vote-threshold", @@ -10381,7 +10397,7 @@ { "name": "read-pattern", "default": null, - "type": "530" + "type": "531" } ], "meta-type": "object" @@ -10391,7 +10407,7 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "offset", @@ -10435,7 +10451,7 @@ { "name": "encrypt", "default": null, - "type": "531" + "type": "532" }, { "name": "user", @@ -10445,7 +10461,7 @@ { "name": "auth-client-required", "default": null, - "type": "[532]" + "type": "[533]" }, { "name": "key-secret", @@ -10455,7 +10471,7 @@ { "name": "server", "default": null, - "type": "[533]" + "type": "[534]" } ], "meta-type": "object" @@ -10465,11 +10481,11 @@ "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "mode", - "type": "534" + "type": "535" }, { "name": "top-id", @@ -10484,7 +10500,7 @@ "members": [ { "name": "server", - "type": "535" + "type": "536" }, { "name": "path", @@ -10498,7 +10514,7 @@ { "name": "host-key-check", "default": null, - "type": "536" + "type": "537" } ], "meta-type": "object" @@ -10512,7 +10528,7 @@ }, { "name": "file", - "type": "517" + "type": "518" } ], "meta-type": "object" @@ -10539,6 +10555,16 @@ }, { "name": "327", + "members": [ + { + "name": "path", + "type": "str" + } + ], + "meta-type": "object" + }, + { + "name": "328", "members": [ { "name": "dir", @@ -10573,64 +10599,64 @@ "meta-type": "array" }, { - "name": "328", + "name": "329", "tag": "driver", "variants": [ { "case": "file", - "type": "537" + "type": "538" }, { "case": "gluster", - "type": "538" + "type": "539" }, { "case": "luks", - "type": "539" + "type": "540" }, { "case": "nfs", - "type": "540" + "type": "541" }, { "case": "parallels", - "type": "541" + "type": "542" }, { "case": "qcow", - "type": "542" + "type": "543" }, { "case": "qcow2", - "type": "543" + "type": "544" }, { "case": "qed", - "type": "544" + "type": "545" }, { "case": "rbd", - "type": "545" + "type": "546" }, { "case": "ssh", - "type": "546" + "type": "547" }, { "case": "vdi", - "type": "547" + "type": "548" }, { "case": "vhdx", - "type": "548" + "type": "549" }, { "case": "vmdk", - "type": "549" + "type": "550" }, { "case": "vpc", - "type": "550" + "type": "551" }, { "case": "blkdebug", @@ -10748,6 +10774,10 @@ "case": "throttle", "type": "0" }, + { + "case": "virtio-blk-vfio-pci", + "type": "0" + }, { "case": "virtio-blk-vhost-user", "type": "0" @@ -10770,16 +10800,16 @@ "meta-type": "object" }, { - "name": "329", + "name": "330", "tag": "driver", "variants": [ { "case": "luks", - "type": "551" + "type": "552" }, { "case": "qcow2", - "type": "552" + "type": "553" }, { "case": "blkdebug", @@ -10937,6 +10967,10 @@ "case": "vhdx", "type": "0" }, + { + "case": "virtio-blk-vfio-pci", + "type": "0" + }, { "case": "virtio-blk-vhost-user", "type": "0" @@ -10967,7 +11001,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "331", "members": [ { "name": "read" @@ -10983,7 +11017,7 @@ ] }, { - "name": "331", + "name": "332", "members": [ { "name": "ignore" @@ -11003,7 +11037,7 @@ ] }, { - "name": "332", + "name": "333", "members": [ { "name": "commit" @@ -11047,7 +11081,7 @@ ] }, { - "name": "333", + "name": "334", "members": [ { "type": "str" @@ -11059,7 +11093,7 @@ "meta-type": "alternate" }, { - "name": "334", + "name": "335", "members": [ { "name": "read" @@ -11079,36 +11113,36 @@ ] }, { - "name": "335", + "name": "336", "tag": "type", "variants": [ { "case": "inet", - "type": "554" + "type": "555" }, { "case": "unix", - "type": "555" + "type": "556" }, { "case": "vsock", - "type": "556" + "type": "557" }, { "case": "fd", - "type": "557" + "type": "558" } ], "members": [ { "name": "type", - "type": "553" + "type": "554" } ], "meta-type": "object" }, { - "name": "336", + "name": "337", "members": [ { "name": "safe" @@ -11124,7 +11158,7 @@ ] }, { - "name": "337", + "name": "338", "members": [ { "name": "nbd" @@ -11148,7 +11182,7 @@ ] }, { - "name": "338", + "name": "339", "members": [ { "name": "name", @@ -11174,11 +11208,11 @@ "meta-type": "object" }, { - "name": "339", + "name": "340", "members": [ { "name": "addr", - "type": "364" + "type": "365" }, { "name": "logical-block-size", @@ -11194,7 +11228,7 @@ "meta-type": "object" }, { - "name": "340", + "name": "341", "members": [ { "name": "mountpoint", @@ -11208,13 +11242,13 @@ { "name": "allow-other", "default": null, - "type": "558" + "type": "559" } ], "meta-type": "object" }, { - "name": "341", + "name": "342", "members": [ { "name": "name", @@ -11244,7 +11278,7 @@ "meta-type": "object" }, { - "name": "342", + "name": "343", "members": [ { "name": "utf8" @@ -11260,108 +11294,108 @@ ] }, { - "name": "343", + "name": "344", "tag": "type", "variants": [ { "case": "file", - "type": "560" + "type": "561" }, { "case": "serial", - "type": "561" + "type": "562" }, { "case": "parallel", - "type": "561" + "type": "562" }, { "case": "pipe", - "type": "561" + "type": "562" }, { "case": "socket", - "type": "562" + "type": "563" }, { "case": "udp", - "type": "563" + "type": "564" }, { "case": "pty", - "type": "564" + "type": "565" }, { "case": "null", - "type": "564" + "type": "565" }, { "case": "mux", - "type": "565" + "type": "566" }, { "case": "msmouse", - "type": "564" + "type": "565" }, { "case": "wctablet", - "type": "564" + "type": "565" }, { "case": "braille", - "type": "564" + "type": "565" }, { "case": "testdev", - "type": "564" + "type": "565" }, { "case": "stdio", - "type": "566" + "type": "567" }, { "case": "console", - "type": "564" + "type": "565" }, { "case": "spicevmc", - "type": "567" + "type": "568" }, { "case": "spiceport", - "type": "568" + "type": "569" }, { "case": "qemu-vdagent", - "type": "569" + "type": "570" }, { "case": "dbus", - "type": "570" + "type": "571" }, { "case": "vc", - "type": "571" + "type": "572" }, { "case": "ringbuf", - "type": "572" + "type": "573" }, { "case": "memory", - "type": "572" + "type": "573" } ], "members": [ { "name": "type", - "type": "559" + "type": "560" } ], "meta-type": "object" }, { - "name": "344", + "name": "345", "members": [ { "name": "elf" @@ -11389,7 +11423,7 @@ ] }, { - "name": "345", + "name": "346", "members": [ { "name": "none" @@ -11413,12 +11447,12 @@ ] }, { - "name": "[344]", - "element-type": "344", + "name": "[345]", + "element-type": "345", "meta-type": "array" }, { - "name": "346", + "name": "347", "members": [ { "name": "none" @@ -11482,7 +11516,7 @@ ] }, { - "name": "347", + "name": "348", "members": [ { "name": "netdev", @@ -11513,7 +11547,7 @@ "meta-type": "object" }, { - "name": "348", + "name": "349", "members": [ { "name": "hostname", @@ -11573,7 +11607,7 @@ { "name": "dnssearch", "default": null, - "type": "[573]" + "type": "[574]" }, { "name": "domainname", @@ -11613,12 +11647,12 @@ { "name": "hostfwd", "default": null, - "type": "[573]" + "type": "[574]" }, { "name": "guestfwd", "default": null, - "type": "[573]" + "type": "[574]" }, { "name": "tftp-server-name", @@ -11629,7 +11663,7 @@ "meta-type": "object" }, { - "name": "349", + "name": "350", "members": [ { "name": "ifname", @@ -11710,7 +11744,7 @@ "meta-type": "object" }, { - "name": "350", + "name": "351", "members": [ { "name": "src", @@ -11783,7 +11817,7 @@ "meta-type": "object" }, { - "name": "351", + "name": "352", "members": [ { "name": "fd", @@ -11819,11 +11853,11 @@ "meta-type": "object" }, { - "name": "352", + "name": "353", "members": [ { "name": "addr", - "type": "364" + "type": "365" }, { "name": "server", @@ -11834,23 +11868,23 @@ "meta-type": "object" }, { - "name": "353", + "name": "354", "members": [ { "name": "local", "default": null, - "type": "364" + "type": "365" }, { "name": "remote", "default": null, - "type": "364" + "type": "365" } ], "meta-type": "object" }, { - "name": "354", + "name": "355", "members": [ { "name": "sock", @@ -11876,7 +11910,7 @@ "meta-type": "object" }, { - "name": "355", + "name": "356", "members": [ { "name": "br", @@ -11892,7 +11926,7 @@ "meta-type": "object" }, { - "name": "356", + "name": "357", "members": [ { "name": "hubid", @@ -11907,7 +11941,7 @@ "meta-type": "object" }, { - "name": "357", + "name": "358", "members": [ { "name": "ifname", @@ -11922,7 +11956,7 @@ "meta-type": "object" }, { - "name": "358", + "name": "359", "members": [ { "name": "chardev", @@ -11942,7 +11976,7 @@ "meta-type": "object" }, { - "name": "359", + "name": "360", "members": [ { "name": "vhostdev", @@ -11971,7 +12005,7 @@ "meta-type": "object" }, { - "name": "363", + "name": "364", "members": [ { "name": "normal" @@ -11996,36 +12030,36 @@ "meta-type": "array" }, { - "name": "364", + "name": "365", "tag": "type", "variants": [ { "case": "inet", - "type": "535" + "type": "536" }, { "case": "unix", - "type": "574" + "type": "575" }, { "case": "vsock", - "type": "575" + "type": "576" }, { "case": "fd", - "type": "573" + "type": "574" } ], "members": [ { "name": "type", - "type": "553" + "type": "554" } ], "meta-type": "object" }, { - "name": "365", + "name": "366", "members": [ { "name": "half" @@ -12041,7 +12075,7 @@ ] }, { - "name": "366", + "name": "367", "members": [ { "name": "off" @@ -12057,7 +12091,7 @@ ] }, { - "name": "367", + "name": "368", "members": [ { "name": "priority", @@ -12116,7 +12150,7 @@ "meta-type": "object" }, { - "name": "368", + "name": "369", "members": [ { "name": "in-pport", @@ -12157,7 +12191,7 @@ "meta-type": "object" }, { - "name": "369", + "name": "370", "members": [ { "name": "goto-tbl", @@ -12193,16 +12227,16 @@ "meta-type": "object" }, { - "name": "370", + "name": "371", "tag": "type", "variants": [ { "case": "passthrough", - "type": "576" + "type": "577" }, { "case": "emulator", - "type": "577" + "type": "578" } ], "members": [ @@ -12214,7 +12248,7 @@ "meta-type": "object" }, { - "name": "371", + "name": "372", "members": [ { "name": "vnc" @@ -12230,7 +12264,7 @@ ] }, { - "name": "372", + "name": "373", "members": [ { "name": "keep" @@ -12250,7 +12284,7 @@ ] }, { - "name": "373", + "name": "374", "members": [ { "name": "display", @@ -12261,7 +12295,7 @@ "meta-type": "object" }, { - "name": "374", + "name": "375", "members": [ { "name": "display", @@ -12272,7 +12306,7 @@ "meta-type": "object" }, { - "name": "375", + "name": "376", "members": [ { "name": "ppm" @@ -12288,7 +12322,7 @@ ] }, { - "name": "376", + "name": "377", "members": [ { "name": "client" @@ -12308,12 +12342,12 @@ ] }, { - "name": "[377]", - "element-type": "377", + "name": "[378]", + "element-type": "378", "meta-type": "array" }, { - "name": "377", + "name": "378", "members": [ { "name": "host", @@ -12325,7 +12359,7 @@ }, { "name": "family", - "type": "380" + "type": "381" }, { "name": "connection-id", @@ -12347,7 +12381,7 @@ "meta-type": "object" }, { - "name": "378", + "name": "379", "members": [ { "name": "host", @@ -12359,13 +12393,13 @@ }, { "name": "family", - "type": "380" + "type": "381" } ], "meta-type": "object" }, { - "name": "379", + "name": "380", "members": [ { "name": "host", @@ -12377,7 +12411,7 @@ }, { "name": "family", - "type": "380" + "type": "381" }, { "name": "auth", @@ -12388,7 +12422,7 @@ "meta-type": "object" }, { - "name": "380", + "name": "381", "members": [ { "name": "ipv4" @@ -12416,12 +12450,12 @@ ] }, { - "name": "[381]", - "element-type": "381", + "name": "[382]", + "element-type": "382", "meta-type": "array" }, { - "name": "381", + "name": "382", "members": [ { "name": "host", @@ -12433,7 +12467,7 @@ }, { "name": "family", - "type": "380" + "type": "381" }, { "name": "websocket", @@ -12453,12 +12487,12 @@ "meta-type": "object" }, { - "name": "[382]", - "element-type": "382", + "name": "[383]", + "element-type": "383", "meta-type": "array" }, { - "name": "382", + "name": "383", "members": [ { "name": "host", @@ -12470,7 +12504,7 @@ }, { "name": "family", - "type": "380" + "type": "381" }, { "name": "websocket", @@ -12478,18 +12512,18 @@ }, { "name": "auth", - "type": "383" + "type": "384" }, { "name": "vencrypt", "default": null, - "type": "384" + "type": "385" } ], "meta-type": "object" }, { - "name": "383", + "name": "384", "members": [ { "name": "none" @@ -12533,7 +12567,7 @@ ] }, { - "name": "384", + "name": "385", "members": [ { "name": "plain" @@ -12577,7 +12611,7 @@ ] }, { - "name": "385", + "name": "386", "members": [ { "name": "host", @@ -12589,7 +12623,7 @@ }, { "name": "family", - "type": "380" + "type": "381" }, { "name": "websocket", @@ -12604,7 +12638,7 @@ "meta-type": "object" }, { - "name": "386", + "name": "387", "members": [ { "name": "host", @@ -12616,7 +12650,7 @@ }, { "name": "family", - "type": "380" + "type": "381" }, { "name": "websocket", @@ -12626,67 +12660,67 @@ "meta-type": "object" }, { - "name": "[387]", - "element-type": "387", + "name": "[388]", + "element-type": "388", "meta-type": "array" }, { - "name": "387", + "name": "388", "tag": "type", "variants": [ { "case": "number", - "type": "579" + "type": "580" }, { "case": "qcode", - "type": "580" + "type": "581" } ], "members": [ { "name": "type", - "type": "578" + "type": "579" } ], "meta-type": "object" }, { - "name": "[388]", - "element-type": "388", + "name": "[389]", + "element-type": "389", "meta-type": "array" }, { - "name": "388", + "name": "389", "tag": "type", "variants": [ { "case": "key", - "type": "582" + "type": "583" }, { "case": "btn", - "type": "583" + "type": "584" }, { "case": "rel", - "type": "584" + "type": "585" }, { "case": "abs", - "type": "584" + "type": "585" } ], "members": [ { "name": "type", - "type": "581" + "type": "582" } ], "meta-type": "object" }, { - "name": "389", + "name": "390", "members": [ { "name": "default" @@ -12722,7 +12756,7 @@ ] }, { - "name": "390", + "name": "391", "members": [ { "name": "off" @@ -12746,7 +12780,7 @@ ] }, { - "name": "391", + "name": "392", "members": [ { "name": "grab-on-hover", @@ -12772,7 +12806,7 @@ "meta-type": "object" }, { - "name": "392", + "name": "393", "members": [ { "name": "left-command-key", @@ -12793,7 +12827,7 @@ "meta-type": "object" }, { - "name": "393", + "name": "394", "members": [ { "name": "charset", @@ -12804,7 +12838,7 @@ "meta-type": "object" }, { - "name": "394", + "name": "395", "members": [ { "name": "rendernode", @@ -12815,7 +12849,7 @@ "meta-type": "object" }, { - "name": "395", + "name": "396", "members": [ { "name": "rendernode", @@ -12841,18 +12875,18 @@ "meta-type": "object" }, { - "name": "396", + "name": "397", "members": [ { "name": "grab-mod", "default": null, - "type": "585" + "type": "586" } ], "meta-type": "object" }, { - "name": "397", + "name": "398", "members": [ { "name": "vnc" @@ -12864,7 +12898,7 @@ ] }, { - "name": "398", + "name": "399", "members": [ { "name": "tls-certs", @@ -12875,7 +12909,7 @@ "meta-type": "object" }, { - "name": "399", + "name": "400", "members": [ { "name": "vnc" @@ -12887,18 +12921,18 @@ ] }, { - "name": "400", + "name": "401", "members": [ { "name": "addresses", "default": null, - "type": "[364]" + "type": "[365]" } ], "meta-type": "object" }, { - "name": "401", + "name": "402", "members": [ { "name": "none" @@ -12962,7 +12996,7 @@ ] }, { - "name": "402", + "name": "403", "members": [ { "name": "transferred", @@ -13040,7 +13074,7 @@ "meta-type": "object" }, { - "name": "403", + "name": "404", "members": [ { "name": "transferred", @@ -13050,7 +13084,7 @@ "meta-type": "object" }, { - "name": "404", + "name": "405", "members": [ { "name": "cache-size", @@ -13084,7 +13118,7 @@ "meta-type": "object" }, { - "name": "405", + "name": "406", "members": [ { "name": "pages", @@ -13110,12 +13144,12 @@ "meta-type": "object" }, { - "name": "[364]", - "element-type": "364", + "name": "[365]", + "element-type": "365", "meta-type": "array" }, { - "name": "406", + "name": "407", "members": [ { "name": "xbzrle" @@ -13213,7 +13247,7 @@ ] }, { - "name": "407", + "name": "408", "members": [ { "name": "none" @@ -13233,12 +13267,12 @@ ] }, { - "name": "[408]", - "element-type": "408", + "name": "[409]", + "element-type": "409", "meta-type": "array" }, { - "name": "408", + "name": "409", "members": [ { "name": "node-name", @@ -13250,13 +13284,13 @@ }, { "name": "bitmaps", - "type": "[586]" + "type": "[587]" } ], "meta-type": "object" }, { - "name": "409", + "name": "410", "members": [ { "name": "none" @@ -13276,7 +13310,7 @@ ] }, { - "name": "410", + "name": "411", "members": [ { "name": "none" @@ -13300,7 +13334,7 @@ ] }, { - "name": "411", + "name": "412", "members": [ { "name": "page-sampling" @@ -13320,7 +13354,7 @@ ] }, { - "name": "412", + "name": "413", "members": [ { "name": "unstarted" @@ -13340,12 +13374,12 @@ ] }, { - "name": "[413]", - "element-type": "413", + "name": "[414]", + "element-type": "414", "meta-type": "array" }, { - "name": "413", + "name": "414", "members": [ { "name": "id", @@ -13359,84 +13393,84 @@ "meta-type": "object" }, { - "name": "[414]", - "element-type": "414", + "name": "[415]", + "element-type": "415", "meta-type": "array" }, { - "name": "414", + "name": "415", "tag": "type", "variants": [ { "case": "abort", - "type": "588" + "type": "589" }, { "case": "block-dirty-bitmap-add", - "type": "589" + "type": "590" }, { "case": "block-dirty-bitmap-remove", - "type": "590" + "type": "591" }, { "case": "block-dirty-bitmap-clear", - "type": "590" + "type": "591" }, { "case": "block-dirty-bitmap-enable", - "type": "590" + "type": "591" }, { "case": "block-dirty-bitmap-disable", - "type": "590" + "type": "591" }, { "case": "block-dirty-bitmap-merge", - "type": "591" + "type": "592" }, { "case": "blockdev-backup", - "type": "592" + "type": "593" }, { "case": "blockdev-snapshot", - "type": "593" + "type": "594" }, { "case": "blockdev-snapshot-internal-sync", - "type": "594" + "type": "595" }, { "case": "blockdev-snapshot-sync", - "type": "595" + "type": "596" }, { "case": "drive-backup", - "type": "596" + "type": "597" } ], "members": [ { "name": "type", - "type": "587" + "type": "588" } ], "meta-type": "object" }, { - "name": "415", + "name": "416", "members": [ { "name": "completion-mode", "default": null, - "type": "597" + "type": "598" } ], "meta-type": "object" }, { - "name": "416", + "name": "417", "members": [ { "name": "unavailable" @@ -13456,12 +13490,12 @@ ] }, { - "name": "[417]", - "element-type": "417", + "name": "[418]", + "element-type": "418", "meta-type": "array" }, { - "name": "417", + "name": "418", "members": [ { "name": "oob" @@ -13473,7 +13507,7 @@ ] }, { - "name": "418", + "name": "419", "members": [ { "name": "major", @@ -13491,7 +13525,7 @@ "meta-type": "object" }, { - "name": "419", + "name": "420", "members": [ { "name": "builtin" @@ -13527,21 +13561,21 @@ ] }, { - "name": "420", + "name": "421", "members": [ { "name": "json-type", - "type": "598" + "type": "599" } ], "meta-type": "object" }, { - "name": "421", + "name": "422", "members": [ { "name": "members", - "type": "[599]" + "type": "[600]" }, { "name": "values", @@ -13554,7 +13588,7 @@ "meta-type": "object" }, { - "name": "422", + "name": "423", "members": [ { "name": "element-type", @@ -13564,11 +13598,11 @@ "meta-type": "object" }, { - "name": "423", + "name": "424", "members": [ { "name": "members", - "type": "[600]" + "type": "[601]" }, { "name": "tag", @@ -13578,23 +13612,23 @@ { "name": "variants", "default": null, - "type": "[601]" + "type": "[602]" } ], "meta-type": "object" }, { - "name": "424", + "name": "425", "members": [ { "name": "members", - "type": "[602]" + "type": "[603]" } ], "meta-type": "object" }, { - "name": "425", + "name": "426", "members": [ { "name": "arg-type", @@ -13613,7 +13647,7 @@ "meta-type": "object" }, { - "name": "426", + "name": "427", "members": [ { "name": "arg-type", @@ -13623,7 +13657,7 @@ "meta-type": "object" }, { - "name": "427", + "name": "428", "members": [ { "name": "authz-list" @@ -13652,6 +13686,9 @@ { "name": "cryptodev-backend-builtin" }, + { + "name": "cryptodev-backend-lkcf" + }, { "name": "cryptodev-vhost-user" }, @@ -13772,6 +13809,7 @@ "colo-compare", "cryptodev-backend", "cryptodev-backend-builtin", + "cryptodev-backend-lkcf", "cryptodev-vhost-user", "dbus-vmstate", "filter-buffer", @@ -13809,23 +13847,23 @@ ] }, { - "name": "428", + "name": "429", "members": [ { "name": "policy", "default": null, - "type": "603" + "type": "604" }, { "name": "rules", "default": null, - "type": "[604]" + "type": "[605]" } ], "meta-type": "object" }, { - "name": "429", + "name": "430", "members": [ { "name": "filename", @@ -13840,7 +13878,7 @@ "meta-type": "object" }, { - "name": "430", + "name": "431", "members": [ { "name": "service", @@ -13850,7 +13888,7 @@ "meta-type": "object" }, { - "name": "431", + "name": "432", "members": [ { "name": "identity", @@ -13860,7 +13898,7 @@ "meta-type": "object" }, { - "name": "432", + "name": "433", "members": [ { "name": "if", @@ -13874,7 +13912,7 @@ "meta-type": "object" }, { - "name": "433", + "name": "434", "members": [ { "name": "primary_in", @@ -13921,7 +13959,7 @@ "meta-type": "object" }, { - "name": "434", + "name": "435", "members": [ { "name": "queues", @@ -13932,7 +13970,7 @@ "meta-type": "object" }, { - "name": "435", + "name": "436", "members": [ { "name": "queues", @@ -13947,7 +13985,7 @@ "meta-type": "object" }, { - "name": "436", + "name": "437", "members": [ { "name": "addr", @@ -13962,7 +14000,7 @@ "meta-type": "object" }, { - "name": "437", + "name": "438", "members": [ { "name": "netdev", @@ -13971,7 +14009,7 @@ { "name": "queue", "default": null, - "type": "605" + "type": "606" }, { "name": "status", @@ -13986,7 +14024,7 @@ { "name": "insert", "default": null, - "type": "606" + "type": "607" }, { "name": "interval", @@ -13996,7 +14034,7 @@ "meta-type": "object" }, { - "name": "438", + "name": "439", "members": [ { "name": "netdev", @@ -14005,7 +14043,7 @@ { "name": "queue", "default": null, - "type": "605" + "type": "606" }, { "name": "status", @@ -14020,7 +14058,7 @@ { "name": "insert", "default": null, - "type": "606" + "type": "607" }, { "name": "file", @@ -14035,7 +14073,7 @@ "meta-type": "object" }, { - "name": "439", + "name": "440", "members": [ { "name": "netdev", @@ -14044,7 +14082,7 @@ { "name": "queue", "default": null, - "type": "605" + "type": "606" }, { "name": "status", @@ -14059,7 +14097,7 @@ { "name": "insert", "default": null, - "type": "606" + "type": "607" }, { "name": "outdev", @@ -14074,7 +14112,7 @@ "meta-type": "object" }, { - "name": "440", + "name": "441", "members": [ { "name": "netdev", @@ -14083,7 +14121,7 @@ { "name": "queue", "default": null, - "type": "605" + "type": "606" }, { "name": "status", @@ -14098,7 +14136,7 @@ { "name": "insert", "default": null, - "type": "606" + "type": "607" }, { "name": "indev", @@ -14119,7 +14157,7 @@ "meta-type": "object" }, { - "name": "441", + "name": "442", "members": [ { "name": "netdev", @@ -14128,7 +14166,7 @@ { "name": "queue", "default": null, - "type": "605" + "type": "606" }, { "name": "status", @@ -14143,13 +14181,13 @@ { "name": "insert", "default": null, - "type": "606" + "type": "607" } ], "meta-type": "object" }, { - "name": "442", + "name": "443", "members": [ { "name": "netdev", @@ -14158,7 +14196,7 @@ { "name": "queue", "default": null, - "type": "605" + "type": "606" }, { "name": "status", @@ -14173,7 +14211,7 @@ { "name": "insert", "default": null, - "type": "606" + "type": "607" }, { "name": "vnet_hdr_support", @@ -14184,7 +14222,7 @@ "meta-type": "object" }, { - "name": "443", + "name": "444", "members": [ { "name": "name", @@ -14224,7 +14262,7 @@ "meta-type": "object" }, { - "name": "444", + "name": "445", "members": [ { "name": "evdev", @@ -14243,13 +14281,13 @@ { "name": "grab-toggle", "default": null, - "type": "607" + "type": "608" } ], "meta-type": "object" }, { - "name": "445", + "name": "446", "members": [ { "name": "aio-max-batch", @@ -14285,7 +14323,7 @@ "meta-type": "object" }, { - "name": "446", + "name": "447", "members": [ { "name": "aio-max-batch", @@ -14306,7 +14344,7 @@ "meta-type": "object" }, { - "name": "447", + "name": "448", "members": [ { "name": "dump", @@ -14326,7 +14364,7 @@ { "name": "policy", "default": null, - "type": "470" + "type": "471" }, { "name": "prealloc", @@ -14366,7 +14404,7 @@ "meta-type": "object" }, { - "name": "448", + "name": "449", "members": [ { "name": "dump", @@ -14386,7 +14424,7 @@ { "name": "policy", "default": null, - "type": "470" + "type": "471" }, { "name": "prealloc", @@ -14450,7 +14488,7 @@ "meta-type": "object" }, { - "name": "449", + "name": "450", "members": [ { "name": "dump", @@ -14470,7 +14508,7 @@ { "name": "policy", "default": null, - "type": "470" + "type": "471" }, { "name": "prealloc", @@ -14525,7 +14563,7 @@ "meta-type": "object" }, { - "name": "450", + "name": "451", "members": [ { "name": "dump", @@ -14545,7 +14583,7 @@ { "name": "policy", "default": null, - "type": "470" + "type": "471" }, { "name": "prealloc", @@ -14585,7 +14623,7 @@ "meta-type": "object" }, { - "name": "451", + "name": "452", "members": [ { "name": "path", @@ -14595,7 +14633,7 @@ "meta-type": "object" }, { - "name": "452", + "name": "453", "members": [ { "name": "chardev", @@ -14610,7 +14648,7 @@ "meta-type": "object" }, { - "name": "453", + "name": "454", "members": [ { "name": "opened", @@ -14624,7 +14662,7 @@ "meta-type": "object" }, { - "name": "454", + "name": "455", "members": [ { "name": "opened", @@ -14642,7 +14680,7 @@ "meta-type": "object" }, { - "name": "455", + "name": "456", "members": [ { "name": "opened", @@ -14661,7 +14699,7 @@ "meta-type": "object" }, { - "name": "456", + "name": "457", "members": [ { "name": "loaded", @@ -14674,7 +14712,7 @@ { "name": "format", "default": null, - "type": "608" + "type": "609" }, { "name": "keyid", @@ -14700,7 +14738,7 @@ "meta-type": "object" }, { - "name": "457", + "name": "458", "members": [ { "name": "loaded", @@ -14713,7 +14751,7 @@ { "name": "format", "default": null, - "type": "608" + "type": "609" }, { "name": "keyid", @@ -14733,7 +14771,7 @@ "meta-type": "object" }, { - "name": "458", + "name": "459", "members": [ { "name": "sev-device", @@ -14778,7 +14816,7 @@ "meta-type": "object" }, { - "name": "459", + "name": "460", "members": [ { "name": "cpu-affinity", @@ -14794,12 +14832,12 @@ "meta-type": "object" }, { - "name": "460", + "name": "461", "members": [ { "name": "limits", "default": null, - "type": "609" + "type": "610" }, { "name": "x-iops-total", @@ -14957,7 +14995,7 @@ "meta-type": "object" }, { - "name": "461", + "name": "462", "members": [ { "name": "verify-peer", @@ -14972,7 +15010,7 @@ { "name": "endpoint", "default": null, - "type": "610" + "type": "611" }, { "name": "priority", @@ -14991,7 +15029,7 @@ "meta-type": "object" }, { - "name": "462", + "name": "463", "members": [ { "name": "verify-peer", @@ -15006,7 +15044,7 @@ { "name": "endpoint", "default": null, - "type": "610" + "type": "611" }, { "name": "priority", @@ -15030,7 +15068,7 @@ "meta-type": "object" }, { - "name": "463", + "name": "464", "members": [ { "name": "verify-peer", @@ -15045,7 +15083,7 @@ { "name": "endpoint", "default": null, - "type": "610" + "type": "611" }, { "name": "priority", @@ -15074,7 +15112,7 @@ "meta-type": "object" }, { - "name": "464", + "name": "465", "members": [ { "name": "verify-peer", @@ -15089,7 +15127,7 @@ { "name": "endpoint", "default": null, - "type": "610" + "type": "611" }, { "name": "priority", @@ -15100,7 +15138,7 @@ "meta-type": "object" }, { - "name": "465", + "name": "466", "members": [ { "name": "fd", @@ -15114,11 +15152,11 @@ "meta-type": "object" }, { - "name": "466", + "name": "467", "members": [ { "name": "socket", - "type": "364" + "type": "365" }, { "name": "device", @@ -15128,7 +15166,7 @@ "meta-type": "object" }, { - "name": "467", + "name": "468", "members": [ { "name": "node-id", @@ -15164,7 +15202,7 @@ "meta-type": "object" }, { - "name": "468", + "name": "469", "members": [ { "name": "aarch64" @@ -15296,17 +15334,17 @@ ] }, { - "name": "469", + "name": "470", "members": [ { "name": "cpu-state", - "type": "611" + "type": "612" } ], "meta-type": "object" }, { - "name": "470", + "name": "471", "members": [ { "name": "default" @@ -15330,7 +15368,7 @@ ] }, { - "name": "471", + "name": "472", "members": [ { "name": "node" @@ -15358,7 +15396,7 @@ ] }, { - "name": "472", + "name": "473", "members": [ { "name": "nodeid", @@ -15389,7 +15427,7 @@ "meta-type": "object" }, { - "name": "473", + "name": "474", "members": [ { "name": "src", @@ -15407,7 +15445,7 @@ "meta-type": "object" }, { - "name": "474", + "name": "475", "members": [ { "name": "node-id", @@ -15443,7 +15481,7 @@ "meta-type": "object" }, { - "name": "475", + "name": "476", "members": [ { "name": "initiator", @@ -15455,11 +15493,11 @@ }, { "name": "hierarchy", - "type": "612" + "type": "613" }, { "name": "data-type", - "type": "613" + "type": "614" }, { "name": "latency", @@ -15475,7 +15513,7 @@ "meta-type": "object" }, { - "name": "476", + "name": "477", "members": [ { "name": "node-id", @@ -15491,11 +15529,11 @@ }, { "name": "associativity", - "type": "614" + "type": "615" }, { "name": "policy", - "type": "615" + "type": "616" }, { "name": "line", @@ -15505,7 +15543,7 @@ "meta-type": "object" }, { - "name": "477", + "name": "478", "members": [ { "name": "dimm" @@ -15532,16 +15570,6 @@ "sgx-epc" ] }, - { - "name": "478", - "members": [ - { - "name": "data", - "type": "616" - } - ], - "meta-type": "object" - }, { "name": "479", "members": [ @@ -15574,6 +15602,16 @@ }, { "name": "482", + "members": [ + { + "name": "data", + "type": "620" + } + ], + "meta-type": "object" + }, + { + "name": "483", "members": [ { "name": "name", @@ -15588,7 +15626,7 @@ "meta-type": "object" }, { - "name": "483", + "name": "484", "members": [ { "name": "incompatible" @@ -15612,7 +15650,7 @@ ] }, { - "name": "484", + "name": "485", "members": [ { "name": "static" @@ -15628,7 +15666,7 @@ ] }, { - "name": "485", + "name": "486", "members": [ { "name": "none" @@ -15648,7 +15686,7 @@ ] }, { - "name": "486", + "name": "487", "members": [ { "name": "block-node" @@ -15668,7 +15706,7 @@ ] }, { - "name": "487", + "name": "488", "members": [ { "name": "node-name", @@ -15678,7 +15716,7 @@ "meta-type": "object" }, { - "name": "488", + "name": "489", "members": [ { "name": "id", @@ -15688,12 +15726,12 @@ "meta-type": "object" }, { - "name": "[489]", - "element-type": "489", + "name": "[490]", + "element-type": "490", "meta-type": "array" }, { - "name": "489", + "name": "490", "members": [ { "name": "fd", @@ -15708,12 +15746,12 @@ "meta-type": "object" }, { - "name": "[490]", - "element-type": "490", + "name": "[491]", + "element-type": "491", "meta-type": "array" }, { - "name": "490", + "name": "491", "members": [ { "name": "name", @@ -15721,7 +15759,7 @@ }, { "name": "type", - "type": "620" + "type": "621" }, { "name": "help", @@ -15737,7 +15775,7 @@ "meta-type": "object" }, { - "name": "491", + "name": "492", "members": [ { "name": "uninit" @@ -15769,12 +15807,12 @@ ] }, { - "name": "[492]", - "element-type": "492", + "name": "[493]", + "element-type": "493", "meta-type": "array" }, { - "name": "492", + "name": "493", "members": [ { "name": "node", @@ -15788,7 +15826,7 @@ "meta-type": "object" }, { - "name": "493", + "name": "494", "members": [ { "name": "DIMM" @@ -15804,12 +15842,12 @@ ] }, { - "name": "[494]", - "element-type": "494", + "name": "[495]", + "element-type": "495", "meta-type": "array" }, { - "name": "494", + "name": "495", "members": [ { "name": "bus", @@ -15825,11 +15863,11 @@ }, { "name": "class_info", - "type": "621" + "type": "622" }, { "name": "id", - "type": "622" + "type": "623" }, { "name": "irq", @@ -15847,17 +15885,17 @@ { "name": "pci_bridge", "default": null, - "type": "623" + "type": "624" }, { "name": "regions", - "type": "[624]" + "type": "[625]" } ], "meta-type": "object" }, { - "name": "495", + "name": "496", "members": [ { "name": "vm" @@ -15873,16 +15911,16 @@ ] }, { - "name": "[496]", - "element-type": "496", + "name": "[497]", + "element-type": "497", "meta-type": "array" }, { - "name": "496", + "name": "497", "members": [ { "name": "provider", - "type": "498" + "type": "499" }, { "name": "names", @@ -15893,7 +15931,7 @@ "meta-type": "object" }, { - "name": "497", + "name": "498", "members": [ { "name": "vcpus", @@ -15904,7 +15942,7 @@ "meta-type": "object" }, { - "name": "498", + "name": "499", "members": [ { "name": "kvm" @@ -15916,12 +15954,12 @@ ] }, { - "name": "[499]", - "element-type": "499", + "name": "[500]", + "element-type": "500", "meta-type": "array" }, { - "name": "499", + "name": "500", "members": [ { "name": "name", @@ -15929,18 +15967,18 @@ }, { "name": "value", - "type": "625" + "type": "626" } ], "meta-type": "object" }, { - "name": "[500]", - "element-type": "500", + "name": "[501]", + "element-type": "501", "meta-type": "array" }, { - "name": "500", + "name": "501", "members": [ { "name": "name", @@ -15948,12 +15986,12 @@ }, { "name": "type", - "type": "626" + "type": "627" }, { "name": "unit", "default": null, - "type": "627" + "type": "628" }, { "name": "base", @@ -15973,7 +16011,7 @@ "meta-type": "object" }, { - "name": "501", + "name": "502", "members": [ { "name": "transports", @@ -15993,7 +16031,7 @@ "meta-type": "object" }, { - "name": "502", + "name": "503", "members": [ { "name": "statuses", @@ -16008,7 +16046,7 @@ "meta-type": "object" }, { - "name": "503", + "name": "504", "members": [ { "name": "n-mem-sections", @@ -16028,19 +16066,19 @@ }, { "name": "features", - "type": "501" + "type": "502" }, { "name": "acked-features", - "type": "501" + "type": "502" }, { "name": "backend-features", - "type": "501" + "type": "502" }, { "name": "protocol-features", - "type": "628" + "type": "629" }, { "name": "max-queues", @@ -16062,12 +16100,12 @@ "meta-type": "object" }, { - "name": "[504]", - "element-type": "504", + "name": "[505]", + "element-type": "505", "meta-type": "array" }, { - "name": "504", + "name": "505", "members": [ { "name": "addr", @@ -16085,7 +16123,7 @@ "meta-type": "object" }, { - "name": "505", + "name": "506", "members": [ { "name": "flags", @@ -16103,7 +16141,7 @@ "meta-type": "object" }, { - "name": "506", + "name": "507", "members": [ { "name": "flags", @@ -16117,7 +16155,7 @@ "meta-type": "object" }, { - "name": "507", + "name": "508", "members": [ { "name": "hyper-v" @@ -16133,7 +16171,7 @@ ] }, { - "name": "508", + "name": "509", "members": [ { "name": "arg1", @@ -16159,7 +16197,7 @@ "meta-type": "object" }, { - "name": "509", + "name": "510", "members": [ { "name": "core", @@ -16175,18 +16213,18 @@ }, { "name": "reason", - "type": "629" + "type": "630" } ], "meta-type": "object" }, { - "name": "[510]", - "element-type": "510", + "name": "[511]", + "element-type": "511", "meta-type": "array" }, { - "name": "510", + "name": "511", "members": [ { "name": "interval_length", @@ -16240,7 +16278,7 @@ "meta-type": "object" }, { - "name": "511", + "name": "512", "members": [ { "name": "boundaries", @@ -16254,7 +16292,7 @@ "meta-type": "object" }, { - "name": "512", + "name": "513", "members": [ { "name": "discard-nb-ok", @@ -16272,7 +16310,7 @@ "meta-type": "object" }, { - "name": "513", + "name": "514", "members": [ { "name": "completion-errors", @@ -16295,36 +16333,36 @@ "meta-type": "array" }, { - "name": "514", + "name": "515", "tag": "type", "variants": [ { "case": "qcow2", - "type": "631" + "type": "632" }, { "case": "vmdk", - "type": "632" + "type": "633" }, { "case": "luks", - "type": "633" + "type": "634" }, { "case": "rbd", - "type": "634" + "type": "635" } ], "members": [ { "name": "type", - "type": "630" + "type": "631" } ], "meta-type": "object" }, { - "name": "515", + "name": "516", "members": [ { "name": "block-backend" @@ -16344,12 +16382,12 @@ ] }, { - "name": "[516]", - "element-type": "516", + "name": "[517]", + "element-type": "517", "meta-type": "array" }, { - "name": "516", + "name": "517", "members": [ { "name": "consistent-read" @@ -16373,7 +16411,7 @@ ] }, { - "name": "517", + "name": "518", "members": [ { "type": "49" @@ -16385,16 +16423,16 @@ "meta-type": "alternate" }, { - "name": "[518]", - "element-type": "518", + "name": "[519]", + "element-type": "519", "meta-type": "array" }, { - "name": "518", + "name": "519", "members": [ { "name": "event", - "type": "635" + "type": "636" }, { "name": "state", @@ -16404,7 +16442,7 @@ { "name": "iotype", "default": null, - "type": "636" + "type": "637" }, { "name": "errno", @@ -16430,16 +16468,16 @@ "meta-type": "object" }, { - "name": "[519]", - "element-type": "519", + "name": "[520]", + "element-type": "520", "meta-type": "array" }, { - "name": "519", + "name": "520", "members": [ { "name": "event", - "type": "635" + "type": "636" }, { "name": "state", @@ -16454,7 +16492,7 @@ "meta-type": "object" }, { - "name": "520", + "name": "521", "members": [ { "name": "break-guest-write" @@ -16470,7 +16508,7 @@ ] }, { - "name": "521", + "name": "522", "members": [ { "name": "auto" @@ -16490,7 +16528,7 @@ ] }, { - "name": "522", + "name": "523", "members": [ { "name": "threads" @@ -16510,7 +16548,7 @@ ] }, { - "name": "523", + "name": "524", "members": [ { "name": "tcp" @@ -16526,7 +16564,7 @@ ] }, { - "name": "524", + "name": "525", "members": [ { "name": "crc32c" @@ -16550,11 +16588,11 @@ ] }, { - "name": "525", + "name": "526", "members": [ { "name": "type", - "type": "637" + "type": "638" }, { "name": "host", @@ -16564,7 +16602,7 @@ "meta-type": "object" }, { - "name": "526", + "name": "527", "members": [ { "type": "49" @@ -16579,62 +16617,62 @@ "meta-type": "alternate" }, { - "name": "527", + "name": "528", "members": [ { - "type": "638" + "type": "639" }, { - "type": "639" + "type": "640" } ], "meta-type": "alternate" }, { - "name": "528", + "name": "529", "tag": "format", "variants": [ { "case": "aes", - "type": "641" + "type": "642" }, { "case": "luks", - "type": "642" + "type": "643" } ], "members": [ { "name": "format", - "type": "640" + "type": "641" } ], "meta-type": "object" }, { - "name": "529", + "name": "530", "tag": "format", "variants": [ { "case": "aes", - "type": "641" + "type": "642" } ], "members": [ { "name": "format", - "type": "643" + "type": "644" } ], "meta-type": "object" }, { - "name": "[517]", - "element-type": "517", + "name": "[518]", + "element-type": "518", "meta-type": "array" }, { - "name": "530", + "name": "531", "members": [ { "name": "quorum" @@ -16650,33 +16688,33 @@ ] }, { - "name": "531", + "name": "532", "tag": "format", "variants": [ { "case": "luks", - "type": "645" + "type": "646" }, { "case": "luks2", - "type": "646" + "type": "647" } ], "members": [ { "name": "format", - "type": "644" + "type": "645" } ], "meta-type": "object" }, { - "name": "[532]", - "element-type": "532", + "name": "[533]", + "element-type": "533", "meta-type": "array" }, { - "name": "532", + "name": "533", "members": [ { "name": "cephx" @@ -16692,12 +16730,12 @@ ] }, { - "name": "[533]", - "element-type": "533", + "name": "[534]", + "element-type": "534", "meta-type": "array" }, { - "name": "533", + "name": "534", "members": [ { "name": "host", @@ -16711,7 +16749,7 @@ "meta-type": "object" }, { - "name": "534", + "name": "535", "members": [ { "name": "primary" @@ -16727,7 +16765,7 @@ ] }, { - "name": "535", + "name": "536", "members": [ { "name": "host", @@ -16771,12 +16809,12 @@ "meta-type": "object" }, { - "name": "536", + "name": "537", "tag": "mode", "variants": [ { "case": "hash", - "type": "648" + "type": "649" }, { "case": "none", @@ -16790,13 +16828,13 @@ "members": [ { "name": "mode", - "type": "647" + "type": "648" } ], "meta-type": "object" }, { - "name": "537", + "name": "538", "members": [ { "name": "filename", @@ -16809,7 +16847,7 @@ { "name": "preallocation", "default": null, - "type": "649" + "type": "650" }, { "name": "nocow", @@ -16825,7 +16863,7 @@ "meta-type": "object" }, { - "name": "538", + "name": "539", "members": [ { "name": "location", @@ -16838,13 +16876,13 @@ { "name": "preallocation", "default": null, - "type": "649" + "type": "650" } ], "meta-type": "object" }, { - "name": "539", + "name": "540", "members": [ { "name": "key-secret", @@ -16854,27 +16892,27 @@ { "name": "cipher-alg", "default": null, - "type": "650" + "type": "651" }, { "name": "cipher-mode", "default": null, - "type": "651" + "type": "652" }, { "name": "ivgen-alg", "default": null, - "type": "652" + "type": "653" }, { "name": "ivgen-hash-alg", "default": null, - "type": "653" + "type": "654" }, { "name": "hash-alg", "default": null, - "type": "653" + "type": "654" }, { "name": "iter-time", @@ -16883,7 +16921,7 @@ }, { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -16892,13 +16930,13 @@ { "name": "preallocation", "default": null, - "type": "649" + "type": "650" } ], "meta-type": "object" }, { - "name": "540", + "name": "541", "members": [ { "name": "location", @@ -16912,11 +16950,11 @@ "meta-type": "object" }, { - "name": "541", + "name": "542", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -16931,11 +16969,11 @@ "meta-type": "object" }, { - "name": "542", + "name": "543", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -16949,22 +16987,22 @@ { "name": "encrypt", "default": null, - "type": "654" + "type": "655" } ], "meta-type": "object" }, { - "name": "543", + "name": "544", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "data-file", "default": null, - "type": "517" + "type": "518" }, { "name": "data-file-raw", @@ -16983,7 +17021,7 @@ { "name": "version", "default": null, - "type": "655" + "type": "656" }, { "name": "backing-file", @@ -16998,7 +17036,7 @@ { "name": "encrypt", "default": null, - "type": "654" + "type": "655" }, { "name": "cluster-size", @@ -17008,7 +17046,7 @@ { "name": "preallocation", "default": null, - "type": "649" + "type": "650" }, { "name": "lazy-refcounts", @@ -17023,17 +17061,17 @@ { "name": "compression-type", "default": null, - "type": "656" + "type": "657" } ], "meta-type": "object" }, { - "name": "544", + "name": "545", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -17063,7 +17101,7 @@ "meta-type": "object" }, { - "name": "545", + "name": "546", "members": [ { "name": "location", @@ -17081,13 +17119,13 @@ { "name": "encrypt", "default": null, - "type": "657" + "type": "658" } ], "meta-type": "object" }, { - "name": "546", + "name": "547", "members": [ { "name": "location", @@ -17101,11 +17139,11 @@ "meta-type": "object" }, { - "name": "547", + "name": "548", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -17114,17 +17152,17 @@ { "name": "preallocation", "default": null, - "type": "649" + "type": "650" } ], "meta-type": "object" }, { - "name": "548", + "name": "549", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -17143,7 +17181,7 @@ { "name": "subformat", "default": null, - "type": "658" + "type": "659" }, { "name": "block-state-zero", @@ -17154,11 +17192,11 @@ "meta-type": "object" }, { - "name": "549", + "name": "550", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -17167,12 +17205,12 @@ { "name": "extents", "default": null, - "type": "[517]" + "type": "[518]" }, { "name": "subformat", "default": null, - "type": "659" + "type": "660" }, { "name": "backing-file", @@ -17182,7 +17220,7 @@ { "name": "adapter-type", "default": null, - "type": "660" + "type": "661" }, { "name": "hwversion", @@ -17203,11 +17241,11 @@ "meta-type": "object" }, { - "name": "550", + "name": "551", "members": [ { "name": "file", - "type": "517" + "type": "518" }, { "name": "size", @@ -17216,7 +17254,7 @@ { "name": "subformat", "default": null, - "type": "661" + "type": "662" }, { "name": "force-size", @@ -17227,11 +17265,11 @@ "meta-type": "object" }, { - "name": "551", + "name": "552", "members": [ { "name": "state", - "type": "662" + "type": "663" }, { "name": "new-secret", @@ -17262,12 +17300,12 @@ "meta-type": "object" }, { - "name": "552", + "name": "553", "members": [ { "name": "encrypt", "default": null, - "type": "663" + "type": "664" } ], "meta-type": "object" @@ -17278,7 +17316,7 @@ "meta-type": "builtin" }, { - "name": "553", + "name": "554", "members": [ { "name": "inet" @@ -17302,47 +17340,47 @@ ] }, { - "name": "554", + "name": "555", "members": [ { "name": "data", - "type": "535" + "type": "536" } ], "meta-type": "object" }, { - "name": "555", + "name": "556", "members": [ { "name": "data", - "type": "574" + "type": "575" } ], "meta-type": "object" }, { - "name": "556", + "name": "557", "members": [ { "name": "data", - "type": "575" + "type": "576" } ], "meta-type": "object" }, { - "name": "557", + "name": "558", "members": [ { "name": "data", - "type": "573" + "type": "574" } ], "meta-type": "object" }, { - "name": "558", + "name": "559", "members": [ { "name": "off" @@ -17362,7 +17400,7 @@ ] }, { - "name": "559", + "name": "560", "members": [ { "name": "file" @@ -17457,16 +17495,6 @@ "memory" ] }, - { - "name": "560", - "members": [ - { - "name": "data", - "type": "664" - } - ], - "meta-type": "object" - }, { "name": "561", "members": [ @@ -17588,12 +17616,22 @@ "meta-type": "object" }, { - "name": "[573]", - "element-type": "573", + "name": "573", + "members": [ + { + "name": "data", + "type": "677" + } + ], + "meta-type": "object" + }, + { + "name": "[574]", + "element-type": "574", "meta-type": "array" }, { - "name": "573", + "name": "574", "members": [ { "name": "str", @@ -17603,7 +17641,7 @@ "meta-type": "object" }, { - "name": "574", + "name": "575", "members": [ { "name": "path", @@ -17623,7 +17661,7 @@ "meta-type": "object" }, { - "name": "575", + "name": "576", "members": [ { "name": "cid", @@ -17637,27 +17675,27 @@ "meta-type": "object" }, { - "name": "576", + "name": "577", "members": [ { "name": "data", - "type": "677" + "type": "678" } ], "meta-type": "object" }, { - "name": "577", + "name": "578", "members": [ { "name": "data", - "type": "678" + "type": "679" } ], "meta-type": "object" }, { - "name": "578", + "name": "579", "members": [ { "name": "number" @@ -17673,7 +17711,7 @@ ] }, { - "name": "579", + "name": "580", "members": [ { "name": "data", @@ -17683,17 +17721,17 @@ "meta-type": "object" }, { - "name": "580", + "name": "581", "members": [ { "name": "data", - "type": "679" + "type": "680" } ], "meta-type": "object" }, { - "name": "581", + "name": "582", "members": [ { "name": "key" @@ -17717,37 +17755,37 @@ ] }, { - "name": "582", + "name": "583", "members": [ { "name": "data", - "type": "680" + "type": "681" } ], "meta-type": "object" }, { - "name": "583", + "name": "584", "members": [ { "name": "data", - "type": "681" + "type": "682" } ], "meta-type": "object" }, { - "name": "584", + "name": "585", "members": [ { "name": "data", - "type": "682" + "type": "683" } ], "meta-type": "object" }, { - "name": "585", + "name": "586", "members": [ { "name": "lctrl-lalt" @@ -17772,12 +17810,12 @@ "meta-type": "builtin" }, { - "name": "[586]", - "element-type": "586", + "name": "[587]", + "element-type": "587", "meta-type": "array" }, { - "name": "586", + "name": "587", "members": [ { "name": "name", @@ -17790,13 +17828,13 @@ { "name": "transform", "default": null, - "type": "683" + "type": "684" } ], "meta-type": "object" }, { - "name": "587", + "name": "588", "members": [ { "name": "abort" @@ -17855,17 +17893,17 @@ ] }, { - "name": "588", + "name": "589", "members": [ { "name": "data", - "type": "684" + "type": "685" } ], "meta-type": "object" }, { - "name": "589", + "name": "590", "members": [ { "name": "data", @@ -17875,7 +17913,7 @@ "meta-type": "object" }, { - "name": "590", + "name": "591", "members": [ { "name": "data", @@ -17885,7 +17923,7 @@ "meta-type": "object" }, { - "name": "591", + "name": "592", "members": [ { "name": "data", @@ -17895,7 +17933,7 @@ "meta-type": "object" }, { - "name": "592", + "name": "593", "members": [ { "name": "data", @@ -17905,7 +17943,7 @@ "meta-type": "object" }, { - "name": "593", + "name": "594", "members": [ { "name": "data", @@ -17915,7 +17953,7 @@ "meta-type": "object" }, { - "name": "594", + "name": "595", "members": [ { "name": "data", @@ -17925,7 +17963,7 @@ "meta-type": "object" }, { - "name": "595", + "name": "596", "members": [ { "name": "data", @@ -17935,7 +17973,7 @@ "meta-type": "object" }, { - "name": "596", + "name": "597", "members": [ { "name": "data", @@ -17945,7 +17983,7 @@ "meta-type": "object" }, { - "name": "597", + "name": "598", "members": [ { "name": "individual" @@ -17961,7 +17999,7 @@ ] }, { - "name": "598", + "name": "599", "members": [ { "name": "string" @@ -18001,12 +18039,12 @@ ] }, { - "name": "[599]", - "element-type": "599", + "name": "[600]", + "element-type": "600", "meta-type": "array" }, { - "name": "599", + "name": "600", "members": [ { "name": "name", @@ -18021,12 +18059,12 @@ "meta-type": "object" }, { - "name": "[600]", - "element-type": "600", + "name": "[601]", + "element-type": "601", "meta-type": "array" }, { - "name": "600", + "name": "601", "members": [ { "name": "name", @@ -18050,12 +18088,12 @@ "meta-type": "object" }, { - "name": "[601]", - "element-type": "601", + "name": "[602]", + "element-type": "602", "meta-type": "array" }, { - "name": "601", + "name": "602", "members": [ { "name": "case", @@ -18069,12 +18107,12 @@ "meta-type": "object" }, { - "name": "[602]", - "element-type": "602", + "name": "[603]", + "element-type": "603", "meta-type": "array" }, { - "name": "602", + "name": "603", "members": [ { "name": "type", @@ -18084,7 +18122,7 @@ "meta-type": "object" }, { - "name": "603", + "name": "604", "members": [ { "name": "deny" @@ -18100,12 +18138,12 @@ ] }, { - "name": "[604]", - "element-type": "604", + "name": "[605]", + "element-type": "605", "meta-type": "array" }, { - "name": "604", + "name": "605", "members": [ { "name": "match", @@ -18113,18 +18151,18 @@ }, { "name": "policy", - "type": "603" + "type": "604" }, { "name": "format", "default": null, - "type": "685" + "type": "686" } ], "meta-type": "object" }, { - "name": "605", + "name": "606", "members": [ { "name": "all" @@ -18144,7 +18182,7 @@ ] }, { - "name": "606", + "name": "607", "members": [ { "name": "before" @@ -18160,7 +18198,7 @@ ] }, { - "name": "607", + "name": "608", "members": [ { "name": "ctrl-ctrl" @@ -18192,7 +18230,7 @@ ] }, { - "name": "608", + "name": "609", "members": [ { "name": "raw" @@ -18208,7 +18246,7 @@ ] }, { - "name": "609", + "name": "610", "members": [ { "name": "iops-total", @@ -18309,7 +18347,7 @@ "meta-type": "object" }, { - "name": "610", + "name": "611", "members": [ { "name": "client" @@ -18325,7 +18363,7 @@ ] }, { - "name": "611", + "name": "612", "members": [ { "name": "uninitialized" @@ -18353,7 +18391,7 @@ ] }, { - "name": "612", + "name": "613", "members": [ { "name": "memory" @@ -18377,7 +18415,7 @@ ] }, { - "name": "613", + "name": "614", "members": [ { "name": "access-latency" @@ -18409,7 +18447,7 @@ ] }, { - "name": "614", + "name": "615", "members": [ { "name": "none" @@ -18429,7 +18467,7 @@ ] }, { - "name": "615", + "name": "616", "members": [ { "name": "none" @@ -18449,7 +18487,7 @@ ] }, { - "name": "616", + "name": "617", "members": [ { "name": "id", @@ -18488,7 +18526,7 @@ "meta-type": "object" }, { - "name": "617", + "name": "618", "members": [ { "name": "id", @@ -18511,7 +18549,7 @@ "meta-type": "object" }, { - "name": "618", + "name": "619", "members": [ { "name": "id", @@ -18550,7 +18588,7 @@ "meta-type": "object" }, { - "name": "619", + "name": "620", "members": [ { "name": "id", @@ -18577,7 +18615,7 @@ "meta-type": "object" }, { - "name": "620", + "name": "621", "members": [ { "name": "string" @@ -18601,7 +18639,7 @@ ] }, { - "name": "621", + "name": "622", "members": [ { "name": "desc", @@ -18616,7 +18654,7 @@ "meta-type": "object" }, { - "name": "622", + "name": "623", "members": [ { "name": "device", @@ -18640,27 +18678,27 @@ "meta-type": "object" }, { - "name": "623", + "name": "624", "members": [ { "name": "bus", - "type": "686" + "type": "687" }, { "name": "devices", "default": null, - "type": "[494]" + "type": "[495]" } ], "meta-type": "object" }, { - "name": "[624]", - "element-type": "624", + "name": "[625]", + "element-type": "625", "meta-type": "array" }, { - "name": "624", + "name": "625", "members": [ { "name": "bar", @@ -18692,7 +18730,7 @@ "meta-type": "object" }, { - "name": "625", + "name": "626", "members": [ { "type": "int" @@ -18707,7 +18745,7 @@ "meta-type": "alternate" }, { - "name": "626", + "name": "627", "members": [ { "name": "cumulative" @@ -18735,7 +18773,7 @@ ] }, { - "name": "627", + "name": "628", "members": [ { "name": "bytes" @@ -18759,7 +18797,7 @@ ] }, { - "name": "628", + "name": "629", "members": [ { "name": "protocols", @@ -18774,7 +18812,7 @@ "meta-type": "object" }, { - "name": "629", + "name": "630", "members": [ { "name": "unknown" @@ -18802,7 +18840,7 @@ ] }, { - "name": "630", + "name": "631", "members": [ { "name": "qcow2" @@ -18826,47 +18864,47 @@ ] }, { - "name": "631", + "name": "632", "members": [ { "name": "data", - "type": "687" + "type": "688" } ], "meta-type": "object" }, { - "name": "632", + "name": "633", "members": [ { "name": "data", - "type": "688" + "type": "689" } ], "meta-type": "object" }, { - "name": "633", + "name": "634", "members": [ { "name": "data", - "type": "689" + "type": "690" } ], "meta-type": "object" }, { - "name": "634", + "name": "635", "members": [ { "name": "data", - "type": "690" + "type": "691" } ], "meta-type": "object" }, { - "name": "635", + "name": "636", "members": [ { "name": "l1_update" @@ -19066,7 +19104,7 @@ ] }, { - "name": "636", + "name": "637", "members": [ { "name": "read" @@ -19098,7 +19136,7 @@ ] }, { - "name": "637", + "name": "638", "members": [ { "name": "inet" @@ -19110,12 +19148,12 @@ ] }, { - "name": "638", + "name": "639", "members": [ { "name": "template", "default": null, - "type": "639" + "type": "640" }, { "name": "main-header", @@ -19166,7 +19204,7 @@ "meta-type": "object" }, { - "name": "639", + "name": "640", "members": [ { "name": "none" @@ -19190,7 +19228,7 @@ ] }, { - "name": "640", + "name": "641", "members": [ { "name": "aes" @@ -19206,7 +19244,7 @@ ] }, { - "name": "641", + "name": "642", "members": [ { "name": "key-secret", @@ -19217,7 +19255,7 @@ "meta-type": "object" }, { - "name": "642", + "name": "643", "members": [ { "name": "key-secret", @@ -19228,7 +19266,7 @@ "meta-type": "object" }, { - "name": "643", + "name": "644", "members": [ { "name": "aes" @@ -19240,7 +19278,7 @@ ] }, { - "name": "644", + "name": "645", "members": [ { "name": "luks" @@ -19256,7 +19294,7 @@ ] }, { - "name": "645", + "name": "646", "members": [ { "name": "key-secret", @@ -19266,7 +19304,7 @@ "meta-type": "object" }, { - "name": "646", + "name": "647", "members": [ { "name": "key-secret", @@ -19276,7 +19314,7 @@ "meta-type": "object" }, { - "name": "647", + "name": "648", "members": [ { "name": "none" @@ -19296,11 +19334,11 @@ ] }, { - "name": "648", + "name": "649", "members": [ { "name": "type", - "type": "691" + "type": "692" }, { "name": "hash", @@ -19310,7 +19348,7 @@ "meta-type": "object" }, { - "name": "649", + "name": "650", "members": [ { "name": "off" @@ -19334,7 +19372,7 @@ ] }, { - "name": "650", + "name": "651", "members": [ { "name": "aes-128" @@ -19390,7 +19428,7 @@ ] }, { - "name": "651", + "name": "652", "members": [ { "name": "ecb" @@ -19414,7 +19452,7 @@ ] }, { - "name": "652", + "name": "653", "members": [ { "name": "plain" @@ -19434,7 +19472,7 @@ ] }, { - "name": "653", + "name": "654", "members": [ { "name": "md5" @@ -19470,28 +19508,28 @@ ] }, { - "name": "654", + "name": "655", "tag": "format", "variants": [ { "case": "qcow", - "type": "641" + "type": "642" }, { "case": "luks", - "type": "693" + "type": "694" } ], "members": [ { "name": "format", - "type": "692" + "type": "693" } ], "meta-type": "object" }, { - "name": "655", + "name": "656", "members": [ { "name": "v2" @@ -19507,7 +19545,7 @@ ] }, { - "name": "656", + "name": "657", "members": [ { "name": "zlib" @@ -19523,28 +19561,28 @@ ] }, { - "name": "657", + "name": "658", "tag": "format", "variants": [ { "case": "luks", - "type": "694" + "type": "695" }, { "case": "luks2", - "type": "695" + "type": "696" } ], "members": [ { "name": "format", - "type": "644" + "type": "645" } ], "meta-type": "object" }, { - "name": "658", + "name": "659", "members": [ { "name": "dynamic" @@ -19560,7 +19598,7 @@ ] }, { - "name": "659", + "name": "660", "members": [ { "name": "monolithicSparse" @@ -19588,7 +19626,7 @@ ] }, { - "name": "660", + "name": "661", "members": [ { "name": "ide" @@ -19612,7 +19650,7 @@ ] }, { - "name": "661", + "name": "662", "members": [ { "name": "dynamic" @@ -19628,7 +19666,7 @@ ] }, { - "name": "662", + "name": "663", "members": [ { "name": "active" @@ -19644,12 +19682,12 @@ ] }, { - "name": "663", + "name": "664", "tag": "format", "variants": [ { "case": "luks", - "type": "696" + "type": "697" }, { "case": "qcow", @@ -19659,13 +19697,13 @@ "members": [ { "name": "format", - "type": "692" + "type": "693" } ], "meta-type": "object" }, { - "name": "664", + "name": "665", "members": [ { "name": "logfile", @@ -19695,7 +19733,7 @@ "meta-type": "object" }, { - "name": "665", + "name": "666", "members": [ { "name": "logfile", @@ -19715,7 +19753,7 @@ "meta-type": "object" }, { - "name": "666", + "name": "667", "members": [ { "name": "logfile", @@ -19729,7 +19767,7 @@ }, { "name": "addr", - "type": "335" + "type": "336" }, { "name": "tls-creds", @@ -19780,7 +19818,7 @@ "meta-type": "object" }, { - "name": "667", + "name": "668", "members": [ { "name": "logfile", @@ -19794,18 +19832,18 @@ }, { "name": "remote", - "type": "335" + "type": "336" }, { "name": "local", "default": null, - "type": "335" + "type": "336" } ], "meta-type": "object" }, { - "name": "668", + "name": "669", "members": [ { "name": "logfile", @@ -19821,7 +19859,7 @@ "meta-type": "object" }, { - "name": "669", + "name": "670", "members": [ { "name": "logfile", @@ -19841,7 +19879,7 @@ "meta-type": "object" }, { - "name": "670", + "name": "671", "members": [ { "name": "logfile", @@ -19862,7 +19900,7 @@ "meta-type": "object" }, { - "name": "671", + "name": "672", "members": [ { "name": "logfile", @@ -19882,7 +19920,7 @@ "meta-type": "object" }, { - "name": "672", + "name": "673", "members": [ { "name": "logfile", @@ -19902,7 +19940,7 @@ "meta-type": "object" }, { - "name": "673", + "name": "674", "members": [ { "name": "logfile", @@ -19928,7 +19966,7 @@ "meta-type": "object" }, { - "name": "674", + "name": "675", "members": [ { "name": "logfile", @@ -19948,7 +19986,7 @@ "meta-type": "object" }, { - "name": "675", + "name": "676", "members": [ { "name": "logfile", @@ -19984,7 +20022,7 @@ "meta-type": "object" }, { - "name": "676", + "name": "677", "members": [ { "name": "logfile", @@ -20005,7 +20043,7 @@ "meta-type": "object" }, { - "name": "677", + "name": "678", "members": [ { "name": "path", @@ -20021,7 +20059,7 @@ "meta-type": "object" }, { - "name": "678", + "name": "679", "members": [ { "name": "chardev", @@ -20031,7 +20069,7 @@ "meta-type": "object" }, { - "name": "679", + "name": "680", "members": [ { "name": "unmapped" @@ -20639,11 +20677,11 @@ ] }, { - "name": "680", + "name": "681", "members": [ { "name": "key", - "type": "387" + "type": "388" }, { "name": "down", @@ -20653,11 +20691,11 @@ "meta-type": "object" }, { - "name": "681", + "name": "682", "members": [ { "name": "button", - "type": "697" + "type": "698" }, { "name": "down", @@ -20667,11 +20705,11 @@ "meta-type": "object" }, { - "name": "682", + "name": "683", "members": [ { "name": "axis", - "type": "698" + "type": "699" }, { "name": "value", @@ -20681,7 +20719,7 @@ "meta-type": "object" }, { - "name": "683", + "name": "684", "members": [ { "name": "persistent", @@ -20692,13 +20730,13 @@ "meta-type": "object" }, { - "name": "684", + "name": "685", "members": [ ], "meta-type": "object" }, { - "name": "685", + "name": "686", "members": [ { "name": "exact" @@ -20714,7 +20752,7 @@ ] }, { - "name": "686", + "name": "687", "members": [ { "name": "number", @@ -20730,21 +20768,21 @@ }, { "name": "io_range", - "type": "699" + "type": "700" }, { "name": "memory_range", - "type": "699" + "type": "700" }, { "name": "prefetchable_range", - "type": "699" + "type": "700" } ], "meta-type": "object" }, { - "name": "687", + "name": "688", "members": [ { "name": "compat", @@ -20782,22 +20820,22 @@ { "name": "encrypt", "default": null, - "type": "700" + "type": "701" }, { "name": "bitmaps", "default": null, - "type": "[701]" + "type": "[702]" }, { "name": "compression-type", - "type": "656" + "type": "657" } ], "meta-type": "object" }, { - "name": "688", + "name": "689", "members": [ { "name": "create-type", @@ -20819,28 +20857,28 @@ "meta-type": "object" }, { - "name": "689", + "name": "690", "members": [ { "name": "cipher-alg", - "type": "650" + "type": "651" }, { "name": "cipher-mode", - "type": "651" + "type": "652" }, { "name": "ivgen-alg", - "type": "652" + "type": "653" }, { "name": "ivgen-hash-alg", "default": null, - "type": "653" + "type": "654" }, { "name": "hash-alg", - "type": "653" + "type": "654" }, { "name": "payload-offset", @@ -20856,24 +20894,24 @@ }, { "name": "slots", - "type": "[702]" + "type": "[703]" } ], "meta-type": "object" }, { - "name": "690", + "name": "691", "members": [ { "name": "encryption-format", "default": null, - "type": "644" + "type": "645" } ], "meta-type": "object" }, { - "name": "691", + "name": "692", "members": [ { "name": "md5" @@ -20893,7 +20931,7 @@ ] }, { - "name": "692", + "name": "693", "members": [ { "name": "qcow" @@ -20909,7 +20947,7 @@ ] }, { - "name": "693", + "name": "694", "members": [ { "name": "key-secret", @@ -20919,27 +20957,27 @@ { "name": "cipher-alg", "default": null, - "type": "650" + "type": "651" }, { "name": "cipher-mode", "default": null, - "type": "651" + "type": "652" }, { "name": "ivgen-alg", "default": null, - "type": "652" + "type": "653" }, { "name": "ivgen-hash-alg", "default": null, - "type": "653" + "type": "654" }, { "name": "hash-alg", "default": null, - "type": "653" + "type": "654" }, { "name": "iter-time", @@ -20950,7 +20988,7 @@ "meta-type": "object" }, { - "name": "694", + "name": "695", "members": [ { "name": "key-secret", @@ -20959,13 +20997,13 @@ { "name": "cipher-alg", "default": null, - "type": "650" + "type": "651" } ], "meta-type": "object" }, { - "name": "695", + "name": "696", "members": [ { "name": "key-secret", @@ -20974,17 +21012,17 @@ { "name": "cipher-alg", "default": null, - "type": "650" + "type": "651" } ], "meta-type": "object" }, { - "name": "696", + "name": "697", "members": [ { "name": "state", - "type": "662" + "type": "663" }, { "name": "new-secret", @@ -21015,7 +21053,7 @@ "meta-type": "object" }, { - "name": "697", + "name": "698", "members": [ { "name": "left" @@ -21059,7 +21097,7 @@ ] }, { - "name": "698", + "name": "699", "members": [ { "name": "x" @@ -21075,7 +21113,7 @@ ] }, { - "name": "699", + "name": "700", "members": [ { "name": "base", @@ -21089,12 +21127,12 @@ "meta-type": "object" }, { - "name": "700", + "name": "701", "tag": "format", "variants": [ { "case": "luks", - "type": "689" + "type": "690" }, { "case": "aes", @@ -21104,18 +21142,18 @@ "members": [ { "name": "format", - "type": "640" + "type": "641" } ], "meta-type": "object" }, { - "name": "[701]", - "element-type": "701", + "name": "[702]", + "element-type": "702", "meta-type": "array" }, { - "name": "701", + "name": "702", "members": [ { "name": "name", @@ -21127,7 +21165,7 @@ }, { "name": "flags", - "type": "[703]" + "type": "[704]" } ], "meta-type": "object" @@ -21138,12 +21176,12 @@ "meta-type": "array" }, { - "name": "[702]", - "element-type": "702", + "name": "[703]", + "element-type": "703", "meta-type": "array" }, { - "name": "702", + "name": "703", "members": [ { "name": "active", @@ -21167,12 +21205,12 @@ "meta-type": "object" }, { - "name": "[703]", - "element-type": "703", + "name": "[704]", + "element-type": "704", "meta-type": "array" }, { - "name": "703", + "name": "704", "members": [ { "name": "in-use" @@ -22954,6 +22992,10 @@ "name": "Conroe-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "cryptodev-backend-lkcf", + "parent": "cryptodev-backend" + }, { "name": "apic", "parent": "apic-common" @@ -24680,6 +24722,12 @@ "description": "on/off", "type": "bool" }, + { + "default-value": true, + "name": "queue_reset", + "description": "on/off", + "type": "bool" + }, { "default-value": true, "name": "write-zeroes", @@ -25094,6 +25142,12 @@ "name": "x-mtu-bypass-backend", "type": "bool" }, + { + "default-value": true, + "name": "queue_reset", + "description": "on/off", + "type": "bool" + }, { "default-value": true, "name": "ctrl_rx_extra", @@ -25334,6 +25388,11 @@ "description": "on/off", "type": "bool" }, + { + "default-value": true, + "name": "use-started", + "type": "bool" + }, { "default-value": true, "name": "use-disabled-flag", @@ -25390,7 +25449,8 @@ }, { "default-value": true, - "name": "use-started", + "name": "queue_reset", + "description": "on/off", "type": "bool" }, { @@ -26873,6 +26933,12 @@ "description": "on/off", "type": "bool" }, + { + "default-value": true, + "name": "queue_reset", + "description": "on/off", + "type": "bool" + }, { "default-value": false, "name": "packed", @@ -26924,8 +26990,8 @@ { "return": [ { - "default-value": false, - "name": "packed", + "default-value": true, + "name": "queue_reset", "description": "on/off", "type": "bool" }, @@ -26934,6 +27000,12 @@ "name": "use-disabled-flag", "type": "bool" }, + { + "default-value": false, + "name": "packed", + "description": "on/off", + "type": "bool" + }, { "default-value": false, "name": "iommu_platform", @@ -27330,13 +27402,13 @@ }, { "default-value": true, - "name": "event_idx", - "description": "on/off", + "name": "use-disabled-flag", "type": "bool" }, { "default-value": true, - "name": "use-disabled-flag", + "name": "event_idx", + "description": "on/off", "type": "bool" }, { @@ -27364,6 +27436,10 @@ "description": "on/off", "type": "bool" }, + { + "name": "iothread", + "type": "link<iothread>" + }, { "default-value": true, "name": "notify_on_empty", @@ -27371,8 +27447,10 @@ "type": "bool" }, { - "name": "iothread", - "type": "link<iothread>" + "default-value": true, + "name": "queue_reset", + "description": "on/off", + "type": "bool" }, { "default-value": false, @@ -27431,8 +27509,8 @@ { "return": [ { - "default-value": false, - "name": "packed", + "default-value": true, + "name": "queue_reset", "description": "on/off", "type": "bool" }, @@ -27441,6 +27519,12 @@ "name": "use-disabled-flag", "type": "bool" }, + { + "default-value": false, + "name": "packed", + "description": "on/off", + "type": "bool" + }, { "default-value": false, "name": "iommu_platform", @@ -27557,6 +27641,11 @@ "name": "x-scalable-mode", "type": "bool" }, + { + "default-value": true, + "name": "dma-translation", + "type": "bool" + }, { "default-value": false, "name": "caching-mode", @@ -27584,8 +27673,8 @@ "type": "bool" }, { - "default-value": true, - "name": "dma-translation", + "default-value": false, + "name": "x-pasid-mode", "type": "bool" }, { @@ -27982,8 +28071,8 @@ { "return": [ { - "default-value": false, - "name": "packed", + "default-value": true, + "name": "queue_reset", "description": "on/off", "type": "bool" }, @@ -27992,6 +28081,12 @@ "name": "use-disabled-flag", "type": "bool" }, + { + "default-value": false, + "name": "packed", + "description": "on/off", + "type": "bool" + }, { "default-value": false, "name": "iommu_platform", @@ -28241,6 +28336,10 @@ "name": "node", "type": "uint32" }, + { + "name": "requested-size", + "type": "size" + }, { "default-value": false, "name": "x-disable-legacy-check", @@ -28253,8 +28352,10 @@ "type": "bool" }, { - "name": "requested-size", - "type": "size" + "default-value": true, + "name": "queue_reset", + "description": "on/off", + "type": "bool" }, { "default-value": true, @@ -28460,6 +28561,12 @@ "name": "use-disabled-flag", "type": "bool" }, + { + "default-value": true, + "name": "queue_reset", + "description": "on/off", + "type": "bool" + }, { "name": "virtio-backend", "type": "child<virtio-iommu-device>" @@ -33190,11 +33297,6 @@ "return": [ { "parameters": [ - { - "name": "zpcii-disable", - "help": "disable zPCI interpretation facilities", - "type": "boolean" - }, { "name": "loadparm", "help": "Up to 8 chars in set of [A-Za-z0-9. ](lower case chars converted to upper case) to pass to machine loader, boot manager, and guest kernel", diff --git a/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml b/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml index b478c53502..0fa042a339 100644 --- a/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml @@ -200,10 +200,10 @@ <flag name='query-stats'/> <flag name='query-stats-schemas'/> <flag name='thread-context'/> - <version>7001050</version> + <version>7001091</version> <kvmVersion>0</kvmVersion> <microcodeVersion>43100245</microcodeVersion> - <package>v7.1.0-1579-g5107fd3eff</package> + <package>v7.2.0-rc1</package> <arch>x86_64</arch> <hostCPU type='kvm' model='base' migratability='yes'> <property name='vmx-entry-load-rtit-ctl' type='boolean' value='false'/> -- 2.37.3

2 1

[libvirt PATCH 0/1] Fix the failing integration CI stage
by Erik Skultety 16 Nov '22

16 Nov '22

Avocado has changed something in their internals between v98.0 and v99.0 which caused our TCK test suite to start failing in GitLab. The problem could not be identified easily because GitLab doesn't run 'after_script' when a job timeout is reached [1]. Avocado issue created here [2]. Here's a successful pipeline with the patch applied [3]. [1] https://gitlab.com/gitlab-org/gitlab/-/issues/15603 [2] https://github.com/avocado-framework/avocado/issues/5521 [3] https://gitlab.com/eskultety/libvirt/-/pipelines/695512878 Erik Skultety (1): ci: integration: Lock the Avocado version to 98.0 for now ci/integration-template.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.38.1

2 2

[PATCH 0/7] qemu: Make memory allocation NUMA aware
by Michal Privoznik 15 Nov '22

15 Nov '22

See 2/7 for explanation. Michal Prívozník (7): qemu_capabilities: Introduce QEMU_CAPS_THREAD_CONTEXT qemu_command: Introduce qemuBuildThreadContextProps() qemu: Delete thread-context objects at domain startup qemu_command: Generate thread-context object for guest NUMA memory qemu: Generate thread-context object for memory devices qemu_command: Generate thread-context object for main guest memory qemu_hotplug: Generate thread-context object for memory device src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 83 +++++++++++++++++++ src/qemu/qemu_command.h | 5 ++ src/qemu/qemu_domain.c | 2 + src/qemu/qemu_domain.h | 2 + src/qemu/qemu_hotplug.c | 22 +++++ src/qemu/qemu_process.c | 47 +++++++++++ src/qemu/qemu_process.h | 2 + .../caps_7.2.0.x86_64.xml | 1 + .../hugepages-memaccess.x86_64-latest.args | 15 ++-- .../hugepages-memaccess2.x86_64-latest.args | 15 ++-- ...pages-numa-default-dimm.x86_64-latest.args | 3 +- .../hugepages-shared.x86_64-latest.args | 12 ++- ...memory-default-hugepage.x86_64-latest.args | 3 +- .../memfd-memory-numa.x86_64-latest.args | 6 +- ...emory-hotplug-dimm-addr.x86_64-latest.args | 3 +- ...mory-hotplug-virtio-mem.x86_64-latest.args | 3 +- .../numatune-memnode.x86_64-latest.args | 9 +- .../numatune-system-memory.x86_64-latest.args | 3 +- .../pages-dimm-discard.x86_64-latest.args | 3 +- 21 files changed, 217 insertions(+), 25 deletions(-) -- 2.37.4

3 15

[PATCH 0/2] Fix virt-qemu-run with network interface
by Martin Kletzander 15 Nov '22

15 Nov '22

yay, blurb Martin Kletzander (2): util: Remove return value from virTypedParamsCopy virGetConnectGeneric: Only delegate existing identities src/driver.c | 14 ++++++-------- src/libvirt-domain.c | 3 +-- src/util/viridentity.c | 10 ++++------ src/util/virtypedparam.c | 6 ++---- src/util/virtypedparam.h | 6 +++--- src/vz/vz_driver.c | 3 +-- 6 files changed, 17 insertions(+), 25 deletions(-) -- 2.38.1

2 3

[libvirt PATCH] ci: regenerate with lcitool manifest
by Daniel P. Berrangé 14 Nov '22

14 Nov '22

Two notable changes: * the macOS platform has switched from x86_64 to aarch64 * if a new pipeline starts before a previous one finishes, jobs marked 'interruptible: true' will be auto-cancelled Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NB: the macOS changes are pending on approval of: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/333 ci/gitlab.yml | 1 + ci/gitlab/build-templates.yml | 37 ++++++++++++++++++------------- ci/gitlab/builds.yml | 6 ++--- ci/gitlab/container-templates.yml | 1 + ci/gitlab/sanity-checks.yml | 1 + ci/manifest.yml | 2 +- 6 files changed, 28 insertions(+), 20 deletions(-) diff --git a/ci/gitlab.yml b/ci/gitlab.yml index bdc5e0a96f..3866dcf545 100644 --- a/ci/gitlab.yml +++ b/ci/gitlab.yml @@ -67,6 +67,7 @@ workflow: debug: image: docker.io/library/alpine:3 stage: sanity_checks + interruptible: true needs: [] script: - printenv | sort diff --git a/ci/gitlab/build-templates.yml b/ci/gitlab/build-templates.yml index 5d7d6c59c5..259cf2b173 100644 --- a/ci/gitlab/build-templates.yml +++ b/ci/gitlab/build-templates.yml @@ -9,14 +9,14 @@ # We use pre-built containers for any pipelines that are: # # - Validating code committed on default upstream branch -# - Validating patches targetting default upstream branch +# - Validating patches targeting default upstream branch # which do not have CI changes # # We use a local build env for any pipelines that are: # # - Validating code committed to a non-default upstream branch -# - Validating patches targetting a non-default upstream branch -# - Validating patches targetting default upstream branch which +# - Validating patches targeting a non-default upstream branch +# - Validating patches targeting default upstream branch which # include CI changes # - Validating code committed to a fork branch # @@ -26,6 +26,7 @@ .gitlab_native_build_job_prebuilt_env: image: $CI_REGISTRY/$RUN_UPSTREAM_NAMESPACE/libvirt/ci-$NAME:latest stage: builds + interruptible: true before_script: - cat /packages.txt rules: @@ -36,14 +37,14 @@ - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH' when: on_success - # upstream: other web/api/scheduled pipelines targetting the default branch + # upstream: other web/api/scheduled pipelines targeting the default branch - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/ && $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' when: manual allow_failure: true - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/ && $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH' when: on_success - # upstream+forks: merge requests targetting the default branch, without CI changes + # upstream+forks: merge requests targeting the default branch, without CI changes - if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME == $CI_DEFAULT_BRANCH' changes: - ci/gitlab/container-templates.yml @@ -61,6 +62,7 @@ .gitlab_native_build_job_local_env: image: $IMAGE stage: builds + interruptible: true before_script: - source ci/buildenv/$NAME.sh - install_buildenv @@ -79,7 +81,7 @@ - if: '$CI_PROJECT_NAMESPACE != $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE == "push" && $RUN_PIPELINE' when: on_success - # upstream: other web/api/scheduled pipelines targetting non-default branches + # upstream: other web/api/scheduled pipelines targeting non-default branches - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/ && $CI_COMMIT_REF_NAME != $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' when: manual allow_failure: true @@ -93,7 +95,7 @@ - if: '$CI_PROJECT_NAMESPACE != $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/' when: on_success - # upstream+forks: merge requests targetting the default branch, with CI changes + # upstream+forks: merge requests targeting the default branch, with CI changes - if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME == $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' changes: - ci/gitlab/container-templates.yml @@ -106,7 +108,7 @@ - ci/containers/$NAME.Dockerfile when: on_success - # upstream+forks: merge requests targetting non-default branches + # upstream+forks: merge requests targeting non-default branches - if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME != $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' when: manual allow_failure: true @@ -121,14 +123,14 @@ # We use pre-built containers for any pipelines that are: # # - Validating code committed on default upstream branch -# - Validating patches targetting default upstream branch +# - Validating patches targeting default upstream branch # which do not have CI changes # # We use a local build env for any pipelines that are: # # - Validating code committed to a non-default upstream branch -# - Validating patches targetting a non-default upstream branch -# - Validating patches targetting default upstream branch which +# - Validating patches targeting a non-default upstream branch +# - Validating patches targeting default upstream branch which # include CI changes # - Validating code committed to a fork branch # @@ -138,6 +140,7 @@ .gitlab_cross_build_job_prebuilt_env: image: $CI_REGISTRY/$RUN_UPSTREAM_NAMESPACE/libvirt/ci-$NAME-cross-$CROSS:latest stage: builds + interruptible: true before_script: - cat /packages.txt rules: @@ -148,14 +151,14 @@ - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE == "push" && $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH' when: on_success - # upstream: other web/api/scheduled pipelines targetting the default branch + # upstream: other web/api/scheduled pipelines targeting the default branch - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/ && $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' when: manual allow_failure: true - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/ && $CI_COMMIT_REF_NAME == $CI_DEFAULT_BRANCH' when: on_success - # upstream+forks: merge requests targetting the default branch, without CI changes + # upstream+forks: merge requests targeting the default branch, without CI changes - if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME == $CI_DEFAULT_BRANCH' changes: - ci/gitlab/container-templates.yml @@ -173,6 +176,7 @@ .gitlab_cross_build_job_local_env: image: $IMAGE stage: builds + interruptible: true before_script: - source ci/buildenv/$NAME.sh - install_buildenv @@ -191,7 +195,7 @@ - if: '$CI_PROJECT_NAMESPACE != $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE == "push" && $RUN_PIPELINE' when: on_success - # upstream: other web/api/scheduled pipelines targetting non-default branches + # upstream: other web/api/scheduled pipelines targeting non-default branches - if: '$CI_PROJECT_NAMESPACE == $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/ && $CI_COMMIT_REF_NAME != $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' when: manual allow_failure: true @@ -205,7 +209,7 @@ - if: '$CI_PROJECT_NAMESPACE != $RUN_UPSTREAM_NAMESPACE && $CI_PIPELINE_SOURCE =~ /(web|api|schedule)/' when: on_success - # upstream+forks: merge requests targetting the default branch, with CI changes + # upstream+forks: merge requests targeting the default branch, with CI changes - if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME == $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' changes: - ci/gitlab/container-templates.yml @@ -218,7 +222,7 @@ - ci/containers/$NAME.Dockerfile when: on_success - # upstream+forks: merge requests targetting non-default branches + # upstream+forks: merge requests targeting non-default branches - if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TARGET_BRANCH_NAME != $CI_DEFAULT_BRANCH && $JOB_OPTIONAL' when: manual allow_failure: true @@ -232,6 +236,7 @@ .cirrus_build_job: stage: builds image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master + interruptible: true needs: [] script: - source ci/cirrus/$NAME.vars diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index e2f2f39320..0e2daebe97 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -860,14 +860,14 @@ x86_64-freebsd-13: UPGRADE_COMMAND: pkg upgrade -y -x86_64-macos-12: +aarch64-macos-12: extends: .cirrus_build_job needs: [] allow_failure: false variables: - CIRRUS_VM_IMAGE_NAME: monterey-base + CIRRUS_VM_IMAGE_NAME: ghcr.io/cirruslabs/macos-monterey-base:latest CIRRUS_VM_IMAGE_SELECTOR: image - CIRRUS_VM_INSTANCE_TYPE: osx_instance + CIRRUS_VM_INSTANCE_TYPE: macos_instance INSTALL_COMMAND: brew install NAME: macos-12 PATH_EXTRA: /usr/local/opt/ccache/libexec:/usr/local/opt/gettext/bin:/usr/local/opt/libpcap/bin:/usr/local/opt/libxslt/bin:/usr/local/opt/rpcgen/bin diff --git a/ci/gitlab/container-templates.yml b/ci/gitlab/container-templates.yml index a577028d11..edb4aba676 100644 --- a/ci/gitlab/container-templates.yml +++ b/ci/gitlab/container-templates.yml @@ -16,6 +16,7 @@ .container_job: image: docker:stable stage: containers + interruptible: false needs: [] services: - docker:dind diff --git a/ci/gitlab/sanity-checks.yml b/ci/gitlab/sanity-checks.yml index f843c7f708..cdcfb9bf91 100644 --- a/ci/gitlab/sanity-checks.yml +++ b/ci/gitlab/sanity-checks.yml @@ -9,6 +9,7 @@ check-dco: stage: sanity_checks needs: [] image: registry.gitlab.com/libvirt/libvirt-ci/check-dco:master + interruptible: true script: - /check-dco "$RUN_UPSTREAM_NAMESPACE" rules: diff --git a/ci/manifest.yml b/ci/manifest.yml index 865a82a4a9..2aec92dd26 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -175,7 +175,7 @@ targets: macos-12: jobs: - - arch: x86_64 + - arch: aarch64 variables: PATH_EXTRA: /usr/local/opt/ccache/libexec:/usr/local/opt/gettext/bin:/usr/local/opt/libpcap/bin:/usr/local/opt/libxslt/bin:/usr/local/opt/rpcgen/bin PKG_CONFIG_PATH: /usr/local/opt/curl/lib/pkgconfig:/usr/local/opt/libpcap/lib/pkgconfig:/usr/local/opt/libxml2/lib/pkgconfig:/usr/local/opt/ncurses/lib/pkgconfig:/usr/local/opt/readline/lib/pkgconfig -- 2.37.3

2 1

[libvirt PATCH][pushed] Fix spelling
by Tim Wiederhake 14 Nov '22

14 Nov '22

Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- NEWS.rst | 2 +- src/qemu/qemu.conf.in | 2 +- src/qemu/qemu_monitor.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/NEWS.rst b/NEWS.rst index e584bc1fed..2ce8ef4b6a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -218,7 +218,7 @@ v8.5.0 (2022-07-01) * qemu: Add support for zero-copy migration With QEMU 7.1.0, libvirt can enable zerocopy for parallel migration. This - is implmented by adding a new ``VIR_MIGRATE_ZEROCOPY`` flag(``virsh migrate + is implemented by adding a new ``VIR_MIGRATE_ZEROCOPY`` flag(``virsh migrate --zerocopy``). * Introduce thread_pool_min and thread_pool_max attributes to IOThread diff --git a/src/qemu/qemu.conf.in b/src/qemu/qemu.conf.in index 623da72d60..3895d42514 100644 --- a/src/qemu/qemu.conf.in +++ b/src/qemu/qemu.conf.in @@ -963,7 +963,7 @@ # "vcpus" - only QEMU vCPU threads are placed into a separate scheduling group, # emulator threads and helper processes remain outside of the group # "emulator" - only QEMU and its threads (emulator + vCPUs) are placed into -# separate scheduling group, helper proccesses remain outside of +# separate scheduling group, helper processes remain outside of # the group # "full" - both QEMU and its helper processes are placed into separate # scheduling group diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 8ada16154c..80f262cec7 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -4346,7 +4346,7 @@ qemuMonitorQueryStatsProviderNew(qemuMonitorQueryStatsProviderType provider_type /* * This can be lowered later in case of the enum getting quite large, hence - * the virBitmapSetExpand below which also incidently makes this function + * the virBitmapSetExpand below which also incidentally makes this function * non-fallible. */ provider->names = virBitmapNew(QEMU_MONITOR_QUERY_STATS_NAME_LAST); -- 2.36.1

2 1

[PATCH] tests: Fix libxlxml2domconfigtest
by Jim Fehlig 11 Nov '22

11 Nov '22

Downstream CI recently encountered failures of libxlxml2domconfigtest when building libvirt packages against Xen 4.17 rc3 packages. The test fails on vnuma_hvm config, where suddently the actual json produced by libxl_domain_config_to_json() contains a 'pnode' entry in the 'vnuma_nodes' list, which is absent in the expected json. It appears the test has thus far passed by luck. E.g. I was able to make the test pass in the failing environment by changing the meson buildtype from debugoptimized to debug. When a VM config contains vnuma settings, libxlMakeVnumaList() checks if the number of requested vnuma nodes exceeds the number of physical nodes. The number of physical nodes is retrieved with libxl_get_physinfo(), which can return wildly different results in the context of unit tests. This change mocks libxl_get_physinfo() to return consistent results. All fields of the libxl_physinfo struct are set to 0 except nr_nodes, which is set to 6 to ensure the vnuma_hvm configuration is properly tested. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- tests/libxlmock.c | 15 +++++++++++++++ tests/libxlxml2domconfigdata/vnuma-hvm.json | 5 +++++ 2 files changed, 20 insertions(+) diff --git a/tests/libxlmock.c b/tests/libxlmock.c index 4754597e5b..205d34df19 100644 --- a/tests/libxlmock.c +++ b/tests/libxlmock.c @@ -70,6 +70,21 @@ VIR_MOCK_IMPL_RET_ARGS(libxl_get_version_info, return &info; } +VIR_MOCK_IMPL_RET_ARGS(libxl_get_physinfo, + int, + libxl_ctx *, ctx, + libxl_physinfo *, physinfo) +{ + memset(physinfo, 0, sizeof(*physinfo)); + physinfo->nr_nodes = 6; + + /* silence gcc warning about unused function */ + if (0) + real_libxl_get_physinfo(ctx, physinfo); + + return 0; +} + VIR_MOCK_STUB_RET_ARGS(libxl_get_free_memory, int, 0, libxl_ctx *, ctx, diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm.json b/tests/libxlxml2domconfigdata/vnuma-hvm.json index 2556c82d5f..c90ee823a4 100644 --- a/tests/libxlxml2domconfigdata/vnuma-hvm.json +++ b/tests/libxlxml2domconfigdata/vnuma-hvm.json @@ -39,6 +39,7 @@ 41, 51 ], + "pnode": 1, "vcpus": [ 1 ] @@ -53,6 +54,7 @@ 31, 41 ], + "pnode": 2, "vcpus": [ 2 ] @@ -67,6 +69,7 @@ 21, 31 ], + "pnode": 3, "vcpus": [ 3 ] @@ -81,6 +84,7 @@ 10, 21 ], + "pnode": 4, "vcpus": [ 4 ] @@ -95,6 +99,7 @@ 21, 10 ], + "pnode": 5, "vcpus": [ 5 ] -- 2.37.3

2 2

[PATCH] qemu_validate: Use proper printf directive for ssize_t
by Michal Privoznik 11 Nov '22

11 Nov '22

In one of recent commits an error message was introduced. In this message a variable of type ssize_t is being printed out, but the corresponding format directive is %ld instead of %zd which breaks on 32bits systems. Switch to proper format. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/qemu/qemu_validate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index bd040c7ff8..c687df0bfc 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -5047,7 +5047,7 @@ qemuValidateDomainDeviceDefMemory(virDomainMemoryDef *mem, while ((node = virBitmapNextSetBit(mem->sourceNodes, node)) >= 0) { if (mem->size > sgxCaps->sgxSections[node].size) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("sgx epc size %lld on host node %ld is less than requested size %lld"), + _("sgx epc size %lld on host node %zd is less than requested size %lld"), sgxCaps->sgxSections[node].size, node, mem->size); return -1; } -- 2.37.4

1 0

[libvirt][PATCH v17 0/9] Support query and use SGX
by Lin Yang 11 Nov '22

11 Nov '22

Diff to v16: * Included SGX EPC in the calculation and validation of maximum memory space in qemuDomainDefValidateMemoryHotplug. Removed all hacking in this function, but only skip qemuDomainDefValidateMemoryHotplugDevice validation for SGX EPC, since it is not hotpluggable. * Added SGX fields in new QEMU 7.2 domaincaps xml. Haibin Huang (4): domain_capabilities: Define SGX capabilities structs qemu: Get SGX capabilities form QMP Convert QMP capabilities to domain capabilities conf: expose SGX feature in domain capabilities Lin Yang (2): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend Michal Prívozník (3): qemu_cgroup: Allow SGX in devices controller qemu_namespace: Create SGX related nodes in domain's namespace security_dac: Set DAC label on SGX /dev nodes docs/formatdomain.rst | 25 +- docs/formatdomaincaps.rst | 40 ++++ src/conf/domain_capabilities.c | 47 ++++ src/conf/domain_capabilities.h | 22 ++ src/conf/domain_conf.c | 30 +++ src/conf/domain_conf.h | 1 + src/conf/domain_postparse.c | 1 + src/conf/domain_validate.c | 9 + src/conf/schemas/domaincaps.rng | 43 ++++ src/conf/schemas/domaincommon.rng | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_alias.c | 6 +- src/qemu/qemu_capabilities.c | 220 ++++++++++++++++++ src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_cgroup.c | 78 ++++++- src/qemu/qemu_command.c | 66 +++++- src/qemu/qemu_domain.c | 28 ++- src/qemu/qemu_domain.h | 2 + src/qemu/qemu_domain_address.c | 6 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_monitor.c | 10 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 154 +++++++++++- src/qemu/qemu_monitor_json.h | 4 + src/qemu/qemu_namespace.c | 20 +- src/qemu/qemu_process.c | 2 + src/qemu/qemu_validate.c | 40 ++++ src/security/security_apparmor.c | 1 + src/security/security_dac.c | 46 ++-- src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.sparc.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 1 + .../qemu_5.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.0.0-tcg.x86_64.xml | 1 + .../qemu_6.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_6.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_6.2.0-tcg.x86_64.xml | 1 + .../qemu_6.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_6.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 10 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 10 + .../qemu_7.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 10 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 1 + .../caps_6.2.0.x86_64.replies | 21 +- .../caps_7.0.0.x86_64.replies | 34 ++- .../caps_7.0.0.x86_64.xml | 11 + .../caps_7.1.0.x86_64.replies | 21 +- .../caps_7.2.0.x86_64.replies | 21 +- .../sgx-epc.x86_64-7.0.0.args | 40 ++++ tests/qemuxml2argvdata/sgx-epc.xml | 65 ++++++ tests/qemuxml2argvtest.c | 2 + .../sgx-epc.x86_64-7.0.0.xml | 65 ++++++ tests/qemuxml2xmltest.c | 2 + 98 files changed, 1210 insertions(+), 70 deletions(-) create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml create mode 100644 tests/qemuxml2xmloutdata/sgx-epc.x86_64-7.0.0.xml -- 2.25.1

2 1

[libvirt][PATCH v17 1/9] domain_capabilities: Define SGX capabilities structs
by Lin Yang 11 Nov '22

11 Nov '22

From: Haibin Huang <haibin.huang(a)intel.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> Reviewed-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Haibin Huang <haibin.huang(a)intel.com> --- src/conf/domain_capabilities.c | 11 +++++++++++ src/conf/domain_capabilities.h | 22 ++++++++++++++++++++++ src/libvirt_private.syms | 1 + 3 files changed, 34 insertions(+) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index a7f256e4ec..daeaee3c5c 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -76,6 +76,17 @@ virSEVCapabilitiesFree(virSEVCapability *cap) } +void +virSGXCapabilitiesFree(virSGXCapability *cap) +{ + if (!cap) + return; + + g_free(cap->sgxSections); + g_free(cap); +} + + static void virDomainCapsDispose(void *obj) { diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h index e0cfa75531..1d504a3506 100644 --- a/src/conf/domain_capabilities.h +++ b/src/conf/domain_capabilities.h @@ -208,6 +208,22 @@ struct _virSEVCapability { unsigned int max_es_guests; }; +typedef struct _virSGXSection virSGXSection; +struct _virSGXSection { + unsigned long long size; + unsigned int node; +}; + +typedef struct _virSGXCapability virSGXCapability; +struct _virSGXCapability { + bool flc; + bool sgx1; + bool sgx2; + unsigned long long section_size; + size_t nSgxSections; + virSGXSection *sgxSections; +}; + typedef enum { VIR_DOMAIN_CAPS_FEATURE_IOTHREADS = 0, VIR_DOMAIN_CAPS_FEATURE_VMCOREINFO, @@ -246,6 +262,7 @@ struct _virDomainCaps { virDomainCapsFeatureGIC gic; virSEVCapability *sev; + virSGXCapability *sgx; /* add new domain features here */ virTristateBool features[VIR_DOMAIN_CAPS_FEATURE_LAST]; @@ -296,3 +313,8 @@ void virSEVCapabilitiesFree(virSEVCapability *capabilities); G_DEFINE_AUTOPTR_CLEANUP_FUNC(virSEVCapability, virSEVCapabilitiesFree); + +void +virSGXCapabilitiesFree(virSGXCapability *capabilities); + +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virSGXCapability, virSGXCapabilitiesFree); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 97ff2a43e4..ebd7bc61a8 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -218,6 +218,7 @@ virDomainCapsEnumSet; virDomainCapsFormat; virDomainCapsNew; virSEVCapabilitiesFree; +virSGXCapabilitiesFree; # conf/domain_conf.h -- 2.25.1

1 8

[libvirt][PATCH v16 1/9] domain_capabilities: Define SGX capabilities structs
by Lin Yang 10 Nov '22

10 Nov '22

From: Haibin Huang <haibin.huang(a)intel.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> Signed-off-by: Haibin Huang <haibin.huang(a)intel.com> --- src/conf/domain_capabilities.c | 11 +++++++++++ src/conf/domain_capabilities.h | 22 ++++++++++++++++++++++ src/libvirt_private.syms | 1 + 3 files changed, 34 insertions(+) diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index 653123f293..869b5d68e6 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -76,6 +76,17 @@ virSEVCapabilitiesFree(virSEVCapability *cap) } +void +virSGXCapabilitiesFree(virSGXCapability *cap) +{ + if (!cap) + return; + + g_free(cap->sgxSections); + g_free(cap); +} + + static void virDomainCapsDispose(void *obj) { diff --git a/src/conf/domain_capabilities.h b/src/conf/domain_capabilities.h index a526969cda..3c9fd7f7de 100644 --- a/src/conf/domain_capabilities.h +++ b/src/conf/domain_capabilities.h @@ -193,6 +193,22 @@ struct _virSEVCapability { unsigned int max_es_guests; }; +typedef struct _virSGXSection virSGXSection; +struct _virSGXSection { + unsigned long long size; + unsigned int node; +}; + +typedef struct _virSGXCapability virSGXCapability; +struct _virSGXCapability { + bool flc; + bool sgx1; + bool sgx2; + unsigned long long section_size; + size_t nSgxSections; + virSGXSection *sgxSections; +}; + typedef enum { VIR_DOMAIN_CAPS_FEATURE_IOTHREADS = 0, VIR_DOMAIN_CAPS_FEATURE_VMCOREINFO, @@ -229,6 +245,7 @@ struct _virDomainCaps { virDomainCapsFeatureGIC gic; virSEVCapability *sev; + virSGXCapability *sgx; /* add new domain features here */ virTristateBool features[VIR_DOMAIN_CAPS_FEATURE_LAST]; @@ -277,3 +294,8 @@ void virSEVCapabilitiesFree(virSEVCapability *capabilities); G_DEFINE_AUTOPTR_CLEANUP_FUNC(virSEVCapability, virSEVCapabilitiesFree); + +void +virSGXCapabilitiesFree(virSGXCapability *capabilities); + +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virSGXCapability, virSGXCapabilitiesFree); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 00cb07709d..97b019d00a 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -218,6 +218,7 @@ virDomainCapsEnumSet; virDomainCapsFormat; virDomainCapsNew; virSEVCapabilitiesFree; +virSGXCapabilitiesFree; # conf/domain_conf.h -- 2.25.1

5 15