- Devel - libvirt List Archives

[libvirt] [PATCH] Fix usage of virFileMakePath, it doesn't set errno but returns it
by Matthias Bolte 05 Jul '11

05 Jul '11

Also be explicity about the != 0 check in the few places that weren't. --- src/conf/domain_conf.c | 6 +++--- src/conf/network_conf.c | 2 +- src/conf/nwfilter_conf.c | 4 ++-- src/conf/storage_conf.c | 2 +- src/libxl/libxl_driver.c | 20 ++++++++++---------- src/lxc/lxc_container.c | 16 ++++++++-------- src/lxc/lxc_controller.c | 6 +++--- src/lxc/lxc_driver.c | 2 +- src/network/bridge_driver.c | 6 +++--- src/qemu/qemu_driver.c | 28 ++++++++++++++-------------- src/qemu/qemu_process.c | 6 +++--- src/storage/storage_driver.c | 2 +- src/uml/uml_driver.c | 13 +++++++------ src/util/dnsmasq.c | 2 +- src/util/util.c | 2 +- 15 files changed, 59 insertions(+), 58 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 109a947..2467fcf 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9980,14 +9980,14 @@ int virDomainSaveXML(const char *configDir, const char *xml) { char *configFile = NULL; - int fd = -1, ret = -1; + int fd = -1, ret = -1, err; size_t towrite; if ((configFile = virDomainConfigFile(configDir, def->name)) == NULL) goto cleanup; - if (virFileMakePath(configDir)) { - virReportSystemError(errno, + if ((err = virFileMakePath(configDir)) != 0) { + virReportSystemError(err, _("cannot create config directory '%s'"), configDir); goto cleanup; diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 45ddee2..b0dbd43 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -1119,7 +1119,7 @@ int virNetworkSaveXML(const char *configDir, if ((configFile = virNetworkConfigFile(configDir, def->name)) == NULL) goto cleanup; - if ((err = virFileMakePath(configDir))) { + if ((err = virFileMakePath(configDir)) != 0) { virReportSystemError(err, _("cannot create config directory '%s'"), configDir); diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 127d4be..bd03f67 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -2189,7 +2189,7 @@ int virNWFilterSaveXML(const char *configDir, if ((configFile = virNWFilterConfigFile(configDir, def->name)) == NULL) goto cleanup; - if ((err = virFileMakePath(configDir))) { + if ((err = virFileMakePath(configDir)) != 0) { virReportSystemError(err, _("cannot create config directory '%s'"), configDir); @@ -2576,7 +2576,7 @@ virNWFilterObjSaveDef(virNWFilterDriverStatePtr driver, if (!nwfilter->configFile) { int err; - if ((err = virFileMakePath(driver->configDir))) { + if ((err = virFileMakePath(driver->configDir)) != 0) { virReportSystemError(err, _("cannot create config directory %s"), driver->configDir); diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index ca86f19..8ccfc8c 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1514,7 +1514,7 @@ virStoragePoolObjSaveDef(virStorageDriverStatePtr driver, if (!pool->configFile) { int err; - if ((err = virFileMakePath(driver->configDir))) { + if ((err = virFileMakePath(driver->configDir)) != 0) { virReportSystemError(err, _("cannot create config directory %s"), driver->configDir); diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 7fd257d..0a5ea07 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -854,7 +854,7 @@ libxlStartup(int privileged) { const libxl_version_info *ver_info; char *log_file = NULL; virCommandPtr cmd; - int status, ret = 0; + int status, ret = 0, err; /* Disable libxl driver if non-root */ if (!privileged) { @@ -914,28 +914,28 @@ libxlStartup(int privileged) { "%s", LIBXL_SAVE_DIR) == -1) goto out_of_memory; - if (virFileMakePath(libxl_driver->logDir) != 0) { + if ((err = virFileMakePath(libxl_driver->logDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create log dir '%s': %s"), - libxl_driver->logDir, virStrerror(errno, ebuf, sizeof ebuf)); + libxl_driver->logDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(libxl_driver->stateDir) != 0) { + if ((err = virFileMakePath(libxl_driver->stateDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create state dir '%s': %s"), - libxl_driver->stateDir, virStrerror(errno, ebuf, sizeof ebuf)); + libxl_driver->stateDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(libxl_driver->libDir) != 0) { + if ((err = virFileMakePath(libxl_driver->libDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create lib dir '%s': %s"), - libxl_driver->libDir, virStrerror(errno, ebuf, sizeof ebuf)); + libxl_driver->libDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(libxl_driver->saveDir) != 0) { + if ((err = virFileMakePath(libxl_driver->saveDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create save dir '%s': %s"), - libxl_driver->saveDir, virStrerror(errno, ebuf, sizeof ebuf)); + libxl_driver->saveDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } @@ -3391,7 +3391,7 @@ libxlDomainSetAutostart(virDomainPtr dom, int autostart) if (autostart) { int err; - if ((err = virFileMakePath(driver->autostartDir))) { + if ((err = virFileMakePath(driver->autostartDir)) != 0) { virReportSystemError(err, _("cannot create autostart directory %s"), driver->autostartDir); diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 7924858..b4138c4 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -406,7 +406,7 @@ static int lxcContainerMountBasicFS(virDomainFSDefPtr root) { "none", "/selinux", "selinuxfs" }, #endif }; - int i, rc = -1; + int i, rc = -1, err; char *devpts; if (virAsprintf(&devpts, "/.oldroot%s/dev/pts", root->src) < 0) { @@ -415,8 +415,8 @@ static int lxcContainerMountBasicFS(virDomainFSDefPtr root) } for (i = 0 ; i < ARRAY_CARDINALITY(mnts) ; i++) { - if (virFileMakePath(mnts[i].dst) != 0) { - virReportSystemError(errno, + if ((err = virFileMakePath(mnts[i].dst)) != 0) { + virReportSystemError(err, _("Failed to mkdir %s"), mnts[i].src); goto cleanup; @@ -429,8 +429,8 @@ static int lxcContainerMountBasicFS(virDomainFSDefPtr root) } } - if ((rc = virFileMakePath("/dev/pts") != 0)) { - virReportSystemError(rc, "%s", + if ((err = virFileMakePath("/dev/pts") != 0)) { + virReportSystemError(err, "%s", _("Cannot create /dev/pts")); goto cleanup; } @@ -515,7 +515,7 @@ static int lxcContainerPopulateDevices(void) static int lxcContainerMountNewFS(virDomainDefPtr vmDef) { - int i; + int i, err; /* Pull in rest of container's mounts */ for (i = 0 ; i < vmDef->nfss ; i++) { @@ -531,8 +531,8 @@ static int lxcContainerMountNewFS(virDomainDefPtr vmDef) return -1; } - if (virFileMakePath(vmDef->fss[i]->dst) != 0) { - virReportSystemError(errno, + if ((err = virFileMakePath(vmDef->fss[i]->dst)) != 0) { + virReportSystemError(err, _("Failed to create %s"), vmDef->fss[i]->dst); VIR_FREE(src); diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 7d60090..db3ef21 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -615,7 +615,7 @@ lxcControllerRun(virDomainDefPtr def, int appPty, int handshakefd) { - int rc = -1; + int rc = -1, err; int control[2] = { -1, -1}; int containerhandshake[2] = { -1, -1 }; int containerPty = -1; @@ -690,8 +690,8 @@ lxcControllerRun(virDomainDefPtr def, goto cleanup; } - if (virFileMakePath(devpts) != 0) { - virReportSystemError(errno, + if ((err = virFileMakePath(devpts)) != 0) { + virReportSystemError(err, _("Failed to make path %s"), devpts); goto cleanup; diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 7220a9b..2222365 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -2541,7 +2541,7 @@ static int lxcDomainSetAutostart(virDomainPtr dom, if (autostart) { int err; - if ((err = virFileMakePath(driver->autostartDir))) { + if ((err = virFileMakePath(driver->autostartDir)) != 0) { virReportSystemError(err, _("Cannot create autostart directory %s"), driver->autostartDir); diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 660dd65..517f03d 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2500,7 +2500,7 @@ static int networkSetAutostart(virNetworkPtr net, struct network_driver *driver = net->conn->networkPrivateData; virNetworkObjPtr network; char *configFile = NULL, *autostartLink = NULL; - int ret = -1; + int ret = -1, err; networkDriverLock(driver); network = virNetworkFindByUUID(&driver->networks, net->uuid); @@ -2526,8 +2526,8 @@ static int networkSetAutostart(virNetworkPtr net, goto cleanup; if (autostart) { - if (virFileMakePath(driver->networkAutostartDir)) { - virReportSystemError(errno, + if ((err = virFileMakePath(driver->networkAutostartDir)) != 0) { + virReportSystemError(err, _("cannot create autostart directory '%s'"), driver->networkAutostartDir); goto cleanup; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index aab3ab9..835e3e1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -372,7 +372,7 @@ static int qemudStartup(int privileged) { char *base = NULL; char *driverConf = NULL; - int rc; + int rc, err; virConnectPtr conn = NULL; if (VIR_ALLOC(qemu_driver) < 0) @@ -469,40 +469,40 @@ qemudStartup(int privileged) { goto out_of_memory; } - if (virFileMakePath(qemu_driver->stateDir) != 0) { + if ((err = virFileMakePath(qemu_driver->stateDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create state dir '%s': %s"), - qemu_driver->stateDir, virStrerror(errno, ebuf, sizeof ebuf)); + qemu_driver->stateDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(qemu_driver->libDir) != 0) { + if ((err = virFileMakePath(qemu_driver->libDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create lib dir '%s': %s"), - qemu_driver->libDir, virStrerror(errno, ebuf, sizeof ebuf)); + qemu_driver->libDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(qemu_driver->cacheDir) != 0) { + if ((err = virFileMakePath(qemu_driver->cacheDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create cache dir '%s': %s"), - qemu_driver->cacheDir, virStrerror(errno, ebuf, sizeof ebuf)); + qemu_driver->cacheDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(qemu_driver->saveDir) != 0) { + if ((err = virFileMakePath(qemu_driver->saveDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create save dir '%s': %s"), - qemu_driver->saveDir, virStrerror(errno, ebuf, sizeof ebuf)); + qemu_driver->saveDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(qemu_driver->snapshotDir) != 0) { + if ((err = virFileMakePath(qemu_driver->snapshotDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create save dir '%s': %s"), - qemu_driver->snapshotDir, virStrerror(errno, ebuf, sizeof ebuf)); + qemu_driver->snapshotDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } - if (virFileMakePath(qemu_driver->autoDumpPath) != 0) { + if ((err = virFileMakePath(qemu_driver->autoDumpPath)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create dump dir '%s': %s"), - qemu_driver->autoDumpPath, virStrerror(errno, ebuf, sizeof ebuf)); + qemu_driver->autoDumpPath, virStrerror(err, ebuf, sizeof ebuf)); goto error; } @@ -5019,7 +5019,7 @@ static int qemudDomainSetAutostart(virDomainPtr dom, if (autostart) { int err; - if ((err = virFileMakePath(driver->autostartDir))) { + if ((err = virFileMakePath(driver->autostartDir)) != 0) { virReportSystemError(err, _("cannot create autostart directory %s"), driver->autostartDir); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index f2c439b..d52b0ad 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2336,7 +2336,7 @@ int qemuProcessStart(virConnectPtr conn, const char *stdin_path, enum virVMOperationType vmop) { - int ret; + int ret, err; off_t pos = -1; char ebuf[1024]; char *pidfile = NULL; @@ -2448,8 +2448,8 @@ int qemuProcessStart(virConnectPtr conn, } } - if (virFileMakePath(driver->logDir) != 0) { - virReportSystemError(errno, + if ((err = virFileMakePath(driver->logDir)) != 0) { + virReportSystemError(err, _("cannot create log directory %s"), driver->logDir); goto cleanup; diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index f9652f8..7b95340 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1021,7 +1021,7 @@ storagePoolSetAutostart(virStoragePoolPtr obj, if (autostart) { int err; - if ((err = virFileMakePath(driver->autostartDir))) { + if ((err = virFileMakePath(driver->autostartDir)) != 0) { virReportSystemError(err, _("cannot create autostart directory %s"), driver->autostartDir); diff --git a/src/uml/uml_driver.c b/src/uml/uml_driver.c index a71ea21..fbd8bca 100644 --- a/src/uml/uml_driver.c +++ b/src/uml/uml_driver.c @@ -350,6 +350,7 @@ umlStartup(int privileged) uid_t uid = geteuid(); char *base = NULL; char *userdir = NULL; + int err; if (VIR_ALLOC(uml_driver) < 0) return -1; @@ -420,10 +421,10 @@ umlStartup(int privileged) goto error; } - if (virFileMakePath(uml_driver->monitorDir) != 0) { + if ((err = virFileMakePath(uml_driver->monitorDir)) != 0) { char ebuf[1024]; VIR_ERROR(_("Failed to create monitor directory %s: %s"), - uml_driver->monitorDir, virStrerror(errno, ebuf, sizeof ebuf)); + uml_driver->monitorDir, virStrerror(err, ebuf, sizeof ebuf)); goto error; } @@ -811,7 +812,7 @@ static int umlCleanupTapDevices(virConnectPtr conn ATTRIBUTE_UNUSED, static int umlStartVMDaemon(virConnectPtr conn, struct uml_driver *driver, virDomainObjPtr vm) { - int ret; + int ret, err; char *logfile; int logfd = -1; umlDomainObjPrivatePtr priv = vm->privateData; @@ -839,8 +840,8 @@ static int umlStartVMDaemon(virConnectPtr conn, return -1; } - if (virFileMakePath(driver->logDir) != 0) { - virReportSystemError(errno, + if ((err = virFileMakePath(driver->logDir)) != 0) { + virReportSystemError(err, _("cannot create log directory %s"), driver->logDir); return -1; @@ -2006,7 +2007,7 @@ static int umlDomainSetAutostart(virDomainPtr dom, if (autostart) { int err; - if ((err = virFileMakePath(driver->autostartDir))) { + if ((err = virFileMakePath(driver->autostartDir)) != 0) { virReportSystemError(err, _("cannot create autostart directory %s"), driver->autostartDir); diff --git a/src/util/dnsmasq.c b/src/util/dnsmasq.c index aadca10..27b1dcb 100644 --- a/src/util/dnsmasq.c +++ b/src/util/dnsmasq.c @@ -526,7 +526,7 @@ dnsmasqSave(const dnsmasqContext *ctx) int err; int ret = 0; - if ((err = virFileMakePath(ctx->config_dir))) { + if ((err = virFileMakePath(ctx->config_dir)) != 0) { virReportSystemError(err, _("cannot create config directory '%s'"), ctx->config_dir); return -1; diff --git a/src/util/util.c b/src/util/util.c index 13973c3..e0c625f 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1182,7 +1182,7 @@ int virFileWritePid(const char *dir, goto cleanup; } - if ((rc = virFileMakePath(dir))) + if ((rc = virFileMakePath(dir)) != 0) goto cleanup; if (!(pidfile = virFilePid(dir, name))) { -- 1.7.4.1

2 2

[libvirt] [PATCH] fix the failure of nodedev-reattach caused by the variables from nodedev-attach
by Guannan Ren 05 Jul '11

05 Jul '11

the "virsh nodedev-reattch" command could return successfully, but the pci device is still bound to pci-stub driver. The reason is noddev-reattach trys to use the variables set by nodedev-dettach commands. Becuase these variables is not persistent, this is not we expected. the patch try to fix it. --- src/util/pci.c | 74 +++++++++++++++++++------------------------------------ 1 files changed, 26 insertions(+), 48 deletions(-) diff --git a/src/util/pci.c b/src/util/pci.c index 46a3a83..d345c3e 100644 --- a/src/util/pci.c +++ b/src/util/pci.c @@ -67,9 +67,6 @@ struct _pciDevice { unsigned managed : 1; /* used by reattach function */ - unsigned unbind_from_stub : 1; - unsigned remove_slot : 1; - unsigned reprobe : 1; }; struct _pciDeviceList { @@ -882,14 +879,23 @@ pciUnbindDeviceFromStub(pciDevice *dev, const char *driver) if (pciDriverDir(&drvdir, driver) < 0) goto cleanup; - if (!dev->unbind_from_stub) - goto remove_slot; - - /* If the device is bound to stub, unbind it. - */ if (pciDeviceFile(&path, dev->name, "driver") < 0) goto cleanup; + /* If the device is bound to a driver instead of pci-stub, do nothing. + */ + if (virFileExists(path) && ! virFileLinkPointsTo(path, drvdir)){ + result = 0; + goto cleanup; + } + + /* If the device is not bound to any driver, reprobe it. + */ + if (!virFileExists(path)) + goto reprobe; + + /* If the device is bound to stub, unbind it. + */ if (virFileExists(drvdir) && virFileLinkPointsTo(path, drvdir)) { if (pciDriverFile(&path, driver, "unbind") < 0) { goto cleanup; @@ -902,11 +908,6 @@ pciUnbindDeviceFromStub(pciDevice *dev, const char *driver) goto cleanup; } } - dev->unbind_from_stub = 0; - -remove_slot: - if (!dev->remove_slot) - goto reprobe; /* Xen's pciback.ko wants you to use remove_slot on the specific device */ if (pciDriverFile(&path, driver, "remove_slot") < 0) { @@ -919,14 +920,8 @@ remove_slot: dev->name, driver); goto cleanup; } - dev->remove_slot = 0; reprobe: - if (!dev->reprobe) { - result = 0; - goto cleanup; - } - /* Trigger a re-probe of the device is not in the stub's dynamic * ID table. If the stub is available, but 'remove_id' isn't * available, then re-probing would just cause the device to be @@ -935,6 +930,12 @@ reprobe: if (pciDriverFile(&path, driver, "remove_id") < 0) { goto cleanup; } + + /* If the device is still in stub's dynamic ID table,remove it, + * otherwise, ignore the error. + */ + if (virFileExists(path) && virFileWriteStr(path, dev->name, 0) < 0){ + } if (!virFileExists(drvdir) || virFileExists(path)) { if (virFileWriteStr(PCI_SYSFS "drivers_probe", dev->name, 0) < 0) { @@ -948,11 +949,6 @@ reprobe: result = 0; cleanup: - /* do not do it again */ - dev->unbind_from_stub = 0; - dev->remove_slot = 0; - dev->reprobe = 0; - VIR_FREE(drvdir); VIR_FREE(path); @@ -966,7 +962,6 @@ pciBindDeviceToStub(pciDevice *dev, const char *driver) int result = -1; char *drvdir = NULL; char *path = NULL; - int reprobe = 0; /* check whether the device is already bound to a driver */ if (pciDriverDir(&drvdir, driver) < 0 || @@ -980,7 +975,6 @@ pciBindDeviceToStub(pciDevice *dev, const char *driver) result = 0; goto cleanup; } - reprobe = 1; } /* Add the PCI device ID to the stub's dynamic ID table; @@ -1011,8 +1005,7 @@ pciBindDeviceToStub(pciDevice *dev, const char *driver) } if (virFileLinkPointsTo(path, drvdir)) { - dev->unbind_from_stub = 1; - dev->remove_slot = 1; + result = 0; goto remove_id; } @@ -1022,7 +1015,7 @@ pciBindDeviceToStub(pciDevice *dev, const char *driver) * your root filesystem. */ if (pciDeviceFile(&path, dev->name, "driver/unbind") < 0) { - goto cleanup; + goto remove_id; } if (virFileExists(path)) { @@ -1030,9 +1023,8 @@ pciBindDeviceToStub(pciDevice *dev, const char *driver) virReportSystemError(errno, _("Failed to unbind PCI device '%s'"), dev->name); - goto cleanup; + goto remove_id; } - dev->reprobe = reprobe; } /* If the device isn't already bound to pci-stub, try binding it now. @@ -1054,7 +1046,6 @@ pciBindDeviceToStub(pciDevice *dev, const char *driver) dev->name, driver); goto remove_id; } - dev->remove_slot = 1; if (pciDriverFile(&path, driver, "bind") < 0) { goto remove_id; @@ -1066,20 +1057,15 @@ pciBindDeviceToStub(pciDevice *dev, const char *driver) dev->name, driver); goto remove_id; } - dev->unbind_from_stub = 1; } + result = 0; remove_id: /* If 'remove_id' exists, remove the device id from pci-stub's dynamic * ID table so that 'drivers_probe' works below. */ if (pciDriverFile(&path, driver, "remove_id") < 0) { - /* We do not remove PCI ID from pci-stub, and we cannot reprobe it */ - if (dev->reprobe) { - VIR_WARN("Could not remove PCI ID '%s' from %s, and the device " - "cannot be probed again.", dev->id, driver); - } - dev->reprobe = 0; + result = -1; goto cleanup; } @@ -1087,18 +1073,10 @@ remove_id: virReportSystemError(errno, _("Failed to remove PCI ID '%s' from %s"), dev->id, driver); - - /* remove PCI ID from pci-stub failed, and we cannot reprobe it */ - if (dev->reprobe) { - VIR_WARN("Failed to remove PCI ID '%s' from %s, and the device " - "cannot be probed again.", dev->id, driver); - } - dev->reprobe = 0; + result = -1; goto cleanup; } - result = 0; - cleanup: VIR_FREE(drvdir); VIR_FREE(path); -- 1.7.1

5 8

[libvirt] offline migration / vm cloning with libvirt/virsh
by Sethuraman Subbiah 05 Jul '11

05 Jul '11

Hi , I am trying to perform offline migration (i.e) Create an incremental image using the qcow format, transfer the vm memory state to a state fie.Use the image and statefile together as a template. Now create a new vm using the template. I can successfully do it using the following commands : Save phase : stop migrate "exec:gzip -c > STATEFILE.gz" qemu-img qemu-img create -b BASE_img -f qcow2 INCRE_img Restore phase : qemu-kvm -m 1024 -hda INCRE_img -incoming "exec: gzip -c -d STATEFILE.gz" And it works fine. But I am not able to find the vm with virt-manager or other libvirt based tools. If I use : virsh save <dom_id> STATEFILE I can restore using "virsh restore STATEFILE" but I want to associate this with the incremental image that I created, but I dont know how. I think it saves the existing vm's xml file along with the STATEFILE, thus I am not able to change the disk image to the incremental image. Thus , 1. Either I should find a way to make vms created using qemu-kvm appear in libvirt-based tools. OR 2. Find a way to associate the virsh save STATEFILE with a incremental image. Any help or hint with respect to these will be very helpful. I am try to do cloning with minimal cost. This takes only 25 seconds ( to create STATEFILE) and creating incremental image is instantatenous . But I want to use the vm monitoring code based on libvirt. And it makes life difficult. Thanks for your help. - Regards, Sethuraman Subbiah Graduate Student - NC state University M.S in Computer Science

2 1

[libvirt] [PATCH] build: fix virBufferVasprintf on mingw
by Eric Blake 05 Jul '11

05 Jul '11

Gnulib documents that mingw [v]snprintf is broken (it returns -1 on out-of-space, instead of the count of what would have been printed); but while we were using the snprintf wrapper, we had not yet been using the vsnprintf wrapper. * bootstrap.conf (gnulib_modules): Add vsnprintf. Reported by Matthias Bolte. --- bootstrap.conf | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/bootstrap.conf b/bootstrap.conf index 581d60b..302cce8 100644 --- a/bootstrap.conf +++ b/bootstrap.conf @@ -97,6 +97,7 @@ usleep vasprintf verify vc-list-files +vsnprintf waitpid warnings ' -- 1.7.4.4

2 8

[libvirt] [PATCH] Fix default value of security label 'relabel' attribute
by Daniel P. Berrange 05 Jul '11

05 Jul '11

From: "Daniel P. Berrange" <berrange(a)redhat.com> When no <seclabel> is present in the XML, the virDomainSeclabelDef struct is left as all zeros. Unfortunately, this means it gets setup as type=dynamic, with relabel=no, which is an illegal combination. Change the 'bool relabel' attribute in virDomainSeclabelDef to the inverse 'bool norelabel' so that the default initialization is sensible * src/conf/domain_conf.c, src/conf/domain_conf.h, src/security/security_apparmor.c, src/security/security_selinux.c: Replace 'relabel' with 'norelabel' --- src/conf/domain_conf.c | 18 +++++++++--------- src/conf/domain_conf.h | 2 +- src/security/security_apparmor.c | 8 ++++---- src/security/security_selinux.c | 20 ++++++++++---------- 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 109a947..b74ab4d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5076,25 +5076,25 @@ virSecurityLabelDefParseXML(const virDomainDefPtr def, VIR_SECURITY_LABEL_BUFLEN-1, ctxt); if (p != NULL) { if (STREQ(p, "yes")) { - def->seclabel.relabel = true; + def->seclabel.norelabel = false; } else if (STREQ(p, "no")) { - def->seclabel.relabel = false; + def->seclabel.norelabel = true; } else { virDomainReportError(VIR_ERR_XML_ERROR, _("invalid security relabel value %s"), p); goto error; } if (def->seclabel.type == VIR_DOMAIN_SECLABEL_DYNAMIC && - !def->seclabel.relabel) { + def->seclabel.norelabel) { virDomainReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("dynamic label type must use resource relabeling")); goto error; } } else { if (def->seclabel.type == VIR_DOMAIN_SECLABEL_STATIC) - def->seclabel.relabel = false; + def->seclabel.norelabel = true; else - def->seclabel.relabel = true; + def->seclabel.norelabel = false; } /* Only parse label, if using static labels, or @@ -5114,7 +5114,7 @@ virSecurityLabelDefParseXML(const virDomainDefPtr def, } /* Only parse imagelabel, if requested live XML with relabeling */ - if (def->seclabel.relabel && + if (!def->seclabel.norelabel && !(flags & VIR_DOMAIN_XML_INACTIVE)) { p = virXPathStringLimit("string(./seclabel/imagelabel[1])", VIR_SECURITY_LABEL_BUFLEN-1, ctxt); @@ -9890,15 +9890,15 @@ char *virDomainDefFormat(virDomainDefPtr def, (flags & VIR_DOMAIN_XML_INACTIVE)) { virBufferAsprintf(&buf, " <seclabel type='%s' model='%s' relabel='%s'/>\n", sectype, def->seclabel.model, - def->seclabel.relabel ? "yes" : "no"); + def->seclabel.norelabel ? "no" : "yes"); } else { virBufferAsprintf(&buf, " <seclabel type='%s' model='%s' relabel='%s'>\n", sectype, def->seclabel.model, - def->seclabel.relabel ? "yes" : "no"); + def->seclabel.norelabel ? "no" : "yes"); if (def->seclabel.label) virBufferEscapeString(&buf, " <label>%s</label>\n", def->seclabel.label); - if (def->seclabel.relabel && def->seclabel.imagelabel) + if (!def->seclabel.norelabel && def->seclabel.imagelabel) virBufferEscapeString(&buf, " <imagelabel>%s</imagelabel>\n", def->seclabel.imagelabel); if (def->seclabel.baselabel && diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 258289a..44d5bcd 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -960,7 +960,7 @@ struct _virSecurityLabelDef { char *imagelabel; /* security image label string */ char *baselabel; /* base name of label string */ int type; /* virDomainSeclabelType */ - bool relabel; + bool norelabel; }; enum virDomainTimerNameType { diff --git a/src/security/security_apparmor.c b/src/security/security_apparmor.c index 98995a8..76c6e3d 100644 --- a/src/security/security_apparmor.c +++ b/src/security/security_apparmor.c @@ -265,7 +265,7 @@ reload_profile(virSecurityManagerPtr mgr, int rc = -1; char *profile_name = NULL; - if (!secdef->relabel) + if (secdef->norelabel) return 0; if ((profile_name = get_profile_name(vm)) == NULL) @@ -610,7 +610,7 @@ AppArmorSetSecurityImageLabel(virSecurityManagerPtr mgr, int rc = -1; char *profile_name; - if (!secdef->relabel) + if (secdef->norelabel) return 0; if (!disk->src || disk->type == VIR_DOMAIN_DISK_TYPE_NETWORK) @@ -682,7 +682,7 @@ AppArmorSetSecurityHostdevLabel(virSecurityManagerPtr mgr, struct SDPDOP *ptr; int ret = -1; - if (!secdef->relabel) + if (secdef->norelabel) return 0; if (dev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) @@ -741,7 +741,7 @@ AppArmorRestoreSecurityHostdevLabel(virSecurityManagerPtr mgr, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (!secdef->relabel) + if (secdef->norelabel) return 0; return reload_profile(mgr, vm, NULL, false); diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 44e770e..50e1978 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -537,7 +537,7 @@ SELinuxRestoreSecurityImageLabelInt(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (!secdef->relabel) + if (secdef->norelabel) return 0; /* Don't restore labels on readoly/shared disks, because @@ -621,7 +621,7 @@ SELinuxSetSecurityImageLabel(virSecurityManagerPtr mgr, const virSecurityLabelDefPtr secdef = &vm->def->seclabel; bool allowDiskFormatProbing = virSecurityManagerGetAllowDiskFormatProbing(mgr); - if (!secdef->relabel) + if (secdef->norelabel) return 0; return virDomainDiskDefForeachPath(disk, @@ -661,7 +661,7 @@ SELinuxSetSecurityHostdevLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, const virSecurityLabelDefPtr secdef = &vm->def->seclabel; int ret = -1; - if (!secdef->relabel) + if (secdef->norelabel) return 0; if (dev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) @@ -730,7 +730,7 @@ SELinuxRestoreSecurityHostdevLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, const virSecurityLabelDefPtr secdef = &vm->def->seclabel; int ret = -1; - if (!secdef->relabel) + if (secdef->norelabel) return 0; if (dev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) @@ -784,7 +784,7 @@ SELinuxSetSecurityChardevLabel(virDomainObjPtr vm, char *in = NULL, *out = NULL; int ret = -1; - if (!secdef->relabel) + if (secdef->norelabel) return 0; switch (dev->type) { @@ -830,7 +830,7 @@ SELinuxRestoreSecurityChardevLabel(virDomainObjPtr vm, char *in = NULL, *out = NULL; int ret = -1; - if (!secdef->relabel) + if (secdef->norelabel) return 0; switch (dev->type) { @@ -918,7 +918,7 @@ SELinuxRestoreSecurityAllLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, VIR_DEBUG("Restoring security label on %s", vm->def->name); - if (!secdef->relabel) + if (secdef->norelabel) return 0; for (i = 0 ; i < vm->def->nhostdevs ; i++) { @@ -989,7 +989,7 @@ SELinuxSetSavedStateLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (!secdef->relabel) + if (secdef->norelabel) return 0; return SELinuxSetFilecon(savefile, secdef->imagelabel); @@ -1003,7 +1003,7 @@ SELinuxRestoreSavedStateLabel(virSecurityManagerPtr mgr ATTRIBUTE_UNUSED, { const virSecurityLabelDefPtr secdef = &vm->def->seclabel; - if (!secdef->relabel) + if (secdef->norelabel) return 0; return SELinuxRestoreSecurityFileLabel(savefile); @@ -1218,7 +1218,7 @@ SELinuxSetSecurityAllLabel(virSecurityManagerPtr mgr, const virSecurityLabelDefPtr secdef = &vm->def->seclabel; int i; - if (!secdef->relabel) + if (secdef->norelabel) return 0; for (i = 0 ; i < vm->def->ndisks ; i++) { -- 1.7.6

2 1

[libvirt] networkxml2argvtest fails to compile
by Ruben Kerkhof 05 Jul '11

05 Jul '11

Hi all, Building libvirt 0.9.3 from source with --without-network, make check fails with: CC networkxml2xmltest.o CCLD networkxml2xmltest CC networkxml2argvtest.o make[2]: *** No rule to make target `../src/libvirt_driver_network.la', needed by `networkxml2argvtest'. Stop. make[2]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make[1]: *** [check-am] Error 2 make[1]: Leaving directory `/home/ruben/src/libvirt/libvirt-0.9.3/tests' make: *** [check-recursive] Error 1 Kind regards, Ruben

3 4

[libvirt] [PATCH] qemu: Fix virFileMakePath error handling in snapshot creation
by Matthias Bolte 05 Jul '11

05 Jul '11

virFileMakePath returns an errno value on error, that will never be negative. So a virFileMakePath error whould have been ignored here. --- src/qemu/qemu_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 363a361..aab3ab9 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7498,7 +7498,7 @@ static int qemuDomainSnapshotWriteMetadata(virDomainObjPtr vm, goto cleanup; } err = virFileMakePath(snapDir); - if (err < 0) { + if (err != 0) { virReportSystemError(err, _("cannot create snapshot directory '%s'"), snapDir); goto cleanup; -- 1.7.4.1

2 2

[libvirt] problems with <seclabel> when restarting libvirtd
by Laine Stump 05 Jul '11

05 Jul '11

I had libvirtd build from 0.9.2+something running on my test machine. There was a single guest running on it. I grabbed the latest libvirt from git (0.9.3+??), built an rpm, and installed it. My guest reconnected with no problems, but I was unable to start new guests due to an selinux problem with the labeling of the image file. Interestingly, I found that I could shutdown and restart the one guest that had been running at the time of the upgrade. *Until* I restarted libvirtd again while the guest was stopped. After this point, I could no longer start that guest either. I then set selinux to permissive mode and was able to start my original guest. Then I restarted libvirtd and found that, although the qemu-kvm process was still running, libvirtd couldn't reconnect to the guest. When I looked at the logs, I saw this: error: virSecurityLabelDefParseXML:5073 : unsupported configuration: dynamic label type must use resource relabeling In the domain state file, I see this: | <seclabel type='dynamic' model='selinux' relabel='no'> | <label>system_u:system_r:svirt_t:s-:c419,c955</label> | </seclabel> The data in the state file was written by the same version of libvirtd that wrote it. So why did it write something it knows it doesn't support?

2 1

[libvirt] Duplicate symbol error with 0.9.3 on OSX
by Justin Clift 05 Jul '11

05 Jul '11

Hi all, Just went to update the OSX libvirt build for 0.9.3, but it's giving a duplicate symbol error: ld: duplicate symbol _virNetworkDNSHostsDef in ./.libs/libvirt_driver_test.a(libvirt_driver_test_la-test_driver.o) and ./.libs/libvirt_conf.a(libvirt_conf_la-network_conf.o) "virNetworkDNSHostsDef" is definitely in src/conf/network_conf.*, but not seeing it anywhere in src/test/test_driver.*. Anyone have suggestions on what to look at? Regards and best wishes, Justin Clift -- Aeolus Community Manager http://www.aeolusproject.org

2 4

[libvirt] [PATCH] Quieten build & ensure API build scripts exit with non-zero status
by Daniel P. Berrange 04 Jul '11

04 Jul '11

The current API build scripts will continue and exit with a zero status even if they find problems. This has been the cause of many build problems, or hidden build errors, in the past. Change the scripts so they always exit with a non-zero status for any problems they do not understand. Also turn off all debug output by default so they respect $(AM_V_GEN) * docs/Makefile.am: Use $(AM_V_GEN) for API/HTML scripts * docs/apibuild.py, python/generator.py: Exit with non-zero status if problems are found. Also be silent, not outputting any debug messages. * src/Makefile.am: Use $(AM_V_GEN) for ESX generator * python/Makefile.am: Tweak rule --- docs/Makefile.am | 11 ++---- docs/apibuild.py | 95 ++++++++++++++++++++++++++++++-------------------- python/Makefile.am | 6 ++-- python/generator.py | 16 +++++--- src/Makefile.am | 2 +- 5 files changed, 75 insertions(+), 55 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 050ebe1..e7d356e 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -153,21 +153,18 @@ internals/%.html.tmp: internals/%.html.in subsite.xsl page.xsl sitemap.html.in html/index.html: libvirt-api.xml newapi.xsl page.xsl sitemap.html.in - -@if [ -x $(XSLTPROC) ] ; then \ - echo "Rebuilding the HTML pages from the XML API" ; \ + $(AM_V_GEN)if [ -x $(XSLTPROC) ] ; then \ $(XSLTPROC) --nonet -o $(srcdir)/ \ - $(srcdir)/newapi.xsl $(srcdir)/libvirt-api.xml ; fi - -@if test -x $(XMLLINT) && test -x $(XMLCATALOG) ; then \ + $(srcdir)/newapi.xsl $(srcdir)/libvirt-api.xml ; fi ; \ + if test -x $(XMLLINT) && test -x $(XMLCATALOG) ; then \ if $(XMLCATALOG) '$(XML_CATALOG_FILE)' "-//W3C//DTD XHTML 1.0 Strict//EN" \ > /dev/null ; then \ - echo "Validating the resulting XHTML pages" ; \ SGML_CATALOG_FILES='$(XML_CATALOG_FILE)' \ $(XMLLINT) --catalogs --nonet --valid --noout $(srcdir)/html/*.html ; \ else echo "missing XHTML1 DTD" ; fi ; fi $(addprefix $(srcdir)/,$(devhelphtml)): $(srcdir)/libvirt-api.xml $(devhelpxsl) - -@echo Rebuilding devhelp files - -@if [ -x $(XSLTPROC) ] ; then \ + $(AM_V_GEN)if [ -x $(XSLTPROC) ] ; then \ $(XSLTPROC) --nonet -o $(srcdir)/devhelp/ \ $(top_srcdir)/docs/devhelp/devhelp.xsl $(srcdir)/libvirt-api.xml ; fi diff --git a/docs/apibuild.py b/docs/apibuild.py index f31a853..cb273dc 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -11,6 +11,8 @@ import os, sys import string import glob +quiet=1 +warnings=0 debug=0 debugsym=None @@ -95,7 +97,7 @@ class identifier: self.conditionals = None else: self.conditionals = conditionals[:] - if self.name == debugsym: + if self.name == debugsym and not quiet: print "=> define %s : %s" % (debugsym, (module, type, info, extra, conditionals)) @@ -155,7 +157,7 @@ class identifier: def update(self, header, module, type = None, info = None, extra=None, conditionals=None): - if self.name == debugsym: + if self.name == debugsym and not quiet: print "=> update %s : %s" % (debugsym, (module, type, info, extra, conditionals)) if header != None and self.header == None: @@ -203,7 +205,7 @@ class index: if d != None and name != None and type != None: self.references[name] = d - if name == debugsym: + if name == debugsym and not quiet: print "New ref: %s" % (d) return d @@ -244,9 +246,9 @@ class index: elif type == "macro": self.macros[name] = d else: - print "Unable to register type ", type + self.warning("Unable to register type ", type) - if name == debugsym: + if name == debugsym and not quiet: print "New symbol: %s" % (d) return d @@ -260,8 +262,8 @@ class index: if self.macros.has_key(id): del self.macros[id] if self.functions.has_key(id): - print "function %s from %s redeclared in %s" % ( - id, self.functions[id].header, idx.functions[id].header) + self.warning("function %s from %s redeclared in %s" % ( + id, self.functions[id].header, idx.functions[id].header)) else: self.functions[id] = idx.functions[id] self.identifiers[id] = idx.functions[id] @@ -273,15 +275,15 @@ class index: if self.macros.has_key(id): del self.macros[id] if self.variables.has_key(id): - print "variable %s from %s redeclared in %s" % ( - id, self.variables[id].header, idx.variables[id].header) + self.warning("variable %s from %s redeclared in %s" % ( + id, self.variables[id].header, idx.variables[id].header)) else: self.variables[id] = idx.variables[id] self.identifiers[id] = idx.variables[id] for id in idx.structs.keys(): if self.structs.has_key(id): - print "struct %s from %s redeclared in %s" % ( - id, self.structs[id].header, idx.structs[id].header) + self.warning("struct %s from %s redeclared in %s" % ( + id, self.structs[id].header, idx.structs[id].header)) else: self.structs[id] = idx.structs[id] self.identifiers[id] = idx.structs[id] @@ -294,8 +296,8 @@ class index: self.identifiers[id] = idx.unions[id] for id in idx.typedefs.keys(): if self.typedefs.has_key(id): - print "typedef %s from %s redeclared in %s" % ( - id, self.typedefs[id].header, idx.typedefs[id].header) + self.warning("typedef %s from %s redeclared in %s" % ( + id, self.typedefs[id].header, idx.typedefs[id].header)) else: self.typedefs[id] = idx.typedefs[id] self.identifiers[id] = idx.typedefs[id] @@ -311,15 +313,15 @@ class index: if self.enums.has_key(id): continue if self.macros.has_key(id): - print "macro %s from %s redeclared in %s" % ( - id, self.macros[id].header, idx.macros[id].header) + self.warning("macro %s from %s redeclared in %s" % ( + id, self.macros[id].header, idx.macros[id].header)) else: self.macros[id] = idx.macros[id] self.identifiers[id] = idx.macros[id] for id in idx.enums.keys(): if self.enums.has_key(id): - print "enum %s from %s redeclared in %s" % ( - id, self.enums[id].header, idx.enums[id].header) + self.warning("enum %s from %s redeclared in %s" % ( + id, self.enums[id].header, idx.enums[id].header)) else: self.enums[id] = idx.enums[id] self.identifiers[id] = idx.enums[id] @@ -330,10 +332,10 @@ class index: # check that function condition agrees with header if idx.functions[id].conditionals != \ self.functions[id].conditionals: - print "Header condition differs from Function for %s:" \ - % id - print " H: %s" % self.functions[id].conditionals - print " C: %s" % idx.functions[id].conditionals + self.warning("Header condition differs from Function for %s:" \ + % id) + self.warning(" H: %s" % self.functions[id].conditionals) + self.warning(" C: %s" % idx.functions[id].conditionals) up = idx.functions[id] self.functions[id].update(None, up.module, up.type, up.info, up.extra) # else: @@ -356,12 +358,13 @@ class index: def analyze(self): - self.analyze_dict("functions", self.functions) - self.analyze_dict("variables", self.variables) - self.analyze_dict("structs", self.structs) - self.analyze_dict("unions", self.unions) - self.analyze_dict("typedefs", self.typedefs) - self.analyze_dict("macros", self.macros) + if not quiet: + self.analyze_dict("functions", self.functions) + self.analyze_dict("variables", self.variables) + self.analyze_dict("structs", self.structs) + self.analyze_dict("unions", self.unions) + self.analyze_dict("typedefs", self.typedefs) + self.analyze_dict("macros", self.macros) class CLexer: """A lexer for the C language, tokenize the input by reading and @@ -621,6 +624,8 @@ class CParser: info, extra, self.conditionals) def warning(self, msg): + global warnings + warnings = warnings + 1 if self.no_error: return print msg @@ -1802,7 +1807,8 @@ class CParser: return token def parse(self): - self.warning("Parsing %s" % (self.filename)) + if not quiet: + print "Parsing %s" % (self.filename) token = self.token() while token != None: if token[0] == 'name': @@ -1869,7 +1875,8 @@ class docBuilder: pass def analyze(self): - print "Project %s : %d headers, %d modules" % (self.name, len(self.headers.keys()), len(self.modules.keys())) + if not quiet: + print "Project %s : %d headers, %d modules" % (self.name, len(self.headers.keys()), len(self.modules.keys())) self.idx.analyze() def scanHeaders(self): @@ -1995,7 +2002,7 @@ class docBuilder: else: output.write(" <field name='%s' type='%s' info='%s'/>\n" % (field[1] , field[0], desc)) except: - print "Failed to serialize struct %s" % (name) + self.warning("Failed to serialize struct %s" % (name)) output.write(" </struct>\n") else: output.write("/>\n"); @@ -2023,7 +2030,7 @@ class docBuilder: def serialize_function(self, output, name): id = self.idx.functions[name] - if name == debugsym: + if name == debugsym and not quiet: print "=>", id output.write(" <%s name='%s' file='%s' module='%s'>\n" % (id.type, @@ -2059,7 +2066,7 @@ class docBuilder: output.write(" <arg name='%s' type='%s' info='%s'/>\n" % (param[1], param[0], escape(param[2]))) self.indexString(name, param[2]) except: - print "Failed to save function %s info: " % name, `id.info` + self.warning("Failed to save function %s info: " % name, `id.info`) output.write(" </%s>\n" % (id.type)) def serialize_exports(self, output, file): @@ -2074,7 +2081,7 @@ class docBuilder: escape(dict.info[data]), string.lower(data))) except: - print "Header %s lacks a %s description" % (module, data) + self.warning("Header %s lacks a %s description" % (module, data)) if dict.info.has_key('Description'): desc = dict.info['Description'] if string.find(desc, "DEPRECATED") != -1: @@ -2287,7 +2294,8 @@ class docBuilder: def serialize(self): filename = "%s/%s-api.xml" % (self.path, self.name) - print "Saving XML description %s" % (filename) + if not quiet: + print "Saving XML description %s" % (filename) output = open(filename, "w") output.write('<?xml version="1.0" encoding="ISO-8859-1"?>\n') output.write("<api name='%s'>\n" % self.name) @@ -2323,7 +2331,8 @@ class docBuilder: output.close() filename = "%s/%s-refs.xml" % (self.path, self.name) - print "Saving XML Cross References %s" % (filename) + if not quiet: + print "Saving XML Cross References %s" % (filename) output = open(filename, "w") output.write('<?xml version="1.0" encoding="ISO-8859-1"?>\n') output.write("<apirefs name='%s'>\n" % self.name) @@ -2336,7 +2345,8 @@ def rebuild(): builder = None srcdir = os.environ["srcdir"] if glob.glob(srcdir + "/../src/libvirt.c") != [] : - print "Rebuilding API description for libvirt" + if not quiet: + print "Rebuilding API description for libvirt" dirs = [srcdir + "/../src", srcdir + "/../src/util", srcdir + "/../include/libvirt"] @@ -2344,12 +2354,13 @@ def rebuild(): dirs.append("../include/libvirt") builder = docBuilder("libvirt", srcdir, dirs, []) elif glob.glob("src/libvirt.c") != [] : - print "Rebuilding API description for libvirt" + if not quiet: + print "Rebuilding API description for libvirt" builder = docBuilder("libvirt", srcdir, ["src", "src/util", "include/libvirt"], []) else: - print "rebuild() failed, unable to guess the module" + self.warning("rebuild() failed, unable to guess the module") return None builder.scan() builder.analyze() @@ -2368,5 +2379,13 @@ if __name__ == "__main__": if len(sys.argv) > 1: debug = 1 parse(sys.argv[1]) + if warnings > 0: + sys.exit(2) + else: + sys.exit(0) else: rebuild() + if warnings > 0: + sys.exit(2) + else: + sys.exit(0) diff --git a/python/Makefile.am b/python/Makefile.am index 0edb3e4..a4c9a6b 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -53,11 +53,11 @@ GENERATED= libvirt-export.c \ libvirt.h \ libvirt.py -generated.stamp: $(srcdir)/$(GENERATE) $(API_DESC) - $(PYTHON) $(srcdir)/$(GENERATE) $(PYTHON) +$(GENERATE).stamp: $(srcdir)/$(GENERATE) $(API_DESC) + $(AM_V_GEN)$(PYTHON) $(srcdir)/$(GENERATE) $(PYTHON) && \ touch $@ -$(GENERATED): generated.stamp +$(GENERATED): $(GENERATE).stamp $(libvirtmod_la_OBJECTS): $(GENERATED) diff --git a/python/generator.py b/python/generator.py index c27ff73..d3a3616 100755 --- a/python/generator.py +++ b/python/generator.py @@ -11,6 +11,8 @@ import sys import string import re +quiet=1 + if __name__ == "__main__": # launched as a script srcPref = os.path.dirname(sys.argv[0]) @@ -617,7 +619,8 @@ def buildStubs(): sys.exit(1) n = len(functions.keys()) - print "Found %d functions in libvirt-api.xml" % (n) + if not quiet: + print "Found %d functions in libvirt-api.xml" % (n) py_types['pythonObject'] = ('O', "pythonObject", "pythonObject", "pythonObject") try: @@ -629,8 +632,8 @@ def buildStubs(): except IOError, msg: print file, ":", msg - - print "Found %d functions in libvirt-override-api.xml" % ( + if not quiet: + print "Found %d functions in libvirt-override-api.xml" % ( len(functions.keys()) - n) nb_wrap = 0 failed = 0 @@ -662,20 +665,21 @@ def buildStubs(): export.close() wrapper.close() - print "Generated %d wrapper functions" % nb_wrap + if not quiet: + print "Generated %d wrapper functions" % nb_wrap if unknown_types: print "Missing type converters: " for type in unknown_types.keys(): print "%s:%d " % (type, len(unknown_types[type])), - print - for f in functions_failed: print "ERROR: failed %s" % f if failed > 0: return -1 + if len(unknown_types) > 0: + return -1 return 0 ####################################################################### diff --git a/src/Makefile.am b/src/Makefile.am index cd8a7e9..844ec9d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -786,7 +786,7 @@ endif BUILT_SOURCES += $(ESX_DRIVER_GENERATED) $(ESX_DRIVER_GENERATED): $(srcdir)/esx/esx_vi_generator.input $(srcdir)/esx/esx_vi_generator.py - -srcdir=$(srcdir) $(srcdir)/esx/esx_vi_generator.py + $(AM_V_GEN)srcdir=$(srcdir) $(srcdir)/esx/esx_vi_generator.py if WITH_ESX if WITH_DRIVER_MODULES -- 1.7.4.4

2 1

[libvirt] [PATCH] qemu: Add support for SGA video
by Michal Privoznik 04 Jul '11

04 Jul '11

This patch extends possible values for <video> element. Serial Graphics Adapter allows users to see BIOS messages from the very first moment domain boots up. Therefore, users can choose boot medium, set PXE, etc. However, to be able to use this, one need SGABIOS, which is accessible here: http://code.google.com/p/sgabios/ --- docs/formatdomain.html.in | 5 +++-- docs/schemas/domain.rng | 1 + src/conf/domain_conf.c | 43 ++++++++++++++++++++++++------------------- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 28 ++++++++++++++++++++++------ 5 files changed, 51 insertions(+), 27 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 3a64983..2d89b37 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2005,8 +2005,9 @@ qemu-kvm -net nic,model=? /dev/null <dd> The <code>model</code> element has a mandatory <code>type</code> attribute which takes the value "vga", "cirrus", "vmvga", "xen", - "vbox", or "qxl" (since 0.8.6) - depending on the hypervisor features available. + "vbox", "qxl" (since 0.8.6), or "sga" + (Since 0.9.4) depending on the hypervisor + features available. You can also provide the amount of video memory in kilobytes using <code>vram</code> and the number of screen with <code>heads</code>. </dd> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng index 891662d..74bc111 100644 --- a/docs/schemas/domain.rng +++ b/docs/schemas/domain.rng @@ -1502,6 +1502,7 @@ <value>xen</value> <value>vbox</value> <value>qxl</value> + <value>sga</value> </choice> </attribute> <optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f9bf51e..9848359 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -299,7 +299,8 @@ VIR_ENUM_IMPL(virDomainVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, "vmvga", "xen", "vbox", - "qxl") + "qxl", + "sga") VIR_ENUM_IMPL(virDomainInput, VIR_DOMAIN_INPUT_TYPE_LAST, "mouse", @@ -4713,28 +4714,32 @@ virDomainVideoDefParseXML(const xmlNodePtr node, } } - if (vram) { - if (virStrToLong_ui(vram, NULL, 10, &def->vram) < 0) { - virDomainReportError(VIR_ERR_INTERNAL_ERROR, - _("cannot parse video ram '%s'"), vram); - goto error; + /* SGA video device does not support heads, vram + * or PCI address. It is not PCI device anyway */ + if (def->type != VIR_DOMAIN_VIDEO_TYPE_SGA) { + if (vram) { + if (virStrToLong_ui(vram, NULL, 10, &def->vram) < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse video ram '%s'"), vram); + goto error; + } + } else { + def->vram = virDomainVideoDefaultRAM(dom, def->type); } - } else { - def->vram = virDomainVideoDefaultRAM(dom, def->type); - } - if (heads) { - if (virStrToLong_ui(heads, NULL, 10, &def->heads) < 0) { - virDomainReportError(VIR_ERR_INTERNAL_ERROR, - _("cannot parse video heads '%s'"), heads); - goto error; + if (heads) { + if (virStrToLong_ui(heads, NULL, 10, &def->heads) < 0) { + virDomainReportError(VIR_ERR_INTERNAL_ERROR, + _("cannot parse video heads '%s'"), heads); + goto error; + } + } else { + def->heads = 1; } - } else { - def->heads = 1; - } - if (virDomainDeviceInfoParseXML(node, &def->info, flags) < 0) - goto error; + if (virDomainDeviceInfoParseXML(node, &def->info, flags) < 0) + goto error; + } VIR_FREE(type); VIR_FREE(vram); diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index e81977c..7f60754 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -605,6 +605,7 @@ enum virDomainVideoType { VIR_DOMAIN_VIDEO_TYPE_XEN, VIR_DOMAIN_VIDEO_TYPE_VBOX, VIR_DOMAIN_VIDEO_TYPE_QXL, + VIR_DOMAIN_VIDEO_TYPE_SGA, VIR_DOMAIN_VIDEO_TYPE_LAST }; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 6e4480e..7685d7e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -80,7 +80,8 @@ VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, "vmware", "", /* no arg needed for xen */ "", /* don't support vbox */ - "qxl"); + "qxl", + "sga"); static void uname_normalize (struct utsname *ut) @@ -1213,7 +1214,8 @@ qemuAssignDevicePCISlots(virDomainDefPtr def, qemuDomainPCIAddressSetPtr addrs) /* Further non-primary video cards */ for (i = 1; i < def->nvideos ; i++) { - if (def->videos[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) + if (def->videos[i]->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE || + def->videos[i]->type == VIR_DOMAIN_VIDEO_TYPE_SGA) continue; if (qemuDomainPCIAddressSetNextAddr(addrs, &def->videos[i]->info) < 0) goto error; @@ -2083,8 +2085,9 @@ qemuBuildVideoDevStr(virDomainVideoDefPtr video, virBufferAsprintf(&buf, ",vram_size=%u", video->vram * 1024); } - if (qemuBuildDeviceAddressStr(&buf, &video->info, qemuCaps) < 0) - goto error; + if (video->type != VIR_DOMAIN_VIDEO_TYPE_SGA) + if (qemuBuildDeviceAddressStr(&buf, &video->info, qemuCaps) < 0) + goto error; if (virBufferError(&buf)) { virReportOOMError(); @@ -4254,6 +4257,11 @@ qemuBuildCommandLine(virConnectPtr conn, if (qemuCapsGet(qemuCaps, QEMU_CAPS_VGA)) { if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_XEN) { /* nothing - vga has no effect on Xen pvfb */ + } else if (def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_SGA) { + if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) + virCommandAddArgList(cmd, "-device", "sga", NULL); + else + virCommandAddArg(cmd, "-nographic"); } else { if ((def->videos[0]->type == VIR_DOMAIN_VIDEO_TYPE_QXL) && !qemuCapsGet(qemuCaps, QEMU_CAPS_VGA_QXL)) { @@ -4309,6 +4317,13 @@ qemuBuildCommandLine(virConnectPtr conn, /* No special args - this is the default */ break; + case VIR_DOMAIN_VIDEO_TYPE_SGA: + if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) + virCommandAddArgList(cmd, "-device", "sga", NULL); + else + virCommandAddArg(cmd, "-nographic"); + break; + default: qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("video type %s is not supported with this QEMU"), @@ -4321,10 +4336,11 @@ qemuBuildCommandLine(virConnectPtr conn, if (qemuCapsGet(qemuCaps, QEMU_CAPS_DEVICE)) { for (i = 1 ; i < def->nvideos ; i++) { char *str; - if (def->videos[i]->type != VIR_DOMAIN_VIDEO_TYPE_QXL) { + if (def->videos[i]->type != VIR_DOMAIN_VIDEO_TYPE_QXL && + def->videos[i]->type != VIR_DOMAIN_VIDEO_TYPE_SGA) { qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("video type %s is only valid as primary video card"), - virDomainVideoTypeToString(def->videos[0]->type)); + virDomainVideoTypeToString(def->videos[i]->type)); goto error; } -- 1.7.5.rc3

2 1

[libvirt] VMWare "independent disk" processing needed
by computernews＠rambler.ru 04 Jul '11

04 Jul '11

Hello, On VMware ESX server it is possible for the virtual machine to add the "independent disk" - the kind of virtual disk that (among other features) is not being covered by the snapshot logic. As I am working on some kind of backup solution I need to be able to backup the precise state of the guest virtual machine running on say VMware ESX server. I am able to perform a backup of a guest machine description with libvirts's amazing API which covers most of my needs except the aforementioned "independent disk" virtual disk type. The problem shows up at the restore type when I need to create the new virtual machine having an .xml file created by "virsh dumpxml" command. In fact I use API but "virsh does the same". This .xml file covers most of guest machine's aspects but it doesn't reflect the "independent" nature of such disks. So the virtual machine is going to be restored incorrectly when includes "independent disks". From the source codes of "libvirt" ("/libvirt/src/vmx/vmx.*") I see that this is ment to be covered but yet is not implemented. Appropriate nodes must be stored in .xml file during the backup and returned back to .vmx file during the restore. So here are my questions: Is someone on it at the moment ? If yes - can I help somehow ? If no - whom shell I approach in order to be mentored/directed if I decide to participate, implement this and contribute the patch back to the source code ? Thanks for an answer in advance. Best regards Oleh Paliy

1 0

[libvirt] PPPoE-Server problem
by B Veera-B37207 04 Jul '11

04 Jul '11

HI, I am using Libvirt with LXC as hypervisor. When I am starting pppoe-server , unable to create ppp0 interface in Virtual machine, it is unable to serve ips to clients. Let me know is there any plug-in for this (Or) What is the solution. Regards, Veera.

1 0

[libvirt] [PATCH 1/4] libvirtd: avoid memory leak on OOM
by Eric Blake 04 Jul '11

04 Jul '11

Detected by Coverity; only strikes on OOM so not serious. * daemon/libvirtd.c (daemonPidFilePath): Plug leak. --- daemon/libvirtd.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 60ee705..06d2077 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -310,8 +310,10 @@ daemonPidFilePath(bool privileged, if (!(userdir = virGetUserDirectory(geteuid()))) goto error; - if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0) + if (virAsprintf(pidfile, "%s/.libvirt/libvirtd.pid", userdir) < 0) { + VIR_FREE(userdir); goto no_memory; + } VIR_FREE(userdir); } -- 1.7.4.4

4 11

[libvirt] [PATCH] storage: Do not override the exact error of createRawFile
by Osier Yang 04 Jul '11

04 Jul '11

virStorageBackendCreateRaw: createRawFile already reported the exact error. Before the fix: error: Failed to create vol vol-create.img error: cannot create path '/var/lib/libvirt/images/vol-create.img': Unknown error 18446744073709551597 After the fix: error: Failed to create vol vol-create.img error: cannot fill file '/var/lib/libvirt/images/vol-create.img': No space left on device --- src/storage/storage_backend.c | 13 ++++++++----- 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index a6e66e1..cee2010 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -299,6 +299,7 @@ createRawFile(int fd, virStorageVolDefPtr vol, { int ret = 0; unsigned long long remain; + off_t cur_pos = 0; /* Seek to the final size, so the capacity is available upfront * for progress reporting */ @@ -310,7 +311,12 @@ createRawFile(int fd, virStorageVolDefPtr vol, goto cleanup; } + cur_pos = lseek(fd, 0, SEEK_CUR); + + VIR_WARN("cur_pos = %jd", cur_pos); + remain = vol->allocation; + VIR_WARN("remain = %llu", remain); if (inputvol) { ret = virStorageBackendCopyToFD(vol, inputvol, fd, &remain, 1); @@ -399,12 +405,9 @@ virStorageBackendCreateRaw(virConnectPtr conn ATTRIBUTE_UNUSED, goto cleanup; } - if ((ret = createRawFile(fd, vol, inputvol)) < 0) { - virReportSystemError(-fd, - _("cannot create path '%s'"), - vol->target.path); + if ((ret = createRawFile(fd, vol, inputvol)) < 0) + /* createRawFile already reported the exact error. */ ret = -1; - } cleanup: VIR_FORCE_CLOSE(fd); -- 1.7.4

2 4

[libvirt] Release of libvirt-0.9.3
by Daniel Veillard 04 Jul '11

04 Jul '11

As scheduled, I made the new release of libvirt-0.9.3 today, it is available at ftp://libvirt.org/libvirt/ , the rpms are still being pushed as I write. This is a fairly large release again, with over 330 commits incorporated, including a number of new APIs, large refactoring of the client server code, LXC containers improvements and many improvements and various bug fixes. Features: - vcpupin: introduce the new libvirt API (virDomainGetVcpupinInfo) (Taku Izumi) - Add TXT record support for virtual DNS service (Michal Novotny) - Support reboots with the QEMU driver (Daniel P. Berrange) - Introduce virDomainGetControlInfo API (Jiri Denemark) - virNodeGetMemoryStats: Expose new API (Minoru Usui) - virNodeGetCPUTime: Implement public API (Minoru Usui) - send-key: Defining the public API (Lai Jiangshan) - vcpupin: introduce a new libvirt API (virDomainPinVcpuFlags) (Taku Izumi) - support multifunction PCI device (Wen Congyang) - lxc: various improvements Documentation: - Add documentation for configuration lock managers (Daniel P. Berrange) - fix indentation of sub-elements of <ip> in network XML (Laine Stump) - document correct flag name (Eric Blake) - documenting the 802.1Qbh parameters of a 'direct' interface (David S. Wang) - Make virConnectClose comply to apibuild.py expectations (Matthias Bolte) - fix docs to match behavior of virConnectClose (Eric Blake) - numatune: Add doc for new numatune XML (Osier Yang) - Fix documentation of virStreamRecv (Matthias Bolte) - updated list of applications using libvirt. (Ohad Levy) - improve VIR_DOMAIN_AFFECT_CURRENT description (Eric Blake) - Add doc for video element (Osier Yang) - Make hvsupport.pl pick up the host device drivers (Matthias Bolte) Portability: - Explicitely invoke python for API doc generator (Daniel Veillard) - fix virParseVersionString with linux 3.0 (Scott Moser) - Add conditionals to allow build without SASL (Daniel P. Berrange) - Add missing include of signal.h in virnetsocket.c (Daniel P. Berrange) - Fix compilation with systemtap 1.3 (Matthias Bolte) - build: fix mingw build (Eric Blake) - daemon: Fix build without polkit (Jiri Denemark) - build: fix 'make check' when pdwtags is available (Eric Blake) - build: sanlock-devel is not in F15 yet (Eric Blake) - Only include parthelper if built with storage_disk (Ruben Kerkhof) - build: fix VPATH builds (Eric Blake) - python: Don't declare Py_ssize_t for Python 2.6 (Matthias Bolte) - build: avoid python 2.4 build failure (Eric Blake) - build: fix NUMA build on RHEL 5 (Eric Blake) - build: avoid python 2.4 build failure (Eric Blake) - build: avoid compiler failure (Eric Blake) - build: fix compilation on systems missing libnl and new includes (Stefan Berger) - configure: Make libnl optional unless macvtap is required (Matthias Bolte) - build: require newer netcf when it is available (Eric Blake) - build: fix building error when building without libvirtd (Wen Congyang) - Skip nodeinfo test on non intel architectures (Guido Günther) - Fix dlopen dependency (Matthias Bolte) - virt-aa-helper: add missing include (Eric Blake) Bug Fixes: - initialize pointer to NULL (Wen Congyang) - storage: avoid crash on parse error (Eric Blake) - vmware: avoid null deref on failed lookup (Eric Blake) - qemu: avoid null deref on low memory (Eric Blake) - rpc: avoid memory leak on error (Eric Blake) - rpc: fix logic bug (Eric Blake) - pci: avoid memory leak on error (Eric Blake) - interface: avoid memory leak on parse error (Eric Blake) - libvirtd: avoid memory leak on OOM (Eric Blake) - build: avoid double-close bug with pipe2 (Eric Blake) - rpc: avoid freeing uninitialized variable (Eric Blake) - virsh: avoid uninitialized variable (Eric Blake) - virsh: avoid integer overflow (Eric Blake) - Fix stream procedure number for virDomainMigratePrepareTunnel3 (Daniel P. Berrange) - Fix release of virNetMessagePtr instances in streams processing (Daniel P. Berrange) - Fix potential crash when saving guests (Daniel P. Berrange) - Fix uninitialized value in QEMU monitor FD sending code (Daniel P. Berrange) - Fix leak of JSON object for events (Daniel P. Berrange) - Fix use of uninitialized memory when releasing PCI slots (Daniel P. Berrange) - Fix leak of virStreamPtr object with callback added in fdstream impl (Daniel P. Berrange) - Fix leak of mdnsGroupName in virNetServer object (Daniel P. Berrange) - Fix release of filtered stream messages (Daniel P. Berrange) - save domain status after modifing vcpupin (Wen Congyang) - Fix memory leak in virDomainVcpuPinDel() (Wen Congyang) - sysinfo: fix illegal NULL return (Minoru Usui) - Fix locking wrt virNetClientStreamPtr object (Daniel P. Berrange) - Avoid referencing NULL pointer when copying stream error (Daniel P. Berrange) - Avoid free'ing a filtered RPC message in the server (Daniel P. Berrange) - Ensure empty payload is written upon stream completion (Daniel P. Berrange) - Fix propagation of RPC errors from streams (Daniel P. Berrange) - Fix crash when aborting a stream from a I/O callback (Daniel P. Berrange) - dnsmasq: Fix errno handling and don't unlink non-existing files (Matthias Bolte) - tests: Fix memory leak in virnetmessagetest (Osier Yang) - conf: Fix memory leak in virNetworkDNSDefFormat (Osier Yang) - sysinfo: fix parsing regression (Eric Blake) - remote: fix uninitialized variable (Eric Blake) - build: avoid uninitialized variable (Eric Blake) - buf: protect against integer overflow (Eric Blake) - remote: protect against integer overflow (Eric Blake) - Fix typo in libvirt_private.syms (Matthias Bolte) - Fix some bugs in RPC protocol make rules (Daniel P. Berrange) - Fix job type set in qemuMigrationPrepareDirect/PrepareTunnel (Daniel P. Berrange) - Avoid high privileges taint warning for QEMU session driver (Daniel P. Berrange) - util: Fix memory leak in virJSONParserHandleStartMap (Osier Yang) - qemu: Fix memory leak in qemuProcessWaitForMonitor (Osier Yang) - storage: fix volDelete return when volume still being allocated (Matthew Booth) - Fix use-after-free in handling domain taint flags (Daniel P. Berrange) - qemu: Fix one memory leak (Osier Yang) - virsh: avoid bogus description (Eric Blake) - set and restore MAC address of a NIC when using PASSTHROUGH mode (Dirk Herrendoerfer) - conf: Fix one memory leak (Osier Yang) - Add missing checks for NULL in domain lock manager (Daniel P. Berrange) - Fix errno return in safezero() (Daniel P. Berrange) - Fix allocation of veth's to not skip an index (Daniel P. Berrange) - command: avoid double close (Eric Blake) - qemu: Fix parsing 'info chardev' (Cole Robinson) - vcpupin: Fix cpu affinity setting bug of qemu driver (Taku Izumi) - daemon: plug memory leak (Eric Blake) - qemu: add missing break statement (Eric Blake) - storage: avoid mishandling backing store > 2GB (Eric Blake) Improvements: - tests: Add a general util test (Matthias Bolte) - util: choose whether to require micro in version strings (Eric Blake) - build: consistently use CFLAGS (Eric Blake) - build: simplify sanlock distribution (Eric Blake) - build: allow 'make syntax-check' on fresh checkout (Eric Blake) - Send back an error if we get unexpected stream control message (Daniel P. Berrange) - Add test case for parsing JSON docs (Daniel P. Berrange) - Remove bogus warning message in JSON code (Daniel P. Berrange) - Ensure RPC message is cleared before being reused (Daniel P. Berrange) - Fix hardcoded limit on client requests in RPC code (Daniel P. Berrange) - tests: Add valgrind.supp into EXTRA_DIST (Osier Yang) - virsh: Fix a problem of buildPoolXML (Osier Yang) - lock qemu_driver early in qemuGetSchedulerParametersFlags() (Wen Congyang) - build: avoid pod2man on tarball (Eric Blake) - Ensure that EOF is dispatched to the stream callback (Daniel P. Berrange) - Improve two log messages in virNetMessage (Daniel P. Berrange) - Lower logging level when failing to register socket watch (Daniel P. Berrange) - screenshot: Set access rights to temporary file (Michal Privoznik) - maint: improve makefile whitespace (Eric Blake) - network: Don't ignore errors in dnsmasq config file creation (Matthias Bolte) - network: Fix dnsmasq hostsfile creation logic and related tests (Matthias Bolte) - build: update translated files (Eric Blake) - Support automatic creation of leases for disks in sanlock (Daniel P. Berrange) - Support loading a configuration file for sanlock plugin (Daniel P. Berrange) - Allow per-driver config file for lock manager plugins (Daniel P. Berrange) - network: add domain to unqualified names defined with <host> (Laine Stump) - Convert libvirtd over to the new RPC handling APIs (Daniel P. Berrange) - Convert the remote driver to new RPC client APIs (Daniel P. Berrange) - Add XDR_CFLAGS to libvirt-net-rpc.la library (Daniel P. Berrange) - Ensure sanlock socket is labelled with the VM process label (Daniel P. Berrange) - Add a virSecurityManagerSetProcessFDLabel (Daniel P. Berrange) - Rename virSecurityManagerSetFDLabel method (Daniel P. Berrange) - Add node prefix to virNodeGet(CPU|Memory)Stats structs and defines (Matthias Bolte) - qemu: Fix update device for CURRENT + FORCE flags (Jiri Denemark) - nwfilter: Return error message about unresolvable variables (Stefan Berger) - build: rename Vcpupin to VcpuPin (Eric Blake) - sysinfo: cleanup function/struct names. (Minoru Usui) - sysinfo: fix lack of error check in virSysinfoFormat(). (Minoru Usui) - tests: Partly fix networkxml2argvtest being configure result dependent (Matthias Bolte) - qemu: Remove bogus error codes for NUMA memory tuning (Osier Yang) - network: fix indentation in networkBuildDnsmasqArgv (Laine Stump) - vcpupin: add query option to virsh vcpupin command (Taku Izumi) - vcpuinfo: add the code to fallback to try new API (Taku Izumi) - vcpupin: implement the remote protocol to address the new API (Taku Izumi) - vcpupin: implement the code to support new API for the qemu driver (Taku Izumi) - build: update gnulib for intprops (Eric Blake) - Rename iface(G|S)etMacaddr to iface(G|S)etMacAddress for consistency (Matthias Bolte) - Network: Add support for DNS hosts definition to the network XML (Michal Novotny) - Network: Add additional hosts internal infrastructure (Michal Novotny) - Network: Add regression tests for the command-line arguments (Michal Novotny) - Network: modify dnsmasq commandline build function to allow testing (Michal Novotny) - tests: Improve IPv6 detection for virNetSocket tests (Matthias Bolte) - Move load of AppArmor profile to GenLabel() (Jamie Strandboge) - Add Memory Device Information to virSysinfoRead() from dmidecode type 17 (Minoru Usui) - Add Processor Information to virSysinfoRead() from dmidecode type 4 (Minoru Usui) - Cleanup virSysinfoRead() (Minoru Usui) - Make sure virnetprotocol.[ch] are in BUILT_SOURCES (Daniel P. Berrange) - maint: typo fixes (Eric Blake) - Add missing translation of error message from QEMU reboot patch (Daniel P. Berrange) - Allow automatic kill of guests when a connection is closed (Daniel P. Berrange) - Automatically kill target QEMU if migration aborts abnormally (Daniel P. Berrange) - Add infrastructure to automatically destroy guests when a connection closes (Daniel P. Berrange) - Move the RPC generator scripts into src/rpc (Daniel P. Berrange) - Introduce generic RPC client objects (Daniel P. Berrange) - Introduce generic RPC module for advertising via MDNS (Daniel P. Berrange) - Introduce generic RPC server objects (Daniel P. Berrange) - Integrate TLS/SASL directly into the socket APIs (Daniel P. Berrange) - Generic module for handling SASL authentication & encryption (Daniel P. Berrange) - Generic module for handling TLS encryption and x509 certs (Daniel P. Berrange) - Introduce a generic object for using network sockets (Daniel P. Berrange) - Provide a simple object for encoding/decoding RPC messages (Daniel P. Berrange) - Defines the basics of a generic RPC protocol in XDR (Daniel P. Berrange) - build: update to latest gnulib (Eric Blake) - python: Generate virStreamFree but don't expose in bindings (Cole Robinson) - maint: avoid future setgid problems (Eric Blake) - qemu: Only check for NUMA availability if required (Jiri Denemark) - util: avoid PATH_MAX-sized array (Eric Blake) - xen: avoid PATH_MAX-sized array (Eric Blake) - tests: avoid PATH_MAX-sized array (Eric Blake) - virStorageVol: avoid PATH_MAX-sized array (Eric Blake) - cleanup: make several interface functions commonly available (Stefan Berger) - cleanup: make nlComm commonly available (Stefan Berger) - maint: remove syntax-check exception (Eric Blake) - Remove macvtap dependency on domain configuration (Daniel P. Berrange) - util: Correct the error prompt string (Osier Yang) - Fix to python API extractor and API doc generation (Daniel Veillard) - qemu: domain I/O asynchronous handling (Michal Privoznik) - python: Mark event callback wrappers as private (Cole Robinson) - python: events: Fix C->Python handle callback prototype (Cole Robinson) - python: Add bindings for virEvent*Handle/Timeout (Cole Robinson) - events: Correct virEventAddTimeout docs (Cole Robinson) - Promote virEvent*Handle/Timeout to public API (Cole Robinson) - python: Implement virStreamSend/RecvAll helpers (Cole Robinson) - python: Implement virStreamSend/Recv (Cole Robinson) - conf: Make full use of goto label (Osier Yang) - python: Implement bindings for virStreamEventAddCallback (Cole Robinson) - python: generator: Don't print warning if nothing to warn about (Cole Robinson) - python: libvirt-override: use simpler debug (Cole Robinson) - virsh: enhance snapshot-create-as (Eric Blake) - virsh: add snapshot-create-as command (Eric Blake) - virsh: clarify snapshot vs. save (Eric Blake) - Fix compile warnings in virsh vcpupin (Daniel P. Berrange) - remote generator: Allow to annotate arrays with typecasts (Matthias Bolte) - remote: Handle functions that return optional strings (Matthias Bolte) - remote: Generate virDomainGetBlockPullInfo (Matthias Bolte) - vcpupin: add vcpupin resetting feature to qemu driver (Taku Izumi) - vcpupin: add virDomainVcpupinDel function (Taku Izumi) - vcpupin: add reset option to virsh vcpupin command (Taku Izumi) - vcpupin: improve vcpupin definition of virsh vcpupin (Taku Izumi) - Fix preprocessor indentation in nodeinfo.c (Matthias Bolte) - Move XenAPI driver to correct spec file section (Matthias Bolte) - numatune: Add tests for numatune XML (Osier Yang) - numatune: Support NUMA memory tuning in qemu driver (Osier Yang) - numatune: Support persistent XML for numatune (Osier Yang) - numatune: Define XML schema (Osier Yang) - Update qemuDomainSetBlkioParameters to use flags (Hu Tao) - update qemuDomainGetBlkioParameters to use flags (Hu Tao) - Add new parameters for blkiotune (Hu Tao) - apparmor: implement AppArmorSetFDLabel() (Jamie Strandboge) - Add missing error reporting when loading mac filter config for QEMU (Daniel P. Berrange) - virsh: Add support for virDomainGetControlInfo (Jiri Denemark) - qemu: Implement virDomainGetControlInfo (Jiri Denemark) - Wire protocol and remote driver for virDomainGetControlInfo (Jiri Denemark) - sendkey: use consistent API convention (Eric Blake) - build: export correct function names (Eric Blake) - build: avoid compiler warning on non-Linux (Eric Blake) - remote generator: Handle struct returning functions better (part 2) (Matthias Bolte) - Fix apibuild.py warnings about missing comment headers (Matthias Bolte) - remote generator: Handle struct returning functions better (Matthias Bolte) - support for Xen HVM Viridian (Hyper-V) enlightenment interface (Daniel Gollub) - virsh: reduce complexity in argv iteration (Eric Blake) - Add support for network filter code in LXC driver (Daniel P. Berrange) - qemu: Translate boot config into bootindex if possible (Jiri Denemark) - spice: add <clipboard copypaste='yes|no'> option (Marc-André Lureau) - virNodeGetMemoryStats: Implement linux support (Minoru Usui) - virNodeGetMemoryStats: Implement virsh support (Minoru Usui) - virNodeGetMemoryStats: Implement remote protocol (Minoru Usui) - virNodeGetMemoryStats: Implement public API (Minoru Usui) - virNodeGetMemoryStats: Define internal driver API (Minoru Usui) - virNodeGetCPUStats: Implement linux support (Minoru Usui) - virNodeGetCPUStats: Implement virsh support (Minoru Usui) - virNodeGetCPUStats: Implement remote protocol (Minoru Usui) - virNodeGetCPUStats: Define internal driver API (Minoru Usui) - virNodeGetCPUStats: Expose new API (Minoru Usui) - Fix autostart flag when loading running domains (Michael Chapman) - send-key: Implementing the remote protocol (Lai Jiangshan) - send-key: Implementing the public API (Lai Jiangshan) - send-key: Defining the internal API (Lai Jiangshan) - remote generator: Handle (unsigned) int arrays (Lai Jiangshan) - add VSH_OFLAG_REQ_OPT options (Lai Jiangshan) - allow name for VSH_OT_ARGV options (Lai Jiangshan) - storage: avoid an intermediate malloc (Eric Blake) - command: reduce duplicated debug messages (Eric Blake) - qemu: Scrape stdout for virtio console pty (Cole Robinson) - virsh: Add daemon version reporting (Michal Privoznik) - nodeinfo: remove superflous braces (Guido Günther) - util: Cleanup indention problem in virterror.c (Osier Yang) - qemu: Parse current balloon value returned by query_balloon (Osier Yang) - Deprecate several CURRENT/LIVE/CONFIG enums (Hu Tao) - qemu: Faster response time to qemu startup errors (Stefan Berger) - build: update to latest gnulib (Eric Blake) - vcpupin: add the new option to "virsh vcpupin" command (Taku Izumi) - vcpupin: implement the remote protocol to address the new API (Taku Izumi) - vcpupin: implement the code to address the new API in the qemu driver (Taku Izumi) - Use virTimeMs when appropriate (Jiri Denemark) - Introduce virTimeMs for getting current time in ms (Jiri Denemark) - test: Remove unused timeval (Jiri Denemark) - tests: add a test for multi function PCI device (Wen Congyang) - the hotplugged PCI device should use the whole slot (Wen Congyang) - assign the whole slot to the PCI device that has no address (Wen Congyang) - Reimplement qemuDomainPCIAddressReserveSlot(): reserve all functions in the slot (Wen Congyang) - the key of hash table should include the function value (Wen Congyang) - prevent hot unplugging multi function PCI device (Wen Congyang) - check whether qemu supports multi function PCI device (Wen Congyang) - xenapi: Improve error message on session failure (Matthew Booth) - qemu: Fix one type in the error prompt string (Osier Yang) - Move VMware Workstation/Player driver to correct spec file section (Matthias Bolte) - esx: avoid dead code (Eric Blake) - qemu: reorder checks for safety (Eric Blake) - uuid: annotate non-null requirements (Eric Blake) - debug: avoid null dereference on uuid lookup api (Eric Blake) - python: avoid unlikely sign extension bug (Eric Blake) - build: detect Coverity 5.3.0 (Eric Blake) - build: Fix typos in configure.ac (Osier Yang) - virsh: Expose virDomainMigrateSetMaxSpeed API to virsh (Osier Yang) - lxc: Ensure container <init> actually exists (Cole Robinson) - lxc: Verify root fs exists before mounting (Cole Robinson) - lxc: controller: Improve container error reporting (Cole Robinson) - lxc: Improve guest startup error reporting (Cole Robinson) - lxc: Refactor controller command building (Cole Robinson) - lxc: Don't report error in Wait/SendContinue (Cole Robinson) - lxc: Drop container stdio as late as possible (Cole Robinson) - util: Implement virRun as a wrapper around virCommand (Cole Robinson) - qemu: Convert virExec usage to virCommand (Cole Robinson) - Use VIR_USE_CPU instead of new wheel (Osier Yang) - Avoid virGetVersion failure on specific driver support configurations (Matthias Bolte) Cleanups - cgroup: silence coverity warning (Eric Blake) - rpc: silence coverity warning (Eric Blake) - qemu: silence coverity warnings (Eric Blake) - build: avoid 'make syntax-check' failure (Eric Blake) - build: remove dead variables (Eric Blake) - Remove bogus jsondata.h file reference which does not exist (Daniel P. Berrange) - build: ignore generated file (Eric Blake) - build: Don't expect translatable strings in a dead file (Jiri Denemark) - Cleanup remote protocol definitions (Daniel P. Berrange) - Remove obsolete libvirtd mdns code (Daniel P. Berrange) - build: avoid long line tests (Eric Blake) - maint: add omitted copyright header (Eric Blake) - build: break some long lines (Eric Blake) - build: silence coverity false positives (Eric Blake) - secret: drop dead code (Eric Blake) - build: silence coverity false positive (Eric Blake) - Move virRun, virExec*, virFork to util/command (Cole Robinson) - util: Remove unused virExec wrapper (Cole Robinson) - esx: Remove duplicated invalid-argument checks (Matthias Bolte) Thanks everybody for your help with this release, be it by submitting documentations, ideas, patches, etc ... ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] initialize pointer to NULL
by Wen Congyang 04 Jul '11

04 Jul '11

>From 577ac7e8594cbcccb59653786e80c3916a3238cb Mon Sep 17 00:00:00 2001 From: Wen Congyang <wency(a)cn.fujitsu.com> Date: Sat, 2 Jul 2011 06:41:18 +0800 Subject: [PATCH] initialize pointer to NULL def and cmd is not initialized to NULL, but we try to freed it if we meet some error. It's very dangerous. --- src/qemu/qemu_command.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 90a6653..6c78161 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -5818,7 +5818,7 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr caps, const char **progenv, const char **progargv) { - virDomainDefPtr def; + virDomainDefPtr def = NULL; int i; int nographics = 0; int fullscreen = 0; @@ -5827,7 +5827,7 @@ virDomainDefPtr qemuParseCommandLine(virCapsPtr caps, const char **nics = NULL; int video = VIR_DOMAIN_VIDEO_TYPE_CIRRUS; int nvirtiodisk = 0; - qemuDomainCmdlineDefPtr cmd; + qemuDomainCmdlineDefPtr cmd = NULL; if (!progargv[0]) { qemuReportError(VIR_ERR_INTERNAL_ERROR, -- 1.6.5.2

3 2

[libvirt] [PATCH 0/8] more coverity cleanups
by Eric Blake 04 Jul '11

04 Jul '11

Many are minor (silencing warnings or only affect OOM), but at least patch 5/8 is a real bug that needs to be fixed pre-release. Eric Blake (8): rpc: avoid memory leak on error qemu: silence coverity warnings rpc: silence coverity warning cgroup: silence coverity warning rpc: fix logic bug qemu: avoid null deref on low memory vmware: avoid null deref on failed lookup storage: avoid crash on parse error src/qemu/qemu_audit.c | 6 ++++-- src/qemu/qemu_command.c | 6 +++++- src/qemu/qemu_domain.c | 4 ++-- src/qemu/qemu_migration.c | 3 ++- src/rpc/virnetclient.c | 3 ++- src/rpc/virnetserverclient.c | 1 + src/rpc/virnetserverservice.c | 7 ++++++- src/storage/storage_backend_iscsi.c | 14 ++++++++++---- src/util/cgroup.c | 2 +- src/vmware/vmware_driver.c | 2 +- 10 files changed, 34 insertions(+), 14 deletions(-) -- 1.7.4.4

3 15

[libvirt] [PATCH] monitor-proxy: Tool for testing qemu monitor interaction
by Jiri Denemark 04 Jul '11

04 Jul '11

It has two modes, normal and interactive. In normal mode, messages are passed from libvirt to qemu and back as they come and copyied to stdout so that one can monitor the communication. In interactive mode, whenever a message comes from either libvirt or qemu, it is printed to stdout and the user is asked what action to take. One can also inject any message to either libvirt or qemu. Interactive mode can be entered by sending any command to monitor-proxy (sending an empty command, i.e., hitting enter enters interactive mode without doing anything else). The proxy can also be started directly in interactive mode by specifying "-i" command line option. Command "cont" can be used to return back to normal mode. For list of supported commands and their description, use "help" or "h" command. To start monitor-proxy one needs to follow the following steps: - start a domain - run monitor-proxy [-i] <monitor socket path> for example: monitor-proxy /var/lib/libvirt/qemu/vm1.monitor - restart libvirtd (this makes libvirtd disconnect from qemu and reconnect to the proxy) monitor-proxy supports libvirtd restarts, i.e., if libvirtd disconnects, the proxy just waits until it reconnects again. Stopping the proxy while libvirtd is running kills the domain since libvirtd sees monitor EOF. To stop using monitor-proxy without killing the domain, one needs to stop libvirtd, stop monitor-proxy, and start libvirtd. The proxy works by renaming qemu monitor socket so that it can listen at the original place for connections from libvirtd. Once libvirtd connects to monitor-proxy, the proxy connects to qemu through the renamed socket. The socket is renamed back to its original name when proxy is killed or asked to exit. The proxy also supports fd passing through SCM_RIGHTS so to be usable for testing migrations. --- Makefile.am | 3 +- configure.ac | 3 +- examples/monitor-proxy/Makefile.am | 3 + examples/monitor-proxy/README | 36 ++ examples/monitor-proxy/monitor-proxy.c | 751 ++++++++++++++++++++++++++++++++ 5 files changed, 794 insertions(+), 2 deletions(-) create mode 100644 examples/monitor-proxy/Makefile.am create mode 100644 examples/monitor-proxy/README create mode 100644 examples/monitor-proxy/monitor-proxy.c diff --git a/Makefile.am b/Makefile.am index 49e42bf..1ac65e3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -6,7 +6,8 @@ GENHTML = genhtml SUBDIRS = gnulib/lib include src daemon tools docs gnulib/tests \ python tests po examples/domain-events/events-c examples/hellolibvirt \ examples/dominfo examples/domsuspend examples/python examples/apparmor \ - examples/xml/nwfilter examples/openauth examples/systemtap + examples/xml/nwfilter examples/openauth examples/systemtap \ + examples/monitor-proxy ACLOCAL_AMFLAGS = -I m4 -I gnulib/m4 diff --git a/configure.ac b/configure.ac index cd22afb..9d2fe04 100644 --- a/configure.ac +++ b/configure.ac @@ -2414,7 +2414,8 @@ AC_OUTPUT(Makefile src/Makefile include/Makefile docs/Makefile \ examples/python/Makefile \ examples/hellolibvirt/Makefile \ examples/systemtap/Makefile \ - examples/xml/nwfilter/Makefile) + examples/xml/nwfilter/Makefile \ + examples/monitor-proxy/Makefile) AC_MSG_NOTICE([]) AC_MSG_NOTICE([Configuration summary]) diff --git a/examples/monitor-proxy/Makefile.am b/examples/monitor-proxy/Makefile.am new file mode 100644 index 0000000..4fbbed5 --- /dev/null +++ b/examples/monitor-proxy/Makefile.am @@ -0,0 +1,3 @@ +noinst_PROGRAMS = monitor-proxy +monitor_proxy_CFLAGS = $(WARN_CFLAGS) +monitor_proxy_SOURCES = monitor-proxy.c diff --git a/examples/monitor-proxy/README b/examples/monitor-proxy/README new file mode 100644 index 0000000..bf00460 --- /dev/null +++ b/examples/monitor-proxy/README @@ -0,0 +1,36 @@ +monitor-proxy is meant as a developer tool for testing libvirt-qemu +communication. + +It has two modes, normal and interactive. In normal mode, messages are passed +from libvirt to qemu and back as they come and copyied to stdout so that one +can monitor the communication. In interactive mode, whenever a message comes +from either libvirt or qemu, it is printed to stdout and the user is asked +what action to take. One can also inject any message to either libvirt or +qemu. Interactive mode can be entered by sending any command to monitor-proxy +(sending an empty command, i.e., hitting enter enters interactive mode without +doing anything else). The proxy can also be started directly in interactive +mode by specifying "-i" command line option. Command "cont" can be used to +return back to normal mode. For list of supported commands and their +description, use "help" or "h" command. + +To start monitor-proxy one needs to follow the following steps: +- start a domain +- run monitor-proxy [-i] <monitor socket path> + for example: monitor-proxy /var/lib/libvirt/qemu/vm1.monitor +- restart libvirtd (this makes libvirtd disconnect from qemu and reconnect to + the proxy) + +monitor-proxy supports libvirtd restarts, i.e., if libvirtd disconnects, the +proxy just waits until it reconnects again. Stopping the proxy while libvirtd +is running kills the domain since libvirtd sees monitor EOF. To stop using +monitor-proxy without killing the domain, one needs to stop libvirtd, stop +monitor-proxy, and start libvirtd. + +The proxy works by renaming qemu monitor socket so that it can listen at the +original place for connections from libvirtd. Once libvirtd connects to +monitor-proxy, the proxy connects to qemu through the renamed socket. The +socket is renamed back to its original name when proxy is killed or asked to +exit. + +The proxy also supports fd passing through SCM_RIGHTS so to be usable for +testing migrations. diff --git a/examples/monitor-proxy/monitor-proxy.c b/examples/monitor-proxy/monitor-proxy.c new file mode 100644 index 0000000..403033d --- /dev/null +++ b/examples/monitor-proxy/monitor-proxy.c @@ -0,0 +1,751 @@ +#include <stdlib.h> +#include <stdio.h> +#include <stdbool.h> +#include <stdarg.h> +#include <string.h> +#include <signal.h> +#include <unistd.h> +#include <fcntl.h> +#include <errno.h> +#include <sys/select.h> +#include <sys/socket.h> +#include <sys/un.h> + +# ifndef ATTRIBUTE_FMT_PRINTF +# if __GNUC_PREREQ (4, 4) +# define ATTRIBUTE_FMT_PRINTF(fmtpos,argpos) __attribute__((__format__ (gnu_printf, fmtpos,argpos))) +# else +# define ATTRIBUTE_FMT_PRINTF(fmtpos,argpos) __attribute__((__format__ (printf, fmtpos,argpos))) +# endif +# endif + +# ifndef ATTRIBUTE_NORETURN +# define ATTRIBUTE_NORETURN __attribute__((__noreturn__)) +# endif + +#ifndef UNIX_PATH_MAX +# define UNIX_PATH_MAX 108 +#endif +#define SOCK_SUFFIX ".proxy" +#define SIZE (1 << 14) + +#define LABEL_LIBVIRT "libvirt> " +#define LABEL_QEMU "qemu> " +#define LABEL_PROMPT "command> " + +enum party { + PARTY_QEMU, + PARTY_LIBVIRT +}; + +enum command { + CMD_NONE, + CMD_NOOP, + CMD_UNKNOWN, + CMD_CONTINUE, + CMD_QUIT, + CMD_HELP, + CMD_PASS, + CMD_DISCARD, + CMD_SEND_QEMU, + CMD_SEND_LIBVIRT +}; + +struct proxy_command { + enum command command; + const char *name; + bool shortcut; + bool argument; + const char *description; +}; + +const char *monitor; +char *monitor_qemu; + +char *buffer; +char *control; +char *commands; + +struct message { + enum party source; + int fd_qemu; + int fd_libvirt; + struct msghdr hdr; +}; + + +#define ncommands (sizeof(proxy_commands) / sizeof(*proxy_commands)) +static const struct proxy_command proxy_commands[] = { + { + CMD_CONTINUE, + "cont", true, false, + "leave interactive mode" + }, { + CMD_QUIT, + "quit", false, false, + "quit monitor-proxy" + }, { + CMD_HELP, + "help", true, false, + "print this help" + }, { + CMD_PASS, + "pass", true, false, + "pass current data to its destination" + }, { + CMD_DISCARD, + "discard", true, false, + "discard current data" + }, { + CMD_SEND_QEMU, + "qemu", true, true, + "send DATA to qemu" + }, { + CMD_SEND_LIBVIRT, + "libvirt", true, true, + "send DATA to libvirt" + } +}; + + +static void ATTRIBUTE_NORETURN +usage(int ret) +{ + fprintf(stderr, "monitor-proxy [-i] <qemu monitor socket>\n"); + exit(ret); +} + + +static void ATTRIBUTE_FMT_PRINTF(1, 2) +print(const char *msg, ...) +{ + va_list args; + + printf("* "); + va_start(args, msg); + vprintf(msg, args); + va_end(args); + printf("\n"); + fflush(NULL); +} + + +#define HELP_LINE 80 +#define HELP_NAME 20 +static void +help(void) +{ + unsigned int i; + char line[HELP_LINE]; + char name[HELP_NAME]; + + print("Available proxy commands:"); + for (i = 0; i < ncommands; i++) { + const struct proxy_command *cmd = proxy_commands + i; + + if (cmd->shortcut) + snprintf(name, HELP_NAME, "%c(%s)", cmd->name[0], cmd->name + 1); + else + strncpy(name, cmd->name, HELP_NAME); + name[HELP_NAME - 1] = '\0'; + if (cmd->argument) { + strncpy(name + strlen(name), " DATA", HELP_NAME - strlen(name)); + name[HELP_NAME - 1] = '\0'; + } + + snprintf(line, HELP_LINE, " %-*s %s", + HELP_NAME, name, cmd->description); + line[HELP_LINE - 1] = '\0'; + print("%s", line); + } + print("Signals:"); + print(" SIGINT (^C) quit monitor-proxy"); +} + + +static int +move_socket(void) +{ + if (monitor_qemu) { + fprintf(stderr, "Socket already moved to %s\n", monitor_qemu); + return -1; + } + + monitor_qemu = malloc(strlen(monitor) + strlen(SOCK_SUFFIX) + 1); + if (!monitor_qemu) + return -1; + + sprintf(monitor_qemu, "%s%s", monitor, SOCK_SUFFIX); + + if (rename(monitor, monitor_qemu) < 0) { + perror("Cannot move monitor socket"); + free(monitor_qemu); + monitor_qemu = NULL; + return -1; + } + + print("Monitor socket renamed as %s", monitor_qemu); + + return 0; +} + + +static int +restore_socket(void) +{ + if (!monitor_qemu) + return 0; + + if (rename(monitor_qemu, monitor) < 0) { + perror("Cannot restore monitor socket"); + return -1; + } + + print("Monitor socket renamed back to %s", monitor); + + free(monitor_qemu); + monitor_qemu = NULL; + + return 0; +} + + +static void ATTRIBUTE_NORETURN +signal_handler(int signum) +{ + restore_socket(); + + if (signum == SIGINT) + exit(0); + else + exit(1); +} + + +static int +open_qemu(void) +{ + struct sockaddr_un addr; + int fd = -1; + + if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) == -1) { + perror("Cannot create monitor socket"); + goto error; + } + + addr.sun_family = AF_UNIX; + strncpy(addr.sun_path, monitor_qemu, UNIX_PATH_MAX); + addr.sun_path[UNIX_PATH_MAX - 1] = '\0'; + + if (connect(fd, (struct sockaddr *) &addr, sizeof(addr)) < 0) { + perror("Cannot connect to qemu monitor"); + goto error; + } + + print("Connected to qemu monitor"); + + return fd; + +error: + close(fd); + return -1; +} + + +static int +listen_libvirt(void) +{ + struct sockaddr_un addr; + int fd = -1; + + if ((fd = socket(PF_UNIX, SOCK_STREAM, 0)) == -1) { + perror("Cannot create listening socket"); + goto error; + } + + addr.sun_family = AF_UNIX; + strncpy(addr.sun_path, monitor, UNIX_PATH_MAX); + addr.sun_path[UNIX_PATH_MAX - 1] = '\0'; + + if (bind(fd, (struct sockaddr *) &addr, sizeof(addr)) < 0) { + perror("Cannot bind listening socket"); + goto error; + } + + if (listen(fd, 1) < 0) { + perror("Cannot listen"); + goto error; + } + + return fd; + +error: + close(fd); + return -1; +} + + +static int +accept_libvirt(int sock) +{ + int fd = -1; + + print("Waiting for libvirt connection"); + + if ((fd = accept(sock, NULL, NULL)) == -1) { + perror("Cannot accept connection from libvirt"); + goto error; + } + + print("Libvirt connection accepted"); + + return fd; + +error: + close(fd); + return -1; +} + + +static int +init_message(struct message *msg, int qemu, int libvirt) +{ + struct iovec *iov; + + if (!(iov = malloc(sizeof(*iov)))) + return -1; + + memset(msg, 0, sizeof(*msg)); + msg->fd_qemu = qemu; + msg->fd_libvirt = libvirt; + msg->hdr.msg_iov = iov; + msg->hdr.msg_iovlen = 1; + + return 0; +} + + +static ssize_t +receive_message(enum party source, struct message *msg) +{ + ssize_t count; + int fd = source == PARTY_QEMU ? msg->fd_qemu : msg->fd_libvirt; + + msg->source = source; + msg->hdr.msg_iov[0].iov_base = buffer; + msg->hdr.msg_iov[0].iov_len = SIZE; + msg->hdr.msg_control = control; + msg->hdr.msg_controllen = SIZE; + + if ((count = recvmsg(fd, &msg->hdr, 0)) >= 0) { + msg->hdr.msg_iov[0].iov_len = count; + if (msg->hdr.msg_controllen == 0) + msg->hdr.msg_control = NULL; + } + + return count; +} + + +static void +send_message(enum party target, struct message *msg) +{ + int fd = target == PARTY_QEMU ? msg->fd_qemu : msg->fd_libvirt; + + if (sendmsg(fd, &msg->hdr, 0) < 0) { + if (target == PARTY_QEMU) { + perror("Cannot send message to qemu"); + } else { + perror("Cannot send message to libvirt"); + } + } + + msg->hdr.msg_iov[0].iov_base = NULL; + msg->hdr.msg_iov[0].iov_len = 0; + msg->hdr.msg_control = NULL; + msg->hdr.msg_controllen = 0; +} + + +static int +write_all(int fd, const char *buf, size_t count) +{ + size_t written = 0; + ssize_t w; + + while (count > 0) { + w = write(fd, buf, count); + + if (w == 0) { + break; + } else if (w < 0) { + if (errno == EINTR) + continue; + perror("Cannot write data"); + return -1; + } + + buf += w; + count -= w; + written += w; + } + + return written; +} + + +static int +output(const char *label, const struct message *msg) +{ + ssize_t start = 0; + char *buf = msg->hdr.msg_iov[0].iov_base; + ssize_t count = msg->hdr.msg_iov[0].iov_len; + + while (start < count) { + ssize_t len = 0; + const char* p; + + if (write_all(STDOUT_FILENO, label, strlen(label)) < 0) + return -1; + + p = buf + start; + while (start + len < count && *p != '\n') { + len++; + p++; + } + if (start + len < count) + len++; + + if (write_all(STDOUT_FILENO, buf + start, len) < 0) + return -1; + + start += len; + } + + return 0; +} + + +static ssize_t +read_line(char *buf, size_t size, bool data) +{ + ssize_t count = 0; + struct timeval tv = { 0, 0 }; + struct timeval *timeout; + fd_set fds; + int ret; + + FD_ZERO(&fds); + FD_SET(STDIN_FILENO, &fds); + + if (data) + timeout = NULL; + else + timeout = &tv; + + ret = select(STDIN_FILENO + 1, &fds, NULL, NULL, timeout); + if (ret < 0) + return -1; + if (ret == 0) + return 0; + + while (count < size - 1 && read(STDIN_FILENO, buf, 1) == 1) { + count++; + if (*buf == '\n') { + *buf = '\r'; + *++buf = '\n'; + count++; + break; + } + buf++; + } + return count; +} + + +static enum command +get_command(char **cmd_buf, ssize_t *cmd_len, bool data) +{ + ssize_t len; + unsigned int i; + + if (data) + write_all(STDOUT_FILENO, LABEL_PROMPT, strlen(LABEL_PROMPT)); + + len = read_line(commands, SIZE, data); + if (len < 0) + return CMD_QUIT; + if (len == 0) + return CMD_NONE; + if (len <= 2) + return CMD_NOOP; + + commands[len] = '\0'; + + for (i = 0; i < ncommands; i++) { + const struct proxy_command *cmd = proxy_commands + i; + int skip; + + if (strncmp(commands, cmd->name, strlen(cmd->name)) == 0) + skip = strlen(cmd->name); + else if (cmd->shortcut && *commands == *cmd->name) + skip = 1; + else + continue; + + if (cmd->argument) { + if (commands[skip] == ' ') { + skip++; + *cmd_buf = commands + skip; + *cmd_len = len - skip; + return cmd->command; + } + } else { + if (strncmp(commands + skip, "\r\n", 2) == 0) + return cmd->command; + } + } + + commands[len - 2] = '\0'; + *cmd_buf = commands; + *cmd_len = len - 2; + return CMD_UNKNOWN; +} + + +static int +process_commands(struct message *msg, bool *interactive) +{ + enum party source = msg->source; + ssize_t data_len = msg->hdr.msg_iov[0].iov_len; + ssize_t control_len = msg->hdr.msg_controllen; + bool data = data_len > 0 || control_len > 0; + enum command cmd; + char *cmd_buf = NULL; + ssize_t cmd_len = 0; + + msg->hdr.msg_iov[0].iov_base = NULL; + msg->hdr.msg_iov[0].iov_len = 0; + msg->hdr.msg_control = NULL; + msg->hdr.msg_controllen = 0; + + if (data) { + print("Processing data from %s", + source == PARTY_QEMU ? "qemu" : "libvirt"); + print(" Enter proxy commands (type \"help\" to list them)"); + print(" Finish processing with \"pass\" or \"discard\" command"); + } + + while (*interactive && + (cmd = get_command(&cmd_buf, &cmd_len, data)) != CMD_NONE) { + switch (cmd) { + case CMD_NONE: + case CMD_NOOP: + break; + + case CMD_QUIT: + return -1; + + case CMD_HELP: + help(); + break; + + case CMD_UNKNOWN: + print("Unknown command: \"%s\"", cmd_buf); + break; + + case CMD_CONTINUE: + *interactive = false; + print("Leaving interactive mode"); + case CMD_PASS: + if (data_len > 0) { + msg->hdr.msg_iov[0].iov_len = data_len; + msg->hdr.msg_iov[0].iov_base = buffer; + } + if (control_len > 0) { + msg->hdr.msg_controllen = control_len; + msg->hdr.msg_control = control; + } + if (data) { + print("Passing data from %s to %s", + source == PARTY_QEMU ? "qemu" : "libvirt", + source == PARTY_QEMU ? "libvirt" : "qemu"); + send_message(source == PARTY_QEMU ? PARTY_LIBVIRT : PARTY_QEMU, + msg); + data = false; + } else { + if (cmd == CMD_PASS) + print("No data to pass"); + } + break; + + case CMD_DISCARD: + if (data) { + print("Discarding data from %s", + source == PARTY_QEMU ? "qemu" : "libvirt"); + } else { + print("No data to discard"); + } + data_len = control_len = 0; + data = false; + break; + + case CMD_SEND_QEMU: + case CMD_SEND_LIBVIRT: + msg->hdr.msg_iov[0].iov_len = cmd_len; + msg->hdr.msg_iov[0].iov_base = cmd_buf; + send_message(cmd == CMD_SEND_QEMU ? PARTY_QEMU : PARTY_LIBVIRT, + msg); + break; + } + } + + return 0; +} + + +static int +process_data(struct message *msg, bool *interactive) +{ + output(msg->source == PARTY_QEMU ? LABEL_QEMU : LABEL_LIBVIRT, msg); + + if (!*interactive) { + send_message(msg->source == PARTY_QEMU ? PARTY_LIBVIRT : PARTY_QEMU, + msg); + } else { + return process_commands(msg, interactive); + } + + return 0; +} + + +static int +proxy(bool *interactive, int libvirt, int qemu) +{ + fd_set fds; + int maxfd; + struct message msg; + int ret = -1; + ssize_t count; + + print("New monitor session"); + if (*interactive) + print("Entering interactive mode"); + + if (init_message(&msg, qemu, libvirt) < 0) { + perror("Cannot initialize msghdr"); + goto cleanup; + } + + maxfd = libvirt > qemu ? libvirt : qemu; + while (1) { + FD_ZERO(&fds); + FD_SET(STDIN_FILENO, &fds); + FD_SET(libvirt, &fds); + FD_SET(qemu, &fds); + + if (select(maxfd + 1, &fds, NULL, NULL, NULL) == -1) { + perror("select() failed"); + goto cleanup; + } + + if (FD_ISSET(qemu, &fds)) { + if ((count = receive_message(PARTY_QEMU, &msg)) <= 0) { + if (count < 0) + perror("Cannot receive message from qemu"); + else + print("Qemu closed connection"); + goto cleanup; + } + if (process_data(&msg, interactive) < 0) + goto cleanup; + } + + if (FD_ISSET(libvirt, &fds)) { + if ((count = receive_message(PARTY_LIBVIRT, &msg) <= 0)) { + if (count < 0) { + perror("Cannot receive message from libvirt"); + } else { + print("Libvirt closed connection"); + ret = 0; + } + goto cleanup; + } + if (process_data(&msg, interactive) < 0) + goto cleanup; + } + + if (!*interactive && FD_ISSET(STDIN_FILENO, &fds)) { + print("Entering interactive mode"); + *interactive = true; + } + + if (*interactive && process_commands(&msg, interactive) < 0) + goto cleanup; + } + +cleanup: + print("Session closed"); + + close(libvirt); + close(qemu); + return ret; +} + + +int +main(int argc, char **argv) +{ + int sock = -1; + int libvirt = -1; + bool interactive = false; + + if (argc < 2) + usage(2); + + if (strcmp(argv[1], "-i") == 0) { + interactive = true; + if (argc < 3) + usage(2); + monitor = argv[2]; + } else { + monitor = argv[1]; + } + + signal(SIGHUP, signal_handler); + signal(SIGINT, signal_handler); + signal(SIGQUIT, signal_handler); + signal(SIGABRT, signal_handler); + signal(SIGKILL, signal_handler); + signal(SIGPIPE, SIG_IGN); + signal(SIGTERM, signal_handler); + + if (move_socket() < 0) + goto error; + + buffer = malloc(SIZE); + control = malloc(SIZE); + commands = malloc(SIZE); + if (!buffer || !control || !commands) + goto error; + + if ((sock = listen_libvirt()) == -1) + goto error; + + while ((libvirt = accept_libvirt(sock)) != -1) { + int qemu; + + if ((qemu = open_qemu()) != -1) { + if (proxy(&interactive, libvirt, qemu) < 0) + break; + } else { + close(libvirt); + } + } + +error: + restore_socket(); + close(sock); + return 1; +} -- 1.7.6

3 2

[libvirt] Network device abstraction aka virtual switch - V3
by Laine Stump 03 Jul '11

03 Jul '11

This is a followup to https://www.redhat.com/archives/libvir-list/2011-April/msg00591.html (and an even earlier draft) which I alluded to here: https://www.redhat.com/archives/libvir-list/2011-June/msg00383.html Network device abstraction aka virtual switch - V3 ================================================== The <interface> element of a guest's domain config in libvirt has a <source> element that describes what resources on a host will be used to connect the guest's network interface to the rest of the world. This is very flexible, allowing several different types of connection (virtual network, host bridge, direct macvtap connection to physical interface, qemu usermode, user-defined via an external script), but currently has the problem that unnecessary details of the host resources are embedded into the guest's config; if the guest is migrated to a different host, and that host has a different hardware or network config (or possibly the same hardware, but that hardware is currently in use by a different guest), the migration will fail. I am proposing a change to libvirt's network XML that will allow us to (optionally - old configs will remain valid) remove the host details from the guest's domain XML (which can move around from host to host) and place them in the network XML (which remains with a single host); the domain XML will then use existing config elements to associate each guest interface with a "network". The motivating use case for this change is the "direct" connection type (which uses macvtap for vepa and vnlink connections directly between a guest and a physical interface, rather than through a bridge), but it is applicable for all types of connection. (Another hopeful side effect of this change will be to make libvirt's network connection model easier to realize on non-Linux hypervisors (eg, VMWare ESX) and for other network technologies, such as openvswitch, VDE, and various VPN implementations). Background ========== (parts lifted from Dan Berrange's last mail on this subject) Currently <network> supports 3 connectivity modes - Non-routed network, separate subnet (no <forward> element present) - Routed network, separate subnet with NAT (<forward mode='nat'/>) - Routed network, separate subnet (<forward mode='route'/>) Each of these is implemented in the existing network driver by creating a bridge device using brctl, and connecting the guest network interfaces via tap devices (a detail which, now that I've stated it, you should promptly forget!). All traffic between that bridge and the outside network is done via the host's IP routing stack (ie, there is no physical device directly connected to the bridge) In the future, these two additional routed modes might be useful: - Routed network, IP subnetting - Routed network, separate subnet with VPN The core goal of this proposal, though, is to replace type=bridge and type=direct from the domain interface XML with new types of <network> definitions so that the domain can just give "type='network'" and have all the necessary details filled in at runtime. This basically means we're adding several bridging modes (the submodes of "direct" have been flattened out here): - Bridged network, eth + bridge + tap - Bridged network, eth + macvtap + vepa - Bridged network, eth + macvtap + private - Bridged network, eth + macvtap + passthrough - Bridged network, eth + macvtap + bridge Another "future expansion" could be to add: - Bridged network, with VPN Likewise, support for other technologies, such as openvswitch and VDE would each be another entry on this list. (Dan also listed each of the above "+sriov" separately, but that ends up being handled in an orthogonal manner (by just specifying a pool of interfaces for a single network), so I'm only giving the abbreviated list) I. Changes to domain <interface> element ======================================== In many cases, the <interface> element of the domain XML will be identical to what is used now when connecting the interface to a libvirt-style virtual network: <interface type='network'> <source network='red-network'/> <mac address='xx:xx:xx:xx:xx:xx'/> </interface> Depending on the definition of the network "red-network" on the host the guest was started on / migrated to, this could be either a direct (macvtap) connection using one of the various direct modes (vepa/private/bridge/passthrough), a bridge (again, pointed to by the definition of 'red-network'), or a virtual network (using the current network definition syntax). This way the same guest could be migrated not only between macvtap-enabled hosts, but from there to a host using a bridge, or maybe a host in a remote location that used a virtual network with a secure tunnel to connect back to the rest of the red-network. (Part of the migration process would of course check that the destination host had a network of the proper name with adequate available resources, and fail if it didn't; management software at a level above libvirt would probably filter a list of candidate migration destinations based on available networks and any various details of those networks (eg. it could search for only networks using vepa for the connection), and only attempt migration to one that had the matching network available). <virtualport> element of <interface> ------------------------------------ Since many of the attributes/sub-elements of <virtualport> (used by some modes of "direct" interface connections) are identical for all interfaces connecting to any given switch, most of the information in <virtualport> will be optional in the domain's interface definition - it can be filled in from a similar <virtualport> element that will be added to the <network> definition. Some parameters in <virtualport> ("instanceid", for example) must be unique for every interface, though, so those will still be specified in the <interface> XML. The two <virtualport> elements will be OR'ed at runtime to arrive at the actual set of parameters that are used. (Open Question: What should be the policy when a parameter is specified in both places? Should one take precedence? Or should it be considered an error?) portgroup attribute of <source> ------------------------------- The <source> element of an interface definition will be able to optionally specify a "portgroup" attribute. If portgroup is *NOT* given, the default (first) portgroup of the network will be used (if any are defined). If portgroup *IS* specified, the source network must have a portgroup by that name (or the domain startup/migration will fail), and the attributes of that portgroup will be used for the connection. Here is an example <interface> definition that has both a reduced <virtualport> element, as well as a portgroup attribute: <interface type='network'> <source network='red-network' portgroup='engineering'/> <virtualport type="802.1Qbg"> <parameters instanceid="09b11c53-8b5c-4eeb-8f00-d84eaa0aaa4f"/> </virtualport> <mac address='de:ad:be:ef:ca:fe'/> </interface> (The specifics of what can be in a portgroup are given below) II. Changes to <network> definition =================================== As Dan has pointed out, any additions to <network> must be designed so that existing management applications (written to understand <network> prior to these new additions) will at least recognize that the XML they've been given is for something new that they don't fully understand. At the same time, the new types of network definition should attempt to re-use as much of the existing elements/attributes as possible, both to make it easier to extend these applications, as well as to make the status displays of un-updated applications make as much sense as possible. Dan's suggestion (which I obviously endorse :-) is that the new types of network should be specified by extending the choices for <forward mode='....'>. He also suggested adding a new "layer='network|link'" attribute to <forward>. I'm not convinced that item is necessary (it seems redundant), but am including it here for sake of discussion. The current modes are: <forward layer='network' mode='route|nat'/> (in addition to not listing any mode, which equates to "isolated") Here are suggested new modes: <forward layer='link' mode='bridge-brctl|vepa|private|passthrough|bridge-macvtap'/> A description of each: bridge-brctl - equivalent to "<interface type='bridge'>" in the interface definition. The bridge device to use would be given in the existing <forward dev='xxx'>. (Dan also suggests putting this in <network>'s <bridge name='xxx'/> - opinions?) (Question: better name for this?) vepa - same as "<interface type='direct'>..." with <source mode='vepa'/> private - <interface type='direct'> ... <source mode='private'/> passthrough - <interface type='direct'> ... <source mode='passthrough'/> bridge-macvtap - <interface type='direct'> ... <source mode='bridge'/> (Question: better name for this?) Interface Pools --------------- In many cases, a single host network may have multiple physical network devices associated with it (especially in the case of an SRIOV-capable ethernet card, which will have several "virtual functions" associated with a single physical ethernet connection). The host will at least want to balance the load of multiple guests between these multiple devices, and may even require (in the case of passthrough mode, for example) that only a single guest interface be attached to each host device. The current specification for <forward> only allows for a single "dev" attribute, though. In order to support multiple device names, we will extend <forward> to allow 0 or more <interface> sub-elements: <forward mode='vepa' dev='eth10'/> <interface dev='eth10'/> <interface dev='eth11'/> <interface dev='eth12'/> <interface dev='eth13'/> </forward> Note that, as a convenience, the first of these elements will always be a duplicate of the "dev" attribute in <forward> itself. (Is this necessary/desirable?) In the case of mode='passthrough', only one guest interface can be connected to a device at a time. libvirt will keep track of which devices are in use, and attempt to assign a free device; failure to assign a device will result in a failure of the domain to start/migrate. For the other direct modes, libvirt will simply keep track of the number of guest interfaces currently using each device, and attempt to keep them balanced. (Open question: where will we keep track of this allocation/assignment?) Portgroups ----------- A <portgroup> (sub-element of <network>) is just a way of easily putting connections to the network into different classes, with each class having a different level/type of service. Each <network> can have multiple <portgroup> elements, and each <portgroup> has a name, as well as various attributes associated with it. The first thing we will use portgroups for is as an alternate place to specify <virtualport> parameters: <portgroup name='engineering'> <virtualport type="802.1Qbg"> <parameters managerid="11" typeid="1193047" typeidversion="2"/> </virtualport> </portgroup> Anything that is valid in an interface's <virtualport> is also valid here. The next thing to specify in a portgroup will be bandwidth limiting / QoS configuration. Since I don't know exactly what's needed for that, I won't specify it here. If anything is specified both directly under <network> and in a <portgroup>, the value in portgroup will take precedence. (Again - what will the precedence of items specified in the <interface> be?) EXAMPLES -------- Examples of 'red-network' for different types of connections (all of these would work with minor variations of the interface XML given above, e.g. the 'vepa' version would require <virtualport> in the interface that specified an instanceid, and if the <interface> specified a portgroup, it would need to also be in the <network> definition (even if it was empty aside from name).  <network> <name>red-network</name> <bridge name='virbr0'/> <forward layer='network' mode='route'/> ... </network>  <network> <name>red-network</name> <forward mode='bridge-brctl' dev='br0'/> </network>  <network> <name>red-network</name> <forward layer='link' mode='vepa' dev='eth10'/> <virtualport type='802.1Qbg'> <parameters managerid='11' typeid='1193047' typeidversion='2'/> </virtualport>   <portgroup name='accounting'> <virtualport> <parameters typeid='22'/> </virtualport> </portgroup> <portgroup name='engineering'> <virtualport> <parameters typeid='33'/> </virtualport> </portgroup> </network>  <network> <name>red-network</name> <forward layer='link' mode='passthrough' dev='eth10'/> <interface dev='eth10'/> <interface dev='eth11'/> <interface dev='eth12'/> <interface dev='eth13'/> <interface dev='eth14'/> <interface dev='eth15'/> <interface dev='eth16'/> <interface dev='eth17'/> </forward> </network> ============= Open Questions: * Is there a good reason to include the "layer='network|link'" attribute in forward? (maybe just because it's useful info for a management application that doesn't know the details of the modes?) Or is it redundant? * What should be the policy when a virtualport parameter is specified in both the <interface> and the <network>/<portgroup>? Should one take precedence? Or should it be considered an error? * Is it okay for the domain's own definition to specify what portgroup it will be in? Or are there cases where we want to allow someone to modify their domain XML, but force them into a particular portgroup beyond their control? * Is it really necessary/desirable for the first ethernet device in a pool to be duplicated in the <forward dev='xxx'...> attribute? Or can that attribute be omitted when there is a pool of devices? * Where will we keep track of the count of guest interfaces connected to each host interface device, and where will we keep track of which device is being used by a particular guest interface? In the network/domain XML? * Does anyone have better names for "brctl-bridge" and "macvtap-bridge"?

6 11

[libvirt] FreeBSD Port, update to 0.9.2 compile error
by Jason Helfman 01 Jul '11

01 Jul '11

Hi, I am trying to update the port for libvirt to 0.9.2, but am receiving a new compiling error, that I have not seen yet. console.c:280: warning: declaration of 'devname' shadows a global declaration [-Wshadow] /usr/include/stdlib.h:264: warning: shadowed declaration is here [-Wshadow] CC virsh-virsh.o CCLD virsh GEN virt-xml-validate GEN virt-pki-validate gmake[3]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.2/tools' gmake[2]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.2/tools' Making all in docs gmake[2]: Entering directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.2/docs' GEN libvirt-api.xml ./apibuild.py: not found gmake[2]: *** [libvirt-api.xml] Error 127 gmake[2]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.2/docs' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.2' gmake: *** [all] Error 2 *** Error code 1 Stop in /home/jhelfman/ports/devel/libvirt. Any thoughts? Thanks, Jason -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5

5 19

[libvirt] [PATCH] build: avoid 'make syntax-check' failure
by Eric Blake 01 Jul '11

01 Jul '11

* tests/utiltest.c (DO_TEST): Fix indentation for cppi. --- Pushing under the build-breaker rule. tests/utiltest.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/utiltest.c b/tests/utiltest.c index 1b26b72..774a2f7 100644 --- a/tests/utiltest.c +++ b/tests/utiltest.c @@ -160,7 +160,7 @@ mymain(void) virSetErrorFunc(NULL, testQuietError); - #define DO_TEST(_name) \ +#define DO_TEST(_name) \ do { \ if (virtTestRun("Util "#_name, 1, test##_name, \ NULL) < 0) { \ -- 1.7.4.4

1 0

[libvirt] virtual switch - how to store state information
by Laine Stump 01 Jul '11

01 Jul '11

(If you already know about my work on putting a logical switch abstraction into libvirt's <network>, skip to part 2) INTRODUCTION =========== The rudimentary logical network switch capability I'm currently implementing (see https://bugzilla.redhat.com/show_bug.cgi?id=643947) is intended to allow a guest's interface XML to be free of any specific physical network device name, particularly in bridge and direct modes. It does this by expanding the definition of a libvirt <network> to include cases that merely describe a host-configured bridge, or a host interface (or pool of interfaces) that can be used by a guest in one of the 'direct' modes (bridge, private, vepa, or passthrough). It will also allow certain details of the guest's network connection to be configured by "portgroups" in the <network> definition (initially this will be limited to a portgroup containing a <virtualportprofile> and bandwidth limiting information). For example, in the past, a guest that wanted to connect to interface eth10 using the direct (aka 'macvtap') "vepa" mode would need to have this <interface> in its guest XML: <interface type='direct'> <mac address='52:54:00:34:a5:aa'/> <source dev='eth10' mode='vepa'/> <model type='virtio'/> <virtualport type='802.1Qbg'> <parameters managerid='33' typeid='89' typeidversion='3'/> </virtualport> </interface> With my new code, you can instead define a <network> with connections on several physical ethernets: <network> <name>test</name> <forward mode='vepa'> <interface dev='eth10'/> <interface dev='eth11'/> <interface dev='eth12'/> <interface dev='eth13'/> <interface dev='eth14'/> <interface dev='eth15'/> <interface dev='eth16'/> <interface dev='eth17'/> </forward> <portgroup name='accounting'> <virtualport type='802.1Qbg'> <parameters managerid='44' typeid='54' typeidversion='1'/> </virtualport> </portgroup> <portgroup name='engineering' default='yes'> <virtualport type='802.1Qbg'> <parameters managerid='33' typeid='89' typeidversion='3'/> </virtualport> </portgroup> </network> and then tell the domain's <interface> to get the information from the network: <interface type='network'> <mac address='52:54:00:34:a5:aa'/> <source network='test' portgroup='engineering'/> <model type='virtio'/> </interface> When libvirt sets up the interface connection, it will grab the config for network 'test', see that the forward mode is 'vepa', decide which physical ethernet to use, add in any extra stuff from the <portgroup>, and use that as the information for connection. In this manner, 1) it will remove the hardcoded device name from the domain config, making it possible to migrate the domain to other hardware, and 2) share a pool of physical devices over a group of domains. PROPOSAL ======== After I've determined which physical device to use, I need to save that information for as long as the domain is running, so that if libvirtd is restarted, it won't be lost (in some configs, only a single guest can use any particular netdev at a given time, so we want to be able to manage allocation of the devices without leaking any). My current idea is to save this in the domain <interface> XML that's put in the state directory, but make sure that it's never put into the XML returned by virsh dumpxml. What I'm thinking of is to add an <actual> subelement under <interface>, like this: <interface type='network'> <mac address='52:54:00:34:a5:aa'/> <source network='test' porgroup='engineering'/> <model type='virtio'/> <actual type='direct'/> <source dev='eth10' mode='vepa'/> <virtualport type='802.1Qbg'> <parameters managerid='33' typeid='89' typeidversion='3'/> </virtualport> </actual> </interface> This will be a private/internal thing used only within libvirt, however it does need to be stable, since it has to be understandable by a libvirtd that has started up while guests are running (eg during a libvirt upgrade). So I want to make sure I'm doing something reasonable. So, it is? Should <actual> contain *everything* from the parent interface, plus the items that are changed? Or should it contain only: * type attribute * source element * <bridge name=.../> (if applicable) * <virtualport> (and other items that might come from <portgroup> in the future (i.e. the things that have changed)? I *think* the answer is that it should just contain the items that have changed, and there should be a wrapper API around the virDomainNetDef object for retrieving things like type (if (def->actual) return def->actual.type; else return def->type; and similar) to make sure that all functions use the correct data.

1 0

[libvirt] [PATCH] tests: Add a general util test
by Matthias Bolte 01 Jul '11

01 Jul '11

Move non-esx specific tests from esxutilstest there and add a test for virParseVersionString. --- tests/.gitignore | 1 + tests/Makefile.am | 8 ++- tests/esxutilstest.c | 70 -------------------- tests/utiltest.c | 178 ++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 186 insertions(+), 71 deletions(-) create mode 100644 tests/utiltest.c diff --git a/tests/.gitignore b/tests/.gitignore index 7f26dd7..32457ab 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -30,6 +30,7 @@ sockettest statstest storagepoolxml2xmltest storagevolxml2xmltest +utiltest virbuftest virnetmessagetest virnetsockettest diff --git a/tests/Makefile.am b/tests/Makefile.am index 4bea18e..30b2d95 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -84,7 +84,8 @@ EXTRA_DIST = \ check_PROGRAMS = virshtest conftest sockettest \ nodeinfotest qparamtest virbuftest \ commandtest commandhelper seclabeltest \ - hashtest virnetmessagetest virnetsockettest ssh + hashtest virnetmessagetest virnetsockettest ssh \ + utiltest # This is a fake SSH we use from virnetsockettest ssh_SOURCES = ssh.c @@ -202,6 +203,7 @@ TESTS = virshtest \ hashtest \ virnetmessagetest \ virnetsockettest \ + utiltest \ $(test_scripts) if HAVE_YAJL @@ -460,6 +462,10 @@ jsontest_SOURCES = \ jsontest.c testutils.h testutils.c jsontest_LDADD = $(LDADDS) +utiltest_SOURCES = \ + utiltest.c testutils.h testutils.c +utiltest_LDADD = $(LDADDS) + if WITH_LIBVIRTD eventtest_SOURCES = \ eventtest.c testutils.h testutils.c diff --git a/tests/esxutilstest.c b/tests/esxutilstest.c index 51c1e34..2097648 100644 --- a/tests/esxutilstest.c +++ b/tests/esxutilstest.c @@ -24,74 +24,6 @@ testQuietError(void *userData ATTRIBUTE_UNUSED, -static const char* names[] = { - "sda", "sdb", "sdc", "sdd", "sde", "sdf", "sdg", "sdh", "sdi", "sdj", "sdk", "sdl", "sdm", "sdn", "sdo", "sdp", "sdq", "sdr", "sds", "sdt", "sdu", "sdv", "sdw", "sdx", "sdy", "sdz", - "sdaa", "sdab", "sdac", "sdad", "sdae", "sdaf", "sdag", "sdah", "sdai", "sdaj", "sdak", "sdal", "sdam", "sdan", "sdao", "sdap", "sdaq", "sdar", "sdas", "sdat", "sdau", "sdav", "sdaw", "sdax", "sday", "sdaz", - "sdba", "sdbb", "sdbc", "sdbd", "sdbe", "sdbf", "sdbg", "sdbh", "sdbi", "sdbj", "sdbk", "sdbl", "sdbm", "sdbn", "sdbo", "sdbp", "sdbq", "sdbr", "sdbs", "sdbt", "sdbu", "sdbv", "sdbw", "sdbx", "sdby", "sdbz", - "sdca", "sdcb", "sdcc", "sdcd", "sdce", "sdcf", "sdcg", "sdch", "sdci", "sdcj", "sdck", "sdcl", "sdcm", "sdcn", "sdco", "sdcp", "sdcq", "sdcr", "sdcs", "sdct", "sdcu", "sdcv", "sdcw", "sdcx", "sdcy", "sdcz", - "sdda", "sddb", "sddc", "sddd", "sdde", "sddf", "sddg", "sddh", "sddi", "sddj", "sddk", "sddl", "sddm", "sddn", "sddo", "sddp", "sddq", "sddr", "sdds", "sddt", "sddu", "sddv", "sddw", "sddx", "sddy", "sddz", - "sdea", "sdeb", "sdec", "sded", "sdee", "sdef", "sdeg", "sdeh", "sdei", "sdej", "sdek", "sdel", "sdem", "sden", "sdeo", "sdep", "sdeq", "sder", "sdes", "sdet", "sdeu", "sdev", "sdew", "sdex", "sdey", "sdez", - "sdfa", "sdfb", "sdfc", "sdfd", "sdfe", "sdff", "sdfg", "sdfh", "sdfi", "sdfj", "sdfk", "sdfl", "sdfm", "sdfn", "sdfo", "sdfp", "sdfq", "sdfr", "sdfs", "sdft", "sdfu", "sdfv", "sdfw", "sdfx", "sdfy", "sdfz", - "sdga", "sdgb", "sdgc", "sdgd", "sdge", "sdgf", "sdgg", "sdgh", "sdgi", "sdgj", "sdgk", "sdgl", "sdgm", "sdgn", "sdgo", "sdgp", "sdgq", "sdgr", "sdgs", "sdgt", "sdgu", "sdgv", "sdgw", "sdgx", "sdgy", "sdgz", - "sdha", "sdhb", "sdhc", "sdhd", "sdhe", "sdhf", "sdhg", "sdhh", "sdhi", "sdhj", "sdhk", "sdhl", "sdhm", "sdhn", "sdho", "sdhp", "sdhq", "sdhr", "sdhs", "sdht", "sdhu", "sdhv", "sdhw", "sdhx", "sdhy", "sdhz", - "sdia", "sdib", "sdic", "sdid", "sdie", "sdif", "sdig", "sdih", "sdii", "sdij", "sdik", "sdil", "sdim", "sdin", "sdio", "sdip", "sdiq", "sdir", "sdis", "sdit", "sdiu", "sdiv", "sdiw", "sdix", "sdiy", "sdiz" -}; - -static int -testIndexToDiskName(const void *data ATTRIBUTE_UNUSED) -{ - int i; - char *name = NULL; - - for (i = 0; i < ARRAY_CARDINALITY(names); ++i) { - VIR_FREE(name); - - name = virIndexToDiskName(i, "sd"); - - if (STRNEQ(names[i], name)) { - virtTestDifference(stderr, names[i], name); - VIR_FREE(name); - - return -1; - } - } - - VIR_FREE(name); - - return 0; -} - -static int -testDiskNameToIndex(const void *data ATTRIBUTE_UNUSED) -{ - int i, k; - char *name = NULL; - - for (i = 0; i < 100000; ++i) { - VIR_FREE(name); - - name = virIndexToDiskName(i, "sd"); - k = virDiskNameToIndex(name); - - if (k != i) { - if (virTestGetDebug() > 0) { - fprintf(stderr, "\nExpect [%d]\n", i); - fprintf(stderr, "Actual [%d]\n", k); - } - - VIR_FREE(name); - - return -1; - } - } - - VIR_FREE(name); - - return 0; -} - - - struct testPath { const char *datastorePath; int result; @@ -336,8 +268,6 @@ mymain(void) } \ } while (0) - DO_TEST(IndexToDiskName); - DO_TEST(DiskNameToIndex); DO_TEST(ParseDatastorePath); DO_TEST(ConvertDateTimeToCalendarTime); DO_TEST(EscapeDatastoreItem); diff --git a/tests/utiltest.c b/tests/utiltest.c new file mode 100644 index 0000000..1b26b72 --- /dev/null +++ b/tests/utiltest.c @@ -0,0 +1,178 @@ +#include <config.h> + +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <unistd.h> + +#include "internal.h" +#include "memory.h" +#include "testutils.h" +#include "util.h" + + +static void +testQuietError(void *userData ATTRIBUTE_UNUSED, + virErrorPtr error ATTRIBUTE_UNUSED) +{ + /* nothing */ +} + + + +static const char* diskNames[] = { + "sda", "sdb", "sdc", "sdd", "sde", "sdf", "sdg", "sdh", "sdi", "sdj", "sdk", "sdl", "sdm", "sdn", "sdo", "sdp", "sdq", "sdr", "sds", "sdt", "sdu", "sdv", "sdw", "sdx", "sdy", "sdz", + "sdaa", "sdab", "sdac", "sdad", "sdae", "sdaf", "sdag", "sdah", "sdai", "sdaj", "sdak", "sdal", "sdam", "sdan", "sdao", "sdap", "sdaq", "sdar", "sdas", "sdat", "sdau", "sdav", "sdaw", "sdax", "sday", "sdaz", + "sdba", "sdbb", "sdbc", "sdbd", "sdbe", "sdbf", "sdbg", "sdbh", "sdbi", "sdbj", "sdbk", "sdbl", "sdbm", "sdbn", "sdbo", "sdbp", "sdbq", "sdbr", "sdbs", "sdbt", "sdbu", "sdbv", "sdbw", "sdbx", "sdby", "sdbz", + "sdca", "sdcb", "sdcc", "sdcd", "sdce", "sdcf", "sdcg", "sdch", "sdci", "sdcj", "sdck", "sdcl", "sdcm", "sdcn", "sdco", "sdcp", "sdcq", "sdcr", "sdcs", "sdct", "sdcu", "sdcv", "sdcw", "sdcx", "sdcy", "sdcz", + "sdda", "sddb", "sddc", "sddd", "sdde", "sddf", "sddg", "sddh", "sddi", "sddj", "sddk", "sddl", "sddm", "sddn", "sddo", "sddp", "sddq", "sddr", "sdds", "sddt", "sddu", "sddv", "sddw", "sddx", "sddy", "sddz", + "sdea", "sdeb", "sdec", "sded", "sdee", "sdef", "sdeg", "sdeh", "sdei", "sdej", "sdek", "sdel", "sdem", "sden", "sdeo", "sdep", "sdeq", "sder", "sdes", "sdet", "sdeu", "sdev", "sdew", "sdex", "sdey", "sdez", + "sdfa", "sdfb", "sdfc", "sdfd", "sdfe", "sdff", "sdfg", "sdfh", "sdfi", "sdfj", "sdfk", "sdfl", "sdfm", "sdfn", "sdfo", "sdfp", "sdfq", "sdfr", "sdfs", "sdft", "sdfu", "sdfv", "sdfw", "sdfx", "sdfy", "sdfz", + "sdga", "sdgb", "sdgc", "sdgd", "sdge", "sdgf", "sdgg", "sdgh", "sdgi", "sdgj", "sdgk", "sdgl", "sdgm", "sdgn", "sdgo", "sdgp", "sdgq", "sdgr", "sdgs", "sdgt", "sdgu", "sdgv", "sdgw", "sdgx", "sdgy", "sdgz", + "sdha", "sdhb", "sdhc", "sdhd", "sdhe", "sdhf", "sdhg", "sdhh", "sdhi", "sdhj", "sdhk", "sdhl", "sdhm", "sdhn", "sdho", "sdhp", "sdhq", "sdhr", "sdhs", "sdht", "sdhu", "sdhv", "sdhw", "sdhx", "sdhy", "sdhz", + "sdia", "sdib", "sdic", "sdid", "sdie", "sdif", "sdig", "sdih", "sdii", "sdij", "sdik", "sdil", "sdim", "sdin", "sdio", "sdip", "sdiq", "sdir", "sdis", "sdit", "sdiu", "sdiv", "sdiw", "sdix", "sdiy", "sdiz" +}; + +static int +testIndexToDiskName(const void *data ATTRIBUTE_UNUSED) +{ + int i; + char *diskName = NULL; + + for (i = 0; i < ARRAY_CARDINALITY(diskNames); ++i) { + VIR_FREE(diskName); + + diskName = virIndexToDiskName(i, "sd"); + + if (STRNEQ(diskNames[i], diskName)) { + virtTestDifference(stderr, diskNames[i], diskName); + VIR_FREE(diskName); + + return -1; + } + } + + VIR_FREE(diskName); + + return 0; +} + + + +static int +testDiskNameToIndex(const void *data ATTRIBUTE_UNUSED) +{ + int i, k; + char *diskName = NULL; + + for (i = 0; i < 100000; ++i) { + VIR_FREE(diskName); + + diskName = virIndexToDiskName(i, "sd"); + k = virDiskNameToIndex(diskName); + + if (k != i) { + if (virTestGetDebug() > 0) { + fprintf(stderr, "\nExpect [%d]\n", i); + fprintf(stderr, "Actual [%d]\n", k); + } + + VIR_FREE(diskName); + + return -1; + } + } + + VIR_FREE(diskName); + + return 0; +} + + + +struct testVersionString +{ + const char *string; + bool allowMissing; + int result; + unsigned long version; +}; + +static struct testVersionString versions[] = { + { "2.6.38-8-generic", false, 0, 1000000 * 2 + 1000 * 6 + 38 }, + { "3.0-1-virtual", true, 0, 1000000 * 3 + 1000 * 0 + 0 }, + { "5", true, 0, 1000000 * 5 + 1000 * 0 + 0 }, + { "4.1.0", false, 0, 1000000 * 4 + 1000 * 1 + 0 }, + { "12.345.678", false, 0, 1000000 * 12 + 1000 * 345 + 678 }, + { "1.234.5678", false, -1, 0 }, + { "1.2345.678", false, -1, 0 }, + { "12345.6.78", false, -1, 0 }, + { "123456789", true, -1, 0 }, + { "3.0-2-virtual", false, -1, 0 }, + { "no-number-here", false, -1, 0 }, +}; + +static int +testParseVersionString(const void *data ATTRIBUTE_UNUSED) +{ + int i, result; + unsigned long version; + + for (i = 0; i < ARRAY_CARDINALITY(versions); ++i) { + result = virParseVersionString(versions[i].string, &version, + versions[i].allowMissing); + + if (result != versions[i].result) { + if (virTestGetDebug() > 0) { + fprintf(stderr, "\nVersion string [%s]\n", versions[i].string); + fprintf(stderr, "Expect result [%d]\n", versions[i].result); + fprintf(stderr, "Actual result [%d]\n", result); + } + + return -1; + } + + if (result < 0) { + continue; + } + + if (version != versions[i].version) { + if (virTestGetDebug() > 0) { + fprintf(stderr, "\nVersion string [%s]\n", versions[i].string); + fprintf(stderr, "Expect version [%lu]\n", versions[i].version); + fprintf(stderr, "Actual version [%lu]\n", version); + } + + return -1; + } + } + + return 0; +} + + + + +static int +mymain(void) +{ + int result = 0; + + virSetErrorFunc(NULL, testQuietError); + + #define DO_TEST(_name) \ + do { \ + if (virtTestRun("Util "#_name, 1, test##_name, \ + NULL) < 0) { \ + result = -1; \ + } \ + } while (0) + + DO_TEST(IndexToDiskName); + DO_TEST(DiskNameToIndex); + DO_TEST(ParseVersionString); + + return result == 0 ? EXIT_SUCCESS : EXIT_FAILURE; +} + +VIRT_TEST_MAIN(mymain) -- 1.7.4.1

2 2

[libvirt] [PATCH] fix virParseVersionString with linux 3.0
by Scott Moser 01 Jul '11

01 Jul '11

linux 3.0 has no micro version number, and that is causing problems for virParseVersionString. The patch below should allow for: major major.minor major.minor.micro If major or minor are not present they just default to zero. We found this in Ubuntu (https://bugs.launchpad.net/bugs/802977) diff --git a/src/util/util.c b/src/util/util.c index 463d2b8..01848a1 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -1598,17 +1598,17 @@ virParseNumber(const char **str) int virParseVersionString(const char *str, unsigned long *version) { - unsigned int major, minor, micro; + unsigned int major, minor=0, micro=0; char *tmp; - if (virStrToLong_ui(str, &tmp, 10, &major) < 0 || *tmp != '.') + if (virStrToLong_ui(str, &tmp, 10, &major) < 0) return -1; - if (virStrToLong_ui(tmp + 1, &tmp, 10, &minor) < 0 || *tmp != '.') - return -1; + if ((*tmp == '.') && virStrToLong_ui(tmp + 1, &tmp, 10, &minor) < 0) + return -1; - if (virStrToLong_ui(tmp + 1, &tmp, 10, &micro) < 0) - return -1; + if ((*tmp == '.') && virStrToLong_ui(tmp + 1, &tmp, 10, &micro) < 0) + return -1; *version = 1000000 * major + 1000 * minor + micro;

3 9

[libvirt] [PATCHv2] build: consistently use CFLAGS
by Eric Blake 01 Jul '11

01 Jul '11

According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled in automake 1.9.6) should only include -I, -D, and -U directives; more generic directives like -Wall belong in CFLAGS since they affect more phases of the build process. Therefore, we should be sticking CFLAGS additions into a CFLAGS container, not a CPPFLAGS container. * src/Makefile.am (INCLUDES): Move CFLAGS items... (AM_CFLAGS): ...to their proper location. * python/Makefile.am (INCLUDES, AM_CFLAGS): Likewise. * tests/Makefile.am (INCLUDES, AM_CFLAGS): Likewise. --- v1 had no review: https://www.redhat.com/archives/libvir-list/2011-May/msg01934.html changes from v1: rebase to latest I tested it on top of these two patches, hopefully they'll be ack'd first: https://www.redhat.com/archives/libvir-list/2011-June/msg01537.html https://www.redhat.com/archives/libvir-list/2011-June/msg01486.html python/Makefile.am | 5 +++-- src/Makefile.am | 15 +++++++-------- tests/Makefile.am | 8 +++++--- 3 files changed, 15 insertions(+), 13 deletions(-) diff --git a/python/Makefile.am b/python/Makefile.am index 432ad70..0edb3e4 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -3,12 +3,13 @@ SUBDIRS= . tests INCLUDES = \ - $(WARN_CFLAGS) \ - $(PYTHON_INCLUDES) \ + $(PYTHON_INCLUDES) \ -I$(top_srcdir)/include \ -I$(top_builddir)/include \ -I$(top_builddir)/$(subdir) +AM_CFLAGS = $(WARN_CFLAGS) + DOCS_DIR = $(datadir)/doc/libvirt-python-$(LIBVIRT_VERSION) DOCS = ${srcdir}/TODO diff --git a/src/Makefile.am b/src/Makefile.am index 4ba3ea7..10ee20a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -3,20 +3,19 @@ # No libraries with the exception of LIBXML should be listed # here. List them against the individual XXX_la_CFLAGS targets # that actually use them -INCLUDES = \ - -I$(top_srcdir)/gnulib/lib \ +INCLUDES = -I$(top_srcdir)/gnulib/lib \ -I../gnulib/lib \ -I../include \ -I@top_srcdir@/src/util \ -I@top_srcdir@/include \ - $(DRIVER_MODULE_CFLAGS) \ + -DIN_LIBVIRT + +AM_CFLAGS = $(DRIVER_MODULE_CFLAGS) \ $(LIBXML_CFLAGS) \ $(WARN_CFLAGS) \ - $(LOCK_CHECKING_CFLAGS) \ - -DIN_LIBVIRT \ - $(WIN32_EXTRA_CFLAGS) - -AM_CFLAGS = $(COVERAGE_CFLAGS) + $(LOCK_CHECKING_CFLAGS) \ + $(WIN32_EXTRA_CFLAGS) \ + $(COVERAGE_CFLAGS) AM_LDFLAGS = $(COVERAGE_LDFLAGS) EXTRA_DIST = $(conf_DATA) diff --git a/tests/Makefile.am b/tests/Makefile.am index 38a353f..984d8fd 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -8,15 +8,17 @@ INCLUDES = \ -I$(top_srcdir)/include \ -I$(top_srcdir)/src \ -I$(top_srcdir)/src/util \ - -I$(top_srcdir)/src/conf \ + -I$(top_srcdir)/src/conf + +AM_CFLAGS = \ $(LIBXML_CFLAGS) \ $(GNUTLS_CFLAGS) \ $(SASL_CFLAGS) \ $(SELINUX_CFLAGS) \ $(APPARMOR_CFLAGS) \ $(YAJL_CFLAGS) \ - $(COVERAGE_CFLAGS) \ - $(WARN_CFLAGS) + $(COVERAGE_CFLAGS) \ + $(WARN_CFLAGS) if WITH_DRIVER_MODULES INCLUDES += \ -- 1.7.4.4

2 5

[libvirt] [PATCH] build: remove dead variables
by Eric Blake 01 Jul '11

01 Jul '11

Detected by Coverity. No real harm in leaving these, but fixing them cuts down on the noise for future analysis. * src/rpc/virnetserver.c (virNetServerAddService): Delete unused entry. * src/util/sysinfo.c (virSysinfoRead): Delete dead assignment to base. --- src/rpc/virnetserver.c | 7 +++---- src/util/sysinfo.c | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 0ef81fd..5e1719b 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -529,11 +529,10 @@ int virNetServerAddService(virNetServerPtr srv, #if HAVE_AVAHI if (mdnsEntryName) { int port = virNetServerServiceGetPort(svc); - virNetServerMDNSEntryPtr entry; - if (!(entry = virNetServerMDNSAddEntry(srv->mdnsGroup, - mdnsEntryName, - port))) + if (!virNetServerMDNSAddEntry(srv->mdnsGroup, + mdnsEntryName, + port)) goto error; } #endif diff --git a/src/util/sysinfo.c b/src/util/sysinfo.c index f4edde9..eec996b 100644 --- a/src/util/sysinfo.c +++ b/src/util/sysinfo.c @@ -472,7 +472,7 @@ virSysinfoRead(void) { ret->nmemory = 0; ret->memory = NULL; - if ((base = virSysinfoParseMemory(base, ret)) == NULL) + if (virSysinfoParseMemory(base, ret) == NULL) goto no_memory; cleanup: -- 1.7.4.4

2 2

[libvirt] [Libvirt-test-API][PATCH 1/6] add createWithFlags() API and modify migrate() function to align with libvirt Python migration definition
by Guannan.ren 01 Jul '11

01 Jul '11

--- lib/domainAPI.py | 57 ++++++++++++++++++++++++++++++++++++------------------ 1 files changed, 38 insertions(+), 19 deletions(-) diff --git a/lib/domainAPI.py b/lib/domainAPI.py index 0c725f8..5667c20 100644 --- a/lib/domainAPI.py +++ b/lib/domainAPI.py @@ -40,18 +40,6 @@ append_path(result.group(0)) import exception -# DomainMigrateFlags -VIR_MIGRATE_LIVE = 1 - -# DomainState -VIR_DOMAIN_NOSTATE = 0 -VIR_DOMAIN_RUNNING = 1 -VIR_DOMAIN_BLOCKED = 2 -VIR_DOMAIN_PAUSED = 3 -VIR_DOMAIN_SHUTDOWN = 4 -VIR_DOMAIN_SHUTOFF = 5 -VIR_DOMAIN_CRASHED = 6 - class DomainAPI(object): def __init__(self, connection): self.conn = connection @@ -182,6 +170,16 @@ class DomainAPI(object): code = e.get_error_code() raise exception.LibvirtAPI(message, code) + def start_with_flags(self, domname, flags = 0): + try: + dom_obj = self.get_defined_obj(domname) + retval = dom_obj.createWithFlags(flags) + return retval + except libvirt.libvirtError, e: + message = e.get_error_message() + code = e.get_error_code() + raise exception.LibvirtAPI(message, code) + def suspend(self, domname): try: dom_obj = self.get_domain_by_name(domname) @@ -223,10 +221,10 @@ class DomainAPI(object): code = e.get_error_code() raise exception.LibvirtAPI(message, code) - def migrate(self, domname, dconn, flags = VIR_MIGRATE_LIVE): + def migrate(self, domname, dconn, flags, dname = None, uri = None, bandwidth = 0): try: dom_obj = self.get_domain_by_name(domname) - retval = dom_obj.migrate(dconn, flags, None, None, 0) + retval = dom_obj.migrate(dconn, flags, dname, uri, 0) return retval except libvirt.libvirtError, e: message = e.get_error_message() @@ -484,7 +482,7 @@ class DomainAPI(object): dom_obj = self.get_domain_by_name(domname) state = dom_obj.info() if state[0] == VIR_DOMAIN_NOSTATE: - dom_state = 'no state' + dom_state = 'nostate' elif state[0] == VIR_DOMAIN_RUNNING: dom_state = 'running' elif state[0] == VIR_DOMAIN_BLOCKED: @@ -581,7 +579,7 @@ class DomainAPI(object): code = e.get_error_code() raise exception.LibvirtAPI(message, code) - def isActive(self, domname): + def is_active(self, domname): try: dom_obj = self.get_domain_by_name(domname) return dom_obj.isActive() @@ -590,7 +588,7 @@ class DomainAPI(object): code = e.get_error_code() raise exception.LibvirtAPI(message, code) - def isPersistent(self, domname): + def is_persistent(self, domname): try: dom_obj = self.get_domain_by_name(domname) return dom_obj.isPersistent() @@ -662,10 +660,10 @@ class DomainAPI(object): code = e.get_error_code() raise exception.LibvirtAPI(message, code) - def migrate_to_uri(self, domname, duri, dname, bandwidth, flag = 0): + def migrate_to_uri(self, domname, duri, flags, dname = None, bandwidth = 0): try: dom_obj = self.get_domain_by_name(domname) - return dom_obj.migrateToURI(duri, dname, bandwidth, flag) + return dom_obj.migrateToURI(duri, flags, dname, bandwidth) except libvirt.libvirtError, e: message = e.get_error_message() code = e.get_error_code() @@ -761,3 +759,24 @@ class DomainAPI(object): code = e.get_error_code() raise exception.LibvirtAPI(message, code) + +# DomainState +VIR_DOMAIN_NOSTATE = 0 +VIR_DOMAIN_RUNNING = 1 +VIR_DOMAIN_BLOCKED = 2 +VIR_DOMAIN_PAUSED = 3 +VIR_DOMAIN_SHUTDOWN = 4 +VIR_DOMAIN_SHUTOFF = 5 +VIR_DOMAIN_CRASHED = 6 + + +# virDomainMigrateFlags +VIR_MIGRATE_LIVE = 1 +VIR_MIGRATE_PEER2PEER = 2 +VIR_MIGRATE_TUNNELLED = 4 +VIR_MIGRATE_PERSIST_DEST = 8 +VIR_MIGRATE_UNDEFINE_SOURCE = 16 +VIR_MIGRATE_PAUSED = 32 +VIR_MIGRATE_NON_SHARED_DISK = 64 +VIR_MIGRATE_NON_SHARED_INC = 128 + -- 1.7.1

4 12

[libvirt] PPPoE-Server problem
by B Veera-B37207 01 Jul '11

01 Jul '11

HI, I am using Libvirt with LXC as hypervisor. When I am starting pppoe-server , unable to create ppp0 interface in Virtual machine, it is unable to serve ips to clients. Let me know is there any plug-in for this (Or) What is the solution. Regards, Veera.

1 0

[libvirt] [PATCH] Add test case for parsing JSON docs
by Daniel P. Berrange 01 Jul '11

01 Jul '11

While investigating some memory leaks it was unclear whether the JSON code correctly free'd all memory during parsing. Add a test case which can be run under valgrind to clearly demonstrate that the parser is leak free. * tests/Makefile.am: Add 'jsontest' * tests/jsontest.c: A few simple JSON parsing tests --- tests/Makefile.am | 14 +++++++ tests/jsontest.c | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 125 insertions(+), 0 deletions(-) create mode 100644 tests/jsontest.c diff --git a/tests/Makefile.am b/tests/Makefile.am index 7db9d1f..3bde22e 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -14,6 +14,7 @@ INCLUDES = \ $(SASL_CFLAGS) \ $(SELINUX_CFLAGS) \ $(APPARMOR_CFLAGS) \ + $(YAJL_CFLAGS) \ $(COVERAGE_CFLAGS) \ $(WARN_CFLAGS) @@ -29,6 +30,7 @@ LDADDS = \ $(SASL_LIBS) \ $(SELINUX_LIBS) \ $(APPARMOR_LIBS) \ + $(YAJL_LIBS) \ $(WARN_CFLAGS) \ ../src/libvirt_test.la \ ../gnulib/lib/libgnu.la \ @@ -112,6 +114,10 @@ if WITH_CIL check_PROGRAMS += object-locking endif +if HAVE_YAJL +check_PROGRAMS += jsontest +endif + check_PROGRAMS += networkxml2xmltest check_PROGRAMS += networkxml2argvtest @@ -195,6 +201,10 @@ TESTS = virshtest \ virnetsockettest \ $(test_scripts) +if HAVE_YAJL +TESTS += jsontest +endif + if WITH_XEN TESTS += xml2sexprtest \ sexpr2xmltest \ @@ -443,6 +453,10 @@ hashtest_SOURCES = \ hashtest.c hashdata.h testutils.h testutils.c hashtest_LDADD = $(LDADDS) +jsontest_SOURCES = \ + jsontest.c jsondata.h testutils.h testutils.c +jsontest_LDADD = $(LDADDS) + if WITH_LIBVIRTD eventtest_SOURCES = \ eventtest.c testutils.h testutils.c diff --git a/tests/jsontest.c b/tests/jsontest.c new file mode 100644 index 0000000..412f475 --- /dev/null +++ b/tests/jsontest.c @@ -0,0 +1,111 @@ +#include <config.h> + +#include <stdio.h> +#include <stdlib.h> +#include <string.h> +#include <time.h> + +#include "internal.h" +#include "json.h" +#include "testutils.h" + +struct testInfo { + const char *doc; + bool pass; +}; + + +static int +testJSONFromString(const void *data) +{ + const struct testInfo *info = data; + virJSONValuePtr json; + int ret = -1; + + json = virJSONValueFromString(info->doc); + + if (info->pass) { + if (!json) { + if (virTestGetVerbose()) + fprintf(stderr, "Fail to parse %s\n", info->doc); + ret = -1; + goto cleanup; + } else { + if (virTestGetDebug()) + fprintf(stderr, "Parsed %s\n", info->doc); + } + } else { + if (json) { + if (virTestGetVerbose()) + fprintf(stderr, "Should not have parsed %s\n", info->doc); + ret = -1; + goto cleanup; + } else { + if (virTestGetDebug()) + fprintf(stderr, "Fail to parse %s\n", info->doc); + } + } + + ret = 0; + +cleanup: + virJSONValueFree(json); + return ret; +} + + +static int +mymain(void) +{ + int ret = 0; + +#define DO_TEST_FULL(name, cmd, doc, pass) \ + do { \ + struct testInfo info = { doc, pass }; \ + if (virtTestRun(name, 1, testJSON ## cmd, &info) < 0) \ + ret = -1; \ + } while (0) + +#define DO_TEST_PARSE(name, doc) \ + DO_TEST_FULL(name, FromString, doc, true) + + DO_TEST_PARSE("Simple", "{\"return\": {}, \"id\": \"libvirt-1\"}"); + DO_TEST_PARSE("NotSoSimple", "{\"QMP\": {\"version\": {\"qemu\":" + "{\"micro\": 91, \"minor\": 13, \"major\": 0}," + "\"package\": \" (qemu-kvm-devel)\"}, \"capabilities\": []}}"); + + + DO_TEST_PARSE("Harder", "{\"return\": [{\"filename\": " + "\"unix:/home/berrange/.libvirt/qemu/lib/tck.monitor,server\"," + "\"label\": \"charmonitor\"}, {\"filename\": \"pty:/dev/pts/158\"," + "\"label\": \"charserial0\"}], \"id\": \"libvirt-3\"}"); + + DO_TEST_PARSE("VeryHard", "{\"return\": [{\"name\": \"quit\"}, {\"name\":" + "\"eject\"}, {\"name\": \"change\"}, {\"name\": \"screendump\"}," + "{\"name\": \"stop\"}, {\"name\": \"cont\"}, {\"name\": " + "\"system_reset\"}, {\"name\": \"system_powerdown\"}, " + "{\"name\": \"device_add\"}, {\"name\": \"device_del\"}, " + "{\"name\": \"cpu\"}, {\"name\": \"memsave\"}, {\"name\": " + "\"pmemsave\"}, {\"name\": \"migrate\"}, {\"name\": " + "\"migrate_cancel\"}, {\"name\": \"migrate_set_speed\"}," + "{\"name\": \"client_migrate_info\"}, {\"name\": " + "\"migrate_set_downtime\"}, {\"name\": \"netdev_add\"}, " + "{\"name\": \"netdev_del\"}, {\"name\": \"block_resize\"}," + "{\"name\": \"balloon\"}, {\"name\": \"set_link\"}, {\"name\":" + "\"getfd\"}, {\"name\": \"closefd\"}, {\"name\": \"block_passwd\"}," + "{\"name\": \"set_password\"}, {\"name\": \"expire_password\"}," + "{\"name\": \"qmp_capabilities\"}, {\"name\": " + "\"human-monitor-command\"}, {\"name\": \"query-version\"}," + "{\"name\": \"query-commands\"}, {\"name\": \"query-chardev\"}," + "{\"name\": \"query-block\"}, {\"name\": \"query-blockstats\"}, " + "{\"name\": \"query-cpus\"}, {\"name\": \"query-pci\"}, {\"name\":" + "\"query-kvm\"}, {\"name\": \"query-status\"}, {\"name\": " + "\"query-mice\"}, {\"name\": \"query-vnc\"}, {\"name\": " + "\"query-spice\"}, {\"name\": \"query-name\"}, {\"name\": " + "\"query-uuid\"}, {\"name\": \"query-migrate\"}, {\"name\": " + "\"query-balloon\"}], \"id\": \"libvirt-2\"}"); + + return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; +} + +VIRT_TEST_MAIN(mymain) -- 1.7.4.4

3 2

[libvirt] network filters not working at all in 0.9.2
by xxyton 01 Jul '11

01 Jul '11

Hi there, is just upgraded to libvirt 0.9.2 and restarted my domains but now all network filters are gone. Why does libvirt not set iptables configuration while filterref clause exists? Is this a known bug? How can I fix it. Restarting / redefining doesn't output any errors. Example config XML of domain: ... <filterref filter='clean-traffic'> <parameter name='IP' value='192.168.2.34'/> </filterref> ... # virsh -v 0.9.2 # iptables -L Chain INPUT (policy ACCEPT) target prot opt source destination ACCEPT udp -- anywhere anywhere udp dpt:domain ACCEPT tcp -- anywhere anywhere tcp dpt:domain ACCEPT udp -- anywhere anywhere udp dpt:bootps ACCEPT tcp -- anywhere anywhere tcp dpt:bootps Chain FORWARD (policy ACCEPT) target prot opt source destination ACCEPT all -- anywhere 192.168.122.0/24 state RELATED,ESTABLISHED ACCEPT all -- 192.168.122.0/24 anywhere ACCEPT all -- anywhere anywhere REJECT all -- anywhere anywhere reject-with icmp-port-unreachable REJECT all -- anywhere anywhere reject-with icmp-port-unreachable Chain OUTPUT (policy ACCEPT) target prot opt source destination

2 1

[libvirt] [PATCH] build: simplify sanlock distribution
by Eric Blake 30 Jun '11

30 Jun '11

EXTRA_DIST is intended for files that must unconditionally be part of the tarball, so it should be outside HAVE_SANLOCK. Once that is fixed, then there is no need to cp an unchanged qemu-sanlock.conf from srcdir to builddir in a VPATH build, not to mention that $(builddir) is not supported in the automake in use in RHEL 5. * src/Makefile.am ($(builddir)/locking/%-sanlock.conf): Delete. (BUILT_SOURCES): No need to build qemu-sanlock.conf. (EXTRA_DIST): Always ship sanlock .aug and .conf files. --- As promised in: https://www.redhat.com/archives/libvir-list/2011-June/msg01448.html I'm starting a 'make distcheck' overnight to fully test this, but think that it will pass without issues. src/Makefile.am | 15 +++++---------- 1 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 8f99cc2..bfbaa06 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1186,6 +1186,10 @@ libvirt_qemu_la_LIBADD = libvirt.la $(CYGWIN_EXTRA_LIBADD) EXTRA_DIST += $(LIBVIRT_QEMU_SYMBOL_FILE) +EXTRA_DIST += locking/sanlock.conf \ + locking/libvirt_sanlock.aug \ + locking/test_libvirt_sanlock.aug + if HAVE_SANLOCK lockdriverdir = $(libdir)/libvirt/lock-driver lockdriver_LTLIBRARIES = sanlock.la @@ -1199,20 +1203,11 @@ sanlock_la_LIBADD = -lsanlock \ augeas_DATA += locking/libvirt_sanlock.aug augeastest_DATA += locking/test_libvirt_sanlock.aug -EXTRA_DIST += locking/sanlock.conf \ - locking/libvirt_sanlock.aug \ - locking/test_libvirt_sanlock.aug - -$(builddir)/locking/%-sanlock.conf: $(srcdir)/locking/sanlock.conf - $(AM_V_GEN)mkdir locking ; \ - cp $< $@ - if WITH_QEMU conf_DATA += locking/qemu-sanlock.conf -BUILT_SOURCES += locking/qemu-sanlock.conf endif else -EXTRA_DIST += $(LOCK_DRIVER_SANLOCK_SOURCES) locking/sanlock.conf +EXTRA_DIST += $(LOCK_DRIVER_SANLOCK_SOURCES) endif noinst_LTLIBRARIES += libvirt-net-rpc.la libvirt-net-rpc-server.la libvirt-net-rpc-client.la -- 1.7.4.4

4 6

[libvirt] [PATCH] build: allow 'make syntax-check' on fresh checkout
by Eric Blake 30 Jun '11

30 Jun '11

For good or for bad, I did a fresh checkout, ./autogen.sh, then 'configure', then 'make syntax-check', and was surprised that it failed. Running 'make' before 'make syntax-check' cleaned up the issue, but this patch makes it work up front. * cfg.mk (sc_po_check): Add prerequisite. --- I debated about pushing this one, but couldn't quite bring myself to call it a build-breaker. However, if it gets an ACK, I see no negative effects to pushing before 0.9.3. cfg.mk | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/cfg.mk b/cfg.mk index 69f35a3..fa9ea1c 100644 --- a/cfg.mk +++ b/cfg.mk @@ -605,6 +605,11 @@ _autogen: # regenerate HACKING as part of the syntax-check syntax-check: $(top_srcdir)/HACKING +# sc_po_check can fail if generated files are not built first +sc_po_check: daemon/remote_dispatch.h +daemon/remote_dispatch.h: + $(MAKE) -C daemon remote_dispatch.h + # List all syntax-check exemptions: exclude_file_name_regexp--sc_avoid_strcase = ^tools/virsh\.c$$ -- 1.7.4.4

2 4

[libvirt] [PATCH] build: ignore generated file
by Eric Blake 30 Jun '11

30 Jun '11

* .gitignore: Exempt jsontest binary. --- Pushing under the trivial rule. .gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index be4193d..1bfb7b9 100644 --- a/.gitignore +++ b/.gitignore @@ -57,6 +57,7 @@ /tests/*.log /tests/cputest /tests/hashtest +/tests/jsontest /tests/networkxml2argvtest /tests/nwfilterxml2xmltest /tests/openvzutilstest -- 1.7.4.4

1 0

[libvirt] [PATCH 0/4] several Coverity fixes
by Eric Blake 30 Jun '11

30 Jun '11

I ran Coverity on the state of yesterday's git; while I have not finished reading through all the findings, I figured I'd get some review started on these. Eric Blake (4): virsh: avoid integer overflow virsh: avoid uninitialized variable rpc: avoid freeing uninitialized variable build: avoid double-close bug with pipe2 .gnulib | 2 +- src/rpc/virnetclient.c | 2 +- src/rpc/virnetsocket.c | 4 ++-- tools/virsh.c | 7 +++++-- 4 files changed, 9 insertions(+), 6 deletions(-) -- 1.7.4.4

2 9

[libvirt] [PATCH] Add conditionals to allow build without SASL
by Daniel P. Berrange 30 Jun '11

30 Jun '11

* daemon/libvirtd.c, daemon/remote.c: Add #if HAVE_SASL and suitable function stubs to allow build without SASL --- daemon/libvirtd.c | 6 ++++++ daemon/remote.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+), 0 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 118aa92..60ee705 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -91,7 +91,9 @@ #include "configmake.h" +#if HAVE_SASL virNetSASLContextPtr saslCtxt = NULL; +#endif virNetServerProgramPtr remoteProgram = NULL; virNetServerProgramPtr qemuProgram = NULL; @@ -560,6 +562,7 @@ static int daemonSetupNetworking(virNetServerPtr srv, } } +#if HAVE_SASL if (config->auth_unix_rw == REMOTE_AUTH_SASL || config->auth_unix_ro == REMOTE_AUTH_SASL || config->auth_tcp == REMOTE_AUTH_SASL || @@ -569,6 +572,7 @@ static int daemonSetupNetworking(virNetServerPtr srv, if (!saslCtxt) goto error; } +#endif #if HAVE_POLKIT0 if (auth_unix_rw == REMOTE_AUTH_POLKIT || @@ -745,8 +749,10 @@ static int remoteConfigGetAuth(virConfPtr conf, const char *key, int *auth, cons if (STREQ(p->str, "none")) { *auth = VIR_NET_SERVER_SERVICE_AUTH_NONE; +#if HAVE_SASL } else if (STREQ(p->str, "sasl")) { *auth = VIR_NET_SERVER_SERVICE_AUTH_SASL; +#endif } else if (STREQ(p->str, "polkit")) { *auth = VIR_NET_SERVER_SERVICE_AUTH_POLKIT; } else { diff --git a/daemon/remote.c b/daemon/remote.c index 9e6cf77..2889908 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -1653,6 +1653,7 @@ cleanup: } +#ifdef HAVE_SASL /* * Initializes the SASL session in prepare for authentication * and gives the client a list of allowed mechanisms to choose @@ -1969,6 +1970,49 @@ error: virMutexUnlock(&priv->lock); return -1; } +#else +static int +remoteDispatchAuthSaslInit(virNetServerPtr server ATTRIBUTE_UNUSED, + virNetServerClientPtr client ATTRIBUTE_UNUSED, + virNetMessageHeaderPtr hdr ATTRIBUTE_UNUSED, + virNetMessageErrorPtr rerr, + remote_auth_sasl_init_ret *ret ATTRIBUTE_UNUSED) +{ + VIR_WARN("Client tried unsupported SASL auth"); + virNetError(VIR_ERR_AUTH_FAILED, "%s", + _("authentication failed")); + virNetMessageSaveError(rerr); + return -1; +} +static int +remoteDispatchAuthSaslStart(virNetServerPtr server ATTRIBUTE_UNUSED, + virNetServerClientPtr client ATTRIBUTE_UNUSED, + virNetMessageHeaderPtr hdr ATTRIBUTE_UNUSED, + virNetMessageErrorPtr rerr, + remote_auth_sasl_start_args *args ATTRIBUTE_UNUSED, + remote_auth_sasl_start_ret *ret ATTRIBUTE_UNUSED) +{ + VIR_WARN("Client tried unsupported SASL auth"); + virNetError(VIR_ERR_AUTH_FAILED, "%s", + _("authentication failed")); + virNetMessageSaveError(rerr); + return -1; +} +static int +remoteDispatchAuthSaslStep(virNetServerPtr server ATTRIBUTE_UNUSED, + virNetServerClientPtr client ATTRIBUTE_UNUSED, + virNetMessageHeaderPtr hdr ATTRIBUTE_UNUSED, + virNetMessageErrorPtr rerr, + remote_auth_sasl_step_args *args ATTRIBUTE_UNUSED, + remote_auth_sasl_step_ret *ret ATTRIBUTE_UNUSED) +{ + VIR_WARN("Client tried unsupported SASL auth"); + virNetError(VIR_ERR_AUTH_FAILED, "%s", + _("authentication failed")); + virNetMessageSaveError(rerr); + return -1; +} +#endif -- 1.7.4.4

4 3

[libvirt] SIGTERM undeclared, virNetSocketFree
by Jason Helfman 30 Jun '11

30 Jun '11

Hi, I get this error when compiling 0.9.3-rc2 on FreeBSD. Is there a fix for this? rpc/virnetsocket.c: In function 'virNetSocketFree': rpc/virnetsocket.c:654: warning: implicit declaration of function 'kill' rpc/virnetsocket.c:654: warning: nested extern declaration of 'kill' [-Wnested-externs] rpc/virnetsocket.c:654: error: 'SIGTERM' undeclared (first use in this function) rpc/virnetsocket.c:654: error: (Each undeclared identifier is reported only once rpc/virnetsocket.c:654: error: for each function it appears in.) gmake[3]: *** [libvirt_net_rpc_la-virnetsocket.lo] Error 1 gmake[3]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.3/src' gmake[2]: *** [all] Error 2 gmake[2]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.3/src' gmake[1]: *** [all-recursive] Error 1 gmake[1]: Leaving directory `/home/jhelfman/ports/devel/libvirt/work/libvirt-0.9.3' gmake: *** [all] Error 2 *** Error code 1 Thanks, Jason -- Jason Helfman System Administrator experts-exchange.com http://www.experts-exchange.com/M_4830110.html E4AD 7CF1 1396 27F6 79DD 4342 5E92 AD66 8C8C FBA5

4 4

[libvirt] [PATCH] Fix stream procedure number for virDomainMigratePrepareTunnel3
by Daniel P. Berrange 30 Jun '11

30 Jun '11

The virDomainMigratePrepareTunnel3 impl in the remote driver was using the procedure number for the virDomainMigratePrepareTunnel method. This doesn't work out so well, because it makes the server ignore & drop all stream packets * src/remote/remote_driver.c: Fix procedure for PrepareTunnel3 --- src/remote/remote_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index ce9bcb1..f318740 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -3691,7 +3691,7 @@ remoteDomainMigratePrepareTunnel3(virConnectPtr dconn, memset(&ret, 0, sizeof(ret)); if (!(netst = virNetClientStreamNew(priv->remoteProgram, - REMOTE_PROC_DOMAIN_MIGRATE_PREPARE_TUNNEL, + REMOTE_PROC_DOMAIN_MIGRATE_PREPARE_TUNNEL3, priv->counter))) goto done; -- 1.7.4.4

2 2

[libvirt] [PATCH] Send back an error if we get unexpected stream control message
by Daniel P. Berrange 30 Jun '11

30 Jun '11

We ignore any stream data packets which come in for streams which are not registered, since these packets are async and do not have a reply. If we get a stream control packet though we must send back an actual error, otherwise a (broken) client may hang forever making it hard to diagnose the client bug. * src/rpc/virnetserverprogram.c: Send back error for unexpected stream control messages --- src/rpc/virnetserverprogram.c | 25 +++++++++++++++++-------- 1 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/rpc/virnetserverprogram.c b/src/rpc/virnetserverprogram.c index ca80ae0..63a6b6d 100644 --- a/src/rpc/virnetserverprogram.c +++ b/src/rpc/virnetserverprogram.c @@ -257,14 +257,23 @@ int virNetServerProgramDispatch(virNetServerProgramPtr prog, * stream packets after we closed down a stream. Just drop & ignore * these. */ - VIR_INFO("Ignoring unexpected stream data serial=%d proc=%d status=%d", - msg->header.serial, msg->header.proc, msg->header.status); - /* Send a dummy reply to free up 'msg' & unblock client rx */ - memset(msg, 0, sizeof(*msg)); - msg->header.type = VIR_NET_REPLY; - if (virNetServerClientSendMessage(client, msg) < 0) { - ret = -1; - goto cleanup; + if (msg->header.status == VIR_NET_CONTINUE) { + VIR_INFO("Ignoring unexpected stream data serial=%d proc=%d status=%d", + msg->header.serial, msg->header.proc, msg->header.status); + /* Send a dummy reply to free up 'msg' & unblock client rx */ + memset(msg, 0, sizeof(*msg)); + msg->header.type = VIR_NET_REPLY; + if (virNetServerClientSendMessage(client, msg) < 0) { + ret = -1; + goto cleanup; + } + } else { + VIR_INFO("Unexpected stream control message serial=%d proc=%d status=%d", + msg->header.serial, msg->header.proc, msg->header.status); + virNetError(VIR_ERR_RPC, + _("Unexpected stream control message serial=%d proc=%d status=%d"), + msg->header.serial, msg->header.proc, msg->header.status); + goto error; } ret = 0; break; -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix release of virNetMessagePtr instances in streams processing
by Daniel P. Berrange 30 Jun '11

30 Jun '11

If a message packet for a invalid stream is received it is just free'd. This is not good because it doesn't let the client RPC request counter decrement. If a stream is shutdown with pending packets the message also isn't released properly because of an incorrect header type * daemon/stream.c: Fix message header type * src/rpc/virnetserverprogram.c: Send dummy reply instead of free'ing ignored stream message --- daemon/stream.c | 1 + src/rpc/virnetserverprogram.c | 9 ++++++++- 2 files changed, 9 insertions(+), 1 deletions(-) diff --git a/daemon/stream.c b/daemon/stream.c index 685cee2..56d79c2 100644 --- a/daemon/stream.c +++ b/daemon/stream.c @@ -327,6 +327,7 @@ int daemonFreeClientStream(virNetServerClientPtr client, virNetMessagePtr tmp = msg->next; /* Send a dummy reply to free up 'msg' & unblock client rx */ memset(msg, 0, sizeof(*msg)); + msg->header.type = VIR_NET_REPLY; if (virNetServerClientSendMessage(client, msg) < 0) { virNetServerClientMarkClose(client); virNetMessageFree(msg); diff --git a/src/rpc/virnetserverprogram.c b/src/rpc/virnetserverprogram.c index 4afed64..ca80ae0 100644 --- a/src/rpc/virnetserverprogram.c +++ b/src/rpc/virnetserverprogram.c @@ -259,7 +259,13 @@ int virNetServerProgramDispatch(virNetServerProgramPtr prog, */ VIR_INFO("Ignoring unexpected stream data serial=%d proc=%d status=%d", msg->header.serial, msg->header.proc, msg->header.status); - virNetMessageFree(msg); + /* Send a dummy reply to free up 'msg' & unblock client rx */ + memset(msg, 0, sizeof(*msg)); + msg->header.type = VIR_NET_REPLY; + if (virNetServerClientSendMessage(client, msg) < 0) { + ret = -1; + goto cleanup; + } ret = 0; break; @@ -275,6 +281,7 @@ int virNetServerProgramDispatch(virNetServerProgramPtr prog, error: ret = virNetServerProgramSendReplyError(prog, client, msg, &rerr, &msg->header); +cleanup: return ret; } -- 1.7.4.4

2 1

[libvirt] libvirt-0.9.3 week freeze, RC1 version to test
by Daniel Veillard 30 Jun '11

30 Jun '11

So we are entering the week freeze for the new version 0.9.3 I have made an rc1 tarball available at: ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz along with rpms for those interested We pushed a lot of patches in the last few days, we know there is at least some cleanup issues, but I tried it locally and basic operations seems to work fine, please give it a try too and report issues, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

11 26

[libvirt] [PATCH 0/3] Fix stream upload in new RPC code
by Daniel P. Berrange 30 Jun '11

30 Jun '11

These patches do three small fixes to the RPC code in libvirtd to make sure stream upload works correctly again

2 7

[libvirt] [PATCH] Fix leak of virStreamPtr object with callback added in fdstream impl
by Daniel P. Berrange 30 Jun '11

30 Jun '11

When adding a callback to an FD stream, we take an extra reference on the virStreamPtr instance. We forgot to registered a free function with the callback, so when the callback was removed, the extra reference held on virStreamPtr was not released. * src/fdstream.c: Use a free callback to release reference on virStreamPtr when removing callback --- src/fdstream.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/fdstream.c b/src/fdstream.c index 182b6fa..54f8198 100644 --- a/src/fdstream.c +++ b/src/fdstream.c @@ -171,6 +171,13 @@ static void virFDStreamEvent(int watch ATTRIBUTE_UNUSED, } } +static void virFDStreamCallbackFree(void *opaque) +{ + virStreamPtr st = opaque; + virStreamFree(st); +} + + static int virFDStreamAddCallback(virStreamPtr st, int events, @@ -198,7 +205,7 @@ virFDStreamAddCallback(virStreamPtr st, events, virFDStreamEvent, st, - NULL)) < 0) { + virFDStreamCallbackFree)) < 0) { streamsReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot register file watch on stream")); goto cleanup; -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix leak of mdnsGroupName in virNetServer object
by Daniel P. Berrange 30 Jun '11

30 Jun '11

* src/rpc/virnetserver.c: Free mdnsGroupName --- src/rpc/virnetserver.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/rpc/virnetserver.c b/src/rpc/virnetserver.c index 8a2b113..0ef81fd 100644 --- a/src/rpc/virnetserver.c +++ b/src/rpc/virnetserver.c @@ -746,6 +746,8 @@ void virNetServerFree(virNetServerPtr srv) } VIR_FREE(srv->clients); + VIR_FREE(srv->mdnsGroupName); + virNetServerUnlock(srv); virMutexDestroy(&srv->lock); VIR_FREE(srv); -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix potential crash when saving guests
by Daniel P. Berrange 30 Jun '11

30 Jun '11

The qemudDomainSaveFlag method will call EndJob on the 'vm' object it is passed in. This can result in the 'vm' object being free'd if the last reference is removed. Thus no caller of 'qemudDomainSaveFlag' must *ever* reference 'vm' again upon return. Unfortunately qemudDomainSave and qemuDomainManagedSave both call 'virDomainObjUnlock', which can result in a crash. This is non-deterministic since it involves a race with the monitor I/O thread. Fix this by making qemudDomainSaveFlag responsible for calling virDomainObjUnlock instead. * src/qemu/qemu_driver.c: Fix potential use after free when saving guests --- src/qemu/qemu_driver.c | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d63f57d..363a361 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2091,7 +2091,10 @@ qemuCompressProgramName(int compress) } /* This internal function expects the driver lock to already be held on - * entry and the vm must be active. + * entry and the vm must be active + locked. Vm will be unlocked and + * potentially free'd after this returns (eg transient VMs are freed + * shutdown). So 'vm' must not be referenced by the caller after + * this returns (whether returning success or failure). */ static int qemudDomainSaveFlag(struct qemud_driver *driver, virDomainPtr dom, virDomainObjPtr vm, const char *path, @@ -2318,6 +2321,8 @@ cleanup: unlink(path); if (event) qemuDomainEventQueue(driver, event); + if (vm) + virDomainObjUnlock(vm); return ret; } @@ -2380,6 +2385,7 @@ static int qemudDomainSave(virDomainPtr dom, const char *path) } ret = qemudDomainSaveFlag(driver, dom, vm, path, compressed); + vm = NULL; cleanup: if (vm) @@ -2436,6 +2442,7 @@ qemuDomainManagedSave(virDomainPtr dom, unsigned int flags) compressed = QEMUD_SAVE_FORMAT_RAW; ret = qemudDomainSaveFlag(driver, dom, vm, name, compressed); + vm = NULL; cleanup: if (vm) -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix uninitialized value in QEMU monitor FD sending code
by Daniel P. Berrange 30 Jun '11

30 Jun '11

The 'char control[CMSG_SPACE(sizeof(int))];' was not being wiped, so could potentially contain uninitialized bytes. While this was harmless in this case, it caused complaints from valgrind * src/qemu/qemu_monitor.c: memset 'control' variable in qemuMonitorIOWriteWithFD --- src/qemu/qemu_monitor.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index e995d97..8573262 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -383,6 +383,7 @@ qemuMonitorIOWriteWithFD(qemuMonitorPtr mon, struct cmsghdr *cmsg; memset(&msg, 0, sizeof(msg)); + memset(control, 0, sizeof(control)); iov[0].iov_base = (void *)data; iov[0].iov_len = len; -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix leak of JSON object for events
by Daniel P. Berrange 30 Jun '11

30 Jun '11

The event handler functions do not free the virJSONValuePtr object. Every event received from a VM thus caused a memory leak * src/qemu/qemu_monitor_json.c: Fix leak of event object --- src/qemu/qemu_monitor_json.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 7d286d8..81b7f8c 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -122,7 +122,6 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon, if (virJSONValueObjectHasKey(obj, "QMP") == 1) { ret = 0; - virJSONValueFree(obj); } else if (virJSONValueObjectHasKey(obj, "event") == 1) { ret = qemuMonitorJSONIOProcessEvent(mon, obj); } else if (virJSONValueObjectHasKey(obj, "error") == 1 || @@ -130,6 +129,7 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon, if (msg) { msg->rxObject = obj; msg->finished = 1; + obj = NULL; ret = 0; } else { qemuReportError(VIR_ERR_INTERNAL_ERROR, @@ -141,8 +141,7 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon, } cleanup: - if (ret < 0) - virJSONValueFree(obj); + virJSONValueFree(obj); return ret; } -- 1.7.4.4

2 1

[libvirt] [PATCH] Remove bogus warning message in JSON code
by Daniel P. Berrange 30 Jun '11

30 Jun '11

* src/util/json.c: Remove warning message --- src/util/json.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/src/util/json.c b/src/util/json.c index 48521f2..a85f580 100644 --- a/src/util/json.c +++ b/src/util/json.c @@ -950,7 +950,6 @@ cleanup: if (parser.nstate) { int i; - VIR_WARN("cleanup state %d", parser.nstate); for (i = 0 ; i < parser.nstate ; i++) { VIR_FREE(parser.state[i].key); } -- 1.7.4.4

2 1

[libvirt] [PATCH] Fix use of uninitialized memory when releasing PCI slots
by Daniel P. Berrange 30 Jun '11

30 Jun '11

The 'function' field in the PCI address was not correctly initialized, so it was building the wrong address address string and so not removing all functions from the in use list. * src/qemu/qemu_command.c: Fix initialization of PCI function --- src/qemu/qemu_command.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 7ac1faf..90a6653 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -931,14 +931,14 @@ int qemuDomainPCIAddressReleaseSlot(qemuDomainPCIAddressSetPtr addrs, int slot) { virDomainDeviceInfo dev; char *addr; - int function; int ret = 0; + unsigned int *function = &dev.addr.pci.function; dev.addr.pci.domain = 0; dev.addr.pci.bus = 0; dev.addr.pci.slot = slot; - for (function = 0; function <= QEMU_PCI_ADDRESS_LAST_FUNCTION; function++) { + for (*function = 0; *function <= QEMU_PCI_ADDRESS_LAST_FUNCTION; (*function)++) { addr = qemuPCIAddressAsString(&dev); if (!addr) return -1; @@ -950,7 +950,7 @@ int qemuDomainPCIAddressReleaseSlot(qemuDomainPCIAddressSetPtr addrs, int slot) VIR_FREE(addr); - if (qemuDomainPCIAddressReleaseFunction(addrs, slot, function) < 0) + if (qemuDomainPCIAddressReleaseFunction(addrs, slot, *function) < 0) ret = -1; } -- 1.7.4.4

2 1

[libvirt] [PATCH] storage: Fix problem of creating a volume in LVM pool
by Osier Yang 30 Jun '11

30 Jun '11

LVM allows one specify the VG with VG path like "/dev/lv_pool", and it gets the correct VG name internally by skipping "/dev". <snip> vg_name = skip_dev_dir(cmd, argv[0], NULL); if (strrchr(vg_name, '/')) { log_error("Volume group name expected " "(no slash)"); return 0; } </snip> However, if the path is like "/dev/t/lv_pool", the VG name will be "/t/lv_pool" then, definitely it's not a valid VG name, and LVM will complain and fail. This patch change the codes to use "pool->def->source.name" instead of "pool->def->target.path" to avoid the problem. --- src/storage/storage_backend_logical.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 4de5442..8fe69ea 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -562,7 +562,7 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn, char size[100]; const char *cmdargvnew[] = { LVCREATE, "--name", vol->name, "-L", size, - pool->def->target.path, NULL + pool->def->source.name, NULL }; const char *cmdargvsnap[] = { LVCREATE, "--name", vol->name, "-L", size, -- 1.7.4

2 2