- Devel - libvirt List Archives

[libvirt] libvirt / libxl testing emails
by George Dunlap 06 Jun '14

06 Jun '14

Ian / Ian, Daniel V. was lurking on a recent CentOS Virt SIG IRC meetings, and asked about testing the libvirt git repo against libxl. I mentioned that we already had some basic tests to do that, and he asked whether it would make sense to have the push gate e-mail the libvirt list. I have no idea how the libvirt people feel about that, so I'll let DV make his case, and also let he Ians give their opinions. -George

4 7

[libvirt] [PATCH 0/3] Attach USB hostdevs using serial id
by Ján Tomko 06 Jun '14

06 Jun '14

Originally posted a year ago: https://www.redhat.com/archives/libvir-list/2013-June/msg00624.html Rebased, with tests and nodedev 'implementation' and some nits fixed. David Waring (2): Add serials to USB hostdevs in domain XML Add ability to attach host USB devices using serial id Ján Tomko (1): Add USB serials to node device driver docs/formatdomain.html.in | 22 +++++---- docs/schemas/domaincommon.rng | 8 ++++ docs/schemas/nodedev.rng | 9 ++++ src/conf/domain_conf.c | 31 ++++++++++-- src/conf/domain_conf.h | 1 + src/conf/node_device_conf.c | 4 ++ src/conf/node_device_conf.h | 1 + src/node_device/node_device_hal.c | 1 + src/node_device/node_device_udev.c | 6 +++ src/util/virhostdev.c | 17 +++---- src/util/virusb.c | 56 +++++++++++++++++++--- src/util/virusb.h | 2 + tests/nodedevschemadata/usb_1_1_5_3.xml | 11 +++++ tests/nodedevxml2xmltest.c | 1 + .../qemuxml2argvdata/qemuxml2argv-usb-hostdev.xml | 42 ++++++++++++++++ tests/qemuxml2xmltest.c | 2 + tests/virusbtest.c | 40 +++++++++++----- .../sys_bus_usb/devices/1-1.5.3.1/serial | 1 + .../sys_bus_usb/devices/1-1.5.3.3/serial | 1 + .../sys_bus_usb/devices/1-1.5.5/serial | 1 + .../sys_bus_usb/devices/1-1.5.6/serial | 1 + .../sys_bus_usb/devices/1-1.5/serial | 1 + .../sys_bus_usb/devices/1-1.6/serial | 1 + .../virusbtestdata/sys_bus_usb/devices/1-1/serial | 1 + .../sys_bus_usb/devices/2-1.2/serial | 1 + .../virusbtestdata/sys_bus_usb/devices/2-1/serial | 1 + .../virusbtestdata/sys_bus_usb/devices/usb1/serial | 1 + .../virusbtestdata/sys_bus_usb/devices/usb2/serial | 1 + .../virusbtestdata/sys_bus_usb/devices/usb3/serial | 1 + .../virusbtestdata/sys_bus_usb/devices/usb4/serial | 1 + 30 files changed, 227 insertions(+), 40 deletions(-) create mode 100644 tests/nodedevschemadata/usb_1_1_5_3.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hostdev.xml create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.1/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.3.3/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.5/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5.6/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.5/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1.6/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/1-1/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1.2/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/2-1/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb1/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb2/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb3/serial create mode 100644 tests/virusbtestdata/sys_bus_usb/devices/usb4/serial -- 1.8.3.2

2 4

[libvirt] [PATCH RFC] Add support for QEMU vhost-user feature
by Luke Gorrie 06 Jun '14

06 Jun '14

Howdy! This patch adds support for the QEMU vhost-user feature to Libvirt. vhost-user is an efficient interface between guests and userspace network stacks (vswitches). Our goal is to have vhost-user supported in the OpenStack Juno release. We hope it is okay to start code review on qemu, Libvirt, and OpenStack in parallel. We understand that code will have to be merged first into QEMU and then into Libvirt and then into OpenStack. References: vhost-user qemu patches: http://lists.gnu.org/archive/html/qemu-devel/2014-05/msg05443.html vhost-user high level description: http://www.virtualopensystems.com/en/solutions/guides/snabbswitch-qemu/ OpenStack feature that this is intended to support (Snabb NFV): http://snabb.co/nfv.html https://blueprints.launchpad.net/neutron/+spec/snabb-nfv-mech-driver Luke Gorrie (1): Add support for QEMU vhost-user feature docs/schemas/domaincommon.rng | 23 ++++++++ src/conf/domain_conf.c | 42 ++++++++++++++ src/conf/domain_conf.h | 5 ++ src/lxc/lxc_process.c | 1 + src/qemu/qemu_command.c | 66 +++++++++++++++++++++- src/uml/uml_conf.c | 5 ++ src/xenxs/xen_sxpr.c | 1 + tests/qemuxml2argvdata/qemuxml2argv-hugepages.args | 2 +- 8 files changed, 142 insertions(+), 3 deletions(-) -- 1.9.1

3 8

[libvirt] [PATCH] translations: Don't leave default template fields in .po files
by Martin Kletzander 06 Jun '14

06 Jun '14

New gettext-0.19 doesn't like it and we can't build without it. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Notes: I'm *not* pushing it as a build-breaker as it's not that urgent. It should be updated in transifex as well. @DV: Can you update this in transifex or do I need to go through some special procedure? po/af.po | 3 ++- po/am.po | 3 ++- po/ar.po | 3 ++- po/be.po | 3 ++- po/bg.po | 3 ++- po/bn.po | 3 ++- po/bs.po | 3 ++- po/cy.po | 3 ++- po/da.po | 3 ++- po/el.po | 3 ++- po/et.po | 3 ++- po/eu_ES.po | 3 ++- po/fa.po | 3 ++- po/fi.po | 3 ++- po/gl.po | 3 ++- po/he.po | 3 ++- po/hr.po | 3 ++- po/hu.po | 3 ++- po/hy.po | 3 ++- po/is.po | 3 ++- po/ka.po | 3 ++- po/ku.po | 3 ++- po/lo.po | 3 ++- po/lt.po | 3 ++- po/lv.po | 3 ++- po/mk.po | 3 ++- po/ms.po | 3 ++- po/my.po | 3 ++- po/nb.po | 3 ++- po/nn.po | 3 ++- po/nso.po | 3 ++- po/ro.po | 3 ++- po/si.po | 3 ++- po/sk.po | 3 ++- po/sl.po | 3 ++- po/sq.po | 3 ++- po/sr.po | 3 ++- po/sr(a)latin.po | 3 ++- po/th.po | 3 ++- po/tr.po | 3 ++- po/ur.po | 3 ++- po/vi.po | 3 ++- po/zu.po | 3 ++- 43 files changed, 86 insertions(+), 43 deletions(-) diff --git a/po/af.po b/po/af.po index 47d5709..5983946 100644 --- a/po/af.po +++ b/po/af.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Afrikaans (http://www.transifex.com/projects/p/" +"fedora/language/af/)\n" "Language: af\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/am.po b/po/am.po index ec8e96a..11c0d57 100644 --- a/po/am.po +++ b/po/am.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Amharic (http://www.transifex.com/projects/p/" +"fedora/language/am/)\n" "Language: am\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/ar.po b/po/ar.po index 04f4ad6..6b37615 100644 --- a/po/ar.po +++ b/po/ar.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Arabic (http://www.transifex.com/projects/p/" +"fedora/language/ar/)\n" "Language: ar\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/be.po b/po/be.po index 869c267..3eb7547 100644 --- a/po/be.po +++ b/po/be.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Belarusian (http://www.transifex.com/projects/p/" +"fedora/language/be/)\n" "Language: be\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/bg.po b/po/bg.po index a2aad89..376068d 100644 --- a/po/bg.po +++ b/po/bg.po @@ -12,7 +12,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Bulgarian (http://www.transifex.com/projects/p/" +"fedora/language/bg/)\n" "Language: bg\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/bn.po b/po/bn.po index 6a088ad..c00862a 100644 --- a/po/bn.po +++ b/po/bn.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Bengali (http://www.transifex.com/projects/p/" +"fedora/language/bn/)\n" "Language: bn\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/bs.po b/po/bs.po index b7b2b6c..de318fe 100644 --- a/po/bs.po +++ b/po/bs.po @@ -12,7 +12,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Bosnian (http://www.transifex.com/projects/p/" +"fedora/language/bs/)\n" "Language: bs\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/cy.po b/po/cy.po index 40f8755..abf8983 100644 --- a/po/cy.po +++ b/po/cy.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Welsh (http://www.transifex.com/projects/p/" +"fedora/language/cy/)\n" "Language: cy\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/da.po b/po/da.po index 19c8715..309e20b 100644 --- a/po/da.po +++ b/po/da.po @@ -14,7 +14,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Danish (http://www.transifex.com/projects/p/" +"fedora/language/da/)\n" "Language: da\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/el.po b/po/el.po index e435e18..1b37281 100644 --- a/po/el.po +++ b/po/el.po @@ -12,7 +12,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Greek (http://www.transifex.com/projects/p/" +"fedora/language/el/)\n" "Language: el\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/et.po b/po/et.po index eaa5407..475815c 100644 --- a/po/et.po +++ b/po/et.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Estonian (http://www.transifex.com/projects/p/" +"fedora/language/et/)\n" "Language: et\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/eu_ES.po b/po/eu_ES.po index f331fe7..50a6d47 100644 --- a/po/eu_ES.po +++ b/po/eu_ES.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Basque (Spain) (http://www.transifex.com/projects/p/" +"fedora/language/eu_ES/)\n" "Language: eu_ES\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/fa.po b/po/fa.po index 232fe37..b51e1e9 100644 --- a/po/fa.po +++ b/po/fa.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Persian (http://www.transifex.com/projects/p/" +"fedora/language/fa/)\n" "Language: fa\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/fi.po b/po/fi.po index d8ef7e3..4e72b3b 100644 --- a/po/fi.po +++ b/po/fi.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Finnish (http://www.transifex.com/projects/p/" +"fedora/language/fi/)\n" "Language: fi\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/gl.po b/po/gl.po index c13e639..60785ff 100644 --- a/po/gl.po +++ b/po/gl.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Galician (http://www.transifex.com/projects/p/" +"fedora/language/gl/)\n" "Language: gl\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/he.po b/po/he.po index f3fe81a..7e96512 100644 --- a/po/he.po +++ b/po/he.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Hebrew (http://www.transifex.com/projects/p/" +"fedora/language/he/)\n" "Language: he\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/hr.po b/po/hr.po index 20dd8af..a89a097 100644 --- a/po/hr.po +++ b/po/hr.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Croatian (http://www.transifex.com/projects/p/" +"fedora/language/hr/)\n" "Language: hr\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/hu.po b/po/hu.po index 3ca40e8..1ac232c 100644 --- a/po/hu.po +++ b/po/hu.po @@ -13,7 +13,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Hungarian (http://www.transifex.com/projects/p/" +"fedora/language/hu/)\n" "Language: hu\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/hy.po b/po/hy.po index f03527c..6d91677 100644 --- a/po/hy.po +++ b/po/hy.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Armenian (http://www.transifex.com/projects/p/" +"fedora/language/hy/)\n" "Language: hy\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/is.po b/po/is.po index 8bf7060..78841b8 100644 --- a/po/is.po +++ b/po/is.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Icelandic (http://www.transifex.com/projects/p/" +"fedora/language/is/)\n" "Language: is\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/ka.po b/po/ka.po index 8709719..42b3001 100644 --- a/po/ka.po +++ b/po/ka.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Georgian (http://www.transifex.com/projects/p/" +"fedora/language/ka/)\n" "Language: ka\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/ku.po b/po/ku.po index 16d9e4c..351753b 100644 --- a/po/ku.po +++ b/po/ku.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Kurdish (http://www.transifex.com/projects/p/" +"fedora/language/ku/)\n" "Language: ku\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/lo.po b/po/lo.po index b197727..d989680 100644 --- a/po/lo.po +++ b/po/lo.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Lao (http://www.transifex.com/projects/p/" +"fedora/language/lo/)\n" "Language: lo\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/lt.po b/po/lt.po index 711a787..a85c614 100644 --- a/po/lt.po +++ b/po/lt.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Lithuanian (http://www.transifex.com/projects/p/" +"fedora/language/lt/)\n" "Language: lt\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/lv.po b/po/lv.po index eda0f0b..20686e3 100644 --- a/po/lv.po +++ b/po/lv.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Latvian (http://www.transifex.com/projects/p/" +"fedora/language/lv/)\n" "Language: lv\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/mk.po b/po/mk.po index baa63b8..ea7a345 100644 --- a/po/mk.po +++ b/po/mk.po @@ -13,7 +13,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Macedonian (http://www.transifex.com/projects/p/" +"fedora/language/mk/)\n" "Language: mk\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/ms.po b/po/ms.po index c032193..4b1ba01 100644 --- a/po/ms.po +++ b/po/ms.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Malay (http://www.transifex.com/projects/p/" +"fedora/language/ms/)\n" "Language: ms\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/my.po b/po/my.po index 92f7928..fedac71 100644 --- a/po/my.po +++ b/po/my.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Burmese (http://www.transifex.com/projects/p/" +"fedora/language/my/)\n" "Language: my\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/nb.po b/po/nb.po index 5747634..0833e5b 100644 --- a/po/nb.po +++ b/po/nb.po @@ -13,7 +13,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Norwegian Bokmål (http://www.transifex.com/projects/p/" +"fedora/language/nb/)\n" "Language: nb\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/nn.po b/po/nn.po index 25db485..29a3bfb 100644 --- a/po/nn.po +++ b/po/nn.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Norwegian Nynorsk (http://www.transifex.com/projects/p/" +"fedora/language/nn/)\n" "Language: nn\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/nso.po b/po/nso.po index a1133f0..1d9d033 100644 --- a/po/nso.po +++ b/po/nso.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Northern Sotho (http://www.transifex.com/projects/p/" +"fedora/language/nso/)\n" "Language: nso\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/ro.po b/po/ro.po index 1034523..77ac4a6 100644 --- a/po/ro.po +++ b/po/ro.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Romanian (http://www.transifex.com/projects/p/" +"fedora/language/ro/)\n" "Language: ro\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/si.po b/po/si.po index c49b142..79e193f 100644 --- a/po/si.po +++ b/po/si.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Sinhala (http://www.transifex.com/projects/p/" +"fedora/language/si/)\n" "Language: si\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/sk.po b/po/sk.po index c1f87e4..8741916 100644 --- a/po/sk.po +++ b/po/sk.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Slovak (http://www.transifex.com/projects/p/" +"fedora/language/sk/)\n" "Language: sk\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/sl.po b/po/sl.po index fea62eb..3d0b0d0 100644 --- a/po/sl.po +++ b/po/sl.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Slovenian (http://www.transifex.com/projects/p/" +"fedora/language/sl/)\n" "Language: sl\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/sq.po b/po/sq.po index 4a89203..c6e753a 100644 --- a/po/sq.po +++ b/po/sq.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Albanian (http://www.transifex.com/projects/p/" +"fedora/language/sq/)\n" "Language: sq\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/sr.po b/po/sr.po index cb8d778..89ec973 100644 --- a/po/sr.po +++ b/po/sr.po @@ -12,7 +12,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Serbian (http://www.transifex.com/projects/p/" +"fedora/language/sr/)\n" "Language: sr\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/sr(a)latin.po b/po/sr(a)latin.po index 2259992..ca6ebb3 100644 --- a/po/sr(a)latin.po +++ b/po/sr(a)latin.po @@ -12,7 +12,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Serbian (Latin) (http://www.transifex.com/projects/p/" +"fedora/language/sr@latin/)\n" "Language: sr@latin\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/th.po b/po/th.po index 3e4b343..5039af4 100644 --- a/po/th.po +++ b/po/th.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Thai (http://www.transifex.com/projects/p/" +"fedora/language/th/)\n" "Language: th\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/tr.po b/po/tr.po index cf5f540..892fffc 100644 --- a/po/tr.po +++ b/po/tr.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Turkish (http://www.transifex.com/projects/p/" +"fedora/language/tr/)\n" "Language: tr\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/ur.po b/po/ur.po index b50e05b..4520fe2 100644 --- a/po/ur.po +++ b/po/ur.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:12+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Urdu (http://www.transifex.com/projects/p/" +"fedora/language/ur/)\n" "Language: ur\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/vi.po b/po/vi.po index 2f76bd4..d4b46c3 100644 --- a/po/vi.po +++ b/po/vi.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Vietnamese (http://www.transifex.com/projects/p/" +"fedora/language/vi/)\n" "Language: vi\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" diff --git a/po/zu.po b/po/zu.po index 3bacc98..b5c272e 100644 --- a/po/zu.po +++ b/po/zu.po @@ -11,7 +11,8 @@ msgstr "" "POT-Creation-Date: 2014-06-02 09:35+0800\n" "PO-Revision-Date: 2013-01-28 14:11+0000\n" "Last-Translator: Daniel <veillard(a)redhat.com>\n" -"Language-Team: LANGUAGE <LL(a)li.org>\n" +"Language-Team: Zulu (http://www.transifex.com/projects/p/" +"fedora/language/zu/)\n" "Language: zu\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" -- 2.0.0

2 2

[libvirt] [PATCH] manual: Add virsh manual about specified migration host
by Chen Fan 06 Jun '14

06 Jun '14

the 'migration_host' description maybe have a bit of difficulty to understand for user, so add this manual for them. Signed-off-by: Chen Fan <chen.fan.fnst(a)cn.fujitsu.com> --- tools/virsh.pod | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index de9a4f7..8d77a2f 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1238,6 +1238,11 @@ seen from the source machine. When I<migrateuri> is not specified, libvirt will automatically determine the hypervisor specific URI, by looking up the target host's configured hostname. +In particular, some hypervisors support having this migration hostname specified +separately by setting 'migration_host' in definition file, if 'migration_host' +is specified, the hostname or IP address will be used to as the default I<migrateuri> +while running migration from source host. if 'migration_host' is not specified, +the migration hostname is set to the host's configured hostname by default. There are a few scenarios where specifying I<migrateuri> may help: =over 4 @@ -1251,7 +1256,9 @@ explicitly specified, using an IP address, or a correct hostname. interfaces, it might be desirable for the migration data stream to be sent over a specific interface for either security or performance reasons. In this case I<migrateuri> should be explicitly specified, using an IP address associated -with the network to be used. +with the network to be used. In particular, Some hypervisors could be easy to +specify the default network interface by setting 'migration_host'. then the +I<migrateuri> can be omitted. =item * The firewall restricts what ports are available. When libvirt generates a migration URI, it will pick a port number using hypervisor specific rules. -- 1.9.3

3 4

[libvirt] [PATCH 0/3] Fix storage format probing
by Ján Tomko 06 Jun '14

06 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1104908 Ján Tomko (3): Don't reuse 'ret' variable in virStorageBackendProbeTarget Simplify conditions in virStorageBackendProbeTarget Fix storage format probing src/storage/storage_backend_fs.c | 69 ++++++++++++++++------------------- src/storage/storage_backend_gluster.c | 1 + 2 files changed, 32 insertions(+), 38 deletions(-) -- 1.8.3.2

2 7

[libvirt] [PATCH 0/4] Expose link state & speed
by Michal Privoznik 05 Jun '14

05 Jun '14

This is practically a v2, but this time split into more patches and extended. Michal Privoznik (4): virInterface: Expose link state & speed interface_backend_udev: Implement link speed & state interface_backend_netcf: Implement link speed & state node_device: Expose link state & speed docs/formatnode.html.in | 6 ++ docs/schemas/basictypes.rng | 25 ++++++ docs/schemas/interface.rng | 1 + docs/schemas/nodedev.rng | 1 + src/conf/device_conf.c | 62 ++++++++++++++ src/conf/device_conf.h | 27 +++++- src/conf/interface_conf.c | 11 ++- src/conf/interface_conf.h | 2 + src/conf/node_device_conf.c | 7 +- src/conf/node_device_conf.h | 2 + src/interface/interface_backend_netcf.c | 104 ++++++++++++++++++++++++ src/interface/interface_backend_udev.c | 27 ++++++ src/libvirt_private.syms | 4 + src/node_device/node_device_driver.c | 27 ++++-- src/node_device/node_device_hal.c | 9 ++ src/node_device/node_device_hal.h | 1 + src/node_device/node_device_udev.c | 65 +++++++++++++++ src/node_device/node_device_udev.h | 4 + tests/interfaceschemadata/bridge-no-address.xml | 1 + tests/interfaceschemadata/bridge.xml | 1 + tests/interfaceschemadata/ethernet-dhcp.xml | 1 + 21 files changed, 380 insertions(+), 8 deletions(-) -- 2.0.0

2 7

[libvirt] [PATCH v2 0/2] Couple of virCaps improvements
by Michal Privoznik 05 Jun '14

05 Jun '14

diff to v1: -rename the test -drop even more from the original documentation Michal Privoznik (2): vircaps2xmltest: Introduce basic testing formatcaps: Rework and add stubs to document docs/formatcaps.html.in | 139 +++++++++++++++------ tests/Makefile.am | 6 + tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml | 74 +++++++++++ tests/vircaps2xmltest.c | 164 +++++++++++++++++++++++++ 4 files changed, 345 insertions(+), 38 deletions(-) create mode 100644 tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml create mode 100644 tests/vircaps2xmltest.c -- 2.0.0

2 4

[libvirt] [PATCH 0/2] Couple of virCaps improvements
by Michal Privoznik 05 Jun '14

05 Jun '14

Literally couple. As usual, the aim is not completeness, but to prepare environment for future work (if somebody is willing to contribute patches). Michal Privoznik (2): vircapstest: Introduce basic testing formatcaps: Rework and add stubs to document docs/formatcaps.html.in | 158 +++++++++++++++++++++++++++--------- tests/vircapsdata/vircaps-basic.xml | 66 +++++++++++++++ tests/vircapstest.c | 77 +++++++++++++++++- 3 files changed, 262 insertions(+), 39 deletions(-) create mode 100644 tests/vircapsdata/vircaps-basic.xml -- 2.0.0

3 7

[libvirt] [PATCH v2] maint: prohibit empty first lines
by Martin Kletzander 05 Jun '14

05 Jun '14

Based on discussion with Eric: https://www.redhat.com/archives/libvir-list/2014-March/msg01001.html Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- v2: - rebase on current master and s/FILENAME:1:/FILENAME ":1:"/ cfg.mk | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/cfg.mk b/cfg.mk index 675af21..80440b5 100644 --- a/cfg.mk +++ b/cfg.mk @@ -938,6 +938,13 @@ sc_require_locale_h: fi; \ done; +sc_prohibit_empty_first_line: + @awk 'BEGIN { fail=0; } \ + FNR == 1 { if ($$0 == "") { print FILENAME ":1:"; fail=1; } } \ + END { if (fail == 1) { \ + print "$(ME): Prohibited empty first line" > "/dev/stderr"; \ + } exit fail; }' $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); + # We don't use this feature of maint.mk. prev_version_file = /dev/null -- 2.0.0

3 3

[libvirt] [libvirt-sandbox PATCH] Only set SELinux seclabel if supported by the host.
by Cédric Bosdonnat 05 Jun '14

05 Jun '14

This code depends on new API in libvirt-gconfig to extract the secmodels handled by the host. --- libvirt-sandbox/libvirt-sandbox-builder.c | 68 ++++++++++++++++++++----------- 1 file changed, 45 insertions(+), 23 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-builder.c b/libvirt-sandbox/libvirt-sandbox-builder.c index 48b3acc..547b1c7 100644 --- a/libvirt-sandbox/libvirt-sandbox-builder.c +++ b/libvirt-sandbox/libvirt-sandbox-builder.c @@ -323,38 +323,60 @@ static gboolean gvir_sandbox_builder_construct_devices(GVirSandboxBuilder *build } -static gboolean gvir_sandbox_builder_construct_security(GVirSandboxBuilder *builder G_GNUC_UNUSED, +static gboolean gvir_sandbox_builder_construct_security(GVirSandboxBuilder *builder, GVirSandboxConfig *config G_GNUC_UNUSED, const gchar *statedir G_GNUC_UNUSED, GVirConfigDomain *domain, - GError **error G_GNUC_UNUSED) + GError **error) { GVirConfigDomainSeclabel *sec = gvir_config_domain_seclabel_new(); const char *label = gvir_sandbox_config_get_security_label(config); + GVirConnection *connection = gvir_sandbox_builder_get_connection(builder); + GVirConfigCapabilities *configCapabilities; + GVirConfigCapabilitiesHost *hostCapabilities; + GList *secmodels, *iter; + gboolean supportsSelinux = FALSE; + + /* What security models are available on the host? */ + if (!(configCapabilities = gvir_connection_get_capabilities(connection, error))) { + g_object_unref(sec); + return FALSE; + } + + hostCapabilities = gvir_config_capabilities_get_host(configCapabilities); - gvir_config_domain_seclabel_set_model(sec, "selinux"); - if (gvir_sandbox_config_get_security_dynamic(config)) { - gvir_config_domain_seclabel_set_type(sec, - GVIR_CONFIG_DOMAIN_SECLABEL_DYNAMIC); - if (label) - gvir_config_domain_seclabel_set_baselabel(sec, label); - else if (gvir_config_domain_get_virt_type(domain) == - GVIR_CONFIG_DOMAIN_VIRT_LXC) - gvir_config_domain_seclabel_set_baselabel(sec, "system_u:system_r:svirt_lxc_net_t:s0"); - else if (gvir_config_domain_get_virt_type(domain) == - GVIR_CONFIG_DOMAIN_VIRT_QEMU) - gvir_config_domain_seclabel_set_baselabel(sec, "system_u:system_r:svirt_tcg_t:s0"); - else if (gvir_config_domain_get_virt_type(domain) == - GVIR_CONFIG_DOMAIN_VIRT_KVM) - gvir_config_domain_seclabel_set_baselabel(sec, "system_u:system_r:svirt_t:s0"); - } else { - gvir_config_domain_seclabel_set_type(sec, - GVIR_CONFIG_DOMAIN_SECLABEL_STATIC); - if (label) - gvir_config_domain_seclabel_set_label(sec, label); + secmodels = gvir_config_capabilities_host_get_secmodels(hostCapabilities); + for (iter = secmodels; iter != NULL; iter = iter->next) { + supportsSelinux = g_str_equal(gvir_config_capabilities_secmodel_get_model( + GVIR_CONFIG_CAPABILITIES_SECMODEL(iter->data)), "selinux"); + g_object_unref(iter->data); } - gvir_config_domain_set_seclabel(domain, sec); + if (supportsSelinux) { + gvir_config_domain_seclabel_set_model(sec, "selinux"); + if (gvir_sandbox_config_get_security_dynamic(config)) { + gvir_config_domain_seclabel_set_type(sec, + GVIR_CONFIG_DOMAIN_SECLABEL_DYNAMIC); + if (label) + gvir_config_domain_seclabel_set_baselabel(sec, label); + else if (gvir_config_domain_get_virt_type(domain) == + GVIR_CONFIG_DOMAIN_VIRT_LXC) + gvir_config_domain_seclabel_set_baselabel(sec, "system_u:system_r:svirt_lxc_net_t:s0"); + else if (gvir_config_domain_get_virt_type(domain) == + GVIR_CONFIG_DOMAIN_VIRT_QEMU) + gvir_config_domain_seclabel_set_baselabel(sec, "system_u:system_r:svirt_tcg_t:s0"); + else if (gvir_config_domain_get_virt_type(domain) == + GVIR_CONFIG_DOMAIN_VIRT_KVM) + gvir_config_domain_seclabel_set_baselabel(sec, "system_u:system_r:svirt_t:s0"); + } else { + gvir_config_domain_seclabel_set_type(sec, + GVIR_CONFIG_DOMAIN_SECLABEL_STATIC); + if (label) + gvir_config_domain_seclabel_set_label(sec, label); + } + + gvir_config_domain_set_seclabel(domain, sec); + } g_object_unref(sec); return TRUE; -- 1.8.4.5

1 0

[libvirt] [PATCH] maint: detect VPATH builds when checking for gnulib update
by Eric Blake 04 Jun '14

04 Jun '14

I accidentally typed 'make' in the srcdir of a VPATH build, and was surprised to see this: $ make /bin/sh: s/^[ +-]//;s/ .*//: No such file or directory INFO: gnulib update required; running ./autogen.sh first make: -n: Command not found ./autogen.sh I am going to run ./configure with no arguments - if you wish to pass any to it, please specify them on the ./autogen.sh command line. running bootstrap... ./bootstrap: Bootstrapping from checked-out libvirt sources... ./bootstrap: getting gnulib files... Oops - we're trying to execute some fairly bogus command names, and then trying to configure in-tree (which breaks all existing VPATH builds, since automake refuses to do a VPATH build if it detects an in-tree configure). The third line (executing "-n") is fixed by updating to the latest gnulib; the rest of the problem is fixed by copying the same filtering in our cfg.mk as what gnulib just added, so that we avoid any $(shell) invocations which in turn depend on variables that are only populated by a working Makefile. With that in place, we are back to the much nicer: $ make There seems to be no Makefile in this directory. You must run ./configure before running 'make'. make: *** [abort-due-to-no-makefile] Error 1 Additionally, although harder to see - there was a trailing space in the message warning us that autogen would run an in-tree configure. * .gnulib: Update to latest, in part for maint.mk improvements. * cfg.mk (_update_required): Don't check for update in unconfigured directory. * autogen.sh (no_git): Drop trailing space. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the gnulib maintenance rule. * .gnulib e8e0eb6...d55899f (35): > maintainer-makefile: delete obsolete code > maintainer-makefile: avoid spurious error messages > rename: avoid unused-but-set-variable compiler warning > maint: add ChangeLog entry missing in previous commit > rename: mark a label as potentially unused > gnulib-common.m4: Fix typo in _GL_UNUSED_LABEL. > acl: apply pure attribute to two functions > gnulib-common.m4: add _GL_UNUSED_LABEL > dup2, fcntl, fcntl-h: port to AIX 7.1 > printf, config.rpath: Port to FreeBSD 10. > ftoastr: work around compiler bug in IBM xlc 12.1 > valgrind-tests: fixed misleading help message > isfinite, isinf, isnan tests: fix for little-endian PowerPC > exclude-tests: port to AIX 7.1 > pthread_sigmask, timer-time: use gl_THREADLIB only if needed > gnulib-tool: wget translations using --no-verbose rather than --quiet > gnulib-tool: adjust translation wget to avoid a https redirection > getlogin_r-tests: check return value rather than errno > getlogin_r-tests: fix various issues in recent change > fchdir: port 'open' and 'close' redefinitions to AIX 7.1 > update from texinfo > xalloc: don't potentially generate invalid code for xmemdup calls > getlogin_r-tests: avoid false failure under sudo/ssh etc. > getlogin-tests: avoid false failure under cron > mbrtowc.m4: fix a comment typo > mbrlen, mbrtowc: fix bug with empty input > doc: document mbrtowc and mbrlen problem with empty input > doc: document exec* = spawn+exit bug with non-Cygwin Windows platforms > autoupdate > getlogin-tests: avoid false failure under sudo/ssh etc. > mbsstr, quotearg, xstrtol: pacify IRIX 6.5 cc > update from texinfo > autoupdate > autoupdate > autoupdate .gnulib | 2 +- autogen.sh | 2 +- cfg.mk | 4 ++++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gnulib b/.gnulib index e8e0eb6..d55899f 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit e8e0eb6bfb728685ec8d5afd924e41b18e9d928d +Subproject commit d55899fd2c5794ac85ecb14d5e2f646a89e4b4dd diff --git a/autogen.sh b/autogen.sh index 5aa1990..1965f64 100755 --- a/autogen.sh +++ b/autogen.sh @@ -35,7 +35,7 @@ if test -z "$NOCONFIGURE" ; then echo "Running ./configure with $EXTRA_ARGS $@" else if test -z "$*" && test ! -f "$THEDIR/config.status"; then - echo "I am going to run ./configure with no arguments - if you wish " + echo "I am going to run ./configure with no arguments - if you wish" echo "to pass any to it, please specify them on the $0 command line." fi fi diff --git a/cfg.mk b/cfg.mk index 4601b35..b5f1fa2 100644 --- a/cfg.mk +++ b/cfg.mk @@ -939,6 +939,7 @@ sc_require_locale_h: # We don't use this feature of maint.mk. prev_version_file = /dev/null +ifneq ($(_gl-Makefile),) ifeq (0,$(MAKELEVEL)) _curr_status = .git-module-status # The sed filter accommodates those who check out on a commit from which @@ -971,6 +972,7 @@ ifeq (0,$(MAKELEVEL)) maint.mk Makefile: _autogen endif endif +endif # It is necessary to call autogen any time gnulib changes. Autogen # reruns configure, then we regenerate all Makefiles at once. @@ -980,7 +982,9 @@ _autogen: ./config.status # regenerate HACKING as part of the syntax-check +ifneq ($(_gl-Makefile),) syntax-check: $(top_srcdir)/HACKING bracket-spacing-check +endif bracket-spacing-check: $(AM_V_GEN)files=`$(VC_LIST) | grep '\.c$$'`; \ -- 1.9.3

1 0

[libvirt] [PATCH V7] libxl: add migration support
by Jim Fehlig 04 Jun '14

04 Jun '14

This patch adds initial migration support to the libxl driver, using the VIR_DRV_FEATURE_MIGRATION_PARAMS family of migration functions. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- V6 here https://www.redhat.com/archives/libvir-list/2014-May/msg00017.html In V7: There were no comments on V6, but during testing I noticed that 'virsh migrate --suspend ...' was not being honored. Fixed that in this version so that the domain is paused on the destination once migration completes. po/POTFILES.in | 1 + src/Makefile.am | 3 +- src/libxl/libxl_conf.h | 6 + src/libxl/libxl_domain.h | 1 + src/libxl/libxl_driver.c | 235 ++++++++++++++++++ src/libxl/libxl_migration.c | 581 ++++++++++++++++++++++++++++++++++++++++++++ src/libxl/libxl_migration.h | 79 ++++++ 7 files changed, 905 insertions(+), 1 deletion(-) diff --git a/po/POTFILES.in b/po/POTFILES.in index e35eb82..a72dc1e 100644 --- a/po/POTFILES.in +++ b/po/POTFILES.in @@ -73,6 +73,7 @@ src/lxc/lxc_process.c src/libxl/libxl_domain.c src/libxl/libxl_driver.c src/libxl/libxl_conf.c +src/libxl/libxl_migration.c src/network/bridge_driver.c src/network/bridge_driver_linux.c src/node_device/node_device_driver.c diff --git a/src/Makefile.am b/src/Makefile.am index e9dc9e0..0dbda7f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -706,7 +706,8 @@ XENAPI_DRIVER_SOURCES = \ LIBXL_DRIVER_SOURCES = \ libxl/libxl_conf.c libxl/libxl_conf.h \ libxl/libxl_domain.c libxl/libxl_domain.h \ - libxl/libxl_driver.c libxl/libxl_driver.h + libxl/libxl_driver.c libxl/libxl_driver.h \ + libxl/libxl_migration.c libxl/libxl_migration.h UML_DRIVER_SOURCES = \ uml/uml_conf.c uml/uml_conf.h \ diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index 24e1720..b798567 100644 --- a/src/libxl/libxl_conf.h +++ b/src/libxl/libxl_conf.h @@ -43,6 +43,9 @@ # define LIBXL_VNC_PORT_MIN 5900 # define LIBXL_VNC_PORT_MAX 65535 +# define LIBXL_MIGRATION_PORT_MIN 49152 +# define LIBXL_MIGRATION_PORT_MAX 49216 + # define LIBXL_CONFIG_DIR SYSCONFDIR "/libvirt/libxl" # define LIBXL_AUTOSTART_DIR LIBXL_CONFIG_DIR "/autostart" # define LIBXL_STATE_DIR LOCALSTATEDIR "/run/libvirt/libxl" @@ -115,6 +118,9 @@ struct _libxlDriverPrivate { /* Immutable pointer, self-locking APIs */ virPortAllocatorPtr reservedVNCPorts; + /* Immutable pointer, self-locking APIs */ + virPortAllocatorPtr migrationPorts; + /* Immutable pointer, lockless APIs*/ virSysinfoDefPtr hostsysinfo; }; diff --git a/src/libxl/libxl_domain.h b/src/libxl/libxl_domain.h index 979ce2a..9d48049 100644 --- a/src/libxl/libxl_domain.h +++ b/src/libxl/libxl_domain.h @@ -69,6 +69,7 @@ struct _libxlDomainObjPrivate { virChrdevsPtr devs; libxl_evgen_domain_death *deathW; libxlDriverPrivatePtr driver; + unsigned short migrationPort; struct libxlDomainJobObj job; }; diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index df7d510..35467ac 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -45,6 +45,7 @@ #include "libxl_domain.h" #include "libxl_driver.h" #include "libxl_conf.h" +#include "libxl_migration.h" #include "xen_xm.h" #include "xen_sxpr.h" #include "virtypedparam.h" @@ -209,6 +210,7 @@ libxlStateCleanup(void) virObjectUnref(libxl_driver->xmlopt); virObjectUnref(libxl_driver->domains); virObjectUnref(libxl_driver->reservedVNCPorts); + virObjectUnref(libxl_driver->migrationPorts); virObjectEventStateFree(libxl_driver->domainEventState); virSysinfoDefFree(libxl_driver->hostsysinfo); @@ -301,6 +303,13 @@ libxlStateInitialize(bool privileged, LIBXL_VNC_PORT_MAX))) goto error; + /* Allocate bitmap for migration port reservation */ + if (!(libxl_driver->migrationPorts = + virPortAllocatorNew(_("migration"), + LIBXL_MIGRATION_PORT_MIN, + LIBXL_MIGRATION_PORT_MAX))) + goto error; + if (!(libxl_driver->domains = virDomainObjListNew())) goto error; @@ -4155,6 +4164,7 @@ libxlConnectSupportsFeature(virConnectPtr conn, int feature) switch (feature) { case VIR_DRV_FEATURE_TYPED_PARAM_STRING: + case VIR_DRV_FEATURE_MIGRATION_PARAMS: return 1; default: return 0; @@ -4333,6 +4343,226 @@ libxlNodeDeviceReset(virNodeDevicePtr dev) return ret; } +static char * +libxlDomainMigrateBegin3Params(virDomainPtr domain, + virTypedParameterPtr params, + int nparams, + char **cookieout ATTRIBUTE_UNUSED, + int *cookieoutlen ATTRIBUTE_UNUSED, + unsigned int flags) +{ + const char *xmlin = NULL; + virDomainObjPtr vm = NULL; + + virCheckFlags(LIBXL_MIGRATION_FLAGS, NULL); + if (virTypedParamsValidate(params, nparams, LIBXL_MIGRATION_PARAMETERS) < 0) + return NULL; + + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_XML, + &xmlin) < 0) + return NULL; + + if (!(vm = libxlDomObjFromDomain(domain))) + return NULL; + + if (virDomainMigrateBegin3ParamsEnsureACL(domain->conn, vm->def) < 0) { + virObjectUnlock(vm); + return NULL; + } + + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + virObjectUnlock(vm); + return NULL; + } + + return libxlDomainMigrationBegin(domain->conn, vm, xmlin); +} + +static int +libxlDomainMigratePrepare3Params(virConnectPtr dconn, + virTypedParameterPtr params, + int nparams, + const char *cookiein ATTRIBUTE_UNUSED, + int cookieinlen ATTRIBUTE_UNUSED, + char **cookieout ATTRIBUTE_UNUSED, + int *cookieoutlen ATTRIBUTE_UNUSED, + char **uri_out, + unsigned int flags) +{ + libxlDriverPrivatePtr driver = dconn->privateData; + virDomainDefPtr def = NULL; + const char *dom_xml = NULL; + const char *dname = NULL; + const char *uri_in = NULL; + + virCheckFlags(LIBXL_MIGRATION_FLAGS, -1); + if (virTypedParamsValidate(params, nparams, LIBXL_MIGRATION_PARAMETERS) < 0) + goto error; + + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_XML, + &dom_xml) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, + &dname) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_URI, + &uri_in) < 0) + + goto error; + + if (!(def = libxlDomainMigrationPrepareDef(driver, dom_xml, dname))) + goto error; + + if (virDomainMigratePrepare3ParamsEnsureACL(dconn, def) < 0) + goto error; + + if (libxlDomainMigrationPrepare(dconn, def, uri_in, uri_out, flags) < 0) + goto error; + + return 0; + + error: + virDomainDefFree(def); + return -1; +} + +static int +libxlDomainMigratePerform3Params(virDomainPtr dom, + const char *dconnuri, + virTypedParameterPtr params, + int nparams, + const char *cookiein ATTRIBUTE_UNUSED, + int cookieinlen ATTRIBUTE_UNUSED, + char **cookieout ATTRIBUTE_UNUSED, + int *cookieoutlen ATTRIBUTE_UNUSED, + unsigned int flags) +{ + libxlDriverPrivatePtr driver = dom->conn->privateData; + virDomainObjPtr vm = NULL; + const char *dom_xml = NULL; + const char *dname = NULL; + const char *uri = NULL; + int ret = -1; + + virCheckFlags(LIBXL_MIGRATION_FLAGS, -1); + if (virTypedParamsValidate(params, nparams, LIBXL_MIGRATION_PARAMETERS) < 0) + goto cleanup; + + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_XML, + &dom_xml) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, + &dname) < 0 || + virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_URI, + &uri) < 0) + + goto cleanup; + + if (!(vm = libxlDomObjFromDomain(dom))) + goto cleanup; + + if (virDomainMigratePerform3ParamsEnsureACL(dom->conn, vm->def) < 0) + goto cleanup; + + if (libxlDomainMigrationPerform(driver, vm, dom_xml, dconnuri, + uri, dname, flags) < 0) { + /* Job terminated and vm unlocked if MigrationPerform failed */ + vm = NULL; + goto cleanup; + } + + ret = 0; + + cleanup: + if (vm) + virObjectUnlock(vm); + return ret; +} + +static virDomainPtr +libxlDomainMigrateFinish3Params(virConnectPtr dconn, + virTypedParameterPtr params, + int nparams, + const char *cookiein ATTRIBUTE_UNUSED, + int cookieinlen ATTRIBUTE_UNUSED, + char **cookieout ATTRIBUTE_UNUSED, + int *cookieoutlen ATTRIBUTE_UNUSED, + unsigned int flags, + int cancelled) +{ + libxlDriverPrivatePtr driver = dconn->privateData; + virDomainObjPtr vm = NULL; + const char *dname = NULL; + + virCheckFlags(LIBXL_MIGRATION_FLAGS, NULL); + if (virTypedParamsValidate(params, nparams, LIBXL_MIGRATION_PARAMETERS) < 0) + return NULL; + + if (virTypedParamsGetString(params, nparams, + VIR_MIGRATE_PARAM_DEST_NAME, + &dname) < 0) + return NULL; + + if (!dname || + !(vm = virDomainObjListFindByName(driver->domains, dname))) { + /* Migration obviously failed if the domain doesn't exist */ + virReportError(VIR_ERR_OPERATION_FAILED, + _("Migration failed. No domain on destination host " + "with matching name '%s'"), + NULLSTR(dname)); + return NULL; + } + + if (virDomainMigrateFinish3ParamsEnsureACL(dconn, vm->def) < 0) { + virObjectUnlock(vm); + return NULL; + } + + if (!virDomainObjIsActive(vm)) { + /* Migration failed if domain is inactive */ + virReportError(VIR_ERR_OPERATION_FAILED, + "%s", _("Migration failed. Domain is not running " + "on destination host")); + virObjectUnlock(vm); + return NULL; + } + + return libxlDomainMigrationFinish(dconn, vm, flags, cancelled); +} + +static int +libxlDomainMigrateConfirm3Params(virDomainPtr domain, + virTypedParameterPtr params, + int nparams, + const char *cookiein ATTRIBUTE_UNUSED, + int cookieinlen ATTRIBUTE_UNUSED, + unsigned int flags, + int cancelled) +{ + libxlDriverPrivatePtr driver = domain->conn->privateData; + virDomainObjPtr vm = NULL; + + virCheckFlags(LIBXL_MIGRATION_FLAGS, -1); + if (virTypedParamsValidate(params, nparams, LIBXL_MIGRATION_PARAMETERS) < 0) + return -1; + + if (!(vm = libxlDomObjFromDomain(domain))) + return -1; + + if (virDomainMigrateConfirm3ParamsEnsureACL(domain->conn, vm->def) < 0) { + virObjectUnlock(vm); + return -1; + } + + return libxlDomainMigrationConfirm(driver, vm, flags, cancelled); +} + static virDriver libxlDriver = { .no = VIR_DRV_LIBXL, @@ -4423,6 +4653,11 @@ static virDriver libxlDriver = { .nodeDeviceDetachFlags = libxlNodeDeviceDetachFlags, /* 1.2.3 */ .nodeDeviceReAttach = libxlNodeDeviceReAttach, /* 1.2.3 */ .nodeDeviceReset = libxlNodeDeviceReset, /* 1.2.3 */ + .domainMigrateBegin3Params = libxlDomainMigrateBegin3Params, /* 1.2.3 */ + .domainMigratePrepare3Params = libxlDomainMigratePrepare3Params, /* 1.2.3 */ + .domainMigratePerform3Params = libxlDomainMigratePerform3Params, /* 1.2.3 */ + .domainMigrateFinish3Params = libxlDomainMigrateFinish3Params, /* 1.2.3 */ + .domainMigrateConfirm3Params = libxlDomainMigrateConfirm3Params, /* 1.2.3 */ }; static virStateDriver libxlStateDriver = { diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c new file mode 100644 index 0000000..e3699c5 --- /dev/null +++ b/src/libxl/libxl_migration.c @@ -0,0 +1,581 @@ +/* + * libxl_migration.c: methods for handling migration with libxenlight + * + * Copyright (C) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: + * Jim Fehlig <jfehlig(a)suse.com> + * Chunyan Liu <cyliu(a)suse.com> + */ + +#include <config.h> + +#include "internal.h" +#include "virlog.h" +#include "virerror.h" +#include "virconf.h" +#include "datatypes.h" +#include "virfile.h" +#include "viralloc.h" +#include "viruuid.h" +#include "vircommand.h" +#include "virstring.h" +#include "virobject.h" +#include "rpc/virnetsocket.h" +#include "libxl_domain.h" +#include "libxl_driver.h" +#include "libxl_conf.h" +#include "libxl_migration.h" + +#define VIR_FROM_THIS VIR_FROM_LIBXL + +VIR_LOG_INIT("libxl.libxl_migration"); + +typedef struct _libxlMigrationDstArgs { + virObject parent; + + virConnectPtr conn; + virDomainObjPtr vm; + unsigned int flags; + + /* for freeing listen sockets */ + virNetSocketPtr *socks; + size_t nsocks; +} libxlMigrationDstArgs; + +static virClassPtr libxlMigrationDstArgsClass; + +static void +libxlMigrationDstArgsDispose(void *obj) +{ + libxlMigrationDstArgs *args = obj; + + VIR_FREE(args->socks); +} + +static int +libxlMigrationDstArgsOnceInit(void) +{ + if (!(libxlMigrationDstArgsClass = virClassNew(virClassForObject(), + "libxlMigrationDstArgs", + sizeof(libxlMigrationDstArgs), + libxlMigrationDstArgsDispose))) + return -1; + + return 0; +} + +VIR_ONCE_GLOBAL_INIT(libxlMigrationDstArgs) + +static void +libxlDoMigrateReceive(virNetSocketPtr sock, + int events ATTRIBUTE_UNUSED, + void *opaque) +{ + libxlMigrationDstArgs *args = opaque; + virConnectPtr conn = args->conn; + virDomainObjPtr vm = args->vm; + virNetSocketPtr *socks = args->socks; + size_t nsocks = args->nsocks; + bool paused = args->flags & VIR_MIGRATE_PAUSED; + libxlDriverPrivatePtr driver = conn->privateData; + virNetSocketPtr client_sock; + int recvfd = -1; + size_t i; + int ret; + + virNetSocketAccept(sock, &client_sock); + if (client_sock == NULL) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("Fail to accept migration connection")); + goto cleanup; + } + VIR_DEBUG("Accepted migration connection\n"); + recvfd = virNetSocketDupFD(client_sock, true); + virObjectUnref(client_sock); + + virObjectLock(vm); + ret = libxlDomainStart(driver, vm, paused, recvfd); + virObjectUnlock(vm); + + if (ret < 0 && !vm->persistent) + virDomainObjListRemove(driver->domains, vm); + + cleanup: + /* Remove all listen socks from event handler, and close them. */ + for (i = 0; i < nsocks; i++) { + virNetSocketUpdateIOCallback(socks[i], 0); + virNetSocketRemoveIOCallback(socks[i]); + virNetSocketClose(socks[i]); + virObjectUnref(socks[i]); + } + + VIR_FORCE_CLOSE(recvfd); +} + +static int +libxlDoMigrateSend(libxlDriverPrivatePtr driver, + virDomainObjPtr vm, + unsigned long flags, + int sockfd) +{ + libxlDomainObjPrivatePtr priv; + libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); + virObjectEventPtr event = NULL; + int xl_flags = 0; + int ret; + + if (flags & VIR_MIGRATE_LIVE) + xl_flags = LIBXL_SUSPEND_LIVE; + + priv = vm->privateData; + ret = libxl_domain_suspend(priv->ctx, vm->def->id, sockfd, + xl_flags, NULL); + if (ret != 0) { + /* attempt to resume the domain on failure */ + if (libxl_domain_resume(priv->ctx, vm->def->id, 0, 0) != 0) { + VIR_DEBUG("Failed to resume domain following failed migration"); + virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, + VIR_DOMAIN_PAUSED_MIGRATION); + event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_SUSPENDED, + VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED); + ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm)); + } + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("Failed to send migration data to destination host")); + ret = -1; + goto cleanup; + } + + cleanup: + if (event) + libxlDomainEventQueue(driver, event); + virObjectUnref(cfg); + return ret; +} + +static bool +libxlDomainMigrationIsAllowed(virDomainDefPtr def) +{ + /* Migration is not allowed if definition contains any hostdevs */ + if (def->nhostdevs > 0) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("domain has assigned host devices")); + return false; + } + + return true; +} + +char * +libxlDomainMigrationBegin(virConnectPtr conn, + virDomainObjPtr vm, + const char *xmlin) +{ + libxlDriverPrivatePtr driver = conn->privateData; + libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); + virDomainDefPtr tmpdef = NULL; + virDomainDefPtr def; + char *xml = NULL; + + if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0) + goto cleanup; + + if (xmlin) { + if (!(tmpdef = virDomainDefParseString(xmlin, cfg->caps, + driver->xmlopt, + 1 << VIR_DOMAIN_VIRT_XEN, + VIR_DOMAIN_XML_INACTIVE))) + goto endjob; + + def = tmpdef; + } else { + def = vm->def; + } + + if (!libxlDomainMigrationIsAllowed(def)) + goto endjob; + + xml = virDomainDefFormat(def, VIR_DOMAIN_XML_SECURE); + + cleanup: + if (vm) + virObjectUnlock(vm); + + virDomainDefFree(tmpdef); + virObjectUnref(cfg); + return xml; + + endjob: + if (!libxlDomainObjEndJob(driver, vm)) + vm = NULL; + goto cleanup; +} + +virDomainDefPtr +libxlDomainMigrationPrepareDef(libxlDriverPrivatePtr driver, + const char *dom_xml, + const char *dname) +{ + libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); + virDomainDefPtr def; + char *name = NULL; + + if (!dom_xml) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("no domain XML passed")); + return NULL; + } + + if (!(def = virDomainDefParseString(dom_xml, cfg->caps, driver->xmlopt, + 1 << VIR_DOMAIN_VIRT_XEN, + VIR_DOMAIN_XML_INACTIVE))) + goto cleanup; + + if (dname) { + name = def->name; + if (VIR_STRDUP(def->name, dname) < 0) { + virDomainDefFree(def); + def = NULL; + } + } + + cleanup: + virObjectUnref(cfg); + VIR_FREE(name); + return def; +} + +int +libxlDomainMigrationPrepare(virConnectPtr dconn, + virDomainDefPtr def, + const char *uri_in, + char **uri_out, + unsigned int flags) +{ + libxlDriverPrivatePtr driver = dconn->privateData; + virDomainObjPtr vm = NULL; + char *hostname = NULL; + unsigned short port; + char portstr[100]; + virURIPtr uri = NULL; + virNetSocketPtr *socks = NULL; + size_t nsocks = 0; + int nsocks_listen = 0; + libxlMigrationDstArgs *args; + size_t i; + int ret = -1; + + if (!(vm = virDomainObjListAdd(driver->domains, def, + driver->xmlopt, + VIR_DOMAIN_OBJ_LIST_ADD_LIVE | + VIR_DOMAIN_OBJ_LIST_ADD_CHECK_LIVE, + NULL))) + goto cleanup; + + /* Create socket connection to receive migration data */ + if (!uri_in) { + if ((hostname = virGetHostname()) == NULL) + goto cleanup; + + if (STRPREFIX(hostname, "localhost")) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("hostname on destination resolved to localhost," + " but migration requires an FQDN")); + goto cleanup; + } + + if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0) + goto cleanup; + + if (virAsprintf(uri_out, "tcp://%s:%d", hostname, port) < 0) + goto cleanup; + } else { + if (!(STRPREFIX(uri_in, "tcp://"))) { + /* not full URI, add prefix tcp:// */ + char *tmp; + if (virAsprintf(&tmp, "tcp://%s", uri_in) < 0) + goto cleanup; + uri = virURIParse(tmp); + VIR_FREE(tmp); + } else { + uri = virURIParse(uri_in); + } + + if (uri == NULL) { + virReportError(VIR_ERR_INVALID_ARG, + _("unable to parse URI: %s"), + uri_in); + goto cleanup; + } + + if (uri->server == NULL) { + virReportError(VIR_ERR_INVALID_ARG, + _("missing host in migration URI: %s"), + uri_in); + goto cleanup; + } else { + hostname = uri->server; + } + + if (uri->port == 0) { + if (virPortAllocatorAcquire(driver->migrationPorts, &port) < 0) + goto cleanup; + + } else { + port = uri->port; + } + + if (virAsprintf(uri_out, "tcp://%s:%d", hostname, port) < 0) + goto cleanup; + } + + snprintf(portstr, sizeof(portstr), "%d", port); + + if (virNetSocketNewListenTCP(hostname, portstr, &socks, &nsocks) < 0) { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("Fail to create socket for incoming migration")); + goto cleanup; + } + + if (libxlMigrationDstArgsInitialize() < 0) + goto cleanup; + + if (!(args = virObjectNew(libxlMigrationDstArgsClass))) + goto cleanup; + + args->conn = dconn; + args->vm = vm; + args->flags = flags; + args->socks = socks; + args->nsocks = nsocks; + + for (i = 0; i < nsocks; i++) { + if (virNetSocketSetBlocking(socks[i], true) < 0) + continue; + + if (virNetSocketListen(socks[i], 1) < 0) + continue; + + if (virNetSocketAddIOCallback(socks[i], + VIR_EVENT_HANDLE_READABLE, + libxlDoMigrateReceive, + args, + virObjectFreeCallback) < 0) + continue; + + /* + * Successfully added sock to event loop. Take a ref on args to + * ensure it is not freed until sock is removed from the event loop. + * Ref is dropped in virObjectFreeCallback after being removed + * from the event loop. + */ + virObjectRef(args); + nsocks_listen++; + } + + /* Done with args in this function, drop reference */ + virObjectUnref(args); + + if (!nsocks_listen) + goto cleanup; + + ret = 0; + goto done; + + cleanup: + for (i = 0; i < nsocks; i++) { + virNetSocketClose(socks[i]); + virObjectUnref(socks[i]); + } + + done: + virURIFree(uri); + if (vm) + virObjectUnlock(vm); + return ret; +} + +int +libxlDomainMigrationPerform(libxlDriverPrivatePtr driver, + virDomainObjPtr vm, + const char *dom_xml ATTRIBUTE_UNUSED, + const char *dconnuri ATTRIBUTE_UNUSED, + const char *uri_str, + const char *dname ATTRIBUTE_UNUSED, + unsigned int flags) +{ + char *hostname = NULL; + unsigned short port = 0; + char portstr[100]; + virURIPtr uri = NULL; + virNetSocketPtr sock; + int sockfd = -1; + int saved_errno = EINVAL; + int ret = -1; + + /* parse dst host:port from uri */ + uri = virURIParse(uri_str); + if (uri == NULL || uri->server == NULL || uri->port == 0) + goto cleanup; + + hostname = uri->server; + port = uri->port; + snprintf(portstr, sizeof(portstr), "%d", port); + + /* socket connect to dst host:port */ + if (virNetSocketNewConnectTCP(hostname, portstr, &sock) < 0) { + virReportSystemError(saved_errno, + _("unable to connect to '%s:%s'"), + hostname, portstr); + goto cleanup; + } + + if (virNetSocketSetBlocking(sock, true) < 0) { + virObjectUnref(sock); + goto cleanup; + } + + sockfd = virNetSocketDupFD(sock, true); + virObjectUnref(sock); + + /* suspend vm and send saved data to dst through socket fd */ + virObjectUnlock(vm); + ret = libxlDoMigrateSend(driver, vm, flags, sockfd); + virObjectLock(vm); + + cleanup: + /* If failure, terminate the job started in MigrationBegin */ + if (ret == -1) { + if (libxlDomainObjEndJob(driver, vm)) + virObjectUnlock(vm); + } + VIR_FORCE_CLOSE(sockfd); + virURIFree(uri); + return ret; +} + +virDomainPtr +libxlDomainMigrationFinish(virConnectPtr dconn, + virDomainObjPtr vm, + unsigned int flags, + int cancelled) +{ + libxlDriverPrivatePtr driver = dconn->privateData; + libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); + libxlDomainObjPrivatePtr priv = vm->privateData; + virObjectEventPtr event = NULL; + virDomainPtr dom = NULL; + + virPortAllocatorRelease(driver->migrationPorts, priv->migrationPort); + priv->migrationPort = 0; + + if (cancelled) + goto cleanup; + + if (!(flags & VIR_MIGRATE_PAUSED)) { + if (libxl_domain_unpause(priv->ctx, vm->def->id) != 0) { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", + _("Failed to unpause domain")); + goto cleanup; + } + + virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, + VIR_DOMAIN_RUNNING_MIGRATED); + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_RESUMED, + VIR_DOMAIN_EVENT_RESUMED_MIGRATED); + } else { + virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, VIR_DOMAIN_PAUSED_USER); + event = virDomainEventLifecycleNewFromObj(vm, + VIR_DOMAIN_EVENT_SUSPENDED, + VIR_DOMAIN_EVENT_SUSPENDED_PAUSED); + } + + if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm) < 0) + goto cleanup; + + dom = virGetDomain(dconn, vm->def->name, vm->def->uuid); + + if (dom == NULL) { + libxl_domain_destroy(priv->ctx, vm->def->id, NULL); + libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_FAILED); + event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, + VIR_DOMAIN_EVENT_STOPPED_FAILED); + libxlDomainEventQueue(driver, event); + } + + cleanup: + if (event) + libxlDomainEventQueue(driver, event); + if (vm) + virObjectUnlock(vm); + virObjectUnref(cfg); + return dom; +} + +int +libxlDomainMigrationConfirm(libxlDriverPrivatePtr driver, + virDomainObjPtr vm, + unsigned int flags, + int cancelled) +{ + libxlDriverConfigPtr cfg = libxlDriverConfigGet(driver); + libxlDomainObjPrivatePtr priv = vm->privateData; + virObjectEventPtr event = NULL; + int ret = -1; + + if (cancelled) { + if (libxl_domain_resume(priv->ctx, vm->def->id, 1, 0) == 0) { + ret = 0; + } else { + VIR_DEBUG("Unable to resume domain '%s' after failed migration", + vm->def->name); + virDomainObjSetState(vm, VIR_DOMAIN_PAUSED, + VIR_DOMAIN_PAUSED_MIGRATION); + event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_SUSPENDED, + VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED); + ignore_value(virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm)); + } + goto cleanup; + } + + libxl_domain_destroy(priv->ctx, vm->def->id, NULL); + libxlDomainCleanup(driver, vm, VIR_DOMAIN_SHUTOFF_MIGRATED); + event = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_STOPPED, + VIR_DOMAIN_EVENT_STOPPED_MIGRATED); + + VIR_DEBUG("Domain '%s' successfully migrated", vm->def->name); + + if (flags & VIR_MIGRATE_UNDEFINE_SOURCE) + virDomainDeleteConfig(cfg->configDir, cfg->autostartDir, vm); + + if (!vm->persistent || (flags & VIR_MIGRATE_UNDEFINE_SOURCE)) + virDomainObjListRemove(driver->domains, vm); + + ret = 0; + + cleanup: + if (!libxlDomainObjEndJob(driver, vm)) + vm = NULL; + if (event) + libxlDomainEventQueue(driver, event); + if (vm) + virObjectUnlock(vm); + virObjectUnref(cfg); + return ret; +} diff --git a/src/libxl/libxl_migration.h b/src/libxl/libxl_migration.h new file mode 100644 index 0000000..aab96f5 --- /dev/null +++ b/src/libxl/libxl_migration.h @@ -0,0 +1,79 @@ +/* + * libxl_migration.h: methods for handling migration with libxenlight + * + * Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library. If not, see + * <http://www.gnu.org/licenses/>. + * + * Authors: + * Jim Fehlig <jfehlig(a)suse.com> + */ + +#ifndef LIBXL_MIGRATION_H +# define LIBXL_MIGRATION_H + +# include "libxl_conf.h" + +# define LIBXL_MIGRATION_FLAGS \ + (VIR_MIGRATE_LIVE | \ + VIR_MIGRATE_UNDEFINE_SOURCE | \ + VIR_MIGRATE_PAUSED) + +/* All supported migration parameters and their types. */ +# define LIBXL_MIGRATION_PARAMETERS \ + VIR_MIGRATE_PARAM_URI, VIR_TYPED_PARAM_STRING, \ + VIR_MIGRATE_PARAM_DEST_NAME, VIR_TYPED_PARAM_STRING, \ + VIR_MIGRATE_PARAM_DEST_XML, VIR_TYPED_PARAM_STRING, \ + NULL + +char * +libxlDomainMigrationBegin(virConnectPtr conn, + virDomainObjPtr vm, + const char *xmlin); + +virDomainDefPtr +libxlDomainMigrationPrepareDef(libxlDriverPrivatePtr driver, + const char *dom_xml, + const char *dname); + +int +libxlDomainMigrationPrepare(virConnectPtr dconn, + virDomainDefPtr def, + const char *uri_in, + char **uri_out, + unsigned int flags); + +int +libxlDomainMigrationPerform(libxlDriverPrivatePtr driver, + virDomainObjPtr vm, + const char *dom_xml, + const char *dconnuri, + const char *uri_str, + const char *dname, + unsigned int flags); + +virDomainPtr +libxlDomainMigrationFinish(virConnectPtr dconn, + virDomainObjPtr vm, + unsigned int flags, + int cancelled); + +int +libxlDomainMigrationConfirm(libxlDriverPrivatePtr driver, + virDomainObjPtr vm, + unsigned int flags, + int cancelled); + +#endif /* LIBXL_DRIVER_H */ -- 1.8.1.4

2 3

[libvirt] [PATCH] cfg.mk: Introduce rule for setlocale()
by Michal Privoznik 04 Jun '14

04 Jun '14

In the past we had some issues where setlocale() was called without corresponding include of locale.h. While on some systems this may work, on others the compilation failed. We should have a syntax-check rule for that to prevent this from happening again. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- cfg.mk | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/cfg.mk b/cfg.mk index 9e8fcec..36395c6 100644 --- a/cfg.mk +++ b/cfg.mk @@ -929,6 +929,15 @@ sc_prohibit_mixed_case_abbreviations: halt='Use PCI, USB, SCSI, not Pci, Usb, Scsi' \ $(_sc_search_regexp) +# Require #include <locale.h> in all files that call setlocale() +sc_require_locale_h: + @for i in $$($(VC_LIST_EXCEPT) | grep '\.[chx]$$'); do \ + if test -z "$$(grep setlocale $$i)" ; then continue; fi; \ + if test -z "$$(grep 'include <locale.h>' $$i)" ; then \ + echo '$(ME): missing locale.h include in' $$i 1>&2; exit 1; \ + fi; \ + done; + # We don't use this feature of maint.mk. prev_version_file = /dev/null -- 2.0.0

3 4

[libvirt] Parse commandline for -device option
by Hong-Hua.Yin＠freescale.com 04 Jun '14

04 Jun '14

Hi Maintainers, Currently libvirt could only parse commandline for several legacy devices. For example, -pcidevice: qemuParseCommandLinePCI() -usbdevice: qemuParseCommandLineUSB() It also provides test cases for host device assignment. DO_TEST("hostdev-usb-address"); DO_TEST("hostdev-pci-address"); But for other hostdev with -device option, it failed to convert into <hostdev> tag. -device vfio-pci,host=06:12.5,id=hostdev0,bus=pci.0,addr=0x3 $ virsh domxml-from-native qemu-argv kvm.args >kvm.xml <qemu:commandline> <qemu:arg value='-device'/> <qemu:arg value='vfio-pci,host=06:12.5,id=hostdev0,bus=pci.0,addr=0x3'/> </qemu:commandline> Expected XML file should like below: <hostdev mode='subsystem' type='pci' managed='yes'> <driver name='vfio'/> <source> <address domain='0x0000' bus='0x06' slot='0x12' function='0x5'/> </source> </hostdev> Maybe it is not very critical. Is it complicated to add support to -device option in function qemuParseCommandLine()? Do you have any thought or plan about it? Best Regards, Olivia

3 2

[libvirt] Problem connecting to hypervisor.
by Vikas Kokare 04 Jun '14

04 Jun '14

I am trying to establish a connection (using virsh command) to a couple of hypervisor hosts, both on SLES 11.3 environments. The host from where i am making both the connections is a SLES 10.4 instance. *kvmh911351246:~ # virsh -c qemu+ssh://9.113.51.247:22/system <http://9.113.51.247:22/system>libvir: XML-RPC error : authentication requirederror: failed to connect to the hypervisor* The SSH authentication to hypervisor host 9.113.51.247 has already been established. *kvmh911351246:~ # ssh root(a)9.113.51.247 <root(a)9.113.51.247>Last login: Tue Jun 3 11:31:56 2014 from scm-kvmh2-rhel6 SLES11-51-247:~ #* Hence the cause of the authentication failure is not clear. The second connection to another SLES 11.3 host looks like *virsh # connect qemu+ssh://9.121.58.19:22/system <http://9.121.58.19:22/system> bash: socat: command not foundlibvir: Remote error : socket closed unexpectedlyerror: Failed to connect to the hypervisor* where the cause of the error is entirely different. The libvirt packages available on these environments are *9.113.51.247 (SLES 11.3)* *libvirt-cim-0.5.12-0.7.16libvirt-1.0.5.1-0.7.10libvirt-python-1.0.5.1-0.7.10libvirt-client-32bit-1.0.5.1-0.7.10 libvirt-lock-sanlock-1.0.5.1-0.7.10libvirt-client-1.0.5.1-0.7.10* *9.121.58.19 (SLES 11.3)* *libvirt-cim-0.5.12-0.7.16libvirt-client-1.0.5.1-0.7.10libvirt-python-1.0.5.1-0.7.10 libvirt-1.0.5.1-0.7.10* *9.113.51.246 ( SLES 10.4)* *libvirt-python-0.3.3-18.22.1libvirt-devel-0.3.3-18.22.1libvirt-0.3.3-18.22.1* How can these connection failures be debugged? Is there a way to know more information about them?

2 1

[libvirt] [PATCH] virnuma: Check for numa_bitmask_isbitset presence
by Michal Privoznik 04 Jun '14

04 Jun '14

On some systems, libnuma can be present but it's so ancient that it misses some symbols that virNumaGetDistances() needs. To be more precise: numa_bitmask_isbitset() and numa_nodes_ptr are the symbols in question. Fortunately, they were both introduced in the same release so it's sufficient for us to check for only one of them. And the winner is numa_bitmask_isbitset(). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Notes: While this is a build breaker, it's not that critical. Come on - who runs libvirt from git on stable enterprise systems? I'm sending it to know if the check for numa_bitmask_isbitset() is in the right place or should be moved to a different file. m4/virt-numactl.m4 | 4 ++ src/util/virnuma.c | 135 +++++++++++++++++++++++++++-------------------------- 2 files changed, 73 insertions(+), 66 deletions(-) diff --git a/m4/virt-numactl.m4 b/m4/virt-numactl.m4 index 1dcb029..fa66d24 100644 --- a/m4/virt-numactl.m4 +++ b/m4/virt-numactl.m4 @@ -19,6 +19,10 @@ dnl AC_DEFUN([LIBVIRT_CHECK_NUMACTL],[ LIBVIRT_CHECK_LIB([NUMACTL], [numa], [numa_available], [numa.h]) + AC_CHECK_LIB([numa], [numa_bitmask_isbitset], [have_numa_bitmask_isbitset=yes]) + if test "$have_numa_bitmask_isbitset" = "yes"; then + AC_DEFINE_UNQUOTED([HAVE_NUMA_BITMASK_ISBITSET], 1, [whether numa_bitmask_isbitset is available]) + fi ]) AC_DEFUN([LIBVIRT_RESULT_NUMACTL],[ diff --git a/src/util/virnuma.c b/src/util/virnuma.c index 042844b..f979f49 100644 --- a/src/util/virnuma.c +++ b/src/util/virnuma.c @@ -217,61 +217,6 @@ virNumaGetMaxNode(void) /** - * virNumaGetDistances: - * @node: identifier of the requested NUMA node - * @distances: array of distances to sibling nodes - * @ndistances: size of @distances - * - * Get array of distances to sibling nodes from @node. If a - * distances[x] equals to zero, the node x is not enabled or - * doesn't exist. As a special case, if @node itself refers to - * disabled or nonexistent NUMA node, then @distances and - * @ndistances are set to NULL and zero respectively. - * - * The distances are a bit of magic. For a local node the value - * is 10, for remote it's typically 20 meaning that time penalty - * for accessing a remote node is two time bigger than when - * accessing a local node. - * - * Returns 0 on success, -1 otherwise. - */ -int -virNumaGetDistances(int node, - int **distances, - int *ndistances) -{ - int ret = -1; - int max_node; - size_t i; - - if (!numa_bitmask_isbitset(numa_nodes_ptr, node)) { - VIR_DEBUG("Node %d does not exist", node); - *distances = NULL; - *ndistances = 0; - return 0; - } - - if ((max_node = virNumaGetMaxNode()) < 0) - goto cleanup; - - if (VIR_ALLOC_N(*distances, max_node) < 0) - goto cleanup; - - *ndistances = max_node + 1; - - for (i = 0; i<= max_node; i++) { - if (!numa_bitmask_isbitset(numa_nodes_ptr, i)) - continue; - - (*distances)[i] = numa_distance(node, i); - } - - ret = 0; - cleanup: - return ret; -} - -/** * virNumaGetNodeMemory: * @node: identifier of the requested NUMA node * @memsize: returns the total size of memory in the NUMA node @@ -443,17 +388,6 @@ virNumaGetNodeCPUs(int node ATTRIBUTE_UNUSED, _("NUMA isn't available on this host")); return -1; } - -int -virNumaGetDistances(int node ATTRIBUTE_UNUSED, - int **distances, - int *ndistances) -{ - *distances = NULL; - *ndistances = 0; - VIR_DEBUG("NUMA isn't available on this host"); - return 0; -} #endif @@ -469,3 +403,72 @@ virNumaGetMaxCPUs(void) { return NUMA_MAX_N_CPUS; } + + +#ifdef HAVE_NUMA_BITMASK_ISBITSET +/** + * virNumaGetDistances: + * @node: identifier of the requested NUMA node + * @distances: array of distances to sibling nodes + * @ndistances: size of @distances + * + * Get array of distances to sibling nodes from @node. If a + * distances[x] equals to zero, the node x is not enabled or + * doesn't exist. As a special case, if @node itself refers to + * disabled or nonexistent NUMA node, then @distances and + * @ndistances are set to NULL and zero respectively. + * + * The distances are a bit of magic. For a local node the value + * is 10, for remote it's typically 20 meaning that time penalty + * for accessing a remote node is two time bigger than when + * accessing a local node. + * + * Returns 0 on success, -1 otherwise. + */ +int +virNumaGetDistances(int node, + int **distances, + int *ndistances) +{ + int ret = -1; + int max_node; + size_t i; + + if (!numa_bitmask_isbitset(numa_nodes_ptr, node)) { + VIR_DEBUG("Node %d does not exist", node); + *distances = NULL; + *ndistances = 0; + return 0; + } + + if ((max_node = virNumaGetMaxNode()) < 0) + goto cleanup; + + if (VIR_ALLOC_N(*distances, max_node) < 0) + goto cleanup; + + *ndistances = max_node + 1; + + for (i = 0; i<= max_node; i++) { + if (!numa_bitmask_isbitset(numa_nodes_ptr, i)) + continue; + + (*distances)[i] = numa_distance(node, i); + } + + ret = 0; + cleanup: + return ret; +} +#else +int +virNumaGetDistances(int node ATTRIBUTE_UNUSED, + int **distances, + int *ndistances) +{ + *distances = NULL; + *ndistances = 0; + VIR_DEBUG("NUMA isn't available on this host"); + return 0; +} +#endif -- 2.0.0

2 1

[libvirt] [RFC] Atomic Operations
by Tucker DiNapoli 04 Jun '14

04 Jun '14

I'm working on job control which involves a lot of locking and unlocking, often for operations that could be done atomically. I use the existing atomic integer operations in viratomic.h where possible, but there are a lot of parameters involved in jobs (such as time, thread id's, progress information, etc) which don't fit in an integer. I have several ideas of ways to update the existing integer atomic operations to support more types. The easiest way (at least regarding code) would be to use an existing atomic operations library. My suggestion would be the libatomic_ops library, which is licensed under an MIT style license and could be added to the source tree as a git submodule (similar to the way gnulib is) or a specific version could be used and the library source itself added to the git repository. The library can be found at https://github.com/ivmai/libatomic_ops/ . The other way of augmenting atomic operations would be to extend the existing viratomic.h file to support additional types. Personally I have experience working with GCC atomic operations and could implement that myself, but I wouldn't be able to implement the windows versions. Again I think the easiest and most maintainable way of supporting atomic operations is via an external library, but I am not sure of the feasibility of adding another dependency to libvirt. In general atomic operations are an optimization, but they can help make multithreaded programming easier and I think libvirt would be enhanced by having more comprehensive support for atomic operations. Tucker DiNapoli

3 2

[libvirt] [libvirt-sandbox] virt-sandbox-service: fixed /lib/ into /usr/lib for searching unit files
by Cédric Bosdonnat 04 Jun '14

04 Jun '14

--- bin/virt-sandbox-service | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/virt-sandbox-service b/bin/virt-sandbox-service index 2dcbfb8..9ed37e0 100755 --- a/bin/virt-sandbox-service +++ b/bin/virt-sandbox-service @@ -1071,7 +1071,7 @@ class CheckUnit(argparse.Action): src = "/etc/systemd/system/" + unit if os.path.exists(src): return src - src = "/lib/systemd/system/" + unit + src = "/usr/lib/systemd/system/" + unit if os.path.exists(src): return src return None -- 1.8.4.5

4 7

[libvirt] [PATCH] virnuma: Implement virNumaGetDistances stub for non-NUMA
by Michal Privoznik 04 Jun '14

04 Jun '14

In case the libvirt is built without numactl support, we're missing the virNumaGetDistances() stub so the linking fails: CCLD libvirt_lxc libvirt_lxc-nodeinfo.o: In function `virNodeCapsGetSiblingInfo': /home/zippy/tmp/libvirt.git/src/nodeinfo.c:1763: undefined reference to `virNumaGetDistances' collect2: error: ld returned 1 exit status make[3]: *** [libvirt_lxc] Error 1 The issue was introduced in 77c830d8c4. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Notes: Pushing under build-breaker and trivial rules. src/util/virnuma.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/util/virnuma.c b/src/util/virnuma.c index e8ceec8..042844b 100644 --- a/src/util/virnuma.c +++ b/src/util/virnuma.c @@ -443,6 +443,17 @@ virNumaGetNodeCPUs(int node ATTRIBUTE_UNUSED, _("NUMA isn't available on this host")); return -1; } + +int +virNumaGetDistances(int node ATTRIBUTE_UNUSED, + int **distances, + int *ndistances) +{ + *distances = NULL; + *ndistances = 0; + VIR_DEBUG("NUMA isn't available on this host"); + return 0; +} #endif -- 2.0.0

1 0

[libvirt] [libvirt-glib] spec: Move .vapi files to -devel RPMs
by Christophe Fergeau 04 Jun '14

04 Jun '14

.vapi files are only needed when building vala programs using libvirt-glib, so they belong to the -devel RPMs, not to the non-devel RPMs which only hold files needed at runtime. --- libvirt-glib.spec.in | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libvirt-glib.spec.in b/libvirt-glib.spec.in index f467767..202e624 100644 --- a/libvirt-glib.spec.in +++ b/libvirt-glib.spec.in @@ -162,28 +162,18 @@ rm -rf $RPM_BUILD_ROOT %if %{with_introspection} %{_libdir}/girepository-1.0/LibvirtGLib-1.0.typelib %endif -%if %{with_vala} -%{_datadir}/vala/vapi/libvirt-glib-1.0.vapi -%endif %files -n libvirt-gconfig %{_libdir}/libvirt-gconfig-1.0.so.* %if %{with_introspection} %{_libdir}/girepository-1.0/LibvirtGConfig-1.0.typelib %endif -%if %{with_vala} -%{_datadir}/vala/vapi/libvirt-gconfig-1.0.vapi -%endif %files -n libvirt-gobject %{_libdir}/libvirt-gobject-1.0.so.* %if %{with_introspection} %{_libdir}/girepository-1.0/LibvirtGObject-1.0.typelib %endif -%if %{with_vala} -%{_datadir}/vala/vapi/libvirt-gobject-1.0.deps -%{_datadir}/vala/vapi/libvirt-gobject-1.0.vapi -%endif %files devel %defattr(-,root,root,-) @@ -198,6 +188,9 @@ rm -rf $RPM_BUILD_ROOT %{_datadir}/gir-1.0/LibvirtGLib-1.0.gir %endif %{_datadir}/gtk-doc/html/Libvirt-glib +%if %{with_vala} +%{_datadir}/vala/vapi/libvirt-glib-1.0.vapi +%endif %files -n libvirt-gconfig-devel %defattr(-,root,root,-) @@ -212,6 +205,9 @@ rm -rf $RPM_BUILD_ROOT %{_datadir}/gir-1.0/LibvirtGConfig-1.0.gir %endif %{_datadir}/gtk-doc/html/Libvirt-gconfig +%if %{with_vala} +%{_datadir}/vala/vapi/libvirt-gconfig-1.0.vapi +%endif %files -n libvirt-gobject-devel %defattr(-,root,root,-) @@ -226,6 +222,10 @@ rm -rf $RPM_BUILD_ROOT %{_datadir}/gir-1.0/LibvirtGObject-1.0.gir %endif %{_datadir}/gtk-doc/html/Libvirt-gobject +%if %{with_vala} +%{_datadir}/vala/vapi/libvirt-gobject-1.0.deps +%{_datadir}/vala/vapi/libvirt-gobject-1.0.vapi +%endif %if %{with_python} %files python -- 1.9.3

2 2

[libvirt] [PATCH] build: fix race in vapi/ subdirectory
by Michael Catanzaro 04 Jun '14

04 Jun '14

libvirt-gobject-1.0.vapi depends on libvirt-gconfig-1.0.vapi --- vapi/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vapi/Makefile.am b/vapi/Makefile.am index 0154104..af10e98 100644 --- a/vapi/Makefile.am +++ b/vapi/Makefile.am @@ -17,7 +17,7 @@ libvirt-glib-1.0.vapi: $(top_builddir)/libvirt-glib/LibvirtGLib-1.0.gir --library libvirt-glib-1.0 \ $< -libvirt-gobject-1.0.vapi: $(top_builddir)/libvirt-gobject/LibvirtGObject-1.0.gir libvirt-glib-1.0.vapi +libvirt-gobject-1.0.vapi: $(top_builddir)/libvirt-gobject/LibvirtGObject-1.0.gir libvirt-glib-1.0.vapi libvirt-gconfig-1.0.vapi $(AM_V_GEN)$(VAPIGEN) \ --vapidir=$(builddir) \ --pkg gobject-2.0 \ -- 1.9.3

3 6

[libvirt] [PATCH v2 0/4] Testing libvirt XML -> libxl_domain_config conversion
by Daniel P. Berrange 03 Jun '14

03 Jun '14

Version 2 of: https://www.redhat.com/archives/libvir-list/2014-May/msg01102.html This tests the conversion of libvirt XML to libxl_domain_config objects by the libvirt libxl driver. Changed in v2: - Compare the parsed JSON object model instead of strcmp() on the string-ified JSON document - To cope with new additions between Xen 4.3 and 4.4 - Ignore case where actual JSON object has gained new keys. This copes with fact that '/c_info' gained a new key called 'pvh' in 4.4 - Ignore case where actual JSON value has changed from 'null' to a non-'null' value type. This copes with fact that the element at /b_info/device_model_version changed from 'null' to a specific value by default in 4.4. - Use libxl_domain_config_to_json instead of libxl_json.h functions, and disable test if running on Xen version which lacks this function (eg 4.2) - Isolate VNC port allocator from host TCP ports so a predictable VNC port is always in the config. Daniel P. Berrange (4): util: Introduce virJSONStringCompare for JSON doc comparisons util: Allow port allocator to skip bind() check tests: Add more test suite mock helpers libxl: Add a test suite for libxl option generator configure.ac | 2 + src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 3 +- src/qemu/qemu_driver.c | 9 +- src/util/virjson.c | 185 ++++++++++++++++++++++++++++++++++ src/util/virjson.h | 22 +++++ src/util/virportallocator.c | 14 ++- src/util/virportallocator.h | 7 +- tests/Makefile.am | 25 ++++- tests/libxlxml2jsondata/minimal.json | 172 ++++++++++++++++++++++++++++++++ tests/libxlxml2jsondata/minimal.xml | 36 +++++++ tests/libxlxml2jsontest.c | 186 +++++++++++++++++++++++++++++++++++ tests/virfirewalltest.c | 4 +- tests/virmock.h | 54 +++++++--- tests/virmocklibxl.c | 87 ++++++++++++++++ tests/virportallocatortest.c | 4 +- tests/virsystemdtest.c | 4 +- 17 files changed, 786 insertions(+), 29 deletions(-) create mode 100644 tests/libxlxml2jsondata/minimal.json create mode 100644 tests/libxlxml2jsondata/minimal.xml create mode 100644 tests/libxlxml2jsontest.c create mode 100644 tests/virmocklibxl.c -- 1.9.3

2 8

[libvirt] [PATCH v2 0/2] Expose distance between host NUMA nodes
by Michal Privoznik 03 Jun '14

03 Jun '14

diff to v1: -slight change in the XML format -added description to distances value Michal Privoznik (2): virnuma: Introduce virNumaGetDistances virCaps: Expose distance between host NUMA nodes docs/schemas/capability.rng | 15 +++++++++++ src/conf/capabilities.c | 19 +++++++++++++- src/conf/capabilities.h | 13 +++++++++- src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 4 +-- src/nodeinfo.c | 61 ++++++++++++++++++++++++++++++++++++++++++--- src/test/test_driver.c | 2 +- src/util/virnuma.c | 55 ++++++++++++++++++++++++++++++++++++++++ src/util/virnuma.h | 3 +++ src/xen/xend_internal.c | 3 ++- tests/vircapstest.c | 4 +-- 11 files changed, 169 insertions(+), 11 deletions(-) -- 2.0.0

2 4

[libvirt] [PATCH] tests: monitor: json: Fix error message when returning json in json
by Peter Krempa 03 Jun '14

03 Jun '14

The qemu JSON monitor test allows to test also expected command arguments. As the error from the monitor simulator is returned as a simulated qemu error (in JSON) all other JSON contained in the error message needs to be escaped. This will happen if the monitor command under test receives a JSON array as an argument. This will improve the error message from: libvirt: error : internal error: cannot parse json { "error": { "desc": "Invalid value of argument 'keys' of command 'send-key': expected 'ble' got '[{"type":"number","data":43},{"type":"number","data":26}, {"type":"number","data":46},{"type":"number","data":32}]'", "class": "UnexpectedCommand" } }: lexical error: invalid string in json text. To: libvirt: QEMU Driver error : internal error: unable to execute QEMU command 'send-key': Invalid value of argument 'keys' of command 'send-key': expected 'ble' got '[{"type":"number","data":43}, {"type":"number","data":26},{"type":"number","data":46}, {"type":"number","data":32}]' This improvement will not have any effect on tests executing as expected, but it will help test development. --- tests/qemumonitortestutils.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/qemumonitortestutils.c b/tests/qemumonitortestutils.c index 30c2153..8155a69 100644 --- a/tests/qemumonitortestutils.c +++ b/tests/qemumonitortestutils.c @@ -145,6 +145,12 @@ qemuMonitorReportError(qemuMonitorTestPtr test, const char *errmsg, ...) goto cleanup; if (test->agent || test->json) { + char *tmp = msg; + msg = qemuMonitorEscapeArg(tmp); + VIR_FREE(tmp); + if (!msg) + goto cleanup; + if (virAsprintf(&jsonmsg, "{ \"error\": " " { \"desc\": \"%s\", " " \"class\": \"UnexpectedCommand\" } }", -- 1.9.3

2 2

[libvirt] parallels: add 2 functions needed by OpenStack
by Alexander Burluka 03 Jun '14

03 Jun '14

Hello, I would like to apologize my for my inattention, that led to unformatted subjects. I'll try to prevent this in the future. -- Regards, Alexander Burluka

2 5

Re: [libvirt] [PATCH 1/2] Parallels: add domainGetVcpus().
by Daniel P. Berrange 03 Jun '14

03 Jun '14

Re-adding the mailing list - please don't drop the list CC when replying. On Mon, Jun 02, 2014 at 09:22:35PM +0400, aburluka wrote: > >Hmm, what error did you get from openstack ? The two uses of the > >'dom.vcpus' function are both wrapped in try/except so that it is > >considered non-fatal if libvirt doesn't provide this. > I have caught this error on Havana release. I would try to reproduce > this error, but it will take some short time to test it on Icehouse. Ok, then I think you should find the lack of this API is non-fatal in Icehouse / Juno now. > >Are you talking about container based virt here or full machine > >based virt ? IIUC Parallels can do both ? With container based > >virt, does parallels have the concept of 'vcpus' at all ? We > >don't have that in LXC at least. > Parallels Cloud Server has that concept in both types of virt. With the full machine virt does Parallels have a separate process or thread for each vCPU, and if so can we identify the PIDs for the vCPUs to let us do proper pCPU<->vCPU mapping & reporting. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

2 2

[libvirt] [PATCH 0/3] Expose distance between host NUMA nodes
by Michal Privoznik 03 Jun '14

03 Jun '14

*** BLURB HERE *** Michal Privoznik (3): virnuma.c: Fix some comments virnuma: Introduce virNumaGetDistances virCaps: Expose distance between host NUMA nodes docs/schemas/capability.rng | 11 ++++++++ src/conf/capabilities.c | 13 +++++++++- src/conf/capabilities.h | 13 +++++++++- src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 4 +-- src/nodeinfo.c | 61 ++++++++++++++++++++++++++++++++++++++++++--- src/test/test_driver.c | 2 +- src/util/virnuma.c | 54 +++++++++++++++++++++++++++++++++++++-- src/util/virnuma.h | 3 +++ src/xen/xend_internal.c | 3 ++- tests/vircapstest.c | 4 +-- 11 files changed, 156 insertions(+), 13 deletions(-) -- 2.0.0

2 8

[libvirt] [PATCH] network: bridge: Avoid memory leak from networkBuildDhcpDaemonCommandLine
by Peter Krempa 03 Jun '14

03 Jun '14

If the leasehelper_path couldn't be found the code would leak the freshly constructed command structure. Re-arrange code to avoid the problem. Found by coverity, broken by baafe668fa56767c031468ccd5df3e62eaa11370. --- src/network/bridge_driver.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 51f01fb..4fc4c9a 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1273,15 +1273,14 @@ networkBuildDhcpDaemonCommandLine(virNetworkObjPtr network, goto cleanup; } - cmd = virCommandNew(dnsmasqCapsGetBinaryPath(caps)); - virCommandAddArgFormat(cmd, "--conf-file=%s", configfile); - /* This helper is used to create custom leases file for libvirt */ if (!(leaseshelper_path = virFileFindResource("libvirt_leaseshelper", "src", LIBEXECDIR))) goto cleanup; + cmd = virCommandNew(dnsmasqCapsGetBinaryPath(caps)); + virCommandAddArgFormat(cmd, "--conf-file=%s", configfile); virCommandAddArgFormat(cmd, "--dhcp-script=%s", leaseshelper_path); *cmdout = cmd; -- 1.9.3

2 2

[libvirt] [PATCH] qemu: monitor: Fix type of holdtime argument in qemuMonitorJSONSendKey
by Peter Krempa 03 Jun '14

03 Jun '14

qemuMonitorJSONSendKey declares the "holdtime" argument as unsigned int while the command was constructed in qemuMonitorJSONMakeCommand using the "P" modifier which took a unsigned long from the variable arguments which then made it possible to access uninitialized memory. This broke the qemumonitorjsontest on 32bit fedora 20: 64) qemuMonitorJSONSendKey ... libvirt: QEMU Driver error : internal error: unsupported data type 'W' for arg 'WVSì D$0èwÿÿÃAå' FAILED Uncovered by upstream commit f744b831c66d9e82453f7a96cab5eddf7570c253. Additionally add test for the hold-time option. --- src/qemu/qemu_monitor_json.c | 2 +- tests/qemumonitorjsontest.c | 33 +++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 0c44b11..bedd959 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -3610,7 +3610,7 @@ int qemuMonitorJSONSendKey(qemuMonitorPtr mon, cmd = qemuMonitorJSONMakeCommand("send-key", "a:keys", keys, - "P:hold-time", holdtime, + "p:hold-time", holdtime, NULL); if (!cmd) goto cleanup; diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 47d7481..2099dc8 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -1960,6 +1960,38 @@ testQemuMonitorJSONqemuMonitorJSONSendKey(const void *data) } static int +testQemuMonitorJSONqemuMonitorJSONSendKeyHoldtime(const void *data) +{ + virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data; + qemuMonitorTestPtr test = qemuMonitorTestNewSimple(true, xmlopt); + int ret = -1; + unsigned int keycodes[] = {43, 26, 46, 32}; + + if (!test) + return -1; + + if (qemuMonitorTestAddItemParams(test, "send-key", + "{\"return\":{}}", + "hold-time", "31337", + "keys", "[{\"type\":\"number\",\"data\":43}," + "{\"type\":\"number\",\"data\":26}," + "{\"type\":\"number\",\"data\":46}," + "{\"type\":\"number\",\"data\":32}]", + NULL, NULL) < 0) + goto cleanup; + + if (qemuMonitorJSONSendKey(qemuMonitorTestGetMonitor(test), + 31337, keycodes, + ARRAY_CARDINALITY(keycodes)) < 0) + goto cleanup; + + ret = 0; + cleanup: + qemuMonitorTestFree(test); + return ret; +} + +static int testQemuMonitorJSONqemuMonitorJSONGetDumpGuestMemoryCapability(const void *data) { virDomainXMLOptionPtr xmlopt = (virDomainXMLOptionPtr)data; @@ -2230,6 +2262,7 @@ mymain(void) DO_TEST(qemuMonitorJSONGetVirtType); DO_TEST(qemuMonitorJSONSendKey); DO_TEST(qemuMonitorJSONGetDumpGuestMemoryCapability); + DO_TEST(qemuMonitorJSONSendKeyHoldtime); DO_TEST_CPU_DATA("host"); DO_TEST_CPU_DATA("full"); -- 1.9.3

2 2

[libvirt] [PATCH] tests: Build virstoragetest only when storage driver is compiled too
by Peter Krempa 03 Jun '14

03 Jun '14

virstoragetest now requires parts of the storage driver to be built. Without this change the test can't be compiled on platforms that don't build the storage driver (mingw). make[2]: *** No rule to make target `../src/libvirt_driver_storage_impl.la', needed by `virstoragetest.exe'. Stop. Broken by commit 713cc3b0a7ff8ad42b4c13429b624d1b2b5a99f2 --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index f9f2b84..1fdfd3b 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -162,7 +162,6 @@ test_programs = virshtest sockettest \ virstringtest \ virportallocatortest \ sysinfotest \ - virstoragetest \ virnetdevbandwidthtest \ virkmodtest \ vircapstest \ @@ -279,7 +278,8 @@ test_programs += nwfilterxml2firewalltest endif WITH_NWFILTER if WITH_STORAGE -test_programs += storagevolxml2argvtest +test_programs += storagevolxml2argvtest \ + virstoragetest endif WITH_STORAGE if WITH_LINUX -- 1.9.3

2 2

[libvirt] Idea for representing VMX virtualHW.version in domain XML
by Daniel P. Berrange 03 Jun '14

03 Jun '14

At the Xen Hackathon we were discussing dealing hypervisors which have a "virtual hardware version" concept, like VMWares' virtualHW.version. Currently our code mostly ignores the virtualHW.version when reading VMX files, and when writing them, just uses the hypervisor's default virtual hardware version. This is sub-optimal since that means the guest's hardware version could change if the hypervisor is upgraded, which could in turn cause Windows re-activation. It was suggested to me that the virtualHW.version is really akin to QEMU's machine type concept, and so we should map it that way in the XML. eg if the VMX file contains virtualHW.version = "4" Then we might represent that in the XML as <domain type='vmware'> ... <os> <type machine="vmware4">hvm</type> </os> ... </domain> ie we just invent a machine type prefix and append the version number to it. I'm not planning on implementing this myself, just sending this mail so the idea is in the historical record and some other motivated person can wire it up.... Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH 0/5] Testing libvirt XML -> libxl_domain_config conversion
by Daniel P. Berrange 03 Jun '14

03 Jun '14

At the Xen Hackathon I learnt that libxl provides an API which can serialize a libxl_domain_config instance to a JSON document. This is exactly what we need for testing the XML -> libxl_domain_config conversion process, so I spent the afternoon trying to get such a test working. The result is that we can now just add pairs of XML, JSON files to libvirt to test handling of new config features. I hit a couple of small issues with libxl, which I worked around, when writing this test which I why I'm copying xen-devel - libxl_ctx_alloc() will call xs_daemon_open and xc_interface_open, and stat /var/run/xenstored.pid to see if Xen is actually running. This fails when run on non-Xen hosts (and also possibly if run unprivileged). I used an evil LD_PRELOAD hack to stub out xs_daemon_open and xc_interface_open to return (void*)0x1, and also turn xc_interface_close and xs_daemon_close to no-ops, and make stat() always return success for xenstored.pid. This works (evidenced by the fact that if something was needing these xs/xc handles they would have crashed referencing 0x1), but at the same time it might be an idea to have an officially supported "non live" mode for libxl_ctx_alloc() turned on by a flag of some sort. - The libxl_json.h header file is relying on conditionals that are only set by Xen's build process eg HAVE_YAJL_YAJL_VERSION_H I hacked around this, but it is a little dirty too. libvirt already links to libyajl for the QEMU driver, but we don't really need the raw YAJL objects. It'd be nice to have a char * libxl_domain_config_as_json(libxl_domain_config *p) as a higher level wrapper around libxl_domain_config_gen_json avoiding the pain of dealing with YAJL's different APIs. Ian J mentioned to me that he thought there was already such a method, but AFAICT, the only such code is in the 'xl' command line tool itself (xl_cmdimpl.c - printf_info_one_json) A few further ideas that could be done as a followup - Make virConnectDomainXMLToNative accept 'xl-json" as a data format, so you can feed in a libvirt XML and get back out a JSON document. This could be a useful debugging tool for Xen developers trying to identify bugs in libvirt. - Write out the JSON document to /var/log/libvirt/libxl/$GUEST.log whenever starting a guest. Again this would be a useful debugging aid to Xen developers / support people trying to identify why a guest might be mis-behaving Regards, Daniel Daniel P. Berrange (5): Don't pass virDomainObjPtr to libxlBuildDomainConfig Don't pass libxlDriverPrivatePtr into libxlBuildDomainConfig libxl: Move virDomainXMLOptionNew into libxlCreateXMLConf Add more test suite mock helpers Add a test suite for libxl option generator src/libxl/libxl_conf.c | 38 +++--- src/libxl/libxl_conf.h | 10 +- src/libxl/libxl_domain.c | 7 +- src/libxl/libxl_driver.c | 4 +- tests/Makefile.am | 25 +++- tests/libxlxml2jsondata/minimal.json | 172 +++++++++++++++++++++++++++ tests/libxlxml2jsondata/minimal.xml | 36 ++++++ tests/libxlxml2jsontest.c | 219 +++++++++++++++++++++++++++++++++++ tests/virfirewalltest.c | 4 +- tests/virmock.h | 54 ++++++--- tests/virmocklibxl.c | 87 ++++++++++++++ tests/virsystemdtest.c | 4 +- 12 files changed, 617 insertions(+), 43 deletions(-) create mode 100644 tests/libxlxml2jsondata/minimal.json create mode 100644 tests/libxlxml2jsondata/minimal.xml create mode 100644 tests/libxlxml2jsontest.c create mode 100644 tests/virmocklibxl.c -- 1.9.3

3 17

[libvirt] [libvirt-glib] [PATCH v3] GVirDomainSnapshot: Add gvir_domain_snapshot_delete
by Timm Bäder 03 Jun '14

03 Jun '14

--- libvirt-gobject/libvirt-gobject-domain-snapshot.c | 29 +++++++++++++++++++++++ libvirt-gobject/libvirt-gobject-domain-snapshot.h | 16 +++++++++++++ libvirt-gobject/libvirt-gobject.sym | 6 +++++ 3 files changed, 51 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-domain-snapshot.c b/libvirt-gobject/libvirt-gobject-domain-snapshot.c index fcf70ed..f835b58 100644 --- a/libvirt-gobject/libvirt-gobject-domain-snapshot.c +++ b/libvirt-gobject/libvirt-gobject-domain-snapshot.c @@ -205,3 +205,32 @@ GVirConfigDomainSnapshot *gvir_domain_snapshot_get_config free(xml); return conf; } + +/** + * gvir_domain_snapshot_delete: + * @snapshot: The domain snapshot + * @flags: Bitwise or of #GVirDomainSnapshotDeleteFlags + * @error: (allow-none): Place-holder for error or NULL + * + * Returns: TRUE on success, FALSE otherwise + */ +gboolean gvir_domain_snapshot_delete (GVirDomainSnapshot *snapshot, + guint flags, + GError **error) +{ + GVirDomainSnapshotPrivate *priv; + int status; + + g_return_if_fail(GVIR_IS_DOMAIN_SNAPSHOT (snapshot)); + g_return_if_fail(error == NULL || *error == NULL); + + priv = snapshot->priv; + status = virDomainSnapshotDelete(priv->handle, flags); + if (status < 0) { + gvir_set_error(error, GVIR_DOMAIN_SNAPSHOT_ERROR, 0, + "Unable to delete snapshot `%s'", + gvir_domain_snapshot_get_name(snapshot)); + return FALSE; + } + return TRUE; +} diff --git a/libvirt-gobject/libvirt-gobject-domain-snapshot.h b/libvirt-gobject/libvirt-gobject-domain-snapshot.h index 5bd827c..b3ebe7f 100644 --- a/libvirt-gobject/libvirt-gobject-domain-snapshot.h +++ b/libvirt-gobject/libvirt-gobject-domain-snapshot.h @@ -58,6 +58,18 @@ struct _GVirDomainSnapshotClass gpointer padding[20]; }; +/** + * GVirDomainSnapshotDeleteFlags: + * @GVIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN: Also delete children + * @GVIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY: Delete just metadata + * @GVIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY: Delete just children + */ +typedef enum { + GVIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN = 1, + GVIR_DOMAIN_SNAPSHOT_DELETE_METADATA_ONLY = 2, + GVIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY = 4 +} GVirDomainSnapshotDeleteFlags; + GType gvir_domain_snapshot_get_type(void); GType gvir_domain_snapshot_handle_get_type(void); @@ -69,6 +81,10 @@ GVirConfigDomainSnapshot *gvir_domain_snapshot_get_config guint flags, GError **err); +gboolean gvir_domain_snapshot_delete (GVirDomainSnapshot *snapshot, + guint flags, + GError **error); + G_END_DECLS #endif /* __LIBVIRT_GOBJECT_DOMAIN_SNAPSHOT_H__ */ diff --git a/libvirt-gobject/libvirt-gobject.sym b/libvirt-gobject/libvirt-gobject.sym index f2419ac..232e63b 100644 --- a/libvirt-gobject/libvirt-gobject.sym +++ b/libvirt-gobject/libvirt-gobject.sym @@ -234,4 +234,10 @@ LIBVIRT_GOBJECT_0.1.5 { gvir_connection_open_read_only_finish; } LIBVIRT_GOBJECT_0.1.4; +LIBVIRT_GOBJECT_0.1.9 { + global: + gvir_domain_snapshot_delete_flags_get_type; + gvir_domain_snapshot_delete; +} LIBVIRT_GOBJECT_0.1.5; + # .... define new API here using predicted next version number .... -- 2.0.0

2 2

[libvirt] [PATCH v2 0/4] qemu: Some more device unplug fixes
by Jiri Denemark 03 Jun '14

03 Jun '14

Jiri Denemark (4): qemu: Remove interface backend only after frontend is gone qemu: Remove disk backend only after frontend is gone qemu: Remove character device backend only after frontend is gone qemu: Return in from qemuDomainRemove*Device src/qemu/qemu_hotplug.c | 162 +++++++++++++++++++++++++----------------------- 1 file changed, 84 insertions(+), 78 deletions(-) -- 2.0.0

2 9

[libvirt] [libvirt-glib] [PATCH] Remove #if 0's from libvirt-gobject-domain-snapshot
by Timm Bäder 03 Jun '14

03 Jun '14

The code seems to be fine. --- I'd like to use this code (in later patches). If anything is wrong with the current implementation, I'd like to know so I can fix it. libvirt-gobject/libvirt-gobject-domain-snapshot.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libvirt-gobject/libvirt-gobject-domain-snapshot.c b/libvirt-gobject/libvirt-gobject-domain-snapshot.c index d4e9b97..ab23342 100644 --- a/libvirt-gobject/libvirt-gobject-domain-snapshot.c +++ b/libvirt-gobject/libvirt-gobject-domain-snapshot.c @@ -144,9 +144,7 @@ typedef struct virDomainSnapshot GVirDomainSnapshotHandle; static GVirDomainSnapshotHandle* gvir_domain_snapshot_handle_copy(GVirDomainSnapshotHandle *src) { -#if 0 virDomainSnapshotRef((virDomainSnapshotPtr)src); -#endif return src; } @@ -162,7 +160,7 @@ G_DEFINE_BOXED_TYPE(GVirDomainSnapshotHandle, gvir_domain_snapshot_handle, const gchar *gvir_domain_snapshot_get_name(GVirDomainSnapshot *snapshot) { g_return_val_if_fail(GVIR_IS_DOMAIN_SNAPSHOT(snapshot), NULL); -#if 0 + GVirDomainSnapshotPrivate *priv = snapshot->priv; const char *name; @@ -172,12 +170,6 @@ const gchar *gvir_domain_snapshot_get_name(GVirDomainSnapshot *snapshot) } return name; -#else - if (snapshot) - return NULL; -#endif - - g_return_val_if_reached(NULL); } -- 1.9.3

3 3

[libvirt] [PATCH] xenapi_utils: Adapt to enum cleanups
by Michal Privoznik 03 Jun '14

03 Jun '14

It was just very recently that we transfered from: enum virSomeEnumName{ ... }; to: typedef enum { ... } virSomeEnumName; This change requires some code adaptation, which wasn't done for xenapi driver. With this fix we are able to build again. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under build breaker rule. src/xenapi/xenapi_utils.c | 14 +++++++------- src/xenapi/xenapi_utils.h | 10 +++++----- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/xenapi/xenapi_utils.c b/src/xenapi/xenapi_utils.c index c9a62d9..156e0c8 100644 --- a/src/xenapi/xenapi_utils.c +++ b/src/xenapi/xenapi_utils.c @@ -127,7 +127,7 @@ xenapiUtil_ParseQuery(virConnectPtr conn, virURIPtr uri, int *noVerify) enum xen_on_normal_exit -actionShutdownLibvirt2XenapiEnum(enum virDomainLifecycleAction action) +actionShutdownLibvirt2XenapiEnum(virDomainLifecycleAction action) { enum xen_on_normal_exit num = XEN_ON_NORMAL_EXIT_RESTART; if (action == VIR_DOMAIN_LIFECYCLE_DESTROY) @@ -139,7 +139,7 @@ actionShutdownLibvirt2XenapiEnum(enum virDomainLifecycleAction action) enum xen_on_crash_behaviour -actionCrashLibvirt2XenapiEnum(enum virDomainLifecycleCrashAction action) +actionCrashLibvirt2XenapiEnum(virDomainLifecycleCrashAction action) { enum xen_on_crash_behaviour num = XEN_ON_CRASH_BEHAVIOUR_RESTART; if (action == VIR_DOMAIN_LIFECYCLE_CRASH_DESTROY) @@ -180,7 +180,7 @@ createXenAPIBootOrderString(int nboot, int *bootDevs) } /* convert boot order string to libvirt boot order enum */ -enum virDomainBootOrder +virDomainBootOrder map2LibvirtBootOrder(char c) { switch (c) { @@ -197,10 +197,10 @@ map2LibvirtBootOrder(char c) } } -enum virDomainLifecycleAction +virDomainLifecycleAction xenapiNormalExitEnum2virDomainLifecycle(enum xen_on_normal_exit action) { - enum virDomainLifecycleAction num = VIR_DOMAIN_LIFECYCLE_RESTART; + virDomainLifecycleAction num = VIR_DOMAIN_LIFECYCLE_RESTART; if (action == XEN_ON_NORMAL_EXIT_DESTROY) num = VIR_DOMAIN_LIFECYCLE_DESTROY; else if (action == XEN_ON_NORMAL_EXIT_RESTART) @@ -209,10 +209,10 @@ xenapiNormalExitEnum2virDomainLifecycle(enum xen_on_normal_exit action) } -enum virDomainLifecycleCrashAction +virDomainLifecycleCrashAction xenapiCrashExitEnum2virDomainLifecycle(enum xen_on_crash_behaviour action) { - enum virDomainLifecycleCrashAction num = VIR_DOMAIN_LIFECYCLE_CRASH_RESTART; + virDomainLifecycleCrashAction num = VIR_DOMAIN_LIFECYCLE_CRASH_RESTART; if (action == XEN_ON_CRASH_BEHAVIOUR_DESTROY) num = VIR_DOMAIN_LIFECYCLE_CRASH_DESTROY; else if (action == XEN_ON_CRASH_BEHAVIOUR_RESTART) diff --git a/src/xenapi/xenapi_utils.h b/src/xenapi/xenapi_utils.h index 31b313b..26e1ac2 100644 --- a/src/xenapi/xenapi_utils.h +++ b/src/xenapi/xenapi_utils.h @@ -43,20 +43,20 @@ int xenapiUtil_ParseQuery(virConnectPtr conn, virURIPtr uri, int *noVerify); enum xen_on_normal_exit -actionShutdownLibvirt2XenapiEnum(enum virDomainLifecycleAction action); +actionShutdownLibvirt2XenapiEnum(virDomainLifecycleAction action); enum xen_on_crash_behaviour -actionCrashLibvirt2XenapiEnum(enum virDomainLifecycleCrashAction action); +actionCrashLibvirt2XenapiEnum(virDomainLifecycleCrashAction action); char * createXenAPIBootOrderString(int nboot, int *bootDevs); -enum virDomainBootOrder map2LibvirtBootOrder(char c); +virDomainBootOrder map2LibvirtBootOrder(char c); -enum virDomainLifecycleAction +virDomainLifecycleAction xenapiNormalExitEnum2virDomainLifecycle(enum xen_on_normal_exit action); -enum virDomainLifecycleCrashAction +virDomainLifecycleCrashAction xenapiCrashExitEnum2virDomainLifecycle(enum xen_on_crash_behaviour action); void getCpuBitMapfromString(char *mask, unsigned char *cpumap, int maplen); -- 2.0.0

1 0

[libvirt] [PATCH 1/3] cpu: use typedefs for enums in "src/cpu/cpu_map.h"
by Julio Faracco 02 Jun '14

02 Jun '14

In "src/cpu/" there are some enumerations (enum) declarations. Similar to the recent cleanup to "src/util", "src/conf" and other directories, it's better to use a typedef for variable types, function types and other usages. Other enumeration and folders will be changed to typedef's in the future. Specially, in files that are in different places of "src/util" and "src/conf". Most of the files changed in this commit are related to CPU (cpu_map.h) enums. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/cpu/cpu.c | 2 +- src/cpu/cpu_map.c | 2 +- src/cpu/cpu_map.h | 6 +++--- src/cpu/cpu_powerpc.c | 2 +- src/cpu/cpu_x86.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/cpu/cpu.c b/src/cpu/cpu.c index 528e1a7..c3d66dd 100644 --- a/src/cpu/cpu.c +++ b/src/cpu/cpu.c @@ -729,7 +729,7 @@ struct cpuGetModelsData }; static int -cpuGetArchModelsCb(enum cpuMapElement element, +cpuGetArchModelsCb(cpuMapElement element, xmlXPathContextPtr ctxt, void *cbdata) { diff --git a/src/cpu/cpu_map.c b/src/cpu/cpu_map.c index 68d287a..4706f67 100644 --- a/src/cpu/cpu_map.c +++ b/src/cpu/cpu_map.c @@ -42,7 +42,7 @@ VIR_ENUM_IMPL(cpuMapElement, CPU_MAP_ELEMENT_LAST, static int load(xmlXPathContextPtr ctxt, - enum cpuMapElement element, + cpuMapElement element, cpuMapLoadCallback callback, void *data) { diff --git a/src/cpu/cpu_map.h b/src/cpu/cpu_map.h index 23ce888..fcd6c34 100644 --- a/src/cpu/cpu_map.h +++ b/src/cpu/cpu_map.h @@ -27,19 +27,19 @@ # include "virxml.h" -enum cpuMapElement { +typedef enum { CPU_MAP_ELEMENT_VENDOR, CPU_MAP_ELEMENT_FEATURE, CPU_MAP_ELEMENT_MODEL, CPU_MAP_ELEMENT_LAST -}; +} cpuMapElement; VIR_ENUM_DECL(cpuMapElement) typedef int -(*cpuMapLoadCallback) (enum cpuMapElement element, +(*cpuMapLoadCallback) (cpuMapElement element, xmlXPathContextPtr ctxt, void *data); diff --git a/src/cpu/cpu_powerpc.c b/src/cpu/cpu_powerpc.c index 372272f..05fa55b 100644 --- a/src/cpu/cpu_powerpc.c +++ b/src/cpu/cpu_powerpc.c @@ -273,7 +273,7 @@ ppcModelLoad(xmlXPathContextPtr ctxt, } static int -ppcMapLoadCallback(enum cpuMapElement element, +ppcMapLoadCallback(cpuMapElement element, xmlXPathContextPtr ctxt, void *data) { diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 06fbfba..72c5216 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1098,7 +1098,7 @@ x86MapFree(struct x86_map *map) static int -x86MapLoadCallback(enum cpuMapElement element, +x86MapLoadCallback(cpuMapElement element, xmlXPathContextPtr ctxt, void *data) { -- 1.7.10.4

2 5

[libvirt] [Question] Collect vNode pinning to pNode run-time information
by Shi, Xiao-Lei (Bruce, HP Servers-PSC-CQ) 02 Jun '14

02 Jun '14

Hi all, I have a question about NUMA. User configured vNode(guest virtual numa node), but he didn't configure cputune and numatune. Now we want to get the information that each vNode run in which pNode(host numa node). It's run-time information that may be modified with high frequency. In current Libvirt's API, we can get the information that each vCpu running on which pCpu through virsh vcpuinfo(there should be a corresponding Libvirt API function). But we didn't find any APIs to get the information that each vNode uses which pNode's memory, or just each vCpu consumes which pNode's memory. We find a command "numastat -mcn -p qemu" that can get the memory consume data of each VM, but it still loses the information that we want(vNode memory consume data), as following: # numastat -mcn -p qemu Per-node process memory usage (in MBs) PID Node 0 Node 1 Total --------------- ------ ------ ----- 8900 (qemu-kvm) 2032 50 2083 17716 (qemu-kvm) 1546 663 2209 22484 (qemu-kvm) 621 1524 2146 29694 (qemu-kvm) 892 1350 2242 --------------- ------ ------ ----- Total 5092 3588 8680 ......... My question is: 1. In Libvirt, are there any ways that we can get our needed data? 2. If no ways in Libvirt, do you have any other suggestions to collect the information? Any feedbacks from you are appreciated. Thanks & Best Regards Shi, Xiao-Lei (Bruce) Hewlett-Packard Co., Ltd. HP Servers Core Platform Software China Telephone +86 23 65683093 Mobile +86 18696583447 Email xiao-lei.shi(a)hp.com<mailto:shiguo.li@hp.com>

2 1

[libvirt] Is there a way to get host uptime in remote libvirt
by coffeeball 02 Jun '14

02 Jun '14

We manage hypervisors (VMWare ESXi/vCenter, KVM, XEN, Hyper-V) by remote Libvirt API, in our case we need to get the host uptime via the same libvirt interface. Is there a way get this info now for all the aforementioned hypervisor types? The APIs virConnectGetSysinfo(), virNodeGetInfo() provide host info but it doesn't include the system uptime. The virNodeGetCPUStats() can returns CPU usage in nanosecond, can we add the user + system + idle + iowait to calculate the system uptime? Looks like the sum value has a huge gap with the real uptime value returned by "uptime" CLI. virsh # nodecpustats user: 2985046540000000 system: 1368209710000000 idle: 388018933920000000 iowait: 43371960000000

2 1

[libvirt] [PATCH] virsh-nodedev: Avoid spurious errors
by Michal Privoznik 02 Jun '14

02 Jun '14

Our public free functions explicitly don't accept NULL pointers (sigh). Therefore, callers must do something like this: if (dev) virNodeDeviceFree(dev); And we are not doing that on two places I've found. This leads to dummy error message thrown by virsh: virsh # nodedev-dumpxml nonexistent-device error: Could not find matching device 'nonexistent-device' error: invalid node device pointer in virNodeDeviceFree Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-nodedev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index a35387a..46e0045 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -162,7 +162,8 @@ cmdNodeDeviceDestroy(vshControl *ctl, const vshCmd *cmd) ret = true; cleanup: virStringFreeList(arr); - virNodeDeviceFree(dev); + if (dev) + virNodeDeviceFree(dev); return ret; } @@ -571,7 +572,8 @@ cmdNodeDeviceDumpXML(vshControl *ctl, const vshCmd *cmd) cleanup: virStringFreeList(arr); VIR_FREE(xml); - virNodeDeviceFree(device); + if (device) + virNodeDeviceFree(device); return ret; } -- 2.0.0

2 2

[libvirt] [libvirt-php] libvirt_domain_new Create a slow vm
by Mario Di Ture 02 Jun '14

02 Jun '14

Hi, I've tested this script on centos 6.5 (libvirt-0.10.2, qemu-kvm-0.12.1.2) and ubuntu server 14.04 (libvirt 1.2.2, qemu-kvm 2.0.0) with the same result. The created vm is very slow compared to the vm created with virt-manager, with the same features/devices on the same host. Can you suggest any configuration that can avoid that slowness? With regards Mario D. <?php $conn = libvirt_connect('null', false); $name="testvm"; $arch="x86_64"; $memMB=1024; $maxmemMB=1536; $vcpus=1; $iso_image="/home/iso/CentOS-6.5-x86_64-minimal.iso"; $disk1 = array( "path" => "/home/vm/centos-script.raw", "driver" => "raw", "bus" => "virtio", "dev" => "hda", "size" => "6G", "flags" => VIR_DOMAIN_DISK_FILE | VIR_DOMAIN_DISK_ACCESS_ALL ); $disks = array( $disk1 ); $network1 = array( 'mac' => '00:11:22:33:44:55', 'network' => 'default', 'model' => 'e1000' ); $networks = array( $network1 ); $flags=VIR_DOMAIN_FLAG_FEATURE_ACPI; $newdom=libvirt_domain_new($conn, $name, $arch, $memMB, $maxmemMB, $vcpus, $iso_image, $disks, $networks, $flags); print_r($newdom); ?>

2 2

[libvirt] parallels: add 2 functions needed by OpenStack
by Alexander Burluka 02 Jun '14

02 Jun '14

Hello, I would like to contribute in Libvirt development. Parallels team continues working on driver to make it compatible with OpenStack. So, this patches are part of our goal. I would gracefully accept your comments and remarks. Thank you! -- Regards, Alexander Burluka

2 3

[libvirt] [PATCH] Don't use AI_ADDRCONFIG when binding to wildcard addresses
by Ján Tomko 02 Jun '14

02 Jun '14

https://bugzilla.redhat.com/show_bug.cgi?id=1098659 With parallel boot, network addresses might not yet be assigned [1], but binding to wildcard addresses should work. For non-wildcard addresses, ADDRCONFIG is still used. Document this in libvirtd.conf. [1] http://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ --- daemon/libvirtd.conf | 4 ++++ src/rpc/virnetsocket.c | 28 ++++++++++++++++++++++++++-- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.conf b/daemon/libvirtd.conf index aeba11d..e5856d4 100644 --- a/daemon/libvirtd.conf +++ b/daemon/libvirtd.conf @@ -48,6 +48,10 @@ # Override the default configuration which binds to all network # interfaces. This can be a numeric IPv4/6 address, or hostname # +# If the libvirtd service is started in parallel with network +# startup (e.g. with systemd), binding to addresses other than +# the wildcards (0.0.0.0/::) might not be available yet. +# #listen_addr = "192.168.0.1" diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index a7e1783..87b39f2 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -226,15 +226,29 @@ int virNetSocketNewListenTCP(const char *nodename, struct addrinfo hints; int fd = -1; size_t i; - int addrInUse = false; + bool addrInUse = false; + bool familyNotSupported = false; + virSocketAddr tmp_addr; *retsocks = NULL; *nretsocks = 0; memset(&hints, 0, sizeof(hints)); - hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG; + hints.ai_flags = AI_PASSIVE; hints.ai_socktype = SOCK_STREAM; + /* Don't use ADDRCONFIG for binding to the wildcard address. + * Just catch the error returned by socket() if the system has + * no IPv6 support. + * + * This allows libvirtd to be started in parallel with the network + * startup in most cases. + */ + if (nodename && + !(virSocketAddrParse(&tmp_addr, nodename, AF_UNSPEC) > 0 && + virSocketAddrIsWildcard(&tmp_addr))) + hints.ai_flags = AI_ADDRCONFIG; + int e = getaddrinfo(nodename, service, &hints, &ai); if (e != 0) { virReportError(VIR_ERR_SYSTEM_ERROR, @@ -251,6 +265,11 @@ int virNetSocketNewListenTCP(const char *nodename, if ((fd = socket(runp->ai_family, runp->ai_socktype, runp->ai_protocol)) < 0) { + if (errno == EAFNOSUPPORT) { + familyNotSupported = true; + runp = runp->ai_next; + continue; + } virReportSystemError(errno, "%s", _("Unable to create socket")); goto error; } @@ -307,6 +326,11 @@ int virNetSocketNewListenTCP(const char *nodename, fd = -1; } + if (nsocks == 0 && familyNotSupported) { + virReportSystemError(EAFNOSUPPORT, "%s", _("Unable to bind to port")); + goto error; + } + if (nsocks == 0 && addrInUse) { virReportSystemError(EADDRINUSE, "%s", _("Unable to bind to port")); -- 1.8.3.2

3 5

[libvirt] [PATCH] leaseshelper: Include locale.h
by Michal Privoznik 02 Jun '14

02 Jun '14

The commit baafe668 introduces this new helper utility. As in all our programs, there's setlocale() called at the beginning of main(). However, this source file don't include locale.h file which causes build errors on some systems (e.g. mine). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/leaseshelper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index e53a73c..eb695e4 100644 --- a/src/network/leaseshelper.c +++ b/src/network/leaseshelper.c @@ -28,6 +28,7 @@ #include <stdio.h> #include <stdlib.h> #include <sys/stat.h> +#include <locale.h> #include "virutil.h" #include "virthread.h" -- 2.0.0

2 1

[libvirt] ANNOUNCE: Perl binding Sys-Virt release 1.2.5
by Daniel P. Berrange 02 Jun '14

02 Jun '14

I am pleased to announce that release 1.2.5 of Sys-Virt, the libvirt Perl API binding, is now available for download: http://search.cpan.org/CPAN/authors/id/D/DA/DANBERR/Sys-Virt-1.2.5.tar.gz Changed in the 1.2.5 release: - Add VIR_DOMAIN_{REBOOT,SHUTDOWN}_PARAVIRT constants - Add virDomainFSFreeze/virDomainFSThaw APIs - Add virDomainSetTime/virDomainGetTime APIs Further information, including online API documentation & previous release archives, is available from the CPAN home page http://search.cpan.org/dist/Sys-Virt/ Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH 0/4] qemu: Some more device unplug fixes
by Jiri Denemark 02 Jun '14

02 Jun '14

This series depends on "qemu: Process DEVICE_DELETED event in a separate thread" series I sent yesterday. Jiri Denemark (4): qemu: Unref cfg when detaching hostdev interface qemu: Remove interface backend only after frontend is gone qemu: Remove disk backend only after frontend is gone qemu: Remove character device backend only after frontend is gone src/qemu/qemu_hotplug.c | 122 ++++++++++++++++++++++++------------------------ 1 file changed, 60 insertions(+), 62 deletions(-) -- 1.9.3

2 9

[libvirt] [PATCH] Fix build on freebsd
by Pavel Hrdina 02 Jun '14

02 Jun '14

On freebsd there isn't known "setlocale" so we have to include locale.h Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under trivial rule src/network/leaseshelper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index e53a73c..b6f6c32 100644 --- a/src/network/leaseshelper.c +++ b/src/network/leaseshelper.c @@ -25,6 +25,7 @@ #include <config.h> +#include <locale.h> #include <stdio.h> #include <stdlib.h> #include <sys/stat.h> -- 1.8.5.5

1 0

[libvirt] [PATCH 0/2] qemu: Process DEVICE_DELETED event in a separate thread
by Jiri Denemark 02 Jun '14

02 Jun '14

Jiri Denemark (2): qemu: Finish device removal in the original thread qemu: Process DEVICE_DELETED event in a separate thread src/qemu/qemu_domain.h | 2 ++ src/qemu/qemu_driver.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++-- src/qemu/qemu_hotplug.c | 44 +++++++++++++++++++++++++++++++++----------- src/qemu/qemu_hotplug.h | 2 +- src/qemu/qemu_process.c | 30 +++++++++++++++++++++--------- 5 files changed, 103 insertions(+), 23 deletions(-) -- 1.9.3

2 5

[libvirt] Bug: iohelper drops I/O error messages
by Jason J. Herne 02 Jun '14

02 Jun '14

During a recent managed save operation I received the following error message: error: operation failed: domain save job: unexpectedly failed. It turns out that I had run out of disk space. After a brief investigation I discovered that libvirt_iohelper is exec'ed and is used to handle all I/O during a (Qemu) managed save operation. While iohelper appears to be set up to log error conditions when they occur, for some reason the logging is getting lost. I'm hoping someone can help figure out why these errors are getting lost. It would be nice to present a useful error message to the user when a managed save fails because of an I/O error. -- -- Jason J. Herne (jjherne(a)linux.vnet.ibm.com)

1 1