- Devel - libvirt List Archives

[libvirt] [libvirt-test-API][PATCH] Rewrite case for listAllInterfaces() API
by jiahu 12 Mar '15

12 Mar '15

Using actual python API to validate test case, rather than use virsh iface-* command lines. --- cases/basic_interface.conf | 12 ++ repos/interface/iface_list.py | 299 ++++++++++++------------------------------ 2 files changed, 99 insertions(+), 212 deletions(-) diff --git a/cases/basic_interface.conf b/cases/basic_interface.conf index e2125bb..43e37e8 100644 --- a/cases/basic_interface.conf +++ b/cases/basic_interface.conf @@ -15,3 +15,15 @@ interface:define interface:create ifacename $testnic + +interface:iface_list + flags + all + +interface:iface_list + flags + active + +interface:iface_list + flags + inactive diff --git a/repos/interface/iface_list.py b/repos/interface/iface_list.py index 49f0c05..85f9df9 100644 --- a/repos/interface/iface_list.py +++ b/repos/interface/iface_list.py @@ -1,65 +1,26 @@ #!/usr/bin/env python +# test listAllInterfaces() API import os -import sys -import re -import commands +import libvirt -required_params = ('ifaceopt',) -optional_params = {} - -VIRSH_QUIET_IFACE_LIST = "virsh --quiet iface-list %s | awk '{print ""$%s""}'" -NETWORK_CONFIG = "/etc/sysconfig/network-scripts/" -IFCONFIG_DRIVER = "ifconfig %s | sed 's/[ \t].*//;/^$/d'" -GET_MAC = "ip link show %s |sed -n '2p'| awk '{print $2}'" -VIRSH_IFACE_LIST = "virsh iface-list %s" - -names = [] -state = [] -macs = [] - -def get_option_list(params): - """return options we need to test - """ - logger = params['logger'] - option_list=[] +from libvirt import libvirtError +from src import sharedmod +from utils import utils - value = params['ifaceopt'] - if value == 'all': - option_list = [' ', '--all', '--inactive'] - elif value == '--all' or value == '--inactive': - option_list.append(value) - else: - logger.error("value %s is not supported" % value) - return 1, option_list +required_params = ('flags',) +optional_params = {} - return 0, option_list +NETWORK_CONFIG = "/etc/sysconfig/network-scripts/" +IFCONFIG_DRIVER = "ifconfig %s | sed 's/[ \t].*//;/^$/d'| cut -d \":\" -f -1" -def get_output(command, logger): - """execute shell command +def get_inteface_list_from_ifcfg(logger): + """ + return host interface list from ifcfg-* """ - status, ret = commands.getstatusoutput(command) - if status: - logger.error("executing "+ "\"" + command + "\"" + " failed") - logger.error(ret) - return status, ret - -def get_interface_list(option, logger): - """ return active host interface list """ - interface_list = [] - status, interface_str = get_output(IFCONFIG_DRIVER % option, logger) - if not status: - interface_list = interface_str.split('\n') - return interface_list - else: - logger.error("\"" + IFCONFIG_DRIVER % option + "\"" + "error") - logger.error(interface_str) - return interface_list - -def check_ifacename(names, option, logger): - """ verify the validity of output data """ ifcfg_files = [] + nic_names = [] for f in os.listdir(NETWORK_CONFIG): if f.startswith("ifcfg-"): f_path = os.path.join(NETWORK_CONFIG, f) @@ -67,18 +28,6 @@ def check_ifacename(names, option, logger): ifcfg_files.append(f_path) else: logger.warn("%s is not a regular file" % f_path) - - interface_active = get_interface_list('', logger) - logger.debug("list of active host interface: %s" % interface_active) - if interface_active == None: - return 1 - - interface_all = get_interface_list('-a', logger) - logger.debug("list of all host interface: %s" % interface_all) - if interface_all == None: - return 1 - - for ifcfg_file in ifcfg_files: fp = open(ifcfg_file, 'r') fp.seek(0,0) @@ -87,165 +36,91 @@ def check_ifacename(names, option, logger): device_str = eachLine.rstrip() nic_string = device_str.split("=")[1] if nic_string.startswith("\""): - nic_name = nic_string[1:-1] + nic_names = nic_string[1:-1] else: - nic_name = nic_string + nic_names.append(nic_string) break - fp.close() + return list(set(nic_names)) - if option == ' ': - if nic_name not in interface_active: - continue - else: - if nic_name in names: - logger.info("it contains interface %s in %s" % (nic_name, ifcfg_file)) - else: - logger.error("interface %s in %s couldn't \n\ - be in the output of virsh iface-list with option %s" % \ - (nic_name, ifcfg_file, option)) - return 1 - elif option == '--all': - if nic_name in names: - logger.info("it contains interface %s in %s" % (nic_name, ifcfg_file)) - else: - logger.error("interface %s in %s couldn't \n\ - be in the output of virsh iface-list with option %s" % \ - (nic_name, ifcfg_file, option)) - - return 1 - elif option == '--inactive': - if nic_name in interface_active: - continue - else: - if nic_name in names: - logger.info("it contains interface %s in %s" % (nic_name, ifcfg_file)) - else: - logger.error("interface %s in %s couldn't \n\ - be in the output of virsh iface-list with option %s" % \ - (nic_name, ifcfg_file, option)) - return 1 - - return 0 - -def check_ifacestate(names, state, logger): - """ check the state of give host interface """ - - interface_active = get_interface_list('', logger) - if interface_active == None: - return 1 - - interface_all = get_interface_list('-a', logger) - if interface_all == None: - return 1 - - index = 0 - count = len(names) - while(index < count): - if names[index] in interface_active and state[index] == 'active': - logger.info("interface %s is %s" % (names[index], state[index])) - elif names[index] not in interface_active and \ - names[index] in interface_all and \ - state[index] == 'inactive': - logger.info("interface %s is %s" % (names[index], state[index])) - else: - logger.error("interface %s is %s, but not we expected" % \ - (names[index], state[index])) - return 1 - - index = index + 1 - - return 0 - -def check_ifacemac(names, macs, logger): - """ check if the mac corresponding to approriate name is correct """ - index = 0 - count = len(names) - while(index < count): - status, mac_shell = get_output(GET_MAC % names[index], logger) - if not status: - if mac_shell == macs[index]: - logger.info("interface %s's mac address is %s" % \ - (names[index], macs[index])) - else: - logger.error("interface %s's mac address from iface-list: %s \ - is different from one from ip link show: %s" % \ - (name[index], macs[indesx], mac_shell)) - return 1 - index = index + 1 - - return 0 - -def iface_list_output(option, logger): - """ check the output of virsh iface-list with appropriate option """ - global names, state, macs - - status, ret = get_output(VIRSH_QUIET_IFACE_LIST % (option, 1), logger) - if not status: - names = ret.split('\n') - logger.info("interface names from option '%s' : %s" % (option, names)) - - else: - return 1 - - status, ret = get_output(VIRSH_QUIET_IFACE_LIST % (option, 2), logger) - if not status: - state = ret.split('\n') - logger.info("interface state from option '%s' : %s" % (option, state)) - else: - return 1 - - status, ret = get_output(VIRSH_QUIET_IFACE_LIST % (option, 3), logger) +def get_interface_list(option, logger): + """ + return host interface list + """ + nic_names = [] + status, nic_names = utils.exec_cmd(IFCONFIG_DRIVER % option, shell=True) if not status: - macs = ret.split('\n') - logger.info("interface macs from option '%s' : %s" % (option, macs)) + return nic_names else: - return 1 + logger.error("\"" + IFCONFIG_DRIVER % option + "\"" + "error") + logger.error(nic_names) + return nic_names - return 0 +def iface_list_output_from_ifconfig(flags, logger): + """ + get all host interface using ifconfig command + """ + nic_names = [] + if flags == 0: + nic_names = get_interface_list('-a', logger) + elif flags == 1: + interface_all = get_interface_list('-a', logger) + interface_active = get_interface_list('', logger) + nic_names = list(set(interface_all) - set(interface_active)) + elif flags == 2: + nic_names = get_interface_list('', logger) + + if nic_names == None: + return False + return nic_names + +def iface_list_output_from_api(flags,logger): + """ + get interface list using listAllInterfaces() + """ + nic_names_api = [] + for interface in conn.listAllInterfaces(flags): + nic_names_api.append(str(interface.name())) + return nic_names_api def iface_list(params): - """ test the validity of the output of iface_list with - default, --all, --inactive option, including - interface name, state, and mac + """ + test listAllInterfaces() api """ + global conn logger = params['logger'] - ret, option_list = get_option_list(params) - global names, state, macs - - if ret: - return 1 - - for option in option_list: - logger.info("CHECK the output of virsh pool-list with option '%s'" % option) - logger.info("get the name, corresponding state and mac address of interfaces") - if iface_list_output(option, logger): - logger.error("faied to name, state, and mac from iface-list") - return 1 + flags = params['flags'] + conn = sharedmod.libvirtobj['conn'] + logger.info("The given flags is %s " % flags) + if flags == "all": + flag = 0 + elif flags == "inactive": + flag = 1 + elif flags == "active": + flag = 2 + try: + iface_list = iface_list_output_from_api(flag, logger) + iface_list_ifconfig = iface_list_output_from_ifconfig(flag, logger) + if iface_list_ifconfig == False: + return 1 + ifcfg = get_inteface_list_from_ifcfg(logger) + logger.info("interface list from API: %s" % iface_list) + logger.debug("interface list from ifcfg: %s" % ifcfg) + for interface in iface_list_ifconfig: + if interface not in ifcfg: + iface_list_ifconfig.remove(interface) + logger.debug("%s has not regular ifcfg file" % interface) + + logger.info("interface list from ifconfig cmd: %s" % iface_list_ifconfig) + for interface in iface_list: + if interface in iface_list_ifconfig: + logger.debug("%s :Pass" % interface) else: - logger.info("then, check the validity of these interface names") - if check_ifacename(names, option, logger): - logger.error("checking interface names FAILED") - return 1 - else: - logger.info("checking interface names SUCCESSFULLY") - - logger.info("check the state of these interfaces") - if check_ifacestate(names, state, logger): - logger.error("checking interface state FAILED") - return 1 - else: - logger.info("checking interface state SUCCESSFULLY") - - logger.info("check the interface mac address") - if check_ifacemac(names, macs, logger): - logger.error("checking interface mac address FAILED") - return 1 - else: - logger.info("checking interface mac address SUCESSFULLY") - - status, ret = get_output(VIRSH_IFACE_LIST % option, logger) - if not status: - logger.info("\n" + ret) + logger.debug("%s :Fail" % interface) + return 1 + + except libvirtError, e: + logger.error("API error message: %s" % e.message) + return 1 return 0 -- 1.8.3.1

2 1

[libvirt] [PATCH] Introduce virBitmapIsBitSet
by Ján Tomko 12 Mar '15

12 Mar '15

A helper that never returns an error and treats bits out of bitmap range as false. Use it everywhere we use ignore_value on virBitmapGetBit, or loop over the bitmap size. --- src/conf/domain_conf.c | 4 +--- src/conf/node_device_conf.c | 4 +--- src/conf/snapshot_conf.c | 6 ++---- src/conf/storage_conf.c | 4 +--- src/libvirt_private.syms | 1 + src/libxl/libxl_domain.c | 4 +--- src/libxl/libxl_driver.c | 5 +---- src/nodeinfo.c | 6 +----- src/qemu/qemu_capabilities.c | 7 +------ src/storage/storage_backend.c | 4 +--- src/util/virbitmap.c | 18 ++++++++++++++++++ src/util/virbitmap.h | 5 +++++ src/util/vircgroup.c | 4 +--- src/util/virdnsmasq.c | 6 +----- src/util/virportallocator.c | 17 +++-------------- src/util/virprocess.c | 9 ++------- src/xen/xen_driver.c | 4 +--- src/xen/xend_internal.c | 5 +---- 18 files changed, 43 insertions(+), 70 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 127fc91..ae8688e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -3107,7 +3107,6 @@ virDomainDefRejectDuplicateControllers(virDomainDefPtr def) virDomainControllerDefPtr cont; size_t nbitmaps = 0; int ret = -1; - bool b; size_t i; memset(max_idx, -1, sizeof(max_idx)); @@ -3133,8 +3132,7 @@ virDomainDefRejectDuplicateControllers(virDomainDefPtr def) if (max_idx[cont->type] == -1) continue; - ignore_value(virBitmapGetBit(bitmaps[cont->type], cont->idx, &b)); - if (b) { + if (virBitmapIsBitSet(bitmaps[cont->type], cont->idx)) { virReportError(VIR_ERR_XML_ERROR, _("Multiple '%s' controllers with index '%d'"), virDomainControllerTypeToString(cont->type), diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index f9c9b6f..2899a06 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -439,9 +439,7 @@ char *virNodeDeviceDefFormat(const virNodeDeviceDef *def) virInterfaceLinkFormat(&buf, &data->net.lnk); if (data->net.features) { for (i = 0; i < VIR_NET_DEV_FEAT_LAST; i++) { - bool b; - ignore_value(virBitmapGetBit(data->net.features, i, &b)); - if (b) { + if (virBitmapIsBitSet(data->net.features, i)) { virBufferAsprintf(&buf, "<feature name='%s'/>\n", virNetDevFeatureTypeToString(i)); } diff --git a/src/conf/snapshot_conf.c b/src/conf/snapshot_conf.c index a0667c2..dc5436f 100644 --- a/src/conf/snapshot_conf.c +++ b/src/conf/snapshot_conf.c @@ -465,7 +465,6 @@ virDomainSnapshotAlignDisks(virDomainSnapshotDefPtr def, virBitmapPtr map = NULL; size_t i; int ndisks; - bool inuse; if (!def->dom) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -500,7 +499,7 @@ virDomainSnapshotAlignDisks(virDomainSnapshotDefPtr def, goto cleanup; } - if (virBitmapGetBit(map, idx, &inuse) < 0 || inuse) { + if (virBitmapIsBitSet(map, idx)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("disk '%s' specified twice"), disk->name); @@ -553,8 +552,7 @@ virDomainSnapshotAlignDisks(virDomainSnapshotDefPtr def, for (i = 0; i < def->dom->ndisks; i++) { virDomainSnapshotDiskDefPtr disk; - ignore_value(virBitmapGetBit(map, i, &inuse)); - if (inuse) + if (virBitmapIsBitSet(map, i)) continue; disk = &def->disks[ndisks++]; if (VIR_ALLOC(disk->src) < 0) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 4c1f05d..b070448 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1567,7 +1567,6 @@ virStorageVolTargetDefFormat(virStorageVolOptionsPtr options, if (options->featureToString && def->features) { size_t i; - bool b; bool empty = virBitmapIsAllClear(def->features); if (empty) { @@ -1578,8 +1577,7 @@ virStorageVolTargetDefFormat(virStorageVolOptionsPtr options, } for (i = 0; i < VIR_STORAGE_FILE_FEATURE_LAST; i++) { - ignore_value(virBitmapGetBit(def->features, i, &b)); - if (b) + if (virBitmapIsBitSet(def->features, i)) virBufferAsprintf(buf, "<%s/>\n", options->featureToString(i)); } diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7262c95..b5fe88c 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1070,6 +1070,7 @@ virBitmapFree; virBitmapGetBit; virBitmapIsAllClear; virBitmapIsAllSet; +virBitmapIsBitSet; virBitmapLastSetBit; virBitmapNew; virBitmapNewCopy; diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 9af5758..66ca988 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -1093,9 +1093,7 @@ libxlDomainSetVcpuAffinities(libxlDriverPrivatePtr driver, virDomainObjPtr vm) cpumask = def->cputune.vcpupin[vcpu]->cpumask; for (i = 0; i < virBitmapSize(cpumask); ++i) { - bool bit; - ignore_value(virBitmapGetBit(cpumask, i, &bit)); - if (bit) + if (virBitmapIsBitSet(cpumask, i)) VIR_USE_CPU(cpumap, i); } diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 88fa6ff..d4a8b9d 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -2051,7 +2051,6 @@ libxlDomainGetVcpuPinInfo(virDomainPtr dom, int ncpumaps, virBitmapPtr cpumask = NULL; int maxcpu, hostcpus, vcpu, pcpu, n, ret = -1; unsigned char *cpumap; - bool pinned; virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG, -1); @@ -2100,9 +2099,7 @@ libxlDomainGetVcpuPinInfo(virDomainPtr dom, int ncpumaps, cpumask = vcpupin_list[n]->cpumask; cpumap = VIR_GET_CPUMAP(cpumaps, maplen, vcpu); for (pcpu = 0; pcpu < maxcpu; pcpu++) { - if (virBitmapGetBit(cpumask, pcpu, &pinned) < 0) - goto cleanup; - if (!pinned) + if (!virBitmapIsBitSet(cpumask, pcpu)) VIR_UNUSE_CPU(cpumap, pcpu); } } diff --git a/src/nodeinfo.c b/src/nodeinfo.c index 3a27c22..05256cc 100644 --- a/src/nodeinfo.c +++ b/src/nodeinfo.c @@ -1911,11 +1911,7 @@ nodeCapsInitNUMA(virCapsPtr caps) cpu = 0; for (i = 0; i < virBitmapSize(cpumap); i++) { - bool cpustate; - if (virBitmapGetBit(cpumap, i, &cpustate) < 0) - continue; - - if (cpustate) { + if (virBitmapIsBitSet(cpumap, i)) { if (virNodeCapsFillCPUInfo(i, cpus + cpu++) < 0) { topology_failed = true; virResetLastError(); diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index c513d46..ccf22f0 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2048,12 +2048,7 @@ bool virQEMUCapsGet(virQEMUCapsPtr qemuCaps, virQEMUCapsFlags flag) { - bool b; - - if (!qemuCaps || virBitmapGetBit(qemuCaps->flags, flag, &b) < 0) - return false; - else - return b; + return qemuCaps && virBitmapIsBitSet(qemuCaps->flags, flag); } diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index a4e75f5a5..9322571 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -807,7 +807,6 @@ virStorageBackendCreateQemuImgOpts(char **opts, virBitmapPtr features) { virBuffer buf = VIR_BUFFER_INITIALIZER; - bool b; size_t i; if (backingType) @@ -823,8 +822,7 @@ virStorageBackendCreateQemuImgOpts(char **opts, virBufferAsprintf(&buf, "compat=%s,", compat); if (features && format == VIR_STORAGE_FILE_QCOW2) { for (i = 0; i < VIR_STORAGE_FILE_FEATURE_LAST; i++) { - ignore_value(virBitmapGetBit(features, i, &b)); - if (b) { + if (virBitmapIsBitSet(features, i)) { switch ((virStorageFileFeature) i) { case VIR_STORAGE_FILE_FEATURE_LAZY_REFCOUNTS: if (STREQ_NULLABLE(compat, "0.10")) { diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index b531be5..5322bce 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -179,6 +179,24 @@ static bool virBitmapIsSet(virBitmapPtr bitmap, size_t b) } /** + * virBitmapIsBitSet: + * @bitmap: Pointer to bitmap + * @b: bit position to get + * + * Get setting of bit position @b in @bitmap. + * + * If @b is in the range of @bitmap, returns the value of the bit. + * Otherwise false is returned. + */ +bool virBitmapIsBitSet(virBitmapPtr bitmap, size_t b) +{ + if (bitmap->max_bit <= b) + return false; + + return virBitmapIsSet(bitmap, b); +} + +/** * virBitmapGetBit: * @bitmap: Pointer to bitmap * @b: bit position to get diff --git a/src/util/virbitmap.h b/src/util/virbitmap.h index 136e819..d326c6a 100644 --- a/src/util/virbitmap.h +++ b/src/util/virbitmap.h @@ -62,6 +62,11 @@ int virBitmapClearBit(virBitmapPtr bitmap, size_t b) ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; /* + * Get bit @b in @bitmap. Returns false if b is out of range. + */ +bool virBitmapIsBitSet(virBitmapPtr bitmap, size_t b) + ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; +/* * Get setting of bit position @b in @bitmap and store in @result */ int virBitmapGetBit(virBitmapPtr bitmap, size_t b, bool *result) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 6957e81..e54a079 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -3085,9 +3085,7 @@ virCgroupGetPercpuStats(virCgroupPtr group, need_cpus = MIN(total_cpus, start_cpu + ncpus); for (i = 0; i < need_cpus; i++) { - bool present; - ignore_value(virBitmapGetBit(cpumap, i, &present)); - if (!present) { + if (!virBitmapIsBitSet(cpumap, i)) { cpu_time = 0; } else if (virStrToLong_ull(pos, &pos, 10, &cpu_time) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index 97652c0..6a2a2fb 100644 --- a/src/util/virdnsmasq.c +++ b/src/util/virdnsmasq.c @@ -874,10 +874,6 @@ dnsmasqCapsGetVersion(dnsmasqCapsPtr caps) bool dnsmasqCapsGet(dnsmasqCapsPtr caps, dnsmasqCapsFlags flag) { - bool b; - if (!caps || virBitmapGetBit(caps->flags, flag, &b) < 0) - return false; - else - return b; + return caps && virBitmapIsBitSet(caps->flags, flag); } diff --git a/src/util/virportallocator.c b/src/util/virportallocator.c index 578debf..fcd4f74 100644 --- a/src/util/virportallocator.c +++ b/src/util/virportallocator.c @@ -184,14 +184,7 @@ int virPortAllocatorAcquire(virPortAllocatorPtr pa, for (i = pa->start; i <= pa->end && !*port; i++) { bool used = false, v6used = false; - if (virBitmapGetBit(pa->bitmap, - i - pa->start, &used) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to query port %zu"), i); - goto cleanup; - } - - if (used) + if (virBitmapIsBitSet(pa->bitmap, i - pa->start)) continue; if (!(pa->flags & VIR_PORT_ALLOCATOR_SKIP_BIND_CHECK)) { @@ -269,12 +262,8 @@ int virPortAllocatorSetUsed(virPortAllocatorPtr pa, } if (value) { - bool used = false; - if (virBitmapGetBit(pa->bitmap, port - pa->start, &used) < 0) - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to query port %d"), port); - - if (used || virBitmapSetBit(pa->bitmap, port - pa->start) < 0) { + if (virBitmapIsBitSet(pa->bitmap, port - pa->start) || + virBitmapSetBit(pa->bitmap, port - pa->start) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to reserve port %d"), port); goto cleanup; diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 342bf40..aa00a99 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -407,7 +407,6 @@ virProcessKillPainfully(pid_t pid, bool force) int virProcessSetAffinity(pid_t pid, virBitmapPtr map) { size_t i; - bool set = false; VIR_DEBUG("Set process affinity on %lld\n", (long long)pid); # ifdef CPU_ALLOC /* New method dynamically allocates cpu mask, allowing unlimted cpus */ @@ -433,9 +432,7 @@ int virProcessSetAffinity(pid_t pid, virBitmapPtr map) CPU_ZERO_S(masklen, mask); for (i = 0; i < virBitmapSize(map); i++) { - if (virBitmapGetBit(map, i, &set) < 0) - return -1; - if (set) + if (virBitmapIsBitSet(map, i)) CPU_SET_S(i, masklen, mask); } @@ -457,9 +454,7 @@ int virProcessSetAffinity(pid_t pid, virBitmapPtr map) CPU_ZERO(&mask); for (i = 0; i < virBitmapSize(map); i++) { - if (virBitmapGetBit(map, i, &set) < 0) - return -1; - if (set) + if (virBitmapIsBitSet(map, i)) CPU_SET(i, &mask); } diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index 5e6ef68..7577881 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -232,9 +232,7 @@ xenDomainUsedCpus(virDomainPtr dom, virDomainDefPtr def) cpumap, cpumaplen)) >= 0) { for (n = 0; n < ncpus; n++) { for (m = 0; m < priv->nbNodeCpus; m++) { - bool used; - ignore_value(virBitmapGetBit(cpulist, m, &used)); - if ((!used) && + if (!virBitmapIsBitSet(cpulist, m) && (VIR_CPU_USABLE(cpumap, cpumaplen, n, m))) { ignore_value(virBitmapSetBit(cpulist, m)); nb++; diff --git a/src/xen/xend_internal.c b/src/xen/xend_internal.c index ab03c1c..1722c3f 100644 --- a/src/xen/xend_internal.c +++ b/src/xen/xend_internal.c @@ -1089,10 +1089,7 @@ sexpr_to_xend_topology(const struct sexpr *root, virCapsPtr caps) } for (n = 0, cpu = 0; cpu < numCpus; cpu++) { - bool used; - - ignore_value(virBitmapGetBit(cpuset, cpu, &used)); - if (used) + if (virBitmapIsBitSet(cpuset, cpu)) cpuInfo[n++].id = cpu; } virBitmapFree(cpuset); -- 2.0.5

2 1

[libvirt] [libvirt-test-API][PATCH 0/2] Add connection_getAllDomainStats test case
by jiahu 12 Mar '15

12 Mar '15

The testing case will validate the getAllDomainStats API in class virConnect jiahu (2): Add connection_getAllDomainStats test case to linux_domain.conf Add connection_getAllDomainStats test case cases/linux_domain.conf | 6 + repos/virconn/connection_getAllDomainStats.py | 528 ++++++++++++++++++++++++++ 2 files changed, 534 insertions(+) create mode 100644 repos/virconn/connection_getAllDomainStats.py -- 1.8.3.1

3 4

[libvirt] [libvirt-python PATCHv3 0/2] Python bindings for IOThreads
by John Ferlan 12 Mar '15

12 Mar '15

v2: http://www.redhat.com/archives/libvir-list/2015-February/msg00876.html Changes over v3 based on upstream libvirt API changes: - Change virDomainIOThreadsInfo[Ptr] to virDomainIOThreadInfo[Ptr] - Remove 'nresources' and 'resources' - Less python object manipulation... - Change virDomainSetIOThreads to virDomainPinIOThread John Ferlan (2): Support virDomainGetIOThreadsInfo and virDomainIOThreadsInfoFree Support virDomainPinIOThread generator.py | 6 ++ libvirt-override-api.xml | 14 ++++ libvirt-override.c | 162 +++++++++++++++++++++++++++++++++++++++++++++++ sanitytest.py | 5 ++ 4 files changed, 187 insertions(+) -- 2.1.0

2 5

[libvirt] [PATCH 0/6] Coverity fixes
by John Ferlan 12 Mar '15

12 Mar '15

Some Coverity patches - the first one has been showing up in my dailies for a few days... The other 5 I don't see, but that's because I don't generally build with xenapi in my Coverity environment. So for those, I'm hoping someone with that environment could check them out. John Ferlan (6): conf: Resolve Coverity RESOURCE_LEAK xenapi: Resolve Coverity FORWARD_NULL xenapi: Resolve Coverity NO_EFFECT xenapi: Resolve Coverity NULL_RETURNS xenapi: Resolve Coverity REVERSE_INULL xenapi: Resolve Coverity REVERSE_INULL src/conf/node_device_conf.c | 1 + src/xenapi/xenapi_driver.c | 13 ++++++++----- src/xenapi/xenapi_utils.c | 33 ++++++++++++++++++--------------- 3 files changed, 27 insertions(+), 20 deletions(-) -- 2.1.0

2 13

[libvirt] [PATCH v5 0/5] Introduce display of IOThreads Information
by John Ferlan 12 Mar '15

12 Mar '15

Well technically this is the pinning API's, but keeping the subject the same for continuity sake. v4: http://www.redhat.com/archives/libvir-list/2015-March/msg00262.html Specifically replacing patches 5-9 Changes over v4 - remove the virDomainGetIOThreadPin related code leaving only the virDomainPinIOThread code. Will address jtomko's comments from 3/9 in a separate followup patch John Ferlan (5): Implement public API for virDomainPinIOThread remote: Implement the plumbing for virDomainPinIOThread domain: Introduce virDomainIOThreadsPin{Add|Del} qemu: Add support to pin IOThreads to specific CPU virsh: Add iothreadpin command include/libvirt/libvirt-domain.h | 14 +++ src/conf/domain_conf.c | 64 ++++++++++++ src/conf/domain_conf.h | 10 ++ src/driver-hypervisor.h | 8 ++ src/libvirt-domain.c | 76 ++++++++++++++ src/libvirt_private.syms | 2 + src/libvirt_public.syms | 1 + src/qemu/qemu_driver.c | 221 +++++++++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 17 ++- src/remote_protocol-structs | 10 ++ src/rpc/gendispatch.pl | 1 + tools/virsh-domain.c | 106 +++++++++++++++++++ tools/virsh.pod | 26 +++++ 14 files changed, 556 insertions(+), 1 deletion(-) -- 2.1.0

3 18

[libvirt] [PATCHv2 0/4]add support for graphics to get a IPv6 address
by Luyao Huang 11 Mar '15

11 Mar '15

https://bugzilla.redhat.com/show_bug.cgi?id=1192318 We already support add a IPv6 address to graphics listen address and xml like this: <graphics type='spice' port='5900' autoport='yes' listen='2001b8:ca2:2::1' keymap='en-us'> <listen type='address' address='2001b8:ca2:2::1'/> </graphics> However we do not support get a IPv6 address for the network. add some helpers and rework networkGetNetworkAddress to make it can get a IPv6 address when we need. Luyao Huang (4): util: introduce 2 new helpers for get interface IPv6 address conf: introduce new family attribute in graphics listen for chose IP family network: rework networkGetNetworkAddress to make it can get IPv6 address qemu: fix a error coverd issue in 2 place docs/formatdomain.html.in | 10 ++- docs/schemas/domaincommon.rng | 8 ++ src/conf/domain_conf.c | 20 +++++ src/conf/domain_conf.h | 9 ++ src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 15 ++-- src/network/bridge_driver.h | 6 +- src/qemu/qemu_command.c | 22 +++-- src/util/virnetdev.c | 98 ++++++++++++++++++++++ src/util/virnetdev.h | 4 + .../qemuxml2argv-graphics-listen-network-ipv6.xml | 35 ++++++++ .../qemuxml2argv-graphics-listen-network.xml | 2 +- .../qemuxml2xmlout-graphics-listen-network2.xml | 2 +- tests/qemuxml2xmltest.c | 1 + 14 files changed, 209 insertions(+), 24 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network-ipv6.xml -- 1.8.3.1

3 19

[libvirt] [PATCH 00/12] qemu: Refactor block stats gathering and implement summary stats
by Peter Krempa 11 Mar '15

11 Mar '15

Peter Krempa (12): qemu: Use macro to set block stats typed parameters qemu: monitor: Drop parsing of 'errs' from block info qemu: blockstats: Switch to caller allocated hash table test: qemu: Fix qemu monitor test utils to allow testing HMP qemu: monitor: Implement HMP version for listing all block device stats qemu: monitor: Convert common code to a macro qemu: monitor: Count block stats fields in qemuMonitorGetAllBlockStatsInfo qemu: Split out working code qemuDomainBlockStats qemu: blockstats: Add support for totalled block statistics qemu: blockstats: Refactor qemuDomainBlockStatsFlags test: qemu: json: Avoid using the now obsolete functions qemu: monitor: Kill qemuMonitorGetBlockStats(Info,ParamsNumber) src/qemu/qemu_driver.c | 299 ++++++++++++++++++++----------------------- src/qemu/qemu_monitor.c | 106 ++++++--------- src/qemu/qemu_monitor.h | 15 --- src/qemu/qemu_monitor_json.c | 233 ++++----------------------------- src/qemu/qemu_monitor_json.h | 15 +-- src/qemu/qemu_monitor_text.c | 256 ++++++++++++++---------------------- src/qemu/qemu_monitor_text.h | 16 +-- tests/Makefile.am | 8 +- tests/qemumonitorjsontest.c | 65 ++++------ tests/qemumonitortest.c | 89 ++++++++++++- tests/qemumonitortestutils.c | 3 +- tools/virsh.pod | 5 +- 12 files changed, 425 insertions(+), 685 deletions(-) -- 2.2.2

2 20

[libvirt] [libvirt-test-API][PATCH 0/2] Add test cases for setTime and getTime
by Jincheng Miao 11 Mar '15

11 Mar '15

create some test cases for libvirt-python API setTime and getTime Jincheng Miao (2): Add guest setTime and getTime testing Add test cases for linux_domain cases/linux_domain.conf | 26 +++++++++ repos/domain/guest_time.py | 98 ++++++++++++++++++++++++++++++++ repos/domain/set_guest_time.py | 122 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 246 insertions(+), 0 deletions(-) create mode 100644 repos/domain/guest_time.py create mode 100644 repos/domain/set_guest_time.py

2 3

[libvirt] [PATCH] virnetdev: fix build with old kernel
by Pavel Hrdina 11 Mar '15

11 Mar '15

Commit c9027d8f added a detection of NIC HW features, but some of them are not available in old kernel. Very old kernels lack enum ethtool_flags and even if this enum is present, not all values are available for all kernels. To be sure that we have everything in kernel that we need, we must check for existence of newest value which is ETH_FLAG_TXVLAN. Only then we can be sure that the feature detection can be successfully built. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- configure.ac | 6 ++++++ src/util/virnetdev.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index e071813..3cffb84 100644 --- a/configure.ac +++ b/configure.ac @@ -383,6 +383,12 @@ AC_CHECK_TYPE([struct ifreq], #include <net/if.h> ]]) +AC_CHECK_DECL([ETH_FLAG_TXVLAN], + [AC_DEFINE([HAVE_ETH_FLAG_TXVLAN],[1], + [Defined if ETH_FLAG_TXVLAN exists in linux/ethtool.h])], + [], [[#include <linux/ethtool.h> + ]]) + dnl Our only use of libtasn1.h is in the testsuite, and can be skipped dnl if the header is not present. Assume -ltasn1 is present if the dnl header could be found. diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 971db43..7519579 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -47,7 +47,8 @@ # undef HAVE_STRUCT_IFREQ #endif -#if defined(SIOCETHTOOL) && defined(HAVE_STRUCT_IFREQ) +#if defined(SIOCETHTOOL) && defined(HAVE_STRUCT_IFREQ) && \ + defined(HAVE_ETH_FLAG_TXVLAN) # include <linux/ethtool.h> #endif @@ -2733,7 +2734,8 @@ int virNetDevGetRxFilter(const char *ifname, return ret; } -#if defined(SIOCETHTOOL) && defined(HAVE_STRUCT_IFREQ) +#if defined(SIOCETHTOOL) && defined(HAVE_STRUCT_IFREQ) && \ + defined(HAVE_ETH_FLAG_TXVLAN) /** * virNetDevFeatureAvailable -- 2.0.5

3 2

[libvirt] [PATCH] RNG: Allow multiple parameters to be passed to an interface filter
by Michal Privoznik 11 Mar '15

11 Mar '15

Our code supports that for ages. When using a <filterref/> to an <interface/> several parameters can be passed to the filter. Later, when building firewall rules, parameters are substituted for their values. However, our RNG schema allowed only one parameter to be passed. Reported-by: Brian Rak <brak(a)gameservers.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/schemas/domaincommon.rng | 4 +- .../domain-qemu-interface-filterref.xml | 170 +++++++++++++++++++++ 2 files changed, 172 insertions(+), 2 deletions(-) create mode 100644 tests/domainschemadata/domain-qemu-interface-filterref.xml diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 56ea6a4..b1d883f 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -4530,7 +4530,7 @@ <attribute name="filter"> <data type="NCName"/> </attribute> - <optional> + <zeroOrMore> <element name="parameter"> <attribute name="name"> <ref name="filter-param-name"/> @@ -4539,7 +4539,7 @@ <ref name="filter-param-value"/> </attribute> </element> - </optional> + </zeroOrMore> </define> <define name="deviceBoot"> diff --git a/tests/domainschemadata/domain-qemu-interface-filterref.xml b/tests/domainschemadata/domain-qemu-interface-filterref.xml new file mode 100644 index 0000000..0aa0c99 --- /dev/null +++ b/tests/domainschemadata/domain-qemu-interface-filterref.xml @@ -0,0 +1,170 @@ +<domain type='kvm'> + <name>gentoo</name> + <uuid>a75aca4b-a02f-2bcb-4a91-c93cd848c34b</uuid> + <memory unit='KiB'>4194304</memory> + <currentMemory unit='KiB'>4194304</currentMemory> + <memoryBacking> + <hugepages> + <page size='1048576' unit='KiB' nodeset='0-3'/> + </hugepages> + </memoryBacking> + <vcpu placement='static'>4</vcpu> + <os> + <type arch='x86_64' machine='pc-i440fx-1.4'>hvm</type> + <boot dev='hd'/> + <boot dev='cdrom'/> + </os> + <features> + <acpi/> + <apic/> + <pae/> + </features> + <cpu mode='custom' match='exact'> + <model fallback='allow'>Haswell</model> + <vendor>Intel</vendor> + <feature policy='require' name='tm2'/> + <feature policy='require' name='est'/> + <feature policy='require' name='vmx'/> + <feature policy='require' name='osxsave'/> + <feature policy='require' name='smx'/> + <feature policy='require' name='ss'/> + <feature policy='require' name='ds'/> + <feature policy='require' name='vme'/> + <feature policy='require' name='dtes64'/> + <feature policy='require' name='abm'/> + <feature policy='require' name='ht'/> + <feature policy='require' name='acpi'/> + <feature policy='require' name='pbe'/> + <feature policy='require' name='tm'/> + <feature policy='require' name='pdcm'/> + <feature policy='require' name='pdpe1gb'/> + <feature policy='require' name='ds_cpl'/> + <feature policy='require' name='rdrand'/> + <feature policy='require' name='f16c'/> + <feature policy='require' name='xtpr'/> + <feature policy='require' name='monitor'/> + <numa> + <cell id='0' cpus='0' memory='1048576' unit='KiB'/> + <cell id='1' cpus='1' memory='1048576' unit='KiB'/> + <cell id='2' cpus='2' memory='1048576' unit='KiB'/> + <cell id='3' cpus='3' memory='1048576' unit='KiB'/> + </numa> + </cpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>restart</on_crash> + <pm> + <suspend-to-mem enabled='yes'/> + <suspend-to-disk enabled='yes'/> + </pm> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <disk type='file' device='floppy'> + <driver name='qemu' type='raw' cache='none'/> + <source file='/var/lib/libvirt/images/fd.img'/> + <target dev='fda' bus='fdc'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2'/> + <source file='/var/lib/libvirt/images/gentoo.qcow2'/> + <target dev='vda' bus='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> + </disk> + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2'/> + <source file='/var/lib/libvirt/images/OtherDemo.img'/> + <target dev='vdb' bus='virtio'/> + <encryption format='qcow'> + <secret type='passphrase' uuid='e78d4b51-a2af-485f-b0f5-afca709a80f4'/> + </encryption> + <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> + </disk> + <disk type='file' device='cdrom'> + <driver name='qemu' type='raw' cache='none'/> + <source file='/home/zippy/tmp/install-amd64-minimal-20140619.iso'/> + <target dev='hdc' bus='ide'/> + <readonly/> + <shareable/> + <address type='drive' controller='0' bus='1' target='0' unit='0'/> + </disk> + <controller type='usb' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> + </controller> + <controller type='pci' index='0' model='pci-root'/> + <controller type='ide' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> + </controller> + <controller type='virtio-serial' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x08' function='0x0'/> + </controller> + <controller type='fdc' index='0'/> + <interface type='network'> + <mac address='52:54:00:d6:c0:0b'/> + <source network='default'/> + <bandwidth> + <inbound average='100'/> + <outbound average='100'/> + </bandwidth> + <model type='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> + </interface> + <interface type='bridge'> + <mac address='52:54:00:35:82:59'/> + <source bridge='br0'/> + <model type='rtl8139'/> + <filterref filter='myfilter'> + <parameter name='CTRL_IP_LEARNING' value='none'/> + <parameter name='DHCPSERVER' value='104.156.226.10'/> + <parameter name='IP' value='104.207.129.11'/> + <parameter name='IP6_ADDR' value='2001:19f0:300:2102::'/> + <parameter name='IP6_MASK' value='64'/> + </filterref> + <address type='pci' domain='0x0000' bus='0x00' slot='0x0b' function='0x0'/> + </interface> + <interface type='server'> + <mac address='52:54:00:22:c9:42'/> + <source address='127.0.0.1' port='1234'/> + <bandwidth> + <inbound average='1234'/> + <outbound average='5678'/> + </bandwidth> + <model type='rtl8139'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/> + </interface> + <interface type='client'> + <mac address='52:54:00:8c:b1:f8'/> + <source address='127.0.0.1' port='1234'/> + <model type='rtl8139'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x0a' function='0x0'/> + </interface> + <serial type='pty'> + <target port='0'/> + </serial> + <serial type='pty'> + <target port='1'/> + </serial> + <console type='pty'> + <target type='serial' port='0'/> + </console> + <channel type='unix'> + <source mode='bind' path='/var/lib/libvirt/qemu/channel/target/gentoo.org.qemu.guest_agent.0'/> + <target type='virtio' name='org.qemu.guest_agent.0'/> + <address type='virtio-serial' controller='0' bus='0' port='1'/> + </channel> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <graphics type='vnc' port='-1' autoport='yes'/> + <sound model='ich6'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> + </sound> + <video> + <model type='cirrus' vram='16384' heads='1'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> + </video> + <memballoon model='virtio'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> + </memballoon> + </devices> +</domain> -- 2.0.5

2 1

[libvirt] [PATCH 0/4] parallels: fix different domain define parameters
by Maxim Nestratov 11 Mar '15

11 Mar '15

Actually our checking for unsupported parameters is too strict about cpumask, vcpupin and NUMA parameters and in general wrong. First of all, we do support cpumask and consequently we don't have to prevent domain definition in case cpumask is specified. Also we should allow vcpupin parameters if they don't contradict with common cpumask. NUMA checking was also wrong because def->numa is always allocated. Here we check that its content is not specified. Maxim Nestratov (4): parallels: cpumask support parallels: don't forget to unlock domain in parallelsDomainHasManagedSaveImage parallels: prevent domain define only if NUMA is really specified parallels: prevent domain define only if vcpupin is specified

2 8

[libvirt] [libvirt-test-API][PATCH 0/2] Add securitylabel test case
by jiahu 11 Mar '15

11 Mar '15

The test case will check securityLabel() and securityLabelList() APIs. jiahu (2): Add securitylabel test case to linux_domain.conf Add securitylabel test case cases/linux_domain.conf | 4 + repos/domain/securitylabel.py | 170 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 174 insertions(+) create mode 100644 repos/domain/securitylabel.py -- 1.8.3.1

2 3

[libvirt] [PATCH v3 0/5] Add support for graphics to get a IPv6 address
by John Ferlan 11 Mar '15

11 Mar '15

Update to Luyao's series - figured I'd repost just to make it easier rather than continued replies... v2 here: http://www.redhat.com/archives/libvir-list/2015-February/msg01228.html Changes since v2: * Split patch 1 into two parts - one to create the IPAddress shim that just calls the existing (and now static) IPv4 code. * Adjust remainder of patches according to my review comments (hopefully and thus why I'm reposting) John Ferlan (1): util: Replace virNetDevGetIPv4Address with virNetDevGetIPAddress Luyao Huang (4): util: Update virNetDevGetIPAddress to add IPv6 boolean conf: Add 'family' attribute to <graphics> 'listen' element network: Allow networkGetNetworkAddress to return IPv6 address qemu: Remove unnecessary virReportError on networkGetNetworkAddress return docs/formatdomain.html.in | 14 ++- docs/schemas/domaincommon.rng | 8 ++ src/conf/domain_conf.c | 21 ++++ src/conf/domain_conf.h | 10 ++ src/libvirt_private.syms | 2 +- src/network/bridge_driver.c | 17 +-- src/network/bridge_driver.h | 6 +- src/qemu/qemu_command.c | 22 ++-- src/util/virnetdev.c | 121 +++++++++++++++++++-- src/util/virnetdev.h | 7 +- .../qemuxml2argv-graphics-listen-network-ipv4.xml | 35 ++++++ .../qemuxml2argv-graphics-listen-network-ipv6.xml | 35 ++++++ tests/qemuxml2xmltest.c | 2 + 13 files changed, 263 insertions(+), 37 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network-ipv4.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-listen-network-ipv6.xml -- 2.1.0

2 10

[libvirt] [libvirt-test-API][PATCH V2 0/2] Add freepages test cases
by Jincheng Miao 11 Mar '15

11 Mar '15

Add freepages test cases. V2: Assign ps.strip().upper() to ps variable in free_page.py Jincheng Miao (2): Add freepage test Add freepage test case to test_connection.conf cases/test_connection.conf | 6 +++ repos/virconn/free_pages.py | 97 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 103 insertions(+), 0 deletions(-) create mode 100644 repos/virconn/free_pages.py

3 4

[libvirt] [PATCH] domain_conf: fix crash in virDomainObjListFindByUUIDInternal
by Michael Chapman 11 Mar '15

11 Mar '15

If a domain object is being removed and looked up concurrently we must ensure we unlock the object before unreferencing it, since the latter might free the object. Signed-off-by: Michael Chapman <mike(a)very.puzzling.org> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cc8616b..ce0e173 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1068,9 +1068,9 @@ virDomainObjListFindByUUIDInternal(virDomainObjListPtr doms, if (obj) { virObjectLock(obj); if (obj->removing) { + virObjectUnlock(obj); if (ref) virObjectUnref(obj); - virObjectUnlock(obj); obj = NULL; } } -- 2.1.0

2 1

[libvirt] [PATCH 0/3] virBitmapGetBit cleanups
by Ján Tomko 11 Mar '15

11 Mar '15

Return bool instead of ignoring the return value almost everywhere. Ján Tomko (3): Use virBitmapNextClearBit in networkNextClassID Return bool in virBitmapGetBit Reverse the logic in virbitmaptest src/conf/domain_conf.c | 4 +--- src/conf/node_device_conf.c | 4 +--- src/conf/snapshot_conf.c | 6 ++---- src/conf/storage_conf.c | 4 +--- src/libxl/libxl_domain.c | 4 +--- src/libxl/libxl_driver.c | 5 +---- src/network/bridge_driver.c | 8 +++----- src/nodeinfo.c | 6 +----- src/qemu/qemu_capabilities.c | 8 +++----- src/qemu/qemu_command.c | 12 +----------- src/qemu/qemu_driver.c | 15 +++------------ src/qemu/qemu_process.c | 13 ++++--------- src/storage/storage_backend.c | 4 +--- src/test/test_driver.c | 5 +---- src/util/virbitmap.c | 13 +++++-------- src/util/virbitmap.h | 6 +++--- src/util/vircgroup.c | 4 +--- src/util/virdnsmasq.c | 7 ++----- src/util/virportallocator.c | 14 ++------------ src/util/virprocess.c | 9 ++------- src/xen/xen_driver.c | 4 +--- src/xen/xend_internal.c | 5 +---- tests/virbitmaptest.c | 18 ++++-------------- tools/virsh-domain.c | 6 ++---- 24 files changed, 47 insertions(+), 137 deletions(-) -- 2.0.5

3 8

[libvirt] [PATCH] {domain, network}_conf: disable autostart when deleting config
by Michael Chapman 11 Mar '15

11 Mar '15

Undefining a running, autostarted domain removes the autostart link, but dom->autostart is not cleared. If the domain is subsequently redefined, libvirt thinks it is already autostarted and will not create the link even if requested: # virsh dominfo example | grep Autostart Autostart: enable # ls /etc/libvirt/qemu/autostart/example.xml /etc/libvirt/qemu/autostart/example.xml # virsh undefine example Domain example has been undefined # virsh define example.xml Domain example defined from example.xml # virsh dominfo example | grep Autostart Autostart: enable # virsh autostart example Domain example marked as autostarted # ls /etc/libvirt/qemu/autostart/example.xml ls: cannot access /etc/libvirt/qemu/autostart/example.xml: No such file or directory This commit ensures dom->autostart is cleared whenever the config and autostart link (if present) are removed. The bridge network driver cleared this flag itself in networkUndefine. This commit moves this into virNetworkDeleteConfig for symmetry with virDomainDeleteConfig, and to ensure it is not missed in future network drivers. Signed-off-by: Michael Chapman <mike(a)very.puzzling.org> --- src/conf/domain_conf.c | 1 + src/conf/network_conf.c | 1 + src/network/bridge_driver.c | 1 - 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cc8616b..a8f4ce2 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -20998,6 +20998,7 @@ virDomainDeleteConfig(const char *configDir, /* Not fatal if this doesn't work */ unlink(autostartLink); + dom->autostart = 0; if (unlink(configFile) < 0 && errno != ENOENT) { diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 9c1d578..779a08a 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -3077,6 +3077,7 @@ int virNetworkDeleteConfig(const char *configDir, /* Not fatal if this doesn't work */ unlink(autostartLink); + net->autostart = 0; if (unlink(configFile) < 0) { virReportSystemError(errno, diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 5752acb..5158078 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3050,7 +3050,6 @@ networkUndefine(virNetworkPtr net) driver->networkAutostartDir, network) < 0) goto cleanup; - network->autostart = 0; event = virNetworkEventLifecycleNew(network->def->name, network->def->uuid, -- 2.1.0

2 1

[libvirt] CfP 10th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '15)
by VHPC 15 11 Mar '15

11 Mar '15

================================================================= CALL FOR PAPERS 10th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '15) held in conjunction with Euro-Par 2015, August 24-28, Vienna, Austria (Springer LNCS) ================================================================= Date: August 25, 2015 Workshop URL: http://vhpc.org Paper Submission Deadline: May 22, 2015 CALL FOR PAPERS Virtualization technologies constitute a key enabling factor for flexible resource management in modern data centers, cloud environments, and increasingly in HPC as well. Providers need to dynamically manage complex infrastructures in a seamless fashion for varying workloads and hosted applications, independently of the customers deploying software or users submitting highly dynamic and heterogeneous workloads. Thanks to virtualization, we have the ability to manage vast computing and networking resources dynamically and close to the marginal cost of providing the services, which is unprecedented in the history of scientific and commercial computing. Various virtualization technologies contribute to the overall picture in different ways: machine virtualization, with its capability to enable consolidation of multiple under-utilized servers with heterogeneous software and operating systems (OSes), and its capability to live-migrate a fully operating virtual machine (VM) with a very short downtime, enables novel and dynamic ways to manage physical servers; OS-level virtualization, with its capability to isolate multiple user-space environments and to allow for their co-existence within the same OS kernel, promises to provide many of the advantages of machine virtualization with high levels of responsiveness and performance; I/O Virtualization allows physical network adapters to take traffic from multiple VMs; network virtualization, with its capability to create logical network overlays that are independent of the underlying physical topology and IP addressing, provides the fundamental ground on top of which evolved network services can be realized with an unprecedented level of dynamicity and flexibility; These technologies have to be inter-mixed and integrated in an intelligent way, to support workloads that are increasingly demanding in terms of absolute performance, responsiveness and interactivity, and have to respect well-specified Service- Level Agreements (SLAs), as needed for industrial-grade provided services. Indeed, among emerging and increasingly interesting application domains for virtualization, we can find big-data application workloads in cloud infrastructures, interactive and real-time multimedia services in the cloud, including real-time big-data streaming platforms such as used in real-time analytics supporting nowadays a plethora of application domains. Distributed cloud infrastructures promise to offer unprecedented responsiveness levels for hosted applications, but that is only possible if the underlying virtualization technologies can overcome most of the latency impairments typical of current virtualized infrastructures (e.g., far worse tail-latency). The Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims to bring together researchers and industrial practitioners facing the challenges posed by virtualization in order to foster discussion, collaboration, mutual exchange of knowledge and experience, enabling research to ultimately provide novel solutions for virtualized computing systems of tomorrow. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections, and lightning talks, limited to 5 minutes. Presentations may be accompanied by interactive demonstrations. TOPICS Topics of interest include, but are not limited to: - Virtualization in supercomputing environments, HPC clusters, cloud HPC and grids - Optimizations of virtual machine monitor platforms, hypervisors and OS-level virtualization - Hypervisor and network virtualization QoS and SLAs - Cloud based network and system management for SDN and NFV - Management, deployment and monitoring of virtualized environments - Performance measurement, modelling and monitoring of virtualized/cloud workloads - Programming models for virtualized environments - Cloud reliability, fault-tolerance, high-availability and security - Heterogeneous virtualized environments, virtualized accelerators, GPUs and co-processors - Optimized communication libraries/protocols in the cloud and for HPC in the cloud - Topology management and optimization for distributed virtualized applications - Cluster provisioning in the cloud and cloud bursting - Adaptation of emerging HPC technologies (high performance networks, RDMA, etc..) - I/O and storage virtualization, virtualization aware file systems - Job scheduling/control/policy in virtualized environments - Checkpointing and migration of VM-based large compute jobs - Cloud frameworks and APIs - Energy-efficient / power-aware virtualization Important Dates April 29, 2015 - Abstract registration May 22, 2015 - Full paper submission June 19, 2014 - Acceptance notification October 2, 2014 - Camera-ready version due August 25, 2014 - Workshop Date TPC CHAIR Michael Alexander (chair), TU Wien, Austria Anastassios Nanos (co-chair), NTUA, Greece Balazs Gerofi (co-chair), RIKEN Advanced Institute for Computational Science, Japan PROGRAM COMMITTEE Stergios Anastasiadis, University of Ioannina, Greece Costas Bekas, IBM Zurich Research Laboratory, Switzerland Jakob Blomer, CERN Ron Brightwell, Sandia National Laboratories, USA Roberto Canonico, University of Napoli Federico II, Italy Julian Chesterfield, OnApp, UK Patrick Dreher, MIT, USA William Gardner, University of Guelph, Canada Kyle Hale, Northwestern University, USA Marcus Hardt, Karlsruhe Institute of Technology, Germany Iftekhar Hussain, Infinera, USA Krishna Kant, Temple University, USA Eiji Kawai, National Institute of Information and Communications Technology, Japan Romeo Kinzler, IBM, Switzerland Kornilios Kourtis, ETH, Switzerland Nectarios Koziris, National Technical University of Athens, Greece Massimo Lamanna, CERN Che-Rung Roger Lee, National Tsing Hua University, Taiwan Helge Meinhard, CERN Jean-Marc Menaud, Ecole des Mines de Nantes France Christine Morin, INRIA, France Amer Qouneh, University of Florida, USA Seetharami Seelam, IBM Watson Research Center, USA Josh Simons, VMWare, USA Borja Sotomayor, University of Chicago, USA Kurt Tutschku, Blekinge Institute of Technology, Sweden Yasuhiro Watashiba, Osaka University, Japan Chao-Tung Yang, Tunghai University, Taiwan PAPER SUBMISSION-PUBLICATION Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, key words, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in the Springer LNCS series - the format must be according to the Springer LNCS Style. Initial submissions are in PDF; authors of accepted papers will be requested to provide source files. Format Guidelines: http://www.springer.de/comp/lncs/authors.html Submission Link: https://easychair.org/conferences/?conf=europar2015ws GENERAL INFORMATION The workshop is one day in length and will be held in conjunction with Euro-Par 2015, 24-28 August, Vienna, Austria

1 0

[libvirt] [PATCH] qemu: fix memory leak in qemuAgentGetFSInfo
by Chen Fan 10 Mar '15

10 Mar '15

in virDomainFSInfoFree(), don't free the virDomainFSInfo data. ==10670== 80 bytes in 2 blocks are definitely lost in loss record 576 of 793 ==10670== at 0x4A06BC3: calloc (vg_replace_malloc.c:618) ==10670== by 0x509DEBD: virAlloc (viralloc.c:144) ==10670== by 0x19FBD558: qemuAgentGetFSInfo (qemu_agent.c:1837) ==10670== by 0x1A03CF91: qemuDomainGetFSInfo (qemu_driver.c:19238) Signed-off-by: Chen Fan <chen.fan.fnst(a)cn.fujitsu.com> --- src/libvirt-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 04545fd..7f8a7ce 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11337,4 +11337,6 @@ virDomainFSInfoFree(virDomainFSInfoPtr info) for (i = 0; i < info->ndevAlias; i++) VIR_FREE(info->devAlias[i]); VIR_FREE(info->devAlias); + + VIR_FREE(info); } -- 1.9.3

4 5

[libvirt] [PATCH] virQEMUCapsInitQMP: Don't dispose locked @vm
by Michal Privoznik 10 Mar '15

10 Mar '15

When creating qemu capabilities, a dummy virDomainObj is created just because our monitor code expects that. However, the object is created locked already. Then, under cleanup label, we simply unref the object which results in whole domain object to be disposed. The object lock is destroyed subsequently, but hey - it's still locked: ==24845== Thread #14's call to pthread_mutex_destroy failed ==24845== with error code 16 (EBUSY: Device or resource busy) ==24845== at 0x4C3024E: pthread_mutex_destroy (in /usr/lib64/valgrind/vgpreload_helgrind-amd64-linux.so) ==24845== by 0x531F72E: virMutexDestroy (virthread.c:83) ==24845== by 0x5302977: virObjectLockableDispose (virobject.c:237) ==24845== by 0x5302A89: virObjectUnref (virobject.c:265) ==24845== by 0x1DD37866: virQEMUCapsInitQMP (qemu_capabilities.c:3397) ==24845== by 0x1DD37CC6: virQEMUCapsNewForBinary (qemu_capabilities.c:3481) ==24845== by 0x1DD381E2: virQEMUCapsCacheLookup (qemu_capabilities.c:3609) ==24845== by 0x1DD30F8A: virQEMUCapsInitGuest (qemu_capabilities.c:744) ==24845== by 0x1DD31889: virQEMUCapsInit (qemu_capabilities.c:1020) ==24845== by 0x1DD7DD36: virQEMUDriverCreateCapabilities (qemu_conf.c:888) ==24845== by 0x1DDC57C0: qemuStateInitialize (qemu_driver.c:803) ==24845== by 0x53DC743: virStateInitialize (libvirt.c:777) ==24845== Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_capabilities.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 8193805..dce40e0 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3394,7 +3394,10 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps, if (monpath) ignore_value(unlink(monpath)); VIR_FREE(monpath); - virObjectUnref(vm); + if (vm) { + virObjectUnlock(vm); + virObjectUnref(vm); + } virObjectUnref(xmlopt); if (pid != 0) { -- 2.0.5

2 1

[libvirt] [PATCH 0/6] Follow-up patches for IOThread API/display
by John Ferlan 10 Mar '15

10 Mar '15

Based on jtomko's review of the IOThread series and my foray into the libvirt-perl bindings, these patches make the following adjustments: Patch 1 - Found while generating the virsh iothreadpin description, the vcpupin description had a few missing words Patch 2 - While working on the libvirt-perl bindings - I found I was a bit overaggressive with my GetIOThreadsInfo interface with regard to checking ReadOnly unnecessarily Patch 3 - Adjust the IOThread CPU Affnity algorithm based on jtomko's review comments Patch 4 - Fallout because I ran the patches through my Coverity checker. Patch 5 - Similar to IOThread - adjust the GetVcpuInfo CPU Affinity algorithm for the returned cpumap Patch 5 - Similar to IOThread - adjust the GetEmulatorInfo CPU Affinity algorithm for the returned cpumap John Ferlan (6): Fix syntax for vcpupin description Remove ReadOnly check for GetIOThreadsInfo qemu: Change/Fix IOThread CPU affinity bitmap manipulation qemu: Resolve Coverity CHECKED_RETURN issue qemu: Change qemuDomainGetVcpuPinInfo bitmap manipulation qemu: Change qemuDomainGetEmulatorPinInfo bitmap manipulation src/libvirt-domain.c | 1 - src/qemu/qemu_driver.c | 177 +++++++++++++++++++++---------------------------- tools/virsh.pod | 4 +- 3 files changed, 76 insertions(+), 106 deletions(-) -- 2.1.0

2 10

[libvirt] [PATCH] qemu: don't fill in nicindexes for session mode libvirtd
by Laine Stump 10 Mar '15

10 Mar '15

Commit 4bbe1029f fixed a problem in commit f7afeddc by moving the call to virNetDevGetIndex() to a location common to all interface types (so that the niceindex array would be filled in for macvtap as well as tap interfaces), but the location was *too* common, as the original call to virNetDevGetIndex() had been in a section qualified by "if (cfg->privileged)". The result was that the "fixed" libvirtd would try to call virNetDevGetIndex() even for session mode libvirtd, and end up failing with the log message: Unable to open control socket: Operation not permitted To remedy that, this patch qualifies the call to virNetDevGetIndex() in its new location with cfg->privileged. This resolves https://bugzilla.redhat.com/show_bug.cgi?id=1198244 --- If someone (Rich?) needs this pushed before I am awake, please feel free to push it. (also push to the 1.2.13-maint branch if you do) src/qemu/qemu_command.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 1510797..3d1483e 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7861,6 +7861,7 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, char **tapfdName = NULL; char **vhostfdName = NULL; int actualType = virDomainNetGetActualType(net); + virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); virNetDevBandwidthPtr actualBandwidth; size_t i; @@ -7936,7 +7937,7 @@ qemuBuildInterfaceCommandLine(virCommandPtr cmd, /* network and bridge use a tap device, and direct uses a * macvtap device */ - if (nicindexes && nnicindexes && net->ifname) { + if (cfg->privileged && nicindexes && nnicindexes && net->ifname) { if (virNetDevGetIndex(net->ifname, &nicindex) < 0 || VIR_APPEND_ELEMENT(*nicindexes, *nnicindexes, nicindex) < 0) goto cleanup; -- 2.1.0

4 4

[libvirt] [PATCH] virnet*: Don't unlock object in dispose
by Michal Privoznik 10 Mar '15

10 Mar '15

As of bba93d40 all of our RPC objects are derived from virObjectLockable. However, during rewrite some errors sneaked in. For instance, the dispose functions to virNetClient and virNetServerClient objects were not only freeing allocated memory, but unlocking themselves. This is wrong. Object should never disappear while locked. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/rpc/virnetclient.c | 2 -- src/rpc/virnetserverclient.c | 1 - 2 files changed, 3 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index d7455b5..7fca055 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -622,8 +622,6 @@ void virNetClientDispose(void *obj) #endif virNetMessageClear(&client->msg); - - virObjectUnlock(client); } diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index b2a4fdf..f5259c2 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -866,7 +866,6 @@ void virNetServerClientDispose(void *obj) virObjectUnref(client->tlsCtxt); #endif virObjectUnref(client->sock); - virObjectUnlock(client); } -- 2.0.5

2 1

[libvirt] [PATCH v3 00/10] Network enhancements and other fixes
by Maxim Nestratov 10 Mar '15

10 Mar '15

Maxim Nestratov (9): parallels: don't forget to unlock domain if unregister fails parallels: fix home directory for VMs parallels: minor cleanup parallels: introduce and use string constants for network types and names parallels: fix parallelsLoadNetworks parallels: better bridge network interface support parallels: set network adapter device status to connected parallels: make E1000 network adapter type default parallels: switch off offline management feature Mikhail Feoktistov (1): parallels: set cpu mode when applying xml configuration

1 12

[libvirt] [PATCH 0/7] parallels: bridge network support enhancement and other network fixes
by Maxim Nestratov 10 Mar '15

10 Mar '15

Maxim Nestratov (7): parallels: introduce and use string constants for network types and names parallels: fix parallelsLoadNetworks parallels: better bridge network interface support parallels: set network adapter device status to connected parallels: make E1000 network adapter type default parallels: switch off offline management feature parallels: don't prevent domain start if VIR_DOMAIN_NET_TYPE_BRIDGE

1 7

[libvirt] [PATCH 0/4] parallels: fixes and cleanups
by Maxim Nestratov 10 Mar '15

10 Mar '15

Maxim Nestratov (3): parallels: don't forget to unlock domain if unregister fails parallels: fix home directory for VMs parallels: minor cleanup Mikhail Feoktistov (1): parallels: set cpu mode when applying xml configuration

1 4

[libvirt] OVMF whitepaper released
by Laszlo Ersek 10 Mar '15

10 Mar '15

http://people.redhat.com/~lersek/ovmf-whitepaper-c770f8c.txt (An official Red Hat whitepaper PDF edition, for graphical displays, is in the works. As time and technical hurdles allow, both the plain text and the PDF editions shall appear under <http://www.linux-kvm.org/page/OVMF> too, replacing the stale article currently visible there.) Feedback is welcome. For public feedback, please trim the address list to <edk2-devel(a)lists.sourceforge.net> and yours truly; my intent is to spam qemu-devel, linux-efi and libvir-list just this once. (Appropriate levels of embarrassment are already being felt for spamming those.) Thanks Laszlo

1 0

[libvirt] [PATCH v2] docs: add a note that spice channel is usable only with spice graphics
by Pavel Hrdina 10 Mar '15

10 Mar '15

To prevent a confusion about missing chardev argument in qemu command line add a note about that behavior into documentation. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- docs/formatdomain.html.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index fb0a0d1..2f2976c 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5372,6 +5372,10 @@ qemu-kvm -net nic,model=? /dev/null under a channel name specified in the <code>channel</code> attribute. <span class="since">Since 1.2.2</span> </p> + <p> + Note: in order for the spiceport to be usable, the domain must have + spice graphics as well. + </p> <pre> ... -- 2.0.5

2 2

[libvirt] [PATCH v9 0/4] Introduce API to query IP addresses for given domain
by Daniel P. Berrange 10 Mar '15

10 Mar '15

This polishes off Nehal's long standing work to add IP address reporting to libvirt. In v9 I address John's coverity comments and switched to use an dedicated parameter for selecting the data source, instead of flags. Nehal J Wani (4): domifaddr: Implement the public APIs domifaddr: Implement the remote protocol domifaddr: Implement the API for qemu domifaddr: Add virsh support daemon/remote.c | 135 ++++++++++++++++++++++++++ include/libvirt/libvirt-domain.h | 28 ++++++ src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c | 123 +++++++++++++++++++++++ src/libvirt_public.syms | 2 + src/qemu/qemu_agent.c | 204 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_agent.h | 4 + src/qemu/qemu_driver.c | 175 +++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 104 ++++++++++++++++++++ src/remote/remote_protocol.x | 37 ++++++- src/remote_protocol-structs | 25 +++++ tests/qemuagenttest.c | 188 ++++++++++++++++++++++++++++++++++++ tools/virsh-domain-monitor.c | 146 ++++++++++++++++++++++++++++ tools/virsh.pod | 16 +++ 14 files changed, 1192 insertions(+), 1 deletion(-) -- 2.1.0

2 5

[libvirt] [PATCH] network_conf: check sysfs if the bridge exists on host for user created bridges
by Shivaprasad G Bhat 09 Mar '15

09 Mar '15

The patch fixes the below problem. ============================== If the bridge name is not mentioned in the <network> xml, the bridge name is auto generated from virNetworkAllocateBridge(). If the default template named bridge is created manually by a user, the bridge start will fail with "File exists". bash-4.3$ sudo brctl addbr virbr1 bash-4.3$ brctl show bridge name bridge id STP enabled interfaces br0 8000.000000000000 no virbr0 8000.525400a91d03 yes virbr0-nic virbr1 8000.000000000000 no bash-4.3$ sudo virsh net-list --all Name State Autostart Persistent ---------------------------------------------------------- default active no yes bash-4.3$ cat /tmp/isolated # Notice that the <bridge> intentionally not given. <network> <name>isolated</name> <forward/> <ip address="192.168.123.1" netmask="255.255.255.0"> <dhcp> <range start="192.168.123.2" end="192.168.123.254"/> </dhcp> </ip> </network> bash-4.3$ sudo virsh net-create /tmp/isolated error: Failed to create network from isolated error: Unable to create bridge virbr1: File exists =============================== --- The following series implements... Shivaprasad G Bhat (1): network_conf: check sysfs if the bridge exists on host for user created bridges src/conf/network_conf.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) -- Signature

3 3

[libvirt] [PATCH 0/3] update and unify some documentation texts
by Pavel Hrdina 09 Mar '15

09 Mar '15

Pavel Hrdina (3): iface-define: update and unify documentation pool-define: update and unify documentation net-define: update or unify documentation src/libvirt-interface.c | 3 ++- src/libvirt-network.c | 3 ++- src/libvirt-storage.c | 4 ++-- tools/virsh-interface.c | 5 +++-- tools/virsh-network.c | 5 +++-- tools/virsh-pool.c | 5 +++-- tools/virsh.pod | 11 ++++++----- 7 files changed, 21 insertions(+), 15 deletions(-) -- 2.0.5

2 5

[libvirt] [PATCH v2] qemu: bulk stats: implement (cpu) tune group.
by Francesco Romani 09 Mar '15

09 Mar '15

Management applications, like oVirt, may need to setup cpu quota limits to enforce QoS for domains. For this purpose, management applications also need to check how domains are behaving with respect to CPU quota. This data is available using the virDomainGetSchedulerParameters API. This patch adds a new group to bulk stats API to obtain the same information. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1191428 --- include/libvirt/libvirt-domain.h | 1 + src/libvirt-domain.c | 16 ++++++++ src/qemu/qemu_driver.c | 84 ++++++++++++++++++++++++++++++++++++++++ tools/virsh-domain-monitor.c | 7 ++++ tools/virsh.pod | 10 ++++- 5 files changed, 117 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index a9d3efd..a283f93 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1723,6 +1723,7 @@ typedef enum { VIR_DOMAIN_STATS_VCPU = (1 << 3), /* return domain virtual CPU info */ VIR_DOMAIN_STATS_INTERFACE = (1 << 4), /* return domain interfaces info */ VIR_DOMAIN_STATS_BLOCK = (1 << 5), /* return domain block info */ + VIR_DOMAIN_STATS_TUNE_CPU = (1 << 6), /* return domain CPU tuning info */ } virDomainStatsTypes; typedef enum { diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 89d1eab..b451299 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11004,6 +11004,22 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * "block.<num>.physical" - physical size in bytes of the container of the * backing image as unsigned long long. * + * VIR_DOMAIN_STATS_TUNE_CPU: Return CPU tuning statistics + * and usage information. + * The typed parameter keys are in this format: + * "tune.vcpu.quota" - max allowed bandwidth, in microseconds, as + * long long integer. -1 means 'infinite'. + * "tune.vcpu.period" - timeframe on which the virtual cpu quota is + * enforced, in microseconds, as unsigned long long. + * "tune.emu.quota" - max allowed bandwidth for emulator threads, + * in microseconds, as long long integer. + * -1 means 'infinite'. + * "tune.emu.period" - timeframe on which the emulator quota is + * enforced, in microseconds, as unsigned long long. + * "tune.cpu.shares" - weight of this domain. This value is meaningful + * only if compared with the other values of + * the running domains. Expressed as unsigned long long. + * * Note that entire stats groups or individual stat fields may be missing from * the output in case they are not supported by the given hypervisor, are not * applicable for the current state of the guest domain, or their retrieval diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ffa4e19..a810fa5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -18768,6 +18768,89 @@ qemuDomainGetStatsBlock(virQEMUDriverPtr driver, #undef QEMU_ADD_COUNT_PARAM + +#define QEMU_ADD_PARAM_LL(record, maxparams, name, value) \ +do { \ + if (virTypedParamsAddLLong(&(record)->params, \ + &(record)->nparams, \ + maxparams, \ + name, \ + value) < 0) \ + goto cleanup; \ +} while (0) + +#define QEMU_ADD_PARAM_ULL(record, maxparams, name, value) \ +do { \ + if (virTypedParamsAddULLong(&(record)->params, \ + &(record)->nparams, \ + maxparams, \ + name, \ + value) < 0) \ + goto cleanup; \ +} while (0) + +static int +qemuDomainGetStatsCpuTune(virQEMUDriverPtr driver, + virDomainObjPtr dom, + virDomainStatsRecordPtr record, + int *maxparams, + unsigned int privflags ATTRIBUTE_UNUSED) +{ + int ret = -1; + unsigned long long shares = 0; + qemuDomainObjPrivatePtr priv = dom->privateData; + virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); + + if (!cfg->privileged || + !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPU)) { + ret = 0; + goto cleanup; + } + + if (virCgroupGetCpuShares(priv->cgroup, &shares) < 0) { + ret = 0; + goto cleanup; + } + + QEMU_ADD_PARAM_ULL(record, maxparams, "tune.cpu.shares", shares); + + if (virCgroupSupportsCpuBW(priv->cgroup)) { + unsigned long long period = 0; + long long quota = 0; + unsigned long long emulator_period = 0; + long long emulator_quota = 0; + int err; + + err = qemuGetVcpusBWLive(dom, &period, &quota); + if (!err) { + QEMU_ADD_PARAM_ULL(record, maxparams, + "tune.vcpu.period", period); + QEMU_ADD_PARAM_LL(record, maxparams, + "tune.vcpu.quota", quota); + } + + err = qemuGetEmulatorBandwidthLive(dom, priv->cgroup, + &emulator_period, &emulator_quota); + if (!err) { + QEMU_ADD_PARAM_ULL(record, maxparams, + "tune.emu.period", emulator_period); + QEMU_ADD_PARAM_LL(record, maxparams, + "tune.emu.quota", emulator_quota); + } + } + + ret = 0; + + cleanup: + virObjectUnref(cfg); + return ret; +} + +#undef QEMU_ADD_PARAM_LL + +#undef QEMU_ADD_PARAM_ULL + + typedef int (*qemuDomainGetStatsFunc)(virQEMUDriverPtr driver, virDomainObjPtr dom, @@ -18788,6 +18871,7 @@ static struct qemuDomainGetStatsWorker qemuDomainGetStatsWorkers[] = { { qemuDomainGetStatsVcpu, VIR_DOMAIN_STATS_VCPU, false }, { qemuDomainGetStatsInterface, VIR_DOMAIN_STATS_INTERFACE, false }, { qemuDomainGetStatsBlock, VIR_DOMAIN_STATS_BLOCK, true }, + { qemuDomainGetStatsCpuTune, VIR_DOMAIN_STATS_TUNE_CPU, false }, { NULL, 0, false } }; diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 464ac11..ede433d 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -2017,6 +2017,10 @@ static const vshCmdOptDef opts_domstats[] = { .type = VSH_OT_BOOL, .help = N_("report domain block device statistics"), }, + {.name = "tune-cpu", + .type = VSH_OT_BOOL, + .help = N_("report domain cpu scheduler parameters"), + }, {.name = "list-active", .type = VSH_OT_BOOL, .help = N_("list only active domains"), @@ -2127,6 +2131,9 @@ cmdDomstats(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptBool(cmd, "block")) stats |= VIR_DOMAIN_STATS_BLOCK; + if (vshCommandOptBool(cmd, "tune-cpu")) + stats |= VIR_DOMAIN_STATS_TUNE_CPU; + if (vshCommandOptBool(cmd, "list-active")) flags |= VIR_CONNECT_GET_ALL_DOMAINS_STATS_ACTIVE; diff --git a/tools/virsh.pod b/tools/virsh.pod index 1f71c91..bcc966e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -828,6 +828,7 @@ or unique source names printed by this command. =item B<domstats> [I<--raw>] [I<--enforce>] [I<--backing>] [I<--state>] [I<--cpu-total>] [I<--balloon>] [I<--vcpu>] [I<--interface>] [I<--block>] +[I<--tune-cpu>] [[I<--list-active>] [I<--list-inactive>] [I<--list-persistent>] [I<--list-transient>] [I<--list-running>] [I<--list-paused>] [I<--list-shutoff>] [I<--list-other>]] | [I<domain> ...] @@ -846,7 +847,7 @@ behavior use the I<--raw> flag. The individual statistics groups are selectable via specific flags. By default all supported statistics groups are returned. Supported statistics groups flags are: I<--state>, I<--cpu-total>, I<--balloon>, -I<--vcpu>, I<--interface>, I<--block>. +I<--vcpu>, I<--interface>, I<--block>, I<--tune-cpu>. When selecting the I<--state> group the following fields are returned: "state.state" - state of the VM, returned as number from virDomainState enum, @@ -906,6 +907,13 @@ local file or block device, "block.<num>.capacity" - logical size of source file in bytes, "block.<num>.physical" - physical size of source file in bytes +I<--tune-cpu> returns: +"tune.vcpu.quota" - max allowed bandwidth, in microseconds, +"tune.vcpu.period" - timeframe for enforcing the vcpu quota, in microseconds, +"tune.emu.quota" - maximum bandwidth for emulator threads, in microseconds, +"tune.emu.period" - timeframe for enforcing the emu quota, in microseconds, +"tune.cpu.shares" - weight of this domain, compared to other running domains. + Selecting a specific statistics groups doesn't guarantee that the daemon supports the selected group of stats. Flag I<--enforce> forces the command to fail if the daemon doesn't support the -- 2.1.0

2 3

[libvirt] [PATCH] Error out on an address for isa-serial in QEMU driver.
by Ján Tomko 09 Mar '15

09 Mar '15

We've never formatted them on the qemu command line. https://bugzilla.redhat.com/show_bug.cgi?id=1164053 --- src/qemu/qemu_command.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c112619..e7b8c66 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -10409,7 +10409,8 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, virDomainChrSerialTargetTypeToString(serial->targetType), serial->info.alias, serial->info.alias); - if (serial->targetType == VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_USB) { + switch (serial->targetType) { + case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_USB: if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_USB_SERIAL)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("usb-serial is not supported in this QEMU binary")); @@ -10425,6 +10426,15 @@ qemuBuildSerialChrDeviceStr(char **deviceStr, if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) goto error; + break; + + case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_ISA: + if (serial->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("no addresses are suported for isa-serial")); + goto error; + } + break; } } -- 2.0.5

2 1

[libvirt] [PATCH] sanlock: Don't spam logs with "target pid not found"
by Jiri Denemark 09 Mar '15

09 Mar '15

Commit v1.2.4-52-gda879e5 fixed issues with domains started before sanlock driver was enabled by checking whether a running domain is registered with sanlock and if it's not, sanlock driver is basically ignored for the domain. However, it was checking this even for domain which has just been started and no sanlock_* API was called for them yet. This results in cmd 9 target pid 2135544 not found error messages to appear in sanlock.log whenever we start a new domain. This patch avoids this useless check for freshly started domains. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/locking/domain_lock.c | 22 ++++++++++++---------- src/locking/lock_driver.h | 12 +++++++++++- src/locking/lock_driver_lockd.c | 2 +- src/locking/lock_driver_sanlock.c | 9 ++++++--- src/locking/lock_manager.c | 2 +- 5 files changed, 31 insertions(+), 16 deletions(-) diff --git a/src/locking/domain_lock.c b/src/locking/domain_lock.c index d7b681e..705b132 100644 --- a/src/locking/domain_lock.c +++ b/src/locking/domain_lock.c @@ -104,7 +104,8 @@ static int virDomainLockManagerAddImage(virLockManagerPtr lock, static virLockManagerPtr virDomainLockManagerNew(virLockManagerPluginPtr plugin, const char *uri, virDomainObjPtr dom, - bool withResources) + bool withResources, + unsigned int flags) { virLockManagerPtr lock; size_t i; @@ -138,7 +139,7 @@ static virLockManagerPtr virDomainLockManagerNew(virLockManagerPluginPtr plugin, VIR_LOCK_MANAGER_OBJECT_TYPE_DOMAIN, ARRAY_CARDINALITY(params), params, - 0))) + flags))) goto error; if (withResources) { @@ -177,7 +178,8 @@ int virDomainLockProcessStart(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p paused=%d fd=%p", plugin, dom, paused, fd); - if (!(lock = virDomainLockManagerNew(plugin, uri, dom, true))) + if (!(lock = virDomainLockManagerNew(plugin, uri, dom, true, + VIR_LOCK_MANAGER_NEW_STARTED))) return -1; if (paused) @@ -201,7 +203,7 @@ int virDomainLockProcessPause(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p state=%p", plugin, dom, state); - if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, true))) + if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, true, 0))) return -1; ret = virLockManagerRelease(lock, state, 0); @@ -221,7 +223,7 @@ int virDomainLockProcessResume(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p state=%s", plugin, dom, NULLSTR(state)); - if (!(lock = virDomainLockManagerNew(plugin, uri, dom, true))) + if (!(lock = virDomainLockManagerNew(plugin, uri, dom, true, 0))) return -1; ret = virLockManagerAcquire(lock, state, 0, dom->def->onLockFailure, NULL); @@ -240,7 +242,7 @@ int virDomainLockProcessInquire(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p state=%p", plugin, dom, state); - if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, true))) + if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, true, 0))) return -1; ret = virLockManagerInquire(lock, state, 0); @@ -260,7 +262,7 @@ int virDomainLockImageAttach(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p src=%p", plugin, dom, src); - if (!(lock = virDomainLockManagerNew(plugin, uri, dom, false))) + if (!(lock = virDomainLockManagerNew(plugin, uri, dom, false, 0))) return -1; if (virDomainLockManagerAddImage(lock, src) < 0) @@ -297,7 +299,7 @@ int virDomainLockImageDetach(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p src=%p", plugin, dom, src); - if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, false))) + if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, false, 0))) return -1; if (virDomainLockManagerAddImage(lock, src) < 0) @@ -334,7 +336,7 @@ int virDomainLockLeaseAttach(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p lease=%p", plugin, dom, lease); - if (!(lock = virDomainLockManagerNew(plugin, uri, dom, false))) + if (!(lock = virDomainLockManagerNew(plugin, uri, dom, false, 0))) return -1; if (virDomainLockManagerAddLease(lock, lease) < 0) @@ -362,7 +364,7 @@ int virDomainLockLeaseDetach(virLockManagerPluginPtr plugin, VIR_DEBUG("plugin=%p dom=%p lease=%p", plugin, dom, lease); - if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, false))) + if (!(lock = virDomainLockManagerNew(plugin, NULL, dom, false, 0))) return -1; if (virDomainLockManagerAddLease(lock, lease) < 0) diff --git a/src/locking/lock_driver.h b/src/locking/lock_driver.h index a7d9782..f8fd38e 100644 --- a/src/locking/lock_driver.h +++ b/src/locking/lock_driver.h @@ -65,6 +65,11 @@ typedef enum { VIR_LOCK_MANAGER_ACQUIRE_RESTRICT = (1 << 1), } virLockManagerAcquireFlags; +typedef enum { + /* virLockManagerNew called for a freshly started domain */ + VIR_LOCK_MANAGER_NEW_STARTED = (1 << 0), +} virLockManagerNewFlags; + enum { VIR_LOCK_MANAGER_PARAM_TYPE_STRING, VIR_LOCK_MANAGER_PARAM_TYPE_CSTRING, @@ -142,13 +147,18 @@ typedef int (*virLockDriverDeinit)(void); * @type: the type of process to be supervised * @nparams: number of metadata parameters * @params: extra metadata parameters - * @flags: optional flags, currently unused + * @flags: bitwise-OR of virLockManagerNewFlags * * Initialize a new context to supervise a process, usually * a virtual machine. The lock driver implementation can use * the <code>privateData</code> field of <code>man</code> * to store a pointer to any driver specific state. * + * If @flags contains VIR_LOCK_MANAGER_NEW_STARTED, this API is called for + * a domain that has just been started and may therefore skip some actions. + * Specifically, checking whether the domain is registered with a lock + * daemon is useless in this case. + * * A process of VIR_LOCK_MANAGER_START_DOMAIN will be * given the following parameters * diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c index 8d184fe..72a4a0c 100644 --- a/src/locking/lock_driver_lockd.c +++ b/src/locking/lock_driver_lockd.c @@ -439,7 +439,7 @@ static int virLockManagerLockDaemonNew(virLockManagerPtr lock, virLockManagerLockDaemonPrivatePtr priv; size_t i; - virCheckFlags(VIR_LOCK_MANAGER_USES_STATE, -1); + virCheckFlags(VIR_LOCK_MANAGER_NEW_STARTED, -1); if (VIR_ALLOC(priv) < 0) return -1; diff --git a/src/locking/lock_driver_sanlock.c b/src/locking/lock_driver_sanlock.c index 60f305c..dbe79bc 100644 --- a/src/locking/lock_driver_sanlock.c +++ b/src/locking/lock_driver_sanlock.c @@ -455,7 +455,7 @@ static int virLockManagerSanlockNew(virLockManagerPtr lock, size_t i; int resCount = 0; - virCheckFlags(0, -1); + virCheckFlags(VIR_LOCK_MANAGER_NEW_STARTED, -1); if (!driver) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", @@ -497,8 +497,11 @@ static int virLockManagerSanlockNew(virLockManagerPtr lock, * if it returns any other error (rv < 0), then we cannot fail due * to back-compat. So this whole call is non-fatal, because it's * called from all over the place (it will usually fail). It merely - * updates privateData. */ - if (sanlock_inquire(-1, priv->vm_pid, 0, &resCount, NULL) >= 0) + * updates privateData. + * If the process has just been started, we are pretty sure it is not + * registered. */ + if (!(flags & VIR_LOCK_MANAGER_NEW_STARTED) && + sanlock_inquire(-1, priv->vm_pid, 0, &resCount, NULL) >= 0) priv->registered = true; lock->privateData = priv; diff --git a/src/locking/lock_manager.c b/src/locking/lock_manager.c index f277f22..a002ea8 100644 --- a/src/locking/lock_manager.c +++ b/src/locking/lock_manager.c @@ -287,7 +287,7 @@ virLockDriverPtr virLockManagerPluginGetDriver(virLockManagerPluginPtr plugin) * virLockManagerNew: * @driver: the lock manager implementation to use * @type: the type of process to be supervised - * @flags: optional flags, currently unused + * @flags: bitwise-OR of virLockManagerNewFlags * * Create a new context to supervise a process, usually * a virtual machine. -- 2.3.1

2 4

[libvirt] [PATCH] tests: fix qemuxml2argvtest to be arch independent
by Pavel Hrdina 09 Mar '15

09 Mar '15

Commit 5aee81a0 introduced a new test for disk-serial. The test fails on i686 arch because there is no need to add "-cpu qemu32" to command line. To fix the test update emulator in XML to "/usr/bin/qemu" so we don't add the "-cpu qemu32" to command while running the test on i686 or x86_64 host. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed as build-breaker patch. tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args | 2 +- tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args index 794b94b..4d64843 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.args @@ -1,5 +1,5 @@ LC_ALL=C PATH=/bin HOME=/home/test USER=test LOGNAME=test QEMU_AUDIO_DRV=none \ -/usr/libexec/qemu-kvm -S -M pc -cpu qemu32 -m 214 -smp 1 -nographic -nodefaults \ +/usr/bin/qemu -S -M pc -m 214 -smp 1 -nographic -nodefaults \ -monitor unix:/tmp/test-monitor,server,nowait -no-acpi -boot c -usb \ -drive 'file=/dev/HostVG/QEMUGuest1,if=none,\ id=drive-ide0-0-1,serial=\ \ WD-WMAP9A966149' \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml index 0fe75f3..565462e 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml +++ b/tests/qemuxml2argvdata/qemuxml2argv-disk-serial.xml @@ -13,7 +13,7 @@ <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> - <emulator>/usr/libexec/qemu-kvm</emulator> + <emulator>/usr/bin/qemu</emulator> <disk type='block' device='disk'> <source dev='/dev/HostVG/QEMUGuest1'/> <target dev='hda' bus='ide'/> -- 2.0.5

1 0

[libvirt] [PATCH] libvirt-domain.h: changing some unsigned int parameters to the respective enum type.
by Julio Faracco 09 Mar '15

09 Mar '15

Recently, some code were cleaned ups. Now, some parameters are being converted to its respective enum type. For example, there are many functions that are using int or unsigned int types instead enum types. So, this kind of cleaning up can be necessary. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- include/libvirt/libvirt-domain.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 9487b80..8016e2a 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -854,7 +854,7 @@ typedef enum { int virDomainShutdown (virDomainPtr domain); int virDomainShutdownFlags (virDomainPtr domain, - unsigned int flags); + virDomainShutdownFlagValues flags); typedef enum { VIR_DOMAIN_REBOOT_DEFAULT = 0, /* hypervisor choice */ @@ -866,7 +866,7 @@ typedef enum { } virDomainRebootFlagValues; int virDomainReboot (virDomainPtr domain, - unsigned int flags); + virDomainRebootFlagValues flags); int virDomainReset (virDomainPtr domain, unsigned int flags); @@ -884,7 +884,7 @@ typedef enum { } virDomainDestroyFlagsValues; int virDomainDestroyFlags (virDomainPtr domain, - unsigned int flags); + virDomainDestroyFlagsValues flags); int virDomainRef (virDomainPtr domain); int virDomainFree (virDomainPtr domain); -- 1.9.1

2 3

[libvirt] [libvirt-perl PATCH] Add virDomainGetIOThreads and virDomainPinIOThread bindings
by John Ferlan 09 Mar '15

09 Mar '15

Test results in the following output: $ perl examples/iothreadsinfo.pl Addr VMM type: QEMU ... Domain: { ID: 2 'f18iothr' UUID: fb9f7826-b5d7-4f74-b962-7181ef3fc9ec IOThread: { affinity: 0010 number: 1 } IOThread: { affinity: 0001 number: 2 } IOThread: { affinity: 1100 number: 3 } } Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Figured I'd post these just to have them "ready" once the pinning options for IOThreads are done being reviewed. Also running the Perl bindings did find one issue regarding the already pushed GetIOThreadsInfo with respect to ReadOnly bit checking (when it shouldn't have been) - a patch to resolve that has been posted as well. Changes | 4 ++++ Virt.xs | 43 +++++++++++++++++++++++++++++++++++++++++++ examples/iothreadsinfo.pl | 36 ++++++++++++++++++++++++++++++++++++ lib/Sys/Virt/Domain.pm | 17 +++++++++++++++++ 4 files changed, 100 insertions(+) create mode 100644 examples/iothreadsinfo.pl diff --git a/Changes b/Changes index b62ee24..f3e2f83 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,9 @@ Revision history for perl module Sys::Virt +1.2.14 2015-03-06 + + - Add virDomainGetIOThreads and virDomainPinIOThread API bindings + 1.2.14 2015-00-00 - XXX diff --git a/Virt.xs b/Virt.xs index f9ec7a4..15d48f7 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5014,6 +5014,49 @@ get_emulator_pin_info(dom, flags=0) RETVAL +void +get_iothread_info(dom, flags=0) + virDomainPtr dom; + unsigned int flags; + PREINIT: + virDomainIOThreadInfoPtr *iothrinfo; + int niothreads; + int i; + PPCODE: + if ((niothreads = virDomainGetIOThreadsInfo(dom, &iothrinfo, + flags)) < 0) + _croak_error(); + + EXTEND(SP, niothreads); + for (i = 0 ; i < niothreads ; i++) { + HV *rec = newHV(); + (void)hv_store(rec, "number", 6, + newSViv(iothrinfo[i]->iothread_id), 0); + (void)hv_store(rec, "affinity", 8, + newSVpvn((char*)iothrinfo[i]->cpumap, + iothrinfo[i]->cpumaplen), 0); + PUSHs(newRV_noinc((SV *)rec)); + } + + if (iothrinfo) + Safefree(iothrinfo); + + +void +pin_iothread(dom, iothread_id, mask, flags=0) + virDomainPtr dom; + unsigned int iothread_id; + SV *mask; + unsigned int flags; +PREINIT: + STRLEN masklen; + unsigned char *maps; + PPCODE: + maps = (unsigned char *)SvPV(mask, masklen); + if (virDomainPinVcpuFlags(dom, iothread_id, maps, masklen, flags) < 0) + _croak_error(); + + int num_of_snapshots(dom, flags=0) virDomainPtr dom; diff --git a/examples/iothreadsinfo.pl b/examples/iothreadsinfo.pl new file mode 100644 index 0000000..c527e8c --- /dev/null +++ b/examples/iothreadsinfo.pl @@ -0,0 +1,36 @@ +# -*- perl -*- +use strict; +use warnings; +use Sys::Virt; + +my $addr = @ARGV ? shift @ARGV : ""; +print "Addr $addr\n"; +my $con = Sys::Virt->new(address => $addr, readonly => 1); + +print "VMM type: ", $con->get_type(), "\n"; + +foreach my $dom (sort { $a->get_id <=> $b->get_id } $con->list_all_domains) { + print "Domain: {\n"; + print " ID: ", $dom->get_id(), " '" , $dom->get_name(), "'\n"; + print " UUID: ", $dom->get_uuid_string(), "\n"; + my $nodeinfo = $con->get_node_info; + my @info = $dom->get_iothread_info(Sys::Virt::Domain::AFFECT_CONFIG); + + foreach my $info (@info) { + print " IOThread: {\n"; + foreach (sort { $a cmp $b } keys %{$info}) { + if ($_ eq "affinity") { + print " ", $_, ": "; + my @mask = split //, $info->{$_}; + for (my $p = 0 ; $p < $nodeinfo->{cpus} ; $p++) { + print ((ord($mask[$p/8]) & (1 << ($p % 8))) ? 1 : 0); + } + print "\n"; + } else { + print " ", $_, ": ", $info->{$_}, "\n"; + } + } + print " }\n"; + } + print "}\n"; +} diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 5c8ef47..062c012 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -1216,6 +1216,23 @@ the physical CPUa, 8 cpus per character. To create a suitable bitstring, use the C<vec> function with a value of C<1> for the C<BITS> parameter. +=item @iothreadinfo = $dom->get_iothread_info($flags=0) + +Obtain information about the state of all IOThreads in a running +guest domain. The returned list will have one element for each IOThread, +where each elements contains a hash reference. The keys in the hash +are, C<number> the IOThread number and C<affinity> giving the allowed +schedular placement. The value for C<affinity> is a +string representing a bitmask against physical CPUs, 8 cpus per +character. To extract the bits use the C<unpack> function with +the C<b*> template. + +=item $dom->pin_iothread($iothread, $mask) + +Pin the IOThread given by index C<$iothread> to physical CPUs +given by C<$mask>. The C<$mask> is a string representing a bitmask +against physical CPUs, 8 cpus per character. + =item my @stats = $dom->get_cpu_stats($startCpu, $numCpus, $flags=0) Requests the guests host physical CPU usage statistics, starting -- 2.1.0

2 1

[libvirt] [PATCH v2 00/24] Drop network driver lock
by Michal Privoznik 09 Mar '15

09 Mar '15

Yet another version. This time with: 1) Peter's review worked in 2) Even more patches, that allow even more parallelism. With my test program [1], I've been able to go from 56s to 23s. 1: https://www.redhat.com/archives/libvir-list/2015-February/msg01214.html Michal Privoznik (24): network_conf: Introduce virNetworkObjListForEach network_conf: Introduce virNetworkObjListGetNames network_conf: Introduce virNetworkObjListNumOfNetworks network_conf: Introduce virNetworkObjListPrune bridge_driver: Adapt to new virNetworkObjList accessors test_driver: Adapt to new virNetworkObjList accessors parallels_network: Adapt to new virNetworkObjList accessors network_conf: Turn virNetworkObjList into virObject network_conf: Turn struct _virNetworkObjList private network_conf: Make virNetworkObj actually virObject virNetworkObjList: Derive from virObjectLockableClass network_conf: Introduce virNetworkObjEndAPI bridge_driver: Use virNetworkObjEndAPI test_driver: Use virNetworkObjEndAPI parallels_network: Use virNetworkObjEndAPI network_conf: Introduce locked versions of lookup functions virNetworkObjListPtr: Make APIs self-locking virNetworkObjFindBy*: Return an reference to found object bridge_driver: Drop networkDriverLock() from almost everywhere test_driver: Drop testDriverLock() from almost everywhere parallels_network: Drop parallelsDriverLock() from everywhere. bridge_driver: Use more of networkObjFromNetwork virNetworkObjUnsetDefTransient: Lock object list if needed virNetworkObjFindBy*: Don't lock all networks in the list cfg.mk | 3 - src/conf/network_conf.c | 422 +++++++++++++++++++++++++------- src/conf/network_conf.h | 52 ++-- src/libvirt_private.syms | 13 +- src/network/bridge_driver.c | 500 ++++++++++++++------------------------ src/parallels/parallels_network.c | 135 +++------- src/test/test_driver.c | 185 +++----------- tests/networkxml2conftest.c | 4 +- tests/objectlocking.ml | 2 - 9 files changed, 634 insertions(+), 682 deletions(-) -- 2.0.5

3 58

[libvirt] [RFC PATCH v2 0/4] Enable spapr-pci-vfio-host-bridge controllers for VFIO passthrough support
by Shivaprasad G Bhat 09 Mar '15

09 Mar '15

The following series of patches enable spapr-pci-vfio-host-bridge controllers on PPC64-pseries machine which is required for supporting host device passthrough using VFIO. There were some initial enablement work on the same at http://www.redhat.com/archives/libvir-list/2013-September/msg00838.html. On pseries(ppc64), the vfio host devices(will refer as hostdevs here on) cannot be assigned to the default emulated pci-host-bus(phb) controller(like the default pci.0). The hostdevs goto spapr-pci-vfio-host-bridge. The hostdevs belonging to the same iommu group share the same spapr-pci-vfio-host-bridge. Henceforth, new spapr-pci-host-bridge needs to be added for every hostdev belonging to any new iommu group. The hostdevs should be attached to their respective spapr-pci-vfio-host-bridge. Libvirt today adds all the devices to the default pci domain. The patch series take care to add the new controller. A new pci domain in the guest per controller is created. The hostdevs get their pci address in the respective domain. The patch series taskes care of device addressing in vfio hostdevs, SR-IOV interfaces and network interfaces from SRIOV virtual function pools. Reference: ====== v1: http://www.redhat.com/archives/libvir-list/2014-October/msg00500.html Changes Since v1: * Some minor code clean up and rebase to latest code base after review with Prerna * Patch 2 : Added logic to remove redundant spapr-vfio controllers. * : Moved domaincommon.rng from Patch 4 to Patch 2. --- Shivaprasad G Bhat (4): qemu: Add SPAPR_VFIO_HOST_BRIDGE capability for PPC platform qemu: parse spapr-vfio-pci controller from xml qemu: assign addresses for spapr vfio hostdevices and generate cli qemu: add test case for spapr-pci-vfio-host-bridge docs/schemas/domaincommon.rng | 28 ++ src/bhyve/bhyve_domain.c | 2 src/conf/domain_addr.c | 8 - src/conf/domain_addr.h | 2 src/conf/domain_conf.c | 165 +++++++++++- src/conf/domain_conf.h | 19 + src/libvirt_private.syms | 2 src/qemu/qemu_capabilities.c | 2 src/qemu/qemu_capabilities.h | 1 src/qemu/qemu_command.c | 276 +++++++++++++++++++- src/qemu/qemu_command.h | 17 + src/qemu/qemu_domain.c | 12 - src/qemu/qemu_driver.c | 6 tests/qemuhotplugtest.c | 2 .../qemuxml2argv-hostdev-spapr-vfio.args | 20 + .../qemuxml2argv-hostdev-spapr-vfio.xml | 75 +++++ tests/qemuxml2argvtest.c | 8 + 17 files changed, 609 insertions(+), 36 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-spapr-vfio.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-spapr-vfio.xml -- Signature

3 10

[libvirt] [PATCHv2 0/7] Automaticaly fill <memory> element for NUMA enabled guests
by Peter Krempa 09 Mar '15

09 Mar '15

This series changes the behavior of the <memory> element in case the guest has NUMA enabled and fills automatically the sum of sizes of numa nodes instead of relying on the user passing correct data. Peter Krempa (7): qemu: Forbid setting maximum memory size with the API with NUMA enabled qemu: lxc: Clarify error message when setting current memory conf: Replace access to def->mem.max_balloon with accessor functions phyp: Fix error messages mentioning memory qemu: command: Add helper to align memory sizes conf: numa: Add helper to count total memory size configured in NUMA conf: Automatically use NUMA memory size in case NUMA is enabled src/conf/domain_conf.c | 72 +++++++++++++++++++--- src/conf/domain_conf.h | 4 ++ src/conf/numa_conf.c | 13 ++++ src/conf/numa_conf.h | 2 + src/hyperv/hyperv_driver.c | 2 +- src/libvirt_private.syms | 4 ++ src/libxl/libxl_conf.c | 2 +- src/libxl/libxl_driver.c | 8 +-- src/lxc/lxc_cgroup.c | 2 +- src/lxc/lxc_driver.c | 28 +++++---- src/lxc/lxc_fuse.c | 4 +- src/lxc/lxc_native.c | 4 +- src/openvz/openvz_driver.c | 2 +- src/parallels/parallels_driver.c | 2 +- src/parallels/parallels_sdk.c | 12 ++-- src/phyp/phyp_driver.c | 15 +++-- src/qemu/qemu_command.c | 23 ++++--- src/qemu/qemu_domain.c | 21 +++++++ src/qemu/qemu_domain.h | 2 + src/qemu/qemu_driver.c | 49 ++++++++++----- src/qemu/qemu_hotplug.c | 8 ++- src/qemu/qemu_process.c | 2 +- src/test/test_driver.c | 8 +-- src/uml/uml_driver.c | 8 +-- src/vbox/vbox_common.c | 4 +- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.c | 12 ++-- src/xen/xm_internal.c | 14 ++--- src/xenapi/xenapi_driver.c | 2 +- src/xenapi/xenapi_utils.c | 4 +- src/xenconfig/xen_common.c | 8 ++- src/xenconfig/xen_sxpr.c | 9 +-- .../qemuxml2argv-numatune-memnode.args | 2 +- 33 files changed, 243 insertions(+), 111 deletions(-) -- 2.2.2

2 21

[libvirt] ANNOUNCE: Oz 0.13.0 release
by Chris Lalancette 08 Mar '15

08 Mar '15

All, I'm pleased to announce release 0.13.0 of Oz. Oz is a program for doing automated installation of guest operating systems with limited input from the user. Release 0.13.0 is a bugfix and feature release for Oz. Some of the highlights between Oz 0.12.0 and 0.13.0 are: - For Fedora, if the user specifies a version, but that isn't supported yet, try the last supported version (in this case), as that will often work. - Fix a regression where we forgot to force the qcow2 image type - Allow installs that use more than one installation device - Add support for RHEL 6.5 - Rename OEL-6 to OL-6 - Add support for Ubuntu 14.04 - Add Windows 8.1 support - Add CentOS-7 support - Add the ability to specify kernel parameters in the TDL - Make sure to remove dhcp leases from guests after the install - Fix support for FreeBSD - Add in support for TDL "precommands"; these are commands that are run *before* package installation - Fix up file locking - Add support for RHEL 5.11 - Remove Ubuntu ssh keys at the end of installation - Add support for Ubuntu 14.10 - Add support for XInclude, for merging various TDLs together - Add Fedora 21 support - Add support for ppc64 and ppc64le A tarball and zipfile of this release is available on the Github releases page: https://github.com/clalancette/oz/releases . Packages for Fedora-20, Fedora-21, Fedora-22, EPEL-6, and EPEL-7 have been built in Koji and will eventually make their way to stable. Instructions on how to get and use Oz are available at http://github.com/clalancette/oz/wiki . If you have questions or comments about Oz, please feel free to contact me at clalancette at gmail.com, or open up an issue on the github page: http://github.com/clalancette/oz/issues . Thanks to everyone who contributed to this release through bug reports, patches, and suggestions for improvement. Chris Lalancette

1 0

[libvirt] [PATCH 0/2] Add some tiny tests for latest commits
by Martin Kletzander 07 Mar '15

07 Mar '15

Two commits (hashes mentioned in commit messages) were added lately without tests and I feel like both deserve one, so here goes. Martin Kletzander (2): tests: Add test for virtio-mmio address type tests: Add test for os interleaving ...=> qemuxml2argv-aarch64-aavmf-virtio-mmio.args} | 4 ++-- ... => qemuxml2argv-aarch64-aavmf-virtio-mmio.xml} | 27 +++++++++++----------- ...l => qemuxml2argv-bios-nvram-os-interleave.xml} | 2 +- tests/qemuxml2argvtest.c | 4 ++++ .../qemuxml2xmlout-bios-nvram-os-interleave.xml} | 0 tests/qemuxml2xmltest.c | 2 ++ 6 files changed, 23 insertions(+), 16 deletions(-) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-virt-virtio.args => qemuxml2argv-aarch64-aavmf-virtio-mmio.args} (85%) copy tests/qemuxml2argvdata/{qemuxml2argv-aarch64-virt-virtio.xml => qemuxml2argv-aarch64-aavmf-virtio-mmio.xml} (68%) copy tests/qemuxml2argvdata/{qemuxml2argv-bios-nvram.xml => qemuxml2argv-bios-nvram-os-interleave.xml} (100%) copy tests/{qemuxml2argvdata/qemuxml2argv-bios-nvram.xml => qemuxml2xmloutdata/qemuxml2xmlout-bios-nvram-os-interleave.xml} (100%) -- 2.3.0

2 3

[libvirt] [PATCH v4 0/9] Introduce display of IOThreads Information
by John Ferlan 06 Mar '15

06 Mar '15

v3: http://www.redhat.com/archives/libvir-list/2015-February/msg00593.html Changes since v3: (from code reviews) - Updated to use 1.2.14 not 1.2.13 - Change struct from virDomainIOThreadsInfo to virDomainIOThreadInfo - Remove the resources and nresources from virDomainIOThreadInfo and of course all associated code as well as changing the remote struct from iothreads_* to iothread_ - Create separate routines for virDomainGetIOThreadsInfo, virDomainGetIOThreadPin, and virDomainPinIOThread... and of course all the accompanying code - Use EnterMonitor instead of EnterMonitorAsync Still need to generate a v3 of the python code, but I'll wait for this to be reviewed first. John Ferlan (9): Implement public API for virDomainGetIOThreadsInfo remote: Implement the remote plumbing for virDomainGetIOThreadsInfo qemu: Implement the qemu driver fetch for IOThreads virsh: Add 'iothreadsinfo' command Implement public API for getting/setting specific IOThread pinning remote: Plumbing for getting/setting specific IOThread pinning domain: Introduce virDomainIOThreadsPin{Add|Del} qemu: Add support to get/set specific IOThread pinning data virsh: Add iothreadpin command daemon/remote.c | 123 ++++++++- include/libvirt/libvirt-domain.h | 41 ++- src/conf/domain_conf.c | 64 +++++ src/conf/domain_conf.h | 10 + src/driver-hypervisor.h | 24 +- src/libvirt-domain.c | 227 ++++++++++++++++- src/libvirt_private.syms | 2 + src/libvirt_public.syms | 8 + src/qemu/qemu_driver.c | 526 +++++++++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 143 ++++++++++- src/remote/remote_protocol.x | 61 ++++- src/remote_protocol-structs | 43 ++++ src/rpc/gendispatch.pl | 2 + tools/virsh-domain.c | 216 ++++++++++++++++ tools/virsh.pod | 38 +++ 15 files changed, 1521 insertions(+), 7 deletions(-) -- 2.1.0

3 21

[libvirt] ANNOUNCE: Libvirt Designer version 0.0.2 released
by Daniel P. Berrange 06 Mar '15

06 Mar '15

I'm pleased to announce the second release of the libvirt designer library, version 0.0.2 ftp://ftp.libvirt.org/libvirt/designer/libvirt-designer-0.0.2.tar.gz The release is signed ftp://ftp.libvirt.org/libvirt/designer/libvirt-designer-0.0.2.tar.gz.asc with the GPG key having the fingerprint DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) In this release: - Bumped soname & version for ABI change - Remove use of deprecated libosinfo calls - Fix various memory leaks - Treat errors loading the libosinfo DB as non-fatal as some data may be successfully loaded - Improve building of libosinfo short-id from libvirt capabilities information - Expose the libosinfo DB object via a property on the domain object - Don't set PKG_CONFIG_PATH for g-ir-scanner - Auto-generate list of AUTHORS - Avoid redefining _FORTIFY_SOURCE macro - Fix & add gtk-doc introspection annotation - Add Vala APi binding - Add support for floppy & CDROM devices - Use libvirt style libtool versioning csheme - Add API to set list of installed drivers - Add API for querying supported devices - Remove many bogus assumptions in disk bus handling - Populate clock settings, input devices & console - Add API for enabling sound devices - Add AP ifor enabling choice of graphics backends - Add SPICE agent if using SPICE - Add API for enabling USB redirection - Add API for enabling smartcard devices - Add API for enabling video devices - Import latest compiler warnings from gnulib - Avoid using deprecated libvirt-gconfig APIs - Rename virtxml binary to virt-designer - Add API for choosing network backend type - Add further test cases for validing domain builder - Always build test programs The libvirt-designer library builds on top of the libvirt-gconfig and libosinfo libraries, to provide an API that assists applications in building guest domain configurations based on libosinfo policy. The intention is that it be usable from applications such as virt-manager and GNOME boxes which currently duplicate this kind of policy based configuration logic between them. It is still at an early experimental stage of development so it is liable to have further ABI incompatible changes in future releases, which will require recompiling applications and possibly source level changes too. Thanks to all the people who contributed towards this new release. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

1 0

[libvirt] [PATCH v2 0/3] unify memtune value representation in libvirt
by Pavel Hrdina 06 Mar '15

06 Mar '15

The first patch rewrites virsh memtune command to accept 0 as valid value instead of ignoring it. In the second patch I'll introduce a simple helper to crop the *_limit values to VIR_DOMAIN_MEMORY_PARAM_UNLIMITED as its used several times while reading values from cgroups and also a helper to check whether the memory limits are set or not. The last patch actually changes the internal representation of unlimited memtune settings. More detailed description is in commit message. My motivation to change it completely is to prevent future bugs with those limits. Pavel Hrdina (3): virsh: fix memtune to also accept 0 as valid value virutil: introduce helper functions for memory limits memtune: change the way how we store unlimited value docs/formatdomain.html.in | 4 +- src/conf/domain_conf.c | 75 +++++++++++++++---- src/libvirt-domain.c | 3 + src/libvirt_private.syms | 3 +- src/lxc/lxc_cgroup.c | 18 ++--- src/lxc/lxc_driver.c | 7 +- src/lxc/lxc_fuse.c | 12 ++-- src/lxc/lxc_native.c | 6 +- src/openvz/openvz_conf.c | 4 +- src/openvz/openvz_driver.c | 4 +- src/qemu/qemu_cgroup.c | 24 +++---- src/qemu/qemu_command.c | 8 ++- src/qemu/qemu_driver.c | 10 +-- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_migration.c | 5 +- src/util/virutil.c | 47 ++++++------ src/util/virutil.h | 5 +- tests/qemuxml2argvdata/qemuxml2argv-memtune.xml | 2 +- .../qemuxml2xmloutdata/qemuxml2xmlout-memtune.xml | 2 +- tools/virsh-domain.c | 83 ++++++++++------------ 20 files changed, 185 insertions(+), 139 deletions(-) -- 2.0.5

2 8

[libvirt] expose via api event about changing domain metadata
by Vasiliy Tolstov 06 Mar '15

06 Mar '15

Hello. I have in domain metadata some info that i need , but now i need to notify when the info changed. Does it possible to add even about changing domain metadata like other events (http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainEventID) -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru jabber: vase(a)selfip.ru

2 2

[libvirt] [PATCH v2 1/3] utils: Implement virCommandPassFDGetFDIndex
by Stefan Berger 06 Mar '15

06 Mar '15

Implement virCommandPassFDGetFDIndex to determine the index a given file descriptor will have when passed to the child process. Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com> --- src/libvirt_private.syms | 1 + src/util/vircommand.c | 24 ++++++++++++++++++++++++ src/util/vircommand.h | 3 +++ 3 files changed, 28 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6028002..96cfbf2 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1214,6 +1214,7 @@ virCommandNewArgList; virCommandNewArgs; virCommandNonblockingFDs; virCommandPassFD; +virCommandPassFDGetFDIndex; virCommandPassListenFDs; virCommandRawStatus; virCommandRequireHandshake; diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 6527d85..648f5ed 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -1019,6 +1019,30 @@ virCommandPassListenFDs(virCommandPtr cmd) cmd->flags |= VIR_EXEC_LISTEN_FDS; } +/* + * virCommandPassFDGetFDIndex: + * @cmd: pointer to virCommand + * @fd: FD to get index of + * + * Determine the index of the FD in the transfer set. + * + * Returns index >= 0 if @set contains @fd, + * -1 otherwise. + */ +int +virCommandPassFDGetFDIndex(virCommandPtr cmd, int fd) +{ + size_t i = 0; + + while (i < cmd->npassfd) { + if (cmd->passfd[i].fd == fd) + return i; + i++; + } + + return -1; +} + /** * virCommandSetPidFile: * @cmd: the command to modify diff --git a/src/util/vircommand.h b/src/util/vircommand.h index bf65de4..198da2f 100644 --- a/src/util/vircommand.h +++ b/src/util/vircommand.h @@ -62,6 +62,9 @@ void virCommandPassFD(virCommandPtr cmd, void virCommandPassListenFDs(virCommandPtr cmd); +int virCommandPassFDGetFDIndex(virCommandPtr cmd, + int fd); + void virCommandSetPidFile(virCommandPtr cmd, const char *pidfile) ATTRIBUTE_NONNULL(2); -- 1.9.3

2 4

[libvirt] [PATCH] Document the effect of empty string as a rom file
by Ján Tomko 06 Mar '15

06 Mar '15

This can be used to disable the ROM. --- docs/formatdomain.html.in | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6276a61..050476f 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4265,7 +4265,8 @@ qemu-kvm -net nic,model=? /dev/null The optional <code>file</code> attribute is used to point to a binary file to be presented to the guest as the device's ROM BIOS. This can be useful to provide an alternative boot ROM for a - network device. + network device. If the file attribute is present, but empty, + no ROM file will be loaded. <span class="since">Since 0.9.10 (QEMU and KVM only)</span>. </p> <h5><a name="elementDomain">Setting up a network backend in a driver domain</a></h5> -- 2.0.5

2 1

[libvirt] [PATCH v8 0/4] Introduce API to query IP addresses for given domain
by Nehal J Wani 06 Mar '15

06 Mar '15

This feature has been requested for a very long time. Since qemu guest agent and leaseshelper give us reliable results, now the wait is over. The RFC was first proposed by Michal Privoznik: http://www.redhat.com/archives/libvir-list/2012-February/msg00437.html A patch was submitted, using structs: https://www.redhat.com/archives/libvir-list/2012-June/msg00220.html Another patch was submitted, using XML: https://www.redhat.com/archives/libvir-list/2012-June/msg00904.html Neither of the patches were accepted, probably due to lack of extensibility and usability. Hence, we thought of using virTypedParameters for reporting list of interfaces along with their MAC address and IP addresses. The RFC can be found here: https://www.redhat.com/archives/libvir-list/2013-July/msg00084.html The idea of extensibility was rejected and rendered out of scope of libvirt. Hence, we were back to structs. This API is called virDomainInterfaceAddresses which returns a dynamically allocated array of virDomainInterface struct. The great disadvantage is once this gets released, it's written in stone and we cannot change or add an item into it. The virsh CLI supports two methods: * Return information (list of all associated interfaces with MAC address and IP addresses) of all of the domain interfaces by default (if no interface name is provided) * Return information for the specified interface (if an interface name is provided) v8: * qemuDomainInterfaceAddresses: redo logic related to flags * Make sure that NIC(s) on guest is/are using libvirt virtual network before querying leaseshelper * domifaddr: change --network option from VSH_OT_DATA to VSH_OT_STRING v7: * Enable support for DHCP lease file parsing method * http://www.redhat.com/archives/libvir-list/2014-December/msg00866.html v6: * Inclusion of flags, readonly check for guest agent connection * Correction of memory leaks, other small nits. * https://www.redhat.com/archives/libvir-list/2013-September/msg00350.html v5: * s/virDomainInterfacesAddresses/virDomainInterfaceAddresses. * Case for IP aliasing handled using virHashTable. * New test cases added, involving multiple and 0 IP addresse(s) per interface. * IP prefix changed from int to unsigned int. * Changes to practice libvirt habits. * https://www.redhat.com/archives/libvir-list/2013-September/msg00003.html v4: * Various style nits, indentation errors, memory leaks fixed. * https://www.redhat.com/archives/libvir-list/2013-August/msg01265.html v3: * Upper bounds to number of interfaces and addresses per interface introduced. * Change from array of structs to array of pointers * ifaces_count moved from function argument to return value * Changes in variable names * Test cases added for qemuAgentGetInterfaces. * https://www.redhat.com/archives/libvir-list/2013-August/msg01215.html v2: * Logical errors, memory leaks and few other errors fixed. * https://www.redhat.com/archives/libvir-list/2013-August/msg00631.html v1: * http://www.redhat.com/archives/libvir-list/2013-July/msg01553.html Nehal J Wani (4): domifaddr: Implement the public APIs domifaddr: Implement the remote protocol domifaddr: Implement the API for qemu domifaddr: Add virsh support daemon/remote.c | 134 ++++++++++++++++++++++++++ include/libvirt/libvirt-domain.h | 27 ++++++ src/driver-hypervisor.h | 5 + src/libvirt-domain.c | 129 +++++++++++++++++++++++++ src/libvirt_public.syms | 6 ++ src/qemu/qemu_agent.c | 202 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_agent.h | 4 + src/qemu/qemu_driver.c | 173 +++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 100 +++++++++++++++++++ src/remote/remote_protocol.x | 36 ++++++- src/remote_protocol-structs | 24 +++++ tests/qemuagenttest.c | 188 ++++++++++++++++++++++++++++++++++++ tools/virsh-domain-monitor.c | 141 +++++++++++++++++++++++++++ tools/virsh.pod | 16 ++++ 14 files changed, 1184 insertions(+), 1 deletion(-) -- 2.1.0

4 12