- Devel - libvirt List Archives

[libvirt] "opertaions" typo on wiki.
by Dennis 07 Mar '16

07 Mar '16

Hi, I tried to edit http://wiki.libvirt.org/page/Main_Page to fix a typo of the word 'operations,' (see email subject) but could not figure out how to create an account. I read on the contact page that if I am not subscribed to the mailing list I am mailing this small insignificant task won't be emailed to a large group of people and will be moderated appropriately. Thanks, Dennis O.

2 1

[libvirt] [libvirt-glib] gconfig: Fix next API version number
by Fabiano Fidêncio 07 Mar '16

07 Mar '16

Commit 01e01f2 introduced a wrong next API version number in libvirt-gconfig.sym Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- libvirt-gconfig/libvirt-gconfig.sym | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index f11f97a..5bc2e24 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -733,7 +733,7 @@ global: gvir_config_domain_video_set_vgamem; } LIBVIRT_GCONFIG_0.2.1; -LIBVIRT_GCONFIG_0.2.4 { +LIBVIRT_GCONFIG_0.2.3 { gvir_config_domain_graphics_spice_set_gl; gvir_config_domain_video_set_accel3d; } LIBVIRT_GCONFIG_0.2.2; -- 2.5.0

2 1

[libvirt] [PATCH 00/25] Final pile of qemu_command.c changes
by John Ferlan 07 Mar '16

07 Mar '16

Finishing the adventure - certainly qemuBuildCommandLine looks much cleaner now and is much shorter (~2100 lines down to ~250 lines). The downside is plowing though the changes and the reviews. John Ferlan (25): qemu: Introduce qemuBuildClockCommandLine qemu: Introduce qemuBuildPMCommandLine qemu: Introduce qemuBuildBootCommandLine qemu: Introduce qemuBuildGlobalControllerCommandLine qemu: Introduce qemuBuildControllerDevCommandLine qemu: Introduce qemuBuildHubCommandLine qemu: Introduce qemuBuildDiskDriveCommandLine qemu: Introduce qemuBuildFSDevCommandLine qemu: Introduce qemuBuildNetCommandLine qemu: Introduce qemuBuildSmartcardCommandLine qemu: Introduce qemuBuildSerialCommandLine qemu: Introduce qemuBuildParallelsCommandLine qemu: Introduce qemuBuildChannelsCommandLine qemu: Introduce qemuBuildConsoleCommandLine qemu: Modify qemuBuildTPMCommandLine qemu: Introduce qemuBuildInputCommandLine qemu: Introduce qemuBuildVideoCommandLine qemu: Introduce qemuBuildSoundCommandLine qemu: Introduce qemuBuildWatchdogCommandLine qemu: Introduce qemuBuildRedirdevCommandLine qemu: Introduce qemuBuildHostdevCommandLine qemu: Introduce qemuBuildMemballoonCommandLine qemu: Introduce qemuBuildRNGCommandLine qemu: Introduce qemuBuildNVRAMCommandLine qemu: Introduce qemuBuildPanicCommandLine src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 8 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 7703 +++++++++++++++++++++------------------- src/qemu/qemu_command.h | 46 +- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_domain_address.h | 2 +- 8 files changed, 4073 insertions(+), 3706 deletions(-) -- 2.5.0

2 27

[libvirt] [PATCH] locking: Use bit shift for flag values not constant values.
by John Ferlan 07 Mar '16

07 Mar '16

So far it hasn't bitten us, but if the next value wasn't 4, then the logic used to check flag bits would have issues. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Noted this while reviewing danpb's virtlogd as chardev series. src/locking/lock_driver_lockd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/locking/lock_driver_lockd.h b/src/locking/lock_driver_lockd.h index baf346a..6931fe7 100644 --- a/src/locking/lock_driver_lockd.h +++ b/src/locking/lock_driver_lockd.h @@ -23,8 +23,8 @@ # define __VIR_LOCK_DRIVER_LOCKD_H__ enum virLockSpaceProtocolAcquireResourceFlags { - VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = 1, - VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = 2, + VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = (1 << 0), + VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = (1 << 1), }; #endif /* __VIR_LOCK_DRIVER_LOCKD_H__ */ -- 2.5.0

2 1

[libvirt] [PATCH] _virtualboxCreateMachine: Avoid unbound stack
by Michal Privoznik 07 Mar '16

07 Mar '16

If the stars are in the right position and you're building with VBox >= 4.2.0 it will happen that compiler thinks an array allocated on the stack may be unbound: In file included from vbox/vbox_V4_2.c:13:0: vbox/vbox_tmpl.c: In function '_virtualboxCreateMachine': vbox/vbox_tmpl.c:2811:1: error: stack usage might be unbounded [-Werror=stack-usage=] _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **machine, char *uuidstr ATTRIBUTE_UNUSED) ^ Well, given how the variable is declared, I had some hard time seeing it is actually bounded. Surprisingly compiler does not complain because of -Wframe-larger-than. This is because variable length arrays do not count into that warning. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/vbox/vbox_tmpl.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 0fbd5b3..7a8205d 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -2812,7 +2812,7 @@ _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **m { vboxIID iid = VBOX_IID_INITIALIZER; PRUnichar *machineNameUtf16 = NULL; - nsresult rc; + nsresult rc = -1; VBOX_UTF8_TO_UTF16(def->name, &machineNameUtf16); vboxIIDFromUUID(&iid, def->uuid); @@ -2843,18 +2843,12 @@ _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **m override, machine); #else /* VBOX_API_VERSION >= 4002000 */ - const char *flagsUUIDPrefix = "UUID="; - const char *flagsForceOverwrite = "forceOverwrite=0"; - const char *flagsSeparator = ","; - char createFlags[strlen(flagsUUIDPrefix) + VIR_UUID_STRING_BUFLEN + strlen(flagsSeparator) + strlen(flagsForceOverwrite) + 1]; + char *createFlags = NULL; PRUnichar *createFlagsUtf16 = NULL; - snprintf(createFlags, sizeof(createFlags), "%s%s%s%s", - flagsUUIDPrefix, - uuidstr, - flagsSeparator, - flagsForceOverwrite - ); + if (virAsprintf(&createFlags, + "UUID=%s,forceOverwrite=0", uuidstr) < 0) + goto cleanup; VBOX_UTF8_TO_UTF16(createFlags, &createFlagsUtf16); rc = data->vboxObj->vtbl->CreateMachine(data->vboxObj, NULL, @@ -2864,6 +2858,8 @@ _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **m nsnull, createFlagsUtf16, machine); + cleanup: + VIR_FREE(createFlags); #endif /* VBOX_API_VERSION >= 4002000 */ } VBOX_UTF16_FREE(machineNameUtf16); -- 2.4.10

2 1

[libvirt] [PATCH] qemu: improve the error when try to undefine transient network
by Shanzhi Yu 07 Mar '16

07 Mar '16

Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/network/bridge_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 7ab9e29..b62fdff 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3222,6 +3222,12 @@ networkUndefine(virNetworkPtr net) if (virNetworkObjIsActive(network)) active = true; + if (!network->persistent) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("can't undefine transient network")); + goto cleanup; + } + /* remove autostart link */ if (virNetworkDeleteConfig(driver->networkConfigDir, driver->networkAutostartDir, -- 1.8.3.1

2 1

[libvirt] [PATCH] qemu: rename: Forbid renaming domains with managed save image
by Peter Krempa 07 Mar '16

07 Mar '16

The code does not handle renaming of the save state file. In addition to that the resuming code would need to be tweaked to handle the name change since the XML is extracted from the save image. The easies option is to make the rename API even less useful by forbiding this. --- src/qemu/qemu_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 102fade..4020364 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19994,6 +19994,12 @@ static int qemuDomainRename(virDomainPtr dom, goto endjob; } + if (vm->hasManagedSave) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("domain with a managed saved state can't be renamed")); + goto endjob; + } + if (virDomainObjGetState(vm, NULL) != VIR_DOMAIN_SHUTOFF) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("domain has to be shutoff before renaming")); -- 2.6.2

2 1

[libvirt] [PATCH v3] Use correct pci addresses during interface-detach
by Nitesh Konkar 07 Mar '16

07 Mar '16

From: Nitesh_Konkar <niteshkonkar.libvirt(a)gmail.com> --- tools/virsh-domain.c | 103 +++++++++++++++++++++++++++++++++------------------ 1 file changed, 64 insertions(+), 39 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 979f115..a15ef40 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c -static bool -cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) +static bool +vshDomainDetachInterface(char *doc, unsigned int flags, virDomainPtr dom, vshControl *ctl, const vshCmd *cmd) { - virDomainPtr dom = NULL; xmlDocPtr xml = NULL; xmlXPathObjectPtr obj = NULL; xmlXPathContextPtr ctxt = NULL; xmlNodePtr cur = NULL, matchNode = NULL; - char *detach_xml = NULL; const char *mac = NULL, *type = NULL; - char *doc = NULL; + char *detach_xml = NULL; + bool current = vshCommandOptBool(cmd, "current"); char buf[64]; int diff_mac; size_t i; int ret; bool functionReturn = false; - unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; - bool current = vshCommandOptBool(cmd, "current"); - bool config = vshCommandOptBool(cmd, "config"); - bool live = vshCommandOptBool(cmd, "live"); - bool persistent = vshCommandOptBool(cmd, "persistent"); - - VSH_EXCLUSIVE_OPTIONS_VAR(persistent, current); - - VSH_EXCLUSIVE_OPTIONS_VAR(current, live); - VSH_EXCLUSIVE_OPTIONS_VAR(current, config); - - if (config || persistent) - flags |= VIR_DOMAIN_AFFECT_CONFIG; - if (live) - flags |= VIR_DOMAIN_AFFECT_LIVE; - - if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) - return false; if (vshCommandOptStringReq(ctl, cmd, "type", &type) < 0) goto cleanup; @@ -10859,15 +10823,6 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "mac", &mac) < 0) goto cleanup; - if (persistent && - virDomainIsActive(dom) == 1) - flags |= VIR_DOMAIN_AFFECT_LIVE; - - if (flags & VIR_DOMAIN_AFFECT_CONFIG) - doc = virDomainGetXMLDesc(dom, VIR_DOMAIN_XML_INACTIVE); - else - doc = virDomainGetXMLDesc(dom, 0); - if (!doc) goto cleanup; @@ -10935,20 +10890,72 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) else ret = virDomainDetachDevice(dom, detach_xml); - if (ret != 0) { - vshError(ctl, "%s", _("Failed to detach interface")); - } else { - vshPrint(ctl, "%s", _("Interface detached successfully\n")); + if (ret == 0) functionReturn = true; - } cleanup: - VIR_FREE(doc); VIR_FREE(detach_xml); - virDomainFree(dom); + xmlFreeDoc(xml); xmlXPathFreeObject(obj); xmlXPathFreeContext(ctxt); - xmlFreeDoc(xml); + return functionReturn; +} + +static bool +cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) +{ + virDomainPtr dom = NULL; + unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; + char *doc_live = NULL, *doc_config = NULL; + bool current = vshCommandOptBool(cmd, "current"); + bool config = vshCommandOptBool(cmd, "config"); + bool live = vshCommandOptBool(cmd, "live"); + bool persistent = vshCommandOptBool(cmd, "persistent"); + bool functionReturn = false; + + VSH_EXCLUSIVE_OPTIONS_VAR(persistent, current); + + VSH_EXCLUSIVE_OPTIONS_VAR(current, live); + VSH_EXCLUSIVE_OPTIONS_VAR(current, config); + + if (config || persistent) + flags |= VIR_DOMAIN_AFFECT_CONFIG; + + if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) + return false; + + if (persistent && + virDomainIsActive(dom) == 1) + flags |= VIR_DOMAIN_AFFECT_LIVE; + + if (flags & VIR_DOMAIN_AFFECT_CONFIG) { + doc_config = virDomainGetXMLDesc(dom, VIR_DOMAIN_XML_INACTIVE); + if (!(functionReturn = vshDomainDetachInterface(doc_config, flags, dom, ctl, cmd))) + goto cleanup; + } + + if (live || (!live && !config)) + flags |= VIR_DOMAIN_AFFECT_LIVE; + + if (flags & VIR_DOMAIN_AFFECT_LIVE) { + doc_live = virDomainGetXMLDesc(dom, 0); + + if (flags & VIR_DOMAIN_AFFECT_CONFIG) + flags &= (~VIR_DOMAIN_AFFECT_CONFIG); + + functionReturn = vshDomainDetachInterface(doc_live, flags, dom, ctl, cmd); + } + + cleanup: + if (functionReturn == false) { + vshError(ctl, "%s", _("Failed to detach interface")); + } else { + vshPrint(ctl, "%s", _("Interface detached successfully\n")); + functionReturn = true; + } + VIR_FREE(doc_live); + VIR_FREE(doc_config); + virDomainFree(dom); return functionReturn; }

1 0

[libvirt] [PATCH] Use correct pci addresses during interface-detach[v2]
by Nitesh Konkar 07 Mar '16

07 Mar '16

The virsh attach virsh detach interface command fails when both live and config are set and when the interface gets attached to different pci slots on live and config xml respectively. When we attach an interface with both --live and --config, the first time they get the same PCI slots, but the second time onwards it differs and hence the virsh detach-interface --live --config command fails. This patch makes sure that when both --live --config are set , qemuDomainDetachDeviceFlags is called twice, once with config xml and once with live xml. Steps to see the issue: virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config Signed-off-by:nitkon12@linux.vnet.ibm.com --- tools/virsh-domain.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 62acecb..43c8436 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10815,7 +10815,7 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) char buf[64]; int diff_mac; size_t i; - int ret; + int ret, flag_live_config_both = 0; bool functionReturn = false; unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; bool current = vshCommandOptBool(cmd, "current"); @@ -10830,7 +10830,7 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) if (config || persistent) flags |= VIR_DOMAIN_AFFECT_CONFIG; - if (live) + if (!(config || persistent) && live) // Only Live flags |= VIR_DOMAIN_AFFECT_LIVE; if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) @@ -10851,6 +10851,8 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) else doc = virDomainGetXMLDesc(dom, 0); + forlivexml: + if (!doc) goto cleanup; @@ -10921,6 +10923,14 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) if (ret != 0) { vshError(ctl, "%s", _("Failed to detach interface")); } else { + if ((config || persistent) && live && flag_live_config_both == 0) {//executed only when live config both in cmd. + doc = virDomainGetXMLDesc(dom, 0); + flag_live_config_both=1; //Need to execute this code only once + flags |= VIR_DOMAIN_AFFECT_LIVE; //set live flag + flags &= (~VIR_DOMAIN_AFFECT_CONFIG ); // need to unset config flag as config xml detach is already done. + mac=NULL; + goto forlivexml; + } vshPrint(ctl, "%s", _("Interface detached successfully\n")); functionReturn = true; } -- 1.8.3.1

2 2

[libvirt] [PATCH v3] Use correct pci addresses during interface-detach
by Nitesh Konkar 07 Mar '16

07 Mar '16

From: Nitesh_Konkar <niteshkonkar.libvirt(a)gmail.com> --- tools/virsh-domain.c | 103 +++++++++++++++++++++++++++++++++------------------ 1 file changed, 64 insertions(+), 39 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 979f115..a15ef40 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c -static bool -cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) +static bool +vshDomainDetachInterface(char *doc, unsigned int flags, virDomainPtr dom, vshControl *ctl, const vshCmd *cmd) { - virDomainPtr dom = NULL; xmlDocPtr xml = NULL; xmlXPathObjectPtr obj = NULL; xmlXPathContextPtr ctxt = NULL; xmlNodePtr cur = NULL, matchNode = NULL; - char *detach_xml = NULL; const char *mac = NULL, *type = NULL; - char *doc = NULL; + char *detach_xml = NULL; + bool current = vshCommandOptBool(cmd, "current"); char buf[64]; int diff_mac; size_t i; int ret; bool functionReturn = false; - unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; - bool current = vshCommandOptBool(cmd, "current"); - bool config = vshCommandOptBool(cmd, "config"); - bool live = vshCommandOptBool(cmd, "live"); - bool persistent = vshCommandOptBool(cmd, "persistent"); - - VSH_EXCLUSIVE_OPTIONS_VAR(persistent, current); - - VSH_EXCLUSIVE_OPTIONS_VAR(current, live); - VSH_EXCLUSIVE_OPTIONS_VAR(current, config); - - if (config || persistent) - flags |= VIR_DOMAIN_AFFECT_CONFIG; - if (live) - flags |= VIR_DOMAIN_AFFECT_LIVE; - - if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) - return false; if (vshCommandOptStringReq(ctl, cmd, "type", &type) < 0) goto cleanup; @@ -10859,15 +10823,6 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "mac", &mac) < 0) goto cleanup; - if (persistent && - virDomainIsActive(dom) == 1) - flags |= VIR_DOMAIN_AFFECT_LIVE; - - if (flags & VIR_DOMAIN_AFFECT_CONFIG) - doc = virDomainGetXMLDesc(dom, VIR_DOMAIN_XML_INACTIVE); - else - doc = virDomainGetXMLDesc(dom, 0); - if (!doc) goto cleanup; @@ -10935,20 +10890,72 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) else ret = virDomainDetachDevice(dom, detach_xml); - if (ret != 0) { - vshError(ctl, "%s", _("Failed to detach interface")); - } else { - vshPrint(ctl, "%s", _("Interface detached successfully\n")); + if (ret == 0) functionReturn = true; - } cleanup: - VIR_FREE(doc); VIR_FREE(detach_xml); - virDomainFree(dom); + xmlFreeDoc(xml); xmlXPathFreeObject(obj); xmlXPathFreeContext(ctxt); - xmlFreeDoc(xml); + return functionReturn; +} + +static bool +cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) +{ + virDomainPtr dom = NULL; + unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; + char *doc_live = NULL, *doc_config = NULL; + bool current = vshCommandOptBool(cmd, "current"); + bool config = vshCommandOptBool(cmd, "config"); + bool live = vshCommandOptBool(cmd, "live"); + bool persistent = vshCommandOptBool(cmd, "persistent"); + bool functionReturn = false; + + VSH_EXCLUSIVE_OPTIONS_VAR(persistent, current); + + VSH_EXCLUSIVE_OPTIONS_VAR(current, live); + VSH_EXCLUSIVE_OPTIONS_VAR(current, config); + + if (config || persistent) + flags |= VIR_DOMAIN_AFFECT_CONFIG; + + if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) + return false; + + if (persistent && + virDomainIsActive(dom) == 1) + flags |= VIR_DOMAIN_AFFECT_LIVE; + + if (flags & VIR_DOMAIN_AFFECT_CONFIG) { + doc_config = virDomainGetXMLDesc(dom, VIR_DOMAIN_XML_INACTIVE); + if (!(functionReturn = vshDomainDetachInterface(doc_config, flags, dom, ctl, cmd))) + goto cleanup; + } + + if (live || (!live && !config)) + flags |= VIR_DOMAIN_AFFECT_LIVE; + + if (flags & VIR_DOMAIN_AFFECT_LIVE) { + doc_live = virDomainGetXMLDesc(dom, 0); + + if (flags & VIR_DOMAIN_AFFECT_CONFIG) + flags &= (~VIR_DOMAIN_AFFECT_CONFIG); + + functionReturn = vshDomainDetachInterface(doc_live, flags, dom, ctl, cmd); + } + + cleanup: + if (functionReturn == false) { + vshError(ctl, "%s", _("Failed to detach interface")); + } else { + vshPrint(ctl, "%s", _("Interface detached successfully\n")); + functionReturn = true; + } + VIR_FREE(doc_live); + VIR_FREE(doc_config); + virDomainFree(dom); return functionReturn; }

1 0

[libvirt] Ext transport mode libvirt
by nidhi d 07 Mar '16

07 Mar '16

How do i create a new mode of communication between source and destination using ext mode of transport?

1 0

[libvirt] [PATCH] qemu: Support to detach redirdev device
by Osier Yang 06 Mar '16

06 Mar '16

Attaching redirdev device has been supported for a while, but detaching is not never implemented. Simple procedure to test: % lsusb Bus 001 Device 014: ID 0781:5567 SanDisk Corp. Cruzer Blade % usbredirserver -p 4000 0781:5567 % virsh attach-device test usb.xml % cat usb.xml <redirdev bus='usb' type='tcp'> <source mode='connect' host='192.168.84.6' service='4000'/> </redirdev> % virsh detach-device test usb.xml % virsh qemu-monitor-command test --pretty '{"execute": "query-chardev"}' | grep 4000 On success, the chardev should not seen in output of above command. --- src/conf/domain_conf.c | 67 +++++++++++++++++++++++++++++++++ src/conf/domain_conf.h | 4 ++ src/libvirt_private.syms | 3 ++ src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 97 +++++++++++++++++++++++++++++++++++++++++++++++- src/qemu/qemu_hotplug.h | 3 ++ 6 files changed, 176 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 3b15cb4..d304232 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -13825,6 +13825,73 @@ virDomainMemoryRemove(virDomainDefPtr def, return ret; } +ssize_t +virDomainRedirdevFind(virDomainDefPtr def, + virDomainRedirdevDefPtr redirdev) +{ + size_t i; + + for (i = 0; i < def->nredirdevs; i++) { + virDomainRedirdevDefPtr tmp = def->redirdevs[i]; + + if (redirdev->bus != tmp->bus) + continue; + + virDomainChrSourceDef source_chr = redirdev->source.chr; + virDomainChrSourceDef tmp_chr = tmp->source.chr; + + if (source_chr.type != tmp_chr.type) + continue; + + switch (source_chr.type) { + case VIR_DOMAIN_CHR_TYPE_TCP: + if (STRNEQ_NULLABLE(source_chr.data.tcp.host, + tmp_chr.data.tcp.host)) + continue; + if (STRNEQ_NULLABLE(source_chr.data.tcp.service, + tmp_chr.data.tcp.service)) + continue; + if (source_chr.data.tcp.listen != tmp_chr.data.tcp.listen) + continue; + if (source_chr.data.tcp.protocol != tmp_chr.data.tcp.protocol) + continue; + break; + + case VIR_DOMAIN_CHR_TYPE_SPICEVMC: + if (source_chr.data.spicevmc != tmp_chr.data.spicevmc) + continue; + break; + + default: + /* Unlikely, currently redirdev only supports character device of + * type "tcp" and "spicevmc". + */ + break; + } + + if (redirdev->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE && + !virDomainDeviceInfoAddressIsEqual(&redirdev->info, &tmp->info)) + continue; + + break; + } + + if (i < def->nredirdevs) + return i; + + return -1; +} + +virDomainRedirdevDefPtr +virDomainRedirdevRemove(virDomainDefPtr def, + size_t idx) +{ + virDomainRedirdevDefPtr ret = def->redirdevs[idx]; + + VIR_DELETE_ELEMENT(def->redirdevs, idx, def->nredirdevs); + + return ret; +} char * virDomainDefGetDefaultEmulator(virDomainDefPtr def, diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 1de3be3..03c0155 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2538,6 +2538,10 @@ void virDomainHostdevDefClear(virDomainHostdevDefPtr def); void virDomainHostdevDefFree(virDomainHostdevDefPtr def); void virDomainHubDefFree(virDomainHubDefPtr def); void virDomainRedirdevDefFree(virDomainRedirdevDefPtr def); +ssize_t virDomainRedirdevFind(virDomainDefPtr def, + virDomainRedirdevDefPtr redirdev); +virDomainRedirdevDefPtr virDomainRedirdevRemove(virDomainDefPtr def, + size_t idx); void virDomainRedirFilterDefFree(virDomainRedirFilterDefPtr def); void virDomainShmemDefFree(virDomainShmemDefPtr def); void virDomainDeviceDefFree(virDomainDeviceDefPtr def); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 4b40612..ad7d82c 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -423,6 +423,9 @@ virDomainPMSuspendedReasonTypeFromString; virDomainPMSuspendedReasonTypeToString; virDomainRedirdevBusTypeFromString; virDomainRedirdevBusTypeToString; +virDomainRedirdevDefFree; +virDomainRedirdevFind; +virDomainRedirdevRemove; virDomainRNGBackendTypeToString; virDomainRNGDefFree; virDomainRNGFind; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 45ff3c0..8905af6 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7736,6 +7736,9 @@ qemuDomainDetachDeviceLive(virDomainObjPtr vm, case VIR_DOMAIN_DEVICE_MEMORY: ret = qemuDomainDetachMemoryDevice(driver, vm, dev->data.memory); break; + case VIR_DOMAIN_DEVICE_REDIRDEV: + ret = qemuDomainDetachRedirdevDevice(driver, vm, dev->data.redirdev); + break; case VIR_DOMAIN_DEVICE_FS: case VIR_DOMAIN_DEVICE_INPUT: @@ -7748,7 +7751,6 @@ qemuDomainDetachDeviceLive(virDomainObjPtr vm, case VIR_DOMAIN_DEVICE_MEMBALLOON: case VIR_DOMAIN_DEVICE_NVRAM: case VIR_DOMAIN_DEVICE_SHMEM: - case VIR_DOMAIN_DEVICE_REDIRDEV: case VIR_DOMAIN_DEVICE_NONE: case VIR_DOMAIN_DEVICE_TPM: case VIR_DOMAIN_DEVICE_PANIC: diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index dc76268..bbe8aa7 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3287,6 +3287,49 @@ qemuDomainRemoveRNGDevice(virQEMUDriverPtr driver, } +static int +qemuDomainRemoveRedirdevDevice(virQEMUDriverPtr driver, + virDomainObjPtr vm, + virDomainRedirdevDefPtr redirdev) +{ + qemuDomainObjPrivatePtr priv = vm->privateData; + virObjectEventPtr event; + char *charAlias = NULL; + ssize_t idx; + int rc; + int ret = -1; + + VIR_DEBUG("Removing redirdev device %s from domain %p %s", + redirdev->info.alias, vm, vm->def->name); + + if (virAsprintf(&charAlias, "char%s", redirdev->info.alias) < 0) + return -1; + + qemuDomainObjEnterMonitor(driver, vm); + rc = qemuMonitorDetachCharDev(priv->mon, charAlias); + if (qemuDomainObjExitMonitor(driver, vm) < 0) + goto cleanup; + + virDomainAuditRedirdev(vm, redirdev, "detach", rc == 0); + + if (rc < 0) + goto cleanup; + + event = virDomainEventDeviceRemovedNewFromObj(vm, redirdev->info.alias); + qemuDomainEventQueue(driver, event); + + if ((idx = virDomainRedirdevFind(vm->def, redirdev)) >= 0) + virDomainRedirdevRemove(vm->def, idx); + qemuDomainReleaseDeviceAddress(vm, &redirdev->info, NULL); + virDomainRedirdevDefFree(redirdev); + + ret = 0; + + cleanup: + VIR_FREE(charAlias); + return ret; +} + int qemuDomainRemoveDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, @@ -3318,6 +3361,10 @@ qemuDomainRemoveDevice(virQEMUDriverPtr driver, ret = qemuDomainRemoveMemoryDevice(driver, vm, dev->data.memory); break; + case VIR_DOMAIN_DEVICE_REDIRDEV: + ret = qemuDomainRemoveRedirdevDevice(driver, vm, dev->data.redirdev); + break; + case VIR_DOMAIN_DEVICE_NONE: case VIR_DOMAIN_DEVICE_LEASE: case VIR_DOMAIN_DEVICE_FS: @@ -3327,7 +3374,6 @@ qemuDomainRemoveDevice(virQEMUDriverPtr driver, case VIR_DOMAIN_DEVICE_WATCHDOG: case VIR_DOMAIN_DEVICE_GRAPHICS: case VIR_DOMAIN_DEVICE_HUB: - case VIR_DOMAIN_DEVICE_REDIRDEV: case VIR_DOMAIN_DEVICE_SMARTCARD: case VIR_DOMAIN_DEVICE_MEMBALLOON: case VIR_DOMAIN_DEVICE_NVRAM: @@ -4318,3 +4364,52 @@ qemuDomainDetachMemoryDevice(virQEMUDriverPtr driver, qemuDomainResetDeviceRemoval(vm); return ret; } + +int +qemuDomainDetachRedirdevDevice(virQEMUDriverPtr driver, + virDomainObjPtr vm, + virDomainRedirdevDefPtr redirdev) +{ + qemuDomainObjPrivatePtr priv = vm->privateData; + virDomainRedirdevDefPtr tmp; + ssize_t idx; + int rc; + int ret = -1; + + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_DEVICE)) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("qemu does not support -device")); + return -1; + } + + if ((idx = virDomainRedirdevFind(vm->def, redirdev)) < 0) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("device not present in domain configuration")); + return -1; + } + + tmp = vm->def->redirdevs[idx]; + + if (!tmp->info.alias) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("alias not set for redirdev device")); + return -1; + } + + qemuDomainMarkDeviceForRemoval(vm, &tmp->info); + + qemuDomainObjEnterMonitor(driver, vm); + rc = qemuMonitorDelDevice(priv->mon, tmp->info.alias); + if (qemuDomainObjExitMonitor(driver, vm) || rc < 0) + goto cleanup; + + rc = qemuDomainWaitForDeviceRemoval(vm); + if (rc == 0 || rc == 1) + ret = qemuDomainRemoveRedirdevDevice(driver, vm, tmp); + else + ret = 0; + + cleanup: + qemuDomainResetDeviceRemoval(vm); + return ret; +} diff --git a/src/qemu/qemu_hotplug.h b/src/qemu/qemu_hotplug.h index 4140da3..4ef42e9 100644 --- a/src/qemu/qemu_hotplug.h +++ b/src/qemu/qemu_hotplug.h @@ -51,6 +51,9 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, int qemuDomainAttachRedirdevDevice(virQEMUDriverPtr driver, virDomainObjPtr vm, virDomainRedirdevDefPtr hostdev); +int qemuDomainDetachRedirdevDevice(virQEMUDriverPtr driver, + virDomainObjPtr vm, + virDomainRedirdevDefPtr redirdev); int qemuDomainAttachHostDevice(virConnectPtr conn, virQEMUDriverPtr driver, virDomainObjPtr vm, -- 2.1.4

2 2

[libvirt] patch doc/apps.html.in
by Alex Roithman 05 Mar '16

05 Mar '16

Follow to http://libvirt.org/apps.html#add send the patch.

1 0

[libvirt] [PATCH 0/3] vz: disk format support
by Mikhail Feoktistov 04 Mar '16

04 Mar '16

Mikhail Feoktistov (3): vz: add vzInitVersion function vz: add virStorageFileFormat to connection structure vz: check supported disk format src/vz/vz_driver.c | 52 +++++++----------------------------------- src/vz/vz_sdk.c | 28 ++++++++++++++++------- src/vz/vz_sdk.h | 2 +- src/vz/vz_utils.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_utils.h | 10 +++++++++ 5 files changed, 105 insertions(+), 53 deletions(-) -- 1.8.3.1

1 4

[libvirt] [PATCH] virLXCProcessMonitorInitNotify: Initialize @inode
by Michal Privoznik 04 Mar '16

04 Mar '16

This is an error message I've just seen. Fix it by initializing @inode. CC lxc/libvirt_driver_lxc_impl_la-lxc_process.lo lxc/lxc_process.c: In function 'virLXCProcessMonitorInitNotify': lxc/lxc_process.c:767:23: error: 'inode' may be used uninitialized in this function [-Werror=maybe-uninitialized] virDomainAuditInit(vm, initpid, inode); ^ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. src/lxc/lxc_process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 50bee48..5e0bbe2 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -749,7 +749,7 @@ static void virLXCProcessMonitorInitNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED virLXCDriverPtr driver = lxc_driver; virLXCDomainObjPrivatePtr priv; virLXCDriverConfigPtr cfg = virLXCDriverGetConfig(driver); - ino_t inode; + ino_t inode = 0; virObjectLock(vm); @@ -762,7 +762,6 @@ static void virLXCProcessMonitorInitNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED (unsigned long long)initpid, err && err->message ? err->message : "<unknown>"); virResetLastError(); - inode = 0; } virDomainAuditInit(vm, initpid, inode); -- 2.4.10

1 0

[libvirt] [PATCH v3 0/2] cleanup resolving persistent/running/current flags
by Nikolay Shirokovskiy 04 Mar '16

04 Mar '16

Changes from version2 ===================== 1. Already ACKed or PUSHed patches are dropped. 2. Patch of reusing virDomainObjUpdateModificationImpact is splitted into lxc and libxl and compilation is fixed. Nikolay Shirokovskiy (2): lxc: reuse virDomainObjUpdateModificationImpact libxl: reuse virDomainObjUpdateModificationImpact src/libxl/libxl_driver.c | 63 ++++------------------------------------ src/lxc/lxc_driver.c | 75 ++++-------------------------------------------- 2 files changed, 12 insertions(+), 126 deletions(-) -- 1.8.3.1

3 4

[libvirt] [PATCH] tools: do not leak uri in disconnect handler
by Ján Tomko 04 Mar '16

04 Mar '16

Commit 035947e introduced a call to virConnectGetURI without a matching free() in virshCatchDisconnect. Also fix vshAdmCatchDisconnect where it was copied by commit 6dd7e42. https://bugzilla.redhat.com/show_bug.cgi?id=1303891 --- tools/virsh.c | 1 + tools/virt-admin.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/virsh.c b/tools/virsh.c index 72446be..57b4ff3 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -124,6 +124,7 @@ virshCatchDisconnect(virConnectPtr conn, break; } vshError(ctl, _(str), NULLSTR(uri)); + VIR_FREE(uri); if (error) { virSetError(error); diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 3c818a3..c470536 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -92,6 +92,7 @@ vshAdmCatchDisconnect(virAdmConnectPtr conn ATTRIBUTE_UNUSED, } vshError(ctl, _(str), NULLSTR(uri)); + VIR_FREE(uri); if (error) { virSetError(error); -- 2.4.10

2 1

[libvirt] [PATCH v2 0/4] cleanup resolving persistent/running/current flags
by Nikolay Shirokovskiy 04 Mar '16

04 Mar '16

Original name of series was: Subject: [PATCH 0/3] make virDomainObjGetPersistentDef return only persistent definition Changes from version1 ===================== Original motivation of the series was fixing virDomainObjGetPersistentDef so that it would not return configs other than persistent. However the final patch that does it in the first version is absent in current version. I think the fix should be done another way and in different series. Thus this version has only misc cleanups which are better splitted into patches in this version. A few words why I leave patch for virDomainObjGetPersistentDef. First I should not return NULL from the function as this value already has different meaning - memory allocation error and there is code that checks for this error. This code calls virDomainObjGetPersistentDef unconditionally but later use the return value only for persistent domains, thus it could get NULL pointer on function call and treat it as an allocation error. I think the proper way would be chaning virDomainObjGetPersistentDef so it could not fail that is not call virDomainObjSetDefTransient. Looks like this is already true because drivers that distiguish between running/persistent config call virDomainObjSetDefTransient ealy in the domain start process (and even two times) so that later calls for virDomainObjSetDefTransient are unnecessary. Nikolay Shirokovskiy (4): virDomainObjUpdateModificationImpact: reduce nesting libxlDomainSetMemoryFlags : reuse virDomainLiveConfigHelperMethod lxc, libxl: reuse virDomainObjUpdateModificationImpact libxlDomainPinVcpuFlags: remove check duplicates src/conf/domain_conf.c | 12 +++--- src/libxl/libxl_driver.c | 103 ++++------------------------------------------- src/lxc/lxc_driver.c | 75 +++------------------------------- 3 files changed, 19 insertions(+), 171 deletions(-) -- 1.8.3.1

3 14

[libvirt] [PATCH] Use correct LDFLAGS for leaseshelper
by Jiri Denemark 03 Mar '16

03 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/Makefile.am | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Makefile.am b/src/Makefile.am index a316b4d..d57d303 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2810,6 +2810,10 @@ libvirt_iohelper_CFLAGS = \ if WITH_NETWORK libexec_PROGRAMS += libvirt_leaseshelper libvirt_leaseshelper_SOURCES = $(NETWORK_LEASES_HELPER_SOURCES) +libvirt_leaseshelper_LDFLAGS = \ + $(AM_LDFLAGS) \ + $(PIE_LDFLAGS) \ + $(NULL) libvirt_leaseshelper_LDADD = \ libvirt_util.la \ ../gnulib/lib/libgnu.la -- 2.7.2

2 1

[libvirt] [PATCH] qemu: Check if domain is active in GetControlInfo
by Jiri Denemark 03 Mar '16

03 Mar '16

Reporting status of a control connection makes no sense for an inactive domain. https://bugzilla.redhat.com/show_bug.cgi?id=1281706 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4bd4071..9fd4c57 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2763,6 +2763,12 @@ qemuDomainGetControlInfo(virDomainPtr dom, if (virDomainGetControlInfoEnsureACL(dom->conn, vm->def) < 0) goto cleanup; + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("domain is not running")); + goto cleanup; + } + priv = vm->privateData; memset(info, 0, sizeof(*info)); -- 2.7.2

2 1

[libvirt] [PATCH] qemu: forbid renaming domain which has managedsave file
by Shanzhi Yu 03 Mar '16

03 Mar '16

after rename a domain which has managedsave file, the new name domain can't boot up from the state it saved, and the managedsave file will exist with the original name. Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/qemu/qemu_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 4bd4071..036a367 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20000,6 +20000,12 @@ static int qemuDomainRename(virDomainPtr dom, goto endjob; } + if (vm->hasManagedSave) { + virReportError(VIR_ERR_OPERATION_INVALID, "%s", + _("can't rename a domain has managedsave file")); + goto endjob; + } + if (virDomainObjListRename(driver->domains, vm, new_name, flags, qemuDomainRenameCallback, driver) < 0) goto endjob; -- 2.5.0

1 0

[libvirt] [PATCH 0/7] Couple of -Os fixes
by Michal Privoznik 03 Mar '16

03 Mar '16

So while trying to bring down the size of my nss module, one of the things I've tried was compiling with -Os instead of -O3. Interesting errors pop up. Here are the fixes. If you think I should squash some patches together, I will gladly do that. Michal Privoznik (7): virCommandAddEnv: Drop inline virDomainNumatuneNodeSpecified: Drop inline virDomainChrRemove: Initialize @ret vbox: Initialize @rc qemuDomainBlockCommit: Initialize @baseSource virNetworkDefForwardIf: drop inline virStorageBackendLogicalMatchPoolSource: Initialize @thisSource src/conf/domain_conf.c | 2 +- src/conf/network_conf.c | 8 ++++++++ src/conf/network_conf.h | 8 +------- src/conf/numa_conf.c | 2 +- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 2 +- src/storage/storage_backend_logical.c | 2 +- src/util/vircommand.c | 2 +- src/vbox/vbox_common.c | 2 +- src/vbox/vbox_tmpl.c | 2 +- 10 files changed, 17 insertions(+), 14 deletions(-) -- 2.4.10

2 9

[libvirt] [PATCH] daemon: fixup refcounting in close callback handling
by Nikolay Shirokovskiy 03 Mar '16

03 Mar '16

remoteDispatchConnectCloseCallbackRegister introduced in f484310add53ebdc26a6fdcb88bc398750325b7e has problems. It refcounts network client object and in case of NOOP driver operations for close callback registering/unregistering (any driveres besides vz) nobody will unref it later. As a result client connection will not be disposed and driver connection will not be closed. The fix is easy. We don't need to refcount at all. We don't get dangling pointer because in remoteClientFreeFunc which is called upon disposing this network client object we unregistering close callback. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- daemon/remote.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 04d8ada..17783fa 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -3382,11 +3382,9 @@ remoteDispatchConnectCloseCallbackRegister(virNetServerPtr server ATTRIBUTE_UNUS goto cleanup; } - // on behalf of close callback - virObjectRef(client); if (virConnectRegisterCloseCallback(priv->conn, remoteRelayConnectionClosedEvent, - client, virObjectFreeCallback) < 0) + client, NULL) < 0) goto cleanup; priv->closeRegistered = true; -- 1.8.3.1

2 1

[libvirt] [PATCH] Reject migration with both --live and --offline when migration requested from other clients/API.
by Nitesh Konkar 03 Mar '16

03 Mar '16

--- src/libvirt-domain.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 9491845..6a5034e 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3616,6 +3616,13 @@ virDomainMigrate(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if ((flags & VIR_MIGRATE_OFFLINE) && (flags & VIR_MIGRATE_LIVE)) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Options --live and --offline are " + "mutually exclusive")); + goto error; + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { @@ -3840,6 +3847,13 @@ virDomainMigrate2(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if ((flags & VIR_MIGRATE_OFFLINE) && (flags & VIR_MIGRATE_LIVE)) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Options --live and --offline are " + "mutually exclusive")); + goto error; + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { @@ -4014,6 +4028,13 @@ virDomainMigrate3(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if ((flags & VIR_MIGRATE_OFFLINE) && (flags & VIR_MIGRATE_LIVE)) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Options --live and --offline are " + "mutually exclusive")); + goto error; + } + if (flags & VIR_MIGRATE_PEER2PEER) { virReportInvalidArg(flags, "%s", _("use virDomainMigrateToURI3 for peer-to-peer " -- 1.8.3.1

2 1

[libvirt] [PATCH v3] This patch gives an error when migration is attempted with both --live and --offline options.
by Nitesh Konkar 03 Mar '16

03 Mar '16

Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 43c8436..b9f678f 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9838,6 +9838,8 @@ cmdMigrate(vshControl *ctl, const vshCmd *cmd) bool live_flag = false; virshCtrlData data = { .dconn = NULL }; + VSH_EXCLUSIVE_OPTIONS("live", "offline"); + if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) return false; -- 1.8.3.1

3 3

[libvirt] [PATCH] util: Cleanup error path for virPolkitAgentCreate
by John Ferlan 03 Mar '16

03 Mar '16

More fallout from changing to using virPolkitAgent and handling error paths. Needed to clear the 'cmd' once stored and of course add the virCommandFree(cmd) in the error: label. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Found by coverity... Pushed as trivial... src/util/virpolkit.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 44f2328..2038744 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -182,6 +182,7 @@ virPolkitAgentCreate(void) if (VIR_ALLOC(agent) < 0) goto error; agent->cmd = cmd; + cmd = NULL; virCommandAddArgFormat(cmd, "%lld", (long long int) getpid()); virCommandAddArg(cmd, "--notify-fd"); @@ -206,6 +207,7 @@ virPolkitAgentCreate(void) VIR_FORCE_CLOSE(pipe_fd[0]); VIR_FORCE_CLOSE(pipe_fd[1]); virPolkitAgentDestroy(agent); + virCommandFree(cmd); return NULL; } -- 2.5.0

1 0

[libvirt] [PATCH] datatypes.c: Replace 'close' with 'closeData'
by Michal Privoznik 02 Mar '16

02 Mar '16

Older compilers fail to see that 'close' is not used a function rather than a variable and produce the following error: cc1: warnings being treated as errors ../../src/datatypes.c: In function 'virConnectCloseCallbackDataReset': ../../src/datatypes.c:149: error: declaration of 'close' shadows a global declaration [-Wshadow] Replace all the 'close' occurrences with 'closeData' to resolve this. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/datatypes.c | 72 ++++++++++++++++++++++++++++----------------------------- 1 file changed, 36 insertions(+), 36 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index 163db39..696e8c0 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -145,16 +145,16 @@ virConnectDispose(void *obj) } -static -void virConnectCloseCallbackDataReset(virConnectCloseCallbackDataPtr close) +static void +virConnectCloseCallbackDataReset(virConnectCloseCallbackDataPtr closeData) { - if (close->freeCallback) - close->freeCallback(close->opaque); + if (closeData->freeCallback) + closeData->freeCallback(closeData->opaque); - close->freeCallback = NULL; - close->opaque = NULL; - virObjectUnref(close->conn); - close->conn = NULL; + closeData->freeCallback = NULL; + closeData->opaque = NULL; + virObjectUnref(closeData->conn); + closeData->conn = NULL; } /** @@ -178,77 +178,77 @@ virNewConnectCloseCallbackData(void) return virObjectLockableNew(virConnectCloseCallbackDataClass); } -void virConnectCloseCallbackDataRegister(virConnectCloseCallbackDataPtr close, +void virConnectCloseCallbackDataRegister(virConnectCloseCallbackDataPtr closeData, virConnectPtr conn, virConnectCloseFunc cb, void *opaque, virFreeCallback freecb) { - virObjectLock(close); + virObjectLock(closeData); - if (close->callback != NULL) { + if (closeData->callback != NULL) { VIR_WARN("Attempt to register callback on armed" - " close callback object %p", close); + " close callback object %p", closeData); goto cleanup; return; } - close->conn = conn; - virObjectRef(close->conn); - close->callback = cb; - close->opaque = opaque; - close->freeCallback = freecb; + closeData->conn = conn; + virObjectRef(closeData->conn); + closeData->callback = cb; + closeData->opaque = opaque; + closeData->freeCallback = freecb; cleanup: - virObjectUnlock(close); + virObjectUnlock(closeData); } -void virConnectCloseCallbackDataUnregister(virConnectCloseCallbackDataPtr close, +void virConnectCloseCallbackDataUnregister(virConnectCloseCallbackDataPtr closeData, virConnectCloseFunc cb) { - virObjectLock(close); + virObjectLock(closeData); - if (close->callback != cb) { + if (closeData->callback != cb) { VIR_WARN("Attempt to unregister different callback on " - " close callback object %p", close); + " close callback object %p", closeData); goto cleanup; } - virConnectCloseCallbackDataReset(close); - close->callback = NULL; + virConnectCloseCallbackDataReset(closeData); + closeData->callback = NULL; cleanup: - virObjectUnlock(close); + virObjectUnlock(closeData); } -void virConnectCloseCallbackDataCall(virConnectCloseCallbackDataPtr close, +void virConnectCloseCallbackDataCall(virConnectCloseCallbackDataPtr closeData, int reason) { - virObjectLock(close); + virObjectLock(closeData); - if (!close->conn) + if (!closeData->conn) goto exit; VIR_DEBUG("Triggering connection close callback %p reason=%d, opaque=%p", - close->callback, reason, close->opaque); - close->callback(close->conn, reason, close->opaque); + closeData->callback, reason, closeData->opaque); + closeData->callback(closeData->conn, reason, closeData->opaque); - virConnectCloseCallbackDataReset(close); + virConnectCloseCallbackDataReset(closeData); exit: - virObjectUnlock(close); + virObjectUnlock(closeData); } virConnectCloseFunc -virConnectCloseCallbackDataGetCallback(virConnectCloseCallbackDataPtr close) +virConnectCloseCallbackDataGetCallback(virConnectCloseCallbackDataPtr closeData) { virConnectCloseFunc cb; - virObjectLock(close); - cb = close->callback; - virObjectUnlock(close); + virObjectLock(closeData); + cb = closeData->callback; + virObjectUnlock(closeData); return cb; } -- 2.4.10

1 1

[libvirt] after update to libvirt >= 1.2.9.3 no connection to libvirtd (time out) - bug 1308736
by Florian Hubold 02 Mar '16

02 Mar '16

Hi all, I've reported https://bugzilla.redhat.com/show_bug.cgi?id=1308736 two weeks ago, including the results of a git bisect. It would be greatly appreciated if someone could take a look, otherwise we can't push an update for CVE-2015-5313 for our stable distribution. Kind regards and thanks in advance

1 0

[libvirt] [PATCH] util: Fix missing initializer for agent
by John Ferlan 02 Mar '16

02 Mar '16

In virPolkitAgentCreate neglected to initialize agent to NULL. If there was an error in the pipe, then we jump to error and would have an issue. Found by coverity. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushing as trivial src/util/virpolkit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 3d2be61..44f2328 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -166,7 +166,7 @@ virPolkitAgentDestroy(virPolkitAgentPtr agent) virPolkitAgentPtr virPolkitAgentCreate(void) { - virPolkitAgentPtr agent; + virPolkitAgentPtr agent = NULL; virCommandPtr cmd = virCommandNewArgList(PKTTYAGENT, "--process", NULL); int pipe_fd[2] = {-1, -1}; struct pollfd pollfd; -- 2.5.0

1 0

[libvirt] Libvirt accepted to GSoC
by Michal Privoznik 02 Mar '16

02 Mar '16

Dear community, let me announce great news: Libvirt applied for this year's Google Summer of Code and got accepted [1]! You may recall that in previous years we created a joint organisation with QEMU/KVM folks and participated that way. However, since the number of libvirt students was growing and usually exceeded number of QEMU or KVM students combined it started to become more and more obvious that libvirt should no longer misuse hospitality of QEMU/KVM volunteers and try on its own. And it worked. In addition, QEMU/KVM organisation has been accepted too - join me in congratulating them and saying big thank you for all of the work that they have done for us in those previous years! The idea of splitting has been discussed here too [2]. What to do next? You can still propose ideas, and ideally add them to the list [3]. Or if you don't feel confident enough, drop me an e-mail and I'll take care of that. It's until 14th March that students are able to start filling in their proposals. And this is where this year differs from the previous ones - the deadline for proposals is 25th March. Without proposal no student can be accepted to the program. So you may help by spreading the word too. Happy coding! Michal 1: https://summerofcode.withgoogle.com/organizations/5982501017223168/ 2: https://www.redhat.com/archives/libvir-list/2016-January/msg01076.html 3: http://wiki.libvirt.org/page/Google_Summer_of_Code_2016

1 0

[libvirt] [PATCH] Libvirt: Add missing default value for config option max_queued_clients
by Jason J. Herne 02 Mar '16

02 Mar '16

Commit 1199edb1d4e3 added config option max_queued_clients and documented the default value as 1000 but never actually set that value. This patch sets the default value. This addresses an issue whereby the following error message is reported if too many migrations are started simultaneously: error: End of file while reading data: Ncat: Invalid argument.: Input/output error The problem is that too many ncat processes are spawned on the destination system. They all attempt to connect to the libvirt socket. Because the destination libvirtd cannot respond to the connect requests quickly enough we overrun the socket's pending connections queue. Signed-off-by: Jason J. Herne <jjherne(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- daemon/libvirtd-config.c | 1 + 1 file changed, 1 insertion(+) diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c index c31c8b2..7a448f9 100644 --- a/daemon/libvirtd-config.c +++ b/daemon/libvirtd-config.c @@ -280,6 +280,7 @@ daemonConfigNew(bool privileged ATTRIBUTE_UNUSED) data->min_workers = 5; data->max_workers = 20; data->max_clients = 5000; + data->max_queued_clients = 1000; data->max_anonymous_clients = 20; data->prio_workers = 5; -- 1.9.1

2 1

[libvirt] [PATCH] docs: Clarify interface/target/@dev docs
by Jiri Denemark 01 Mar '16

01 Mar '16

https://bugzilla.redhat.com/show_bug.cgi?id=1313314 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/formatdomain.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index c54b308..df8c06c 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4507,10 +4507,10 @@ qemu-kvm -net nic,model=? /dev/null If no target is specified, certain hypervisors will automatically generate a name for the created tun device. This - name can be manually specified, however the name must not + name can be manually specified, however the name should not start with either 'vnet' or 'vif', which are prefixes reserved by libvirt and certain hypervisors. Manually specified - targets using these prefixes will be ignored. + targets using these prefixes may be ignored. -- 2.7.2

3 3

[libvirt] [PATCH v7 0/6] Global domain cpu.cfs_period_us and cpu.cfs_quota_us setup
by Alexander Burluka 01 Mar '16

01 Mar '16

This patchset implements an ability to specify values for domain top level cpu.cfs_period_us and cpu.cfs_quota_us cgroups. These parameters are opt-in and named "global_period" and "global_quota". Introduction of these settings gives management applications further choice of controlling CPU usage. Changes in v2: add XML validation test Changes in v3: remove unneccessary cgroup copying Changes in v4: fix little rebase error Changes in v5: rebase to version 1.3.1 Changes in v6: remove unnecessary check Changes in v7: rebase to current master Alexander Burluka (6): Add global period definitions Add global quota parameter necessary definitions Add error checking on global quota and period Add global_period and global_quota XML validation test Implement qemuSetupGlobalCpuCgroup Implement handling of per-domain bandwidth settings docs/schemas/domaincommon.rng | 10 +++ include/libvirt/libvirt-domain.h | 32 +++++++ src/conf/domain_conf.c | 37 +++++++++ src/conf/domain_conf.h | 2 + src/qemu/qemu_cgroup.c | 49 +++++++++++ src/qemu/qemu_cgroup.h | 1 + src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 97 +++++++++++++++++++++- src/qemu/qemu_process.c | 4 + tests/qemuxml2argvdata/qemuxml2argv-cputune.xml | 2 + .../qemuxml2xmloutdata/qemuxml2xmlout-cputune.xml | 2 + 11 files changed, 236 insertions(+), 3 deletions(-) -- 1.8.3.1

2 16

[libvirt] [PATCH] qemu: Don't always wait for SPICE to finish migration
by Jiri Denemark 01 Mar '16

01 Mar '16

When SPICE graphics is configured for a domain but we did not ask the client to switch to the destination, we should not wait for SPICE_MIGRATE_COMPLETED event (which will never come). https://bugzilla.redhat.com/show_bug.cgi?id=1151723 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_domain.h | 2 ++ src/qemu/qemu_migration.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 8359b1a..0144792 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -137,6 +137,8 @@ struct qemuDomainJobObj { qemuDomainJobInfoPtr current; /* async job progress data */ qemuDomainJobInfoPtr completed; /* statistics data of a recently completed job */ bool abortJob; /* abort of the job requested */ + bool spiceMigration; /* we asked for spice migration and we + * should wait for it to finish */ bool spiceMigrated; /* spice migration completed */ }; diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 704e182..64cbffa 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2415,7 +2415,8 @@ qemuMigrationWaitForSpice(virDomainObjPtr vm) bool wait_for_spice = false; size_t i = 0; - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_SEAMLESS_MIGRATION)) + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_SEAMLESS_MIGRATION) || + !priv->job.spiceMigration) return 0; for (i = 0; i < vm->def->ngraphics; i++) { @@ -2789,6 +2790,7 @@ qemuDomainMigrateGraphicsRelocate(virQEMUDriverPtr driver, QEMU_ASYNC_JOB_MIGRATION_OUT) == 0) { ret = qemuMonitorGraphicsRelocate(priv->mon, type, listenAddress, port, tlsPort, tlsSubject); + priv->job.spiceMigration = !ret; if (qemuDomainObjExitMonitor(driver, vm) < 0) ret = -1; } -- 2.7.2

2 2

[libvirt] [PATCH] qemu: Don't try to fetch migration stats on destination
by Jiri Denemark 01 Mar '16

01 Mar '16

Migration statistics are not available on the destination host and starting a query job during incoming migration is not allowed. Trying to do that would result in Timed out during operation: cannot acquire state change lock (held by remoteDispatchDomainMigratePrepare3Params) error. We should not even try to start the job. https://bugzilla.redhat.com/show_bug.cgi?id=1278727 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_driver.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 45ff3c0..241de67 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12901,9 +12901,16 @@ qemuDomainGetJobStatsInternal(virQEMUDriverPtr driver, if (!priv->job.current || !priv->job.current->stats.status) fetch = false; - if (fetch && - qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) - return -1; + if (fetch) { + if (priv->job.asyncJob == QEMU_ASYNC_JOB_MIGRATION_IN) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("migration statistics are available only on " + "the source host")); + return -1; + } + if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) + return -1; + } if (!completed && !virDomainObjIsActive(vm)) { -- 2.7.2

2 2

[libvirt] [PATCH] Fix formatting in remote_protocol-structs
by Jiri Denemark 01 Mar '16

01 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/remote_protocol-structs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 11048b7..6c1cf5d 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -2503,7 +2503,7 @@ struct remote_domain_event_callback_device_added_msg { remote_nonnull_string devAlias; }; struct remote_connect_event_connection_closed_msg { - int reason; + int reason; }; struct remote_connect_get_cpu_model_names_args { remote_nonnull_string arch; -- 2.7.2

1 1

[libvirt] [PATCH] util: Fix build without polkit
by Jiri Denemark 01 Mar '16

01 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virpolkit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 3bb60a5..3d2be61 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -329,13 +329,13 @@ int virPolkitCheckAuth(const char *actionid ATTRIBUTE_UNUSED, void -virPolkitAgentDestroy(virCommandPtr cmd ATTRIBUTE_UNUSED) +virPolkitAgentDestroy(virPolkitAgentPtr agent ATTRIBUTE_UNUSED) { return; /* do nothing */ } -virCommandPtr +virPolkitAgentPtr virPolkitAgentCreate(void) { virReportError(VIR_ERR_AUTH_FAILED, "%s", -- 2.7.2

1 1

[libvirt] [PATCH] qemu: enalbe hotplugging of macvtap device with multiqueue
by Shanzhi Yu 01 Mar '16

01 Mar '16

in commit 81a110, multiqueue for macvtap is enabled but forget to support hotplugging enabled Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/qemu/qemu_hotplug.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index dc76268..b580283 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -892,10 +892,11 @@ int qemuDomainAttachNetDevice(virConnectPtr conn, goto cleanup; } - /* Currently nothing besides TAP devices supports multiqueue. */ + /* Currently only TAP/macvtap devices supports multiqueue. */ if (net->driver.virtio.queues > 0 && !(actualType == VIR_DOMAIN_NET_TYPE_NETWORK || - actualType == VIR_DOMAIN_NET_TYPE_BRIDGE)) { + actualType == VIR_DOMAIN_NET_TYPE_BRIDGE || + actualType == VIR_DOMAIN_NET_TYPE_DIRECT)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Multiqueue network is not supported for: %s"), virDomainNetTypeToString(actualType)); -- 1.8.3.1

2 1

[libvirt] Wiki account
by Christophe Fergeau 01 Mar '16

01 Mar '16

Hey, I thought I already had a wiki account, but after a few failures to login or retrieve a password, it seems I don't, so I would like to get one for username 'teuf' Thanks, Christophe

2 1

[libvirt] [RFC] [libvirt-gconfig] Suggestion about (maybe) re-factoring GVirtConfigDomainGraphics
by Fabiano Fidêncio 01 Mar '16

01 Mar '16

Howdy! I've been trying to use libvirt-gobject and libvirt-gconfig, on virt-viewer, for accessing VMs and looking at their config, instead of using libvrit and parsing XML directly and turns out, that libvirt-gconfig is not exactly handful for a "read-only" use case (as virt-viewer's one). Let me try to explain pointing to some code as example and then I'll give my suggestions. For example, let's take a look on https://git.fedorahosted.org/cgit/virt-viewer.git/tree/src/virt-viewer.c#n4… In this function, the first thing done is to get the type of the graphic device (SPICE or VNC) and here is the first problem. There is no straightforward way for doing this on libvirt-gconfig (or is there?). Seems easier to continue getting the type using libxml and then use the specific spice/vnc functions for getting the properties. And here is the second problem, because I'll always need to have an if/else statement for getting the properties. Something like: if (g_str_equal(type, "vnc")) port = gvir_config_domain_graphics_vnc_get_port(domain); else if (g_str_equal(type, "spice")) port = gvir_config_domain_graphics_spice_get_port(domain); This kind of usage makes me think that libvirt-gconfig is missing some abstraction class, parent of GVirConfigDomainGraphics{Spice,Vnc,...) which could provide virtual functions like: gtype = gvir_config_domain_graphics_get_gtype(domain); port = gvir_config_domain_graphics_get_port(domain); Thinking a bit about it and taking a look in the GVirConfigDomainGraphics code, is possible to see a possibility for 2 new classes: GVirConfigDomainGraphicsLocal and GVirConfigDomainGraphicsRemote. Then we could have something like: GVirtConfigDomainGraphics |_ | GVirtConfigDomainGraphicsLocal | |_ | | GVirtConfigDomainGraphicsLocalDesktop | |_ | GVirtConfigDomainGraphicsLocalSdl |_ GVirtConfigDomainGraphicsRemote |_ | GVirtConfigDomainGraphicsRemoteSpice |_ | GVirtConfigDomainGraphicsRemoteVnc |_ GVirtConfigDomainGraphicsRemoteRdp I do know that Local and Remote are not exactly accurate names, but is the best that I could come up with. So, would be acceptable to introduce these two new classes and then have the specific graphics classes inheriting from those? Does this make sense for you, people? I'm more than happy in provide the code for this, but not before we discuss and set a decision about the approach. :-) I'm looking forward for some feedback. -- Fabiano Fidêncio

3 2

[libvirt] [PATCH v5 0/10] add close callback for drivers with persistent connection
by Nikolay Shirokovskiy 01 Mar '16

01 Mar '16

Currently close callback API can only inform us of closing the connection between remote driver and daemon. But what if a driver running in the daemon itself can have another persistent connection? In this case we want to be informed of that connection changes state too. This patch series extends meaning of current close callback API so that now it notifies of closing of any internal persistent connection. The overall approach is to move close callback support to drivers. Changes from v4: ================ 1. New patch "remote: factor out feature checks on connection open" to get rid of code dups. 2. "daemon: add connection close rpc" now checks if peer supports rpc for close callbacks. If it is not then we handle only disconnections to peer as before. Changes from v3: ================ Add patch [3] "close callback: make unregister clean after connect close event." Make register/unregister methods of connection close callback object return void. This solves the problem of patch [8] "daemon: add connection close rpc" ([7] in previous version) of consistent unregistering. All checks are moved outside of the methods. I hesitate whether to add or not means that track connection close callback object consinstency and finally decided to add (checks and warnings inside methods). The reason is that without these checks we get memory leaks which are rather difficult to find out. Unfortunately this change touch a number of patches as the first change is done in the first patch of the series. Changes from v2: ================ Split patches further to make it more comprehensible. Nikolay Shirokovskiy (10): factor out virConnectCloseCallbackDataPtr methods virConnectCloseCallbackData: fix connection object refcount close callback: make unregister clean after connect close event virConnectCloseCallbackData: factor out callback disarming close callback API: remove unnecessary locks virConnectCloseCallbackDataDispose: remove unnecessary locks close callback: move it to driver remote: factor out feature checks on connection open daemon: add connection close rpc vz: implement connection close notification daemon/libvirtd.h | 1 + daemon/remote.c | 85 ++++++++++++++++++++++ src/datatypes.c | 118 +++++++++++++++++++++++------- src/datatypes.h | 16 ++++- src/driver-hypervisor.h | 12 ++++ src/libvirt-host.c | 46 ++---------- src/libvirt_internal.h | 5 ++ src/remote/remote_driver.c | 167 ++++++++++++++++++++++++++++++++----------- src/remote/remote_protocol.x | 24 ++++++- src/remote_protocol-structs | 6 ++ src/vz/vz_driver.c | 59 +++++++++++++++ src/vz/vz_sdk.c | 4 ++ src/vz/vz_utils.h | 3 + 13 files changed, 433 insertions(+), 113 deletions(-) -- 1.8.3.1

2 23

[libvirt] [PATCHv2 0/3] reorder qemu cgroups operations
by Henning Schild 01 Mar '16

01 Mar '16

This is a much shorter series focusing on the key point, the second patch. The first patch is somehing that was found when looking at the code and is just a cosmetic change. The third patch just cleans up. They where both already ACKed. Patch 2 was also already ACKed but conflicted with another pending change. It should be reviewed in its new context. Note the new order with the "manual" affinity setting code. @Peter: qemuProcessInitCpuAffinity and qemuProcessSetupEmulator have a lot in in common. I guess there is potential for further simplification. The series is based on 92ec2e5e9b79b7df4d575040224bd606ab0b6dd8 with these two patches on top: http://www.redhat.com/archives/libvir-list/2016-February/msg01211.html Henning Schild (3): vircgroup: one central point for adding tasks to cgroups qemu_cgroup: put qemu right into emulator sub-cgroup qemu_cgroup: use virCgroupAddTask instead of virCgroupMoveTask src/libvirt_private.syms | 1 - src/qemu/qemu_process.c | 10 ++--- src/util/vircgroup.c | 105 +---------------------------------------------- src/util/vircgroup.h | 3 -- 4 files changed, 6 insertions(+), 113 deletions(-) -- 2.4.10

3 9

[libvirt] [PATCH 0/2] Remove old buggy check when pinning iothreads/emulators
by Peter Krempa 01 Mar '16

01 Mar '16

Peter Krempa (2): qemu: process: Move emulator thread setting code into one function qemu: Allow setting pinning of emulator/iohtread with automatic placement src/qemu/qemu_cgroup.c | 66 ----------------------------------------- src/qemu/qemu_cgroup.h | 1 - src/qemu/qemu_driver.c | 14 --------- src/qemu/qemu_process.c | 78 +++++++++++++++++++++++++++++++++++++++---------- 4 files changed, 62 insertions(+), 97 deletions(-) -- 2.6.2

2 6

[libvirt] [PATCH v3 0/7] NSS module for libvirt
by Michal Privoznik 01 Mar '16

01 Mar '16

v3 of: https://www.redhat.com/archives/libvir-list/2016-February/msg00693.html diff to v2: - don't link against libvirt.la rather than create a separate small lib to link with - teach nsstest to check multiple addresses Note that patches 1..4 have been ACKed already, but I'm sending them anyway for completeness. Michal Privoznik (7): Export virLease* functions for leases file handling virjson: Resolve const correctness Initial support for NSS plugin skeleton libvirt.spec.in: Introduce libvirt-nss package nss: Implement _nss_libvirt_gethostbyname3_r Implement _nss_libvirt_gethostbyname4_r nss: Introduce a test cfg.mk | 2 +- config-post.h | 21 ++ configure.ac | 2 + libvirt.spec.in | 21 ++ m4/virt-nss.m4 | 51 +++++ po/POTFILES.in | 1 + src/Makefile.am | 67 +++++++ src/libvirt_private.syms | 6 + src/network/leaseshelper.c | 271 +------------------------ src/util/virfile.c | 2 +- src/util/virjson.c | 58 +++--- src/util/virjson.h | 54 ++--- src/util/virlease.c | 304 ++++++++++++++++++++++++++++ src/util/virlease.h | 44 ++++ tests/Makefile.am | 20 +- tests/nssdata/virbr0.status | 20 ++ tests/nssmock.c | 140 +++++++++++++ tests/nsstest.c | 188 +++++++++++++++++ tools/Makefile.am | 44 ++++ tools/nss/libvirt_nss.c | 476 ++++++++++++++++++++++++++++++++++++++++++++ tools/nss/libvirt_nss.h | 52 +++++ tools/nss/libvirt_nss.syms | 12 ++ 22 files changed, 1527 insertions(+), 329 deletions(-) create mode 100644 m4/virt-nss.m4 create mode 100644 src/util/virlease.c create mode 100644 src/util/virlease.h create mode 100644 tests/nssdata/virbr0.status create mode 100644 tests/nssmock.c create mode 100644 tests/nsstest.c create mode 100644 tools/nss/libvirt_nss.c create mode 100644 tools/nss/libvirt_nss.h create mode 100644 tools/nss/libvirt_nss.syms -- 2.4.10

1 7

[libvirt] [PATCH v2 0/2] qemu: add spice opengl support
by Marc-André Lureau 01 Mar '16

01 Mar '16

Hi, The following patches allow to enable OpenGl support with spice/qemu server. Qemu should support this option starting from 2.6 (patches still under review). v1->v2: - move gl attribute as a sub-element - update documentation - comment TristateSwitch vs TristateBool usage - fix caps test location - fix syntax-check Marc-André Lureau (2): util: TristateBool and TristateSwitch are interchangeable qemu: add spice opengl support docs/formatdomain.html.in | 8 ++++ docs/schemas/domaincommon.rng | 8 ++++ src/conf/domain_conf.c | 26 ++++++++++++- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +++++++ src/util/virutil.h | 7 +++- tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 4 ++ .../qemuxml2argv-video-virtio-gpu-spice-gl.args | 24 ++++++++++++ .../qemuxml2argv-video-virtio-gpu-spice-gl.xml | 38 ++++++++++++++++++ tests/qemuxml2argvtest.c | 6 +++ .../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml | 45 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 15 files changed, 183 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-virtio-gpu-spice-gl.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-virtio-gpu-spice-gl.xml -- 2.5.0

6 12

[libvirt] Release of libvirt-1.3.2
by Daniel Veillard 01 Mar '16

01 Mar '16

So as planned I pushed the release earlier today, it is tagged in git and signed tarball and rpms are at the usual place: ftp://libvirt.org/libvirt/ I also built a libvirt-python 1.3.2 release which can be found at ftp://libvirt.org/libvirt/python This is a relatively big release with around 375 commits done in the last month and a half. There are user visible improvement listed as features and a lot more improvements and refactoring under the hood. Of course this also carries a large set of bug fixes, including serious ones but none labelled as security, upgrade is still recommended ! Features: - Various improvements for the Xen libxl driver (Joao Martins and Jim Fehlig) - virt-admin improvement (Erik Skultety) - Various improvements for the RDB volumes (Wido den Hollander) Documentation: - docs: mention ZFS on Linux support (Roman Bogorodskiy) - docs: formatdomain: Document "spice" as a valid value for <graphics type=..> (Richard W.M. Jones) - docs: Try harder to uninstall (Michal Privoznik) - tests: Fix typo oaque -> opaque (Andrea Bolognani) - docs: List possible GIC versions (Andrea Bolognani) - Spell VMware with a lowercase w (Ján Tomko) - leaseshelper: move comment about adding IPv6 leases (Ján Tomko) Portability: - build: accomodate selinux 2.5 header API change (Eric Blake) - rbd: fix 32-bit build (Eric Blake) - util: Use virBitmapIsBitSet in freebsd impl of virProcessSetAffinity (Peter Krempa) - domsuspend: Fix warning on mingw build (Andrea Bolognani) - virportallocatortest: Run on linux only (Michal Privoznik) - Revert "tests: Don't link mock libraries against libvirt and gnulib" (Andrea Bolognani) - tests: Don't link mock libraries against libvirt and gnulib (Andrea Bolognani) - virDomainFormatSchedDef: Initialize @priority (Michal Privoznik) - Fix '-pie' build with clang (Martin Kletzander) - include: Handle case when builddir == srcdir (Michal Privoznik) - tests: avoid realpath in test-lib.sh (Eric Blake) - includes: Install libvirt-common.h (Michal Privoznik) - docs: fix generation of docs from VPATH build (Daniel P. Berrange) - Fix make check with gcc version 5 (Martin Kletzander) Bug Fixes: - storage: Fix error path in storagePoolDefineXML (John Ferlan) - storage: Fix error path in virStoragePoolObjLoad (John Ferlan) - qemu: error out on missing machine type in configs (Ján Tomko) - Revert "Error out on missing machine type in machine configs" (Ján Tomko) - libxl: unref objects in error paths (Jim Fehlig) - storage: No need to check ret after VIR_APPEND_ELEMENT (John Ferlan) - zfs: Resolve RESOURCE_LEAK (John Ferlan) - netdev: Use virNetDevIsVirtualFunction() properly (Andrea Bolognani) - Fix bug of attaching redirdev device (Osier Yang) - libxl: small fix in parsing network (Chunyan Liu) - qemuBuildCommandLine: Change the condition for -nographics (Michal Privoznik) - xen: Check return value of virStringReplace (Michal Privoznik) - vbox: Avoid signed and unsigned comparison (Michal Privoznik) - qemu_process: mark auto-generated spice ports as reserved (Pavel Hrdina) - adminDaemonListServers: Don't leak @srv_names array (Michal Privoznik) - Check for active domain in virDomainObjWait (Jiri Denemark) - qemu: Avoid calling qemuProcessStop without a job (Jiri Denemark) - qemu: Process monitor EOF in a job (Jiri Denemark) - qemu: qemuDomainGetStatsVcpu: Fix output for possible sparse vCPU settings (Peter Krempa) - qemu: vcpupin: Don't overwrite errors from functions setting pinning (Peter Krempa) - admin: Fix memory leak in remoteAdminConnectClose (Erik Skultety) - esx: Avoid using vSphere SessionIsActive function (Matthias Bolte) - Error out on missing machine type in machine configs (Ján Tomko) - qemu: cgroup: fix cgroup permission logic (Bjoern Walk) - virsh: Remove <backingStore> when changing cdrom media source (Peter Krempa) - vircgroup: Update virCgroupDenyDevicePath stub (Michal Privoznik) - qemu: cgroup: Avoid reporting errors from inaccessible NFS volumes (Peter Krempa) - qemu: fix hot unplug of PCI devices with VFIO (Ludovic Beliveau) - vz: fix race condition when adding domain to domains list (Mikhail Feoktistov) - vz: fix notification subscription (Mikhail Feoktistov) - conf: snapshot: Avoid autogenerating duplicate snapshot names (Peter Krempa) - dbus: Don't unref NULL messages (Michal Privoznik) - qemu: Connect to guest agent iff needed (Michal Privoznik) - xenconfig: Properly check retval of virDomainGraphicsListenSetAddress (Michal Privoznik) - leaseshelper: swap two parameters of virLeaseNew (Ján Tomko) - vboxDumpDisplay: check return of virDomainGraphicsListenSetAddress (Ján Tomko) - Check return value of vboxDumpVideo (Ján Tomko) - qemu: vcpu: Reuse qemuProcessSetupVcpu in vcpu hotplug (Peter Krempa) - remote: enforce VIR_TYPED_PARAM_STRING_OKAY flag on client side serialization (Joao Martins) - vircgroup: Update virCgroupGetPercpuStats stump (Michal Privoznik) - conf: Don't store vcpusched orthogonally to other vcpu info (Peter Krempa) - qemu: snapshot: Avoid infinite loop if vCPUs can't be resumed (Peter Krempa) - qemu: snapshot: Don't overwrite existing errors when thawing filesystems (Peter Krempa) - util: Fix virCgroupNewMachine ATTRIBUTE_NONNULL args (John Ferlan) - bhyve: Fix the build (Michal Privoznik) - virSystemdGetMachineNameByPID: Initialize @reply (Michal Privoznik) - virnetdevbandwidth: Compute quantum value (Michal Privoznik) - systemd: Modernize machine naming (Martin Kletzander) - bhyve: fix build (Roman Bogorodskiy) - Fix build after recent patches (Peter Krempa) - qemu: qemuDomainRename and virDomainObjListNumOfDomains ABBA deadlock fix (Nikolay Shirokovskiy) - Revert "systemd: Escape only needed characters for machined" (Martin Kletzander) - qemu: Don't crash when create fails early (Martin Kletzander) - virsh: ensure SIGINT action is reset on all errors (Michael Chapman) - conf: disallow empty cpusets for vcpu pinning when parsing XML (Peter Krempa) - Fix libvirtd free() segfault when migrating guest with deleted open vswitch port (Jason J. Herne) - vz: Fix invalid iteration of def->cputune.vcpupin (Peter Krempa) - qemu: process: Disallow VMs with 0 vcpus (Peter Krempa) - virt-host-validate: Fix error level for user namespace check (Michal Privoznik) - virsh: Correctly detect inserted media in change-media command (Michal Privoznik) - vmx: Adapt to emptyBackingString for cdrom-image (Michal Privoznik) - qemu: snapshot: Correctly report qemu error on 'savevm' (Peter Krempa) - lxc: fuse: Stub out Slab bits in /proc/meminfo (Cole Robinson) - lxc: fuse: Fill in MemAvailable for /proc/meminfo (Cole Robinson) - qemuDomainReboot: use fakeReboot=true only for acpi mode (Dmitry Andreev) - build: predictably generate systemtap tapsets (bz 1173641) (Cole Robinson) - leaseshelper: fix crash when no mac is specified (Ján Tomko) - virLogManagerDomainReadLogFile: Don't do dummy allocs (Michal Privoznik) - qemuProcessReadLog: Fix memmove arguments (Michal Privoznik) - rbd: Set r variable so it can be returned should an error occur (Wido den Hollander) Improvements: - virsh: reject migration with both --live and --offline (Nitesh Konkar) - tests: add parseFlags to qemuxml2argvtest (Ján Tomko) - tests: add a test for persistent LXC XML parsing (Ján Tomko) - testCompareDomXML2XMLFiles: add parseFlags parameter (Ján Tomko) - openvz: Use virStringSplitCount instead of strtok_r (John Ferlan) - hostdev: Remove temporary variable when checking for VF (Andrea Bolognani) - util: Avoid calling closedir(NULL) (Jiri Denemark) - vircgroupmock: Mock access("/sys/devices/system/cpu/present") (Michal Privoznik) - libxl: implement virDomainInterfaceStats (Joao Martins) - libxl: fix bogus indentation from commit fb2bd208 (Jim Fehlig) - libxl: add support for rbd qdisk (Jim Fehlig) - xenconfig: support xl<->xml conversion of rbd disk devices (Jim Fehlig) - xenconfig: produce key=value disk config syntax in xl formatter (Jim Fehlig) - xenconfig: replace text 'xm' with 'xl' in xlconfigtest (Jim Fehlig) - hostdev: Minor style adjustments (Andrea Bolognani) - cmdSaveImageEdit: Prefer VSH_EXCLUSIVE_OPTIONS over by hand check (Michal Privoznik) - cmdNetworkUpdate: Prefer VSH_EXCLUSIVE_OPTIONS over if-else tree (Michal Privoznik) - util: TristateBool and TristateSwitch are interchangeable (Marc-André Lureau) - Miscellaneous for-loop syntax clean-ups (Martin Kletzander) - qemu: add support for LSI SAS1068 (aka MPT Fusion) SCSI controller (Paolo Bonzini) - virDomainDefFormatInternal: Drop useless check (Michal Privoznik) - gic: Introduce VIR_GIC_VERSION_DEFAULT alias (Andrea Bolognani) - security_selinux: Fix typo in error message (Laurent Bigonville) - qemu: iothreadpin: Always set affinity when pinning iothread (Peter Krempa) - qemu: emulatorpin: Always set affinity when pinning emulator thread (Peter Krempa) - qemu: parse: drop redundant AddImplicitControllers (Cole Robinson) - qemu: parse: rename qemuCaps->caps (Cole Robinson) - domain: add implicit controllers from post parse (Cole Robinson) - qemu: Simplify error handling in qemuProcessReconnect (Jiri Denemark) - qemu: Start an async job for processGuestPanicEvent (Jiri Denemark) - qemu: Start job in qemuDomainDestroyFlags early (Jiri Denemark) - qemu: Introduce qemuProcessBeginStopJob (Jiri Denemark) - qemu: Pass async job to qemuProcessInit (Jiri Denemark) - qemu: End nested jobs properly (Jiri Denemark) - qemu: Export qemuDomainObjBeginNestedJob (Jiri Denemark) - virsh: cpupin: Extract getter code into a separate function (Peter Krempa) - qemu: vcpupin: Always set affinity even when cgroups are supported (Peter Krempa) - virsh: cmdVcpuPin: Simplify handling of API flags (Peter Krempa) - test: qemuxml2argv: Drop QEMU_CAPS_DEVICE uses (Andrea Bolognani) - vsh: use virBufferTrim in vshOutputLogFile (Ján Tomko) - qemu: Introduce qemuBuildMonitorCommandLine (John Ferlan) - qemu: Introduce qemuBuildSgaCommandLine (John Ferlan) - qemu: Introduce qemuBuildSmbiosCommandLine (John Ferlan) - qemu: Introduce qemuBuildNumaCommandLine (John Ferlan) - qemu: Introduce qemuBuildIOThreadCommandLine (John Ferlan) - qemu: Rename qemuBuildSmpArgStr to qemuBuildSmpCommandLine (John Ferlan) - qemu: Introduce qemuBuildMemCommandLine (John Ferlan) - qemu: Rename qemuBuildCpuArgStr to qemuBuildCpuCommandLine (John Ferlan) - qemu: Rename qemuBuildMachineArgStr (John Ferlan) - qemu: Make basic upfront checks before create command (John Ferlan) - qemu: Remove local emulator (John Ferlan) - qemu: Kill VIR_WRAPPER_SHELL_PREFIX (Peter Krempa) - qemu: Move PORT definitions to qemu_conf.c (Cole Robinson) - tests: Remove unused virtTestClearLineRegex (Cole Robinson) - tests: lxcconf2xml: Drop XML blanking (Cole Robinson) - tests: qemuargv2xml: Drop memory XML blanking (Cole Robinson) - tests: qemuargv2xml: hardcode disk auth usage (Cole Robinson) - tests: qemuargv2xml: Remove UUID randomness (Cole Robinson) - tests: qemuargv2xml: Remove unneeded XML blanking (Cole Robinson) - qemu: Remove unnecessary calculations in qemuDomainSaveMemory (Peter Krempa) - qemu: monitor: Remove unused qemuMonitorMigrateToFile (Peter Krempa) - Revert "storageVolCreateXMLFrom: Check if backend knows how to createVol" (Ján Tomko) - syms: add forgotten virAdmConnectClass symbol (Erik Skultety) - virt-admin: Introduce cmdSrvList (Erik Skultety) - admin: Introduce adminDaemonConnectListServers API (Erik Skultety) - admin: Introduce virAdmServer structure (Erik Skultety) - admin: Move admin_server.{h,c} to admin.{h,c} (Erik Skultety) - virnetdaemon: Store servers in a hash table (Erik Skultety) - util: Refactor virHashForEach so it returns as soon as an iterator fails (Erik Skultety) - util: Add a return value to void hash iterators (Erik Skultety) - qemu: cgroup: Setup cgroups for bios/firmware images (Peter Krempa) - qemu: cgroup: Extract guts of qemuSetupImageCgroupInternal (Peter Krempa) - qemu: cgroup: Split up qemuSetImageCgroupInternal (Peter Krempa) - qemu: cgroup: Switch to qemu(Setup|Teardown)ImageCgroup (Peter Krempa) - util: cgroup: Allow ignoring EACCES in virCgroup(Allow|Deny)DevicePath (Peter Krempa) - util: cgroup: Drop virCgroup(Allow|Deny)DeviceMajor (Peter Krempa) - util: cgroup: Instrument virCgroupDenyDevice to handle -1 device number as * (Peter Krempa) - qemu: migration: Refactor code now that we assume support for fd migration (Peter Krempa) - qemu: cgroup: Remove abandoned function qemuAddToCgroup (Peter Krempa) - conf: Use a temporary int variable to store GIC version (Andrea Bolognani) - qemu: Move qemuDomainNetVLAN (John Ferlan) - qemu: Move qemuAssign*Alias* API's into their own module (John Ferlan) - qemu: Move qemuNetworkPrepareDevices (John Ferlan) - qemu: Move and rename qemuOpenVhostNet (John Ferlan) - qemu: Move qemuDomain*Address* functions (John Ferlan) - qemu: Move qemuDomainSupports* functions (John Ferlan) - qemu: Move qemuNetworkIfaceConnect to qemu_interface.c and rename (John Ferlan) - qemu: Move qemuPhysIfaceConnect to qemu_interface.c and rename (John Ferlan) - qemu: Move qemuVirCommandGetDevSet (John Ferlan) - qemu: Move qemuBuildTPMDevStr (John Ferlan) - qemu: Move qemuVirCommandGetFDSet (John Ferlan) - qemu: Move qemuBuildTPMBackendStr (John Ferlan) - tests: Add more GIC test cases (Andrea Bolognani) - tests: Reorganize and simplify GIC test cases (Andrea Bolognani) - qemu: Always enable GIC on ARM virt machines (Andrea Bolognani) - qemu: Default to GIC v2 (Andrea Bolognani) - conf: Use virGICVersion enumeration in virDomainDef (Andrea Bolognani) - schema: List allowed GIC versions (Andrea Bolognani) - gic: Introduce virGICVersion enumeration (Andrea Bolognani) - vsh: Replace vshPrint macro with function (Peter Krempa) - vsh: Simplify bailing out on OOM conditions (Peter Krempa) - util: clean up and expand 802.1QbX negotiation logging (Laine Stump) - network: consolidated info log for all network allocate/free operations (Laine Stump) - network: consolidate connection count updates for device pool (Laine Stump) - rbd: Use RBD fast-diff for querying actual volume allocation (Wido den Hollander) - rbd: rbd_diff_iterate2() is available in librbd since 266 (Wido den Hollander) - rbd: Add volStorageBackendRBDGetFeatures() for internal calls (Wido den Hollander) - storageVolCreateXMLFrom: Check if backend knows how to createVol (Michal Privoznik) - storageVolCreateXML: Swap order of two operations (Michal Privoznik) - virsh: Teach vol-create-as to --print-xml (Michal Privoznik) - cmdVolCreateAs: Rework to follow usual func pattern (Michal Privoznik) - vz: remove unused struct field (Mikhail Feoktistov) - vz: make output arguments in prlsdkGetDomainIds as optional (Mikhail Feoktistov) - Change maintainers list (Maxim Nestratov) - tests: Rename virmockdbus -> virdbusmock for consistency (Andrea Bolognani) - tests: Don't use "lib" prefix for mock libraries (Andrea Bolognani) - tests: Allow use of close() in mock libraries (Andrea Bolognani) - tests: Split off the mock part of the port allocator test (Andrea Bolognani) - conf: snapshot: Refactor virDomainSnapshotDefAssignExternalNames (Peter Krempa) - conf: snapshot: Extract code to generate default external file names (Peter Krempa) - conf: snapshot: Rename disksorter to virDomainSnapshotCompareDiskIndex (Peter Krempa) - tests: Link mock libraries against gnulib and gnulib only (Andrea Bolognani) - tests: Use plain close() in mock code (Andrea Bolognani) - virhook: do not save the return value of virBuildPath (Ján Tomko) - Clean up usage of 'ret' variable (Ján Tomko) - Prohibit verbose strcat (Ján Tomko) - vbox: remove more extra spaces (Ján Tomko) - vbox: remove extra spaces from function headers (Ján Tomko) - vbox: remove extra spaces from assignments (Ján Tomko) - vbox: remove extra spaces from variable initializations (Ján Tomko) - vbox: remove extra spaces from macro definitions (Ján Tomko) - qemu: Split the command parsing routines into own module (John Ferlan) - qemu: Check return status for virDomainGraphicsListenSetAddress (John Ferlan) - qemu: Introduce qemuParseCommandLineVnc (John Ferlan) - libxl: keepalive messages support (Joao Martins) - libxl: add p2p migration (Joao Martins) - tests: qemu: More aarch64 virtio and pci tests (Cole Robinson) - tests: qemuxml2xml: assign device addresses (Cole Robinson) - tests: utils: Add PreFormat callback for CompareXML2XML helper (Cole Robinson) - virStringListLength: Ensure const correctness (Michal Privoznik) - tests: qemuxml2xml: specify qemuCaps in test cases (Cole Robinson) - tests: Unconditionally enable QEMU_CAPS_DEVICE (Cole Robinson) - tests: qemuxml2argv: remove some QEMU_CAPS_DEVICE problem cases (Cole Robinson) - util: Get rid of virStringListLen() (Martin Kletzander) - tests: qemuxml2xml: Always use different output file (Cole Robinson) - vboxDumpDisplay: realign variable initializations (Ján Tomko) - vboxDumpDisplay: remove suspicious strlen (Ján Tomko) - vboxDumpDisplay: reuse the keyUtf16 variable (Ján Tomko) - vboxDumpDisplay: use VIR_APPEND_ELEMENT (Ján Tomko) - vboxDumpDisplay: clean up VIR_STRDUP usage (Ján Tomko) - vboxDumpDisplay: fill out the graphics structure earlier (Ján Tomko) - vboxDumpDisplay: allocate the graphics structure upfront (Ján Tomko) - vboxDumpDisplay: split out def->graphics allocation (Ján Tomko) - vboxDumpDisplay: remove extra virReportOOMError (Ján Tomko) - vboxDumpDisplay: add addDesktop bool (Ján Tomko) - vboxDumpDisplay: more indentation reducing (Ján Tomko) - vboxDumpDisplay: reduce indentation level (Ján Tomko) - leaseshelper: split out virLeaseNew (Ján Tomko) - qemu: iothread: Reuse qemuProcessSetupIOThread in iothread hotplug (Peter Krempa) - qemu: iothread: Aggregate code to set IOThread tuning (Peter Krempa) - qemu: vcpu: Aggregate code to set vCPU tuning (Peter Krempa) - conf: Fix how iothread scheduler info is stored (Peter Krempa) - conf: Extract code that formats <cputune> (Peter Krempa) - conf: remove unused cpu pinning helpers and data structures (Peter Krempa) - conf: Store cpu pinning data in def->vcpus (Peter Krempa) - conf: Don't copy def->cpumask into cpu pinning info (Peter Krempa) - qemu: Reuse qemuDomainDetectVcpuPids in cpu hot(un)plug (Peter Krempa) - qemu: Differentiate error codes when VM exits in qemuDomainDetectVcpuPids (Peter Krempa) - cgroup: Prepare for sparse vCPU topologies in virCgroupGetPercpuStats (Peter Krempa) - conf: Move and optimize disk target duplicity checking (Peter Krempa) - tests: Integrate startup checks to qemuxml2argvtest (Peter Krempa) - qemu: process: Extract pre-start checks into a function (Peter Krempa) - qemu: process: Reorder operations on early VM startup (Peter Krempa) - qemu: hotplug: Check duplicate disk serial/wwn on hotplug too (Peter Krempa) - conf: Extract code that checks disk serial/wwn conflict (Peter Krempa) - qemu: hotplug: Extract common code to qemuDomainAttachDeviceDiskLive (Peter Krempa) - qemu: hotplug: Use more common 'cleanup' label in qemuDomainAttachDeviceDiskLive (Peter Krempa) - qemu: hotplug: Break up if/else statement into switch (Peter Krempa) - qemu: hotplug: Remove unnecessary variable (Peter Krempa) - qemu: hotplug: Use typecasted switch (Peter Krempa) - nodedev: stub nodeDeviceSysfsGetPCIRelatedDevCaps (Roman Bogorodskiy) - bhyve: fix preprocessor indentation (Roman Bogorodskiy) - tests: qemuargv2xml: separate from qemuxml2argv data (Cole Robinson) - tests: Run test-wrap-argv with REGENERATE_OUTPUT (Cole Robinson) - rbd: Use %zu for uint64_t instead of casting to unsigned long long (Wido den Hollander) - rbd: Code styling cleanup (Wido den Hollander) - conf: Extract code for parsing thread resource scheduler info (Peter Krempa) - conf: Add helper to return a bitmap of active iothread ids (Peter Krempa) - util: bitmap: Introduce bitmap subtraction (Peter Krempa) - conf: add caps to virDomainSnapshotDefFormat (Joao Martins) - conf: add caps to virDomainObjFormat/SaveStatus (Daniel P. Berrange) - qemu migration: factor out setting migration option (Nikolay Shirokovskiy) - logical: Clarify pieces of lvs regex (John Ferlan) - libxl: set net device prefix (Joao Martins) - conf: add caps to virDomainSaveConfig (Joao Martins) - conf: add caps to virDomainDefFormat* (Joao Martins) - conf: add prefix in virDomainNetDefParseXML (Joao Martins) - conf: add net device prefix to capabilities (Joao Martins) - virsh: display if ZFS storage backend is enabled (Roman Bogorodskiy) - configure: zfs: enable on Linux (Roman Bogorodskiy) - storage: zfs: flexible use of 'volmode' option (Roman Bogorodskiy) - util: Export remoteSerializeTypedParameters internally via util (Erik Skultety) - util: Export remoteFreeTypedParameters internally via util (Erik Skultety) - util: Export remoteDeserializeTypedParameters internally via util (Erik Skultety) - util: Introduce virTypedParameterRemote datatype (Erik Skultety) - systemd: Add virSystemdGetMachineNameByPID (Martin Kletzander) - Simplify virDomainParseMemory (Ján Tomko) - conf: Split out logic to determine whether cpupin was provided (Peter Krempa) - qemu: domain: Prepare qemuDomainDetectVcpuPids for reuse (Peter Krempa) - qemu: Move and rename qemuProcessDetectVcpuPIDs to qemuDomainDetectVcpuPids (Peter Krempa) - qemu: cpu hotplug: Set vcpu state directly in the new structure (Peter Krempa) - conf: Add helper to retrieve bitmap of active vcpus for a definition (Peter Krempa) - cgroup: Clean up virCgroupGetPercpuStats (Peter Krempa) - cfg.mk: Adjust sc_prohibit_int_ijk to support 'exempt from syntax-check' (Erik Skultety) - qemuDomainResume: allow to resume domain with guest panicked (Dmitry Andreev) - qemu: return -1 on error paths in qemuDomainSaveImageStartVM (Nikolay Shirokovskiy) - logical: Clean up allocation when building regex on the fly (John Ferlan) - logical: Use 'stripes' value for mirror/raid segtype (John Ferlan) - logical: Use VIR_APPEND_ELEMENT instead of VIR_REALLOC_N (John Ferlan) - virsh: improve waiting for block job readiness (Michael Chapman) - virsh: be consistent with style of loop exit (Michael Chapman) - virsh: avoid unnecessary progress updates (Michael Chapman) - qemu: Mark some functions as static (Cole Robinson) - fdstream: Realign (Michal Privoznik) - qemu: Align dump options for watchdog and on_crash events (Boris Fiuczynski) - logical: Create helper virStorageBackendLogicalParseVolExtents (John Ferlan) - rbd: Open in Read-Only mode when refreshing a volume (Wido den Hollander) - rbd: Implement buildVolFrom using RBD cloning (Wido den Hollander) - rbd: Add support for wiping RBD volumes using TRIM. (Wido den Hollander) - storage: Add TRIM algorithm to storage volume API (Wido den Hollander) - rbd: Add support for wiping RBD volumes (Wido den Hollander) - storage: Adjust fix virStorageBackendVolWipeLocal switch (Wido den Hollander) - logical: Fix comment examples for virStorageBackendLogicalFindLVs (John Ferlan) - pci: Use bool return type for some virPCIDeviceGet*() functions (Andrea Bolognani) - gendispatch: Don't output spaces on empty line (Michal Privoznik) - pci: Add debug messages when unbinding from stub driver (Andrea Bolognani) - pci: Phase out virPCIDeviceReattachInit() (Andrea Bolognani) - qemu: don't iterate vcpus using priv->nvcpupids in qemuProcessSetSchedParams (Peter Krempa) - conf: disallow empty cpuset for emulatorpin (Peter Krempa) - qemu: Don't use priv->ncpus to iterate cgroup setting (Peter Krempa) - virnetdevopenvswitch: Don't call strlen() twice on the same string (Andrea Bolognani) - virnetdevmacvlan: Provide stubs for build without macvtap (Michal Privoznik) - util: keep/use a bitmap of in-use macvtap devices (Laine Stump) - util: increase libnl buffer size (Leno Hou) - device: cleanup input device code (Pavel Hrdina) - tests: add some missing tests to qemuxml2xmltest (Pavel Hrdina) - tests: use virtTestDifferenceFull in tests where we have output file (Pavel Hrdina) - vircgroup: Finish renaming of virCgroupIsolateMount (Michal Privoznik) - lxc: don't try to hide parent cgroups inside container (Daniel P. Berrange) - qemu: add reporting of vCPU wait time (Daniel P. Berrange) - virsh: fix cpu-stats command output format issue (Luyao Huang) - util: buffer: Sanitize comment for virBufferAddBuffer (Peter Krempa) - test: Touch up error message when attempting to pin invalid vCPU (Peter Krempa) - tests: qemuxml2xml: Order pinning information numerically (Peter Krempa) - virsh: cpu-stats: Remove unneeded flags (Peter Krempa) - virsh: cpu-stats: Extract common printing code into a function (Peter Krempa) - (qemu|lxc)DomainGetCPUStats: Clean up (Peter Krempa) - qemu: process: refactor and rename qemuValidateCpuMax to qemuValidateCpuCount (Peter Krempa) - virt-host-validate: Check those CGroups that we actually use (Michal Privoznik) - qemu: monitor: Refactor error handling for 'savevm' (Peter Krempa) - bhyve: bhyveload: respect boot dev and boot order (Roman Bogorodskiy) - conf: expose virDomainBootType(From|To)String (Roman Bogorodskiy) - util: reset MAC address of macvtap passthrough physdev after disassociate (Laine Stump) - lxc: fuse: Fix /proc/meminfo size calculation (Cole Robinson) - lxc: fuse: Unindent meminfo logic (Cole Robinson) - libxl: Support cmdline= in xl config files (Ian Campbell) - libxl: dispose libxl_dominfo after libxl_domain_info() (Joao Martins) - Xen: add XENXL to virErrorDomain enum (Jim Fehlig) - Xen: VIR_FROM_THIS cleanup (Jim Fehlig) - qemu: Add support for migration iteration event (Jiri Denemark) - Introduce migration iteration event (Jiri Denemark) - virsh: Don't fetch status for all domains in cmdList (Michal Privoznik) - docs: fix syntax-check long line error (Cole Robinson) - leaseshelper: reduce indentation level in virLeaseReadCustomLeaseFile (Ján Tomko) - leaseshelper: remove useless comparison (Ján Tomko) - leaseshelper: split out virLeasePrintLeases (Ján Tomko) - leaseshelper: split out custom leases file read (Ján Tomko) - leaseshelper: store server_duid as an allocated string (Ján Tomko) - storage: Add new flag for libvirt_parthelper (John Ferlan) - conf: Add storage pool device attribute part_separator (John Ferlan) - qemuTestDriverInit: fill driver with zeroes (Michal Privoznik) - Post-release version bump to 1.3.2 (Michal Privoznik) - NEWS: Don't prefix version numbers with 'v' (Andrea Bolognani) - NEWS: Fix whitespace issues (Andrea Bolognani) - NEWS: Move 2015 entries to a separate file (Andrea Bolognani) So thanks everybody for your contributions for this release, be it with patches, ideas, reviews, docs, etc ... Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version
by Peter Xu 01 Mar '16

01 Mar '16

For ARM platform, we still do not have any interface to query whether current QEMU/host support specific GIC version. This patchset is trying to add one QMP interface for that. By querying the GIC capability using the new interface, one should know exactly what GIC version(s) the platform will support. The capability bits will be decided by both QEMU and host kernel. The current patchset only provides interface for review. Its handler is a fake one which returns empty always. The command interface I am planning to add is something like this: -> { "execute": "query-gic-capability" } <- { "return": [ "gicv2", "gicv2-kvm", "gicv3-kvm" ] } Currently, all the possible supported GIC versions are: - gicv2: GIC version 2 without kernel IRQ chip - gicv2-kvm: GIC version 2 with kernel IRQ chip - gicv3: GIC version 3 without kernel IRQ chip (not supported) - gicv3-kvm: GIC version 3 with kernel IRQ chip Since "gicv3" is still not supported (to use GICv3, kernel irqchip support is required for now, which corresponds to "gicv3-kvm"), currently the maximum superset of the result should be: ["gicv2", "gicv2-kvm", "gicv3-kvm"] Please help review whether the interface suits our need, also please point out any error I have made. One question: how should I make this command "ARM only"? I see that in qmp-commands.hx, I can use something like "#if defined TARGET_ARM" to block out ARM specified commands, however how should I do the similiar thing in qapi-schema.json? Thanks! Peter Peter Xu (2): arm: gic: add GICType arm: gic: add "query-gic-capability" interface qapi-schema.json | 28 ++++++++++++++++++++++++++++ qmp-commands.hx | 25 +++++++++++++++++++++++++ qmp.c | 5 +++++ scripts/qapi.py | 1 + 4 files changed, 59 insertions(+) -- 2.4.3

10 35

[libvirt] setlocale problems / "initialization failed" in Rawhide
by Richard W.M. Jones 01 Mar '16

01 Mar '16

https://bugzilla.redhat.com/show_bug.cgi?id=1312688 When you upgrade from F23 to current Rawhide, you don't get any "language pack" installed. It turns out this breaks many things including libvirtd which no longer starts up: $ ./daemon/libvirtd --help /home/rjones/d/libvirt/daemon/.libs/lt-libvirtd: initialization failed Simply installing glibc-langpack-en is sufficient to fix this, but I was wondering if we should try to make libvirt work anyway. The failure comes from setlocale (LC_ALL, "") returning NULL. The attached test program prints: $ ./test setlocale failed, errno=No such file or directory Also attached is the strace output so you can see what files it is looking for. Seems like solutions to this include: - Make libvirt in Fedora depend on glibc-langpack-en. - Ignore the return value from setlocale. It seems unlikely that we really care if setlocale fails. I'm not even sure what it does. Note that virsh already ignores setlocale: if (!setlocale(LC_ALL, "")) { perror("setlocale"); /* failure to setup locale is not fatal */ } Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top

4 5

[libvirt] [PATCH libvirt-glib 0/5] Add virgl config support
by Marc-André Lureau 29 Feb '16

29 Feb '16

A few fixes followed by spice gl and virtio-gpu config patches. (libvirt "spice gl" support is pending merge after the release) thanks Marc-André Lureau (5): build-sys: fix gir introspection warnings tests: fix potential crash config: add spice gl child config: add virtio video model config: add accel3d setter examples/config-demo.py | 4 +++- libvirt-gconfig/Makefile.am | 1 + .../libvirt-gconfig-domain-graphics-spice.c | 9 +++++++++ .../libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig-domain-video.c | 18 ++++++++++++++++++ libvirt-gconfig/libvirt-gconfig-domain-video.h | 5 ++++- libvirt-gconfig/libvirt-gconfig.sym | 5 +++++ libvirt-glib/Makefile.am | 1 + libvirt-gobject/Makefile.am | 1 + libvirt-gobject/libvirt-gobject-connection.c | 2 +- libvirt-gobject/libvirt-gobject-domain.c | 2 +- libvirt-gobject/libvirt-gobject-network.c | 1 - libvirt-gobject/libvirt-gobject-stream.c | 3 +-- tests/test-events.c | 8 +++++++- 14 files changed, 55 insertions(+), 8 deletions(-) -- 2.5.0

3 11

[libvirt] ANNOUNCE: Oz 0.15.0 release
by Chris Lalancette 29 Feb '16

29 Feb '16

All, I'm pleased to announce release 0.15.0 of Oz. Oz is a program for doing automated installation of guest operating systems with limited input from the user. Release 0.15.0 is a bugfix and feature release for Oz. Some of the highlights between Oz 0.14.0 and 0.15.0 are: * Make sure openssh-clients is included in CentOS builds * Add support for Fedora-23 * Add customization support for Debian * Use the ssh -i option to avoid "Too many authentication failures" with many ssh keys * Support "rawhide" as a Fedora version * Add in Ubuntu 15.10 support * Add in OpenSUSE 13.2 support * Improve Oz's free port selection A tarball and zipfile of this release is available on the Github releases page: https://github.com/clalancette/oz/releases . Packages for Fedora-22, Fedora-23, and EPEL-7 have been built in Koji and will eventually make their way to stable. Instructions on how to get and use Oz are available at http://github.com/clalancette/oz/wiki . If you have questions or comments about Oz, please feel free to contact me at clalancette at gmail.com, or open up an issue on the github page: http://github.com/clalancette/oz/issues . Thanks to everyone who contributed to this release through bug reports, patches, and suggestions for improvement. Chris Lalancette

1 0