- Devel - libvirt List Archives

[libvirt] [PATCH] conf: nodedev: Remove inverted match logic
by Andrea Bolognani 16 Mar '16

16 Mar '16

Commit c1276177f832 simplified the match logic; this commit gets rid of the inverted logic to make the code even more straightforward. --- src/conf/node_device_conf.c | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 0c9c348..b9b9dfa 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1806,22 +1806,22 @@ virNodeDeviceMatch(virNodeDeviceObjPtr devobj, { /* filter by cap type */ if (flags & VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP) { - if (!(MATCH(SYSTEM) || - MATCH(PCI_DEV) || - MATCH(USB_DEV) || - MATCH(USB_INTERFACE) || - MATCH(NET) || - MATCH(SCSI_HOST) || - MATCH(SCSI_TARGET) || - MATCH(SCSI) || - MATCH(STORAGE) || - MATCH(FC_HOST) || - MATCH(VPORTS) || - MATCH(SCSI_GENERIC))) - return false; + if (MATCH(SYSTEM) || + MATCH(PCI_DEV) || + MATCH(USB_DEV) || + MATCH(USB_INTERFACE) || + MATCH(NET) || + MATCH(SCSI_HOST) || + MATCH(SCSI_TARGET) || + MATCH(SCSI) || + MATCH(STORAGE) || + MATCH(FC_HOST) || + MATCH(VPORTS) || + MATCH(SCSI_GENERIC)) + return true; } - return true; + return false; } #undef MATCH -- 2.5.0

2 2

[libvirt] [PATCH] qemu migration: assign addresses in xml passed as parameter
by Nikolay Shirokovskiy 16 Mar '16

16 Mar '16

Usecase: 1. define domain with xml A where addresses are not set 2. migrate with '--xml A' You get ABI incompatibility because we comprare xmls with addresses set and not. This patch assign addresses in parameter xml so the comprasion is fair. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/qemu/qemu_migration.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 1443d96..7cceaa1 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2992,6 +2992,7 @@ qemuMigrationBeginPhase(virQEMUDriverPtr driver, virDomainDefPtr def = NULL; qemuDomainObjPrivatePtr priv = vm->privateData; virCapsPtr caps = NULL; + virQEMUCapsPtr qemuCaps = NULL; unsigned int cookieFlags = QEMU_MIGRATION_COOKIE_LOCKSTATE; VIR_DEBUG("driver=%p, vm=%p, xmlin=%s, dname=%s," @@ -3105,6 +3106,13 @@ qemuMigrationBeginPhase(virQEMUDriverPtr driver, VIR_DOMAIN_DEF_PARSE_INACTIVE))) goto cleanup; + if (!(qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, + def->emulator))) + goto cleanup; + + if (qemuDomainAssignAddresses(def, qemuCaps, NULL) < 0) + goto cleanup; + if (!qemuDomainDefCheckABIStability(driver, vm->def, def)) goto cleanup; @@ -3117,6 +3125,7 @@ qemuMigrationBeginPhase(virQEMUDriverPtr driver, qemuMigrationCookieFree(mig); virObjectUnref(caps); virDomainDefFree(def); + virObjectUnref(qemuCaps); return rv; } -- 1.8.3.1

2 2

[libvirt] [PATCH] qemu: Don't access uninitialized memory
by Martin Kletzander 16 Mar '16

16 Mar '16

In qemuConnectDomainXMLToNative() we set up the monitor, but we never memset() it to zeros. Thanks to the introduction of the logfile parameter of chardevs (and the logfile member of the struct), we started checking whether that's non-NULL and that exposed this old error. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a0d6596aef7b..e868b9f899e7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -6950,7 +6950,7 @@ static char *qemuConnectDomainXMLToNative(virConnectPtr conn, { virQEMUDriverPtr driver = conn->privateData; virDomainDefPtr def = NULL; - virDomainChrSourceDef monConfig; + virDomainChrSourceDef monConfig = {0}; virQEMUCapsPtr qemuCaps = NULL; bool monitor_json = false; virCommandPtr cmd = NULL; -- 2.7.3

2 2

[libvirt] [PATCH 0/3] Cosmetic changes to SPICE QEMU commandline
by Christophe Fergeau 16 Mar '16

16 Mar '16

Hey, I've been trying out the recently adding virgl support, which does not need any TCP port/address to be set (it's directly opening a local unix fd). While looking at QEMU command line in configs such as <graphics type="spice" autoport="no"/>, I've noticed that the QEMU command line gets some 'useless' arguments such as -spice port=0 or -spice addr=127.0.0.1 (without a port defined). This series changes the spice command line generation so that we don't add these arguments when not needed. Christophe

2 6

[libvirt] [PATCH v5 0/2] notify about reverting to a snapshot
by Dmitry Andreev 16 Mar '16

16 Mar '16

The original idea of this patch-set was to notify API clients about changes in domain configuration on revert to a snapshot. But in the last review Cole noticed that updated configuration doesn't saved to a file and libvirtd reboot drops changes. So in the patch-set v5 configuration is saved and event is emitted for all cases when persistent domain configuration was updated from a snapshot. Dmitry Andreev (2): Introduce new VIR_DOMAIN_EVENT_DEFINED_FROM_SNAPSHOT sub-event qemuDomainRevertToSnapshot: save domain configuration examples/object-events/event-test.c | 2 ++ include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c | 9 +++++++++ tools/virsh-domain.c | 3 ++- 4 files changed, 14 insertions(+), 1 deletion(-) -- 1.8.3.1

2 5

[libvirt] [PATCH] qemu: Don't overwrite DomainSave errors
by Cole Robinson 16 Mar '16

16 Mar '16

These functions already report fine grained errors, there's no benefit to overwriting the error here. --- src/qemu/qemu_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index edf39d9..36c8fb5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17632,8 +17632,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("Saving live XML config failed")); goto endjob; } @@ -17659,8 +17657,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, conf_disk->blkdeviotune = info; ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("Write to config file failed")); goto endjob; } } -- 2.5.0

2 2

[libvirt] [PATCH] nodedev: Shorten match condition
by Martin Kletzander 16 Mar '16

16 Mar '16

Just a cleanup I stumbled upon in one of my older branches I did when browsing through some code and forgot to send it. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/conf/node_device_conf.c | 41 +++++++++++++++-------------------------- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index c04739f90121..0c9c348e3793 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1798,37 +1798,26 @@ virNodeDeviceCapMatch(virNodeDeviceObjPtr devobj, return false; } -#define MATCH(FLAG) (flags & (FLAG)) +#define MATCH(FLAG) ((flags & (VIR_CONNECT_LIST_NODE_DEVICES_CAP_ ## FLAG)) && \ + virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_ ## FLAG)) static bool virNodeDeviceMatch(virNodeDeviceObjPtr devobj, unsigned int flags) { /* filter by cap type */ - if (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP)) { - if (!((MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SYSTEM) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SYSTEM)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_PCI_DEV)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_USB_DEV) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_USB_DEV)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_USB_INTERFACE) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_USB_INTERFACE)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_NET) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_NET)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_HOST) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_HOST)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_TARGET) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_TARGET)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_STORAGE) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_STORAGE)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_FC_HOST) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_FC_HOST)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_VPORTS) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_VPORTS)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_GENERIC) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_GENERIC)))) + if (flags & VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP) { + if (!(MATCH(SYSTEM) || + MATCH(PCI_DEV) || + MATCH(USB_DEV) || + MATCH(USB_INTERFACE) || + MATCH(NET) || + MATCH(SCSI_HOST) || + MATCH(SCSI_TARGET) || + MATCH(SCSI) || + MATCH(STORAGE) || + MATCH(FC_HOST) || + MATCH(VPORTS) || + MATCH(SCSI_GENERIC))) return false; } -- 2.7.3

2 1

[libvirt] [PATCH] Report error when both live and offline flags are used for migration.
by Nitesh Konkar 16 Mar '16

16 Mar '16

--- src/libvirt-domain.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 9491845..dc11945 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3617,6 +3617,15 @@ virDomainMigrate(virDomainPtr domain, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -3841,6 +3850,15 @@ virDomainMigrate2(virDomainPtr domain, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -4014,6 +4032,15 @@ virDomainMigrate3(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_PEER2PEER) { virReportInvalidArg(flags, "%s", _("use virDomainMigrateToURI3 for peer-to-peer " -- 1.8.3.1

2 4

[libvirt] [PATCH 0/2] qemu: Support for QXL heads
by Martin Kletzander 15 Mar '16

15 Mar '16

So this is an old, tiny series that was posted some time ago; actually a lot of time ago. I complained because of two things. First one being that there are no tests, so this series has them in. The second one was that this could break migration from old code since the parameter was not used before. So I coded up a migration flag, handled all the special cases and then started testing it. And while testing it, I've found out that QEMU doesn't care at all about this parameter being there and there is no point in keeping it super-stable, especially when it can be changed on the fly. So I removed all that code and ended up with tiny series very similar to previous attempts by various people. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 8 ++++ .../qemuxml2argv-video-qxl-heads.args | 28 +++++++++++++ .../qemuxml2argv-video-qxl-heads.xml | 47 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 8 ++++ .../qemuxml2xmlout-video-qxl-heads.xml | 47 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 8 files changed, 146 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-heads.xml -- 2.7.2

2 6

[libvirt] github and gitlab mirrors are far behind
by Henning Schild 15 Mar '16

15 Mar '16

Hey, as the title says the mirrors are pretty far behind, probably something is broken there. Henning

1 0

[libvirt] User Behavior Tracking defenses in VMs
by bancfc＠openmailbox.org 14 Mar '16

14 Mar '16

Intended for qemu-discuss /cc/ libvir-list, whonix-devel, tor-dev *** Hello. I work on WhonixOS an anonymity distro based on Tor. This feature request is related to the topics of privacy and anonymity. Its a complex topic and probably not in your area of focus but I think it has important implications because security and privacy are very much related in today's hostile computing environment. Virtualization is useful in presenting an identical environment and set of "hardware" for each user which goes a long way in creating an anonymity set of systems. That way a system attacker, advertisers and online trackers would not be able to fingerprint a user or their hardware. The problem: Tracking techniques have become more sophisticated with time. They advanced from simple cookies to browser/device fingerprinting (which Tor Browser focuses on defeating) to user behavior fingerprinting. The latter is about profiling how a user types on a keyboard or uses a mouse [2]. Keystroke dynamics is a super creepy way to track users based on how long they press keys (dwell time) and the time between key presses (gap time). This is extremely accurate at identifying individuals because of how unique these measurements are. Advertising networks (Google, Facebook...) that fingeprprint users on both the clearnet and Tor can deanonymize users. This technique is already actively used in the wild [6][7]. Potential Solutions: Since input devices are all emulated its a great opportunity to stop this profiling technique. * A security researcher designed a proof of concept plugin for Chrome browser that mitigates this. Implementing something like the PoC addon in [1] known as KeyBoardPrivacy. Some random delay in milliseconds in a 50 millisecond range for dwell and gap times for the emulated keyboards is enough to skew the values to render this attack useless while not affecting performance. * The changes made to Tor Borwser to make JS timers more coarse grained but constant (250ms for keyboard events) were not enough to stop keystroke dynamics fingerprinting because a malicious script can evict the cache and allow extrapolation of true timing events within 1-5ms accuracy .[3][5] Their goal is to instead add jitter to the timers [4]. A similar solution proposed in [4] can be implemented in all QEMU-KVM timers to mitigate both attacks. [1] https://paul.reviews/behavioral-profiling-the-password-you-cant-change/ [2] http://jcarlosnorte.com/security/2016/03/06/advanced-tor-browser-fingerprin… [3] https://www.lightbluetouchpaper.org/2015/07/30/double-bill-password-hashing… [4] https://trac.torproject.org/projects/tor/ticket/16110 [5] https://trac.torproject.org/projects/tor/ticket/1517 [6] http://scraping.pro/no-captcha-recaptcha-challenge/ [7] https://nakedsecurity.sophos.com/2013/11/01/facebook-to-silent-track-users-…

1 0

[libvirt] [PATCH] schema: support 'default' cache mode
by Jim Fehlig 14 Mar '16

14 Mar '16

The docs claims the cache attribute of the disk <driver> element supports 'default' as one of its permissible values, but such configuration fails virt-xml-validate. Add 'default' as one of the cache attribute choices in domaincommon.rng. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- docs/schemas/domaincommon.rng | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 67af93a..d4e375f 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1596,6 +1596,7 @@ <define name="driverCache"> <attribute name="cache"> <choice> + <value>default</value> <value>none</value> <value>writeback</value> <value>writethrough</value> -- 2.1.4

2 3

[libvirt] Storage Backend - buildVolFrom Semantics
by Richard Laager 14 Mar '16

14 Mar '16

storage_backend_rbd.c uses an RBD clone operation to implement buildVolFrom. If I'm understanding the RBD documentation correctly, you cannot delete the parent until the clone has been deleted: http://docs.ceph.com/docs/master/dev/rbd-layering/ "Before cloning a snapshot, you must mark it as protected, to prevent it from being deleted while child images refer to it:" & "To delete the parent, you must first mark it unprotected, which checks that there are no children left:" Is libvirt okay with those semantics for volumes? That is, if you clone a volume, is it acceptable that you cannot delete the parent until you delete the clone? The answer to this affects how I'll write a patch to implement buildVolFrom for storage_backend_zfs.c. -- Richard

2 1

[libvirt] [libvirt-perl][PATCH] Add VIR_ERR_NO_SERVER constant
by Michal Privoznik 14 Mar '16

14 Mar '16

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Changes | 1 + Virt.xs | 1 + lib/Sys/Virt/Error.pm | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/Changes b/Changes index 4e343d5..aa71a1e 100644 --- a/Changes +++ b/Changes @@ -7,6 +7,7 @@ Revision history for perl module Sys::Virt VIR_DOMAIN_TUNABLE_CPU_GLOBAL_PERIOD & VIR_DOMAIN_TUNABLE_CPU_GLOBAL_QUOTA constants - Add VIR_DOMAIN_EVENT_ID_JOB_COMPLETED constant and callback + - Add VIR_ERR_NO_SERVER constant 1.3.2 2016-03-01 diff --git a/Virt.xs b/Virt.xs index 6059cdc..9cb80fa 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8439,4 +8439,5 @@ BOOT: REGISTER_CONSTANT(VIR_ERR_XML_INVALID_SCHEMA, ERR_INVALID_SCHEMA); REGISTER_CONSTANT(VIR_ERR_MIGRATE_FINISH_OK, ERR_MIGRATE_FINISH_OK); REGISTER_CONSTANT(VIR_ERR_AUTH_UNAVAILABLE, ERR_AUTH_UNAVAILABLE); + REGISTER_CONSTANT(VIR_ERR_NO_SERVER, ERR_NO_SERVER); } diff --git a/lib/Sys/Virt/Error.pm b/lib/Sys/Virt/Error.pm index e1b2578..3f6b058 100644 --- a/lib/Sys/Virt/Error.pm +++ b/lib/Sys/Virt/Error.pm @@ -784,6 +784,10 @@ Migration finished but expected to return NULL domain. Authentication services were not available +=item Sys::Virt::Error::ERR_NO_SERVER + +Libvirt server was not found + =back =head1 AUTHORS -- 2.4.10

2 1

[libvirt] [PATCH] qemu: Restore error/cleanup logic for qemuBuildNetCommandLine
by John Ferlan 14 Mar '16

14 Mar '16

The virDomainConfVMNWFilterTeardown was called in the error path of qemuBuildCommandLine once network setup was partially or fully completed using the last_good_net as the basis to determine which filters needed to be torn down. Commit id 'ef2ab8fd' moved that inside the new qemuBuildNetCommandLine, so that lost the failure. Moving that cleanup back outside the call to the more general failure case. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Jan notes post push that the cleanup path after building the network command line was there for any other failures and not just the failure in building the network command line: http://www.redhat.com/archives/libvir-list/2016-March/msg00561.html Even though the teardown is called during qemuProcessStop from virDomainConfVMNWFilterTeardown, the cleanup here could still be done. The reason for moving it inside was based on a different patch where the desire was to not leak anything that could have changed inside one of the moved qemuBuild*CommandLine functions. In this case, though since it's used more generally for cleanup, it seems a good idea to return it. The other option would be to just let qemuProcessStop handle it and a different patch to remove the error reset logic. src/qemu/qemu_command.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ba8c216..2e15c05 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7659,10 +7659,10 @@ qemuBuildNetCommandLine(virCommandPtr cmd, bool emitBootindex, size_t *nnicindexes, int **nicindexes, - int *bootHostdevNet) + int *bootHostdevNet, + int *last_good_net) { size_t i; - int last_good_net = -1; if (!def->nnets) { /* If we have -device, then we set -nodefault already */ @@ -7697,9 +7697,9 @@ qemuBuildNetCommandLine(virCommandPtr cmd, qemuCaps, vlan, bootNet, vmop, standalone, nnicindexes, nicindexes) < 0) - goto error; + return -1; - last_good_net = i; + *last_good_net = i; /* if this interface is a type='hostdev' interface and we * haven't yet added a "bootindex" parameter to an * emulated network device, save the bootindex - hostdev @@ -7714,11 +7714,6 @@ qemuBuildNetCommandLine(virCommandPtr cmd, } } return 0; - - error: - for (i = 0; last_good_net != -1 && i <= last_good_net; i++) - virDomainConfNWFilterTeardown(def->nets[i]); - return -1; } @@ -8604,6 +8599,7 @@ qemuBuildCommandLine(virConnectPtr conn, bool emitBootindex = false; virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); int bootHostdevNet = 0; + int last_good_net = -1; VIR_DEBUG("conn=%p driver=%p def=%p mon=%p json=%d " @@ -8725,7 +8721,7 @@ qemuBuildCommandLine(virConnectPtr conn, if (qemuBuildNetCommandLine(cmd, driver, def, qemuCaps, vmop, standalone, emitBootindex, nnicindexes, nicindexes, - &bootHostdevNet) < 0) + &bootHostdevNet, &last_good_net) < 0) goto error; if (qemuBuildSmartcardCommandLine(logManager, cmd, def, qemuCaps) < 0) @@ -9280,6 +9276,8 @@ qemuBuildCommandLine(virConnectPtr conn, /* free up any resources in the network driver * but don't overwrite the original error */ originalError = virSaveLastError(); + for (i = 0; last_good_net != -1 && i <= last_good_net; i++) + virDomainConfNWFilterTeardown(def->nets[i]); virSetError(originalError); virFreeError(originalError); virCommandFree(cmd); -- 2.5.0

2 1

[libvirt] [PATCH] vz: fix active domain listing
by Maxim Nestratov 14 Mar '16

14 Mar '16

Since commit 9c14a9ab we have broken active domain listing because reworked prlsdkLoadDomain doesn't set dom->def->id propely. It just looses it when a new def structure is set. Now we make prlsdkConvertDomainState function return void and move calling it after an old dom->def is replaces with a new one within prlsdkLoadDomain function. Signed-off-by: Maxim Nestratov <mnestratov(a)virtuozzo.com> --- src/vz/vz_sdk.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index de73c31..f7d769b 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -1051,7 +1051,7 @@ prlsdkAddVNCInfo(PRL_HANDLE sdkdom, virDomainDefPtr def) return -1; } -static int +static void prlsdkConvertDomainState(VIRTUAL_MACHINE_STATE domainState, PRL_UINT32 envId, virDomainObjPtr dom) @@ -1121,17 +1121,12 @@ prlsdkConvertDomainState(VIRTUAL_MACHINE_STATE domainState, dom->def->id = envId; break; case VMS_UNKNOWN: + default: virDomainObjSetState(dom, VIR_DOMAIN_NOSTATE, VIR_DOMAIN_NOSTATE_UNKNOWN); - break; - default: - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unknown domain state: %X"), domainState); - return -1; + dom->def->id = -1; break; } - - return 0; } static int @@ -1374,9 +1369,6 @@ prlsdkLoadDomain(vzConnPtr privconn, virDomainObjPtr dom) goto error; } - if (prlsdkConvertDomainState(domainState, envId, dom) < 0) - goto error; - /* assign new virDomainDef without any checks * we can't use virDomainObjAssignDef, because it checks * for state and domain name */ @@ -1386,6 +1378,8 @@ prlsdkLoadDomain(vzConnPtr privconn, virDomainObjPtr dom) VIR_FREE(pdom->home); pdom->home = home; + prlsdkConvertDomainState(domainState, envId, dom); + if (!pdom->sdkdom) { PrlHandle_AddRef(sdkdom); pdom->sdkdom = sdkdom; @@ -1532,8 +1526,8 @@ prlsdkHandleVmStateEvent(vzConnPtr privconn, prlsdkCheckRetGoto(pret, cleanup); pdom = dom->privateData; - if (prlsdkConvertDomainState(domainState, pdom->id, dom) < 0) - goto cleanup; + + prlsdkConvertDomainState(domainState, pdom->id, dom); prlsdkNewStateToEvent(domainState, &lvEventType, -- 2.4.3

2 2

[libvirt] [REPOST PATCH 0/8] Reorganize qemu_command.c in smaller piles (round 3)
by John Ferlan 14 Mar '16

14 Mar '16

Final pile of split. Rather than hope for a review of 25 patches or creating some remote place to place a branch - I'll repost the original: http://www.redhat.com/archives/libvir-list/2016-February/msg00975.html in smaller chunks. Differences in this set of patches vs. original series includes handling merge conflicts for logManager series plus a few minor edits/tweaks for better formatting/flow. This series was based off of git head commit 'ef2ab8fdc' which is the round 1 of the split: http://www.redhat.com/archives/libvir-list/2016-March/msg00288.html This is round 2 of the split based off of commit id '95ca4fe2': http://www.redhat.com/archives/libvir-list/2016-March/msg00491.html John Ferlan (8): qemu: Introduce qemuBuildSoundCommandLine qemu: Introduce qemuBuildWatchdogCommandLine qemu: Introduce qemuBuildRedirdevCommandLine qemu: Introduce qemuBuildHostdevCommandLine qemu: Introduce qemuBuildMemballoonCommandLine qemu: Introduce qemuBuildRNGCommandLine qemu: Introduce qemuBuildNVRAMCommandLine qemu: Introduce qemuBuildPanicCommandLine src/qemu/qemu_command.c | 1346 ++++++++++++++++++++++++++--------------------- src/qemu/qemu_command.h | 25 +- 2 files changed, 743 insertions(+), 628 deletions(-) -- 2.5.0

2 9

[libvirt] [PATCH] qemuBuildVideoCommandLine: Don't access def->videos without check
by Michal Privoznik 14 Mar '16

14 Mar '16

This function can be called over a domain definition that has no video configured. The tests/qemuxml2argvdata/qemuxml2argv-minimal.xml file could serve as an example. Problem is, before the check that domain has some or none video configured, def->videos is dereferenced causing a segmentation fault in case there's none video configured. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_command.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ba8c216..32d32b1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3809,7 +3809,7 @@ qemuBuildVideoCommandLine(virCommandPtr cmd, virQEMUCapsPtr qemuCaps) { size_t i; - int primaryVideoType = def->videos[0]->type; + int primaryVideoType; if (!def->nvideos) { /* If we have -device, then we set -nodefaults already */ @@ -3819,6 +3819,8 @@ qemuBuildVideoCommandLine(virCommandPtr cmd, return 0; } + primaryVideoType = def->videos[0]->type; + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY) && ((primaryVideoType == VIR_DOMAIN_VIDEO_TYPE_VGA && virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VGA)) || -- 2.4.10

3 2

[libvirt] Enhancement: Random Clock Offset
by bancfc＠openmailbox.org 14 Mar '16

14 Mar '16

For better system anonymity (to decouple VM OS timestamps leaked in traffic from host ones) a feature can be added to the clock offset variable to select randomly from a specified range of seconds from instead of a fixed number of seconds. That way a guest's clock can vary unpredictably from the host's and confuse correlation by network adversaries. Full Disclosure: I am from the Tor centric Whonix Project - whonix.org and this would be a very useful feature for us.

3 4

[libvirt] [PATCH REPOST 0/9] Reorganize qemu_command.c in smaller piles
by John Ferlan 14 Mar '16

14 Mar '16

Rather than hope for a review of 25 patches or creating some remote place to place a branch - I'll repost the original: http://www.redhat.com/archives/libvir-list/2016-February/msg00975.html in smaller chunks. No differences in these patches other than a rebase to top of tree a short while ago (commit id 'cf091094a'). There were also no conflicts from changes since initial posting. John Ferlan (9): qemu: Introduce qemuBuildClockCommandLine qemu: Introduce qemuBuildPMCommandLine qemu: Introduce qemuBuildBootCommandLine qemu: Introduce qemuBuildGlobalControllerCommandLine qemu: Introduce qemuBuildControllerDevCommandLine qemu: Introduce qemuBuildHubCommandLine qemu: Introduce qemuBuildDiskDriveCommandLine qemu: Introduce qemuBuildFSDevCommandLine qemu: Introduce qemuBuildNetCommandLine src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 8 +- src/qemu/qemu_command.c | 5488 +++++++++++++++++++++------------------- src/qemu/qemu_command.h | 15 +- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_domain_address.h | 2 +- 6 files changed, 2843 insertions(+), 2686 deletions(-) -- 2.5.0

3 20

[libvirt] [PATCH 0/2] Fix building with clang (again)
by Martin Kletzander 14 Mar '16

14 Mar '16

*** SOME VERY RANDOM BLURB HERE *** Martin Kletzander (2): Skip pdwtags-related tests when compiling with clang Fix build with clang src/Makefile.am | 4 +++- tests/qemuxml2argvmock.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) -- 2.7.3

2 5

[libvirt] any better way to treat device-detach timeout ?
by Zhangbo (Oscar) 14 Mar '16

14 Mar '16

Hi,all: I find that we remove devices only after DEVICE_DELETED event.(patch:3fbf78bd). And it treats TIMEOUT as success. The detailed codes are shown as below: rc = qemuDomainWaitForDeviceRemoval(vm); if (rc == 0 || rc == 1) ret = qemuDomainRemoveDiskDevice(driver, vm, detach); else ret = 0; Here comes the problem: If 1. We pass flags=3(VIR_DOMAIN_AFFECT_LIVE|VIR_DOMAIN_AFFECT_CONFIG) to virDomainDetachDeviceFlags, 2. It timed out to receive DEVICE_DELETED event, virDomainDetachDeviceFlags api will return 0(succeed). Please be aware that: vm->newdef(persistent) removes the device while vm->def(transient) keeps it untouched. 3. Then we try to attach the same device with flag 3, because it differs in newDef and def, the API virDomainDetachDeviceFlags() returns ERROR. Consequent attach/detach jobs all fail after then. So, shall we make it return FAIL when it fails in qemuDomainWaitForDeviceRemoval()? Or just remove the device in def after we get the DEVICE_DELETED event? Any ideas, thanks!

2 5

[libvirt] [PATCH REPOST 0/8] Reorganize qemu_command.c in smaller piles (round 2)
by John Ferlan 12 Mar '16

12 Mar '16

Rather than hope for a review of 25 patches or creating some remote place to place a branch - I'll repost the original: http://www.redhat.com/archives/libvir-list/2016-February/msg00975.html in smaller chunks. Differences in this set of patches vs. original series includes handling merge conflicts for logManager series plus a few minor edits/tweaks for better formatting/flow. This series was based off of git head commit 'ef2ab8fdc' which is the round 1 of the split: http://www.redhat.com/archives/libvir-list/2016-March/msg00288.html John Ferlan (8): qemu: Introduce qemuBuildSmartcardCommandLine qemu: Introduce qemuBuildSerialCommandLine qemu: Introduce qemuBuildParallelsCommandLine qemu: Introduce qemuBuildChannelsCommandLine qemu: Introduce qemuBuildConsoleCommandLine qemu: Modify qemuBuildTPMCommandLine qemu: Introduce qemuBuildInputCommandLine qemu: Introduce qemuBuildVideoCommandLine src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 1410 +++++++++++++++++++++++------------------- src/qemu/qemu_command.h | 6 +- 4 files changed, 760 insertions(+), 660 deletions(-) -- 2.5.0

2 16

[libvirt] [PATCH] Added qt-virt-manager to Application docs.
by F1ash 12 Mar '16

12 Mar '16

*** BLURB HERE *** F1ash (1): added qt-virt-manager to Application docs; docs/apps.html.in | 4 ++++ 1 file changed, 4 insertions(+) -- 2.7.2

1 1

[libvirt] [libvirt-glib v2 0/9] gconfig: Add hostdev support
by Christophe Fergeau 12 Mar '16

12 Mar '16

Hey, While reviewing Zeeshan's libvirt-gconfig hostdev series, I fixed up a few things, and added a few additional helpers/getters in order to simplify the code/make the test case more complete. This series contains this new code. The changes I made to Zeeshan's initial patches are in separate fixup! commits to make reviewing them easier (for you Zeeshan ;). I expect these to be squashed in the main commits before being pushed. Zeeshan's commits are unchanged from v1. Christophe

2 14

[libvirt] [libvirt-glib v3 1/5] gconfig: Add gvir_config_object_has_child
by Christophe Fergeau 11 Mar '16

11 Mar '16

--- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h b/libvirt-gconfig/libvirt-gconfig-object-private.h index e91c4ef..7a0d21f 100644 --- a/libvirt-gconfig/libvirt-gconfig-object-private.h +++ b/libvirt-gconfig/libvirt-gconfig-object-private.h @@ -117,6 +117,8 @@ GVirConfigObject *gvir_config_object_get_child(GVirConfigObject *object, GVirConfigObject *gvir_config_object_get_child_with_type(GVirConfigObject *object, const gchar *child_name, GType child_type); +gboolean gvir_config_object_has_child(GVirConfigObject *object, + const gchar *child_name); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index bf328f3..6225de2 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -970,3 +970,16 @@ gvir_config_object_get_child(GVirConfigObject *object, child_name, GVIR_CONFIG_TYPE_OBJECT); } + +G_GNUC_INTERNAL gboolean +gvir_config_object_has_child(GVirConfigObject *object, const gchar *child_name) +{ + xmlNodePtr node; + + g_return_val_if_fail(GVIR_CONFIG_IS_OBJECT(object), FALSE); + g_return_val_if_fail(child_name != NULL, FALSE); + + node = gvir_config_xml_get_element(object->priv->node, child_name, NULL); + + return (node != NULL); +} -- 2.5.0

1 4

Re: [libvirt] dist-git build problem on epel-6-x86_64 chroot
by Jean-Marc LIGER 11 Mar '16

11 Mar '16

Le 19/02/2016 11:40, Miroslav Suchý a écrit : > Dne 19.1.2016 v 17:01 Jean-Marc LIGER napsal(a): >> Hy, >> >> I'm facing the problem below on epel-6-x86_64 chroot for both from URL and upload SRPM : >> >> [2016-01-19 15:16:26,790][ INFO][PID:3241] Setting up builder: 172.25.94.167 >> [2016-01-19 15:16:27,991][ INFO][PID:3241] marking build dir with build_id, >> [2016-01-19 15:16:27,992][ INFO][PID:3241] Start build: BuildJob<id: 154509, owner: jmliger, project: virt6-upstream, >> git branch: el6, git_hash: acef5efd6153aa8f9ea760f468333e65c9b46a4e, status: 3 > >> [2016-01-19 15:16:27,993][ INFO][PID:3241] putting into minimal buildroot of epel-6-x86_64 >> [2016-01-19 15:16:28,902][ INFO][PID:3241] Cloning Dist Git repo jmliger/virt6-upstream/libvirt, branch >> acef5efd6153aa8f9ea760f468333e65c9b46a4e, hash el6 >> [2016-01-19 15:16:30,906][ ERROR][PID:3241] Failed to obtain srpm from dist-git >> Traceback (most recent call last): >> File "/usr/share/copr/backend/mockremote/builder.py", line 209, in download_job_pkg_to_builder >> self.remote_pkg_path = list(results["contacted"].values())[0][u"stdout"].split("Wrote: ")[1] >> IndexError: list index out of range >> [2016-01-19 15:16:30,911][ ERROR][PID:3241] builder.build error building pkg `libvirt`: BuildError: Failed to obtain >> srpm from dist-git: ansible results {'dark': {}, 'contacted': {'172.25.94.167': {'cmd': 'rm -rf /tmp/build_package_repo >> && mkdir /tmp/build_package_repo && cd /tmp/build_package_repo && git clone >> http://copr-dist-git.fedorainfracloud.org/git/jmliger/virt6-upstream/libvir… && cd libvirt && git checkout >> acef5efd6153aa8f9ea760f468333e65c9b46a4e && fedpkg-copr --dist el6 srpm', 'end': '2016-01-19 15:16:30.308282', 'stdout': >> 'Downloading libvirt-1.3.1.tar.gz\n\r >> 0.0%\r >> 100.0%\r######################################################################## 100.0%', 'changed': True, 'start': >> '2016-01-19 15:16:28.758321', 'delta': '0:00:01.549961', 'stderr': "Cloning into 'libvirt'...\nNote: checking out >> 'acef5efd6153aa8f9ea760f468333e65c9b46a4e'.\n\nYou are in 'detached HEAD' state. You can look around, make >> experimental\nchanges and commit them, and you can discard any commits you make in this\nstate without impacting any >> branches by performing another checkout.\n\nIf you want to create a new branch to retain commits you create, you may\ndo >> so (now or later) by using -b with the checkout command again. Example:\n\n git checkout -b <new-branch-name>\n\nHEAD >> is now at acef5ef... import_srpm\nerror: line 1800: Trigger fired by the same package is already defined in spec file: >> %post daemon-config-network\n\nerror: query of specfile /tmp/build_package_repo/libvirt/libvirt.spec failed, can't >> parse\n\nCould not execute srpm: Could not get n-v-r-e from '\\n\\n'", 'rc': 1, 'invocation': {'module_name': 'shell', >> 'module_complex_args': {}, 'module_args': u'rm -rf /tmp/build_package_repo && mkdir /tmp/build_package_repo && cd >> /tmp/build_package_repo && git clone http://copr-dist-git.fedorainfracloud.org/git/jmliger/virt6-upstream/libvir… && >> cd libvirt && git checkout acef5efd6153aa8f9ea760f468333e65c9b46a4e && fedpkg-copr --dist el6 srpm'}, 'warnings': >> ['Consider using file module with state=absent rather than running rm']}}} >> [2016-01-19 15:16:31,759][ INFO][PID:3241] End Build: BuildJob<id: 154509, owner: jmliger, project: virt6-upstream, git >> branch: el6, git_hash: acef5efd6153aa8f9ea760f468333e65c9b46a4e, status: 3 > >> >> https://copr.fedoraproject.org/coprs/jmliger/virt6-upstream/builds/ >> >> Regards, >> Jean-Marc LIGER >> >> >> _______________________________________________ >> copr-devel mailing list >> copr-devel(a)lists.fedorahosted.org >> https://lists.fedorahosted.org/admin/lists/copr-devel@lists.fedorahosted.org > It is some problem with your spec file. > You can reproduce it by installing fedpkg-copr from our Copr project and > git clone http://copr-dist-git.fedorainfracloud.org/git/jmliger/virt6-upstream/libvir… > cd libvirt > git checkout acef5efd6153aa8f9ea760f468333e65c9b46a4e > fedpkg-copr -vvv --dist el6 srpm > > Which will fails on: > > rpm --define '_sourcedir /tmp/libvirt' --define '_specdir /tmp/libvirt' --define '_builddir /tmp/libvirt' --define > '_srcrpmdir /tmp/libvirt' --define '_rpmdir /tmp/libvirt' --define 'dist .el6' --define 'rhel 6' --eval '%undefine > fedora' --define 'el6 1' --eval '%undefine fc23' -q --qf "%{NAME} %{EPOCH} %{VERSION} %{RELEASE}??" --specfile > /tmp/libvirt/libvirt.spec > > error: line 1800: Trigger fired by the same package is already defined in spec file: %post daemon-config-network > error: query of specfile /tmp/libvirt/libvirt.spec failed, can't parse > > And your spec file is so complex that I have no idea why it is failing. You may ask on RPM mailing list. > Thanks for your reply, I'm addressing this problem to the libvirt list.

1 1

[libvirt] [PATCH V3 0/2] libxl: support assignment VF to guest from a pool of SRIOV VFs
by Chunyan Liu 11 Mar '16

11 Mar '16

This patch series is to support assigning VF to guest from a pool of SRIOV VFs in libxl driver, detailed usage can be referred to: http://wiki.libvirt.org/page/Networking#Assignment_from_a_pool_of_SRIOV_VFs… Chunyan Liu (2): libxl_conf: reuse virDomainNetGetActualtype in libxlMakeNicList libxl: support assignment from a pool of SRIOV VFs src/libxl/libxl_conf.c | 3 ++- src/libxl/libxl_domain.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ src/libxl/libxl_driver.c | 12 ++++++++++++ tests/Makefile.am | 3 +++ 4 files changed, 63 insertions(+), 1 deletion(-) -- 2.1.4

3 5

[libvirt] [PATCH 0/2] RFC: qemu: aarch64 virtio-pci work
by Cole Robinson 11 Mar '16

11 Mar '16

These patches apply on top of the series I just posted: [PATCH 0/9] tests: qemu: unconditionally enable QEMU_CAPS_DEVICE https://www.redhat.com/archives/libvir-list/2016-January/msg01233.html These specific changers were discussed here: https://www.redhat.com/archives/libvir-list/2015-December/msg00217.html We need a way for apps to tell libvirt 'use virtio-pci not virtio-mmio' for aarch64 -M virt. We can't really make use this by default yet since most OS don't actually support it. So we decided the best course of interaction is to allow users to pass a manual pci controller, and libvirt will interpret that to mean it's okay to use virtio-pci. Patch #1 undoes the current behavior of unconditionally adding a q35 style PCIe controller setup for mach-virt that supports it. In the future we will probably re-enable something like this, but maybe not for a year or so until the bits proliferate to distros. Patch #2 tries to implement the manual pci controller bit. Unfortunately it's not that easy get the ideal XML to work, so this isn't ready for committing. See the commit message for more details Cole Robinson (2): qemu: aarch64: Don't add PCIe controller by default HACK: qemu: aarch64: Use virtio-pci if user specifies PCI controller src/qemu/qemu_command.c | 34 ++++++++---- src/qemu/qemu_domain.c | 4 -- ...l2argv-aarch64-pci-manual-nocontroller-fail.xml | 43 ++++++++++++++++ .../qemuxml2argv-aarch64-virtio-pci-default.args | 2 - ...l2argv-aarch64-virtio-pci-manual-addresses.args | 2 - ...ml2argv-aarch64-virtio-pci-manual-addresses.xml | 1 + ...2argv-aarch64-virtio-pci-manual-controller.args | 36 +++++++++++++ ...l2argv-aarch64-virtio-pci-manual-controller.xml | 50 ++++++++++++++++++ tests/qemuxml2argvtest.c | 22 ++++++-- .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 10 ---- ...2xmlout-aarch64-virtio-pci-manual-addresses.xml | 11 +--- ...xmlout-aarch64-virtio-pci-manual-controller.xml | 60 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 6 +++ 13 files changed, 239 insertions(+), 42 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-pci-manual-nocontroller-fail.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-controller.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-controller.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-manual-controller.xml -- 2.5.0

4 15

[libvirt] [PATCH v4 0/2] qemu: add debug-threads support
by Marc-André Lureau 11 Mar '16

11 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and enable debug-threads if supported. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers v3->v4: - simplify a bit command generation - added a test v2->v3: - move -name command generation in seperate function - fix syntax-check - fix leak v1->v2: - drop the configuration, enable debug-thread automatically Marc-André Lureau (2): qemu: check for debug-threads capability qemu: enable debug threads src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 34 +++++++++++++++++----- tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + .../qemuxml2argv-debug-threads.args | 22 ++++++++++++++ .../qemuxml2argv-debug-threads.xml | 34 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 10 files changed, 91 insertions(+), 8 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-debug-threads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-debug-threads.xml -- 2.5.0

3 4

[libvirt] [PATCH v3 0/2] qemu: add debug-threads support
by Marc-André Lureau 11 Mar '16

11 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and enable debug-threads if supported. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers v2->v3: - move -name command generation in seperate function - fix syntax-check - fix leak v1->v2: - drop the configuration, enable debug-thread automatically Marc-André Lureau (2): qemu: check for debug-threads capability qemu: enable debug threads src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 40 ++++++++++++++++++++++------ tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + 7 files changed, 39 insertions(+), 8 deletions(-) -- 2.5.0

3 5

[libvirt] [PATCH v2 0/2] qemu: add debug-threads support
by Marc-André Lureau 11 Mar '16

11 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and enable debug-threads if supported. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers v1->v2: - drop the configuration, enable debug-thread automatically Marc-André Lureau (2): qemu: check for debug-threads capability qemu: enable debug threads src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +++++++++---- tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + 7 files changed, 16 insertions(+), 4 deletions(-) -- 2.5.0

4 8

[libvirt] [PATCH] qemuxml2argvtest: Fix monitor path in serial-file-log
by Jiri Denemark 11 Mar '16

11 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: Pushed as a build-breaker. tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args index de313e5..38cad7b 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args @@ -13,7 +13,8 @@ QEMU_AUDIO_DRV=none \ -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ -nographic \ -nodefaults \ --chardev socket,id=charmonitor,path=/tmp/test-monitor,server,nowait \ +-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ +server,nowait \ -mon chardev=charmonitor,id=monitor,mode=readline \ -no-acpi \ -boot c \ -- 2.7.2

1 0

[libvirt] [PATCH 0/4] docs: website: improve readability
by Cole Robinson 11 Mar '16

11 Mar '16

Some css tweaks to improve test readability and be more consistent with other sites (I was using en.wikipedia.org as a reference) First 2 bits are cleanups, latter 2 bits are actual changes. Front before: http://i.imgur.com/zvFqBa9.png Front after: http://i.imgur.com/gsHa5Pq.png List before: http://i.imgur.com/nh6hMsy.png List after: http://i.imgur.com/WxgE4y0.png Text before: http://i.imgur.com/8bvgEYg.png Text after: http://i.imgur.com/wg0hk4r.png Cole Robinson (4): docs: website: Remove the et.redhat.com footer docs: generic.css: minor cleanups docs: generic.css: font size tweaks docs: generic.css: Indentation and spacing tweaks docs/Makefile.am | 3 --- docs/et.png | Bin 9779 -> 0 bytes docs/footer_corner.png | Bin 2359 -> 0 bytes docs/footer_pattern.png | Bin 817 -> 0 bytes docs/generic.css | 57 ++++++++++++++++++++++++------------------------ docs/libvirt.css | 34 ----------------------------- docs/page.xsl | 6 ----- 7 files changed, 29 insertions(+), 71 deletions(-) delete mode 100644 docs/et.png delete mode 100644 docs/footer_corner.png delete mode 100644 docs/footer_pattern.png -- 2.5.0

3 10

[libvirt] [PATCH 0/3] storage: fix file unlink with old uid cache
by Cole Robinson 10 Mar '16

10 Mar '16

There's been several reports of issues deleting storage volumes after creating a VM with virt-manager/virt-install. These patches fix the reports, see patch descriptions for details. Patch #1 is the main fix IMO Patch #2 is a related cleanup that clarifies some remove logic Patch #3 is optional and may not be exhaustive, it's mostly for discussion Pavel's original patches and discussions: https://www.redhat.com/archives/libvir-list/2016-February/msg01224.html https://bugzilla.redhat.com/show_bug.cgi?id=1289327 https://bugzilla.redhat.com/show_bug.cgi?id=1293804 Cole Robinson (3): storage: refresh volume before deletion util: virfile: Clarify setuid usage for virFileRemove util: virfile: Only setuid for virFileRemove if on NFS src/storage/storage_driver.c | 10 ++++++++++ src/util/virfile.c | 39 +++++++++++++++++++++++++++++++++------ 2 files changed, 43 insertions(+), 6 deletions(-) -- 2.5.0

4 13

[libvirt] [PATCH v2 0/8] Use virtlogd for chardevs & support logging
by Daniel P. Berrange 10 Mar '16

10 Mar '16

This series of patches does two things * Converts the type=file chardev over to use virtlogd (assuming use of virtlogd is enabled in qemu.conf) * Adds a <log file="..."/> element to all chardev sources, allowing data to be captured to a logfile Both of these are important features wanted by openstack. The first thing fixes a long standing security issue that a guest OS can trivially exhuast host disk space by outputing lots of data to its serial port. The second thing allows OpenStack to record boot up messages for a guest's serial console, while still allowing interactive serial console ussage. ie the serial port will be configured with type=tcp, and the new <log> element used to record the data. Both these thing required changes in QEMU, which have been merged for the forthcoming QEMU 2.6 release. Changed in v2: * Split patch 4 up into 4 separate patches * Fix memory leaks * Use common function for building log manager cli args * Add missing XML docs Daniel P. Berrange (8): logging: allow inode/offset params to be NULL conf: allow use of a logfile with chardev backends qemu: add support for logging chardev output to a file qemu: don't append -chardev arg until after value is formatted qemu: move functions for handling FD passing logging: support truncation of logfiles when opening qemu: use virtlogd for character device log files qemu: support use of virtlogd with file based chardevs docs/formatdomain.html.in | 14 + docs/schemas/domaincommon.rng | 12 + src/conf/domain_conf.c | 30 +++ src/conf/domain_conf.h | 2 + src/logging/log_daemon_dispatch.c | 3 +- src/logging/log_handler.c | 6 +- src/logging/log_handler.h | 2 +- src/logging/log_manager.c | 6 +- src/logging/log_manager.h | 2 + src/logging/log_protocol.x | 4 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 282 ++++++++++++++------- src/qemu/qemu_command.h | 9 +- src/qemu/qemu_domain.c | 6 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_process.c | 4 +- .../qemuxml2argv-serial-file-log.args | 25 ++ .../qemuxml2argv-serial-file-log.xml | 39 +++ tests/qemuxml2argvtest.c | 4 +- 21 files changed, 353 insertions(+), 105 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.xml -- 2.5.0

2 13

[libvirt] [PATCH 0/3] vcpu refactoring fixes
by Peter Krempa 10 Mar '16

10 Mar '16

My recent refactros led to a few bugs. The memory leak was not caused by me, but it looked like I might have broken it so I've fixed it. Peter Krempa (3): qemu: cpu: Don't remove pinning of cold-unplugged cpu conf: Fix off-by-one in virDomainDefGetVcpu qemu: Fix memory leak in qemuGetSchedInfo src/conf/domain_conf.c | 2 +- src/qemu/qemu_driver.c | 15 +-------------- 2 files changed, 2 insertions(+), 15 deletions(-) -- 2.6.2

3 6

[libvirt] [PATCH 0/2] qemu: add debug-threads support
by Marc-André Lureau 10 Mar '16

10 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and a qemu-conf key to enable debug-threads. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers Marc-André Lureau (2): qemu: check for debug-threads capability qemu_conf: add set_debug_threads_name configuration key src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 6 ++++++ src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 14 ++++++++++---- src/qemu/qemu_conf.c | 1 + src/qemu/qemu_conf.h | 1 + src/qemu/test_libvirtd_qemu.aug.in | 1 + tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + 12 files changed, 27 insertions(+), 4 deletions(-) -- 2.5.0

4 6

[libvirt] [PATCH v2 0/2] vcpu info refactors - part 3b
by Peter Krempa 10 Mar '16

10 Mar '16

Peter Krempa (2): qemu: vcpupin: Extract live vcpupin setting into a separate function qemu: Refactor bitmap handling in qemuDomainPinVcpuFlags src/qemu/qemu_driver.c | 163 +++++++++++++++++++++++++++---------------------- 1 file changed, 89 insertions(+), 74 deletions(-) -- 2.6.2

2 3

[libvirt] [PATCH 0/2] persistant live migration with specified XML
by Dmitry Andreev 10 Mar '16

10 Mar '16

Live migration has a bug: specified XML doesn't used for persistant configuration. https://bugzilla.redhat.com/show_bug.cgi?id=835300 This patch-set fixes this problem. Specified XML used for both active and inactive domain XML. Hope this is what it should be. Dmitry Andreev (2): qemuMigrationCookieAddPersistent: change argument type qemu: migration: use specified XML for active and inactive confguration src/qemu/qemu_migration.c | 55 ++++++++++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 27 deletions(-) -- 1.8.3.1

2 3

[libvirt] [PATCH] libxl: small fix in parsing network
by Chunyan Liu 10 Mar '16

10 Mar '16

Signed-off-by: Chunyan Liu <cyliu(a)suse.com> --- src/libxl/libxl_conf.c | 2 +- src/libxl/libxl_domain.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 5133299..48b8826 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1471,7 +1471,7 @@ libxlMakeNicList(virDomainDefPtr def, libxl_domain_config *d_config) VIR_SHRINK_N(x_nics, nnics, nnics - nvnics); d_config->nics = x_nics; - d_config->num_nics = nnics; + d_config->num_nics = nvnics; return 0; diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 632acfd..50f7eed 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -315,7 +315,7 @@ libxlDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, virDomainHostdevSubsysPCIPtr pcisrc; if (dev->type == VIR_DOMAIN_DEVICE_NET) - hostdev = &(dev->data.net)->data.hostdev.def; + hostdev = &dev->data.net->data.hostdev.def; else hostdev = dev->data.hostdev; pcisrc = &hostdev->source.subsys.u.pci; -- 2.1.4

3 4

[libvirt] [PATCH 0/9] vcpu info refactors - part 3b
by Peter Krempa 09 Mar '16

09 Mar '16

Yet another continuation of the saga. In this episode we add pinning for inactive cpus. Peter Krempa (9): virsh: vcpupin: Ask for pinning info for all vCPUs conf: Extract code filling data for virDomainGetVcpuPinInfo qemu: Report pinning for all vCPUs in qemuDomainGetVcpuPinInfo conf: introduce parser feature flags conf: refactor checking for unsupported memory devices conf: extract ignoring of inactive vcpu pinning information qemu: add support for offline vcpupin qemu: vcpupin: Extract live vcpupin setting into a separate function qemu: Refactor bitmap handling in qemuDomainPinVcpuFlags src/bhyve/bhyve_domain.c | 9 +- src/conf/domain_conf.c | 157 +++++++++++++++++++++++++++--- src/conf/domain_conf.h | 20 +++- src/libvirt_private.syms | 3 +- src/libxl/libxl_domain.c | 7 -- src/libxl/libxl_driver.c | 38 +------- src/lxc/lxc_domain.c | 8 -- src/openvz/openvz_driver.c | 7 -- src/phyp/phyp_driver.c | 6 +- src/qemu/qemu_domain.c | 2 + src/qemu/qemu_driver.c | 234 +++++++++++++++++++-------------------------- src/test/test_driver.c | 38 +------- src/uml/uml_driver.c | 9 +- src/vbox/vbox_common.c | 6 +- src/vmware/vmware_driver.c | 6 +- src/vmx/vmx.c | 8 +- src/vz/vz_driver.c | 6 +- src/xen/xen_driver.c | 7 -- src/xenapi/xenapi_driver.c | 7 -- tools/virsh-domain.c | 3 +- 20 files changed, 279 insertions(+), 302 deletions(-) -- 2.6.2

2 18

[libvirt] [python PATCH] Add support for JOB_COMPLETED event
by Jiri Denemark 09 Mar '16

09 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- examples/event-test.py | 3 ++ libvirt-override-virConnect.py | 9 ++++++ libvirt-override.c | 64 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 76 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py index 615f86c..5be4978 100755 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -533,6 +533,8 @@ def myDomainEventDeviceAddedCallback(conn, dom, dev, opaque): def myDomainEventMigrationIteration(conn, dom, iteration, opaque): print("myDomainEventMigrationIteration: Domain %s(%s) started migration iteration %d" % ( dom.name(), dom.ID(), iteration)) +def myDomainEventJobCompletedCallback(conn, dom, params, opaque): + print("myDomainEventJobCompletedCallback: Domain %s(%s) %s" % (dom.name(), dom.ID(), params)) ########################################################################## # Network events @@ -646,6 +648,7 @@ def main(): vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE, myDomainEventAgentLifecycleCallback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_DEVICE_ADDED, myDomainEventDeviceAddedCallback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION, myDomainEventMigrationIteration, None) + vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_JOB_COMPLETED, myDomainEventJobCompletedCallback, None) vc.networkEventRegisterAny(None, libvirt.VIR_NETWORK_EVENT_ID_LIFECYCLE, myNetworkEventLifecycleCallback, None) diff --git a/libvirt-override-virConnect.py b/libvirt-override-virConnect.py index 4231195..396a6ed 100644 --- a/libvirt-override-virConnect.py +++ b/libvirt-override-virConnect.py @@ -225,6 +225,15 @@ cb(self, virDomain(self, _obj=dom), iteration, opaque) return 0 + def _dispatchDomainEventJobCompletedCallback(self, dom, params, cbData): + """Dispatches event to python user domain job completed callbacks + """ + cb = cbData["cb"] + opaque = cbData["opaque"] + + cb(self, virDomain(self, _obj=dom), params, opaque) + return 0 + def domainEventDeregisterAny(self, callbackID): """Removes a Domain Event Callback. De-registering for a domain callback will disable delivery of this event type """ diff --git a/libvirt-override.c b/libvirt-override.c index 2308802..ce36280 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6835,6 +6835,65 @@ libvirt_virConnectDomainEventMigrationIterationCallback(virConnectPtr conn ATTRI } #endif /* VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION */ +#ifdef VIR_DOMAIN_EVENT_ID_JOB_COMPLETED +static int +libvirt_virConnectDomainEventJobCompletedCallback(virConnectPtr conn ATTRIBUTE_UNUSED, + virDomainPtr dom, + virTypedParameterPtr params, + int nparams, + void *opaque) +{ + PyObject *pyobj_cbData = (PyObject*)opaque; + PyObject *pyobj_dom; + PyObject *pyobj_ret = NULL; + PyObject *pyobj_conn; + PyObject *dictKey; + PyObject *pyobj_dict = NULL; + int ret = -1; + + LIBVIRT_ENSURE_THREAD_STATE; + + pyobj_dict = getPyVirTypedParameter(params, nparams); + if (!pyobj_dict) + goto cleanup; + + if (!(dictKey = libvirt_constcharPtrWrap("conn"))) + goto cleanup; + pyobj_conn = PyDict_GetItem(pyobj_cbData, dictKey); + Py_DECREF(dictKey); + + /* Create a python instance of this virDomainPtr */ + virDomainRef(dom); + if (!(pyobj_dom = libvirt_virDomainPtrWrap(dom))) { + virDomainFree(dom); + goto cleanup; + } + Py_INCREF(pyobj_cbData); + + /* Call the Callback Dispatcher */ + pyobj_ret = PyObject_CallMethod(pyobj_conn, + (char*)"_dispatchDomainEventJobCompletedCallback", + (char*)"OOO", + pyobj_dom, pyobj_dict, pyobj_cbData); + + Py_DECREF(pyobj_cbData); + Py_DECREF(pyobj_dom); + + cleanup: + if (!pyobj_ret) { + DEBUG("%s - ret:%p\n", __FUNCTION__, pyobj_ret); + PyErr_Print(); + Py_XDECREF(pyobj_dict); + } else { + Py_DECREF(pyobj_ret); + ret = 0; + } + + LIBVIRT_RELEASE_THREAD_STATE; + return ret; +} +#endif /* VIR_DOMAIN_EVENT_ID_JOB_COMPLETED */ + static PyObject * libvirt_virConnectDomainEventRegisterAny(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) @@ -6940,6 +6999,11 @@ libvirt_virConnectDomainEventRegisterAny(PyObject *self ATTRIBUTE_UNUSED, cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventMigrationIterationCallback); break; #endif /* VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION */ +#ifdef VIR_DOMAIN_EVENT_ID_JOB_COMPLETED + case VIR_DOMAIN_EVENT_ID_JOB_COMPLETED: + cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventJobCompletedCallback); + break; +#endif /* VIR_DOMAIN_EVENT_ID_JOB_COMPLETED */ case VIR_DOMAIN_EVENT_ID_LAST: break; } -- 2.7.2

2 1

[libvirt] sVirt shouldn't let Nova do stupid things
by Matthew Booth 09 Mar '16

09 Mar '16

Nova just released a fix for this critical CVE: https://bugs.launchpad.net/nova/+bug/1548450 To summarise, it's a qcow2 backing file exploit. The user writes a malicious qcow2 header to the top of a raw disk, then triggers a bug in Nova which causes it to do format detection. If you read the bug and comments, you'll see that when I initially reported it I was fairly dismissive of its impact because it's only exploitable through libvirt, and the instance is going to be confined by SELinux. But then Dan B points out that sVirt is going to trust whatever Nova tells it to do and label it appropriately. Cue rapid ramping of severity, and it turns out this allows an unprivileged user to read anything on the host, including all raw block devices. I'm not sure exactly where, but something in this stack has failed us. Let's be clear a couple of things, though: 1. This is an egregious, stupid bug in Nova, and Nova shouldn't have egregious, stupid bugs. 2. SELinux should prevent obviously bad things from happening, even in the presence of egregious, stupid bugs. I point that out to head off: 'Well Nova shouldn't do that'. Of course it shouldn't. However, it might, and when it does, I'd like to think that SELinux has its back. It doesn't, though. As I understand it, sVirt is the mechanism libvirt uses for controlling SELinux. I wonder if the current sVirt model is enough to cover the use case where the thing connecting to libvirt is large enough to have its own serious bugs. Is there any way we could define a sane set of operations independent of Nova? Matt -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK)

2 1

[libvirt] [PATCH v4 0/8] NSS module for libvirt
by Michal Privoznik 08 Mar '16

08 Mar '16

v4 of: https://www.redhat.com/archives/libvir-list/2016-February/msg00693.html diff to v3: - Introduced yet another test to catch linkage problems - Extended nsstest to test multiple addresses - Reworked src/libvirt_nss.la CFLAGS/LDFLAGS - dropped some dependencies - Dropped checking for lease timestamp from nss plugin implementation as it's already done by lease parsing function Michal Privoznik (8): Export virLease* functions for leases file handling virjson: Resolve const correctness Initial support for NSS plugin skeleton libvirt.spec.in: Introduce libvirt-nss package nss: Implement _nss_libvirt_gethostbyname3_r Implement _nss_libvirt_gethostbyname4_r nss: Introduce a test tests: Introduce nsslinktest cfg.mk | 2 +- config-post.h | 24 +++ configure.ac | 2 + libvirt.spec.in | 21 ++ m4/virt-nss.m4 | 51 +++++ po/POTFILES.in | 1 + src/Makefile.am | 60 ++++++ src/libvirt_private.syms | 6 + src/network/leaseshelper.c | 271 +------------------------- src/util/virfile.c | 2 +- src/util/virjson.c | 58 +++--- src/util/virjson.h | 54 +++--- src/util/virlease.c | 304 +++++++++++++++++++++++++++++ src/util/virlease.h | 44 +++++ tests/Makefile.am | 31 ++- tests/nssdata/virbr0.status | 20 ++ tests/nssdata/virbr1.status | 14 ++ tests/nsslinktest.c | 39 ++++ tests/nssmock.c | 140 ++++++++++++++ tests/nsstest.c | 195 +++++++++++++++++++ tools/Makefile.am | 44 +++++ tools/nss/libvirt_nss.c | 463 ++++++++++++++++++++++++++++++++++++++++++++ tools/nss/libvirt_nss.h | 52 +++++ tools/nss/libvirt_nss.syms | 12 ++ 24 files changed, 1580 insertions(+), 330 deletions(-) create mode 100644 m4/virt-nss.m4 create mode 100644 src/util/virlease.c create mode 100644 src/util/virlease.h create mode 100644 tests/nssdata/virbr0.status create mode 100644 tests/nssdata/virbr1.status create mode 100644 tests/nsslinktest.c create mode 100644 tests/nssmock.c create mode 100644 tests/nsstest.c create mode 100644 tools/nss/libvirt_nss.c create mode 100644 tools/nss/libvirt_nss.h create mode 100644 tools/nss/libvirt_nss.syms -- 2.4.10

2 14

[libvirt] GSoC 2016
by Tahir Ramzan 08 Mar '16

08 Mar '16

Respected Sir, I am a MS CS scholar of Virtual University of Pakistan, I want to participate in GSoC 2016 for Libvirt. Data Science, Networks, Information security, digital forensics and ethical hacking are my core areas of interest. Currently, I am working on a research project on live forensics of GPU and volatile memories like RAMs and Caches. I am looking forward your guidance to start my contribution for Libvirt, thanks in anticipation. Regards Tahir Ramzan

4 4

[libvirt] ruby-libvirt mixed storage migration
by Tim Förster - Hetzner Online AG 08 Mar '16

08 Mar '16

Heyho guys, is there any reason why mixed storage migration is restriced. I am unable to serve parameter "migrate_disks" through #migrate_to_uri3. It looks like there is a missing macro here. http://libvirt.org/git/?p=ruby-libvirt.git;a=blob;f=ext/libvirt/domain.c#l3…. Could you please verify this? regrads, tim

2 3

[libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()
by Dan Williams 08 Mar '16

08 Mar '16

Not all lease values are mandatory, and when they aren't supplied by the libvirt driver they get set to NULL. That makes rb_str_new2() bail out. Signed-off-by: Dan Williams <dcbw(a)redhat.com> --- For example using the qemu driver we don't get 'iaid', and that makes ruby unhappy: [{"iface"=>"virbr1", "expirytime"=>1452189569, "type"=>0, "mac"=>"52:54:00:05:2b:6f", "ipaddr"=>"192.168.121.49", "prefix"=>24, "hostname"=>"openshiftdev", "clientid"=>"ff:00:05:2b:6f:00:01:00:01:1e:21:55:ed:52:54:00:05:2b:6f"}] ext/libvirt/network.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/ext/libvirt/network.c b/ext/libvirt/network.c index 7c77d73..c250d7d 100644 --- a/ext/libvirt/network.c +++ b/ext/libvirt/network.c @@ -269,14 +269,20 @@ static VALUE leases_wrap(VALUE arg) rb_hash_aset(hash, rb_str_new2("expirytime"), LL2NUM(lease->expirytime)); rb_hash_aset(hash, rb_str_new2("type"), INT2NUM(lease->type)); - rb_hash_aset(hash, rb_str_new2("mac"), rb_str_new2(lease->mac)); - rb_hash_aset(hash, rb_str_new2("iaid"), rb_str_new2(lease->iaid)); + if (lease->mac) + rb_hash_aset(hash, rb_str_new2("mac"), rb_str_new2(lease->mac)); + if (lease->iaid) + rb_hash_aset(hash, rb_str_new2("iaid"), rb_str_new2(lease->iaid)); rb_hash_aset(hash, rb_str_new2("ipaddr"), rb_str_new2(lease->ipaddr)); rb_hash_aset(hash, rb_str_new2("prefix"), UINT2NUM(lease->prefix)); - rb_hash_aset(hash, rb_str_new2("hostname"), - rb_str_new2(lease->hostname)); - rb_hash_aset(hash, rb_str_new2("clientid"), - rb_str_new2(lease->clientid)); + if (lease->hostname) { + rb_hash_aset(hash, rb_str_new2("hostname"), + rb_str_new2(lease->hostname)); + } + if (lease->clientid) { + rb_hash_aset(hash, rb_str_new2("clientid"), + rb_str_new2(lease->clientid)); + } rb_ary_store(result, i, hash); } -- 2.4.3

3 6

[libvirt] [PATCH] Fix minor typos in messages
by Yuri Chornoivan 08 Mar '16

08 Mar '16

Hi, Attached is a patch to fix minor typos in libvirt messages. Thanks for fixing them in the repo. By the way, libvirt template has not been updated for almost 1 year on Zanata. Are the translation moved into some new location? Thanks in advance for your answers. Best regards, Yuri

2 1

[libvirt] [PATCH v2 0/7] Fix and enhance statistics of a completed job
by Jiri Denemark 07 Mar '16

07 Mar '16

Jiri Denemark (7): qemu: Store completed stats at the very end of migration qemu: Properly update completed migration stats qemu: Don't explicitly stop CPUs after migration qemu: Fix a race when computing migration downtime qemu: Do not report completed stats until the job finishes Introduce job completed event qemu: Add support for job completed event daemon/remote.c | 38 ++++++++++++++++++ include/libvirt/libvirt-domain.h | 24 ++++++++++++ src/conf/domain_event.c | 85 +++++++++++++++++++++++++++++++++++++++- src/conf/domain_event.h | 10 +++++ src/libvirt-domain.c | 4 +- src/libvirt_private.syms | 2 + src/qemu/qemu_domain.c | 24 ++++++++++++ src/qemu/qemu_domain.h | 4 ++ src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_migration.c | 74 ++++++++++++++++++++++------------ src/qemu/qemu_process.c | 20 +++++++--- src/remote/remote_driver.c | 42 ++++++++++++++++++++ src/remote/remote_protocol.x | 14 ++++++- src/remote_protocol-structs | 9 +++++ tools/virsh-domain.c | 25 ++++++++++++ 15 files changed, 344 insertions(+), 35 deletions(-) -- 2.7.2

2 16