- Devel - libvirt List Archives

[libvirt] Hello and a question about QEMU log
by zhukaijie 01 Apr '16

01 Apr '16

Hello,Each running VM has it's command line logged in /var/log/libvirt/qemu/${vmname}.And now I'd like to disable this log function, that is to say, not to recordthe QEMU command line of VM. Could you please tell me will can I configure it? Are there any configure info such as "log level" to coordinate this log function? In fact, once the qemu command line contains some sensitive info which I try to prevent others from see it, I can make the qemu command not to be logged.

2 1

[libvirt] [For 1.3.3 0/2] small fixes for recent libxl commits
by Jim Fehlig 01 Apr '16

01 Apr '16

For 1.3.3: small fixes for recent libxl commits Chunyan noted some problems in commits e6336442 and b5534e53 https://www.redhat.com/archives/libvir-list/2016-March/msg01431.html These two patches fix those issues, essentially making e6336442 and b5534e53 resemble the correct patches originally submitted by Chunyan. See the individual patches for details. With these fixes, Chunyan's patch to "support creating domain with VF assignment from a pool" [0] works fine, save a bug or two in xen-unstable libxl. The patch has been through several revisions and on the list for quite some time. Would it be okay to commit it, along with these patches, for 1.3.3? [0] https://www.redhat.com/archives/libvir-list/2016-March/msg00930.html Jim Fehlig (2): libxl: fix attaching net device of type hostdev libxl: fix net device detach src/libxl/libxl_driver.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) -- 2.6.1

2 5

[libvirt] [PATCH 0/2] Couple of Coverity fixes
by Michal Privoznik 31 Mar '16

31 Mar '16

*** SOME BLURB HERE *** Michal Privoznik (2): virPerfReadEvent: Prefer saferead over read qemuProcessVerifyGuestCPU: Avoid coverity false positive src/qemu/qemu_process.c | 2 ++ src/util/virperf.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.7.3

3 6

[libvirt] build: workaround broken SASL header (again)
by Fabiano Fidêncio 31 Mar '16

31 Mar '16

Compilation for xdg-app failed due to a buggy SASL headers present on the used runtime (org.gnome.Sdk 3.18). In file included from rpc/virnetsaslcontext.h:24:0, from rpc/virnetsaslcontext.c:25: /usr/include/sasl/sasl.h:230:38: error: unknown type name 'size_t' typedef void *sasl_realloc_t(void *, size_t); ^ /usr/include/sasl/sasl.h:235:5: error: unknown type name 'sasl_realloc_t' sasl_realloc_t *, --- src/rpc/virnetsaslcontext.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsaslcontext.h b/src/rpc/virnetsaslcontext.h index 54634d5..edc082f 100644 --- a/src/rpc/virnetsaslcontext.h +++ b/src/rpc/virnetsaslcontext.h @@ -21,9 +21,9 @@ #ifndef __VIR_NET_CLIENT_SASL_CONTEXT_H__ # define __VIR_NET_CLIENT_SASL_CONTEXT_H__ +# include "internal.h" # include <sasl/sasl.h> -# include "internal.h" # include "virobject.h" typedef struct _virNetSASLContext virNetSASLContext; -- 2.7.3

2 1

[libvirt] [PATCH] spec: fix trigger already defined issue on systems without systemd
by Jean-Marc LIGER 31 Mar '16

31 Mar '16

There is a trigger already defined issue when you try to rebuild libvirt >= 1.3.0 for el6 with copr and most probably koji. Regards, Jean-Marc diff -uri a/libvirt.spec.in b/libvirt.spec.in --- a/libvirt.spec.in 2016-03-01 04:21:48.000000000 +0100 +++ b/libvirt.spec.in 2016-03-11 14:57:43.347652313 +0100 @@ -1767,16 +1767,6 @@ fi %endif - %if %{with_systemd} - %else -%triggerpostun daemon -- libvirt-daemon < 1.2.1 -if [ "$1" -ge "1" ]; then - /sbin/service virtlockd reload > /dev/null 2>&1 || : - /sbin/service virtlogd reload > /dev/null 2>&1 || : - /sbin/service libvirtd condrestart > /dev/null 2>&1 -fi - %endif - # In upgrade scenario we must explicitly enable virtlockd/virtlogd # sockets, if libvirtd is already enabled and start them if # libvirtd is running, otherwise you'll get failures to start @@ -1789,6 +1779,12 @@ /bin/systemctl is-active libvirtd.service 1>/dev/null 2>&1 && /bin/systemctl start virtlogd.socket || : %else + %triggerpostun daemon -- libvirt-daemon < 1.2.1 + if [ "$1" -ge "1" ]; then + /sbin/service virtlockd reload > /dev/null 2>&1 || : + /sbin/service virtlogd reload > /dev/null 2>&1 || : + /sbin/service libvirtd condrestart > /dev/null 2>&1 + fi /sbin/chkconfig libvirtd 1>/dev/null 2>&1 && /sbin/chkconfig virtlogd on || : /sbin/service libvirtd status 1>/dev/null 2>&1 &&

2 2

[libvirt] [PATCH 0/7] docs: Some website tweaks
by Andrea Bolognani 31 Mar '16

31 Mar '16

Basically, the navigation menu is *way* too big, and takes the focus away from the actual content. Plus it's very easy for longish words to overflow it (see "Authentication" in the screenshots below). The headers are probably bigger than needed as well, so I've scaled them down. Using Wikipedia for comparison, you can see the new size is more comparable to what they use. Some other minor cleanups have been included as well. Before[1] and after[2] screenshots for your convenience. Cheers. [1] http://i.imgur.com/MZchAWD.png [2] http://i.imgur.com/BXepLTh.png Andrea Bolognani (7): docs: Adjust vertical whitespace in CSS docs: Remove empty CSS rule docs: Don't use <strong> in headers docs: Make menu entries smaller docs: Don't use bold text for menu entries docs: Use bold text for all headers docs: Make most headers a bit smaller docs/apps.html.in | 2 +- docs/generic.css | 15 +++++++++------ docs/libvirt.css | 30 ++++++------------------------ 3 files changed, 16 insertions(+), 31 deletions(-) -- 2.5.5

2 9

[libvirt] [PATCH] remote: Add flags to remote_protocol-structs
by Martin Kletzander 31 Mar '16

31 Mar '16

Caused by 3b6c8185328f. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed under the 'build-breaker' rule. src/remote_protocol-structs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/remote_protocol-structs b/src/remote_protocol-structs index 1257aac51dfb..6dddd52ab116 100644 --- a/src/remote_protocol-structs +++ b/src/remote_protocol-structs @@ -310,9 +310,11 @@ struct remote_domain_set_perf_events_args { u_int params_len; remote_typed_param * params_val; } params; + u_int flags; }; struct remote_domain_get_perf_events_args { remote_nonnull_domain dom; + u_int flags; }; struct remote_domain_get_perf_events_ret { struct { -- 2.8.0

1 0

[libvirt] libvirt python binding and strange errors in logs
by Vasiliy Tolstov 31 Mar '16

31 Mar '16

I'm use libvirt-python binding to export some metrics to ganglia from libvirt. python code http://paste.debian.net/422944/ when this script is running i get many erros in libvirtd.log like this: error : virNetSocketReadWire:1613 : End of file while reading data: Input/output error При этом открывается сокет: virNetSocketNew:277 : RPC_SOCKET_NEW: sock=0x7fced8036ae0 fd=27 errfd=-1 pid=0 localAddr=::1;16509, remoteAddr=::1;39962 As i understand libvirt try to determine client alive and fails, my code properly close libvirt connection, but may be it not freed? Or something else broken with my code? i'm use libvirt-python from 1.2.1 to 1.2.9 and libvirt from 1.3.0 to 1.3.3 -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

1 1

[libvirt] [PATCH] virDomain{Get, Set}PerfEvents: Tweak documentation
by Michal Privoznik 31 Mar '16

31 Mar '16

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/libvirt-domain.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 3e144b6..4f473c9 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -9695,11 +9695,13 @@ virDomainOpenChannel(virDomainPtr dom, * @domain: a domain object * @params: where to store perf events setting * @nparams: number of items in @params - * @flags: extra flags; not used yet, so callers should always pass 0 + * @flags: bitwise-OR of virDomainModificationImpact * - * Get all perf events setting. Possible fields returned in @params are - * defined by VIR_DOMAIN_PERF_* macros and new fields will likely be - * introduced in the future. + * Get all Linux perf events setting. Possible fields returned in + * @params are defined by VIR_PERF_EVENT_* macros and new fields + * will likely be introduced in the future. + * + * Linux perf events are performance analyzing tool in Linux. * * Returns -1 in case of failure, 0 in case of success. */ @@ -9743,9 +9745,13 @@ int virDomainGetPerfEvents(virDomainPtr domain, * @params: pointer to perf events parameter object * @nparams: number of perf event parameters (this value can be the same * less than the number of parameters supported) - * @flags: extra flags; not used yet, so callers should always pass 0 + * @flags: bitwise-OR of virDomainModificationImpact * - * Enable or disable the particular list of perf events you care about. + * Enable or disable the particular list of Linux perf events you + * care about. The @params argument should contain any subset of + * VIR_PERF_EVENT_ macros. + * + * Linux perf events are performance analyzing tool in Linux. * * Returns -1 in case of error, 0 in case of success. */ -- 2.7.3

1 0

[libvirt] [PATCH v4 0/5] migration: add multithread compression
by Nikolay Shirokovskiy 31 Mar '16

31 Mar '16

Add means to turn multithread compression on during migration. Add means to pass compression parameters in migration command. Changes from v3 =============== 1. HMP support is dropped. 2. Switch to a different implementation of setting migration parameters. Version 3 sets all parameters when configuring migration compression. If parameter is not specified explicitly it is set to hardcoded default value. New version set only explicitly specified parameters instead. This has some reproducibility drawbacks which are nevertheless could be overcomed and this issue will be addressed in another series. 3. Unspecified values are presented by bitset fields rather then specific values of parameters itself. This is a bit more tedious implementation to use but if we take it we can pass all parameter values checking to QEMU. 4. Misc minor changes on Jiri comments. Eli Qiao (1): qemumonitorjsontest: add test for getting multithread compress params Nikolay Shirokovskiy (2): migration: add compress method option qemu: migration: add compression options ShaoHe Feng (2): qemu monitor: add multithread compress parameters accessors virsh: add compression options for migration include/libvirt/libvirt-domain.h | 44 +++++++ src/qemu/qemu_driver.c | 29 ++++- src/qemu/qemu_migration.c | 246 ++++++++++++++++++++++++++++++++++----- src/qemu/qemu_migration.h | 30 +++++ src/qemu/qemu_monitor.c | 24 +++- src/qemu/qemu_monitor.h | 18 +++ src/qemu/qemu_monitor_json.c | 110 +++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 + tests/qemumonitorjsontest.c | 53 +++++++++ tools/virsh-domain.c | 83 +++++++++++++ tools/virsh.pod | 25 +++- 11 files changed, 628 insertions(+), 39 deletions(-) -- 1.8.3.1

3 20

[libvirt] [PATCH] host-validate: Improve CPU flags processing
by Andrea Bolognani 31 Mar '16

31 Mar '16

Instead of relying on substring search, tokenize the input and process each CPU flag separately. This ensures CPU flag detection will continue to work correctly even if we start looking for CPU flags whose name might appear as part of other CPU flags' names. The result of processing is stored in a virBitmap, which means we don't have to parse /proc/cpuinfo in its entirety for each single CPU flag we want to check. Moreover, use of the newly-introduced virHostValidateCPUFlag enumeration ensures we don't go looking for random CPU flags which might actually be simple typos. --- The concern was raised by John in https://www.redhat.com/archives/libvir-list/2016-March/msg01301.html when discussing a new check on the "sie" CPU flag. tools/virt-host-validate-common.c | 50 +++++++++++++++++++++++++++++---------- tools/virt-host-validate-common.h | 13 +++++++++- tools/virt-host-validate-qemu.c | 12 ++++++++-- 3 files changed, 60 insertions(+), 15 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 8ebf73e..57fa332 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -31,7 +31,6 @@ #endif /* HAVE_MNTENT_H */ #include <sys/stat.h> -#include "virutil.h" #include "viralloc.h" #include "virfile.h" #include "virt-host-validate-common.h" @@ -39,6 +38,10 @@ #define VIR_FROM_THIS VIR_FROM_NONE +VIR_ENUM_IMPL(virHostValidateCPUFlag, VIR_HOST_VALIDATE_CPU_FLAG_LAST, + "vmx", + "svm"); + static bool quiet; void virHostMsgSetQuiet(bool quietFlag) @@ -188,29 +191,47 @@ int virHostValidateNamespace(const char *hvname, } -bool virHostValidateHasCPUFlag(const char *name) +virBitmapPtr virHostValidateGetCPUFlags(void) { - FILE *fp = fopen("/proc/cpuinfo", "r"); - bool ret = false; + FILE *fp; + virBitmapPtr flags; - if (!fp) - return false; + if (!(fp = fopen("/proc/cpuinfo", "r"))) + return NULL; + + if (!(flags = virBitmapNewQuiet(VIR_HOST_VALIDATE_CPU_FLAG_LAST))) + return NULL; do { char line[1024]; + char *saveptr; + char *token; if (!fgets(line, sizeof(line), fp)) break; - if (strstr(line, name)) { - ret = true; - break; + if (!(token = strtok_r(line, " \t\n", &saveptr))) + continue; + + /* The line we're interested in is marked either as "flags" or + * as "Features" depending on the architecture, so check both + * prefixes. It's very unlikely that there will be no whitespace + * between the line name and the colon, but handle that as well */ + if (strcmp(token, "flags") && strcmp(token, "flags:") && + strcmp(token, "Features") && strcmp(token, "Features:")) + continue; + + while ((token = strtok_r(NULL, " \t\n", &saveptr))) { + int value; + + if ((value = virHostValidateCPUFlagTypeFromString(token)) >= 0) + ignore_value(virBitmapSetBit(flags, value)); } } while (1); VIR_FORCE_FCLOSE(fp); - return ret; + return flags; } @@ -359,15 +380,20 @@ int virHostValidateCGroupController(const char *hvname, int virHostValidateIOMMU(const char *hvname, virHostValidateLevel level) { + virBitmapPtr flags; struct stat sb; const char *bootarg = NULL; bool isAMD = false, isIntel = false; - if (virHostValidateHasCPUFlag("vmx")) + flags = virHostValidateGetCPUFlags(); + + if (flags && virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX)) isIntel = true; - else if (virHostValidateHasCPUFlag("svm")) + else if (flags && virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SVM)) isAMD = true; + virBitmapFree(flags); + virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); if (isIntel) { diff --git a/tools/virt-host-validate-common.h b/tools/virt-host-validate-common.h index d4c4759..26e006b 100644 --- a/tools/virt-host-validate-common.h +++ b/tools/virt-host-validate-common.h @@ -23,6 +23,8 @@ # define __VIRT_HOST_VALIDATE_COMMON_H__ # include "internal.h" +# include "virutil.h" +# include "virbitmap.h" typedef enum { VIR_HOST_VALIDATE_FAIL, @@ -32,6 +34,15 @@ typedef enum { VIR_HOST_VALIDATE_LAST, } virHostValidateLevel; +typedef enum { + VIR_HOST_VALIDATE_CPU_FLAG_VMX = 0, + VIR_HOST_VALIDATE_CPU_FLAG_SVM, + + VIR_HOST_VALIDATE_CPU_FLAG_LAST, +} virHostValidateCPUFlag; + +VIR_ENUM_DECL(virHostValidateCPUFlag); + extern void virHostMsgSetQuiet(bool quietFlag); extern void virHostMsgCheck(const char *prefix, @@ -53,7 +64,7 @@ extern int virHostValidateDeviceAccessible(const char *hvname, virHostValidateLevel level, const char *hint); -extern bool virHostValidateHasCPUFlag(const char *name); +extern virBitmapPtr virHostValidateGetCPUFlags(void); extern int virHostValidateLinuxKernel(const char *hvname, int version, diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c index a9f6c1e..b96b020 100644 --- a/tools/virt-host-validate-qemu.c +++ b/tools/virt-host-validate-qemu.c @@ -24,14 +24,20 @@ #include "virt-host-validate-qemu.h" #include "virt-host-validate-common.h" +#include "virbitmap.h" int virHostValidateQEMU(void) { + virBitmapPtr flags; int ret = 0; virHostMsgCheck("QEMU", "%s", ("for hardware virtualization")); - if (virHostValidateHasCPUFlag("svm") || - virHostValidateHasCPUFlag("vmx")) { + + flags = virHostValidateGetCPUFlags(); + + if (flags && + (virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_SVM) || + virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX))) { virHostMsgPass(); if (virHostValidateDeviceExists("QEMU", "/dev/kvm", VIR_HOST_VALIDATE_FAIL, @@ -48,6 +54,8 @@ int virHostValidateQEMU(void) _("Only emulated CPUs are available, performance will be significantly limited")); } + virBitmapFree(flags); + if (virHostValidateDeviceExists("QEMU", "/dev/vhost-net", VIR_HOST_VALIDATE_WARN, _("Load the 'vhost_net' module to improve performance " -- 2.5.5

2 4

[libvirt] [PATCH 0/6] Couple of perf events APIs fixes
by Michal Privoznik 31 Mar '16

31 Mar '16

I really like to see these in before release and thus APIs get written in the stone. One note though regarding the last patch: while writing it I've noticed couple of other getter APIs don't grab any job at all. I think they should grab _QUERY job though. So maybe those will need some fixing too. Michal Privoznik (6): remoteDomainGetPerfEvents: Re-indent virDomain{Get,Set}PerfEvents: Add @flags argument virsh: Prefer VIRSH_COMMON_OPT_DOMAIN_FULL over full enumeration virsh: Make perf accept event list separated by commas virDomain{Get,Set}PerfEvents: support --config --live --current virDomain{Get,Set}PerfEvents: Grab job daemon/remote.c | 2 +- include/libvirt/libvirt-domain.h | 6 ++- src/driver-hypervisor.h | 6 ++- src/libvirt-domain.c | 22 +++++---- src/qemu/qemu_driver.c | 99 +++++++++++++++++++++++++++++----------- src/remote/remote_driver.c | 12 +++-- src/remote/remote_protocol.x | 2 + tools/virsh-domain.c | 27 +++++++---- tools/virsh.pod | 25 ++++++---- 9 files changed, 141 insertions(+), 60 deletions(-) -- 2.7.3

2 13

[libvirt] Join
by Tim Streit 31 Mar '16

31 Mar '16

Im having problems with my install. Debian Jessie (8.3), but using libvirt and kernel from back ports (for enhanced vt-d support, passing through a USB card). Guest is a windows xp sp3 box. Initially I had hardware time set to UTC, and I set the RealTimeIsUtc=1 in the registry. But it would periodically reset itself ahead 6 hours (CST), and since we just changed day light savings time now its jumping 5 hours. Every morning. I have a similarly configured system running a win7 guest, time works fine. Someone on #kvm suggested that maybe I need to set my hwclock to local time, and so I went through all that - changed it, appended LOCAL to /etc/adjtime etc. I then changed the RealTimeIsUtc=0, and for the first boot it seemed okay. Now, whenever I boot, it is constantly 5 hours ahead. I can reset it but when you reboot, its back. Im stumped. Help...

2 1

Re: [libvirt] [PATCH V4 4/6] libxl: support creating domain with VF assignment from a pool
by Jim Fehlig 31 Mar '16

31 Mar '16

On 03/30/2016 03:38 AM, Chun Yan Liu wrote: > >>>> On 3/29/2016 at 08:05 AM, in message <56F9C6D0.5000702(a)suse.com>, Jim Fehlig > <jfehlig(a)suse.com> wrote: >> On 03/21/2016 02:11 AM, Chunyan Liu wrote: >>> Add codes to support creating domain with network defition of assigning >>> SRIOV VF from a pool. >>> >>> Signed-off-by: Chunyan Liu <cyliu(a)suse.com> >>> --- >>> src/libxl/libxl_domain.c | 50 >> ++++++++++++++++++++++++++++++++++++++++++++++++ >>> tests/Makefile.am | 3 +++ >>> 2 files changed, 53 insertions(+) >>> >>> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c >>> index c8d09b1..d11bf3a 100644 >>> --- a/src/libxl/libxl_domain.c >>> +++ b/src/libxl/libxl_domain.c >>> @@ -36,6 +36,7 @@ >>> #include "virtime.h" >>> #include "locking/domain_lock.h" >>> #include "xen_common.h" >>> +#include "network/bridge_driver.h" >>> >>> #define VIR_FROM_THIS VIR_FROM_LIBXL >>> >>> @@ -764,6 +765,10 @@ libxlDomainCleanup(libxlDriverPrivatePtr driver, >>> if (net->ifname && >>> STRPREFIX(net->ifname, LIBXL_GENERATED_PREFIX_XEN)) >>> VIR_FREE(net->ifname); >>> + >>> + /* cleanup actual device */ >>> + virDomainNetRemoveHostdev(vm->def, net); >>> + networkReleaseActualDevice(vm->def, net); >>> } >>> } >>> >>> @@ -960,6 +965,48 @@ libxlDomainCreateIfaceNames(virDomainDefPtr def, >> libxl_domain_config *d_config) >>> } >>> } >>> >>> +static int >>> +libxlNetworkPrepareDevices(virDomainDefPtr def) >>> +{ >>> + int ret = -1; >>> + size_t i; >>> + >>> + for (i = 0; i < def->nnets; i++) { >>> + virDomainNetDefPtr net = def->nets[i]; >>> + int actualType; >>> + >>> + /* If appropriate, grab a physical device from the configured >>> + * network's pool of devices, or resolve bridge device name >>> + * to the one defined in the network definition. >>> + */ >>> + if (networkAllocateActualDevice(def, net) < 0) >>> + goto cleanup; >>> + >>> + actualType = virDomainNetGetActualType(net); >>> + if (actualType == VIR_DOMAIN_NET_TYPE_HOSTDEV && >>> + net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { >>> + /* Each type='hostdev' network device must also have a >>> + * corresponding entry in the hostdevs array. For netdevs >>> + * that are hardcoded as type='hostdev', this is already >>> + * done by the parser, but for those allocated from a >>> + * network / determined at runtime, we need to do it >>> + * separately. >>> + */ >>> + virDomainHostdevDefPtr hostdev = >> virDomainNetGetActualHostdev(net); >>> + virDomainHostdevSubsysPCIPtr pcisrc = >> &hostdev->source.subsys.u.pci; >>> + >>> + if (hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && >>> + hostdev->source.subsys.type == >> VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) >>> + pcisrc->backend = VIR_DOMAIN_HOSTDEV_PCI_BACKEND_XEN; >>> + >>> + if (virDomainHostdevInsert(def, hostdev) < 0) >>> + goto cleanup; >>> + } >>> + } >>> + ret = 0; >>> + cleanup: >>> + return ret; >> >> Nothing to cleanup here. I think we should just return -1 on failure paths >> and 0 >> on success. >> >>> +} >>> >>> /* >>> * Start a domain through libxenlight. >>> @@ -1036,6 +1083,9 @@ libxlDomainStart(libxlDriverPrivatePtr driver, >> virDomainObjPtr vm, >>> vm, true) < 0) >>> goto cleanup; >>> >>> + if (libxlNetworkPrepareDevices(vm->def) < 0) >>> + goto cleanup; >> >> I accessed a machine to test this series and have found a few problems. >> >> 1. When attaching an SR-IOV vf from a pool, the attach appears successful. >> I see that xen's pciback driver is bound to the device in the host. I >> didn't see the device in the guest (could be a guest problem), > For pv guest, from testing, it is shown in guest. For HVM, seems > xl pci-attach has the same result. Yes, I'm seeing the same thing. Looks like a bug in libxl or qemu. >> nor in >> dumpxml or /var/run/libvirt/libxl/<dom-name>.xml. > Ah, there is a mistake during a review change to original patch 1/6. > Didn't notice that earlier. > > In libxlDomainAttachNetDevice: > The if (!ret) is needed, maybe cleanup is not proper. > Since for actual type is hostdev case, after a successful > libxlDomainAttachHostDevice, we need to > update vm->def->nets too. > > cleanup: > libxl_device_nic_dispose(&nic); > - out: > - if (!ret) > + if (!ret) { > vm->def->nets[vm->def->nnets++] = net; > + } else { > + virDomainNetRemoveHostdev(vm->def, net); > + networkReleaseActualDevice(vm->def, net); > + } > > Similar for libxDomainDetachNetDevice cleanup: > Original is still needed. > > cleanup: > libxl_device_nic_dispose(&nic); > - if (!ret) > + if (!ret) { > + networkReleaseActualDevice(vm->def, detach); > virDomainNetRemove(vm->def, detachidx); > + } Yikes! I should have looked at the code closer before making those changes - lesson learned. I sent a small series to fix it https://www.redhat.com/archives/libvir-list/2016-March/msg01470.html >> Not surprisingly, >> this causes problems with device-detach >> >> # virsh detach-device dom sriov-pool-vif.xml >> error: Failed to detach device from sriov-pool-vif.xml >> error: operation failed: no device matching mac address 00:16:3e:7a:35:df >> found >> >> 2. After starting a domain containing an interface from sr-iov vf pool, the >> interface xml is changed from type='network' to type='hostdev'. E.g. >> before creating domain >> >> <interface type='network'> >> <source network='passthrough'/> >> <mac address='00:16:3e:7a:35:df'/> >> </interface> >> >> after creating domain >> >> <interface type='hostdev' managed='yes'> >> <mac address='00:16:3e:7a:35:df'/> >> <driver name='xen'/> >> <source> >> <address type='pci' domain='0x0000' bus='0x0a' slot='0x11' >> function='0x1'/> >> </source> >> </interface> >> >> Maybe this is intended behavior, but it seems odd. > This is intended. > >> >> 3. I started a domain containing an interface from sr-iov vf pool. Looks >> good. I then tried 'virsh detach-device ...', which never returned >> until keepalive timeout. The device was removed from the guest, but >> libvirtd got hung up in the process. Oddly, I wasn't able to interrupt >> libvirtd with gdb to see what its threads were doing. > This is libxl problem. With xl pci-detach, it has the same issue. Yep, another bug in xen-unstable libxl. With the small fixes in the series I mentioned above, this patch looks and tests good :-). Since it has been around for quite some time, I've asked for permission to commit it even though we are in 1.3.3 freeze. Regards, Jim

1 0

[libvirt] [PATCH 0/3] qemu: fix automatic NUMA pinning with memory hotplug
by Peter Krempa 31 Mar '16

31 Mar '16

We forgot to propagate the automatic nodeset and reported non-ideal errors. Peter Krempa (3): qemu: command: Pass numad nodeset when formatting memory devices at boot qemu: command: Split up formatting of -numa and memory devices qemu: hotplug: Improve error when hotpluging memory with auto-placement src/conf/numa_conf.c | 20 +++++++++++++++++--- src/conf/numa_conf.h | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 27 ++++++++++++++------------- src/qemu/qemu_hotplug.c | 7 +++++++ 5 files changed, 40 insertions(+), 16 deletions(-) -- 2.7.3

2 5

[libvirt] [PATCH v7 0/4] ARM: add query-gic-capabilities QMP command
by Peter Xu 30 Mar '16

30 Mar '16

v7 changes: - patch 1 - add more to commit log, about how to use the results [Markus] - change interface from dict back to array [Markus, Eric] - patch 2 - kvm_arm_create_scratch_host_vcpu should raise error when init non-zero, but failed to find a good CPU model [Sergey] - patch 3 - rename function to kvm_device_supported [Sergey] - patch 4 - comment line from "FIXME" to "TODO" [Sergey] - make kvm-related part another function [Sergey] - change result to array to follow patch 1's change v6 changes: - patch 1 (squashed into patch 2) - explain more about the following in commit message: why we need this command, and what does the entries mean [Markus] - explain what GIC is [Eric] - squash this patch into patch 2 [Eric] - patch 2 (new patch 1) - fix "does not implement" english error [Eric] - remove useless headers in target-arm/monitor.c [Markus] - remove this command from whitelist [Markus, Eric] - return dict rather than array, with single key points to the original array results [Markus, Eric] - patch 5 (new patch 4) - tiny change in implementation to suite the new interface. v5 changes: - patch 2: moved to target-arm/monitor.c (from target-arm/machine.c) [Peter] - patch 3: splitted into three patches: [all from Peter's comments] - patch 3 (new): leverage kvm_arm_create_scratch_host_vcpu(), tiny enhancement of old one to suite our need - patch 4: introduce kvm_support_device() in kvm-all.c - patch 5: do the implementation. v4 changes: - all: rename query-gic-capability to query-gic-capabilities [Andrea] - patch 3: rename helper function to kvm_support_device, make it inline and lighter. [Drew] v3 changes: - patch 2: remove func declaration, add qmp header [Drew] - patch 3: being able to detect KVM GIC capabilities even without kvm enabled [Andrea]: this is a little bit hacky, need some more review on this. v2 changes: - result layout change: use array and dict for the capability bits rather than a single array of strings [Andrea/Markus] - spelling out what GIC is in doc [Eric] This patch is to add ARM-specific command "query-gic-capability". The new command can report which kind of GIC device the host/QEMU support. The returned result is in the form of array. Sample command and output: {"execute": "query-gic-capability"} {"return": [{"emulated": false, "version": 3, "kernel": false}, {"emulated": true, "version": 2, "kernel": true}]} Testing: Smoke tests on both x86 (emulated) and another moonshot ARM server. Peter Xu (4): arm: qmp: add query-gic-capabilities interface arm: enhance kvm_arm_create_scratch_host_vcpu kvm: add kvm_device_supported() helper function arm: implement query-gic-capabilities include/sysemu/kvm.h | 9 ++++++ kvm-all.c | 15 +++++++++ monitor.c | 8 +++++ qapi-schema.json | 36 +++++++++++++++++++++ qmp-commands.hx | 27 ++++++++++++++++ target-arm/Makefile.objs | 2 +- target-arm/kvm.c | 14 +++++++- target-arm/kvm_arm.h | 6 ++-- target-arm/monitor.c | 84 ++++++++++++++++++++++++++++++++++++++++++++++++ 9 files changed, 197 insertions(+), 4 deletions(-) create mode 100644 target-arm/monitor.c -- 2.4.3

5 12

[libvirt] [PATCH] docs: Don't use bold text in headers and menu items
by Andrea Bolognani 30 Mar '16

30 Mar '16

Now that headers and menu items are using a bigger font and more generous spacing, they don't really need to be bold to stand out. --- This applies on top of Cole's series https://www.redhat.com/archives/libvir-list/2016-March/msg00323.html docs/apps.html.in | 2 +- docs/generic.css | 2 +- docs/libvirt.css | 11 +---------- 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/docs/apps.html.in b/docs/apps.html.in index 39fb78d..b8337b9 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -2,7 +2,7 @@ <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <body> - <h1>Applications using <strong>libvirt</strong></h1> + <h1>Applications using libvirt</h1> <p> This page provides an illustration of the wide variety of diff --git a/docs/generic.css b/docs/generic.css index e862fe0..94b9612 100644 --- a/docs/generic.css +++ b/docs/generic.css @@ -45,7 +45,7 @@ dl dd { h1, h2, h3, h4, h5, h6 { - font-weight: bold; + font-weight: normal; margin: 0px; padding: 0px; margin-top: 0.5em; diff --git a/docs/libvirt.css b/docs/libvirt.css index 17ecbb4..3b65f4c 100644 --- a/docs/libvirt.css +++ b/docs/libvirt.css @@ -1,12 +1,4 @@ -h1 { - font-weight: normal; - color: #3c857c; -} -h1 strong { - font-weight: bold; -} - -h2, h3, h4, h5, h6 { +h1, h2, h3, h4, h5, h6 { color: #3c857c; } @@ -55,7 +47,6 @@ h2, h3, h4, h5, h6 { padding: 0px; margin: 0px; border: 0px; - font-weight: bold; font-size: 1.2em; } -- 2.5.0

2 2

[libvirt] [PATCH v4 0/2] qemu: Support for QXL heads
by Martin Kletzander 30 Mar '16

30 Mar '16

v4: - Added test case without "heads=" - Don't consolidate 'size_t i, j' declarations v3: - https://www.redhat.com/archives/libvir-list/2016-March/msg01198.html - rebase on top of current master in order to cleanly apply v2: - don't change heads when migrating - https://www.redhat.com/archives/libvir-list/2016-March/msg00811.html v1: - https://www.redhat.com/archives/libvir-list/2016-March/msg00410.html Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 8 +++ src/qemu/qemu_migration.c | 64 ++++++++++++++++++++-- .../qemuhotplug-agent-nopath.xml | 5 ++ .../qemuhotplug-hotplug-base+agent-nopath.xml | 58 ++++++++++++++++++++ .../qemuxml2argv-video-qxl-heads.args | 28 ++++++++++ .../qemuxml2argv-video-qxl-heads.xml | 47 ++++++++++++++++ .../qemuxml2argv-video-qxl-noheads.args | 24 ++++++++ .../qemuxml2argv-video-qxl-noheads.xml | 39 +++++++++++++ tests/qemuxml2argvtest.c | 16 ++++++ .../qemuxml2xmlout-video-qxl-heads.xml | 47 ++++++++++++++++ .../qemuxml2xmlout-video-qxl-noheads.xml | 39 +++++++++++++ tests/qemuxml2xmltest.c | 3 + 14 files changed, 379 insertions(+), 5 deletions(-) create mode 100644 tests/qemuhotplugtestdata/qemuhotplug-agent-nopath.xml create mode 100644 tests/qemuhotplugtestdata/qemuhotplug-hotplug-base+agent-nopath.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-noheads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-noheads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-heads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-noheads.xml -- 2.8.0

1 3

[libvirt] [PATCH 0/3] some additional hyper-v features fixes
by Pavel Hrdina 30 Mar '16

30 Mar '16

Pavel Hrdina (3): docs: fix qemu version for hyperv features qemu_process: skip only cpu features qemu_process: add check for hyperv features docs/formatdomain.html.in | 4 ++-- src/cpu/cpu_x86.c | 8 +++++++ src/cpu/cpu_x86_data.h | 8 +++++++ src/qemu/qemu_process.c | 57 +++++++++++++++++++++++++++++++++++------------ 4 files changed, 61 insertions(+), 16 deletions(-) -- 2.7.4

4 12

[libvirt] [PATCH V4 0/6] libxl: support assign VF to guest from SRIOV pool
by Chunyan Liu 30 Mar '16

30 Mar '16

This patch series is to support assign VF to guest from SRIOV pool, including fixes to network attach/detach and fix to libxlDomainstart. Chunyan Liu (6): libxlDomainAttachNetDevice: release actual deivce and remove hostdev when fail libxlDomainDetachNetDevice: cleanup codes libxlDomainDetachDeviceLive: handle hostdev parent is network device libxl: support creating domain with VF assignment from a pool libxl: fix hot add/remove VF from a pool libxlDomainStart: correct cleanup after failure src/libxl/libxl_domain.c | 85 +++++++++++++++++++++++++++++++++++++++--------- src/libxl/libxl_driver.c | 52 ++++++++++++++++++++--------- tests/Makefile.am | 3 ++ 3 files changed, 108 insertions(+), 32 deletions(-) -- 2.1.4

3 15

[libvirt] [PATCH] host-validate: Fix suggestion for missing cpu cgroup
by Andrea Bolognani 30 Mar '16

30 Mar '16

If the cpu cgroup is not found when validating an host for LXC support, virt-host-validate will suggest to enable the CONFIG_CGROUP_SCHED kconfig option. The appropriate option is really CONFIG_CGROUP_CPU. The QEMU checks already get that right, so no changes needed. --- tools/virt-host-validate-lxc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virt-host-validate-lxc.c b/tools/virt-host-validate-lxc.c index 89a6388..2b906cc 100644 --- a/tools/virt-host-validate-lxc.c +++ b/tools/virt-host-validate-lxc.c @@ -70,7 +70,7 @@ int virHostValidateLXC(void) if (virHostValidateCGroupController("LXC", "cpu", VIR_HOST_VALIDATE_FAIL, - "CGROUP_SCHED") < 0) + "CGROUP_CPU") < 0) ret = -1; if (virHostValidateCGroupController("LXC", "cpuacct", -- 2.5.5

2 2

[libvirt] [PATCH v2] nss: FreeBSD support
by Roman Bogorodskiy 30 Mar '16

30 Mar '16

* tools/nss/libvirt_nss.[ch]: add BSD-comptabile wrappers and register via the nss_module_register() interface * m4/virt-nss.m4: add checks if we're building NSS for FreeBSD * tools/Makefile.am: handle target library name differences, as Linux needs libnss_libvirt.so.2 and FreeBSD needs nss_libvirt.so.1. Also, different syms files have to be used as Linux needs to export all the methods while FreeBSD only needs to have nss_module_register() * tests/nsstest.c, tests/nssmock.c: s/__linux__/NSS/ * libvirt_nss_bsd.syms: FreeBSD syms file --- m4/virt-nss.m4 | 18 +++++- tests/nssmock.c | 6 +- tests/nsstest.c | 2 +- tools/Makefile.am | 16 ++++- tools/nss/libvirt_nss.c | 139 +++++++++++++++++++++++++++++++++++++++-- tools/nss/libvirt_nss.h | 9 +++ tools/nss/libvirt_nss_bsd.syms | 9 +++ 7 files changed, 189 insertions(+), 10 deletions(-) create mode 100644 tools/nss/libvirt_nss_bsd.syms diff --git a/m4/virt-nss.m4 b/m4/virt-nss.m4 index 3fa4ad3..3d6e8f4 100644 --- a/m4/virt-nss.m4 +++ b/m4/virt-nss.m4 @@ -23,6 +23,7 @@ AC_DEFUN([LIBVIRT_CHECK_NSS],[ [enable Name Servie Switch plugin for resolving guest IP addresses])], [], [with_nss_plugin=check]) + bsd_nss=no fail=0 if test "x$with_nss_plugin" != "xno" ; then AC_CHECK_HEADERS([nss.h], [ @@ -39,11 +40,26 @@ AC_DEFUN([LIBVIRT_CHECK_NSS],[ if test "x$with_nss_plugin" = "xyes" ; then AC_DEFINE_UNQUOTED([NSS], 1, [whether nss plugin is enabled]) + + AC_CHECK_TYPE([struct gaih_addrtuple], + [AC_DEFINE([HAVE_STRUCT_GAIH_ADDRTUPLE], [1], + [Defined if struct gaih_addrtuple exists in nss.h])], + [], [[#include <nss.h> + ]]) + + AC_CHECK_TYPES([ns_mtab, nss_module_unregister_fn], + [AC_DEFINE([HAVE_BSD_NSS], + [1], + [whether using BSD style NSS]) + bsd_nss=yes + ], + [], + [#include <nsswitch.h>]) fi fi AM_CONDITIONAL(WITH_NSS, [test "x$with_nss_plugin" = "xyes"]) - + AM_CONDITIONAL(WITH_BSD_NSS, [test "x$bsd_nss" = "xyes"]) ]) AC_DEFUN([LIBVIRT_RESULT_NSS],[ diff --git a/tests/nssmock.c b/tests/nssmock.c index b4a4260..31b1177 100644 --- a/tests/nssmock.c +++ b/tests/nssmock.c @@ -20,7 +20,7 @@ #include <config.h> -#ifdef __linux__ +#ifdef NSS # include <stdio.h> # include <stdlib.h> # include <dlfcn.h> @@ -107,7 +107,7 @@ open(const char *path, int flags, ...) va_list ap; mode_t mode; va_start(ap, flags); - mode = va_arg(ap, mode_t); + mode = va_arg(ap, int); va_end(ap); ret = realopen(newpath ? newpath : path, flags, mode); } else { @@ -136,5 +136,5 @@ opendir(const char *path) return ret; } #else -/* Nothing to override on non-__linux__ platforms */ +/* Nothing to override if NSS plugin is not enabled */ #endif diff --git a/tests/nsstest.c b/tests/nsstest.c index 7399d9a..63c7162 100644 --- a/tests/nsstest.c +++ b/tests/nsstest.c @@ -22,7 +22,7 @@ #include "testutils.h" -#ifdef __linux__ +#ifdef NSS # include <stdbool.h> # include <arpa/inet.h> diff --git a/tools/Makefile.am b/tools/Makefile.am index 4320040..6005b8b 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -417,8 +417,22 @@ CLEANFILES += wireshark/src/plugin.c endif WITH_WIRESHARK_DISSECTOR +if WITH_BSD_NSS +LIBVIRT_NSS_SYMBOL_FILE = \ + $(srcdir)/nss/libvirt_nss_bsd.syms +NSS_SO_VER = 1 + +install-exec-hook: + cd $(DESTDIR)$(libdir) && \ + $(LN_S) libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER) + +uninstall-local: + rm $(DESTDIR)$(libdir)/libnss_libvirt.so.$(NSS_SO_VER) +else ! WITH_BSD_NSS LIBVIRT_NSS_SYMBOL_FILE = \ $(srcdir)/nss/libvirt_nss.syms +NSS_SO_VER = 2 +endif ! WITH_BSD_NSS LIBVIRT_NSS_SOURCES = \ nss/libvirt_nss.c \ @@ -449,7 +463,7 @@ nss_libnss_libvirt_la_LDFLAGS = \ -export-dynamic \ -avoid-version \ -shared \ - -shrext .so.2 + -shrext .so.$(NSS_SO_VER) nss_libnss_libvirt_la_LIBADD = \ nss/libnss_libvirt_impl.la diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c index 218c62a..de34baf 100644 --- a/tools/nss/libvirt_nss.c +++ b/tools/nss/libvirt_nss.c @@ -29,11 +29,16 @@ #include "libvirt_nss.h" +#include <netinet/in.h> #include <resolv.h> #include <sys/types.h> #include <dirent.h> #include <arpa/inet.h> +#if defined(HAVE_BSD_NSS) +# include <nsswitch.h> +#endif + #include "virlease.h" #include "viralloc.h" #include "virfile.h" @@ -65,7 +70,7 @@ do { \ #define LEASEDIR LOCALSTATEDIR "/lib/libvirt/dnsmasq/" -#define ALIGN(x) (((x) + __SIZEOF_POINTER__ - 1) & ~(__SIZEOF_POINTER__ - 1)) +#define LIBVIRT_ALIGN(x) (((x) + __SIZEOF_POINTER__ - 1) & ~(__SIZEOF_POINTER__ - 1)) #define FAMILY_ADDRESS_SIZE(family) ((family) == AF_INET6 ? 16 : 4) typedef struct { @@ -256,7 +261,7 @@ static inline void * move_and_align(void *buf, size_t len, size_t *idx) { char *buffer = buf; - size_t move = ALIGN(len); + size_t move = LIBVIRT_ALIGN(len); if (!idx) return buffer + move; @@ -321,7 +326,7 @@ _nss_libvirt_gethostbyname3_r(const char *name, int af, struct hostent *result, * b) alias * c) addresses * d) NULL stem */ - need = ALIGN(nameLen + 1) + naddr * ALIGN(alen) + (naddr + 2) * sizeof(char*); + need = LIBVIRT_ALIGN(nameLen + 1) + naddr * LIBVIRT_ALIGN(alen) + (naddr + 2) * sizeof(char*); if (buflen < need) { *errnop = ENOMEM; @@ -383,6 +388,7 @@ _nss_libvirt_gethostbyname3_r(const char *name, int af, struct hostent *result, return ret; } +#ifdef HAVE_STRUCT_GAIH_ADDRTUPLE enum nss_status _nss_libvirt_gethostbyname4_r(const char *name, struct gaih_addrtuple **pat, char *buffer, size_t buflen, int *errnop, @@ -426,7 +432,7 @@ _nss_libvirt_gethostbyname4_r(const char *name, struct gaih_addrtuple **pat, /* We need space for: * a) name * b) addresses */ - need = ALIGN(nameLen + 1) + naddr * ALIGN(sizeof(struct gaih_addrtuple)); + need = LIBVIRT_ALIGN(nameLen + 1) + naddr * LIBVIRT_ALIGN(sizeof(struct gaih_addrtuple)); if (buflen < need) { *errnop = ENOMEM; @@ -474,3 +480,128 @@ _nss_libvirt_gethostbyname4_r(const char *name, struct gaih_addrtuple **pat, cleanup: return ret; } +#endif /* HAVE_STRUCT_GAIH_ADDRTUPLE */ + +#if defined(HAVE_BSD_NSS) +NSS_METHOD_PROTOTYPE(_nss_compat_getaddrinfo); +NSS_METHOD_PROTOTYPE(_nss_compat_gethostbyname2_r); + +ns_mtab methods[] = { + { NSDB_HOSTS, "getaddrinfo", _nss_compat_getaddrinfo, NULL }, + { NSDB_HOSTS, "gethostbyname", _nss_compat_gethostbyname2_r, NULL }, + { NSDB_HOSTS, "gethostbyname2_r", _nss_compat_gethostbyname2_r, NULL }, +}; + +static void +aiforaf(const char *name, int af, struct addrinfo *pai, struct addrinfo **aip) +{ + int ret; + struct hostent resolved; + char buf[1024] = { 0 }; + int err, herr; + struct addrinfo hints, *res0, *res; + char **addrList; + + if ((ret = _nss_libvirt_gethostbyname2_r(name, af, &resolved, + buf, sizeof(buf), + &err, &herr)) != NS_SUCCESS) + return; + + addrList = resolved.h_addr_list; + while (*addrList) { + virSocketAddr sa; + char *ipAddr = NULL; + void *address = *addrList; + + memset(&sa, 0, sizeof(sa)); + if (resolved.h_addrtype == AF_INET) { + virSocketAddrSetIPv4AddrNetOrder(&sa, *((uint32_t *) address)); + } else { + virSocketAddrSetIPv6AddrNetOrder(&sa, address); + } + + ipAddr = virSocketAddrFormat(&sa); + + hints = *pai; + hints.ai_flags = AI_NUMERICHOST; + hints.ai_family = af; + + if (getaddrinfo(ipAddr, NULL, &hints, &res0)) { + addrList++; + continue; + } + + for (res = res0; res; res = res->ai_next) + res->ai_flags = pai->ai_flags; + + (*aip)->ai_next = res0; + while ((*aip)->ai_next) + *aip = (*aip)->ai_next; + + addrList++; + } +} + +int +_nss_compat_getaddrinfo(void *retval, void *mdata ATTRIBUTE_UNUSED, va_list ap) +{ + struct addrinfo sentinel, *cur, *ai; + const char *name; + + name = va_arg(ap, char *); + ai = va_arg(ap, struct addrinfo *); + + memset(&sentinel, 0, sizeof(sentinel)); + cur = &sentinel; + + if ((ai->ai_family == AF_UNSPEC) || (ai->ai_family == AF_INET6)) + aiforaf(name, AF_INET6, ai, &cur); + if ((ai->ai_family == AF_UNSPEC) || (ai->ai_family == AF_INET)) + aiforaf(name, AF_INET, ai, &cur); + + if (sentinel.ai_next == NULL) { + h_errno = HOST_NOT_FOUND; + return NS_NOTFOUND; + } + *((struct addrinfo **)retval) = sentinel.ai_next; + + return NS_SUCCESS; +} + +int +_nss_compat_gethostbyname2_r(void *retval, void *mdata ATTRIBUTE_UNUSED, va_list ap) +{ + int ret; + + const char *name; + int af; + struct hostent *result; + char *buffer; + size_t buflen; + int *errnop; + int *herrnop; + + name = va_arg(ap, const char *); + af = va_arg(ap, int); + result = va_arg(ap, struct hostent *); + buffer = va_arg(ap, char *); + buflen = va_arg(ap, size_t); + errnop = va_arg(ap, int *); + herrnop = va_arg(ap, int *); + + ret = _nss_libvirt_gethostbyname2_r( + name, af, result, buffer, buflen, errnop, herrnop); + *(struct hostent **)retval = (ret == NS_SUCCESS) ? result : NULL; + + return ret; +} + +ns_mtab* +nss_module_register(const char *name ATTRIBUTE_UNUSED, unsigned int *size, + nss_module_unregister_fn *unregister) +{ + *size = sizeof(methods) / sizeof(methods[0]); + *unregister = NULL; + return methods; +} +#endif /* HAVE_BSD_NSS */ diff --git a/tools/nss/libvirt_nss.h b/tools/nss/libvirt_nss.h index 589c1e6..e025e63 100644 --- a/tools/nss/libvirt_nss.h +++ b/tools/nss/libvirt_nss.h @@ -45,8 +45,17 @@ enum nss_status _nss_libvirt_gethostbyname3_r(const char *name, int af, struct hostent *result, char *buffer, size_t buflen, int *errnop, int *herrnop, int32_t *ttlp, char **canonp); +# ifdef HAVE_STRUCT_GAIH_ADDRTUPLE enum nss_status _nss_libvirt_gethostbyname4_r(const char *name, struct gaih_addrtuple **pat, char *buffer, size_t buflen, int *errnop, int *herrnop, int32_t *ttlp); +# endif /* HAVE_STRUCT_GAIH_ADDRTUPLE */ + +# if defined(HAVE_BSD_NSS) +ns_mtab* +nss_module_register(const char *name, unsigned int *size, + nss_module_unregister_fn *unregister); +# endif /* HAVE_BSD_NSS */ + #endif /* __LIBVIRT_NSS_H__ */ diff --git a/tools/nss/libvirt_nss_bsd.syms b/tools/nss/libvirt_nss_bsd.syms new file mode 100644 index 0000000..7da3926 --- /dev/null +++ b/tools/nss/libvirt_nss_bsd.syms @@ -0,0 +1,9 @@ +# +# Officially exported symbols. +# + +{ +global: + nss_module_register; +local: *; +}; -- 2.7.2

2 4

Re: [libvirt] [PATCH 3/3] libxl: only disable domain death events in libxlDomainCleanup
by Jim Fehlig 30 Mar '16

30 Mar '16

On 03/28/2016 07:36 PM, Chun Yan Liu wrote: > Reviewed-by: Chunyan Liu <cyliu(a)suse.com> Thanks for taking a look! I'm going to push this series since it just splits your previous patch, which I'm happy to ACK after the split :-). It is a nice cleanup and plugs potential resource leaks, so good stuff for the 1.3.3 release. Regards, Jim > >>>> On 3/29/2016 at 08:54 AM, in message > <1459212889-5490-4-git-send-email-jfehlig(a)suse.com>, Jim Fehlig > <jfehlig(a)suse.com> wrote: >> Remove disabling domain death events from libxlDomainStart error >> path. The domain death event is already disabled in libxlDomainCleanup. >> >> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> >> --- >> src/libxl/libxl_domain.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c >> index 068bfb6..04962a0 100644 >> --- a/src/libxl/libxl_domain.c >> +++ b/src/libxl/libxl_domain.c >> @@ -1144,10 +1144,6 @@ libxlDomainStart(libxlDriverPrivatePtr driver, >> virDomainObjPtr vm, >> >> destroy_dom: >> ret = -1; >> - if (priv->deathW) { >> - libxl_evdisable_domain_death(cfg->ctx, priv->deathW); >> - priv->deathW = NULL; >> - } >> libxlDomainDestroyInternal(driver, vm); >> vm->def->id = -1; >> virDomainObjSetState(vm, VIR_DOMAIN_SHUTOFF, >> VIR_DOMAIN_SHUTOFF_FAILED); > >

1 0

[libvirt] [PATCH 0/3] Decrease execution complexity of formating iothread scheduler info
by Peter Krempa 30 Mar '16

30 Mar '16

While refactoring the old way to store iothread scheduler info I've added an algorithm that isn't entirely optimal but allows to store the scheduler info in a sane way. Unfortunately when you specify an insane number of iothreads the code takes ages to execute. To avoid this series being completely useless except for the one corner case I've opted to finally add support for self expanding bitmaps, which might become useful in the future. The self-expanding bitmap is then used instead of one of the loops that was necessary to determine the maximum iothread ID. Peter Krempa (3): util: bitmap: Intoduce self-expanding bitmap APIs conf: decrease iterations complexity when formatting iothreads conf: Remove now unused virDomainIOThreadIDMap src/conf/domain_conf.c | 51 ++++++++++---------------- src/conf/domain_conf.h | 3 -- src/libvirt_private.syms | 4 ++- src/util/virbitmap.c | 93 ++++++++++++++++++++++++++++++++++++++++++++++++ src/util/virbitmap.h | 8 +++++ tests/virbitmaptest.c | 51 ++++++++++++++++++++++++++ 6 files changed, 173 insertions(+), 37 deletions(-) -- 2.7.3

3 6

[libvirt] [PATCH] bhyve: implement domainShutdown
by Roman Bogorodskiy 30 Mar '16

30 Mar '16

Bhyve supports ACPI shutdown by issuing SIGTERM signal to the bhyve process. Add the bhyveDomainShutdown() function and virBhyveProcessShutdown() helper function that just sends SIGTERM to VM's bhyve process. If a guest supports ACPI shutdown then process will be terminated and this event will be noticed by the bhyve monitor code that will handle setting proper status and clean up VM's resources. Also, remove a warning in domainDestroy in case if virProcessKillPainfully() returns 1, meaning that it killed process using SIGKILL. This behavior should be expected when using 'destroy'. --- src/bhyve/bhyve_driver.c | 27 +++++++++++++++++++++++++++ src/bhyve/bhyve_process.c | 30 ++++++++++++++++++++++++++---- src/bhyve/bhyve_process.h | 2 ++ 3 files changed, 55 insertions(+), 4 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 9219890..b9eacb9 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1018,6 +1018,32 @@ bhyveDomainDestroy(virDomainPtr dom) } static int +bhyveDomainShutdown(virDomainPtr dom) +{ + virDomainObjPtr vm; + int ret = -1; + + if (!(vm = bhyveDomObjFromDomain(dom))) + goto cleanup; + + if (virDomainShutdownEnsureACL(dom->conn, vm->def) < 0) + goto cleanup; + + if (!virDomainObjIsActive(vm)) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("Domain is not running")); + goto cleanup; + } + + ret = virBhyveProcessShutdown(vm); + + cleanup: + if (vm) + virObjectUnlock(vm); + return ret; +} + +static int bhyveDomainOpenConsole(virDomainPtr dom, const char *dev_name ATTRIBUTE_UNUSED, virStreamPtr st, @@ -1507,6 +1533,7 @@ static virHypervisorDriver bhyveHypervisorDriver = { .domainCreateWithFlags = bhyveDomainCreateWithFlags, /* 1.2.3 */ .domainCreateXML = bhyveDomainCreateXML, /* 1.2.4 */ .domainDestroy = bhyveDomainDestroy, /* 1.2.2 */ + .domainShutdown = bhyveDomainShutdown, /* 1.3.3 */ .domainLookupByUUID = bhyveDomainLookupByUUID, /* 1.2.2 */ .domainLookupByName = bhyveDomainLookupByName, /* 1.2.2 */ .domainLookupByID = bhyveDomainLookupByID, /* 1.2.3 */ diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 14588a9..fba3896 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -282,10 +282,9 @@ virBhyveProcessStop(bhyveConnPtr driver, bhyveMonitorClose(priv->mon); /* First, try to kill 'bhyve' process */ - if (virProcessKillPainfully(vm->pid, true) != 0) - VIR_WARN("Failed to gracefully stop bhyve VM '%s' (pid: %d)", - vm->def->name, - (int)vm->pid); + if (virProcessKillPainfully(vm->pid, true) == -1) + VIR_WARN("Failed to kill bhyve process for VM '%s': %s", + vm->def->name, virGetLastErrorMessage()); /* Cleanup network interfaces */ bhyveNetCleanup(vm); @@ -317,6 +316,29 @@ virBhyveProcessStop(bhyveConnPtr driver, } int +virBhyveProcessShutdown(virDomainObjPtr vm) +{ + if (vm->pid <= 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Invalid PID %d for VM"), + (int)vm->pid); + return -1; + } + + /* Bhyve tries to perform ACPI shutdown when it receives + * SIGTERM signal. So we just issue SIGTERM here and rely + * on the bhyve monitor to clean things up if process disappears. + */ + if (virProcessKill(vm->pid, SIGTERM) != 0) { + VIR_WARN("Failed to terminate bhyve process for VM '%s': %s", + vm->def->name, virGetLastErrorMessage()); + return -1; + } + + return 0; +} + +int virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, unsigned long long *cpustats) { diff --git a/src/bhyve/bhyve_process.h b/src/bhyve/bhyve_process.h index cfa80af..ebabe17 100644 --- a/src/bhyve/bhyve_process.h +++ b/src/bhyve/bhyve_process.h @@ -34,6 +34,8 @@ int virBhyveProcessStop(bhyveConnPtr driver, virDomainObjPtr vm, virDomainShutoffReason reason); +int virBhyveProcessShutdown(virDomainObjPtr vm); + int virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, unsigned long long *cpustats); -- 2.7.4

3 5

[libvirt] [PATCH] perf: fix build on non-Linux
by Roman Bogorodskiy 30 Mar '16

30 Mar '16

* Sync stubbed functions with prototypes * Add missing ATTRIBUTE_UNUSED where needed Pushing under the build breaker rule. --- src/util/virperf.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/util/virperf.c b/src/util/virperf.c index 42eee85..9dc4e25 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -262,6 +262,7 @@ virPerfReadEvent(virPerfPtr perf, #else int virPerfEventEnable(virPerfPtr perf ATTRIBUTE_UNUSED, + virPerfEventType type ATTRIBUTE_UNUSED, pid_t pid ATTRIBUTE_UNUSED) { virReportSystemError(ENXIO, "%s", @@ -271,7 +272,7 @@ virPerfEventEnable(virPerfPtr perf ATTRIBUTE_UNUSED, int virPerfEventDisable(virPerfPtr perf ATTRIBUTE_UNUSED, - int event ATTRIBUTE_UNUSED) + virPerfEventType type ATTRIBUTE_UNUSED) { virReportSystemError(ENXIO, "%s", _("Perf not supported on this platform")); @@ -279,15 +280,15 @@ virPerfEventDisable(virPerfPtr perf ATTRIBUTE_UNUSED, } bool -virPerfEventIsEnabled(virPerfPtr perf, - virPerfEventType type) +virPerfEventIsEnabled(virPerfPtr perf ATTRIBUTE_UNUSED, + virPerfEventType type ATTRIBUTE_UNUSED) { return false; } int -virPerfGetEventFd(virPerfPtr perf, - virPerfEventType type) +virPerfGetEventFd(virPerfPtr perf ATTRIBUTE_UNUSED, + virPerfEventType type ATTRIBUTE_UNUSED) { virReportSystemError(ENXIO, "%s", _("Perf not supported on this platform")); @@ -295,9 +296,9 @@ virPerfGetEventFd(virPerfPtr perf, } int -virPerfReadEvent(virPerfPtr perf, - virPerfEventType type - uint64_t *value) +virPerfReadEvent(virPerfPtr perf ATTRIBUTE_UNUSED, + virPerfEventType type ATTRIBUTE_UNUSED, + uint64_t *value ATTRIBUTE_UNUSED) { virReportSystemError(ENXIO, "%s", _("Perf not supported on this platform")); -- 2.7.4

1 0

[libvirt] [PATCH 0/3] Add a domain masterKey secret for qemu
by John Ferlan 29 Mar '16

29 Mar '16

Differences to RFC: http://www.redhat.com/archives/libvir-list/2016-March/msg00966.html (many, but highlights are): * Patch2 is Patch1 and I figured out the 'qom-list-types' magic in order to fill in the .replies file * Use of qemuDomainObjPrivate rather than passing 'masterKey' * The masterKey is not stored in XML output nor is it stored as a base64 value * The masterKey is created during qemuProcessPrepareHost right after the libDir is created. It is only created if the capability exists. * The masterKey is removed during qemuProcessStop. There is no call to qemuDomainMasterKeyRemove from qemuDomainObjPrivateFree since the assumption is the *Stop code will handle things. * Created a qemuDomainMasterKeyReadFile to handle reading the master.key file during qemuProcessReconnect rather than the prior code which would have taken the masterKey from the XML file in base64 format. * The MasterKeyCreate and MasterKeyRemove incorporate the file manipulation as well. The *Create code will save the base64 encoded secret. The callers need only call those API's. * The masterKey is generated using gnutls_rnd if that's available (following examples w/ HAVE_GNUTLS_CRYPTO_H); otherwise, the fallback position is the virRandomBits. * Moved alias code to qemu_alias.c instead of qemu_domain.c. Notes on comments where I didn't change things: * Since qemuBuildCommandLine doesn't get the qemuDomainObjPrivate, I kept the qemuBuildHasMasterKey checking the capability bit only. Other *CommandLine callers would use the same decision point. If the key was available, then "assume" it's already present on the command line since there's no failure path from building the master key command line. * I kept the write "0" to the key file just before deletion. I wasn't sure with file caches being as they can be if there could ever be that 100% guarantee that what was unlink()'d really "went away" completely. Something I noted and wasn't "clear" how to resolve, so I followed existing practices of not checking if something exists: * The recent changes to have a qemuProcessCreatePretendCmd which will allow libDir and channelTargetDir creation using "/tmp/", but not actually creating the directory inhibit this code from being able to check if the path to the masterKey exists before sending it to qemu. Now if the 'flags' was passed to qemuBuildCommandLine and the VIR_QEMU_PROCESS_START_PRETEND could be checked while building the MasterKey command line, then I could have the check in. Otherwise, I just have to assume everything's worked "right" up to this point. A secondary note on that... Why "/tmp/" - shouldn't have been "tmp/"? John Ferlan (3): qemu: Add capability bit for qemu secret object qemu: Create domain master key qemu: Introduce qemuBuildMasterKeyCommandLine src/qemu/qemu_alias.c | 17 ++ src/qemu/qemu_alias.h | 3 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 68 ++++++ src/qemu/qemu_domain.c | 269 +++++++++++++++++++++ src/qemu/qemu_domain.h | 13 + src/qemu/qemu_process.c | 11 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 3 + .../qemuxml2argvdata/qemuxml2argv-master-key.args | 23 ++ tests/qemuxml2argvdata/qemuxml2argv-master-key.xml | 30 +++ tests/qemuxml2argvtest.c | 2 + 13 files changed, 443 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-master-key.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-master-key.xml -- 2.5.0

3 10

[libvirt] [PATCH v4 0/8] Add perf and Intel CMT feature support
by Qiaowei Ren 29 Mar '16

29 Mar '16

The series mainly adds Intel CMT feature support into libvirt. CMT is new introduced PQos (Platform Qos) feature to monitor the usage of cache by applications running on the platform. Currently CMT patches has been merged into Linux kernel mainline. The CMT implementation in Linux kernel is based on perf mechanism and there is no support for perf in libvirt, and so this series firstly add perf support into libvirt, including two public API and a set of util interfaces. And based on these APIs and interfaces, thie series implements CMT perf event support. Current state: * 1/8 - perf: add new public APIs for perf event - ACKed by Daniel * 2/8 - perf: implement the remote protocol for perf event - ACKed by Daniel * 3/8 - perf: implement a set of util functions for perf event - ACKed by Daniel * 4/8 - qemu_driver: add support to perf event - restart perf in qemuProcessReconnect and qemuProcessAttach in patch 6/8 * 5/8 - perf: add new xml element - ACKed by Daniel * 6/8 - perf: reenable perf events when libvirtd restart - add qemuDomainPerfRestart() into qemuProcessReconnect() and qemuProcessAttach() * 7/8 - virsh: implement new command to support perf - ACKed by Daniel * 8/8 - virsh: extend domstats command - ACKed by Daniel TODO: 1. add support for new APIs into libvirt-python library. Changes since v1: * change perf APIs implementation to match new style of the API. * add new xml element * reenable all perf events previously enabled when libvirtd daemon restart. * redesign perf util functions. Changes since v2: * add an example XML file to the test suite. * add virPerfReadEvent(). * change 'perf' xml element to new style. * change 'perf' command to new stype. Changes since v3: * move qemuDomainPerfRestart() into qemuProcessReconnect() and qemuProcessAttach(). Qiaowei Ren (8): perf: add new public APIs for perf event perf: implement the remote protocol for perf event perf: implement a set of util functions for perf event qemu_driver: add support to perf event perf: add new xml element perf: reenable perf events when libvirtd restart virsh: implement new command to support perf virsh: extend domstats command daemon/remote.c | 47 ++++ docs/schemas/domaincommon.rng | 27 +++ include/libvirt/libvirt-domain.h | 19 ++ include/libvirt/virterror.h | 2 + src/Makefile.am | 1 + src/conf/domain_conf.c | 111 ++++++++++ src/conf/domain_conf.h | 10 + src/driver-hypervisor.h | 12 + src/libvirt-domain.c | 93 ++++++++ src/libvirt_private.syms | 12 + src/libvirt_public.syms | 2 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 159 +++++++++++++ src/qemu/qemu_process.c | 44 ++++ src/remote/remote_driver.c | 39 ++++ src/remote/remote_protocol.x | 30 ++- src/remote_protocol-structs | 18 ++ src/util/virerror.c | 2 + src/util/virperf.c | 307 ++++++++++++++++++++++++++ src/util/virperf.h | 63 ++++++ tests/domainschemadata/domain-perf-simple.xml | 20 ++ tools/virsh-domain-monitor.c | 7 + tools/virsh-domain.c | 128 +++++++++++ tools/virsh.pod | 27 ++- 24 files changed, 1180 insertions(+), 3 deletions(-) create mode 100644 src/util/virperf.c create mode 100644 src/util/virperf.h create mode 100644 tests/domainschemadata/domain-perf-simple.xml -- 1.9.1

3 14

[libvirt] [PATCH] qemu: Fix /proc/**/stat parsing
by Jiri Denemark 29 Mar '16

29 Mar '16

Since commit v1.3.2-119-g1e34a8f which enabled debug-threads in QEMU qemuGetProcessInfo would fail to parse stats for any thread with a space in its name. https://bugzilla.redhat.com/show_bug.cgi?id=1316803 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 7e01459..dec99ca 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1460,7 +1460,7 @@ qemuGetProcessInfo(unsigned long long *cpuTime, int *lastCpu, long *vm_rss, if (!pidinfo || fscanf(pidinfo, /* pid -> stime */ - "%*d %*s %*c %*d %*d %*d %*d %*d %*u %*u %*u %*u %*u %llu %llu" + "%*d (%*[^)]) %*c %*d %*d %*d %*d %*d %*u %*u %*u %*u %*u %llu %llu" /* cutime -> endcode */ "%*d %*d %*d %*d %*d %*d %*u %*u %ld %*u %*u %*u" /* startstack -> processor */ -- 2.7.4

2 1

[libvirt] [PATCH 0/6] virsh: Add support for byte granularity and scaled integers for virsh block APIs
by Peter Krempa 29 Mar '16

29 Mar '16

Quite some time ago we've added support for byte granularity for block job bandwidth. Make it work in virsh and add support for scaled integers too. Peter Krempa (6): vsh: Tweak error message for scaled integers vsh: Refactor vshCommandOptScaledInt virsh: blockjob: Support --bytes and scaled integers as bandwidth virsh: blockcommit: Support --bytes and scaled integers virsh: blockcopy: Support --bytes and scaled integers virsh: blockpull: Support --bytes and scaled integers tests/virsh-optparse | 6 ++--- tools/virsh-domain.c | 73 ++++++++++++++++++++++++++++++++++++---------------- tools/virsh.pod | 37 ++++++++++++++------------ tools/vsh.c | 66 +++++++++++++++++++++++++++++++++++++++++------ tools/vsh.h | 4 +++ 5 files changed, 137 insertions(+), 49 deletions(-) -- 2.7.3

2 10

[libvirt] Plan for next release
by Daniel Veillard 29 Mar '16

29 Mar '16

I'm a bit behind, I forgot ! I think we should freeze tomorrow (Wed 30), then make an rc2 on Friday and shoot for a release next Monday (Apr 4), works for everybody ? Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH] tools: virt-host-validate: fix KVM check on s390
by Bjoern Walk 29 Mar '16

29 Mar '16

Since kernel version 4.5, s390 has the 'sie' flag to declare its hardware virtualization support. Let's make virt-host-validate aware so this check is passed correctly. Signed-off-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- tools/virt-host-validate-qemu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virt-host-validate-qemu.c b/tools/virt-host-validate-qemu.c index a9f6c1e..01fb24b 100644 --- a/tools/virt-host-validate-qemu.c +++ b/tools/virt-host-validate-qemu.c @@ -31,7 +31,8 @@ int virHostValidateQEMU(void) virHostMsgCheck("QEMU", "%s", ("for hardware virtualization")); if (virHostValidateHasCPUFlag("svm") || - virHostValidateHasCPUFlag("vmx")) { + virHostValidateHasCPUFlag("vmx") || + virHostValidateHasCPUFlag("sie")) { virHostMsgPass(); if (virHostValidateDeviceExists("QEMU", "/dev/kvm", VIR_HOST_VALIDATE_FAIL, -- 2.6.5

4 3

[libvirt] [PATCH 0/2] bhyve: tiny cleanup and fix
by Maxim Nestratov 29 Mar '16

29 Mar '16

Maxim Nestratov (2): bhyve: cleanup unnecessary variables bhyve: fix invalid hostsysinfo freeing src/bhyve/bhyve_driver.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.4.3

2 5

[libvirt] [PATCH] qemu: tolerate panic device on S390
by Boris Fiuczynski 29 Mar '16

29 Mar '16

If a panic device is being defined without a model in a domain the default value is always overwritten with model ISA. An ISA bus does not exist on S390 and therefore specifying a panic device results in an unsupported configuration. Since the s390 architecture inherently provides a crash detection capability the panic device should be tolerated in the domain xml. This patch achieves the toleration by setting the model to the default value in case the architecture is S390. Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> Reviewed-by: Cornelia Huck <cornelia.huck(a)de.ibm.com> --- src/qemu/qemu_domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 9f9fae3..96561c0 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1605,6 +1605,9 @@ qemuDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, if (ARCH_IS_PPC64(def->os.arch) && STRPREFIX(def->os.machine, "pseries")) dev->data.panic->model = VIR_DOMAIN_PANIC_MODEL_PSERIES; + else if (ARCH_IS_S390(def->os.arch)) + /* since S390 does not support ISA use default for toleration */ + dev->data.panic->model = VIR_DOMAIN_PANIC_MODEL_DEFAULT; else dev->data.panic->model = VIR_DOMAIN_PANIC_MODEL_ISA; } -- 2.5.0

2 1

[libvirt] [PATCH] SCSI storage: Initialise the pool size parameters to zero while refreshing
by Nitesh Konkar 29 Mar '16

29 Mar '16

If the pool creation thread happens to detect the luns in the scsi target,the size parameters will be populated as part of the refresh called from storagePoolCreate(). The commit <4a85bf3e2f> added additional refresh for SCSI which should also have these values initialised to zero, otherwise the values would appear exactly double. A separate refresh would correct the values, but without an explicit pool-refresh, the allocation/capacity would appear exactly double after pool-create. --- src/storage/storage_backend_scsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/storage/storage_backend_scsi.c b/src/storage/storage_backend_scsi.c index 670cc4d..7c7d7d0 100644 --- a/src/storage/storage_backend_scsi.c +++ b/src/storage/storage_backend_scsi.c @@ -614,6 +614,9 @@ virStoragePoolFCRefreshThread(void *opaque) */ VIR_DEBUG("Attempt FC Refresh for pool='%s' name='%s' tries='%d'", pool->def->name, fchost_name, tries); + + pool->def->allocation = pool->def->capacity = pool->def->available = 0; + if (virStoragePoolObjIsActive(pool) && virGetSCSIHostNumber(fchost_name, &host) == 0 && virStorageBackendSCSITriggerRescan(host) == 0) { -- 1.8.3.1

2 1

[libvirt] [PATCH] docs: Document NSS module
by Michal Privoznik 29 Mar '16

29 Mar '16

While we have a wiki page describing the feature [1] since the feature is distributed in our .tar.gz we ought to document it. So I went ahead, copied the wiki page and reformatted so it fits our docs coding style. 1: http://wiki.libvirt.org/page/NSS_module Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/nss.html.in | 141 +++++++++++++++++++++++++++++++++++++++++++++++++++ docs/sitemap.html.in | 4 ++ 2 files changed, 145 insertions(+) create mode 100644 docs/nss.html.in diff --git a/docs/nss.html.in b/docs/nss.html.in new file mode 100644 index 0000000..84ea8df --- /dev/null +++ b/docs/nss.html.in @@ -0,0 +1,141 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> +<html xmlns="http://www.w3.org/1999/xhtml"> + <body> + <h1>Libvirt NSS module</h1> + + <ul id="toc"></ul> + + <p> + When it comes to managing guests and executing commands inside them, logging + into guest operating system and doing the job is convenient. Users are used + to ssh in this case. Ideally: + </p> + + <code>ssh user@virtualMachine</code> + + <p> + would be nice. But depending on virtual network configuration it might not + be always possible. For instance, when using libvirt NATed network it's + dnsmasq (spawned by libvirt) who assigns IP addresses to domains. But by + default, the dnsmasq process is then not consulted when it comes to host + name translation. Users work around this problem by configuring their + libvirt network to assign static IP addresses and maintaining + <code>/etc/hosts</code> file in sync. But this puts needless burden onto + users. This is where NSS module comes handy. + </p> + + <h2><a name="Installation">Installation</a></h2> + + <p> + Installing the module is really easy: + </p> + +<pre> +# yum install libvirt-nss +</pre> + + <h2><a name="Configuration">Configuration</a></h2> + + <p> + Enabling the module is really easy. Just add <b>libvirt</b> into + <code>/etc/nsswitch.conf</code> file. For instance: + </p> + +<pre> +$ cat /etc/nsswitch.conf +# /etc/nsswitch.conf: +passwd: compat +shadow: compat +group: compat +hosts: files libvirt dns +# ... +</pre> + + <p> + So, in this specific case, whenever ssh program is looking up the host user + is trying to connect to, <b>files</b> module is consulted first (which + boils down to looking up the host name in <code>/etc/hosts</code> file), if + not found <b>libvirt</b> module is consulted then. The DNS is the last + effort then, if none of the previous modules matched the host in question. + Therefore users should consider the order in which they want the modules to + lookup given host name. + </p> + + <h2><a name="Internals">How does it work?</a></h2> + + <p> + Whenever an Unix process wants to do a host name translation + <a href="http://linux.die.net/man/3/gethostbyname"><code>gethostbyname()</code></a> + or some variant of it is called. This is a glibc function that takes a + string containing the host name, crunch it and produces a list of IP + addresses assigned to that host. Now, glibc developers made a really good + decision when implementing the internals of the function when they decided + to make the function pluggable. Since there can be several sources for the + records (e.g. <code>/etc/hosts</code> file, DNS, LDAP, etc.) it would not + make much sense to create one big implementation containing all possible + cases. What they have done instead is this pluggable mechanism. Small + plugins implementing nothing but specific technology for lookup process are + provided and the function then calls those plugins. There is just one + configuration file that instructs the lookup function in which order should + the plugins be called and which plugins should be loaded. For more info + reading <a href="https://en.wikipedia.org/wiki/Name_Service_Switch">wiki + page</a> is recommended. + </p> + + <p> + And this is point where libvirt comes in. Libvirt provides plugin for the + NSS ecosystem. For some time now libvirt keeps a list of assigned IP + addresses for libvirt networks. The NSS plugin does no more than search the + list trying to find matching record for given host name. When found, + matching IP address is returned to the caller. If not found, translation + process continues with the next plugin configured. At this point it is + important to stress the order in which plugins are called. Users should be + aware that a hostname might match in multiple plugins and right after first + match, translation process is terminated and no other plugin is consulted. + Therefore, if there are two different records for the same host name users + should carefully chose the lookup order. + </p> + + <h2><a name="Limitations">Limitations</a></h2> + + <ol> + <li>The libvirt NSS module matches only hostnames provided by guest. If + the libvirt name and one advertised by guest differs, the latter is + matched.</li> + <li>The module works only in that cases where IP addresses are assigned by + dnsmasq spawned by libvirt. Libvirt NATed networks are typical + example.</li> + </ol> + + <p> + These limitation are result of libvirt's internal implementation. While + libvirt can report IP addresses regardless of their origin, a public API + must be used to obtain those. However, for the API a connection object is + required. Doing that for every name translation request would be too + costly. Fortunately, libvirt spawns dnsmasq for NATed networks. Not only + that, it provides small executable that on each IP address space change + updates an internal list of addresses thus keeping it in sync. The NSS + module then merely consults the list trying to find the match. Users can + view the list themselves: + </p> + +<pre> +virsh net-dhcp-leases $network +</pre> + + <p> + where <code>$network</code> iterates through all running networks. So the module + does merely the same as + </p> + +<pre> +virsh domifaddr --source lease $domain +</pre> + + <p> + If there's no record for either of the aforementioned commands, it's very + likely that NSS module won't find anything and vice versa. + </p> + </body> +</html> diff --git a/docs/sitemap.html.in b/docs/sitemap.html.in index 7e3746e..22e410c 100644 --- a/docs/sitemap.html.in +++ b/docs/sitemap.html.in @@ -120,6 +120,10 @@ <a href="hooks.html">Hooks</a> <span>Hooks for system specific management</span> </li> + <li> + <a href="nss.html">NSS module</a> + <span>Enable domain host name translation to IP addresses</span> + </li> </ul> </li> <li> -- 2.7.3

2 1

[libvirt] [PATCH v3 0/2] qemu: Support for QXL heads
by Martin Kletzander 29 Mar '16

29 Mar '16

v3: - rebase on top of current master in order to cleanly apply v2: - don't change heads when migrating - https://www.redhat.com/archives/libvir-list/2016-March/msg00811.html v1: - https://www.redhat.com/archives/libvir-list/2016-March/msg00410.html Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 8 +++ src/qemu/qemu_migration.c | 64 ++++++++++++++++++++-- .../qemuxml2argv-video-qxl-heads.args | 28 ++++++++++ .../qemuxml2argv-video-qxl-heads.xml | 47 ++++++++++++++++ tests/qemuxml2argvtest.c | 8 +++ .../qemuxml2xmlout-video-qxl-heads.xml | 47 ++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 9 files changed, 204 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-heads.xml -- 2.7.4

2 4

[libvirt] Publishing libvirt 'patches' JSON database?
by Kashyap Chamarthy 29 Mar '16

29 Mar '16

I'd imagine most developers on this list have their own workflows to track/apply/test patches from the mailing list. I normally just save patches in Mutt's Maildir and apply them manually to a Git branch. I recently began using the 'patches'[1] tool, that some of you on this list must be familiar with, to test arbitrary QEMU patches from the mailing list, and found it relatively easy large patch series from mailing list. I'm writing this to check if the libvirt upstream community finds it desirable to setup such a patches database. What is 'patches'? ------------------ Quoting the README[2]: "patches is a patch tracking system. It consists of two parts: a set of commands that build a database of patches from a mailing list and then a set of commands that can search that database. It supports the following features: - Tracking patch status by determining which patches are already committed, have newer versions posted, are RFC, etc. - Applying patches or pull requests with a single command. - Searching for patches using a rich query language." A quick workflow to test patches from mailing list --------------------------------------------------- FWIW, this is my rudimentary use-case. Clone the repo, and fetch the patches database (may take a few minutes): $ git clone https://github.com/stefanha/patches.git $ cd patches $ ./patches fetch http://wiki.qemu.org/patches/patches.json And, suppose, I want to test Dan's LUKS encryption support (26) patch series, I go find the message ID: $ ./patches list | grep -B5 "Support LUKS encryption" Message-id: 1456747261-22032-1-git-send-email-berrange(a)redhat.com From: Daniel P. Berrange <berrange(a)redhat.com> Date: 2016-02-29 Tags: v4 [0/26] Support LUKS encryption in block devices Trivially apply it (assuming you have a test branch): $ ./patches apply --git-dir ~/src/qemu/ \ id:1456747261-22032-1-git-send-email-berrange@redhat.com Applying: crypto: add cryptographic random byte source Applying: crypto: add support for PBKDF2 algorithm Applying: crypto: add support for generating initialization vectors Applying: crypto: add support for anti-forensic split algorithm Applying: crypto: skip testing of unsupported cipher algorithms [...] Test away! Rinse, repeat: "The `fetch` command should be run whenever you want to refresh the patch database; it will download any new patches that have arrived since the last time you did a fetch." Here's[3] the documentation to setup the patches database. [1] https://github.com/stefanha/patches/tree/stefanha-tweaks [2] https://github.com/stefanha/patches/blob/stefanha-tweaks/README.md [3] https://github.com/stefanha/patches/blob/stefanha-tweaks/README-server.md -- /kashyap

3 7

[libvirt] Request for testing: migration of libvirt wiki site
by Daniel P. Berrange 29 Mar '16

29 Mar '16

I'm preparing for a migration of the libvirt wiki off the host it is currently running on, to OpenShift hosting. This isn't entirely straightforward, as I'm also upgrading the version of mediawiki and as a result had to re-write the CSS customization from scratch. I may well have messed something up, so would appreciate if people could have a quick look at this testing instance of the wiki and confirm that it looks / works reasonably for them. http://wiki-libvirt.rhcloud.com NB, any edits you make in this test instance will be discarded when I load a fresh database dump from the current live wiki. If all looks good, I'll look at getting DNS updated to switch over later this week. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|

5 12

[libvirt] [PATCH 00/10] Introduce worker tuning APIs
by Erik Skultety 29 Mar '16

29 Mar '16

Erik Skultety (10): libvirt-host: Move virTypedParam* to libvirt-common admin: Enable usage of typed parameters admin: Introduce virAdmConnectServerLookupByName util: Refactor thread creation by introducing virThreadPoolExpand util: Report system error when virThreadCreateFull fails util: Add more getters to threadpool parameters admin: Prepare admin protocol for future worker related procedures admin: Introduce virAdmServerGethreadPoolParameters admin: Introduce virAdmServerSetThreadPoolParameters virt-admin: Introduce srv-workertune command cfg.mk | 2 +- daemon/admin.c | 129 ++++++++++++++++++++++++ daemon/admin_server.c | 129 ++++++++++++++++++++++++ daemon/admin_server.h | 15 +++ include/libvirt/libvirt-admin.h | 74 ++++++++++++++ include/libvirt/libvirt-common.h.in | 185 ++++++++++++++++++++++++++++++++++ include/libvirt/libvirt-host.h | 186 ---------------------------------- include/libvirt/virterror.h | 1 + po/POTFILES.in | 4 +- src/admin/admin_protocol.x | 67 +++++++++++- src/admin/admin_remote.c | 104 +++++++++++++++++++ src/admin_protocol-structs | 52 ++++++++++ src/libvirt-admin.c | 114 +++++++++++++++++++++ src/libvirt_admin_private.syms | 5 + src/libvirt_admin_public.syms | 3 + src/libvirt_private.syms | 4 + src/rpc/virnetserver.c | 37 +++++++ src/rpc/virnetserver.h | 13 +++ src/util/virerror.c | 6 ++ src/util/virthreadpool.c | 196 ++++++++++++++++++++++++------------ src/util/virthreadpool.h | 8 ++ tools/virt-admin.c | 132 ++++++++++++++++++++++++ 22 files changed, 1212 insertions(+), 254 deletions(-) -- 2.4.3

3 13

[libvirt] [PATCH] rbd: use unsigned long long instead of uint64_t
by Shanzhi Yu 29 Mar '16

29 Mar '16

Fix below error: storage/storage_backend_rbd.c: In function 'virStorageBackendRBDSetAllocation': storage/storage_backend_rbd.c:337:5: error: format '%llu' expects argument of type 'long long unsigned int', but argument 8 has type 'uint64_t' [-Werror=format=] VIR_DEBUG("Found %llu bytes allocated for RBD image %s", Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/storage/storage_backend_rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index c9b47e2..dec0905 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -324,7 +324,7 @@ virStorageBackendRBDSetAllocation(virStorageVolDefPtr vol, rbd_image_info_t *info) { int r, ret = -1; - uint64_t allocation = 0; + unsigned long long allocation = 0; if ((r = rbd_diff_iterate2(image, NULL, 0, info->size, 0, 1, &virStorageBackendRBDRefreshVolInfoCb, -- 1.8.3.1

2 1

[libvirt] [PATCH] storage: rbd: Fix build
by Peter Krempa 29 Mar '16

29 Mar '16

After the recent commits the build didn't work for me. Fix it by using size_t as the callback argument is using and the correct formatter. The attempted fixup to use %llu as a formatter was wrong. --- Pushed now. src/storage/storage_backend_rbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index c9b47e2..6e92ff7 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -311,7 +311,7 @@ virStorageBackendRBDRefreshVolInfoCb(uint64_t offset ATTRIBUTE_UNUSED, int exists, void *arg) { - uint64_t *used_size = (uint64_t *)(arg); + size_t *used_size = (size_t *)(arg); if (exists) (*used_size) += len; @@ -324,7 +324,7 @@ virStorageBackendRBDSetAllocation(virStorageVolDefPtr vol, rbd_image_info_t *info) { int r, ret = -1; - uint64_t allocation = 0; + size_t allocation = 0; if ((r = rbd_diff_iterate2(image, NULL, 0, info->size, 0, 1, &virStorageBackendRBDRefreshVolInfoCb, @@ -334,7 +334,7 @@ virStorageBackendRBDSetAllocation(virStorageVolDefPtr vol, goto cleanup; } - VIR_DEBUG("Found %llu bytes allocated for RBD image %s", + VIR_DEBUG("Found %zu bytes allocated for RBD image %s", allocation, vol->name); vol->target.allocation = allocation; -- 2.7.3

1 0

[libvirt] [PATCH] util: generate correct macvtap name
by Shanzhi Yu 29 Mar '16

29 Mar '16

in commit 370608b, bitmap of in-used macvtap devices was introduced. if there is already macvtap device created not by libvirt, virNetDevMacVLanCreateWithVPortProfile will failed after try MACVLAN_MAX_ID times call virNetDevMacVLanReleaseID Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1321546 Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/util/virnetdevmacvlan.c | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index 2409113..973363e 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -988,7 +988,8 @@ virNetDevMacVLanCreateWithVPortProfile(const char *ifnameRequested, MACVTAP_NAME_PREFIX : MACVLAN_NAME_PREFIX; const char *pattern = (flags & VIR_NETDEV_MACVLAN_CREATE_WITH_TAP) ? MACVTAP_NAME_PATTERN : MACVLAN_NAME_PATTERN; - int rc, reservedID = -1; + int rc = -1; + int reservedID = 0; char ifname[IFNAMSIZ]; int retries, do_retry = 0; uint32_t macvtapMode; @@ -1072,16 +1073,17 @@ virNetDevMacVLanCreateWithVPortProfile(const char *ifnameRequested, retries = MACVLAN_MAX_ID; while (!ifnameCreated && retries) { virMutexLock(&virNetDevMacVLanCreateMutex); - reservedID = virNetDevMacVLanReserveID(reservedID, flags, false, true); - if (reservedID < 0) { - virMutexUnlock(&virNetDevMacVLanCreateMutex); - return -1; - } snprintf(ifname, sizeof(ifname), pattern, reservedID); rc = virNetDevMacVLanCreate(ifname, type, macaddress, linkdev, macvtapMode, &do_retry); if (rc < 0) { - virNetDevMacVLanReleaseID(reservedID, flags); + reservedID++; + reservedID = virNetDevMacVLanReserveID(reservedID, flags, false, true); + if (reservedID < 0) { + virMutexUnlock(&virNetDevMacVLanCreateMutex); + return -1; + } + virMutexUnlock(&virNetDevMacVLanCreateMutex); if (!do_retry) return -1; -- 1.8.3.1

2 3

[libvirt] [PATCH 0/3] libxl: improve libxlDomainStart error handling
by Jim Fehlig 29 Mar '16

29 Mar '16

libxlDomainStart allocates and reserves resources, which should be cleaned up on error paths. This small series is based on Chunyan's patch to do the same [0]. It breaks the patch into three patches to ease review and better understand the changes. [0] https://www.redhat.com/archives/libvir-list/2016-March/msg00929.html Chunyan Liu (1): libxl: fix resource leaks in libxlDomainStart error paths Jim Fehlig (2): libxl: rename cleanup_dom label libxl: only disable domain death events in libxlDomainCleanup src/libxl/libxl_domain.c | 44 ++++++++++++++++++++------------------------ 1 file changed, 20 insertions(+), 24 deletions(-) -- 2.1.4

2 6

[libvirt] [PATCH] libxl: remove reference to non-existent out label
by Jim Fehlig 29 Mar '16

29 Mar '16

Commit e6336442 changed the 'out:' label to 'cleanup' in libxlDomainAttachNetDevice(), but missed a comment referencing the 'out:' label. Remove it from the comment since it is no longer accurate anyhow. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- Pushing as trivial. src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index cfc4555..5103495 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -3159,7 +3159,7 @@ libxlDomainAttachNetDevice(libxlDriverPrivatePtr driver, /* This is really a "smart hostdev", so it should be attached * as a hostdev (the hostdev code will reach over into the * netdev-specific code as appropriate), then also added to - * the nets list (see out:) if successful. + * the nets list if successful. */ ret = libxlDomainAttachHostDevice(driver, vm, hostdev); goto cleanup; -- 2.1.4

1 0

[libvirt] [PATCH] tests: virtnettlscontexttest: Use virGetLastErrorMessage()
by Cole Robinson 29 Mar '16

29 Mar '16

Use virGetLastErrorMessage() rather than open code it --- There's many more examples of this spread around the code; this patch is meant as an example for http://wiki.libvirt.org/page/BiteSizedTasks tests/virnettlscontexttest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index a3e24a3..d33b896 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -90,13 +90,12 @@ static int testTLSContextInit(const void *opaque) goto cleanup; } } else { - virErrorPtr err = virGetLastError(); if (!data->expectFail) { VIR_WARN("Unexpected failure %s against %s", data->cacrt, data->crt); goto cleanup; } - VIR_DEBUG("Got error %s", err ? err->message : "<unknown>"); + VIR_DEBUG("Got error %s", virGetLastErrorMessage()); } ret = 0; -- 2.5.0

2 1

[libvirt] [PATCH] docs: Update the hyperv feature qemu supported version
by John Ferlan 29 Mar '16

29 Mar '16

In order to follow recent comments which indicate support for specific feature bits are supported by a specific QEMU version add the version from whence the relaxed, vapic, and spinlocks support was added. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushing as trivial and essentially a follow on to commit id '7068b56c' in order to keep things looking the same docs/formatdomain.html.in | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 630c682..a1d7c4a 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1528,19 +1528,19 @@ <td>relaxed</td> <td>Relax constraints on timers</td> <td> on, off</td> - <td><span class="since">1.0.0 (QEMU only)</span></td> + <td><span class="since">1.0.0 (QEMU 2.0)</span></td> </tr> <tr> <td>vapic</td> <td>Enable virtual APIC</td> <td>on, off</td> - <td><span class="since">1.1.0 (QEMU only)</span></td> + <td><span class="since">1.1.0 (QEMU 2.0)</span></td> </tr> <tr> <td>spinlocks</td> <td>Enable spinlock support</td> <td>on, off; retries - at least 4095</td> - <td><span class="since">1.1.0 (QEMU only)</span></td> + <td><span class="since">1.1.0 (QEMU 2.0)</span></td> </tr> <tr> <td>vpindex</td> -- 2.5.5

2 1

[libvirt] [PATCH] docs: website: more header spacing tweaks
by Cole Robinson 29 Mar '16

29 Mar '16

- remove top padding for h1. this means page titles sit flush with the top of the side bar (like 'The virtualization API' on the front page) - up the top padding for the remaining sections. makes it visually easier to tell adjacent header sections apart, especially in dense wiki pages - use two different spacing levels for h2-h4 and h5-h6, gives pages some more visual flexibility - use a slightly lower bottom padding... this makes top padding stick out more which makes it visually easier to differentiate between adjacent header sections --- Before: http://i.imgur.com/5TxW9Fg.png After: http://i.imgur.com/1MPjzHR.png docs/generic.css | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/docs/generic.css b/docs/generic.css index 664e719..aeea17f 100644 --- a/docs/generic.css +++ b/docs/generic.css @@ -48,26 +48,31 @@ h1, h2, h3, h4, h5, h6 { font-weight: bold; margin: 0px; padding: 0px; - margin-top: 0.5em; - margin-bottom: 0.5em; + margin-bottom: 0.25em; border-bottom: 1px solid #aaa; } h1 { + margin-top: 0em; font-size: 2em; } h2 { + margin-top: 1.0em; font-size: 1.6em; } h3 { + margin-top: 1.0em; font-size: 1.4em; } h4 { + margin-top: 1.0em; font-size: 1.2em; } h5 { + margin-top: 0.75em; font-size: 1em; } h6 { + margin-top: 0.75em; font-size: 0.8em; } -- 2.5.0

2 1

[libvirt] [PATCH v2 0/3] Add support for more HyperV Enlightenment features
by Nikolay Shirokovskiy 29 Mar '16

29 Mar '16

Changes from v1: ================ 1. hv_reset and hv_vendor_id are supported 2. preparation patches [2],[3] for hv_vendor_id to reduce code dups Maxim Nestratov (1): conf: qemu: Add support for more HyperV Enlightenment features Nikolay Shirokovskiy (2): conf: refactor hyperv features parsing conf: refactor hyperv features xml output docs/formatdomain.html.in | 41 +++++ docs/schemas/domaincommon.rng | 37 ++++ src/conf/domain_conf.c | 186 +++++++++++++-------- src/conf/domain_conf.h | 9 + src/qemu/qemu_command.c | 11 ++ src/qemu/qemu_parse_command.c | 20 +++ tests/qemuxml2argvdata/qemuxml2argv-hyperv-off.xml | 6 + tests/qemuxml2argvdata/qemuxml2argv-hyperv.args | 3 +- tests/qemuxml2argvdata/qemuxml2argv-hyperv.xml | 6 + .../qemuxml2xmlout-hyperv-off.xml | 6 + tests/qemuxml2xmloutdata/qemuxml2xmlout-hyperv.xml | 6 + 11 files changed, 262 insertions(+), 69 deletions(-) -- 1.8.3.1

3 7

[libvirt] [PATCH 0/2] Enable pool-rbd storagexml2xmltest
by Anatole Denis 29 Mar '16

29 Mar '16

The test for an RBD pool in storagepoolxml2xml was commited 4 years ago but it was not enabled. It was also incorrect, but didn't generate errors because it was never run. These patches correct the test then enable it Anatole Denis (2): tests: storagepoolxml2xmltest: Fix pool-rbd test tests: storagepoolxml2xmltest: Enable pool-rbd tests/storagepoolxml2xmlin/pool-rbd.xml | 1 + tests/storagepoolxml2xmlout/pool-rbd.xml | 2 +- tests/storagepoolxml2xmltest.c | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) -- 2.7.2

2 3