- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/5] Remove caching of address sets
by Tomasz Flendrich 16 Aug '16

16 Aug '16

Link to last version (1-6 are already ACK'd) https://www.redhat.com/archives/libvir-list/2016-July/msg00917.html Changes: * qemuDomainPCIAddressSetCreate is now expanded instead of creating a completely new function. It now contains qemuDomainValidateDevicePCISlotsChipsets. * A parameter was added to qemuDomainValidateDevicePCISlotsChipsets to make new address asignment optional. If it's false, then that function doesn't assign any new addresses: it just validates the current ones (and in some cases reserves addresses for the future) By the way I'd be grateful if someone took a look at my other patches: https://www.redhat.com/archives/libvir-list/2016-July/msg01205.html https://www.redhat.com/archives/libvir-list/2016-August/msg00132.html Kind regards, Tomasz Tomasz Flendrich (5): Move validating chipset PCI slots to qemuDomainPCIAddressSetCreate Make address assignment in qemuDomainPCIAddressSetCreate optional Reduce number of parameters to qemuDomainPCIAddressSetCreate qemu_hotplug: generate pci address set on demand qemu: remove pciaddrs caching src/qemu/qemu_domain.c | 1 - src/qemu/qemu_domain.h | 1 - src/qemu/qemu_domain_address.c | 222 +++++++++++++++++++++++------------------ src/qemu/qemu_domain_address.h | 6 ++ src/qemu/qemu_hotplug.c | 50 ++++++++-- 5 files changed, 175 insertions(+), 105 deletions(-) -- 1.9.1

2 7

[libvirt] [PATCH] utils: storage: Fix JSON field name for uri based storage
by Peter Krempa 16 Aug '16

16 Aug '16

qemu uses 'url' instead of 'uri'. They unfortunately look very similar. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1367260 --- src/util/virstoragefile.c | 2 +- tests/virstoragetest.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 6f7d131..8d3895d 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2684,7 +2684,7 @@ virStorageSourceParseBackingJSONUri(virStorageSourcePtr src, { const char *uri; - if (!(uri = virJSONValueObjectGetString(json, "uri"))) { + if (!(uri = virJSONValueObjectGetString(json, "url"))) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("missing URI in JSON backing volume definition")); return -1; diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index 3b19f59..b3d59ad 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -1377,19 +1377,19 @@ mymain(void) "\"file.filename\":\"/path/to/cdrom\"}", "<source dev='/path/to/cdrom'/>\n"); TEST_BACKING_PARSE("json:{\"file.driver\":\"http\", " - "\"file.uri\":\"http://example.com/file\"}", + "\"file.url\":\"http://example.com/file\"}", "<source protocol='http' name='file'>\n" " <host name='example.com'/>\n" "</source>\n"); TEST_BACKING_PARSE("json:{\"file\":{ \"driver\":\"http\"," - "\"uri\":\"http://example.com/file\"" + "\"url\":\"http://example.com/file\"" "}" "}", "<source protocol='http' name='file'>\n" " <host name='example.com'/>\n" "</source>\n"); TEST_BACKING_PARSE("json:{\"file.driver\":\"ftp\", " - "\"file.uri\":\"http://example.com/file\"}", + "\"file.url\":\"http://example.com/file\"}", NULL); TEST_BACKING_PARSE("json:{\"file.driver\":\"gluster\", " "\"file.filename\":\"gluster://example.com/vol/file\"}", -- 2.9.2

2 2

[libvirt] [libvirt-perl][PATCH] Register VIR_NODE_DEVICE_EVENT_ID_UPDATE constant
by Michal Privoznik 16 Aug '16

16 Aug '16

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I figured that there's no need to update Changelog here as it already mentions nodedev events implementation. Virt.xs | 1 + lib/Sys/Virt/NodeDevice.pm | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/Virt.xs b/Virt.xs index 5025f2e..ee83431 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8635,6 +8635,7 @@ BOOT: REGISTER_CONSTANT(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_GENERIC, LIST_CAP_SCSI_GENERIC); REGISTER_CONSTANT(VIR_NODE_DEVICE_EVENT_ID_LIFECYCLE, EVENT_ID_LIFECYCLE); + REGISTER_CONSTANT(VIR_NODE_DEVICE_EVENT_ID_UPDATE, EVENT_ID_UPDATE); REGISTER_CONSTANT(VIR_NODE_DEVICE_EVENT_CREATED, EVENT_CREATED); REGISTER_CONSTANT(VIR_NODE_DEVICE_EVENT_DELETED, EVENT_DELETED); diff --git a/lib/Sys/Virt/NodeDevice.pm b/lib/Sys/Virt/NodeDevice.pm index 4a8212b..1ebb97f 100644 --- a/lib/Sys/Virt/NodeDevice.pm +++ b/lib/Sys/Virt/NodeDevice.pm @@ -175,6 +175,10 @@ Include devices with the SCSI generic capability Node device lifecycle events +=item Sys::Virt::NodeDevice::EVENT_ID_UPDATE + +Node device update events + =back =head2 LIFECYCLE CHANGE EVENTS -- 2.8.4

2 1

[libvirt] [PATCH] qemu: driver: Fix format characters in error message
by Peter Krempa 16 Aug '16

16 Aug '16

Error message in qemuDomainSetVcpusFlags uses %d for the two arguments but both are unsigned. The resulting error message may be weird when attempting to set a very large vcpu count. --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 5a7733c..a0587e1 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4826,7 +4826,7 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus, if (!(flags & VIR_DOMAIN_VCPU_MAXIMUM) && nvcpus > maxvcpus) { virReportError(VIR_ERR_INVALID_ARG, _("requested vcpus is greater than max allowable" - " vcpus for the domain: %d > %d"), + " vcpus for the domain: %u > %u"), nvcpus, maxvcpus); goto endjob; } -- 2.9.2

1 1

[libvirt] [PATCH 0/2] USB address assignment fixes
by Ján Tomko 16 Aug '16

16 Aug '16

Ján Tomko (2): conf: free the ports array of a USB hub conf: report an error message for non-existing USB hubs src/conf/domain_addr.c | 9 +++++++++ .../qemuxml2argv-usb-hub-nonexistent.xml | 19 +++++++++++++++++++ tests/qemuxml2argvtest.c | 3 +++ 3 files changed, 31 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-hub-nonexistent.xml -- 2.7.3

2 4

[libvirt] [PATCH] libxl_driver: Indent LIBXL_VBD_SECTOR_SIZE macro correctly
by Michal Privoznik 16 Aug '16

16 Aug '16

Because of change in caaa1bd357a99ad this macro is no under #ifdef block. That means it needs to be re-intended correctly. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under build-breaker rule. src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 1170062..a573c82 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -5307,7 +5307,7 @@ libxlDiskPathToID(const char *virtpath) return id; } -#define LIBXL_VBD_SECTOR_SIZE 512 +# define LIBXL_VBD_SECTOR_SIZE 512 static int libxlDiskSectorSize(int domid, int devno) -- 2.8.4

1 0

[libvirt] [PATCH] tests: fix domaincapstest linking for libxl
by Roman Bogorodskiy 16 Aug '16

16 Aug '16

Commit 11567cf added some libxl tests into domaincapstest and added libvirt_driver_libxl_impl.la to domaincapstest_LDADD. This causes link fail on systems without GNU regex implementation: gmake[2]: Entering directory '/usr/home/novel/code/libvirt/tests' CCLD domaincapstest ../src/.libs/libvirt_driver_libxl_impl.a(libvirt_driver_libxl_impl_la-libxl_capabilities.o): In function `libxlMakeCapabilities': libxl/libxl_capabilities.c:(.text+0x6b2): undefined reference to `rpl_regcomp' libxl/libxl_capabilities.c:(.text+0x6d0): undefined reference to `rpl_regerror' libxl/libxl_capabilities.c:(.text+0x803): undefined reference to `rpl_regexec' libxl/libxl_capabilities.c:(.text+0xa58): undefined reference to `rpl_regfree' clang-3.8: error: linker command failed with exit code 1 (use -v to see invocation) This happens because on these system it tries to use gnulib's builtin regex implementation, but doesn't link to gnulib. Fix by adding $(GNULIB_LIBS) along with libvirt_driver_libxl_impl.la to domaincapstest_LDADD. --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 5714d11..0cd8391 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -953,7 +953,7 @@ endif WITH_QEMU if WITH_LIBXL domaincapstest_SOURCES += testutilsxen.c testutilsxen.h -domaincapstest_LDADD += ../src/libvirt_driver_libxl_impl.la +domaincapstest_LDADD += ../src/libvirt_driver_libxl_impl.la $(GNULIB_LIBS) endif WITH_LIBXL virnetmessagetest_SOURCES = \ -- 2.7.4

2 2

[libvirt] [PATCH] libxl: fix unused functions
by Roman Bogorodskiy 16 Aug '16

16 Aug '16

Commit eee7bd4e introduced two functions: libxlDiskPathToID and libxlDiskSectorSize. However, as they're used only by code under #ifdef __linux__, on non-Linux platforms it results in errors similar to this: CC libxl/libvirt_driver_libxl_impl_la-libxl_driver.lo libxl/libxl_driver.c:5263:1: error: unused function 'libxlDiskPathToID' [-Werror,-Wunused-function] libxlDiskPathToID(const char *virtpath) ^ libxl/libxl_driver.c:5312:1: error: unused function 'libxlDiskSectorSize' [-Werror,-Wunused-function] libxlDiskSectorSize(int domid, int devno) ^ 2 errors generated. Fix that by moving these functions under the #ifdef __linux__ block. --- src/libxl/libxl_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 4957072..1170062 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -5259,6 +5259,7 @@ libxlDomainGetJobStats(virDomainPtr dom, return ret; } +#ifdef __linux__ static int libxlDiskPathToID(const char *virtpath) { @@ -5348,7 +5349,6 @@ libxlDiskSectorSize(int domid, int devno) return ret; } -#ifdef __linux__ static int libxlDomainBlockStatsVBD(virDomainObjPtr vm, const char *dev, -- 2.7.4

2 2

[libvirt] [PATCH 0/3] Node device update lifecycle event as top level event
by Jovanka Gulicoska 15 Aug '16

15 Aug '16

Introduce node device update lifecycle as top level event. Series include API implementation, udev driver implementation, event-test implementation and virsh nodedev-event changes. Jovanka Gulicoska (3): Introduce node device update event as top level event virsh: nodedev-event update callback support event-test: add support node device update event API daemon/remote.c | 29 +++++++++++++++++ examples/object-events/event-test.c | 12 +++++++ include/libvirt/libvirt-nodedev.h | 1 + src/conf/node_device_event.c | 55 ++++++++++++++++++++++++++++++++ src/conf/node_device_event.h | 3 ++ src/libvirt_private.syms | 1 + src/node_device/node_device_udev.c | 2 ++ src/remote/remote_driver.c | 30 ++++++++++++++++++ src/remote/remote_protocol.x | 13 +++++++- src/remote_protocol-structs | 5 +++ tools/virsh-nodedev.c | 62 ++++++++++++++++++++++++++++++++----- 11 files changed, 204 insertions(+), 9 deletions(-) -- 2.7.4

2 4

[libvirt] [PATCH] virsh: Fix core for cmdSecretGetValue
by John Ferlan 15 Aug '16

15 Aug '16

https://bugzilla.redhat.com/show_bug.cgi?id=1366611 When commit id 'cb2e3e50' reworked the cmdSecretGetValue call to use VIR_DISPOSE_STRING for base64, it neglected to initialize the base64 value to NULL since the cleanup: label could be reached prior to the base64 value being set or not. This resulted in a core dump, adding the initialization will avoid the issue. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/virsh-secret.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 8588f4c..537bdd7 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -253,7 +253,7 @@ static bool cmdSecretGetValue(vshControl *ctl, const vshCmd *cmd) { virSecretPtr secret; - char *base64; + char *base64 = NULL; unsigned char *value; size_t value_size; bool ret = false; -- 2.7.4

2 1

[libvirt] Drop support for old libvirt versions?
by Andrea Bolognani 15 Aug '16

15 Aug '16

A while ago, we agreed to drop support for QEMU versions older than 0.12.0, with the rationale that we should focus on operating systems that are still supported by the respective vendors, eg. RHEL/CentOS 6, Ubuntu 12.04 and SLES 11. Recently, when discussing how to ensure a certain change will not break migration with libvirt <= 0.9.4, I started wondering whether we should apply the same rationale to libvirt versions as well. Here's a quick run down of relevant libvirt versions: SLES 11 → ??? RHEL 6.0 → 0.8.1 Ubuntu 12.04 → 0.9.2 RHEL 6.8 → 0.10.2 Ubuntu 12.04.5 → 0.9.8 SLES 11 SP4 → 1.2.5 One thing I'm not clear about is whether or not SUSE, Red Hat and Canonical will support old minor releases or just the latest one. If the latter, we could safely drop support for anything older than 0.9.8, which incidentally would make the discussion referenced above entirely moot ;) In any case, having a well-defined cut-off point has been very useful when dealing with QEMU, so I think having one for libvirt itself would be beneficial too. Looking forward to your thoughts on this :) -- Andrea Bolognani / Red Hat / Virtualization

7 9

[libvirt] [PATCH] qemu_command: don't modify heads for graphics device
by Pavel Hrdina 13 Aug '16

13 Aug '16

Setting heads to 0 in case that *max_outputs* is not supported while building command line doesn't have any real effect. It only removes *heads* attribute from live XML, but after restarting libvirt the default value is restored. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_command.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 55df23d..06f5091 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4298,8 +4298,6 @@ qemuBuildDeviceVideoStr(const virDomainDef *def, virQEMUCapsGet(qemuCaps, QEMU_CAPS_QXL_MAX_OUTPUTS))) { if (video->heads) virBufferAsprintf(&buf, ",max_outputs=%u", video->heads); - } else { - video->heads = 0; } } else if (video->vram && ((video->type == VIR_DOMAIN_VIDEO_TYPE_VGA && -- 2.9.2

2 3

[libvirt] libvirtd crash with host cpu model qemu64
by Jim Fehlig 13 Aug '16

13 Aug '16

I have an L1 nested VM with the following cpu # lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 2 On-line CPU(s) list: 0,1 Thread(s) per core: 1 Core(s) per socket: 1 Socket(s): 2 NUMA node(s): 1 Vendor ID: AuthenticAMD CPU family: 6 Model: 2 Model name: QEMU Virtual CPU version 0.14 Stepping: 3 CPU MHz: 3092.210 BogoMIPS: 6184.42 Virtualization: AMD-V Hypervisor vendor: KVM Virtualization type: full L1d cache: 64K L1i cache: 64K L2 cache: 512K NUMA node0 CPU(s): 0,1 Flags: fpu de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 syscall nx lm nopl pni cx16 popcnt hypervisor lahf_lm svm abm sse4a 3dnowprefetch vmmcall When starting an L2 VM with <cpu mode="host-model">, libvirtd in the L1 VM crashes Program received signal SIGSEGV, Segmentation fault. 0x00007ffff739bf33 in x86DataCpuid (cpuid=0x8, cpuid=0x8, data=data@entry=0x7fffb800ee78) at cpu/cpu_x86.c:287 287 for (i = 0; i < data->len; i++) { (gdb) bt f0 0x00007ffff739bf33 in x86DataCpuid (cpuid=0x8, cpuid=0x8, data=data@entry=0x7fffb800ee78) at cpu/cpu_x86.c:287 f1 virCPUx86DataAddCPUID (data=data@entry=0x7fffb800ee78, cpuid=0x8) at cpu/cpu_x86.c:355 f2 0x00007ffff739ef47 in x86Compute (host=<optimized out>, cpu=0x7fffb8000cc0, guest=0x7fffecca7348, message=<optimized out>) at cpu/cpu_x86.c:1580 f3 0x00007fffd2b38e53 in qemuBuildCpuModelArgStr (migrating=false, hasHwVirt=<synthetic pointer>, qemuCaps=0x7fffb8001040, buf=0x7fffecca7360, def=0x7fffc400ce20, driver=0x1c) at qemu/qemu_command.c:6283 f4 qemuBuildCpuCommandLine (cmd=cmd@entry=0x7fffb8002f60, driver=driver@entry=0x7fffc80882c0, def=def@entry=0x7fffc400ce20, qemuCaps=qemuCaps@entry=0x7fffb8001040, migrating=<optimized out>) at qemu/qemu_command.c:6445 In frame 2, &host_model->vendor->cpuid is passed to virCPUx86DataAddCPUID(), but (gdb) p *host_model $23 = {name = 0x7fffb800ec50 "qemu64", vendor = 0x0, signature = 0, data = { len = 2, data = 0x7fffb800e720}} With vendor = 0x0, &host_model->vendor->cpuid evaluates to 8, which is not a nice value to pass to virCPUx86DataAddCPUID(). I've hacked around the problem by checking for a non-null host->vendor before calling virCPUx86DataAddCPUID, but I get the feeling it is just that - a hack. Comments on the attached patch, or suggestions for an alternate fix, are kindly welcomed :-). Regards, Jim

2 3

[libvirt] [PATCH 0/9] qemu: Reflect USB controller model in guest XML
by Andrea Bolognani 12 Aug '16

12 Aug '16

Patches 1-3 take care of some tiny nits; patches 4-7 clean up the test suite and add some new test cases that cover the code changed by subsequent patches. Patch 8 implements the feature advertised in the subject :) Patch 9 gets rid of some code that's no longer necessary after the changes. Andrea Bolognani (9): tests: qemuxml2argv: Remove useless GIC flags tests: qemuxml2argv: Fix usb-too-long-port-path-invalid tests: qemuxml2xml: Fix disk-mirror tests: qemuxml2xml: Use WHEN_BOTH for most tests tests: qemuxml2xml: Pass capabilities to DO_TEST() tests: qemuxml2xml: Use DO_TEST() for most tests tests: qemuxml2xml: Add some USB test cases qemu: domain: Reflect USB controller model in guest XML qemu: command: Simplify USB controller model selection src/qemu/qemu_command.c | 60 +- src/qemu/qemu_domain.c | 20 + tests/qemuxml2argvtest.c | 16 +- .../qemuxml2xmlout-ppc64-usb-controller-legacy.xml | 31 + .../qemuxml2xmlout-ppc64-usb-controller.xml | 31 + .../qemuxml2xmlout-usb-controller-default-q35.xml | 37 + .../qemuxml2xmlout-usb-controller-explicit-q35.xml | 37 + .../qemuxml2xmlout-usb-controller.xml | 27 + .../qemuxml2xmloutdata/qemuxml2xmlout-usb-none.xml | 25 + .../qemuxml2xmlout-usb-piix3-controller.xml | 27 + tests/qemuxml2xmltest.c | 932 ++++++++++----------- 11 files changed, 728 insertions(+), 515 deletions(-) create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-ppc64-usb-controller-legacy.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-ppc64-usb-controller.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-controller-default-q35.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-controller-explicit-q35.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-controller.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-none.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-usb-piix3-controller.xml -- 2.7.4

2 19

[libvirt] [PATCH 0/2] Couple of virschematest fixes
by Michal Privoznik 12 Aug '16

12 Aug '16

It's true that rewriting this into C made this test run faster. But maybe too much to my taste. Michal Privoznik (2): virschematest: Initialize @data virschematest: Make sure that validator is initialized tests/virschematest.c | 29 +++++++++++++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) -- 2.8.4

2 4

[libvirt] [PATCH v2] schema: Don't validate paths
by Michal Privoznik 12 Aug '16

12 Aug '16

https://bugzilla.redhat.com/show_bug.cgi?id=1353296 On UNIX like systems there are no constraints on what characters can be in file/dir names (except for NULL, obviously). Moreover, some values that we think of as paths (e.g. disk source) are not necessarily paths at all. For instance, some hypervisors take that as an arbitrary identifier and corresponding file is then looked up by hypervisor in its table. Instead of trying to fix our regular expressions (and forgetting to include yet another character there), lets drop the validation completely. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v1: - Instead of adding some more chars to whitelist, drop it docs/schemas/basictypes.rng | 8 ++--- .../domainschemadata/domain-disk-source-space.xml | 36 ++++++++++++++++++++++ 2 files changed, 40 insertions(+), 4 deletions(-) create mode 100644 tests/domainschemadata/domain-disk-source-space.xml diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index 474ad77..1b4f980 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -247,25 +247,25 @@ <define name="filePath"> <data type="string"> - <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/%]+</param> + <param name="pattern">.+</param> </data> </define> <define name="dirPath"> <data type="string"> - <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/%]+</param> + <param name="pattern">.+</param> </data> </define> <define name="absFilePath"> <data type="string"> - <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%,:]+</param> + <param name="pattern">/.+</param> </data> </define> <define name="absDirPath"> <data type="string"> - <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%]*</param> + <param name="pattern">/.*</param> </data> </define> diff --git a/tests/domainschemadata/domain-disk-source-space.xml b/tests/domainschemadata/domain-disk-source-space.xml new file mode 100644 index 0000000..553b6c7 --- /dev/null +++ b/tests/domainschemadata/domain-disk-source-space.xml @@ -0,0 +1,36 @@ +<domain type='kvm'> + <name>dummy</name> + <uuid>aa86471a-e67b-41b1-8d7d-2dc37c2ac5ec</uuid> + <memory unit='KiB'>2097152</memory> + <currentMemory unit='KiB'>2097152</currentMemory> + <vcpu placement='static'>4</vcpu> + <os> + <type arch='x86_64' machine='pc-i440fx-2.5'>hvm</type> + </os> + <features> + <acpi/> + <apic/> + </features> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>restart</on_crash> + <pm> + <suspend-to-mem enabled='no'/> + <suspend-to-disk enabled='no'/> + </pm> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <disk type='file' device='cdrom'> + <driver name='qemu' type='raw'/> + <source file='/a/path/with some space in it.iso'/> + <target dev='hda' bus='ide'/> + <readonly/> + <boot order='1'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='pci' index='0' model='pci-root'/> + <controller type='ide' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> + </controller> + </devices> +</domain> -- 2.8.4

2 1

[libvirt] [PATCH] conf: Fix initialization value of 'multi' in PCI address
by Xian Han Yu 12 Aug '16

12 Aug '16

Signed-off-by: Xian Han Yu <xhyubj(a)linux.vnet.ibm.com> --- src/conf/node_device_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index a23d8ef..96fdb6f 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1163,7 +1163,7 @@ virNodeDevCapPCIDevIommuGroupParseXML(xmlXPathContextPtr ctxt, goto cleanup; for (i = 0; i < nAddrNodes; i++) { - virPCIDeviceAddress addr = { 0, 0, 0, 0, 0 }; + virPCIDeviceAddress addr = { 0, 0, 0, 0, false }; if (virPCIDeviceAddressParseXML(addrNodes[i], &addr) < 0) goto cleanup; if (VIR_ALLOC(pciAddr) < 0) -- 2.5.5

6 12

[libvirt] [PATCH] schema: Allow spaces in paths
by Michal Privoznik 12 Aug '16

12 Aug '16

Since ages filesystems allowed to have space characters in filenames and even directory names. In fact, on all major filesystems out there you can have whatever character you like except NULL. There's no reason why we should forbid users to not have spaces in their filenames. Moreover, if we do that only on RNG schema level while our XML parser/formatter crunches that happily. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/schemas/basictypes.rng | 8 ++--- .../domainschemadata/domain-disk-source-space.xml | 36 ++++++++++++++++++++++ 2 files changed, 40 insertions(+), 4 deletions(-) create mode 100644 tests/domainschemadata/domain-disk-source-space.xml diff --git a/docs/schemas/basictypes.rng b/docs/schemas/basictypes.rng index 474ad77..f2b7930 100644 --- a/docs/schemas/basictypes.rng +++ b/docs/schemas/basictypes.rng @@ -247,25 +247,25 @@ <define name="filePath"> <data type="string"> - <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/%]+</param> + <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/% ]+</param> </data> </define> <define name="dirPath"> <data type="string"> - <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/%]+</param> + <param name="pattern">[a-zA-Z0-9_\.\+\-\\&"'<>/% ]+</param> </data> </define> <define name="absFilePath"> <data type="string"> - <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%,:]+</param> + <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%,: ]+</param> </data> </define> <define name="absDirPath"> <data type="string"> - <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/%]*</param> + <param name="pattern">/[a-zA-Z0-9_\.\+\-\\&"'<>/% ]*</param> </data> </define> diff --git a/tests/domainschemadata/domain-disk-source-space.xml b/tests/domainschemadata/domain-disk-source-space.xml new file mode 100644 index 0000000..553b6c7 --- /dev/null +++ b/tests/domainschemadata/domain-disk-source-space.xml @@ -0,0 +1,36 @@ +<domain type='kvm'> + <name>dummy</name> + <uuid>aa86471a-e67b-41b1-8d7d-2dc37c2ac5ec</uuid> + <memory unit='KiB'>2097152</memory> + <currentMemory unit='KiB'>2097152</currentMemory> + <vcpu placement='static'>4</vcpu> + <os> + <type arch='x86_64' machine='pc-i440fx-2.5'>hvm</type> + </os> + <features> + <acpi/> + <apic/> + </features> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>restart</on_crash> + <pm> + <suspend-to-mem enabled='no'/> + <suspend-to-disk enabled='no'/> + </pm> + <devices> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <disk type='file' device='cdrom'> + <driver name='qemu' type='raw'/> + <source file='/a/path/with some space in it.iso'/> + <target dev='hda' bus='ide'/> + <readonly/> + <boot order='1'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='pci' index='0' model='pci-root'/> + <controller type='ide' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> + </controller> + </devices> +</domain> -- 2.8.4

2 2

[libvirt] [PATCH 0/5] Introduce NVDIMM support
by Michal Privoznik 12 Aug '16

12 Aug '16

NVDIMM was introduced to qemu in v2.6.0-rc0~248^2~25. So it's been a while since then. It's not the next big thing, but it is very interesting feature enabling higher performance as reading/writing to the module (and subsequently to the file on the host) does not require a VMEXIT. It can be used to access host files directly bypassing page cache whilst doing so. How to test the feature? 1) you need PMEM enabled kernel: CONFIG_LIBNVDIMM=y CONFIG_BLK_DEV_PMEM=m CONFIG_ACPI_NFIT=m 2) Create a file in the host: truncate -s 512M /tmp/nvdimm 3) Add the following to the domain XML: <memory model='nvdimm' memAccess='shared'> <source> <path>/tmp/nvdimm</path> </source> <target> <size unit='KiB'>523264</size> <node>0</node> </target> </memory> 4) Start the domain and write something into the NVDIMM module: (guest) $ echo 'Hello world' > /dev/pmem0 5) From the host, check the file has changed: (host) $ hexdump -C /tmp/nvdimm Want to watch very interesting video while reviewing? https://youtu.be/Vit3-PjbN9M Michal Privoznik (5): Introduce NVDIMM memory model qemu: Introduce QEMU_CAPS_DEVICE_NVDIMM qemu: Implement NVDIMM conf: Introduce memAccess to <memory/> qemu: Implement memAccess for <memory/> banks docs/formatdomain.html.in | 41 ++++++-- docs/schemas/domaincommon.rng | 51 ++++++---- src/conf/domain_conf.c | 112 ++++++++++++++++----- src/conf/domain_conf.h | 4 + src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 12 ++- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 87 +++++++++++----- src/qemu/qemu_command.h | 2 + src/qemu/qemu_domain.c | 29 ++++-- src/qemu/qemu_hotplug.c | 3 +- tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + .../qemuxml2argv-hugepages-numa.args | 5 +- .../qemuxml2argv-hugepages-pages.args | 24 ++--- .../qemuxml2argv-hugepages-pages2.args | 8 +- .../qemuxml2argv-hugepages-pages3.args | 4 +- .../qemuxml2argv-hugepages-shared.args | 22 ++-- .../qemuxml2argv-memory-hotplug-dimm-addr.args | 5 +- .../qemuxml2argv-memory-hotplug-dimm.args | 5 +- ...muxml2argv-memory-hotplug-nvdimm-memAccess.args | 26 +++++ ...emuxml2argv-memory-hotplug-nvdimm-memAccess.xml | 49 +++++++++ .../qemuxml2argv-memory-hotplug-nvdimm.args | 25 +++++ .../qemuxml2argv-memory-hotplug-nvdimm.xml | 49 +++++++++ tests/qemuxml2argvtest.c | 6 +- 25 files changed, 452 insertions(+), 123 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-memAccess.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-memAccess.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm.xml -- 2.8.4

4 9

Re: [libvirt] wiki accounts for GSOC submissions
by Tomasz Flendrich 11 Aug '16

11 Aug '16

Hello, please sign me up too. username: tflendrich email: t.flendrich gmail com

1 0

[libvirt] Failing build on rawhide
by Martin Kletzander 11 Aug '16

11 Aug '16

So after updating my fedora-rawhide machines, I started receiving an interesting error: In file included from /usr/include/features.h:397:0, from /usr/include/bits/libc-header-start.h:33, from /usr/include/stdio.h:28, from ../gnulib/lib/stdio.h:43, from util/vircgroup.c:26: /usr/include/sys/sysmacros.h:88:1: note: declared here __SYSMACROS_DEFINE_MINOR (__SYSMACROS_FST_IMPL_TEMPL) ^ util/vircgroup.c: In function 'virCgroupAllowDevicePath': util/vircgroup.c:2944:33: error: '__major_from_sys_types' is deprecated: In the GNU C Library, `major' is defined by <sys/sysmacros.h>. For historical compatibility, it is currently defined by <sys/types.h> as well, but we plan to remove this soon. To use `major', include <sys/sysmacros.h> directly. If you did not intend to use a system-defined macro `major', you should #undef it after including <sys/types.h>. [-Werror=deprecated-declarations] major(sb.st_rdev), ^~~~~ It looks like we might need to reorder the includes, but whatever I do, I still get the warning. Updating gnulib doesn't help, so either we need to #undef minor/major/makedev, or maybe gnulib needs to fix that (my guess inspired by the include stack above). So I figured I just post my findings here and let others continue the wondering so that I can do some more useful stuff. Have a nice day, Martin

2 1

[libvirt] [PATCHv2 00/11] qemu: allow disabling certain virtio revisions
by Ján Tomko 11 Aug '16

11 Aug '16

https://bugzilla.redhat.com/show_bug.cgi?id=1227354 v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01235.html v2: * probe for the qemu capability * add the attribute to virtio1-only devices such as virtio-gpu and virtio-input devices * allow multiple revisions to be specified Ján Tomko (11): Use separate buffer for <input> subelements Add virtio revision attribute to memballoon Add virtio revision attribute to disks Add virtio revision attribute to controllers Add virtio revision attribute to filesystems Add virtio revision attribute to interfaces Add virtio revision to rng devices Add virtio revision attribute to video Add virtio revision attribute to input devices Introduce QEMU_CAPS_DEVICE_VIRTIO_REVISION qemu: format options for enforcing virtio revisions docs/formatdomain.html.in | 69 ++++++++++ docs/schemas/domaincommon.rng | 37 ++++++ src/conf/domain_conf.c | 148 +++++++++++++++++++-- src/conf/domain_conf.h | 16 +++ src/qemu/qemu_capabilities.c | 6 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 56 ++++++++ tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + .../qemuxml2argv-virtio-revision.args | 62 +++++++++ .../qemuxml2argv-virtio-revision.xml | 113 ++++++++++++++++ tests/qemuxml2argvtest.c | 11 ++ .../qemuxml2xmlout-virtio-revision.xml | 113 ++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 19 files changed, 630 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-revision.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-revision.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-virtio-revision.xml -- 2.7.3

3 20

[libvirt] [PATCH 0/6] Use more PCIe, less legacy PCI slots
by Laine Stump 11 Aug '16

11 Aug '16

These patches use three methods to get more of the PCI devices onto PCIe slots on Q35 and aarch64/virt machinetypes: 1) When virtio devices can present themselves as PCIe if they're plugged into a PCIe controller, do that. (This capability is detected by looking for presence of the "disable-modern" option on the virtio-net device. If you have a better idea for how to detect it, please let me know.) 2) Any devices that aren't hotpluggable anyway will no longer request a hotplug-capable slot. This, along with a change to auto-assign legacy PCI devices to pcie-root (as long as they don't require hotplug) means the devices will now be assigned to pcie-root. 3) Also using the fact that devices that won't be hotplugged can be assigned to pcie-root, the devices that *do* support hotplug have a new optional subelement "<hotplug require='no'/>" (it defaults to "yes" for historical reasons). If hotplug require is set to 'no', even a PCI device can be auto-assigned to pcie-root. I haven't yet removed the dmi-to-pci-bridge that is added by default, and we still will only auto-add pci-bridge (so if you're adding a virtio device without <hostplug require='no'/> then you will also need to add a <controller type='pci' model='pcie-root-port'/> to plug it into). These 6 patches together resolve: https://bugzilla.redhat.com/show_bug.cgi?id=1330024 They need to be applied on top of the series I sent on Friday: https://www.redhat.com/archives/libvir-list/2016-August/msg00380.html Laine Stump (6): conf: restrict what type of buses will accept a pci-bridge conf: permit auto-assignment of *non-hotpluggable* PCI devices to pcie-root qemu: add capabilities bit for virtio-net "disable-modern" option conf: new <hotplug require='yes|no'/> element for hotpluggable devices qemu: don't require a hotpluggable slot for devices that can't be hotplugged qemu: auto-assign virtio devices to PCIe slots when appropriate docs/formatdomain.html.in | 37 +++++++ docs/schemas/domaincommon.rng | 17 +++ src/conf/device_conf.h | 15 +++ src/conf/domain_addr.c | 44 ++++++-- src/conf/domain_addr.h | 4 +- src/conf/domain_conf.c | 28 +++++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_domain_address.c | 94 ++++++++++++++-- tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemuxml2argvdata/qemuxml2argv-autoindex.args | 22 ++-- .../qemuxml2argv-bios-nvram-secure.args | 2 +- .../qemuxml2argv-machine-smm-opt.args | 2 +- .../qemuxml2argv-q35-hotpluggable.args | 50 +++++++++ .../qemuxml2argv-q35-hotpluggable.xml | 62 +++++++++++ .../qemuxml2argv-q35-pm-disable-fallback.args | 3 +- .../qemuxml2argv-q35-pm-disable.args | 3 +- .../qemuxml2argv-q35-usb2-multi.args | 10 +- .../qemuxml2argv-q35-usb2-reorder.args | 10 +- .../qemuxml2argv-q35-virtio-pcie.args | 54 +++++++++ .../qemuxml2argv-q35-virtio-pcie.xml | 69 ++++++++++++ tests/qemuxml2argvtest.c | 18 +++ .../qemuxml2xmlout-autoindex.xml | 18 +-- .../qemuxml2xmlout-q35-hotpluggable.xml | 103 +++++++++++++++++ .../qemuxml2xmlout-q35-usb2-multi.xml | 8 +- .../qemuxml2xmlout-q35-usb2-reorder.xml | 8 +- .../qemuxml2xmlout-q35-virtio-pcie.xml | 123 +++++++++++++++++++++ tests/qemuxml2xmltest.c | 15 +++ 34 files changed, 765 insertions(+), 64 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-hotpluggable.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-hotpluggable.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virtio-pcie.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-virtio-pcie.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-hotpluggable.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-virtio-pcie.xml -- 2.7.4

3 19

[libvirt] [PATCH] lxc: don't try to resolve a NULL path for filesystems
by Daniel P. Berrange 11 Aug '16

11 Aug '16

<filesystem type='ram' accessmode='passthrough'> <source usage='524288' units='KiB'/> <target dir='/dev/shm'/> </filesystem> would lead to lxcContainerResolveSymlinks calling access(NULL) because it failed to check if fs->src->path was non-NULL. This is a regression caused by commit da665fbd4858890fbb3bbf5da2a7b6ca37bb3220 Author: Olga Krishtal <okrishtal(a)virtuozzo.com> Date: Thu Jul 14 16:52:38 2016 +0300 filesystem: adds possibility to use storage pool as fs source Signed-off-by: Olga Krishtal <okrishtal(a)virtuozzo.com> Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/lxc/lxc_container.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 124b441..e1eb434 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -616,7 +616,7 @@ static int lxcContainerResolveSymlinks(virDomainFSDefPtr fs, bool gentle) { char *newroot; - if (!fs->src || fs->symlinksResolved) + if (!fs->src || !fs->src->path || fs->symlinksResolved) return 0; if (access(fs->src->path, F_OK)) { -- 2.7.4

2 1

[libvirt] [PATCH 0/7] qemu: Trivially add support for newer ivshmem
by Martin Kletzander 11 Aug '16

11 Aug '16

It's "trivially" because it's just about using different parameters. It is a series because I wanted to make some code paths saner and some output nicer, but I tried keeping every patch self-contained and as small as possible while keeping the readability. Also I wanted to make the series to be looked upon by more people by just using the word "trivial". Sorry for that =) Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1347049 Martin Kletzander (7): qemu: Add capabilities for ivshmem-{plain,doorbell} qemu: Save various defaults for shmem qemu: Make qemuBuildShmemDevStr static qemu: Rename qemuBuildShmemDevStr to qemuBuildShmemDevLegacyStr qemu: Move common checks outside qemuBuildShmemDevLegacyStr qemu: Reorder shmem params nicely qemu: Support newer ivshmem and prefer that over the legacy one src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 144 +++++++++++++++------ src/qemu/qemu_command.h | 4 - src/qemu/qemu_domain.c | 18 +++ .../caps_2.6.0-gicv2.aarch64.xml | 2 + .../caps_2.6.0-gicv3.aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + .../qemuxml2argv-shmem-plain-doorbell.args | 42 ++++++ .../qemuxml2argv-shmem-plain-doorbell.xml} | 14 +- tests/qemuxml2argvdata/qemuxml2argv-shmem.args | 16 +-- tests/qemuxml2argvtest.c | 3 + tests/qemuxml2xmloutdata/qemuxml2xmlout-shmem.xml | 1 + 15 files changed, 193 insertions(+), 65 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem-plain-doorbell.args copy tests/{qemuxml2xmloutdata/qemuxml2xmlout-shmem.xml => qemuxml2argvdata/qemuxml2argv-shmem-plain-doorbell.xml} (66%) -- 2.9.2

2 10

[libvirt] an AB deadlock or libvirtd crash problem in virsh console and virsh destroy
by weifuqiang 11 Aug '16

11 Aug '16

Hi all: I encountered with an AB deadlock and libvirtd crash problem the other day. The process to generate the problems: 1 use the command "virsh create ***.xml" to create a vm 2 after vm is running , use the command "virsh console ***" to connect vm with console 3 after connection, use the command "virsh destroy ****" to destroy vm and delete it Then, an AB lock problem occurs, or libvirtd got crashed. AB LOCK stack: [Switching to thread 1 (Thread 0x7ff96bf3d7a0 (LWP 9772))] #0 0x00007ff967b49324 in __lll_lock_wait () from /lib64/libpthread.so.0 #0 0x00007ff967b49324 in __lll_lock_wait () from /lib64/libpthread.so.0 #1 0x00007ff967b44669 in _L_lock_1008 () from /lib64/libpthread.so.0 #2 0x00007ff967b4447e in pthread_mutex_lock () from /lib64/libpthread.so.0 #3 0x00007ff96b3bd96c in virChrdevFDStreamCloseCb () from /usr/lib64/libvirt.so.0 #4 0x00007ff96b3c9a34 in virFDStreamCloseInt () from /usr/lib64/libvirt.so.0 #5 0x00007ff96b40ac3e in virStreamAbort () from /usr/lib64/libvirt.so.0 #6 0x00007ff96bfa242a in daemonStreamHandleAbort () #7 0x00007ff96bfa2803 in daemonStreamEvent () #8 0x00007ff96b3c9bfc in virFDStreamEvent () from /usr/lib64/libvirt.so.0 #9 0x00007ff96b3083aa in virEventPollRunOnce () from /usr/lib64/libvirt.so.0 #10 0x00007ff96b307042 in virEventRunDefaultImpl () from /usr/lib64/libvirt.so.0 #11 0x00007ff96b4503dd in virNetDaemonRun () from /usr/lib64/libvirt.so.0 #12 0x00007ff96bf72528 in main () [Switching to thread 12 (Thread 0x7ff9640ff700 (LWP 9778))] #0 0x00007ff967b49324 in __lll_lock_wait () from /lib64/libpthread.so.0 #0 0x00007ff967b49324 in __lll_lock_wait () from /lib64/libpthread.so.0 #1 0x00007ff967b44669 in _L_lock_1008 () from /lib64/libpthread.so.0 #2 0x00007ff967b4447e in pthread_mutex_lock () from /lib64/libpthread.so.0 #3 0x00007ff96b3c8f26 in virFDStreamSetInternalCloseCb () from /usr/lib64/libvirt.so.0 #4 0x00007ff96b30f7b9 in virHashForEach () from /usr/lib64/libvirt.so.0 #5 0x00007ff96b3be1a2 in virChrdevFree () from /usr/lib64/libvirt.so.0 #6 0x00007ff96055980f in qemuDomainObjPrivateFree () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #7 0x00007ff96b367014 in virDomainObjDispose () from /usr/lib64/libvirt.so.0 #8 0x00007ff96b330c33 in virObjectUnref () from /usr/lib64/libvirt.so.0 #9 0x00007ff96b35edb9 in virDomainObjEndAPI () from /usr/lib64/libvirt.so.0 #10 0x00007ff9605c6e89 in qemuDomainUndefineFlags () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #11 0x00007ff96b3e35ac in virDomainUndefine () from /usr/lib64/libvirt.so.0 #12 0x00007ff96bf996db in remoteDispatchDomainUndefineHelper () #13 0x00007ff96b4537ef in virNetServerProgramDispatch () from /usr/lib64/libvirt.so.0 #14 0x00007ff96b45205e in virNetServerProcessMsg () from /usr/lib64/libvirt.so.0 #15 0x00007ff96b4520e8 in virNetServerHandleJob () from /usr/lib64/libvirt.so.0 #16 0x00007ff96b349f94 in virThreadPoolWorker () from /usr/lib64/libvirt.so.0 #17 0x00007ff96b3494a8 in virThreadHelper () from /usr/lib64/libvirt.so.0 #18 0x00007ff967b42806 in start_thread () from /lib64/libpthread.so.0 #19 0x00007ff96789d67d in clone () from /lib64/libc.so.6 #20 0x0000000000000000 in ?? () coredump stack (gdb) f 1 #1 0x00007f1672a7c73f in virMutexLock (m=0x68) at util/virthread.c:89 89 pthread_mutex_lock(&m->lock); (gdb) bt #0 0x00007f1670ace444 in pthread_mutex_lock () from /lib64/libpthread.so.0 #1 0x00007f1672a7c73f in virMutexLock (m=0x68) at util/virthread.c:89 #2 0x00007f1672b2fda2 in virFDStreamSetInternalCloseCb (st=0x7f1673a1a370, cb=0x0, opaque=0x0, fcb=0x0) at fdstream.c:796 #3 0x00007f1672b1f5ad in virChrdevFreeClearCallbacks (payload=0x7f1673a1a370, name=0x7f1673a12520, data=0x0) at conf/virchrdev.c:301 #4 0x00007f1672a36c9b in virHashForEach (table=0x7f1673a0ba20, iter=0x7f1672b1f567 <virChrdevFreeClearCallbacks>, data=0x0) at util/virhash.c:521 #5 0x00007f1672b1f626 in virChrdevFree (devs=0x7f1673a2f820) at conf/virchrdev.c:316 #6 0x00007f1669cca988 in qemuDomainObjPrivateFree (data=0x7f1673a1afa0) at qemu/qemu_domain.c:496 #7 0x00007f1672a9e293 in virDomainObjDispose (obj=0x7f1673a16400) at conf/domain_conf.c:2545 #8 0x00007f1672a5b326 in virObjectUnref (anyobj=0x7f1673a16400) at util/virobject.c:265 #9 0x00007f1672a9e7a5 in virDomainObjEndAPI (vm=0x7f166b07d8d0) at conf/domain_conf.c:2684 #10 0x00007f1669d3ff00 in qemuDomainDestroyFlags (dom=0x7f16600017f0, flags=0) at qemu/qemu_driver.c:2264 #11 0x00007f1669d3ff69 in qemuDomainDestroy (dom=0x7f16600017f0) at qemu/qemu_driver.c:2273 #12 0x00007f1672b39333 in virDomainDestroy (domain=0x7f16600017f0) at libvirt-domain.c:483 #13 0x00007f16737167a5 in remoteDispatchDomainDestroy (server=0x7f167398f4f0, client=0x7f1673a172f0, msg=0x7f1673a2fc70, rerr=0x7f166b07db50, args=0x7f1673a2f9b0) at remote_dispatch.h:4002 #14 0x00007f1673716648 in remoteDispatchDomainDestroyHelper (server=0x7f167398f4f0, client=0x7f1673a172f0, msg=0x7f1673a2fc70, rerr=0x7f166b07db50, args=0x7f1673a2f9b0, ret= 0x7f1673a10e10) at remote_dispatch.h:3977 #15 0x00007f1672bd8a9b in virNetServerProgramDispatchCall (prog=0x7f167399c610, server=0x7f167398f4f0, client=0x7f1673a172f0, msg=0x7f1673a2fc70) at rpc/virnetserverprogram.c:437 #16 0x00007f1672bd85fd in virNetServerProgramDispatch (prog=0x7f167399c610, server=0x7f167398f4f0, client=0x7f1673a172f0, msg=0x7f1673a2fc70) at rpc/virnetserverprogram.c:307 #17 0x00007f1672bd2a08 in virNetServerProcessMsg (srv=0x7f167398f4f0, client=0x7f1673a172f0, prog=0x7f167399c610, msg=0x7f1673a2fc70) at rpc/virnetserver.c:136 #18 0x00007f1672bd2aed in virNetServerHandleJob (jobOpaque=0x7f1673a1d780, opaque=0x7f167398f4f0) at rpc/virnetserver.c:157 #19 0x00007f1672a7d833 in virThreadPoolWorker (opaque=0x7f167399bad0) at util/virthreadpool.c:145 #20 0x00007f1672a7cbec in virThreadHelper (data=0x7f167399c980) at util/virthread.c:206 #21 0x00007f1670acc806 in start_thread () from /lib64/libpthread.so.0 #22 0x00007f167082767d in clone () from /lib64/libc.so.6 #23 0x0000000000000000 in ?? () (gdb) bt #0 0x00007f1670ad3324 in __lll_lock_wait () from /lib64/libpthread.so.0 #1 0x00007f1670ace669 in _L_lock_1008 () from /lib64/libpthread.so.0 #2 0x00007f1670ace47e in pthread_mutex_lock () from /lib64/libpthread.so.0 #3 0x00007f1672a7c73f in virMutexLock (m=0x7f1673a2f820) at util/virthread.c:89 #4 0x00007f1672b1f3fe in virChrdevFDStreamCloseCb (st=0x7f1673a1a370, opaque=0x7f1673a149e0) at conf/virchrdev.c:254 #5 0x00007f1672b2e8a8 in virFDStreamCloseInt (st=0x7f1673a1a370, streamAbort=true) at fdstream.c:329 #6 0x00007f1672b2e9d5 in virFDStreamAbort (st=0x7f1673a1a370) at fdstream.c:355 #7 0x00007f1672b7d856 in virStreamAbort (stream=0x7f1673a1a370) at libvirt-stream.c:663 #8 0x00007f16737497e8 in daemonStreamHandleAbort (client=0x7f1673a1b1b0, stream=0x7f1673a1ec50, msg=0x7f1673a0d660) at stream.c:613 #9 0x00007f16737499fa in daemonStreamHandleWrite (client=0x7f1673a1b1b0, stream=0x7f1673a1ec50) at stream.c:662 #10 0x00007f167374866b in daemonStreamEvent (st=0x7f1673a1a370, events=14, opaque=0x7f1673a1b1b0) at stream.c:138 #11 0x00007f1672b2e17a in virFDStreamEvent (watch=18, fd=17, events=14, opaque=0x7f1673a1a370) at fdstream.c:173 #12 0x00007f1672a2c2cb in virEventPollDispatchHandles (nfds=12, fds=0x7f1673a2fda0) at util/vireventpoll.c:509 #13 0x00007f1672a2cb08 in virEventPollRunOnce () at util/vireventpoll.c:658 #14 0x00007f1672a2a9e0 in virEventRunDefaultImpl () at util/virevent.c:308 #15 0x00007f1672bd25d2 in virNetDaemonRun (dmn=0x7f1673990ed0) at rpc/virnetdaemon.c:707 #16 0x00007f167370cad4 in main (argc=3, argv=0x7ffd63276288) at libvirtd.c:1581 The reason of this problem is that fdstream abort event or close event occured at the same time, libvirtd doesn't deal with the synchronousness well enough. the flows about fdStream is bellow 1、qemuDomainDefineXMLFlags -> virDomainObjListAdd -> qemuDomainObjPrivateAlloc -> virChrdevAlloc -> virHashCreate 2、qemuDomainOpenConsole -> virChrdevOpen -> virHashAddEntry(devs->hash, path, st) 3、virDomainObjDispose -> privateDataFreeFunc (qemuDomainObjPrivateFree) - > virChrdevFree(*dev locked*) -> virChrdevFreeClearCallbacks - > virFDStreamSetInternalCloseCb(*fdst locked*) 4、virFDStreamCloseInt (*fdst locked*) -> icbFreeOpaque(virChrdevFDStreamCloseCb (*dev locked*)) -> virHashRemoveEntry The AB lock problem is obviouse: in step 3, it locks chardev before fdst, and in step 4, it's the opsite way. The reason of libvirtd crash is that: in virFDStreamCloseInt function we set fdst to NULL, while in virFDStreamSetInternalCloseCb we use fdst->lock, note that fdst has already been freed. another crash problem occurs because that when virChrdevFree was earlier finished, dev->hash freed and all date of hash is freed, but fdstream event flow use fdStream after hash free. Ahha~~， libvirtd coredump. All of those problem is because clear vm flow and fdStream flow concurs synchronously. then I fix this problem by modify virChrdevFree() void virChrdevFree(virChrdevsPtr devs) { if (!devs || !devs->hash) return; for (;;) { virMutexLock(&devs->lock); if (0 == virHashSize(devs->hash)) { virMutexUnlock(&devs->lock); break; } virMutexUnlock(&devs->lock); usleep(10 * 1000); } virMutexLock(&devs->lock); virHashFree(devs->hash); virMutexUnlock(&devs->lock); virMutexDestroy(&devs->lock); VIR_FREE(devs); } If the chardev is removed by fdStream close or fdStream abort when vm destroy or shutdown, the modification works well. But I'm not sure is that all chardev would be removed when we clear vm, if not, it would always sleep here. Another solution is as follows: virMutexLock(vm); virChrdevFree(); virMutexUnlock(vm); virMutexLock(vm); virFDStreamCloseInt(); virMutexUnlock(vm); I lock vm before calling these 2 functions, which makes them run sequently. Do you have other better idea to solve this problem. thanks in advance. Thanks in advance. Wei Fuqiang

2 1

[libvirt] [PATCH v2] libxl: support serial list
by Bob Liu 11 Aug '16

11 Aug '16

Add support for multi serial devices, after this patch virsh can be used to connect different serial devices of running domains. E.g. vish # console <xxx> --devname serial<xxx> Note: This depends on a xen/libxl bug fix to have libxl_console_get_tty(...) correctly returning the tty path (as opposed to always returning the first one). [0] https://lists.xen.org/archives/html/xen-devel/2016-08/msg00438.html Signed-off-by: Bob Liu <bob.liu(a)oracle.com> --- v2: Add #ifdef LIBXL_HAVE_BUILDINFO_SERIAL_LIST --- src/libxl/libxl_conf.c | 24 +++++++++++++++++++++--- src/libxl/libxl_domain.c | 23 +++++++++++++++++++++++ src/libxl/libxl_driver.c | 17 +++++++++-------- 3 files changed, 53 insertions(+), 11 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 146e08a..26c704d 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -431,14 +431,32 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, } if (def->nserials) { - if (def->nserials > 1) { + if (def->nserials == 1) { + if (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) < + 0) + return -1; + } else { +#ifdef LIBXL_HAVE_BUILDINFO_SERIAL_LIST + if (VIR_ALLOC_N(b_info->u.hvm.serial_list, def->nserials + 1) < + 0) + return -1; + + for (i = 0; i < def->nserials; i++) { + if (libxlMakeChrdevStr(def->serials[i], + &b_info->u.hvm.serial_list[i]) < 0) + { + libxl_string_list_dispose(&b_info->u.hvm.serial_list); + return -1; + } + } + b_info->u.hvm.serial_list[i] = NULL; +#else virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Only one serial device is supported by libxl")); return -1; +#endif } - if (libxlMakeChrdevStr(def->serials[0], &b_info->u.hvm.serial) < 0) - return -1; } if (def->nparallels) { diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 0e26b91..5d8c9c1 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -989,6 +989,29 @@ libxlConsoleCallback(libxl_ctx *ctx, libxl_event *ev, void *for_callback) VIR_FREE(console); } } + for (i = 0; i < vm->def->nserials; i++) { + virDomainChrDefPtr chr = vm->def->serials[i]; + char *console = NULL; + int ret; + + ignore_value(virAsprintf(&chr->info.alias, "serial%zd", i)); + if (chr->source.type == VIR_DOMAIN_CHR_TYPE_PTY) { + if (chr->source.data.file.path) + continue; + ret = libxl_console_get_tty(ctx, ev->domid, + chr->target.port, + LIBXL_CONSOLE_TYPE_SERIAL, + &console); + if (!ret) { + VIR_FREE(chr->source.data.file.path); + if (console && console[0] != '\0') { + ignore_value(VIR_STRDUP(chr->source.data.file.path, + console)); + } + } + VIR_FREE(console); + } + } virObjectUnlock(vm); libxl_event_free(ctx, ev); } diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index f153f69..a34eb02 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -4450,13 +4450,6 @@ libxlDomainOpenConsole(virDomainPtr dom, virCheckFlags(VIR_DOMAIN_CONSOLE_FORCE, -1); - if (dev_name) { - /* XXX support device aliases in future */ - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Named device aliases are not supported")); - goto cleanup; - } - if (!(vm = libxlDomObjFromDomain(dom))) goto cleanup; @@ -4472,8 +4465,16 @@ libxlDomainOpenConsole(virDomainPtr dom, } priv = vm->privateData; + if (dev_name) { + size_t i; - if (vm->def->nconsoles) { + for (i = 0; !chr && i < vm->def->nserials; i++) { + if (STREQ(dev_name, vm->def->serials[i]->info.alias)) { + chr = vm->def->serials[i]; + break; + } + } + } else if (vm->def->nconsoles) { chr = vm->def->consoles[0]; if (chr->targetType == VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL) chr = vm->def->serials[0]; -- 2.6.5

2 1

[libvirt] [PATCH 0/2] libxl USB vendor/product support
by Cédric Bosdonnat 10 Aug '16

10 Aug '16

Hi all, Libxl API only allows providing bus/dev for USB hostdevs. If libvirt libxl driver users provide vendor/product they get an error, instead search for the corresponding bus/dev pair and feed them to libxl. Cédric Bosdonnat (2): Add virHostdevFindUSBDevice to private symbols libxl: allow vendor/product addressing for USB hostdevs src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 25 +++++++++++++++++-------- src/util/virhostdev.c | 2 +- src/util/virhostdev.h | 6 ++++++ 4 files changed, 25 insertions(+), 9 deletions(-) -- 2.6.6

2 4

[libvirt] [PATCH jenkins-ci 00/19] Use jenkins-job-builder for CI
by Daniel P. Berrange 10 Aug '16

10 Aug '16

We are using the CentOS Jenkins server for running CI tasks. Currently those tasks are maintained by people manually updating the Jenkins web UI. This is a horrible interface that requires 100's of mouse clicks to achieve even the simplest things. It is also incredibly hard to compare the config of different jobs to make sure they are working in a consistent manner. Fortunately there are tools which can help - OpenStack created the jenkins-job-builder tool which uses the Jenkins REST API to create/update jobs from a simple YAML file definition. This series thus creates a set of YAML files which will (almost) replicate our current manually create config. I've used jenkins-job-builder in offline test mode to generate Jenkins XML files and then compared them to what we currently have and they are mostly the same. So there should not be too many suprises lurking, but I do still expect some accidental breakage in places. As such I have not actually uploaded the new auto-generated job configs to ci.centos.org at this time. The intention is that these configs will all live in the libvirt GIT server in a new 'libvirt-jenkins-ci' repository Daniel P. Berrange (19): jobs: add global default variables jobs: add a template for generic build process jobs: add a template for GNU autotools jobs: add a template for Python distutils jobs: add a template for Perl ExtUtils::MakeMaker jobs: add a template for Perl Module::Build projects: add the libvirt package projects: add the libvirt-python package projects: add the libvirt-perl package projects: add the libvirt-tck package projects: add the libvirt-glib package projects: add the libvirt-sandbox package projects: add the osinfo-db-tools package projects: add the osinfo-db package projects: add the libvirt-cim package projects: add the virt-viewer package projects: add the virt-manager package projects: add the libosinfo package Add README explaining how to use it README | 34 ++++++++ jobs/autotools.yaml | 198 ++++++++++++++++++++++++++++++++++++++++++ jobs/defaults.yaml | 11 +++ jobs/generic.yaml | 124 ++++++++++++++++++++++++++ jobs/perl-makemaker.yaml | 105 ++++++++++++++++++++++ jobs/perl-modulebuild.yaml | 104 ++++++++++++++++++++++ jobs/python-distutils.yaml | 99 +++++++++++++++++++++ projects/libosinfo.yaml | 20 +++++ projects/libvirt-cim.yaml | 24 +++++ projects/libvirt-glib.yaml | 20 +++++ projects/libvirt-perl.yaml | 18 ++++ projects/libvirt-python.yaml | 18 ++++ projects/libvirt-sandbox.yaml | 19 ++++ projects/libvirt-tck.yaml | 16 ++++ projects/libvirt.yaml | 44 ++++++++++ projects/osinfo-db-tools.yaml | 19 ++++ projects/osinfo-db.yaml | 24 +++++ projects/virt-manager.yaml | 19 ++++ projects/virt-viewer.yaml | 19 ++++ 19 files changed, 935 insertions(+) create mode 100644 README create mode 100644 jobs/autotools.yaml create mode 100644 jobs/defaults.yaml create mode 100644 jobs/generic.yaml create mode 100644 jobs/perl-makemaker.yaml create mode 100644 jobs/perl-modulebuild.yaml create mode 100644 jobs/python-distutils.yaml create mode 100644 projects/libosinfo.yaml create mode 100644 projects/libvirt-cim.yaml create mode 100644 projects/libvirt-glib.yaml create mode 100644 projects/libvirt-perl.yaml create mode 100644 projects/libvirt-python.yaml create mode 100644 projects/libvirt-sandbox.yaml create mode 100644 projects/libvirt-tck.yaml create mode 100644 projects/libvirt.yaml create mode 100644 projects/osinfo-db-tools.yaml create mode 100644 projects/osinfo-db.yaml create mode 100644 projects/virt-manager.yaml create mode 100644 projects/virt-viewer.yaml -- 2.7.4

3 38

[libvirt] [PATCH] qemu: fix qemu.conf security_driver
by Cole Robinson 10 Aug '16

10 Aug '16

Since a9331394 (first release v2.1.0), specifying a manual security_driver setting in qemu.conf causes the daemon to fail to start, erroring with 'Duplicate security driver X'. The duplicate checking was incorrectly comparing every entry against itself, guaranteeing a false positive. https://bugzilla.redhat.com/show_bug.cgi?id=1365607 --- src/qemu/qemu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index b51f36f..7b971f1 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -436,7 +436,7 @@ int virQEMUDriverConfigLoadFile(virQEMUDriverConfigPtr cfg, goto cleanup; for (i = 0; cfg->securityDriverNames && cfg->securityDriverNames[i] != NULL; i++) { - for (j = i; cfg->securityDriverNames[j] != NULL; j++) { + for (j = i + 1; cfg->securityDriverNames[j] != NULL; j++) { if (STREQ(cfg->securityDriverNames[i], cfg->securityDriverNames[j])) { virReportError(VIR_ERR_CONF_SYNTAX, -- 2.7.4

2 1

[libvirt] [PATCH 0/3] Couple of virNetDevMacVLanCreateWithVPortProfile fixes
by Michal Privoznik 10 Aug '16

10 Aug '16

Le sigh. How come this slipped uncaught for that long? Michal Privoznik (3): virNetDevMacVLanCreateWithVPortProfile: Don't mask virNetDevMacVLanTapOpen error virNetDevMacVLanCreateWithVPortProfile: Drop @rc virNetDevMacVLanCreateWithVPortProfile: Drop @ret src/util/virnetdevmacvlan.c | 37 ++++++++++++++----------------------- 1 file changed, 14 insertions(+), 23 deletions(-) -- 2.8.4

2 6

[libvirt] [PATCH] virt-admin: Fix the error when an invalid URI has been provided
by Erik Skultety 10 Aug '16

10 Aug '16

After commit 9d479dd1 fiddled with the cmdConnect's output which used to be a bit more verbose prior to the mentioned commit, the program flow would result in a quite confusing error if an invalid URI has been provided: error: Failed to connect to the admin server Connected to the admin server error: <some error> The problem is that the commit mentioned above relied on the fact that connect routine always succeeds which is not true. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- tools/virt-admin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virt-admin.c b/tools/virt-admin.c index 2ae05da..513054b 100644 --- a/tools/virt-admin.c +++ b/tools/virt-admin.c @@ -351,7 +351,7 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd) } vshAdmReconnect(ctl); - if (!connected) + if (!connected && priv->conn) vshPrint(ctl, "%s\n", _("Connected to the admin server")); return !!priv->conn; -- 2.5.5

2 2

[libvirt] [PATCH 0/4] Fix host-model CPUs on hosts with CMT
by Jiri Denemark 10 Aug '16

10 Aug '16

Since the introduction of CMT features (commit v1.3.5-461-gf294b83) starting a domain with host-model CPU on a host which supports CMT fails because QEMU complains about unknown 'cmt' feature: qemu-system-x86_64: CPU feature cmt not found https://bugzilla.redhat.com/show_bug.cgi?id=1355857 Jiri Denemark (4): cpu_x86: Introduce x86FeatureIsMigratable cpu_x86: Properly drop non-migratable features tests: Add a test for host-model CPU with CMT feature cpu_x86: Fix host-model CPUs on hosts with CMT src/cpu/cpu_x86.c | 53 +++++++++++++++------- .../qemuxml2argv-cpu-host-model-cmt.args | 22 +++++++++ .../qemuxml2argv-cpu-host-model-cmt.xml | 19 ++++++++ tests/qemuxml2argvtest.c | 1 + tests/testutilsqemu.c | 1 + 5 files changed, 79 insertions(+), 17 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-cmt.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-host-model-cmt.xml -- 2.9.2

2 6

[libvirt] [PATCH] virsh: clarify snapshot --live
by Chen Hanxiao 10 Aug '16

10 Aug '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> In libvirt, snapshot means disk snapshot. snapshot --live is more like VM checkpoint. Make it clear in virsh.pod. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- tools/virsh.pod | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index fc6a680..30e6bf3 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3896,8 +3896,9 @@ this. If this flag is not specified, then some hypervisors may fail after partially performing the action, and B<dumpxml> must be used to see whether any partial changes occurred. -If I<--live> is specified, libvirt takes the snapshot while the guest is -running. This increases the size of the memory image of the external +If I<--live> is specified, libvirt takes the snapshot(checkpoint) while +the guest is running. Both disk snapshot and VM memory snapshot will be took. +This increases the size of the memory image of the external checkpoint. This is currently supported only for external checkpoints. Existence of snapshot metadata will prevent attempts to B<undefine> -- 1.8.3.1

2 2

[libvirt] [RFC] Design executing commands from within domains
by Michal Privoznik 10 Aug '16

10 Aug '16

Dear list, while wiring qemu-ga into libvirt I've noticed that it has ability to spawn commands inside guest. I haven't paid much attention to it then as implementing libvirt <-> qemu-ga communication was more important. But lately couple of requests on the list showed up where ability to spawn various commands inside guests would be much appreciated (e.g. when fetching some stats that HV can't know or has no support for yet - free/df/..). When it comes to spawning commands we distinguish two modes: sync and async. I think we should stick to this on the public API level too. Yet better, we can have async APIs and the sync API would just be a wrapper around async then. One picture instead of thousand words: /* obtain conn and dom somehow */ const char argv[] = {"argv1", "argv2", "argv3", ...} size_t argc = ARRAY_CARDINALITY(argv); unsigned int flags = 0; virDomainCommandPtr cmd = virDomainCommandNew("/path/to/binary", argv, argc, flags); /* Should we care about env too? */ virStreamPtr st = virSreamNew(conn, VIR_STREAM_NONBLOCK); virDomainCommandRun(dom, cmd, st, VIR_COMMAND_STRING_IO); virStreamEventAddCallback(st, VIR_STREAM_EVENT_READABLE, domainCommandCallback, ...); /* ... */ virDomainCommandJoin(dom, cmd); virStreamEventRemoveCallback(con->st) virDomainCommandFree(cmd); While qemu-ga can handle input for a binary its executing, this must be put right into JSON when constructing the qemu-ga command. It's not common that by that time users know the input they want to enter. So I have to figure out something. Opinions? Michal

4 9

[libvirt] [PATCH 0/3] Adjust device compat. rules for dmi-to-pci-bridge and pcie-bus-expander
by Laine Stump 09 Aug '16

09 Aug '16

I got a few things wrong in the original implementation. Details in the individual patches. Laine Stump (3): conf: improve error log when PCI devices don't match requested controller conf: don't allow connecting upstream-port directly to pce-expander-bus conf: restrict where dmi-to-pci-bridge can be connected docs/formatdomain.html.in | 24 ++++--- src/conf/domain_addr.c | 79 ++++++++++++---------- src/conf/domain_addr.h | 4 +- .../qemuxml2argv-q35-dmi-bad-address1.xml | 39 +++++++++++ .../qemuxml2argv-q35-dmi-bad-address2.xml | 39 +++++++++++ tests/qemuxml2argvtest.c | 16 +++++ 6 files changed, 155 insertions(+), 46 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-dmi-bad-address1.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-dmi-bad-address2.xml -- 2.7.4

2 12

[libvirt] [PATCH v3] virsh: Introduce nodedev-event command
by Jovanka Gulicoska 09 Aug '16

09 Aug '16

Add nodedev-event support for node device lifecycle events --- tools/virsh-nodedev.c | 187 ++++++++++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 18 +++++ 2 files changed, 205 insertions(+) diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index a715b61..d3d3fc1 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -31,6 +31,7 @@ #include "viralloc.h" #include "virfile.h" #include "virstring.h" +#include "virtime.h" #include "conf/node_device_conf.h" /* @@ -739,6 +740,186 @@ cmdNodeDeviceReset(vshControl *ctl, const vshCmd *cmd) return ret; } +/* + * "nodedev-event" command + */ +VIR_ENUM_DECL(virshNodeDeviceEvent) +VIR_ENUM_IMPL(virshNodeDeviceEvent, + VIR_NODE_DEVICE_EVENT_LAST, + N_("Created"), + N_("Deleted")) + +static const char * +virshNodeDeviceEventToString(int event) +{ + const char *str = virshNodeDeviceEventTypeToString(event); + return str ? _(str) : _("unknown"); +} + +struct virshNodeDeviceEventData { + vshControl *ctl; + bool loop; + bool timestamp; + int count; +}; +typedef struct virshNodeDeviceEventData virshNodeDeviceEventData; + +VIR_ENUM_DECL(virshNodeDeviceEventId) +VIR_ENUM_IMPL(virshNodeDeviceEventId, + VIR_NODE_DEVICE_EVENT_ID_LAST, + "lifecycle") + +static void +vshEventLifecyclePrint(virConnectPtr conn ATTRIBUTE_UNUSED, + virNodeDevicePtr dev, + int event, + int detail ATTRIBUTE_UNUSED, + void *opaque) +{ + virshNodeDeviceEventData *data = opaque; + + if (!data->loop && data->count) + return; + + if (data->timestamp) { + char timestamp[VIR_TIME_STRING_BUFLEN]; + + if (virTimeStringNowRaw(timestamp) < 0) + timestamp[0] = '\0'; + + vshPrint(data->ctl, _("%s: event 'lifecycle' for node device %s: %s\n"), + timestamp, + virNodeDeviceGetName(dev), virshNodeDeviceEventToString(event)); + } else { + vshPrint(data->ctl, _("event 'lifecycle' for node device %s: %s\n"), + virNodeDeviceGetName(dev), virshNodeDeviceEventToString(event)); + } + + data->count++; + if (!data->loop) + vshEventDone(data->ctl); +} + +static const vshCmdInfo info_node_device_event[] = { + {.name = "help", + .data = N_("Node Device Events") + }, + {.name = "desc", + .data = N_("List event types, or wait for node device events to occur") + }, + {.name = NULL} +}; + +static const vshCmdOptDef opts_node_device_event[] = { + {.name = "device", + .type = VSH_OT_STRING, + .help = N_("filter by node device name") + }, + {.name = "event", + .type = VSH_OT_STRING, + .help = N_("which event type to wait for") + }, + {.name = "loop", + .type = VSH_OT_BOOL, + .help = N_("loop until timeout or interrupt, rather than one-shot") + }, + {.name = "timeout", + .type = VSH_OT_INT, + .help = N_("timeout seconds") + }, + {.name = "list", + .type = VSH_OT_BOOL, + .help = N_("list valid event types") + }, + {.name = "timestamp", + .type = VSH_OT_BOOL, + .help = N_("show timestamp for each printed event") + }, + {.name = NULL} +}; + +static bool +cmdNodeDeviceEvent(vshControl *ctl, const vshCmd *cmd) +{ + virNodeDevicePtr dev = NULL; + bool ret = false; + int eventId = -1; + int timeout = 0; + virshNodeDeviceEventData data; + const char *eventName = NULL; + const char *device_value = NULL; + int event; + virshControlPtr priv = ctl->privData; + + if (vshCommandOptBool(cmd, "list")) { + size_t i; + + for (i = 0; i < VIR_NODE_DEVICE_EVENT_ID_LAST; i++) + vshPrint(ctl, "%s\n", virshNodeDeviceEventIdTypeToString(i)); + return true; + } + + if (vshCommandOptStringReq(ctl, cmd, "event", &eventName) < 0) + return false; + if (!eventName) { + vshError(ctl, "%s", _("either --list or event type is required")); + return false; + } + if ((event = virshNodeDeviceEventIdTypeFromString(eventName)) < 0) { + vshError(ctl, _("unknown event type %s"), eventName); + return false; + } + + data.ctl = ctl; + data.loop = vshCommandOptBool(cmd, "loop"); + data.timestamp = vshCommandOptBool(cmd, "timestamp"); + data.count = 0; + if (vshCommandOptTimeoutToMs(ctl, cmd, &timeout) < 0) + return false; + if (vshCommandOptStringReq(ctl, cmd, "device", &device_value) < 0) + return false; + + if (device_value) { + if (!(dev = virNodeDeviceLookupByName(priv->conn, device_value))) { + vshError(ctl, "%s '%s'", + _("Could not find matching device"), device_value); + goto cleanup; + } + } + if (vshEventStart(ctl, timeout) < 0) + goto cleanup; + + if ((eventId = virConnectNodeDeviceEventRegisterAny(priv->conn, dev, event, + VIR_NODE_DEVICE_EVENT_CALLBACK(vshEventLifecyclePrint), + &data, NULL)) < 0) + goto cleanup; + switch (vshEventWait(ctl)) { + case VSH_EVENT_INTERRUPT: + vshPrint(ctl, "%s", _("event loop interrupted\n")); + break; + case VSH_EVENT_TIMEOUT: + vshPrint(ctl, "%s", _("event loop timed out\n")); + break; + case VSH_EVENT_DONE: + break; + default: + goto cleanup; + } + vshPrint(ctl, _("events received: %d\n"), data.count); + if (data.count) + ret = true; + + cleanup: + vshEventCleanup(ctl); + if (eventId >= 0 && + virConnectNodeDeviceEventDeregisterAny(priv->conn, eventId) < 0) + ret = false; + if (dev) + virNodeDeviceFree(dev); + return ret; +} + + const vshCmdDef nodedevCmds[] = { {.name = "nodedev-create", .handler = cmdNodeDeviceCreate, @@ -788,5 +969,11 @@ const vshCmdDef nodedevCmds[] = { .info = info_node_device_reset, .flags = 0 }, + {.name = "nodedev-event", + .handler = cmdNodeDeviceEvent, + .opts = opts_node_device_event, + .info = info_node_device_event, + .flags = 0 + }, {.name = NULL} }; diff --git a/tools/virsh.pod b/tools/virsh.pod index 97d16c5..a6e9516 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2958,6 +2958,24 @@ a node device between guest passthrough or the host. Libvirt will often do this action implicitly when required, but this command allows an explicit reset when needed. +=item B<nodedev-event> {[I<nodedev>] I<event> [I<--loop>] [I<--timeout> +I<seconds>] [I<--timestamp>] | I<--list>} + +Wait for a class of node device events to occur, and print appropriate +details of events as they happen. The events can optionally be filtered +by I<nodedev>. Using I<--list> as the only argument will provide a list +of possible I<event> values known by this client, although the connection +might not allow registering for all these events. + +By default, this command is one-shot, and returns success once an event +occurs; you can send SIGINT (usually via C<Ctrl-C>) to quit immediately. +If I<--timeout> is specified, the command gives up waiting for events +after I<seconds> have elapsed. With I<--loop>, the command prints all +events until a timeout or interrupt key. + +When I<--timestamp> is used, a human-readable timestamp will be printed +before the event. + =back =head1 VIRTUAL NETWORK COMMANDS -- 2.7.4

2 1

[libvirt] [PATCH] virt-admin: Properly fix the default session daemon URI to admin server
by Erik Skultety 09 Aug '16

09 Aug '16

Commit 30ce2f0e tried to fix the issue with an incorrect session URI to admin server but it messed up the checks: if (geteuid == 0 && VIR_STRDUP(*uristr, "libvirtd:///system") < 0) return -1; else if (VIR_STRDUP(*uristr, "libvirtd:///session") < 0) return -1; So if a client executed with root privileges tries to connect, its euid is checked (true) and the correct URI is successfully copied to @uristr (false), therefore the 'else' branch is taken and @uristr is replaced by the session URI which for root results in: Failed to connect socket to '/root/.cache/libvirt/libvirt-admin-sock': No such file or directory Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/libvirt-admin.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index 4552e84..03245b6 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -179,11 +179,13 @@ virAdmGetDefaultURI(virConfPtr conf, char **uristr) * we set the default admin server URI to 'libvirtd:///system' or * 'libvirtd:///session' depending on the process's EUID. */ - if (geteuid() == 0 && - VIR_STRDUP(*uristr, "libvirtd:///system") < 0) + if (geteuid() == 0) { + if (VIR_STRDUP(*uristr, "libvirtd:///system") < 0) return -1; - else if (VIR_STRDUP(*uristr, "libvirtd:///session") < 0) + } else { + if (VIR_STRDUP(*uristr, "libvirtd:///session") < 0) return -1; + } } } -- 2.5.5

2 2

[libvirt] [PATCH] admin: Fix the default uri for session daemon to libvirtd:///session
by Erik Skultety 09 Aug '16

09 Aug '16

Just like we decide on which URI we go with based on EUID for qemu in remote driver, do a similar thing for admin except we do not spawn a daemon in this case. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1356858 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/libvirt-admin.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/libvirt-admin.c b/src/libvirt-admin.c index 4bf29b1..4552e84 100644 --- a/src/libvirt-admin.c +++ b/src/libvirt-admin.c @@ -176,10 +176,14 @@ virAdmGetDefaultURI(virConfPtr conf, char **uristr) /* Since we can't probe connecting via any hypervisor driver as libvirt * does, if no explicit URI was given and neither the environment * variable, nor the configuration parameter had previously been set, - * we set the default admin server URI to 'libvirtd://system'. + * we set the default admin server URI to 'libvirtd:///system' or + * 'libvirtd:///session' depending on the process's EUID. */ - if (VIR_STRDUP(*uristr, "libvirtd:///system") < 0) - return -1; + if (geteuid() == 0 && + VIR_STRDUP(*uristr, "libvirtd:///system") < 0) + return -1; + else if (VIR_STRDUP(*uristr, "libvirtd:///session") < 0) + return -1; } } -- 2.5.5

4 5

[libvirt] vfio: Error: Failed to setup INTx fd: Device or resource busy when PF pass-thought duel port NIC
by Moshe Levi 09 Aug '16

09 Aug '16

Hi, I am trying to PF pass-thought with Mellanox NIC CX4 with duel port card. I know the currently it doesn't support ACS, therefore we can't allocate 2 PF to 2 guest. (both pci device are in the same IOMMU group) But if I understand accoriding to [1] this currently there should be a problem to pass-thought both PFs to the same guest. before we boot the guest I unbind the pci device with the following commands. echo 0000:03:00.00> /sys/bus/pci/devices/0000:03:00.00/driver/unbind echo 0000:03:00.01 > /sys/bus/pci/devices/0000:03:00.1/driver/unbind I tried it worked and it was working on one environment , but on other environment we are getting the following error vfio: Error: Failed to setup INTx fd: Device or resource busy. See detail error [2]. Can anyone explain when/why this error occurs? And how can we fix it? [1] - http://vfio.blogspot.co.il/2014/08/iommu-groups-inside-and-out.html [2] - Nova-compute.log error: 2016-08-08 21:20:14.213 20236 ERROR nova.virt.libvirt.guest [req-5a6532d4-317f-4165-855e-37d8b36c71ec 295fe519b3864de5894fa0219362c26f 2e4cb36a0a3645e7b924deecea3bd210 - - -] Error launching a defined domain with XML: <domain type='kvm'> <name>instance-00000040</name> <uuid>74abfd25-aab6-4362-ab28-49c3bbd5e508</uuid> <metadata> <nova:instance xmlns:nova="http://openstack.org/xmlns/libvirt/nova/1.0"> <nova:package version="12.0.3-1.el7ost"/> <nova:name>Test</nova:name> <nova:creationTime>2016-08-08 21:20:08</nova:creationTime> <nova:flavor name="Mellanox_PT_2"> <nova:memory>16384</nova:memory> <nova:disk>0</nova:disk> <nova:swap>0</nova:swap> <nova:ephemeral>0</nova:ephemeral> <nova:vcpus>16</nova:vcpus> </nova:flavor> <nova:owner> <nova:user uuid="295fe519b3864de5894fa0219362c26f">admin</nova:user> <nova:project uuid="2e4cb36a0a3645e7b924deecea3bd210">openstack</nova:project> </nova:owner> <nova:root type="image" uuid="49d20d6e-e247-43ff-aeec-84ba53d6b439"/> </nova:instance> </metadata> <memory unit='KiB'>16777216</memory> <currentMemory unit='KiB'>16777216</currentMemory> <vcpu placement='static' cpuset='3-23,27-47'>16</vcpu> <cputune> <shares>16384</shares> </cputune> <sysinfo type='smbios'> <system> <entry name='manufacturer'>Red Hat</entry> <entry name='product'>OpenStack Compute</entry> <entry name='version'>12.0.3-1.el7ost</entry> <entry name='serial'>d336b2a1-4abd-4602-9bc4-4aeb20f778e7</entry> <entry name='uuid'>74abfd25-aab6-4362-ab28-49c3bbd5e508</entry> <entry name='family'>Virtual Machine</entry> </system> </sysinfo> <os> <type arch='x86_64' machine='pc-i440fx-rhel7.2.0'>hvm</type> <boot dev='hd'/> <smbios mode='sysinfo'/> </os> <features> <acpi/> <apic/> </features> <cpu mode='host-model'> <model fallback='allow'/> <topology sockets='16' cores='1' threads='1'/> </cpu> <clock offset='utc'> <timer name='pit' tickpolicy='delay'/> <timer name='rtc' tickpolicy='catchup'/> <timer name='hpet' present='no'/> </clock> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>destroy</on_crash> <devices> <emulator>/usr/libexec/qemu-kvm</emulator> <disk type='file' device='disk'> <driver name='qemu' type='qcow2' cache='none'/> <source file='/var/lib/nova/instances/74abfd25-aab6-4362-ab28-49c3bbd5e508/disk'/> <target dev='vda' bus='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x04' function='0x0'/> </disk> <controller type='usb' index='0'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> </controller> <controller type='pci' index='0' model='pci-root'/> <interface type='bridge'> <mac address='fa:16:3e:14:ec:96'/> <source bridge='qbre5243bb0-8e'/> <target dev='tape5243bb0-8e'/> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x03' function='0x0'/> </interface> <serial type='file'> <source path='/var/lib/nova/instances/74abfd25-aab6-4362-ab28-49c3bbd5e508/console.log'/> <target port='0'/> </serial> <serial type='pty'> <target port='1'/> </serial> <console type='file'> <source path='/var/lib/nova/instances/74abfd25-aab6-4362-ab28-49c3bbd5e508/console.log'/> <target type='serial' port='0'/> </console> <input type='tablet' bus='usb'/> <input type='mouse' bus='ps2'/> <input type='keyboard' bus='ps2'/> <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0' keymap='en-us'> <listen type='address' address='0.0.0.0'/> </graphics> <video> <model type='cirrus' vram='16384' heads='1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> </video> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x03' slot='0x00' function='0x1'/> </source> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </hostdev> <hostdev mode='subsystem' type='pci' managed='yes'> <source> <address domain='0x0000' bus='0x03' slot='0x00' function='0x0'/> </source> <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> </hostdev> <memballoon model='virtio'> <stats period='10'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </memballoon> </devices> </domain> 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [req-5a6532d4-317f-4165-855e-37d8b36c71ec 295fe519b3864de5894fa0219362c26f 2e4cb36a0a3645e7b924deecea3bd210 - - -] [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] Instance failed to spawn 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] Traceback (most recent call last): 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 2156, in _build_resources 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] yield resources 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/nova/compute/manager.py", line 2009, in _build_and_run_instance 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] block_device_info=block_device_info) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 2585, in spawn 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] block_device_info=block_device_info) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 4699, in _create_domain_and_network 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] xml, pause=pause, power_on=power_on) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/driver.py", line 4629, in _create_domain 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] guest.launch(pause=pause) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/guest.py", line 142, in launch 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] self._encoded_xml, errors='ignore') 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/oslo_utils/excutils.py", line 204, in __exit__ 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] six.reraise(self.type_, self.value, self.tb) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/nova/virt/libvirt/guest.py", line 137, in launch 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] return self._domain.createWithFlags(flags) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/eventlet/tpool.py", line 183, in doit 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] result = proxy_call(self._autowrap, f, *args, **kwargs) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/eventlet/tpool.py", line 141, in proxy_call 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] rv = execute(f, *args, **kwargs) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/eventlet/tpool.py", line 122, in execute 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] six.reraise(c, e, tb) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib/python2.7/site-packages/eventlet/tpool.py", line 80, in tworker 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] rv = meth(*args, **kwargs) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] File "/usr/lib64/python2.7/site-packages/libvirt.py", line 1059, in createWithFlags 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] if ret == -1: raise libvirtError ('virDomainCreateWithFlags() failed', dom=self) 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] libvirtError: internal error: early end of file from monitor: possible problem: 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] 2016-08-08T21:20:13.577395Z qemu-kvm: -device vfio-pci,host=03:00.0,id=hostdev1,bus=pci.0,addr=0x6: vfio: Error: Failed to setup INTx fd: Device or resource busy 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] 2016-08-08T21:20:13.578216Z qemu-kvm: -device vfio-pci,host=03:00.0,id=hostdev1,bus=pci.0,addr=0x6: Device initialization failed 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] 2016-08-08T21:20:13.578231Z qemu-kvm: -device vfio-pci,host=03:00.0,id=hostdev1,bus=pci.0,addr=0x6: Device 'vfio-pci' could not be initialized 2016-08-08 21:20:14.214 20236 ERROR nova.compute.manager [instance: 74abfd25-aab6-4362-ab28-49c3bbd5e508] 2016-08-08 21:20:54.118 20236 WARNING nova.compute.manager [req-d1bd757e-ab71-472b-8555-935bfbecbe89 - - - - -] Bandwidth usage not supported by hypervisor.

1 0

[libvirt] ANNOUNCE: libguestfs 1.34 released
by Richard W.M. Jones 08 Aug '16

08 Aug '16

I'm pleased to announce libguestfs 1.34, a library and set of tools for accessing and modifying virtual machine disk images. This release took about 8 months of work by many contributors. Amongst the new features are large performance improvements, substantial enhancements to virt-p2v & virt-v2v, better SELinux support, and APIs for doing forensic analysis of disk images. See the release notes below for full details. You can get libguestfs 1.34 here: Main website: http://libguestfs.org/ Source: http://libguestfs.org/download/1.34-stable/ Fedora 24: http://koji.fedoraproject.org/koji/packageinfo?packageID=8391 It will appear as an update for F24 in about a week. Fedora 25: (blocked on RHBZ#1365270) Debian/experimental: https://packages.debian.org/libguestfs0 Rich. Release notes (also available online at http://libguestfs.org/guestfs-release-notes.1.html ): New features Multiple performance enhancements were made in libguestfs. The "hot cache" time to launch to appliance should be under 1 second assuming recent qemu and kernel are installed. There are also new utilities for precisely benchmarking libguestfs (utils/boot-benchmark and utils/boot-analysis in the source tree). The virt-p2v tool for converting physical machines to virtual machines was substantially improved. This includes: clearer, coloured output during conversions, support for Gtk 3, more detailed information about hardware, click to identify network interfaces, more debugging tools included with the ISO, and many bug fixes. f2fs (Flash Friendly File System) is now supported (Pino Toscano). New tools virt-p2v-make-kiwi(1) can be used to build the virt-p2v ISO based on SLES and openSUSE, using the kiwi utility (Cédric Bosdonnat). New features in existing tools virt-resize will now preserve the GPT GUID. This was required for Windows Server 2012 R2, where the bootloader would become confused if the GUID changed (Maxim Perevedentsev). virt-resize will use sparse copying for (old MBR-style) extended partitions. This makes resizing of guests that use extended partitions much faster (Maxim Perevedentsev). virt-p2v kernel command line options can now be used to set defaults for GUI configuration. The virt-p2v debugging options have been completely removed, simplifying the interface and documentation. Debugging information is now captured fully automatically. virt-p2v-make-disk lets you specify an --arch option, allowing you to build a 32 bit virt-p2v, for compatibility with older systems. virt-p2v-make-disk no longer requires that you specify an "os-version" for the virt-p2v disk. If omitted it will try to choose a suitable "os-version" depending on your host system. virt-p2v-make-disk and virt-p2v-make-kickstart both gain a new --install option that allows you to add arbitrary extra packages to the virt-p2v ISO, for customization, additional debugging tools and so on. virt-v2v will now uninstall Parallels Tools (or the equivalent Virtuozzo Tools) from Linux guests. Also stop the Windows drivers from loading at boot. (Roman Kagan and Pavel Butsykin) virt-v2v --in-place mode has been enhanced to allow the caller to choose whether or not to install certain virtio drivers in the guest (Roman Kagan). virt-v2v conversion of Windows guests was substantially rewritten and simplified (Roman Kagan). virt-v2v --in-place mode now supports installing virtio-scsi drivers in guests (Roman Kagan). virt-v2v can now convert SUSE guests and SUSE guests using UEFI (Cédric Bosdonnat and Jim Fehlig). virt-v2v can now convert guests to Glance that have multiple disks. Previously it would fail on such guests. The virt-v2v --no-trim and --vmtype options are now no-ops. They will print a warning but are otherwise ignored. virt-v2v can now generate the OVF vmtype correctly without user intervention. virt-v2v has now been tested against Citrix Xen as a source hypervisor (Cédric Bosdonnat). virt-v2v adds support for SUSE VMDP drivers (Cédric Bosdonnat). virt-v2v can convert OVA files containing subfolders, as produced by SUSE Studio (Cédric Bosdonnat). virt-v2v sets the OVF "<Origin>" element correctly. oVirt has been extended to support more source hypervisors (Shahar Havivi). virt-v2v now supports Windows Server 2016 (Tomáš Golembiovský). The virt-builder --list option can now be used to show all templates or a single template (Pino Toscano). All OCaml-based tools now use getopt_long(3) for option parsing, and --help output has been improved (Pino Toscano). virt-builder and virt-customize --selinux-relabel option can now fully relabel the guest filesystem at build time, without requiring a lengthy autorelabel at first boot. virt-customize --delete now accepts globs. New virt-customize --uninstall option lets you uninstall packages. virt-customize can now use "pvvxsvc" as an alternative to "rhsrvany" for running firstboot scripts in Windows guests (Cédric Bosdonnat). virt-customize now uses the strongest hashing scheme for passwords on Arch and Void Linux (Pino Toscano). virt-customize --install now works correctly on Arch (Pino Toscano). virt-inspector has new options --no-applications and --no-icon to prevent the list of applications and icon from being included in the XML output (Pino Toscano). New virt-sysprep --network option has been added, allowing you to actually use the --install etc options which were present in virt- sysprep before but did not usually work. Note that the network is still disabled by default. virt-sysprep "fs-uuids" operation no longer fails on btrfs guests (Maxim Perevedentsev). virt-dib can output Docker images (Pino Toscano). virt-dib has a new --drive-format option to allow the user to specify the format of the helper drive (Pino Toscano). All OCaml virt tools now have a --colors/--colours option which enables coloured output (using ANSI escape sequences) even if the output is not a tty. The default is to check if the output is a tty and disable coloured output if not. This allows coloured output to be consumed by other tools. Language bindings PHP test coverage has been enhanced (Pino Toscano). PHP 7 is now supported (Pino Toscano). Python bindings are now compliant with PEP 8 (Pino Toscano). A Python pip package is available in http://libguestfs.org/download/python/ The Ruby bindings now print the full exception if one is thrown by the event callback. Note this is still incorrect behaviour as event callbacks should not throw exceptions, but it aids debugging. All OCaml libraries and programs are now compiled with -safe-string, if supported by the OCaml compiler. Inspection Alpine Linux using busybox can now be inspected. Also the APK package manager is supported in virt-customize (Pino Toscano). We now handle inspection of Mageia 4 (Pino Toscano). Void Linux and the Void Linux xbps package manager are fully supported (Pino Toscano). Parsing of CoreOS version information has been enhanced (Pino Toscano). It is now possible to get an icon from ALT Linux (Pino Toscano). PLD Linux versions < 3 are now recognized (Pino Toscano). Windows drive letters are now returned for guests using GPT partitions (Dawid Zamirski). We can now correctly inspect Unix guests that do not have an /etc/fstab file (Pino Toscano). Added another source for the Ubuntu icon which doesn't rely on GNOME having been installed in the guest. We can now get an icon for Windows 7 64 bit guests. Libosinfo integration was rewritten to deal with the new database format used by osinfo (Pino Toscano). Documentation New manual page guestfs-building(1) describes how to build libguestfs from source. The man pages, tools and tool --help output is now automatically checked to ensure that all tool options are properly documented, that warning sections are included where necessary, and that every page has a description section. The guestfs-testing(1) man page has been refreshed and based on a newer libguestfs. Architectures and platforms virt-customize now works on POWER7 and POWER8 platforms, both big endian and little endian (Xianghua Chen and Hu Zhang). Security See also guestfs-security(1). CVE-2015-8869 https://bugzilla.redhat.com/CVE-2015-8869 This vulnerability in OCaml might affect virt tools written in the OCaml programming language. It affects only 64 bit platforms. Because this bug affects code generation it is difficult to predict which precise software could be affected, and therefore our recommendation is that you recompile libguestfs using a version of the OCaml compiler where this bug has been fixed (or ask your Linux distro to do the same). virt-customize ownership of .ssh, .ssh/authorized_keys https://bugzilla.redhat.com/1337561 Previously when virt-customize injected an SSH key into a guest, when it created the ~/.ssh and ~/.ssh/authorized_keys directory and file (in case they were missing) it created them with owner and group "root.root". This has been fixed so the correct user is used. This is not thought to have been exploitable. Windows "%systemroot%" The inspection code has been made more robust against guests which might use very long "%systemroot%" (derived from the guest-controlled Windows Registry). This is not thought to have been exploitable. Virtio-rng is now available in the appliance virtio-rng (the virtual Random Number Generator device) is now passed to the appliance, which should improve the quality random numbers generated for GUIDs and cryptographic key generation. API New APIs "btrfs_filesystem_show" List all devices where a btrfs filesystem is spanned (Pino Toscano). "download_blocks" "download_inode" "filesystem_walk" Download filesystem data blocks from a given partition. Download arbitrary files by inode number. Retrieve all files from a filesystem including deleted files. Note these require optional dependency The Sleuth Kit. (Matteo Cafasso) "get_sockdir" Read the path where temporary sockets are stored (Pino Toscano). "mountable_device" "mountable_subvolume" Split a Mountable into device name and subvolume (Cédric Bosdonnat). "ntfscat_i" Download NTFS file by inode number (Matteo Cafasso). "part_expand_gpt" Allow in-place expanding of GPT partitions by moving the second (backup) partition table to the end of the disk (Maxim Perevedentsev). "part_get_disk_guid" "part_set_disk_guid" "part_set_disk_guid_random" Get and set the GPT disk GUID, or set it to a fresh random value (Maxim Perevedentsev). "selinux_relabel" SELinux-relabel part or all of the guest filesystem. Other API changes "guestfs_set_selinux", "guestfs_get_selinux", "guestfs_setcon", "guestfs_getcon" and "guestfs_llz" have been deprecated. Use the new API "guestfs_selinux_relabel" to relabel filesystems. Use "guestfs_lgetxattrs" to list the "security.selinux" extended attributes of existing files. "guestfs_vfs_minimum_size" can now be used on dirty filesystems (Maxim Perevedentsev). "guestfs_ll" now works on paths which contain absolute symlinks (Pino Toscano). "guestfs_glob_expand" now has an optional "directoryslash" boolean parameter which controls whether trailing slashes are returned for directory names (Pino Toscano). "guestfs_lvs" will no longer return LVs which have the "activationskip" flag set. The reason is that such LVs have no "/dev/VG/LV" device node and so code which read the list of LVs and then probed the devices themselves would immediately fail. You can use "guestfs_lvs_full" if you want to read all LVs. (Pino Toscano). "guestfs_list_disk_labels" now no longer fails if no disks with labels were added. Instead it now returns an empty list (Pino Toscano). "guestfs_is_lv" no longer fails if passed a btrfs subvolume, it returns false instead (Maxim Perevedentsev). Build changes qemu ≥ 1.3.0 is required. yajl (a JSON parsing library) is required to build libguestfs. You can now build with GCC 6. "make check-valgrind" now has substantially better coverage. "make check-slow" now works again. Use "make -C appliance clean-supermin-appliance" to clean the supermin appliance (it will be rebuilt on next "make"). There are a variety of new rules for running virt-p2v from the source directory: "make -C p2v run-virt-p2v-directly" | "run-virt-p2v-in-a-vm" | "run-virt-p2v-non-gui-conversion". These are documented further in guestfs-hacking(1). virt-p2v may be built using either Gtk 2 or Gtk 3. To force a particular version of Gtk to be used, "./configure --with-gtk=2|3" The "./configure" options are now mostly documented in guestfs-building(1). Internals In git, versions are now tagged with "v1.XX.YY" (previously they were tagged with "1.XX.YY"). Using the "v-" prefix is more common in git repositories. When using the libvirt backend, we now wait for qemu to exit gracefully instead of killing it after 15 seconds. This helps when writing to slow devices (especially cheap USB keys). Error messages from libvirt now include the "err->int1" field which usually contains the "errno". On ARM, all DTB (device tree) code has been removed. qemu creates the right device tree on the fly, we do not need to specify one. The C API tests now use larger test disks, allowing BTRFS to be tested properly (Pino Toscano). The tests should now work on a pure Python 3 host (Pino Toscano). In C bindings, internal functions are now (mostly) consistently named "guestfs_int_*" whereas previously there was no consistent scheme. The old "safe_malloc" etc functions are now no longer exported by the library, nor used in language bindings. Setting TMPDIR to a path longer than ~ 100 characters will no longer cause libguestfs to fail silently and randomly when creating Unix domain sockets (Pino Toscano). The "COMPILE_REGEXP" macro can now be used in the daemon. When tracing, results containing structs are now printed in full (Pino Toscano). The Perl "Sys::Guestfs" module now no longer embeds an incrementing API "version number". This module is now always at phony version "1.0". To find the real version of libguestfs from Perl you must call "$g->version". All code is compiled with "-Wstack-usage=10000" and multiple changes have been made to remove stack allocation of large strings and buffers. The error(3) function is now used everywhere, replacing most previous uses of perror(3) + exit(3), and fprintf(3) + exit. In C code, "/**" comments are turned into documentation which is automatically added to the guestfs-hacking(1) manual page. A safe "getumask" function has been added. For recent Linux kernels this uses the newly added "Umask" field in /proc/self/status. For older Linux and other Unix, this uses a thread-safe technique involving fork(2) (thanks: Josh Stone, Jiri Jaburek, Eric Blake). Safe posix_fadvise(2) wrappers have been added, and more hints have been added to the code which may make a minor difference to performance. A safe wrapper around waitpid(2) has been added which handles "INTR" properly. "podwrapper.pl" (used to generate the manual pages) now stops if any POD error is found. A new script called "podcheck.pl" does cross- checking of --help output, tool options and manual pages. All version numbers in the library (eg. versions of qemu, versions of libvirt, versions of guest operating systems) are unified in a single file src/version.c (Pino Toscano). On Windows guests, virt-customize will use the vendor-neutral path "C:\Program Files\Guestfs\Firstboot" to store firstboot scripts. Previously it used "C:\Program Files\Red Hat\Firstboot". This change should be invisible to the scripts themselves. (Cédric Bosdonnat) On Linux guests, the firstboot services generated by virt-builder --firstboot etc have been renamed to "guestfs-firstboot" (Pino Toscano). There is now a common "debug" function used by all OCaml tools, replacing previous code which did "if verbose () then printf ...". virt-p2v copies files it needs over to the virt-v2v conversion server using scp(1), instead of trying to send them via the shell session. This should improve reliability and should be a completely transparent to end users. All code in mllib is now built into a single "mllib.cma" or "mllib.cmxa" library. All code in customize is now built into a single "customize.cma" or "customize.cmxa" library. This simplifies the build of the OCaml tools. lvmetad(8) is now used in the appliance when available (Pino Toscano). "Silent rules" are used for OCaml, Java, Erlang and POD. Use "make V=1" to see the full command lines again (Pino Toscano). Bugs fixed https://bugzilla.redhat.com/1364347 virt-sparsify --in-place failed with UEFI system https://bugzilla.redhat.com/1362357 run_command runs exit handlers when execve fails (e.g. due to missing executable) https://bugzilla.redhat.com/1362354 virt-dib failed to create image using DIB_YUM_REPO_CONF https://bugzilla.redhat.com/1359652 Fail to inspect Windows ISO file https://bugzilla.redhat.com/1358142 Some info will show when convert guest to libvirt by virt-v2v with parameter --quiet https://bugzilla.redhat.com/1354335 overlay of disk images does not specify the format of the backing file https://bugzilla.redhat.com/1352761 Virt-manager can't show OS icons of win7/win8/ubuntu guest. https://bugzilla.redhat.com/1350363 Improve error info "remote server timeout unexpectedly waiting for password prompt" when connect to a bogus server at p2v client https://bugzilla.redhat.com/1348900 virt-p2v should update error prompt when 'Test connection' with a non-existing user in conversion server https://bugzilla.redhat.com/1345813 virt-sysprep --install always failed to install the packages specified https://bugzilla.redhat.com/1345809 virt-customize --truncate-recursive should give an error message when specifying a no-existing path https://bugzilla.redhat.com/1343423 [RFE]Should give a better description about 'curl error 22' when failed using ssh identity http url at p2v client https://bugzilla.redhat.com/1343414 Failed SSH to conversion server by ssh identity http url at p2v client https://bugzilla.redhat.com/1343375 [RFE] uninstall packages inside the VM https://bugzilla.redhat.com/1342447 Ifconfig command is not supported on p2v client https://bugzilla.redhat.com/1342398 Convert a guest from RHEL by virt-v2v but its origin info shows RHEV at rhevm https://bugzilla.redhat.com/1342337 Should remind a warning about disk image has a partition when using virt-p2v-make-disk https://bugzilla.redhat.com/1341984 virt-get-kernel prompts an 'invalid value' error when using --format auto https://bugzilla.redhat.com/1341564 virt-p2v spinner should be hidden when it stops spinning https://bugzilla.redhat.com/1340809 Testing connection timeout when input regular user of conversion server with checked "use sudo......"button https://bugzilla.redhat.com/1340464 [RFE] Suggestion give user a reminder for "Cancel conversion" button https://bugzilla.redhat.com/1340407 Multiple network ports will not be aligned at p2v client https://bugzilla.redhat.com/1338083 Update UEFI whitelist for official fedora packages https://bugzilla.redhat.com/1337561 virt-customize --ssh-inject not applying correct file permission https://bugzilla.redhat.com/1335671 extra quotes around UUID confuses findfs in RHEL (but not in Fedora) https://bugzilla.redhat.com/1332025 Inspection does not parse /etc/redhat-release containing "Derived from Red Hat Enterprise Linux 7.1 (Source)" https://bugzilla.redhat.com/1327488 RFE: Allow p2v kernel options without p2v.server to set defaults https://bugzilla.redhat.com/1325825 virt-v2v should prevent using multiple '-b' and '-n' option appears on the command line https://bugzilla.redhat.com/1321620 libguestfs: error: could not parse integer in version number: 7" https://bugzilla.redhat.com/1321338 [1.33.16] Compilation Error: Unbound value List.sort_uniq in v2v.ml line 988, characters 10-24: https://bugzilla.redhat.com/1317843 `virt-builder --update` fails with: "dnf -y --best upgrade: command exited with an error" https://bugzilla.redhat.com/1316479 v2v cmd cannot exit and "block I/O error in device 'appliance': No space left on device (28)" is printed when specified "-v -x" https://bugzilla.redhat.com/1316041 virt-rescue fails, but missing error message https://bugzilla.redhat.com/1314244 RFE: virt-p2v log window should process colour escapes and backspaces https://bugzilla.redhat.com/1312254 virt-v2v -o libvirt doesn't preserve or use correct <graphics type="vnc|spice"> https://bugzilla.redhat.com/1309706 error: internal error: Invalid floppy device name: hdb https://bugzilla.redhat.com/1309619 Wrong warning info "use standard VGA" shows when converting windows > 7 by virt-v2v https://bugzilla.redhat.com/1309580 OS name of win8.1 x64 guest shows incorrect in rhevm3.6 general info https://bugzilla.redhat.com/1308769 virt-v2v does not copy additional disks to Glance https://bugzilla.redhat.com/1306666 Failure when disk contains an LV with activationskip=y https://bugzilla.redhat.com/1296606 virt-v2v doesn't remove VirtualBox additions correctly because of file quoting https://bugzilla.redhat.com/1293527 There should be a reminder to avoid user to edit a guest image by multiple tools at the same time in guestfish man page https://bugzilla.redhat.com/1293276 guestfish can not ll a symbolic link dir or edit a file in it https://bugzilla.redhat.com/1278878 guestfish should be able to handle LVM thin layouts https://bugzilla.redhat.com/1264835 ppc64le: virt-customize --install fail to detect the guest arch https://bugzilla.redhat.com/1264332 Test that trimming in virt-v2v doesn't regress https://bugzilla.redhat.com/1232192 Virt-v2v gives an error on a blank disk: part_get_parttype: unknown signature, of the output: BYT; https://bugzilla.redhat.com/1229386 virt-p2v in non-GUI mode doesn't show any conversion progress or status https://bugzilla.redhat.com/1227599 P2V invalid password prints unexpected end of file waiting for command prompt. https://bugzilla.redhat.com/1224795 On Ubuntu, virt-builder --install and --update cannot use the network https://bugzilla.redhat.com/1213324 virt-v2v: warning: unknown guest operating system: windows windows 6.3 when converting win8,win8.1,win2012,win2012R2,win10 to rhev https://bugzilla.redhat.com/1203898 Support inspecting docker images without /etc/fstab https://bugzilla.redhat.com/1186935 libguestfs cannot inspect recent Fedora / RHEL >= 7 when /usr is a separate partition https://bugzilla.redhat.com/1167916 P2V: invalid conversion server prints unexpected end of file waiting for password prompt. https://bugzilla.redhat.com/1152825 virt-rescue --selinux can not work well, when enable selinux in the command line the value of 'getenforce' is still Disabled in virt- rescue appliance https://bugzilla.redhat.com/1150298 ARM 32 bit on Ubuntu: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] https://bugzilla.redhat.com/1089100 NetworkManager avc unlink denied for resolv.conf after using --selinux-relabel https://bugzilla.redhat.com/983969 RFE: virt-sysprep should be SELinux-aware https://bugzilla.redhat.com/855058 RFE: virt-p2v: display more information about storage devices https://bugzilla.redhat.com/554829 SELinux handling could be done better. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

1 0

[libvirt] Virtqueue size exceeded error when resuming VM
by Moshe Levi 08 Aug '16

08 Aug '16

Hi, A new security fix [1],[2] and [3] merged to qemu. After updating the packages we started to get "qemu-system-x86_64: Virtqueue size exceeded", when resuming the guest. Our environment is OpenStack master and we have Mellanox CI that test SR-IOV functionality. Ubuntu 14.04 with Qemu 2.0.0+dfsg-2ubuntu1.26 that contains the fixes see [2] ii qemu-kvm 2.0.0+dfsg-2ubuntu1.26 amd64 QEMU Full virtualization ii qemu-system-x86 2.0.0+dfsg-2ubuntu1.26 amd64 QEMU full system emulation binaries (x86) ii qemu-utils 2.0.0+dfsg-2ubuntu1.26 amd64 QEMU utilities Our CI started to fail last week when this security packages released. The scenarios is as follows (sorry for the OpenStack commands :)) : 1. nova boot guest 2. nova suspend guest 3. nova resume guest The result is that the guest is in poweroff state and when I power it on everything is working fine. I tested in direct port (SR-IOV) and normal port (virtual port) and it happens in both cases. According to the [3] it prevent from malicious guest to submit more requests than the virtqueuesize permits. Our CI uses proprietary Cirros image with mlnx4_en driver. (http://13.69.151.247/images/mellanox_eth.img) I started to test it with other images to see if the problem with our image. I also tested with Ubuntu image - https://cloud-images.ubuntu.com/wily/current/wily-server-cloudimg-amd64-dis… And OpenStack Cirros image http://download.cirros-cloud.net/0.3.4/cirros-0.3.4-x86_64-disk.img The Ubuntu image had the same failure, but the Cirros worked. I wonder if there is a problem with the patch or with the images? What in these images can make them malicious guest? [1] - https://access.redhat.com/security/cve/cve-2016-5403 [2] - http://www.ubuntu.com/usn/usn-3047-1/ [3] - https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg06257.html

1 0

[libvirt] [PATCH] docs: Distribute subsite.xsl
by Michal Privoznik 08 Aug '16

08 Aug '16

So, I've ran into very interesting problem lately. When doing the following, I've encountered an error: libvirt.git $ make dist && tar -xJf libvirt-2.2.0.tar.xz && \ cd libvirt-2.2.0 && ./configure && \ rm docs/formatdomain.html && make -C docs make: Entering directory 'docs' make: *** No rule to make target 'formatdomain.html', needed by 'web'. Stop. make: Leaving directory 'docs' I had no idea what was going on, so I've nailed down the commit that "broke it" via running git-bisect. It was this one: 7659bd9221b9dd1cdf. But that shed no more light until I realized that the commit might actually just exposed a problem we had. And guess what - I've nailed it down. Of course we are not distributing subsite.xsl that's why make prints error message. Very misleading one I must say. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index 206ef3b..14aad83 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -152,7 +152,7 @@ schema_DATA = $(wildcard $(srcdir)/schemas/*.rng) EXTRA_DIST= \ apibuild.py genaclperms.pl \ - site.xsl newapi.xsl news.xsl page.xsl \ + site.xsl subsite.xsl newapi.xsl news.xsl page.xsl \ hacking1.xsl hacking2.xsl wrapstring.xsl \ $(dot_html) $(dot_html_in) $(gif) $(apihtml) $(apipng) \ $(devhelphtml) $(devhelppng) $(devhelpcss) $(devhelpxsl) \ -- 2.8.4

2 2

[libvirt] Release of libvirt-2.1.0
by Daniel Veillard 08 Aug '16

08 Aug '16

Sorry I didn't push an rc2 on Friday, finishing my move, but not seeing any issue raised by rc1, I though it was better to push the final release now and free up the tree for pending development. As a result 2.1.0 is tagged in git and I pushed signed tarbal and rpms to the usual place: ftp://libvirt.org/libvirt/ I didn't gave as much eyeballing to this release as usual, but this is still a fairly big one with more than 300 commits. It is heavilly pushed toward improvements of the code base, some major changes and fixes in the vz driver and less bug fixes than the usual ratio: Documentation: - docs: Add Kimchi as Web Application (Ramon Medeiros) - docs: Update docs to reflect LUKS secret changes (John Ferlan) - docs: remove outdated suggestion to make patches with "diff -urp"/"git diff" (Laine Stump) Portability: - Fix RPM spec for wireshark on Fedora < 24 (Daniel P. Berrange) - libvirt.spec.in: Adapt to newest wireshark plugindir (Michal Privoznik) - virt-wireshark: Properly substract wireshark prefix (Michal Privoznik) - virConfGetValueSSizeT: Fix build on 32 bits (Michal Privoznik) - tests: command: Fix build on ppc64/aarch64 (Andrea Bolognani) - libvirt.spec.in: require systemd-container on >= f24 (Daniel P. Berrange) - build: drop hack for old mingw ssize_t (Eric Blake) - build: virrandommock.c not needed on mingw (Eric Blake) - maint: update to latest gnulib (Martin Kletzander) - mingw-libvirt.spec.in: add perl + perl(Getopt::Long) BRs (Daniel P. Berrange) - mingw-libvirt.spec.in: fix packaging of admin API and other bugs (Daniel P. Berrange) Bug Fixes: - storage: Document wiping formatted volume types (Martin Kletzander) - qemu: remove panic dev models s390 and pseries when migrating (Boris Fiuczynski) - schema: fix resolved interfaces of network type (Nikolay Shirokovskiy) - qemu: fix domain id after domainCreateWithFlags() (Sascha Silbe) - tests: qemu: Don't leak security manager object (Peter Krempa) - qemu: Need to free fileprops in error path (John Ferlan) - iscsi: Establish connection to target via static target login (John Ferlan) - tools: Make use of the correct environment variables (Erik Skultety) - qemu: Adjust the cur_ballon on coldplug/unplug of dimms (Shivaprasad G Bhat) - virconf: Fix config file path construction (Erik Skultety) - util: qemu: Don't generate any extra commas in virQEMUBuildCommandLineJSON (Peter Krempa) - tests: qemuxml2xml: Avoid crash when processing an XML that fails to parse (Peter Krempa) - conf: events: handle NULL uuid (Jovanka Gulicoska) - lxc: Don't crash by forgetting to ref transient domains (Martin Kletzander) - vz: handle gracefully races on undefining domain (Nikolay Shirokovskiy) - qemu: Disallow usage of luks encryption if aes secret not possible (John Ferlan) - storage: Fix error path (John Ferlan) - lxc: errors after the handshake won't be reported (Cédric Bosdonnat) - vsh: Properly initialize res (John Ferlan) - conf: Need to check for glisten before accessing (John Ferlan) - tests: Need to check return of virGetLastError (John Ferlan) - tools: Fix comparison in virLoginShellGetShellArgv (John Ferlan) - util: Fix incorrect VIR_FREE in virConfGetValueStringList (John Ferlan) - fs: Fix '<' comparison of value produced by logical not '!' (Erik Skultety) - security: compilation error due to wrong parameter for vah_add_path(). (Julio Faracco) - vz: don't fail unregister on sending event error (Nikolay Shirokovskiy) - vz: dont remove domain from list on client object error (Nikolay Shirokovskiy) - vz: restore accidentally removed locks around close callback calls (Nikolay Shirokovskiy) - vz: fixed null-pointer dereference in applying graphic params (Olga Krishtal) - vz: fix destination domain synchronization (Nikolay Shirokovskiy) - vz: fix memory leaks in prlsdkLoadDomains (Nikolay Shirokovskiy) - vz: fix missed defined domain event (Nikolay Shirokovskiy) - vz: don't pass empty and unused fields in migration cookie (Nikolay Shirokovskiy) - qemu: Fix migration from old libvirt (Jiri Denemark) - qemu: Drop default channel path during migration (Jiri Denemark) - qemu: Copy complete domain def in qemuDomainDefFormatBuf (Jiri Denemark) - conf: Make really sure we don't access non-existing vCPUs again (Martin Kletzander) - conf: Make really sure we don't access non-existing vCPUs (Martin Kletzander) - qemu: getAutoDumpPath() return value should be dumpfile not domname. (Yan Fu) - systemd: fix ready notification on abstract socket (Jim Fehlig) - virCommandExec: Report error if execve fails (Michal Privoznik) - storage: dir: adapts .wipeVol for ploop volumes (Olga Krishtal) - virconf: fix off-by-1 when appending \n to config file (Daniel P. Berrange) - qemuxml2argvmock: Don't leak @netdef->ifname (Michal Privoznik) - qemuxml2argvtest: Don't leak dummy monitor (Michal Privoznik) - qemuDomainObjPrivateFree: Free @masterKey too (Michal Privoznik) - qemuBuildCpuCommandLine: Don't leak @buf (Michal Privoznik) - virStorageEncryptionSecretFree: Don't leak secret lookup definition (Michal Privoznik) - Fix logic in qemuDomainObjPrivateXMLParseVcpu (Daniel P. Berrange) - qemu: Properly reset spiceMigration flag (Jiri Denemark) - virDomainHostdevDefFree: Don't leak privateData (Michal Privoznik) Improvements: - daemon: sasl: Don't forget to save SASL username to client's identity (Erik Skultety) - admin: Retrieve the SASL context for both local and remote connection (Erik Skultety) - wireshark: Drop glib dependency (Michal Privoznik) - schema: add missed alias element to memory device (Nikolay Shirokovskiy) - conf: Catch invalid memory model earlier (Michal Privoznik) - admin: Fix default uri config option name s/admin_uri_default/uri_default (Erik Skultety) - wireshark: Adapt to dissector function header change (Michal Privoznik) - util: Introduce virISCSINodeNew (John Ferlan) - vsh: Make vshInitDebug return int instead of void (Erik Skultety) - Refresh translations from zanata (Daniel P. Berrange) - vshReadlineParse: Drop some unused variables (Michal Privoznik) - vshCmddefGetOption: Change type of opt_index (Michal Privoznik) - libvirt.spec.in: fix indentation in previous commit (Daniel P. Berrange) - storage: remove "luks" storage volume type (Daniel P. Berrange) - virstoragefile: refactor virStorageFileMatchesNNN methods (Daniel P. Berrange) - qemu: return balloon statistics when all domain statistics reported (Derbyshev Dmitry) - qemu: split qemuDomainMemoryStats into internal and external functions (Derbyshev Dmitry) - qemu: fix domain memory 'last-update' timestamp (Pavel Hrdina) - qemu: fix domain memory 'usable' stat (Pavel Hrdina) - virsh: Add balloon stats description to .pod (Derbyshev Dmitry) - virt-admin.pod: Remove a statement about remote access to the daemon (Erik Skultety) - qemu: command: Add support for multi-host gluster disks (Prasanna Kumar Kalever) - qemu: command: Add infrastructure for object specified disk sources (Peter Krempa) - util: qemu: Add support for numbered array members (Peter Krempa) - storage: gluster: Support multiple hosts in backend functions (Peter Krempa) - qemu: command: Refactor code extracted to qemuBuildDriveSourceStr (Peter Krempa) - qemu: command: Extract drive source command line formatter (Peter Krempa) - qemu: command: Split out network disk URI building (Peter Krempa) - qemu: command: Rename qemuBuildNetworkDriveURI to qemuBuildNetworkDriveStr (Peter Krempa) - util: storage: Add JSON backing volume parser for 'ssh' protocol (Peter Krempa) - util: storage: Add 'ssh' network storage protocol (Peter Krempa) - util: storage: Add JSON backing store parser for 'sheepdog' protocol (Peter Krempa) - util: storage: Add JSON backing volume parser for 'nbd' protocol (Peter Krempa) - util: storage: Add json pseudo protocol support for iSCSI volumes (Peter Krempa) - util: storage: Add json pseudo protocol support for gluster volumes (Peter Krempa) - util: storage: Add support for URI based backing volumes in qemu's JSON pseudo-protocol (Peter Krempa) - util: storage: Add support for host device backing specified via JSON (Peter Krempa) - util: storage: Add parser for qemu's json backing pseudo-protocol (Peter Krempa) - util: json: Make first argument of virJSONValueCopy const (Peter Krempa) - util: qemu: Allow for different approaches to format JSON arrays (Peter Krempa) - util: qemu: Allow nested objects in JSON -> commandline generator (Peter Krempa) - util: qemu: Add support for user-passed strings in JSON->commandline (Peter Krempa) - util: qemu: Add wrapper for JSON -> commandline conversion (Peter Krempa) - util: json: Make first argument of virJSONValueObjectForeachKeyValue const (Peter Krempa) - tests: Add testing of backing store string parser (Peter Krempa) - Remove unnecessary virDomainDefClearDeviceAliases (John Ferlan) - conf: Remove CCW,PCI clear address helpers (John Ferlan) - libxl: implement virDomainBlockStats (Joao Martins) - qemu: rename QEMU_CAPS_MLOCK to QEMU_CAPS_REALTIME_MLOCK (Henning Schild) - network: Added hook for network modification event (Anton Khramov) - qemu: expand domain memory statistics with 'last-update' timestamp (Derbyshev Dmitry) - qemu: expand domain memory statistics with 'usable' (Derbyshev Dmitry) - qemu: remove ccwaddrs caching (Tomasz Flendrich) - qemu_hotplug: generate ccw address list on demand (Tomasz Flendrich) - Add qemuDomainCCWAddrSetCreateFromDomain (Tomasz Flendrich) - qemu: remove vioserialaddrs caching (Tomasz Flendrich) - qemu_hotplug: generate vioserial address list on demand (Tomasz Flendrich) - add virDomainVirtioSerialAddrSetCreateFromDomain (Tomasz Flendrich) - cgroup: drop INSERT_ELEMENT usage virCgroupPartitionEscape (Ján Tomko) - util: systemd: Define MSG_NOSIGNAL if needed (Andrea Bolognani) - qemu_monitor: search memballoon QOM device path using alias (Pavel Hrdina) - qemu_monitor_json: add support to search QOM device path by device alias (Pavel Hrdina) - Split qemuDomainDetachDeviceFlags in two (Tomasz Flendrich) - Narrow down a parameter in qemuDomainDetachDeviceFlags (Tomasz Flendrich) - Split qemuDomainAttachDeviceFlags in two (Tomasz Flendrich) - qemu: Remove an unnecessary variables (Tomasz Flendrich) - Change parameters to qemuDomainAttachDeviceLive (Tomasz Flendrich) - qemuhotplugtest: Add tests for ccw devices (Tomasz Flendrich) - virt-aa-helper: Make help output match option name (Guido Günther) - qemu: hotplug: fix changeable media ejection (Bjoern Walk) - lxc: make container's init process session leader (Katerina Koukiou) - Auto-add one hub if there are too many USB devices (Ján Tomko) - Assign addresses on USB device hotplug (Ján Tomko) - Assign addresses to USB devices (Ján Tomko) - Add tests for USB address assignment (Ján Tomko) - Reserve existing USB addresses (Ján Tomko) - Add functions for adding USB hubs to addrs (Ján Tomko) - Add functions for adding USB controllers to addrs (Ján Tomko) - Introduce virDomainUSBAddressSet (Ján Tomko) - vz: make vz driver more responsive (Nikolay Shirokovskiy) - vz: keep naming convention for domain objects (Nikolay Shirokovskiy) - vz: remove redundant variable in prlsdkHandleVmAddedEvent (Nikolay Shirokovskiy) - vz: use state variable sdkdom in prlsdkApplyConfig (Nikolay Shirokovskiy) - storage: Add extra failure condition for luks volume creation (John Ferlan) - qemu: Move setting of encobjAdded for qemuDomainAttachSCSIDisk (John Ferlan) - qemu: Move setting of obj bools for qemuDomainAttachVirtioDiskDevice (John Ferlan) - hvsupport: skip non-matching lines early (Ján Tomko) - hvsupport: construct the group regex upfront (Ján Tomko) - hvsupport: use a regex instead of XML::XPath (Ján Tomko) - virt-aa-helper: better write denials handling (Cédric Bosdonnat) - qemu: Add luks support for domain disk (John Ferlan) - qemu: Alter the qemuDomainGetSecretAESAlias to add new arg (John Ferlan) - qemu: Add secinfo for hotplug virtio disk (John Ferlan) - storage: Add support to create a luks volume (John Ferlan) - virt-admin: Output srv-threadpool-info data as unsigned int rather than signed (Erik Skultety) - qemu: Move and rename qemuBufferEscapeComma (John Ferlan) - qemu: Alter error path cleanup for qemuDomainAttachMemory (John Ferlan) - qemu: Alter error path cleanup for qemuDomainAttachRNGDevice (John Ferlan) - qemu: Alter error path cleanup for qemuDomainAttachChrDevice (John Ferlan) - qemu: Alter error path cleanup for qemuDomainAttachSCSIDisk (John Ferlan) - qemu: Alter error path cleanup for qemuDomainAttachVirtioDiskDevice (John Ferlan) - qemu: Alter error path cleanup for qemuDomainAttachHostSCSIDevice (John Ferlan) - vz: add tcp and udp serial device support (Nikolay Shirokovskiy) - vz: add mode of unix socket serial device to xml dump (Nikolay Shirokovskiy) - vz: use single variable for domain (Nikolay Shirokovskiy) - vz: cleanup loading domain code (Nikolay Shirokovskiy) - vz: use domain list infrastructure to deal with private domain (Nikolay Shirokovskiy) - vz: make error handling idiomatic in prlsdkCreateVm (Nikolay Shirokovskiy) - vz: fix leaks in prlsdkCreate* functions (Nikolay Shirokovskiy) - vz: remove unnecessary labels in simple API calls (Nikolay Shirokovskiy) - vz: support filesystem type volume (Olga Krishtal) - vz: refactoring of prlsdkCreateCt (Olga Krishtal) - devices: filesystems: added volume type (Olga Krishtal) - filesystem: adds possibility to use storage pool as fs source (Olga Krishtal) - test: Add scsi vport nodedev to test:///default (Cole Robinson) - test: Have test:///default open use file parsing helpers (Cole Robinson) - test: Move testOpenDefault definition later (Cole Robinson) - test: Introduce testOpenParse (Cole Robinson) - util: conf: Rename VIR_CONF_{U,}LONG -> VIR_CONF_{U,}LLONG (Andrea Bolognani) - util: conf: Clarify choice between VIR_CONF_LONG and VIR_CONF_ULONG (Andrea Bolognani) - util: conf: Fix parameters alignment (Andrea Bolognani) - util: conf: Fix comment for virConfGetValueULLong() (Andrea Bolognani) - util: conf: Claim the proper range for signed numbers (Andrea Bolognani) - util: conf: Add integer casts (Andrea Bolognani) - util: conf: Improve virConfGet*() logic (Andrea Bolognani) - util: conf: Use long long when parsing (Andrea Bolognani) - hvsupport: Introduce parseSymsFile (Ján Tomko) - Store USB port path as an array of integers (Ján Tomko) - Allow omitting USB port (Ján Tomko) - virconf: skip some range checks if SSIZE_MAX >= LLONG_MAX (Daniel P. Berrange) - virconf: clarify type range checks for integers (Daniel P. Berrange) - conf: Revert changes to add new secret type "passphrase" (John Ferlan) - tests: Adjust LUKS tests to use 'volume' secret type (John Ferlan) - spec: Fix indentation (Andrea Bolognani) - qemu: command: Fix awkward formatting (Andrea Bolognani) - dnsmasq: disable IPv6 default gateway in RA for isolated networks (Maxim Perevedentsev) - Fix message about dnsmasq BINDTODEVICE capability. (Maxim Perevedentsev) - esx: Fetch snapshot info directly for filtering (Tomáš Golembiovský) - qemu: format intel-iommu on the command line (Ján Tomko) - Add QEMU_CAPS_DEVICE_INTEL_IOMMU (Ján Tomko) - Introduce <iommu> device (Ján Tomko) - test-wrap-argv: set cutoff at 78 characters (Ján Tomko) - test-wrap-argv: print diff instead of the incorrectly wrapped file (Ján Tomko) - testutils: only rewrap args files (Ján Tomko) - testutils: find perl early (Ján Tomko) - qemuxml2argvtest: drop empty pseries-vio-address-clash.args (Ján Tomko) - tests: add missing directories in EXTRA_DIST (Luyao Huang) - remote: convert to typesafe virConf accessors (Daniel P. Berrange) - sanlock: convert to typesafe virConf accessors (Daniel P. Berrange) - lockd: convert to typesafe virConf accessors (Daniel P. Berrange) - selinux: convert to typesafe virConf accessors (Daniel P. Berrange) - virt-login-shell: convert to typesafe virConf accessors (Daniel P. Berrange) - uri: convert to typesafe virConf accessors (Daniel P. Berrange) - libxl: convert to typesafe virConf accessors (Daniel P. Berrange) - lxc: convert to typesafe virConf accessors (Daniel P. Berrange) - virtlogd: convert to typedef virConf accessors (Daniel P. Berrange) - virtlockd: convert to typesafe virConf accessors (Daniel P. Berrange) - libvirt: convert to typesafe virConf accessors (Daniel P. Berrange) - qemu: convert to typesafe virConf accessors (Daniel P. Berrange) - libvirtd: convert to typesafe virConf accessors (Daniel P. Berrange) - virconf: add typed value accessor methods (Daniel P. Berrange) - tests: remove pointless virconftest.sh wrapper (Daniel P. Berrange) - qemuhotplugtest: Move domain and device XMLs to different directories (Tomasz Flendrich) - qemuhotplugtest: Move all XMLs to one directory (Tomasz Flendrich) - virsh: allow both --uuid and --name at same time (Chen Hanxiao) - qemu: Use qemuProcessSetupPid() in qemuProcessSetupVcpu() (Martin Kletzander) - qemu: Use qemuProcessSetupPid() in qemuProcessSetupEmulator() (Martin Kletzander) - qemu: Add qemuProcessSetupPid() and use it in qemuProcessSetupIOThread() (Martin Kletzander) - qemu: capabilities: Make virHostCPUGetKVMMaxVCPUs() errors fatal (Andrea Bolognani) - util: hostcpu: Drop obsolete compatibility code (Andrea Bolognani) - util: hostcpu: Add virHostCPUGetKVMMaxVCPUs() stub (Andrea Bolognani) - qemu: Store vCPU thread ids in vcpu private data objects (Peter Krempa) - qemu: Add cpu ID to the vCPU pid list in the status XML (Peter Krempa) - qemu: domain: Extract formating and parsing of vCPU thread ids (Peter Krempa) - qemu: domain: Add vcpu private data structure (Peter Krempa) - conf: Add private data for virDomainVcpuDef (Peter Krempa) - conf: convert def->vcpus to a array of pointers (Peter Krempa) - tests: qemuxml2xml: Format status XML header dynamically (Peter Krempa) - conf: Don't report errors from virDomainDefGetVcpu (Peter Krempa) - conf: Rename virDomainVcpuInfoPtr to virDomainVcpuDefPtr (Peter Krempa) - conf: Extract code formatting vCPU info (Peter Krempa) - conf: Annotate that private data for objects are not copied (Peter Krempa) - virsh: Introduce vshReadlineParse for improved auto-completion (Nishith Shah) - virsh: Add option to suppress error in various functions (Nishith Shah) - virsh: Fix variable types in readline generators (Nishith Shah) - virsh: Break vshCmddefOptParse into helper functions (Nishith Shah) - bhyve: implement virConnectGetDomainCapabilities (Fabian Freyer) - bhyve: fix bhyveargv2xml custom loader test (Roman Bogorodskiy) - bhyve: add tests for bhyveParseCommandLineString (Fabian Freyer) - bhyve: implement argument parser for loader (Fabian Freyer) - bhyve: implement bhyve argument parser (Fabian Freyer) - bhyve: implement virConnectDomainXMLFromNative (Fabian Freyer) - gnulib: add getopt module (Fabian Freyer) - tests: Add test cases for the empty bitmap (Marc Hartmayer) - util: bitmap: Mention the size == 0 handling (Marc Hartmayer) - util: bitmap: clarify virBitmapLastSetBit() behavior for empty bitmaps (Marc Hartmayer) - tests: env perl shebang for test-wrap-argv.pl (Fabian Freyer) - qemu: Drop useless SPICE migration code (Jiri Denemark) - virtlogd: increase max file size to 2 MB (Daniel P. Berrange) - virtlogd: make max file size & number of backups configurable (Daniel P. Berrange) - qemu: caps: Always assume QEMU_CAPS_SMP_TOPOLOGY (Peter Krempa) - qemu: generate -display none (Paolo Bonzini) - qemu: detect -display (Paolo Bonzini) - conf: Isolate virDomainLiveConfigHelperMethod to libxl only (Peter Krempa) - conf: Don't use virDomainLiveConfigHelperMethod in virDomainObjGetMetadata (Peter Krempa) - conf: Don't use virDomainLiveConfigHelperMethod in virDomainObjSetMetadata (Peter Krempa) - openvz: Remove use of virDomainLiveConfigHelperMethod (Peter Krempa) - lxc: Synchronize implementation of qemuDomainSetMemoryParameters (Peter Krempa) - qemu: driver: Make name of QEMU_SET_MEM_PARAMETER more universal (Peter Krempa) - spec: Move virt-admin into its own package (Michal Privoznik) - spec: Split libvirt-client (Michal Privoznik) - virlog: Introduce virLogFilterListFree (Erik Skultety) - virlog: Introduce virLogFilterFree (Erik Skultety) - virlog: Introduce virLogOutputListFree (Erik Skultety) - virlog: Introduce virLogOutputFree (Erik Skultety) - virlog: Convert virLogFilters to a list of pointers to filters (Erik Skultety) - virlog: Convert virLogOutputs to a list of pointers to outputs (Erik Skultety) - virlog: Return void instead of int in virLogReset<Foo> methods (Erik Skultety) - qemu: Memory locking is only required for KVM guests on ppc64 (Andrea Bolognani) - qemu: support setting host-side IP addresses/routes (Laine Stump) - lxc: support setting host-side IP addresses/routes (Laine Stump) - util: support setting peer for virNetDevIPInfo addresses (Laine Stump) - conf: support host-side IP/route information in <interface> (Laine Stump) - conf: allow setting peer address in <ip> element of <interface> (Vasiliy Tolstov) - util: new function virNetDevIPInfoAddToDev (Laine Stump) - qemu: Introduce helper qemuDomainSecretDiskCapable (John Ferlan) - encryption: Add <cipher> and <ivgen> to encryption (John Ferlan) - encryption: Add luks parsing for storageencryption (John Ferlan) - util: Add 'usage' for encryption (John Ferlan) - conf: Add new secret type "passphrase" (John Ferlan) - conf: No need to check for usage fields during Format (John Ferlan) - Allow custom metadata in network configuration XML (Brandon Bennett) - util: new function virXMLNodeSanitizeNamespaces() (Laine Stump) - util: hostcpu: Only define /dev/kvm path once (Andrea Bolognani) - examples: check asprintf return value in client_info.c (Ján Tomko) - events: Rename argument uuid->key (Cole Robinson) - events: Add explicit lookup 'key' value (Cole Robinson) - events: Pass in UUID as a string (Cole Robinson) - events: Cleanup callback variable name (Cole Robinson) - events: Add virObjectEventCallbackFree (Cole Robinson) - events: Privatize virObjectEventCallback (Cole Robinson) - Introduce virDomainUSBDeviceDefForeach (Ján Tomko) - Add USB addresses to qemuhotplug test cases (Ján Tomko) - qemu: Avoid needless copies of static strings (Jiri Denemark) - qemu: Drop emitBootindex parameter (Jiri Denemark) - qemu: Use bootindex whenever possible (Jiri Denemark) - qemu: Remove redundant parameter in virQEMUCapsFillDomainCaps (Jiri Denemark) - domaincapstest: Don't read data from host (Jiri Denemark) - cpu: Drop NR_DRIVERS macro (Jiri Denemark) - cpu: Drop generic driver (Jiri Denemark) - Post-release version bump to 2.1.0 (Jiri Denemark) Thanks everybody who contributed to this release, with code, ideas, reviews, docs, and not forgetting the translator as this release got a major update from zanata ! Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 4

[libvirt] [PATCH] nsslinktest: also build virAtomic.h
by kai.7.kang＠gmail.com 08 Aug '16

08 Aug '16

From: Kai Kang <kai.kang(a)windriver.com> When build for architecture that don't use gcc atomic ops but pthread, it fails to build for armel: | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virClassNew': | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:153: undefined reference to `virAtomicLock' | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectNew': | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:205: undefined reference to `virAtomicLock' | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectUnref': | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:277: undefined reference to `virAtomicLock' | ../tools/nss/.libs/libnss_libvirt_impl.a(libvirt_nss_la-virobject.o): In function `virObjectRef': | /buildarea2/kkang/builds/qemuarm-Aug03/bitbake_build/tmp/work/armv5e-wrs-linux-gnueabi/libvirt/1.3.5-r0/build/src/../../libvirt-1.3.5/src/util/virobject.c:298: undefined reference to `virAtomicLock' | collect2: error: ld returned 1 exit status It is similar with: http://libvirt.org/git/?p=libvirt.git;a=commit;h=12dc729 Signed-off-by: Kai Kang <kai.kang(a)windriver.com> --- src/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Makefile.am b/src/Makefile.am index 12b66c2..6e55972 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -2989,6 +2989,8 @@ noinst_LTLIBRARIES += libvirt-nss.la libvirt_nss_la_SOURCES = \ util/viralloc.c \ util/viralloc.h \ + util/viratomic.c \ + util/viratomic.h \ util/virbitmap.c \ util/virbitmap.h \ util/virbuffer.c \ -- 2.9.0

3 2

[libvirt] [PATCH] virsystemd: Fix error check
by Marc Hartmayer 08 Aug '16

08 Aug '16

Commit b3e4401dc620 introduced a check to ignore an error if the guest is already terminated. However the check accidentally compared error.code with VIR_ERR_ERROR, which is an error level, not an error code. Because of this, almost every error got silently ignored. Fixes: b3e4401dc620 ("systemd: don't report an error if the guest is already terminated") Signed-off-by: Marc Hartmayer <mhartmay(a)linux.vnet.ibm.com> Reviewed-by: Sascha Silbe <silbe(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- src/util/virsystemd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 7d6985b..604dcdd 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -468,7 +468,7 @@ int virSystemdTerminateMachine(const char *name) name) < 0) goto cleanup; - if (error.code == VIR_ERR_ERROR && + if (error.level == VIR_ERR_ERROR && STRNEQ_NULLABLE("org.freedesktop.machine1.NoSuchMachine", error.str1)) { virReportErrorObject(&error); -- 2.5.5

2 1

[libvirt] [PATCH 0/2] vz: add getting job info for migration
by Nikolay Shirokovskiy 06 Aug '16

06 Aug '16

Nikolay Shirokovskiy (2): vz: add getting job info for migration vz: add vzDomainGetJobStats src/vz/vz_driver.c | 113 +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_sdk.c | 31 +++++++++++++++ src/vz/vz_utils.c | 42 ++++++++++++++++---- src/vz/vz_utils.h | 17 +++++++- 4 files changed, 194 insertions(+), 9 deletions(-) -- 1.8.3.1

2 3

[libvirt] [PATCH] build: centralize use of extra Cygwin LDFLAGS
by Eric Blake 06 Aug '16

06 Aug '16

The build was failing with: CCLD lockd.la libtool: error: can't build i686-pc-cygwin shared library unless -no-undefined is specified Rather than add yet another $(CYGWIN_EXTRA_LDFLAGS) to all the impacted *_la_LDFLAGS, it was easier to just pull the extra flags into ALL libraries via AM_LDFLAGS. Then, fix lockd_la_LDFLAGS to include AM_LDFLAGS, like all other libraries. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule. src/Makefile.am | 29 +++++++---------------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index cc1fca5..4416390 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -46,6 +46,8 @@ AM_LDFLAGS = $(DRIVER_MODULE_LDFLAGS) \ $(COVERAGE_LDFLAGS) \ $(RELRO_LDFLAGS) \ $(NO_INDIRECT_LDFLAGS) \ + $(CYGWIN_EXTRA_LDFLAGS) \ + $(MINGW_EXTRA_LDFLAGS) \ $(NULL) EXTRA_DIST = $(conf_DATA) util/keymaps.csv @@ -2180,9 +2182,7 @@ libvirt_admin_la_SOURCES = \ libvirt_admin_la_LDFLAGS = \ $(VERSION_SCRIPT_FLAGS)$(LIBVIRT_ADMIN_SYMBOL_FILE) \ -version-info $(LIBVIRT_VERSION_INFO) \ - $(AM_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) + $(AM_LDFLAGS) libvirt_admin_la_LIBADD = \ libvirt.la \ @@ -2224,8 +2224,6 @@ libvirt_la_LDFLAGS = \ -version-info $(LIBVIRT_VERSION_INFO) \ $(LIBVIRT_NODELETE) \ $(AM_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) \ $(NULL) libvirt_la_BUILT_LIBADD += ../gnulib/lib/libgnu.la libvirt_la_LIBADD += \ @@ -2309,8 +2307,6 @@ libvirt_qemu_la_LDFLAGS = \ $(VERSION_SCRIPT_FLAGS)$(LIBVIRT_QEMU_SYMBOL_FILE) \ -version-info $(LIBVIRT_VERSION_INFO) \ $(AM_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) \ $(NULL) libvirt_qemu_la_CFLAGS = $(AM_CFLAGS) libvirt_qemu_la_LIBADD = libvirt.la $(CYGWIN_EXTRA_LIBADD) @@ -2320,8 +2316,6 @@ libvirt_lxc_la_LDFLAGS = \ $(VERSION_SCRIPT_FLAGS)$(LIBVIRT_LXC_SYMBOL_FILE) \ -version-info $(LIBVIRT_VERSION_INFO) \ $(AM_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) \ $(NULL) libvirt_lxc_la_CFLAGS = $(AM_CFLAGS) libvirt_lxc_la_LIBADD = libvirt.la $(CYGWIN_EXTRA_LIBADD) @@ -2431,7 +2425,7 @@ lockd_la_SOURCES = \ lockd_la_CFLAGS = -I$(srcdir)/conf \ $(XDR_CFLAGS) \ $(AM_CFLAGS) -lockd_la_LDFLAGS = -module -avoid-version +lockd_la_LDFLAGS = -module -avoid-version $(AM_LDFLAGS) lockd_la_LIBADD = ../gnulib/lib/libgnu.la \ libvirt-net-rpc.la \ libvirt-net-rpc-client.la \ @@ -2474,8 +2468,6 @@ virtlockd_CFLAGS = \ virtlockd_LDFLAGS = \ $(AM_LDFLAGS) \ $(PIE_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) \ $(NULL) virtlockd_LDADD = \ libvirt-net-rpc-server.la \ @@ -2502,8 +2494,6 @@ virtlogd_CFLAGS = \ virtlogd_LDFLAGS = \ $(AM_LDFLAGS) \ $(PIE_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) \ $(NULL) virtlogd_LDADD = \ libvirt-net-rpc-server.la \ @@ -2808,8 +2798,7 @@ libvirt_net_rpc_la_LDFLAGS = \ $(SSH2_LIBS)\ $(SECDRIVER_LIBS) \ $(AM_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) + $(NULL) libvirt_net_rpc_la_LIBADD = \ $(CYGWIN_EXTRA_LIBADD) @@ -2829,8 +2818,7 @@ libvirt_net_rpc_server_la_LDFLAGS = \ $(AM_LDFLAGS) \ $(AVAHI_LIBS) \ $(DBUS_LIBS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) + $(NULL) libvirt_net_rpc_server_la_LIBADD = \ $(CYGWIN_EXTRA_LIBADD) @@ -2841,10 +2829,7 @@ libvirt_net_rpc_client_la_SOURCES = \ libvirt_net_rpc_client_la_CFLAGS = \ $(AM_CFLAGS) \ $(XDR_CFLAGS) -libvirt_net_rpc_client_la_LDFLAGS = \ - $(AM_LDFLAGS) \ - $(CYGWIN_EXTRA_LDFLAGS) \ - $(MINGW_EXTRA_LDFLAGS) +libvirt_net_rpc_client_la_LDFLAGS = $(AM_LDFLAGS) libvirt_net_rpc_client_la_LIBADD = \ $(CYGWIN_EXTRA_LIBADD) -- 2.5.5

1 0

[libvirt] [PATCH] build: use XDR_CFLAGS for Cygwin build
by Eric Blake 06 Aug '16

06 Aug '16

Without XDR_CFLAGS, compilation on Cygwin fails with: CC libvirt_driver_la-libvirt-stream.lo In file included from libvirt-stream.c:26:0: rpc/virnetprotocol.h:9:21: fatal error: rpc/rpc.h: No such file or directory Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule src/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index e2a2128..cc1fca5 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,6 +1,6 @@ ## Process this file with automake to produce Makefile.in -## Copyright (C) 2005-2015 Red Hat, Inc. +## Copyright (C) 2005-2016 Red Hat, Inc. ## ## This library is free software; you can redistribute it and/or ## modify it under the terms of the GNU Lesser General Public @@ -1172,7 +1172,7 @@ libvirt_la_BUILT_LIBADD += libvirt_driver.la libvirt_driver_la_SOURCES = $(DRIVER_SOURCES) libvirt_driver_la_CFLAGS = \ - $(GNUTLS_CFLAGS) $(CURL_CFLAGS) \ + $(GNUTLS_CFLAGS) $(CURL_CFLAGS) $(XDR_CFLAGS) \ -I$(srcdir)/conf $(AM_CFLAGS) libvirt_driver_la_LIBADD = \ $(GNUTLS_LIBS) $(CURL_LIBS) $(DLOPEN_LIBS) @@ -1364,6 +1364,7 @@ endif ! WITH_DRIVER_MODULES libvirt_driver_qemu_impl_la_CFLAGS = \ $(GNUTLS_CFLAGS) \ $(LIBNL_CFLAGS) \ + $(XDR_CFLAGS) \ -I$(srcdir)/access \ -I$(srcdir)/conf \ -I$(srcdir)/secret \ -- 2.5.5

1 0

[libvirt] Libvirt's DomainGetInfo Function Development
by Aleem Akhtar 06 Aug '16

06 Aug '16

I am trying to get stats of Domains running under XEN hypervisor. I used Libvirt function for this purpose. I am trying to understand output for Memory. Domain running is Fedora-22 with 1GB Ram. Here is my code y = virDomainGetInfo(allDomain, &info); if (y == -1) printf("Errorl\n"); else { printf("Max Memory: %lu\n", info.maxMem); printf("Memory: %lu", info.memory); } I get output as *Max Memory: 1048576 Memory: 1048576* Now, as per Libvirt API <http://libvirt.org/html/libvirt-libvirt-domain.html#virDomainInfo>, info.memory should return the memory in KBytes used by the domain. My Question is, if info.memory returns memory used and my domain is using complete 100% of Max Memory or not? Also I tried to create Domain with memory varying from 128MB to 2GB with same effect. I also tried to run some applications in Domain but Memory usage return by given function does not change. Any help or guidance will be much appreciated. *Regards,* *Aleem Akhtar * *Research Assistant | HPC-Lab | SEECS* National University of Sciences & Technology Sector H-12, Islamabad Email: aleem.akhtar(a)seecs.nust.edu.pk <aleem.akhtar(a)seecs.nust.edu.pk> Website: aleemakhtar.com

3 6