- Devel - libvirt List Archives

[libvirt] [PATCH] storage: Fix build on i686
by Jiri Denemark 28 Mar '17

28 Mar '17

off_t is signed and it's size is the same as long only on 64b archs. Thus it cannot be formatted as %lu. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/storage/storage_backend_logical.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 9ca6fd43b..d87aaf0b6 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -116,9 +116,9 @@ virStorageBackendLogicalInitializeDevice(const char *path) if (size < 4 * PV_BLANK_SECTOR_SIZE) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, - _("cannot initialize '%s' detected size='%lu' less " + _("cannot initialize '%s' detected size='%zd' less " "than minimum required='%d"), - path, size, 4 * PV_BLANK_SECTOR_SIZE); + path, (ssize_t) size, 4 * PV_BLANK_SECTOR_SIZE); goto cleanup; } if ((size = lseek(fd, 0, SEEK_SET)) == (off_t)-1) { -- 2.12.2

2 1

[libvirt] [PATCHv2 0/2] Restore logical pool functionality
by Ján Tomko 28 Mar '17

28 Mar '17

John Ferlan (1): storage: Better describe logical pool creation/definition parameters Ján Tomko (1): Revert "storage: Better describe logical pool creation/definition parameters" src/conf/storage_conf.c | 8 -------- tools/virsh.pod | 7 +++---- 2 files changed, 3 insertions(+), 12 deletions(-) -- 2.10.2

2 3

[libvirt] [PATCH] news: Fix typo in element name
by Jiri Denemark 28 Mar '17

28 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Oops, pushed as trivial. We really need a schema for news.xml... docs/news.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 85a1d4d97..17186b954 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,7 +72,7 @@ introducing a new host device type in the XML. </description> </change> - <changes> + <change> <summary> qemu: Add support for setting TSC frequency </summary> @@ -80,7 +80,7 @@ Setting TSC frequency is required to enable migration for domains with 'invtsc' CPU feature turned on. </description> - </changes> + </change> </section> <section title="Improvements"> <change> -- 2.12.2

2 1

[libvirt] [PATCH v2 0/7] Memory locking fixes
by Andrea Bolognani 28 Mar '17

28 Mar '17

Changes from [v1]: * exit early from the loop in patch 2; * dropped patch 5/8, as it's no longer needed; * rewrote tests not to generate QEMU command line; * changed documentation slightly. [v1] https://www.redhat.com/archives/libvir-list/2017-March/msg01089.html Andrea Bolognani (7): Revert "qemu: Forbid <memoryBacking><locked> without <memtune><hard_limit>" qemu: Remove qemuDomainRequiresMemLock() qemu: Fix memory locking limit calculation process: Translate "unlimited" correctly tests: Introduce virTestCompareToULL() tests: Introduce QEMU memory locking limit tests docs: Improve documentation related to memory locking docs/formatdomain.html.in | 39 ++++-- src/qemu/qemu_command.c | 4 +- src/qemu/qemu_domain.c | 76 ++++------ src/qemu/qemu_domain.h | 1 - src/util/virprocess.c | 20 ++- tests/Makefile.am | 9 ++ .../qemumemlock-pc-hardlimit+hostdev.xml | 20 +++ .../qemumemlock-pc-hardlimit+locked+hostdev.xml | 23 ++++ .../qemumemlock-pc-hardlimit+locked.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-hostdev.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pc-kvm.xml | 11 ++ .../qemumemlock-pc-locked+hostdev.xml | 20 +++ tests/qemumemlockdata/qemumemlock-pc-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pc-tcg.xml | 11 ++ .../qemumemlock-pseries-hardlimit+hostdev.xml | 20 +++ ...emumemlock-pseries-hardlimit+locked+hostdev.xml | 23 ++++ .../qemumemlock-pseries-hardlimit+locked.xml | 17 +++ .../qemumemlock-pseries-hardlimit.xml | 14 ++ .../qemumemlock-pseries-hostdev.xml | 17 +++ tests/qemumemlockdata/qemumemlock-pseries-kvm.xml | 11 ++ .../qemumemlock-pseries-locked+hostdev.xml | 20 +++ .../qemumemlockdata/qemumemlock-pseries-locked.xml | 14 ++ tests/qemumemlockdata/qemumemlock-pseries-tcg.xml | 11 ++ tests/qemumemlocktest.c | 153 +++++++++++++++++++++ tests/qemuxml2argvdata/qemuxml2argv-mlock-on.xml | 3 - tests/testutils.c | 27 ++++ tests/testutils.h | 2 + 28 files changed, 556 insertions(+), 72 deletions(-) create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pc-tcg.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit+locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hardlimit.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-kvm.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked+hostdev.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-locked.xml create mode 100644 tests/qemumemlockdata/qemumemlock-pseries-tcg.xml create mode 100644 tests/qemumemlocktest.c -- 2.7.4

2 11

[libvirt] [PATCH] Revert "storage: Better describe logical pool creation/definition parameters"
by Ján Tomko 28 Mar '17

28 Mar '17

This reverts commit ca4515d2639057020c749470f390fe1f5981e91e which broke the functionality of logical storage pools not named after their volume groups. --- src/conf/storage_conf.c | 8 -------- tools/virsh.pod | 7 ------- 2 files changed, 15 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 5213503..585ca71 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -760,14 +760,6 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (VIR_STRDUP(ret->source.name, ret->name) < 0) goto error; } - if (ret->type == VIR_STORAGE_POOL_LOGICAL && - STRNEQ(ret->name, ret->source.name)) { - virReportError(VIR_ERR_XML_ERROR, - _("for a logical pool, the pool name='%s' " - "must match the pool source name='%s'"), - ret->name, ret->source.name); - goto error; - } } if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) && diff --git a/tools/virsh.pod b/tools/virsh.pod index 55b71a9..43124ba 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3639,13 +3639,6 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. -For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>] -must match the Volume Group name for which the pool is being defined or -created. The [I<--source-name>] if provided must match the Volume Group -name. If not provided, one will be generated using the [I<--name>]. If -provided the [I<--target>] is ignored and a target source is generated -using the [I<--source-name>] (or as generated from the [I<--name>]). - =item B<pool-define> I<file> Define an inactive persistent storage pool or modify an existing persistent one -- 2.10.2

3 2

[libvirt] [PATCH] hostdev: Fix build with GCC's static analysis in mdev
by Martin Kletzander 28 Mar '17

28 Mar '17

Similarly to eec3b255d26e7b38bdb0830990569fd91aee661f, fix build with lv_cv_static_analysis=yes. Caused by a4a39d90ab4930750bcbcfccffdf6bb6d310b5d5 --- src/util/virhostdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 2c557f5bbc6b..998df5871539 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -2060,8 +2060,8 @@ virHostdevReAttachMediatedDevices(virHostdevManagerPtr mgr, continue; virMediatedDeviceGetUsedBy(tmp, &used_by_drvname, &used_by_domname); - if (STREQ_NULLABLE(drv_name, used_by_drvname) && - STREQ_NULLABLE(dom_name, used_by_domname)) { + if (used_by_drvname && STREQ(drv_name, used_by_drvname) && + used_by_domname && STREQ(dom_name, used_by_domname)) { VIR_DEBUG("Removing %s dom=%s from activeMediatedHostdevs", mdevsrc->uuidstr, dom_name); virMediatedDeviceListDel(mgr->activeMediatedHostdevs, tmp); -- 2.12.1

3 4

[libvirt] [PATCH v2 0/4] storage: Better describe logical pool creation/definition parameters
by John Ferlan 28 Mar '17

28 Mar '17

v1: https://www.redhat.com/archives/libvir-list/2017-March/msg01227.html changes since v1: Split things part - added news article John Ferlan (4): conf: Set defaultFormat if no storage source XML present virsh.pod: Move the positional --print-xml for pool-{define|create}-as storage: Better describe logical pool creation/definition parameters docs: Add news article for logical pool-create-as docs/news.xml | 5 +++++ src/conf/storage_conf.c | 11 +++++++++++ tools/virsh.pod | 15 +++++++++++---- 3 files changed, 27 insertions(+), 4 deletions(-) -- 2.9.3

4 10

[libvirt] [PATCH] storage: Better describe logical pool creation/definition parameters
by John Ferlan 28 Mar '17

28 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1398087 Clean up the virsh man page description for --pool-create-as in order to better describe how the various arguments are used when creating (or defining) a logical pool. Also move the --print-xml to the end of the qualifiers since it's not properly positionally situated for both --pool-create-as and --pool-define-as. Finally modify the storage pool XML parsing algorithm to check for the mismatched "name" and "source-name" as well as a more general if not provided, then set the default source format. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/conf/storage_conf.c | 11 +++++++++++ tools/virsh.pod | 15 +++++++++++---- 2 files changed, 22 insertions(+), 4 deletions(-) diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 6b34cea..6ca4949 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -703,6 +703,9 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (virStoragePoolDefParseSource(ctxt, &ret->source, ret->type, source_node) < 0) goto error; + } else { + if (options->formatFromString) + ret->source.format = options->defaultFormat; } ret->name = virXPathString("string(./name)", ctxt); @@ -757,6 +760,14 @@ virStoragePoolDefParseXML(xmlXPathContextPtr ctxt) if (VIR_STRDUP(ret->source.name, ret->name) < 0) goto error; } + if (ret->type == VIR_STORAGE_POOL_LOGICAL && + STRNEQ(ret->name, ret->source.name)) { + virReportError(VIR_ERR_XML_ERROR, + _("for a logical pool, the pool name='%s' " + "must match the pool source name='%s'"), + ret->name, ret->source.name); + goto error; + } } if ((options->flags & VIR_STORAGE_POOL_SOURCE_ADAPTER) && diff --git a/tools/virsh.pod b/tools/virsh.pod index ee79046..a1b4086 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3572,13 +3572,13 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. -=item B<pool-create-as> I<name> I<type> [I<--print-xml>] +=item B<pool-create-as> I<name> I<type> [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>] [I<--source-name name>] [I<--target path>] [I<--source-format format>] [I<--auth-type authtype> I<--auth-username username> I<--secret-usage usage>] [[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>] [I<--adapter-parent parent>]] -[I<--build>] [[I<--overwrite>] | [I<--no-overwrite>]] +[I<--build>] [[I<--overwrite>] | [I<--no-overwrite>]] [I<--print-xml>] Create and start a pool object I<name> from the raw parameters. If @@ -3628,17 +3628,24 @@ follow-up command to build the pool. The I<--overwrite> and I<--no-overwrite> flags follow the same rules as B<pool-build>. If just I<--build> is provided, then B<pool-build> is called with no flags. +For a "logical" pool only [I<--name>] needs to be provided. The [I<--name>] +must match the Volume Group name for which the pool is being defined or +created. The [I<--source-name>] if provided must match the Volume Group +name. If not provided, one will be generated using the [I<--name>]. If +provided the [I<--target>] is ignored and a target source is generated +using the [I<--source-name>] (or as generated from the [I<--name>]). + =item B<pool-define> I<file> Define an inactive persistent storage pool or modify an existing persistent one from the XML I<file>. -=item B<pool-define-as> I<name> I<type> [I<--print-xml>] +=item B<pool-define-as> I<name> I<type> [I<--source-host hostname>] [I<--source-path path>] [I<--source-dev path>] [I<--source-name name>] [I<--target path>] [I<--source-format format>] [I<--auth-type authtype> I<--auth-username username> I<--secret-usage usage>] [[I<--adapter-name name>] | [I<--adapter-wwnn> I<--adapter-wwpn>] -[I<--adapter-parent parent>]] +[I<--adapter-parent parent>]] [I<--print-xml>] Create, but do not start, a pool object I<name> from the raw parameters. If I<--print-xml> is specified, then print the XML of the pool object -- 2.9.3

3 4

[libvirt] [PATCH] news: Move recent bug fixes into 3.2.0 release
by Jiri Denemark 27 Mar '17

27 Mar '17

Commits 29f7b5ea6a and 5edf9aaf54 pushed them incorrectly at the end of the file in the bug fixes section for libvirt 2.5.0. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as trivial. docs/news.xml | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 494c6489b..85a1d4d97 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -120,7 +120,17 @@ zero out pages for qemu. The timeout is now flexible and computed by libvirt at domain startup. </description> - </change> + </change> + <change> + <summary> + Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device + </summary> + </change> + <change> + <summary> + Describe the logical backend requirements better for pool-create-as + </summary> + </change> </section> </release> <release version="v3.1.0" date="2017-03-03"> @@ -704,16 +714,6 @@ Fix compilation on macOS </summary> </change> - <change> - <summary> - Overwrite (clear) 2 KB instead of just 512 bytes when initializing logical device - </summary> - </change> - <change> - <summary> - Describe the logical backend requirements better for pool-create-as - </summary> - </change> </section> </release> </libvirt> -- 2.12.0

1 0

[libvirt] [PATCH 0/2] build: Fix build on mingw
by Martin Kletzander 27 Mar '17

27 Mar '17

Fixes pushed under build-breaker rule. Martin Kletzander (2): Use stub for virNetDevGetName on mingw Build vircaps2xmltest and requirements only on Linux configure.ac | 7 ++++--- src/util/virnetdev.c | 10 ++++++++++ tests/Makefile.am | 17 ++++++++++------- tests/vircaps2xmltest.c | 16 ++-------------- 4 files changed, 26 insertions(+), 24 deletions(-) -- 2.12.2

1 2

[libvirt] [PATCH 0/4] Start refactoring migration cookies
by Jiri Denemark 27 Mar '17

27 Mar '17

This series is a first step in refactoring migration cookies. The rest will take some time until it's done, but I figured the part which moves the code is very fragile and I don't really want to keep rebasing it until the refactoring is finished. Jiri Denemark (4): qemu: Move migration cookies to a separate file qemu: Fix formatting in qemu_migration_cookie.c qemu: Typedef migration cookie enums qemu: Free persistent def inside qemuMigrationCookieFree po/POTFILES.in | 1 + src/Makefile.am | 1 + src/qemu/qemu_migration.c | 1425 +------------------------------------- src/qemu/qemu_migration_cookie.c | 1348 ++++++++++++++++++++++++++++++++++++ src/qemu/qemu_migration_cookie.h | 153 ++++ 5 files changed, 1512 insertions(+), 1416 deletions(-) create mode 100644 src/qemu/qemu_migration_cookie.c create mode 100644 src/qemu/qemu_migration_cookie.h -- 2.12.1

2 6

[libvirt] [PATCH] news: Add support for setting TSC frequency
by Jiri Denemark 27 Mar '17

27 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/news.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index a77279948..3f3821a16 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -72,6 +72,15 @@ introducing a new host device type in the XML. </description> </change> + <changes> + <summary> + qemu: Add support for setting TSC frequency + </summary> + <description> + Setting TSC frequency is required to enable migration for domains + with 'invtsc' CPU feature turned on. + </description> + </changes> </section> <section title="Improvements"> <change> -- 2.12.0

2 1

[libvirt] [PATCH 0/4] qemu: Add support for setting TSC frequency to enable migration with invtsc
by Jiri Denemark 27 Mar '17

27 Mar '17

QEMU allows for TSC frequency to be explicitly set to enable migration with invtsc (migration fails if the destination QEMU cannot set the exact same frequency used when starting the domain on the source host). Jiri Denemark (4): conf: Fix XML parser for timer frequency qemu: Add support for setting TSC frequency qemu: Use virCPUCheckFeature in qemuMigrationIsAllowed qemu: Allow migration with invtsc if tsc frequency is set src/conf/domain_conf.c | 2 +- src/qemu/qemu_command.c | 16 ++++++---- src/qemu/qemu_migration.c | 28 +++++++++++------ .../qemuxml2argv-cpu-tsc-frequency.args | 23 ++++++++++++++ .../qemuxml2argv-cpu-tsc-frequency.xml | 35 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 1 + 6 files changed, 89 insertions(+), 16 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cpu-tsc-frequency.xml -- 2.12.1

2 6

[libvirt] [PATCH v2] virmdev: fix build on non-Linux
by Roman Bogorodskiy 27 Mar '17

27 Mar '17

- Make virMediatedDeviceNew() stub args match its prototype - Fix typo: virRerportError -> virReportError - Move MDEV_SYSFS_DEVICES definition out of the #ifdef __linux__ block so we don't have to stub virMediatedDeviceGetSysfsPath() --- Changes from v1: instead of adding a stub for virMediatedDeviceGetSysfsPath(), just unconditionally define MDEV_SYSFS_DEVICES as it makes things easier for the tests. src/util/virmdev.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index e924af3c1..2a1ade739 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -28,6 +28,8 @@ #define VIR_FROM_THIS VIR_FROM_NONE +#define MDEV_SYSFS_DEVICES "/sys/bus/mdev/devices/" + VIR_LOG_INIT("util.mdev"); struct _virMediatedDevice { @@ -68,7 +70,6 @@ virMediatedOnceInit(void) VIR_ONCE_GLOBAL_INIT(virMediated) #ifdef __linux__ -# define MDEV_SYSFS_DEVICES "/sys/bus/mdev/devices/" static int virMediatedDeviceGetSysfsDeviceAPI(virMediatedDevicePtr dev, @@ -173,12 +174,12 @@ virMediatedDeviceNew(const char *uuidstr, virMediatedDeviceModelType model) #else virMediatedDevicePtr -virMediatedDeviceNew(virPCIDeviceAddressPtr pciaddr ATTRIBUTE_UNUSED, - const char *uuidstr ATTRIBUTE_UNUSED) +virMediatedDeviceNew(const char *uuidstr ATTRIBUTE_UNUSED, + virMediatedDeviceModelType model ATTRIBUTE_UNUSED) { - virRerportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("mediated devices are not supported on non-linux " - "platforms")); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("mediated devices are not supported on non-linux " + "platforms")); return NULL; } -- 2.11.0

1 1

[libvirt] [PATCH] util: Fix build on FreeBSD
by Jiri Denemark 27 Mar '17

27 Mar '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as a trivial build-braker. src/util/virnetdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..486fe4cd1 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, ret = 0; cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, ret < 0 ? "Fail" : "Success"); VIR_FORCE_CLOSE(s); -- 2.12.0

2 3

[libvirt] [PATCH] netdev: fix build on non-Linux
by Roman Bogorodskiy 27 Mar '17

27 Mar '17

Fix some typos in the source code: - Missplaced ")", - virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and syntax-checking failing, so I cannot do a complete test build. src/util/virnetdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..47e2b20d5 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, ret = 0; cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, ret < 0 ? "Fail" : "Success"); VIR_FORCE_CLOSE(s); @@ -2336,7 +2336,7 @@ virNetDevReadNetConfig(const char *linkdev ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, const char *stateDir ATTRIBUTE_UNUSED, virMacAddrPtr *adminMAC ATTRIBUTE_UNUSED, - virNetDevVLanPtr *vlan ATTRIBUTE_UNUSED, + virNetDevVlanPtr *vlan ATTRIBUTE_UNUSED, virMacAddrPtr *MAC ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", -- 2.11.0

3 3

[libvirt] [PATCH] news: Update after recent commits
by Peter Krempa 27 Mar '17

27 Mar '17

Mention the hyperv notifier and the new API to set block thresholds. --- docs/news.xml | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 814bd93fd..2dbd2335d 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -70,6 +70,20 @@ introducing a new host device type in the XML. </description> </change> + <change> + <summary> + Add support for block device threshold event + </summary> + <description> + When using thin provisioning, management tools need to resize the + disk in certain cases. To avoid having them to poll disk usage + this version introduces an event which will be fired when a given + offset of the storage is written by the hypervisor. Together with the + API it allows registering thresholds for given storage backing + volumes and this event will then notify management if the threshold + is exceeded. Currently only the qemu driver supports this. + </description> + </change> </section> <section title="Improvements"> <change> @@ -94,6 +108,17 @@ applications running on the platform. </description> </change> + <change> + <summary> + Write hyperv crash information into vm log + </summary> + <description> + qemu's implementation of the hyperv panic notifier now reports + information about the crash from the guest os. Libvirt starting from + this version logs the information to the vm log file for possible + debugging. + </description> + </change> </section> <section title="Bug fixes"> <change> -- 2.12.1

2 1

[libvirt] [PATCH 0/2] More simple fixes.
by John Ferlan 27 Mar '17

27 Mar '17

One noted after push w/r/t change in news.xml and the other found after I rebased to current head from recent commit. John Ferlan (2): news: Add <change> lost in merge util: Remove NONNUL from virHostdevReAttachMediatedDevices docs/news.xml | 2 ++ src/util/virhostdev.h | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.9.3

2 4

[libvirt] [PATCH] virmdev: fix build on non-Linux
by Roman Bogorodskiy 27 Mar '17

27 Mar '17

- Make virMediatedDeviceNew() stub args match its prototype - Fix typo: virRerportError -> virReportError - Move virMediatedDeviceGetSysfsPath() into #ifdef __linux__ block as it uses MDEV_SYSFS_DEVICES, and a stub for it --- I'm not pushing this one too, until I get a completely clean build. src/util/virmdev.c | 39 ++++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/src/util/virmdev.c b/src/util/virmdev.c index e924af3c1..e49ea18e5 100644 --- a/src/util/virmdev.c +++ b/src/util/virmdev.c @@ -170,15 +170,34 @@ virMediatedDeviceNew(const char *uuidstr, virMediatedDeviceModelType model) return ret; } + +char * +virMediatedDeviceGetSysfsPath(const char *uuidstr) +{ + char *ret = NULL; + + ignore_value(virAsprintf(&ret, MDEV_SYSFS_DEVICES "%s", uuidstr)); + return ret; +} + #else virMediatedDevicePtr -virMediatedDeviceNew(virPCIDeviceAddressPtr pciaddr ATTRIBUTE_UNUSED, - const char *uuidstr ATTRIBUTE_UNUSED) +virMediatedDeviceNew(const char *uuidstr ATTRIBUTE_UNUSED, + virMediatedDeviceModelType model ATTRIBUTE_UNUSED) { - virRerportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("mediated devices are not supported on non-linux " - "platforms")); + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("mediated devices are not supported on non-linux " + "platforms")); + return NULL; +} + +char * +virMediatedDeviceGetSysfsPath(const char *uuidstr ATTRIBUTE_UNUSED) +{ + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("mediated devices are not supported on non-linux " + "platforms")); return NULL; } @@ -423,16 +442,6 @@ virMediatedDeviceIsUsed(virMediatedDevicePtr dev, } -char * -virMediatedDeviceGetSysfsPath(const char *uuidstr) -{ - char *ret = NULL; - - ignore_value(virAsprintf(&ret, MDEV_SYSFS_DEVICES "%s", uuidstr)); - return ret; -} - - int virMediatedDeviceListMarkDevices(virMediatedDeviceListPtr dst, virMediatedDeviceListPtr src, -- 2.11.0

1 0

[libvirt] [PATCH] network: better validation of devices in hostdev network pool
by Laine Stump 27 Mar '17

27 Mar '17

This adds a few validations to the devices listed for a hostdev network: * devices must be listed by PCI address, not by netdev name * listing a device by PCI address is valid only for hostdev networks, not for other types of network (e.g. macvtap passthrough). * each device in a hostdev pool must be an SR-IOV VF Resolves: https://bugzilla.redhat.com/1004676 --- src/network/bridge_driver.c | 47 ++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 3a7a249..3270dc5 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -3224,14 +3224,55 @@ networkValidate(virNetworkDriverStatePtr driver, * the type of each. */ for (i = 0; i < def->forward.nifs; i++) { - switch ((virNetworkForwardHostdevDeviceType) - def->forward.ifs[i].type) { + virNetworkForwardIfDefPtr iface = &def->forward.ifs[i]; + char *sysfs_path = NULL; + + switch ((virNetworkForwardHostdevDeviceType) iface->type) { case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_NETDEV: usesInterface = true; + + if (def->forward.type == VIR_NETWORK_FORWARD_HOSTDEV) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("hostdev network '%s' lists '%s' " + "in the device pool, but hostdev " + "networks require all devices to " + "be listed by PCI address, not " + "network device name"), + def->name, iface->device.dev); + return -1; + } break; - case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_PCI: + + case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_PCI: { usesAddress = true; + + if (def->forward.type != VIR_NETWORK_FORWARD_HOSTDEV) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("network '%s' has forward mode '%s' " + " but lists a device by PCI address " + "in the device pool. This is only " + "supported for networks with forward " + "mode 'hostdev'"), + def->name, + virNetworkForwardTypeToString(def->forward.type)); + return -1; + } + + if (virPCIDeviceAddressGetSysfsFile(&iface->device.pci, &sysfs_path) < 0) + return -1; + + if (!virPCIIsVirtualFunction(sysfs_path)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("device '%s' in network '%s' is not " + "an SR-IOV Virtual Function"), + sysfs_path, def->name); + VIR_FREE(sysfs_path); + return -1; + } + VIR_FREE(sysfs_path); break; + } + case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_NONE: case VIR_NETWORK_FORWARD_HOSTDEV_DEVICE_LAST: break; -- 2.9.3

2 1

[libvirt] [PATCH 0/3] Build and other fixes
by Martin Kletzander 27 Mar '17

27 Mar '17

So I broke the build on non-Linux. Sorry. But I did that *because* I was considering other platforms in the code. Also there was a bad dereference somewhere. So because it's three patches, I'm rather sending it for review than just pushing it. Martin Kletzander (3): tests: Properly dereference cpus pointer in virnumamock.c virhostcpu: Expose virHostCPUGetOnline on non-Linux virhostcpu: Make only defined symbols available src/util/virhostcpu.c | 35 +++++++++++++++++------------------ src/util/virhostcpu.h | 5 ++++- tests/virnumamock.c | 2 +- 3 files changed, 22 insertions(+), 20 deletions(-) -- 2.12.1

2 8

[libvirt] [PATCH] logical: Need to overwrite/clear more than just first 512 bytes
by John Ferlan 27 Mar '17

27 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1430679 As it turns out some file headers (e.g. ext4) may be larger/longer than the 512 bytes of zeros being written prior to a pvcreate, so let's write out 2048 bytes similar to how the pvcreate sources would peek at the first 4 sectors of the device. Make sure there is at enough bytes on the device to clear before doing doing the clear - just to be sure. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/storage/storage_backend_logical.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 29d63b1..9ca6fd4 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -93,7 +93,8 @@ static int virStorageBackendLogicalInitializeDevice(const char *path) { int fd = -1; - char zeros[PV_BLANK_SECTOR_SIZE] = {0}; + char zeros[4 * PV_BLANK_SECTOR_SIZE] = {0}; + off_t size; int ret = -1; virCommandPtr pvcmd = NULL; @@ -107,6 +108,25 @@ virStorageBackendLogicalInitializeDevice(const char *path) return -1; } + if ((size = lseek(fd, 0, SEEK_END)) == (off_t)-1) { + virReportSystemError(errno, + _("failed to seek to end of %s"), path); + goto cleanup; + } + + if (size < 4 * PV_BLANK_SECTOR_SIZE) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, + _("cannot initialize '%s' detected size='%lu' less " + "than minimum required='%d"), + path, size, 4 * PV_BLANK_SECTOR_SIZE); + goto cleanup; + } + if ((size = lseek(fd, 0, SEEK_SET)) == (off_t)-1) { + virReportSystemError(errno, + _("failed to seek to start of %s"), path); + goto cleanup; + } + if (safewrite(fd, zeros, sizeof(zeros)) < 0) { virReportSystemError(errno, _("cannot clear device header of '%s'"), path); -- 2.9.3

2 1

[libvirt] [PATCH 0/2] Fix syntax check
by Jiri Denemark 27 Mar '17

27 Mar '17

Jiri Denemark (2): build: Fix sc_prohibit_exit_in_tests syntax check build: Fix syntax check in VPATH cfg.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.12.2

2 3

[libvirt] [PATCH 0/2] Reject negative storage size
by Ján Tomko 27 Mar '17

27 Mar '17

https://bugzilla.redhat.com/show_bug.cgi?id=1436119 Ján Tomko (2): storage: reject negative capacity virsh: reject more negative numbers src/conf/storage_conf.c | 2 +- tools/virsh-domain.c | 22 +++++++++++----------- tools/virsh-host.c | 6 +++--- tools/virsh-volume.c | 2 +- 4 files changed, 16 insertions(+), 16 deletions(-) -- 2.10.2

2 3

[libvirt] [PATCH] qemu: command: align disk serial check to schema
by Nikolay Shirokovskiy 27 Mar '17

27 Mar '17

Disk serial schema has extra '.+' allowed characters in comparison with check in code. Looks like there is no reason for that as qemu allows any character AFAIK for serial. This discrepancy is originated in 85d15b51 where ability to add serial was added. --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index c76f923..c5369b0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -432,7 +432,7 @@ qemuBuildIoEventFdStr(virBufferPtr buf, } #define QEMU_SERIAL_PARAM_ACCEPTED_CHARS \ - "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_ " + "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789-_ .+" static int qemuSafeSerialParamValue(const char *value) -- 1.8.3.1

2 1

[libvirt] [PATCH 0/4] qemu: Use additional data reported by the hyperv panic notifier
by Peter Krempa 27 Mar '17

27 Mar '17

Allow easier debug of windows crashes by reporting the 5 additional field now reported by qemu if the hyperv panic notifier is used. Plus few cleanups noticed while adding the code. Peter Krempa (4): qemu: driver: Remove useless forward declarations qemu: driver: Fix formatting in processGuestPanicEvent qemu: monitor: Extract additional info from GUEST_PANICKED event qemu: Log additional data from hyperv crash notifier src/qemu/qemu_driver.c | 81 +++++++++++++++++++++++++++++++------------- src/qemu/qemu_monitor.c | 15 ++++++-- src/qemu/qemu_monitor.h | 32 ++++++++++++++++- src/qemu/qemu_monitor_json.c | 56 ++++++++++++++++++++++++++++-- src/qemu/qemu_process.c | 2 ++ 5 files changed, 157 insertions(+), 29 deletions(-) -- 2.12.0

2 10

[libvirt] [PATCH] conf: validate that PCI controller index is < 256
by Laine Stump 27 Mar '17

27 Mar '17

This is the maximum for many reasons, for starters because index == bus number, and a controller's bus number is 8 bits. This incidentally resolves: https://bugzilla.redhat.com/1329090 --- src/conf/domain_conf.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6bbc6a2..2139ab0 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -4846,6 +4846,24 @@ virDomainNetDefValidate(const virDomainNetDef *net) static int +virDomainControllerDefValidate(const virDomainControllerDef *controller) +{ + if (controller->type == VIR_DOMAIN_CONTROLLER_TYPE_PCI) { + if (controller->idx > 255) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("PCI controller index %d too high, or too many " + "PCI controllers. A maximum of 256 PCI " + "controllers is allowed, and the maximum value " + "of the index attribute is 255"), + controller->idx); + return -1; + } + } + return 0; +} + + +static int virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, const virDomainDef *def) { @@ -4867,6 +4885,7 @@ virDomainDeviceDefValidateInternal(const virDomainDeviceDef *dev, case VIR_DOMAIN_DEVICE_HOSTDEV: case VIR_DOMAIN_DEVICE_WATCHDOG: case VIR_DOMAIN_DEVICE_CONTROLLER: + return virDomainControllerDefValidate(dev->data.controller); case VIR_DOMAIN_DEVICE_GRAPHICS: case VIR_DOMAIN_DEVICE_HUB: case VIR_DOMAIN_DEVICE_SMARTCARD: -- 2.9.3

2 3

[libvirt] [PATCH] util: fix build on RHEL 6
by Eric Blake 27 Mar '17

27 Mar '17

We keep forgetting that older setups don't like 'index': CC util/libvirt_util_la-virsysinfo.lo cc1: warnings being treated as errors util/virstoragefile.c: In function 'virStorageSourceFindByNodeName': util/virstoragefile.c:3804: error: declaration of 'index' shadows a global declaration [-Wshadow] /usr/include/string.h:489: error: shadowed declaration is here [-Wshadow] Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing under the build-breaker rule src/util/virstoragefile.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 0ac7079..22cdb83 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -1,7 +1,7 @@ /* * virstoragefile.c: file utility functions for FS storage backend * - * Copyright (C) 2007-2014, 2016 Red Hat, Inc. + * Copyright (C) 2007-2017 Red Hat, Inc. * Copyright (C) 2007-2008 Daniel P. Berrange * * This library is free software; you can redistribute it and/or @@ -3801,23 +3801,23 @@ virStorageSourceIsRelative(virStorageSourcePtr src) virStorageSourcePtr virStorageSourceFindByNodeName(virStorageSourcePtr top, const char *nodeName, - unsigned int *index) + unsigned int *idx) { virStorageSourcePtr tmp; - if (index) - *index = 0; + if (idx) + *idx = 0; for (tmp = top; tmp; tmp = tmp->backingStore) { if ((tmp->nodeformat && STREQ(tmp->nodeformat, nodeName)) || (tmp->nodebacking && STREQ(tmp->nodebacking, nodeName))) return tmp; - if (index) - (*index)++; + if (idx) + (*idx)++; } - if (index) - *index = 0; + if (idx) + *idx = 0; return NULL; } -- 2.9.3

1 0

[libvirt] [PATCH 00/23] Pre-CAT preparation patches (mostly trivial, I promise)
by Martin Kletzander 27 Mar '17

27 Mar '17

Don't get pushed away just because it is 23 patches. They are almost one-liners. Just a lot of stuff I got dragged into, lot of rabbit holes where I reached the end, basically lot of side fixes. That's mostly due to one of the bigger changes being removed from the series completely about two days ago when I realized I'm not spending week of fixing terribly tricky stuff just so we can test one more teeny tiny thing that's not even needed (which I realized way too late). The patches are available on github: https://github.com/nertpinx/libvirt -- branch pre-cat The patches should be *really* nice to review, and there's lot of cleanups. The only reason for this patch-series to add more lines than remove them, is because it adds tests. And tests are good and yummy. Me like tests... Yeah, I guess it's Friday, 8PM. I should go home... Bye. Martin Kletzander (23): Add virNumaGetNodeCPUs to private syms Introduce virCPUProbeHost Expose virCapabilitiesFreeGuest vmware: Fix some initialization problems cpu: Don't use prefixes for no reason syms: Add one newline to make things consistent tests: Fix indentation in virhostcputest vz: Do not use magic constants when building capabilities Separate syms based on files they are defined in openvz: Ditch openvzGetNodeCPUs tests: Remove some unneeded files virfile: Add helpers for reading simple values tests: Add cpu/{online,present} files for old tests util: Add virsysfs for handling sysfs files util: Adapt virhostcpu to the new virsysfs Move src/fdstream to src/util/virfdstream Remove src/nodeinfo util: Fix naming in util/virnodesuspend Change virQEMUCapsInitPages to virCapabilitiesInitPages tests: Add sysfs node/cpu topology for the only vircaps2xml testcase tests: Add linux-caches sysfs entries for vircaps2xmltest tests: Add virnumamock tests: Enhance vircaps2xml test cfg.mk | 2 +- po/POTFILES.in | 3 +- src/Makefile.am | 7 +- src/bhyve/bhyve_capabilities.c | 20 +- src/bhyve/bhyve_driver.c | 7 +- src/conf/capabilities.c | 317 +++++++++++++++- src/conf/capabilities.h | 9 + src/conf/virchrdev.c | 2 +- src/cpu/cpu.c | 15 +- src/cpu/cpu.h | 5 +- src/libvirt_linux.syms | 1 - src/libvirt_private.syms | 93 +++-- src/libxl/libxl_migration.c | 2 +- src/lxc/lxc_conf.c | 3 +- src/lxc/lxc_driver.c | 7 +- src/nodeinfo.c | 418 --------------------- src/openvz/openvz_conf.c | 17 +- src/openvz/openvz_conf.h | 1 - src/openvz/openvz_driver.c | 5 +- src/phyp/phyp_driver.c | 3 +- src/qemu/qemu_capabilities.c | 43 +-- src/qemu/qemu_conf.c | 1 - src/qemu/qemu_driver.c | 7 +- src/qemu/qemu_migration.c | 2 +- src/storage/storage_driver.c | 2 +- src/storage/storage_util.c | 2 +- src/test/test_driver.c | 2 +- src/uml/uml_conf.c | 3 +- src/uml/uml_driver.c | 7 +- src/{fdstream.c => util/virfdstream.c} | 4 +- src/{fdstream.h => util/virfdstream.h} | 2 +- src/util/virfile.c | 83 ++++ src/util/virfile.h | 6 + src/util/virhostcpu.c | 345 +++++------------ src/util/virhostcpu.h | 7 +- src/util/virhostcpupriv.h | 2 - src/util/virnodesuspend.c | 20 +- src/util/virnodesuspend.h | 6 +- src/util/virsysfs.c | 229 +++++++++++ src/util/virsysfs.h | 70 ++++ src/{nodeinfo.h => util/virsysfspriv.h} | 18 +- src/vbox/vbox_common.c | 7 +- src/vmware/vmware_conf.c | 20 +- src/vz/vz_driver.c | 16 +- src/vz/vz_sdk.c | 1 - src/xen/xen_driver.c | 5 +- tests/Makefile.am | 7 + tests/commandtest.c | 1 - tests/fdstreamtest.c | 2 +- .../linux-basic/cpu/cpu0/topology/core_id} | 0 .../linux-basic/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list | 1 + .../cpu/cpu0/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list} | 0 .../linux-basic/cpu/cpu1/topology/core_id | 1 + .../linux-basic/cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list | 1 + .../cpu/cpu1/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu10/topology/core_id | 1 + .../linux-basic/cpu/cpu10/topology/core_siblings | 1 + .../cpu/cpu10/topology/core_siblings_list | 1 + .../cpu/cpu10/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu10/topology/thread_siblings | 1 + .../cpu/cpu10/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu11/topology/core_id | 1 + .../linux-basic/cpu/cpu11/topology/core_siblings | 1 + .../cpu/cpu11/topology/core_siblings_list | 1 + .../cpu/cpu11/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu11/topology/thread_siblings | 1 + .../cpu/cpu11/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu12/topology/core_id | 1 + .../linux-basic/cpu/cpu12/topology/core_siblings | 1 + .../cpu/cpu12/topology/core_siblings_list | 1 + .../cpu/cpu12/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu12/topology/thread_siblings | 1 + .../cpu/cpu12/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu13/topology/core_id | 1 + .../linux-basic/cpu/cpu13/topology/core_siblings | 1 + .../cpu/cpu13/topology/core_siblings_list | 1 + .../cpu/cpu13/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu13/topology/thread_siblings | 1 + .../cpu/cpu13/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu14/topology/core_id | 1 + .../linux-basic/cpu/cpu14/topology/core_siblings | 1 + .../cpu/cpu14/topology/core_siblings_list | 1 + .../cpu/cpu14/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu14/topology/thread_siblings | 1 + .../cpu/cpu14/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu15/topology/core_id | 1 + .../linux-basic/cpu/cpu15/topology/core_siblings | 1 + .../cpu/cpu15/topology/core_siblings_list | 1 + .../cpu/cpu15/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu15/topology/thread_siblings | 1 + .../cpu/cpu15/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu2/topology/core_id | 1 + .../linux-basic/cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list | 1 + .../cpu/cpu2/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu3/topology/core_id | 1 + .../linux-basic/cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list | 1 + .../cpu/cpu3/topology/physical_package_id} | 0 .../linux-basic/cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu4/topology/core_id | 1 + .../linux-basic/cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list | 1 + .../cpu/cpu4/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu5/topology/core_id | 1 + .../linux-basic/cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list | 1 + .../cpu/cpu5/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu6/topology/core_id | 1 + .../linux-basic/cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list | 1 + .../cpu/cpu6/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu7/topology/core_id | 1 + .../linux-basic/cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list | 1 + .../cpu/cpu7/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu8/topology/core_id | 1 + .../linux-basic/cpu/cpu8/topology/core_siblings | 1 + .../cpu/cpu8/topology/core_siblings_list | 1 + .../cpu/cpu8/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu8/topology/thread_siblings | 1 + .../cpu/cpu8/topology/thread_siblings_list | 1 + .../linux-basic/cpu/cpu9/topology/core_id | 1 + .../linux-basic/cpu/cpu9/topology/core_siblings | 1 + .../cpu/cpu9/topology/core_siblings_list | 1 + .../cpu/cpu9/topology/physical_package_id | 1 + .../linux-basic/cpu/cpu9/topology/thread_siblings | 1 + .../cpu/cpu9/topology/thread_siblings_list | 1 + tests/vircaps2xmldata/linux-basic/cpu/online | 1 + tests/vircaps2xmldata/linux-basic/cpu/present | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu0 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu1 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu2 | 1 + tests/vircaps2xmldata/linux-basic/node/node0/cpu3 | 1 + .../vircaps2xmldata/linux-basic/node/node0/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu4 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu5 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu6 | 1 + tests/vircaps2xmldata/linux-basic/node/node1/cpu7 | 1 + .../vircaps2xmldata/linux-basic/node/node1/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu10 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu11 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu8 | 1 + tests/vircaps2xmldata/linux-basic/node/node2/cpu9 | 1 + .../vircaps2xmldata/linux-basic/node/node2/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu12 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu13 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu14 | 1 + tests/vircaps2xmldata/linux-basic/node/node3/cpu15 | 1 + .../vircaps2xmldata/linux-basic/node/node3/cpulist | 1 + tests/vircaps2xmldata/linux-basic/node/online | 1 + tests/vircaps2xmldata/linux-basic/node/possible | 1 + .../linux-caches/cpu/cpu0/cache/index0/level | 1 + .../cpu/cpu0/cache/index0/shared_cpu_list | 1 + .../cpu/cpu0/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index0/size | 1 + .../linux-caches/cpu/cpu0/cache/index0/type | 1 + .../linux-caches/cpu/cpu0/cache/index1/level | 1 + .../cpu/cpu0/cache/index1/shared_cpu_list | 1 + .../cpu/cpu0/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index1/size | 1 + .../linux-caches/cpu/cpu0/cache/index1/type | 1 + .../linux-caches/cpu/cpu0/cache/index2/level | 1 + .../cpu/cpu0/cache/index2/shared_cpu_list | 1 + .../cpu/cpu0/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index2/size | 1 + .../linux-caches/cpu/cpu0/cache/index2/type | 1 + .../linux-caches/cpu/cpu0/cache/index3/level | 1 + .../cpu/cpu0/cache/index3/shared_cpu_list} | 0 .../cpu/cpu0/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu0/cache/index3/size | 1 + .../linux-caches/cpu/cpu0/cache/index3/type | 1 + .../linux-caches/cpu/cpu0/topology/core_id} | 0 .../linux-caches/cpu/cpu0/topology/core_siblings | 1 + .../cpu/cpu0/topology/core_siblings_list} | 0 .../cpu/cpu0/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu0/topology/thread_siblings | 1 + .../cpu/cpu0/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu1/cache/index0/level | 1 + .../cpu/cpu1/cache/index0/shared_cpu_list | 1 + .../cpu/cpu1/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index0/size | 1 + .../linux-caches/cpu/cpu1/cache/index0/type | 1 + .../linux-caches/cpu/cpu1/cache/index1/level | 1 + .../cpu/cpu1/cache/index1/shared_cpu_list | 1 + .../cpu/cpu1/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index1/size | 1 + .../linux-caches/cpu/cpu1/cache/index1/type | 1 + .../linux-caches/cpu/cpu1/cache/index2/level | 1 + .../cpu/cpu1/cache/index2/shared_cpu_list | 1 + .../cpu/cpu1/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index2/size | 1 + .../linux-caches/cpu/cpu1/cache/index2/type | 1 + .../linux-caches/cpu/cpu1/cache/index3/level | 1 + .../cpu/cpu1/cache/index3/shared_cpu_list} | 0 .../cpu/cpu1/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu1/cache/index3/size | 1 + .../linux-caches/cpu/cpu1/cache/index3/type | 1 + .../linux-caches/cpu/cpu1/topology/core_id | 1 + .../linux-caches/cpu/cpu1/topology/core_siblings | 1 + .../cpu/cpu1/topology/core_siblings_list} | 0 .../cpu/cpu1/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu1/topology/thread_siblings | 1 + .../cpu/cpu1/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu2/cache/index0/level | 1 + .../cpu/cpu2/cache/index0/shared_cpu_list | 1 + .../cpu/cpu2/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index0/size | 1 + .../linux-caches/cpu/cpu2/cache/index0/type | 1 + .../linux-caches/cpu/cpu2/cache/index1/level | 1 + .../cpu/cpu2/cache/index1/shared_cpu_list | 1 + .../cpu/cpu2/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index1/size | 1 + .../linux-caches/cpu/cpu2/cache/index1/type | 1 + .../linux-caches/cpu/cpu2/cache/index2/level | 1 + .../cpu/cpu2/cache/index2/shared_cpu_list | 1 + .../cpu/cpu2/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index2/size | 1 + .../linux-caches/cpu/cpu2/cache/index2/type | 1 + .../linux-caches/cpu/cpu2/cache/index3/level | 1 + .../cpu/cpu2/cache/index3/shared_cpu_list} | 0 .../cpu/cpu2/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu2/cache/index3/size | 1 + .../linux-caches/cpu/cpu2/cache/index3/type | 1 + .../linux-caches/cpu/cpu2/topology/core_id | 1 + .../linux-caches/cpu/cpu2/topology/core_siblings | 1 + .../cpu/cpu2/topology/core_siblings_list} | 0 .../cpu/cpu2/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu2/topology/thread_siblings | 1 + .../cpu/cpu2/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu3/cache/index0/level | 1 + .../cpu/cpu3/cache/index0/shared_cpu_list | 1 + .../cpu/cpu3/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index0/size | 1 + .../linux-caches/cpu/cpu3/cache/index0/type | 1 + .../linux-caches/cpu/cpu3/cache/index1/level | 1 + .../cpu/cpu3/cache/index1/shared_cpu_list | 1 + .../cpu/cpu3/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index1/size | 1 + .../linux-caches/cpu/cpu3/cache/index1/type | 1 + .../linux-caches/cpu/cpu3/cache/index2/level | 1 + .../cpu/cpu3/cache/index2/shared_cpu_list | 1 + .../cpu/cpu3/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index2/size | 1 + .../linux-caches/cpu/cpu3/cache/index2/type | 1 + .../linux-caches/cpu/cpu3/cache/index3/level | 1 + .../cpu/cpu3/cache/index3/shared_cpu_list} | 0 .../cpu/cpu3/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu3/cache/index3/size | 1 + .../linux-caches/cpu/cpu3/cache/index3/type | 1 + .../linux-caches/cpu/cpu3/topology/core_id | 1 + .../linux-caches/cpu/cpu3/topology/core_siblings | 1 + .../cpu/cpu3/topology/core_siblings_list} | 0 .../cpu/cpu3/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu3/topology/thread_siblings | 1 + .../cpu/cpu3/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu4/cache/index0/level | 1 + .../cpu/cpu4/cache/index0/shared_cpu_list | 1 + .../cpu/cpu4/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index0/size | 1 + .../linux-caches/cpu/cpu4/cache/index0/type | 1 + .../linux-caches/cpu/cpu4/cache/index1/level | 1 + .../cpu/cpu4/cache/index1/shared_cpu_list | 1 + .../cpu/cpu4/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index1/size | 1 + .../linux-caches/cpu/cpu4/cache/index1/type | 1 + .../linux-caches/cpu/cpu4/cache/index2/level | 1 + .../cpu/cpu4/cache/index2/shared_cpu_list | 1 + .../cpu/cpu4/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index2/size | 1 + .../linux-caches/cpu/cpu4/cache/index2/type | 1 + .../linux-caches/cpu/cpu4/cache/index3/level | 1 + .../cpu/cpu4/cache/index3/shared_cpu_list} | 0 .../cpu/cpu4/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu4/cache/index3/size | 1 + .../linux-caches/cpu/cpu4/cache/index3/type | 1 + .../linux-caches/cpu/cpu4/topology/core_id} | 0 .../linux-caches/cpu/cpu4/topology/core_siblings | 1 + .../cpu/cpu4/topology/core_siblings_list} | 0 .../cpu/cpu4/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu4/topology/thread_siblings | 1 + .../cpu/cpu4/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu5/cache/index0/level | 1 + .../cpu/cpu5/cache/index0/shared_cpu_list | 1 + .../cpu/cpu5/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index0/size | 1 + .../linux-caches/cpu/cpu5/cache/index0/type | 1 + .../linux-caches/cpu/cpu5/cache/index1/level | 1 + .../cpu/cpu5/cache/index1/shared_cpu_list | 1 + .../cpu/cpu5/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index1/size | 1 + .../linux-caches/cpu/cpu5/cache/index1/type | 1 + .../linux-caches/cpu/cpu5/cache/index2/level | 1 + .../cpu/cpu5/cache/index2/shared_cpu_list | 1 + .../cpu/cpu5/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index2/size | 1 + .../linux-caches/cpu/cpu5/cache/index2/type | 1 + .../linux-caches/cpu/cpu5/cache/index3/level | 1 + .../cpu/cpu5/cache/index3/shared_cpu_list} | 0 .../cpu/cpu5/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu5/cache/index3/size | 1 + .../linux-caches/cpu/cpu5/cache/index3/type | 1 + .../linux-caches/cpu/cpu5/topology/core_id | 1 + .../linux-caches/cpu/cpu5/topology/core_siblings | 1 + .../cpu/cpu5/topology/core_siblings_list} | 0 .../cpu/cpu5/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu5/topology/thread_siblings | 1 + .../cpu/cpu5/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu6/cache/index0/level | 1 + .../cpu/cpu6/cache/index0/shared_cpu_list | 1 + .../cpu/cpu6/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index0/size | 1 + .../linux-caches/cpu/cpu6/cache/index0/type | 1 + .../linux-caches/cpu/cpu6/cache/index1/level | 1 + .../cpu/cpu6/cache/index1/shared_cpu_list | 1 + .../cpu/cpu6/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index1/size | 1 + .../linux-caches/cpu/cpu6/cache/index1/type | 1 + .../linux-caches/cpu/cpu6/cache/index2/level | 1 + .../cpu/cpu6/cache/index2/shared_cpu_list | 1 + .../cpu/cpu6/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index2/size | 1 + .../linux-caches/cpu/cpu6/cache/index2/type | 1 + .../linux-caches/cpu/cpu6/cache/index3/level | 1 + .../cpu/cpu6/cache/index3/shared_cpu_list} | 0 .../cpu/cpu6/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu6/cache/index3/size | 1 + .../linux-caches/cpu/cpu6/cache/index3/type | 1 + .../linux-caches/cpu/cpu6/topology/core_id | 1 + .../linux-caches/cpu/cpu6/topology/core_siblings | 1 + .../cpu/cpu6/topology/core_siblings_list} | 0 .../cpu/cpu6/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu6/topology/thread_siblings | 1 + .../cpu/cpu6/topology/thread_siblings_list | 1 + .../linux-caches/cpu/cpu7/cache/index0/level | 1 + .../cpu/cpu7/cache/index0/shared_cpu_list | 1 + .../cpu/cpu7/cache/index0/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index0/size | 1 + .../linux-caches/cpu/cpu7/cache/index0/type | 1 + .../linux-caches/cpu/cpu7/cache/index1/level | 1 + .../cpu/cpu7/cache/index1/shared_cpu_list | 1 + .../cpu/cpu7/cache/index1/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index1/size | 1 + .../linux-caches/cpu/cpu7/cache/index1/type | 1 + .../linux-caches/cpu/cpu7/cache/index2/level | 1 + .../cpu/cpu7/cache/index2/shared_cpu_list | 1 + .../cpu/cpu7/cache/index2/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index2/size | 1 + .../linux-caches/cpu/cpu7/cache/index2/type | 1 + .../linux-caches/cpu/cpu7/cache/index3/level | 1 + .../cpu/cpu7/cache/index3/shared_cpu_list} | 0 .../cpu/cpu7/cache/index3/shared_cpu_map | 1 + .../linux-caches/cpu/cpu7/cache/index3/size | 1 + .../linux-caches/cpu/cpu7/cache/index3/type | 1 + .../linux-caches/cpu/cpu7/topology/core_id | 1 + .../linux-caches/cpu/cpu7/topology/core_siblings | 1 + .../cpu/cpu7/topology/core_siblings_list} | 0 .../cpu/cpu7/topology/physical_package_id} | 0 .../linux-caches/cpu/cpu7/topology/thread_siblings | 1 + .../cpu/cpu7/topology/thread_siblings_list | 1 + tests/vircaps2xmldata/linux-caches/cpu/kernel_max | 1 + .../linux-caches/cpu/online} | 0 .../linux-caches/cpu/present} | 0 tests/vircaps2xmldata/linux-caches/node/node0/cpu0 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu1 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu2 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu3 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu4 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu5 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu6 | 1 + tests/vircaps2xmldata/linux-caches/node/node0/cpu7 | 1 + .../linux-caches/node/node0/cpulist} | 0 .../linux-caches/node/node0/meminfo | 31 ++ .../linux-caches/node/online} | 0 .../linux-caches/node}/possible | 0 tests/vircaps2xmldata/vircaps-aarch64-basic.xml | 64 ++++ tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml | 74 ---- tests/vircaps2xmldata/vircaps-x86_64-basic.xml | 62 +++ tests/vircaps2xmldata/vircaps-x86_64-caches.xml | 33 ++ tests/vircaps2xmltest.c | 133 +++---- .../cpu/offline | 0 .../cpu/possible | 0 tests/virhostcpudata/linux-deconf-cpus/cpu/offline | 1 - .../virhostcpudata/linux-deconf-cpus/cpu/possible | 1 - tests/virhostcpudata/linux-raspberrypi/cpu/offline | 1 - .../linux-rhelsa-3.19.0-mustang/cpu/offline | 1 - tests/virhostcpudata/linux-subcores1/cpu/offline | 1 - tests/virhostcpudata/linux-subcores1/cpu/possible | 1 - tests/virhostcpudata/linux-subcores2/cpu/offline | 1 - tests/virhostcpudata/linux-subcores2/cpu/possible | 1 - tests/virhostcpudata/linux-subcores3/cpu/offline | 1 - tests/virhostcpudata/linux-subcores3/cpu/possible | 1 - tests/virhostcpudata/linux-test1/cpu/online | 1 + tests/virhostcpudata/linux-test1/cpu/present | 1 + tests/virhostcpudata/linux-test2/cpu/online | 1 + tests/virhostcpudata/linux-test2/cpu/present | 1 + tests/virhostcpudata/linux-test3/cpu/online | 1 + tests/virhostcpudata/linux-test3/cpu/present | 1 + tests/virhostcpudata/linux-test4/cpu/online | 1 + tests/virhostcpudata/linux-test4/cpu/present | 1 + tests/virhostcpudata/linux-test5/cpu/online | 1 + tests/virhostcpudata/linux-test5/cpu/present | 1 + tests/virhostcpudata/linux-test6/cpu/online | 1 + .../cpu/possible => linux-test6/cpu/present} | 0 tests/virhostcpudata/linux-test7/cpu/online | 1 + tests/virhostcpudata/linux-test7/cpu/present | 1 + tests/virhostcpudata/linux-test8/cpu/offline | 0 tests/virhostcpudata/linux-test8/cpu/possible | 1 - tests/virhostcputest.c | 9 +- tests/virnumamock.c | 191 ++++++++++ 427 files changed, 1736 insertions(+), 1047 deletions(-) delete mode 100644 src/nodeinfo.c rename src/{fdstream.c => util/virfdstream.c} (99%) rename src/{fdstream.h => util/virfdstream.h} (97%) create mode 100644 src/util/virsysfs.c create mode 100644 src/util/virsysfs.h rename src/{nodeinfo.h => util/virsysfspriv.h} (62%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu0/topology/thread_siblings copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu0/topology/thread_siblings_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu1/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu10/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu11/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu12/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu13/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu14/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu15/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu2/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/core_siblings_list copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-basic/cpu/cpu3/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu8/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/core_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/physical_package_id create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/cpu9/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/online create mode 100644 tests/vircaps2xmldata/linux-basic/cpu/present create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu0 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu1 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu2 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node0/cpu3 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node0/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu4 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu5 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu6 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node1/cpu7 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node1/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu10 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu11 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu8 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node2/cpu9 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node2/cpulist create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu12 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu13 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu14 create mode 120000 tests/vircaps2xmldata/linux-basic/node/node3/cpu15 create mode 100644 tests/vircaps2xmldata/linux-basic/node/node3/cpulist create mode 100644 tests/vircaps2xmldata/linux-basic/node/online create mode 100644 tests/vircaps2xmldata/linux-basic/node/possible create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/cache/index3/type copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_siblings rename tests/{virhostcpudata/linux-rhelsa-3.19.0-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu0/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu0/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu1/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu1/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu2/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu2/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu3/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu3/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/cache/index3/type copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu4/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu4/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu5/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu5/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu6/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu6/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index0/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index1/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/level create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/shared_cpu_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index2/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/level copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/shared_cpu_list} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/shared_cpu_map create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/size create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/cache/index3/type create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_id create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_siblings copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/topology/core_siblings_list} (100%) copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/cpu/cpu7/topology/physical_package_id} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/thread_siblings create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/cpu7/topology/thread_siblings_list create mode 100644 tests/vircaps2xmldata/linux-caches/cpu/kernel_max copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/online} (100%) copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/cpu/present} (100%) create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu0 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu1 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu2 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu3 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu4 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu5 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu6 create mode 120000 tests/vircaps2xmldata/linux-caches/node/node0/cpu7 copy tests/{virhostcpudata/linux-f21-mustang/cpu/possible => vircaps2xmldata/linux-caches/node/node0/cpulist} (100%) create mode 100644 tests/vircaps2xmldata/linux-caches/node/node0/meminfo copy tests/{virhostcpudata/linux-raspberrypi/cpu/possible => vircaps2xmldata/linux-caches/node/online} (100%) rename tests/{virhostcpudata/linux-raspberrypi/cpu => vircaps2xmldata/linux-caches/node}/possible (100%) create mode 100644 tests/vircaps2xmldata/vircaps-aarch64-basic.xml delete mode 100644 tests/vircaps2xmldata/vircaps-basic-4-4-2G.xml create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-basic.xml create mode 100644 tests/vircaps2xmldata/vircaps-x86_64-caches.xml rename tests/virhostcpudata/{linux-f21-mustang => linux-caches1}/cpu/offline (100%) copy tests/virhostcpudata/{linux-f21-mustang => linux-caches1}/cpu/possible (100%) delete mode 100644 tests/virhostcpudata/linux-deconf-cpus/cpu/offline delete mode 100644 tests/virhostcpudata/linux-deconf-cpus/cpu/possible delete mode 100644 tests/virhostcpudata/linux-raspberrypi/cpu/offline delete mode 100644 tests/virhostcpudata/linux-rhelsa-3.19.0-mustang/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores1/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores1/cpu/possible delete mode 100644 tests/virhostcpudata/linux-subcores2/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores2/cpu/possible delete mode 100644 tests/virhostcpudata/linux-subcores3/cpu/offline delete mode 100644 tests/virhostcpudata/linux-subcores3/cpu/possible create mode 100644 tests/virhostcpudata/linux-test1/cpu/online create mode 100644 tests/virhostcpudata/linux-test1/cpu/present create mode 100644 tests/virhostcpudata/linux-test2/cpu/online create mode 100644 tests/virhostcpudata/linux-test2/cpu/present create mode 100644 tests/virhostcpudata/linux-test3/cpu/online create mode 100644 tests/virhostcpudata/linux-test3/cpu/present create mode 100644 tests/virhostcpudata/linux-test4/cpu/online create mode 100644 tests/virhostcpudata/linux-test4/cpu/present create mode 100644 tests/virhostcpudata/linux-test5/cpu/online create mode 100644 tests/virhostcpudata/linux-test5/cpu/present create mode 100644 tests/virhostcpudata/linux-test6/cpu/online rename tests/virhostcpudata/{linux-f21-mustang/cpu/possible => linux-test6/cpu/present} (100%) create mode 100644 tests/virhostcpudata/linux-test7/cpu/online create mode 100644 tests/virhostcpudata/linux-test7/cpu/present delete mode 100644 tests/virhostcpudata/linux-test8/cpu/offline delete mode 100644 tests/virhostcpudata/linux-test8/cpu/possible create mode 100644 tests/virnumamock.c -- 2.12.0

3 29

[libvirt] Plan for next release
by Daniel Veillard 27 Mar '17

27 Mar '17

Hi all, if we want to release around the end of the month, I think we need to enter freeze on Monday end of day (for me europe) to try to get the release around the next week-end. I assume that work for everyone, if not please tell :-) Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 2

[libvirt] [PATCH] Fix build with GCC's static analysis
by Martin Kletzander 27 Mar '17

27 Mar '17

STREQ_NULLABLE returns true if both parameters are NULL. And that's not what we want here. We just want to skop comparing source nodes that don't have that info set. The function wouldn't make much sense with nodeName == NULL, so we don't need to check that. Moreover, the function's declaration uses ATTRIBUDE_NONNULL for nodeName, which not only means that function expects the parameter not to be NULL, but actually tells the compiler that it can optimize out the NULL checks. That way it could end up calling strcmp on NULL (either nodeformat or nodebacking). GCC figures this out if libvirt is compiled with lv_cv_static_analysis=yes, unfortunately not everyone uses that. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/util/virstoragefile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 3bcb69bf6206..0ac707962102 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -3809,8 +3809,8 @@ virStorageSourceFindByNodeName(virStorageSourcePtr top, *index = 0; for (tmp = top; tmp; tmp = tmp->backingStore) { - if (STREQ_NULLABLE(tmp->nodeformat, nodeName) || - STREQ_NULLABLE(tmp->nodebacking, nodeName)) + if ((tmp->nodeformat && STREQ(tmp->nodeformat, nodeName)) || + (tmp->nodebacking && STREQ(tmp->nodebacking, nodeName))) return tmp; if (index) -- 2.12.1

3 4

[libvirt] [PATCH v2 00/11] Fix saving/setting/restoring SR-IOV VF MAC address
by Laine Stump 27 Mar '17

27 Mar '17

I pushed the 1st 10 patches of this series. The rest of the series was ACKed as well, except patch 11, which is patch 01/11 in this repost. Michal had asked that the rewrite of the saving/restoring of MAC and vlan tag data use a more sane format for the data file (it has been just an unformatted plaintext file since the beginning, which has always bothered me, but not enough to change it.) The resulting JSON format file is *much* nicer, and will be easier to expand if we ever need to. Patches 2 - 11 were already ACKed and haven't been modified, but feel free to go over them again if you want :-) Laine Stump (11): util: new functions virNetDev(Save|Read|Set)NetConfig() util: use new virNetDev*NetConfig() functions for macvtap setup/teardown util: use new virNetDev*NetConfig() functions for hostdev setup/teardown util: replace virHostdevNetConfigReplace with ...(Save|Set)NetConfig() util: save hostdev network device config before unbinding from host driver util: after hostdev assignment, restore VF MAC address via setting admin MAC util: remove unused functions from virnetdev.c util: if setting admin MAC to 00:00:00:00:00:00 fails, try 02:00:00:00:00:00 util: try *really* hard to set the MAC address of an SRIOV VF util: log all setting of MAC addresses and vlan tags util: rename virHostdevNetConfigRestore() to virHostdevRestoreNetConfig() src/libvirt_private.syms | 7 +- src/util/virhostdev.c | 147 ++++++-- src/util/virnetdev.c | 855 +++++++++++++++++++++++++++++++------------- src/util/virnetdev.h | 29 +- src/util/virnetdevmacvlan.c | 40 ++- 5 files changed, 778 insertions(+), 300 deletions(-) -- 2.9.3

2 12

[libvirt] [PATCH 00/23] Add block write threshold event
by Peter Krempa 27 Mar '17

27 Mar '17

This is another version of the stuff that I've posted here: https://www.redhat.com/archives/libvir-list/2017-February/msg01391.html which was partially based on the very old discussion at https://www.redhat.com/archives/libvir-list/2015-May/msg00580.html This version fixes some of the review feedback that I've got and also fixes all the issues pointed out in the original cover letter since I managed to implement the node name detection in a way suitable for this. The event is useful for mgmt apps using thin-provisioned storage so that they don't have to poll for the disk filling all the time. Peter Krempa (23): qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs util: buffer: Add API to set indentation level to a given value util: storage: Split out useful bits of virStorageFileParseChainIndex util: storage: Add variables for node names into virStorageSource lib: Introduce event for tracking disk backing file write threshold qemu: monitor: Add support for BLOCK_WRITE_THRESHOLD event qemu: domain: Add helper to lookup disk by node name qemu: domain: Add helper to generate indexed backing store names qemu: process: Wire up firing of the VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD event lib: Add API for setting the threshold size for VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD virsh: Implement 'domblkthreshold' command to call virDomainSetBlockThreshold qemu: domain: Add helper to look up disk soruce by the backing store string qemu: implement qemuDomainSetBlockThreshold qemu: capabilities: add capability for query-named-block-nodes qmp cmd qemu: monitor: Add monitor infrastructure for query-named-block-nodes qemu: block: Add code to allow detection of auto-allocated node names tests: qemumonitorjson: Add test case for node name detection code tests: qemumonitorjson: Add long backing chain test case for node name detection tests: qemumonitorjson: Add case for two disks sharing a backing image tests: qemumonitorjson: Add relative image names for node name detection tests: qemumonitorjson: Test node name detection on networked storage qemu: monitor: Extract the top level format node when querying disks qemu: block: Add code to detect node names when necessary daemon/remote.c | 45 + examples/object-events/event-test.c | 19 + include/libvirt/libvirt-domain.h | 36 + src/Makefile.am | 1 + src/conf/domain_event.c | 97 + src/conf/domain_event.h | 15 + src/driver-hypervisor.h | 8 + src/libvirt-domain.c | 51 + src/libvirt_private.syms | 5 + src/libvirt_public.syms | 1 + src/qemu/qemu_block.c | 378 ++++ src/qemu/qemu_block.h | 51 + src/qemu/qemu_blockjob.c | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_domain.c | 102 + src/qemu/qemu_domain.h | 14 + src/qemu/qemu_driver.c | 80 +- src/qemu/qemu_monitor.c | 54 +- src/qemu/qemu_monitor.h | 20 + src/qemu/qemu_monitor_json.c | 91 +- src/qemu/qemu_monitor_json.h | 9 + src/qemu/qemu_process.c | 44 + src/remote/remote_driver.c | 34 + src/remote/remote_protocol.x | 33 +- src/remote_protocol-structs | 16 + src/util/virbuffer.c | 19 + src/util/virbuffer.h | 2 + src/util/virstoragefile.c | 108 +- src/util/virstoragefile.h | 15 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 + .../caps_2.6.0-gicv2.aarch64.xml | 2 + .../caps_2.6.0-gicv3.aarch64.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 2 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 2 + .../qemumonitorjson-nodename-1.json | 268 +++ .../qemumonitorjson-nodename-1.result | 15 + .../qemumonitorjson-nodename-2.json | 2270 ++++++++++++++++++++ .../qemumonitorjson-nodename-2.result | 60 + .../qemumonitorjson-nodename-gluster.json | 135 ++ .../qemumonitorjson-nodename-gluster.result | 10 + .../qemumonitorjson-nodename-relative.json | 554 +++++ .../qemumonitorjson-nodename-relative.result | 31 + .../qemumonitorjson-nodename-same-backing.json | 316 +++ .../qemumonitorjson-nodename-same-backing.result | 11 + tests/qemumonitorjsontest.c | 120 ++ tools/virsh-domain.c | 85 + tools/virsh.pod | 8 + 55 files changed, 5243 insertions(+), 19 deletions(-) create mode 100644 src/qemu/qemu_block.c create mode 100644 src/qemu/qemu_block.h create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-1.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-1.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-2.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-gluster.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-relative.result create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing.json create mode 100644 tests/qemumonitorjsondata/qemumonitorjson-nodename-same-backing.result -- 2.12.0

2 64

[libvirt] [PATCH] docs: make interface start mode element optional
by Laine Stump 27 Mar '17

27 Mar '17

This brings the libvirt version of this RNG file in line with the same file in netcf (as soon as the corresponding patch there is ACKed and pushed). There's no reason to require it when defining an interface (the config option it corresponds to is optional), and it isn't even output in the status of an interface. Resolves: https://bugzilla.redhat.com/1414404 --- docs/schemas/interface.rng | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/docs/schemas/interface.rng b/docs/schemas/interface.rng index 052703c..4bb08e9 100644 --- a/docs/schemas/interface.rng +++ b/docs/schemas/interface.rng @@ -279,17 +279,19 @@ </define> <define name="startmode"> - <element name="start"> - <attribute name="mode"> - <choice> - <value>onboot</value> - <value>none</value> - <value>hotplug</value> -  - </choice> - </attribute> - </element> + <optional> + <element name="start"> + <attribute name="mode"> + <choice> + <value>onboot</value> + <value>none</value> + <value>hotplug</value> +  + </choice> + </attribute> + </element> + </optional> </define> <!-- -- 2.9.3

2 1

[libvirt] Question about qemuDomainLogContextNew
by Liu Feng 27 Mar '17

27 Mar '17

Hi, Dear all I have a question, and need your help. I want to output some log message to "/var/log/libvirt/qemu/instance-xxxxxx" when guest kernel crashed, so I add following the code: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> static int qemuProcessHandleGuestPanic(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, void *opaque) { ...... + qemuDomainLogContextPtr logCtxt = NULL; + if (!(logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START))){ + VIR_WARN("Unable to open domainlog"); + goto cleanup; + } ...... } <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< But this code cannot get the logCtxt, logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START) always return NULL, so I CANNOT write message to log file. Really Need your help, Thanks! Thanks Feng

3 2

[libvirt] [PATCH] conf: don't ignore <target dev='blah'/> for macvtap interfaces
by Laine Stump 27 Mar '17

27 Mar '17

The parser had been clearing out *all* suggested device names for type='direct' (aka macvtap) interfaces. All of the code implementing macvtap allows for a user-specified device name, so we should allow it. In the case that an interface name starts with "macvtap" or "macvlan" though, we do still clear it out, just as we do with "vnet" (which is the prefix used for automatically generated tap device names), since those are the prefixes for the names we autogenerate for macvtap and macvlan devices. Resolves: https://bugzilla.redhat.com/1335798 --- docs/formatdomain.html.in | 6 +++--- src/conf/domain_conf.c | 6 +++++- src/conf/domain_conf.h | 4 ++++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 4a3123e..8a2294f 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5125,9 +5125,9 @@ qemu-kvm -net nic,model=? /dev/null If no target is specified, certain hypervisors will automatically generate a name for the created tun device. This name can be manually specified, however the name <i>should not - start with either 'vnet' or 'vif'</i>, which are prefixes - reserved by libvirt and certain hypervisors. Manually specified - targets using these prefixes may be ignored. + start with either 'vnet', 'vif', 'macvtap', or 'macvlan'</i>, + which are prefixes reserved by libvirt and certain hypervisors. + Manually specified targets using these prefixes may be ignored. </p> <p> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 2139ab0..4b80018 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9826,8 +9826,12 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, def->data.direct.linkdev = dev; dev = NULL; - if (flags & VIR_DOMAIN_DEF_PARSE_INACTIVE) + if (ifname && + flags & VIR_DOMAIN_DEF_PARSE_INACTIVE && + (STRPREFIX(ifname, VIR_NET_GENERATED_MACVTAP_PREFIX) || + STRPREFIX(ifname, VIR_NET_GENERATED_MACVTAP_PREFIX))) { VIR_FREE(ifname); + } break; diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 8e6d874..38a15f1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1033,6 +1033,10 @@ struct _virDomainNetDef { * by libvirt, and cannot be used for a persistent network name. */ # define VIR_NET_GENERATED_PREFIX "vnet" +/* except to macvtap/macvlan interfaces, which start with "macv(tap|lan) */ +# define VIR_NET_GENERATED_MACVTAP_PREFIX "macvtap" +# define VIR_NET_GENERATED_MACVLAN_PREFIX "macvlan" + typedef enum { VIR_DOMAIN_CHR_DEVICE_STATE_DEFAULT = 0, VIR_DOMAIN_CHR_DEVICE_STATE_CONNECTED, -- 2.9.3

2 1

[libvirt] Question about qemuDomainLogContextNew()
by Feng Feng24 Liu 27 Mar '17

27 Mar '17

Hi, Dear all I have a question, and need your help. 　　I want to output some log message to "/var/log/libvirt/qemu/instance-xxxxxx" when guest kernel crashed, so I add following the code: >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> static int qemuProcessHandleGuestPanic(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, void *opaque) { ...... + qemuDomainLogContextPtr logCtxt = NULL; + if (!(logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START))){ + VIR_WARN("Unable to open domainlog"); + goto cleanup; + } ...... } <<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< But this code cannot get the logCtxt, logCtxt = qemuDomainLogContextNew(driver, vm, QEMU_DOMAIN_LOG_CONTEXT_MODE_START) always return NULL, so I CANNOT write message to log file. Really Need your help, Thanks! Thanks Feng

1 0

[libvirt] [PATCH 0/2] Fix possible use-after-free when sending event message
by John Ferlan 27 Mar '17

27 Mar '17

Rework patches/logic most recently posted here: https://www.redhat.com/archives/libvir-list/2017-March/msg00072.html John Ferlan (2): daemon: Rework remoteClientFreeFunc cleanup loops into C macro remote: Fix possible use-after-free when sending event message daemon/remote.c | 158 +++++++++++++++++++------------------------------------- 1 file changed, 52 insertions(+), 106 deletions(-) -- 2.9.3

2 3

[libvirt] [PATCH v4 00/10] Add TLS support for migration
by John Ferlan 26 Mar '17

26 Mar '17

v3: http://www.redhat.com/archives/libvir-list/2017-March/msg00878.html Changes from v1 Patch 1: Fix the (false); to (0) Patch 2: New to adjust the other (false); in qemu_conf.c Patch 3: Alter the text slightly - also found that the client parameters are only required if *tls_x509_verify = 1, so adjust the descriptions to reflect that Patch 4: Alter the vnc_* and chardev_* descriptions to match the migrate_* Patch 5: Previous patch 3, ACK'd Patch 6: Previous patch 4, altered comments Patch 7: Previous patch 5, fixed commit message Patch 8: Previous patch 6, multiple changes: - Reduced verbosity of comments - Rework the ResetTLS logic (combined code, fetched tls-creds if necessary again) - Add the qemuProcessRecoverMigrationIn call to ResetTLS in the FINISH3 stage Patch 9: Previous patch 7, alter based on patch 7 adjustments vis-a-vis ResetTLS Patch 10: Previous patch 8, alter text of description to include "migrate" All changes were tested in my nested virt environment... A virsh qemu-monitor-command $DOM '{"execute":"query-migrate-parameters"}' after the migrations were completed (back and forth) returned "" for tls-creds and tls-hostname for each hostname (incoming and outgoing tests). John Ferlan (10): qemu: Create #define for TLS configuration setup. qemu: Replace macro usage of (false); with just (0) conf: Introduce migrate_tls_x509_cert_dir qemu: Update the TLS client verify descriptions for vnc and chardev Add new migration flag VIR_MIGRATE_TLS qemu: Add TLS params to _qemuMonitorMigrationParams qemu: Add job for qemuDomain{Add|Del}TLSObjects qemu: Set up the migration TLS objects for target qemu: Set up the migration TLS objects for source docs: Add news entry for Migration using TLS docs/news.xml | 8 + include/libvirt/libvirt-domain.h | 8 + src/qemu/libvirtd_qemu.aug | 5 + src/qemu/qemu.conf | 63 ++++++- src/qemu/qemu_conf.c | 47 +++-- src/qemu/qemu_conf.h | 4 + src/qemu/qemu_domain.c | 7 +- src/qemu/qemu_domain.h | 91 ++++++---- src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_hotplug.c | 24 ++- src/qemu/qemu_hotplug.h | 2 + src/qemu/qemu_migration.c | 363 ++++++++++++++++++++++++++++++++++++- src/qemu/qemu_migration.h | 16 +- src/qemu/qemu_monitor.c | 11 +- src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_monitor_json.c | 21 +++ src/qemu/qemu_process.c | 3 + src/qemu/test_libvirtd_qemu.aug.in | 3 + tests/qemumonitorjsontest.c | 25 ++- tools/virsh-domain.c | 7 + 20 files changed, 641 insertions(+), 76 deletions(-) -- 2.9.3

3 21

[libvirt] [PATCH 1/2] bhyve: helper function to probe hypervisor caps
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

There are a number of functions in bhyve_capabilities.c that probe hypervisor capabilities by executing the bhyve(1) binary with the specific device arugment, checking error message (if any) and setting proper capability bit. As those are extremely similar, move this logic into a helper function and convert existing functions to use that. --- src/bhyve/bhyve_capabilities.c | 122 +++++++++++++++++------------------------ 1 file changed, 49 insertions(+), 73 deletions(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 4bf1d84fa..f72fdea41 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -193,121 +193,97 @@ virBhyveProbeGrubCaps(virBhyveGrubCapsFlags *caps) } static int -bhyveProbeCapsRTC_UTC(unsigned int *caps, char *binary) +bhyveProbeCapsDeviceHelper(unsigned int *caps, + char *binary, + const char *bus, + const char *device, + const char *errormsg, + unsigned int flag) { - char *help; + char *error; virCommandPtr cmd = NULL; - int ret = 0, exit; + int ret = -1, exit; cmd = virCommandNew(binary); - virCommandAddArg(cmd, "-h"); - virCommandSetErrorBuffer(cmd, &help); - if (virCommandRun(cmd, &exit) < 0) { - ret = -1; - goto out; - } + virCommandAddArgList(cmd, bus, device, NULL); + virCommandSetErrorBuffer(cmd, &error); + if (virCommandRun(cmd, &exit) < 0) + goto cleanup; - if (strstr(help, "-u:") != NULL) - *caps |= BHYVE_CAP_RTC_UTC; + if (strstr(error, errormsg) == NULL) + *caps |= flag; - out: - VIR_FREE(help); + ret = 0; + cleanup: + VIR_FREE(error); virCommandFree(cmd); return ret; } static int -bhyveProbeCapsAHCI32Slot(unsigned int *caps, char *binary) +bhyveProbeCapsRTC_UTC(unsigned int *caps, char *binary) { - char *error; + char *help; virCommandPtr cmd = NULL; int ret = 0, exit; cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-s", "0,ahci", NULL); - virCommandSetErrorBuffer(cmd, &error); + virCommandAddArg(cmd, "-h"); + virCommandSetErrorBuffer(cmd, &help); if (virCommandRun(cmd, &exit) < 0) { ret = -1; goto out; } - if (strstr(error, "pci slot 0:0: unknown device \"ahci\"") == NULL) - *caps |= BHYVE_CAP_AHCI32SLOT; + if (strstr(help, "-u:") != NULL) + *caps |= BHYVE_CAP_RTC_UTC; out: - VIR_FREE(error); + VIR_FREE(help); virCommandFree(cmd); return ret; } static int -bhyveProbeCapsNetE1000(unsigned int *caps, char *binary) +bhyveProbeCapsAHCI32Slot(unsigned int *caps, char *binary) { - char *error; - virCommandPtr cmd = NULL; - int ret = -1, exit; - - cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-s", "0,e1000", NULL); - virCommandSetErrorBuffer(cmd, &error); - if (virCommandRun(cmd, &exit) < 0) - goto cleanup; + return bhyveProbeCapsDeviceHelper(caps, binary, + "-s", + "0,ahci", + "pci slot 0:0: unknown device \"ahci\"", + BHYVE_CAP_AHCI32SLOT); +} - if (strstr(error, "pci slot 0:0: unknown device \"e1000\"") == NULL) - *caps |= BHYVE_CAP_NET_E1000; - ret = 0; - cleanup: - VIR_FREE(error); - virCommandFree(cmd); - return ret; +static int +bhyveProbeCapsNetE1000(unsigned int *caps, char *binary) +{ + return bhyveProbeCapsDeviceHelper(caps, binary, + "-s", + "0,e1000", + "pci slot 0:0: unknown device \"e1000\"", + BHYVE_CAP_NET_E1000); } static int bhyveProbeCapsLPC_Bootrom(unsigned int *caps, char *binary) { - char *error; - virCommandPtr cmd = NULL; - int ret = -1, exit; - - cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-l", "bootrom", NULL); - virCommandSetErrorBuffer(cmd, &error); - if (virCommandRun(cmd, &exit) < 0) - goto cleanup; - - if (strstr(error, "bhyve: invalid lpc device configuration 'bootrom'") == NULL) - *caps |= BHYVE_CAP_LPC_BOOTROM; - - ret = 0; - cleanup: - VIR_FREE(error); - virCommandFree(cmd); - return ret; + return bhyveProbeCapsDeviceHelper(caps, binary, + "-l", + "bootrom", + "bhyve: invalid lpc device configuration 'bootrom'", + BHYVE_CAP_LPC_BOOTROM); } static int bhyveProbeCapsFramebuffer(unsigned int *caps, char *binary) { - char *error; - virCommandPtr cmd = NULL; - int ret = -1, exit; - - cmd = virCommandNew(binary); - virCommandAddArgList(cmd, "-s", "0,fbuf", NULL); - virCommandSetErrorBuffer(cmd, &error); - if (virCommandRun(cmd, &exit) < 0) - goto cleanup; - - if (strstr(error, "pci slot 0:0: unknown device \"fbuf\"") == NULL) - *caps |= BHYVE_CAP_FBUF; - - ret = 0; - cleanup: - VIR_FREE(error); - virCommandFree(cmd); - return ret; + return bhyveProbeCapsDeviceHelper(caps, binary, + "-s", + "0,fbuf", + "pci slot 0:0: unknown device \"fbuf\"", + BHYVE_CAP_FBUF); } int -- 2.11.0

2 4

[libvirt] [PATCH] domaincapstest: add bhyve caps test
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

* Extract filling bhyve capabilities from virBhyveDomainCapsBuild() into a new function virBhyveDomainCapsFill() to make testing easier by not having to mock firmware directory listing and hypervisor capabilities probing * Also, just presence of the firmware files is not sufficient to enable os.loader.supported, hypervisor should support UEFI boot too * Add tests to domaincapstest for the main caps possible flows: - when UEFI bootrom is supported - when video (fbus) is supported - neither of above is supported --- src/bhyve/bhyve_capabilities.c | 72 +++++++++++++++-------- src/bhyve/bhyve_capabilities.h | 3 + tests/Makefile.am | 4 ++ tests/domaincapsschemadata/bhyve_basic.x86_64.xml | 32 ++++++++++ tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml | 49 +++++++++++++++ tests/domaincapsschemadata/bhyve_uefi.x86_64.xml | 41 +++++++++++++ tests/domaincapstest.c | 65 ++++++++++++++++++++ 7 files changed, 242 insertions(+), 24 deletions(-) create mode 100644 tests/domaincapsschemadata/bhyve_basic.x86_64.xml create mode 100644 tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml create mode 100644 tests/domaincapsschemadata/bhyve_uefi.x86_64.xml diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 4bf1d84fa..6f8be45c4 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -87,6 +87,44 @@ virBhyveCapsBuild(void) return NULL; } +int +virBhyveDomainCapsFill(virDomainCapsPtr caps, + unsigned int bhyvecaps, + virDomainCapsStringValuesPtr firmwares) +{ + caps->disk.supported = true; + VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.diskDevice, + VIR_DOMAIN_DISK_DEVICE_DISK, + VIR_DOMAIN_DISK_DEVICE_CDROM); + + VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.bus, + VIR_DOMAIN_DISK_BUS_SATA, + VIR_DOMAIN_DISK_BUS_VIRTIO); + + caps->os.supported = true; + + if (bhyvecaps & BHYVE_CAP_LPC_BOOTROM) { + caps->os.loader.supported = true; + VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.type, + VIR_DOMAIN_LOADER_TYPE_PFLASH); + VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.readonly, + VIR_TRISTATE_BOOL_YES); + + caps->os.loader.values.values = firmwares->values; + caps->os.loader.values.nvalues = firmwares->nvalues; + } + + + if (bhyvecaps & BHYVE_CAP_FBUF) { + caps->graphics.supported = true; + caps->video.supported = true; + VIR_DOMAIN_CAPS_ENUM_SET(caps->graphics.type, VIR_DOMAIN_GRAPHICS_TYPE_VNC); + VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_TYPE_GOP); + } + return 0; +} + + virDomainCapsPtr virBhyveDomainCapsBuild(bhyveConnPtr conn, const char *emulatorbin, @@ -101,6 +139,7 @@ virBhyveDomainCapsBuild(bhyveConnPtr conn, size_t firmwares_alloc = 0; virBhyveDriverConfigPtr cfg = virBhyveDriverGetConfig(conn); const char *firmware_dir = cfg->firmwareDir; + virDomainCapsStringValuesPtr firmwares = NULL; if (!(caps = virDomainCapsNew(emulatorbin, machine, arch, virttype))) goto cleanup; @@ -111,46 +150,31 @@ virBhyveDomainCapsBuild(bhyveConnPtr conn, goto cleanup; } - caps->os.supported = true; - caps->os.loader.supported = true; - VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.type, - VIR_DOMAIN_LOADER_TYPE_PFLASH); - VIR_DOMAIN_CAPS_ENUM_SET(caps->os.loader.readonly, - VIR_TRISTATE_BOOL_YES); + if (VIR_ALLOC(firmwares) < 0) + goto cleanup; if (virDirOpenIfExists(&dir, firmware_dir) > 0) { while ((virDirRead(dir, &entry, firmware_dir)) > 0) { - if (VIR_RESIZE_N(caps->os.loader.values.values, - firmwares_alloc, caps->os.loader.values.nvalues, 2) < 0) + if (VIR_RESIZE_N(firmwares->values, + firmwares_alloc, firmwares->nvalues, 1) < 0) goto cleanup; if (virAsprintf( - &caps->os.loader.values.values[caps->os.loader.values.nvalues], + &firmwares->values[firmwares->nvalues], "%s/%s", firmware_dir, entry->d_name) < 0) goto cleanup; - caps->os.loader.values.nvalues++; + firmwares->nvalues++; } } else { VIR_WARN("Cannot open firmware directory %s", firmware_dir); } - caps->disk.supported = true; - VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.diskDevice, - VIR_DOMAIN_DISK_DEVICE_DISK, - VIR_DOMAIN_DISK_DEVICE_CDROM); - - VIR_DOMAIN_CAPS_ENUM_SET(caps->disk.bus, - VIR_DOMAIN_DISK_BUS_SATA, - VIR_DOMAIN_DISK_BUS_VIRTIO); + if (virBhyveDomainCapsFill(caps, bhyve_caps, firmwares) < 0) + goto cleanup; - if (bhyve_caps & BHYVE_CAP_FBUF) { - caps->graphics.supported = true; - caps->video.supported = true; - VIR_DOMAIN_CAPS_ENUM_SET(caps->graphics.type, VIR_DOMAIN_GRAPHICS_TYPE_VNC); - VIR_DOMAIN_CAPS_ENUM_SET(caps->video.modelType, VIR_DOMAIN_VIDEO_TYPE_GOP); - } cleanup: + VIR_FREE(firmwares); VIR_DIR_CLOSE(dir); virObjectUnref(cfg); return caps; diff --git a/src/bhyve/bhyve_capabilities.h b/src/bhyve/bhyve_capabilities.h index 3db4f1b88..194061fde 100644 --- a/src/bhyve/bhyve_capabilities.h +++ b/src/bhyve/bhyve_capabilities.h @@ -28,6 +28,9 @@ # include "bhyve_utils.h" virCapsPtr virBhyveCapsBuild(void); +int virBhyveDomainCapsFill(virDomainCapsPtr caps, + unsigned int bhyvecaps, + virDomainCapsStringValuesPtr firmwares); virDomainCapsPtr virBhyveDomainCapsBuild(bhyveConnPtr, const char *emulatorbin, const char *machine, diff --git a/tests/Makefile.am b/tests/Makefile.am index af69a3a84..d4eedaf17 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -964,6 +964,10 @@ domaincapstest_SOURCES += testutilsxen.c testutilsxen.h domaincapstest_LDADD += ../src/libvirt_driver_libxl_impl.la $(GNULIB_LIBS) endif WITH_LIBXL +if WITH_BHYVE +domaincapstest_LDADD += ../src/libvirt_driver_bhyve_impl.la $(GNULIB_LIBS) +endif WITH_BHYVE + virnetmessagetest_SOURCES = \ virnetmessagetest.c testutils.h testutils.c virnetmessagetest_CFLAGS = $(XDR_CFLAGS) $(AM_CFLAGS) diff --git a/tests/domaincapsschemadata/bhyve_basic.x86_64.xml b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml new file mode 100644 index 000000000..f6dfabed2 --- /dev/null +++ b/tests/domaincapsschemadata/bhyve_basic.x86_64.xml @@ -0,0 +1,32 @@ +<domainCapabilities> + <path>/usr/sbin/bhyve</path> + <domain>bhyve</domain> + <machine>(null)</machine> + <arch>x86_64</arch> + <os supported='yes'> + <loader supported='no'/> + </os> + <cpu> + <mode name='host-passthrough' supported='no'/> + <mode name='host-model' supported='no'/> + <mode name='custom' supported='no'/> + </cpu> + <devices> + <disk supported='yes'> + <enum name='diskDevice'> + <value>disk</value> + <value>cdrom</value> + </enum> + <enum name='bus'> + <value>virtio</value> + <value>sata</value> + </enum> + </disk> + <graphics supported='no'/> + <video supported='no'/> + <hostdev supported='no'/> + </devices> + <features> + <gic supported='no'/> + </features> +</domainCapabilities> diff --git a/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml new file mode 100644 index 000000000..6fec72c89 --- /dev/null +++ b/tests/domaincapsschemadata/bhyve_fbuf.x86_64.xml @@ -0,0 +1,49 @@ +<domainCapabilities> + <path>/usr/sbin/bhyve</path> + <domain>bhyve</domain> + <machine>(null)</machine> + <arch>x86_64</arch> + <os supported='yes'> + <loader supported='yes'> + <value>/foo/bar</value> + <value>/foo/baz</value> + <enum name='type'> + <value>pflash</value> + </enum> + <enum name='readonly'> + <value>yes</value> + </enum> + </loader> + </os> + <cpu> + <mode name='host-passthrough' supported='no'/> + <mode name='host-model' supported='no'/> + <mode name='custom' supported='no'/> + </cpu> + <devices> + <disk supported='yes'> + <enum name='diskDevice'> + <value>disk</value> + <value>cdrom</value> + </enum> + <enum name='bus'> + <value>virtio</value> + <value>sata</value> + </enum> + </disk> + <graphics supported='yes'> + <enum name='type'> + <value>vnc</value> + </enum> + </graphics> + <video supported='yes'> + <enum name='modelType'> + <value>gop</value> + </enum> + </video> + <hostdev supported='no'/> + </devices> + <features> + <gic supported='no'/> + </features> +</domainCapabilities> diff --git a/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml new file mode 100644 index 000000000..c0b5c161b --- /dev/null +++ b/tests/domaincapsschemadata/bhyve_uefi.x86_64.xml @@ -0,0 +1,41 @@ +<domainCapabilities> + <path>/usr/sbin/bhyve</path> + <domain>bhyve</domain> + <machine>(null)</machine> + <arch>x86_64</arch> + <os supported='yes'> + <loader supported='yes'> + <value>/foo/bar</value> + <value>/foo/baz</value> + <enum name='type'> + <value>pflash</value> + </enum> + <enum name='readonly'> + <value>yes</value> + </enum> + </loader> + </os> + <cpu> + <mode name='host-passthrough' supported='no'/> + <mode name='host-model' supported='no'/> + <mode name='custom' supported='no'/> + </cpu> + <devices> + <disk supported='yes'> + <enum name='diskDevice'> + <value>disk</value> + <value>cdrom</value> + </enum> + <enum name='bus'> + <value>virtio</value> + <value>sata</value> + </enum> + </disk> + <graphics supported='no'/> + <video supported='no'/> + <hostdev supported='no'/> + </devices> + <features> + <gic supported='no'/> + </features> +</domainCapabilities> diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index a4bc8d6d0..c61a5c05f 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -273,12 +273,37 @@ fillXenCaps(virDomainCapsPtr domCaps) } #endif /* WITH_LIBXL */ +#ifdef WITH_BHYVE +# include "bhyve/bhyve_capabilities.h" + +static int +fillBhyveCaps(virDomainCapsPtr domCaps, unsigned int *bhyve_caps) +{ + virDomainCapsStringValuesPtr firmwares = NULL; + int ret = -1; + + if (VIR_ALLOC(firmwares) < 0) + return -1; + + if (fillStringValues(firmwares, "/foo/bar", "/foo/baz", NULL) < 0) + goto cleanup; + + if (virBhyveDomainCapsFill(domCaps, *bhyve_caps, firmwares) < 0) + goto cleanup; + + ret = 0; + cleanup: + VIR_FREE(firmwares); + return ret; +} +#endif /* WITH_BHYVE */ enum testCapsType { CAPS_NONE, CAPS_ALL, CAPS_QEMU, CAPS_LIBXL, + CAPS_BHYVE, }; struct testData { @@ -333,6 +358,12 @@ test_virDomainCapsFormat(const void *opaque) goto cleanup; #endif break; + case CAPS_BHYVE: +#if WITH_BHYVE + if (fillBhyveCaps(domCaps, data->capsOpaque) < 0) + goto cleanup; +#endif + break; } if (!(domCapsXML = virDomainCapsFormat(domCaps))) @@ -354,6 +385,10 @@ mymain(void) { int ret = 0; +#if WITH_BHYVE + unsigned int bhyve_caps = 0; +#endif + #if WITH_QEMU virQEMUDriverConfigPtr cfg = virQEMUDriverConfigNew(false); @@ -419,6 +454,26 @@ mymain(void) DO_TEST("full", "/bin/emulatorbin", "my-machine-type", "x86_64", VIR_DOMAIN_VIRT_KVM, CAPS_ALL); +#define DO_TEST_BHYVE(Name, Emulator, BhyveCaps, Type) \ + do { \ + char *name = NULL; \ + if (virAsprintf(&name, "bhyve_%s.x86_64", Name) < 0) { \ + ret = -1; \ + break; \ + } \ + struct testData data = { \ + .name = name, \ + .emulator = Emulator, \ + .arch = "x86_64", \ + .type = Type, \ + .capsType = CAPS_BHYVE, \ + .capsOpaque = BhyveCaps, \ + }; \ + if (virTestRun(name, test_virDomainCapsFormat, &data) < 0) \ + ret = -1; \ + VIR_FREE(name); \ + } while (0) + #if WITH_QEMU DO_TEST_QEMU("1.7.0", "caps_1.7.0", @@ -488,6 +543,16 @@ mymain(void) #endif /* WITH_LIBXL */ +#if WITH_BHYVE + DO_TEST_BHYVE("basic", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); + + bhyve_caps |= BHYVE_CAP_LPC_BOOTROM; + DO_TEST_BHYVE("uefi", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); + + bhyve_caps |= BHYVE_CAP_FBUF; + DO_TEST_BHYVE("fbuf", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); +#endif /* WITH_BHYVE */ + return ret; } -- 2.11.0

2 2

[libvirt] [PATCH] domain_capabilities: Don't report machine type for bhyve
by Michal Privoznik 26 Mar '17

26 Mar '17

For some drivers the domain's machine type makes no sense. They just don't use it. A great example is bhyve driver. Therefore it makes very less sense to report machine in domain capabilities XML. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/formatdomaincaps.html.in | 3 ++- src/conf/domain_capabilities.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index 648e3d481..007cab62d 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -70,7 +70,8 @@ <dt><code>machine</code></dt> <dd>The domain's <a href="formatdomain.html#elementsOSBIOS">machine - type</a>.</dd> + type</a>. Since not every hypervisor has a sense of machine types + this element might be omitted in such drivers.</dd> <dt><code>arch</code></dt> <dd>The domain's <a href="formatdomain.html#elementsOSBIOS"> diff --git a/src/conf/domain_capabilities.c b/src/conf/domain_capabilities.c index bb6742359..7a3d2e6fb 100644 --- a/src/conf/domain_capabilities.c +++ b/src/conf/domain_capabilities.c @@ -527,7 +527,8 @@ virDomainCapsFormatInternal(virBufferPtr buf, virBufferEscapeString(buf, "<path>%s</path>\n", caps->path); virBufferAsprintf(buf, "<domain>%s</domain>\n", virttype_str); - virBufferAsprintf(buf, "<machine>%s</machine>\n", caps->machine); + if (caps->machine) + virBufferAsprintf(buf, "<machine>%s</machine>\n", caps->machine); virBufferAsprintf(buf, "<arch>%s</arch>\n", arch_str); if (caps->maxvcpus) -- 2.11.0

2 5

[libvirt] [PATCH] schema: domaincaps: make machine element optional
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

Commit df769041c made the 'machine' element in domaincaps optional. Update the schema to reflect that. --- Pushed as trivial as per https://www.redhat.com/archives/libvir-list/2017-March/msg01239.html docs/schemas/domaincaps.rng | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/schemas/domaincaps.rng b/docs/schemas/domaincaps.rng index 20cbc4e94..39053181e 100644 --- a/docs/schemas/domaincaps.rng +++ b/docs/schemas/domaincaps.rng @@ -17,9 +17,11 @@ <element name='domain'> <text/> </element> - <element name='machine'> - <text/> - </element> + <optional> + <element name='machine'> + <text/> + </element> + </optional> <element name='arch'> <text/> </element> -- 2.11.0

1 0

[libvirt] [PATCH] qemu: fix build with clang
by Roman Bogorodskiy 26 Mar '17

26 Mar '17

qemuMigrationResetTLS() does not initialize 'ret' by default, so when it jumps to 'cleanup' on error, the 'ret' variable will be uninitialized, which clang complains about. Set it to '-1' by default. --- Pushed under the build-breaker rule. src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index d91279ec6..a69e8784a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -3815,7 +3815,7 @@ qemuMigrationResetTLS(virQEMUDriverPtr driver, char *tlsAlias = in_tlsAlias; char *secAlias = in_secAlias; qemuMonitorMigrationParams migParams = { 0 }; - int ret; + int ret = -1; /* If coming from a path that doesn't know whether it's been used or not, * let's first check we need to do this. If the tls-creds doesn't exist -- 2.11.0

1 0

[libvirt] [PATCH libvirt-glib] examples: make detail strings match event details
by Guido Günther 25 Mar '17

25 Mar '17

--- examples/event-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/event-test.c b/examples/event-test.c index 7c9f4ec..a204485 100644 --- a/examples/event-test.c +++ b/examples/event-test.c @@ -78,7 +78,7 @@ static const char *eventDetailToString(int event, int detail) { break; case VIR_DOMAIN_EVENT_SUSPENDED: if (detail == VIR_DOMAIN_EVENT_SUSPENDED_PAUSED) - ret = "Unpaused"; + ret = "Paused"; else if (detail == VIR_DOMAIN_EVENT_SUSPENDED_MIGRATED) ret = "Migrated"; break; @@ -103,7 +103,7 @@ static const char *eventDetailToString(int event, int detail) { ret = "Migrated"; break; case VIR_DOMAIN_EVENT_STOPPED_SAVED: - ret = "Failed"; + ret = "Saved"; break; case VIR_DOMAIN_EVENT_STOPPED_FAILED: ret = "Failed"; -- 2.11.0

2 2

[libvirt] [PATCH] util: fix build on non-Linux
by Roman Bogorodskiy 25 Mar '17

25 Mar '17

Fix typo in virNetDevPFGetVF() stub: ATTRUBUTE_UNUSED -> ATTRIBUTE_UNUSED. While here, use common indent style for arguments in virNetDevGetVirtualFunctionIndex() stub. --- Pushed under the build-breaker rule. src/util/virnetdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index b9e9cbe54..93a931912 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1493,8 +1493,8 @@ virNetDevIsVirtualFunction(const char *ifname ATTRIBUTE_UNUSED) int virNetDevGetVirtualFunctionIndex(const char *pfname ATTRIBUTE_UNUSED, - const char *vfname ATTRIBUTE_UNUSED, - int *vf_index ATTRIBUTE_UNUSED) + const char *vfname ATTRIBUTE_UNUSED, + int *vf_index ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Unable to get virtual function index on this platform")); @@ -1513,7 +1513,7 @@ virNetDevGetPhysicalFunction(const char *ifname ATTRIBUTE_UNUSED, int virNetDevPFGetVF(const char *pfname ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, - char **vfname ATTRUBUTE_UNUSED) + char **vfname ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Unable to get virtual function name on this platform")); -- 2.11.0

2 1

[libvirt] [PATCH] Coverity fix for virNetDevIPCheckIPv6ForwardingCallback
by Cédric Bosdonnat 25 Mar '17

25 Mar '17

Add check for more than one RTA_OIF, even though this is rather unlikely and get rid of the buggy switch / break. --- src/util/virnetdevip.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index c9ac6baf7..f5662413a 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -556,15 +556,17 @@ virNetDevIPCheckIPv6ForwardingCallback(const struct nlmsghdr *resp, if (resp->nlmsg_type != RTM_NEWROUTE) return ret; - /* Extract a few attributes */ + /* Extract a device ID attribute */ for (rta = RTM_RTA(rtmsg); RTA_OK(rta, len); rta = RTA_NEXT(rta, len)) { - switch (rta->rta_type) { - case RTA_OIF: + if (rta->rta_type == RTA_OIF) { oif = *(int *)RTA_DATA(rta); + /* Should never happen: netlink message would be broken */ + if (ifname) + goto error; + if (!(ifname = virNetDevGetName(oif))) goto error; - break; } } -- 2.12.0

3 2

[libvirt] [PATCH] virpci: fix build on non-Linux
by Roman Bogorodskiy 25 Mar '17

25 Mar '17

virPCIGetDeviceAddressFromSysfsLink() should return virPCIDeviceAddressPtr, so return NULL in the stub instead of "-1". --- Pushed under the build-breaker rule. src/util/virpci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 546aeb550..65c108f2e 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2945,7 +2945,7 @@ virPCIDeviceAddressPtr virPCIGetDeviceAddressFromSysfsLink(const char *device_link ATTRIBUTE_UNUSED) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _(unsupported)); - return -1; + return NULL; } -- 2.11.0

1 0

[libvirt] ARMv7 guest PCI support broken in 3.0.0 onwards
by Daniel P. Berrange 24 Mar '17

24 Mar '17

$ cat arm.xml <domain type="qemu"> <name>f22-arm32</name> <uuid>a6bc14fb-585b-40b0-a15b-5e19f26079ba</uuid> <memory>1048576</memory> <currentMemory>1048576</currentMemory> <vcpu>1</vcpu> <os> <type arch="armv7l" machine="virt">hvm</type> <boot dev="hd"/> </os> <clock offset="utc"/> <on_poweroff>destroy</on_poweroff> <on_reboot>restart</on_reboot> <on_crash>restart</on_crash> <devices> <emulator>/usr/bin/qemu-system-arm</emulator> <disk type="file" device="disk"> <driver name="qemu" type="qcow2"/> <source file="/home/berrange/VirtualMachines/demo.qcow2"/> <target dev="sda" bus="scsi"/> </disk> <controller type="scsi" index="0" model="virtio-scsi"/> <interface type="user"> <mac address="52:54:00:87:d4:c0"/> <model type="virtio"/> </interface> <console type="pty"/> </devices> </domain> $ virsh define arm.xml Domain f22-arm32 defined from arm.xml $ virsh start f22-arm32 error: Failed to start domain f22-arm32 error: internal error: qemu unexpectedly closed the monitor: 2017-02-15T09:24:03.967648Z qemu-system-arm: -device ioh3420,port=0x8,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1: MSI is not supported by interrupt controller 2017-02-15T09:24:03.968154Z qemu-system-arm: -device ioh3420,port=0x8,chassis=1,id=pci.1,bus=pcie.0,multifunction=on,addr=0x1: Device initialization failed I've not bisected it other than to find it works in 2.5.0 and is broken in 3.0.0 Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|

3 7

[libvirt] [PATCH 0/3] Report block threshold in bulk stats
by Peter Krempa 24 Mar '17

24 Mar '17

This is a follow up to: https://www.redhat.com/archives/libvir-list/2017-March/msg00650.html so that management apps can query the current value. The series needs to be applied on top of the block threshold series. For convenience I've pushed it to the same remote repository as the original series. You can fetch it here: git fetch git://pipo.sk/pipo/libvirt.git block-threshold-1 Peter Krempa (3): util: json: Make function to free JSON values in virHash universal qemu: block: Add code to fetch block node data by node name qemu: stats: Display the block threshold size in bulk stats src/libvirt-domain.c | 4 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_block.c | 46 +++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_block.h | 3 +++ src/qemu/qemu_driver.c | 51 +++++++++++++++++++++++++++++++++++++++++--- src/qemu/qemu_monitor_json.c | 10 +-------- src/util/virjson.c | 8 +++++++ src/util/virjson.h | 1 + tools/virsh.pod | 3 +++ 9 files changed, 115 insertions(+), 12 deletions(-) -- 2.12.0

2 8