- Devel - libvirt List Archives

[PATCH 0/5] qemu: IO error reporting fixes and improvements (part 1?)
by Peter Krempa 27 Jan '25

27 Jan '25

This series: - fixed bug in lookup of devices for the IO error which made them useless (2/5) - adds framework to return error messages (3/5) - implements the passthrough of errors (4/5) - logs the I/O errors in the VM log (5/5) Peter Krempa (5): qemuProcessHandleIOError: Refactor to extract 'priv' instead of 'driver' qemuProcessHandleIOError: Fix logic for lookup of disk API: Document more possibilities for @reason field of VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON event qemu: monitor: Plumb in disk IO error message passthrough to VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON qemuProcessHandleIOError: Log IO errors in the VM log file include/libvirt/libvirt-domain.h | 8 +++-- src/qemu/qemu_monitor_json.c | 19 ++++++++++-- src/qemu/qemu_process.c | 51 ++++++++++++++++++-------------- 3 files changed, 51 insertions(+), 27 deletions(-) -- 2.48.1

2 11

[PATCH V2 00/20] qemu: support mapped-ram+directio+mulitfd
by Jim Fehlig 25 Jan '25

25 Jan '25

I'm claiming this to be V2 of a series to support QEMU's mapped-ram stream format [1] and migration capability, even though the approach to control the feature is different than V1. To control mapped-ram in V1, I bumped the save format version and added a 'features' field to the save image header. In V2, I use the save_image_format setting in qemu.conf, extending it with a 'sparse' option to enable mapped-ram. IMO, the latter is nicer approach that fits better with existing save options. V2 leaves the "raw" save image format as default. save_image_format must be set to "sparse" to enable use of mapped-ram. Like V1, this version of the series also includes patches that leverage mapped-ram to add support for parallel save/restore. In one of the previous threads on this topic we discussed per-VM control of save image format by adding a 'format' parameter to virDomainSaveParams. I can do that as a followup series if folks agree its useful. Changes in V2 * Use save_image_format setting to control mapped-ram instead of introducing a new field to the header and bumping the save image version * Rename save parameter parallel-connections to parallel-channels * Address other minor comments from V1 [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MNB… Claudio Fontana (3): include: Define constants for parallel save/restore tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command Jim Fehlig (17): lib: virDomain{Save,Restore}Params: Ensure absolute path qemu_fd: Add function to retrieve fdset ID qemu: Add function to check capability in migration params qemu: Add function to get bool value from migration params qemu: Add mapped-ram migration capability qemu: Add function to get migration params for save qemu_saveimage: add "sparse" to supported save image formats qemu: Add helper function for creating save image fd qemu: Move declaration of virQEMUSaveFormat to header file qemu: Add support for mapped-ram on save qemu: Decompose qemuSaveImageOpen qemu: Move creation of qemuProcessIncomingDef struct qemu: Apply migration parameters in qemuMigrationDstRun qemu: Add support for mapped-ram on restore qemu: Support O_DIRECT with mapped-ram on save qemu: Support O_DIRECT with mapped-ram on restore qemu: Add support for parallel save and restore docs/manpages/virsh.rst | 21 ++- include/libvirt/libvirt-domain.h | 11 ++ src/libvirt-domain.c | 95 +++++++++++--- src/qemu/qemu.conf.in | 9 +- src/qemu/qemu_driver.c | 108 +++++++++++----- src/qemu/qemu_fd.c | 18 +++ src/qemu/qemu_fd.h | 3 + src/qemu/qemu_migration.c | 194 +++++++++++++++++++--------- src/qemu/qemu_migration.h | 10 +- src/qemu/qemu_migration_params.c | 92 ++++++++++++++ src/qemu/qemu_migration_params.h | 17 +++ src/qemu/qemu_monitor.c | 40 ++++++ src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_process.c | 117 ++++++++++++----- src/qemu/qemu_process.h | 19 ++- src/qemu/qemu_saveimage.c | 211 ++++++++++++++++++------------- src/qemu/qemu_saveimage.h | 39 +++++- src/qemu/qemu_snapshot.c | 29 +++-- tools/virsh-domain.c | 79 ++++++++++-- 19 files changed, 856 insertions(+), 261 deletions(-) -- 2.43.0

1 21

[PATCH v5 0/5] ch: handle events from cloud-hypervisor
by Purna Pavan Chandra Aekkaladevi 24 Jan '25

24 Jan '25

changes from v4->v5: * Incase of invalid events, exit VirCHEventHandler * Open eventmonitor fifo (Reader end) in virCHMonitorNew itself. This way, we can clean exit incase open fails for some reason. changes from v3->v4: * Don't abort; instead kill the VM and exit * use g_clear_pointer along with g_free * Fix possible memory leak changes from v2->v3: * Remove patch 'utils: Implement virFileIsNamedPipe' as it is no more needed. * Remove the eventmonitorpath only if it exists * Added domain name as a prefix to logs from ch_events.c. This will make debugging easier. * Simplified event parsing logic by reserving a byte for null char. changes from v1->v2: * Rebase on latest master * Use /* */ for comments * Remove fifo file if already exists * Address other comments from Praveen Paladugu cloud-hypervisor raises various events, including VM lifecylce operations such as boot, shutdown, pause, resume, etc. Libvirt will now read these events and take the necessary actions, such as correctly updating the domain state. A FIFO file is passed to `--event-monitor` option of cloud-hypervisor. Libvirt creates a new thread that acts as the reader of the fifo file and continuously monitors for new events. Currently, shutdown events are handled by updating the domain state appropriately. Purna Pavan Chandra Aekkaladevi (5): ch: pass --event-monitor option to cloud-hypervisor ch: start a new thread for handling ch events ch: events: Read and parse cloud-hypervisor events ch: events: facilitate lifecycle events handling NEWS: Mention event handling support in ch driver NEWS.rst | 7 + po/POTFILES | 1 + src/ch/ch_events.c | 312 ++++++++++++++++++++++++++++++++++++++++++++ src/ch/ch_events.h | 54 ++++++++ src/ch/ch_monitor.c | 76 ++++++++++- src/ch/ch_monitor.h | 12 ++ src/ch/meson.build | 2 + 7 files changed, 458 insertions(+), 6 deletions(-) create mode 100644 src/ch/ch_events.c create mode 100644 src/ch/ch_events.h -- 2.34.1

3 8

[PATCH] qemu: Allow virDomainBlockJobSetSpeed during migration
by Jiri Denemark 24 Jan '25

24 Jan '25

When a migration with non-shared storage is started with VIR_MIGRATE_PARAM_BANDWIDTH set, it will be applied to both memory migration and each block job started for storage migration. Once the migration is running virDomainMigrateSetMaxSpeed may be used to change the bandwidth used by memory migration, but there was no way of changing storage migration speed. Let's allow virDomainBlockJobSetSpeed during migration to enable the missing functionality. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/conf/virdomainjob.h | 11 +++++++---- src/qemu/qemu_driver.c | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/conf/virdomainjob.h b/src/conf/virdomainjob.h index 8b2dccd298..d8685cf236 100644 --- a/src/conf/virdomainjob.h +++ b/src/conf/virdomainjob.h @@ -37,10 +37,13 @@ typedef enum { VIR_JOB_MODIFY, /* May change state */ VIR_JOB_ABORT, /* Abort current async job */ VIR_JOB_MIGRATION_OP, /* Operation influencing outgoing migration */ - VIR_JOB_MODIFY_MIGRATION_SAFE, /* Internal only job for event handlers which - need to be processed even during migration. - The code may only change state in a way - that does not affect migration. */ + VIR_JOB_MODIFY_MIGRATION_SAFE, /* Modify job that is safe to be run during + migration. The code may only change state + in a way that does not affect migration. + Used in event handlers which need to be + processed even during migration or for + setting block job speed when migrating + with non-shared storage. */ /* The following two items must always be the last items before JOB_LAST */ VIR_JOB_ASYNC, /* Asynchronous job */ diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d2eddbd9ae..a1fc61bae2 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13982,7 +13982,7 @@ qemuDomainBlockJobSetSpeed(virDomainPtr dom, if (virDomainBlockJobSetSpeedEnsureACL(dom->conn, vm->def) < 0) goto cleanup; - if (virDomainObjBeginJob(vm, VIR_JOB_MODIFY) < 0) + if (virDomainObjBeginJob(vm, VIR_JOB_MODIFY_MIGRATION_SAFE) < 0) goto cleanup; if (virDomainObjCheckActive(vm) < 0) -- 2.48.1

2 1

[PATCH] ch: implement domainInterfaceAddresses
by Praveen K Paladugu 24 Jan '25

24 Jan '25

From: Anirudh Rayabharam <anrayabh(a)linux.microsoft.com> Implement domainInterfaceAddresses for the Cloud Hypervisor driver. Support VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE and VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP sources. Implementation is similar to other drivers. Signed-off-by: Anirudh Rayabharam <anrayabh(a)linux.microsoft.com> Signed-off-by: Praveen K Paladugu <praveenkpaladugu(a)gmail.com> --- src/ch/ch_driver.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/src/ch/ch_driver.c b/src/ch/ch_driver.c index 6a8da5f356..d284524337 100644 --- a/src/ch/ch_driver.c +++ b/src/ch/ch_driver.c @@ -2298,6 +2298,47 @@ chConnectDomainEventDeregisterAny(virConnectPtr conn, return 0; } +static int +chDomainInterfaceAddresses(virDomain *dom, + virDomainInterfacePtr **ifaces, + unsigned int source, + unsigned int flags) +{ + virDomainObj *vm = NULL; + int ret = -1; + + virCheckFlags(0, -1); + + if (!(vm = virCHDomainObjFromDomain(dom))) + goto cleanup; + + if (virDomainInterfaceAddressesEnsureACL(dom->conn, vm->def, source) < 0) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + switch (source) { + case VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE: + ret = virDomainNetDHCPInterfaces(vm->def, ifaces); + break; + + case VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_ARP: + ret = virDomainNetARPInterfaces(vm->def, ifaces); + break; + + default: + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, + _("Unsupported IP address data source %1$d"), + source); + break; + } + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + /* Function Tables */ static virHypervisorDriver chHypervisorDriver = { @@ -2316,6 +2357,7 @@ static virHypervisorDriver chHypervisorDriver = { .domainCreateXML = chDomainCreateXML, /* 7.5.0 */ .domainCreate = chDomainCreate, /* 7.5.0 */ .domainCreateWithFlags = chDomainCreateWithFlags, /* 7.5.0 */ + .domainInterfaceAddresses = chDomainInterfaceAddresses, /* 10.10.1 */ .domainShutdown = chDomainShutdown, /* 7.5.0 */ .domainShutdownFlags = chDomainShutdownFlags, /* 7.5.0 */ .domainReboot = chDomainReboot, /* 7.5.0 */ -- 2.47.0

2 3

[PATCH v2 0/3] qemu: Add support for avail-switchover-bandwidth migration parameter
by Jiri Denemark 24 Jan '25

24 Jan '25

See documentation in 1/3 for details. Jiri Denemark (3): Add a migration parameter for available bandwidth in switchover virsh migrate: Add --available-switchover-bandwidth option qemu: Add support for avail-switchover-bandwidth migration parameter docs/manpages/virsh.rst | 12 ++++++++++++ include/libvirt/libvirt-domain.h | 18 ++++++++++++++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 9 +++++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 13 +++++++++++++ 6 files changed, 54 insertions(+) -- 2.48.1

2 4

[PATCH 0/3] Unify handling of directories used for loadable modules
by Andrea Bolognani 24 Jan '25

24 Jan '25

This solves the same problem as 7a8c2319acf2 but in a different, more generic fashion. Andrea Bolognani (3): meson: Unify handling of directories used for loadable modules rpm: Add missing Requires rpm: Unify handling of directories used for loadable modules libvirt.spec.in | 7 ++++--- meson.build | 5 +++++ src/locking/meson.build | 6 ++---- src/meson.build | 13 +++++++++++-- src/storage/meson.build | 2 -- src/storage_file/meson.build | 2 -- 6 files changed, 22 insertions(+), 13 deletions(-) -- 2.48.1

2 4

[PATCH v3 0/4] conf,qemu: add AIA support for RISC-V 'virt'
by Daniel Henrique Barboza 24 Jan '25

24 Jan '25

Hi, This version has changes in patch 2 proposed by Martin. An extra patch was added to add my contact info in .mailmap, also suggested by Martin. Changes from v2: - patch 2: - use VIR_DOMAIN_AIA_DEFAULT instead of VIR_DOMAIN_AIA_NONE in virDomainFeaturesDefParse() - use VIR_DOMAIN_AIA_DEFAULT instead of VIR_TRISTATE_SWITCH_ABSENT in both checks in qemuValidateDomainDefFeatures() - patch 4 (new): - add my address info in .mailmap - v2 link: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/EAPF… Daniel Henrique Barboza (4): qemu: add capability for RISC-V AIA feature conf,qemu: implement RISC-V 'aia' virt domain feature qemu: add RISC-V 'aia' command line .mailmap: add my contact info .mailmap | 2 + docs/formatdomain.rst | 8 ++++ src/conf/domain_conf.c | 40 +++++++++++++++++++ src/conf/domain_conf.h | 12 ++++++ src/conf/schemas/domaincommon.rng | 15 +++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 5 +++ src/qemu/qemu_validate.c | 15 +++++++ .../caps_8.0.0_riscv64.xml | 1 + .../caps_9.1.0_riscv64.xml | 1 + ...cv64-virt-features-aia.riscv64-latest.args | 31 ++++++++++++++ ...scv64-virt-features-aia.riscv64-latest.xml | 1 + .../riscv64-virt-features-aia.xml | 27 +++++++++++++ tests/qemuxmlconftest.c | 2 + 16 files changed, 165 insertions(+) create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.args create mode 120000 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.xml create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.xml -- 2.48.1

3 9

[PATCH 1/1] virsysinfo: fix RISC-V detection
by Heinrich Schuchardt 23 Jan '25

23 Jan '25

The correct compiler define to detect the RISC-V architecture is __riscv. Fixes: b902cfece0db ("virsysinfo: Try reading DMI table") Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt(a)canonical.com> --- src/util/virsysinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index d9b2b5e89e..b7413c3bf5 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -1254,7 +1254,7 @@ virSysinfoRead(void) (defined(__x86_64__) || \ defined(__i386__) || \ defined(__amd64__) || \ - defined(__riscv__) || \ + defined(__riscv) || \ defined(__mips__) || \ defined(__loongarch__)) return virSysinfoReadDMI(); -- 2.47.1

2 1

[PATCH 0/3] qemu: Add support for avail-switchover-bandwidth migration parameter
by Jiri Denemark 23 Jan '25

23 Jan '25

See documentation in 1/3 for details. Jiri Denemark (3): Add a migration parameter for available bandwidth in switchover virsh migrate: Add --available-switchover-bandwidth option qemu: Add support for avail-switchover-bandwidth migration parameter docs/manpages/virsh.rst | 12 ++++++++++++ include/libvirt/libvirt-domain.h | 18 ++++++++++++++++++ src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 9 +++++++++ src/qemu/qemu_migration_params.h | 1 + tools/virsh-domain.c | 13 +++++++++++++ 6 files changed, 54 insertions(+) -- 2.48.1

1 4

[PATCH v2 0/3] conf,qemu: add AIA support for RISC-V 'virt'
by Daniel Henrique Barboza 23 Jan '25

23 Jan '25

Hi, This new version has improvements suggested by Martin in v1. Most notably we're now doing a proper handling of 'aia=none' by adding a 'default' value that is internal only. Changes from v1: - patch 2: - changed libvirt version to 11.1.0 in 'aia' docs in formatdomain.rst - added a new internal only VIR_DOMAIN_AIA_DEFAULT value in domain_conf.h - virDomainDefFormatFeatures: skip if VIR_DOMAIN_AIA_DEFAULT instead of VIR_DOMAIN_AIA_NONE - patch 3: - skip cmd line appending if VIR_DOMAIN_AIA_DEFAULT instead of VIR_DOMAIN_AIA_NONE - changed riscv64-virt-features-aia.xml to use 'aia=none' to verify the intended behavior - v1 link: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/YUYY… Daniel Henrique Barboza (3): qemu: add capability for RISC-V AIA feature conf,qemu: implement RISC-V 'aia' virt domain feature qemu: add RISC-V 'aia' command line docs/formatdomain.rst | 8 ++++ src/conf/domain_conf.c | 40 +++++++++++++++++++ src/conf/domain_conf.h | 12 ++++++ src/conf/schemas/domaincommon.rng | 15 +++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 5 +++ src/qemu/qemu_validate.c | 15 +++++++ .../caps_8.0.0_riscv64.xml | 1 + .../caps_9.1.0_riscv64.xml | 1 + ...cv64-virt-features-aia.riscv64-latest.args | 31 ++++++++++++++ ...scv64-virt-features-aia.riscv64-latest.xml | 1 + .../riscv64-virt-features-aia.xml | 27 +++++++++++++ tests/qemuxmlconftest.c | 2 + 15 files changed, 163 insertions(+) create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.args create mode 120000 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.xml create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.xml -- 2.48.1

2 9

[PATCH 0/3] conf,qemu: add AIA support for RISC-V 'virt'
by Daniel Henrique Barboza 22 Jan '25

22 Jan '25

Hi, This series adds official support for RISC-V AIA (Advanced Interrupt Architecture). AIA and has been supported by the 'virt' RISC-V board, as a machine property, since QEMU 7.0. Daniel Henrique Barboza (3): qemu: add capability for RISC-V AIA feature conf,qemu: implement RISC-V 'aia' virt domain feature qemu: add RISC-V 'aia' command line docs/formatdomain.rst | 8 ++++ src/conf/domain_conf.c | 39 +++++++++++++++++++ src/conf/domain_conf.h | 11 ++++++ src/conf/schemas/domaincommon.rng | 15 +++++++ src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 5 +++ src/qemu/qemu_validate.c | 15 +++++++ .../caps_8.0.0_riscv64.xml | 1 + .../caps_9.1.0_riscv64.xml | 1 + ...cv64-virt-features-aia.riscv64-latest.args | 31 +++++++++++++++ ...scv64-virt-features-aia.riscv64-latest.xml | 1 + .../riscv64-virt-features-aia.xml | 27 +++++++++++++ tests/qemuxmlconftest.c | 2 + 15 files changed, 161 insertions(+) create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.args create mode 120000 tests/qemuxmlconfdata/riscv64-virt-features-aia.riscv64-latest.xml create mode 100644 tests/qemuxmlconfdata/riscv64-virt-features-aia.xml -- 2.45.2

2 8

[PATCH 00/12] Introduce SEV-SNP support
by Michal Privoznik 22 Jan '25

22 Jan '25

SEV-SNP support just landed in QEMU. Here is the first round of patches to incorporate support into libvirt. TODOs (aka problems of future me): - Teach tools/virt-qemu-sev-validate how to deal with SEV-SNP - Try to find a SEV-SNP machine a test these patches in real worl - Write a kbase article on attestation with SEV-SNP Michal Prívozník (12): qemu_monitor_json: Report error in error paths in SEV related code conf: Move some members of virDomainSEVDef into virDomainSEVCommonDef conf: Separate SEV formatting into a function Drop needless typecast to virDomainLaunchSecurity src: Convert some _virDomainSecDef::sectype checks to switch() qemu_monitor: Allow querying SEV-SNP state in 'query-sev' qemu: Report snp-policy in virDomainGetLaunchSecurityInfo() qemu_capabilities: Introduce QEMU_CAPS_SEV_SNP_GUEST conf: Introduce SEV-SNP support qemu: Build cmd line for SEV-SNP qemu: Allow setting launch security for SEV-SNP qemu_firmware: Pick the right firmware for SEV-SNP guests docs/formatdomain.rst | 108 ++++++++++++ include/libvirt/libvirt-domain.h | 10 ++ src/conf/domain_conf.c | 156 ++++++++++++++---- src/conf/domain_conf.h | 28 +++- src/conf/domain_validate.c | 44 +++++ src/conf/schemas/domaincommon.rng | 73 ++++++-- src/conf/virconftypes.h | 4 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_cgroup.c | 19 ++- src/qemu/qemu_command.c | 56 ++++++- src/qemu/qemu_driver.c | 60 +++++-- src/qemu/qemu_firmware.c | 20 ++- src/qemu/qemu_monitor.c | 7 +- src/qemu/qemu_monitor.h | 41 ++++- src/qemu/qemu_monitor_json.c | 67 ++++++-- src/qemu/qemu_monitor_json.h | 8 +- src/qemu/qemu_namespace.c | 3 +- src/qemu/qemu_process.c | 34 ++-- src/qemu/qemu_validate.c | 13 +- src/security/security_dac.c | 34 +++- .../caps_9.1.0_x86_64.xml | 1 + .../firmware/60-edk2-ovmf-x64-amdsev.json | 1 + tests/qemumonitorjsontest.c | 65 +++++++- ...launch-security-sev-snp.x86_64-latest.args | 35 ++++ .../launch-security-sev-snp.x86_64-latest.xml | 1 + .../launch-security-sev-snp.xml | 47 ++++++ tests/qemuxmlconftest.c | 2 + 28 files changed, 817 insertions(+), 127 deletions(-) create mode 100644 tests/qemuxmlconfdata/launch-security-sev-snp.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/launch-security-sev-snp.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-sev-snp.xml -- 2.44.2

5 31

[PATCH] qemu: Fix hang when migration is canceled at the last moment
by Jiri Denemark 21 Jan '25

21 Jan '25

When a migration is canceled very late once virtual CPUs are already stopped, QEMU will automatically resume them. If this happens after we exited a waiting loop in qemuMigrationSrcWaitForCompletion, but before a loop that tries to make sure CPUs are stopped by waiting for the appropriate event, we may end up waiting forever because the CPUs are running (they were resumed by migrate_cancel), but the STOP event is already gone. This is possible because we enter monitor for fetching migration statistics at which point other APIs can be processed and migration may change its state. We should recheck the state when we get back from the monitor code. https://issues.redhat.com/browse/RHEL-52493 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index bb4d11e196..53bbbee629 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2169,6 +2169,13 @@ qemuMigrationSrcWaitForCompletion(virDomainObj *vm, ignore_value(qemuMigrationAnyFetchStats(vm, asyncJob, jobData, NULL)); + /* We need to recheck migration status here as it might have changed while + * we were fetching statistics. For example, the migration might have been + * canceled. + */ + if ((rv = qemuMigrationAnyCompleted(vm, asyncJob, dconn, flags)) < 0) + return rv; + qemuDomainJobDataUpdateTime(jobData); qemuDomainJobDataUpdateDowntime(jobData); g_clear_pointer(&vm->job->completed, virDomainJobDataFree); -- 2.48.1

2 1

[PATCH] qemu monitor: Fix incorrect error message condition
by Fabian Leditzky 21 Jan '25

21 Jan '25

Fixes 'block_io_throttle inserted entry was not in expected format' error message spam. Without this patch, libvirtd writes an error message every time this function runs for a domain which has CD-ROM drives without a media attached. The 'inserted' key is not present when the drive is empty. The original code incorrectly assumes that the 'inserted' entry is not in the right format (wrong JSON value type, not an 'Object') when virJSONValueObjectGetObject(temp_dev, "inserted") returns NULL. However, NULL is also returned when the 'inserted' entry is simply not present. Signed-off-by: Fabian Leditzky <fabian(a)ldsoft.dev> --- src/qemu/qemu_monitor_json.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 9f417d27c6..baf934c2af 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -4581,8 +4581,16 @@ qemuMonitorJSONBlockIoThrottleInfo(virJSONValue *io_throttle, found = true; if (!(inserted = virJSONValueObjectGetObject(temp_dev, "inserted"))) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("block_io_throttle inserted entry was not in expected format")); + /* + * Ensure that we only print the error message when the 'inserted' key is actually the wrong type/format. + * Some device types (e.g. SATA CD-ROM) will have no 'inserted' key present if no media is present. + * Avoid spamming this error in such cases. + */ + if (virJSONValueObjectGet(temp_dev, "inserted")) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("block_io_throttle inserted entry was not in expected format")); + } + return -1; } GET_THROTTLE_STATS("bps", total_bytes_sec); -- 2.47.1

2 2

[PATCH] tools: ssh-proxy: Check for domain status before parsing its CID
by Michal Privoznik 21 Jan '25

21 Jan '25

Inactive domain XML can be wildly different to the live XML. For instance, it can have VSOCK CID of that from another (running) domain. Since domain status is not checked for, attempting to ssh into an inactive domain may in fact result in opening a connection to a different live domain that listens on said CID currently. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/737 Resolves: https://issues.redhat.com/browse/RHEL-75577 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/ssh-proxy/ssh-proxy.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/ssh-proxy/ssh-proxy.c b/tools/ssh-proxy/ssh-proxy.c index e60c58d57f..22daffeb63 100644 --- a/tools/ssh-proxy/ssh-proxy.c +++ b/tools/ssh-proxy/ssh-proxy.c @@ -194,7 +194,10 @@ lookupDomainAndFetchCID(const char *uri, if (virStrToLong_i(domname, NULL, 10, &id) >= 0) dom = virDomainLookupByID(conn, id); } - if (!dom) + + /* If no domain is found, return an error. Similarly, inactive domain may + * contain CID of another (running) domain, yielding misleading results. */ + if (!dom || virDomainIsActive(dom) <= 0) return -1; return extractCID(dom, cid); -- 2.45.2

2 1

[PATCH] nss: Skip empty files and avoid use of uninitialized value
by Jiang XueQian 21 Jan '25

21 Jan '25

JSON parser isn't called when reading empty files so `jerr` will be used uninitialized in the original code. Empty files appear when a network has no dhcp clients. This patch checks for such files and skip them. Signed-off-by: Jiang XueQian <jiangxueqian(a)gmail.com> --- tools/nss/libvirt_nss_leases.c | 5 +++++ tools/nss/libvirt_nss_macs.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/tools/nss/libvirt_nss_leases.c b/tools/nss/libvirt_nss_leases.c index aea81bb56e..7ffe4a8761 100644 --- a/tools/nss/libvirt_nss_leases.c +++ b/tools/nss/libvirt_nss_leases.c @@ -290,6 +290,11 @@ findLeases(const char *file, jerr = json_tokener_get_error(tok); } while (jerr == json_tokener_continue); + if (nreadTotal == 0) { + ret = 0; + goto cleanup; + } + if (jerr == json_tokener_continue) { ERROR("Cannot parse %s: incomplete json found", file); goto cleanup; diff --git a/tools/nss/libvirt_nss_macs.c b/tools/nss/libvirt_nss_macs.c index 23229a18f3..57c0f79fbb 100644 --- a/tools/nss/libvirt_nss_macs.c +++ b/tools/nss/libvirt_nss_macs.c @@ -152,6 +152,11 @@ findMACs(const char *file, jerr = json_tokener_get_error(tok); } while (jerr == json_tokener_continue); + if (nreadTotal == 0) { + ret = 0; + goto cleanup; + } + if (jerr == json_tokener_continue) { ERROR("Cannot parse %s: incomplete json found", file); goto cleanup; -- 2.48.1

2 2

[libvirt PATCH v2 0/2] meson: error out when ch driver is requested but unsupported
by Ján Tomko 20 Jan '25

20 Jan '25

v1 forgot to define the 'use_ch' variable in some corner case v2 also disables the build for mingw Ján Tomko (2): meson: error out when ch driver is requested but unsupported libvirt.spec: do not build ch driver on mingw libvirt.spec.in | 1 + meson.build | 11 +++++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) -- 2.47.0

2 3

[PATCH 0/2] Fix storage_file_backend_fs demodularization
by Peter Krempa 20 Jan '25

20 Jan '25

2 bugs were missed; brown paper bag was installed Peter Krempa (2): libvirt.spec: Move ownership of 'storage-file' backends directory to gluster storage_file_backend_fs: Compile out 'chown' backend on mingw libvirt.spec.in | 2 +- src/storage_file/storage_file_backend_fs.c | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) -- 2.48.1

2 3

[PATCH v2 0/2] tests: Add qemu-9.2 dev cycle caps on s390x
by Michal Privoznik 20 Jan '25

20 Jan '25

v2 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WABE… diff to v1: - instead of switching test case from 2.7 machine type to something newer, just drop the test case. Michal Prívozník (2): qemuxmlconftest: Drop s390-default-cpu-...ccw-virtio-2.7 test cases tests: qemucapabilities: Add test data for the qemu-9.2 dev cycle on s390x tests/domaincapsdata/qemu_9.3.0.s390x.xml | 436 + .../caps_9.3.0_s390x.replies | 38101 ++++++++++++++++ .../qemucapabilitiesdata/caps_9.3.0_s390x.xml | 4268 ++ ...-deprecated-features-off.s390x-latest.args | 2 +- ...default-video-type-s390x.s390x-latest.args | 2 +- ...vfio-zpci-ccw-memballoon.s390x-latest.args | 2 +- .../launch-security-s390-pv.s390x-latest.args | 2 +- ...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 32 - ...lt-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml | 25 - .../s390-default-cpu-kvm-ccw-virtio-2.7.xml | 16 - ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 2 +- ...t-cpu-tcg-ccw-virtio-2.7.s390x-latest.args | 32 - ...lt-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml | 27 - .../s390-default-cpu-tcg-ccw-virtio-2.7.xml | 16 - .../s390-defaultconsole.s390x-latest.args | 2 +- .../s390-panic.s390x-latest.args | 2 +- tests/qemuxmlconftest.c | 2 - 17 files changed, 42812 insertions(+), 157 deletions(-) create mode 100644 tests/domaincapsdata/qemu_9.3.0.s390x.xml create mode 100644 tests/qemucapabilitiesdata/caps_9.3.0_s390x.replies create mode 100644 tests/qemucapabilitiesdata/caps_9.3.0_s390x.xml delete mode 100644 tests/qemuxmlconfdata/s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.args delete mode 100644 tests/qemuxmlconfdata/s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml delete mode 100644 tests/qemuxmlconfdata/s390-default-cpu-kvm-ccw-virtio-2.7.xml delete mode 100644 tests/qemuxmlconfdata/s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.args delete mode 100644 tests/qemuxmlconfdata/s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml delete mode 100644 tests/qemuxmlconfdata/s390-default-cpu-tcg-ccw-virtio-2.7.xml -- 2.45.2

4 6

[PATCH] util: avoid overflow in hextable buffer
by Daniel P. Berrangé 20 Jan '25

20 Jan '25

The assigned string is 17 chars long once the trailing nul is taken into account. This triggers a warning with GCC 15 src/util/virsystemd.c: In function ‘virSystemdEscapeName’: src/util/virsystemd.c:59:38: error: initializer-string for array of ‘char’ is too long [-Werror=unterminated-string-initialization] 59 | static const char hextable[16] = "0123456789abcdef"; | ^~~~~~~~~~~~~~~~~~ Switch to a dynamically sized array as used in all the other places we have a hextable array. See also: https://gcc.gnu.org/PR115185 Reported-by: Yaakov Selkowitz <yselkowi(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virsystemd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 5b772e29dd..d46e5f74fc 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -56,7 +56,7 @@ struct _virSystemdActivationEntry { static void virSystemdEscapeName(virBuffer *buf, const char *name) { - static const char hextable[16] = "0123456789abcdef"; + static const char hextable[] = "0123456789abcdef"; #define ESCAPE(c) \ do { \ -- 2.47.1

2 1

[libvirt PATCH] meson: error out when ch driver is requested but unsupported
by Ján Tomko 20 Jan '25

20 Jan '25

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- meson.build | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 16ec3ba7e2..326d9dd0f9 100644 --- a/meson.build +++ b/meson.build @@ -1582,8 +1582,12 @@ elif get_option('driver_lxc').enabled() error('linux and remote_driver are required for LXC') endif -if not get_option('driver_ch').disabled() and host_machine.system() == 'linux' and (host_machine.cpu_family() == 'x86_64' or host_machine.cpu_family() == 'aarch64') - use_ch = true +if not get_option('driver_ch').disabled() + if host_machine.system() == 'linux' and (host_machine.cpu_family() == 'x86_64' or host_machine.cpu_family() == 'aarch64') + use_ch = true + elif get_option('driver_ch').enabled() + error('linux on x86_64 or aarch64 is required to build Cloud-Hypervisor driver') + endif if not conf.has('WITH_LIBVIRTD') use_ch = false -- 2.47.0

2 1

[PATCH] spec: Only build ch driver on x86_64 and aarch64
by Cole Robinson 20 Jan '25

20 Jan '25

This matches the cpu_family() check in `meson.build` Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- note: something probably needs to be fixed on meson.build side too, since an explicit `driver_ch=enabled` doesn't generate a build error. libvirt.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 2bc8dfd323..5a1755d74f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -29,6 +29,7 @@ %define arches_zfs %{arches_x86} %{power64} %{arm} %define arches_numactl %{arches_x86} %{power64} aarch64 s390x %define arches_numad %{arches_x86} %{power64} aarch64 +%define arches_ch x86_64 aarch64 # The hypervisor drivers that run in libvirtd %define with_qemu 0%{!?_without_qemu:1} @@ -124,6 +125,9 @@ %ifnarch %{arches_ceph} %define with_storage_rbd 0 %endif +%ifnarch %{arches_ch} + %define with_ch 0 +%endif # RHEL doesn't ship many hypervisor drivers %if 0%{?rhel} -- 2.48.1

2 1

[PATCH 0/4] Implement virsh hypervisor-cpu-models
by Boris Fiuczynski 17 Jan '25

17 Jan '25

Allows for the query of hypervisor-known CPU models via the simple command: virsh hypervisor-cpu-models. For the QEMU driver, the models are queried via the capabilities file. Each model is printed to the terminal on its own line similar to the cpu-models command, and there is no order to the listing. There is a related libvirt-python merge request at https://gitlab.com/libvirt/libvirt-python/-/merge_requests/159 David Judkovics (4): libvirt: Introduce virConnectGetHypervisorCPUModelNames public API remote: Implement virConnectGetHypervisorCPUModelNames qemu_driver: Implement qemuConnectGetHypervisorCPUModelNames virsh: Introduce new hypervisor-cpu-models command docs/manpages/virsh.rst | 20 ++++++++ include/libvirt/libvirt-host.h | 7 +++ src/driver-hypervisor.h | 10 ++++ src/libvirt-host.c | 65 +++++++++++++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_driver.c | 59 +++++++++++++++++++++++ src/remote/remote_daemon_dispatch.c | 62 ++++++++++++++++++++++++ src/remote/remote_driver.c | 52 ++++++++++++++++++++ src/remote/remote_protocol.x | 26 +++++++++- src/remote_protocol-structs | 16 +++++++ tools/virsh-host.c | 74 +++++++++++++++++++++++++++++ 11 files changed, 395 insertions(+), 1 deletion(-) -- 2.47.0

5 10

[PATCH 0/3] Remove deprecated machines pc-i440fx-2.4 up to pc-i440fx-2.12
by Thomas Huth 17 Jan '25

17 Jan '25

While our new auto-disablement of old machine types will only kick in with the next (v10.1) release, the pc-i440fx-2.* machine types have been explicitly marked as deprecated via our old deprecation policy mechanism before (two releases ago), so it should be fine to remove them now already. Note that we can not do much additional clean ups on top yet since the corresponding q35 machines (which share the same compatibility knobs) are still around and only will be removed for the 10.1 release instead. So the bigger clean-up can only be done for 10.1, but removing the i440fx machine types now will still have at least a small benefit of accelerating our CI a little bit (since we don't have to run tests for these old machine types anymore). Thomas Huth (3): tests/qtest/test-x86-cpuid-compat: Remove tests related to pc-i440fx-2.3 hw/i386/pc_piix: Remove pc-i440fx-2.4 up to pc-i440fx-2.12 tests/qtest/test-x86-cpuid-compat: Replaced the removed pc-i440fx-2.* machines docs/about/deprecated.rst | 7 --- docs/about/removed-features.rst | 4 +- docs/interop/firmware.json | 2 +- hw/i386/pc_piix.c | 95 ----------------------------- tests/qtest/test-x86-cpuid-compat.c | 52 ++++++---------- qemu-options.hx | 10 +-- 6 files changed, 25 insertions(+), 145 deletions(-) -- 2.47.1

5 11

[PATCH 0/1] Support cloning saved VMs
by Felipe Franciosi 17 Jan '25

17 Jan '25

Hello! I have a use case which I'm struggling to support with libvirt: saving a VM to a file, cloning it (which renames the VM), and restoring it. My search revealed a number of tutorials for using virt-clone [1], but that doesn't seem to cover VMs which are _saved_ (only running or paused). [1] https://github.com/virt-manager/virt-manager/blob/main/virtinst/virtclone.py In a nutshell, I want to power on a VM and do some setup, then save its full state to disk (e.g., with virsh save). Finally I want to modify the XML to: - rename the VM - change which bridge its NICs are on (while maintaining mac addresses) - change the disk image to a copy (done while the VM is saved) But the restore operation fails because of a target domain name check implemented in virDomainDefCheckABIStabilityFlags(). I've debated how to best address this and I'm looking for your views. I suspect this call is there for a reason (which may still be relevant), although the name is clearly not part of the ABI; it's the host identifier for that domain and not guest-visible. My first stab at this is therefore just to drop this check (patch attached). I'm open to suggestions, for example by plumbing through a flag which makes the check optional. Please let me know how you prefer that I take this forward. Thanks, F. Felipe Franciosi (1): conf: remove domain name change check on CheckABI src/conf/domain_conf.c | 11 ----------- 1 file changed, 11 deletions(-) -- 2.39.5

2 15

[PATCH] cpu_x86: Probe host CPU for all MSR features
by Jiri Denemark 17 Jan '25

17 Jan '25

The list of CPU features we probe from various MSR grew significantly over time and the CPU map currently mentions 11 distinct MSR indexes. But the code for directly probing host CPU features was still reading only the original 0x10a index. Thus the CPU model in host capabilities was missing a lot of features. Instead of specifying a static list of indexes to read (which we would forget to update in the future), let's just read all indexes found in the CPU map. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu/cpu_x86.c | 62 ++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 53 insertions(+), 9 deletions(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 6d72d446c9..1ce97d9dcf 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -2836,15 +2836,61 @@ cpuidSet(uint32_t base, virCPUData *data) } +static size_t +virCPUx86ListMSRs(virCPUx86Map *map, + unsigned long **msrs) +{ + size_t n = 0; + size_t i, j, k; + + /* These three nested loops look horrible, but data->len is always 1 here + * and thanks to grouping features in the CPU map by their MSR index the + * third loop will run more than one iteration only once for each distinct + * index. + */ + for (i = 0; i < map->nfeatures; i++) { + virCPUx86Data *data = &map->features[i]->data; + + for (j = 0; j < data->len; j++) { + virCPUx86DataItem *item = &data->items[j]; + bool found = false; + unsigned long msr; + + if (item->type != VIR_CPU_X86_DATA_MSR) + continue; + + msr = item->data.msr.index; + + for (k = n; k > 0; k--) { + if ((*msrs)[k - 1] == msr) { + found = true; + break; + } + } + + if (!found) + VIR_APPEND_ELEMENT(*msrs, n, msr); + } + } + + return n; +} + + static int virCPUx86GetHost(virCPUDef *cpu, virDomainCapsCPUModels *models) { g_autoptr(virCPUData) cpuData = NULL; unsigned int addrsz; + virCPUx86Map *map; + g_autofree unsigned long *msrs = NULL; + size_t nmsrs; + uint64_t msr; + size_t i; int ret; - if (virCPUx86DriverInitialize() < 0) + if (!(map = virCPUx86GetMap())) return -1; if (!(cpuData = virCPUDataNew(archs[0]))) @@ -2854,18 +2900,16 @@ virCPUx86GetHost(virCPUDef *cpu, cpuidSet(CPUX86_EXTENDED, cpuData) < 0) return -1; - /* Read the IA32_ARCH_CAPABILITIES MSR (0x10a) if supported. - * This is best effort since there might be no way to read the MSR - * when we are not running as root. */ - if (virCPUx86DataCheckFeature(cpuData, "arch-capabilities") == 1) { - uint64_t msr; - unsigned long index = 0x10a; + nmsrs = virCPUx86ListMSRs(map, &msrs); - if (virHostCPUGetMSR(index, &msr) == 0) { + /* This is best effort since there might be no way to read the MSR + * when we are not running as root. */ + for (i = 0; i < nmsrs; i++) { + if (virHostCPUGetMSR(msrs[i], &msr) == 0) { virCPUx86DataItem item = { .type = VIR_CPU_X86_DATA_MSR, .data.msr = { - .index = index, + .index = msrs[i], .eax = msr & 0xffffffff, .edx = msr >> 32, }, -- 2.47.1

2 2

[PATCH v3 0/4] fix AppArmor policy restore for runtime rules
by Georgia Garcia 16 Jan '25

16 Jan '25

Some rules are generated dynamically during boot and added to the AppArmor policy. An example of that is macvtap devices that call the AppArmorSetFDLabel hook to add a rule for the tap device path. Since this information is dynamic, it is not available in the xml config, therefore whenever a "Restore" hook is called, the entire profile is regenerated by virt-aa-helper based only the information from the VM definition, so the dynamic/runtime information is lost. This patchset fixes that by storing these rules in a different file called libvirt-uuid.runtime_files, which is included by libvirt-uuid.files that already exists. It also includes other fixes like memory leaks, adoption of the GLib API in the apparmor files and a fix on the AppArmor policy that incorrectly applies apparmor policy syntax. Georgia Garcia (4): security_apparmor: fix memleaks in AppArmorSetFDLabel security: replace uses of label and VIR_FREE by g_autofree apparmor: fix UUID specification virt-aa-helper: store dynamically generated rules .../usr.lib.libvirt.virt-aa-helper.in | 5 +- src/security/apparmor/usr.sbin.libvirtd.in | 7 +- src/security/apparmor/usr.sbin.virtqemud.in | 6 +- src/security/security_apparmor.c | 84 +++++----- src/security/virt-aa-helper.c | 145 +++++++++--------- 5 files changed, 125 insertions(+), 122 deletions(-) -- 2.43.0

4 15

[PATCH] qemu: Report error from both sides of migration
by Jiri Denemark 16 Jan '25

16 Jan '25

When migration fails in Perform phase, we call Finish on the destination host with cancelled=1 and get the error from there and report it to the user. This works well if the error on the destination caused the migration to fail. But in other cases the main error may reported by the source and the destination would just be complaining about broken migration stream. In other words, we don't really know which error caused the migration to fail and we have no way of detecting that. So instead of choosing one error, this patch will combine the error messages from both sides of migration into a single message and report it to the user. The result would be, for example: operation failed: migration failed. Message from the source host: operation failed: job 'migration out' failed: Certificate does not match the hostname ble.bla. Message from the destination host: operation failed: job 'migration in' failed: load of migration failed: Invalid argument And yes, this is ugly, but I wasn't able to come up with a better way of fixing this issue. https://issues.redhat.com/browse/RHEL-58933 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/libvirt-domain.c | 26 +++++++++++++------------- src/qemu/qemu_migration.c | 26 +++++++++++++------------- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index e8e5379672..efccafc4d2 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3430,26 +3430,26 @@ virDomainMigrateVersion3Full(virDomainPtr domain, if (ddomain) { VIR_ERROR(_("finish step ignored that migration was cancelled")); } else { - /* If Finish reported a useful error, use it instead of the - * original "migration unexpectedly failed" error. + virErrorPtr err = virGetLastError(); + /* When both Confirm and Finish reported an error in QEMU driver, + * we don't really know which error is the root cause. Let's report + * both errors to the user. * * This is ugly but we can't do better with the APIs we have. We * only replace the error if Finish was called with cancelled == 1 * and reported a real error (old libvirt would report an error - * from RPC instead of MIGRATE_FINISH_OK), which only happens when - * the domain died on destination. To further reduce a possibility - * of false positives we also check that Perform returned - * VIR_ERR_OPERATION_FAILED. + * from RPC instead of MIGRATE_FINISH_OK). */ if (orig_err && orig_err->domain == VIR_FROM_QEMU && - orig_err->code == VIR_ERR_OPERATION_FAILED) { - virErrorPtr err = virGetLastError(); - if (err && - err->domain == VIR_FROM_QEMU && - err->code != VIR_ERR_MIGRATE_FINISH_OK) { - g_clear_pointer(&orig_err, virFreeError); - } + orig_err->code == VIR_ERR_OPERATION_FAILED && + err && + err->domain == VIR_FROM_QEMU && + err->code != VIR_ERR_MIGRATE_FINISH_OK) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("migration failed. Message from the source host: %1$s. Message from the destination host: %2$s"), + orig_err->message, err->message); + g_clear_pointer(&orig_err, virFreeError); } } } diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 1582a738a3..8c0e522828 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -5904,26 +5904,26 @@ qemuMigrationSrcPerformPeer2Peer3(virQEMUDriver *driver, if (ddomain) { VIR_ERROR(_("finish step ignored that migration was cancelled")); } else { - /* If Finish reported a useful error, use it instead of the - * original "migration unexpectedly failed" error. + virErrorPtr err = virGetLastError(); + /* When both Confirm and Finish reported an error in QEMU driver, + * we don't really know which error is the root cause. Let's report + * both errors to the user. * * This is ugly but we can't do better with the APIs we have. We * only replace the error if Finish was called with cancelled == 1 * and reported a real error (old libvirt would report an error - * from RPC instead of MIGRATE_FINISH_OK), which only happens when - * the domain died on destination. To further reduce a possibility - * of false positives we also check that Perform returned - * VIR_ERR_OPERATION_FAILED. + * from RPC instead of MIGRATE_FINISH_OK). */ if (orig_err && orig_err->domain == VIR_FROM_QEMU && - orig_err->code == VIR_ERR_OPERATION_FAILED) { - virErrorPtr err = virGetLastError(); - if (err && - err->domain == VIR_FROM_QEMU && - err->code != VIR_ERR_MIGRATE_FINISH_OK) { - g_clear_pointer(&orig_err, virFreeError); - } + orig_err->code == VIR_ERR_OPERATION_FAILED && + err && + err->domain == VIR_FROM_QEMU && + err->code != VIR_ERR_MIGRATE_FINISH_OK) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("migration failed. Message from the source host: %1$s. Message from the destination host: %2$s"), + orig_err->message, err->message); + g_clear_pointer(&orig_err, virFreeError); } } } -- 2.47.1

2 1

[PATCH 0/2] qemu_migration: Do not automatically resume domain after I/O error
by Jiri Denemark 16 Jan '25

16 Jan '25

Jiri Denemark (2): qemu_migration: Refactor qemuMigrationSrcRestoreDomainState qemu_migration: Do not automatically resume domain after I/O error src/qemu/qemu_migration.c | 69 +++++++++++++++++++-------------------- 1 file changed, 33 insertions(+), 36 deletions(-) -- 2.47.1

2 3

[PATCH 0/2] tests: Add qemu-9.2 dev cycle caps on s390x
by Michal Privoznik 16 Jan '25

16 Jan '25

NB, the capabilities were captured in a VM running on an actual s390x machine so there might be some CPU features (incorrectly) missing. But it's the best I can do. Michal Prívozník (2): qemuxmlconftest: Switch s390-default-cpu-...-virtio-2.7 to virtio-2.9 tests: qemucapabilities: Add test data for the qemu-9.2 dev cycle on s390x tests/domaincapsdata/qemu_9.3.0.s390x.xml | 436 + .../caps_9.3.0_s390x.replies | 38101 ++++++++++++++++ .../qemucapabilitiesdata/caps_9.3.0_s390x.xml | 4268 ++ ...-deprecated-features-off.s390x-latest.args | 2 +- ...default-video-type-s390x.s390x-latest.args | 2 +- ...vfio-zpci-ccw-memballoon.s390x-latest.args | 2 +- .../launch-security-s390-pv.s390x-latest.args | 2 +- ...-cpu-kvm-ccw-virtio-2.9.s390x-latest.args} | 4 +- ...t-cpu-kvm-ccw-virtio-2.9.s390x-latest.xml} | 4 +- ...> s390-default-cpu-kvm-ccw-virtio-2.9.xml} | 2 +- ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 2 +- ...-cpu-tcg-ccw-virtio-2.9.s390x-latest.args} | 2 +- ...t-cpu-tcg-ccw-virtio-2.9.s390x-latest.xml} | 2 +- ...> s390-default-cpu-tcg-ccw-virtio-2.9.xml} | 2 +- .../s390-defaultconsole.s390x-latest.args | 2 +- .../s390-panic.s390x-latest.args | 2 +- tests/qemuxmlconftest.c | 4 +- 17 files changed, 42822 insertions(+), 17 deletions(-) create mode 100644 tests/domaincapsdata/qemu_9.3.0.s390x.xml create mode 100644 tests/qemucapabilitiesdata/caps_9.3.0_s390x.replies create mode 100644 tests/qemucapabilitiesdata/caps_9.3.0_s390x.xml rename tests/qemuxmlconfdata/{s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.args => s390-default-cpu-kvm-ccw-virtio-2.9.s390x-latest.args} (70%) rename tests/qemuxmlconfdata/{s390-default-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml => s390-default-cpu-kvm-ccw-virtio-2.9.s390x-latest.xml} (86%) rename tests/qemuxmlconfdata/{s390-default-cpu-kvm-ccw-virtio-2.7.xml => s390-default-cpu-kvm-ccw-virtio-2.9.xml} (85%) rename tests/qemuxmlconfdata/{s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.args => s390-default-cpu-tcg-ccw-virtio-2.9.s390x-latest.args} (94%) rename tests/qemuxmlconfdata/{s390-default-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml => s390-default-cpu-tcg-ccw-virtio-2.9.s390x-latest.xml} (92%) rename tests/qemuxmlconfdata/{s390-default-cpu-tcg-ccw-virtio-2.7.xml => s390-default-cpu-tcg-ccw-virtio-2.9.xml} (85%) -- 2.45.2

3 4

Release of libvirt-11.0.0
by Jiri Denemark 15 Jan '25

15 Jan '25

The 11.0.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * New features * network/qemu/lxc: support vlans on standard Linux host bridges The network, qemu, and lxc drivers now support (using the ``<vlan>`` subelement) vlan tagging and trunking on network interfaces connected to a standard Linux host bridge. * qemu: Add support for direct and extended tlbflush features Domains can now utilise more tlbflush hyperv features. * Improvements * ch: Enable user aliases User can now specify custom aliases for devices in domain XML * qemu: Grab a QUERY job when formatting domain XML Under some specific conditions it might have happened that domain XML did not contain runtime information or returned an XML that's in process of changing (e.g. by a thread that's hotplugging a device). Formatting domain XML now serializes properly with other threads. * virtiofs: Allow read only mode The ``<filesystem/>`` with `virtiofsd` backend can now use ``<readonly/>`` tag to export underlying filesystem in read only mode. * qemu: allow migration of vGPU from mdev device <-> SRIOV VF device Some GPU vendors are switching from using vGPUs creating using mdev and identified with a uuid, to vGPUs created as SRIOV VFs and identified by their PCI address, and want to support live migration from a host using one type of vGPU to the other type. This is now possible. * Bug fixes * qemu: tpm: do not update profile name for transient domains Fix a possible crash when starting a transient domain which was introduced in the previous release. * qemu: Fix snapshot to not delete disk image with internal snapshot When a VM has internal snapshot that is parent to external snapshot and user reverts to the internal snapshot and deletes the external snapshot libvirt would delete the disk image containing the internal snapshot. This would result in data loss. * qemu: Do not format invalid XML with hyperv features in passthrough mode When hyperv features were specified together with ``mode="passthrough"`` libvirt parsed and formatted such features in the domain XML even though they were not used at all, resulting in XML that is not valid based on our schema. This is now fixed by not parsing any specified features when the passthrough mode is used. * qemu: Fix a crash when starting a domain with ovs bridge and QOS * cpu: Add missing -v1 variants for CPU models Some CPU models (mostly old ones) were missed when versioned CPU model names were introduced in the previous release. * qemu: Fix false error when recovering failed post-copy migration In some cases libvirt would report a failure to recover post-copy migration even though the recovery started just fine and migration would eventually successfully finish. Enjoy. Jirka

1 0

[PATCH 00/20] qemu: support mapped-ram+directio+mulitfd
by Jim Fehlig 15 Jan '25

15 Jan '25

This series is essentially V1 of a prior RFC [1] to support QEMU's mapped-ram stream format [2] and migration capability. Along with supporting mapped-ram, it implements a design approach we discussed for supporting parallel save/restore [3]. In summary, the approach is 1. Add mapped-ram migration capability 2. Steal an element from save header 'unused' for a 'features' variable and bump save version to 3. 3. Add /etc/libvirt/qemu.conf knob for the save format version, defaulting to latest v3 4. Use v3 (aka mapped-ram) by default 5. Use mapped-ram with BYPASS_CACHE for v3, old approach for v2 6. include: Define constants for parallel save/restore 7. qemu: Add support for parallel save. Implies mapped-ram, reject if v2 8. qemu: Add support for parallel restore. Implies mapped-ram. Reject if v2 9. tools: add parallel parameter to virsh save command 10. tools: add parallel parameter to virsh restore command With this series, saving and restoring using mapped-ram is enabled by default if the underlying QEMU advertises the mapped-ram migration capability. It can be disabled by changing the 'save_image_version' setting in qemu.conf. To use mapped-ram with QEMU: - The 'mapped-ram' migration capability must be set to true - The 'multifd' migration capability must be set to true and the 'multifd-channels' migration parameter must set to a value >= 1 - QEMU must be provided an fdset containing the migration fd(s) - The 'migrate' qmp command is invoked with a URI referencing the fdset and an offset where to start reading or writing the data stream, e.g. {"execute":"migrate", "arguments":{"detach":true,"resume":false, "uri":"file:/dev/fdset/0,offset=0x11921"}} The mapped-ram stream, in conjunction with direct IO and multifd, can significantly improve the time required to save VM memory state. The following tables compare mapped-ram with the existing, sequential save stream. In all cases, the save and restore operations are to/from a block device comprised of two NVMe disks in RAID0 configuration with xfs (~8600MiB/s). The values in the 'save time' and 'restore time' columns were scraped from the 'real' time reported by time(1). The 'Size' and 'Blocks' columns were provided by the corresponding outputs of stat(1). VM: 32G RAM, 1 vcpu, idle (shortly after boot) | save | restore | | time | time | Size | Blocks -----------------------+---------+---------+--------------+-------- legacy | 6.193s | 4.399s | 985744812 | 1925288 -----------------------+---------+---------+--------------+-------- mapped-ram | 5.109s | 1.176s | 34368554354 | 1774472 -----------------------+---------+---------+--------------+-------- legacy + direct IO | 5.725s | 4.512s | 985765251 | 1925328 -----------------------+---------+---------+--------------+-------- mapped-ram + direct IO | 4.627s | 1.490s | 34368554354 | 1774304 -----------------------+---------+---------+--------------+-------- mapped-ram + direct IO | | | | + multifd-channels=8 | 4.421s | 0.845s | 34368554318 | 1774312 ------------------------------------------------------------------- VM: 32G RAM, 30G dirty, 1 vcpu in tight loop dirtying memory | save | restore | | time | time | Size | Blocks -----------------------+---------+---------+--------------+--------- legacy | 25.800s | 14.332s | 33154309983 | 64754512 -----------------------+---------+---------+--------------+--------- mapped-ram | 18.742s | 15.027s | 34368559228 | 64617160 -----------------------+---------+---------+--------------+--------- legacy + direct IO | 13.115s | 18.050s | 33154310496 | 64754520 -----------------------+---------+---------+--------------+--------- mapped-ram + direct IO | 13.623s | 15.959s | 34368557392 | 64662040 -----------------------+-------- +---------+--------------+--------- mapped-ram + direct IO | | | | + multifd-channels=8 | 6.994s | 6.470s | 34368554980 | 64665776 -------------------------------------------------------------------- As can be seen from the tables, one caveat of mapped-ram is the logical file size of a saved image is basically equivalent to the VM memory size. Note however that mapped-ram typically uses fewer blocks on disk. Support for mapped-ram+direct-io only recently landed in upstream QEMU and will first appear in the 9.1 release, which may complicate merging support in libvirt. Specifically, I'm not sure how to detect if the combination is supported by QEMU. Suggestions welcomed. Similar to the RFC, V1 ignores compression. libvirt currently supports compression by connecting the output of QEMU's save stream to the specified compression program via a pipe. This approach is incompatible with mapped-ram since the fd provided to QEMU must be seekable. In general, we can consider mapped-ram and compression incompatible and document they cannot be used together. [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/EF6… [2] https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration/map… [3] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/K4B… Claudio Fontana (2): include: Define constants for parallel save/restore tools: add parallel parameter to virsh restore command Jim Fehlig (17): lib: virDomainSaveParams: Ensure absolute save path qemu_fd: Add function to retrieve fdset ID qemu: Add function to check capability in migration params qemu: Add function to get bool value from migration params qemu: Add mapped-ram migration capability qemu: Add function to get migration params for save qemu: QEMU_SAVE_VERSION: Bump to version 3 qemu: conf: Add setting for save image version qemu: Add helper function for creating save image fd qemu: Add support for mapped-ram on save qemu: Decompose qemuSaveImageOpen qemu: Move creation of qemuProcessIncomingDef struct qemu: Apply migration parameters in qemuMigrationDstRun qemu: Add support for mapped-ram on restore qemu: Support O_DIRECT with mapped-ram on save qemu: Support O_DIRECT with mapped-ram on restore qemu: Add support for parallel save and restore Li Zhang (1): tools: add parallel parameter to virsh save command docs/manpages/virsh.rst | 9 +- include/libvirt/libvirt-domain.h | 13 ++ src/libvirt-domain.c | 52 +++++-- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf.in | 6 + src/qemu/qemu_conf.c | 16 +++ src/qemu/qemu_conf.h | 5 + src/qemu/qemu_driver.c | 104 +++++++++----- src/qemu/qemu_fd.c | 18 +++ src/qemu/qemu_fd.h | 3 + src/qemu/qemu_migration.c | 192 +++++++++++++++++-------- src/qemu/qemu_migration.h | 9 +- src/qemu/qemu_migration_params.c | 86 ++++++++++++ src/qemu/qemu_migration_params.h | 17 +++ src/qemu/qemu_monitor.c | 39 ++++++ src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_process.c | 120 +++++++++++----- src/qemu/qemu_process.h | 19 ++- src/qemu/qemu_saveimage.c | 216 ++++++++++++++++++++--------- src/qemu/qemu_saveimage.h | 35 +++-- src/qemu/qemu_snapshot.c | 26 ++-- src/qemu/test_libvirtd_qemu.aug.in | 1 + tools/virsh-domain.c | 79 +++++++++-- 23 files changed, 827 insertions(+), 244 deletions(-) -- 2.35.3

4 47

[PATCH] NEWS: Document some of my fixes in this release
by Jiri Denemark 14 Jan '25

14 Jan '25

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- NEWS.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 15042595ed..1d3e3c3cff 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -61,6 +61,19 @@ v11.0.0 (unreleased) schema. This is now fixed by not parsing any specified features when the passthrough mode is used. + * qemu: Fix a crash when starting a domain with ovs bridge and QOS + + * cpu: Add missing -v1 variants for CPU models + + Some CPU models (mostly old ones) were missed when versioned CPU model + names were introduced in the previous release. + + * qemu: Fix false error when recovering failed post-copy migration + + In some cases libvirt would report a failure to recover post-copy migration + even though the recovery started just fine and migration would eventually + successfully finish. + v10.10.0 (2024-12-02) ===================== -- 2.47.1

2 1

[PATCH] NEWS: Add few things I changed this release
by Martin Kletzander 14 Jan '25

14 Jan '25

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 9f0804ec67ff..02679602cc6a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,10 @@ v11.0.0 (unreleased) * **New features** + * qemu: Add support for direct and extended tlbflush features + + Domains can now utilise more tlbflush hyperv features. + * **Improvements** * ch: Enable user aliases @@ -42,6 +46,14 @@ v11.0.0 (unreleased) Fix a possible crash when starting a transient domain which was introduced in the previous release. + * qemu: Do not format invalid XML with hyperv features in passthrough mode + + When hyperv features were specified together with ``mode="passthrough"`` + libvirt parsed and formatted such features in the domain XML even though + they were not used at all, resulting in XML that is not valid based on our + schema. This is now fixed by not parsing any specified features when the + passthrough mode is used. + v10.10.0 (2024-12-02) ===================== -- 2.48.0

2 1

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in
by Michal Privoznik 14 Jan '25

14 Jan '25

There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index eedb6008bd..9f0804ec67 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -19,6 +19,22 @@ v11.0.0 (unreleased) * **Improvements** + * ch: Enable user aliases + + User can now specify custom aliases for devices in domain XML + + * qemu: Grab a QUERY job when formatting domain XML + + Under some specific conditions it might have happened that domain XML did + not contain runtime information or returned an XML that's in process of + changing (e.g. by a thread that's hotplugging a device). Formatting domain + XML now serializes properly with other threads. + + * virtiofs: Allow read only mode + + The ``<filesystem/>`` with `virtiofsd` backend can now use ``<readonly/>`` + tag to export underlying filesystem in read only mode. + * **Bug fixes** * qemu: tpm: do not update profile name for transient domains -- 2.45.2

2 1

[libvirt PATCH] NEWS: document bug fix for snapshots
by Pavel Hrdina 14 Jan '25

14 Jan '25

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 08d1d24d48..98f489dfb0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -21,6 +21,13 @@ v11.0.0 (unreleased) * **Bug fixes** + * qemu: Fix snapshot to not delete disk image with internal snapshot + + When a VM has internal snapshot that is parent to external snapshot and user + reverts to the internal snapshot and deletes the external snapshot Libvirt + would delete the disk image containing the internal snapshot. This would result + in data loss. + v10.10.0 (2024-12-02) ===================== -- 2.47.1

2 1

[libvirt PATCH] NEWS: document fix for starting transient domains
by Ján Tomko 14 Jan '25

14 Jan '25

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 08d1d24d48..eedb6008bd 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -21,6 +21,11 @@ v11.0.0 (unreleased) * **Bug fixes** + * qemu: tpm: do not update profile name for transient domains + + Fix a possible crash when starting a transient domain which was + introduced in the previous release. + v10.10.0 (2024-12-02) ===================== -- 2.47.0

2 1

Entering freeze for libvirt-11.0.0
by Jiri Denemark 13 Jan '25

13 Jan '25

I have just tagged v11.0.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 1

[PATCH 0/2] storage_file: Refuse qcow2 images with empty string as 'data_file'
by Peter Krempa 13 Jan '25

13 Jan '25

See patch 1/2 for justification. Patch 2 is a test case. Peter Krempa (2): storage_file: Refuse qcow2 images with empty string as 'data_file' virstoragetest: Add case for qcow2 image with empty string as 'data_file' src/storage_file/storage_source.c | 10 ++++++++++ tests/virstoragetest.c | 5 +++++ .../images/datafile-emptystr.qcow2 | Bin 0 -> 327680 bytes 3 files changed, 15 insertions(+) create mode 100644 tests/virstoragetestdata/images/datafile-emptystr.qcow2 -- 2.47.1

2 3

[PATCH] meson: Replace meson.source_root() with meson.project_source_root()
by Michal Privoznik 13 Jan '25

13 Jan '25

The source_root() method is deprecated in 0.56.0 and we're recommended to use project_source_root() instead. This is similar to commit v8.9.0-rc1~70 but somehow, the old method sneaked in. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index c1a2e6eadb..f8eff99e2c 100644 --- a/meson.build +++ b/meson.build @@ -17,7 +17,7 @@ endif i18n = import('i18n') -po_dir = meson.source_root() / 'po' +po_dir = meson.project_source_root() / 'po' # figure out if we are building from git -- 2.45.2

2 1

[PATCH] access: fix po_check when polkit is disabled
by Daniel P. Berrangé 13 Jan '25

13 Jan '25

The generated org.libvirt.api.policy.in file was recently added to the POTFILES list as it contains translatable messages. It is only generated when WITH_POLKIT && WITH_LIBVIRTD is satisfied though, resulting in the 'po_check' syntax rule failing if either of those conditions are not met. It is harmless to unconditionally generate this file, as a separate rule takes care of of installing it, and the latter remains under the build conditions. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/access/meson.build | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/src/access/meson.build b/src/access/meson.build index 0cc9cf2b79..d1336c0093 100644 --- a/src/access/meson.build +++ b/src/access/meson.build @@ -63,19 +63,22 @@ foreach name : [ 'remote', 'qemu', 'lxc' ] ) endforeach +# Generated outside the WITH_POLKIT / WITH_LIBVIRTD condition +# because syntax-check/po_check requires this to exist +polgen = custom_target( + 'org.libvirt.api.policy.in', + input: access_perm_h, + output: 'org.libvirt.api.policy.in', + command: [ meson_python_prog, python3_prog, genpolkit_prog, '@INPUT@' ], + capture: true, + build_by_default: true, +) +access_generated += polgen + if conf.has('WITH_POLKIT') access_sources += access_polkit_sources if conf.has('WITH_LIBVIRTD') - polgen = custom_target( - 'org.libvirt.api.policy.in', - input: access_perm_h, - output: 'org.libvirt.api.policy.in', - command: [ meson_python_prog, python3_prog, genpolkit_prog, '@INPUT@' ], - capture: true, - build_by_default: true, - ) - access_generated += polgen i18n.merge_file( input: polgen, -- 2.47.1

2 1

[PATCH] qemu: support vlan change for linux host bridge during update-device
by Laine Stump 13 Jan '25

13 Jan '25

Since we previously only supported vlan tagging for interfaces connected to an OVS bridge [*], the code in qemuChangeNet() (used by the update-device API) assumed an interface with modified vlan config was on an OVS bridge, and would call the OVS-specific virNetDevOpenvswitchUpdateVlan(). Now that we support vlan tagging for interfaces connected to a standard Linux host bridge, we must check the type of connection and only call the OVS function when connected to an OVS bridge *both before and after the update*. Otherwise we just set the flag to re-connect to the bridge, which has the side effect of redoing the vlan setup. ([*] or an SRIOV VF assigned using VFIO, but we don't support *any runtime changes to that type of netdev so it's irrelevant here.) Signed-off-by: Laine Stump <laine(a)redhat.com> --- I'm fine with this going in either before or after the 11.0.0 release (would prefer before since it is a bugfix), but if it's going into the release I'd rather it be included with RC2 rather than only in the final release. For that reason, if someone ACKs the patch and agrees that it's safe to go in, please push it for me (since Jiri will almost certainly tag RC2 before I'm conscious on Monday morning) src/qemu/qemu_hotplug.c | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index de0777d330..5a7e6c3b12 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -4144,8 +4144,13 @@ qemuDomainChangeNet(virQEMUDriver *driver, * they don't apply to a particular type. */ - if (!virNetDevVlanEqual(virDomainNetGetActualVlan(olddev), - virDomainNetGetActualVlan(newdev))) { + /* since attaching to a new bridge will re-do the vlan setup, + * we don't need to separately do that in the case that we're + * already switching to a different bridge + */ + if (!(needBridgeChange || + virNetDevVlanEqual(virDomainNetGetActualVlan(olddev), + virDomainNetGetActualVlan(newdev)))) { needVlanUpdate = true; } @@ -4215,6 +4220,23 @@ qemuDomainChangeNet(virQEMUDriver *driver, needReplaceDevDef = true; } + if (needVlanUpdate) { + if (virDomainNetDefIsOvsport(olddev) && virDomainNetDefIsOvsport(newdev)) { + /* optimization if we're attached to an OVS bridge. This + * will redo vlan setup without needing to re-attach the + * tap device to the bridge + */ + if (virNetDevOpenvswitchUpdateVlan(newdev->ifname, &newdev->vlan) < 0) + goto cleanup; + } else { + /* vlan setup is done as a part of reconnecting the tap + * device to a new bridge (either OVS or Linux host bridge). + */ + needBridgeChange = true; + } + needReplaceDevDef = true; + } + if (needBridgeChange) { if (qemuDomainChangeNetBridge(vm, olddev, newdev) < 0) goto cleanup; @@ -4266,12 +4288,6 @@ qemuDomainChangeNet(virQEMUDriver *driver, goto cleanup; } - if (needVlanUpdate) { - if (virNetDevOpenvswitchUpdateVlan(newdev->ifname, &newdev->vlan) < 0) - goto cleanup; - needReplaceDevDef = true; - } - if (needReplaceDevDef) { /* the changes above warrant replacing olddev with newdev in * the domain's nets list. -- 2.47.1

2 1

[PATCH 0/2] news: add a couple items before release
by Laine Stump 13 Jan '25

13 Jan '25

This adds a "new feature" for the VLAN tagging support on Linux host bridges added by Leigh Brown, and an "improvement" (migration between mdev<->SRIOV vGPUs) by me. Feel free to push this for me so it can be included in RC2. *** BLURB HERE *** Laine Stump (2): news: note addition of vlan tagging support for Linux host bridges news: document support for mdev <-> SRIOV VF vGPU live migration NEWS.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) -- 2.47.1

2 3

[PATCH] qemu_migration: Do not consider post-copy active in postcopy-recover
by Jiri Denemark 13 Jan '25

13 Jan '25

The postcopy-recover migration state in QEMU means a connection for the migration stream was established. Depending on the schedulers on both hosts a relative timing of the corresponding MIGRATION event on the source host and the destination host may differ. Specifically it's possible that the source sees postcopy-recover while the destination is still in postcopy-paused. Currently the Perform phase on the source host ends when we get postcopy-recover event and the Finish phase on the destination host is called. If this is fast enough we can still see postcopy-paused state when the Finish phase starts waiting for migration to complete. This is interpreted as a failure and reported back to the caller. Even though the recovery may actually start just a few moments later. To avoid this race we now don't consider post-copy migration active in postcopy-recover state and keep waiting for postcopy-active event (in the success path). Thus the Finish phase is entered only after the migration switches to postcopy-active. In this state QEMU guarantees the destination already switched at least to postcopy-recover and we won't be confused be seeing an old postcopy-failed state. https://issues.redhat.com/browse/RHEL-73085 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 50e350b0c4..1582a738a3 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1872,11 +1872,11 @@ qemuMigrationUpdateJobType(virDomainJobData *jobData) switch ((qemuMonitorMigrationStatus) priv->stats.mig.status) { case QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY: - case QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY_RECOVER: jobData->status = VIR_DOMAIN_JOB_STATUS_POSTCOPY; break; case QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY_RECOVER_SETUP: + case QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY_RECOVER: jobData->status = VIR_DOMAIN_JOB_STATUS_POSTCOPY_RECOVER; break; -- 2.47.1

2 1

[PATCH] conf: Do not parse hyperv features with passthrough mode
by Martin Kletzander 13 Jan '25

13 Jan '25

The schema does not allow that anyway and we then format them all back which leads to libvirt producing an invalid XML. Resolves: https://issues.redhat.com/browse/RHEL-70656 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/conf/domain_conf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index e658b68c48b6..3f88a77a8fea 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16643,6 +16643,9 @@ virDomainFeaturesHyperVDefParse(virDomainDef *def, def->features[VIR_DOMAIN_FEATURE_HYPERV] = mode; + if (mode == VIR_DOMAIN_HYPERV_MODE_PASSTHROUGH) + return 0; + node = xmlFirstElementChild(node); while (node != NULL) { int feature; -- 2.47.1

2 1

Virtual manager error
by Domenico Panella 13 Jan '25

13 Jan '25

Hi everyone, when i try to run a VM through virt-manager application (Slackware 15), I get the following error: *Errore nell'avvio del dominio: internal error: unknown architecture 'loongarch64'** ** **Traceback (most recent call last):** ** File "/usr/share/virt-manager/virtManager/asyncjob.py", line 72, in cb_wrapper** ** callback(asyncjob, *args, **kwargs)** ** File "/usr/share/virt-manager/virtManager/asyncjob.py", line 108, in tmpcb** ** callback(*args, **kwargs)** ** File "/usr/share/virt-manager/virtManager/object/libvirtobject.py", line 57, in newfn** ** ret = fn(self, *args, **kwargs)** ** File "/usr/share/virt-manager/virtManager/object/domain.py", line 1402, in startup** ** self._backend.create()** ** File "/usr/lib64/python3.9/site-packages/libvirt.py", line 1373, in create** ** raise libvirtError('virDomainCreate() failed')** **libvirt.libvirtError: internal error: unknown architecture 'loongarch64'* How can i fix it? Cordially Domenico

2 1

[PATCH v4 0/4] iproute2 bridge vlan support
by Leigh Brown 11 Jan '25

11 Jan '25

I have incorporated Laine's feedback and added Reviewed-by tags. I also noticed that I hadn't updated the patch series description, so I updated it to reflect the change to using netlink, for posterity. Description ----------- The iproute2 bridge command supports the capability for VLAN filtering that allows each interface connected to a standard linux bridge to be configured to use one or more VLANs. For simple setups, this capability is enough to allow virtual machines or containers to be put onto separate VLANs without creating multiple bridges and VLANs on the host. The first patch adds a new function virNetDevBridgeVlanFilterSet that allows a VLAN filter to be added or removed from an interface associated with a bridge. The second patch adds virNetDevBridgeSetupVlans that will, given a virNetDevVlan structure, call virNetDevBridgeVlanFilterSet to apply the required VLAN filtering for the given interface. The third patch adjusts the domain and network validation to permit standard linux bridges to allow VLAN configuration and updates calls to virNetDevBridgeAddPort to pass the VLAN configuration. The fourth patch updates documentation to match the new capability. Changes since v3 ---------------- - Update patch series description. - Fix coding style. - Add G_GNUC_UNUSED annotation to virNetDevBridgeAddPort for MacOS. Changes since v2 ---------------- - Convert to use netlink rather than executing bridge vlan commands. - Add unsupported on this platform error message on FreeBSD. Changes since v1 ---------------- - Fix bug in virNetDevSetupVlans where bridge port has no native vlan. - Update bridge network validation to permit vlan configuration. - Update documentation to match the functionality. - Tweak some of the commit descriptions for clarity. Usage example ------------- Configure the host with systemd-networkd as follows: /etc/systemd/network/br0.netdev (br0.network not shown) [NetDev] Name=br0 Kind=bridge MACAddress=xx:xx:xx:xx:xx:xx [Bridge] VLANFiltering=on /etc/systemd/network/eno1.network [Match] Name=eno1 [Network] Bridge=br0 [Link] MTUBytes=9000 [BridgeVLAN] VLAN=40 [BridgeVLAN] VLAN=60 Then add <vlan> tags into the lxc or qemu config: lxc interface definition: <interface type='bridge'> <mac address='xx:xx:xx:xx:xx:xx'/> <source bridge='br0'/> <vlan> <tag id='40'/> </vlan> </interface> qemu interface definition: <interface type='network'> <mac address='xx:xx:xx:xx:xx:xx'/> <source network='br0'/> <vlan> <tag id='60'/> </vlan> <model type='virtio'/> <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> </interface> Then, after starting them, you will see the following $ sudo bridge vlan port vlan-id eno1 1 PVID Egress Untagged 40 60 br0 1 PVID Egress Untagged vnet0 60 PVID Egress Untagged vnet1 40 PVID Egress Untagged Regards, Leigh Brown (4): util: add netlink bridge vlan filtering util: Add vlan support to virNetDevBridgeAddPort Enable vlan support for standard linux bridges docs: standard linux bridges now support vlans docs/formatdomain.rst | 37 +++++++++--------- docs/formatnetwork.rst | 45 +++++++++++----------- src/conf/domain_validate.c | 3 +- src/lxc/lxc_process.c | 2 +- src/network/bridge_driver.c | 13 ++++--- src/util/virnetdevbridge.c | 75 +++++++++++++++++++++++++++++++++++-- src/util/virnetdevbridge.h | 4 +- src/util/virnetdevtap.c | 2 +- src/util/virnetlink.c | 66 ++++++++++++++++++++++++++++++++ src/util/virnetlink.h | 7 ++++ 10 files changed, 201 insertions(+), 53 deletions(-) -- 2.39.5

3 8

[libvirt PATCH] qemu: snapshot: delete disk image only if parent snapshot is external
by Pavel Hrdina 10 Jan '25

10 Jan '25

When we are deleting external snapshot that is not active we only need to delete overlay disk image of the parent snapshot. This works correctly even if parent snapshot is external and active as it will have another overlay created when user reverted to that snapshot. In case the parent snapshot is internal there are no overlay disk images created as everything is stored internally within the disk image. In this case we would delete the actual disk image storing internal snapshots and most likely the original disk image as well resulting in data loss once the VM is shutoff. Fixes: https://gitlab.com/libvirt/libvirt/-/issues/734 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_snapshot.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c index 18b2e478f6..80cd54bf33 100644 --- a/src/qemu/qemu_snapshot.c +++ b/src/qemu/qemu_snapshot.c @@ -3144,6 +3144,8 @@ qemuSnapshotDeleteExternalPrepareData(virDomainObj *vm, return -1; } + data->parentSnap = qemuSnapshotFindParentSnapForDisk(snap, data->snapDisk); + if (data->merge) { virStorageSource *snapDiskSrc = NULL; @@ -3185,8 +3187,6 @@ qemuSnapshotDeleteExternalPrepareData(virDomainObj *vm, qemuSnapshotGetDisksWithBackingStore(vm, snap, data); } - data->parentSnap = qemuSnapshotFindParentSnapForDisk(snap, data->snapDisk); - if (data->parentSnap && !virDomainSnapshotIsExternal(data->parentSnap)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("deleting external snapshot that has internal snapshot as parent not supported")); @@ -3642,10 +3642,12 @@ qemuSnapshotDiscardExternal(virDomainObj *vm, if (!data->job) goto error; } else { - if (virStorageSourceInit(data->parentDomDisk->src) < 0 || - virStorageSourceUnlink(data->parentDomDisk->src) < 0) { - VIR_WARN("Failed to remove snapshot image '%s'", - data->snapDisk->name); + if (data->parentSnap && virDomainSnapshotIsExternal(data->parentSnap)) { + if (virStorageSourceInit(data->parentDomDisk->src) < 0 || + virStorageSourceUnlink(data->parentDomDisk->src) < 0) { + VIR_WARN("Failed to remove snapshot image '%s'", + data->snapDisk->name); + } } } } -- 2.47.1

2 2

[PATCH 0/1] RFC: Add Arm CCA support for getting capability information and running Realm VM
by Akio Kakuno 10 Jan '25

10 Jan '25

Hi, all. - This patch adds Arm CCA support to qemu driver for aarch64 system. CCA is an abbreviation for Arm Confidential Compute Architecture feature, it enhances the virtualization capabilities of the platform by separating the management of resources from access to those resources. - We are not yet at the stage where we can merge this patch as host linux/qemu suppor is no yet merged, but I would like to receive reviews and comments on the overall direction. [summary] - At this stage, all you can do is getting the CCA capability with the virsh domcapabilities command and start the CCA VM with the virsh create command. - capability info uses qemu QMP to query qemu options. The option that exists now is for selecting a hash algorithm. [Capability example] - Execution results of 'virsh domcapability" on qemu <domaincapabilities> ... <features> ... </sgx> <cca supported='yes'> <enum name='measurement-algo'> <value>sha256</value> <value>sha512</value> </enum> </cca> <hyperv supported='yes'> ... </features> </domaincapabilities> [XML example] <domain> ... <launchsecurity type='cca'> <measurement-algo>sha256</measurement-algo> </launchsecurity> ... </domain> [limitations/tests] - To obtain capability info, it is necessary to support the qemu QMP command, which qemu does not yet support. Therefore, I put a hack in the code at hand and only confirmed the communication. Also, I think we should check whether CPUFW supports CCA or not in qemu_firmware.c, but it is not yet implemented. - Verified that the CCA VM can be started from virsh create command. [software version] - I followed the steps in Linaro's blog below. https://linaro.atlassian.net/wiki/spaces/QEMU/pages/29051027459/Building+an… - The Qemu used was based on Linaro's qemu(9.1.91). https://git.codelinaro.org/linaro/dcap/qemu/-/tree/cca/v3?ref_type=heads Signed-off-by: Akio Kakuno <fj3333bs(a)fujitsu.com> Best Regards. Akio Kakuno (1): RFC: Add Arm CCA support for getting capability information and running Realm VM docs/formatdomain.rst | 28 ++++++ docs/formatdomaincaps.rst | 26 ++++- src/conf/domain_capabilities.c | 41 ++++++++ src/conf/domain_capabilities.h | 12 +++ src/conf/domain_conf.c | 13 +++ src/conf/domain_conf.h | 7 ++ src/conf/schemas/domaincaps.rng | 14 +++ src/conf/schemas/domaincommon.rng | 14 +++ src/conf/virconftypes.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 156 ++++++++++++++++++++++++++++++ src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_cgroup.c | 2 + src/qemu/qemu_command.c | 32 ++++++ src/qemu/qemu_driver.c | 2 + src/qemu/qemu_monitor.c | 10 ++ src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 104 ++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 4 + src/qemu/qemu_namespace.c | 2 + src/qemu/qemu_process.c | 4 + src/qemu/qemu_validate.c | 7 ++ 22 files changed, 487 insertions(+), 1 deletion(-) -- 2.34.1

3 3