- Devel - libvirt List Archives

[libvirt] [PATCH for-4.1] hw/arm/nseries: Deprecate the n800 and n810 machines
by Thomas Huth 12 Apr '19

12 Apr '19

These machines depend on the deprecated bluetooth subsystem. In case we finally decide to remove the bluetooth subsystem, we likely need to remove the n800 and n810 machines, too, so mark them now as deprecated. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- hw/arm/nseries.c | 3 +++ qemu-deprecated.texi | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index 906b7ca22d..66e50b850c 100644 --- a/hw/arm/nseries.c +++ b/hw/arm/nseries.c @@ -1309,6 +1309,9 @@ static void n8x0_init(MachineState *machine, struct n800_s *s = (struct n800_s *) g_malloc0(sizeof(*s)); int sdram_size = binfo->ram_size; + warn_report("The n800 and n810 machines are deprecated. Please use a " + "different Arm machine instead."); + s->mpu = omap2420_mpu_init(sysmem, sdram_size, machine->cpu_type); /* Setup peripherals diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 2219386769..4de7452fac 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -145,6 +145,12 @@ This machine type uses an unmaintained firmware, broken in lots of ways, and unable to start post-2004 operating systems. 40p machine type should be used instead. +@subsection n800 and n810 (Arm) (since 4.1) + +These machines depend on the deprecated bluetooth subsystem. When the +bluetooth subsystem will be removed, the n800 and n810 machines will be +deleted, too. If possible, use a different Arm board instead. + @section Device options @subsection Block device options -- 2.21.0

3 3

[libvirt] [PATCH] network: only reload firewall after firewalld is finished restarting
by Laine Stump 12 Apr '19

12 Apr '19

The network driver used to reload the firewall rules whenever a dbus NameOwnerChanged message for org.fedoraproject.FirewallD1 was received. Presumably at some point in the past this was successful at reloading our rules after a firewalld restart. Recently though I noticed that once firewalld was restarted, libvirt's logs would get this message: The name org.fedoraproject.FirewallD1 was not provided by any .service files After this point, no networks could be started until libvirtd itself was restarted. The problem is that the NameOwnerChanged message is sent twice during a firewalld restart - once when the old firewalld is stopped, and again when the new firewalld is started. If we try to reload at the point the old firewalld is stopped, none of the firewalld dbus calls will succeed. The solution is to check the new_owner field of the message - we should reload our firewall rules only if new_owner is non-empty (it is set to "" when firewalld is stopped, and some sort of epoch number when it is again started). Signed-off-by: Laine Stump <laine(a)laine.org> --- src/network/bridge_driver.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 4d4ab0f375..167c142ae2 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -549,8 +549,23 @@ firewalld_dbus_filter_bridge(DBusConnection *connection ATTRIBUTE_UNUSED, dbus_message_is_signal(message, "org.fedoraproject.FirewallD1", "Reloaded")) { - VIR_DEBUG("Reload in bridge_driver because of firewalld."); - networkReloadFirewallRules(driver, false); + VIR_AUTOFREE(char *) name = NULL; + VIR_AUTOFREE(char *) old_owner = NULL; + VIR_AUTOFREE(char *) new_owner = NULL; + + if (virDBusMessageDecode(message, "sss", &name, &old_owner, &new_owner) < 0) { + VIR_WARN("Failed to decode DBus NameOwnerChanged message"); + return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; + } + + /* + * if new_owner is empty, firewalld is shutting down. If it is + * non-empty, then it is starting + */ + if (new_owner && *new_owner) { + VIR_DEBUG("Reload in bridge_driver because of firewalld."); + networkReloadFirewallRules(driver, false); + } } return DBUS_HANDLER_RESULT_NOT_YET_HANDLED; -- 2.20.1

2 2

[libvirt] [PATCH] network: clear cached error if we successfully create firewall chains
by Daniel P. Berrangé 12 Apr '19

12 Apr '19

Since: commit 9f4e35dc73ec9e940aa61bc7c140c2b800218ef3 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Mon Mar 18 17:31:21 2019 +0000 network: improve error report when firewall chain creation fails We cache an error when failing to create the top level firewall chains. This commit failed to account for fact that we may invoke networkPreReloadFirewallRules() many times while libvirtd is running. For example when firewalld is restarted. When this happens the original failure may no longer occurr and we'll successfully create our top level chains. We failed to clear the cached error resulting in us failing to start virtual networks. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/network/bridge_driver_linux.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/network/bridge_driver_linux.c b/src/network/bridge_driver_linux.c index 50fc197134..f2827543ca 100644 --- a/src/network/bridge_driver_linux.c +++ b/src/network/bridge_driver_linux.c @@ -55,6 +55,9 @@ void networkPreReloadFirewallRules(bool startup) if (rc < 0) { errInitV4 = virSaveLastError(); virResetLastError(); + } else { + virFreeError(errInitV4); + errInitV4 = NULL; } if (rc) created = true; @@ -63,6 +66,9 @@ void networkPreReloadFirewallRules(bool startup) if (rc < 0) { errInitV6 = virSaveLastError(); virResetLastError(); + } else { + virFreeError(errInitV6); + errInitV6 = NULL; } if (rc) created = true; -- 2.20.1

2 1

[libvirt] [PATCH] qemu: Label uniqDir when probing capabilities
by Martin Kletzander 12 Apr '19

12 Apr '19

This does not cause a problem in usual scenarios thanks to us allowing CAP_DAC_OVERRIDE for the qemu process, however in some scenarios this might be an issue because the directory is created with mkdtemp(3) which explicitly creates that with 0700 permissions and qemu running as non-root cannot access that. The scenarios include: - Builds without CAPNG - Running libvirtd in a container [1] - and possibly others. [1] https://github.com/kubevirt/kubevirt/pull/2181#issuecomment-481840304 Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/qemu/qemu_process.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 47d8ca2ff163..2e2c4812fef7 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8447,6 +8447,19 @@ qemuProcessQMPNew(const char *binary, } +static int +qemuProcessQEMULabelUniqPath(qemuProcessQMPPtr proc) { + /* We cannot use the security driver here, but we should not need to. */ + if (chown(proc->uniqDir, proc->runUid, -1) < 0) { + virReportSystemError(errno, + "Cannot chown uniq path: %s", proc->uniqDir); + return -1; + } + + return 0; +} + + static int qemuProcessQMPInit(qemuProcessQMPPtr proc) { @@ -8466,6 +8479,9 @@ qemuProcessQMPInit(qemuProcessQMPPtr proc) goto cleanup; } + if (qemuProcessQEMULabelUniqPath(proc) < 0) + goto cleanup; + if (virAsprintf(&proc->monpath, "%s/%s", proc->uniqDir, "qmp.monitor") < 0) goto cleanup; -- 2.21.0

2 5

[libvirt] [jenkins-ci PATCH 0/2] guests: Remove readline symlink kludge
by Andrea Bolognani 12 Apr '19

12 Apr '19

The last remaining one! \o/ Andrea Bolognani (2): guests: Install ncurses for libvirt guests: Remove readline symlink kludge guests/playbooks/update/tasks/kludges.yml | 14 -------------- guests/vars/mappings.yml | 8 ++++++++ guests/vars/projects/libvirt.yml | 1 + 3 files changed, 9 insertions(+), 14 deletions(-) -- 2.20.1

2 5

[libvirt] [PATCH v2] maint: Add filetype annotations to Makefile.inc.am
by Andrea Bolognani 12 Apr '19

12 Apr '19

Vim has trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help it out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Changes from [v1]: * drop emacs annotation; * switch from filetype=make to filetype=automake. [v1] https://www.redhat.com/archives/libvir-list/2019-April/msg00867.html src/access/Makefile.inc.am | 2 ++ src/admin/Makefile.inc.am | 2 ++ src/bhyve/Makefile.inc.am | 2 ++ src/conf/Makefile.inc.am | 2 ++ src/cpu/Makefile.inc.am | 2 ++ src/cpu_map/Makefile.inc.am | 2 ++ src/esx/Makefile.inc.am | 2 ++ src/hyperv/Makefile.inc.am | 2 ++ src/interface/Makefile.inc.am | 2 ++ src/libxl/Makefile.inc.am | 2 ++ src/locking/Makefile.inc.am | 2 ++ src/logging/Makefile.inc.am | 2 ++ src/lxc/Makefile.inc.am | 2 ++ src/network/Makefile.inc.am | 2 ++ src/node_device/Makefile.inc.am | 2 ++ src/nwfilter/Makefile.inc.am | 2 ++ src/openvz/Makefile.inc.am | 2 ++ src/phyp/Makefile.inc.am | 2 ++ src/qemu/Makefile.inc.am | 2 ++ src/remote/Makefile.inc.am | 2 ++ src/rpc/Makefile.inc.am | 2 ++ src/secret/Makefile.inc.am | 2 ++ src/security/Makefile.inc.am | 2 ++ src/storage/Makefile.inc.am | 2 ++ src/test/Makefile.inc.am | 2 ++ src/util/Makefile.inc.am | 2 ++ src/vbox/Makefile.inc.am | 2 ++ src/vmware/Makefile.inc.am | 2 ++ src/vmx/Makefile.inc.am | 2 ++ src/vz/Makefile.inc.am | 2 ++ src/xenapi/Makefile.inc.am | 2 ++ src/xenconfig/Makefile.inc.am | 2 ++ 32 files changed, 64 insertions(+) diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am index 6d57ca1a1b..4dc742f4e5 100644 --- a/src/access/Makefile.inc.am +++ b/src/access/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ACCESS_DRIVER_GENERATED = \ access/viraccessapicheck.h \ access/viraccessapicheck.c \ diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am index 19afb0e179..4cc588a47c 100644 --- a/src/admin/Makefile.inc.am +++ b/src/admin/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ADMIN_PROTOCOL = $(srcdir)/admin/admin_protocol.x ADMIN_PROTOCOL_GENERATED = \ diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index fba1b9ef30..36af5d7504 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + BHYVE_DRIVER_SOURCES = \ bhyve/bhyve_capabilities.c \ bhyve/bhyve_capabilities.h \ diff --git a/src/conf/Makefile.inc.am b/src/conf/Makefile.inc.am index 6eb64db9de..3e9fdd1aea 100644 --- a/src/conf/Makefile.inc.am +++ b/src/conf/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NETDEV_CONF_SOURCES = \ conf/netdev_bandwidth_conf.h \ conf/netdev_bandwidth_conf.c \ diff --git a/src/cpu/Makefile.inc.am b/src/cpu/Makefile.inc.am index 5020d40583..0abeee87b6 100644 --- a/src/cpu/Makefile.inc.am +++ b/src/cpu/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + CPU_SOURCES = \ cpu/cpu.h \ cpu/cpu.c \ diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 9d7cef15c5..5634dd9348 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + cpumapdir = $(pkgdatadir)/cpu_map cpumap_DATA = \ cpu_map/index.xml \ diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am index 152dd7b979..2d55c6573c 100644 --- a/src/esx/Makefile.inc.am +++ b/src/esx/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + ESX_DRIVER_SOURCES = \ esx/esx_private.h \ esx/esx_driver.c \ diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am index a768272b72..51be8bcacc 100644 --- a/src/hyperv/Makefile.inc.am +++ b/src/hyperv/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + HYPERV_DRIVER_SOURCES = \ hyperv/hyperv_private.h \ hyperv/hyperv_driver.c \ diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am index 08b35d040d..339a92786b 100644 --- a/src/interface/Makefile.inc.am +++ b/src/interface/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + INTERFACE_DRIVER_SOURCES = \ interface/interface_driver.h \ interface/interface_driver.c \ diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am index 59c136bf4e..7f60b449d8 100644 --- a/src/libxl/Makefile.inc.am +++ b/src/libxl/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LIBXL_DRIVER_SOURCES = \ libxl/libxl_conf.c \ libxl/libxl_conf.h \ diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index 5d5e923769..da26fab91f 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + DRIVER_SOURCES += \ locking/lock_manager.c \ locking/lock_manager.h \ diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index 3f4a87d91a..f5eba2a4f7 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LOG_PROTOCOL_GENERATED = \ logging/log_protocol.h \ logging/log_protocol.c \ diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index 8dd2e9ea9e..f27827c1e9 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + LXC_MONITOR_PROTOCOL_GENERATED = \ lxc/lxc_monitor_protocol.h \ lxc/lxc_monitor_protocol.c \ diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index cbaaa7ea68..3fed59c13b 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NETWORK_DRIVER_SOURCES = \ network/bridge_driver.h \ network/bridge_driver.c \ diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am index 0c3ad51273..3e04651e8c 100644 --- a/src/node_device/Makefile.inc.am +++ b/src/node_device/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NODE_DEVICE_DRIVER_SOURCES = \ node_device/node_device_driver.c \ node_device/node_device_driver.h \ diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am index 27aa801095..810ca54bcc 100644 --- a/src/nwfilter/Makefile.inc.am +++ b/src/nwfilter/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_driver.h \ nwfilter/nwfilter_driver.c \ diff --git a/src/openvz/Makefile.inc.am b/src/openvz/Makefile.inc.am index baad737362..93bf3b9c96 100644 --- a/src/openvz/Makefile.inc.am +++ b/src/openvz/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + OPENVZ_DRIVER_SOURCES = \ openvz/openvz_conf.c \ openvz/openvz_conf.h \ diff --git a/src/phyp/Makefile.inc.am b/src/phyp/Makefile.inc.am index 496ff25266..315f1c36ee 100644 --- a/src/phyp/Makefile.inc.am +++ b/src/phyp/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + PHYP_DRIVER_SOURCES = \ phyp/phyp_driver.c \ phyp/phyp_driver.h \ diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 8d10e1085a..fd32a90d56 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + QEMU_DRIVER_SOURCES = \ qemu/qemu_agent.c \ qemu/qemu_agent.h \ diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 13a1f9f8f2..06714249b4 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + REMOTE_DRIVER_GENERATED = \ remote/remote_protocol.c \ remote/remote_protocol.h \ diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index 722ef64db1..68a4945198 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + EXTRA_DIST += \ rpc/gendispatch.pl \ rpc/genprotocol.pl \ diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am index 79c2b2d74a..7a1c8f8e1a 100644 --- a/src/secret/Makefile.inc.am +++ b/src/secret/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + SECRET_DRIVER_SOURCES = \ secret/secret_driver.h \ secret/secret_driver.c \ diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am index b24cdfd083..7fb6d8cc4f 100644 --- a/src/security/Makefile.inc.am +++ b/src/security/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + SECURITY_DRIVER_APPARMOR_HELPER_SOURCES = \ $(DATATYPES_SOURCES) \ security/virt-aa-helper.c \ diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index b4400b556f..ea4681f70e 100644 --- a/src/storage/Makefile.inc.am +++ b/src/storage/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + STORAGE_DRIVER_BACKEND_SOURCES = \ storage/storage_backend.h \ storage/storage_backend.c \ diff --git a/src/test/Makefile.inc.am b/src/test/Makefile.inc.am index d52c281545..c20541a368 100644 --- a/src/test/Makefile.inc.am +++ b/src/test/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + TEST_DRIVER_SOURCES = \ test/test_driver.c \ test/test_driver.h \ diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index 58874cca3c..f44d3b3b2a 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + # These files are not related to driver APIs. Simply generic # helper APIs for various purposes UTIL_SOURCES = \ diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am index 8c76f84e82..15f7b78416 100644 --- a/src/vbox/Makefile.inc.am +++ b/src/vbox/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VBOX_DRIVER_SOURCES = \ vbox/vbox_glue.c \ vbox/vbox_glue.h \ diff --git a/src/vmware/Makefile.inc.am b/src/vmware/Makefile.inc.am index 0fbf866030..2c8c2d9884 100644 --- a/src/vmware/Makefile.inc.am +++ b/src/vmware/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VMWARE_DRIVER_SOURCES = \ vmware/vmware_driver.c \ vmware/vmware_driver.h \ diff --git a/src/vmx/Makefile.inc.am b/src/vmx/Makefile.inc.am index b9bf6ef690..429bdfe51e 100644 --- a/src/vmx/Makefile.inc.am +++ b/src/vmx/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VMX_SOURCES = \ vmx/vmx.c \ vmx/vmx.h \ diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index cacdb38795..a3a146c627 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + VZ_DRIVER_SOURCES = \ vz/vz_driver.h \ vz/vz_driver.c \ diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am index 4640e9943f..b6e4ed0bdb 100644 --- a/src/xenapi/Makefile.inc.am +++ b/src/xenapi/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + XENAPI_DRIVER_SOURCES = \ xenapi/xenapi_driver.c \ xenapi/xenapi_driver.h \ diff --git a/src/xenconfig/Makefile.inc.am b/src/xenconfig/Makefile.inc.am index a87d69990f..cd751029d2 100644 --- a/src/xenconfig/Makefile.inc.am +++ b/src/xenconfig/Makefile.inc.am @@ -1,3 +1,5 @@ +# vim: filetype=automake + XENCONFIG_SOURCES = \ xenconfig/xenxs_private.h \ xenconfig/xen_common.c \ -- 2.20.1

2 1

[libvirt] RFC: remove qemu commandline parsing?
by Cole Robinson 12 Apr '19

12 Apr '19

qemu/qemu_parse_command.c powers 'sudo virsh domxml-from-native qemu-argv', parsing a qemu command line and attempting to turn it into libvirt domain XML. Some history: RFE: https://www.redhat.com/archives/libvir-list/2009-April/msg00266.html Patches: https://www.redhat.com/archives/libvir-list/2009-May/msg00321.html danpb blog post about related qemu-attach: https://www.berrange.com/posts/2011/07/13/attaching-libvirt-to-an-externall… At the time it was added, the parser was pretty comprehensive WRT to what libvirt XML features were available at the time. However it's quite hopelessly out of date these days and has been for a long time. As an example, the only -device it knows to parse is virtio-balloon, and it doesn't know anything about -netdev. So the parser can really only handle typical old style qemu options. AFAICT The original motivation for adding this and qemu-attach was providing a more straightforward path for direct qemu users to switch to libvirt. Googling does provide some cases of users successfully converting very simple qemu invocations to libvirt XML. But at least from my experience I don't think these features every really moved the needle in this respect. If anything, it's been that managing qemu has only grown more complex over time, which has made libvirt and tools that use it all the more compelling over launching your own qemu command line (for end users, think manually setting up usb2 with qemu directly). But IMO all that is kind of beside the point. I don't think it's debatable that the code is largely unused, and it hasn't seen many material improvements in the last 5 years, with zero plans to improve it on the horizon. It's 2000+ lines of text processing code living in every libvirtd instance. Deleting it all and making the qemu_driver.c APIs just return errors seems like an easy win considering we are trying to make libvirtd more modular and have a smaller footprint to facilitate usecases like kubevirt Thoughts? - Cole

4 3

[libvirt] [PATCH] maint: Add filetype annotations to Makefile.inc.am
by Andrea Bolognani 12 Apr '19

12 Apr '19

Both vim and emacs have trouble figuring out the filetype automatically because the name doesn't follow existing conventions; annotations like the ones we already have in Makefile.ci help them out. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/access/Makefile.inc.am | 3 +++ src/admin/Makefile.inc.am | 3 +++ src/bhyve/Makefile.inc.am | 3 +++ src/conf/Makefile.inc.am | 3 +++ src/cpu/Makefile.inc.am | 3 +++ src/cpu_map/Makefile.inc.am | 3 +++ src/esx/Makefile.inc.am | 3 +++ src/hyperv/Makefile.inc.am | 3 +++ src/interface/Makefile.inc.am | 3 +++ src/libxl/Makefile.inc.am | 3 +++ src/locking/Makefile.inc.am | 3 +++ src/logging/Makefile.inc.am | 3 +++ src/lxc/Makefile.inc.am | 3 +++ src/network/Makefile.inc.am | 3 +++ src/node_device/Makefile.inc.am | 3 +++ src/nwfilter/Makefile.inc.am | 3 +++ src/openvz/Makefile.inc.am | 3 +++ src/phyp/Makefile.inc.am | 3 +++ src/qemu/Makefile.inc.am | 3 +++ src/remote/Makefile.inc.am | 3 +++ src/rpc/Makefile.inc.am | 3 +++ src/secret/Makefile.inc.am | 3 +++ src/security/Makefile.inc.am | 3 +++ src/storage/Makefile.inc.am | 3 +++ src/test/Makefile.inc.am | 3 +++ src/util/Makefile.inc.am | 3 +++ src/vbox/Makefile.inc.am | 3 +++ src/vmware/Makefile.inc.am | 3 +++ src/vmx/Makefile.inc.am | 3 +++ src/vz/Makefile.inc.am | 3 +++ src/xenapi/Makefile.inc.am | 3 +++ src/xenconfig/Makefile.inc.am | 3 +++ 32 files changed, 96 insertions(+) diff --git a/src/access/Makefile.inc.am b/src/access/Makefile.inc.am index 6d57ca1a1b..5233a6fc08 100644 --- a/src/access/Makefile.inc.am +++ b/src/access/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ACCESS_DRIVER_GENERATED = \ access/viraccessapicheck.h \ access/viraccessapicheck.c \ diff --git a/src/admin/Makefile.inc.am b/src/admin/Makefile.inc.am index 19afb0e179..d3300d57ff 100644 --- a/src/admin/Makefile.inc.am +++ b/src/admin/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ADMIN_PROTOCOL = $(srcdir)/admin/admin_protocol.x ADMIN_PROTOCOL_GENERATED = \ diff --git a/src/bhyve/Makefile.inc.am b/src/bhyve/Makefile.inc.am index fba1b9ef30..ebd576f334 100644 --- a/src/bhyve/Makefile.inc.am +++ b/src/bhyve/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + BHYVE_DRIVER_SOURCES = \ bhyve/bhyve_capabilities.c \ bhyve/bhyve_capabilities.h \ diff --git a/src/conf/Makefile.inc.am b/src/conf/Makefile.inc.am index 6eb64db9de..2040220378 100644 --- a/src/conf/Makefile.inc.am +++ b/src/conf/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NETDEV_CONF_SOURCES = \ conf/netdev_bandwidth_conf.h \ conf/netdev_bandwidth_conf.c \ diff --git a/src/cpu/Makefile.inc.am b/src/cpu/Makefile.inc.am index 5020d40583..3508158fab 100644 --- a/src/cpu/Makefile.inc.am +++ b/src/cpu/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + CPU_SOURCES = \ cpu/cpu.h \ cpu/cpu.c \ diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 9d7cef15c5..39d98f8ce7 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + cpumapdir = $(pkgdatadir)/cpu_map cpumap_DATA = \ cpu_map/index.xml \ diff --git a/src/esx/Makefile.inc.am b/src/esx/Makefile.inc.am index 152dd7b979..95846baea5 100644 --- a/src/esx/Makefile.inc.am +++ b/src/esx/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + ESX_DRIVER_SOURCES = \ esx/esx_private.h \ esx/esx_driver.c \ diff --git a/src/hyperv/Makefile.inc.am b/src/hyperv/Makefile.inc.am index a768272b72..e5cc06bab7 100644 --- a/src/hyperv/Makefile.inc.am +++ b/src/hyperv/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + HYPERV_DRIVER_SOURCES = \ hyperv/hyperv_private.h \ hyperv/hyperv_driver.c \ diff --git a/src/interface/Makefile.inc.am b/src/interface/Makefile.inc.am index 08b35d040d..d1c59fa75b 100644 --- a/src/interface/Makefile.inc.am +++ b/src/interface/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + INTERFACE_DRIVER_SOURCES = \ interface/interface_driver.h \ interface/interface_driver.c \ diff --git a/src/libxl/Makefile.inc.am b/src/libxl/Makefile.inc.am index 59c136bf4e..86dfb176ca 100644 --- a/src/libxl/Makefile.inc.am +++ b/src/libxl/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LIBXL_DRIVER_SOURCES = \ libxl/libxl_conf.c \ libxl/libxl_conf.h \ diff --git a/src/locking/Makefile.inc.am b/src/locking/Makefile.inc.am index 5d5e923769..1d75223106 100644 --- a/src/locking/Makefile.inc.am +++ b/src/locking/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + DRIVER_SOURCES += \ locking/lock_manager.c \ locking/lock_manager.h \ diff --git a/src/logging/Makefile.inc.am b/src/logging/Makefile.inc.am index 3f4a87d91a..05ec5aa197 100644 --- a/src/logging/Makefile.inc.am +++ b/src/logging/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LOG_PROTOCOL_GENERATED = \ logging/log_protocol.h \ logging/log_protocol.c \ diff --git a/src/lxc/Makefile.inc.am b/src/lxc/Makefile.inc.am index 8dd2e9ea9e..a5b00a830d 100644 --- a/src/lxc/Makefile.inc.am +++ b/src/lxc/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + LXC_MONITOR_PROTOCOL_GENERATED = \ lxc/lxc_monitor_protocol.h \ lxc/lxc_monitor_protocol.c \ diff --git a/src/network/Makefile.inc.am b/src/network/Makefile.inc.am index cbaaa7ea68..ae546be0c2 100644 --- a/src/network/Makefile.inc.am +++ b/src/network/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NETWORK_DRIVER_SOURCES = \ network/bridge_driver.h \ network/bridge_driver.c \ diff --git a/src/node_device/Makefile.inc.am b/src/node_device/Makefile.inc.am index 0c3ad51273..c2255bd845 100644 --- a/src/node_device/Makefile.inc.am +++ b/src/node_device/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NODE_DEVICE_DRIVER_SOURCES = \ node_device/node_device_driver.c \ node_device/node_device_driver.h \ diff --git a/src/nwfilter/Makefile.inc.am b/src/nwfilter/Makefile.inc.am index 27aa801095..aabfccd654 100644 --- a/src/nwfilter/Makefile.inc.am +++ b/src/nwfilter/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + NWFILTER_DRIVER_SOURCES = \ nwfilter/nwfilter_driver.h \ nwfilter/nwfilter_driver.c \ diff --git a/src/openvz/Makefile.inc.am b/src/openvz/Makefile.inc.am index baad737362..f88660ee7b 100644 --- a/src/openvz/Makefile.inc.am +++ b/src/openvz/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + OPENVZ_DRIVER_SOURCES = \ openvz/openvz_conf.c \ openvz/openvz_conf.h \ diff --git a/src/phyp/Makefile.inc.am b/src/phyp/Makefile.inc.am index 496ff25266..2e213413a3 100644 --- a/src/phyp/Makefile.inc.am +++ b/src/phyp/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + PHYP_DRIVER_SOURCES = \ phyp/phyp_driver.c \ phyp/phyp_driver.h \ diff --git a/src/qemu/Makefile.inc.am b/src/qemu/Makefile.inc.am index 8d10e1085a..59b970c077 100644 --- a/src/qemu/Makefile.inc.am +++ b/src/qemu/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + QEMU_DRIVER_SOURCES = \ qemu/qemu_agent.c \ qemu/qemu_agent.h \ diff --git a/src/remote/Makefile.inc.am b/src/remote/Makefile.inc.am index 13a1f9f8f2..26e2091434 100644 --- a/src/remote/Makefile.inc.am +++ b/src/remote/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + REMOTE_DRIVER_GENERATED = \ remote/remote_protocol.c \ remote/remote_protocol.h \ diff --git a/src/rpc/Makefile.inc.am b/src/rpc/Makefile.inc.am index 722ef64db1..50bdde5d9f 100644 --- a/src/rpc/Makefile.inc.am +++ b/src/rpc/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + EXTRA_DIST += \ rpc/gendispatch.pl \ rpc/genprotocol.pl \ diff --git a/src/secret/Makefile.inc.am b/src/secret/Makefile.inc.am index 79c2b2d74a..fa377578ea 100644 --- a/src/secret/Makefile.inc.am +++ b/src/secret/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + SECRET_DRIVER_SOURCES = \ secret/secret_driver.h \ secret/secret_driver.c \ diff --git a/src/security/Makefile.inc.am b/src/security/Makefile.inc.am index b24cdfd083..6d1f749b49 100644 --- a/src/security/Makefile.inc.am +++ b/src/security/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + SECURITY_DRIVER_APPARMOR_HELPER_SOURCES = \ $(DATATYPES_SOURCES) \ security/virt-aa-helper.c \ diff --git a/src/storage/Makefile.inc.am b/src/storage/Makefile.inc.am index b4400b556f..a68e58f065 100644 --- a/src/storage/Makefile.inc.am +++ b/src/storage/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + STORAGE_DRIVER_BACKEND_SOURCES = \ storage/storage_backend.h \ storage/storage_backend.c \ diff --git a/src/test/Makefile.inc.am b/src/test/Makefile.inc.am index d52c281545..8d2201f352 100644 --- a/src/test/Makefile.inc.am +++ b/src/test/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + TEST_DRIVER_SOURCES = \ test/test_driver.c \ test/test_driver.h \ diff --git a/src/util/Makefile.inc.am b/src/util/Makefile.inc.am index 58874cca3c..ccdca2263f 100644 --- a/src/util/Makefile.inc.am +++ b/src/util/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + # These files are not related to driver APIs. Simply generic # helper APIs for various purposes UTIL_SOURCES = \ diff --git a/src/vbox/Makefile.inc.am b/src/vbox/Makefile.inc.am index 8c76f84e82..2cabe96c1c 100644 --- a/src/vbox/Makefile.inc.am +++ b/src/vbox/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VBOX_DRIVER_SOURCES = \ vbox/vbox_glue.c \ vbox/vbox_glue.h \ diff --git a/src/vmware/Makefile.inc.am b/src/vmware/Makefile.inc.am index 0fbf866030..6a1b565070 100644 --- a/src/vmware/Makefile.inc.am +++ b/src/vmware/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VMWARE_DRIVER_SOURCES = \ vmware/vmware_driver.c \ vmware/vmware_driver.h \ diff --git a/src/vmx/Makefile.inc.am b/src/vmx/Makefile.inc.am index b9bf6ef690..b15fe37e62 100644 --- a/src/vmx/Makefile.inc.am +++ b/src/vmx/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VMX_SOURCES = \ vmx/vmx.c \ vmx/vmx.h \ diff --git a/src/vz/Makefile.inc.am b/src/vz/Makefile.inc.am index cacdb38795..8e53906cae 100644 --- a/src/vz/Makefile.inc.am +++ b/src/vz/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + VZ_DRIVER_SOURCES = \ vz/vz_driver.h \ vz/vz_driver.c \ diff --git a/src/xenapi/Makefile.inc.am b/src/xenapi/Makefile.inc.am index 4640e9943f..2eee125ae2 100644 --- a/src/xenapi/Makefile.inc.am +++ b/src/xenapi/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + XENAPI_DRIVER_SOURCES = \ xenapi/xenapi_driver.c \ xenapi/xenapi_driver.h \ diff --git a/src/xenconfig/Makefile.inc.am b/src/xenconfig/Makefile.inc.am index a87d69990f..861e1c69ce 100644 --- a/src/xenconfig/Makefile.inc.am +++ b/src/xenconfig/Makefile.inc.am @@ -1,3 +1,6 @@ +# -*- makefile -*- +# vim: filetype=make + XENCONFIG_SOURCES = \ xenconfig/xenxs_private.h \ xenconfig/xen_common.c \ -- 2.20.1

2 3

[libvirt] [PATCH v2 0/7] readline: Drop obsolete code, add pkg-config support
by Andrea Bolognani 12 Apr '19

12 Apr '19

Changes from [v1]: * ensure macOS builds don't break by picking up libedit instead of readline. [v1] https://www.redhat.com/archives/libvir-list/2019-April/msg00632.html Andrea Bolognani (7): tools: vsh: Drop obsolete readline compatibility code m4: readline: Fix indentation m4: readline: Comment rl_completion_quote_character() check m4: readline: Extract code setting -D_FUNCTION_DEF m4: readline: Drop extra_LIBS machinery m4: readline: Use pkg-config where possible m4: readline: Add gross kludge for include path m4/virt-readline.m4 | 85 +++++++++++++++++++++++++++------------------ tools/vsh.c | 17 --------- 2 files changed, 51 insertions(+), 51 deletions(-) -- 2.20.1

2 14

[libvirt] [PATCH] lib: Don't use virReportSystemError() if virCommandRun() fails
by Michal Privoznik 12 Apr '19

12 Apr '19

Firstly, virCommandRun() does report an error on failure (which in most cases is more accurate than what we overwrite it with). Secondly, usually errno is not set (or gets overwritten in the cleanup code) which makes virReportSystemError() report useless error messages. Drop all virReportSystemError() calls in cases like this (I've found three occurrences). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I was under impression that I've sent this one earlier. Well, maybe I did not. src/storage/storage_backend_fs.c | 7 +------ src/util/virdnsmasq.c | 10 ++-------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 97148acebe..ae4e9a03a3 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -425,13 +425,8 @@ virStorageBackendExecuteMKFS(const char *device, virCommandAddArg(cmd, device); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, - _("Failed to make filesystem of " - "type '%s' on device '%s'"), - format, device); + if (virCommandRun(cmd, NULL) < 0) return -1; - } return 0; } diff --git a/src/util/virdnsmasq.c b/src/util/virdnsmasq.c index 550f3179ae..42f62682c4 100644 --- a/src/util/virdnsmasq.c +++ b/src/util/virdnsmasq.c @@ -751,22 +751,16 @@ dnsmasqCapsRefreshInternal(dnsmasqCapsPtr caps, bool force) virCommandSetOutputBuffer(cmd, &version); virCommandAddEnvPassCommon(cmd); virCommandClearCaps(cmd); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, _("failed to run '%s --version': %s"), - caps->binaryPath, version); + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } virCommandFree(cmd); cmd = virCommandNewArgList(caps->binaryPath, "--help", NULL); virCommandSetOutputBuffer(cmd, &help); virCommandAddEnvPassCommon(cmd); virCommandClearCaps(cmd); - if (virCommandRun(cmd, NULL) < 0) { - virReportSystemError(errno, _("failed to run '%s --help': %s"), - caps->binaryPath, help); + if (virCommandRun(cmd, NULL) < 0) goto cleanup; - } if (virAsprintf(&complete, "%s\n%s", version, help) < 0) goto cleanup; -- 2.21.0

2 1

[libvirt] [PATCH] conf: Fix typo enconding -> encoding
by Andrea Bolognani 12 Apr '19

12 Apr '19

Introduced-by: e0fae78ad550 Spotted-by: Lintian Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed-as: trivial src/conf/domain_audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_audit.c b/src/conf/domain_audit.c index ce176f7940..de7386d4c6 100644 --- a/src/conf/domain_audit.c +++ b/src/conf/domain_audit.c @@ -420,7 +420,7 @@ virDomainAuditHostdev(virDomainObjPtr vm, virDomainHostdevDefPtr hostdev, break; case VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_MDEV: if (VIR_STRDUP_QUIET(address, mdevsrc->uuidstr) < 0) { - VIR_WARN("OOM while enconding audit message"); + VIR_WARN("OOM while encoding audit message"); goto cleanup; } break; -- 2.20.1

1 0

[libvirt] [PATCH 0/7] vbox: drop support for many old versions
by Daniel P. Berrangé 12 Apr '19

12 Apr '19

Per this link: https://www.virtualbox.org/wiki/Download_Old_Builds VirtualBox 6.0 (active maintenance) VirtualBox 5.2 (active maintenance) VirtualBox 5.1 (no longer supported, support ended 2018/04) VirtualBox 5.0 (no longer supported, support ended 2017/05) VirtualBox 4.3 (no longer supported, support ended 2015/12) VirtualBox 4.2 (no longer supported, support ended 2015/12) VirtualBox 4.1 (no longer supported, support ended 2015/12) VirtualBox 4.0 (no longer supported, support ended 2015/12) We can certainly drop all the 4.x versions. The host OS those are officially supported on are very outdated: eg https://www.virtualbox.org/wiki/Download_Old_Builds_4_3 Linux Hosts: Ubuntu 13.04 ("Raring") / 13.10 ("Saucy") / 14.04 ("Trusty") / 14.10 ("Utopic") i386 | AMD64 Ubuntu 12.10 ("Quantal") i386 | AMD64 Ubuntu 12.04 ("Precise") i386 | AMD64 Ubuntu 10.04 LTS ("Lucid") i386 | AMD64 Debian 7 ("Wheezy") i386 | AMD64 Debian 6 ("Squeeze") i386 | AMD64 openSUSE 12.3 / 13.1 i386 | AMD64 openSUSE 11.4 / 12.1 / 12.2 i386 | AMD64 SUSE Linux Enterprise Server 11 (SLES11) i386 | AMD64 SUSE Linux Enterprise Server 10 (SLES10) i386 | AMD64 Fedora 18 ("Spherical Cow") / Fedora 19 ("Schrödingers Cat") i386 | AMD64 Fedora 17 ("Beefy Miracle") i386 | AMD64 Mandriva 2011.0 i386 | AMD64 Oracle Linux 6 ("OL6") / Red Hat Enterprise Linux 6 ("RHEL6") / CentOS 6 i386 | AMD64 Oracle Linux 5 ("OL5") / Red Hat Enterprise Linux 5 ("RHEL5") / CentOS 5 i386 | AMD64 All distributions i386 | AMD64 Although the catch all "All distributions" suggest it might work with newer distros, they are clearly a second tier from a support POV. All these explicitly targetted distros are outside libvirt's support policy. There is a question as to whether to delete 5.0 and 5.1 support from libvirt. There are no remainining #ifdef VBOX_API_VERSION conditionals in the vbox_tmpl.h file related to code differences between 5.0, 5.1 and 5.2, so keeping them is not a maint burden in code. The main burden is distributing the large vbox_CAPI_v5_0.h and vbox_CAPI_v5_1.h files which are ~1 MB in size (uncompressed) or ~85 kb (xz compressed). IOW versions 5.0 and 5.1 increase the release tarballs by a small amount, but nothing that is too unreasonable vs the overall size of 14 MB for libvirt source. Thus I have kept 5.0 and 5.1 support. VirtualBox 6.0 came out in Dec 2018 and given past practice it would not suprise me if that has API changes impacting libvirt. So some interested party might want to look at supporting that in libvirt. Daniel P. Berrangé (7): vbox: drop support for VirtualBox 4.x releases vbox: drop C API definition for release 4.0 vbox: drop C API definition for release 4.1 vbox: drop C API definition for release 4.2 vbox: drop C API definition for release 4.2.20 vbox: drop C API definition for release 4.3 vbox: drop C API definition for release 4.3.4 src/vbox/Makefile.inc.am | 6 - src/vbox/vbox_CAPI_v4_0.h | 7451 ----------------------- src/vbox/vbox_CAPI_v4_1.h | 7882 ------------------------ src/vbox/vbox_CAPI_v4_2.h | 8855 --------------------------- src/vbox/vbox_CAPI_v4_2_20.h | 9001 ---------------------------- src/vbox/vbox_CAPI_v4_3.h | 10210 ------------------------------- src/vbox/vbox_CAPI_v4_3_4.h | 10321 -------------------------------- src/vbox/vbox_V4_0.c | 37 - src/vbox/vbox_V4_1.c | 37 - src/vbox/vbox_V4_2.c | 13 - src/vbox/vbox_V4_2_20.c | 13 - src/vbox/vbox_V4_3.c | 13 - src/vbox/vbox_V4_3_4.c | 13 - src/vbox/vbox_common.h | 14 +- src/vbox/vbox_storage.c | 14 +- src/vbox/vbox_tmpl.c | 218 +- src/vbox/vbox_uniformed_api.h | 10 +- 17 files changed, 7 insertions(+), 54101 deletions(-) delete mode 100644 src/vbox/vbox_CAPI_v4_0.h delete mode 100644 src/vbox/vbox_CAPI_v4_1.h delete mode 100644 src/vbox/vbox_CAPI_v4_2.h delete mode 100644 src/vbox/vbox_CAPI_v4_2_20.h delete mode 100644 src/vbox/vbox_CAPI_v4_3.h delete mode 100644 src/vbox/vbox_CAPI_v4_3_4.h delete mode 100644 src/vbox/vbox_V4_0.c delete mode 100644 src/vbox/vbox_V4_1.c delete mode 100644 src/vbox/vbox_V4_2.c delete mode 100644 src/vbox/vbox_V4_2_20.c delete mode 100644 src/vbox/vbox_V4_3.c delete mode 100644 src/vbox/vbox_V4_3_4.c -- 2.20.1

1 8

[libvirt] [PATCH 0/2] Add capability-based mlock tests
by Ján Tomko 12 Apr '19

12 Apr '19

Ján Tomko (2): qemuxml2argvtest: add mlock tests for QEMU 3.0.0 qemuxml2argvtest: add mlock tests for latest QEMU .../mlock-off.x86_64-3.0.0.args | 32 +++++++++++++++++++ .../mlock-off.x86_64-latest.args | 32 +++++++++++++++++++ .../mlock-on.x86_64-3.0.0.args | 32 +++++++++++++++++++ .../mlock-on.x86_64-latest.args | 32 +++++++++++++++++++ tests/qemuxml2argvtest.c | 5 +++ 5 files changed, 133 insertions(+) create mode 100644 tests/qemuxml2argvdata/mlock-off.x86_64-3.0.0.args create mode 100644 tests/qemuxml2argvdata/mlock-off.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/mlock-on.x86_64-3.0.0.args create mode 100644 tests/qemuxml2argvdata/mlock-on.x86_64-latest.args -- 2.19.2

2 5

[libvirt] [PATCH 0/3] qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock'
by Michal Privoznik 12 Apr '19

12 Apr '19

Patches available also at: https://github.com/zippy2/libvirt/tree/qemu_mlock Inspired by the following QEMU patch: http://lists.nongnu.org/archive/html/qemu-devel/2019-04/msg01980.html Michal Prívozník (3): qemu: Always assume QEMU_CAPS_REALTIME_MLOCK qemu_capabilities: Introduce QEMU_CAPS_OVERCOMMIT qemu_command: Prefer '-overcommit mem-lock' over -realtime mlock' src/qemu/qemu_capabilities.c | 3 ++- src/qemu/qemu_capabilities.h | 3 ++- src/qemu/qemu_command.c | 10 ++++------ tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.11.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.aarch64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv32.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.riscv64.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.s390x.xml | 1 - tests/qemucapabilitiesdata/caps_3.0.0.x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 2 +- tests/qemucapabilitiesdata/caps_3.1.0.x86_64.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.riscv32.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.riscv64.xml | 2 +- tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml | 2 +- tests/qemuxml2argvdata/aarch64-aavmf-virtio-mmio.args | 1 + tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 1 + tests/qemuxml2argvdata/aarch64-cpu-passthrough.args | 1 + tests/qemuxml2argvdata/aarch64-gic-host.args | 1 + tests/qemuxml2argvdata/aarch64-gic-none-tcg.args | 1 + tests/qemuxml2argvdata/aarch64-gic-v2.args | 1 + tests/qemuxml2argvdata/aarch64-gic-v3.args | 1 + tests/qemuxml2argvdata/aarch64-kvm-32-on-64.args | 1 + tests/qemuxml2argvdata/aarch64-noacpi-nouefi.args | 1 + tests/qemuxml2argvdata/aarch64-noacpi-uefi.args | 1 + tests/qemuxml2argvdata/aarch64-pci-serial.args | 1 + tests/qemuxml2argvdata/aarch64-traditional-pci.args | 1 + .../aarch64-usb-controller-nec-xhci.args | 1 + .../aarch64-usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/aarch64-video-default.args | 1 + .../qemuxml2argvdata/aarch64-video-virtio-gpu-pci.args | 1 + .../aarch64-virt-2.6-virtio-pci-default.args | 1 + tests/qemuxml2argvdata/aarch64-virt-default-nic.args | 1 + tests/qemuxml2argvdata/aarch64-virt-virtio.args | 1 + tests/qemuxml2argvdata/aarch64-virtio-pci-default.args | 1 + .../aarch64-virtio-pci-manual-addresses.args | 1 + tests/qemuxml2argvdata/acpi-table.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-basic.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-nodevs.args | 1 + tests/qemuxml2argvdata/arm-vexpressa9-virtio.args | 1 + tests/qemuxml2argvdata/arm-virt-virtio.args | 1 + tests/qemuxml2argvdata/autoindex.args | 1 + tests/qemuxml2argvdata/balloon-ccw-deflate.args | 1 + tests/qemuxml2argvdata/balloon-device-auto.args | 1 + tests/qemuxml2argvdata/balloon-device-deflate-off.args | 1 + tests/qemuxml2argvdata/balloon-device-deflate.args | 1 + tests/qemuxml2argvdata/balloon-device-period.args | 1 + tests/qemuxml2argvdata/balloon-device.args | 1 + tests/qemuxml2argvdata/balloon-mmio-deflate.args | 1 + tests/qemuxml2argvdata/bios-nvram-secure.args | 1 + tests/qemuxml2argvdata/bios-nvram.args | 1 + tests/qemuxml2argvdata/bios.args | 1 + tests/qemuxml2argvdata/blkdeviotune-group-num.args | 1 + tests/qemuxml2argvdata/blkdeviotune-max-length.args | 1 + tests/qemuxml2argvdata/blkdeviotune-max.args | 1 + tests/qemuxml2argvdata/blkiotune-device.args | 1 + tests/qemuxml2argvdata/blkiotune.args | 1 + tests/qemuxml2argvdata/boot-cdrom.args | 1 + tests/qemuxml2argvdata/boot-complex.args | 1 + tests/qemuxml2argvdata/boot-floppy-q35.args | 1 + tests/qemuxml2argvdata/boot-floppy.args | 1 + tests/qemuxml2argvdata/boot-menu-disable-drive.args | 1 + tests/qemuxml2argvdata/boot-menu-disable.args | 1 + .../boot-menu-enable-with-timeout.args | 1 + tests/qemuxml2argvdata/boot-menu-enable.args | 1 + tests/qemuxml2argvdata/boot-multi.args | 1 + tests/qemuxml2argvdata/boot-network.args | 1 + tests/qemuxml2argvdata/boot-order.args | 1 + tests/qemuxml2argvdata/boot-strict.args | 1 + tests/qemuxml2argvdata/channel-guestfwd.args | 1 + tests/qemuxml2argvdata/channel-spicevmc.args | 1 + .../channel-unix-guestfwd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/channel-virtio-auto.args | 1 + tests/qemuxml2argvdata/channel-virtio-autoadd.args | 1 + tests/qemuxml2argvdata/channel-virtio-autoassign.args | 1 + tests/qemuxml2argvdata/channel-virtio-default.args | 1 + tests/qemuxml2argvdata/channel-virtio-state.args | 1 + tests/qemuxml2argvdata/channel-virtio-unix.args | 1 + tests/qemuxml2argvdata/channel-virtio.args | 1 + tests/qemuxml2argvdata/chardev-reconnect.args | 1 + tests/qemuxml2argvdata/clock-catchup.args | 1 + tests/qemuxml2argvdata/clock-france.args | 1 + tests/qemuxml2argvdata/clock-hpet-off.args | 1 + .../clock-localtime-basis-localtime.args | 1 + tests/qemuxml2argvdata/clock-localtime.args | 1 + tests/qemuxml2argvdata/clock-timer-hyperv-rtc.args | 1 + tests/qemuxml2argvdata/clock-utc.args | 1 + tests/qemuxml2argvdata/clock-variable.args | 1 + tests/qemuxml2argvdata/console-compat-auto.args | 1 + tests/qemuxml2argvdata/console-compat-chardev.args | 1 + tests/qemuxml2argvdata/console-compat.args | 1 + tests/qemuxml2argvdata/console-sclp.args | 1 + tests/qemuxml2argvdata/console-virtio-ccw.args | 1 + tests/qemuxml2argvdata/console-virtio-many.args | 1 + tests/qemuxml2argvdata/console-virtio-s390.args | 1 + .../console-virtio-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/console-virtio.args | 1 + tests/qemuxml2argvdata/controller-order.args | 1 + .../controller-virtio-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 1 + tests/qemuxml2argvdata/cpu-Haswell.args | 1 + tests/qemuxml2argvdata/cpu-Haswell2.args | 1 + tests/qemuxml2argvdata/cpu-Haswell3.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable2.args | 1 + tests/qemuxml2argvdata/cpu-cache-disable3.args | 1 + tests/qemuxml2argvdata/cpu-cache-emulate-l3.args | 1 + tests/qemuxml2argvdata/cpu-cache-passthrough.args | 1 + tests/qemuxml2argvdata/cpu-cache-passthrough2.args | 1 + tests/qemuxml2argvdata/cpu-check-default-none.args | 1 + tests/qemuxml2argvdata/cpu-check-default-none2.args | 1 + tests/qemuxml2argvdata/cpu-check-default-partial.args | 1 + tests/qemuxml2argvdata/cpu-check-default-partial2.args | 1 + tests/qemuxml2argvdata/cpu-check-none.args | 1 + tests/qemuxml2argvdata/cpu-eoi-disabled.args | 1 + tests/qemuxml2argvdata/cpu-eoi-enabled.args | 1 + tests/qemuxml2argvdata/cpu-exact1.args | 1 + tests/qemuxml2argvdata/cpu-exact2-nofallback.args | 1 + tests/qemuxml2argvdata/cpu-exact2.args | 1 + tests/qemuxml2argvdata/cpu-fallback.args | 1 + tests/qemuxml2argvdata/cpu-host-kvmclock.args | 1 + tests/qemuxml2argvdata/cpu-host-model-cmt.args | 1 + tests/qemuxml2argvdata/cpu-host-model-fallback.args | 1 + tests/qemuxml2argvdata/cpu-host-model-vendor.args | 1 + tests/qemuxml2argvdata/cpu-host-model.args | 1 + .../cpu-host-passthrough-features.args | 1 + tests/qemuxml2argvdata/cpu-host-passthrough.args | 1 + tests/qemuxml2argvdata/cpu-hotplug-startup.args | 1 + tests/qemuxml2argvdata/cpu-kvmclock.args | 1 + tests/qemuxml2argvdata/cpu-minimum1.args | 1 + tests/qemuxml2argvdata/cpu-minimum2.args | 1 + tests/qemuxml2argvdata/cpu-numa-disjoint.args | 1 + tests/qemuxml2argvdata/cpu-numa-memshared.args | 1 + tests/qemuxml2argvdata/cpu-numa-no-memory-element.args | 1 + tests/qemuxml2argvdata/cpu-numa1.args | 1 + tests/qemuxml2argvdata/cpu-numa2.args | 1 + tests/qemuxml2argvdata/cpu-s390-features.args | 1 + tests/qemuxml2argvdata/cpu-s390-zEC12.args | 1 + tests/qemuxml2argvdata/cpu-strict1.args | 1 + tests/qemuxml2argvdata/cpu-topology1.args | 1 + tests/qemuxml2argvdata/cpu-topology2.args | 1 + tests/qemuxml2argvdata/cpu-topology3.args | 1 + tests/qemuxml2argvdata/cpu-tsc-frequency.args | 1 + tests/qemuxml2argvdata/cputune-numatune.args | 1 + tests/qemuxml2argvdata/cputune-zero-shares.args | 1 + tests/qemuxml2argvdata/cputune.args | 1 + tests/qemuxml2argvdata/debug-threads.args | 1 + tests/qemuxml2argvdata/default-kvm-host-arch.args | 1 + tests/qemuxml2argvdata/default-qemu-host-arch.args | 1 + tests/qemuxml2argvdata/disk-aio.args | 1 + tests/qemuxml2argvdata/disk-aio.x86_64-latest.args | 2 +- .../disk-backing-chains-noindex.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-blockio.args | 1 + tests/qemuxml2argvdata/disk-boot-cdrom.args | 1 + tests/qemuxml2argvdata/disk-boot-disk.args | 1 + tests/qemuxml2argvdata/disk-cache.x86_64-latest.args | 2 +- .../disk-cdrom-bus-other.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom-network.args | 1 + .../disk-cdrom-network.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom-tray.args | 1 + .../disk-cdrom-tray.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-cdrom.args | 1 + tests/qemuxml2argvdata/disk-cdrom.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-copy_on_read.args | 1 + .../disk-copy_on_read.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-detect-zeroes.args | 1 + .../disk-detect-zeroes.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-discard.args | 1 + tests/qemuxml2argvdata/disk-error-policy.args | 1 + .../disk-error-policy.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-floppy-tray.args | 1 + tests/qemuxml2argvdata/disk-floppy.args | 1 + tests/qemuxml2argvdata/disk-floppy.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-fmt-qcow.args | 1 + tests/qemuxml2argvdata/disk-geometry.args | 1 + .../disk-hostdev-scsi-virtio-iscsi-auth-AES.args | 1 + tests/qemuxml2argvdata/disk-ide-split.args | 1 + tests/qemuxml2argvdata/disk-ide-wwn.args | 1 + tests/qemuxml2argvdata/disk-ioeventfd.args | 1 + tests/qemuxml2argvdata/disk-iscsi.args | 1 + tests/qemuxml2argvdata/disk-network-gluster.args | 1 + .../disk-network-gluster.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-iscsi-modern.args | 1 + tests/qemuxml2argvdata/disk-network-iscsi.args | 1 + .../disk-network-iscsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-nbd.args | 1 + .../disk-network-nbd.x86_64-latest.args | 2 +- .../disk-network-rbd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-sheepdog.args | 1 + .../disk-network-sheepdog.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-source-auth.args | 1 + .../disk-network-source-auth.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-tlsx509.args | 1 + .../disk-network-tlsx509.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-network-vxhs.args | 1 + tests/qemuxml2argvdata/disk-no-boot.args | 1 + tests/qemuxml2argvdata/disk-order.args | 1 + tests/qemuxml2argvdata/disk-readonly-disk.args | 1 + .../disk-readonly-disk.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-sata-device.args | 1 + .../disk-scsi-device-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-scsi-disk-split.args | 1 + tests/qemuxml2argvdata/disk-scsi-disk-vpd.args | 1 + tests/qemuxml2argvdata/disk-scsi-disk-wwn.args | 1 + tests/qemuxml2argvdata/disk-scsi-lun-passthrough.args | 1 + tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-serial.args | 1 + tests/qemuxml2argvdata/disk-shared.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-snapshot.args | 1 + tests/qemuxml2argvdata/disk-source-pool-mode.args | 1 + tests/qemuxml2argvdata/disk-source-pool.args | 1 + tests/qemuxml2argvdata/disk-usb-device-removable.args | 1 + tests/qemuxml2argvdata/disk-usb-device.args | 1 + tests/qemuxml2argvdata/disk-virtio-ccw-many.args | 1 + tests/qemuxml2argvdata/disk-virtio-ccw.args | 1 + tests/qemuxml2argvdata/disk-virtio-queues.args | 1 + tests/qemuxml2argvdata/disk-virtio-s390-zpci.args | 1 + tests/qemuxml2argvdata/disk-virtio-s390.args | 1 + .../disk-virtio-scsi-reservations.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-virtio.args | 1 + tests/qemuxml2argvdata/encrypted-disk-usage.args | 1 + tests/qemuxml2argvdata/encrypted-disk.args | 1 + tests/qemuxml2argvdata/eoi-disabled.args | 1 + tests/qemuxml2argvdata/eoi-enabled.args | 1 + tests/qemuxml2argvdata/event_idx.args | 1 + tests/qemuxml2argvdata/fd-memory-no-numa-topology.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology2.args | 1 + tests/qemuxml2argvdata/fd-memory-numa-topology3.args | 1 + tests/qemuxml2argvdata/fips-enabled.args | 1 + tests/qemuxml2argvdata/floppy-drive-fat.args | 1 + .../floppy-drive-fat.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/fs9p-ccw.args | 1 + tests/qemuxml2argvdata/fs9p.args | 1 + tests/qemuxml2argvdata/genid-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/genid.x86_64-latest.args | 2 +- ...graphics-egl-headless-rendernode.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-egl-headless.args | 1 + .../graphics-egl-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-sdl-fullscreen.args | 1 + tests/qemuxml2argvdata/graphics-sdl.args | 1 + .../graphics-spice-agent-file-xfer.args | 1 + tests/qemuxml2argvdata/graphics-spice-agentmouse.args | 1 + .../graphics-spice-auto-socket-cfg.args | 1 + tests/qemuxml2argvdata/graphics-spice-auto-socket.args | 1 + tests/qemuxml2argvdata/graphics-spice-compression.args | 1 + .../qemuxml2argvdata/graphics-spice-egl-headless.args | 1 + ...raphics-spice-gl-auto-rendernode.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-spice-no-args.args | 1 + tests/qemuxml2argvdata/graphics-spice-qxl-vga.args | 1 + tests/qemuxml2argvdata/graphics-spice-sasl.args | 1 + tests/qemuxml2argvdata/graphics-spice-socket.args | 1 + tests/qemuxml2argvdata/graphics-spice-timeout.args | 1 + tests/qemuxml2argvdata/graphics-spice-usb-redir.args | 1 + tests/qemuxml2argvdata/graphics-spice.args | 1 + .../qemuxml2argvdata/graphics-vnc-auto-socket-cfg.args | 1 + tests/qemuxml2argvdata/graphics-vnc-auto-socket.args | 1 + tests/qemuxml2argvdata/graphics-vnc-egl-headless.args | 1 + .../qemuxml2argvdata/graphics-vnc-no-listen-attr.args | 1 + tests/qemuxml2argvdata/graphics-vnc-none.args | 1 + tests/qemuxml2argvdata/graphics-vnc-policy.args | 1 + .../graphics-vnc-remove-generated-socket.args | 1 + tests/qemuxml2argvdata/graphics-vnc-sasl.args | 1 + .../graphics-vnc-socket-new-cmdline.args | 1 + tests/qemuxml2argvdata/graphics-vnc-socket.args | 1 + .../graphics-vnc-tls-secret.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 1 + .../graphics-vnc-tls.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-websocket.args | 1 + tests/qemuxml2argvdata/graphics-vnc.args | 1 + ...-mdev-display-spice-egl-headless.x86_64-latest.args | 2 +- ...ostdev-mdev-display-spice-opengl.x86_64-latest.args | 2 +- ...ev-mdev-display-vnc-egl-headless.x86_64-latest.args | 2 +- .../hostdev-mdev-display-vnc.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hostdev-mdev-precreated.args | 1 + tests/qemuxml2argvdata/hostdev-pci-address-device.args | 1 + tests/qemuxml2argvdata/hostdev-pci-address.args | 1 + .../qemuxml2argvdata/hostdev-scsi-lsi-iscsi-auth.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-lsi-iscsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-lsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-readonly.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-ccw.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-pci.args | 1 + .../qemuxml2argvdata/hostdev-scsi-vhost-scsi-pcie.args | 1 + .../hostdev-scsi-virtio-iscsi-auth.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-virtio-iscsi.args | 1 + tests/qemuxml2argvdata/hostdev-scsi-virtio-scsi.args | 1 + .../qemuxml2argvdata/hostdev-subsys-mdev-vfio-ccw.args | 1 + .../hostdev-usb-address-device-boot.args | 1 + tests/qemuxml2argvdata/hostdev-usb-address-device.args | 1 + tests/qemuxml2argvdata/hostdev-usb-address.args | 1 + tests/qemuxml2argvdata/hostdev-vfio-multidomain.args | 1 + .../hostdev-vfio-zpci-autogenerate.args | 1 + .../qemuxml2argvdata/hostdev-vfio-zpci-boundaries.args | 1 + .../hostdev-vfio-zpci-multidomain-many.args | 1 + tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 1 + tests/qemuxml2argvdata/hostdev-vfio.args | 1 + tests/qemuxml2argvdata/hotplug-base.args | 1 + tests/qemuxml2argvdata/hugepages-default-2M.args | 1 + .../hugepages-default-system-size.args | 1 + tests/qemuxml2argvdata/hugepages-default.args | 1 + tests/qemuxml2argvdata/hugepages-memaccess.args | 1 + tests/qemuxml2argvdata/hugepages-memaccess2.args | 1 + tests/qemuxml2argvdata/hugepages-nodeset.args | 1 + tests/qemuxml2argvdata/hugepages-numa-default-2M.args | 1 + .../qemuxml2argvdata/hugepages-numa-default-dimm.args | 1 + tests/qemuxml2argvdata/hugepages-numa-default.args | 1 + .../qemuxml2argvdata/hugepages-numa-nodeset-part.args | 1 + tests/qemuxml2argvdata/hugepages-numa-nodeset.args | 1 + .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-shared.args | 1 + tests/qemuxml2argvdata/hyperv-off.args | 1 + tests/qemuxml2argvdata/hyperv-panic.args | 1 + tests/qemuxml2argvdata/hyperv.args | 1 + tests/qemuxml2argvdata/input-usbmouse-addr.args | 1 + tests/qemuxml2argvdata/input-usbmouse.args | 1 + tests/qemuxml2argvdata/input-usbtablet.args | 1 + tests/qemuxml2argvdata/input-virtio-ccw.args | 1 + tests/qemuxml2argvdata/intel-iommu-caching-mode.args | 1 + tests/qemuxml2argvdata/intel-iommu-device-iotlb.args | 1 + tests/qemuxml2argvdata/intel-iommu-eim.args | 1 + tests/qemuxml2argvdata/intel-iommu-machine.args | 1 + tests/qemuxml2argvdata/intel-iommu.args | 1 + tests/qemuxml2argvdata/iothreads-disk-virtio-ccw.args | 1 + tests/qemuxml2argvdata/iothreads-disk.args | 1 + tests/qemuxml2argvdata/iothreads-ids-partial.args | 1 + tests/qemuxml2argvdata/iothreads-ids.args | 1 + .../iothreads-virtio-scsi-pci.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/iothreads.args | 1 + tests/qemuxml2argvdata/kvm-features-off.args | 1 + tests/qemuxml2argvdata/kvm-features.args | 1 + tests/qemuxml2argvdata/kvm-pit-delay.args | 1 + tests/qemuxml2argvdata/kvm-pit-discard.args | 1 + tests/qemuxml2argvdata/kvmclock+eoi-disabled.args | 1 + tests/qemuxml2argvdata/kvmclock.args | 1 + tests/qemuxml2argvdata/luks-disks-source-qcow2.args | 1 + tests/qemuxml2argvdata/luks-disks-source.args | 1 + tests/qemuxml2argvdata/luks-disks.args | 1 + tests/qemuxml2argvdata/mach-virt-console-virtio.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-native.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-pci.args | 1 + tests/qemuxml2argvdata/mach-virt-serial-usb.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-off-cap.args | 1 + .../qemuxml2argvdata/machine-aeskeywrap-off-caps.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-on-cap.args | 1 + tests/qemuxml2argvdata/machine-aeskeywrap-on-caps.args | 1 + tests/qemuxml2argvdata/machine-aliases1.args | 1 + tests/qemuxml2argvdata/machine-aliases2.args | 1 + tests/qemuxml2argvdata/machine-core-off.args | 1 + tests/qemuxml2argvdata/machine-core-on.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-off-cap.args | 1 + .../qemuxml2argvdata/machine-deakeywrap-off-caps.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-on-cap.args | 1 + tests/qemuxml2argvdata/machine-deakeywrap-on-caps.args | 1 + tests/qemuxml2argvdata/machine-keywrap-none-caps.args | 1 + tests/qemuxml2argvdata/machine-keywrap-none.args | 1 + .../machine-loadparm-multiple-disks-nets-s390.args | 1 + tests/qemuxml2argvdata/machine-loadparm-net-s390.args | 1 + tests/qemuxml2argvdata/machine-loadparm-s390.args | 1 + tests/qemuxml2argvdata/machine-smm-opt.args | 1 + tests/qemuxml2argvdata/machine-vmport-opt.args | 1 + tests/qemuxml2argvdata/master-key.args | 1 + .../memfd-memory-default-hugepage.x86_64-latest.args | 2 +- .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memory-hotplug-dimm-addr.args | 1 + tests/qemuxml2argvdata/memory-hotplug-dimm.args | 1 + .../memory-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../qemuxml2argvdata/memory-hotplug-ppc64-nonuma.args | 1 + tests/qemuxml2argvdata/memory-hotplug.args | 1 + tests/qemuxml2argvdata/memtune-unlimited.args | 1 + tests/qemuxml2argvdata/memtune.args | 1 + tests/qemuxml2argvdata/migrate-numa-unaligned.args | 1 + tests/qemuxml2argvdata/migrate.args | 1 + tests/qemuxml2argvdata/minimal-msg-timestamp.args | 1 + tests/qemuxml2argvdata/minimal-sandbox.args | 1 + tests/qemuxml2argvdata/minimal.args | 1 + tests/qemuxml2argvdata/misc-acpi.args | 1 + tests/qemuxml2argvdata/misc-disable-s3.args | 1 + tests/qemuxml2argvdata/misc-disable-suspends.args | 1 + tests/qemuxml2argvdata/misc-enable-s4.args | 1 + tests/qemuxml2argvdata/misc-no-reboot.args | 1 + tests/qemuxml2argvdata/misc-uuid.args | 1 + tests/qemuxml2argvdata/mlock-off.args | 2 +- tests/qemuxml2argvdata/mlock-on.args | 2 +- tests/qemuxml2argvdata/mlock-unsupported.args | 1 + tests/qemuxml2argvdata/monitor-json.args | 1 + tests/qemuxml2argvdata/multifunction-pci-device.args | 1 + tests/qemuxml2argvdata/name-escape.args | 1 + tests/qemuxml2argvdata/net-client.args | 1 + tests/qemuxml2argvdata/net-eth-hostip.args | 1 + tests/qemuxml2argvdata/net-eth-ifname.args | 1 + tests/qemuxml2argvdata/net-eth-names.args | 1 + tests/qemuxml2argvdata/net-eth.args | 1 + tests/qemuxml2argvdata/net-hostdev-bootorder.args | 1 + tests/qemuxml2argvdata/net-hostdev-multidomain.args | 1 + .../qemuxml2argvdata/net-hostdev-vfio-multidomain.args | 1 + tests/qemuxml2argvdata/net-hostdev-vfio.args | 1 + tests/qemuxml2argvdata/net-hostdev.args | 1 + tests/qemuxml2argvdata/net-mcast.args | 1 + tests/qemuxml2argvdata/net-server.args | 1 + tests/qemuxml2argvdata/net-udp.args | 1 + tests/qemuxml2argvdata/net-user-addr.args | 1 + tests/qemuxml2argvdata/net-user.args | 1 + tests/qemuxml2argvdata/net-vhostuser-multiq.args | 1 + tests/qemuxml2argvdata/net-vhostuser.args | 1 + .../qemuxml2argvdata/net-vhostuser.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/net-virtio-ccw.args | 1 + tests/qemuxml2argvdata/net-virtio-device.args | 1 + .../qemuxml2argvdata/net-virtio-disable-offloads.args | 1 + tests/qemuxml2argvdata/net-virtio-netdev.args | 1 + tests/qemuxml2argvdata/net-virtio-rxtxqueuesize.args | 1 + tests/qemuxml2argvdata/net-virtio-s390.args | 1 + tests/qemuxml2argvdata/net-virtio.args | 1 + tests/qemuxml2argvdata/nosharepages.args | 1 + .../numad-auto-memory-vcpu-cpuset.args | 1 + ...numad-auto-memory-vcpu-no-cpuset-and-placement.args | 1 + .../numad-auto-vcpu-static-numatune.args | 1 + .../numad-static-memory-auto-vcpu.args | 1 + tests/qemuxml2argvdata/numad.args | 1 + .../numatune-auto-nodeset-invalid.args | 1 + tests/qemuxml2argvdata/numatune-auto-prefer.args | 1 + tests/qemuxml2argvdata/numatune-distances.args | 1 + tests/qemuxml2argvdata/numatune-memnode-no-memory.args | 1 + tests/qemuxml2argvdata/numatune-memnode.args | 1 + tests/qemuxml2argvdata/numatune-memory.args | 1 + .../os-firmware-bios.x86_64-latest.args | 2 +- .../os-firmware-efi-secboot.x86_64-latest.args | 2 +- .../os-firmware-efi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pages-dimm-discard.args | 1 + tests/qemuxml2argvdata/pages-discard-hugepages.args | 1 + tests/qemuxml2argvdata/pages-discard.args | 1 + tests/qemuxml2argvdata/panic-double.args | 1 + tests/qemuxml2argvdata/panic-no-address.args | 1 + tests/qemuxml2argvdata/panic.args | 1 + tests/qemuxml2argvdata/parallel-parport-chardev.args | 1 + tests/qemuxml2argvdata/parallel-tcp-chardev.args | 1 + .../parallel-unix-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 1 + tests/qemuxml2argvdata/pci-autoadd-idx.args | 1 + tests/qemuxml2argvdata/pci-autofill-addr.args | 1 + tests/qemuxml2argvdata/pci-bridge-many-disks.args | 1 + tests/qemuxml2argvdata/pci-bridge.args | 1 + tests/qemuxml2argvdata/pci-expander-bus.args | 1 + tests/qemuxml2argvdata/pci-many.args | 1 + tests/qemuxml2argvdata/pci-rom-disabled.args | 1 + tests/qemuxml2argvdata/pci-rom.args | 1 + tests/qemuxml2argvdata/pci-serial-dev-chardev.args | 1 + tests/qemuxml2argvdata/pcie-expander-bus.args | 1 + .../qemuxml2argvdata/pcie-root-port-model-generic.args | 1 + .../qemuxml2argvdata/pcie-root-port-model-ioh3420.args | 1 + tests/qemuxml2argvdata/pcie-root-port.args | 1 + tests/qemuxml2argvdata/pcie-root.args | 1 + .../qemuxml2argvdata/pcie-switch-downstream-port.args | 1 + tests/qemuxml2argvdata/pcie-switch-upstream-port.args | 1 + tests/qemuxml2argvdata/pcihole64-q35.args | 1 + tests/qemuxml2argvdata/pcihole64.args | 1 + tests/qemuxml2argvdata/pmu-feature-off.args | 1 + tests/qemuxml2argvdata/pmu-feature.args | 1 + tests/qemuxml2argvdata/ppc-dtb.args | 1 + .../ppc64-pseries-graphics.ppc64-latest.args | 2 +- .../ppc64-pseries-headless.ppc64-latest.args | 2 +- .../qemuxml2argvdata/ppc64-usb-controller-legacy.args | 1 + .../ppc64-usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/ppc64-usb-controller.args | 1 + tests/qemuxml2argvdata/ppce500-serial.args | 1 + tests/qemuxml2argvdata/pseries-basic.args | 1 + tests/qemuxml2argvdata/pseries-console-virtio.args | 1 + tests/qemuxml2argvdata/pseries-cpu-compat-power9.args | 1 + tests/qemuxml2argvdata/pseries-cpu-compat.args | 1 + tests/qemuxml2argvdata/pseries-cpu-exact.args | 1 + tests/qemuxml2argvdata/pseries-cpu-le.args | 1 + tests/qemuxml2argvdata/pseries-features.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-1.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-2.args | 1 + tests/qemuxml2argvdata/pseries-hostdevs-3.args | 1 + .../pseries-machine-max-cpu-compat.args | 1 + tests/qemuxml2argvdata/pseries-many-buses-1.args | 1 + tests/qemuxml2argvdata/pseries-many-buses-2.args | 1 + tests/qemuxml2argvdata/pseries-many-devices.args | 1 + tests/qemuxml2argvdata/pseries-nvram.args | 1 + tests/qemuxml2argvdata/pseries-panic-missing.args | 1 + tests/qemuxml2argvdata/pseries-panic-no-address.args | 1 + .../qemuxml2argvdata/pseries-phb-default-missing.args | 1 + tests/qemuxml2argvdata/pseries-phb-numa-node.args | 1 + tests/qemuxml2argvdata/pseries-phb-simple.args | 1 + tests/qemuxml2argvdata/pseries-serial-native.args | 1 + tests/qemuxml2argvdata/pseries-serial-pci.args | 1 + tests/qemuxml2argvdata/pseries-serial-usb.args | 1 + tests/qemuxml2argvdata/pseries-usb-default.args | 1 + tests/qemuxml2argvdata/pseries-usb-kbd.args | 1 + tests/qemuxml2argvdata/pseries-usb-multi.args | 1 + tests/qemuxml2argvdata/pseries-vio-user-assigned.args | 1 + tests/qemuxml2argvdata/pseries-vio.args | 1 + tests/qemuxml2argvdata/pv-spinlock-disabled.args | 1 + tests/qemuxml2argvdata/pv-spinlock-enabled.args | 1 + tests/qemuxml2argvdata/q35-acpi-nouefi.args | 1 + tests/qemuxml2argvdata/q35-acpi-uefi.args | 1 + tests/qemuxml2argvdata/q35-default-devices-only.args | 1 + tests/qemuxml2argvdata/q35-multifunction.args | 1 + tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 1 + tests/qemuxml2argvdata/q35-pci-force-address.args | 1 + tests/qemuxml2argvdata/q35-pcie-autoadd.args | 1 + tests/qemuxml2argvdata/q35-pcie.args | 1 + tests/qemuxml2argvdata/q35-pm-disable-fallback.args | 1 + tests/qemuxml2argvdata/q35-pm-disable.args | 1 + tests/qemuxml2argvdata/q35-usb2-multi.args | 1 + tests/qemuxml2argvdata/q35-usb2-reorder.args | 1 + tests/qemuxml2argvdata/q35-usb2.args | 1 + tests/qemuxml2argvdata/q35-virt-manager-basic.args | 1 + tests/qemuxml2argvdata/q35-virtio-pci.args | 1 + tests/qemuxml2argvdata/q35.args | 1 + tests/qemuxml2argvdata/qemu-ns-alt.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline-ns1.args | 1 + tests/qemuxml2argvdata/qemu-ns-commandline.args | 1 + .../qemu-ns-domain-commandline-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-domain-commandline.args | 1 + tests/qemuxml2argvdata/qemu-ns-domain-ns0.args | 1 + tests/qemuxml2argvdata/qemu-ns-no-env.args | 1 + tests/qemuxml2argvdata/qemu-ns.args | 1 + tests/qemuxml2argvdata/reboot-timeout-disabled.args | 1 + tests/qemuxml2argvdata/reboot-timeout-enabled.args | 1 + tests/qemuxml2argvdata/restore-v2-fd.args | 1 + tests/qemuxml2argvdata/restore-v2.args | 1 + .../riscv64-virt-headless.riscv64-latest.args | 2 +- tests/qemuxml2argvdata/riscv64-virt-pci.args | 1 + tests/qemuxml2argvdata/riscv64-virt.args | 1 + .../s390-allow-bogus-usb-controller.args | 1 + tests/qemuxml2argvdata/s390-allow-bogus-usb-none.args | 1 + tests/qemuxml2argvdata/s390-panic-missing.args | 1 + tests/qemuxml2argvdata/s390-panic-no-address.args | 1 + tests/qemuxml2argvdata/s390-serial-2.args | 1 + tests/qemuxml2argvdata/s390-serial-console.args | 1 + tests/qemuxml2argvdata/s390-serial.args | 1 + tests/qemuxml2argvdata/seclabel-dac-none.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-baselabel.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-labelskip.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-override.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic-relabel.args | 1 + tests/qemuxml2argvdata/seclabel-dynamic.args | 1 + tests/qemuxml2argvdata/seclabel-none.args | 1 + tests/qemuxml2argvdata/seclabel-static-labelskip.args | 1 + tests/qemuxml2argvdata/seclabel-static-relabel.args | 1 + tests/qemuxml2argvdata/seclabel-static.args | 1 + tests/qemuxml2argvdata/serial-dev-chardev-iobase.args | 1 + tests/qemuxml2argvdata/serial-dev-chardev.args | 1 + tests/qemuxml2argvdata/serial-file-chardev.args | 1 + tests/qemuxml2argvdata/serial-file-log.args | 1 + tests/qemuxml2argvdata/serial-many-chardev.args | 1 + tests/qemuxml2argvdata/serial-pty-chardev.args | 1 + tests/qemuxml2argvdata/serial-spiceport-nospice.args | 1 + tests/qemuxml2argvdata/serial-spiceport.args | 1 + tests/qemuxml2argvdata/serial-tcp-chardev.args | 1 + tests/qemuxml2argvdata/serial-tcp-telnet-chardev.args | 1 + .../serial-tcp-tlsx509-chardev-notls.args | 1 + .../serial-tcp-tlsx509-chardev-verify.args | 1 + tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.args | 1 + .../serial-tcp-tlsx509-secret-chardev.args | 1 + tests/qemuxml2argvdata/serial-udp-chardev.args | 1 + tests/qemuxml2argvdata/serial-unix-chardev.args | 1 + .../serial-unix-chardev.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 1 + tests/qemuxml2argvdata/shmem-plain-doorbell.args | 1 + tests/qemuxml2argvdata/shmem.args | 1 + tests/qemuxml2argvdata/smartcard-controller.args | 1 + .../smartcard-host-certificates-database.args | 1 + .../qemuxml2argvdata/smartcard-host-certificates.args | 1 + tests/qemuxml2argvdata/smartcard-host.args | 1 + .../smartcard-passthrough-spicevmc.args | 1 + tests/qemuxml2argvdata/smartcard-passthrough-tcp.args | 1 + .../smartcard-passthrough-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/smbios.args | 1 + tests/qemuxml2argvdata/smp.args | 1 + tests/qemuxml2argvdata/sound-device.args | 1 + tests/qemuxml2argvdata/sound.args | 1 + .../tpm-emulator-tpm2.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/tpm-emulator.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/tpm-passthrough-crb.args | 1 + tests/qemuxml2argvdata/tpm-passthrough.args | 1 + .../tseg-explicit-size.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/usb-controller-default-q35.args | 1 + .../qemuxml2argvdata/usb-controller-explicit-q35.args | 1 + tests/qemuxml2argvdata/usb-controller-qemu-xhci.args | 1 + tests/qemuxml2argvdata/usb-controller-xhci.args | 1 + tests/qemuxml2argvdata/usb-controller.args | 1 + tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.args | 1 + tests/qemuxml2argvdata/usb-hub-autoadd.args | 1 + tests/qemuxml2argvdata/usb-hub.args | 1 + tests/qemuxml2argvdata/usb-ich9-autoassign.args | 1 + tests/qemuxml2argvdata/usb-ich9-companion.args | 1 + tests/qemuxml2argvdata/usb-ich9-ehci-addr.args | 1 + tests/qemuxml2argvdata/usb-long-port-path.args | 1 + tests/qemuxml2argvdata/usb-none.args | 1 + tests/qemuxml2argvdata/usb-piix3-controller.args | 1 + tests/qemuxml2argvdata/usb-port-autoassign.args | 1 + tests/qemuxml2argvdata/usb-port-missing.args | 1 + tests/qemuxml2argvdata/usb-ports.args | 1 + tests/qemuxml2argvdata/usb-redir-boot.args | 1 + tests/qemuxml2argvdata/usb-redir-filter-version.args | 1 + tests/qemuxml2argvdata/usb-redir-filter.args | 1 + .../qemuxml2argvdata/usb-redir-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/usb-redir.args | 1 + tests/qemuxml2argvdata/usb-xhci-autoassign.args | 1 + tests/qemuxml2argvdata/usb1-usb2.args | 1 + tests/qemuxml2argvdata/user-aliases-usb.args | 1 + tests/qemuxml2argvdata/user-aliases.args | 1 + tests/qemuxml2argvdata/vcpu-placement-static.args | 1 + .../vhost-vsock-auto.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vhost-vsock.x86_64-latest.args | 2 +- .../qemuxml2argvdata/video-device-pciaddr-default.args | 1 + tests/qemuxml2argvdata/video-none-device.args | 1 + tests/qemuxml2argvdata/video-qxl-device-vgamem.args | 1 + .../video-qxl-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-device.args | 1 + tests/qemuxml2argvdata/video-qxl-heads.args | 1 + tests/qemuxml2argvdata/video-qxl-nodevice.args | 1 + tests/qemuxml2argvdata/video-qxl-noheads.args | 1 + .../qemuxml2argvdata/video-qxl-sec-device-vgamem.args | 1 + .../video-qxl-sec-device-vram64.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/video-qxl-sec-device.args | 1 + tests/qemuxml2argvdata/video-vga-device-vgamem.args | 1 + tests/qemuxml2argvdata/video-vga-device.args | 1 + tests/qemuxml2argvdata/video-vga-nodevice.args | 1 + tests/qemuxml2argvdata/video-vga-qxl-heads.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-ccw.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-device.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-sdl-gl.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-secondary.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-spice-gl.args | 1 + tests/qemuxml2argvdata/video-virtio-gpu-virgl.args | 1 + tests/qemuxml2argvdata/video-virtio-vga.args | 1 + tests/qemuxml2argvdata/virtio-input-passthrough.args | 1 + tests/qemuxml2argvdata/virtio-input.args | 1 + tests/qemuxml2argvdata/virtio-lun.args | 1 + .../virtio-non-transitional.x86_64-3.1.0.args | 2 +- .../virtio-non-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-options.args | 1 + tests/qemuxml2argvdata/virtio-rng-ccw.args | 1 + tests/qemuxml2argvdata/virtio-rng-default.args | 1 + .../virtio-rng-egd-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-rng-egd.args | 1 + tests/qemuxml2argvdata/virtio-rng-multiple.args | 1 + tests/qemuxml2argvdata/virtio-rng-random.args | 1 + .../virtio-transitional.x86_64-3.1.0.args | 2 +- .../virtio-transitional.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vmcoreinfo.args | 1 + tests/qemuxml2argvdata/watchdog-device.args | 1 + tests/qemuxml2argvdata/watchdog-diag288.args | 1 + tests/qemuxml2argvdata/watchdog-dump.args | 1 + tests/qemuxml2argvdata/watchdog-injectnmi.args | 1 + tests/qemuxml2argvdata/watchdog.args | 1 + tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 1 + .../x86_64-pc-graphics.x86_64-latest.args | 2 +- .../x86_64-pc-headless.x86_64-latest.args | 2 +- .../x86_64-q35-graphics.x86_64-latest.args | 2 +- .../x86_64-q35-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 5 ++--- 688 files changed, 663 insertions(+), 126 deletions(-) -- 2.21.0

2 7

[libvirt] [jenkins-ci PATCH] guests: Remove SASL symlink kludge
by Andrea Bolognani 12 Apr '19

12 Apr '19

It's no longer needed as of libvirt commit ab6f29c6da12. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/update/tasks/kludges.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml index 9d4f232..708e7a4 100644 --- a/guests/playbooks/update/tasks/kludges.yml +++ b/guests/playbooks/update/tasks/kludges.yml @@ -9,9 +9,7 @@ force: yes with_items: - include/readline - - include/sasl - lib/libreadline.so - - lib/libsasl2.so when: - os_name == 'FreeBSD' -- 2.20.1

2 1

[libvirt] [PATCH] virresctrl: fix MBA memory leak
by Pavel Hrdina 12 Apr '19

12 Apr '19

The 'bandwidths' variable is allocated using VIR_RESIZE_N so it has to be freed as well. ==118315== 8 bytes in 1 blocks are definitely lost in loss record 299 of 2,401 ==118315== at 0x4C29DAD: malloc (vg_replace_malloc.c:308) ==118315== by 0x4C2C100: realloc (vg_replace_malloc.c:836) ==118315== by 0x52C3FAF: virReallocN (viralloc.c:245) ==118315== by 0x52C4079: virExpandN (viralloc.c:294) ==118315== by 0x532BBA8: virResctrlAllocParseProcessMemoryBandwidth (virresctrl.c:1156) ==118315== by 0x532BBA8: virResctrlAllocParseMemoryBandwidthLine (virresctrl.c:1211) ==118315== by 0x532BBA8: virResctrlAllocParse (virresctrl.c:1414) ==118315== by 0x532BBA8: virResctrlAllocGetGroup (virresctrl.c:1446) ==118315== by 0x532C11D: virResctrlAllocGetDefault (virresctrl.c:1464) ==118315== by 0x532D15E: virResctrlAllocAssign (virresctrl.c:1923) ==118315== by 0x532D15E: virResctrlAllocCreate (virresctrl.c:2042) ==118315== by 0x31E1ABEE: qemuProcessResctrlCreate (qemu_process.c:2596) ==118315== by 0x31E1ABEE: qemuProcessLaunch (qemu_process.c:6444) ==118315== by 0x31E1E341: qemuProcessStart (qemu_process.c:6721) ==118315== by 0x31E81315: qemuDomainObjStart.constprop.50 (qemu_driver.c:7288) ==118315== by 0x31E81A65: qemuDomainCreateWithFlags (qemu_driver.c:7341) ==118315== by 0x54DDB4B: virDomainCreate (libvirt-domain.c:6534) Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virresctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 9e477fc064..87feb4bdcf 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -407,6 +407,7 @@ virResctrlAllocDispose(void *obj) virResctrlAllocMemBWPtr mem_bw = alloc->mem_bw; for (i = 0; i < mem_bw->nbandwidths; i++) VIR_FREE(mem_bw->bandwidths[i]); + VIR_FREE(alloc->mem_bw->bandwidths); VIR_FREE(alloc->mem_bw); } -- 2.20.1

2 1

[libvirt] [PATCH v3 0/7] extend virsh domstate to show additional information
by Bjoern Walk 12 Apr '19

12 Apr '19

This patch series introduces the ability to save additional information for the domain state and exposes this information in virsh domstate. For example in the case of QEMU guest panic events, we can provide additional information like the crash reason or register state of the domain. This information usually gets logged in the domain log but for debugging it is useful to have it accessible from the client. Therefore, let's introduce a new public API function, virDomainGetStateParams, an extensible version of virDomainGetState, which returns the complete state of the domain, including newly introduced additional information. Let's also extend virsh domstate and introduce a new parameter --info to show the domain state, reason and additional information when available. virsh # domstate --info guest-1 crashed (panicked) s390.core = 0 s390.psw-mask = 0x0002000180000000 s390.psw-addr = 0x000000000010f146 s390.reason = disabled-wait v2 -> v3: * try to find a reasonable naming-scheme for parameters * make state/reason in virDomainGetStateParams optional * use new API only when requested * print additional information per line for easier consumption v1 -> v2: * refactored the public API according to discussions to provide a more machine-parsable interface Bjoern Walk (7): qemu: monitor: move event data structure to domain qemu: domain: store and update panic info lib: introduce virDomainGetStateParams function remote: implement remoteDomainGetStateParams qemu: implement qemuDomainGetStateParams virsh: domstate: report detailed state if available news: add entry for virDomainGetStateParams docs/news.xml | 11 +++ include/libvirt/libvirt-domain.h | 76 +++++++++++++++++ src/driver-hypervisor.h | 9 ++ src/libvirt-domain.c | 62 ++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_domain.c | 80 +++++++++++++++++- src/qemu/qemu_domain.h | 47 +++++++++++ src/qemu/qemu_driver.c | 126 +++++++++++++++++++++++++++- src/qemu/qemu_monitor.c | 53 +----------- src/qemu/qemu_monitor.h | 48 ++--------- src/qemu/qemu_monitor_json.c | 20 ++--- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 50 +++++++++++ src/remote/remote_driver.c | 48 +++++++++++ src/remote/remote_protocol.x | 22 ++++- src/remote_protocol-structs | 13 +++ tools/virsh-domain-monitor.c | 94 +++++++++++++++++++-- tools/virsh.pod | 5 +- 18 files changed, 651 insertions(+), 120 deletions(-) -- 2.19.1

3 17

[libvirt] [PATCH v5] tests: perform cross compiler builds on GitLab CI
by Daniel P. Berrangé 12 Apr '19

12 Apr '19

GitLab CI provides some shared build runners that use Docker containers. This resource can usefully run cross-compiled builds since all other CI build testing is currently x86 only, and Travis CI is already very busy testing native builds. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Changed in v4: - Fix env name - Rename jobs to match image name .gitlab-ci.yml | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index 0000000000..f576757c88 --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,74 @@ +.job_template: &job_definition + script: + - mkdir vpath + - cd vpath + - ../autogen.sh $CONFIGURE_OPTS + - make -j $(getconf _NPROCESSORS_ONLN) + +debian-9-cross-aarch64: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-aarch64:master + +debian-9-cross-armv6l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-armv6l:master + +debian-9-cross-armv7l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-armv7l:master + +debian-9-cross-mips64el: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-mips64el:master + +debian-9-cross-mips: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-mips:master + +debian-9-cross-mipsel: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-mipsel:master + +debian-9-cross-ppc64le: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-ppc64le:master + +debian-9-cross-s390x: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-9-cross-s390x:master + +debian-sid-cross-aarch64: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-aarch64:master + +debian-sid-cross-armv6l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-armv6l:master + +debian-sid-cross-armv7l: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-armv7l:master + +debian-sid-cross-i686: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-i686:master + +debian-sid-cross-mips64el: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-mips64el:master + +debian-sid-cross-mips: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-mips:master + +debian-sid-cross-mipsel: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-mipsel:master + +debian-sid-cross-ppc64le: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-ppc64le:master + +debian-sid-cross-s390x: + <<: *job_definition + image: quay.io/libvirt/buildenv-debian-sid-cross-s390x:master -- 2.20.1

2 2

[libvirt] [PATCH 0/4] Add 'label' arg to VIR_ENUM_IMPL
by Cole Robinson 11 Apr '19

11 Apr '19

This is a different take on an RFE I posted in July: https://www.redhat.com/archives/libvir-list/2018-July/msg01815.html The goal of this series is to get us close to being able to raise errors from ToString and FromString functions directly. This will allow us to drop many hundreds of lines of error reporting and accompanying translator load. The first attempt above added a new macro, VIR_ENUM_IMPL_LABEL, which would take a string label, like 'domain type' for virDomainType enum. The generated ToString and FromString functions for that enum would now raise errors containing the label. Redundant error reporting could now be stripped out piece by piece as individual enums are converted. Thinking some more though I don't really like this strategy. Calling code won't have an easy way to know whether ToString/FromString functions are the type that raise errors or not, which could lead to new code accidentally omitting them and failing to raise an error. It could also stretch out the time that the code base is in a half transitioned state. This series is a slightly different direction. VIR_ENUM_IMPL now always takes a label, but for now we don't actually raise any errors. Later at a chosen time we can enable error reporting in the code and begin removing duplicate error reporting. The only downside is that until the transition is complete, there may be cases of double error reporting, but that's the lesser of two evils compared to the previous approach IMO. So the feedback I'm looking for: - Is this worth doing? (danpb+mprivozn said as much for first posting) - Is this approach acceptable? - Review of the strings added in the last patch Notes: - This is on top of pkrempa's virenum.c patches on list - The last two patches are separated to make review easier, but they will be committed together - When enabled, one notable case this will make error reporting worse is virTristate usage. But I think if we manually implement *TOString/FromString wrappers in that case we can require callers to pass in an identifying string. Something to think about for later Cole Robinson (4): Always put _LAST enums on second line of VIR_ENUM_IMPL cfg.mk: Only force _LAST enum on VIR_ENUM_IMPL second line util: Add 'label' field to VIR_ENUM_IMPL Add string labels to all VIR_ENUM_IMPL calls cfg.mk | 6 +- docs/apibuild.py | 12 ++ src/access/viraccessperm.c | 20 +- src/conf/capabilities.c | 3 +- src/conf/cpu_conf.c | 21 +- src/conf/device_conf.c | 3 +- src/conf/domain_capabilities.c | 3 +- src/conf/domain_conf.c | 333 +++++++++++++++++++----------- src/conf/interface_conf.c | 2 +- src/conf/netdev_vlan_conf.c | 3 +- src/conf/network_conf.c | 11 +- src/conf/node_device_conf.c | 12 +- src/conf/numa_conf.c | 7 +- src/conf/nwfilter_conf.c | 21 +- src/conf/snapshot_conf.c | 6 +- src/conf/storage_adapter_conf.c | 2 +- src/conf/storage_conf.c | 18 +- src/libxl/libxl_domain.c | 3 +- src/locking/lock_daemon.c | 3 +- src/logging/log_daemon.c | 3 +- src/lxc/lxc_domain.c | 7 +- src/lxc/lxc_native.c | 3 +- src/network/leaseshelper.c | 3 +- src/qemu/qemu_agent.c | 4 +- src/qemu/qemu_capabilities.c | 3 +- src/qemu/qemu_command.c | 27 ++- src/qemu/qemu_domain.c | 12 +- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_firmware.c | 6 +- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_migration_cookie.c | 2 +- src/qemu/qemu_migration_params.c | 9 +- src/qemu/qemu_monitor.c | 8 +- src/qemu/qemu_monitor_json.c | 10 +- src/remote/remote_daemon.c | 3 +- src/util/vircgroup.c | 3 +- src/util/vircgroupbackend.c | 3 +- src/util/vircgroupv1.c | 3 +- src/util/vircgroupv2.c | 3 +- src/util/virconf.c | 3 +- src/util/virenum.c | 28 ++- src/util/virenum.h | 15 +- src/util/virerror.c | 3 +- src/util/virfirewall.c | 3 +- src/util/virfirewalld.c | 6 +- src/util/virgic.c | 3 +- src/util/virhook.c | 20 +- src/util/virkeycode.c | 3 +- src/util/virlog.c | 3 +- src/util/virmdev.c | 3 +- src/util/virnetdev.c | 6 +- src/util/virnetdevmacvlan.c | 3 +- src/util/virnetdevvportprofile.c | 6 +- src/util/virpci.c | 9 +- src/util/virperf.c | 3 +- src/util/virprocess.c | 3 +- src/util/virresctrl.c | 12 +- src/util/virsecret.c | 3 +- src/util/virstorageencryption.c | 4 +- src/util/virstoragefile.c | 17 +- src/util/virsysinfo.c | 3 +- src/util/virtypedparam.c | 3 +- src/util/virutil.c | 1 - src/vmware/vmware_conf.c | 3 +- src/vmx/vmx.c | 3 +- tests/group-qemu-caps.pl | 2 +- tests/virkeycodetest.c | 3 +- tools/virsh-domain-monitor.c | 24 +-- tools/virsh-domain.c | 56 ++--- tools/virsh-host.c | 3 +- tools/virsh-network.c | 10 +- tools/virsh-nodedev.c | 2 +- tools/virsh-pool.c | 4 +- tools/virsh-secret.c | 2 +- tools/virsh-volume.c | 5 +- tools/virt-admin.c | 2 +- tools/virt-host-validate-common.c | 3 +- 77 files changed, 561 insertions(+), 334 deletions(-) -- 2.21.0

2 12

[libvirt] [PATCH 0/3] vz: fixes after commits refactoring common snapshot code
by Nikolay Shirokovskiy 11 Apr '19

11 Apr '19

Nikolay Shirokovskiy (3): vz: fix for tracking current snapshot vz: fixes: snapshot: Switch type of virDomainSnapshotObj.def vz: fixes: snapshot: Factor out virDomainMomentDef class src/vz/vz_driver.c | 36 +++++++----------------------------- src/vz/vz_sdk.c | 24 +++++++++++------------- 2 files changed, 18 insertions(+), 42 deletions(-) -- 1.8.3.1

3 5

[libvirt] [PATCH 0/2] sasl: Fix CFLAGS use, switch to pkg-config
by Andrea Bolognani 11 Apr '19

11 Apr '19

Andrea Bolognani (2): src: Include SASL_CFLAGS where appropriate m4: sasl: Use pkg-config m4/virt-sasl.m4 | 2 +- src/admin/Makefile.inc.am | 6 ++++++ src/locking/Makefile.inc.am | 12 ++++++++++++ src/logging/Makefile.inc.am | 6 ++++++ src/remote/Makefile.inc.am | 6 ++++++ src/rpc/Makefile.inc.am | 6 ++++++ 6 files changed, 37 insertions(+), 1 deletion(-) -- 2.20.1

2 4

[libvirt] [PATCH] build: set --without-firewalld-zone in configure commandline for Fedora 30
by Laine Stump 11 Apr '19

11 Apr '19

The firewalld package in Fedora 30 didn't get support for rich rule priorities, which is required by the libvirt zonefile that's installed when the build is configured with --with-firewalld-zone, so we need to set --without-firewalld-zone for that version of Fedora. The needed feature is already upstream in firewalld, so it just needs another upstream release to be there. Let's be optimistic and assume that will happen prior to F31. Signed-off-by: Laine Stump <laine(a)laine.org> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 8ea27c91a3..18f0a0e217 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -137,7 +137,7 @@ %define with_firewalld 1 -%if 0%{?fedora} >= 30 || 0%{?rhel} > 7 +%if 0%{?fedora} >= 31 || 0%{?rhel} > 7 %define with_firewalld_zone 0%{!?_without_firewalld_zone:1} %endif -- 2.20.1

3 2

[libvirt] [PATCH v4 0/7] Facilitate running libvirt builds via docker containers
by Daniel P. Berrangé 11 Apr '19

11 Apr '19

For a while QEMU has provided simple make rules for building QEMU inside standard docker container environments. This provides an equivalent mechanism for libvirt inspired by QEMU's. QEMU actually builds the container images on developer's machines locally. Libvirt already hosts pre-built images on quay.io, so that is used directly as it is quicker to download them than to build them locally. This also ensures the container contents match what the live CI system is using, as opposed to building an image with newer packages. Changed in v4: - Re-add cross-compilation patches now that containers exist - Add CI_ prefix on all variables to avoid clashing with automake defined variables - Fix path given to -f arg for ci-check target - Remove dead code - Fix check for submodule checkout existing - Ensure macOS Homebrew is updated Changed in v3: - Lots of new variables & variable renames - Rename to top level Makefile.ci - Rename make targets to have @ separator for the image - Refactor macOS travis config Changed in v2: - Drop cross-compilation patches temporarily. The cross-compiler images are not yet built on quay.io and rather than creating and bulding many more images manually, I'm working on script to automate setup of quay.io images - Many changes to the make rules to make it possible to use them from Travis CI to match its currently testing setup - Modify Travis CI config to use the new make rules for consistency Daniel P. Berrangé (7): tests: add targets for building libvirt inside Docker containers travis: convert Ubuntu, CentOS & MinGW builds to use new make rules travis: use declarative syntax for Homebrew packages travis: remove display of test-suite.log from macOS travis: put macOS script inline in the macOS matrix entry tests: add cross compiler images to CI test help output tests: perform cross compiler builds on GitLab CI .gitignore | 1 + .gitlab-ci.yml | 74 +++++++++++++++++ .travis.yml | 78 +++++------------ Makefile.am | 2 + Makefile.ci | 222 +++++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 321 insertions(+), 56 deletions(-) create mode 100644 .gitlab-ci.yml create mode 100644 Makefile.ci -- 2.20.1

3 22

[libvirt] [PATCH v2 0/3] docs: add advanced search capability
by Daniel P. Berrangé 11 Apr '19

11 Apr '19

Andrea suggested it would be nice to redirect the search box to a local search page which then let the user submit a site-restricted search to google for website vs wiki vs mailing lists. I took a slightly different approach here, and instead simply popup an extra set of radio buttons below the main search field. This lets the user select the site to search straightaway without the intermediate page. Changed in v2: - Add missing rules for installing javascript - Use mediawiki search - Search dev & users lists separately - Whitespace fixes Daniel P. Berrangé (3): docs: ensure javascript files are included in dist & install rules docs: move javascript logic into a standalone file docs: add advanced search capabilities docs/Makefile.am | 15 +++++++++- docs/js/main.js | 77 ++++++++++++++++++++++++++++++++++++++++++++++++ docs/libvirt.css | 39 ++++++++++++++++++++++++ docs/mobile.css | 7 +++++ docs/page.xsl | 51 ++++++++++---------------------- 5 files changed, 152 insertions(+), 37 deletions(-) create mode 100644 docs/js/main.js -- 2.20.1

2 11

[libvirt] [PATCH] domaincapstest: Call virFileWrapperClearPrefixes only on non-WIN32
by Michal Privoznik 11 Apr '19

11 Apr '19

The virFileWrapperClearPrefixes() function is defined only when building for non-WIN32. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Technically a build breaker fix, but I can't decide if ifdef is better or removing the call is better. tests/domaincapstest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 3ee95a4b58..92676bdd6e 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -476,7 +476,9 @@ mymain(void) DO_TEST_BHYVE("fbuf", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); #endif /* WITH_BHYVE */ +#ifndef WIN32 virFileWrapperClearPrefixes(); +#endif /* WIN32 */ return ret; } -- 2.21.0

3 2

[libvirt] [PATCH 0/2] Fix 'New libvirt-tck failure with libvirt 5.2.0'
by Daniel Henrique Barboza 11 Apr '19

11 Apr '19

Hi, Jim Fehlig reported a failure in a libvirt-tck test after the patch: commit f1d6585300001c7b23b8796a0faa4411c3531996 Author: Daniel Henrique Barboza <danielhb413(a)gmail.com> Date: Fri Mar 15 18:06:45 2019 -0300 domain_conf: check device address before This patch is blocking the use of 'virsh attach-device' for changing and ejecting CDROM/Floppy drives. More info and some discussion can be found at [1]. This small patch set makes changes in the device address verification to allow this usage back. First patch is just an extra helper to make the code a bit easier to read. Patch 2 amends commit f1d658530. [1] https://www.redhat.com/archives/libvir-list/2019-April/msg00733.html Daniel Henrique Barboza (2): domain_conf: adding virDomainDiskIsCdromOrFloppy helper domain_conf: allow CDROM/Floppy media change with attach-device src/conf/domain_conf.c | 9 +++++++++ src/conf/domain_conf.h | 2 ++ src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 3 +-- src/qemu/qemu_driver.c | 3 +-- src/qemu/qemu_hotplug.c | 6 ++---- 6 files changed, 16 insertions(+), 8 deletions(-) -- 2.20.1

2 3

[libvirt] [PATCH] libvirtd.conf: remove extra # after log_outputs line
by Pavel Hrdina 11 Apr '19

11 Apr '19

The only place where we have extra empty comment line. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- This annoys me every time I like to change log_outputs. Let's fix it finally. Pushed under trivial rule. src/remote/libvirtd.conf | 1 - 1 file changed, 1 deletion(-) diff --git a/src/remote/libvirtd.conf b/src/remote/libvirtd.conf index 92562ab7ae..ac07df6930 100644 --- a/src/remote/libvirtd.conf +++ b/src/remote/libvirtd.conf @@ -410,7 +410,6 @@ # Multiple outputs can be defined, they just need to be separated by spaces. # e.g. to log all warnings and errors to syslog under the libvirtd ident: #log_outputs="3:syslog:libvirtd" -# ################################################################## -- 2.20.1

1 0

[libvirt] New libvirt-tck failure with libvirt 5.2.0
by Jim Fehlig 11 Apr '19

11 Apr '19

I noticed libvirt-tck test domain/207-disk-media-change.t started failing after updating to libvirt 5.2.0. A bisection fingered commit f1d65853 commit f1d6585300001c7b23b8796a0faa4411c3531996 Author: Daniel Henrique Barboza <danielhb413(a)gmail.com> Date: Fri Mar 15 18:06:45 2019 -0300 domain_conf: check device address before attach This commit prevents a media change on CDROM devices. Regards, Jim

3 6

[libvirt] [PATCH v2 0/3] introducing QEMU_CAPS_QUERY_CURRENT_MACHINE and QEMU_CAPS_PM_WAKEUP_SUPPORT
by Daniel Henrique Barboza 11 Apr '19

11 Apr '19

v2: Fixed review problems found by Peter Krempa, most notably: - changed the cap name - made the code generic to be easier to add other caps from the query-current-machine API - changed unit tests accordingly Previous version can be found at: https://www.redhat.com/archives/libvir-list/2019-April/msg00104.html Daniel Henrique Barboza (3): adding QEMU_CAPS_QUERY_CURRENT_MACHINE and QEMU_CAPS_PM_WAKEUP_SUPPORT qemu_process: setting QEMU_CAPS_QUERY_CURRENT_MACHINE caps qemuDomainPMSuspendForDuration: check for QEMU_CAPS_PM_WAKEUP_SUPPORT src/qemu/qemu_capabilities.c | 5 ++ src/qemu/qemu_capabilities.h | 4 ++ src/qemu/qemu_driver.c | 21 ++++++++ src/qemu/qemu_monitor.c | 17 ++++++ src/qemu/qemu_monitor.h | 11 ++++ src/qemu/qemu_monitor_json.c | 53 +++++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 ++ src/qemu/qemu_process.c | 36 +++++++++++++ .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + 11 files changed, 155 insertions(+) -- 2.20.1

2 7

[libvirt] [jenkins-ci PATCH] guests: Remove YAJL symlink kludge
by Andrea Bolognani 11 Apr '19

11 Apr '19

It's no longer needed as of libvirt commit 105756660f94. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/update/tasks/kludges.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/guests/playbooks/update/tasks/kludges.yml b/guests/playbooks/update/tasks/kludges.yml index c955a30..9d4f232 100644 --- a/guests/playbooks/update/tasks/kludges.yml +++ b/guests/playbooks/update/tasks/kludges.yml @@ -10,10 +10,8 @@ with_items: - include/readline - include/sasl - - include/yajl - lib/libreadline.so - lib/libsasl2.so - - lib/libyajl.so when: - os_name == 'FreeBSD' -- 2.20.1

2 1

[libvirt] [PATCH] virsh: Add virshDomainShutdownModeCompleter
by Michal Privoznik 10 Apr '19

10 Apr '19

This completer is used to offer shutdown/reboot modes. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-completer.c | 56 +++++++++++++++++++++++++++++++++++++++++ tools/virsh-completer.h | 4 +++ tools/virsh-domain.c | 2 ++ 3 files changed, 62 insertions(+) diff --git a/tools/virsh-completer.c b/tools/virsh-completer.c index aac4579d1f..918e409890 100644 --- a/tools/virsh-completer.c +++ b/tools/virsh-completer.c @@ -936,3 +936,59 @@ virshDomainDeviceAliasCompleter(vshControl *ctl, VIR_STEAL_PTR(ret, tmp); return ret; } + + +char ** +virshDomainShutdownModeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags) +{ + const char *modes[] = {"acpi", "agent", "initctl", "signal", "paravirt"}; + size_t i; + char **ret = NULL; + size_t ntmp = 0; + VIR_AUTOSTRINGLIST tmp = NULL; + const char *modeConst = NULL; + VIR_AUTOFREE(char *) mode = NULL; + VIR_AUTOSTRINGLIST modesSpecified = NULL; + + virCheckFlags(0, NULL); + + if (vshCommandOptStringQuiet(ctl, cmd, "mode", &modeConst) < 0) + return NULL; + + if (STREQ_NULLABLE(modeConst, " ")) + modeConst = NULL; + + if (modeConst) { + char *modeTmp = NULL; + + if (VIR_STRDUP(mode, modeConst) < 0) + return NULL; + + if ((modeTmp = strrchr(mode, ','))) + *modeTmp = '\0'; + else + VIR_FREE(mode); + } + + if (mode && !(modesSpecified = virStringSplit(mode, ",", 0))) + return NULL; + + if (VIR_ALLOC_N(tmp, ARRAY_CARDINALITY(modes) + 1) < 0) + return NULL; + + for (i = 0; i < ARRAY_CARDINALITY(modes); i++) { + if (virStringListHasString((const char **)modesSpecified, modes[i])) + continue; + + if ((mode && virAsprintf(&tmp[ntmp], "%s,%s", mode, modes[i]) < 0) || + (!mode && VIR_STRDUP(tmp[ntmp], modes[i]) < 0)) + return NULL; + + ntmp++; + } + + VIR_STEAL_PTR(ret, tmp); + return ret; +} diff --git a/tools/virsh-completer.h b/tools/virsh-completer.h index 2e2e1edafb..ed37a26cc9 100644 --- a/tools/virsh-completer.h +++ b/tools/virsh-completer.h @@ -110,4 +110,8 @@ char ** virshDomainDeviceAliasCompleter(vshControl *ctl, char ** virshCellnoCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); + +char ** virshDomainShutdownModeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); #endif /* LIBVIRT_VIRSH_COMPLETER_H */ diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index e8d5404acf..a8a0b2f20d 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -5829,6 +5829,7 @@ static const vshCmdOptDef opts_shutdown[] = { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name = "mode", .type = VSH_OT_STRING, + .completer = virshDomainShutdownModeCompleter, .help = N_("shutdown mode: acpi|agent|initctl|signal|paravirt") }, {.name = NULL} @@ -5913,6 +5914,7 @@ static const vshCmdOptDef opts_reboot[] = { VIRSH_COMMON_OPT_DOMAIN_FULL(VIR_CONNECT_LIST_DOMAINS_ACTIVE), {.name = "mode", .type = VSH_OT_STRING, + .completer = virshDomainShutdownModeCompleter, .help = N_("shutdown mode: acpi|agent|initctl|signal|paravirt") }, {.name = NULL} -- 2.21.0

2 1

[libvirt] [PATCH] security: apparmor: make vhost-net access a static rule
by Christian Ehrhardt 10 Apr '19

10 Apr '19

So far we were detecting at guest start if any devices needed vhost net and only if that was true added a rule for /dev/vhost-net. It turns out that it is an absolutely valid case to start a guest without any vhost-net networking but later on wanting to hotplug such a device which then would be denied by apparmor. Unfortunately there also is no security labeling callback involved other than the one to /dev/net/tun. But on the other hand vhost-net is no more new and considered rather safe. Therefore drop the old detection and just add it as a static rule. Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1815910 Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/apparmor/libvirt-qemu | 1 + src/security/virt-aa-helper.c | 17 +---------------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index eaa5167525..a71f34c175 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -21,6 +21,7 @@ signal (receive) peer=/usr/sbin/libvirtd, /dev/net/tun rw, + /dev/vhost-net rw, /dev/kvm rw, /dev/ptmx rw, /dev/kqemu rw, diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 8e22e9978a..ebc4feac77 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -937,7 +937,7 @@ get_files(vahControl * ctl) size_t i; char *uuid; char uuidstr[VIR_UUID_STRING_BUFLEN]; - bool needsVfio = false, needsvhost = false; + bool needsVfio = false; /* verify uuid is same as what we were given on the command line */ virUUIDFormat(ctl->def->uuid, uuidstr); @@ -1248,21 +1248,6 @@ get_files(vahControl * ctl) } } - if (ctl->def->virtType == VIR_DOMAIN_VIRT_KVM) { - for (i = 0; i < ctl->def->nnets; i++) { - virDomainNetDefPtr net = ctl->def->nets[i]; - if (net && net->model) { - if (net->driver.virtio.name == VIR_DOMAIN_NET_BACKEND_TYPE_QEMU) - continue; - if (!virDomainNetIsVirtioModel(net)) - continue; - } - needsvhost = true; - } - } - if (needsvhost) - virBufferAddLit(&buf, " \"/dev/vhost-net\" rw,\n"); - if (needsVfio) { virBufferAddLit(&buf, " \"/dev/vfio/vfio\" rw,\n"); virBufferAddLit(&buf, " \"/dev/vfio/[0-9]*\" rw,\n"); -- 2.17.1

2 5

[libvirt] [PATCH] qemuHotplugDiskSourceDataFree: also free backends
by Ján Tomko 10 Apr '19

10 Apr '19

Also free the backends array, not just its members. Fixes: d3f9dda2c9fd9fa7d2f7f1f1dd70ed7d83938101 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_hotplug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 34249bd030..540befba68 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -512,6 +512,7 @@ qemuHotplugDiskSourceDataFree(qemuHotplugDiskSourceDataPtr data) for (i = 0; i < data->nbackends; i++) qemuBlockStorageSourceAttachDataFree(data->backends[i]); + VIR_FREE(data->backends); VIR_FREE(data); } -- 2.19.2

2 1

[libvirt] [PATCH 00/11] A selection of refactors and improvements from the blockdev-add saga
by Peter Krempa 10 Apr '19

10 Apr '19

Few patches require https://www.redhat.com/archives/libvir-list/2019-April/msg00324.html to be applied. This is a collection of cleanups and improvements from my blockdev branch which make sense even without the rest of the blockdev patches. Peter Krempa (11): qemu: block: Introduce and use AUTOPTR func for qemuBlockStorageSourceAttachDataPtr qemu: block: Use VIR_AUTOPTR for virJSONValue util: uri: Introduce VIR_AUTOPTR freeing function qemu: block: Use VIR_AUTOPTR for virURIPtr qemu: block: Use VIR_AUTOPTR for virHashTablePtr qemu: block: Use VIR_AUTOFREE for char * qemu: block: Add and use AUTOPTR func for qemuBlockNodeNameBackingChainData qemu: block: Remove unneeded cleanup jumps internal: Introduce VIR_RETURN_PTR qemu: block: Use VIR_RETURN_PTR util: json: Use VIR_APPEND_ELEMENT in virJSONValueObjectAppend src/internal.h | 15 ++ src/qemu/qemu_block.c | 388 +++++++++++++------------------------- src/qemu/qemu_block.h | 3 + src/qemu/qemu_command.c | 14 +- src/qemu/qemu_hotplug.c | 9 +- src/qemu/qemu_migration.c | 3 +- src/util/virjson.c | 19 +- src/util/viruri.h | 2 + 8 files changed, 172 insertions(+), 281 deletions(-) -- 2.20.1

2 22

[libvirt] [PATCH] tests: Fix MinGW build for domaincapstest
by Andrea Bolognani 10 Apr '19

10 Apr '19

Commit 5b9819eedc71 started using the virFileWrapper APIs in the test program, and correctly called them only in the section of code guarded by WITH_QEMU; however, a single call to the virFileWrapperClearPrefixes() function ended up in the hypervisor-agnostic section, causing a build failure on MinGW. Move the call to the QEMU-only section; while at it, also drop the virFileWrapperRemovePrefix() calls, which are entirely redundant since we'd drop all prefixes immediately afterwards anyway. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Another approach would be to simply drop the call to virFileWrapperClearPrefixes(), but there really is no point in removing prefixes one by one when we can just clear all of them in one fell swoop. tests/domaincapstest.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 3ee95a4b58..a9922e1edb 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -451,9 +451,7 @@ mymain(void) "x86_64", VIR_DOMAIN_VIRT_KVM); virObjectUnref(cfg); - virFileWrapperRemovePrefix(SYSCONFDIR "/qemu/firmware"); - virFileWrapperRemovePrefix(PREFIX "/share/qemu/firmware"); - virFileWrapperRemovePrefix("/home/user/.config/qemu/firmware"); + virFileWrapperClearPrefixes(); #endif /* WITH_QEMU */ @@ -476,8 +474,6 @@ mymain(void) DO_TEST_BHYVE("fbuf", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); #endif /* WITH_BHYVE */ - virFileWrapperClearPrefixes(); - return ret; } -- 2.20.1

2 1

[libvirt] [PATCH 0/4] qemu: Honor memory mode='strict'
by Michal Privoznik 10 Apr '19

10 Apr '19

If there's a domain configured as: <currentMemory unit='MiB'>4096</currentMemory> <numatune> <memory mode='strict' nodeset='1'/> </numatune> but there is not enough memory on NUMA node 1 the domain will start successfully because we allow it to allocate memory from other nodes. This is a result of some previous fix (v1.2.7-rc1~91). However, I've tested my fix successfully on a NUMA machine with F29 and recent kernel. So the kernel bug I'm mentioning in 4/4 is probably fixed then and we can drop the workaround. Michal Prívozník (4): qemuSetupCpusetMems: Use VIR_AUTOFREE() qemuSetupCpusetMems: Create EMULATOR thread upfront qemu_cgroup: Make qemuSetupCpusetMems static qemuSetupCpusetCgroup: Set up cpuset.mems before execing qemu src/qemu/qemu_cgroup.c | 12 +++++++----- src/qemu/qemu_cgroup.h | 1 - 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.21.0

2 6

[libvirt] [PATCH v2 0/4] domain capabilities: Expose firmware auto selection feature
by Michal Privoznik 10 Apr '19

10 Apr '19

v2 of: https://www.redhat.com/archives/libvir-list/2019-April/msg00460.html diff to v1: - Expose 'secure' too - Switch to uint64_t for qemuFirmwareGetSupported() Michal Prívozník (4): qemu_firmware: Separate firmware loading into a function qemu_firmware: Separate machine and arch matching into a function qemu_firmware: Introduce qemuFirmwareGetSupported domain capabilities: Expose firmware auto selection feature docs/formatdomaincaps.html.in | 23 +++ docs/schemas/domaincaps.rng | 1 + src/conf/domain_capabilities.c | 3 + src/conf/domain_capabilities.h | 2 + src/qemu/qemu_capabilities.c | 35 +++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_firmware.c | 169 ++++++++++++++---- src/qemu/qemu_firmware.h | 10 ++ tests/Makefile.am | 4 +- .../qemu_1.7.0.x86_64.xml | 7 + .../qemu_2.12.0-virt.aarch64.xml | 6 + .../qemu_2.12.0.ppc64.xml | 4 + .../qemu_2.12.0.s390x.xml | 4 + .../qemu_2.12.0.x86_64.xml | 7 + .../qemu_2.6.0-virt.aarch64.xml | 6 + .../qemu_2.6.0.aarch64.xml | 4 + .../domaincapsschemadata/qemu_2.6.0.ppc64.xml | 4 + .../qemu_2.6.0.x86_64.xml | 7 + .../domaincapsschemadata/qemu_2.7.0.s390x.xml | 4 + .../qemu_2.8.0-tcg.x86_64.xml | 7 + .../domaincapsschemadata/qemu_2.8.0.s390x.xml | 4 + .../qemu_2.8.0.x86_64.xml | 7 + .../qemu_2.9.0-q35.x86_64.xml | 8 + .../qemu_2.9.0-tcg.x86_64.xml | 7 + .../qemu_2.9.0.x86_64.xml | 7 + .../domaincapsschemadata/qemu_3.0.0.s390x.xml | 4 + .../qemu_3.1.0.x86_64.xml | 7 + .../qemu_4.0.0.x86_64.xml | 7 + tests/domaincapstest.c | 16 ++ tests/qemufirmwaretest.c | 72 ++++++++ 31 files changed, 412 insertions(+), 36 deletions(-) -- 2.21.0

3 7

[libvirt] [PATCH] Revert "Include unistd.h directly by files using it"
by Peter Krempa 10 Apr '19

10 Apr '19

This reverts commit a5e16020907e91bca1b0ab6c4ee5dbbdcccf6a54. Getting rid of unistd.h from our headers will require more work than just fixing the broken mingw build. Revert it until I have a more complete proposal. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- Pushed under the build-breaker rule. src/conf/virnwfilterbindingobj.c | 2 -- src/libxl/libxl_domain.c | 1 - src/locking/lock_daemon_config.c | 2 -- src/locking/lock_driver_lockd.c | 2 -- src/logging/log_daemon_config.c | 2 -- src/lxc/lxc_conf.c | 2 -- src/lxc/lxc_fuse.c | 1 - src/network/leaseshelper.c | 1 - src/nwfilter/nwfilter_ebiptables_driver.c | 1 - src/qemu/qemu_domain.c | 1 - src/remote/remote_daemon_config.c | 2 -- src/security/security_dac.c | 1 - src/security/security_manager.c | 1 - src/storage/storage_file_fs.c | 1 - src/util/vircgroupv1.c | 1 - src/util/vircgroupv2.c | 1 - src/util/virnetdev.c | 1 - src/util/virnetdevip.c | 1 - src/util/virnetdevmacvlan.c | 2 -- src/util/virnetdevvportprofile.c | 2 -- src/util/virperf.c | 1 - src/util/virpidfile.c | 1 - src/util/virpolkit.c | 1 - src/util/virresctrl.c | 1 - src/util/virutil.h | 1 + tests/eventtest.c | 1 - tests/objecteventtest.c | 2 -- tests/scsihosttest.c | 1 - tests/vboxsnapshotxmltest.c | 1 - tests/virfiletest.c | 1 - tests/virfilewrapper.c | 1 - tests/virlockspacetest.c | 1 - tests/virnetdaemontest.c | 2 -- tests/virnetsockettest.c | 1 - tests/virnettlscontexttest.c | 1 - tests/virnettlshelpers.c | 1 - tests/virnettlssessiontest.c | 1 - tests/virscsitest.c | 1 - tests/virstoragetest.c | 1 - 39 files changed, 1 insertion(+), 48 deletions(-) diff --git a/src/conf/virnwfilterbindingobj.c b/src/conf/virnwfilterbindingobj.c index 56a9022fc5..68afb9c434 100644 --- a/src/conf/virnwfilterbindingobj.c +++ b/src/conf/virnwfilterbindingobj.c @@ -20,8 +20,6 @@ #include <config.h> -#include <unistd.h> - #include "viralloc.h" #include "virerror.h" #include "virstring.h" diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 935d3d86b9..287406d323 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -21,7 +21,6 @@ #include <config.h> #include <fcntl.h> -#include <unistd.h> #include "libxl_domain.h" #include "libxl_capabilities.h" diff --git a/src/locking/lock_daemon_config.c b/src/locking/lock_daemon_config.c index 9dc3d6e409..03feeb02a5 100644 --- a/src/locking/lock_daemon_config.c +++ b/src/locking/lock_daemon_config.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "lock_daemon_config.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/locking/lock_driver_lockd.c b/src/locking/lock_driver_lockd.c index 335180dafa..f6371f3050 100644 --- a/src/locking/lock_driver_lockd.c +++ b/src/locking/lock_driver_lockd.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "lock_driver.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_config.c index 626ef15403..ec6d0686f4 100644 --- a/src/logging/log_daemon_config.c +++ b/src/logging/log_daemon_config.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "log_daemon_config.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/lxc/lxc_conf.c b/src/lxc/lxc_conf.c index a6be352b22..2e4cc4f51a 100644 --- a/src/lxc/lxc_conf.c +++ b/src/lxc/lxc_conf.c @@ -23,8 +23,6 @@ /* includes */ #include <config.h> -#include "unistd.h" - #include "lxc_conf.h" #include "lxc_domain.h" #include "virerror.h" diff --git a/src/lxc/lxc_fuse.c b/src/lxc/lxc_fuse.c index b647743206..4137d1b04f 100644 --- a/src/lxc/lxc_fuse.c +++ b/src/lxc/lxc_fuse.c @@ -23,7 +23,6 @@ #include <fcntl.h> #include <sys/mount.h> #include <mntent.h> -#include <unistd.h> #include "lxc_fuse.h" #include "lxc_cgroup.h" diff --git a/src/network/leaseshelper.c b/src/network/leaseshelper.c index af71e32499..4c23a55326 100644 --- a/src/network/leaseshelper.c +++ b/src/network/leaseshelper.c @@ -23,7 +23,6 @@ #include <config.h> -#include <unistd.h> #include "virthread.h" #include "virfile.h" diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 424daeb3c7..32bbf6d05c 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -25,7 +25,6 @@ #include <sys/stat.h> #include <fcntl.h> #include <sys/utsname.h> -#include <unistd.h> #include "internal.h" diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 58029ab20c..f0bf1aa4fe 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -64,7 +64,6 @@ #endif #include <sys/time.h> #include <fcntl.h> -#include <unistd.h> #if defined(HAVE_SYS_MOUNT_H) # include <sys/mount.h> #endif diff --git a/src/remote/remote_daemon_config.c b/src/remote/remote_daemon_config.c index 59f14bdbdc..a56aa9065a 100644 --- a/src/remote/remote_daemon_config.c +++ b/src/remote/remote_daemon_config.c @@ -21,8 +21,6 @@ #include <config.h> -#include <unistd.h> - #include "remote_daemon_config.h" #include "virconf.h" #include "viralloc.h" diff --git a/src/security/security_dac.c b/src/security/security_dac.c index 5718557411..6f8ca8cd54 100644 --- a/src/security/security_dac.c +++ b/src/security/security_dac.c @@ -22,7 +22,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #ifdef __FreeBSD__ # include <sys/sysctl.h> diff --git a/src/security/security_manager.c b/src/security/security_manager.c index 9bcd8f85ab..74ab0d0dd3 100644 --- a/src/security/security_manager.c +++ b/src/security/security_manager.c @@ -22,7 +22,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #include "security_driver.h" #include "security_stack.h" diff --git a/src/storage/storage_file_fs.c b/src/storage/storage_file_fs.c index 1570170d0e..8817970f44 100644 --- a/src/storage/storage_file_fs.c +++ b/src/storage/storage_file_fs.c @@ -23,7 +23,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #include "virerror.h" #include "storage_file_fs.h" diff --git a/src/util/vircgroupv1.c b/src/util/vircgroupv1.c index 7482b96a27..6224072db0 100644 --- a/src/util/vircgroupv1.c +++ b/src/util/vircgroupv1.c @@ -21,7 +21,6 @@ #include <config.h> #ifdef __linux__ -# include <unistd.h> # include <mntent.h> # include <sys/stat.h> # include <sys/mount.h> diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c index 3264bff014..940ee58528 100644 --- a/src/util/vircgroupv2.c +++ b/src/util/vircgroupv2.c @@ -20,7 +20,6 @@ #include <config.h> #ifdef __linux__ -# include <unistd.h> # include <mntent.h> # include <sys/mount.h> #endif /* __linux__ */ diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 8e098b3634..5c0e9723b9 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -35,7 +35,6 @@ #include <sys/ioctl.h> #include <net/if.h> #include <fcntl.h> -#include <unistd.h> #ifdef __linux__ # include <linux/sockios.h> diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 7fc500007f..e2009fd829 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -36,7 +36,6 @@ #include <sys/ioctl.h> #include <net/if.h> #include <fcntl.h> -#include <unistd.h> #ifdef __linux__ # include <linux/sockios.h> diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index e916ba0a0a..c80a3a381f 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -24,8 +24,6 @@ #include <config.h> -#include <unistd.h> - #include "virnetdevmacvlan.h" #include "virmacaddr.h" #include "virerror.h" diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c index b30204fe7f..fb05190c02 100644 --- a/src/util/virnetdevvportprofile.c +++ b/src/util/virnetdevvportprofile.c @@ -18,8 +18,6 @@ #include <config.h> -#include <unistd.h> - #include "virnetdevvportprofile.h" #include "virerror.h" #include "viralloc.h" diff --git a/src/util/virperf.c b/src/util/virperf.c index 9bde5c1246..6ecfc29cb2 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -17,7 +17,6 @@ */ #include <config.h> -#include <unistd.h> #include <sys/ioctl.h> #if defined HAVE_SYS_SYSCALL_H # include <sys/syscall.h> diff --git a/src/util/virpidfile.c b/src/util/virpidfile.c index a6ee6e1f4b..999bccbee4 100644 --- a/src/util/virpidfile.c +++ b/src/util/virpidfile.c @@ -26,7 +26,6 @@ #include <fcntl.h> #include <signal.h> #include <sys/stat.h> -#include <unistd.h> #include "virpidfile.h" #include "virfile.h" diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 5c94ae346b..198439cea2 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -21,7 +21,6 @@ #include <config.h> #include <poll.h> -#include <unistd.h> #include "virpolkit.h" #include "virerror.h" diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index e495233110..9e477fc064 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -22,7 +22,6 @@ #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> -#include <unistd.h> #define LIBVIRT_VIRRESCTRLPRIV_H_ALLOW #include "virresctrlpriv.h" diff --git a/src/util/virutil.h b/src/util/virutil.h index 477d70554b..ded9b039e5 100644 --- a/src/util/virutil.h +++ b/src/util/virutil.h @@ -24,6 +24,7 @@ # define LIBVIRT_VIRUTIL_H # include "internal.h" +# include <unistd.h> # include <sys/types.h> # ifndef MIN diff --git a/tests/eventtest.c b/tests/eventtest.c index 37166253cc..df7570bac6 100644 --- a/tests/eventtest.c +++ b/tests/eventtest.c @@ -22,7 +22,6 @@ #include <signal.h> #include <time.h> -#include <unistd.h> #if HAVE_MACH_CLOCK_ROUTINES # include <mach/clock.h> diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c index b53763bc1d..9ba082d353 100644 --- a/tests/objecteventtest.c +++ b/tests/objecteventtest.c @@ -19,8 +19,6 @@ #include <config.h> -#include <unistd.h> - #include "testutils.h" #include "virerror.h" diff --git a/tests/scsihosttest.c b/tests/scsihosttest.c index 01cd77462b..6989e4fc4a 100644 --- a/tests/scsihosttest.c +++ b/tests/scsihosttest.c @@ -25,7 +25,6 @@ # include <fcntl.h> # include <sys/stat.h> -# include <unistd.h> # include "virstring.h" # include "virerror.h" # include "virlog.h" diff --git a/tests/vboxsnapshotxmltest.c b/tests/vboxsnapshotxmltest.c index 2f815a2bca..c70d7ab100 100644 --- a/tests/vboxsnapshotxmltest.c +++ b/tests/vboxsnapshotxmltest.c @@ -5,7 +5,6 @@ #ifdef WITH_VBOX # include <regex.h> -# include <unistd.h> # include "vbox/vbox_snapshot_conf.h" # define VIR_FROM_THIS VIR_FROM_NONE diff --git a/tests/virfiletest.c b/tests/virfiletest.c index 6e4805b42d..e2bd4953ed 100644 --- a/tests/virfiletest.c +++ b/tests/virfiletest.c @@ -19,7 +19,6 @@ #include <config.h> #include <fcntl.h> -#include <unistd.h> #include "testutils.h" #include "virfile.h" diff --git a/tests/virfilewrapper.c b/tests/virfilewrapper.c index f4d077d608..067cb30657 100644 --- a/tests/virfilewrapper.c +++ b/tests/virfilewrapper.c @@ -21,7 +21,6 @@ #ifndef WIN32 # include <fcntl.h> -# include <unistd.h> # include "viralloc.h" # include "virfile.h" diff --git a/tests/virlockspacetest.c b/tests/virlockspacetest.c index 4dd485bc0e..991e587db6 100644 --- a/tests/virlockspacetest.c +++ b/tests/virlockspacetest.c @@ -20,7 +20,6 @@ #include <signal.h> #include <sys/stat.h> -#include <unistd.h> #include "testutils.h" #include "virutil.h" diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c index d7b9db6641..3e9b007d9b 100644 --- a/tests/virnetdaemontest.c +++ b/tests/virnetdaemontest.c @@ -18,8 +18,6 @@ #include <config.h> -#include <unistd.h> - #include "testutils.h" #include "virerror.h" #include "rpc/virnetdaemon.h" diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index a7990ee5f3..9c14989287 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -23,7 +23,6 @@ # include <ifaddrs.h> #endif #include <netdb.h> -#include <unistd.h> #include "testutils.h" #include "virutil.h" diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index b94275b943..07910c2749 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -20,7 +20,6 @@ #include <fcntl.h> #include <sys/socket.h> -#include <unistd.h> #include "testutils.h" #include "virnettlshelpers.h" diff --git a/tests/virnettlshelpers.c b/tests/virnettlshelpers.c index dfb747b45d..a6aacf4cc3 100644 --- a/tests/virnettlshelpers.c +++ b/tests/virnettlshelpers.c @@ -20,7 +20,6 @@ #include <fcntl.h> #include <sys/socket.h> -#include <unistd.h> #include "virnettlshelpers.h" #include "viralloc.h" diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c index 153c8929ed..41abbe7eaf 100644 --- a/tests/virnettlssessiontest.c +++ b/tests/virnettlssessiontest.c @@ -20,7 +20,6 @@ #include <fcntl.h> #include <sys/socket.h> -#include <unistd.h> #include "testutils.h" #include "virnettlshelpers.h" diff --git a/tests/virscsitest.c b/tests/virscsitest.c index 75c7be5822..be3ef6234e 100644 --- a/tests/virscsitest.c +++ b/tests/virscsitest.c @@ -19,7 +19,6 @@ #include <config.h> -#include <unistd.h> #include "virscsi.h" #include "testutils.h" diff --git a/tests/virstoragetest.c b/tests/virstoragetest.c index d20559a636..4f23511240 100644 --- a/tests/virstoragetest.c +++ b/tests/virstoragetest.c @@ -18,7 +18,6 @@ #include <config.h> -#include <unistd.h> #include "testutils.h" #include "vircommand.h" -- 2.20.1

1 0

[libvirt] [jenkins-ci PATCH] Fix host list for osinfo-db-tools-check
by Andrea Bolognani 10 Apr '19

10 Apr '19

Commit e423182b4528 updated the host list for the job, but got things slightly wrong in that it included libvirt-debian-sid, libvirt-freebsd-current and libvirt-ubuntu-18 in the Jenkins configuration rather than the Ansible one. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as a trivial fix. guests/playbooks/build/projects/osinfo-db-tools.yml | 3 +++ jenkins/projects/osinfo-db-tools.yaml | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/playbooks/build/projects/osinfo-db-tools.yml b/guests/playbooks/build/projects/osinfo-db-tools.yml index e33ea7a..27f6cc4 100644 --- a/guests/playbooks/build/projects/osinfo-db-tools.yml +++ b/guests/playbooks/build/projects/osinfo-db-tools.yml @@ -14,11 +14,14 @@ # CentOS 7; machines: - libvirt-debian-9 + - libvirt-debian-sid - libvirt-fedora-28 - libvirt-fedora-29 - libvirt-fedora-rawhide - libvirt-freebsd-11 - libvirt-freebsd-12 + - libvirt-freebsd-current + - libvirt-ubuntu-18 - include: '{{ playbook_base }}/jobs/autotools-rpm-job.yml' vars: machines: '{{ rpm_machines }}' diff --git a/jenkins/projects/osinfo-db-tools.yaml b/jenkins/projects/osinfo-db-tools.yaml index 9f738b6..de96bb5 100644 --- a/jenkins/projects/osinfo-db-tools.yaml +++ b/jenkins/projects/osinfo-db-tools.yaml @@ -16,14 +16,11 @@ # CentOS 7; machines: - libvirt-debian-9 - - libvirt-debian-sid - libvirt-fedora-28 - libvirt-fedora-29 - libvirt-fedora-rawhide - libvirt-freebsd-11 - libvirt-freebsd-12 - - libvirt-freebsd-current - - libvirt-ubuntu-18 - autotools-rpm-job: parent_jobs: 'osinfo-db-tools-check' machines: '{rpm_machines}' -- 2.20.1

1 0

[libvirt] [PATCH 0/2] drop QEMU_CAPS*KQEMU
by Ján Tomko 10 Apr '19

10 Apr '19

Ján Tomko (2): Delete QEMU_CAPS_KQEMU and QEMU_CAPS_ENABLE_KQEMU fixup: regroup QEMU capabilities src/qemu/qemu_capabilities.c | 248 +++++++++++++++++------------------ src/qemu/qemu_capabilities.h | 248 +++++++++++++++++------------------ 2 files changed, 246 insertions(+), 250 deletions(-) -- 2.19.2

2 3

[libvirt] [jenkins-ci PATCH 0/7] Update libosinfo/osinfo-db-tools dependencies
by Fabiano Fidêncio 10 Apr '19

10 Apr '19

This patch set updates both libosinfo and osinfo-db-tools deps. The changes done are, basically: libosinfo: - drop gnome-common - drop intltool osinfo-db-tools: - drop gnome-common - drop intltool - add python3 - add python3-pytest - add python3-requests Together with those changes: - gnome-common has been dropped from the mappings as the only consumers were libosinfo and osinfo-db-tools. - `make check` is not ran for CentOS 7 anymore, as the osinfo-db-tools testes depend on python3. Fabiano Fidêncio (7): guests: Drop gnome-common libosinfo's dependency guests: Drop gnome-common osinfo-db-tools' dependency guests: Remove unused "gnome-common" mapping guests: Drop intltool libosinfo's dependency guests: Drop intltool osinfo-db-tools' dependency guests: Update test dependencies for osinfo-db-tools Stop running `make check` against osinfo-db-tools on CentOS 7 guests/playbooks/build/projects/osinfo-db-tools.yml | 10 ++++++++++ guests/vars/mappings.yml | 3 --- guests/vars/projects/libosinfo.yml | 2 -- guests/vars/projects/osinfo-db-tools.yml | 5 +++-- jenkins/projects/osinfo-db-tools.yaml | 12 ++++++++++++ 5 files changed, 25 insertions(+), 7 deletions(-) -- 2.20.1

2 9

[libvirt] [PATCH] vmx: Define VMX_CONFIG_FORMAT_ARGV to replace vmware/esx argv str
by Han Han 10 Apr '19

10 Apr '19

Signed-off-by: Han Han <hhan(a)redhat.com> --- src/esx/esx_driver.c | 4 ++-- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.h | 2 ++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 08d33b6f3b..d80fef0a58 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -2710,7 +2710,7 @@ esxConnectDomainXMLFromNative(virConnectPtr conn, const char *nativeFormat, memset(&data, 0, sizeof(data)); - if (STRNEQ(nativeFormat, "vmware-vmx")) { + if (STRNEQ(nativeFormat, VMX_CONFIG_FORMAT_ARGV)) { virReportError(VIR_ERR_INVALID_ARG, _("Unsupported config format '%s'"), nativeFormat); return NULL; @@ -2755,7 +2755,7 @@ esxConnectDomainXMLToNative(virConnectPtr conn, const char *nativeFormat, memset(&data, 0, sizeof(data)); - if (STRNEQ(nativeFormat, "vmware-vmx")) { + if (STRNEQ(nativeFormat, VMX_CONFIG_FORMAT_ARGV)) { virReportError(VIR_ERR_INVALID_ARG, _("Unsupported config format '%s'"), nativeFormat); return NULL; diff --git a/src/vmware/vmware_driver.c b/src/vmware/vmware_driver.c index f4b0989afd..1bc8a06c39 100644 --- a/src/vmware/vmware_driver.c +++ b/src/vmware/vmware_driver.c @@ -956,7 +956,7 @@ vmwareConnectDomainXMLFromNative(virConnectPtr conn, const char *nativeFormat, virCheckFlags(0, NULL); - if (STRNEQ(nativeFormat, "vmware-vmx")) { + if (STRNEQ(nativeFormat, VMX_CONFIG_FORMAT_ARGV)) { virReportError(VIR_ERR_INVALID_ARG, _("Unsupported config format '%s'"), nativeFormat); return NULL; diff --git a/src/vmx/vmx.h b/src/vmx/vmx.h index cb99e84d18..8c068b4cb2 100644 --- a/src/vmx/vmx.h +++ b/src/vmx/vmx.h @@ -26,6 +26,8 @@ # include "virconf.h" # include "domain_conf.h" +# define VMX_CONFIG_FORMAT_ARGV "vmware-vmx" + typedef struct _virVMXContext virVMXContext; virDomainXMLOptionPtr virVMXDomainXMLConfInit(void); -- 2.20.1

2 2

[libvirt] [PATCH] build-aux: ensure all scripts are included in EXTRA_DIST
by Daniel P. Berrangé 09 Apr '19

09 Apr '19

Few of the scripts in build-aux are included in EXTRA_DIST. This is not a serious problem since they are primarily tools intended for developers upstream, and downstream builds won't need them. Having them missing, however, complicates downstream patching because it means patches that are auto-exported from git will fail to apply if they include a change to a file in build-aux/. By bundling all these scripts in the dist we make patching more straightforward. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Makefile.am | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 621e9b4f89..eba5916352 100644 --- a/Makefile.am +++ b/Makefile.am @@ -40,7 +40,17 @@ EXTRA_DIST = \ cfg.mk \ run.in \ README.md \ - AUTHORS.in + AUTHORS.in \ + build-aux/augeas-gentest.pl \ + build-aux/check-spacing.pl \ + build-aux/gitlog-to-changelog \ + build-aux/header-ifdef.pl \ + build-aux/minimize-po.pl \ + build-aux/mock-noinline.pl \ + build-aux/prohibit-duplicate-header.pl \ + build-aux/useless-if-before-free \ + build-aux/vc-list-files \ + $(NULL) pkgconfigdir = $(libdir)/pkgconfig pkgconfig_DATA = libvirt.pc libvirt-qemu.pc libvirt-lxc.pc libvirt-admin.pc -- 2.20.1

2 1

[libvirt] [PATCH v1 0/4] domain capabilities: Expose firmware auto selection feature
by Michal Privoznik 09 Apr '19

09 Apr '19

Motivated by discussion with Pino and others. Michal Prívozník (4): qemu_firmware: Separate firmware loading into a function qemu_firmware: Separate machine and arch matching into a function qemu_firmware: Introduce qemuFirmwareGetSupported domain capabilities: Expose firmware auto selection feature docs/formatdomaincaps.html.in | 14 ++ docs/schemas/domaincaps.rng | 3 + src/conf/domain_capabilities.c | 2 + src/conf/domain_capabilities.h | 1 + src/qemu/qemu_capabilities.c | 23 ++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 1 + src/qemu/qemu_firmware.c | 149 ++++++++++++++---- src/qemu/qemu_firmware.h | 9 ++ tests/Makefile.am | 4 +- .../qemu_1.7.0.x86_64.xml | 4 + .../qemu_2.12.0-virt.aarch64.xml | 3 + .../qemu_2.12.0.ppc64.xml | 1 + .../qemu_2.12.0.s390x.xml | 1 + .../qemu_2.12.0.x86_64.xml | 4 + .../qemu_2.6.0-virt.aarch64.xml | 3 + .../qemu_2.6.0.aarch64.xml | 1 + .../domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + .../qemu_2.6.0.x86_64.xml | 4 + .../domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + .../qemu_2.8.0-tcg.x86_64.xml | 4 + .../domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + .../qemu_2.8.0.x86_64.xml | 4 + .../qemu_2.9.0-q35.x86_64.xml | 4 + .../qemu_2.9.0-tcg.x86_64.xml | 4 + .../qemu_2.9.0.x86_64.xml | 4 + .../domaincapsschemadata/qemu_3.0.0.s390x.xml | 1 + .../qemu_4.0.0.x86_64.xml | 4 + tests/domaincapstest.c | 16 ++ tests/qemufirmwaretest.c | 58 +++++++ 30 files changed, 295 insertions(+), 35 deletions(-) -- 2.21.0

3 8

[libvirt] [PATCH] rpc: Refactor cleanup paths in virNetLibsshAuthenticatePassword
by Peter Krempa 09 Apr '19

09 Apr '19

Now that the memory disposal is handled automatically we can simplify the cleanup paths. In this case it's not as simple as sometimes the value of the called function is returned. While at it fix the initialization value of the returned variable. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/rpc/virnetlibsshsession.c | 33 ++++++++++++--------------------- 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/src/rpc/virnetlibsshsession.c b/src/rpc/virnetlibsshsession.c index b9143239b9..9bf25c9caa 100644 --- a/src/rpc/virnetlibsshsession.c +++ b/src/rpc/virnetlibsshsession.c @@ -606,25 +606,22 @@ virNetLibsshAuthenticatePassword(virNetLibsshSessionPtr sess, virNetLibsshAuthMethodPtr priv) { const char *errmsg; - int ret = -1; + int rc = SSH_AUTH_ERROR; VIR_DEBUG("sess=%p", sess); if (priv->password) { /* tunelled password authentication */ - if ((ret = ssh_userauth_password(sess->session, NULL, - priv->password)) == 0) { - ret = SSH_AUTH_SUCCESS; - goto cleanup; - } + if ((rc = ssh_userauth_password(sess->session, NULL, + priv->password)) == 0) + return SSH_AUTH_SUCCESS; } else { /* password authentication with interactive password request */ if (!sess->cred || !sess->cred->cb) { virReportError(VIR_ERR_LIBSSH, "%s", _("Can't perform authentication: " "Authentication callback not provided")); - ret = SSH_AUTH_ERROR; - goto cleanup; + return SSH_AUTH_ERROR; } /* Try the authenticating the set amount of times. The server breaks the @@ -634,19 +631,15 @@ virNetLibsshAuthenticatePassword(virNetLibsshSessionPtr sess, if (!(password = virAuthGetPasswordPath(sess->authPath, sess->cred, "ssh", sess->username, - sess->hostname))) { - ret = SSH_AUTH_ERROR; - goto cleanup; - } + sess->hostname))) + return SSH_AUTH_ERROR; /* tunelled password authentication */ - if ((ret = ssh_userauth_password(sess->session, NULL, - password)) == 0) { - ret = SSH_AUTH_SUCCESS; - goto cleanup; - } + if ((rc = ssh_userauth_password(sess->session, NULL, + password)) == 0) + return SSH_AUTH_SUCCESS; - if (ret != SSH_AUTH_DENIED) + if (rc != SSH_AUTH_DENIED) break; } } @@ -655,9 +648,7 @@ virNetLibsshAuthenticatePassword(virNetLibsshSessionPtr sess, errmsg = ssh_get_error(sess->session); virReportError(VIR_ERR_AUTH_FAILED, _("authentication failed: %s"), errmsg); - - cleanup: - return ret; + return rc; } /* perform keyboard interactive authentication -- 2.20.1

2 1

[libvirt] [PATCH 0/6] readline: Drop obsolete code, add pkg-config support
by Andrea Bolognani 09 Apr '19

09 Apr '19

This series drops a bunch of compatibility code that's no longer necessary to support our target platforms and introduces support for getting readline's CFLAGS and LIBS via pkg-config, which in turn makes it possible to automatically enable the feature on FreeBSD. There are a couple of caveats: * while most of the existing kludges are dropped, a new one had to be introduced :( The upsides are that the new kludge is small and straightforward, and that there's an expiration date on it already, since a patch making it unnecessary has already been provided for upstream readline; * autodetection on macOS still doesn't work because of a downstream packaging issue, but that's not any worse than the current situation anyway. Andrea Bolognani (6): tools: vsh: Drop obsolete readline compatibility code m4: readline: Extract code setting -D_FUNCTION_DEF m4: readline: Stop looking for rl_completion_quote_character() m4: readline: Drop extra_LIBS machinery m4: readline: Use pkg-config m4: readline: Add gross kludge for include path m4/virt-readline.m4 | 68 ++++++++++++++++++++++----------------------- tools/vsh.c | 17 ------------ 2 files changed, 33 insertions(+), 52 deletions(-) -- 2.20.1

1 7

[libvirt] [PATCH v2 0/6] lxc: Add suport to virConnectGetAllDomainStats
by Julio Faracco 09 Apr '19

09 Apr '19

This series has a collection of new methods to enable support for virConnectGetAllDomainStats() to LXC driver. The only difference is Disk Stats. It needs to consider only the host file system operations as a valid block device. So, other disks should start with index 1..N. Other difference is an implementation of Kernel Memory CGroup to grab this info from each LXC container. - v1-v2: Added suggestions made by Peter Krempa. Julio Faracco (6): lxc: Introduce method lxcConnectGetAllDomainStats lxc: Introduce method lxcDomainGetStats lxc: Introduce method lxcDomainGetStatsCpu lxc: Introduce method lxcDomainGetStatsBlock cgroup: Get kernel memory entry from CGroup V1 lxc: Introduce method lxcDomainGetBalloonStats src/libvirt_private.syms | 2 + src/lxc/lxc_driver.c | 391 ++++++++++++++++++++++++++++++++++++ src/util/vircgroup.c | 32 +++ src/util/vircgroup.h | 2 + src/util/vircgroupbackend.h | 10 + src/util/vircgroupv1.c | 36 ++++ 6 files changed, 473 insertions(+) -- 2.19.1

2 7

[libvirt] [PATCH] cpu_map: rename x86_EPYC-IBRS file to x86_EPYC-IBPB
by Pavel Hrdina 09 Apr '19

09 Apr '19

The later is the correct CPU model name. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under trivial rule. And yes, there is a typo s/later/latter/. src/cpu_map/Makefile.inc.am | 2 +- src/cpu_map/index.xml | 2 +- src/cpu_map/{x86_EPYC-IBRS.xml => x86_EPYC-IBPB.xml} | 0 3 files changed, 2 insertions(+), 2 deletions(-) rename src/cpu_map/{x86_EPYC-IBRS.xml => x86_EPYC-IBPB.xml} (100%) diff --git a/src/cpu_map/Makefile.inc.am b/src/cpu_map/Makefile.inc.am index 9eeb33e4be..9d7cef15c5 100644 --- a/src/cpu_map/Makefile.inc.am +++ b/src/cpu_map/Makefile.inc.am @@ -22,7 +22,7 @@ cpumap_DATA = \ cpu_map/x86_cpu64-rhel5.xml \ cpu_map/x86_cpu64-rhel6.xml \ cpu_map/x86_EPYC.xml \ - cpu_map/x86_EPYC-IBRS.xml \ + cpu_map/x86_EPYC-IBPB.xml \ cpu_map/x86_Haswell.xml \ cpu_map/x86_Haswell-IBRS.xml \ cpu_map/x86_Haswell-noTSX.xml \ diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml index dccda3919d..130a17a353 100644 --- a/src/cpu_map/index.xml +++ b/src/cpu_map/index.xml @@ -58,7 +58,7 @@ <include filename="x86_Opteron_G4.xml"/> <include filename="x86_Opteron_G5.xml"/> <include filename="x86_EPYC.xml"/> - <include filename="x86_EPYC-IBRS.xml"/> + <include filename="x86_EPYC-IBPB.xml"/> </arch> <arch name='ppc64'> diff --git a/src/cpu_map/x86_EPYC-IBRS.xml b/src/cpu_map/x86_EPYC-IBPB.xml similarity index 100% rename from src/cpu_map/x86_EPYC-IBRS.xml rename to src/cpu_map/x86_EPYC-IBPB.xml -- 2.20.1

1 0

[libvirt] [PATCH 0/3] Replace vmware/esx argv string to VMX_CONFIG_FORMAT_ARGV
by Han Han 09 Apr '19

09 Apr '19

Han Han (3): vmx: Define macro VMX_CONFIG_FORMAT_ARGV for vmware-vmx esx: Use VMX_CONFIG_FORMAT_ARGV for esx naive argv vmware: Use VMX_CONFIG_FORMAT_ARGV for vmware naive argv src/esx/esx_driver.c | 4 ++-- src/vmware/vmware_conf.c | 2 +- src/vmware/vmware_driver.c | 2 +- src/vmx/vmx.h | 2 ++ 4 files changed, 6 insertions(+), 4 deletions(-) -- 2.20.1

2 5

[libvirt] [PATCH] util: Fix uninitalized variable to avoid garbage
by Julio Faracco 09 Apr '19

09 Apr '19

This commit fixes an unitialized variable to avoid garbage value when virNetDevBridgeGet method returns error. When, that method fails before initialize 'val' variable, it can cause problems related to that. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/util/virnetdevbridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetdevbridge.c b/src/util/virnetdevbridge.c index 8d2d8bfc86..0f301d9216 100644 --- a/src/util/virnetdevbridge.c +++ b/src/util/virnetdevbridge.c @@ -760,7 +760,7 @@ int virNetDevBridgeGetSTP(const char *brname, bool *enabled) { int ret = -1; - unsigned long val; + unsigned long val = 0; ret = virNetDevBridgeGet(brname, "stp_state", &val); *enabled = val ? true : false; -- 2.19.1

2 1