- Devel - libvirt List Archives

[libvirt] [PATCH 1/2] test_driver: implement virConnectDomainXMLToNative
by Ilias Stamatis 10 Jun '19

10 Jun '19

Since this is the test driver, we can pretend that the native hypervisor representation is the same as libvirt's domain XML. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 1aa79ce898..ec1d3cacbc 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1563,6 +1563,39 @@ static int testConnectNumOfDomains(virConnectPtr conn) return count; } + +# define TEST_CONFIG_FORMAT_ARGV "test-test" + + +static char *testConnectDomainXMLToNative(virConnectPtr conn, + const char *format, + const char *dxml, + unsigned int flags) +{ + char *ret = NULL; + virDomainDefPtr def = NULL; + testDriverPtr privconn = conn->privateData; + + virCheckFlags(0, NULL); + + if (STRNEQ(format, TEST_CONFIG_FORMAT_ARGV)) { + virReportError(VIR_ERR_INVALID_ARG, + _("Unsupported config format '%s'"), format); + return NULL; + } + + if ((def = virDomainDefParseString(dxml, privconn->caps, privconn->xmlopt, NULL, + VIR_DOMAIN_DEF_PARSE_INACTIVE)) == NULL) + goto cleanup; + + ret = virDomainDefFormat(def, privconn->caps, 0); + + cleanup: + virDomainDefFree(def); + return ret; +} + + static int testDomainIsActive(virDomainPtr dom) { virDomainObjPtr obj; @@ -6998,6 +7031,7 @@ static virHypervisorDriver testHypervisorDriver = { .connectGetType = testConnectGetType, /* 2.3.0 */ .connectListDomains = testConnectListDomains, /* 0.1.1 */ .connectNumOfDomains = testConnectNumOfDomains, /* 0.1.1 */ + .connectDomainXMLToNative = testConnectDomainXMLToNative, /* 5.5.0 */ .connectListAllDomains = testConnectListAllDomains, /* 0.9.13 */ .domainCreateXML = testDomainCreateXML, /* 0.1.4 */ .domainLookupByID = testDomainLookupByID, /* 0.1.1 */ -- 2.21.0

1 1

[libvirt] [PATCH] qemu: check if numa cell's cpu range match with cpu topology count
by Maxiwell S. Garcia 10 Jun '19

10 Jun '19

If the XML doesn't have numa cells, this check is not necessary. But if numa cells are present, it must match with cpu topology count. Signed-off-by: Maxiwell S. Garcia <maxiwell(a)linux.ibm.com> --- src/qemu/qemu_domain.c | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 4d3a8868b2..ab81b9a5be 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4173,15 +4173,24 @@ qemuDomainDefValidate(const virDomainDef *def, if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS)) { unsigned int topologycpus; unsigned int granularity; + unsigned int numacpus; /* Starting from QEMU 2.5, max vCPU count and overall vCPU topology * must agree. We only actually enforce this with QEMU 2.7+, due * to the capability check above */ - if (virDomainDefGetVcpusTopology(def, &topologycpus) == 0 && - topologycpus != virDomainDefGetVcpusMax(def)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("CPU topology doesn't match maximum vcpu count")); - goto cleanup; + if (virDomainDefGetVcpusTopology(def, &topologycpus) == 0) { + if (topologycpus != virDomainDefGetVcpusMax(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("CPU topology doesn't match maximum vcpu count")); + goto cleanup; + } + + numacpus = virDomainNumaGetCPUCountTotal(def->numa); + if ((numacpus != 0) && (topologycpus != numacpus)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("CPU topology doesn't match numa CPU count")); + goto cleanup; + } } /* vCPU hotplug granularity must be respected */ -- 2.20.1

2 1

[libvirt] [PATCH] Fix regression in lxcOpenNamespace
by Sergei Turchanov 10 Jun '19

10 Jun '19

This fixes regression caused by the 1d39dbaf637db03f6e597ed56b96aa065710b4a1 fdlist[i] erroneously was replaced by fdlist[1] which caused lxcOpenNamespace to return a list with identical elements. --- libvirt-lxc-override.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-lxc-override.c b/libvirt-lxc-override.c index 60c2e48..d7af154 100644 --- a/libvirt-lxc-override.c +++ b/libvirt-lxc-override.c @@ -83,7 +83,7 @@ libvirt_lxc_virDomainLxcOpenNamespace(PyObject *self ATTRIBUTE_UNUSED, goto error; for (i = 0; i < c_retval; i++) - VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[1]), error); + VIR_PY_LIST_APPEND_GOTO(py_retval, libvirt_intWrap(fdlist[i]), error); cleanup: VIR_FREE(fdlist); -- 2.17.1

1 0

[libvirt] [PATCH 00/13] qemu: External disk snapshot code refactors/cleanups (blockdev-add saga)
by Peter Krempa 08 Jun '19

08 Jun '19

Few cleanups to the snapshot code extracted from my blockdev branch. Peter Krempa (13): qemu: snapshot: Pass 'cfg' to external snapshot functions qemu: Use VIR_AUTOPTR in qemuDomainSnapshotCreateDiskActive qemu: Use virErrorPreserveLast in qemuDomainSnapshotCreateDiskActive qemu: Use VIR_AUTO* in qemuDomainSnapshotCreateActiveExternal qemu: snapshot: Remove unused cleanup section in qemuDomainSnapshotCreateSingleDiskActive qemu: snapshot: Always save status and config after qemuDomainSnapshotCreateDiskActive qemu: snapshot: Always save config XML after qemuDomainSnapshotCreateDiskActive qemu: snapshot: Densely pack data in qemuDomainSnapshotDiskDataCollect qemu: snapshot: Move all cleanup of snapshot disk data to qemuDomainSnapshotDiskDataFree qemu: snapshot: Don't overload 'ret' in qemuDomainSnapshotCreateDiskActive qemu: snapshot: Unify 'cleanup' and 'error' in qemuDomainSnapshotCreateDiskActive qemu: snapshot: Return early if there's nothing to snapshot qemu: snapshot: Remove unnecessary 'do_transaction' logic in qemuDomainSnapshotCreateDiskActive src/qemu/qemu_driver.c | 189 +++++++++++++++++------------------------ 1 file changed, 79 insertions(+), 110 deletions(-) -- 2.21.0

2 26

[libvirt] [PATCH 0/4] tests: qemu: Allow QMP schema testing with qemuMonitorTestProcessCommandVerbatim
by Peter Krempa 07 Jun '19

07 Jun '19

Allow more tests to be run against QMP schema checker. Peter Krempa (4): tests: Refactor cleanup in qemuMonitorTestProcessCommandVerbatim tests: qemu: Add QMP schema checking in qemuMonitorTestProcessCommandVerbatim tests: Allow QMP schema testing in qemuMonitorTestNewFromFileFull tests: qemuhotplug: Use schema testing with qemuMonitorTestNewFromFileFull tests/qemucapabilitiestest.c | 3 ++- tests/qemuhotplugtest.c | 21 +++++++++++++++++---- tests/qemumonitortestutils.c | 34 +++++++++++++++++++++++++--------- tests/qemumonitortestutils.h | 3 ++- 4 files changed, 46 insertions(+), 15 deletions(-) -- 2.21.0

2 5

[libvirt] [PATCH 0/2] gitdm: Add gitdm configuration
by Andrea Bolognani 07 Jun '19

07 Jun '19

See the commit message for patch 2/2 for more information; patch 1/2 merely addresses some minor issues in .mailmap that I spotted while working on the gitdm configuration. Andrea Bolognani (2): mailmap: Remove some duplicates gitdm: Add gitdm configuration .mailmap | 4 ++ docs/gitdm/aliases | 25 +++++++++ docs/gitdm/companies/canonical | 11 ++++ docs/gitdm/companies/datto | 2 + docs/gitdm/companies/dreamhost | 4 ++ docs/gitdm/companies/nec | 2 + docs/gitdm/companies/others | 98 ++++++++++++++++++++++++++++++++++ docs/gitdm/companies/redhat | 6 +++ docs/gitdm/companies/suse | 7 +++ docs/gitdm/companies/virtuozzo | 2 + docs/gitdm/groups/education | 17 ++++++ docs/gitdm/groups/opensource | 12 +++++ docs/gitdm/groups/unaffiliated | 83 ++++++++++++++++++++++++++++ gitdm.config | 37 +++++++++++++ 14 files changed, 310 insertions(+) create mode 100644 docs/gitdm/aliases create mode 100644 docs/gitdm/companies/canonical create mode 100644 docs/gitdm/companies/datto create mode 100644 docs/gitdm/companies/dreamhost create mode 100644 docs/gitdm/companies/nec create mode 100644 docs/gitdm/companies/others create mode 100644 docs/gitdm/companies/redhat create mode 100644 docs/gitdm/companies/suse create mode 100644 docs/gitdm/companies/virtuozzo create mode 100644 docs/gitdm/groups/education create mode 100644 docs/gitdm/groups/opensource create mode 100644 docs/gitdm/groups/unaffiliated create mode 100644 gitdm.config -- 2.21.0

2 6

[libvirt] [PATCH] test_driver: implement virDomainSendKey
by Ilias Stamatis 07 Jun '19

07 Jun '19

Validate @keycodes and sleep for @holdtime before successfully returning. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f58a1da95..51ded256be 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -64,6 +64,7 @@ #include "virinterfaceobj.h" #include "virhostcpu.h" #include "virdomainsnapshotobjlist.h" +#include "virkeycode.h" #define VIR_FROM_THIS VIR_FROM_TEST @@ -5980,6 +5981,44 @@ testDomainScreenshot(virDomainPtr dom ATTRIBUTE_UNUSED, return ret; } +static int +testDomainSendKey(virDomainPtr domain, + unsigned int codeset, + unsigned int holdtime, + unsigned int *keycodes, + int nkeycodes, + unsigned int flags) +{ + int ret = -1; + size_t i; + virDomainObjPtr vm = NULL; + + virCheckFlags(0, -1); + + if (!(vm = testDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + for (i = 0; i < nkeycodes; i++) { + if (virKeycodeValueTranslate(codeset, codeset, keycodes[i]) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("invalid keycode %u of %s codeset"), + keycodes[i], + virKeycodeSetTypeToString(codeset)); + goto cleanup; + } + } + + usleep(holdtime * 1000); + ret = 0; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + static int testConnectGetCPUModelNames(virConnectPtr conn ATTRIBUTE_UNUSED, const char *archName, @@ -7000,6 +7039,7 @@ static virHypervisorDriver testHypervisorDriver = { .nodeGetCPUMap = testNodeGetCPUMap, /* 1.0.0 */ .domainRename = testDomainRename, /* 4.1.0 */ .domainScreenshot = testDomainScreenshot, /* 1.0.5 */ + .domainSendKey = testDomainSendKey, /* 5.5.0 */ .domainGetMetadata = testDomainGetMetadata, /* 1.1.3 */ .domainSetMetadata = testDomainSetMetadata, /* 1.1.3 */ .connectGetCPUModelNames = testConnectGetCPUModelNames, /* 1.1.3 */ -- 2.21.0

6 15

[libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML
by Ilias Stamatis 07 Jun '19

07 Jun '19

While implementing virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML for the test driver, I realized that there exists already code for saving and loading test images which can be reused. However, it needed to be extracted from testDomainSaveFlags and testDomainRestoreFlags into separate functions. The new functions are inspired by the corresponding QEMU driver code where e.g. qemuDomainSaveImageOpen serves as a helper used by other functions. This series of patches initially extracts the code mentioned above into separate functions and then provides the test driver with implementations for virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML which make use of the newly introduced functions. Ilias Stamatis (4): test_driver: extract image saving code into a separate function test_driver: extract image loading code into a separate function test_driver: implement virDomainSaveImageDefineXML test_driver: implement virDomainSaveImageGetXMLDesc src/test/test_driver.c | 281 ++++++++++++++++++++++++++++------------- 1 file changed, 193 insertions(+), 88 deletions(-) -- 2.21.0

3 15

[libvirt] [PATCH] qemu: Fix NULL pointer access in qemuProcessInitCpuAffinity()
by Andrea Bolognani 06 Jun '19

06 Jun '19

Commit 2f2254c7f4e5 attempted to fix a memory leak by ensuring cpumapToSet is always a freshly allocated bitmap, but regrettably introduced a NULL pointer access while doing so, because it called virBitmapCopy() without allocating the destination bitmap first. Solve the issue by using virBitmapNewCopy() instead. Reported-by: John Ferlan <jferlan(a)redhat.com> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 42a6271411..50a76aa0ed 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -2498,7 +2498,7 @@ qemuProcessInitCpuAffinity(virDomainObjPtr vm) if (virNumaNodesetToCPUset(nodeset, &cpumapToSet) < 0) return -1; } else if (vm->def->cputune.emulatorpin) { - if (virBitmapCopy(cpumapToSet, vm->def->cputune.emulatorpin) < 0) + if (!(cpumapToSet = virBitmapNewCopy(vm->def->cputune.emulatorpin))) return -1; } else { if (qemuProcessGetAllCpuAffinity(&cpumapToSet) < 0) -- 2.21.0

3 2

[libvirt] [PATCH v2 00/11] Grab modify job for changing domain XML
by Michal Privoznik 06 Jun '19

06 Jun '19

v2 of: https://www.redhat.com/archives/libvir-list/2019-May/msg00858.html diff to v1: - 1/9 from the original series is pushed now. It's independent from the feature. - Acquiring job is done in a way suggested by Nikolay in review of v1. Michal Prívozník (11): virDomainObjListAddObjLocked: Don't expect vm->def to be set virDomainObjListAddLocked: Set vm->def only in success path virDomainObjIsActive: Allow vm->def to be NULL virDomainObjListAdd: Leave def assigning as an exercise for caller virDomainObjListAdd: Remove unused flag qemu: Grab modify job for changing domain XML qemu_domain: Allow qemuDomainObjListAdd to keep job upon return lxc: Grab modify job for changing domain XML lxc_domain: Allow lxcDomainObjListAdd to keep job upon return libxl: Grab modify job for changing domain XML libxl_domain: Allow libxlDomainObjListAdd to keep job upon return src/bhyve/bhyve_driver.c | 10 +++--- src/conf/domain_conf.h | 2 +- src/conf/virdomainobjlist.c | 44 +++++++++--------------- src/conf/virdomainobjlist.h | 6 ++-- src/libxl/libxl_domain.c | 68 +++++++++++++++++++++++++++++++++++++ src/libxl/libxl_domain.h | 8 +++++ src/libxl/libxl_driver.c | 40 +++++----------------- src/libxl/libxl_migration.c | 28 +++------------ src/lxc/lxc_domain.c | 68 +++++++++++++++++++++++++++++++++++++ src/lxc/lxc_domain.h | 8 +++++ src/lxc/lxc_driver.c | 28 ++++++--------- src/openvz/openvz_conf.c | 12 +++---- src/openvz/openvz_driver.c | 17 +++++----- src/qemu/qemu_domain.c | 66 +++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 7 ++++ src/qemu/qemu_driver.c | 43 ++++++++--------------- src/qemu/qemu_migration.c | 7 ++-- src/test/test_driver.c | 21 +++++++----- src/vmware/vmware_conf.c | 4 +-- src/vmware/vmware_driver.c | 9 +++-- src/vz/vz_sdk.c | 4 ++- 21 files changed, 326 insertions(+), 174 deletions(-) -- 2.21.0

3 22

[libvirt] [PATCH 0/2] qemu: Fix leak in qemuProcessInitCpuAffinity()
by Andrea Bolognani 06 Jun '19

06 Jun '19

Spotted by John through Coverity. Andrea Bolognani (2): qemu: Fix leak in qemuProcessInitCpuAffinity() qemu: Drop cleanup label from qemuProcessInitCpuAffinity() src/qemu/qemu_process.c | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) -- 2.21.0

3 7

[libvirt] [PATCH] cpu_conf: Fix XPath for parsing TSC frequency
by Jiri Denemark 06 Jun '19

06 Jun '19

Due to this bug the following command would fail on any host where TSC frequency can be probed: $ virsh capabilities | virsh cpu-baseline /dev/stdin error: unsupported configuration: Invalid TSC frequency https://bugzilla.redhat.com/show_bug.cgi?id=1641702 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/conf/cpu_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index dc46e7f57a..825df88246 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -417,8 +417,8 @@ virCPUDefParseXML(xmlXPathContextPtr ctxt, if (VIR_ALLOC(tsc) < 0) goto cleanup; - if (virXPathULongLong("./counter[@name='tsc']/@frequency", ctxt, - &tsc->frequency) < 0) { + if (virXPathULongLong("string(./counter[@name='tsc']/@frequency)", + ctxt, &tsc->frequency) < 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Invalid TSC frequency")); goto cleanup; -- 2.21.0

2 1

[libvirt] [PATCH 0/3] virsh: undefine: Clarify things around snapshots
by Peter Krempa 05 Jun '19

05 Jun '19

Peter Krempa (3): virsh: undefine: Clarify help string for --snapshots-metadata virsh: undefine: Rename --delete-snapshots to --delete-storage-volume-snapshots virsh: undefine: Clarify that --delete-storage-volume-snapshots causes failures tools/virsh-domain.c | 6 +++++- tools/virsh.pod | 10 ++++++---- 2 files changed, 11 insertions(+), 5 deletions(-) -- 2.21.0

3 6

[libvirt] QMP; unsigned 64-bit ints; JSON standards compliance
by Daniel P. Berrangé 05 Jun '19

05 Jun '19

The QEMU QMP service is based on JSON which is nice because that is a widely supported "standard" data format..... ....except QEMU's implementation (and indeed most impls) are not strictly standards compliant. Specifically the problem is around representing 64-bit integers, whether signed or unsigned. The JSON standard declares that largest integer is 2^53-1 and the likewise the smallest is -(2^53-1): http://www.ecma-international.org/ecma-262/6.0/index.html#sec-number.max_sa… A crazy limit inherited from its javascript origins IIUC. QEMU, and indeed many applications, want to handle 64-bit integers. The C JSON library impls have traditionally mapped integers to the data type 'long long int' which gives a min/max of -(2^63) / 2^63-1. QEMU however /really/ needs 64-bit unsigned integers, ie a max 2^64-1. Libvirt has historically used the YAJL library which uses 'long long int' and thus can't officially go beyond 2^63-1 values. Fortunately it lets libvirt get at the raw json string, so libvirt can re-parse the value to get an 'unsigned long long'. We recently tried to switch to Jansson because YAJL has a dead upstream for many years and countless unanswered bugs & patches. Unfortunately we forgot about this need for 2^64-1 max, and Jansson also uses 'long long int' and raises a fatal parse error for unsigned 64-bit values above 2^63-1. It also provides no backdoor for libvirt todo its own integer parsing. Thus we had to abort our switch to jansson as it broke parsing QEMU's JSON: https://bugzilla.redhat.com/show_bug.cgi?id=1614569 Other JSON libraries we've investigated have similar problems. I imagine the same may well be true of non-C based JOSN impls, though I've not investigated in any detail. Essentially libvirt is stuck with either using the dead YAJL library forever, or writing its own JSON parser (most likely copying QEMU's JSON code into libvirt's git). This feels like a very unappealing situation to be in as not being able to use a JSON library of our choice is loosing one of the key benefits of using a standard data format. Thus I'd like to see a solution to this to allow QMP to be reliably consumed by any JSON library that exists. I can think of some options: 1. Encode unsigned 64-bit integers as signed 64-bit integers. This follows the example that most C libraries map JSON ints to 'long long int'. This is still relying on undefined behaviour as apps don't need to support > 2^53-1. Apps would need to cast back to 'unsigned long long' for those QMP fields they know are supposed to be unsigned. 2. Encode all 64-bit integers as a pair of 32-bit integers. This is fully compliant with the JSON spec as each half is fully within the declared limits. App has to split or assemble the 2 pieces from/to a signed/unsigned 64-bit int as needed. 3. Encode all 64-bit integers as strings The application has todo all parsing/formatting client side. None of these changes are backwards compatible, so I doubt we could make the change transparently in QMP. Instead we would have to have a QMP greeting message capability where the client can request enablement of the enhanced integer handling. Any of the three options above would likely work for libvirt, but I would have a slight preference for either 2 or 3, so that we become 100% standards compliant. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

5 22

[libvirt] [PATCH] tests: Fix parentheses order in an assignment-comparison conditional
by Erik Skultety 04 Jun '19

04 Jun '19

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1717090 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed as trivial. tests/testutilsqemu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index bce847ce5e..9ac9f9bd39 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -918,7 +918,7 @@ testQemuCapsIterate(const char *suffix, if (virDirOpen(&dir, TEST_QEMU_CAPS_PATH) < 0) goto cleanup; - while ((rc = virDirRead(dir, &ent, TEST_QEMU_CAPS_PATH) > 0)) { + while ((rc = virDirRead(dir, &ent, TEST_QEMU_CAPS_PATH)) > 0) { char *tmp = ent->d_name; char *base = NULL; char *archName = NULL; -- 2.20.1

1 0

[libvirt] [PATCH 0/9] Grab modify job for changing domain XML
by Michal Privoznik 04 Jun '19

04 Jun '19

This is an alternative proposal to: https://www.redhat.com/archives/libvir-list/2019-May/msg00830.html The problem I'm trying to fix is described here: https://www.redhat.com/archives/libvir-list/2019-May/msg00810.html Michal Prívozník (9): virDomainObjListAddLocked: Drop useless @cleanup label virDomainObjListAddObjLocked: Don't expect vm->def to be set virDomainObjListAddLocked: Set vm->def only in success path virDomainObjIsActive: Allow vm->def to be NULL virDomainObjListAdd: Leave def assigning as an exercise for caller qemu: Allow vm->def == NULL in job control APIs qemu: Grab modify job for changing domain XML lxc: Grab modify job for changing domain XML libxl: Grab modify job for changing domain XML src/bhyve/bhyve_driver.c | 10 +++++--- src/conf/domain_conf.h | 2 +- src/conf/virdomainobjlist.c | 48 ++++++++++++++---------------------- src/conf/virdomainobjlist.h | 3 +-- src/libxl/libxl_domain.c | 3 ++- src/libxl/libxl_driver.c | 48 ++++++++++++++++++++++++------------ src/libxl/libxl_migration.c | 14 +++++------ src/lxc/lxc_domain.c | 3 ++- src/lxc/lxc_driver.c | 23 +++++++++++------ src/openvz/openvz_conf.c | 12 ++++----- src/openvz/openvz_driver.c | 17 +++++++------ src/qemu/qemu_domain.c | 30 ++++++++++++++--------- src/qemu/qemu_driver.c | 49 ++++++++++++++++++++++++++----------- src/qemu/qemu_migration.c | 13 +++++++--- src/test/test_driver.c | 21 +++++++++------- src/vmware/vmware_conf.c | 4 +-- src/vmware/vmware_driver.c | 9 +++---- src/vz/vz_sdk.c | 4 ++- 18 files changed, 183 insertions(+), 130 deletions(-) -- 2.21.0

2 20

[libvirt] [PATCH 0/4] qemu: Fix qemuProcessInitCpuAffinity()
by Andrea Bolognani 04 Jun '19

04 Jun '19

See detailed explanation in the commit message for patch 1/4 and the corresponding bug report. Andrea Bolognani (4): util: Introduce virBitmapUnion() fixup? util: Optimize virBitmapUnion() util: Introduce virNumaNodesetToCPUset() qemu: Fix qemuProcessInitCpuAffinity() src/libvirt_private.syms | 2 ++ src/qemu/qemu_process.c | 7 ++++- src/util/virbitmap.c | 32 +++++++++++++++++++++++ src/util/virbitmap.h | 4 +++ src/util/virnuma.c | 55 ++++++++++++++++++++++++++++++++++++++++ src/util/virnuma.h | 2 ++ tests/virbitmaptest.c | 37 +++++++++++++++++++++++++++ 7 files changed, 138 insertions(+), 1 deletion(-) -- 2.21.0

3 16

[libvirt] [PATCH] util: Propagate numad failures correctly
by Andrea Bolognani 04 Jun '19

04 Jun '19

Right now, if numad fails, we raise an error but return an empty string to the caller instead of a NULL pointer, which means processing will continue and the user will see # virsh start guest error: Failed to start domain guest error: invalid argument: Failed to parse bitmap '' instead of a more reasonable # virsh start guest error: Failed to start domain guest error: operation failed: Failed to query numad for the advisory nodeset Make sure the user gets a better error message. https://bugzilla.redhat.com/show_bug.cgi?id=1716387 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/util/virnuma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/util/virnuma.c b/src/util/virnuma.c index dd3fb7519e..fee0dfcd5a 100644 --- a/src/util/virnuma.c +++ b/src/util/virnuma.c @@ -66,10 +66,12 @@ virNumaGetAutoPlacementAdvice(unsigned short vcpus, virCommandSetOutputBuffer(cmd, &output); - if (virCommandRun(cmd, NULL) < 0) - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + if (virCommandRun(cmd, NULL) < 0) { + virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("Failed to query numad for the " "advisory nodeset")); + VIR_FREE(output); + } return output; } -- 2.21.0

3 2

[libvirt] [PATCH] news: Drop empty section
by Andrea Bolognani 03 Jun '19

03 Jun '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. docs/news.xml | 2 -- 1 file changed, 2 deletions(-) diff --git a/docs/news.xml b/docs/news.xml index 86f5ffb3f6..f95dfdf3b4 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -56,8 +56,6 @@ </section> </release> <release version="v5.4.0" date="2019-06-03"> - <section title="New features"> - </section> <section title="Security"> <change> <summary> -- 2.21.0

1 0

[libvirt] [PATCH v2 0/7] Check TSC frequency before starting QEMU
by Jiri Denemark 03 Jun '19

03 Jun '19

Version 2: - new patches (1 and 2) fixing qemuargv2xmltest, which was probing host CPU When migrating a domain with invtsc CPU feature enabled, the TSC frequency of the destination host must match the frequency used when the domain was started on the source host or the destination host has to support TSC scaling. If the frequencies do not match and the destination host does not support TSC scaling, QEMU will fail to set the right TSC frequency when starting vCPUs on the destination and thus migration will fail. However, this is quite late since both host might have spent significant time transferring memory and perhaps even storage data. By adding the check to libvirt we can let migration fail before any data starts to be sent over. If for some reason libvirt is unable to detect the host's TSC frequency or scaling support, we'll just let QEMU try and the migration will either succeed or fail later. Luckily, we mandate TSC frequency to be explicitly set in the domain XML to even allow migration of domains with invtsc. We can just check whether the requested frequency is compatible with the current host before starting QEMU. And to let libvirt client decide whether it should even start the migration to a specific host, this series adds host's TSC frequency and scaling support to the host CPU capabilities XML. https://bugzilla.redhat.com/show_bug.cgi?id=1641702 Jiri Denemark (7): qemu: Make virQEMUCapsProbeHostCPUForEmulator more generic qemuargv2xmltest: Use mocked virQEMUCapsProbeHostCPU util: Add virHostCPUGetTscInfo conf: Report TSC frequency in host CPU capabilities cpu_x86: Fix placement of *CheckFeature functions cpu_x86: Probe TSC frequency and scaling support qemu: Check TSC frequency before starting QEMU src/conf/cpu_conf.c | 48 +++++++++++++++++++++ src/conf/cpu_conf.h | 2 + src/cpu/cpu_x86.c | 81 ++++++++++++++++++++---------------- src/qemu/qemu_capabilities.c | 14 +++---- src/qemu/qemu_capspriv.h | 5 +-- src/qemu/qemu_process.c | 53 +++++++++++++++++++++++ src/util/virhostcpu.c | 71 +++++++++++++++++++++++++++++++ src/util/virhostcpu.h | 11 +++++ tests/Makefile.am | 3 +- tests/qemuargv2xmltest.c | 3 +- tests/qemucpumock.c | 5 +-- 11 files changed, 243 insertions(+), 53 deletions(-) -- 2.21.0

2 17

[libvirt] Release of libvirt-5.4.0
by Daniel Veillard 03 Jun '19

03 Jun '19

It's out ! The release is tagged in git, and I provided signed tarball and source rpms to the usual place: https://libvirt.org/sources/ I also cut off a 5.4.0 release of the python bindings but code is same a 5.3.0 one, you can find signed tarball and source rpms at: https://libvirt.org/sources/python/ Main theme of this release is security, there is a set of advisory covered so users are invited to update, along with some improvements and bug fixes. Security: - cpu: Introduce support for the md-clear CPUID bit This bit is set when microcode provides the mechanism to invoke a flush of various exploitable CPU buffers by invoking the x86 VERW instruction. CVE-2018-12126, CVE-2018-12127, CVE-2018-12130, CVE-2019-11091. - Restrict user access to virt-admin, virtlogd and virtlockd The intended users for these facilities are the root user and the libvirtd service respectively, but these restrictions were not enforced correctly. CVE-2019-10132. Improvements: - test driver: Expand API coverage Several APIs that were missing from the test driver have now been implemented. - Avoid unnecessary static linking Most binaries shipped as part of libvirt, for example virtlogd and libvirt_iohelper, were embedding parts of the library even though they also linked against the libvirt.so dynamic library. This is no longer the case, which results in both the disk and memory footprint being reduced. - qemu: Report stat-htlb-pgalloc and stat-htlb-pgfail balloon stats These stats have been introduced in QEMU 3.0. Bug fixes: - qemu: Fix emulator scheduler support Setting the scheduler for QEMU's main thread before QEMU had a chance to start up other threads was misleading as it would affect other threads (vCPU and I/O) as well. In some particular situations this could also lead to an error when the thread for vCPU #0 was being moved to its cpu,cpuacct cgroup. This was fixed so that the scheduler for the main thread is set after QEMU starts. - apparmor: Allow hotplug of vhost-scsi devices Thanks everybody who contributed to this release, be it with bug reports, patches, reviews, docs ... Enjoy ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] maint: Post-release version bump to 5.5.0
by Andrea Bolognani 03 Jun '19

03 Jun '19

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7e01b77fc0..1f05055d6f 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [5.4.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [5.5.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/news.xml b/docs/news.xml index 5d5dfb93aa..699fde7b52 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -39,6 +39,14 @@ --> <libvirt> + <release version="v5.5.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v5.4.0" date="2019-06-03"> <section title="New features"> </section> -- 2.21.0

1 0

[libvirt] [PATCH 0/5] Check TSC frequency before starting QEMU
by Jiri Denemark 03 Jun '19

03 Jun '19

When migrating a domain with invtsc CPU feature enabled, the TSC frequency of the destination host must match the frequency used when the domain was started on the source host or the destination host has to support TSC scaling. If the frequencies do not match and the destination host does not support TSC scaling, QEMU will fail to set the right TSC frequency when starting vCPUs on the destination and thus migration will fail. However, this is quite late since both host might have spent significant time transferring memory and perhaps even storage data. By adding the check to libvirt we can let migration fail before any data starts to be sent over. If for some reason libvirt is unable to detect the host's TSC frequency or scaling support, we'll just let QEMU try and the migration will either succeed or fail later. Luckily, we mandate TSC frequency to be explicitly set in the domain XML to even allow migration of domains with invtsc. We can just check whether the requested frequency is compatible with the current host before starting QEMU. And to let libvirt client decide whether it should even start the migration to a specific host, this series adds host's TSC frequency and scaling support to the host CPU capabilities XML. https://bugzilla.redhat.com/show_bug.cgi?id=1641702 Jiri Denemark (5): util: Add virHostCPUGetTscInfo conf: Report TSC frequency in host CPU capabilities cpu_x86: Fix placement of *CheckFeature functions cpu_x86: Probe TSC frequency and scaling support qemu: Check TSC frequency before starting QEMU src/conf/cpu_conf.c | 48 ++++++++++++++++++++++++ src/conf/cpu_conf.h | 2 + src/cpu/cpu_x86.c | 81 ++++++++++++++++++++++------------------- src/qemu/qemu_process.c | 53 +++++++++++++++++++++++++++ src/util/virhostcpu.c | 71 ++++++++++++++++++++++++++++++++++++ src/util/virhostcpu.h | 11 ++++++ 6 files changed, 229 insertions(+), 37 deletions(-) -- 2.21.0

2 7

[libvirt] [PATCH] test_driver: implement virDomainGetHostname
by Ilias Stamatis 03 Jun '19

03 Jun '19

Always return "domain_name" + "host". Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/test/test_driver.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2f58a1da95..aad7bb6036 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1910,6 +1910,27 @@ static int testDomainReboot(virDomainPtr domain, return ret; } +static char * +testDomainGetHostname(virDomainPtr domain, + unsigned int flags) +{ + char *ret = NULL; + virDomainObjPtr vm = NULL; + + virCheckFlags(0, NULL); + + if (!(vm = testDomObjFromDomain(domain))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + ignore_value(virAsprintf(&ret, "%shost", domain->name)); + + cleanup: + return ret; +} + static int testDomainGetInfo(virDomainPtr domain, virDomainInfoPtr info) { @@ -6950,6 +6971,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainGetMaxMemory = testDomainGetMaxMemory, /* 0.1.4 */ .domainSetMaxMemory = testDomainSetMaxMemory, /* 0.1.1 */ .domainSetMemory = testDomainSetMemory, /* 0.1.4 */ + .domainGetHostname = testDomainGetHostname, /* 5.5.0 */ .domainGetInfo = testDomainGetInfo, /* 0.1.1 */ .domainGetState = testDomainGetState, /* 0.9.2 */ .domainGetTime = testDomainGetTime, /* 5.4.0 */ -- 2.21.0

2 2

[libvirt] [PATCH] virDomainSendKey: validate codeset argument
by Ilias Stamatis 03 Jun '19

03 Jun '19

This argument wasn't validated anywhere, neither in the generic implementation nor in the individual drivers. As a result a call to this function with a large enough codeset value prior to this change causes libvirtd to crash. This happens because all drivers call virKeycodeValueTranslate which uses codeset as an index to the virKeymapValues array, causing an out-of-bounds error. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- src/libvirt-domain.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index df7e405b3e..c09448927b 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -6837,6 +6837,13 @@ virDomainSendKey(virDomainPtr domain, virCheckNonNullArgGoto(keycodes, error); virCheckPositiveArgGoto(nkeycodes, error); + if (codeset >= VIR_KEYCODE_SET_LAST) { + virReportInvalidArg(codeset, + _("codeset must be less than %d"), + VIR_KEYCODE_SET_LAST); + goto error; + } + if (nkeycodes > VIR_DOMAIN_SEND_KEY_MAX_KEYS) { virReportInvalidArg(nkeycodes, _("nkeycodes must be <= %d"), -- 2.21.0

2 1

[libvirt] [PATCH] qemu: fix pr-helper0 remain
by Jie Wang 01 Jun '19

01 Jun '19

if libvirt receive DISCONNECTED event and set prDaemonRunning to false, and qemuDomainRemoveDiskDevice is performing in the meantime. qemuDomainRemoveDiskDevice will return directly by prDaemonRunning check, so the pr-helper0 object will remain. I think it is no need to check prDaemonRunning in qemuHotplugRemoveManagedPR. Signed-off-by: Jie Wang <wangjie88(a)huawei.com> --- src/qemu/qemu_hotplug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 34249bd030..5e4a929738 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -465,8 +465,7 @@ qemuHotplugRemoveManagedPR(virQEMUDriverPtr driver, virErrorPtr orig_err; int ret = -1; - if (!priv->prDaemonRunning || - virDomainDefHasManagedPR(vm->def)) + if (virDomainDefHasManagedPR(vm->def)) return 0; virErrorPreserveLast(&orig_err); -- 2.16.2.windows.1

3 6

[libvirt] [PATCH v2] docs: Drop the external AMD SEV links
by Erik Skultety 31 May '19

31 May '19

One of the current SEV document links went dead as AMD moved the resource to another place (document store), so there's probably very little point in maintaining 3rd party links if the resources are being moved. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- docs/formatdomaincaps.html.in | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index 432d7aed5e..bcd2b3354b 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -514,19 +514,9 @@ encrypted with a key unique to that VM.</p> <p> - For more details on the SEV feature and how to use it with libvirt have - a look at the following resources: - <dl> - <dd> - <a href="https://support.amd.com/TechDocs/55766_SEV-KM_API_Specification.pdf">SEV API spec</a> - </dd> - <dd> - <a href="http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_E…">SEV White Paper</a> - </dd> - <dd> - <a href="formatdomain.html#launchSecurity">SEV in domain XML</a> - </dd> - </dl> + For more details on the SEV feature, please follow resources in the + AMD developer's document store. In order to use SEV with libvirt have + a look at <a href="formatdomain.html#launchSecurity">SEV in domain XML</a> </p> <dl> -- 2.20.1

2 1

[libvirt] [PATCH] maint: Add support for .ctags.d
by Jiri Denemark 31 May '19

31 May '19

Depending on the way ctags was compiled, it may look for .ctags.d/*.ctags files rather than .ctags for reading configuration. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- .ctags.d/libvirt.ctags | 1 + 1 file changed, 1 insertion(+) create mode 120000 .ctags.d/libvirt.ctags diff --git a/.ctags.d/libvirt.ctags b/.ctags.d/libvirt.ctags new file mode 120000 index 0000000000..eefd37f401 --- /dev/null +++ b/.ctags.d/libvirt.ctags @@ -0,0 +1 @@ +../.ctags \ No newline at end of file -- 2.21.0

2 1

[libvirt] [PATCH 0/2] news: Update for 5.4.0 release
by Andrea Bolognani 31 May '19

31 May '19

Hopefully I've done a decent enough job at summarizing, especially with the security stuff: if not, please let me know! Andrea Bolognani (2): news: Reformat overgrown line news: Update for 5.4.0 release docs/news.xml | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 60 insertions(+), 1 deletion(-) -- 2.21.0

2 3

[libvirt] Entering freeze for libvirt 5.4.0
by Daniel Veillard 31 May '19

31 May '19

This is tagged in git, I have put the signed tarball and source RPM at the usual place: https://libvirt.org/sources/ I did not build the binaries rpms, first it broke because I was still on F28 c.f. Jan's patch, and second it's true to provides little value, it's doubtful people would just install my binaries as is. Will likely stick to sources as part of releases in the future. Release looks fine in my limited testing, https://ci.centos.org/view/libvirt/ is of a rare uniform green color, which is promising too ! Please give it a try, I will likely cut RC2 on Thrusday, and then if everything goes fine push the GA over the w.e. or Monday, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] Question about save and restore OVS per-port data in live migration
by wangxin (U) 31 May '19

31 May '19

Hi When we try to migrate a guest with 12 NICs, we find libvirt will try to get per-port data in finish phase, it makes the guest paused for several hundred milliseconds. qemuMigrationCookieAddNetwork -> virNetDevOpenvswitchGetMigrateData for per-nic -> run 'ovs-vsctl --if-exists get Interface vnetx external_ids:Port' (about 25ms) In our case, there's no portData available and it seems there is no need to run the cmd. Questions: 1. Is it necessary to get/set per-port data in migration finish phase? It will increase the downtime. 2. Is there any way (i.e. a switch) to not run the OVS cmd if there's no portData available?

2 4

[libvirt] [PATCH] docs: Replace the SEV links with a single one to AMD's document store
by Erik Skultety 31 May '19

31 May '19

The SEV whitepaper link stopped working as the resource has been moved. But all the SEV-related stuff like spec, whitepaper, presentations, etc. are being provided at https://developer.amd.com/sev/ which may look like a more stable resource (in terms of not being removed in the foreseeable future) so rather than providing and maintaining links to individual resources, let's use this one instead. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- docs/formatdomaincaps.html.in | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index 432d7aed5e..ef42bd57c3 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -518,10 +518,7 @@ a look at the following resources: <dl> <dd> - <a href="https://support.amd.com/TechDocs/55766_SEV-KM_API_Specification.pdf">SEV API spec</a> - </dd> - <dd> - <a href="http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_E…">SEV White Paper</a> + <a href="https://developer.amd.com/sev/">SEV further reading</a> </dd> <dd> <a href="formatdomain.html#launchSecurity">SEV in domain XML</a> -- 2.20.1

2 2

[libvirt] [PATCH 0/2] tests: Add aarch64-gigabyte sysinfo test case
by Andrea Bolognani 30 May '19

30 May '19

This is intended to validate that using dmidecode on aarch64[1] works as expected. [1] https://www.redhat.com/archives/libvir-list/2019-May/msg00244.html Andrea Bolognani (2): tests: Tweak x86 sysinfo test case tests: Add aarch64-gigabyte sysinfo test case .../sysinfodata/aarch64-gigabytecpuinfo.data | 288 ++++++++ .../sysinfodata/aarch64-gigabytedmidecode.sh | 3 + .../sysinfodata/aarch64-gigabytesysinfo.data | 619 ++++++++++++++++++ .../aarch64-gigabytesysinfo.expect | 1 + .../{dmidecode.sh => x86dmidecode.sh} | 0 tests/sysinfotest.c | 4 +- 6 files changed, 914 insertions(+), 1 deletion(-) create mode 100644 tests/sysinfodata/aarch64-gigabytecpuinfo.data create mode 100755 tests/sysinfodata/aarch64-gigabytedmidecode.sh create mode 100644 tests/sysinfodata/aarch64-gigabytesysinfo.data create mode 100644 tests/sysinfodata/aarch64-gigabytesysinfo.expect rename tests/sysinfodata/{dmidecode.sh => x86dmidecode.sh} (100%) -- 2.21.0

2 3

[libvirt] [PATCH 0/9] util/resctrl cleanups and refactors
by Wang Huaqiang 30 May '19

30 May '19

Plan to support Resctrl Control Monitors, which is a feature introduced by kernel 'resctrl' sub-model. Submit some cleanup and refactoring patches for upcoming memory bandwidth resource monitoring (MBM) monitors. Related MBM RFC is https://www.redhat.com/archives/libvir-list/2019-April/msg01409.html. This RFC is not actively discussed since libvirt already implemented similar resctrl cache monitoring (CMT), and lots details have been discussed and implemented during the work of CMT. The cleanups and refactoring includes: 1. Removing some reluctant lines and white spaces that is existing in current code and not meet the libvirt coding style. 2. Replace 'virResctrlAllocIsEmpty' with @n==0 for indicating no resctrl allocation in configuration file. 3. Private API changes, removed 'virResctrlMonitorGetCacheOccupancy' and exported a new API named 'virResctrlMonitorGetStats' with similar functionality, but with capability to be used for retrieving MBM statistical information. 4. Refactoring 'virResctrlMonitorFreeStats' for more reusing in code. 5. Extend data structure 'virResctrlMonitorStats' with the capability to carry multiple statistical information from monitor. Wang Huaqiang (9): conf: code cleanup, remove empty line and one space conf: code cleanup for return error code directly conf: check if vcpus matches with any 'existing' allocaiton conf: Replace 'virResctrlAllocIsEmpty' with @n==0 for indicating no resctrl allocation in configuration file conf: refactor 'virDomainResctrlVcpuMatch' util: Refactor 'virResctrlMonitorFreeStats' util: Refactor 'virResctrlMonitorStats' util: Extend virresctl API to retrieve multiple monitor statistics util: Remove unused virResctrlMonitorGetCacheOccupancy src/conf/domain_conf.c | 89 +++++++++++++++++++++++------------------------- src/libvirt_private.syms | 2 +- src/qemu/qemu_driver.c | 36 +++++++++++++++----- src/util/virresctrl.c | 68 +++++++++++++++--------------------- src/util/virresctrl.h | 19 ++++++++--- 5 files changed, 113 insertions(+), 101 deletions(-) -- 2.7.4

3 25

[libvirt] [PATCH v2 0/2] virSysinfo: Try dmidecode on aarch64
by Michal Privoznik 30 May '19

30 May '19

v2 of: https://www.redhat.com/archives/libvir-list/2019-May/msg00221.html diff to v1: - Pushed 1/3 and 2/3 from v1 as they were ACKed already - New patch 1/2 which renames virSysinfoReadX86 - Patch 2/2 then uses the renamed function Michal Prívozník (2): virsysinfo: Rename virSysinfoReadX86 to virSysinfoReadDMI virSysinfoReadARM: Try reading DMI table src/libvirt_private.syms | 2 +- src/util/virsysinfo.c | 22 ++++++++++++++++++++-- src/util/virsysinfopriv.h | 2 +- tests/sysinfotest.c | 2 +- 4 files changed, 23 insertions(+), 5 deletions(-) -- 2.21.0

3 5

[libvirt] [PATCH v2] qemu: aquire job in qemuDomainDefineXMLFlags
by Nikolay Shirokovskiy 30 May '19

30 May '19

The function updates vm->newDef and frees previous pesistent definition which can be used by in different thread by some API that unlocks domain to communicate to qemu. So we have an access to freed memory in that thread. Let's acquire job condition in case of updating exiting domain. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- diff from v1 [1]: - pay a bit of attention to the problem Reproducer in the Michal's reply to the [1]. [1] https://www.redhat.com/archives/libvir-list/2019-May/msg00804.html src/qemu/qemu_driver.c | 37 +++++++++++++++++++++++++++++++++++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 42b1ce2..2dd4442 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7620,6 +7620,7 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, virDomainDefPtr def = NULL; virDomainDefPtr oldDef = NULL; virDomainObjPtr vm = NULL; + virDomainObjPtr exvm = NULL; virDomainPtr dom = NULL; virObjectEventPtr event = NULL; virQEMUDriverConfigPtr cfg; @@ -7647,10 +7648,34 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, if (virDomainDefineXMLFlagsEnsureACL(conn, def) < 0) goto cleanup; + if ((exvm = virDomainObjListFindByUUID(driver->domains, def->uuid))) { + if (qemuDomainObjBeginJob(driver, exvm, QEMU_JOB_MODIFY) < 0) { + virDomainObjEndAPI(&exvm); + goto cleanup; + } + virObjectUnlock(exvm); + } + if (!(vm = virDomainObjListAdd(driver->domains, def, driver->xmlopt, - 0, &oldDef))) + 0, &oldDef))) { + if (exvm) + virObjectLock(exvm); goto cleanup; + } + + if (exvm) { + if (vm != exvm) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("domain '%s' is removed"), def->name); + virObjectLock(exvm); + goto cleanup; + } + + /* we don't need extra reference for same domain */ + virObjectUnref(exvm); + } + def = NULL; vm->persistent = 1; @@ -7670,7 +7695,10 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, /* Brand new domain. Remove it */ VIR_INFO("Deleting domain '%s'", vm->def->name); vm->persistent = 0; - qemuDomainRemoveInactiveJob(driver, vm); + if (exvm) + qemuDomainRemoveInactive(driver, vm); + else + qemuDomainRemoveInactiveJob(driver, vm); } goto cleanup; } @@ -7685,8 +7713,13 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id); cleanup: + if (exvm) + qemuDomainObjEndJob(driver, exvm); + virDomainDefFree(oldDef); virDomainDefFree(def); + if (exvm && exvm != vm) + virDomainObjEndAPI(&exvm); virDomainObjEndAPI(&vm); virObjectEventStateQueue(driver->domainEventState, event); virObjectUnref(caps); -- 1.8.3.1

2 1

[libvirt] [PATCH v2 0/2] introduction of version attribute for VFIO live migration
by Yan Zhao 29 May '19

29 May '19

This patchset introduces a version attribute under sysfs of VFIO Mediated devices. This version attribute is used to check whether two mdev devices are compatible. user space software can take advantage of this version attribute to determine whether to launch live migration between two mdev devices. Patch 1 defines version attribute in Documentation/vfio-mediated-device.txt Patch 2 uses GVT as an example to show how to expose version attribute and check device compatibility in vendor driver. v2: 1. renamed patched 1 2. made definition of device version string completely private to vendor driver 3. abandoned changes to sample mdev drivers 4. described intent and usage of version attribute more clearly. Yan Zhao (2): vfio/mdev: add version attribute for mdev device drm/i915/gvt: export mdev device version to sysfs for Intel vGPU Documentation/vfio-mediated-device.txt | 135 ++++++++++++++++++++++ drivers/gpu/drm/i915/gvt/Makefile | 2 +- drivers/gpu/drm/i915/gvt/device_version.c | 84 ++++++++++++++ drivers/gpu/drm/i915/gvt/gvt.c | 51 ++++++++ drivers/gpu/drm/i915/gvt/gvt.h | 6 + 5 files changed, 277 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm/i915/gvt/device_version.c -- 2.17.1

7 45

[libvirt] [PATCH v3 0/2] introduction of migration_version attribute for VFIO live migration
by Yan Zhao 29 May '19

29 May '19

This patchset introduces a migration_version attribute under sysfs of VFIO Mediated devices. This migration_version attribute is used to check migration compatibility between two mdev devices of the same mdev type. Patch 1 defines migration_version attribute in Documentation/vfio-mediated-device.txt Patch 2 uses GVT as an example to show how to expose migration_version attribute and check migration compatibility in vendor driver. v3: 1. renamed version to migration_version 2. let errno to be freely defined by vendor driver 3. let checking mdev_type be prerequisite of migration compatibility check 4. reworded most part of patch 1 5. print detailed error log in patch 2 and generate migration_version string at init time v2: 1. renamed patched 1 2. made definition of device version string completely private to vendor driver 3. reverted changes to sample mdev drivers 4. described intent and usage of version attribute more clearly. Yan Zhao (2): vfio/mdev: add migration_version attribute for mdev device drm/i915/gvt: export migration_version to mdev sysfs for Intel vGPU Documentation/vfio-mediated-device.txt | 113 +++++++++++++ drivers/gpu/drm/i915/gvt/Makefile | 2 +- drivers/gpu/drm/i915/gvt/gvt.c | 39 +++++ drivers/gpu/drm/i915/gvt/gvt.h | 5 + drivers/gpu/drm/i915/gvt/migration_version.c | 167 +++++++++++++++++++ drivers/gpu/drm/i915/gvt/vgpu.c | 13 +- 6 files changed, 336 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/drm/i915/gvt/migration_version.c -- 2.17.1

3 8

[libvirt] [PATCH 00/11] qemu: Introduce SMMUv3 IOMMU support
by Andrea Bolognani 28 May '19

28 May '19

This is the ARM equivalent of Intel IOMMU. Andrea Bolognani (11): qemu: Fix switch() statements for virDomainIOMMUModel qemu: Drop 'ret' from qemuBuildIOMMUCommandLine() qemu: Use VIR_AUTOCLEAN() in qemuBuildIOMMUCommandLine() qemu: Move virBuffer inside switch() statement qemu: Move capability checks inside switch() statements qemu: Introduce QEMU_CAPS_MACHINE_VIRT_IOMMU conf: Parse and format SMMUv3 IOMMU qemu: Add validation for SMMUv3 IOMMU qemu: Move capability checks for IOMMU features qemu: Format SMMUv3 IOMMU news: Update for SMMUv3 IOMMU support docs/formatdomain.html.in | 7 +- docs/news.xml | 8 + docs/schemas/domaincommon.rng | 5 +- src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 8 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 63 ++++--- src/qemu/qemu_domain.c | 73 +++++--- .../caps_2.12.0.aarch64.replies | 166 +++++++++++++++-- .../caps_3.0.0.riscv32.replies | 131 +++++++++++++- .../caps_3.0.0.riscv64.replies | 131 +++++++++++++- .../caps_4.0.0.aarch64.replies | 171 ++++++++++++++++-- .../caps_4.0.0.aarch64.xml | 1 + .../caps_4.0.0.riscv32.replies | 129 ++++++++++++- .../caps_4.0.0.riscv64.replies | 129 ++++++++++++- .../iommu-smmuv3.aarch64-latest.args | 31 ++++ tests/qemuxml2argvdata/iommu-smmuv3.xml | 15 ++ tests/qemuxml2argvtest.c | 1 + .../iommu-smmuv3.aarch64-latest.xml | 25 +++ tests/qemuxml2xmltest.c | 1 + 21 files changed, 985 insertions(+), 113 deletions(-) create mode 100644 tests/qemuxml2argvdata/iommu-smmuv3.aarch64-latest.args create mode 100644 tests/qemuxml2argvdata/iommu-smmuv3.xml create mode 100644 tests/qemuxml2xmloutdata/iommu-smmuv3.aarch64-latest.xml -- 2.21.0

2 22

[libvirt] [PATCH v3 0/6] numa: deprecate '-numa node, mem' and default memory distribution
by Igor Mammedov 28 May '19

28 May '19

Changes since v2: - taking in account previous review, implement a way for mgmt to intospect if '-numa node,mem' is supported by machine type as suggested by Daniel at https://www.mail-archive.com/qemu-devel@nongnu.org/msg601220.html * ammend "qom-list-properties" to show property values * add "numa-mem-supported" machine property to reflect if '-numa node,mem=SZ' is supported. It culd be used with '-machine none' or at runtime with --preconfig before numa memory mapping are configured * minor fixes to deprecation documentation mentioning "numa-mem-supported" property 1) "I'm considering to deprecating -mem-path/prealloc CLI options and replacing them with a single memdev Machine property to allow interested users to pick used backend for initial RAM (fixes mixed -mem-path+hostmem backends issues) and as a transition step to modeling initial RAM as a Device instead of (ab)using MemoryRegion APIs." (for more details see: https://www.mail-archive.com/qemu-devel@nongnu.org/msg596314.html) However there is a couple of roadblocks on the way (s390x and numa memory handling). I think I finally thought out a way to hack s390x in migration compatible manner, but I don't see any way to do it for -numa node,mem and default RAM assignement to nodes. Considering both numa usecases aren't meaningfully using NUMA (aside guest side testing) and could be replaced with explicitly used memdev parameter, I'd like to propose removing these fake NUMA friends on new machine types, hence this deprecation. And once the last machie type that supported the option is removed we would be able to remove option altogether. As result of removing deprecated options and replacing initial RAM allocation with 'memdev's (1), QEMU will allocate guest RAM in consistent way, fixing mixed use-case and allowing boards to move towards modelling initial RAM as Device(s). Which in its own turn should allow to cleanup NUMA/HMP/memory accounting code more by dropping ad-hoc node_mem tracking and reusing memory device enumeration instead. Reference to previous versions: * [PATCH 0/2] numa: deprecate -numa node, mem and default memory distribution https://www.mail-archive.com/qemu-devel@nongnu.org/msg600706.html * [PATCH] numa: warn if numa 'mem' option or default RAM splitting between nodes is used. https://www.mail-archive.com/qemu-devel@nongnu.org/msg602136.html * [PATCH v2] numa: warn if numa 'mem' option or default RAM splitting between nodes is used. https://www.spinics.net/linux/fedora/libvir/msg180917.html CC: libvir-list(a)redhat.com CC: ehabkost(a)redhat.com CC: pbonzini(a)redhat.com CC: berrange(a)redhat.com CC: armbru(a)redhat.com Igor Mammedov (6): pc: fix possible NULL pointer dereference in pc_machine_get_device_memory_region_size() qmp: make "qom-list-properties" show initial property values qmp: qmp_qom_list_properties(): ignore empty string options numa: introduce "numa-mem-supported" machine property numa: deprecate 'mem' parameter of '-numa node' option numa: deprecate implict memory distribution between nodes include/hw/boards.h | 1 + hw/arm/virt.c | 1 + hw/core/machine.c | 12 ++++++++++++ hw/i386/pc.c | 7 ++++++- hw/ppc/spapr.c | 1 + numa.c | 5 +++++ qapi/misc.json | 5 ++++- qemu-deprecated.texi | 24 ++++++++++++++++++++++++ qmp.c | 15 +++++++++++++++ 9 files changed, 69 insertions(+), 2 deletions(-) -- 2.7.4

3 13

[libvirt] [PATCH] qemu: aquire job in qemuDomainDefineXMLFlags
by Nikolay Shirokovskiy 28 May '19

28 May '19

The function updates vm->newDef and frees previous pesistent definition which can be used by in different thread by some API that unlocks domain to communicate to qemu. So we have an access to freed memory in that thread. Let's acquire job condition when changing persistent xml. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- A bug example (some downstream version of libvirt, nevertheless): (gdb) bt #0 0x00007f3bb77a0533 in virDomainDefHasVcpusOffline (def=def@entry=0x7f3b7802a830) at conf/domain_conf.c:1637 #1 0x00007f3bb77cb32f in virDomainCpuDefFormat (def=0x7f3b7802a830, buf=0x7f3ba7308940) at conf/domain_conf.c:27503 #2 virDomainDefFormatInternal (def=def@entry=0x7f3b7802a830, caps=0x7f3b70000ae0, flags=3, flags@entry=1, buf=buf@entry=0x7f3ba7308940, xmlopt=xmlopt@entry=0x0) at conf/domain_conf.c:27850 #3 0x00007f3bb77ced46 in virDomainDefFormat (def=def@entry=0x7f3b7802a830, caps=<optimized out>, flags=flags@entry=1) at conf/domain_conf.c:28564 #4 0x00007f3bb77d23f9 in virDomainSaveConfig (configDir=0x7f3b981227e0 "/etc/libvirt/qemu", caps=<optimized out>, def=0x7f3b7802a830) at conf/domain_conf.c:28776 #5 0x00007f3ba086b617 in qemuDomainSetMemoryStatsPeriod (dom=<optimized out>, period=30, flags=<optimized out>) at qemu/qemu_driver.c:4839 #6 0x00007f3bb7905613 in virDomainSetMemoryStatsPeriod (domain=domain@entry=0x7f3b74006200, period=30, flags=3) at libvirt-domain.c:2087 (gdb) f 5 #5 0x00007f3ba086b617 in qemuDomainSetMemoryStatsPeriod (dom=<optimized out>, period=30, flags=<optimized out>) at qemu/qemu_driver.c:4839 4839 ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef); (gdb) p vm->def $8 = (virDomainDefPtr) 0x7f3b8400c6f0 (gdb) p vm->newDef $9 = (virDomainDefPtr) 0x7f3b7001de20 (gdb) p persistentDef $10 = (virDomainDefPtr) 0x7f3b7802a830 src/qemu/qemu_driver.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 42b1ce2..683dcaa 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7626,6 +7626,7 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, virCapsPtr caps = NULL; unsigned int parse_flags = VIR_DOMAIN_DEF_PARSE_INACTIVE | VIR_DOMAIN_DEF_PARSE_ABI_UPDATE; + bool job = false; virCheckFlags(VIR_DOMAIN_DEFINE_VALIDATE, NULL); @@ -7647,6 +7648,10 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, if (virDomainDefineXMLFlagsEnsureACL(conn, def) < 0) goto cleanup; + if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0) + goto cleanup; + job = true; + if (!(vm = virDomainObjListAdd(driver->domains, def, driver->xmlopt, 0, &oldDef))) @@ -7685,6 +7690,9 @@ qemuDomainDefineXMLFlags(virConnectPtr conn, dom = virGetDomain(conn, vm->def->name, vm->def->uuid, vm->def->id); cleanup: + if (job) + qemuDomainObjEndJob(driver, vm); + virDomainDefFree(oldDef); virDomainDefFree(def); virDomainObjEndAPI(&vm); -- 1.8.3.1

3 3

[libvirt] Plans for next release
by Daniel Veillard 28 May '19

28 May '19

We should enter freeze for 5.4.0 beginning of next week, maybe Monday evening or Tuesday morning, then plan for RC2 around Wed - Thur for a w.e. release. Hope this works for everybody, thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] [PATCH] vz: fixes: snapshot: s/parent/parent_name/ as prep for virObject
by Nikolay Shirokovskiy 28 May '19

28 May '19

Apply renaming of 36603bc56 for the vz driver. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- Pushed as build breaker/trivial. src/vz/vz_driver.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index dfd49e7..2286f9a 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -2460,14 +2460,14 @@ vzDomainSnapshotGetParent(virDomainSnapshotPtr snapshot, unsigned int flags) if (!(snap = vzSnapObjFromSnapshot(snapshots, snapshot))) goto cleanup; - if (!snap->def->parent) { + if (!snap->def->parent_name) { virReportError(VIR_ERR_NO_DOMAIN_SNAPSHOT, _("snapshot '%s' does not have a parent"), snap->def->name); goto cleanup; } - parent = virGetDomainSnapshot(snapshot->domain, snap->def->parent); + parent = virGetDomainSnapshot(snapshot->domain, snap->def->parent_name); cleanup: virDomainSnapshotObjListFree(snapshots); -- 1.8.3.1

1 0

[libvirt] [PATCH 00/16] examples: Install more files and tidy up
by Andrea Bolognani 28 May '19

28 May '19

This series changes our install procedure so that we install all available examples on the target system; in the process, it also removes all custom shell code from the installation procedure, replacing it with standard autotools usage, and fixes a few admittedly very minor issues. Andrea Bolognani (16): spec: Don't install libvirt-api.xml as documentation examples: Drop object_events_event_test_CFLAGS examples: Reformat $(AM_CPPFLAGS) and $(LDADDS) examples: Remove $(WARN_CFLAGS) from $(LDADD) examples: Don't look for headers in $(top_srcdir) examples: Move $(STATIC_BINARIES) to $(AM_LDFLAGS) examples: Move $(WARN_CFLAGS) to $(AM_CFLAGS) examples: Drop unnecessary $(mkinstalldirs) call examples: Install nwfilters without shell scripting examples: Install Polkit examples examples: Install SystemTap examples examples: Install remaining XML examples examples: Move and install shell examples examples: Organize C examples into categories examples: Rework C examples installation examples: Group all C programs together .gitignore | 30 +-- examples/Makefile.am | 192 ++++++++++-------- examples/{ => c}/admin/client_close.c | 0 examples/{ => c}/admin/client_info.c | 0 examples/{ => c}/admin/client_limits.c | 0 examples/{ => c}/admin/list_clients.c | 0 examples/{ => c}/admin/list_servers.c | 0 examples/{ => c}/admin/logging.c | 0 examples/{ => c}/admin/threadpool_params.c | 0 .../{dommigrate => c/domain}/dommigrate.c | 0 examples/{domtop => c/domain}/domtop.c | 0 examples/{dominfo => c/domain}/info1.c | 0 examples/{rename => c/domain}/rename.c | 0 examples/{domsuspend => c/domain}/suspend.c | 0 .../{object-events => c/misc}/event-test.c | 0 .../{hellolibvirt => c/misc}/hellolibvirt.c | 0 examples/{openauth => c/misc}/openauth.c | 0 examples/{lxcconvert => sh}/virt-lxc-convert | 0 libvirt.spec.in | 4 - 19 files changed, 123 insertions(+), 103 deletions(-) rename examples/{ => c}/admin/client_close.c (100%) rename examples/{ => c}/admin/client_info.c (100%) rename examples/{ => c}/admin/client_limits.c (100%) rename examples/{ => c}/admin/list_clients.c (100%) rename examples/{ => c}/admin/list_servers.c (100%) rename examples/{ => c}/admin/logging.c (100%) rename examples/{ => c}/admin/threadpool_params.c (100%) rename examples/{dommigrate => c/domain}/dommigrate.c (100%) rename examples/{domtop => c/domain}/domtop.c (100%) rename examples/{dominfo => c/domain}/info1.c (100%) rename examples/{rename => c/domain}/rename.c (100%) rename examples/{domsuspend => c/domain}/suspend.c (100%) rename examples/{object-events => c/misc}/event-test.c (100%) rename examples/{hellolibvirt => c/misc}/hellolibvirt.c (100%) rename examples/{openauth => c/misc}/openauth.c (100%) rename examples/{lxcconvert => sh}/virt-lxc-convert (100%) -- 2.21.0

2 17

[libvirt] [ocaml PATCH] build: build with CAML_NAME_SPACE
by Pino Toscano 28 May '19

28 May '19

This way no non-namespaced OCaml C symbols are used, reducing the risk of clashes with other code. Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- libvirt/Makefile.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt/Makefile.in b/libvirt/Makefile.in index 3a68aed..77462c7 100644 --- a/libvirt/Makefile.in +++ b/libvirt/Makefile.in @@ -19,6 +19,7 @@ WIN32 = @WIN32@ CFLAGS = @CFLAGS@ \ @LIBVIRT_CFLAGS@ \ + -DCAML_NAME_SPACE \ -I.. \ -I"$(shell ocamlc -where)" \ @DEBUG@ @WARNINGS@ @CFLAGS_FPIC@ -- 2.21.0

2 1

[libvirt] [PATCH] test_driver: implement virDomainMemoryPeek
by Ilias Stamatis 27 May '19

27 May '19

Begins by writing a @start byte in the first position of @buffer and then for every next byte it stores the value of its previous one incremented by one. Behaves the same for both supported flags. Signed-off-by: Ilias Stamatis <stamatis.iliass(a)gmail.com> --- Initially I thought about checking whether start+size exceeds the available physical or virtual memory. However I noticed that even when I pass -1 as @start the qemu driver doesn't complain and it fills the buffer with data. So I left it as is, without performing any additional checks. src/test/test_driver.c | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index a4c17ef0df..04fdf7a4b8 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -6000,6 +6000,42 @@ testDomainManagedSaveRemove(virDomainPtr dom, unsigned int flags) return 0; } +static int +testDomainMemoryPeek(virDomainPtr dom, + unsigned long long start, + size_t size, + void *buffer, + unsigned int flags) +{ + int ret = -1; + size_t i; + unsigned char b = start; + virDomainObjPtr vm = NULL; + + virCheckFlags(VIR_MEMORY_VIRTUAL | VIR_MEMORY_PHYSICAL, -1); + + if (flags != VIR_MEMORY_VIRTUAL && flags != VIR_MEMORY_PHYSICAL) { + virReportError(VIR_ERR_INVALID_ARG, + "%s", _("flags parameter must be VIR_MEMORY_VIRTUAL or VIR_MEMORY_PHYSICAL")); + goto cleanup; + } + + if (!(vm = testDomObjFromDomain(dom))) + goto cleanup; + + if (virDomainObjCheckActive(vm) < 0) + goto cleanup; + + for (i = 0; i < size; i++) + ((unsigned char *) buffer)[i] = b++; + + ret = 0; + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + /* * Snapshot APIs @@ -6897,6 +6933,7 @@ static virHypervisorDriver testHypervisorDriver = { .domainManagedSave = testDomainManagedSave, /* 1.1.4 */ .domainHasManagedSaveImage = testDomainHasManagedSaveImage, /* 1.1.4 */ .domainManagedSaveRemove = testDomainManagedSaveRemove, /* 1.1.4 */ + .domainMemoryPeek = testDomainMemoryPeek, /* 5.4.0 */ .domainSnapshotNum = testDomainSnapshotNum, /* 1.1.4 */ .domainSnapshotListNames = testDomainSnapshotListNames, /* 1.1.4 */ -- 2.21.0

2 3

[libvirt] [PATCH 0/2] qemu: Fix for emulatorsched
by Martin Kletzander 27 May '19

27 May '19

Partially-related-to: https://bugzilla.redhat.com/show_bug.cgi?id=1712781 Martin Kletzander (2): qemu: Set emulator thread scheduler only after QEMU starts docs: Add emulatorsched fix info to news.xml docs/news.xml | 12 ++++++++++++ src/qemu/qemu_process.c | 10 +++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) -- 2.21.0

2 3

[libvirt] [glib PATCH v2 0/2] Simplify autogen.sh & get rid of our own gtk-doc.make
by Fabiano Fidêncio 27 May '19

27 May '19

Let's use a similiar autogen.sh as the one used by libosinfo and, with the change, let's also drop our own crafted gtk-doc.make (as we'll be using gtkdocize to generate the file). Changes since v1: - Do not remove the "--system" shortcut v1: https://www.redhat.com/archives/libvir-list/2019-May/msg00748.html Fabiano Fidêncio (2): autogen.sh: Simplify autogen.sh gtk-doc.make: Remove the file .gitignore | 4 + autogen.sh | 58 +++++------- gtk-doc.make | 256 --------------------------------------------------- 3 files changed, 29 insertions(+), 289 deletions(-) delete mode 100644 gtk-doc.make -- 2.21.0

3 6

[libvirt] [PATCH] qemu: Get default hugepage size only if needed
by Michal Privoznik 27 May '19

27 May '19

Fixes: 6864d8f740e2502dc7625bdf18ffde4465b14f69 Hugepages don't work in session mode but when building memory part of command line we query for the default size anyway. This breaks creating domains under session daemon. Query the page size only if it's clear we need hugepages. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- As a penance, I'll backport this onto v5.3-main branch too. src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 73f570c419..5bf6c704e0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3573,7 +3573,7 @@ qemuBuildMemoryBackendProps(virJSONValuePtr *backendProps, pagesize = 0; needHugepage = false; useHugepage = false; - } else if (pagesize == 0) { + } else if (useHugepage && pagesize == 0) { if (qemuBuildMemoryGetDefaultPagesize(cfg, &pagesize) < 0) goto cleanup; } -- 2.21.0

2 1

[libvirt] [PATCH] spec: Improve handling for default network
by Andrea Bolognani 27 May '19

27 May '19

This is exactly how we already treat nwfilters, which require the same kind of care (aka nasty hacks) as the default network, because in both cases the UUID is generated and written to disk the first time libvirtd is started after installing the corresponding subpackage. After this patch, RPM will be aware of the fact that the libvirt-daemon-config-network subpackage owns the default network. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b159c50d8f..94691c38fb 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1250,8 +1250,8 @@ install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/lib/libvirt/dnsmasq/ install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/libvirt/networks/ cp $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/default.xml \ $RPM_BUILD_ROOT%{_datadir}/libvirt/networks/default.xml -rm -f $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/default.xml -rm -f $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml +# libvirt saves this file with mode 0600 +chmod 0600 $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/default.xml # nwfilter files are installed in /usr/share/libvirt and copied to /etc in %post # to avoid verification errors on changed files in /etc @@ -1427,6 +1427,8 @@ if test $1 -eq 1 && test ! -f %{_sysconfdir}/libvirt/qemu/networks/default.xml ; < %{_datadir}/libvirt/networks/default.xml \ > %{_sysconfdir}/libvirt/qemu/networks/default.xml ln -s ../default.xml %{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml + # libvirt saves this file with mode 0600 + chmod 0600 %{_sysconfdir}/libvirt/qemu/networks/default.xml # Make sure libvirt picks up the new network defininiton mkdir -p %{_localstatedir}/lib/rpm-state/libvirt || : @@ -1577,6 +1579,8 @@ exit 0 %files daemon-config-network %dir %{_datadir}/libvirt/networks/ %{_datadir}/libvirt/networks/default.xml +%ghost %{_sysconfdir}/libvirt/qemu/networks/default.xml +%ghost %{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml %files daemon-config-nwfilter %dir %{_datadir}/libvirt/nwfilter/ -- 2.21.0

2 1