- Devel - libvirt List Archives

[PATCH] bhyve: support interface type 'network'
by Roman Bogorodskiy 09 Apr '25

09 Apr '25

Add support for interface type 'network'. While bridge remains the only supported options for networks in bhyve, supporting interface type 'network' allows easier configuration and makes domain XMLs more compatible with the other drivers. While here, update the error message for the unsupported interface type to print the requested network type string instead of an integer to make it more user-friendly. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/bhyve/bhyve_command.c | 44 ++++++++++++++++++++++++++++++++++----- src/bhyve/bhyve_process.c | 30 +++++++++++++++++++------- 2 files changed, 62 insertions(+), 12 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index bc287307c8..123d81699f 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -2,6 +2,7 @@ * bhyve_command.c: bhyve command generation * * Copyright (C) 2014 Roman Bogorodskiy + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -26,6 +27,7 @@ #include "bhyve_domain.h" #include "bhyve_conf.h" #include "bhyve_driver.h" +#include "domain_validate.h" #include "datatypes.h" #include "viralloc.h" #include "virfile.h" @@ -40,7 +42,7 @@ VIR_LOG_INIT("bhyve.bhyve_command"); static int -bhyveBuildNetArgStr(const virDomainDef *def, +bhyveBuildNetArgStr(virDomainDef *def, virDomainNetDef *net, struct _bhyveConn *driver, virCommand *cmd, @@ -52,6 +54,7 @@ bhyveBuildNetArgStr(const virDomainDef *def, char *nic_model = NULL; int ret = -1; virDomainNetType actualType = virDomainNetGetActualType(net); + g_autoptr(virConnect) netconn = NULL; if (net->model == VIR_DOMAIN_NET_MODEL_VIRTIO) { nic_model = g_strdup("virtio-net"); @@ -69,12 +72,43 @@ bhyveBuildNetArgStr(const virDomainDef *def, return -1; } - if (actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { + if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) { + if (!netconn && !(netconn = virGetConnectNetwork())) + goto cleanup; + if (virDomainNetAllocateActualDevice(netconn, def, net) < 0) + goto cleanup; + } + /* final validation now that actual type is known */ + if (virDomainActualNetDefValidate(net) < 0) + return -1; + + switch (actualType) { + case VIR_DOMAIN_NET_TYPE_NETWORK: + case VIR_DOMAIN_NET_TYPE_BRIDGE: brname = g_strdup(virDomainNetGetActualBridgeName(net)); - } else { + if (!brname) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("No bridge name specified")); + goto cleanup; + } + break; + case VIR_DOMAIN_NET_TYPE_ETHERNET: + case VIR_DOMAIN_NET_TYPE_DIRECT: + case VIR_DOMAIN_NET_TYPE_USER: + case VIR_DOMAIN_NET_TYPE_VHOSTUSER: + case VIR_DOMAIN_NET_TYPE_SERVER: + case VIR_DOMAIN_NET_TYPE_CLIENT: + case VIR_DOMAIN_NET_TYPE_MCAST: + case VIR_DOMAIN_NET_TYPE_UDP: + case VIR_DOMAIN_NET_TYPE_INTERNAL: + case VIR_DOMAIN_NET_TYPE_HOSTDEV: + case VIR_DOMAIN_NET_TYPE_VDPA: + case VIR_DOMAIN_NET_TYPE_NULL: + case VIR_DOMAIN_NET_TYPE_VDS: + case VIR_DOMAIN_NET_TYPE_LAST: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Network type %1$d is not supported"), - virDomainNetGetActualType(net)); + _("Unsupported network type %1$s"), + virDomainNetTypeToString(actualType)); goto cleanup; } diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 3e6f678cf5..a17994e2a0 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -2,6 +2,7 @@ * bhyve_process.c: bhyve process management * * Copyright (C) 2014 Roman Bogorodskiy + * Copyright (C) 2025 The FreeBSD Foundation * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -71,18 +72,23 @@ static void bhyveNetCleanup(virDomainObj *vm) { size_t i; + g_autoptr(virConnect) conn = NULL; for (i = 0; i < vm->def->nnets; i++) { virDomainNetDef *net = vm->def->nets[i]; virDomainNetType actualType = virDomainNetGetActualType(net); - if (actualType == VIR_DOMAIN_NET_TYPE_BRIDGE) { - if (net->ifname) { - ignore_value(virNetDevBridgeRemovePort( - virDomainNetGetActualBridgeName(net), - net->ifname)); - ignore_value(virNetDevTapDelete(net->ifname, NULL)); - } + if (net->ifname) { + ignore_value(virNetDevBridgeRemovePort( + virDomainNetGetActualBridgeName(net), + net->ifname)); + ignore_value(virNetDevTapDelete(net->ifname, NULL)); + } + if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK) { + if (conn || (conn = virGetConnectNetwork())) + virDomainNetReleaseActualDevice(conn, net); + else + VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname)); } } } @@ -437,6 +443,8 @@ virBhyveProcessReconnect(virDomainObj *vm, char **proc_argv; char *expected_proctitle = NULL; bhyveDomainObjPrivate *priv = vm->privateData; + g_autoptr(virConnect) conn = NULL; + size_t i; int ret = -1; if (!virDomainObjIsActive(vm)) @@ -469,6 +477,14 @@ virBhyveProcessReconnect(virDomainObj *vm, } } + for (i = 0; i < vm->def->nnets; i++) { + virDomainNetDef *net = vm->def->nets[i]; + if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK && !conn) + conn = virGetConnectNetwork(); + + virDomainNetNotifyActualDevice(conn, vm->def, net); + } + cleanup: if (ret < 0) { /* If VM is reported to be in active state, but we cannot find -- 2.49.0

2 1

[PATCH 0/3] bhyve: support random number generator device
by Roman Bogorodskiy 09 Apr '25

09 Apr '25

Roman Bogorodskiy (3): bhyve: support random number generator device bhyve: argv2xml: support virtio-rnd devices bhyve: extend RNG device validation src/bhyve/bhyve_capabilities.c | 15 ++++++++ src/bhyve/bhyve_capabilities.h | 2 + src/bhyve/bhyve_command.c | 23 ++++++++++++ src/bhyve/bhyve_device.c | 11 ++++++ src/bhyve/bhyve_domain.c | 21 +++++++++++ src/bhyve/bhyve_parse_command.c | 29 +++++++++++++++ .../bhyveargv2xml-virtio-rnd.args | 8 ++++ .../bhyveargv2xml-virtio-rnd.xml | 20 ++++++++++ tests/bhyveargv2xmltest.c | 1 + ...yvexml2argv-virtio-rnd-backend-builtin.xml | 26 +++++++++++++ ...io-rnd-backend-random-non-default-file.xml | 26 +++++++++++++ .../bhyvexml2argv-virtio-rnd-transitional.xml | 26 +++++++++++++ .../bhyvexml2argv-virtio-rnd.args | 11 ++++++ .../bhyvexml2argv-virtio-rnd.ldargs | 4 ++ .../bhyvexml2argv-virtio-rnd.xml | 26 +++++++++++++ tests/bhyvexml2argvtest.c | 6 +++ .../bhyvexml2xmlout-virtio-rnd.xml | 37 +++++++++++++++++++ tests/bhyvexml2xmltest.c | 1 + 18 files changed, 293 insertions(+) create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.args create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-virtio-rnd.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd-backend-builtin.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd-backend-random-non-default-file.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd-transitional.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-virtio-rnd.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-virtio-rnd.xml -- 2.49.0

2 4

[PATCH] NEWS: Mention fix for 'qemu-rdp' error being logged
by Peter Krempa 09 Apr '25

09 Apr '25

From: Peter Krempa <pkrempa(a)redhat.com> Add the news entry stating that it's safe to ignore the error. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 2608086717..18b873abe9 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -34,6 +34,16 @@ v11.3.0 (unreleased) installed and thus every attempt to start an ARM domain with custom CPU definition would fail. + * Don't spam logs with with error about ``qemu-rdp`` when starting a qemu VM + + On hosts where the ``qemu-rdp`` binary is not installed a start of a VM + would cause an error such as :: + + error : qemuRdpNewForHelper:103 : 'qemu-rdp' is not a suitable qemu-rdp helper name: No such file or directory + + To be logged in the system log. It is safe to ignore the error. The code + was fixed to avoid the message when probing for support. + v11.2.0 (2025-04-01) ==================== -- 2.49.0

2 1

[PATCH] storage: virStorageVolDefParse and storageVolCreateXML flags fix
by Kirill Shchetiniuk 08 Apr '25

08 Apr '25

When the new storage was created using virsh with --validate option following errors occurred: # virsh vol-create default --file vol-def.xml --validate error: Failed to create vol from vol-def.xml error: unsupported flags (0x4) in function virStorageVolDefParseXML and after virStorageVolDefParse fix: # virsh vol-create default --file vol-def.xml --validate error: Failed to create vol from vol-def.xml error: unsupported flags (0x4) in function storageBackendCreateQemuImg Clear the VIR_STORAGE_VOL_CREATE_VALIDATE flag before virStorageVolDefParseXML and backend->buildVol (traces down to storageBackendCreateQemuImg) calls, as the XML schema validation is already complete within previous steps and there is no validation later. Signed-off-by: Kirill Shchetiniuk <kshcheti(a)redhat.com> --- NEWS.rst | 5 +++++ src/conf/storage_conf.c | 2 ++ src/storage/storage_driver.c | 4 +++- 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index e2dc4e508b..dd345bad7b 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -28,6 +28,11 @@ v11.3.0 (unreleased) * **Bug fixes** + * storage: Fix new volume creation + + No more errors occur when new storage volume is being created + using ``vol-create`` with ``--validate`` option. + v11.2.0 (2025-04-01) ==================== diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c index 68842004b7..f6d804bb39 100644 --- a/src/conf/storage_conf.c +++ b/src/conf/storage_conf.c @@ -1409,6 +1409,8 @@ virStorageVolDefParse(virStoragePoolDef *pool, "volume", &ctxt, "storagevol.rng", validate))) return NULL; + flags &= ~(VIR_STORAGE_VOL_CREATE_VALIDATE); + return virStorageVolDefParseXML(pool, ctxt, flags); } diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 86c03762d2..2f5a26bbef 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1877,6 +1877,7 @@ storageVolCreateXML(virStoragePoolPtr pool, virStorageVolPtr vol = NULL, newvol = NULL; g_autoptr(virStorageVolDef) voldef = NULL; unsigned int parseFlags = VIR_VOL_XML_PARSE_OPT_CAPACITY; + unsigned int buildFlags = flags; virCheckFlags(VIR_STORAGE_VOL_CREATE_PREALLOC_METADATA | VIR_STORAGE_VOL_CREATE_VALIDATE, NULL); @@ -1953,8 +1954,8 @@ storageVolCreateXML(virStoragePoolPtr pool, voldef->building = true; virObjectUnlock(obj); - buildret = backend->buildVol(obj, buildvoldef, flags); + buildFlags &= ~(VIR_STORAGE_VOL_CREATE_VALIDATE); + buildret = backend->buildVol(obj, buildvoldef, buildFlags); VIR_FREE(buildvoldef); -- 2.48.1

3 8

[PATCH 0/4] qemu: Remove legacy 'nbd-export-add' code and deprecate corresponding capabilities
by Peter Krempa 08 Apr '25

08 Apr '25

Peter Krempa (4): qemu: block: Always assume support for 'block-export-add' qemu: monitor: Drop wrappers for 'nbd-server-add' qemu: capabilities: Retire QEMU_CAPS_BLOCK_EXPORT_ADD qemu: capabilities: Retire QEMU_CAPS_NBD_BITMAP src/qemu/qemu_block.c | 7 ----- src/qemu/qemu_capabilities.c | 6 ++-- src/qemu/qemu_capabilities.h | 4 +-- src/qemu/qemu_monitor.c | 17 ----------- src/qemu/qemu_monitor.h | 5 ---- src/qemu/qemu_monitor_json.c | 28 ------------------- src/qemu/qemu_monitor_json.h | 6 ---- .../caps_10.0.0_s390x.xml | 2 -- .../caps_10.0.0_x86_64+amdsev.xml | 2 -- .../caps_10.0.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 2 -- .../caps_6.2.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 2 -- .../caps_7.0.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 2 -- .../caps_7.1.0_x86_64.xml | 2 -- tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 2 -- .../caps_7.2.0_x86_64+hvf.xml | 2 -- .../caps_7.2.0_x86_64.xml | 2 -- .../caps_8.0.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 2 -- .../caps_8.1.0_x86_64.xml | 2 -- .../caps_8.2.0_aarch64.xml | 2 -- .../caps_8.2.0_armv7l.xml | 2 -- .../caps_8.2.0_loongarch64.xml | 2 -- .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 2 -- .../caps_8.2.0_x86_64.xml | 2 -- .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 2 -- .../caps_9.0.0_x86_64.xml | 2 -- .../caps_9.1.0_riscv64.xml | 2 -- .../qemucapabilitiesdata/caps_9.1.0_s390x.xml | 2 -- .../caps_9.1.0_x86_64.xml | 2 -- .../caps_9.2.0_aarch64+hvf.xml | 2 -- .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 2 -- .../caps_9.2.0_x86_64+amdsev.xml | 2 -- .../caps_9.2.0_x86_64.xml | 2 -- tests/qemumonitorjsontest.c | 2 -- 37 files changed, 4 insertions(+), 129 deletions(-) -- 2.49.0

2 5

[PATCH] docs: drvqemu: Fix required minimum qemu version to 6.2.0
by Peter Krempa 08 Apr '25

08 Apr '25

From: Peter Krempa <pkrempa(a)redhat.com> Commit 8824af826d3 (and also commit 073bf167843 before it) which bumped minimu, qemu version forgot to update the qemu driver documentation page Fixes: 8824af826d3 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/drvqemu.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/drvqemu.rst b/docs/drvqemu.rst index e52d9ffd47..796aae587c 100644 --- a/docs/drvqemu.rst +++ b/docs/drvqemu.rst @@ -5,7 +5,7 @@ QEMU/KVM/HVF hypervisor driver ============================== -The libvirt KVM/QEMU driver can manage any QEMU emulator from version 4.2.0 or +The libvirt KVM/QEMU driver can manage any QEMU emulator from version 6.2.0 or later. It supports multiple QEMU accelerators: software -- 2.49.0

2 1

[PATCH v2 0/2] derpecate some block-job- APIs
by Vladimir Sementsov-Ogievskiy 08 Apr '25

08 Apr '25

v2: Update documentation: add patch 01 v1 was: [PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs Supersedes: <20250401155730.103718-1-vsementsov(a)yandex-team.ru> Vladimir Sementsov-Ogievskiy (2): qapi: synchronize jobs and block-jobs documentation qapi/block-core: derpecate some block-job- APIs docs/about/deprecated.rst | 31 ++++++++++++++ qapi/block-core.json | 89 ++++++++++++++++++++++++++++----------- qapi/job.json | 29 ++++++++++++- 3 files changed, 122 insertions(+), 27 deletions(-) -- 2.48.1

3 7

[PATCH] qemu: rdp: Fix 'qemuRdpAvailable()'
by Peter Krempa 08 Apr '25

08 Apr '25

From: Peter Krempa <pkrempa(a)redhat.com> qemuRdpAvailable() is called from the capability filing code, thus: - it must not report spurious errors - it should not call any extra processes We can solve the above by just checking existance of 'qemu-rdp' in the path as: - at the time of adding of qemuRdpAvailable() there was only one 'qemu-rdp' release - it supported all the features - the check can't change as we'd drop the capability Add comments and gut the check to only check existance of the file. Fixes: f5e5a9bec9ec3e6c762f5000e3b8a0ba6a3a8c8d Closes: https://gitlab.com/libvirt/libvirt/-/issues/763 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_rdp.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_rdp.c b/src/qemu/qemu_rdp.c index 984795d599..0c48b87e7b 100644 --- a/src/qemu/qemu_rdp.c +++ b/src/qemu/qemu_rdp.c @@ -413,12 +413,25 @@ qemuRdpSetCredentials(virDomainObj *vm, } +/** + * qemuRdpAvailable: + * @helper: name (or path to) 'qemu-rdp' binary + * + * Returns whether 'qemu-rdp' is available. + * + * Important: + * This function is called from 'virQEMUDriverGetDomainCapabilities'. It must + * not report any errors and must not add any additional checks. + * + * This function is mocked from 'tests/testutilsqemu.c' + * + */ bool qemuRdpAvailable(const char *helper) { - g_autoptr(qemuRdp) rdp = NULL; - - rdp = qemuRdpNewForHelper(helper); + g_autofree char *helperPath = NULL; - return rdp && qemuRdpHasFeature(rdp, QEMU_RDP_FEATURE_DBUS_ADDRESS); + /* This function was added corresponding to the first release of 'qemu-rdp' + * thus checking existance of the helper binary is sufficient. */ + return !!(helperPath = virFindFileInPath(helper)); } -- 2.49.0

3 2

Re: [PATCH v8 55/55] docs: Add TDX documentation
by Daniel P. Berrangé 08 Apr '25

08 Apr '25

CC libvirt / Jiri, for confirmation about whether the CPUID restrictions listed below will have any possible impact on libvirt CPUID handling... On Tue, Apr 01, 2025 at 09:02:05AM -0400, Xiaoyao Li wrote: > Add docs/system/i386/tdx.rst for TDX support, and add tdx in > confidential-guest-support.rst > > Signed-off-by: Xiaoyao Li <xiaoyao.li(a)intel.com> > --- > Changes in v6: > - Add more information of "Feature configuration" > - Mark TD Attestation as future work because KVM now drops the support > of it. > > Changes in v5: > - Add TD attestation section and update the QEMU parameter; > > Changes since v1: > - Add prerequisite of private gmem; > - update example command to launch TD; > > Changes since RFC v4: > - add the restriction that kernel-irqchip must be split > --- > docs/system/confidential-guest-support.rst | 1 + > docs/system/i386/tdx.rst | 156 +++++++++++++++++++++ > docs/system/target-i386.rst | 1 + > 3 files changed, 158 insertions(+) > create mode 100644 docs/system/i386/tdx.rst > +Feature Configuration > +--------------------- > + > +Unlike non-TDX VM, the CPU features (enumerated by CPU or MSR) of a TD are not > +under full control of VMM. VMM can only configure part of features of a TD on > +``KVM_TDX_INIT_VM`` command of VM scope ``MEMORY_ENCRYPT_OP`` ioctl. > + > +The configurable features have three types: > + > +- Attributes: > + - PKS (bit 30) controls whether Supervisor Protection Keys is exposed to TD, > + which determines related CPUID bit and CR4 bit; > + - PERFMON (bit 63) controls whether PMU is exposed to TD. > + > +- XSAVE related features (XFAM): > + XFAM is a 64b mask, which has the same format as XCR0 or IA32_XSS MSR. It > + determines the set of extended features available for use by the guest TD. > + > +- CPUID features: > + Only some bits of some CPUID leaves are directly configurable by VMM. > + > +What features can be configured is reported via TDX capabilities. > + > +TDX capabilities > +~~~~~~~~~~~~~~~~ > + > +The VM scope ``MEMORY_ENCRYPT_OP`` ioctl provides command ``KVM_TDX_CAPABILITIES`` > +to get the TDX capabilities from KVM. It returns a data structure of > +``struct kvm_tdx_capabilities``, which tells the supported configuration of > +attributes, XFAM and CPUIDs. > + > +TD attributes > +~~~~~~~~~~~~~ > + > +QEMU supports configuring raw 64-bit TD attributes directly via "attributes" > +property of "tdx-guest" object. Note, it's users' responsibility to provide a > +valid value because some bits may not supported by current QEMU or KVM yet. > + > +QEMU also supports the configuration of individual attribute bits that are > +supported by it, via properties of "tdx-guest" object. > +E.g., "sept-ve-disable" (bit 28). > + > +MSR based features > +~~~~~~~~~~~~~~~~~~ > + > +Current KVM doesn't support MSR based feature (e.g., MSR_IA32_ARCH_CAPABILITIES) > +configuration for TDX, and it's a future work to enable it in QEMU when KVM adds > +support of it. > + > +Feature check > +~~~~~~~~~~~~~ > + > +QEMU checks if the final (CPU) features, determined by given cpu model and > +explicit feature adjustment of "+featureA/-featureB", can be supported or not. > +It can produce feature not supported warning like > + > + "warning: host doesn't support requested feature: CPUID.07H:EBX.intel-pt [bit 25]" > + > +It can also produce warning like > + > + "warning: TDX forcibly sets the feature: CPUID.80000007H:EDX.invtsc [bit 8]" > + > +if the fixed-1 feature is requested to be disabled explicitly. This is newly > +added to QEMU for TDX because TDX has fixed-1 features that are forcibly enabled > +by TDX module and VMM cannot disable them. This is where I'm wondering if libvirt has anything to be concerned about. Possibly when libvirt queries the actual CPUID after launching the guest it will just "do the right thing" ? Wondering if there's any need for libvirt to be aware of CPUID restrictions before that point though ? > + > +Launching a TD (TDX VM) > +----------------------- > + > +To launch a TD, the necessary command line options are tdx-guest object and > +split kernel-irqchip, as below: > + > +.. parsed-literal:: > + > + |qemu_system_x86| \\ > + -object tdx-guest,id=tdx0 \\ > + -machine ...,kernel-irqchip=split,confidential-guest-support=tdx0 \\ > + -bios OVMF.fd \\ I don't think we need to show 'kernel-irqchip=split' now that we "do the right thing" by default This surely also ought to include '-accel kvm', as IIUC there's no TCG support for TDX. And presumably '-cpu host', since QEMU's default 'qemu64' CPU model is likely a terrible match for what TDX will force set. > + > +Restrictions > +------------ > + > + - kernel-irqchip must be split; Can append "This is set by default for TDX guests if kernel-irqchip is left on its default 'auto' setting." > + > + - No readonly support for private memory; > + > + - No SMM support: SMM support requires manipulating the guest register states > + which is not allowed; > + With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

3 2

[PATCH v3 00/20] Add qemu RDP server support
by marcandre.lureau＠redhat.com 07 Apr '25

07 Apr '25

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Hi, This patch series offers an out-of-process Remote Desktop Protocol (RDP) server solution utilizing QEMU's -display dbus interface, offering improved modularity and potential security benefits compared to built-in server. This initiative was spearheaded by Mihnea Buzatu during the QEMU Summer of Code 2023. The project's goal was to develop an out-of-process RDP server using the -display dbus interface, implemented in Rust. Given that the IronRDP crate lacked some server support at the time, investments in IronRDP were required. I finally released an initial v0.1 version of qemu-rdp on crates.io (https://crates.io/crates/qemu-rdp) That should allow more people to review and evaluate the state of this work. On unix systems, with cargo/rust toolchain installed, it should be as easy as running "cargo install qemu-rdp", apply this patch series for libvirt, set the "rdp_tls_x509_cert_dir" location for your TLS certificates, and configure a VM with both dbus & rdp graphics (run "virsh domdisplay DOMAIN" to get the display connection details). Thanks for the reviews & feedback! v3: thanks to Martin Kletzander review - drop "[PATCH v2 05/21] qemu: fall-through for unsupported graphics" patch - drop extra \n when reporting dbus-daemon log - check password != NULL or VIR_ERR_INTERNAL_ERROR - remove some needless #include/leftover - remove some needless g_auto pointer - rebased - add r-b tags v2: thanks to Daniel review - drop extra error report from "qemu: report an error for unsupported graphics" - replace g_return pre-conditions with ATTRIBUTE_NONNULL - improve "qemu/dbus: keep a connection to the VM D-Bus" to also reconnect - use domainLogContext for logging (for virtiofs as well) - check for qemu-rdp availabilty for setting 'rdp' capability - make dbus-addr qemu-rdp capability mandatory - rebased - add r-b tags Marc-André Lureau (20): build-sys: drop -Winline when optimization=g build: fix -Werror=maybe-uninitialized qemu-slirp: drop unneeded check for OOM util: annotate non-null arguments for virGDBusCallMethod() qemu: add rdp state directory qemu: add qemu RDP configuration conf: parse optional RDP username & password conf: generalize virDomainDefHasSpiceGraphics qemu: use virDomainDefHasGraphics qemu: add RDP ports range allocator qemu: limit to one <graphics type='rdp'> qemu/virtiofs: use domainLogContext qemu/dbus: keep a connection to the VM D-Bus qemu/dbus: log daemon stdout/err, use domainLogContext qemu: validate RDP configuration qemu: add qemu-rdp helper unit qemu: pass virQEMUDriverConfig to capabilities qemu: add 'rdp' capability if qemu-rdp is available qemu: add RDP support tests: add qemu <graphics type='rdp'/> test docs/formatdomain.rst | 25 +- meson.build | 7 +- po/POTFILES | 1 + src/conf/domain_conf.c | 28 +- src/conf/domain_conf.h | 5 +- src/conf/schemas/domaincommon.rng | 10 + src/libvirt_private.syms | 2 +- src/qemu/libvirtd_qemu.aug | 7 + src/qemu/meson.build | 1 + src/qemu/qemu.conf.in | 31 ++ src/qemu/qemu_capabilities.c | 24 +- src/qemu/qemu_capabilities.h | 12 +- src/qemu/qemu_command.c | 8 +- src/qemu/qemu_conf.c | 56 ++- src/qemu/qemu_conf.h | 13 + src/qemu/qemu_dbus.c | 69 ++- src/qemu/qemu_dbus.h | 3 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 4 + src/qemu/qemu_driver.c | 20 + src/qemu/qemu_extdevice.c | 46 +- src/qemu/qemu_hotplug.c | 51 ++- src/qemu/qemu_hotplug.h | 1 + src/qemu/qemu_process.c | 169 ++++++- src/qemu/qemu_rdp.c | 424 ++++++++++++++++++ src/qemu/qemu_rdp.h | 73 +++ src/qemu/qemu_slirp.c | 6 - src/qemu/qemu_validate.c | 48 +- src/qemu/qemu_virtiofs.c | 53 +-- src/qemu/test_libvirtd_qemu.aug.in | 5 + src/util/virgdbus.h | 13 +- .../qemu_10.0.0-q35.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_10.0.0-q35.x86_64.xml | 1 + .../qemu_10.0.0-tcg.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_10.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_10.0.0.s390x.xml | 1 + .../qemu_10.0.0.x86_64+amdsev.xml | 1 + tests/domaincapsdata/qemu_10.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_7.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.1.0.x86_64.xml | 1 + .../qemu_7.2.0-hvf.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-q35.x86_64.xml | 1 + .../qemu_7.2.0-tcg.x86_64+hvf.xml | 1 + .../domaincapsdata/qemu_7.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_7.2.0.ppc.xml | 1 + tests/domaincapsdata/qemu_7.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_8.2.0-q35.x86_64.xml | 1 + .../qemu_8.2.0-tcg-virt.loongarch64.xml | 1 + .../domaincapsdata/qemu_8.2.0-tcg.x86_64.xml | 1 + .../qemu_8.2.0-virt.aarch64.xml | 1 + .../qemu_8.2.0-virt.loongarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_8.2.0.armv7l.xml | 1 + tests/domaincapsdata/qemu_8.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_8.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_9.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.0.0.sparc.xml | 1 + tests/domaincapsdata/qemu_9.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_9.1.0-q35.x86_64.xml | 1 + .../qemu_9.1.0-tcg-virt.riscv64.xml | 1 + .../domaincapsdata/qemu_9.1.0-tcg.x86_64.xml | 1 + .../qemu_9.1.0-virt.riscv64.xml | 1 + tests/domaincapsdata/qemu_9.1.0.s390x.xml | 1 + tests/domaincapsdata/qemu_9.1.0.x86_64.xml | 1 + .../qemu_9.2.0-hvf.aarch64+hvf.xml | 1 + .../qemu_9.2.0-q35.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_9.2.0-q35.x86_64.xml | 1 + .../qemu_9.2.0-tcg.x86_64+amdsev.xml | 1 + .../domaincapsdata/qemu_9.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_9.2.0.s390x.xml | 1 + .../qemu_9.2.0.x86_64+amdsev.xml | 1 + tests/domaincapsdata/qemu_9.2.0.x86_64.xml | 1 + tests/domaincapstest.c | 7 +- .../graphics-rdp.x86_64-latest.args | 35 ++ .../graphics-rdp.x86_64-latest.xml | 1 + tests/qemuxmlconfdata/graphics-rdp.xml | 43 ++ tests/qemuxmlconftest.c | 2 + tests/testutilsqemu.c | 10 + tools/nss/libvirt_nss_leases.c | 2 +- tools/nss/libvirt_nss_macs.c | 2 +- 92 files changed, 1234 insertions(+), 137 deletions(-) create mode 100644 src/qemu/qemu_rdp.c create mode 100644 src/qemu/qemu_rdp.h create mode 100644 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.args create mode 120000 tests/qemuxmlconfdata/graphics-rdp.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/graphics-rdp.xml -- 2.47.0

5 26

[PATCH 0/3] cpu_map: Install Ampere-1 ARM CPU models
by Jiri Denemark 07 Apr '25

07 Apr '25

BTW, the added test will not actually detect similar issues in the future (I'm thinking about such test, though), but it will help with other issues with the ARM CPU map as it hasn't been covered at all. Jiri Denemark (3): tests: Add a basic CPU test for aarch64 cpu_map: Install Ampere-1 ARM CPU models NEWS: Document ARM CPU map bug fix NEWS.rst | 6 +++++ src/cpu_map/meson.build | 2 ++ tests/cputest.c | 35 +++++++++++++++++++++++++++++ tests/cputestdata/aarch64-guest.xml | 4 ++++ 4 files changed, 47 insertions(+) create mode 100644 tests/cputestdata/aarch64-guest.xml -- 2.49.0

4 6

[PATCH v1 00/18] LIBVIRT: X86: TDX support
by Zhenzhong Duan 07 Apr '25

07 Apr '25

Hi, This series brings libvirt the x86 TDX support. * What's TDX? TDX stands for Trust Domain Extensions which isolates VMs from the virtual-machine manager (VMM)/hypervisor and any other software on the platform. This patchset extends libvirt to support TDX, with which one can start a TDX guest from high level rather than running qemu directly. * Misc As QEMU use a software emulated way to reset guest which isn't supported by TDX guest for security reason. We simulate reboot for TDX guest by kill and create a new one in FakeReboot framework. Complete code can be found at [1], matching qemu code can be found at [2]. There is a 'QGS' element for attestation which isn't in matching qemu[2] yet. I keep them intentionally as they will be implemented in qemu as extention series of [2]. * Test start/stop/reboot/reset with virsh stop/reboot trigger in guest stop with on_poweroff=destroy/restart reboot with on_reboot=destroy/restart * Patch organization - patch 1-4: Support query of TDX capabilities - patch 5-11: Add TDX type to launchsecurity framework - patch 12-17: Add reboot/reset support to TDX guest - patch 18: Add docs TODO: - add reconnect logic in virsh command [1] https://github.com/intel/libvirt-tdx/commits/tdx_for_upstream_v1 [2] https://github.com/intel-staging/qemu-tdx/tree/tdx-qemu-upstream-v8 Thanks Zhenzhong Changelog: v1: - s/virQEMUCapsKVMSupportsSecureGuestINTEL/virQEMUCapsKVMSupportsSecureGuestTDX (Daniel) - make policy element optional and expose to QEMU directly (Daniel) - s/qemuProcessSecFakeReboot/qemuProcessFakeRebootViaRecreate (Daniel) - simplify QGS element schema by supporting only UNIX socket (Daniel) - add new events VIR_DOMAIN_EVENT_[STOPPED|STARTED] for control plane (Daniel) - s/quoteGenerationService/quoteGenerationSocket as QEMU - add virsh reset support rfcv4: - add a check to tools/virt-host-validate-qemu.c (Daniel) - remove check of q35 (Daniel) - model 'SocktetAddress' QAPI in xml schema (Daniel) - s/Quote-Generation-Service/quoteGenerationService/ (Daniel) - define bits in tdx->policy and add validating logic (Daniel) - presume QEMU choose split kernel irqchip for TDX guest by default (Daniel) - utilize existing FakeReboot framework to do reboot for TDX guest (Daniel) - drop patch11 'conf: Add support to keep same domid for hard reboot' (Daniel) - add test in tests/ to validate parsing and formatting logic (Daniel) - add doc in docs/formatdomain.rst (Daniel) - add R-B rfcv3: - Change to generate qemu cmdline with -bios - drop firmware auto match as -bios is used - add a hard reboot method to reboot TDX guest rfcv3: https://www.mail-archive.com/devel@lists.libvirt.org/msg00385.html rfcv2: - give up using qmp cmd and check TDX directly on host for TDX capabilities. - use launchsecurity framework to support TDX - use <os>.<loader> for general loader - add auto firmware match feature for TDX A example TDVF fimware description file 70-edk2-x86_64-tdx.json: { "description": "UEFI firmware for x86_64, supporting Intel TDX", "interface-types": [ "uefi" ], "mapping": { "device": "generic", "filename": "/usr/share/OVMF/OVMF_CODE-tdx.fd" }, "targets": [ { "architecture": "x86_64", "machines": [ "pc-q35-*" ] } ], "features": [ "intel-tdx", "verbose-dynamic" ], "tags": [ ] } rfcv2: https://www.mail-archive.com/libvir-list@redhat.com/msg219378.html Zhenzhong Duan (18): tools: Secure guest check for Intel in virt-host-validate qemu: Check if INTEL Trust Domain Extention support is enabled qemu: Add TDX capability conf: Expose TDX feature in domain capabilities conf: Add tdx as launch security type conf: Validate TDX launchSecurity element mrConfigId/mrOwner/mrOwnerConfig qemu: Add command line and validation for TDX type conf: Expose TDX type in domain launch security capability qemu: Force special parameters enabled for TDX guest conf: Add Intel TDX Quote Generation Service(QGS) support qemu: Add command line for TDX Quote Generation Service(QGS) qemu: Add FakeReboot support for TDX guest qemu: Support reboot command in guest qemu: Avoid duplicate FakeReboot for secure guest qemu: Send event VIR_DOMAIN_EVENT_[STOPPED|STARTED] during recreation qemu: Bypass sending VIR_DOMAIN_EVENT_RESUMED event when TD VM reboot qemu: Support domain reset command for TDX guest docs: domain: Add documentation for Intel TDX guest docs/formatdomain.rst | 63 ++++++++++++++++++ docs/formatdomaincaps.rst | 1 + examples/c/misc/event-test.c | 6 ++ include/libvirt/libvirt-domain.h | 2 + src/conf/domain_capabilities.c | 1 + src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 82 +++++++++++++++++++++++ src/conf/domain_conf.h | 21 ++++++ src/conf/domain_validate.c | 11 ++++ src/conf/schemas/domaincaps.rng | 9 +++ src/conf/schemas/domaincommon.rng | 41 ++++++++++++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 38 ++++++++++- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 1 + src/qemu/qemu_command.c | 54 +++++++++++++++ src/qemu/qemu_driver.c | 7 ++ src/qemu/qemu_firmware.c | 1 + src/qemu/qemu_monitor.c | 28 +++++++- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 6 +- src/qemu/qemu_namespace.c | 1 + src/qemu/qemu_process.c | 105 ++++++++++++++++++++++++++++-- src/qemu/qemu_process.h | 2 + src/qemu/qemu_validate.c | 45 +++++++++++++ src/security/security_dac.c | 2 + tools/virsh-domain-event.c | 6 +- tools/virt-host-validate-common.c | 31 ++++++++- tools/virt-host-validate-common.h | 1 + 29 files changed, 558 insertions(+), 13 deletions(-) -- 2.34.1

3 20

[PATCH] [for-10.1] qapi/block-core: derpecate some block-job- APIs
by Vladimir Sementsov-Ogievskiy 05 Apr '25

05 Apr '25

For change, pause, resume, complete, dismiss and finalize actions corresponding job- and block-job commands are almost equal. The difference is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() do check, is found job a block-job. This OK when moving to more generic API, no needs to document this change. 2. find_block_job_locked() reports DeviceNotActive on failure, when find_job_locked() reports GenericError. So, lets document this difference in deprecated.txt. Still, for dismiss and finalize errors are not documented at all, so be silent in deprecated.txt as well. Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov(a)yandex-team.ru> --- Hi all! That's a continuation of my "[RFC 00/15] block job API"[1], exactly, the simplest part of it - deprecating block-job-* commands which simply duplicate job-* ones. Note that the old series was started with trying to introduce job-change command as substitution to both block-job-change (which only can change mirror copy-mode parameter), and block-job-set-speed. It was rather complicated and controversial attempt, which latest implemenation was "[PATCH v3 0/7] introduce job-change qmp command"[2]. In [2] Kevin noted, that we'd better follow existing blockdev-reopen approach of changing options (i.e. specify all options) than introduce a new one. But, on the other hand, now I'm afraid, that rewriting in third tools simple call to (old good) block-job-set-speed into job-change(_all_options_ + changed speed) is too much work just for "having nice interface". And too much for the only two options we want to change. So, let's just start from something more obvious. Finally, we can simple keep block-job-set-speed and block-job-change as is, as they (unlike other block-job-* commands) are not duplicated by similar job-* commands. [1] https://patchew.org/QEMU/20240313150907.623462-1-vsementsov@yandex-team.ru/ [2] https://patchew.org/QEMU/20241002140616.561652-1-vsementsov@yandex-team.ru/ docs/about/deprecated.rst | 31 +++++++++++++++++++++++++++++++ qapi/block-core.json | 30 ++++++++++++++++++++++++++++++ 2 files changed, 61 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index e2b4f077d4..eed3356359 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -148,6 +148,37 @@ options are removed in favor of using explicit ``blockdev-create`` and ``blockdev-add`` calls. See :doc:`/interop/live-block-operations` for details. +``block-job-pause`` (since 10.1) +''''''''''''''''''''''''''''''' + +Use ``job-pause`` instead. The only difference is that ``job-pause`` +always reports GenericError on failure when ``block-job-pause`` reports +DeviceNotActive when block-job is not found. + +``block-job-resume`` (since 10.1) +'''''''''''''''''''''''''''''''' + +Use ``job-resume`` instead. The only difference is that ``job-resume`` +always reports GenericError on failure when ``block-job-resume`` reports +DeviceNotActive when block-job is not found. + +``block-job-complete`` (since 10.1) +'''''''''''''''''''''''''''''''''' + +Use ``job-complete`` instead. The only difference is that ``job-complete`` +always reports GenericError on failure when ``block-job-complete`` reports +DeviceNotActive when block-job is not found. + +``block-job-dismiss`` (since 10.1) +''''''''''''''''''''''''''''''''' + +Use ``job-dismiss`` instead. + +``block-job-finalize`` (since 10.1) +'''''''''''''''''''''''''''''''''' + +Use ``job-finalize`` instead. + ``query-migrationthreads`` (since 9.2) '''''''''''''''''''''''''''''''''''''' diff --git a/qapi/block-core.json b/qapi/block-core.json index b1937780e1..264be8413b 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2968,6 +2968,11 @@ # the name of the parameter), but since QEMU 2.7 it can have other # values. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-pause +# instead. +# # Errors: # - If no background operation is active on this device, # DeviceNotActive @@ -2975,6 +2980,7 @@ # Since: 1.3 ## { 'command': 'block-job-pause', 'data': { 'device': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -2992,6 +2998,11 @@ # the name of the parameter), but since QEMU 2.7 it can have other # values. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-resume +# instead. +# # Errors: # - If no background operation is active on this device, # DeviceNotActive @@ -2999,6 +3010,7 @@ # Since: 1.3 ## { 'command': 'block-job-resume', 'data': { 'device': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -3023,6 +3035,11 @@ # the name of the parameter), but since QEMU 2.7 it can have other # values. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-complete +# instead. +# # Errors: # - If no background operation is active on this device, # DeviceNotActive @@ -3030,6 +3047,7 @@ # Since: 1.3 ## { 'command': 'block-job-complete', 'data': { 'device': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -3047,9 +3065,15 @@ # # @id: The job identifier. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-dismiss +# instead. +# # Since: 2.12 ## { 'command': 'block-job-dismiss', 'data': { 'id': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## @@ -3064,9 +3088,15 @@ # # @id: The job identifier. # +# Features: +# +# @deprecated: This command is deprecated. Use @job-finalize +# instead. +# # Since: 2.12 ## { 'command': 'block-job-finalize', 'data': { 'id': 'str' }, + 'features': ['deprecated'], 'allow-preconfig': true } ## -- 2.48.1

3 6

[PATCH 0/8] Decrease stack size below 2048 bytes
by Michal Privoznik 04 Apr '25

04 Apr '25

Inspired by Roman's patch: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/FNAF… There are two functions where clang produces stack greater than 2048 bytes (our current limit - see @stack_frame_size in meson.build): 1) doRemoteOpen() 2) vboxSnapshotRedefine() It took me a while to realize why a function with a dozen variables requires ~2300 bytes of stack, until the usual suspect turned in - glib. Anyway, green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/1752604895 and I've verified this compiles cleanly on my FreeBSD-14.1-RELEASE-p4 VM. Michal Prívozník (8): remote_driver: Move URI arg extraction into a separate function doRemoteOpen: Move RPC talk to a separate function doRemoteOpen: Drop needless typecast of @transport vbox: Move parts of vboxSnapshotRedefine() into a separate function vbox: Move parts of vboxSnapshotRedefine() into a separate function vbox: Move parts of vboxSnapshotRedefine() into a separate function vbox: Move parts of vboxSnapshotRedefine() into a separate function meson: Drop workaround for -Wframe-larger-than and clang meson.build | 5 - src/remote/remote_driver.c | 182 ++++--- src/vbox/vbox_common.c | 946 ++++++++++++++++++++----------------- 3 files changed, 636 insertions(+), 497 deletions(-) -- 2.49.0

3 10

[PATCH] build: clang stack frame size handling improvement
by Roman Bogorodskiy 04 Apr '25

04 Apr '25

The 'plain' optimization type also triggers the clang stack frame size issues, so increase limit for it as well. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 56823ca25b..0a402a19a2 100644 --- a/meson.build +++ b/meson.build @@ -259,7 +259,7 @@ alloc_max = run_command( stack_frame_size = 2048 # clang without optimization enlarges stack frames in certain corner cases -if cc.get_id() == 'clang' and get_option('optimization') == '0' +if cc.get_id() == 'clang' and get_option('optimization') in ['plain', '0'] stack_frame_size = 4096 endif -- 2.49.0

3 7

[PATCH 0/2] docs: Improve ability to select proper API/XML section
by Peter Krempa 04 Apr '25

04 Apr '25

Browse the result at: https://pipo.sk.gitlab.io/-/libvirt/-/jobs/9603174377/artifacts/website/doc… (The security warning happens as my username on gitlab contains a dot.) Peter Krempa (2): docs: Re-order XML schema after API documentation on 'docs' page docs: Render API and XML sections one per line in HTML docs/css/libvirt.css | 11 +++++++ docs/docs.rst | 75 +++++++++++++++++++++++--------------------- 2 files changed, 51 insertions(+), 35 deletions(-) -- 2.49.0

2 4

[PATCH 0/3] ch: Misc fixes
by Michal Privoznik 04 Apr '25

04 Apr '25

*** BLURB HERE *** Michal Prívozník (3): ch: Use CH_DOMAIN_PRIVATE() more ch: Drop pid from monitor ch: Fix printf format strings wrt size_t argument src/ch/ch_events.c | 4 ++-- src/ch/ch_monitor.c | 14 ++++---------- src/ch/ch_monitor.h | 2 -- src/ch/ch_process.c | 11 +++++------ 4 files changed, 11 insertions(+), 20 deletions(-) -- 2.49.0

2 4

[PATCH] libxl_conf: Implement hyperv domain flags for Xen
by Will 04 Apr '25

04 Apr '25

Adds support for configuring <hyperv/> flags for domains running under Xen. The following flags, making use of QEMU's existing flags, are now configurable for Xen: vapic, synic, stimer, frequencies, tlbflush and ipi Tests have been added validating translation to libxl's viridian flags Updated docs section on <hyperv/> flags to note support and to specify which flags work with Xen Signed-off-by: Will <tcosprojects(a)gmail.com> --- NEWS.rst | 5 + docs/formatdomain.rst | 20 +-- src/libxl/libxl_conf.c | 90 ++++++++++ .../viridian-hvm-full.json | 101 ++++++++++++ .../viridian-hvm-full.xml | 45 +++++ .../viridian-hvm-none.json | 89 ++++++++++ .../viridian-hvm-none.xml | 36 ++++ .../libxlxml2domconfigdata/viridian-hvm.json | 99 +++++++++++ tests/libxlxml2domconfigdata/viridian-hvm.xml | 42 +++++ .../viridian-passthrough.json | 155 ++++++++++++++++++ .../viridian-passthrough.xml | 37 +++++ tests/libxlxml2domconfigtest.c | 9 + 12 files changed, 718 insertions(+), 10 deletions(-) create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-full.json create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-full.xml create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-none.json create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm-none.xml create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm.json create mode 100644 tests/libxlxml2domconfigdata/viridian-hvm.xml create mode 100644 tests/libxlxml2domconfigdata/viridian-passthrough.json create mode 100644 tests/libxlxml2domconfigdata/viridian-passthrough.xml diff --git a/NEWS.rst b/NEWS.rst index 9c940b1a81..d6ad961f56 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,11 @@ v11.2.0 (unreleased) * **New features** + * Support for configuration of ``<hyperv/>`` flags for Xen domains. + + The following flags are now configurable for Xen: ``vapic``, ``synic``, + ``stimer``, ``frequencies``, ``tlbflush`` and ``ipi``. + * **Improvements** * **Bug fixes** diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index cbe378e61d..4162ae7930 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -2084,31 +2084,31 @@ are: based virtualization drivers, such as LXC. ``hyperv`` Enable various features improving behavior of guests running Microsoft - Windows. + Windows. :since:`Since 11.2.0` some of these flags are also available for Xen domains running Microsoft Windows. =============== ====================================================================== ============================================ ======================================================================== Feature Description Value Since =============== ====================================================================== ============================================ ======================================================================== - relaxed Relax constraints on timers on, off :since:`1.0.0 (QEMU 2.0)` - vapic Enable virtual APIC on, off :since:`1.1.0 (QEMU 2.0)` + relaxed Relax constraints on timers on, off :since:`1.0.0 (QEMU 2.0), 11.2.0 (Xen, always on)` + vapic Enable virtual APIC on, off :since:`1.1.0 (QEMU 2.0), 11.2.0 (Xen)` spinlocks Enable spinlock support on, off; retries - at least 4095 :since:`1.1.0 (QEMU 2.0)` - vpindex Virtual processor index on, off :since:`1.3.3 (QEMU 2.5)` + vpindex Virtual processor index on, off :since:`1.3.3 (QEMU 2.5), 11.2.0 (Xen, always on)` runtime Processor time spent on running guest code and on behalf of guest code on, off :since:`1.3.3 (QEMU 2.5)` - synic Enable Synthetic Interrupt Controller (SynIC) on, off :since:`1.3.3 (QEMU 2.6)` - stimer Enable SynIC timers, optionally with Direct Mode support on, off; direct - on,off :since:`1.3.3 (QEMU 2.6), direct mode 5.7.0 (QEMU 4.1)` + synic Enable Synthetic Interrupt Controller (SynIC) on, off :since:`1.3.3 (QEMU 2.6), 11.2.0 (Xen)` + stimer Enable SynIC timers, optionally with Direct Mode support on, off; direct - on,off :since:`1.3.3 (QEMU 2.6), direct mode 5.7.0 (QEMU 4.1), 11.2.0 (Xen, on/off only)` reset Enable hypervisor reset on, off :since:`1.3.3 (QEMU 2.5)` vendor_id Set hypervisor vendor id on, off; value - string, up to 12 characters :since:`1.3.3 (QEMU 2.5)` - frequencies Expose frequency MSRs on, off :since:`4.7.0 (QEMU 2.12)` + frequencies Expose frequency MSRs on, off :since:`4.7.0 (QEMU 2.12), 11.2.0 (Xen)` reenlightenment Enable re-enlightenment notification on migration on, off :since:`4.7.0 (QEMU 3.0)` - tlbflush Enable PV TLB flush support on, off; direct - on,off; extended - on,off :since:`4.7.0 (QEMU 3.0), direct and extended modes 11.0.0 (QEMU 7.1.0)` - ipi Enable PV IPI support on, off :since:`4.10.0 (QEMU 3.1)` + tlbflush Enable PV TLB flush support on, off; direct - on,off; extended - on,off :since:`4.7.0 (QEMU 3.0), direct and extended modes 11.0.0 (QEMU 7.1.0), 11.2.0 (Xen, on/off only)` + ipi Enable PV IPI support on, off :since:`4.10.0 (QEMU 3.1), 11.2.0 (Xen)` evmcs Enable Enlightened VMCS on, off :since:`4.10.0 (QEMU 3.1)` avic Enable use Hyper-V SynIC with hardware APICv/AVIC on, off :since:`8.10.0 (QEMU 6.2)` emsr_bitmap Avoid unnecessary updates to L2 MSR Bitmap upon vmexits. on, off :since:`10.7.0 (QEMU 7.1)` xmm_input Enable XMM Fast Hypercall Input on, off :since:`10.7.0 (QEMU 7.1)` =============== ====================================================================== ============================================ ======================================================================== - :since:`Since 8.0.0`, the hypervisor can be configured further by setting + :since:`Since 8.0.0 (QEMU) Since 11.2.0 (Xen)`, the hypervisor can be configured further by setting the ``mode`` attribute to one of the following values: ``custom`` diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index c404226e43..d79cf93573 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -582,6 +582,96 @@ libxlMakeDomBuildInfo(virDomainDef *def, VIR_TRISTATE_SWITCH_ON); #endif +#ifdef LIBXL_HAVE_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE + if (def->features[VIR_DOMAIN_FEATURE_HYPERV] != VIR_DOMAIN_HYPERV_MODE_NONE) { + libxl_bitmap_alloc(ctx, &b_info->u.hvm.viridian_enable, + LIBXL_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE_WIDTH); + + switch ((virDomainHyperVMode) def->features[VIR_DOMAIN_FEATURE_HYPERV]) { + case VIR_DOMAIN_HYPERV_MODE_CUSTOM: + // Base is required by Xen to enable any other flag + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_BASE); + // Enable crash ctl register by default to allow guest logs to reach Xen + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_CRASH_CTL); + break; + case VIR_DOMAIN_HYPERV_MODE_PASSTHROUGH: + libxl_bitmap_set_any(&b_info->u.hvm.viridian_enable); + break; + case VIR_DOMAIN_HYPERV_MODE_NONE: + case VIR_DOMAIN_HYPERV_MODE_LAST: + default: + virReportEnumRangeError(virDomainHyperVMode, + def->features[VIR_DOMAIN_FEATURE_HYPERV]); + return -1; + } + + for (i = 0; i < VIR_DOMAIN_HYPERV_LAST; i++) { + switch ((virDomainHyperv) i) { + case VIR_DOMAIN_HYPERV_VPINDEX: + case VIR_DOMAIN_HYPERV_RELAXED: + // Already set by base flag + break; + case VIR_DOMAIN_HYPERV_SYNIC: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_SYNIC); + } + break; + case VIR_DOMAIN_HYPERV_STIMER: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + // STIMER implies synic and clock features + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_STIMER); + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_SYNIC); + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_TIME_REF_COUNT); + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_REFERENCE_TSC); + } + break; + case VIR_DOMAIN_HYPERV_VAPIC: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_APIC_ASSIST); + } + break; + case VIR_DOMAIN_HYPERV_FREQUENCIES: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_FREQ); + } + break; + case VIR_DOMAIN_HYPERV_TLBFLUSH: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_HCALL_REMOTE_TLB_FLUSH); + } + break; + case VIR_DOMAIN_HYPERV_IPI: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + libxl_bitmap_set(&b_info->u.hvm.viridian_enable, LIBXL_VIRIDIAN_ENLIGHTENMENT_HCALL_IPI); + } + break; + case VIR_DOMAIN_HYPERV_SPINLOCKS: + case VIR_DOMAIN_HYPERV_VENDOR_ID: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + const char *name = virDomainHypervTypeToString(i); + VIR_WARN("Hyper-v flag '%s' is specified per-domain but is a global Xen setting and will be ignored.", name); + } + break; + case VIR_DOMAIN_HYPERV_RUNTIME: + case VIR_DOMAIN_HYPERV_RESET: + case VIR_DOMAIN_HYPERV_REENLIGHTENMENT: + case VIR_DOMAIN_HYPERV_EVMCS: + case VIR_DOMAIN_HYPERV_AVIC: + case VIR_DOMAIN_HYPERV_EMSR_BITMAP: + case VIR_DOMAIN_HYPERV_XMM_INPUT: + if (def->hyperv_features[i] == VIR_TRISTATE_SWITCH_ON) { + const char *name = virDomainHypervTypeToString(i); + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Hyper-v enlightenment feature '%1$s' is not supported for Xen domains."), name); + } + break; + case VIR_DOMAIN_HYPERV_LAST: + break; + } + } + } +#endif + /* copy SLIC table path to acpi_firmware */ b_info->u.hvm.acpi_firmware = g_strdup(def->os.slic_table); diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-full.json b/tests/libxlxml2domconfigdata/viridian-hvm-full.json new file mode 100644 index 0000000000..5cb69f7b5d --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-full.json @@ -0,0 +1,101 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "viridian_enable": [ + 0, + 1, + 2, + 3, + 4, + 5, + 6, + 7, + 8, + 9 + ], + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-full.xml b/tests/libxlxml2domconfigdata/viridian-hvm-full.xml new file mode 100644 index 0000000000..17f5ed5209 --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-full.xml @@ -0,0 +1,45 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + <hyperv> + <vapic state='on'/> + <vpindex state='on'/> + <synic state='on'/> + <stimer state='on'/> + <frequencies state='on'/> + <tlbflush state='on'/> + <ipi state='on'/> + </hyperv> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-none.json b/tests/libxlxml2domconfigdata/viridian-hvm-none.json new file mode 100644 index 0000000000..d30875420d --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-none.json @@ -0,0 +1,89 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-hvm-none.xml b/tests/libxlxml2domconfigdata/viridian-hvm-none.xml new file mode 100644 index 0000000000..68c2ef08af --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm-none.xml @@ -0,0 +1,36 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigdata/viridian-hvm.json b/tests/libxlxml2domconfigdata/viridian-hvm.json new file mode 100644 index 0000000000..4f9a52ed89 --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm.json @@ -0,0 +1,99 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "viridian_enable": [ + 0, + 2, + 3, + 4, + 6, + 7, + 8, + 9 + ], + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-hvm.xml b/tests/libxlxml2domconfigdata/viridian-hvm.xml new file mode 100644 index 0000000000..c6139885aa --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-hvm.xml @@ -0,0 +1,42 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + <hyperv mode="custom"> + <synic state='on'/> + <stimer state='on'/> + <tlbflush state='on'/> + <ipi state='on'/> + </hyperv> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigdata/viridian-passthrough.json b/tests/libxlxml2domconfigdata/viridian-passthrough.json new file mode 100644 index 0000000000..66069931f6 --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-passthrough.json @@ -0,0 +1,155 @@ +{ + "c_info": { + "type": "hvm", + "name": "test-hvm", + "uuid": "2147d599-9cc6-c0dc-92ab-4064b5446e9b" + }, + "b_info": { + "max_vcpus": 4, + "avail_vcpus": [ + 0, + 1, + 2, + 3 + ], + "max_memkb": 1048576, + "target_memkb": 1048576, + "video_memkb": 8192, + "shadow_memkb": 1234, + "device_model_version": "qemu_xen", + "device_model": "/bin/true", + "sched_params": { + + }, + "apic": "True", + "acpi": "True", + "type.hvm": { + "pae": "True", + "viridian_enable": [ + 0, + 1, + 2, + 3, + 4, + 5, + 6, + 7, + 8, + 9, + 10, + 11, + 12, + 13, + 14, + 15, + 16, + 17, + 18, + 19, + 20, + 21, + 22, + 23, + 24, + 25, + 26, + 27, + 28, + 29, + 30, + 31, + 32, + 33, + 34, + 35, + 36, + 37, + 38, + 39, + 40, + 41, + 42, + 43, + 44, + 45, + 46, + 47, + 48, + 49, + 50, + 51, + 52, + 53, + 54, + 55, + 56, + 57, + 58, + 59, + 60, + 61, + 62, + 63 + ], + "vga": { + "kind": "cirrus" + }, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + }, + "spice": { + + }, + "boot": "c", + "rdm": { + + } + }, + "arch_arm": { + + } + }, + "disks": [ + { + "pdev_path": "/var/lib/xen/images/test-hvm.img", + "vdev": "hda", + "backend": "qdisk", + "format": "raw", + "removable": 1, + "readwrite": 1 + } + ], + "nics": [ + { + "devid": 0, + "mac": "00:16:3e:66:12:b4", + "bridge": "br0", + "script": "/etc/xen/scripts/vif-bridge", + "nictype": "vif_ioemu" + } + ], + "vfbs": [ + { + "devid": -1, + "vnc": { + "enable": "True", + "listen": "0.0.0.0", + "findunused": "False" + }, + "sdl": { + "enable": "False" + } + } + ], + "vkbs": [ + { + "devid": -1 + } + ], + "on_reboot": "restart" +} diff --git a/tests/libxlxml2domconfigdata/viridian-passthrough.xml b/tests/libxlxml2domconfigdata/viridian-passthrough.xml new file mode 100644 index 0000000000..6d6b7d22cd --- /dev/null +++ b/tests/libxlxml2domconfigdata/viridian-passthrough.xml @@ -0,0 +1,37 @@ +<domain type='xen'> + <name>test-hvm</name> + <description>None</description> + <uuid>2147d599-9cc6-c0dc-92ab-4064b5446e9b</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>4</vcpu> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <clock offset='utc'/> + <os> + <type>hvm</type> + <loader>/usr/lib/xen/boot/hvmloader</loader> + <boot dev='hd'/> + </os> + <features> + <apic/> + <acpi/> + <pae/> + <hyperv mode="passthrough"/> + </features> + <devices> + <emulator>/bin/true</emulator> + <disk type='file' device='disk'> + <driver name='qemu'/> + <source file='/var/lib/xen/images/test-hvm.img'/> + <target dev='hda'/> + </disk> + <interface type='bridge'> + <source bridge='br0'/> + <mac address='00:16:3e:66:12:b4'/> + <script path='/etc/xen/scripts/vif-bridge'/> + </interface> + <graphics type='vnc' port='-1' autoport='yes' listen='0.0.0.0'/> + </devices> +</domain> diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c index 255855b156..4654821c3f 100644 --- a/tests/libxlxml2domconfigtest.c +++ b/tests/libxlxml2domconfigtest.c @@ -211,6 +211,15 @@ mymain(void) DO_TEST("single-serial"); DO_TEST("multiple-serial"); +#ifdef LIBXL_HAVE_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE + DO_TEST("viridian-hvm"); + DO_TEST("viridian-hvm-full"); + DO_TEST("viridian-hvm-none"); +#if LIBXL_BUILDINFO_HVM_VIRIDIAN_ENABLE_DISABLE_WIDTH == 64 + DO_TEST("viridian-passthrough"); +#endif +#endif + unlink("libxl-driver.log"); testXLFreeDriver(driver); -- 2.48.1

2 6

[PATCH 0/3] ch: monitor daemonization, sync after reboot, and shutdown fixes
by Kirill Shchetiniuk 03 Apr '25

03 Apr '25

1. Run CH monitor as a daemon Made the monitor process daemonized to prevent VM termination if the CH driver crashes. Added pidfile for daemon's pid aquiring and tracking as well as its init. 2. Update domain info after reboot Fixed an issue where domain properties (e.g., serial console path) were not updated after VM reboot. Added VIR_CH_EVENT_VM_REBOOTED handling to keep the transient domain definition consistent. 3. Update VM shutdown event handler VM monitor was still up even if VM was shut off, which led to an inability to start the domain again. virsh # shutdown ch-test Domain 'ch-test' is being shutdown virsh # list Id Name State ------------------------------ 722117 ch-test shut off Ensured the CH monitor process terminates along with the VM shutdown (e.g., executed using virsh). Updated virCHEventStopProcess to have proper job type. Kirill Shchetiniuk (3): ch: virCHMonitorNew() run new CH monitor daemonized ch: virCHProcessEvent() update domain info after reboot ch: virCHProcessEvent() vm shutdown event handler fix src/ch/ch_domain.c | 1 + src/ch/ch_domain.h | 1 + src/ch/ch_events.c | 8 ++++---- src/ch/ch_monitor.c | 24 ++++++++++++++++++++++-- src/ch/ch_process.c | 18 +++++++++++++++++- src/ch/ch_process.h | 2 ++ 6 files changed, 47 insertions(+), 7 deletions(-) -- 2.48.1

3 8

[PATCH 1/5] virpci: Switch to an implementation using libpciaccess
by Alexander Shursha 03 Apr '25

03 Apr '25

The current virpci code uses the Linux-specific sysfs subsystem, which makes it impossible to use on other Unix-like systems. The libpciaccess library provides a cross-platform API for accessing the PCI bus. Employ it to make the code portable. This makes libpciaccess a non-optional dependency of libvirt. Signed-off-by: Alexander Shursha <kekek2(a)ya.ru> --- meson.build | 11 +- meson_options.txt | 4 +- src/meson.build | 1 + src/util/virpci.c | 465 +++++++++++---------------------------------- tests/virpcimock.c | 22 ++- 5 files changed, 139 insertions(+), 364 deletions(-) diff --git a/meson.build b/meson.build index 2d76a0846c..85bd882406 100644 --- a/meson.build +++ b/meson.build @@ -1207,7 +1207,10 @@ parallels_sdk_version = '7.0.22' parallels_sdk_dep = dependency('parallels-sdk', version: '>=' + parallels_sdk_version, required: false) pciaccess_version = '0.10.0' -pciaccess_dep = dependency('pciaccess', version: '>=' + pciaccess_version, required: get_option('pciaccess')) +pciaccess_dep = dependency('pciaccess', version: '>=' + pciaccess_version) +if not pciaccess_dep.found() + error('pciaccess is required to build libvirt') +endif rbd_dep = cc.find_library('rbd', required: get_option('storage_rbd')) rados_dep = cc.find_library('rados', required: get_option('storage_rbd')) @@ -1461,11 +1464,6 @@ if not get_option('polkit').disabled() endif endif -if udev_dep.found() and not pciaccess_dep.found() - error('You must install the pciaccess module to build with udev') -endif - - # build driver options remote_default_mode = get_option('remote_default_mode') @@ -2341,7 +2339,6 @@ libs_summary = { 'numactl': numactl_dep.found(), 'openwsman': openwsman_dep.found(), 'parallels-sdk': parallels_sdk_dep.found(), - 'pciaccess': pciaccess_dep.found(), 'polkit': conf.has('WITH_POLKIT'), 'rbd': rbd_dep.found(), 'readline': readline_dep.found(), diff --git a/meson_options.txt b/meson_options.txt index 3dc3e8667b..69605238ba 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -38,7 +38,6 @@ option('netcf', type: 'feature', value: 'auto', description: 'netcf support') option('nls', type: 'feature', value: 'auto', description: 'nls support') option('numactl', type: 'feature', value: 'auto', description: 'numactl support') option('openwsman', type: 'feature', value: 'auto', description: 'openwsman support') -option('pciaccess', type: 'feature', value: 'auto', description: 'pciaccess support') option('polkit', type: 'feature', value: 'auto', description: 'use PolicyKit for UNIX socket access checks') option('readline', type: 'feature', value: 'auto', description: 'readline support') option('sanlock', type: 'feature', value: 'auto', description: 'sanlock support') @@ -46,7 +45,6 @@ option('sasl', type: 'feature', value: 'auto', description: 'sasl support') option('selinux', type: 'feature', value: 'auto', description: 'selinux support') option('selinux_mount', type: 'string', value: '', description: 'set SELinux mount point') option('sshconfdir', type: 'string', value: '', description: 'directory for SSH client configuration') -# dep:pciaccess option('udev', type: 'feature', value: 'auto', description: 'udev support') # dep:driver_remote option('wireshark_dissector', type: 'feature', value: 'auto', description: 'wireshark support') @@ -59,7 +57,7 @@ option('driver_bhyve', type: 'feature', value: 'auto', description: 'bhyve drive option('driver_esx', type: 'feature', value: 'auto', description: 'esx driver') # dep:openwsman option('driver_hyperv', type: 'feature', value: 'auto', description: 'Hyper-V driver') -# dep:pciaccess dep:udev dep:driver_remote dep:driver_libvirtd +# dep:udev dep:driver_remote dep:driver_libvirtd option('driver_interface', type: 'feature', value: 'auto', description: 'host interface driver') # dep:driver_remote option('driver_libvirtd', type: 'feature', value: 'auto', description: 'libvirtd driver') diff --git a/src/meson.build b/src/meson.build index 9413192a55..39788ac4d7 100644 --- a/src/meson.build +++ b/src/meson.build @@ -411,6 +411,7 @@ libvirt_lib = shared_library( dtrace_gen_objects, dependencies: [ src_dep, + pciaccess_dep ], link_args: libvirt_link_args, link_whole: [ diff --git a/src/util/virpci.c b/src/util/virpci.c index 90617e69c6..b5bbe73ece 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -2,6 +2,7 @@ * virpci.c: helper APIs for managing host PCI devices * * Copyright (C) 2009-2015 Red Hat, Inc. + * Copyright (C) 2024-2025 Future Crew, LLC * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -29,6 +30,7 @@ #include <sys/types.h> #include <sys/stat.h> #include <unistd.h> +#include <pciaccess.h> #ifdef __linux__ # include <sys/utsname.h> @@ -72,7 +74,7 @@ struct _virPCIDevice { char *name; /* domain:bus:slot.function */ char id[PCI_ID_LEN]; /* product vendor */ - char *path; + struct pci_device *device; /* The driver:domain which uses the device */ char *used_by_drvname; @@ -359,121 +361,6 @@ virPCIDeviceGetCurrentDriverNameAndType(virPCIDevice *dev, } -static int -virPCIDeviceConfigOpenInternal(virPCIDevice *dev, bool readonly, bool fatal) -{ - int fd; - - fd = open(dev->path, readonly ? O_RDONLY : O_RDWR); - - if (fd < 0) { - if (fatal) { - virReportSystemError(errno, - _("Failed to open config space file '%1$s'"), - dev->path); - } else { - VIR_WARN("Failed to open config space file '%s': %s", - dev->path, g_strerror(errno)); - } - return -1; - } - - VIR_DEBUG("%s %s: opened %s", dev->id, dev->name, dev->path); - return fd; -} - -static int -virPCIDeviceConfigOpen(virPCIDevice *dev) -{ - return virPCIDeviceConfigOpenInternal(dev, true, true); -} - -static int -virPCIDeviceConfigOpenTry(virPCIDevice *dev) -{ - return virPCIDeviceConfigOpenInternal(dev, true, false); -} - -static int -virPCIDeviceConfigOpenWrite(virPCIDevice *dev) -{ - return virPCIDeviceConfigOpenInternal(dev, false, true); -} - -static void -virPCIDeviceConfigClose(virPCIDevice *dev, int cfgfd) -{ - if (VIR_CLOSE(cfgfd) < 0) { - VIR_WARN("Failed to close config space file '%s': %s", - dev->path, g_strerror(errno)); - } -} - - -static int -virPCIDeviceRead(virPCIDevice *dev, - int cfgfd, - unsigned int pos, - uint8_t *buf, - unsigned int buflen) -{ - memset(buf, 0, buflen); - errno = 0; - - if (lseek(cfgfd, pos, SEEK_SET) != pos || - saferead(cfgfd, buf, buflen) != buflen) { - VIR_DEBUG("Failed to read %u bytes at %u from '%s' : %s", - buflen, pos, dev->path, g_strerror(errno)); - return -1; - } - return 0; -} - - -/** - * virPCIDeviceReadN: - * @dev: virPCIDevice object (used only to log name of config file) - * @cfgfd: open file descriptor for device config file in sysfs - * @pos: byte offset in the file to read from - * - * read "N" (where "N" is "8", "16", or "32", and appears at the end - * of the function name) bytes from a PCI device's already-opened - * sysfs config file and return them as the return value from the - * function. - * - * Returns the value at @pos in the file, or 0 if there was an - * error. NB: since 0 could be a valid value, occurrence of an error - * must be determined by examining errno. errno is always reset to 0 - * before the seek/read is attempted (see virPCIDeviceRead()), so if - * errno != 0 on return from one of these functions, then either the - * seek or the read operation failed for some reason. If errno == 0 - * and the return value is 0, then the config file really does contain - * the value 0 at @pos. - */ -static uint8_t -virPCIDeviceRead8(virPCIDevice *dev, int cfgfd, unsigned int pos) -{ - uint8_t buf; - virPCIDeviceRead(dev, cfgfd, pos, &buf, sizeof(buf)); - return buf; -} - -static uint16_t -virPCIDeviceRead16(virPCIDevice *dev, int cfgfd, unsigned int pos) -{ - uint8_t buf[2]; - virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); - return (buf[0] << 0) | (buf[1] << 8); -} - -static uint32_t -virPCIDeviceRead32(virPCIDevice *dev, int cfgfd, unsigned int pos) -{ - uint8_t buf[4]; - virPCIDeviceRead(dev, cfgfd, pos, &buf[0], sizeof(buf)); - return (buf[0] << 0) | (buf[1] << 8) | (buf[2] << 16) | (buf[3] << 24); -} - static int virPCIDeviceReadClass(virPCIDevice *dev, uint16_t *device_class) { @@ -499,36 +386,6 @@ virPCIDeviceReadClass(virPCIDevice *dev, uint16_t *device_class) return 0; } -static int -virPCIDeviceWrite(virPCIDevice *dev, - int cfgfd, - unsigned int pos, - uint8_t *buf, - unsigned int buflen) -{ - if (lseek(cfgfd, pos, SEEK_SET) != pos || - safewrite(cfgfd, buf, buflen) != buflen) { - VIR_WARN("Failed to write to '%s' : %s", dev->path, - g_strerror(errno)); - return -1; - } - return 0; -} - -static void -virPCIDeviceWrite16(virPCIDevice *dev, int cfgfd, unsigned int pos, uint16_t val) -{ - uint8_t buf[2] = { (val >> 0), (val >> 8) }; - virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); -} - -static void -virPCIDeviceWrite32(virPCIDevice *dev, int cfgfd, unsigned int pos, uint32_t val) -{ - uint8_t buf[4] = { (val >> 0), (val >> 8), (val >> 16), (val >> 24) }; - virPCIDeviceWrite(dev, cfgfd, pos, &buf[0], sizeof(buf)); -} - typedef int (*virPCIDeviceIterPredicate)(virPCIDevice *, virPCIDevice *, void *); @@ -610,7 +467,6 @@ virPCIDeviceIterDevices(virPCIDeviceIterPredicate predicate, */ static int virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, - int cfgfd, unsigned int capability, unsigned int *offset) { @@ -619,11 +475,13 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, *offset = 0; /* assume failure (*nothing* can be at offset 0) */ - status = virPCIDeviceRead16(dev, cfgfd, PCI_STATUS); + pci_device_cfg_read_u16(dev->device, &status, PCI_STATUS); + if (errno != 0 || !(status & PCI_STATUS_CAP_LIST)) goto error; - pos = virPCIDeviceRead8(dev, cfgfd, PCI_CAPABILITY_LIST); + pci_device_cfg_read_u8(dev->device, &pos, PCI_CAPABILITY_LIST); + if (errno != 0) goto error; @@ -635,7 +493,9 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, * capabilities here. */ while (pos >= PCI_CONF_HEADER_LEN && pos != 0xff) { - uint8_t capid = virPCIDeviceRead8(dev, cfgfd, pos); + uint8_t capid; + pci_device_cfg_read_u8(dev->device, &capid, pos); + if (errno != 0) goto error; @@ -646,7 +506,8 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, return 0; } - pos = virPCIDeviceRead8(dev, cfgfd, pos + 1); + pci_device_cfg_read_u8(dev->device, &pos, pos + 1); + if (errno != 0) goto error; } @@ -665,7 +526,6 @@ virPCIDeviceFindCapabilityOffset(virPCIDevice *dev, static unsigned int virPCIDeviceFindExtendedCapabilityOffset(virPCIDevice *dev, - int cfgfd, unsigned int capability) { int ttl; @@ -677,7 +537,7 @@ virPCIDeviceFindExtendedCapabilityOffset(virPCIDevice *dev, pos = PCI_EXT_CAP_BASE; while (ttl > 0 && pos >= PCI_EXT_CAP_BASE) { - header = virPCIDeviceRead32(dev, cfgfd, pos); + header = pci_device_cfg_read_u32(dev->device, &header, pos); if ((header & PCI_EXT_CAP_ID_MASK) == capability) return pos; @@ -693,7 +553,7 @@ virPCIDeviceFindExtendedCapabilityOffset(virPCIDevice *dev, * not have FLR, 1 if it does, and -1 on error */ static bool -virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) +virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev) { uint32_t caps; unsigned int pos; @@ -707,7 +567,7 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) * on SR-IOV NICs at the moment. */ if (dev->pcie_cap_pos) { - caps = virPCIDeviceRead32(dev, cfgfd, dev->pcie_cap_pos + PCI_EXP_DEVCAP); + pci_device_cfg_read_u32(dev->device, &caps, dev->pcie_cap_pos + PCI_EXP_DEVCAP); if (caps & PCI_EXP_DEVCAP_FLR) { VIR_DEBUG("%s %s: detected PCIe FLR capability", dev->id, dev->name); return true; @@ -718,11 +578,13 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) * the same thing, except for conventional PCI * devices. This is not common yet. */ - if (virPCIDeviceFindCapabilityOffset(dev, cfgfd, PCI_CAP_ID_AF, &pos) < 0) + if (virPCIDeviceFindCapabilityOffset(dev, PCI_CAP_ID_AF, &pos) < 0) goto error; if (pos) { - caps = virPCIDeviceRead16(dev, cfgfd, pos + PCI_AF_CAP); + uint16_t caps16; + pci_device_cfg_read_u16(dev->device, &caps16, pos + PCI_AF_CAP); + caps = caps16; if (caps & PCI_AF_CAP_FLR) { VIR_DEBUG("%s %s: detected PCI FLR capability", dev->id, dev->name); return true; @@ -754,13 +616,13 @@ virPCIDeviceDetectFunctionLevelReset(virPCIDevice *dev, int cfgfd) * internal reset, not just a soft reset. */ static bool -virPCIDeviceDetectPowerManagementReset(virPCIDevice *dev, int cfgfd) +virPCIDeviceDetectPowerManagementReset(virPCIDevice *dev) { if (dev->pci_pm_cap_pos) { uint32_t ctl; /* require the NO_SOFT_RESET bit is clear */ - ctl = virPCIDeviceRead32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL); + pci_device_cfg_read_u32(dev->device, &ctl, dev->pci_pm_cap_pos + PCI_PM_CTRL); if (!(ctl & PCI_PM_CTRL_NO_SOFT_RESET)) { VIR_DEBUG("%s %s: detected PM reset capability", dev->id, dev->name); return true; @@ -811,26 +673,22 @@ virPCIDeviceIsParent(virPCIDevice *dev, virPCIDevice *check, void *data) uint8_t header_type, secondary, subordinate; virPCIDevice **best = data; int ret = 0; - int fd; if (dev->address.domain != check->address.domain) return 0; - if ((fd = virPCIDeviceConfigOpenTry(check)) < 0) - return 0; - /* Is it a bridge? */ ret = virPCIDeviceReadClass(check, &device_class); if (ret < 0 || device_class != PCI_CLASS_BRIDGE_PCI) - goto cleanup; + return ret; /* Is it a plane? */ - header_type = virPCIDeviceRead8(check, fd, PCI_HEADER_TYPE); + pci_device_cfg_read_u8(check->device, &header_type, PCI_HEADER_TYPE); if ((header_type & PCI_HEADER_TYPE_MASK) != PCI_HEADER_TYPE_BRIDGE) - goto cleanup; + return ret; - secondary = virPCIDeviceRead8(check, fd, PCI_SECONDARY_BUS); - subordinate = virPCIDeviceRead8(check, fd, PCI_SUBORDINATE_BUS); + pci_device_cfg_read_u8(check->device, &secondary, PCI_SECONDARY_BUS); + pci_device_cfg_read_u8(check->device, &subordinate, PCI_SUBORDINATE_BUS); VIR_DEBUG("%s %s: found parent device %s", dev->id, dev->name, check->name); @@ -838,8 +696,7 @@ virPCIDeviceIsParent(virPCIDevice *dev, virPCIDevice *check, void *data) * the direct parent. No further work is necessary */ if (dev->address.bus == secondary) { - ret = 1; - goto cleanup; + return 1; } /* otherwise, SRIOV allows VFs to be on different buses than their PFs. @@ -850,35 +707,26 @@ virPCIDeviceIsParent(virPCIDevice *dev, virPCIDevice *check, void *data) if (*best == NULL) { *best = virPCIDeviceNew(&check->address); if (*best == NULL) { - ret = -1; - goto cleanup; + return -1; } } else { /* OK, we had already recorded a previous "best" match for the * parent. See if the current device is more restrictive than the * best, and if so, make it the new best */ - int bestfd; uint8_t best_secondary; - if ((bestfd = virPCIDeviceConfigOpenTry(*best)) < 0) - goto cleanup; - best_secondary = virPCIDeviceRead8(*best, bestfd, PCI_SECONDARY_BUS); - virPCIDeviceConfigClose(*best, bestfd); + pci_device_cfg_read_u8((*best)->device, &best_secondary, PCI_SECONDARY_BUS); if (secondary > best_secondary) { virPCIDeviceFree(*best); *best = virPCIDeviceNew(&check->address); if (*best == NULL) { - ret = -1; - goto cleanup; + return -1; } } } } - - cleanup: - virPCIDeviceConfigClose(check, fd); return ret; } @@ -902,15 +750,14 @@ virPCIDeviceGetParent(virPCIDevice *dev, virPCIDevice **parent) */ static int virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, - int cfgfd, virPCIDeviceList *inactiveDevs) { g_autoptr(virPCIDevice) parent = NULL; g_autoptr(virPCIDevice) conflict = NULL; uint8_t config_space[PCI_CONF_LEN]; uint16_t ctl; - int ret = -1; - int parentfd; + pciaddr_t bytes_read; + pciaddr_t bytes_written; /* Refuse to do a secondary bus reset if there are other * devices/functions behind the bus are used by the host @@ -932,8 +779,6 @@ virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, dev->name); return -1; } - if ((parentfd = virPCIDeviceConfigOpenWrite(parent)) < 0) - goto out; VIR_DEBUG("%s %s: doing a secondary bus reset", dev->id, dev->name); @@ -941,38 +786,37 @@ virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, * for the supplied device since we refuse to do a reset if there * are multiple devices/functions */ - if (virPCIDeviceRead(dev, cfgfd, 0, config_space, PCI_CONF_LEN) < 0) { + pci_device_cfg_read(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_read); + if (bytes_read < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to read PCI config space for %1$s"), dev->name); - goto out; + return -1; } /* Read the control register, set the reset flag, wait 200ms, * unset the reset flag and wait 200ms. */ - ctl = virPCIDeviceRead16(dev, parentfd, PCI_BRIDGE_CONTROL); - virPCIDeviceWrite16(parent, parentfd, PCI_BRIDGE_CONTROL, - ctl | PCI_BRIDGE_CTL_RESET); + pci_device_cfg_read_u16(parent->device, &ctl, PCI_BRIDGE_CONTROL); + + pci_device_cfg_write_u16(parent->device, ctl | PCI_BRIDGE_CTL_RESET, PCI_BRIDGE_CONTROL); g_usleep(200 * 1000); /* sleep 200ms */ - virPCIDeviceWrite16(parent, parentfd, PCI_BRIDGE_CONTROL, ctl); + pci_device_cfg_write_u16(parent->device, ctl, PCI_BRIDGE_CONTROL); g_usleep(200 * 1000); /* sleep 200ms */ - if (virPCIDeviceWrite(dev, cfgfd, 0, config_space, PCI_CONF_LEN) < 0) { + pci_device_cfg_write(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_written); + if (bytes_written < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to restore PCI config space for %1$s"), dev->name); - goto out; + return -1; } - ret = 0; - out: - virPCIDeviceConfigClose(parent, parentfd); - return ret; + return 0; } /* Power management reset attempts to reset a device using a @@ -980,16 +824,19 @@ virPCIDeviceTrySecondaryBusReset(virPCIDevice *dev, * above we require the device supports a full internal reset. */ static int -virPCIDeviceTryPowerManagementReset(virPCIDevice *dev, int cfgfd) +virPCIDeviceTryPowerManagementReset(virPCIDevice *dev) { uint8_t config_space[PCI_CONF_LEN]; uint32_t ctl; + pciaddr_t bytes_read; + pciaddr_t bytes_written; if (!dev->pci_pm_cap_pos) return -1; /* Save and restore the device's config space. */ - if (virPCIDeviceRead(dev, cfgfd, 0, &config_space[0], PCI_CONF_LEN) < 0) { + pci_device_cfg_read(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_read); + if (bytes_read < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to read PCI config space for %1$s"), dev->name); @@ -998,20 +845,19 @@ virPCIDeviceTryPowerManagementReset(virPCIDevice *dev, int cfgfd) VIR_DEBUG("%s %s: doing a power management reset", dev->id, dev->name); - ctl = virPCIDeviceRead32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL); + pci_device_cfg_read_u32(dev->device, &ctl, dev->pci_pm_cap_pos + PCI_PM_CTRL); ctl &= ~PCI_PM_CTRL_STATE_MASK; - virPCIDeviceWrite32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL, - ctl | PCI_PM_CTRL_STATE_D3hot); + pci_device_cfg_write_u32(dev->device, ctl | PCI_PM_CTRL_STATE_D3hot, dev->pci_pm_cap_pos + PCI_PM_CTRL); g_usleep(10 * 1000); /* sleep 10ms */ - virPCIDeviceWrite32(dev, cfgfd, dev->pci_pm_cap_pos + PCI_PM_CTRL, - ctl | PCI_PM_CTRL_STATE_D0); + pci_device_cfg_write_u32(dev->device, ctl | PCI_PM_CTRL_STATE_D0, dev->pci_pm_cap_pos + PCI_PM_CTRL); g_usleep(10 * 1000); /* sleep 10ms */ - if (virPCIDeviceWrite(dev, cfgfd, 0, &config_space[0], PCI_CONF_LEN) < 0) { + pci_device_cfg_write(dev->device, config_space, 0, PCI_CONF_LEN, &bytes_written); + if (bytes_written < PCI_CONF_LEN) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to restore PCI config space for %1$s"), dev->name); @@ -1046,10 +892,10 @@ virPCIDeviceTryPowerManagementReset(virPCIDevice *dev, int cfgfd) * Always returns success (0) (for now) */ static int -virPCIDeviceInit(virPCIDevice *dev, int cfgfd) +virPCIDeviceInit(virPCIDevice *dev) { dev->is_pcie = false; - if (virPCIDeviceFindCapabilityOffset(dev, cfgfd, PCI_CAP_ID_EXP, &dev->pcie_cap_pos) < 0) { + if (virPCIDeviceFindCapabilityOffset(dev, PCI_CAP_ID_EXP, &dev->pcie_cap_pos) < 0) { /* an unprivileged process is unable to read *all* of a * device's PCI config (it can only read the first 64 * bytes, which isn't enough for see the Express @@ -1065,18 +911,13 @@ virPCIDeviceInit(virPCIDevice *dev, int cfgfd) * -1), then we blindly assume the most likely outcome - * PCIe. */ - off_t configLen = virFileLength(virPCIDeviceGetConfigPath(dev), -1); - - if (configLen != 256) - dev->is_pcie = true; - } else { dev->is_pcie = (dev->pcie_cap_pos != 0); } - virPCIDeviceFindCapabilityOffset(dev, cfgfd, PCI_CAP_ID_PM, &dev->pci_pm_cap_pos); - dev->has_flr = virPCIDeviceDetectFunctionLevelReset(dev, cfgfd); - dev->has_pm_reset = virPCIDeviceDetectPowerManagementReset(dev, cfgfd); + virPCIDeviceFindCapabilityOffset(dev, PCI_CAP_ID_PM, &dev->pci_pm_cap_pos); + dev->has_flr = virPCIDeviceDetectFunctionLevelReset(dev); + dev->has_pm_reset = virPCIDeviceDetectPowerManagementReset(dev); return 0; } @@ -1089,7 +930,6 @@ virPCIDeviceReset(virPCIDevice *dev, g_autofree char *drvName = NULL; virPCIStubDriver drvType; int ret = -1; - int fd = -1; int hdrType = -1; if (virPCIGetHeaderType(dev, &hdrType) < 0) @@ -1114,29 +954,26 @@ virPCIDeviceReset(virPCIDevice *dev, * be redundant. */ if (virPCIDeviceGetCurrentDriverNameAndType(dev, &drvName, &drvType) < 0) - goto cleanup; + return -1; if (drvType == VIR_PCI_STUB_DRIVER_VFIO) { VIR_DEBUG("Device %s is bound to %s - skip reset", dev->name, drvName); ret = 0; - goto cleanup; + return 0; } VIR_DEBUG("Resetting device %s", dev->name); - if ((fd = virPCIDeviceConfigOpenWrite(dev)) < 0) - goto cleanup; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; + if (virPCIDeviceInit(dev) < 0) + return -1; /* KVM will perform FLR when starting and stopping * a guest, so there is no need for us to do it here. */ if (dev->has_flr) { ret = 0; - goto cleanup; + return 0; } /* If the device supports PCI power management reset, @@ -1144,11 +981,11 @@ virPCIDeviceReset(virPCIDevice *dev, * the function, not the whole device. */ if (dev->has_pm_reset) - ret = virPCIDeviceTryPowerManagementReset(dev, fd); + ret = virPCIDeviceTryPowerManagementReset(dev); /* Bus reset is not an option with the root bus */ if (ret < 0 && dev->address.bus != 0) - ret = virPCIDeviceTrySecondaryBusReset(dev, fd, inactiveDevs); + ret = virPCIDeviceTrySecondaryBusReset(dev, inactiveDevs); if (ret < 0) { virErrorPtr err = virGetLastError(); @@ -1159,8 +996,6 @@ virPCIDeviceReset(virPCIDevice *dev, _("no FLR, PM reset or bus reset available")); } - cleanup: - virPCIDeviceConfigClose(dev, fd); return ret; } @@ -1756,28 +1591,6 @@ virPCIDeviceReattach(virPCIDevice *dev, return 0; } -static char * -virPCIDeviceReadID(virPCIDevice *dev, const char *id_name) -{ - g_autofree char *path = NULL; - g_autofree char *id_str = NULL; - - path = virPCIFile(dev->name, id_name); - - /* ID string is '0xNNNN\n' ... i.e. 7 bytes */ - if (virFileReadAll(path, 7, &id_str) < 0) - return NULL; - - /* Check for 0x suffix */ - if (id_str[0] != '0' || id_str[1] != 'x') - return NULL; - - /* Chop off the newline; we know the string is 7 bytes */ - id_str[6] = '\0'; - - return g_steal_pointer(&id_str); -} - bool virPCIDeviceAddressIsValid(virPCIDeviceAddress *addr, bool report) @@ -1865,9 +1678,9 @@ virPCIDeviceExists(const virPCIDeviceAddress *addr) virPCIDevice * virPCIDeviceNew(const virPCIDeviceAddress *address) { + struct pci_device * device; + g_autoptr(virPCIDevice) dev = NULL; - g_autofree char *vendor = NULL; - g_autofree char *product = NULL; dev = g_new0(virPCIDevice, 1); @@ -1875,31 +1688,21 @@ virPCIDeviceNew(const virPCIDeviceAddress *address) dev->name = virPCIDeviceAddressAsString(&dev->address); - dev->path = g_strdup_printf(PCI_SYSFS "devices/%s/config", dev->name); - - if (!virFileExists(dev->path)) { - virReportSystemError(errno, - _("Device %1$s not found: could not access %2$s"), - dev->name, dev->path); + pci_system_init(); + device = pci_device_find_by_slot(address->domain, address->bus, address->slot, address->function); + if (!device) return NULL; - } - - vendor = virPCIDeviceReadID(dev, "vendor"); - product = virPCIDeviceReadID(dev, "device"); - - if (!vendor || !product) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Failed to read product/vendor ID for %1$s"), - dev->name); + dev->device = g_memdup(device, sizeof(*dev->device)); + if (!dev->device) { + virReportSystemError(errno, + _("Not found device domain: %1$d, bus: %2$d, slot: %3$d, function: %4$d"), + address->domain, address->bus, address->slot, address->function); return NULL; } - - /* strings contain '0x' prefix */ - if (g_snprintf(dev->id, sizeof(dev->id), "%s %s", &vendor[2], - &product[2]) >= sizeof(dev->id)) { + if (g_snprintf(dev->id, sizeof(dev->id), "%x %x", dev->device->vendor_id, dev->device->device_id) >= sizeof(dev->id)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("dev->id buffer overflow: %1$s %2$s"), - &vendor[2], &product[2]); + _("dev->id buffer overflow: %1$d %2$d"), + dev->device->vendor_id, dev->device->device_id); return NULL; } @@ -1918,10 +1721,10 @@ virPCIDeviceCopy(virPCIDevice *dev) /* shallow copy to take care of most attributes */ *copy = *dev; - copy->path = NULL; - copy->used_by_drvname = copy->used_by_domname = NULL; + copy->device = NULL; + copy->device = g_memdup(dev->device, sizeof(*dev->device)); + copy->name = copy->used_by_drvname = copy->used_by_domname = copy->stubDriverName = NULL; copy->name = g_strdup(dev->name); - copy->path = g_strdup(dev->path); copy->used_by_drvname = g_strdup(dev->used_by_drvname); copy->used_by_domname = g_strdup(dev->used_by_domname); copy->stubDriverName = g_strdup(dev->stubDriverName); @@ -1936,10 +1739,11 @@ virPCIDeviceFree(virPCIDevice *dev) return; VIR_DEBUG("%s %s: freeing", dev->id, dev->name); g_free(dev->name); - g_free(dev->path); g_free(dev->used_by_drvname); g_free(dev->used_by_domname); g_free(dev->stubDriverName); + if (dev->device) + g_free(dev->device); g_free(dev); } @@ -1971,9 +1775,9 @@ virPCIDeviceGetName(virPCIDevice *dev) * config file. */ const char * -virPCIDeviceGetConfigPath(virPCIDevice *dev) +virPCIDeviceGetConfigPath(virPCIDevice *dev G_GNUC_UNUSED) { - return dev->path; + return NULL; } void virPCIDeviceSetManaged(virPCIDevice *dev, bool managed) @@ -2484,47 +2288,37 @@ virPCIDeviceDownstreamLacksACS(virPCIDevice *dev) uint16_t flags; uint16_t ctrl; unsigned int pos; - int fd; - int ret = 0; uint16_t device_class; - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) + if (virPCIDeviceInit(dev) < 0) { return -1; - - if (virPCIDeviceInit(dev, fd) < 0) { - ret = -1; - goto cleanup; } if (virPCIDeviceReadClass(dev, &device_class) < 0) - goto cleanup; + return 0; pos = dev->pcie_cap_pos; if (!pos || device_class != PCI_CLASS_BRIDGE_PCI) - goto cleanup; + return 0; - flags = virPCIDeviceRead16(dev, fd, pos + PCI_EXP_FLAGS); + pci_device_cfg_read_u16(dev->device, &flags, pos + PCI_EXP_FLAGS); if (((flags & PCI_EXP_FLAGS_TYPE) >> 4) != PCI_EXP_TYPE_DOWNSTREAM) - goto cleanup; + return 0; - pos = virPCIDeviceFindExtendedCapabilityOffset(dev, fd, PCI_EXT_CAP_ID_ACS); + pos = virPCIDeviceFindExtendedCapabilityOffset(dev, PCI_EXT_CAP_ID_ACS); if (!pos) { VIR_DEBUG("%s %s: downstream port lacks ACS", dev->id, dev->name); - ret = 1; - goto cleanup; + return 1; } - ctrl = virPCIDeviceRead16(dev, fd, pos + PCI_EXT_ACS_CTRL); + pci_device_cfg_read_u16(dev->device, &ctrl, pos + PCI_EXT_ACS_CTRL); if ((ctrl & PCI_EXT_CAP_ACS_ENABLED) != PCI_EXT_CAP_ACS_ENABLED) { VIR_DEBUG("%s %s: downstream port has ACS disabled", dev->id, dev->name); - ret = 1; - goto cleanup; + return 1; } - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return 0; } static int @@ -3189,48 +2983,27 @@ virPCIDeviceGetVPD(virPCIDevice *dev G_GNUC_UNUSED) int virPCIDeviceIsPCIExpress(virPCIDevice *dev) { - int fd; - int ret = -1; - - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return ret; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; - - ret = dev->is_pcie; + if (virPCIDeviceInit(dev) < 0) + return -1; - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return dev->is_pcie; } int virPCIDeviceHasPCIExpressLink(virPCIDevice *dev) { - int fd; - int ret = -1; uint16_t cap, type; - - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return ret; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; + if (virPCIDeviceInit(dev) < 0) + return -1; if (dev->pcie_cap_pos == 0) { - ret = 0; - goto cleanup; + return 0; } - cap = virPCIDeviceRead16(dev, fd, dev->pcie_cap_pos + PCI_CAP_FLAGS); + pci_device_cfg_read_u16(dev->device, &cap, dev->pcie_cap_pos + PCI_CAP_FLAGS); type = (cap & PCI_EXP_FLAGS_TYPE) >> 4; - ret = type != PCI_EXP_TYPE_ROOT_INT_EP && type != PCI_EXP_TYPE_ROOT_EC; - - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return type != PCI_EXP_TYPE_ROOT_INT_EP && type != PCI_EXP_TYPE_ROOT_EC; } int @@ -3242,53 +3015,39 @@ virPCIDeviceGetLinkCapSta(virPCIDevice *dev, unsigned int *sta_width) { uint32_t t; - int fd; - int ret = -1; - - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return ret; - - if (virPCIDeviceInit(dev, fd) < 0) - goto cleanup; + uint16_t t16; + if (virPCIDeviceInit(dev) < 0) + return -1; if (!dev->pcie_cap_pos) { virReportError(VIR_ERR_INTERNAL_ERROR, _("pci device %1$s is not a PCI-Express device"), dev->name); - goto cleanup; + return -1; } - t = virPCIDeviceRead32(dev, fd, dev->pcie_cap_pos + PCI_EXP_LNKCAP); + pci_device_cfg_read_u32(dev->device, &t, dev->pcie_cap_pos + PCI_EXP_LNKCAP); *cap_port = t >> 24; *cap_speed = t & PCI_EXP_LNKCAP_SPEED; *cap_width = (t & PCI_EXP_LNKCAP_WIDTH) >> 4; - t = virPCIDeviceRead16(dev, fd, dev->pcie_cap_pos + PCI_EXP_LNKSTA); + pci_device_cfg_read_u16(dev->device, &t16, dev->pcie_cap_pos + PCI_EXP_LNKSTA); + t = t16; *sta_speed = t & PCI_EXP_LNKSTA_SPEED; *sta_width = (t & PCI_EXP_LNKSTA_WIDTH) >> 4; - ret = 0; - - cleanup: - virPCIDeviceConfigClose(dev, fd); - return ret; + return 0; } int virPCIGetHeaderType(virPCIDevice *dev, int *hdrType) { - int fd; uint8_t type; *hdrType = -1; - if ((fd = virPCIDeviceConfigOpen(dev)) < 0) - return -1; - - type = virPCIDeviceRead8(dev, fd, PCI_HEADER_TYPE); - - virPCIDeviceConfigClose(dev, fd); + pci_device_cfg_read_u8(dev->device, &type, PCI_HEADER_TYPE); type &= PCI_HEADER_TYPE_MASK; if (type >= VIR_PCI_HEADER_LAST) { diff --git a/tests/virpcimock.c b/tests/virpcimock.c index 5b923c63ce..36bb57edb0 100644 --- a/tests/virpcimock.c +++ b/tests/virpcimock.c @@ -1,5 +1,6 @@ /* * Copyright (C) 2013 Red Hat, Inc. + * Copyright (C) 2024-2025 Future Crew, LLC * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -22,7 +23,7 @@ #include "virpcivpdpriv.h" -#if defined(__linux__) || defined(__FreeBSD__) || defined(__APPLE__) +#if defined(__linux__) || defined(__APPLE__) # define VIR_MOCK_LOOKUP_MAIN # include "virmock.h" # include "virpci.h" @@ -42,6 +43,10 @@ static int (*real___open_2)(const char *path, int flags); static int (*real_close)(int fd); static DIR * (*real_opendir)(const char *name); static char *(*real_virFileCanonicalizePath)(const char *path); +static int (*real_scandir)(const char *restrict dirp, + struct dirent ***restrict namelist, + typeof(int(const struct dirent *)) *filter, + typeof(int(const struct dirent **, const struct dirent **)) *compar); static char *fakerootdir; @@ -955,6 +960,7 @@ init_syms(void) VIR_MOCK_REAL_INIT(opendir); # endif VIR_MOCK_REAL_INIT(virFileCanonicalizePath); + VIR_MOCK_REAL_INIT(scandir); } static void @@ -1172,6 +1178,20 @@ virFileCanonicalizePath(const char *path) return real_virFileCanonicalizePath(newpath); } +int scandir(const char *restrict dirp, struct dirent ***restrict namelist, + typeof(int(const struct dirent *)) *filter, + typeof(int(const struct dirent **, const struct dirent **)) *compar) +{ + g_autofree char *newpath = NULL; + + init_syms(); + + if (getrealpath(&newpath, dirp) < 0) + return -1; + + return real_scandir(newpath, namelist, filter, compar); +} + # include "virmockstathelpers.c" #else -- 2.46.1

2 9

[libvirt PATCH] tools: virsh: metadata: do not report error on missing metadata
by Ján Tomko 02 Apr '25

02 Apr '25

Similarly to `desc` and `net-desc`, return an empty string if there is no metadata to be returned. https://issues.redhat.com/browse/RHEL-27172 Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- tools/virsh-domain.c | 10 ++++++++-- tools/virsh-network.c | 10 ++++++++-- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f3da2f903f..e104aa909a 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -8480,8 +8480,14 @@ cmdMetadata(vshControl *ctl, const vshCmd *cmd) g_autofree char *data = NULL; /* get */ if (!(data = virDomainGetMetadata(dom, VIR_DOMAIN_METADATA_ELEMENT, - uri, flags))) - return false; + uri, flags))) { + if (virGetLastErrorCode() == VIR_ERR_NO_DOMAIN_METADATA) { + virResetLastError(); + data = g_strdup(""); + } else { + return false; + } + } vshPrint(ctl, "%s\n", data); } diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 6fcc7fd8ee..bcdb76ae36 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -604,8 +604,14 @@ cmdNetworkMetadata(vshControl *ctl, const vshCmd *cmd) /* get */ if (!(data = virNetworkGetMetadata(net, VIR_NETWORK_METADATA_ELEMENT, - uri, flags))) - return false; + uri, flags))) { + if (virGetLastErrorCode() == VIR_ERR_NO_NETWORK_METADATA) { + virResetLastError(); + data = g_strdup(""); + } else { + return false; + } + } vshPrint(ctl, "%s\n", data); } -- 2.48.1

4 4

[PATCH 0/6] qemu: Remove last HMP commands
by Peter Krempa 02 Apr '25

02 Apr '25

RIP HMP use in libvirt: 2007-02-14 [1] - 2025-04-02 [1] 23ad665cb05ef9ce7d298cc34bff5efb95ef6948 Peter Krempa (6): qemu: domain: Don't check return value of 'virCPUDefCopy' qemuSnapshotCreateActiveInternal: Fix error logic qemu: snapshot: Always assume support for QEMU_CAPS_SNAPSHOT_INTERNAL_QMP qemu: Always revert internal snapshots via QMP rather than '-loadvm' qemu: monitor: Remove HMP monitor code qemu: capabilities: Retire QEMU_CAPS_SNAPSHOT_INTERNAL_QMP po/POTFILES | 1 - src/qemu/meson.build | 1 - src/qemu/qemu_capabilities.c | 3 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 6 -- src/qemu/qemu_domain.c | 7 +- src/qemu/qemu_monitor.c | 25 ------ src/qemu/qemu_monitor.h | 3 - src/qemu/qemu_monitor_text.c | 88 ------------------- src/qemu/qemu_monitor_text.h | 29 ------ src/qemu/qemu_process.c | 3 +- src/qemu/qemu_snapshot.c | 49 ++--------- .../caps_10.0.0_s390x.xml | 1 - .../caps_10.0.0_x86_64+amdsev.xml | 1 - .../caps_10.0.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 1 - .../caps_6.2.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 1 - .../caps_7.0.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 - .../caps_7.1.0_x86_64.xml | 1 - tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 - .../caps_7.2.0_x86_64+hvf.xml | 1 - .../caps_7.2.0_x86_64.xml | 1 - .../caps_8.0.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 - .../caps_8.1.0_x86_64.xml | 1 - .../caps_8.2.0_aarch64.xml | 1 - .../caps_8.2.0_armv7l.xml | 1 - .../caps_8.2.0_loongarch64.xml | 1 - .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 1 - .../caps_8.2.0_x86_64.xml | 1 - .../qemucapabilitiesdata/caps_9.0.0_sparc.xml | 1 - .../caps_9.0.0_x86_64.xml | 1 - .../caps_9.1.0_riscv64.xml | 1 - .../qemucapabilitiesdata/caps_9.1.0_s390x.xml | 1 - .../caps_9.1.0_x86_64.xml | 1 - .../caps_9.2.0_aarch64+hvf.xml | 1 - .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 1 - .../caps_9.2.0_x86_64+amdsev.xml | 1 - .../caps_9.2.0_x86_64.xml | 1 - 41 files changed, 15 insertions(+), 231 deletions(-) delete mode 100644 src/qemu/qemu_monitor_text.c delete mode 100644 src/qemu/qemu_monitor_text.h -- 2.49.0

3 8

[PATCH] meson: Add back prefix path for runstatedir
by Zhenzhong Duan 02 Apr '25

02 Apr '25

Currently libvirt favors /run instead of /var/run, but for local build run test, a prefix path is still needed to avoid interoperating with OS vendor provided binaries. Signed-off-by: Zhenzhong Duan <zhenzhong.duan(a)intel.com> --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build index bf4a245dd3..84c9796c2f 100644 --- a/meson.build +++ b/meson.build @@ -82,7 +82,7 @@ endif runstatedir = get_option('runstatedir') if runstatedir == '' - runstatedir = '/run' + runstatedir = prefix / 'run' endif initconfdir = get_option('initconfdir') -- 2.34.1

4 4

Report a build issue
by Duan, Zhenzhong 02 Apr '25

02 Apr '25

Hi, When -Dlibnl=disabled, build failed as below: ../src/util/virnetdevbridge.c: In function 'virNetDevBridgeSetupVlans': ../src/util/virnetdevbridge.c:326:9: error: implicit declaration of function 'virNetlinkBridgeVlanFilterSet'; did you mean 'virNetDevBridgeGetVlanFiltering'? [-Werror=implicit-function-declaration] 326 | if (virNetlinkBridgeVlanFilterSet(ifname, RTM_DELLINK, 0, 1, &error) < 0) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | virNetDevBridgeGetVlanFiltering ../src/util/virnetdevbridge.c:326:9: error: nested extern declaration of 'virNetlinkBridgeVlanFilterSet' [-Werror=nested-externs] ../src/util/virnetdevbridge.c:326:47: error: 'RTM_DELLINK' undeclared (first use in this function) 326 | if (virNetlinkBridgeVlanFilterSet(ifname, RTM_DELLINK, 0, 1, &error) < 0) { | ^~~~~~~~~~~ ../src/util/virnetdevbridge.c:326:47: note: each undeclared identifier is reported only once for each function it appears in ../src/util/virnetdevbridge.c:346:55: error: 'RTM_SETLINK' undeclared (first use in this function) 346 | if (virNetlinkBridgeVlanFilterSet(ifname, RTM_SETLINK, flags, | ^~~~~~~~~~~ cc1: all warnings being treated as errors Thanks Zhenzhong

2 2

[PATCH rfcv4 00/13] LIBVIRT: X86: TDX support
by Zhenzhong Duan 02 Apr '25

02 Apr '25

Hi, This series brings libvirt the x86 TDX support. * What's TDX? TDX stands for Trust Domain Extensions which isolates VMs from the virtual-machine manager (VMM)/hypervisor and any other software on the platform. To support TDX, multiple software components, not only KVM but also QEMU, guest Linux and virtual bios, need to be updated. For more details, please check link[1]. This patchset is another software component to extend libvirt to support TDX, with which one can start a TDX guest from high level rather than running qemu directly. * Misc As QEMU use a software emulated way to reset guest which isn't supported by TDX guest for security reason. We simulate reboot for TDX guest by kill and create a new one in FakeReboot framework. Complete code can be found at [2], matching qemu code can be found at [3]. There is a 'debug' property for tdx-guest object which isn't in matching qemu[3] yet. I keep them intentionally as they will be implemented in qemu as extention series of [3]. * Test start/stop/reboot with virsh stop/reboot trigger in guest stop with on_poweroff=destroy/restart reboot with on_reboot=destroy/restart * Patch organization - patch 1-4: Support query of TDX capabilities. - patch 5-8: Add TDX type to launchsecurity framework. - patch 9-11: Add reboot support to TDX guest - patch 12-13: Add test and docs TODO: - update QEMU capabilities data in tests, depending on qemu TDX merged beforehand - add reconnect logic in virsh command [1] https://lore.kernel.org/kvm/cover.1708933498.git.isaku.yamahata@intel.com [2] https://github.com/intel/libvirt-tdx/commits/tdx_for_upstream_rfcv4 [3] https://github.com/intel/qemu-tdx/tree/tdx-qemu-upstream-v5 Thanks Zhenzhong Changelog: rfcv4: - add a check to tools/virt-host-validate-qemu.c (Daniel) - remove check of q35 (Daniel) - model 'SocktetAddress' QAPI in xml schema (Daniel) - s/Quote-Generation-Service/quoteGenerationService/ (Daniel) - define bits in tdx->policy and add validating logic (Daniel) - presume QEMU choose split kernel irqchip for TDX guest by default (Daniel) - utilize existing FakeReboot framework to do reboot for TDX guest (Daniel) - drop patch11 'conf: Add support to keep same domid for hard reboot' (Daniel) - add test in tests/ to validate parsing and formatting logic (Daniel) - add doc in docs/formatdomain.rst (Daniel) - add R-B rfcv3: - Change to generate qemu cmdline with -bios - drop firmware auto match as -bios is used - add a hard reboot method to reboot TDX guest rfcv3: https://www.mail-archive.com/devel@lists.libvirt.org/msg00385.html rfcv2: - give up using qmp cmd and check TDX directly on host for TDX capabilities. - use launchsecurity framework to support TDX - use <os>.<loader> for general loader - add auto firmware match feature for TDX A example TDVF fimware description file 70-edk2-x86_64-tdx.json: { "description": "UEFI firmware for x86_64, supporting Intel TDX", "interface-types": [ "uefi" ], "mapping": { "device": "generic", "filename": "/usr/share/OVMF/OVMF_CODE-tdx.fd" }, "targets": [ { "architecture": "x86_64", "machines": [ "pc-q35-*" ] } ], "features": [ "intel-tdx", "verbose-dynamic" ], "tags": [ ] } rfcv2: https://www.mail-archive.com/libvir-list@redhat.com/msg219378.html Zhenzhong Duan (13): tools: Secure guest check for Intel in virt-host-validate qemu: Check if INTEL Trust Domain Extention support is enabled qemu: Add TDX capability conf: expose TDX feature in domain capabilities conf: add tdx as launch security type qemu: Add command line and validation for TDX type qemu: force special parameters enabled for TDX guest Add Intel TDX Quote Generation Service(QGS) support qemu: add FakeReboot support for TDX guest qemu: Support reboot command in guest qemu: Avoid duplicate FakeReboot for secure guest Add test cases for Intel TDX docs: domain: Add documentation for Intel TDX guest docs/formatdomain.rst | 68 ++++ docs/formatdomaincaps.rst | 1 + src/conf/domain_capabilities.c | 1 + src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 312 ++++++++++++++++++ src/conf/domain_conf.h | 75 +++++ src/conf/schemas/domaincaps.rng | 9 + src/conf/schemas/domaincommon.rng | 135 ++++++++ src/conf/virconftypes.h | 2 + src/qemu/qemu_capabilities.c | 36 +- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 139 ++++++++ src/qemu/qemu_firmware.c | 1 + src/qemu/qemu_monitor.c | 28 +- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.c | 6 +- src/qemu/qemu_namespace.c | 1 + src/qemu/qemu_process.c | 75 +++++ src/qemu/qemu_validate.c | 44 +++ ...unch-security-tdx-qgs-fd.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-fd.xml | 30 ++ ...ch-security-tdx-qgs-inet.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-inet.xml | 30 ++ ...ch-security-tdx-qgs-unix.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-unix.xml | 30 ++ ...h-security-tdx-qgs-vsock.x86_64-latest.xml | 77 +++++ .../launch-security-tdx-qgs-vsock.xml | 30 ++ tests/qemuxmlconftest.c | 24 ++ tools/virt-host-validate-common.c | 22 +- tools/virt-host-validate-common.h | 1 + 30 files changed, 1407 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-fd.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-fd.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-inet.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-inet.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-unix.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-unix.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-vsock.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/launch-security-tdx-qgs-vsock.xml -- 2.34.1

6 45

[PATCH] virt-aa-helper: delete dynamic files
by Alessandro 01 Apr '25

01 Apr '25

We attempted multiple ways to clean up dynamic files; however, we must preserve user overrides, which requires keeping the file /etc/apparmor.d/libvirt/libvirt-uuid This commit proposes to move user overrides into /etc/apparmor.d/libvirt/libvirt-uuid.local and include it, if present, unconditionally. When we stop the domain, we remove libvirt.uuid and libvirt-uuid.files, whereas we preserve libvirt-uuid.local if present. Applying the patch, it produces the following: root@virt-hv-lab002:/etc/apparmor.d/libvirt# ls -1 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033* libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 profile libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 flags=(attach_disconnected) { #include <abstractions/libvirt-qemu> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.local> } root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files "/var/log/libvirt/**/testing-9a4be628.log" w, "/var/lib/libvirt/qemu/domain-testing-9a4be628/monitor.sock" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/*" rw, "/var/run/libvirt/**/testing-9a4be628.pid" rwk, "/var/run/libvirt/**/*.tunnelmigrate.dest.testing-9a4be628" rw, "/var/lib/libvirt/images/testing-9a4be628.qcow2" rwk, "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" rk, # don't audit writes to readonly files deny "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" w, "/var/lib/libvirt/images/testing-9a4be628-ds.qcow2" rwk, "/usr/share/OVMF/OVMF_CODE_4M.fd" rk, # don't audit writes to readonly files deny "/usr/share/OVMF/OVMF_CODE_4M.fd" w, "/var/lib/libvirt/qemu/nvram/testing-9a4be628_VARS.fd" rwk, "/dev/vhost-net" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/{,**}" rwk, "/run/libvirt/qemu/channel/4-testing-9a4be628/{,**}" rwk, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/master-key.aes" rwk, "/dev/net/tun" rwk, "/dev/userfaultfd" rwk, Fixes: https://gitlab.com/libvirt/libvirt/-/issues/451 Signed-off-by: Alessandro <alessandro(a)0x65c.net> --- src/security/virt-aa-helper.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 034c042..6a1fb85 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1495,8 +1495,10 @@ main(int argc, char **argv) rc = parserLoad(ctl->uuid); } else if (ctl->cmd == 'R' || ctl->cmd == 'D') { rc = parserRemove(ctl->uuid); - if (ctl->cmd == 'D') + if (ctl->cmd == 'D') { unlink(include_file); + unlink(profile); + } } else if (ctl->cmd == 'c' || ctl->cmd == 'r') { g_autofree char *included_files = NULL; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; @@ -1561,12 +1563,18 @@ main(int argc, char **argv) /* create the profile from TEMPLATE */ if (ctl->cmd == 'c' || purged) { g_autofree char *tmp = NULL; + g_autofree char *tmp_local = NULL; + char *new_tmp = NULL; #if defined(WITH_APPARMOR_3) const char *ifexists = "if exists "; #else const char *ifexists = ""; #endif tmp = g_strdup_printf(" #include %s<libvirt/%s.files>\n", ifexists, ctl->uuid); + tmp_local = g_strdup_printf(" #include %s<libvirt/%s.local>\n", ifexists, ctl->uuid); + new_tmp = g_strconcat(tmp, tmp_local, NULL); + g_free(tmp); + tmp = g_steal_pointer(&new_tmp); if (ctl->dryrun) { vah_info(profile); -- 2.49.0

3 9

[PATCH] news: document dropping apparmor < 3.0.0
by Daniel P. Berrangé 01 Apr '25

01 Apr '25

From: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NEWS.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 0cb11313cd..d359bc5a32 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,8 @@ v11.3.0 (unreleased) * **Removed features** + * Support for AppArmor versions prior to 3.0.0 has been dropped + * **New features** * **Improvements** -- 2.48.1

2 1

Release of libvirt-11.2.0
by Jiri Denemark 01 Apr '25

01 Apr '25

The 11.2.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * Removed features * Remove support for qemu-6.1 and older Libvirt now requires *qemu-6.2* or newer based on our platform support policy. * New features * qemu: Add new 'image_format' parameter to virDomainSaveParams ``virDomainSaveParams`` now supports an ``image_format`` parameter for specifying the save image format on a per-domain basis. The parameter accepts the same values as the driver-wide ``save_image_format`` setting in ``qemu.conf``. An image format specified via ``virDomainSaveParams`` takes precedence over the driver-wide setting. * qemu: Added guest load averages to the output of virDomainGetGuestInfo This feature will be available with qemu guest agent 10.0 onwards. * qemu: Add support for multiple iothreads for ``virtio-scsi`` controller It's now possible to map multiple iothreads to the ``virtio-scsi`` controller or even map them to specific virtqueues similarly to the ``virtio-blk`` device allowing for better performance in certain scenarios. * qemu: integrate support for VM shutdown on host shutdown It is now possible to instruct the QEMU driver to automatically perform managed save, graceful shutdown, or hard poweroff on running VMs, when a host shutdown is requested. This feature is intended to eventually replace usage of the libvirt-guests script. The new approach improves on the libvirt-guests script, by proactively monitoring logind for a signal that a host shutdown has been requested. It will initiate the chosen action on running guests immediately, allowing shutdown inhibitors to be released sooner. The new solution is also able to iteratively try multiple actions until one of them succeeds in shutting down the VM. Since it must be mutually exclusive with the libvirt-guests script, this feature currently requires a manual opt-in through editing of the /etc/libvirt/qemu.conf configuration file. The libvirt-guests script must be disabled before doing this. * qemu: Add 'sparse' as a new save image format QEMU's ``file`` migration has been supplemented with the new stream format ``mapped-ram``, where RAM pages are mapped directly to offsets in the migration file. ``mapped-ram`` is now supported by augmenting the existing save image formats with the ``sparse`` format. * qemu: Add support for parallel save/restore The ``sparse`` image format can support reading and writing by multiple channels. ``virDomainSaveParams`` and ``virDomainRestoreParams`` now support specifying the number of IO channels used for parallel save and restore. Using multiple channels can reduce the time required to save and restore domains. * virsh: Introduce new hypervisor-cpu-models command Added a new virsh command ``hypervisor-cpu-models``. The command pulls from the existing domcapabilities XML and uses xpath to parse CPU model strings. By default, only models reported as usable by the hypervisor on the host system are printed. A user may specify ``--all`` to also print models which are not supported on the host. * qemu: Introduce os/shim element For secure boot environments where ``<loader/>`` is signed, it may be unfeasible to keep the binary up to date (esp. when revoking certificates contained within). To address that, new ``<shim/>`` element is introduced which allows hypervisor to side load another UEFI binary, which can then contain new certification authorities and/or list of revocations. * ch: Enable SEV SNP support Cloud Hypervisor guests can be now started with SEV SNP enabled. * qemu: Support for Block Disk Along with Throttle Filters Introduce support for multiple throttle groups per block disk in QEMU, enhancing I/O control and performance optimization. This update builds on the existing throttling functionality by allowing more granular control with the ability to assign different throttle groups to multiple block devices, improving shared throttling across devices. * Improvements * qemu: Improved guest agent corner case error reporting The APIs using the guest agent now report two specific error codes aimed at helping management applications/users to differentiate between timeout while libvirt was synchronizing with the guest agent and timeout after a command was already sent. The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and ``VIR_ERR_AGENT_COMMAND_FAILED``. * qemu: Use common check for shared memory use for ``vhost-user`` network devices Historically libvirt printed only a warning if the ``vhost-user`` network was misconfigured. Since we enforce proper configuration for other device types using ``vhost-user`` it is now enforced also for network devices and prints an actual error on misconfiguration. * Introduce constants for discoverability of entries in bulk stats APIs Libvirt introduced constants exposed by our API description XML which allows discoverability of new entries in typed parameter names returned by ``virConnectGetAllDomainStats``, ``virDomainListGetStats``, and ``virDomainGetGuestInfo``. * qemu: Reflect MAC address change in live domain XML When a guest changes MAC address on one of its vNICs the new MAC address is now visible in the live XML under ``currentAddress`` attribute of ``<mac/>`` element. At the same time, ``VIR_DOMAIN_EVENT_ID_NIC_MAC_CHANGE`` event is emitted so that management applications can update their internal state. * Bug fixes * qemu: attach virtio-mem with CCW address Attaching a virtio-mem device on s390 without an address type now gets a default type CCW address assigned. A specified CCW address is now used for the virtio-mem device instead of getting overwritten by a PCI address. * ch: Various memory leak fixes There were some memory leaks identified in the Cloud Hypervisor driver. They are fixed now. Enjoy. Jirka

1 0

[libvirt PATCH 0/7] Deprecate the QEMU driver
by Ján Tomko 01 Apr '25

01 Apr '25

See patch 3/7 (7/3 for Americans) for the reasoning Ján Tomko (7): Add a copy of the Sandwich license remote: do not generate the qemu protocol header Deprecate the QEMU driver meson: remove all references to QEMU Remove src/qemu/ tests: remove qemu NEWS: Document the QEMU driver removal COPYING.Sandwich | 6 + NEWS.rst | 64 +- docs/html/meson.build | 2 +- docs/manpages/meson.build | 4 - docs/meson.build | 7 +- libvirt.spec.in | 2 +- meson.build | 97 +- src/meson.build | 64 +- src/qemu/libvirt-qemu.sysusers.conf | 4 - src/qemu/libvirt_qemu_probes.d | 22 - [...] src/qemu/qemu_shim.c | 418 - src/qemu/qemu_slirp.c | 348 - src/qemu/qemu_slirp.h | 72 - src/qemu/qemu_snapshot.c | 4661 -- src/qemu/qemu_snapshot.h | 91 - src/qemu/qemu_tpm.c | 1377 - src/qemu/qemu_tpm.h | 70 - src/qemu/qemu_validate.c | 5616 -- src/qemu/qemu_validate.h | 46 - src/qemu/qemu_vhost_user.c | 512 - src/qemu/qemu_vhost_user.h | 59 - src/qemu/qemu_vhost_user_gpu.c | 251 - src/qemu/qemu_vhost_user_gpu.h | 48 - src/qemu/qemu_virtiofs.c | 481 - src/qemu/qemu_virtiofs.h | 45 - src/qemu/test_libvirtd_qemu.aug.in | 138 - src/qemu/virtqemud.init.in | 26 - src/qemu/virtqemud.service.extra.in | 18 - src/qemu/virtqemud.socket.extra.in | 2 - src/remote/meson.build | 12 +- src/remote/qemu_protocol.h | 23 + src/security/apparmor/meson.build | 4 +- tests/meson.build | 101 - tests/qemuagentdata/fsinfo.xml | 39 - tests/qemuagenttest.c | 1442 - tests/qemublocktest.c | 1395 - .../backupmerge/basic-deep-out.json | 25 - .../backupmerge/basic-flat-out.json | 25 - .../backupmerge/basic-intermediate-out.json | 25 - .../backupmerge/empty-out.json | 1 - .../backupmerge/snapshots-deep-out.json | 41 - tests/qemuxmlconfdata/x86_64-pc-graphics.xml | 56 - [...] .../x86_64-pc-headless.x86_64-latest.args | 48 - .../x86_64-pc-headless.x86_64-latest.xml | 78 - tests/qemuxmlconfdata/x86_64-pc-headless.xml | 51 - ...4-pc-minimal.x86_64-latest.abi-update.args | 33 - ...64-pc-minimal.x86_64-latest.abi-update.xml | 31 - .../x86_64-pc-minimal.x86_64-latest.args | 33 - .../x86_64-pc-minimal.x86_64-latest.xml | 31 - tests/qemuxmlconfdata/x86_64-pc-minimal.xml | 12 - ...fault-models.x86_64-latest.abi-update.args | 47 - ...efault-models.x86_64-latest.abi-update.xml | 71 - ...6_64-q35-default-models.x86_64-latest.args | 47 - ...86_64-q35-default-models.x86_64-latest.xml | 71 - .../x86_64-q35-default-models.xml | 24 - .../x86_64-q35-graphics.x86_64-latest.args | 59 - .../x86_64-q35-graphics.x86_64-latest.xml | 125 - tests/qemuxmlconfdata/x86_64-q35-graphics.xml | 56 - .../x86_64-q35-headless.x86_64-latest.args | 57 - .../x86_64-q35-headless.x86_64-latest.xml | 117 - tests/qemuxmlconfdata/x86_64-q35-headless.xml | 51 - ...-q35-minimal.x86_64-latest.abi-update.args | 38 - ...4-q35-minimal.x86_64-latest.abi-update.xml | 50 - .../x86_64-q35-minimal.x86_64-latest.args | 38 - .../x86_64-q35-minimal.x86_64-latest.xml | 50 - tests/qemuxmlconfdata/x86_64-q35-minimal.xml | 12 - tests/qemuxmlconftest.c | 3032 -- tools/meson.build | 16 - tools/wireshark/src/libvirt/meson.build | 2 - 4381 files changed, 82 insertions(+), 1491066 deletions(-) Tell me, isn't that beautiful? create mode 100644 COPYING.Sandwich delete mode 100644 src/qemu/libvirt-qemu.sysusers.conf delete mode 100644 src/qemu/libvirt_qemu_probes.d delete mode 100644 src/qemu/libvirtd_qemu.aug delete mode 100644 src/qemu/meson.build delete mode 100644 src/qemu/postcopy-migration.sysctl delete mode 100644 src/qemu/qemu.conf.in delete mode 100644 src/qemu/qemu_agent.c delete mode 100644 src/qemu/qemu_agent.h delete mode 100644 src/qemu/qemu_alias.c delete mode 100644 src/qemu/qemu_alias.h delete mode 100644 src/qemu/qemu_backup.c delete mode 100644 src/qemu/qemu_backup.h delete mode 100644 src/qemu/qemu_block.c delete mode 100644 src/qemu/qemu_block.h delete mode 100644 src/qemu/qemu_blockjob.c delete mode 100644 src/qemu/qemu_blockjob.h delete mode 100644 src/qemu/qemu_capabilities.c delete mode 100644 src/qemu/qemu_capabilities.h delete mode 100644 src/qemu/qemu_capspriv.h delete mode 100644 src/qemu/qemu_cgroup.c delete mode 100644 src/qemu/qemu_cgroup.h delete mode 100644 src/qemu/qemu_chardev.c delete mode 100644 src/qemu/qemu_chardev.h delete mode 100644 src/qemu/qemu_checkpoint.c delete mode 100644 src/qemu/qemu_checkpoint.h delete mode 100644 src/qemu/qemu_command.c delete mode 100644 src/qemu/qemu_command.h delete mode 100644 src/qemu/qemu_conf.c delete mode 100644 src/qemu/qemu_conf.h delete mode 100644 src/qemu/qemu_dbus.c delete mode 100644 src/qemu/qemu_dbus.h delete mode 100644 src/qemu/qemu_domain.c delete mode 100644 src/qemu/qemu_domain.h delete mode 100644 src/qemu/qemu_domain_address.c delete mode 100644 src/qemu/qemu_domain_address.h delete mode 100644 src/qemu/qemu_domainjob.c delete mode 100644 src/qemu/qemu_domainjob.h delete mode 100644 src/qemu/qemu_driver.c delete mode 100644 src/qemu/qemu_driver.h delete mode 100644 src/qemu/qemu_extdevice.c delete mode 100644 src/qemu/qemu_extdevice.h delete mode 100644 src/qemu/qemu_fd.c delete mode 100644 src/qemu/qemu_fd.h delete mode 100644 src/qemu/qemu_firmware.c delete mode 100644 src/qemu/qemu_firmware.h delete mode 100644 src/qemu/qemu_hostdev.c delete mode 100644 src/qemu/qemu_hostdev.h delete mode 100644 src/qemu/qemu_hotplug.c delete mode 100644 src/qemu/qemu_hotplug.h delete mode 100644 src/qemu/qemu_interface.c delete mode 100644 src/qemu/qemu_interface.h delete mode 100644 src/qemu/qemu_interop_config.c delete mode 100644 src/qemu/qemu_interop_config.h delete mode 100644 src/qemu/qemu_migration.c delete mode 100644 src/qemu/qemu_migration.h delete mode 100644 src/qemu/qemu_migration_cookie.c delete mode 100644 src/qemu/qemu_migration_cookie.h delete mode 100644 src/qemu/qemu_migration_params.c delete mode 100644 src/qemu/qemu_migration_params.h delete mode 100644 src/qemu/qemu_migration_paramspriv.h delete mode 100644 src/qemu/qemu_monitor.c delete mode 100644 src/qemu/qemu_monitor.h delete mode 100644 src/qemu/qemu_monitor_json.c delete mode 100644 src/qemu/qemu_monitor_json.h delete mode 100644 src/qemu/qemu_monitor_priv.h delete mode 100644 src/qemu/qemu_monitor_text.c delete mode 100644 src/qemu/qemu_monitor_text.h delete mode 100644 src/qemu/qemu_namespace.c delete mode 100644 src/qemu/qemu_namespace.h delete mode 100644 src/qemu/qemu_nbdkit.c delete mode 100644 src/qemu/qemu_nbdkit.h delete mode 100644 src/qemu/qemu_nbdkitpriv.h delete mode 100644 src/qemu/qemu_passt.c delete mode 100644 src/qemu/qemu_passt.h delete mode 100644 src/qemu/qemu_postparse.c delete mode 100644 src/qemu/qemu_postparse.h delete mode 100644 src/qemu/qemu_process.c delete mode 100644 src/qemu/qemu_process.h delete mode 100644 src/qemu/qemu_processpriv.h delete mode 100644 src/qemu/qemu_qapi.c delete mode 100644 src/qemu/qemu_qapi.h delete mode 100644 src/qemu/qemu_rdp.c delete mode 100644 src/qemu/qemu_rdp.h delete mode 100644 src/qemu/qemu_saveimage.c delete mode 100644 src/qemu/qemu_saveimage.h delete mode 100644 src/qemu/qemu_security.c delete mode 100644 src/qemu/qemu_security.h delete mode 100644 src/qemu/qemu_shim.c delete mode 100644 src/qemu/qemu_slirp.c delete mode 100644 src/qemu/qemu_slirp.h delete mode 100644 src/qemu/qemu_snapshot.c delete mode 100644 src/qemu/qemu_snapshot.h delete mode 100644 src/qemu/qemu_tpm.c delete mode 100644 src/qemu/qemu_tpm.h delete mode 100644 src/qemu/qemu_validate.c delete mode 100644 src/qemu/qemu_validate.h delete mode 100644 src/qemu/qemu_vhost_user.c delete mode 100644 src/qemu/qemu_vhost_user.h delete mode 100644 src/qemu/qemu_vhost_user_gpu.c delete mode 100644 src/qemu/qemu_vhost_user_gpu.h delete mode 100644 src/qemu/qemu_virtiofs.c delete mode 100644 src/qemu/qemu_virtiofs.h delete mode 100644 src/qemu/test_libvirtd_qemu.aug.in delete mode 100644 src/qemu/virtqemud.init.in delete mode 100644 src/qemu/virtqemud.service.extra.in delete mode 100644 src/qemu/virtqemud.socket.extra.in create mode 100644 src/remote/qemu_protocol.h delete mode 100644 tests/qemuagentdata/fsinfo.xml delete mode 100644 tests/qemuagenttest.c delete mode 100644 tests/qemublocktest.c delete mode 100644 tests/qemublocktestdata/backupmerge/basic-deep-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/basic-flat-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/basic-intermediate-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/empty-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/snapshots-deep-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/snapshots-flat-out.json delete mode 100644 tests/qemublocktestdata/backupmerge/snapshots-intermediate-out.json [...] delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-default-models.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-default-models.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-default-models.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-graphics.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-graphics.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-graphics.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-headless.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-headless.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-headless.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.abi-update.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.abi-update.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.args delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.x86_64-latest.xml delete mode 100644 tests/qemuxmlconfdata/x86_64-q35-minimal.xml delete mode 100644 tests/qemuxmlconftest.c -- 2.49.0

2 8

[PATCH 0/8] Support FD passing for the NBD server socket used for backup
by Peter Krempa 01 Apr '25

01 Apr '25

See 6/8 for justification. Peter Krempa (8): virDomainStorageNetworkParseHost: Remove unpopulated 'transport' variable virDomainStorageNetworkParseHost: Refactor cleanup conf: Introduce VIR_STORAGE_NET_HOST_TRANS_FD virStorageNetHostDefClear: Move into virStorageNetHostDefFree qemu: monitor: Support FD passing of sockets to 'qemuMonitorJSONNBDServerStart' backup: Add support for passing server socket file descriptor to backup NBD server tests: domainbackupxml2xml: Add test case for pull-mode backup with NBD transport='fd' qemu: monitor: Improve field annotations in QEMU_CHECK_MONITOR docs/formatbackup.rst | 21 +++++ src/conf/backup_conf.c | 3 +- src/conf/domain_conf.c | 93 ++++++++++++------- src/conf/domain_conf.h | 3 +- src/conf/schemas/domainbackup.rng | 6 ++ src/conf/storage_source_conf.c | 20 ++-- src/conf/storage_source_conf.h | 7 +- src/libvirt_private.syms | 1 - src/qemu/qemu_backup.c | 28 ++++++ src/qemu/qemu_block.c | 1 + src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_monitor_json.c | 21 +++++ .../storage_file_backend_gluster.c | 1 + .../domainbackupxml2xmlin/backup-pull-fd.xml | 22 +++++ .../domainbackupxml2xmlout/backup-pull-fd.xml | 23 +++++ tests/genericxml2xmltest.c | 1 + 16 files changed, 198 insertions(+), 55 deletions(-) create mode 100644 tests/domainbackupxml2xmlin/backup-pull-fd.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull-fd.xml -- 2.49.0

2 12

Re: [PATCH RESEND 0/6] Add support for configuring PCI high memory MMIO size
by Matt Ochs 31 Mar '25

31 Mar '25

Gentle ping. Is there any feedback, comment, or suggestion about this series? -matt

1 0

[PATCH] virt-aa-helper: delete dynamic files
by Alessandro 31 Mar '25

31 Mar '25

We attempted multiple ways to clean up dynamic files; however, we must preserve user overrides, which requires keeping the file /etc/apparmor.d/libvirt/libvirt-uuid This commit proposes to move user overrides into /etc/apparmor.d/libvirt/libvirt-uuid.local and include it, if present, unconditionally. When we stop the domain, we remove libvirt.uuid and libvirt-uuid.files, whereas we preserve libvirt-uuid.local if present. Applying the patch, it produces the following: root@virt-hv-lab002:/etc/apparmor.d/libvirt# ls -1 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033* libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 profile libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033 flags=(attach_disconnected) { #include <abstractions/libvirt-qemu> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files> #include if exists <libvirt/libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.local> } root@virt-hv-lab002:/etc/apparmor.d/libvirt# cat libvirt-e7424556-ffc1-4f6e-bafa-84e66c4dc033.files "/var/log/libvirt/**/testing-9a4be628.log" w, "/var/lib/libvirt/qemu/domain-testing-9a4be628/monitor.sock" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/*" rw, "/var/run/libvirt/**/testing-9a4be628.pid" rwk, "/var/run/libvirt/**/*.tunnelmigrate.dest.testing-9a4be628" rw, "/var/lib/libvirt/images/testing-9a4be628.qcow2" rwk, "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" rk, # don't audit writes to readonly files deny "/var/lib/libvirt/images/noble-server-cloudimg-amd64.img" w, "/var/lib/libvirt/images/testing-9a4be628-ds.qcow2" rwk, "/usr/share/OVMF/OVMF_CODE_4M.fd" rk, # don't audit writes to readonly files deny "/usr/share/OVMF/OVMF_CODE_4M.fd" w, "/var/lib/libvirt/qemu/nvram/testing-9a4be628_VARS.fd" rwk, "/dev/vhost-net" rw, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/{,**}" rwk, "/run/libvirt/qemu/channel/4-testing-9a4be628/{,**}" rwk, "/var/lib/libvirt/qemu/domain-4-testing-9a4be628/master-key.aes" rwk, "/dev/net/tun" rwk, "/dev/userfaultfd" rwk, Fixes: https://gitlab.com/libvirt/libvirt/-/issues/451 Signed-off-by: Alessandro <alessandro(a)0x65c.net> --- src/security/virt-aa-helper.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 034c042..8f044a1 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1495,8 +1495,10 @@ main(int argc, char **argv) rc = parserLoad(ctl->uuid); } else if (ctl->cmd == 'R' || ctl->cmd == 'D') { rc = parserRemove(ctl->uuid); - if (ctl->cmd == 'D') + if (ctl->cmd == 'D'){ unlink(include_file); + unlink(profile); + } } else if (ctl->cmd == 'c' || ctl->cmd == 'r') { g_autofree char *included_files = NULL; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; @@ -1561,12 +1563,15 @@ main(int argc, char **argv) /* create the profile from TEMPLATE */ if (ctl->cmd == 'c' || purged) { g_autofree char *tmp = NULL; + g_autofree char *tmp_local = NULL: #if defined(WITH_APPARMOR_3) const char *ifexists = "if exists "; #else const char *ifexists = ""; #endif tmp = g_strdup_printf(" #include %s<libvirt/%s.files>\n", ifexists, ctl->uuid); + tmp_local = g_strdup_printf(" #include %s<libvirt/%s.local>\n", ifexists, ctl->uuid); + tmp = g_strconcat(tmp,tmp_local, NULL); if (ctl->dryrun) { vah_info(profile); -- 2.49.0

2 2

[PATCH 0/4] ch: timeout fix (GitLab issue #743)
by Kirill Shchetiniuk 31 Mar '25

31 Mar '25

This patch series is supposed to fix the following reported issue on GitLab: virtchd times out even with an active guest running https://gitlab.com/libvirt/libvirt/-/issues/743 During further investigation, we found that there are in fact two bugs: 1. The CH driver does not store any domains' XMLs onto disk, and as a result it does not have any information about running domains when it restarts. Previously, the CH driver did not save any XMLs onto the disk, neither transient nor persistent definitions. To address this issue, add transient domain XML saving when a new domain is defined, as well as saving transient domain XML when a domain starts, to enable reconnecting to running domains when the driver restarts. Now all persistent and transient definitions are stored onto the disk. Also add running domain reconnection helper functions to restore the connection between the driver and running VMM when the driver restarts, to be able to continue work with running domains. 2. Timeout should not be active while a client is connected or there is a running domain. The second bug led to a situation where the CH driver timed out (e.g., --timeout 60) even when some domains were still running. Previously, only an active virsh session prevented the driver from timing out. To address this issue, an inhibitor for the CH driver has been added to prevent the timeout. The inhibitor now stores the count of running domains and prevents the timeout if the count is above zero. NOTE: This series patch series is depend on followin patch series: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/O3SK… Kirill Shchetiniuk (4): ch: add persistent definition save and load ch: add transient definition save and load ch: add reconnection to running domains ch: fix timeout while domain is still running src/ch/ch_conf.c | 10 ++- src/ch/ch_conf.h | 6 ++ src/ch/ch_domain.c | 15 +++++ src/ch/ch_domain.h | 3 + src/ch/ch_driver.c | 49 ++++++++++++++- src/ch/ch_monitor.c | 65 ++++++++++++++++++++ src/ch/ch_monitor.h | 2 + src/ch/ch_process.c | 147 ++++++++++++++++++++++++++++++++++++++++++++ src/ch/ch_process.h | 2 + 9 files changed, 293 insertions(+), 6 deletions(-) -- 2.48.1

1 4

[PATCH v2 0/5] apparmor: assume at least version 3
by Daniel P. Berrangé 31 Mar '25

31 Mar '25

In v2: - Do upfront check for apparmor >= 3.0.0 - Add further revert commit Daniel P. Berrangé (5): meson: mandate apparmor >= 3.0.0 apparmor: assume at least apparmor >= 3 Revert "apparmor: Allow version-specific bits in abstractions too" Revert "apparmor: Allow version-specific bits in profiles" meson: drop remaining checks for apparmor version meson.build | 7 +- .../apparmor/{libvirt-lxc.in => libvirt-lxc} | 2 - .../{libvirt-qemu.in => libvirt-qemu} | 4 -- src/security/apparmor/meson.build | 64 ++----------------- .../usr.lib.libvirt.virt-aa-helper.in | 5 -- src/security/apparmor/usr.sbin.libvirtd.in | 2 - src/security/apparmor/usr.sbin.virtqemud.in | 2 - src/security/apparmor/usr.sbin.virtxend.in | 2 - src/security/virt-aa-helper.c | 9 +-- 9 files changed, 10 insertions(+), 87 deletions(-) rename src/security/apparmor/{libvirt-lxc.in => libvirt-lxc} (99%) rename src/security/apparmor/{libvirt-qemu.in => libvirt-qemu} (99%) -- 2.48.1

2 6

[PATCH 0/3] apparmor: assume at least version 3
by Daniel P. Berrangé 31 Mar '25

31 Mar '25

Daniel P. Berrangé (3): apparmor: assume at least apparmor >= 3 Revert "apparmor: Allow version-specific bits in profiles" meson: drop remaining checks for apparmor version meson.build | 3 -- src/security/apparmor/libvirt-lxc.in | 2 - src/security/apparmor/libvirt-qemu.in | 4 -- src/security/apparmor/meson.build | 45 +------------------ .../usr.lib.libvirt.virt-aa-helper.in | 5 --- src/security/apparmor/usr.sbin.libvirtd.in | 2 - src/security/apparmor/usr.sbin.virtqemud.in | 2 - src/security/apparmor/usr.sbin.virtxend.in | 2 - src/security/virt-aa-helper.c | 9 +--- 9 files changed, 3 insertions(+), 71 deletions(-) -- 2.48.1

2 6

[PATCH v2 0/1] NEWS: qemu: Support for Block Disk Along with Throttle Filters
by Harikumar Rajkumar 31 Mar '25

31 Mar '25

NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: qemu: support block disk along with throttle filters NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) -- 2.48.1

2 4

[PATCH] virDomainDiskDefValidateSourceChainOne: Fix validation of 'data-file' nesting
by Peter Krempa 28 Mar '25

28 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> As the 'dataStore' is internally represented as a virStorageSource object it has provisions for nesting which is not supported. When I've reviewed and modified the commit adding data file parsing support I've added code that was supposed to reject any 'backingStore' and 'dataStore' structures nested in a source of a 'dataStore'. Unfortunately the check was broken as one of the terms checked the presence of parent's 'backingStore' instead of the nesting. Fix it and add tests. Fixes: b3171cf8da3 Resolves: https://issues.redhat.com/browse/RHEL-85320 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/domain_validate.c | 2 +- ...sk-qcow2-datafile-store.x86_64-latest.args | 43 +++++++++++-------- ...isk-qcow2-datafile-store.x86_64-latest.xml | 22 +++++++++- .../disk-qcow2-datafile-store.xml | 19 ++++++++ 4 files changed, 66 insertions(+), 20 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 396d1e400a..d0d4bc0bf4 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -562,7 +562,7 @@ virDomainDiskDefValidateSourceChainOne(const virStorageSource *src) return -1; } - if (src->dataFileStore->dataFileStore || src->backingStore) { + if (src->dataFileStore->dataFileStore || src->dataFileStore->backingStore) { virReportError(VIR_ERR_XML_ERROR, "%s", _("The <source> of <dataStore> can't have another nested <dataStore> or <backingStore> element")); return -1; diff --git a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args index 5a64246af6..74f2d1a090 100644 --- a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args +++ b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.args @@ -27,25 +27,32 @@ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-QEMUGuest1/.config \ -no-shutdown \ -boot strict=on \ -device '{"driver":"piix3-usb-uhci","id":"usb","bus":"pci.0","addr":"0x1.0x2"}' \ --blockdev '{"driver":"file","filename":"/tmp/data-file-store","node-name":"libvirt-9-storage","read-only":false}' \ --blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock"},"export":"Volume2/Image","node-name":"libvirt-8-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"driver":"file","filename":"/tmp/data-file-store","node-name":"libvirt-13-storage","read-only":false}' \ +-blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock"},"export":"Volume2/Image","node-name":"libvirt-12-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-12-format","read-only":false,"driver":"qcow2","data-file":"libvirt-13-storage","file":"libvirt-12-storage"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x2","drive":"libvirt-12-format","id":"virtio-disk0","bootindex":1}' \ +-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","node-name":"libvirt-11-storage","read-only":false}' \ +-blockdev '{"driver":"nbd","server":{"type":"unix","path":"/var/run/nbdsock"},"export":"bar","node-name":"libvirt-10-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-10-format","read-only":false,"driver":"qcow2","data-file":"libvirt-11-storage","file":"libvirt-10-storage"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x3","drive":"libvirt-10-format","id":"virtio-disk1"}' \ +-blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock/datafile"},"export":"Volume2/ImageDataFile","node-name":"libvirt-9-storage","read-only":false}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071879","node-name":"libvirt-8-storage","auto-read-only":true,"discard":"unmap"}' \ -blockdev '{"node-name":"libvirt-8-format","read-only":false,"driver":"qcow2","data-file":"libvirt-9-storage","file":"libvirt-8-storage"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x2","drive":"libvirt-8-format","id":"virtio-disk0","bootindex":1}' \ --blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1","node-name":"libvirt-7-storage","read-only":false}' \ --blockdev '{"driver":"nbd","server":{"type":"unix","path":"/var/run/nbdsock"},"export":"bar","node-name":"libvirt-6-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-6-format","read-only":false,"driver":"qcow2","data-file":"libvirt-7-storage","file":"libvirt-6-storage"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x3","drive":"libvirt-6-format","id":"virtio-disk1"}' \ --blockdev '{"driver":"nbd","server":{"type":"unix","path":"/path/to/sock/datafile"},"export":"Volume2/ImageDataFile","node-name":"libvirt-5-storage","read-only":false}' \ --blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071879","node-name":"libvirt-4-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-4-format","read-only":false,"driver":"qcow2","data-file":"libvirt-5-storage","file":"libvirt-4-storage"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x4","drive":"libvirt-4-format","id":"virtio-disk2"}' \ --blockdev '{"driver":"file","filename":"/tmp/data-file-store-2","node-name":"libvirt-3-storage","read-only":true}' \ --blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071877","node-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-2-format","read-only":true,"driver":"qcow2","data-file":"libvirt-3-storage","file":"libvirt-2-storage"}' \ --blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071880","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ --blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"qcow2","file":"libvirt-1-storage","backing":"libvirt-2-format"}' \ --device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x5","drive":"libvirt-1-format","id":"virtio-disk3"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x4","drive":"libvirt-8-format","id":"virtio-disk2"}' \ +-blockdev '{"driver":"file","filename":"/tmp/data-file-store-2","node-name":"libvirt-7-storage","read-only":true}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071877","node-name":"libvirt-6-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-6-format","read-only":true,"driver":"qcow2","data-file":"libvirt-7-storage","file":"libvirt-6-storage"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/rhel7.1484071880","node-name":"libvirt-5-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-5-format","read-only":false,"driver":"qcow2","file":"libvirt-5-storage","backing":"libvirt-6-format"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x5","drive":"libvirt-5-format","id":"virtio-disk3"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/datastore_1","aio":"native","node-name":"libvirt-4-storage","read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/base-with-data-file.qcow","aio":"native","node-name":"libvirt-3-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"node-name":"libvirt-3-format","read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false},"driver":"qcow2","data-file":"libvirt-4-storage","file":"libvirt-3-storage"}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/datastore_2","aio":"native","node-name":"libvirt-2-storage","read-only":false,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/datastore.qcow2","aio":"native","node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap","cache":{"direct":true,"no-flush":false}}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"discard":"unmap","cache":{"direct":true,"no-flush":false},"driver":"qcow2","data-file":"libvirt-2-storage","file":"libvirt-1-storage","backing":"libvirt-3-format"}' \ +-device '{"driver":"virtio-blk-pci","bus":"pci.0","addr":"0x6","drive":"libvirt-1-format","id":"virtio-disk4","write-cache":"on"}' \ -audiodev '{"id":"audio1","driver":"none"}' \ --device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","addr":"0x6"}' \ +-device '{"driver":"virtio-balloon-pci","id":"balloon0","bus":"pci.0","addr":"0x7"}' \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ -msg timestamp=on diff --git a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml index a026749faf..a4bfcb29e0 100644 --- a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml +++ b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.x86_64-latest.xml @@ -69,6 +69,26 @@ <target dev='vdd' bus='virtio'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </disk> + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2' cache='none' io='native' discard='unmap'/> + <source file='/var/lib/libvirt/images/datastore.qcow2'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_2'/> + </dataStore> + </source> + <backingStore type='file'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/base-with-data-file.qcow'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_1'/> + </dataStore> + </source> + </backingStore> + <target dev='vde' bus='virtio'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> + </disk> <controller type='usb' index='0' model='piix3-uhci'> <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> </controller> @@ -77,7 +97,7 @@ <input type='keyboard' bus='ps2'/> <audio id='1' type='none'/> <memballoon model='virtio'> - <address type='pci' domain='0x0000' bus='0x00' slot='0x06' function='0x0'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x07' function='0x0'/> </memballoon> </devices> </domain> diff --git a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml index dff5f15158..9f2671a3e7 100644 --- a/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml +++ b/tests/qemuxmlconfdata/disk-qcow2-datafile-store.xml @@ -62,6 +62,25 @@ </backingStore> <target dev='vdd' bus='virtio'/> </disk> + <disk type='file' device='disk'> + <driver name='qemu' type='qcow2' cache='none' io='native' discard='unmap'/> + <source file='/var/lib/libvirt/images/datastore.qcow2'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_2'/> + </dataStore> + </source> + <backingStore type='file'> + <format type='qcow2'/> + <source file='/var/lib/libvirt/images/base-with-data-file.qcow'> + <dataStore type='file'> + <format type='raw'/> + <source file='/var/lib/libvirt/images/datastore_1'/> + </dataStore> + </source> + </backingStore> + <target dev='vde' bus='virtio'/> + </disk> <controller type='usb' index='0'/> <controller type='pci' index='0' model='pci-root'/> <memballoon model='virtio'/> -- 2.49.0

2 1

Plans for 11.2.0 release (freeze on Tuesday 25 Mar)
by Jiri Denemark 28 Mar '25

28 Mar '25

We are getting close to 11.2.0 release of libvirt. To aim for the release on Tuesday 01 Apr I suggest entering the freeze on Tuesday 25 Mar and tagging RC2 on Friday 28 Mar. I hope this works for everyone. Jirka

1 1

[PATCH] NEWS: Document features/improvements/bug fixes I've participated in
by Michal Privoznik 28 Mar '25

28 Mar '25

From: Michal Privoznik <mprivozn(a)redhat.com> There are some features/improvements/bug fixes I've either contributed or reviewed/merged. Document them for upcoming release. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 18d45656b8..cd5ec4eab2 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -75,6 +75,18 @@ v11.2.0 (unreleased) system are printed. A user may specify ``--all`` to also print models which are not supported on the host. + * qemu: Introduce os/shim element + + For secure boot environments where ``<loader/>`` is signed, it may be + unfeasible to keep the binary up to date (esp. when revoking certificates + contained within). To address that, new ``<shim/>`` element is introduced + which allows hypervisor to side load another UEFI binary, which can then + contain new certification authorities and/or list of revocations. + + * ch: Enable SEV SNP support + + Cloud Hypervisor guests can be now started with SEV SNP enabled. + * **Improvements** * qemu: Improved guest agent corner case error reporting @@ -87,6 +99,14 @@ v11.2.0 (unreleased) The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and ``VIR_ERR_AGENT_COMMAND_FAILED``. + * qemu: Reflect MAC address change in live domain XML + + When a guest changes MAC address on one of its vNICs the new MAC address is + now visible in the live XML under ``currentAddress`` attribute of + ``<mac/>`` element. At the same time, + ``VIR_DOMAIN_EVENT_ID_NIC_MAC_CHANGE`` event is emitted so that management + applications can update their internal state. + * **Bug fixes** * qemu: attach virtio-mem with CCW address @@ -95,6 +115,11 @@ v11.2.0 (unreleased) default type CCW address assigned. A specified CCW address is now used for the virtio-mem device instead of getting overwritten by a PCI address. + * ch: Various memory leak fixes + + There were some memory leaks identified in the Cloud Hypervisor driver. + They are fixed now. + v11.1.0 (2025-03-03) ==================== -- 2.48.1

2 1

[PATCH] esxConnectListAllDomains: Don't propagate failure to lookup a single domain
by Peter Krempa 26 Mar '25

26 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> In esxConnectListAllDomains if the lookup of the VM name and UUID fails for a single VM (possible e.g. with broken storage) the whole API would return failure even when there are working VMs. Rework the lookup so that if a subset fails we ignore the failure on those. We report an error only if lookup of all of the objects failed. Failure is reported from the last one. Resolves: https://issues.redhat.com/browse/RHEL-80606 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/esx/esx_driver.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index 554fb3e18f..d869481698 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -4792,18 +4792,21 @@ esxConnectListAllDomains(virConnectPtr conn, virtualMachine = virtualMachine->_next) { g_autofree char *name = NULL; - if (needIdentity) { - if (esxVI_GetVirtualMachineIdentity(virtualMachine, &id, - &name, uuid) < 0) { + /* If the lookup of the required properties fails for some of the machines + * in the list it's preferrable to return the valid objects instead of + * failing outright */ + if ((needIdentity && esxVI_GetVirtualMachineIdentity(virtualMachine, &id, &name, uuid) < 0) || + (needPowerState && esxVI_GetVirtualMachinePowerState(virtualMachine, &powerState) < 0)) { + + /* Raise error from last lookup if we didn't successfuly fetch any + * domain objecst yet */ + if (count == 0 && !virtualMachine->_next) goto cleanup; - } - } - if (needPowerState) { - if (esxVI_GetVirtualMachinePowerState(virtualMachine, - &powerState) < 0) { - goto cleanup; - } + /* failure to fetch information of a single VM must not interrupt + * the lookup of the rest */ + virResetLastError(); + continue; } /* filter by active state */ -- 2.49.0

2 3

[PATCH] NEWS: Mention bump to qemu-6.2, vhost-user shmem check and stats params discoverabilty
by Peter Krempa 26 Mar '25

26 Mar '25

From: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 18d45656b8..2855ec77e4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -15,6 +15,11 @@ v11.2.0 (unreleased) * **Removed features** + * Remove support for qemu-6.1 and older + + Libvirt now requires *qemu-6.2* or newer based on our platform support + policy. + * **New features** * qemu: Add new 'image_format' parameter to virDomainSaveParams @@ -87,6 +92,21 @@ v11.2.0 (unreleased) The new error codes are ``VIR_ERR_AGENT_COMMAND_TIMEOUT`` and ``VIR_ERR_AGENT_COMMAND_FAILED``. + * qemu: Use common check for shared memory use for ``vhost-user`` network devices + + Historically libvirt printed only a warning if the ``vhost-user`` network + was misconfigured. Since we enforce proper configuration for other device + types using ``vhost-user`` it is now enforced also for network devices and + prints an actual error on misconfiguration. + + + * Introduce constants for discoverability of entries in bulk stats APIs + + Libvirt introduced constants exposed by our API description XML which allows + discoverability of new entries in typed parameter names returned by + ``virConnectGetAllDomainStats``, ``virDomainListGetStats``, and + ``virDomainGetGuestInfo``. + * **Bug fixes** * qemu: attach virtio-mem with CCW address -- 2.49.0

2 1

[PATCH V4 00/18] qemu: support mapped-ram+directio+mulitfd
by Jim Fehlig 25 Mar '25

25 Mar '25

V4 series adding support for QEMU's mapped-ram stream format [1] and migration capability. The use of mapped-ram is controlled by extending save_image_format setting in qemu.conf with a new 'sparse' option. The 'raw' format continues to be the default. Also included are patches that leverage mapped-ram to add support for parallel save/restore. Changes in V4: * Rebased on latest master, including the series "qemu: Support specifying save image format" V1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MNB… V2: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/GNJ… V3: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/SK2… [1] https://gitlab.com/qemu-project/qemu/-/blob/master/docs/devel/migration/map… Claudio Fontana (3): include: Define constants for parallel save/restore tools: add parallel parameter to virsh save command tools: add parallel parameter to virsh restore command Jim Fehlig (15): lib: virDomain{Save,Restore}Params: Ensure absolute path qemu: Add function to get FDPass object from monitor qemu: Add function to check capability in migration params qemu: Add function to get bool value from migration params qemu: Add mapped-ram migration capability qemu: Add function to get migration params for save qemu_saveimage: add "sparse" to supported save image formats qemu: Add helper function for creating save image fd qemu: Add support for mapped-ram on save qemu: Move creation of qemuProcessIncomingDef struct qemu: Apply migration parameters in qemuMigrationDstRun qemu: Add support for mapped-ram on restore qemu: Support O_DIRECT with mapped-ram on save qemu: Support O_DIRECT with mapped-ram on restore qemu: Add support for parallel save and restore docs/manpages/virsh.rst | 21 +++- include/libvirt/libvirt-domain.h | 11 ++ src/libvirt-domain.c | 92 +++++++++++--- src/qemu/qemu.conf.in | 9 +- src/qemu/qemu_driver.c | 78 +++++++++--- src/qemu/qemu_fd.c | 46 +++++++ src/qemu/qemu_fd.h | 4 + src/qemu/qemu_migration.c | 204 ++++++++++++++++++++++--------- src/qemu/qemu_migration.h | 10 +- src/qemu/qemu_migration_params.c | 92 ++++++++++++++ src/qemu/qemu_migration_params.h | 17 +++ src/qemu/qemu_monitor.c | 37 ++++++ src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_process.c | 100 ++++++++++----- src/qemu/qemu_process.h | 19 ++- src/qemu/qemu_saveimage.c | 120 ++++++++++++------ src/qemu/qemu_saveimage.h | 4 + src/qemu/qemu_snapshot.c | 15 ++- tools/virsh-domain.c | 81 ++++++++++-- 19 files changed, 775 insertions(+), 190 deletions(-) -- 2.43.0

3 45

Entering freeze for libvirt-11.2.0
by Jiri Denemark 25 Mar '25

25 Mar '25

I have just tagged v11.2.0-rc1 in the repository and pushed signed tarballs to https://download.libvirt.org/ Please give the release candidate some testing and in case you find a serious issue which should have a fix in the upcoming release, feel free to reply to this thread to make sure the issue is more visible. If you have not done so yet, please update NEWS.rst to document any significant change you made since the last release. Thanks, Jirka

1 0

[PATCH] NEWS: Mention virsh hypervisor-cpu-models command
by Boris Fiuczynski 25 Mar '25

25 Mar '25

Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- NEWS.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1fc80e2496..18d45656b8 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -67,6 +67,14 @@ v11.2.0 (unreleased) restore. Using multiple channels can reduce the time required to save and restore domains. + * virsh: Introduce new hypervisor-cpu-models command + + Added a new virsh command ``hypervisor-cpu-models``. The command pulls from + the existing domcapabilities XML and uses xpath to parse CPU model strings. + By default, only models reported as usable by the hypervisor on the host + system are printed. A user may specify ``--all`` to also print models which + are not supported on the host. + * **Improvements** * qemu: Improved guest agent corner case error reporting -- 2.47.0

2 1

[PATCH v3 0/3] Reflect MAC change in live domain XML
by Michal Privoznik 25 Mar '25

25 Mar '25

v3 of: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/MW4… or: https://marc.info/?l=libvir-list&m=174230601829060&w=2 since our list archive is giving me some HTTP error currently. diff to v2: - Rebased (there were some public APIs merged meanwhile, creating a conflict in RPC files), - switched from 'guestAddress' to 'currentAddress'. Michal Prívozník (3): qemu: Reflect MAC address change in live domain XML Introduce NIC_MAC_CHANGE event qemu: Emit NIC_MAC_CHANGE event docs/formatdomain.rst | 5 ++ examples/c/misc/event-test.c | 14 +++++ include/libvirt/libvirt-domain.h | 28 +++++++++ src/conf/domain_conf.c | 6 ++ src/conf/domain_conf.h | 3 + src/conf/domain_event.c | 93 +++++++++++++++++++++++++++++ src/conf/domain_event.h | 12 ++++ src/conf/schemas/domaincommon.rng | 5 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_domain.c | 48 ++++++++++++++- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 11 ++-- src/qemu/qemu_process.c | 2 +- src/remote/remote_daemon_dispatch.c | 32 ++++++++++ src/remote/remote_driver.c | 34 +++++++++++ src/remote/remote_protocol.x | 16 ++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain-event.c | 20 +++++++ 18 files changed, 334 insertions(+), 8 deletions(-) -- 2.48.1

2 4

[PATCH] docs: add table showing guest IP/DNS/gateway settings when using SLIRP
by Laine Stump 25 Mar '25

25 Mar '25

When using the default SLIRP backend for <interface type='user'>, the <ip address='blah' prefix='blur'/> setting doesn't behave as might be expected (i.e. it doesn't set the guest interface IP/prefix to exactly the provided values). This *should* have created questions when users originally encountered it, but instead it has become more apparent as people are contemplating switching from using the SLIRP backend to using passt instead (with passt, the <ip> settings do behave "as expected"). In order to make this difference in behavior less mysterious, Yalan Zhang kindly took the time to test and document the effect of various representative <ip> settings on guest interface config when SLIRP is used (see https://issues.redhat.com/browse/RHEL-46601) this patch adds that same table to libvirt's documentation. Signed-off-by: Laine Stump <laine(a)redhat.com> --- docs/formatdomain.rst | 69 ++++++++++++++++++++++++++++++++++++------- 1 file changed, 58 insertions(+), 11 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index aae58fab60..a6d0660135 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -5239,15 +5239,7 @@ network address by including an ``ip`` element specifying an IPv4 address in its one mandatory attribute, ``address``. Optionally, a second ``ip`` element with a ``family`` attribute set to "ipv6" can be specified to add an IPv6 address to the interface. ``address``. -Optionally, an address ``prefix`` can be specified. These settings are -surprisingly **not** used by SLIRP to set the exact IP address; -instead they are used to determine what network/subnet the guest's IP -address should be on, and the guest will be given an address in that -subnet, but the host portion of the address will still be "2.15". In -the example below, for example, the guest will be given the IP address -172.17.2.15 (**note that the '1.1' in the host portion of the address -has been ignored**), default route of 172.17.2.2, and DNS server -172.17.2.3. +Optionally, an address ``prefix`` can be specified. :: @@ -5263,6 +5255,59 @@ has been ignored**), default route of 172.17.2.2, and DNS server </devices> ... +These settings are surprisingly **not** used by SLIRP to set the exact +IP address; instead they are used to determine what **network/subnet** +the guest's IP address should be on, and the guest will be given an +address in that subnet, but the host portion of the address will still +be the host portion of "10.0.2.15" (based on the configured prefix (or +a prefix of 24 if no prefix is specified). The DNS and default gateway +addresses given to the guest will be similarly based on the network +portion of the configuration-provided <ip> combined with the host +portion of SLIRPs default settings for DNS/gateway +(10.0.2.3/10.0.2.2). To help resolve the confusion of the previous +sentences, the table below shows examples of the settings that will be +provided to the guest (via a DHCP response) to use for its interface +config (ip/prefix, DNS, default gateway) for various settings of <ip> +element address and prefix in libvirt's <interface type='user'> +config: + +.. list-table:: + :header-rows: 1 + + * - libvirt <ip> element + - guest ip/prefix + - guest DNS + - guest default gateway + + * - (unspecified) + - 10.0.2.15/24 + - 10.0.2.3 + - 10.0.2.2 + + * - address='172.17.1.1' + prefix='16' + - 172.17.2.15/16 + - 172.17.2.3 + - 172.17.2.2 + + * - address='172.17.1.1' + prefix='24' + - 172.17.1.15/24 + - 172.17.1.3 + - 172.17.1.2 + + * - address='172.17.1.1' + prefix='8' + - 172.0.2.15/16 + - 172.0.2.3 + - 172.0.2.2 + + * - address='172.17.1.1' + prefix='23' + - 172.17.0.15/23 + - 172.17.0.3 + - 172.17.0.2 + Userspace connection using passt ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ @@ -5304,8 +5349,10 @@ any conflict). Also different from SLIRP's behavior: if you do specify IP address(es), the exact address and netmask/prefix you specify will be provided to the guest (i.e. passt doesn't interpret the <ip> settings -as a network address like SLIRP does, but as a host address). In -example given above, the guest IP would be set to exactly 172.17.1.1. +as a network address like SLIRP does, but as a host address). In the +table of examples given above, the guest IP would be set to exactly +172.17.1.1 in all cases (the DNS and default gateway will be set +the same as they are on the host). Just as with SLIRP, though, once traffic from the guest leaves the host towards the rest of the network, it will always appear as if it -- 2.48.1

2 1

[PATCH] NEWS: qemu: Support for Block Disk Along with Throttle Filters
by Harikumar Rajkumar 25 Mar '25

25 Mar '25

NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: Support block disk along with throttle filters NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.48.1

2 2

[libvirt PATCH] qemu_driver: Fix virDomainSaveImageDefineXML
by Pavel Hrdina 24 Mar '25

24 Mar '25

From: Pavel Hrdina <phrdina(a)redhat.com> Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore sparse images but changed the boolean that controls if we open the file as read-only or read-write. Editing XML in the save image resulted in following error message: failed to write header to domain save file '/data/images/fedora40.save': Bad file descriptor Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3cf21380ed..056a9e579d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5945,7 +5945,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path, if (qemuSaveImageGetMetadata(driver, NULL, path, &def, &data) < 0) goto cleanup; - fd = qemuSaveImageOpen(driver, path, false, false, NULL, false); + fd = qemuSaveImageOpen(driver, path, false, false, NULL, true); if (fd < 0) goto cleanup; -- 2.49.0

2 1

[libvirt PATCH 0/6] cleanup and fixes of the mapped-ram feature
by Pavel Hrdina 24 Mar '25

24 Mar '25

Pavel Hrdina (6): tools: remove --parallel from virsh restore command tools: remote --parallel from virsh save command qemu: remove VIR_DOMAIN_SAVE_PARALLEL flag tools: use virDomainRestoreParams only when necessary tools: use virDomainSaveParams only when necessary virsh: add --image-format option to the save command docs/manpages/virsh.rst | 24 +++++---- include/libvirt/libvirt-domain.h | 1 - src/qemu/qemu_driver.c | 6 +-- src/qemu/qemu_migration_params.c | 34 ++++++------ tools/virsh-domain.c | 93 ++++++++++++++++---------------- 5 files changed, 80 insertions(+), 78 deletions(-) -- 2.48.1

4 11

[PATCH] NEWS: hotplug virtio-mem device
by Boris Fiuczynski 21 Mar '25

21 Mar '25

Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- NEWS.rst | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 484333e55a..1de0231c57 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -56,6 +56,12 @@ v11.2.0 (unreleased) * **Bug fixes** + * qemu: attach virtio-mem with CCW address + + Attaching a virtio-mem device on s390 without an address type now gets a + default type CCW address assigned. A specified CCW address is now used for + the virtio-mem device instead of getting overwritten by a PCI address. + v11.1.0 (2025-03-03) ==================== -- 2.47.0

3 2