- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] build: -Wframe-larger-than shenanigans
by Ján Tomko 17 Dec '19

17 Dec '19

The recent cputest addition broke the build with clang for me, since clang calculates the stack size differently than gcc. Put the strict limit into all warning by default (this starts enforcing it for examples, for example) and raise the limit by a few orders, which might appear Sisyphean but I believe it's needed for putting two conflicting limits on the compiler command line. Ján Tomko (2): build: warn on a large frame by default build: relax the relaxed stack frame limit further m4/virt-compile-warnings.m4 | 4 ++-- src/Makefile.am | 2 -- tools/Makefile.am | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) -- 2.19.2

2 4

[libvirt] [PATCH] virtio-blk: deprecate SCSI passthrough
by Stefan Hajnoczi 17 Dec '19

17 Dec '19

The Linux virtio_blk.ko guest driver is removing legacy SCSI passthrough support. Deprecate this feature in QEMU too. Signed-off-by: Stefan Hajnoczi <stefanha(a)redhat.com> --- qemu-deprecated.texi | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 4b4b7425ac..ef94d497da 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -285,6 +285,17 @@ spec you can use the ``-cpu rv64gcsu,priv_spec=v1.9.1`` command line argument. @section Device options +@subsection Emulated device options + +@subsubsection -device virtio-blk,scsi=on|off (since 5.0.0) + +The virtio-blk SCSI passthrough feature is a legacy VIRTIO feature. VIRTIO 1.0 +and later do not support it because the virtio-scsi device was introduced for +full SCSI support. Use virtio-scsi instead when SCSI passthrough is required. + +Note this also applies to ``-device virtio-blk-pci,scsi=on|off'', which is an +alias. + @subsection Block device options @subsubsection "backing": "" (since 2.12.0) -- 2.23.0

6 7

[libvirt] [PATCH 0/5] Introduce the support of Intel RDT-MBM
by Wang Huaqiang 17 Dec '19

17 Dec '19

RDT is the short for Intel Resource Director Technology, consists of four sub-technologies until now: -. CAT for cache allocation -. CMT for cache usage monitoring -. MBA for memory bandwidth allocation -. MBM for memory bandwidth usage monitoring The Linux kernel interface is 'resctrl' file system, and we have already implemented the support of CAT, CMT and MBA, to accomplish the tasks such as allocating a part of shared CPU last level cache to particular domain vcpu or a list of vcpus and monitoring the usage of cache, or the task of allocating a mount of memory bandwidth to specify domain vcpu(s). This series is to introduce the support of MBM. Basically the interfaces are: ** Identify host capability ** Similar to identify the host capability of CMT, it could be gotten through the result of 'virsh capabilities', if following elements are found, then MBM is supported: <memory_bandwidth> <monitor maxMonitors='176'> <feature name='mbm_total_bytes'/> <feature name='mbm_local_bytes'/> </monitor> </memory_bandwidth> 'mbm_total_bytes' means supporting to report the memory bandwidth used by the vcpu(s) of specific monitor on all CPU sockets. 'mbm_local_bytes' means supporting to report the memory bandwidth used by vcpu(s) that is passing through local CPU socket. ** Create monitor group** The monitor group for specific domain vcpus, for example vcpu 0-4, is defined in domain configuration file, in such kind of way: <cputune> <memorytune vcpus='0-4'> <monitor vcpus='0-4'/> </memorytune> </cputune> ** Report memory usage ** Introduced an option '--memory' against 'virsh domstats' command to show the memory bandwidth usage in such way: (also very similar to the format of CMT result.) # virsh domstats --memory Domain: 'libvirt-vm' memory.bandwidth.monitor.count=4 memory.bandwidth.monitor.0.name=vcpus_0-4 memory.bandwidth.monitor.0.vcpus=0-4 memory.bandwidth.monitor.0.node.count=2 memory.bandwidth.monitor.0.node.0.id=0 memory.bandwidth.monitor.0.node.0.bytes.total=14201651200 memory.bandwidth.monitor.0.node.0.bytes.local=7369809920 memory.bandwidth.monitor.0.node.1.id=1 memory.bandwidth.monitor.0.node.1.bytes.total=188897640448 memory.bandwidth.monitor.0.node.1.bytes.local=170044047360 Huaqiang (5): util, resctrl: using 64bit interface instead of 32bit for counters conf: showing cache/memoryBW monitor features in capabilities cachetune schema: a looser check for the order of <cache> and <monitor> element conf: Parse dommon configure file for memorytune monitors virsh: show memoryBW info in 'virsh domstats' command docs/schemas/domaincommon.rng | 91 +++++++++--------- include/libvirt/libvirt-domain.h | 1 + src/conf/capabilities.c | 4 +- src/conf/domain_conf.c | 44 +++++++-- src/libvirt-domain.c | 21 +++++ src/qemu/qemu_driver.c | 103 ++++++++++++++++++++- src/util/virfile.c | 40 ++++++++ src/util/virfile.h | 2 + src/util/virresctrl.c | 6 +- src/util/virresctrl.h | 2 +- tests/genericxml2xmlindata/cachetune.xml | 1 + tests/genericxml2xmlindata/memorytune.xml | 5 + tests/genericxml2xmloutdata/cachetune.xml | 34 +++++++ tests/genericxml2xmloutdata/memorytune.xml | 42 +++++++++ tests/genericxml2xmltest.c | 4 +- tools/virsh-domain-monitor.c | 7 ++ tools/virsh.pod | 23 ++++- 17 files changed, 367 insertions(+), 63 deletions(-) create mode 100644 tests/genericxml2xmloutdata/cachetune.xml create mode 100644 tests/genericxml2xmloutdata/memorytune.xml -- 2.23.0

4 17

[libvirt] [PATCH v1 00/26] move qemucaps validations from qemu_command to qemu_domain
by Daniel Henrique Barboza 17 Dec '19

17 Dec '19

(series based on master commit 97cafa610ecf5) This work was proposed by Cole in [1]. This is Cole's reasoning for it, copy/pasted from [1]: ------- The benefits of moving to validate time is that XML is rejected by 'virsh define' rather than at 'virsh start' time. It also makes it easier to follow the cli building code, and makes it easier to verify qemu_command.c test suite code coverage for the important stuff like covering every CLI option. It's also a good intermediate step for sharing validation with domain capabilities building, like is done presently for rng models. ------- Cole also mentioned that the machine features validation was a good place to start. I took it a step further and did it across the board on all qemu_command.c. This series didn't create any new validation, just moved them to domain define time. Any other outcome is unintended. Not all cases where covered in this work. For a first version I decided to do only the most trivial cases. These are the other cases I left out for another day: - all verifications contained in functions that are also called by qemu_hotplug.c. This means that the hotplug process will also use the validation code, and we can't just move it to qemu_domain.c. Besides, not all validation done in domain define time applies to hotplug, so it's not simply a matter of calling the same function from qemu_domain in qemu_hotplug. I have patches that moved the verification of all virtio options to qemu_domain.c, while also considering qemu_hotplug validation. In the end I decided to leave it away from this work for now because (1) it took 8 patches just for virtio case alone and (2) there are a lot of these cases in qemu_command.c and it would be too much to do it all at in this same series. - moving CPU Model validation is trickier than the rest because there are code in DefPostParse() that makes CPU Model changes that are then validated in qemu_command.c. Moving the validation to define time doesn't cut in this case - the validation is considering PostParse changes in the CPU Model and some of the will fail if done by qemuDomainDefValidate time. I didn't think too much about how to handle this case, but given that the approach would be different from the other cases handled here, I left it out too. - SHMem: part of SHMem validation is being used by hotplug code. I could've moved the non-hotplug validation to define time, instead I decided it's better to to leave it to do it all at once in the future. - DBus-VMState: validation of this fella must be done by first querying if the hash vm->priv->dbusVMState has elements. qemuDomainDefValidate does not have 'vm->priv' in it's API, meaning that I would need to either change the API to include it (which means changing domainValidateCallback), or do the validation by another branch where I can get access to vm->priv. - vmcoreinfo: there are no challenges in moving vmcoreinfo validation to qemuDomainDefValidate. The problem were the unit tests. Moving this validation to domain define time breaks 925 tests on qemuxml2xmltest.c, including tests labelled as 'minimal' which should pass under any circurstances, as far as I understand. It is possible to just shoehorn QEMU_CAPS_DEVICE_VMCOREINFO in the qemuCaps of all tests, but this would tamper the idea of having to deal with NONE or LATEST or a specific set of capabilities for certain tests. Another case I would rather discuss separately. [1] https://www.redhat.com/archives/libvir-list/2019-October/msg00568.html Daniel Henrique Barboza (26): qemu_command.c: move PSeries features validation to qemu_domain.c qemu_command.c: move mem.nosharepages validation to qemu_domain.c qemu_command.c: move validation of vmport to qemu_domain.c qemu_command.c: move nvdimm validation to qemu_domain.c qemu_command.c: move I/O APIC validation to qemu_domain.c numa_conf: add virDomainNumaNodesDistancesAreBeingSet() helper qemu_command.c move NUMA validation to qemu_domain.c qemu_command.c: move NVRAM validation to qemu_domain.c qemu_command: move qemuBuildSoundDevStr caps validation to qemu_domain qemu_command.c: move sound codec validation to qemu_domain.c qemu_command: move qemuBuildHubDevStr caps validation to qemu_domain qemu_command: move qemuBuildChrChardevStr caps validation to qemu_domain qemu: move qemuBuildHostdevCommandLine caps validation to qemu_domain qemu_command.c: move vmGenID validation to qemu_domain.c qemu: move qemuBuildSgaCommandLine validation to qemu_domain.c qemu: move virDomainClockDef validation to qemu_domain.c qemu: move qemuBuildPMCommandLine validation to qemu_domain.c qemu: move qemuBuildBootCommandLine validation to qemu_domain.c qemu_command.c: move pcihole64 validation to qemu_domain.c qemu: move qemuBuildGraphicsSDLCommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsVNCCommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsSPICECommandLine validation to qemu_domain.c qemu: move qemuBuildGraphicsEGLHeadlessCommandLine validation to qemu_domain.c qemu: move qemuBuildSmartcardCommandLine validation to qemu_domain.c qemu: move qemuBuildConsoleCommandLine validation to qemu_domain.c qemu: move qemuBuildTPMDevStr TPM validation to qemu_domain.c src/conf/numa_conf.c | 19 + src/conf/numa_conf.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 575 +--------- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 983 ++++++++++++++++-- tests/qemuhotplugtest.c | 10 + tests/qemumemlocktest.c | 16 +- .../default-video-type-aarch64.xml | 2 +- .../default-video-type-ppc64.xml | 2 +- .../default-video-type-s390x.xml | 2 +- .../graphics-egl-headless.args | 2 +- .../graphics-spice-egl-headless.args | 2 +- .../graphics-vnc-egl-headless.args | 2 +- tests/qemuxml2argvtest.c | 80 +- ...ault-video-type-aarch64.aarch64-latest.xml | 4 +- .../default-video-type-ppc64.ppc64-latest.xml | 4 +- .../default-video-type-s390x.s390x-latest.xml | 4 +- tests/qemuxml2xmltest.c | 244 +++-- 19 files changed, 1246 insertions(+), 709 deletions(-) -- 2.23.0

4 42

[libvirt] [PATCH v6 0/4] scripts: convert most perl scripts to python
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

This series is an effort to reduce the number of different languages we use by eliminating most use of perl in favour of python. This aligns with fact that the likely future build system we'll use (meson) is written in python, and that python is much more commonly used/understood by developers these days than perl. With this applied we use perl in a handful of places only: - src/rpc/gendispatch.pl - this is a horrendously large script and very hard to understand/follow. A straight syntax conversion to Python would still leave a hgue and hard to understand/follow script. It really needs a clean room rewrite from scratch, with better structure. - src/rpc/genprotocol.pl - fairly easy to convert, but might be obsolete depending on approach for rewriting gendispatch.pl, so ignored for now - tests/oomtrace.pl - will be purge by the patches that drop OOM handling anyway - tools/wireshark/util/genxdrstub.pl - a very large script, which I haven't got the courage to tackle yet. - cfg.mk/maint.mk - many syntax rules involve regexes which are fed to perl. Decision on what to do with syntax-check rules punted to another time. - build-aux/gitlog-to-changelog - build-aux/useless-if-before-free - Both pulled in from gnulib. Could be rewritten quite easily if desired, but given that we aren't maintainers of them right now, they're ignored as they don't really impact our developers. Note that the check-spacing.py script is significantly slower in Python than in Perl. After researching this it appears there is nothing that can be done. The Perl regex engine is simply much better optimized than the Python one. As previously discussed we need to loook at uncrustify or clang-format or some other tool to validate whitespace formatting. This is ongoing. We can either accept the slow down in the short term or keep the Perl version in the short term. In v6: - Fix various bugs in check-file-access.py so it now reports same output as original perl script. - Merged the already-ACKd scripts In v5: - Rebased to cope with changes to require VPATH build - Merged the already-ACKd scripts In v4: - Moved all scripts into the scripts/ directory instead of having them scattered around source tree - Use re.search instead of re.match - Don't bother re-compiling regexes In v3: - All scripts comply with all flake8 style rules with exception of E129 visually indented line with same indent as next logical line In v2: - Pulled in patch to hacking file - Converted many more scripts - Forced UTF-8 character set to avoid ascii codec on py3 < 3.7 Daniel P. Berrangé (4): tests: rewrite qemu capability grouper in Python tests: rewrite file access checker in Python docs: rewrite hvsupport.html page generator in python docs: rewrite polkit docs generator in Python Makefile.am | 4 + build-aux/syntax-check.mk | 3 +- docs/Makefile.am | 12 +- docs/genaclperms.pl | 125 -------- docs/hvsupport.pl | 459 ----------------------------- scripts/check-file-access.py | 125 ++++++++ scripts/genaclperms.py | 121 ++++++++ scripts/group-qemu-caps.py | 121 ++++++++ scripts/hvsupport.py | 502 ++++++++++++++++++++++++++++++++ tests/Makefile.am | 3 +- tests/check-file-access.pl | 130 --------- tests/file_access_whitelist.txt | 2 +- tests/group-qemu-caps.pl | 124 -------- 13 files changed, 882 insertions(+), 849 deletions(-) delete mode 100755 docs/genaclperms.pl delete mode 100755 docs/hvsupport.pl create mode 100755 scripts/check-file-access.py create mode 100755 scripts/genaclperms.py create mode 100755 scripts/group-qemu-caps.py create mode 100755 scripts/hvsupport.py delete mode 100755 tests/check-file-access.pl delete mode 100755 tests/group-qemu-caps.pl -- 2.21.0

2 5

[libvirt] [tck PATCH] Update x86_64 image & virt-builder image to F31
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

i386 was dropped even as a secondary arch in F31 so must remain on F30 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- conf/default.cfg | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/conf/default.cfg b/conf/default.cfg index 39d9b04..3493ad7 100644 --- a/conf/default.cfg +++ b/conf/default.cfg @@ -49,7 +49,7 @@ images = ( hvm xen ) - osname = fedora-30 + osname = fedora-31 } ) @@ -76,6 +76,7 @@ images = ( # kernels = ( # Fedora 30 i686 PAE has pv_ops, so one kernel can do both Xen and KVM guests here + # No i386 releases since F30 { arch = i686 ostype = ( @@ -85,15 +86,15 @@ kernels = ( kernel = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i38… initrd = http://dl.fedoraproject.org/pub/fedora-secondary/releases/30/Everything/i38… } - # Fedora 30 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here + # Fedora 31 x86_64 has pv_ops, so one kernel can do both Xen and KVM guests here { arch = x86_64 ostype = ( hvm xen ) - kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/… - initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/30/Everything/x86_64/… + kernel = http://dl.fedoraproject.org/pub/fedora/linux/releases/31/Everything/x86_64/… + initrd = http://dl.fedoraproject.org/pub/fedora/linux/releases/31/Everything/x86_64/… } # LXC containers need a virtual container filesystem somewhere # { -- 2.23.0

2 1

[libvirt] ongoing code transitions section on the wiki
by Cole Robinson 16 Dec '19

16 Dec '19

Hi all, I added a 'Ongoing code transitions' section to the BiteSizedTasks page on the wiki: https://wiki.libvirt.org/page/BiteSizedTasks#Ongoing_code_transitions BiteSizedTasks might not be the best location for it, but I wanted to start a list and that page already exists. I added 3 sections: * g_autofree/g_autoptr, with some example conversion commits * GLib in general, listing APIs that can replace custom libvirt code. Currently the list is only g_key_file for virkeyfile, g_user_*_dir for virGetUser*Dir, some virFile APIs for g_path_* APIs. * gnulib removal. I filled in a few examples of possible gnulib module replacements, and listed all the others as 'Unsorted/replacments unclear'. If you know any GLib replacements for existing code or gnulib modules, please fill them in there. Or any other incomplete code conversions internally Thanks, Cole

1 0

[libvirt] [rust PATCH] Domain: Implement scheduler information related APIs
by Vineeth Remanan Pillai 16 Dec '19

16 Dec '19

Implement the following: - virDomainGetSchedulerType - virDomainSetSchedulerParameters - virDomainSetSchedulerParametersFlags - virDomainGetSchedulerParameters - virDomainGetSchedulerParametersFlags Signed-off-by: Vineeth Remanan Pillai <vpilllai(a)digitalocean.com> --- examples/hello.rs | 38 +++++++ src/domain.rs | 260 +++++++++++++++++++++++++++++++++++++++++++--- 2 files changed, 283 insertions(+), 15 deletions(-) diff --git a/examples/hello.rs b/examples/hello.rs index e5ec6e4..1f336a9 100644 --- a/examples/hello.rs +++ b/examples/hello.rs @@ -89,6 +89,44 @@ fn show_domains(conn: &Connect) -> Result<(), Error> { numa.node_set.unwrap_or(String::from(""))); println!(" Mode: {}", numa.mode.unwrap_or(0)); } + + if let Ok((sched_type, nparams)) = dom.get_scheduler_type() { + println!("SchedType: {}, nparams: {}", + sched_type, nparams); + } + + if let Ok(sched_info) = dom.get_scheduler_parameters() { + println!("Schedule Information:"); + println!("\tScheduler\t: {}", sched_info.scheduler_type); + if let Some(shares) = sched_info.cpu_shares { + println!("\tcpu_shares\t: {}", shares); + } + if let Some(period) = sched_info.vcpu_bw.period { + println!("\tvcpu_period\t: {}", period); + } + if let Some(quota) = sched_info.vcpu_bw.quota { + println!("\tvcpu_quota\t: {}", quota); + } + if let Some(period) = sched_info.emulator_bw.period { + println!("\temulator_period\t: {}", period); + } + if let Some(quota) = sched_info.emulator_bw.quota { + println!("\temulator_quota\t: {}", quota); + } + if let Some(period) = sched_info.global_bw.period { + println!("\tglobal_period\t: {}", period); + } + if let Some(quota) = sched_info.global_bw.quota { + println!("\tglobal_quota\t: {}", quota); + } + if let Some(period) = sched_info.global_bw.period { + println!("\tiothread_period\t: {}", period); + } + if let Some(quota) = sched_info.global_bw.quota { + println!("\tiothread_quota\t: {}", quota); + } + } + } } return Ok(()); diff --git a/src/domain.rs b/src/domain.rs index acb9e6e..40a18d8 100644 --- a/src/domain.rs +++ b/src/domain.rs @@ -363,6 +363,29 @@ extern "C" { snaps: *mut *mut virDomainSnapshotPtr, flags: libc::c_uint) -> libc::c_int; + + fn virDomainGetSchedulerType(ptr: sys::virDomainPtr, + nparams: *mut libc::c_int) + -> *mut libc::c_char; + fn virDomainGetSchedulerParameters(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: *mut libc::c_int) + -> libc::c_int; + fn virDomainSetSchedulerParameters(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: libc::c_int) + -> libc::c_int; + fn virDomainGetSchedulerParametersFlags(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: *mut libc::c_int, + flags: libc::c_uint) + -> libc::c_int; + fn virDomainSetSchedulerParametersFlags(ptr: sys::virDomainPtr, + params: virTypedParameterPtr, + nparams: libc::c_int, + flags: libc::c_uint) + -> libc::c_int; + } pub type DomainXMLFlags = self::libc::c_uint; @@ -607,6 +630,124 @@ impl MemoryStats { } } +/// Structure representing the CFS scheduler cpu bandwidth parameters +/// see https://www.kernel.org/doc/html/latest/scheduler/sched-bwc.html +#[derive(Clone, Debug, Default)] +pub struct SchedBandwidth { + pub period: Option<u64>, + pub quota: Option<i64>, +} + +#[derive(Clone, Debug, Default)] +pub struct SchedulerInfo { + pub scheduler_type: String, + // cpu shares for the domain. + pub cpu_shares: Option<u64>, + // Bandwidth allocated for the vcpu threads. + pub vcpu_bw: SchedBandwidth, + // Bandwidth allocated for the emulator threads. + pub emulator_bw: SchedBandwidth, + // Bandwidth allocated for the Domain. + pub global_bw: SchedBandwidth, + // Bandwidth allocated for the io threads.. + pub iothread_bw: SchedBandwidth, +} + +impl SchedulerInfo { + pub fn from_vec(vec: Vec<virTypedParameter>, scheduler_type: String) -> SchedulerInfo { + unsafe { + let mut ret = SchedulerInfo::default(); + ret.scheduler_type = scheduler_type; + for param in vec { + match str::from_utf8(CStr::from_ptr(param.field.as_ptr()).to_bytes()).unwrap() { + "cpu_shares" => ret.cpu_shares = Some(param.value as u64), + "vcpu_period" => ret.vcpu_bw.period = Some(param.value as u64), + "vcpu_quota" => ret.vcpu_bw.quota = Some(param.value as i64), + "emulator_period" => ret.emulator_bw.period = Some(param.value as u64), + "emulator_quota" => ret.emulator_bw.quota = Some(param.value as i64), + "global_period" => ret.global_bw.period = Some(param.value as u64), + "global_quota" => ret.global_bw.quota = Some(param.value as i64), + "iothread_period" => ret.iothread_bw.period = Some(param.value as u64), + "iothread_quota" => ret.iothread_bw.quota = Some(param.value as i64), + unknow => panic!("Field not implemented for SchedulerInfo, {:?}", unknow), + } + } + ret + } + } + + pub fn to_vec(&self) -> Vec<virTypedParameter> { + let mut cparams: Vec<virTypedParameter> = Vec::new(); + + if let Some(shares) = self.cpu_shares { + cparams.push(virTypedParameter { + field: to_arr("cpu_shares\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: shares + }); + } + + if let Some(period) = self.vcpu_bw.period { + cparams.push(virTypedParameter { + field: to_arr("vcpu_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.vcpu_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("vcpu_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.emulator_bw.period { + cparams.push(virTypedParameter { + field: to_arr("emulator_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.emulator_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("emulator_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.global_bw.period { + cparams.push(virTypedParameter { + field: to_arr("global_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.global_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("global_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + if let Some(period) = self.iothread_bw.period { + cparams.push(virTypedParameter { + field: to_arr("iothread_period\0"), + typed: ::typedparam::VIR_TYPED_PARAM_ULLONG, + value: period, + }); + } + if let Some(quota) = self.iothread_bw.quota { + cparams.push(virTypedParameter { + field: to_arr("iothread_quota\0"), + typed: ::typedparam::VIR_TYPED_PARAM_LLONG, + value: quota as u64, + }); + } + + cparams + } +} + /// Provides APIs for the management of domains. /// /// See http://libvirt.org/html/libvirt-libvirt-domain.html @@ -627,6 +768,14 @@ impl Drop for Domain { } } +fn to_arr(name: &str) -> [libc::c_char; 80] { + let mut field: [libc::c_char; 80] = [0; 80]; + for (a, c) in field.iter_mut().zip(name.as_bytes()) { + *a = *c as i8 + } + field +} + impl Domain { pub fn new(ptr: sys::virDomainPtr) -> Domain { return Domain { ptr: Some(ptr) }; @@ -1656,14 +1805,6 @@ impl Domain { flags: u32) -> Result<u32, Error> { unsafe { - fn to_arr(name: &str) -> [libc::c_char; 80] { - let mut field: [libc::c_char; 80] = [0; 80]; - for (a, c) in field.iter_mut().zip(name.as_bytes()) { - *a = *c as i8 - } - field - } - let mut cparams: Vec<virTypedParameter> = Vec::new(); if params.hard_limit.is_some() { cparams.push(virTypedParameter { @@ -1809,13 +1950,6 @@ impl Domain { pub fn set_numa_parameters(&self, params: NUMAParameters, flags: u32) -> Result<u32, Error> { unsafe { - fn to_arr(name: &str) -> [libc::c_char; 80] { - let mut field: [libc::c_char; 80] = [0; 80]; - for (a, c) in field.iter_mut().zip(name.as_bytes()) { - *a = *c as i8 - } - field - } let mut cparams: Vec<virTypedParameter> = Vec::new(); if params.node_set.is_some() { @@ -1863,4 +1997,100 @@ impl Domain { return Ok(array); } } + + /// Get the cpu scheduler type for the domain + pub fn get_scheduler_type(&self) -> Result<(String, i32), Error> + { + unsafe { + let mut nparams: libc::c_int = -1; + let sched_type = virDomainGetSchedulerType(self.as_ptr(), + &mut nparams); + if sched_type.is_null() { + return Err(Error::new()); + } + + return Ok((c_chars_to_string!(sched_type), nparams)); + } + } + + /// Get the scheduler parameters for the domain. + pub fn get_scheduler_parameters(&self) -> Result<SchedulerInfo, Error> { + + let (sched_type, mut nparams) = self.get_scheduler_type()?; + unsafe { + let mut params: Vec<virTypedParameter> = vec![ + virTypedParameter::default(); 9]; + let ret = virDomainGetSchedulerParameters(self.as_ptr(), + &mut params[0], + &mut nparams); + if ret == -1 { + return Err(Error::new()); + } + Ok(SchedulerInfo::from_vec(params, sched_type)) + } + + } + + /// Get the scheduler parameters for the domain for the configuration + /// as specified by the flags. + /// # Arguments + /// + /// * `flags` - Specifies the Domain Impact: CONFIG, LIVE or CURRENT. + pub fn get_scheduler_parameters_flags(&self, + flags: DomainModImpactFlags) + -> Result<SchedulerInfo, Error> { + + let (sched_type, mut nparams) = self.get_scheduler_type()?; + unsafe { + let mut params: Vec<virTypedParameter> = vec![ + virTypedParameter::default(); 9]; + let ret = virDomainGetSchedulerParametersFlags(self.as_ptr(), + &mut params[0], + &mut nparams, + flags as libc::c_uint); + if ret == -1 { + return Err(Error::new()); + } + Ok(SchedulerInfo::from_vec(params, sched_type)) + } + + } + + /// Set the scheduler parameters for the domain. + pub fn set_scheduler_parameters(&self, + sched_info: &SchedulerInfo) + -> Result<i32, Error> { + unsafe { + let mut params = sched_info.to_vec(); + let ret = virDomainSetSchedulerParameters(self.as_ptr(), + &mut params[0], + params.len() as libc::c_int); + if ret == -1 { + return Err(Error::new()); + } + Ok(ret) + } + } + + /// Set the scheduler parameters for the domain for the configuration + /// as specified by the flags. + /// # Arguments + /// + /// * `flags` - Specifies the Domain Impact: CONFIG, LIVE or CURRENT. + pub fn set_scheduler_parameters_flags(&self, + sched_info: &SchedulerInfo, + flags: DomainModImpactFlags) + -> Result<i32, Error> { + unsafe { + let mut params = sched_info.to_vec(); + let ret = virDomainSetSchedulerParametersFlags(self.as_ptr(), + &mut params[0], + params.len() as libc::c_int, + flags as libc::c_uint); + if ret == -1 { + return Err(Error::new()); + } + Ok(ret) + } + } } -- 2.17.1

2 2

[libvirt] [PATCH] src: warn against virNodeGetInfo() API call due to inaccurate info
by Daniel P. Berrangé 16 Dec '19

16 Dec '19

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- include/libvirt/libvirt-host.h | 4 ++++ src/libvirt-host.c | 16 ++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/include/libvirt/libvirt-host.h b/include/libvirt/libvirt-host.h index be65b4686b..b87d634813 100644 --- a/include/libvirt/libvirt-host.h +++ b/include/libvirt/libvirt-host.h @@ -147,6 +147,10 @@ typedef virSecurityModel *virSecurityModelPtr; * * a virNodeInfo is a structure filled by virNodeGetInfo() and providing * the information for the Node. + * + * Note that the information in this struct is not guaranteed to be an + * accurate relection of the system hardware. See the virNodeGetInfo() + * API documentation for further guidance. */ typedef struct _virNodeInfo virNodeInfo; diff --git a/src/libvirt-host.c b/src/libvirt-host.c index 94ba5a8e80..bc3d1d2803 100644 --- a/src/libvirt-host.c +++ b/src/libvirt-host.c @@ -399,6 +399,22 @@ virConnectGetMaxVcpus(virConnectPtr conn, * * Extract hardware information about the node. * + * Use of this API is strongly discouraged as the information provided + * is not guaranteed to be accurate on all hardware platforms. + * + * The mHZ value merely reflects the speed that the first CPU in the + * machine is currently running at. This speed may vary across CPUs + * and changes continually as the host OS throttles. + * + * The nodes/sockets/cores/threads data is potentially inaccurate as + * it assumes a symmetric installation. If one NUMA node has more + * sockets populated that another NUMA node this information will be + * wrong. It is also not able to report about CPU dies. + * + * Applications are recommended to use the virConnectGetCapabilities() + * call instead, which provides all the information except CPU mHZ, + * in a more accurate representation. + * * Returns 0 in case of success and -1 in case of failure. */ int -- 2.23.0

2 1

[libvirt] [PATCH] tools: skip libvirt-guests fast if libvirtd is not active
by Christian Ehrhardt 16 Dec '19

16 Dec '19

The most common operation of libvirt-guests is to manage the local libvirtd. But users might have disabled that and while we are After=libvirtd for ordering we are not Requiring it.. OTOH adding that or any harder dependency might affect our ordering. But if people have disabled libvirt they will do a full retry loop until timeout. Lets check if the local service is active at all and skip fast if it is not. Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1854653 Reported-by: Doug Smythies <dsmythies(a)telus.net> Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- tools/libvirt-guests.sh.in | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 4bc6e866f0..5a9930ee2f 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -90,6 +90,14 @@ test_connect() { uri=$1 + if [ "x$uri" = xdefault ]; then + # Default config is most common and for the local libvirtd + # Check if it is active before wasting time in connect loop + if ! systemctl -q is-active libvirtd; then + return 1 + fi + fi + i=${CONNECT_RETRIES} while [ $i -gt 0 ]; do run_virsh "$uri" connect 2>/dev/null -- 2.24.0

4 8

[libvirt] [PATCH] virsh.pod: Mention iscsi-direct is supported in find-storage-pool-sources
by Han Han 13 Dec '19

13 Dec '19

Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virsh.pod | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index a8331154e1..14f4121787 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3994,7 +3994,8 @@ any other provided XML elements in I<srcSpec>. For a "logical" pool, the contents of the I<srcSpec> file are ignored, although if provided the file must at least exist. -For an "iscsi" pool, the minimal expect XML required is the <host> element +For an "iscsi" or "iscsi-direct" pool, +the minimal expect XML required is the <host> element with a "name" attribute describing the IP address or hostname to be used to find the pool (the iSCSI server address). Optionally, the "port" attribute may be provided, although it will default to 3260. Optionally, an <initiator> -- 2.24.0.rc1

2 1

[libvirt] [PATCH v3 0/6] PCI hostdev partial assignment support
by Daniel Henrique Barboza 13 Dec '19

13 Dec '19

changes from previous version [1]: - do not overload address type='none'. A new address type called 'unassigned' is introduced; - there is no unassigned' flag being created in virDomainHostdevDef. The logic added by new address type is enough; - do not allow function zero of multifunction devices to be unassigned. Nothing too special to discuss in this cover letter. More details can be found at the discussions of the previous version [1]. Commit messages of the patches have more background info as well. [1] https://www.redhat.com/archives/libvir-list/2019-November/msg01099.html Daniel Henrique Barboza (6): Introducing new address type='unassigned' for PCI hostdevs qemu: handle unassigned PCI hostdevs in command line and alias virhostdev.c: check all IOMMU devs in virHostdevPreparePCIDevices formatdomain.html.in: document <address type='unassigned'/> utils: PCI multifunction detection helpers domain_conf.c: don't allow function zero to be unassigned docs/formatdomain.html.in | 14 +++ docs/schemas/domaincommon.rng | 5 ++ src/conf/device_conf.c | 2 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 20 ++++- src/libvirt_private.syms | 2 + src/qemu/qemu_alias.c | 6 ++ src/qemu/qemu_command.c | 5 ++ src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain_address.c | 5 ++ src/util/virhostdev.c | 88 +++++++++++++++++-- src/util/virhostdev.h | 3 + src/util/virpci.c | 17 ++++ src/util/virpci.h | 2 + .../hostdev-pci-address-unassigned.args | 31 +++++++ .../hostdev-pci-address-unassigned.xml | 42 +++++++++ ...pci-multifunction-zero-unassigned-fail.xml | 42 +++++++++ tests/qemuxml2argvtest.c | 8 ++ .../hostdev-pci-address-unassigned.xml | 58 ++++++++++++ tests/qemuxml2xmltest.c | 1 + tests/virpcimock.c | 9 +- 21 files changed, 351 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.xml create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction-zero-unassigned-fail.xml create mode 100644 tests/qemuxml2xmloutdata/hostdev-pci-address-unassigned.xml -- 2.23.0

2 9

[libvirt] [libvirt-tck PATCH] Add cases for nvram
by Dan Zheng 13 Dec '19

13 Dec '19

This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- scripts/domain/401-ovmf-nvram.t | 143 ++++++++++++++++++++++++++++++++ 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401-ovmf-nvram.t diff --git a/scripts/domain/401-ovmf-nvram.t b/scripts/domain/401-ovmf-nvram.t new file mode 100644 index 0000000..5310dd0 --- /dev/null +++ b/scripts/domain/401-ovmf-nvram.t @@ -0,0 +1,143 @@ +# -*- perl -*- +# +# Copyright (C) 2009 Red Hat, Inc. +# Copyright (C) 2018 Dan Zheng (dzheng(a)redhat.com) +# +# This program is free software; You can redistribute it and/or modify +# it under the GNU General Public License as published by the Free +# Software Foundation; either version 2, or (at your option) any +# later version +# +# The file "LICENSE" distributed along with this file provides full +# details of the terms and conditions +# + +=pod + +=head1 NAME + +domain/401-ovmf-nvram.t - Test OVMF related functions and flags + +=head1 DESCRIPTION + +The test cases validates OVMF related APIs and flags + +Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM +Sys::Virt::Domain::UNDEFINE_NVRAM + +=cut + +use strict; +use warnings; + +use Test::More tests => 8; + +use Sys::Virt::TCK; +use File::stat; +use File::Copy; + + +my $tck = Sys::Virt::TCK->new(); +my $conn = eval { $tck->setup(); }; +BAIL_OUT "failed to setup test harness: $@" if $@; +END { $tck->cleanup if $tck; } + + +sub setup_nvram { + +my $loader_path = shift; +my $nvram_template = shift; +my $nvram_path = shift; + +# Install OVMF and check the two files should exist +# - /usr/share/OVMF/OVMF_CODE.secboot.fd +# - /usr/share/OVMF/OVMF_VARS.fd + +my $ret = `yum install -y OVMF`; +diag "yum install OVMF: $ret"; +my $st = stat($loader_path); +ok($st, "path $loader_path exists after OVMF is installed"); +$st = stat($nvram_template); +ok($st, "path $nvram_template exists after OVMF is installed"); + +# Ensure the sample nvram file exists +copy($nvram_template, $nvram_path) or die "Copy failed: $!"; + +# Use 'q35' as machine type and add below lines to guest xml +# <loader readonly='yes' secure='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.secboot.fd</loader> +# <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/test_VARS.fd</nvram> + +my $xml = $tck->generic_domain(name => "tck")->as_xml; +my $xp = XML::XPath->new($xml); +diag $xp->getNodeText("/domain/os/type/\@machine"); + +diag "Changing guest machine type to q35"; +$xp->setNodeText("/domain/os/type/\@machine", "q35"); + +my $loader_node = XML::XPath::Node::Element->new('loader'); +my $loader_text = XML::XPath::Node::Text->new($loader_path); +my $attr_ro = XML::XPath::Node::Attribute->new('readonly'); +my $attr_secure = XML::XPath::Node::Attribute->new('secure'); +my $attr_type = XML::XPath::Node::Attribute->new('type'); + +$attr_ro -> setNodeValue('yes'); +$attr_secure -> setNodeValue('yes'); +$attr_type -> setNodeValue('pflash'); + +$loader_node->appendChild($loader_text); +$loader_node->appendAttribute($attr_ro); +$loader_node->appendAttribute($attr_secure); +$loader_node->appendAttribute($attr_type); + +my $nvram_node = XML::XPath::Node::Element->new('nvram'); +my $nvram_text = XML::XPath::Node::Text->new($nvram_path); +my $attr_template = XML::XPath::Node::Attribute->new('template'); + +$attr_template -> setNodeValue($nvram_template); + +$nvram_node->appendChild($nvram_text); +$nvram_node->appendAttribute($attr_template); + +my $smm_node = XML::XPath::Node::Element->new('smm'); +my $attr_state = XML::XPath::Node::Attribute->new('state'); +$attr_state -> setNodeValue("on"); +$smm_node -> appendAttribute($attr_state); + +my ($root) = $xp->findnodes('/domain/os'); +$root->appendChild($loader_node); +$root->appendChild($nvram_node); +($root) = $xp->findnodes('/domain/features'); +$root->appendChild($smm_node); + +$xml = $xp->findnodes_as_string('/'); +diag $xml; +return $xml; +} + +diag "Defining an inactive domain config with nvram"; +my $loader_file_path = '/usr/share/OVMF/OVMF_CODE.secboot.fd'; +my $nvram_file_template = '/usr/share/OVMF/OVMF_VARS.fd'; +my $nvram_file_path = '/var/lib/libvirt/qemu/nvram/test_VARS.fd'; + +my $xml = setup_nvram($loader_file_path, $nvram_file_template, $nvram_file_path); +my $dom; + +diag "Test Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +diag "Checking nvram file already exists"; +my $st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' exists as expected"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM); +diag "Checking nvram file still exists"; +$st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' still exists as expected"); + +diag "Test Sys::Virt::Domain::UNDEFINE_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_NVRAM); +diag "Checking nvram file removed"; +$st = stat($nvram_file_path); +ok(!$st, "File '$nvram_file_path' is removed"); + +ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", + Sys::Virt::Error::ERR_NO_DOMAIN); -- 2.18.1

2 1

[libvirt] [PATCH 0/2] configure: Provide OpenRC scripts for sub-daemons
by Michal Privoznik 13 Dec '19

13 Dec '19

Tested on my Gentoo and it works (TM). I've copied dependencies from systemd unit files. I was also thinking about providing a dummy init script that would do nothing but depend on the rest of sub-daemon init files for convenience: /etc/init.d/libvirt-dummy start (the name is still WIP) But I'm not sure if we want that - after we drop libvirtd we can use libvirtd script just for that. But if somebody wants it, I can write and post it as a follow up patch. Michal Prívozník (2): configure: Provide OpenRC scripts for sub-daemons news: Document init scripts docs/news.xml | 11 ++++++ m4/virt-init-script.m4 | 8 +++- src/Makefile.am | 56 +++++++++++++++++++++++++++- src/interface/Makefile.inc.am | 11 ++++++ src/interface/virtinterfaced.init.in | 26 +++++++++++++ src/libxl/Makefile.inc.am | 10 +++++ src/libxl/virtxend.init.in | 26 +++++++++++++ src/lxc/Makefile.inc.am | 10 +++++ src/lxc/virtlxcd.init.in | 26 +++++++++++++ src/network/Makefile.inc.am | 10 +++++ src/network/virtnetworkd.init.in | 26 +++++++++++++ src/node_device/Makefile.inc.am | 11 ++++++ src/node_device/virtnodedevd.init.in | 26 +++++++++++++ src/nwfilter/Makefile.inc.am | 11 ++++++ src/nwfilter/virtnwfilterd.init.in | 26 +++++++++++++ src/qemu/Makefile.inc.am | 10 +++++ src/qemu/virtqemud.init.in | 26 +++++++++++++ src/remote/Makefile.inc.am | 30 +++++++++++++++ src/remote/libvirtd.confd | 18 +++++++++ src/remote/libvirtd.init.in | 29 ++++++++++++++ src/remote/virtproxyd.confd | 10 +++++ src/remote/virtproxyd.init.in | 28 ++++++++++++++ src/secret/Makefile.inc.am | 10 +++++ src/secret/virtsecretd.init.in | 26 +++++++++++++ src/storage/Makefile.inc.am | 10 +++++ src/storage/virtstoraged.init.in | 26 +++++++++++++ src/vbox/Makefile.inc.am | 10 +++++ src/vbox/virtvboxd.init.in | 26 +++++++++++++ src/vz/Makefile.inc.am | 10 +++++ src/vz/virtvzd.init.in | 26 +++++++++++++ 30 files changed, 587 insertions(+), 2 deletions(-) create mode 100644 src/interface/virtinterfaced.init.in create mode 100644 src/libxl/virtxend.init.in create mode 100644 src/lxc/virtlxcd.init.in create mode 100644 src/network/virtnetworkd.init.in create mode 100644 src/node_device/virtnodedevd.init.in create mode 100644 src/nwfilter/virtnwfilterd.init.in create mode 100644 src/qemu/virtqemud.init.in create mode 100644 src/remote/libvirtd.confd create mode 100644 src/remote/libvirtd.init.in create mode 100644 src/remote/virtproxyd.confd create mode 100644 src/remote/virtproxyd.init.in create mode 100644 src/secret/virtsecretd.init.in create mode 100644 src/storage/virtstoraged.init.in create mode 100644 src/vbox/virtvboxd.init.in create mode 100644 src/vz/virtvzd.init.in -- 2.23.0

2 4

[libvirt] [PATCH RESEND 0/4] Add support for Hygon Dhyana CPU
by Yingle Hou 13 Dec '19

13 Dec '19

As a Joint Venture between AMD and Haiguang Information Technology Co., Ltd., Hygon aims to provide x86 server processor in China market. The first generation processor Dhyana (family 18h) shares similar architecture with AMD family 17h. As Dhyana support in QEMU already have been merged in qemu-4.1.0 [1], to add Dhyana support in libvirt, we have added a new Dhyana CPU model file x86_Dhyana.xml in cpu_map directory, and also we have added a series of Dhyana test files. We have tested the patches on Hygon Dhyana machine with the result that it has successfully worked as expected. Reference: [1] https://patchwork.kernel.org/patch/10902889/ Yingle Hou (4): cpu: Remove the verification conditions of the model in the x86 signatures cpu: Add new Dhyana CPU model cputest: Add CPUID data for Hygon Dhyana 7185 32-core Processor domaincapstest: Add CPU model Dhyana to QEMU src/cpu/cpu_x86.c | 2 +- src/cpu_map/Makefile.inc.am | 1 + src/cpu_map/index.xml | 3 + src/cpu_map/x86_Dhyana.xml | 70 + src/cpu_map/x86_vendors.xml | 1 + tests/cputest.c | 1 + ...86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml | 7 + ...x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml | 9 + .../x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml | 16 + .../x86_64-cpuid-Hygon-C86-7185-32-core-host.xml | 17 + .../x86_64-cpuid-Hygon-C86-7185-32-core-json.xml | 12 + .../x86_64-cpuid-Hygon-C86-7185-32-core.json | 1631 ++++++++++++++++++++ .../x86_64-cpuid-Hygon-C86-7185-32-core.sig | 4 + .../x86_64-cpuid-Hygon-C86-7185-32-core.xml | 54 + tests/domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + 20 files changed, 1833 insertions(+), 1 deletion(-) create mode 100644 src/cpu_map/x86_Dhyana.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-disabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-enabled.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-guest.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-host.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core-json.xml create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.json create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.sig create mode 100644 tests/cputestdata/x86_64-cpuid-Hygon-C86-7185-32-core.xml -- 1.8.3.1

2 9

[libvirt] [PATCH] docs: remove link to virsh cmd ref & app dev guide
by Daniel P. Berrangé 13 Dec '19

13 Dec '19

Both the application developer guide and virsh command reference are unmaintained for best part of 8 years, and so horrifically out of date. This does not give a good impression to people reading the docs. Now that we are publishing the man pages online, those are a better doc to read for virsh. We can also highlight the API reference instead of the app dev guide. The virsh command reference & app dev guide will still exist on the web root, but will not be linked to. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/docs.html.in | 48 +++++++++++++++++++++-------------------------- 1 file changed, 21 insertions(+), 27 deletions(-) diff --git a/docs/docs.html.in b/docs/docs.html.in index b592f7d51f..004f099a9f 100644 --- a/docs/docs.html.in +++ b/docs/docs.html.in @@ -54,11 +54,27 @@ <div class="panel"> <h2>Application development</h2> <dl> - <dt><a href="devguide.html">Development Guide</a></dt> - <dd>A guide and reference for developing with libvirt</dd> - - <dt><a href="virshcmdref.html">Virsh Commands</a></dt> - <dd>Command reference for virsh</dd> + <dt><a href="html/index.html">API reference</a></dt> + <dd>Reference manual for the C public API, split in + <a href="html/libvirt-libvirt-common.html">common</a>, + <a href="html/libvirt-libvirt-domain.html">domain</a>, + <a href="html/libvirt-libvirt-domain-checkpoint.html">domain checkpoint</a>, + <a href="html/libvirt-libvirt-domain-snapshot.html">domain snapshot</a>, + <a href="html/libvirt-virterror.html">error</a>, + <a href="html/libvirt-libvirt-event.html">event</a>, + <a href="html/libvirt-libvirt-host.html">host</a>, + <a href="html/libvirt-libvirt-interface.html">interface</a>, + <a href="html/libvirt-libvirt-network.html">network</a>, + <a href="html/libvirt-libvirt-nodedev.html">node device</a>, + <a href="html/libvirt-libvirt-nwfilter.html">network filter</a>, + <a href="html/libvirt-libvirt-secret.html">secret</a>, + <a href="html/libvirt-libvirt-storage.html">storage</a>, + <a href="html/libvirt-libvirt-stream.html">stream</a> + and + <a href="html/index-admin.html">admin</a>, + <a href="html/index-qemu.html">QEMU</a>, + <a href="html/index-lxc.html">LXC</a> libs + </dd> <dt><a href="bindings.html">Language bindings and API modules</a></dt> <dd>Bindings of the libvirt API for @@ -97,28 +113,6 @@ <dt><a href="cgroups.html">CGroups</a></dt> <dd>Control groups integration</dd> - <dt><a href="html/index.html">API reference</a></dt> - <dd>Reference manual for the C public API, split in - <a href="html/libvirt-libvirt-common.html">common</a>, - <a href="html/libvirt-libvirt-domain.html">domain</a>, - <a href="html/libvirt-libvirt-domain-checkpoint.html">domain checkpoint</a>, - <a href="html/libvirt-libvirt-domain-snapshot.html">domain snapshot</a>, - <a href="html/libvirt-virterror.html">error</a>, - <a href="html/libvirt-libvirt-event.html">event</a>, - <a href="html/libvirt-libvirt-host.html">host</a>, - <a href="html/libvirt-libvirt-interface.html">interface</a>, - <a href="html/libvirt-libvirt-network.html">network</a>, - <a href="html/libvirt-libvirt-nodedev.html">node device</a>, - <a href="html/libvirt-libvirt-nwfilter.html">network filter</a>, - <a href="html/libvirt-libvirt-secret.html">secret</a>, - <a href="html/libvirt-libvirt-storage.html">storage</a>, - <a href="html/libvirt-libvirt-stream.html">stream</a> - and - <a href="html/index-admin.html">admin</a>, - <a href="html/index-qemu.html">QEMU</a>, - <a href="html/index-lxc.html">LXC</a> libs - </dd> - <dt><a href="drivers.html">Drivers</a></dt> <dd>Hypervisor specific driver information</dd> -- 2.21.0

2 1

[libvirt] [dockerfiles PATCH] Drop Dockerfile for mips cross-builds on Debian sid
by Andrea Bolognani 13 Dec '19

13 Dec '19

The Debian project has dropped support for the architecture. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfiles maintainance rule. Text diff below. buildenv-libvirt-debian-sid-cross-mips.zip | Bin 1010 -> 0 bytes 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 buildenv-libvirt-debian-sid-cross-mips.zip diff --git a/buildenv-libvirt-debian-sid-cross-mips.zip b/buildenv-libvirt-debian-sid-cross-mips.zip deleted file mode 100644 index 287fa12..0000000 --- a/buildenv-libvirt-debian-sid-cross-mips.zip +++ /dev/null @@ -1,112 +0,0 @@ -FROM debian:sid - -RUN export DEBIAN_FRONTEND=noninteractive && \ - apt-get update && \ - apt-get dist-upgrade -y && \ - apt-get install --no-install-recommends -y \ - augeas-lenses \ - augeas-tools \ - autoconf \ - automake \ - autopoint \ - bash \ - bash-completion \ - ca-certificates \ - ccache \ - chrony \ - dnsmasq-base \ - dwarves \ - ebtables \ - flake8 \ - gcc \ - gdb \ - gettext \ - git \ - iproute2 \ - kmod \ - libc-dev-bin \ - libtool \ - libtool-bin \ - libxml2-utils \ - locales \ - lsof \ - lvm2 \ - make \ - meson \ - net-tools \ - nfs-common \ - ninja-build \ - numad \ - open-iscsi \ - parted \ - patch \ - perl \ - pkgconf \ - policykit-1 \ - python3 \ - python3-docutils \ - python3-setuptools \ - qemu-utils \ - radvd \ - screen \ - scrub \ - strace \ - sudo \ - vim \ - xsltproc \ - zfs-fuse && \ - apt-get autoremove -y && \ - apt-get autoclean -y && \ - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\1,' /etc/locale.gen && \ - dpkg-reconfigure locales - -RUN export DEBIAN_FRONTEND=noninteractive && \ - dpkg --add-architecture mips && \ - apt-get update && \ - apt-get dist-upgrade -y && \ - apt-get install --no-install-recommends -y \ - gcc-mips-linux-gnu \ - libacl1-dev:mips \ - libapparmor-dev:mips \ - libattr1-dev:mips \ - libaudit-dev:mips \ - libavahi-client-dev:mips \ - libblkid-dev:mips \ - libc6-dev:mips \ - libcap-ng-dev:mips \ - libcurl4-gnutls-dev:mips \ - libdbus-1-dev:mips \ - libdevmapper-dev:mips \ - libfuse-dev:mips \ - libglib2.0-dev:mips \ - libglusterfs-dev:mips \ - libgnutls28-dev:mips \ - libiscsi-dev:mips \ - libncurses-dev:mips \ - libnl-3-dev:mips \ - libnl-route-3-dev:mips \ - libnuma-dev:mips \ - libparted-dev:mips \ - libpcap0.8-dev:mips \ - libpciaccess-dev:mips \ - librbd-dev:mips \ - libreadline-dev:mips \ - libsanlock-dev:mips \ - libsasl2-dev:mips \ - libselinux1-dev:mips \ - libssh-gcrypt-dev:mips \ - libssh2-1-dev:mips \ - libtirpc-dev:mips \ - libudev-dev:mips \ - libxml2-dev:mips \ - libyajl-dev:mips \ - xfslibs-dev:mips && \ - apt-get autoremove -y && \ - apt-get autoclean -y - -ENV LANG "en_US.UTF-8" - -ENV ABI "mips-linux-gnu" -ENV CONFIGURE_OPTS "--host=mips-linux-gnu \ - --target=mips-linux-gnu" -ENV PKG_CONFIG_LIBDIR "/usr/lib/mips-linux-gnu/pkgconfig" -- 2.23.0

1 0

[libvirt] [PATCH] gitlab: Move mips job to Debian 9
by Andrea Bolognani 13 Dec '19

13 Dec '19

Support for the mips architecture has been dropped from Debian sid. Move the mipsel job from Debian 9 to Debian sid at the same time to keep things balanced. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .gitlab-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 3915a37a90..ea49c6178b 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -17,9 +17,9 @@ debian-9-cross-mips64el: <<: *job_definition image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mips64el:latest -debian-9-cross-mipsel: +debian-9-cross-mips: <<: *job_definition - image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mipsel:latest + image: quay.io/libvirt/buildenv-libvirt-debian-9-cross-mips:latest debian-10-cross-aarch64: <<: *job_definition @@ -41,6 +41,6 @@ debian-sid-cross-i686: <<: *job_definition image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-i686:latest -debian-sid-cross-mips: +debian-sid-cross-mipsel: <<: *job_definition - image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-mips:latest + image: quay.io/libvirt/buildenv-libvirt-debian-sid-cross-mipsel:latest -- 2.23.0

2 1

[libvirt] [PATCH 0/2] cpu_map: Introduce IA32_ARCH_CAPABILITIES MSR bits for TAA
by Jiri Denemark 13 Dec '19

13 Dec '19

CVE-2019-11135 TAA_NO and TSX_CTRL are new IA32_ARCH_CAPABILITIES MSR bits related to the TSX Asynchronous Abort (TAA) vulnerability. See [1] and [2] for details about the issue and mitigations. [1] https://software.intel.com/security-software-guidance/insights/deep-dive-in… [2] https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.… Jiri Denemark (2): cpu_map: Add TAA_NO bit for IA32_ARCH_CAPABILITIES MSR cpu_map: Add TSX_CTRL bit for IA32_ARCH_CAPABILITIES MSR src/cpu_map/x86_features.xml | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.24.1

2 3

[libvirt] [PATCH] qemu: snapshot: Fix libvirtd crash in snapshot-revert
by Lin Ma 13 Dec '19

13 Dec '19

When reverting a running domain to a snapshot(active state), We need to use the FORCE flag for snapshot-revert if current domain configuration is different from the target domain configuration, and this will start a new qemu instance for the target domain. In this situation, if there is existing connection to the domain, say Spice or VNC through virt-manager, Then the libvirtd would crash during snapshot revert because: Both of snapshot revert worker and new worker job 'remoteDispatchDomainOpenGraphicsFd' are waiting for mon->msg->finished in qemuMonitorSend(), We know if IO process resulted in an error with a message, Libvirtd main thread calls qemuMonitorIO() to wakeup the waiter. Then mon->msg will be set to NULL in qemuMonitorSend() once the worker GraphicsFD is woken up, which causes snapshot revert worker dereferences this null pointer. Not sure whether this scenario makes sense, But at least the libvirtd should not crash, So fix it. Thread 6 "libvirtd" hit Breakpoint 1, qemuMonitorSend 987 if (mon->lastError.code != VIR_ERR_OK) { (gdb) bt #0 in qemuMonitorSend #1 in qemuMonitorJSONCommandWithFd #2 in qemuMonitorJSONSendFileHandle #3 in qemuMonitorSendFileHandle #4 in qemuMonitorOpenGraphics #5 in qemuDomainOpenGraphicsFD #6 in virDomainOpenGraphicsFD #7 in remoteDispatchDomainOpenGraphicsFd #8 in remoteDispatchDomainOpenGraphicsFdHelper #9 in virNetServerProgramDispatchCall #10 in virNetServerProgramDispatch #11 in virNetServerProcessMsg #12 in virNetServerHandleJob #13 in virThreadPoolWorker #14 in virThreadHelper #15 in start_thread #16 in clone (gdb) c Continuing. Thread 2 "libvirtd" received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7fbd20fe2700 (LWP 19014)] 0x00007fbd1c3be838 in qemuMonitorSend (mon=mon@entry=0x7fbd1804a940, msg=msg@entry=0x7fbd20fe15b0) at ../../src/qemu/qemu_monitor.c:1001 1001 while (!mon->msg->finished) { (gdb) bt #0 in qemuMonitorSend #1 in qemuMonitorJSONCommandWithFd #2 in qemuMonitorJSONCommand #3 in qemuMonitorJSONGetChardevInfo #4 in qemuMonitorGetChardevInfo #5 in qemuProcessWaitForMonitor #6 in qemuProcessLaunch #7 in qemuProcessStart #8 in qemuDomainRevertToSnapshot #9 in virDomainRevertToSnapshot #10 in remoteDispatchDomainRevertToSnapshot #11 in remoteDispatchDomainRevertToSnapshotHelper #12 in virNetServerProgramDispatchCall #13 in virNetServerProgramDispatch #14 in virNetServerProcessMsg #15 in virNetServerHandleJob #16 in virThreadPoolWorker #17 in virThreadHelper #18 in start_thread #19 in clone Signed-off-by: Lin Ma <lma(a)suse.com> --- src/qemu/qemu_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index ea3e62dc8e..a8344e698b 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -994,7 +994,7 @@ qemuMonitorSend(qemuMonitorPtr mon, "mon=%p msg=%s fd=%d", mon, mon->msg->txBuffer, mon->msg->txFD); - while (!mon->msg->finished) { + while (mon->msg && !mon->msg->finished) { if (virCondWait(&mon->notify, &mon->parent.lock) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unable to wait on monitor condition")); -- 2.23.0

4 4

[libvirt] [dockerfiles PATCH 0/2] Refresh and add openSUSE Leap 15.1
by Andrea Bolognani 13 Dec '19

13 Dec '19

Pushed under the Dockerfile refresh rule. Text diffs are provided. Andrea Bolognani (2): Refresh Dockerfiles after recent changes Add openSUSE Leap 15.1 Dockerfile for libvirt buildenv-libosinfo-centos-7.zip | Bin 570 -> 1659 bytes buildenv-libosinfo-centos-8.zip | Bin 586 -> 589 bytes buildenv-libvirt-centos-7.zip | Bin 758 -> 1878 bytes buildenv-libvirt-centos-8.zip | Bin 791 -> 793 bytes buildenv-libvirt-debian-10-cross-aarch64.zip | Bin 1016 -> 1021 bytes buildenv-libvirt-debian-10-cross-armv6l.zip | Bin 1009 -> 1014 bytes buildenv-libvirt-debian-10-cross-armv7l.zip | Bin 1013 -> 1019 bytes buildenv-libvirt-debian-10-cross-i686.zip | Bin 1008 -> 1016 bytes buildenv-libvirt-debian-10-cross-mips.zip | Bin 1003 -> 1011 bytes buildenv-libvirt-debian-10-cross-mips64el.zip | Bin 1017 -> 1022 bytes buildenv-libvirt-debian-10-cross-mipsel.zip | Bin 1007 -> 1016 bytes buildenv-libvirt-debian-10-cross-ppc64le.zip | Bin 1019 -> 1024 bytes buildenv-libvirt-debian-10-cross-s390x.zip | Bin 1006 -> 1011 bytes buildenv-libvirt-debian-10.zip | Bin 904 -> 908 bytes buildenv-libvirt-debian-9-cross-aarch64.zip | Bin 1048 -> 1053 bytes buildenv-libvirt-debian-9-cross-armv6l.zip | Bin 1039 -> 1045 bytes buildenv-libvirt-debian-9-cross-armv7l.zip | Bin 1045 -> 1050 bytes buildenv-libvirt-debian-9-cross-mips.zip | Bin 1039 -> 1044 bytes buildenv-libvirt-debian-9-cross-mips64el.zip | Bin 1051 -> 1056 bytes buildenv-libvirt-debian-9-cross-mipsel.zip | Bin 1043 -> 1048 bytes buildenv-libvirt-debian-9-cross-ppc64le.zip | Bin 1053 -> 1057 bytes buildenv-libvirt-debian-9-cross-s390x.zip | Bin 1040 -> 1045 bytes buildenv-libvirt-debian-9.zip | Bin 934 -> 938 bytes buildenv-libvirt-debian-sid-cross-aarch64.zip | Bin 1015 -> 1020 bytes buildenv-libvirt-debian-sid-cross-armv6l.zip | Bin 1009 -> 1013 bytes buildenv-libvirt-debian-sid-cross-armv7l.zip | Bin 1013 -> 1019 bytes buildenv-libvirt-debian-sid-cross-i686.zip | Bin 1008 -> 1016 bytes buildenv-libvirt-debian-sid-cross-mips.zip | Bin 1006 -> 1010 bytes ...denv-libvirt-debian-sid-cross-mips64el.zip | Bin 1017 -> 1022 bytes buildenv-libvirt-debian-sid-cross-mipsel.zip | Bin 1011 -> 1016 bytes buildenv-libvirt-debian-sid-cross-ppc64le.zip | Bin 1018 -> 1023 bytes buildenv-libvirt-debian-sid-cross-s390x.zip | Bin 1006 -> 1011 bytes buildenv-libvirt-debian-sid.zip | Bin 904 -> 908 bytes buildenv-libvirt-opensuse-151.zip | Bin 0 -> 761 bytes buildenv-libvirt-ubuntu-1604.zip | Bin 939 -> 942 bytes buildenv-libvirt-ubuntu-1804.zip | Bin 941 -> 943 bytes 36 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 buildenv-libvirt-opensuse-151.zip -- 2.23.0

1 2

[libvirt] [jenkins-ci PATCH] lcitool: Don't install yast2_base group on openSUSE
by Andrea Bolognani 12 Dec '19

12 Dec '19

We're handling all configuration using lcitool, and we have to be able to cope with minimal openSUSE environments anyway because of containers. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- I've tested this by creating a fresh openSUSE Leap 15.1 VM and verifying that I could successfully 'lcitool build' libvirt inside it. guests/configs/autoinst.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/configs/autoinst.xml b/guests/configs/autoinst.xml index f8ec3df..ceb702d 100644 --- a/guests/configs/autoinst.xml +++ b/guests/configs/autoinst.xml @@ -44,7 +44,6 @@ <patterns config:type="list"> <pattern>base</pattern> <pattern>minimal_base</pattern> - <pattern>yast2_basis</pattern> </patterns> <packages config:type="list"> <package>openssh</package> -- 2.23.0

2 1

[libvirt] [PATCH] Remove redundant usage of WITH_YAJL
by Ján Tomko 12 Dec '19

12 Dec '19

As of commit 2a00ef6e71f30241f9ca6288da984d75f3cef957 which was released in v5.2.0, we require YAJL to build the QEMU driver. Remove the checks from code that requires the QEMU driver or checks that also check for WITH_QEMU. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/qemu/qemu_driver.c | 5 ----- tests/cputest.c | 16 +++++++------- tests/qemuagenttest.c | 5 ----- tests/qemublocktest.c | 42 ++++++++++++++----------------------- tests/qemumigparamstest.c | 5 ----- tests/qemumonitorjsontest.c | 5 ----- 6 files changed, 24 insertions(+), 54 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e65150f42b..66c58d190f 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2104,11 +2104,6 @@ qemuDomainRebootMonitor(virQEMUDriverPtr driver, if (virDomainObjCheckActive(vm) < 0) goto endjob; -#if !WITH_YAJL - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("ACPI reboot is not supported without the JSON monitor")); - goto endjob; -#endif qemuDomainSetFakeReboot(driver, vm, isReboot); qemuDomainObjEnterMonitor(driver, vm); ret = qemuMonitorSystemPowerdown(priv->mon); diff --git a/tests/cputest.c b/tests/cputest.c index fd86344ea4..f57516838b 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -36,7 +36,7 @@ #include "cpu/cpu_map.h" #include "virstring.h" -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU # include "testutilsqemu.h" # include "qemumonitortestutils.h" # define LIBVIRT_QEMU_CAPSPRIV_H_ALLOW @@ -62,7 +62,7 @@ struct data { int result; }; -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU static virQEMUDriver driver; #endif @@ -465,7 +465,7 @@ typedef enum { JSON_MODELS_REQUIRED, } cpuTestCPUIDJson; -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU static virQEMUCapsPtr cpuTestMakeQEMUCaps(const struct data *data) { @@ -547,7 +547,7 @@ cpuTestGetCPUModels(const struct data *data, return 0; } -#else /* if WITH_QEMU && WITH_YAJL */ +#else /* if WITH_QEMU */ static int cpuTestGetCPUModels(const struct data *data, @@ -871,7 +871,7 @@ cpuTestUpdateLive(const void *arg) } -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU static int cpuTestJSONCPUID(const void *arg) { @@ -970,7 +970,7 @@ mymain(void) virDomainCapsCPUModelsPtr ppc_models = NULL; int ret = 0; -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; @@ -1057,7 +1057,7 @@ mymain(void) host "/" cpu " (" #models ")", \ host, cpu, models, 0, result) -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU # define DO_TEST_JSON(arch, host, json) \ do { \ if (json == JSON_MODELS) { \ @@ -1270,7 +1270,7 @@ mymain(void) DO_TEST_CPUID(VIR_ARCH_X86_64, "Ice-Lake-Server", JSON_MODELS); cleanup: -#if WITH_QEMU && WITH_YAJL +#if WITH_QEMU qemuTestDriverFree(&driver); #endif diff --git a/tests/qemuagenttest.c b/tests/qemuagenttest.c index d8824b8f09..644dc9d08b 100644 --- a/tests/qemuagenttest.c +++ b/tests/qemuagenttest.c @@ -1426,11 +1426,6 @@ mymain(void) { int ret = 0; -#if !WITH_YAJL - fputs("libvirt not compiled with JSON support, skipping this test\n", stderr); - return EXIT_AM_SKIP; -#endif - if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index 2c170548ec..c9335774b9 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -18,22 +18,20 @@ #include "testutils.h" +#include "testutilsqemu.h" +#include "testutilsqemuschema.h" +#include "virstoragefile.h" +#include "virstring.h" +#include "virlog.h" +#include "qemu/qemu_block.h" +#include "qemu/qemu_qapi.h" -#if WITH_YAJL -# include "testutilsqemu.h" -# include "testutilsqemuschema.h" -# include "virstoragefile.h" -# include "virstring.h" -# include "virlog.h" -# include "qemu/qemu_block.h" -# include "qemu/qemu_qapi.h" +#include "qemu/qemu_command.h" -# include "qemu/qemu_command.h" +#define LIBVIRT_SNAPSHOT_CONF_PRIV_H_ALLOW +#include "conf/snapshot_conf_priv.h" -# define LIBVIRT_SNAPSHOT_CONF_PRIV_H_ALLOW -# include "conf/snapshot_conf_priv.h" - -# define VIR_FROM_THIS VIR_FROM_NONE +#define VIR_FROM_THIS VIR_FROM_NONE VIR_LOG_INIT("tests.storagetest"); @@ -523,7 +521,7 @@ mymain(void) virTestCounterReset("qemu storage source xml->json->xml "); -# define TEST_JSON_FORMAT(tpe, xmlstr) \ +#define TEST_JSON_FORMAT(tpe, xmlstr) \ do { \ xmljsonxmldata.type = tpe; \ xmljsonxmldata.xml = xmlstr; \ @@ -532,7 +530,7 @@ mymain(void) ret = -1; \ } while (0) -# define TEST_JSON_FORMAT_NET(xmlstr) \ +#define TEST_JSON_FORMAT_NET(xmlstr) \ TEST_JSON_FORMAT(VIR_STORAGE_TYPE_NETWORK, xmlstr) TEST_JSON_FORMAT(VIR_STORAGE_TYPE_FILE, "<source file='/path/to/file'/>\n"); @@ -588,7 +586,7 @@ mymain(void) " <host name='example.com' port='9999'/>\n" "</source>\n"); -# define TEST_DISK_TO_JSON_FULL(nme, fl) \ +#define TEST_DISK_TO_JSON_FULL(nme, fl) \ do { \ diskxmljsondata.name = nme; \ diskxmljsondata.props = NULL; \ @@ -611,7 +609,7 @@ mymain(void) testQemuDiskXMLToPropsClear(&diskxmljsondata); \ } while (0) -# define TEST_DISK_TO_JSON(nme) TEST_DISK_TO_JSON_FULL(nme, false) +#define TEST_DISK_TO_JSON(nme) TEST_DISK_TO_JSON_FULL(nme, false) if (!(diskxmljsondata.schema = testQEMUSchemaLoad())) { ret = -1; @@ -667,7 +665,7 @@ mymain(void) TEST_DISK_TO_JSON("block-raw-noopts"); TEST_DISK_TO_JSON("block-raw-reservations"); -# define TEST_IMAGE_CREATE(testname, testbacking) \ +#define TEST_IMAGE_CREATE(testname, testbacking) \ do { \ imagecreatedata.name = testname; \ imagecreatedata.backingname = testbacking; \ @@ -711,12 +709,4 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -#else -static int -mymain(void) -{ - return EXIT_AM_SKIP; -} -#endif - VIR_TEST_MAIN(mymain) diff --git a/tests/qemumigparamstest.c b/tests/qemumigparamstest.c index b36aa60302..954cd1c578 100644 --- a/tests/qemumigparamstest.c +++ b/tests/qemumigparamstest.c @@ -201,11 +201,6 @@ mymain(void) virQEMUDriver driver; int ret = 0; -#if !WITH_YAJL - fputs("libvirt not compiled with JSON support, skipping this test\n", stderr); - return EXIT_AM_SKIP; -#endif - if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index 4f3bfad1d7..21b029390c 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2991,11 +2991,6 @@ mymain(void) virJSONValuePtr metaschema = NULL; char *metaschemastr = NULL; -#if !WITH_YAJL - fputs("libvirt not compiled with JSON support, skipping this test\n", stderr); - return EXIT_AM_SKIP; -#endif - if (qemuTestDriverInit(&driver) < 0) return EXIT_FAILURE; -- 2.19.2

2 1

[libvirt] [jenkins-ci PATCH 0/5] lcitool: Make Dockerfile generation work on openSUSE
by Andrea Bolognani 12 Dec '19

12 Dec '19

With this series applied, running ./lcitool dockerfile libvirt-opensuse-151 libvirt results in a Dockerfile that can be successfully used to build a container image, and that image in turn can be successfully used to build libvirt in. Andrea Bolognani (5): guests: Add mapping for augeas-lenses guests: Install augeas-lenses for libvirt lcitool: Remove redundant update step for openSUSE guests: Add base container image for openSUSE Leap 15.1 lcitool: Make Dockerfile generation work on openSUSE guests/host_vars/libvirt-opensuse-151/docker.yml | 2 ++ guests/lcitool | 14 ++++++++++++-- guests/playbooks/update/tasks/base.yml | 7 ------- guests/vars/mappings.yml | 5 +++++ guests/vars/projects/libvirt.yml | 1 + 5 files changed, 20 insertions(+), 9 deletions(-) create mode 100644 guests/host_vars/libvirt-opensuse-151/docker.yml -- 2.23.0

4 20

[libvirt] [jenkins-ci PATCH v2 0/6] Add support for gtk-vnc builds
by Daniel P. Berrangé 12 Dec '19

12 Dec '19

Support gtk-vnc and make virt-viewer depend on it I sent this months ago & forgot to push it. Re-sending just in case something has invalidated any patches. I've at least added the newer distros Daniel P. Berrangé (6): mappings: add libgcrypt mappings: add PulseAudio projects: add gtk-vnc project guests: pull in deps for gtk-vnc project projects: make virt-viewer depend on gtk-vnc jobs mappings: remove gtk-vnc2 guests/host_vars/libvirt-centos-7/main.yml | 1 + guests/host_vars/libvirt-centos-8/main.yml | 1 + guests/host_vars/libvirt-debian-10/main.yml | 1 + guests/host_vars/libvirt-debian-9/main.yml | 1 + guests/host_vars/libvirt-debian-sid/main.yml | 1 + guests/host_vars/libvirt-fedora-30/main.yml | 1 + guests/host_vars/libvirt-fedora-31/main.yml | 1 + .../host_vars/libvirt-fedora-rawhide/main.yml | 3 ++ guests/host_vars/libvirt-freebsd-11/main.yml | 1 + guests/host_vars/libvirt-freebsd-12/main.yml | 1 + .../libvirt-freebsd-current/main.yml | 1 + guests/host_vars/libvirt-ubuntu-1604/main.yml | 1 + guests/host_vars/libvirt-ubuntu-1804/main.yml | 1 + guests/playbooks/build/jobs/defaults.yml | 3 ++ .../build/projects/gtk-vnc+mingw32.yml | 12 ++++++++ .../build/projects/gtk-vnc+mingw64.yml | 12 ++++++++ guests/playbooks/build/projects/gtk-vnc.yml | 14 +++++++++ guests/vars/mappings.yml | 30 +++++++++++-------- guests/vars/projects/gtk-vnc+mingw32.yml | 6 ++++ guests/vars/projects/gtk-vnc+mingw64.yml | 6 ++++ guests/vars/projects/gtk-vnc.yml | 11 +++++++ guests/vars/projects/virt-viewer+mingw32.yml | 1 - guests/vars/projects/virt-viewer+mingw64.yml | 1 - guests/vars/projects/virt-viewer.yml | 1 - jenkins/jobs/defaults.yaml | 3 ++ jenkins/projects/gtk-vnc+mingw32.yaml | 12 ++++++++ jenkins/projects/gtk-vnc+mingw64.yaml | 12 ++++++++ jenkins/projects/gtk-vnc.yaml | 17 +++++++++++ jenkins/projects/virt-viewer+mingw32.yaml | 4 ++- jenkins/projects/virt-viewer+mingw64.yaml | 4 ++- jenkins/projects/virt-viewer.yaml | 4 ++- 31 files changed, 149 insertions(+), 19 deletions(-) create mode 100644 guests/playbooks/build/projects/gtk-vnc+mingw32.yml create mode 100644 guests/playbooks/build/projects/gtk-vnc+mingw64.yml create mode 100644 guests/playbooks/build/projects/gtk-vnc.yml create mode 100644 guests/vars/projects/gtk-vnc+mingw32.yml create mode 100644 guests/vars/projects/gtk-vnc+mingw64.yml create mode 100644 guests/vars/projects/gtk-vnc.yml create mode 100644 jenkins/projects/gtk-vnc+mingw32.yaml create mode 100644 jenkins/projects/gtk-vnc+mingw64.yaml create mode 100644 jenkins/projects/gtk-vnc.yaml -- 2.23.0

2 9

[libvirt] [jenkins-ci PATCH] lcitool: Only install EPEL on CentOS
by Andrea Bolognani 12 Dec '19

12 Dec '19

This fixes a bug introduced by commit 0a7993d3ed30 which caused our machinery to try to install the epel-release on all targets, including the likes of Debian and even FreeBSD. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the build breaker rule. guests/playbooks/update/tasks/base.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml index 8128975..f721e39 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -21,6 +21,8 @@ package: name: epel-release state: latest + when: + - os_name == 'CentOS' - name: Create OpenVZ key template: -- 2.23.0

1 0

[libvirt] [PATCH 0/8] Don't hold both monitor and agent jobs at the same time
by Jonathon Jongsma 12 Dec '19

12 Dec '19

We have to assume that the guest agent may be malicious, so we don't want to allow any agent queries to block any other libvirt API. By holding a monitor job and an agent job while we're querying the agent, any other threads will be blocked from using the monitor while the agent is unresponsive. Because libvirt waits forever for an agent response, this makes us vulnerable to a denial of service from a malicious (or simply buggy) guest agent. This series of patches attempts to remove any cases where we were holding both jobs at the same time, removes a convenience function which allows us to grab both jobs at once, and updates documentation regarding this issue. Jonathon Jongsma (8): qemu: don't take agent and monitor job for shutdown qemu: don't hold a monitor and agent job for reboot qemu: don't hold both jobs for suspend qemu: don't hold monitor and agent job when setting time qemu: don't hold monitor job for fsinfo qemu: don't hold monitor job for GetGuestInfo() qemu: remove use of qemuDomainObjBeginJobWithAgent() qemu: remove qemuDomainObjBegin/EndJobWithAgent() src/qemu/THREADS.txt | 58 +----- src/qemu/qemu_domain.c | 56 +----- src/qemu/qemu_domain.h | 7 - src/qemu/qemu_driver.c | 405 +++++++++++++++++++++++++---------------- 4 files changed, 258 insertions(+), 268 deletions(-) -- 2.21.0

3 15

[libvirt] [RFC PATCH 0/9] add virtiofs support (virtio-fs epopee)
by Ján Tomko 12 Dec '19

12 Dec '19

https://bugzilla.redhat.com/show_bug.cgi?id=1694166 A work in progress, but I'm sending it now to get the XML bikesh^Wdiscussion out of the way. TODO: * documentation (due to the requirement of shared memory and therefore a <numa> topology specification, this probably deserves a separate article on https://libvirt.org/kbase.html ) * validation - refuse unsupported combinations and block migration * remove a few hardcoded values * figure out the binary path from qemu interop config * leave queue-size and cache-size on their default values or expose them in XML * use FD passing for vhost-user-fs device as well * clean up the code Tested with: commit 320000e72ec0613e164ce9608d865396fb2da278 Author: Linus Torvalds <torvalds(a)linux-foundation.org> Date: Wed Oct 30 14:17:18 2019 +0100 Merge tag 'iommu-fixes-v5.4-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu and commit d3d2efbb0e37494708dde359a9d0f492f84833e8 Author: Dr. David Alan Gilbert <dgilbert(a)redhat.com> CommitDate: 2019-10-24 11:50:55 +0100 virtio-fs: Allow mapping of meta data version table from https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev git fetch https://gitlab.com/virtio-fs/qemu.git virtio-fs-dev (not yet merged upstream) Ján Tomko (9): qemu: address: take fsdriver type into account qemu: cmdline: take fsdriver into account qemu: add QEMU_CAPS_VHOST_USER_FS wip: tests: add xml2xml tests for virtio-fs wip: add XML -> ARGV tests for virtio-fs conf: qemu: add virtio-fs fsdriver type qemu: pass private data to qemuBuildFilesystemCommandLine wip: start virtiofsd wip: build vhost-user-fs device command line docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 2 + src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 67 +++++- src/qemu/qemu_domain.c | 4 + src/qemu/qemu_domain_address.c | 35 +++- src/qemu/qemu_extdevice.c | 191 ++++++++++++++++++ ...vhost-user-fs-fd-memory.x86_64-latest.args | 38 ++++ .../vhost-user-fs-fd-memory.xml | 38 ++++ ...vhost-user-fs-hugepages.x86_64-latest.args | 42 ++++ .../vhost-user-fs-hugepages.xml | 67 ++++++ tests/qemuxml2argvtest.c | 9 + .../vhost-user-fs-fd-memory.x86_64-latest.xml | 1 + .../vhost-user-fs-hugepages.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 3 + 17 files changed, 493 insertions(+), 14 deletions(-) create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-fd-memory.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-fd-memory.xml create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-hugepages.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/vhost-user-fs-hugepages.xml create mode 120000 tests/qemuxml2xmloutdata/vhost-user-fs-fd-memory.x86_64-latest.xml create mode 120000 tests/qemuxml2xmloutdata/vhost-user-fs-hugepages.x86_64-latest.xml -- 2.21.0

5 19

[libvirt] [jenkins-ci PATCH 0/2] lcitool: Refactor Dockerfile generation
by Andrea Bolognani 12 Dec '19

12 Dec '19

Andrea Bolognani (2): lcitool: Perform system update after enabling repos lcitool: Refactor Dockerfile generation guests/lcitool | 66 +++++++++++++++++++++++++------------------------- 1 file changed, 33 insertions(+), 33 deletions(-) -- 2.23.0

2 6

[libvirt] [PATCH v2 0/3] misc fixes for qemu domain validation/post-parse
by Daniel P. Berrangé 12 Dec '19

12 Dec '19

Daniel P. Berrangé (3): tests: add a domain ID to live status XML doc qemu: check os type / virt type / arch in validate callback qemu: honour parseOpaque instead of refetching caps src/qemu/qemu_domain.c | 54 ++++++++++--------- .../qemustatusxml2xmldata/vcpus-multi-in.xml | 2 +- tests/qemuxml2argvtest.c | 9 ++-- 3 files changed, 35 insertions(+), 30 deletions(-) -- 2.23.0

2 5

[libvirt] [PATCHv2 0/8] Remove VIR_STRNDUP
by Ján Tomko 12 Dec '19

12 Dec '19

Ján Tomko (8): Remove VIR_STRDUP usage that sneaked in in the meantime vsh: remove vshErrorOOM Remove VIR_STRNDUP usage with checked pointers Remove all the uses that use subtraction in their length argument Remove the rest of VIR_STRNDUP tests: delete tests for VIR_STR(N)DUP util: remove VIR_STRDUP and VIR_STRNDUP docs: hacking: document removal of VIR_STR(N)DUP docs/hacking.html.in | 10 +- src/bhyve/bhyve_parse_command.c | 6 +- src/conf/backup_conf.c | 4 +- src/conf/nwfilter_conf.c | 4 +- src/conf/nwfilter_params.c | 6 +- src/interface/interface_backend_udev.c | 8 +- src/libvirt_private.syms | 2 - src/libxl/xen_common.c | 29 +++--- src/libxl/xen_xl.c | 6 +- src/libxl/xen_xm.c | 9 +- src/lxc/lxc_driver.c | 3 +- src/qemu/qemu_driver.c | 3 +- src/qemu/qemu_monitor_json.c | 14 +-- src/rpc/virnetlibsshsession.c | 7 +- src/util/vircgroupv1.c | 5 +- src/util/vircommand.c | 1 - src/util/virconf.c | 24 ++--- src/util/viriscsi.c | 3 +- src/util/virjson.c | 11 +- src/util/virkeyfile.c | 9 +- src/util/virsocketaddr.c | 5 +- src/util/virstoragefile.c | 6 +- src/util/virstring.c | 52 +--------- src/util/virstring.h | 69 ------------- src/util/virsysinfo.c | 3 +- src/vmware/vmware_conf.c | 6 +- tests/virstringtest.c | 136 ------------------------- tools/vsh.c | 16 +-- 28 files changed, 63 insertions(+), 394 deletions(-) -- 2.21.0

2 9

[libvirt] [jenkins-ci PATCH] lcitool: Fix invalid escape sequence
by Andrea Bolognani 12 Dec '19

12 Dec '19

Spotted by flake8. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. guests/lcitool | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/lcitool b/guests/lcitool index e87a805..d4dc1c8 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -723,7 +723,7 @@ class Application: {package_manager} install --no-install-recommends -y {pkgs} && \\ {package_manager} autoremove -y && \\ {package_manager} autoclean -y && \\ - sed -Ei 's,^# (en_US\.UTF-8 .*)$,\\1,' /etc/locale.gen && \\ + sed -Ei 's,^# (en_US\\.UTF-8 .*)$,\\1,' /etc/locale.gen && \\ dpkg-reconfigure locales """).format(**varmap)) if args.cross_arch: -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH] guests: Fix locale handling
by Andrea Bolognani 12 Dec '19

12 Dec '19

Commit 3ce973f2fb38 introduced a new glibc-langpack-en mapping in order to make en_US.UTF-8 available on CentOS 8, but as it turns out we already had a mapping for that and we just needed to tweak it a bit. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/vars/mappings.yml | 9 ++------- guests/vars/projects/base.yml | 1 - 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 68664a0..d32ecf3 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -189,11 +189,6 @@ mappings: rpm: glibc-devel cross-policy-deb: foreign - glibc-langpack-en: - rpm: glibc-langpack-en - CentOS7: - OpenSUSE: - glibc-static: deb: libc6-dev rpm: glibc-static @@ -451,9 +446,9 @@ mappings: cross-policy-deb: foreign locales: - CentOS7: glibc-common deb: locales - Fedora: glibc-langpack-en + rpm: glibc-langpack-en + CentOS7: glibc-common FreeBSD: OpenSUSE: glibc-locale diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 9ebf249..29c10b4 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -14,7 +14,6 @@ packages: - gettext - git - glibc - - glibc-langpack-en - libtool - libtoolize - locales -- 2.23.0

2 2

[libvirt] [dockerfiles PATCH] Refresh after recent changes
by Andrea Bolognani 12 Dec '19

12 Dec '19

This makes the en_US.UTF-8 locale available on CentOS 8 and uses better named tags for CentOS images. The corresponding libvirt-jenkins-ci commit is 2c996a745a68. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. Text diff below. buildenv-libosinfo-centos-7.zip | Bin 572 -> 570 bytes buildenv-libosinfo-centos-8.zip | Bin 578 -> 586 bytes buildenv-libvirt-centos-7.zip | Bin 761 -> 758 bytes buildenv-libvirt-centos-8.zip | Bin 781 -> 791 bytes 4 files changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libosinfo-centos-7.zip b/buildenv-libosinfo-centos-7.zip index b91f3aa..ac09cf5 100644 --- a/buildenv-libosinfo-centos-7.zip +++ b/buildenv-libosinfo-centos-7.zip @@ -1,4 +1,4 @@ -FROM centos:centos7 +FROM centos:7 RUN yum update -y && \ yum install -y epel-release && \ diff --git a/buildenv-libosinfo-centos-8.zip b/buildenv-libosinfo-centos-8.zip index e739059..6ac848e 100644 --- a/buildenv-libosinfo-centos-8.zip +++ b/buildenv-libosinfo-centos-8.zip @@ -1,4 +1,4 @@ -FROM centos:centos8 +FROM centos:8 RUN dnf update -y && \ dnf install 'dnf-command(config-manager)' -y && \ @@ -19,6 +19,7 @@ RUN dnf update -y && \ git \ glib2-devel \ glibc-devel \ + glibc-langpack-en \ gobject-introspection-devel \ gtk-doc \ hwdata \ diff --git a/buildenv-libvirt-centos-7.zip b/buildenv-libvirt-centos-7.zip index 4e9c3db..bc3041f 100644 --- a/buildenv-libvirt-centos-7.zip +++ b/buildenv-libvirt-centos-7.zip @@ -1,4 +1,4 @@ -FROM centos:centos7 +FROM centos:7 RUN yum update -y && \ yum install -y epel-release && \ diff --git a/buildenv-libvirt-centos-8.zip b/buildenv-libvirt-centos-8.zip index 5410201..bb014ea 100644 --- a/buildenv-libvirt-centos-8.zip +++ b/buildenv-libvirt-centos-8.zip @@ -1,4 +1,4 @@ -FROM centos:centos8 +FROM centos:8 RUN dnf update -y && \ dnf install 'dnf-command(config-manager)' -y && \ @@ -27,6 +27,7 @@ RUN dnf update -y && \ git \ glib2-devel \ glibc-devel \ + glibc-langpack-en \ glusterfs-api-devel \ gnutls-devel \ iproute \ -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH] guests: Use more natural tags for CentOS base images
by Andrea Bolognani 12 Dec '19

12 Dec '19

Both the 'X' and 'centosX' tags are available on the registry, and they point to the same image; the former looks more natural though, so let's use that one. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/host_vars/libvirt-centos-7/docker.yml | 2 +- guests/host_vars/libvirt-centos-8/docker.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/docker.yml b/guests/host_vars/libvirt-centos-7/docker.yml index 59f7f12..5c2e299 100644 --- a/guests/host_vars/libvirt-centos-7/docker.yml +++ b/guests/host_vars/libvirt-centos-7/docker.yml @@ -1,2 +1,2 @@ --- -docker_base: centos:centos7 +docker_base: centos:7 diff --git a/guests/host_vars/libvirt-centos-8/docker.yml b/guests/host_vars/libvirt-centos-8/docker.yml index 10c2a50..aae78a2 100644 --- a/guests/host_vars/libvirt-centos-8/docker.yml +++ b/guests/host_vars/libvirt-centos-8/docker.yml @@ -1,2 +1,2 @@ --- -docker_base: centos:centos8 +docker_base: centos:8 -- 2.23.0

2 1

[libvirt] [PATCH] docs: stop using syntax highlighting for man page code blocks
by Daniel P. Berrangé 12 Dec '19

12 Dec '19

Some versions of the rst2man convertor are buggy failing to cope with syntax highlighting in code blocks. This isn't something we really need for the man page code blocks, so we can just delete the highlighting directive. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/manpages/libvirtd.rst | 4 +- docs/manpages/virsh.rst | 576 ++++++++++++++--------------- docs/manpages/virt-admin.rst | 50 +-- docs/manpages/virt-login-shell.rst | 2 +- docs/manpages/virtlockd.rst | 4 +- docs/manpages/virtlogd.rst | 4 +- 6 files changed, 320 insertions(+), 320 deletions(-) diff --git a/docs/manpages/libvirtd.rst b/docs/manpages/libvirtd.rst index b7489a57fc..4125604f9a 100644 --- a/docs/manpages/libvirtd.rst +++ b/docs/manpages/libvirtd.rst @@ -199,7 +199,7 @@ EXAMPLES To retrieve the version of libvirtd: -.. code-block:: shell +.. code-block:: # libvirtd --version libvirtd (libvirt) 0.8.2 @@ -207,7 +207,7 @@ To retrieve the version of libvirtd: To start libvirtd, instructing it to daemonize and create a PID file: -.. code-block:: shell +.. code-block:: # libvirtd -d # ls -la RUNSTATEDIR/libvirtd.pid diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index e9d6deaee1..e063b76641 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -38,7 +38,7 @@ KVM, LXC, OpenVZ, VirtualBox and VMware ESX. The basic structure of most virsh usage is: -.. code-block:: shell +.. code-block:: virsh [OPTION]... <command> <domain> [ARG]... @@ -214,7 +214,7 @@ help **Syntax:** -.. code-block:: shell +.. code-block:: help [command-or-group] @@ -228,7 +228,7 @@ group as an option. For example: **Example 1:** -.. code-block:: shell +.. code-block:: virsh # help host @@ -250,7 +250,7 @@ option instead. For example: **Example 2:** -.. code-block:: shell +.. code-block:: virsh # help list NAME @@ -272,7 +272,7 @@ quit, exit **Syntax:** -.. code-block:: shell +.. code-block:: quit exit @@ -286,7 +286,7 @@ version **Syntax:** -.. code-block:: shell +.. code-block:: version [--daemon] @@ -296,7 +296,7 @@ is included in the output. **Example:** -.. code-block:: shell +.. code-block:: $ virsh version Compiled against library: libvirt 1.2.3 @@ -317,7 +317,7 @@ cd **Syntax:** -.. code-block:: shell +.. code-block:: cd [directory] @@ -334,7 +334,7 @@ pwd **Syntax:** -.. code-block:: shell +.. code-block:: pwd @@ -347,7 +347,7 @@ connect **Syntax:** -.. code-block:: shell +.. code-block:: connect [URI] [--readonly] @@ -388,7 +388,7 @@ uri **Syntax:** -.. code-block:: shell +.. code-block:: uri @@ -400,7 +400,7 @@ hostname **Syntax:** -.. code-block:: shell +.. code-block:: hostname @@ -412,7 +412,7 @@ sysinfo **Syntax:** -.. code-block:: shell +.. code-block:: sysinfo @@ -424,7 +424,7 @@ nodeinfo **Syntax:** -.. code-block:: shell +.. code-block:: nodeinfo @@ -440,7 +440,7 @@ nodecpumap **Syntax:** -.. code-block:: shell +.. code-block:: nodecpumap [--pretty] @@ -456,7 +456,7 @@ nodecpustats **Syntax:** -.. code-block:: shell +.. code-block:: nodecpustats [cpu] [--percent] @@ -471,7 +471,7 @@ nodememstats **Syntax:** -.. code-block:: shell +.. code-block:: nodememstats [cell] @@ -484,7 +484,7 @@ nodesuspend **Syntax:** -.. code-block:: shell +.. code-block:: nodesuspend [target] [duration] @@ -503,7 +503,7 @@ node **Syntax:** -.. code-block:: shell +.. code-block:: node-memory-tune [shm-pages-to-scan] [shm-sleep-millisecs] [shm-merge-across-nodes] @@ -525,7 +525,7 @@ capabilities **Syntax:** -.. code-block:: shell +.. code-block:: capabilities @@ -545,7 +545,7 @@ domcapabilities **Syntax:** -.. code-block:: shell +.. code-block:: domcapabilities [virttype] [emulatorbin] [arch] [machine] @@ -588,7 +588,7 @@ pool-capabilities **Syntax:** -.. code-block:: shell +.. code-block:: pool-capabilities @@ -605,7 +605,7 @@ inject **Syntax:** -.. code-block:: shell +.. code-block:: inject-nmi domain @@ -617,7 +617,7 @@ list **Syntax:** -.. code-block:: shell +.. code-block:: list [--inactive | --all] [--managed-save] [--title] @@ -637,7 +637,7 @@ specified it prints out information about running domains. An example format for the list is as follows: -.. code-block:: shell +.. code-block:: ``virsh`` list Id Name State @@ -775,7 +775,7 @@ printed in an extra column. This flag is usable only with the default **Example 2:** -.. code-block:: shell +.. code-block:: $ virsh list --title Id Name State Title @@ -790,7 +790,7 @@ freecell **Syntax:** -.. code-block:: shell +.. code-block:: freecell [{ [--cellno] cellno | --all }] @@ -809,7 +809,7 @@ freepages **Syntax:** -.. code-block:: shell +.. code-block:: freepages [{ [--cellno] cellno [--pagesize] pagesize | --all }] @@ -824,7 +824,7 @@ allocpages **Syntax:** -.. code-block:: shell +.. code-block:: allocpages [--pagesize] pagesize [--pagecount] pagecount [[--cellno] cellno] [--add] [--all] @@ -843,7 +843,7 @@ cpu-baseline **Syntax:** -.. code-block:: shell +.. code-block:: cpu-baseline FILE [--features] [--migratable] @@ -864,7 +864,7 @@ cpu-compare **Syntax:** -.. code-block:: shell +.. code-block:: cpu-compare FILE [--error] @@ -890,7 +890,7 @@ cpu-models **Syntax:** -.. code-block:: shell +.. code-block:: cpu-models arch @@ -909,7 +909,7 @@ echo **Syntax:** -.. code-block:: shell +.. code-block:: echo [--shell] [--xml] [err...] [arg...] @@ -926,7 +926,7 @@ hypervisor-cpu-compare **Syntax:** -.. code-block:: shell +.. code-block:: hypervisor-cpu-compare FILE [virttype] [emulator] [arch] [machine] [--error] @@ -958,7 +958,7 @@ hypervisor-cpu-baseline **Syntax:** -.. code-block:: shell +.. code-block:: hypervisor-cpu-baseline FILE [virttype] [emulator] [arch] [machine] [--features] [--migratable] @@ -1005,7 +1005,7 @@ autostart **Syntax:** -.. code-block:: shell +.. code-block:: autostart [--disable] domain @@ -1020,7 +1020,7 @@ blkdeviotune **Syntax:** -.. code-block:: shell +.. code-block:: blkdeviotune domain device [[--config] [--live] | [--current]] [[total-bytes-sec] | [read-bytes-sec] [write-bytes-sec]] @@ -1102,7 +1102,7 @@ blkiotune **Syntax:** -.. code-block:: shell +.. code-block:: blkiotune domain [--weight weight] [--device-weights device-weights] [--device-read-iops-sec device-read-iops-sec] @@ -1163,7 +1163,7 @@ blockcommit **Syntax:** -.. code-block:: shell +.. code-block:: blockcommit domain path [bandwidth] [--bytes] [base] [--shallow] [top] [--delete] [--keep-relative] @@ -1221,7 +1221,7 @@ blockcopy **Syntax:** -.. code-block:: shell +.. code-block:: blockcopy domain path { dest [format] [--blockdev] | --xml file } [--shallow] [--reuse-external] [bandwidth] @@ -1293,7 +1293,7 @@ blockjob **Syntax:** -.. code-block:: shell +.. code-block:: blockjob domain path { [--abort] [--async] [--pivot] | [--info] [--raw] [--bytes] | [bandwidth] } @@ -1343,7 +1343,7 @@ blockpull **Syntax:** -.. code-block:: shell +.. code-block:: blockpull domain path [bandwidth] [--bytes] [base] [--wait [--verbose] [--timeout seconds] [--async]] @@ -1384,7 +1384,7 @@ blockresize **Syntax:** -.. code-block:: shell +.. code-block:: blockresize domain path size @@ -1405,7 +1405,7 @@ console **Syntax:** -.. code-block:: shell +.. code-block:: console domain [devname] [--safe] [--force] @@ -1426,7 +1426,7 @@ cpu-stats **Syntax:** -.. code-block:: shell +.. code-block:: cpu-stats domain [--total] [start] [count] @@ -1442,7 +1442,7 @@ create **Syntax:** -.. code-block:: shell +.. code-block:: create FILE [--console] [--paused] [--autodestroy] [--pass-fds N,M,...] [--validate] @@ -1473,7 +1473,7 @@ is only supported with container based virtualization. #. prepare a template from an existing domain (skip directly to 3a if writing one from scratch) - .. code-block:: shell + .. code-block:: # virsh dumpxml <domain> > domain.xml @@ -1482,7 +1482,7 @@ is only supported with container based virtualization. a. DO CHANGE! <name> and <uuid> (<uuid> can also be removed), or b. DON'T CHANGE! either <name> or <uuid> - .. code-block:: shell + .. code-block:: # $EDITOR domain.xml @@ -1493,7 +1493,7 @@ is only supported with container based virtualization. b. an existing persistent domain will run with a modified one-time configuration - .. code-block:: shell + .. code-block:: # virsh create domain.xml @@ -1503,7 +1503,7 @@ define **Syntax:** -.. code-block:: shell +.. code-block:: define FILE [--validate] @@ -1519,7 +1519,7 @@ desc **Syntax:** -.. code-block:: shell +.. code-block:: desc domain [[--live] [--config] | [--current]] [--title] [--edit] [--new-desc @@ -1551,7 +1551,7 @@ destroy **Syntax:** -.. code-block:: shell +.. code-block:: destroy domain [--graceful] @@ -1579,7 +1579,7 @@ domblkerror **Syntax:** -.. code-block:: shell +.. code-block:: domblkerror domain @@ -1595,7 +1595,7 @@ domblkinfo **Syntax:** -.. code-block:: shell +.. code-block:: domblkinfo domain [block-device --all] [--human] @@ -1615,7 +1615,7 @@ domblklist **Syntax:** -.. code-block:: shell +.. code-block:: domblklist domain [--inactive] [--details] @@ -1635,7 +1635,7 @@ domblkstat **Syntax:** -.. code-block:: shell +.. code-block:: domblkstat domain [block-device] [--human] @@ -1672,7 +1672,7 @@ domblkthreshold **Syntax:** -.. code-block:: shell +.. code-block:: domblkthreshold domain dev threshold @@ -1687,7 +1687,7 @@ domcontrol **Syntax:** -.. code-block:: shell +.. code-block:: domcontrol domain @@ -1701,7 +1701,7 @@ domdisplay **Syntax:** -.. code-block:: shell +.. code-block:: domdisplay domain [--include-password] [[--type] type] [--all] @@ -1718,7 +1718,7 @@ domfsfreeze **Syntax:** -.. code-block:: shell +.. code-block:: domfsfreeze domain [[--mountpoint] mountpoint...] @@ -1740,7 +1740,7 @@ domfsinfo **Syntax:** -.. code-block:: shell +.. code-block:: domfsinfo domain @@ -1757,7 +1757,7 @@ domfsthaw **Syntax:** -.. code-block:: shell +.. code-block:: domfsthaw domain [[--mountpoint] mountpoint...] @@ -1774,7 +1774,7 @@ domfstrim **Syntax:** -.. code-block:: shell +.. code-block:: domfstrim domain [--minimum bytes] [--mountpoint mountPoint] @@ -1795,7 +1795,7 @@ domhostname **Syntax:** -.. code-block:: shell +.. code-block:: domhostname domain @@ -1807,7 +1807,7 @@ domid **Syntax:** -.. code-block:: shell +.. code-block:: domid domain-name-or-uuid @@ -1819,7 +1819,7 @@ domif **Syntax:** -.. code-block:: shell +.. code-block:: domif-getlink domain interface-device [--config] @@ -1835,7 +1835,7 @@ domif **Syntax:** -.. code-block:: shell +.. code-block:: domif-setlink domain interface-device state [--config] @@ -1851,7 +1851,7 @@ domifaddr **Syntax:** -.. code-block:: shell +.. code-block:: domifaddr domain [interface] [--full] [--source lease|agent|arp] @@ -1878,7 +1878,7 @@ backup-begin **Syntax:** -.. code-block:: shell +.. code-block:: backup-begin domain [backupxml] [checkpointxml] [--reuse-external] @@ -1912,7 +1912,7 @@ backup-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: backup-dumpxml domain @@ -1924,7 +1924,7 @@ domiflist **Syntax:** -.. code-block:: shell +.. code-block:: domiflist domain [--inactive] @@ -1941,7 +1941,7 @@ domifstat **Syntax:** -.. code-block:: shell +.. code-block:: domifstat domain interface-device @@ -1958,7 +1958,7 @@ domiftune **Syntax:** -.. code-block:: shell +.. code-block:: domiftune domain interface-device [[--config] [--live] | [--current]] [*--inbound average,peak,burst,floor*] @@ -1992,7 +1992,7 @@ dominfo **Syntax:** -.. code-block:: shell +.. code-block:: dominfo domain @@ -2004,7 +2004,7 @@ domjobabort **Syntax:** -.. code-block:: shell +.. code-block:: domjobabort domain @@ -2016,7 +2016,7 @@ domjobinfo **Syntax:** -.. code-block:: shell +.. code-block:: domjobinfo domain [--completed [--keep-completed]] [--anystats] [--rawstats] @@ -2043,7 +2043,7 @@ dommemstat **Syntax:** -.. code-block:: shell +.. code-block:: dommemstat domain [--period seconds] [[--config] [--live] | [--current]] @@ -2096,7 +2096,7 @@ domname **Syntax:** -.. code-block:: shell +.. code-block:: domname domain-id-or-uuid @@ -2108,7 +2108,7 @@ dompmsuspend **Syntax:** -.. code-block:: shell +.. code-block:: dompmsuspend domain target [--duration] @@ -2139,7 +2139,7 @@ dompmwakeup **Syntax:** -.. code-block:: shell +.. code-block:: dompmwakeup domain @@ -2154,7 +2154,7 @@ domrename **Syntax:** -.. code-block:: shell +.. code-block:: domrename domain new-name @@ -2169,7 +2169,7 @@ domstate **Syntax:** -.. code-block:: shell +.. code-block:: domstate domain [--reason] @@ -2182,7 +2182,7 @@ domstats **Syntax:** -.. code-block:: shell +.. code-block:: domstats [--raw] [--enforce] [--backing] [--nowait] [--state] [--cpu-total] [--balloon] [--vcpu] [--interface] @@ -2389,7 +2389,7 @@ domtime **Syntax:** -.. code-block:: shell +.. code-block:: domtime domain { [--now] [--pretty] [--sync] [--time time] } @@ -2414,7 +2414,7 @@ domuuid **Syntax:** -.. code-block:: shell +.. code-block:: domuuid domain-name-or-id @@ -2426,7 +2426,7 @@ domxml **Syntax:** -.. code-block:: shell +.. code-block:: domxml-from-native format config @@ -2444,7 +2444,7 @@ domxml **Syntax:** -.. code-block:: shell +.. code-block:: domxml-to-native format { [--xml] xml | --domain domain-name-or-id-or-uuid } @@ -2459,7 +2459,7 @@ dump **Syntax:** -.. code-block:: shell +.. code-block:: dump domain corefilepath [--bypass-cache] { [--live] | [--crash] | [--reset] } @@ -2501,7 +2501,7 @@ dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: dumpxml domain [--inactive] [--security-info] [--update-cpu] [--migratable] @@ -2522,7 +2522,7 @@ edit **Syntax:** -.. code-block:: shell +.. code-block:: edit domain @@ -2531,7 +2531,7 @@ next boot of the guest. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh dumpxml --inactive --security-info domain > domain.xml vi domain.xml (or make changes with your other text editor) @@ -2548,7 +2548,7 @@ emulatorpin **Syntax:** -.. code-block:: shell +.. code-block:: emulatorpin domain [cpulist] [[--live] [--config] | [--current]] @@ -2570,7 +2570,7 @@ event **Syntax:** -.. code-block:: shell +.. code-block:: event {[domain] { event | --all } [--loop] [--timeout seconds] [--timestamp] | --list} @@ -2597,7 +2597,7 @@ guest **Syntax:** -.. code-block:: shell +.. code-block:: guest-agent-timeout domain --timeout value @@ -2616,7 +2616,7 @@ guestinfo **Syntax:** -.. code-block:: shell +.. code-block:: guestinfo domain [--user] [--os] [--timezone] [--hostname] [--filesystem] @@ -2692,7 +2692,7 @@ guestvcpus **Syntax:** -.. code-block:: shell +.. code-block:: guestvcpus domain [[--enable] | [--disable]] [cpulist] @@ -2711,7 +2711,7 @@ iothreadadd **Syntax:** -.. code-block:: shell +.. code-block:: iothreadadd domain iothread_id [[--config] [--live] | [--current]] @@ -2731,7 +2731,7 @@ iothreaddel **Syntax:** -.. code-block:: shell +.. code-block:: iothreaddel domain iothread_id [[--config] [--live] | [--current]] @@ -2752,7 +2752,7 @@ iothreadinfo **Syntax:** -.. code-block:: shell +.. code-block:: iothreadinfo domain [[--live] [--config] | [--current]] @@ -2772,7 +2772,7 @@ iothreadpin **Syntax:** -.. code-block:: shell +.. code-block:: iothreadpin domain iothread cpulist [[--live] [--config] | [--current]] @@ -2805,7 +2805,7 @@ iothreadset **Syntax:** -.. code-block:: shell +.. code-block:: iothreadset domain iothread_id [[--poll-max-ns ns] [--poll-grow factor] [--poll-shrink divisor]] @@ -2836,7 +2836,7 @@ managedsave **Syntax:** -.. code-block:: shell +.. code-block:: managedsave domain [--bypass-cache] [{--running | --paused}] [--verbose] @@ -2865,7 +2865,7 @@ managedsave-define **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-define domain xml [{--running | --paused}] @@ -2885,7 +2885,7 @@ managedsave-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-dumpxml domain [--security-info] @@ -2899,7 +2899,7 @@ managedsave-edit **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-edit domain [{--running | --paused}] @@ -2913,7 +2913,7 @@ will allow overriding which state the ``restore`` should use. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh managedsave-dumpxml domain-name > state-file.xml vi state-file.xml (or make changes with your other text editor) @@ -2930,7 +2930,7 @@ managedsave-remove **Syntax:** -.. code-block:: shell +.. code-block:: managedsave-remove domain @@ -2943,7 +2943,7 @@ maxvcpus **Syntax:** -.. code-block:: shell +.. code-block:: maxvcpus [type] @@ -2957,7 +2957,7 @@ memtune **Syntax:** -.. code-block:: shell +.. code-block:: memtune domain [--hard-limit size] [--soft-limit size] [--swap-hard-limit size] [--min-guarantee size] [[--config] [--live] | [--current]] @@ -3015,7 +3015,7 @@ metadata **Syntax:** -.. code-block:: shell +.. code-block:: metadata domain [[--live] [--config] | [--current]] [--edit] [uri] [key] [set] [--remove] @@ -3054,7 +3054,7 @@ migrate **Syntax:** -.. code-block:: shell +.. code-block:: migrate [--live] [--offline] [--direct] [--p2p [--tunnelled]] [--persistent] [--undefinesource] [--suspend] [--copy-storage-all] @@ -3228,7 +3228,7 @@ connected to and needs to connect through a proxy, *graphicsuri* may be used to specify the address the client should connect to. The URI is formed as follows: -.. code-block:: shell +.. code-block:: protocol://hostname[:port]/[?parameters] @@ -3236,7 +3236,7 @@ where protocol is either "spice" or "vnc" and parameters is a list of protocol specific parameters separated by '&'. Currently recognized parameters are "tlsPort" and "tlsSubject". For example, -.. code-block:: shell +.. code-block:: spice://target.host.com:1234/?tlsPort=4567 @@ -3255,7 +3255,7 @@ migrate-compcache **Syntax:** -.. code-block:: shell +.. code-block:: migrate-compcache domain [--size bytes] @@ -3275,7 +3275,7 @@ migrate-getmaxdowntime **Syntax:** -.. code-block:: shell +.. code-block:: migrate-getmaxdowntime domain @@ -3290,7 +3290,7 @@ migrate-getspeed **Syntax:** -.. code-block:: shell +.. code-block:: migrate-getspeed domain [--postcopy] @@ -3304,7 +3304,7 @@ migrate-postcopy **Syntax:** -.. code-block:: shell +.. code-block:: migrate-postcopy domain @@ -3317,7 +3317,7 @@ migrate-setmaxdowntime **Syntax:** -.. code-block:: shell +.. code-block:: migrate-setmaxdowntime domain downtime @@ -3331,7 +3331,7 @@ migrate-setspeed **Syntax:** -.. code-block:: shell +.. code-block:: migrate-setspeed domain bandwidth [--postcopy] @@ -3349,7 +3349,7 @@ numatune **Syntax:** -.. code-block:: shell +.. code-block:: numatune domain [--mode mode] [--nodeset nodeset] [[--config] [--live] | [--current]] @@ -3378,7 +3378,7 @@ perf **Syntax:** -.. code-block:: shell +.. code-block:: perf domain [--enable eventSpec] [--disable eventSpec] [[--config] [--live] | [--current]] @@ -3466,7 +3466,7 @@ reboot **Syntax:** -.. code-block:: shell +.. code-block:: reboot domain [--mode MODE-LIST] @@ -3492,7 +3492,7 @@ reset **Syntax:** -.. code-block:: shell +.. code-block:: reset domain @@ -3508,7 +3508,7 @@ restore **Syntax:** -.. code-block:: shell +.. code-block:: restore state-file [--bypass-cache] [--xml file] [{--running | --paused}] @@ -3540,7 +3540,7 @@ resume **Syntax:** -.. code-block:: shell +.. code-block:: resume domain @@ -3554,7 +3554,7 @@ save **Syntax:** -.. code-block:: shell +.. code-block:: save domain state-file [--bypass-cache] [--xml file] [{--running | --paused}] [--verbose] @@ -3598,7 +3598,7 @@ save-image-define **Syntax:** -.. code-block:: shell +.. code-block:: save-image-define file xml [{--running | --paused}] @@ -3620,7 +3620,7 @@ save-image-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: save-image-dumpxml file [--security-info] @@ -3634,7 +3634,7 @@ save-image-edit **Syntax:** -.. code-block:: shell +.. code-block:: save-image-edit file [{--running | --paused}] @@ -3648,7 +3648,7 @@ will allow overriding which state the ``restore`` should use. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh save-image-dumpxml state-file > state-file.xml vi state-file.xml (or make changes with your other text editor) @@ -3665,7 +3665,7 @@ schedinfo **Syntax:** -.. code-block:: shell +.. code-block:: schedinfo domain [[--config] [--live] | [--current]] [[--set] parameter=value]... schedinfo [--weight number] [--cap number] domain @@ -3706,7 +3706,7 @@ screenshot **Syntax:** -.. code-block:: shell +.. code-block:: screenshot domain [imagefilepath] [--screen screenID] @@ -3723,7 +3723,7 @@ send-key **Syntax:** -.. code-block:: shell +.. code-block:: send-key domain [--codeset codeset] [--holdtime holdtime] keycode... @@ -3820,7 +3820,7 @@ distinct keypresses, you must use multiple send-key invocations. **Examples:** -.. code-block:: shell +.. code-block:: # send three strokes 'k', 'e', 'y', using xt codeset. these # are all pressed simultaneously and may be received by the guest @@ -3840,7 +3840,7 @@ send-process-signal **Syntax:** -.. code-block:: shell +.. code-block:: send-process-signal domain-id pid signame @@ -3851,7 +3851,7 @@ domain namespace. The *signame* argument may be either an integer signal constant number, or one of the symbolic names: -.. code-block:: shell +.. code-block:: "nop", "hup", "int", "quit", "ill", "trap", "abrt", "bus", "fpe", "kill", @@ -3871,7 +3871,7 @@ may be in uppercase or lowercase. **Examples:** -.. code-block:: shell +.. code-block:: virsh send-process-signal myguest 1 15 virsh send-process-signal myguest 1 term @@ -3884,7 +3884,7 @@ set-lifecycle-action **Syntax:** -.. code-block:: shell +.. code-block:: set-lifecycle-action domain type action [[--config] [--live] | [--current]] @@ -3901,7 +3901,7 @@ set-user-password **Syntax:** -.. code-block:: shell +.. code-block:: set-user-password domain user password [--encrypted] @@ -3919,7 +3919,7 @@ setmaxmem **Syntax:** -.. code-block:: shell +.. code-block:: setmaxmem domain size [[--config] [--live] | [--current]] @@ -3950,7 +3950,7 @@ setmem **Syntax:** -.. code-block:: shell +.. code-block:: setmem domain size [[--config] [--live] | [--current]] @@ -3985,7 +3985,7 @@ setvcpus **Syntax:** -.. code-block:: shell +.. code-block:: setvcpus domain count [--maximum] [[--config] [--live] | [--current]] [--guest] [--hotpluggable] @@ -4036,7 +4036,7 @@ setvcpu **Syntax:** -.. code-block:: shell +.. code-block:: setvcpu domain vcpulist [--enable] | [--disable] [[--live] [--config] | [--current]] @@ -4063,7 +4063,7 @@ shutdown **Syntax:** -.. code-block:: shell +.. code-block:: shutdown domain [--mode MODE-LIST] @@ -4095,7 +4095,7 @@ start **Syntax:** -.. code-block:: shell +.. code-block:: start domain-name-or-uuid [--console] [--paused] [--autodestroy] [--bypass-cache] [--force-boot] @@ -4124,7 +4124,7 @@ suspend **Syntax:** -.. code-block:: shell +.. code-block:: suspend domain @@ -4137,7 +4137,7 @@ ttyconsole **Syntax:** -.. code-block:: shell +.. code-block:: ttyconsole domain @@ -4150,7 +4150,7 @@ undefine **Syntax:** -.. code-block:: shell +.. code-block:: undefine domain [--managed-save] [--snapshots-metadata] [--checkpoints-metadata] [--nvram] [--keep-nvram] @@ -4216,7 +4216,7 @@ vcpucount **Syntax:** -.. code-block:: shell +.. code-block:: vcpucount domain [{--maximum | --active} {--config | --live | --current}] [--guest] @@ -4247,7 +4247,7 @@ vcpuinfo **Syntax:** -.. code-block:: shell +.. code-block:: vcpuinfo domain [--pretty] @@ -4258,7 +4258,7 @@ With *--pretty*, cpu affinities are shown as ranges. **Example:** -.. code-block:: shell +.. code-block:: $ virsh vcpuinfo fedora VCPU: 0 @@ -4311,7 +4311,7 @@ vcpupin **Syntax:** -.. code-block:: shell +.. code-block:: vcpupin domain [vcpu] [cpulist] [[--live] [--config] | [--current]] @@ -4339,7 +4339,7 @@ vncdisplay **Syntax:** -.. code-block:: shell +.. code-block:: vncdisplay domain @@ -4362,7 +4362,7 @@ attach-device **Syntax:** -.. code-block:: shell +.. code-block:: attach-device domain FILE [[[--live] [--config] | [--current]] | [--persistent]] @@ -4398,7 +4398,7 @@ attach-disk **Syntax:** -.. code-block:: shell +.. code-block:: attach-disk domain source target [[[--live] [--config] | [--current]] | [--persistent]] [--targetbus bus] @@ -4464,7 +4464,7 @@ attach-interface **Syntax:** -.. code-block:: shell +.. code-block:: attach-interface domain type source [[[--live] [--config] | [--current]] | [--persistent]] @@ -4555,7 +4555,7 @@ detach-device **Syntax:** -.. code-block:: shell +.. code-block:: detach-device domain FILE [[[--live] [--config] | [--current]] | [--persistent]] @@ -4601,7 +4601,7 @@ detach-device-alias **Syntax:** -.. code-block:: shell +.. code-block:: detach-device-alias domain alias [[[--live] [--config] | [--current]]]] @@ -4622,7 +4622,7 @@ detach-disk **Syntax:** -.. code-block:: shell +.. code-block:: detach-disk domain target [[[--live] [--config] | [--current]] | [--persistent]] [--print-xml] @@ -4655,7 +4655,7 @@ detach-interface **Syntax:** -.. code-block:: shell +.. code-block:: detach-interface domain type [--mac mac] [[[--live] [--config] | [--current]] | [--persistent]] @@ -4687,7 +4687,7 @@ update-device **Syntax:** -.. code-block:: shell +.. code-block:: update-device domain file [--force] [[[--live] [--config] | [--current]] | [--persistent]] @@ -4721,7 +4721,7 @@ change-media **Syntax:** -.. code-block:: shell +.. code-block:: change-media domain path [--eject] [--insert] [--update] [source] [--force] [[--live] [--config] | @@ -4791,7 +4791,7 @@ nodedev-create **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-create FILE @@ -4807,7 +4807,7 @@ nodedev-destroy **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-destroy device @@ -4822,7 +4822,7 @@ nodedev-detach **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-detach nodedev [--driver backend_driver] @@ -4842,7 +4842,7 @@ nodedev-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-dumpxml device @@ -4859,7 +4859,7 @@ nodedev-list **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-list cap --tree @@ -4878,7 +4878,7 @@ nodedev-reattach **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-reattach nodedev @@ -4893,7 +4893,7 @@ nodedev-reset **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-reset nodedev @@ -4908,7 +4908,7 @@ nodedev-event **Syntax:** -.. code-block:: shell +.. code-block:: nodedev-event {[nodedev] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -4944,7 +4944,7 @@ net-autostart **Syntax:** -.. code-block:: shell +.. code-block:: net-autostart network [--disable] @@ -4957,7 +4957,7 @@ net-create **Syntax:** -.. code-block:: shell +.. code-block:: net-create file @@ -4972,7 +4972,7 @@ net-define **Syntax:** -.. code-block:: shell +.. code-block:: net-define file @@ -4985,7 +4985,7 @@ net-destroy **Syntax:** -.. code-block:: shell +.. code-block:: net-destroy network @@ -4998,7 +4998,7 @@ net-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: net-dumpxml network [--inactive] @@ -5013,7 +5013,7 @@ net-edit **Syntax:** -.. code-block:: shell +.. code-block:: net-edit network @@ -5021,7 +5021,7 @@ Edit the XML configuration file for a network. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh net-dumpxml --inactive network > network.xml vi network.xml (or make changes with your other text editor) @@ -5038,7 +5038,7 @@ net-event **Syntax:** -.. code-block:: shell +.. code-block:: net-event {[network] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -5063,7 +5063,7 @@ net-info **Syntax:** -.. code-block:: shell +.. code-block:: net-info network @@ -5075,7 +5075,7 @@ net-list **Syntax:** -.. code-block:: shell +.. code-block:: net-list [--inactive | --all] { [--table] | --name | --uuid } @@ -5106,7 +5106,7 @@ net-name **Syntax:** -.. code-block:: shell +.. code-block:: net-name network-UUID @@ -5118,7 +5118,7 @@ net-start **Syntax:** -.. code-block:: shell +.. code-block:: net-start network @@ -5130,7 +5130,7 @@ net-undefine **Syntax:** -.. code-block:: shell +.. code-block:: net-undefine network @@ -5143,7 +5143,7 @@ net-uuid **Syntax:** -.. code-block:: shell +.. code-block:: net-uuid network-name @@ -5155,7 +5155,7 @@ net-update **Syntax:** -.. code-block:: shell +.. code-block:: net-update network command section xml [--parent-index index] [[--live] [--config] | [--current]] @@ -5202,7 +5202,7 @@ net-dhcp-leases **Syntax:** -.. code-block:: shell +.. code-block:: net-dhcp-leases network [mac] @@ -5227,7 +5227,7 @@ net-port-list **Syntax:** -.. code-block:: shell +.. code-block:: net-port-list { [--table] | --uuid } network @@ -5244,7 +5244,7 @@ net-port-create **Syntax:** -.. code-block:: shell +.. code-block:: net-port-create network file @@ -5257,7 +5257,7 @@ net-port-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: net-port-dumpxml network port @@ -5269,7 +5269,7 @@ net-port-delete **Syntax:** -.. code-block:: shell +.. code-block:: net-port-delete network port @@ -5298,7 +5298,7 @@ iface-bridge **Syntax:** -.. code-block:: shell +.. code-block:: iface-bridge interface bridge [--no-stp] [delay] [--no-start] @@ -5317,7 +5317,7 @@ iface-define **Syntax:** -.. code-block:: shell +.. code-block:: iface-define file @@ -5330,7 +5330,7 @@ iface-destroy **Syntax:** -.. code-block:: shell +.. code-block:: iface-destroy interface @@ -5343,7 +5343,7 @@ iface-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: iface-dumpxml interface [--inactive] @@ -5357,7 +5357,7 @@ iface-edit **Syntax:** -.. code-block:: shell +.. code-block:: iface-edit interface @@ -5365,7 +5365,7 @@ Edit the XML configuration file for a host interface. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh iface-dumpxml iface > iface.xml vi iface.xml (or make changes with your other text editor) @@ -5382,7 +5382,7 @@ iface-list **Syntax:** -.. code-block:: shell +.. code-block:: iface-list [--inactive | --all] @@ -5396,7 +5396,7 @@ iface-name **Syntax:** -.. code-block:: shell +.. code-block:: iface-name interface @@ -5411,7 +5411,7 @@ iface-mac **Syntax:** -.. code-block:: shell +.. code-block:: iface-mac interface @@ -5425,7 +5425,7 @@ iface-start **Syntax:** -.. code-block:: shell +.. code-block:: iface-start interface @@ -5437,7 +5437,7 @@ iface-unbridge **Syntax:** -.. code-block:: shell +.. code-block:: iface-unbridge bridge [--no-start] @@ -5455,7 +5455,7 @@ iface-undefine **Syntax:** -.. code-block:: shell +.. code-block:: iface-undefine interface @@ -5467,7 +5467,7 @@ iface-begin **Syntax:** -.. code-block:: shell +.. code-block:: iface-begin @@ -5485,7 +5485,7 @@ iface-commit **Syntax:** -.. code-block:: shell +.. code-block:: iface-commit @@ -5499,7 +5499,7 @@ iface-rollback **Syntax:** -.. code-block:: shell +.. code-block:: iface-rollback @@ -5525,7 +5525,7 @@ find-storage-pool-sources **Syntax:** -.. code-block:: shell +.. code-block:: find-storage-pool-sources type [srcSpec] @@ -5562,7 +5562,7 @@ find-pool-sources-as **Syntax:** -.. code-block:: shell +.. code-block:: find-storage-pool-sources-as type [host] [port] [initiator] @@ -5586,7 +5586,7 @@ pool-autostart **Syntax:** -.. code-block:: shell +.. code-block:: pool-autostart pool-or-uuid [--disable] @@ -5598,7 +5598,7 @@ pool-build **Syntax:** -.. code-block:: shell +.. code-block:: pool-build pool-or-uuid [--overwrite] [--no-overwrite] @@ -5640,7 +5640,7 @@ pool-create **Syntax:** -.. code-block:: shell +.. code-block:: pool-create file [--build] [[--overwrite] | [--no-overwrite]] @@ -5658,7 +5658,7 @@ pool-create-as **Syntax:** -.. code-block:: shell +.. code-block:: pool-create-as name type [--source-host hostname] [--source-path path] [--source-dev path] @@ -5744,7 +5744,7 @@ pool-define **Syntax:** -.. code-block:: shell +.. code-block:: pool-define file @@ -5757,7 +5757,7 @@ pool-define-as **Syntax:** -.. code-block:: shell +.. code-block:: pool-define-as name type [--source-host hostname] [--source-path path] [--source-dev path] @@ -5782,7 +5782,7 @@ pool-destroy **Syntax:** -.. code-block:: shell +.. code-block:: pool-destroy pool-or-uuid @@ -5797,7 +5797,7 @@ pool-delete **Syntax:** -.. code-block:: shell +.. code-block:: pool-delete pool-or-uuid @@ -5811,7 +5811,7 @@ pool-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: pool-dumpxml [--inactive] pool-or-uuid @@ -5825,7 +5825,7 @@ pool-edit **Syntax:** -.. code-block:: shell +.. code-block:: pool-edit pool-or-uuid @@ -5833,7 +5833,7 @@ Edit the XML configuration file for a storage pool. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh pool-dumpxml pool > pool.xml vi pool.xml (or make changes with your other text editor) @@ -5850,7 +5850,7 @@ pool-info **Syntax:** -.. code-block:: shell +.. code-block:: pool-info [--bytes] pool-or-uuid @@ -5863,7 +5863,7 @@ pool-list **Syntax:** -.. code-block:: shell +.. code-block:: pool-list [--inactive] [--all] [--persistent] [--transient] @@ -5903,7 +5903,7 @@ pool-name **Syntax:** -.. code-block:: shell +.. code-block:: pool-name uuid @@ -5915,7 +5915,7 @@ pool-refresh **Syntax:** -.. code-block:: shell +.. code-block:: pool-refresh pool-or-uuid @@ -5927,7 +5927,7 @@ pool-start **Syntax:** -.. code-block:: shell +.. code-block:: pool-start pool-or-uuid [--build] [[--overwrite] | [--no-overwrite]] @@ -5955,7 +5955,7 @@ pool-undefine **Syntax:** -.. code-block:: shell +.. code-block:: pool-undefine pool-or-uuid @@ -5967,7 +5967,7 @@ pool-uuid **Syntax:** -.. code-block:: shell +.. code-block:: pool-uuid pool @@ -5979,7 +5979,7 @@ pool-event **Syntax:** -.. code-block:: shell +.. code-block:: pool-event {[pool] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -6007,7 +6007,7 @@ vol-create **Syntax:** -.. code-block:: shell +.. code-block:: vol-create pool-or-uuid FILE [--prealloc-metadata] @@ -6026,7 +6026,7 @@ only slightly higher initial disk space usage. **Example:** -.. code-block:: shell +.. code-block:: virsh vol-dumpxml --pool storagepool1 appvolume1 > newvolume.xml vi newvolume.xml (or make changes with your other text editor) @@ -6038,7 +6038,7 @@ vol-create-from **Syntax:** -.. code-block:: shell +.. code-block:: vol-create-from pool-or-uuid FILE vol-name-or-key-or-path [--inputpool pool-or-uuid] [--prealloc-metadata] [--reflink] @@ -6069,7 +6069,7 @@ vol-create-as **Syntax:** -.. code-block:: shell +.. code-block:: vol-create-as pool-or-uuid name capacity [--allocation size] [--format string] [--backing-vol vol-name-or-key-or-path] @@ -6118,7 +6118,7 @@ vol-clone **Syntax:** -.. code-block:: shell +.. code-block:: vol-clone vol-name-or-key-or-path name [--pool pool-or-uuid] [--prealloc-metadata] [--reflink] @@ -6151,7 +6151,7 @@ vol-delete **Syntax:** -.. code-block:: shell +.. code-block:: vol-delete vol-name-or-key-or-path [--pool pool-or-uuid] [--delete-snapshots] @@ -6175,7 +6175,7 @@ vol-upload **Syntax:** -.. code-block:: shell +.. code-block:: vol-upload vol-name-or-key-or-path local-file [--pool pool-or-uuid] [--offset bytes] @@ -6213,7 +6213,7 @@ vol-download **Syntax:** -.. code-block:: shell +.. code-block:: vol-download vol-name-or-key-or-path local-file [--pool pool-or-uuid] [--offset bytes] [--length bytes] @@ -6244,7 +6244,7 @@ vol-wipe **Syntax:** -.. code-block:: shell +.. code-block:: vol-wipe vol-name-or-key-or-path [--pool pool-or-uuid] [--algorithm algorithm] @@ -6303,7 +6303,7 @@ vol-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: vol-dumpxml vol-name-or-key-or-path [--pool pool-or-uuid] @@ -6323,7 +6323,7 @@ vol-info **Syntax:** -.. code-block:: shell +.. code-block:: vol-info vol-name-or-key-or-path [--pool pool-or-uuid] [--bytes] [--physical] @@ -6352,7 +6352,7 @@ vol-list **Syntax:** -.. code-block:: shell +.. code-block:: vol-list [--pool pool-or-uuid] [--details] @@ -6369,7 +6369,7 @@ vol-pool **Syntax:** -.. code-block:: shell +.. code-block:: vol-pool vol-key-or-path [--uuid] @@ -6387,7 +6387,7 @@ vol-path **Syntax:** -.. code-block:: shell +.. code-block:: vol-path vol-name-or-key [--pool pool-or-uuid] @@ -6406,7 +6406,7 @@ vol-name **Syntax:** -.. code-block:: shell +.. code-block:: vol-name vol-key-or-path @@ -6420,7 +6420,7 @@ vol-key **Syntax:** -.. code-block:: shell +.. code-block:: vol-key vol-name-or-path [--pool pool-or-uuid] @@ -6440,7 +6440,7 @@ vol-resize **Syntax:** -.. code-block:: shell +.. code-block:: vol-resize vol-name-or-path capacity [--pool pool-or-uuid] [--allocate] [--delta] [--shrink] @@ -6485,7 +6485,7 @@ secret-define **Syntax:** -.. code-block:: shell +.. code-block:: secret-define file @@ -6500,7 +6500,7 @@ secret-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: secret-dumpxml secret @@ -6512,7 +6512,7 @@ secret-event **Syntax:** -.. code-block:: shell +.. code-block:: secret-event {[secret] event [--loop] [--timeout seconds] [--timestamp] | --list} @@ -6537,7 +6537,7 @@ secret-set-value **Syntax:** -.. code-block:: shell +.. code-block:: secret-set-value secret base64 @@ -6550,7 +6550,7 @@ secret-get-value **Syntax:** -.. code-block:: shell +.. code-block:: secret-get-value secret @@ -6563,7 +6563,7 @@ secret-undefine **Syntax:** -.. code-block:: shell +.. code-block:: secret-undefine secret @@ -6577,7 +6577,7 @@ secret-list **Syntax:** -.. code-block:: shell +.. code-block:: secret-list [--ephemeral] [--no-ephemeral] [--private] [--no-private] @@ -6604,7 +6604,7 @@ snapshot-create **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-create domain [xmlfile] {[--redefine [--current]] | [--no-metadata] [--halt] [--disk-only] [--reuse-external] @@ -6685,7 +6685,7 @@ snapshot-create-as **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-create-as domain {[--print-xml] [--no-metadata] [--halt] [--reuse-external]} [name] @@ -6723,7 +6723,7 @@ all three of *domain*, *name*, and *description* are also present. For example, a diskspec of "vda,snapshot=external,file=/path/to,,new" results in the following XML: -.. code-block:: xml +.. code-block:: <disk name='vda' snapshot='external'> <source file='/path/to,new'/> @@ -6766,7 +6766,7 @@ snapshot-current **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-current domain {[--name] | [--security-info] | [snapshotname]} @@ -6785,7 +6785,7 @@ snapshot-edit **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-edit domain [snapshotname] [--current] {[--rename] | [--clone]} @@ -6797,7 +6797,7 @@ snapshot. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh snapshot-dumpxml dom name > snapshot.xml vi snapshot.xml (or make changes with your other text editor) @@ -6822,7 +6822,7 @@ snapshot-info **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-info domain {snapshot | --current} @@ -6835,7 +6835,7 @@ snapshot-list **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-list domain [--metadata] [--no-metadata] [{--parent | --roots | [{--tree | --name}]}] [--topological] @@ -6904,7 +6904,7 @@ snapshot-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-dumpxml domain snapshot [--security-info] @@ -6918,7 +6918,7 @@ snapshot-parent **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-parent domain {snapshot | --current} @@ -6931,7 +6931,7 @@ snapshot-revert **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-revert domain {snapshot | --current} [{--running | --paused}] [--force] @@ -6972,7 +6972,7 @@ snapshot-delete **Syntax:** -.. code-block:: shell +.. code-block:: snapshot-delete domain {snapshot | --current} [--metadata] [{--children | --children-only}] @@ -7006,7 +7006,7 @@ checkpoint-create **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-create domain [xmlfile] { --redefine | [--quiesce]} @@ -7045,7 +7045,7 @@ checkpoint-create-as **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-create-as domain [--print-xml] [name] [description] [--quiesce] [--diskspec] diskspec]... @@ -7065,7 +7065,7 @@ all three of *domain*, *name*, and *description* are also present. For example, a diskspec of "vda,checkpoint=bitmap,bitmap=map1" results in the following XML: -.. code-block:: xml +.. code-block:: <disk name='vda' checkpoint='bitmap' bitmap='map1'/> @@ -7083,7 +7083,7 @@ checkpoint-edit **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-edit domain checkpointname @@ -7091,7 +7091,7 @@ Edit the XML configuration file for *checkpointname* of a domain. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh checkpoint-dumpxml dom name > checkpoint.xml vi checkpoint.xml (or make changes with your other text editor) @@ -7109,7 +7109,7 @@ checkpoint-info **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-info domain checkpoint @@ -7121,7 +7121,7 @@ checkpoint-list **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-list domain [{--parent | --roots | [{--tree | --name}]}] [--topological] @@ -7167,7 +7167,7 @@ checkpoint-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-dumpxml domain checkpoint [--security-info] [--no-domain] [--size] @@ -7187,7 +7187,7 @@ checkpoint-parent **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-parent domain checkpoint @@ -7199,7 +7199,7 @@ checkpoint **Syntax:** -.. code-block:: shell +.. code-block:: checkpoint-delete domain checkpoint [--metadata] [{--children | --children-only}] @@ -7236,7 +7236,7 @@ nwfilter-define **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-define xmlfile @@ -7253,7 +7253,7 @@ nwfilter-undefine **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-undefine nwfilter-name @@ -7266,7 +7266,7 @@ nwfilter-list **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-list @@ -7278,7 +7278,7 @@ nwfilter-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-dumpxml nwfilter-name @@ -7290,7 +7290,7 @@ nwfilter-edit **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-edit nwfilter-name @@ -7298,7 +7298,7 @@ Edit the XML of a network filter. This is equivalent to: -.. code-block:: shell +.. code-block:: virsh nwfilter-dumpxml myfilter > myfilter.xml vi myfilter.xml (or make changes with your other text editor) @@ -7329,7 +7329,7 @@ nwfilter-binding-create **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-create xmlfile @@ -7348,7 +7348,7 @@ nwfilter-binding-delete **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-delete port-name @@ -7366,7 +7366,7 @@ nwfilter-binding-list **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-list @@ -7378,7 +7378,7 @@ nwfilter-binding-dumpxml **Syntax:** -.. code-block:: shell +.. code-block:: nwfilter-binding-dumpxml port-name @@ -7402,7 +7402,7 @@ qemu-attach **Syntax:** -.. code-block:: shell +.. code-block:: qemu-attach pid @@ -7411,7 +7411,7 @@ The QEMU process must have been created with a monitor connection using the UNIX driver. Ideally the process will also have had the '-name' argument specified. -.. code-block:: shell +.. code-block:: $ qemu-kvm -cdrom ~/demo.iso \ -monitor unix:/tmp/demo,server,nowait \ @@ -7432,7 +7432,7 @@ qemu-monitor-command **Syntax:** -.. code-block:: shell +.. code-block:: qemu-monitor-command domain { [--hmp] | [--pretty] } command... @@ -7451,7 +7451,7 @@ qemu-agent-command **Syntax:** -.. code-block:: shell +.. code-block:: qemu-agent-command domain [--timeout seconds | --async | --block] command... @@ -7469,7 +7469,7 @@ qemu-monitor-event **Syntax:** -.. code-block:: shell +.. code-block:: qemu-monitor-event [domain] [--event event-name] [--loop] [--timeout seconds] [--pretty] [--regex] [--no-case] @@ -7500,7 +7500,7 @@ lxc-enter-namespace **Syntax:** -.. code-block:: shell +.. code-block:: lxc-enter-namespace domain [--noseclabel] -- /path/to/binary [arg1, [arg2, ...]] diff --git a/docs/manpages/virt-admin.rst b/docs/manpages/virt-admin.rst index bf42139f30..51c3d3917e 100644 --- a/docs/manpages/virt-admin.rst +++ b/docs/manpages/virt-admin.rst @@ -28,7 +28,7 @@ as for monitoring and managing all clients connected to the daemon. The basic structure of most virt-admin usage is: -.. code-block:: shell +.. code-block:: virt-admin [OPTION]... <command> [ARG]... @@ -107,7 +107,7 @@ help **Syntax:** -.. code-block:: shell +.. code-block:: help [command-or-group] @@ -124,7 +124,7 @@ quit, exit **Syntax:** -.. code-block:: shell +.. code-block:: quit exit @@ -136,7 +136,7 @@ version **Syntax:** -.. code-block:: shell +.. code-block:: version @@ -146,7 +146,7 @@ the version of the daemon. **Example:** -.. code-block:: shell +.. code-block:: $ virt-admin version Compiled against library: libvirt 1.2.21 @@ -160,7 +160,7 @@ cd **Syntax:** -.. code-block:: shell +.. code-block:: cd [directory] @@ -175,7 +175,7 @@ pwd **Syntax:** -.. code-block:: shell +.. code-block:: pwd @@ -187,7 +187,7 @@ connect **Syntax:** -.. code-block:: shell +.. code-block:: connect [URI] @@ -206,7 +206,7 @@ uri **Syntax:** -.. code-block:: shell +.. code-block:: uri @@ -230,7 +230,7 @@ server-list **Syntax:** -.. code-block:: shell +.. code-block:: server-list @@ -243,7 +243,7 @@ daemon-log-filters **Syntax:** -.. code-block:: shell +.. code-block:: daemon-log-filters [--filters string] @@ -264,7 +264,7 @@ space. Each filter must conform to the form described in detail by To define a filter which suppresses all e.g. 'virObjectUnref' DEBUG messages, use the following: -.. code-block:: shell +.. code-block:: $ virt-admin daemon-log-filters "4:util.object" @@ -277,7 +277,7 @@ daemon-log-outouts **Syntax:** -.. code-block:: shell +.. code-block:: daemon-log-outputs [--outputs string] @@ -298,13 +298,13 @@ space. Each output must conform to the form described in detail by To replace the current setting for logging outputs with one that writes to a file while logging errors only, the following could be used: -.. code-block:: shell +.. code-block:: $ virt-admin daemon-log-outputs "4:file:<absolute_path_to_the_file>" To define multiple outputs at once they need to be delimited by spaces: -.. code-block:: shell +.. code-block:: $ virt-admin daemon-log-outputs "4:stderr 2:syslog:<msg_ident>" @@ -320,7 +320,7 @@ server-threadpool-info **Syntax:** -.. code-block:: shell +.. code-block:: server-threadpool-info server @@ -355,7 +355,7 @@ that, unlike tasks carried out by normal workers, are within libvirt's full control and libvirt guarantees that such a task cannot hang, thus will always finish. An example of such a task this would be destroying a domain: -.. code-block:: shell +.. code-block:: $ virsh destroy <domain>. @@ -365,7 +365,7 @@ server-threadpool-set **Syntax:** -.. code-block:: shell +.. code-block:: server-threadpool-set server [--min-workers count] [--max-workers count] [--priority-workers count] @@ -394,7 +394,7 @@ server-clients-info **Syntax:** -.. code-block:: shell +.. code-block:: server-clients-info server @@ -407,7 +407,7 @@ runtime values, more specifically, the current number of clients connected to **Example:** -.. code-block:: shell +.. code-block:: # virt-admin server-clients-info libvirtd nclients_max : 120 @@ -421,7 +421,7 @@ server-clients-set **Syntax:** -.. code-block:: shell +.. code-block:: server-clients-set server [--max-clients count] [--max-unauth-clients count] @@ -457,7 +457,7 @@ client-list **Syntax:** -.. code-block:: shell +.. code-block:: client-list server @@ -471,7 +471,7 @@ client-info **Syntax:** -.. code-block:: shell +.. code-block:: client-info server client @@ -487,7 +487,7 @@ enabled within daemon). **Examples:** -.. code-block:: shell +.. code-block:: # virt-admin client-info libvirtd 1 id : 1 @@ -513,7 +513,7 @@ client-disconnect **Syntax:** -.. code-block:: shell +.. code-block:: client-disconnect server client diff --git a/docs/manpages/virt-login-shell.rst b/docs/manpages/virt-login-shell.rst index 4716493f87..3833a3e912 100644 --- a/docs/manpages/virt-login-shell.rst +++ b/docs/manpages/virt-login-shell.rst @@ -29,7 +29,7 @@ configured in ``/etc/libvirt/virt-login-shell.conf``. The basic structure of most ``virt-login-shell`` usage is: -.. code-block:: shell +.. code-block:: virt-login-shell diff --git a/docs/manpages/virtlockd.rst b/docs/manpages/virtlockd.rst index 4066934e42..1dc106d6fc 100644 --- a/docs/manpages/virtlockd.rst +++ b/docs/manpages/virtlockd.rst @@ -120,14 +120,14 @@ EXAMPLES To retrieve the version of ``virtlockd``: -.. code-block:: shell +.. code-block:: # virtlockd --version virtlockd (libvirt) 1.1.1 To start ``virtlockd``, instructing it to daemonize and create a PID file: -.. code-block:: shell +.. code-block:: # virtlockd -d # ls -la RUNSTATEDIR/virtlockd.pid diff --git a/docs/manpages/virtlogd.rst b/docs/manpages/virtlogd.rst index 7f4c5d7e7f..c84ab2e621 100644 --- a/docs/manpages/virtlogd.rst +++ b/docs/manpages/virtlogd.rst @@ -121,14 +121,14 @@ EXAMPLES To retrieve the version of ``virtlogd``: -.. code-block:: shell +.. code-block:: # virtlogd --version virtlogd (libvirt) 1.1.1 To start ``virtlogd``, instructing it to daemonize and create a PID file: -.. code-block:: shell +.. code-block:: # virtlogd -d # ls -la RUNSTATEDIR/virtlogd.pid -- 2.23.0

1 1

[libvirt] [jenkins-ci PATCH 0/2] Add glibc-langpack-en to the mappings & to the base project
by Fabiano Fidêncio 12 Dec '19

12 Dec '19

As done for locales, lets also add glibc-langpack-en to the mappings and to the base project. The reasoning for that is that (at least) osinfo-db tests set the locale to en_US causing errors like: 1215 INTERNALERROR> Traceback (most recent call last): 1216 INTERNALERROR> File "/usr/lib/python3.6/site-packages/_pytest/main.py", line 96, in wrap_session 1217 INTERNALERROR> config._do_configure() 1218 INTERNALERROR> File "/usr/lib/python3.6/site-packages/_pytest/config.py", line 922, in _do_configure 1219 INTERNALERROR> self.hook.pytest_configure.call_historic(kwargs=dict(config=self)) 1220 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 628, in call_historic 1221 INTERNALERROR> res = self._hookexec(self, self._nonwrappers + self._wrappers, kwargs) 1222 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 222, in _hookexec 1223 INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs) 1224 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/__init__.py", line 216, in <lambda> 1225 INTERNALERROR> firstresult=hook.spec_opts.get('firstresult'), 1226 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 201, in _multicall 1227 INTERNALERROR> return outcome.get_result() 1228 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 76, in get_result 1229 INTERNALERROR> raise ex[1].with_traceback(ex[2]) 1230 INTERNALERROR> File "/usr/lib/python3.6/site-packages/pluggy/callers.py", line 180, in _multicall 1231 INTERNALERROR> res = hook_impl.function(*args) 1232 INTERNALERROR> File "/builds/fidencio/osinfo-db/tests/conftest.py", line 27, in pytest_configure 1233 INTERNALERROR> locale.setlocale(locale.LC_CTYPE, 'en_US.UTF-8') 1234 INTERNALERROR> File "/usr/lib64/python3.6/locale.py", line 598, in setlocale 1235 INTERNALERROR> return _setlocale(category, locale) 1236 INTERNALERROR> locale.Error: unsupported locale setting 1237 make: *** [../Makefile:124: check] Error 3 Fabiano Fidêncio (2): mappings: Add glibc-langpack-en guests: Add glibc-langpack-en to the base project guests/vars/mappings.yml | 5 +++++ guests/vars/projects/base.yml | 1 + 2 files changed, 6 insertions(+) -- 2.23.0

2 4

[libvirt] [jenkins-ci PATCH] jenkins: Don't build on CentOS 8 just yet
by Andrea Bolognani 12 Dec '19

12 Dec '19

We're currently waiting to see whether we can get more capacity for our CI environment, and in the meantime we've decided not do create additional builders on the existing machine. In order to be able to deploy other configuration changes without enabling CentOS 8 jobs at the same time, we need to temporarily drop all mentions of the target from the Jenkins configuration: once we've figured out where to create the CentOS 8 builder, we can simply revert this patch. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- jenkins/jobs/defaults.yaml | 2 -- jenkins/projects/libosinfo.yaml | 1 - jenkins/projects/libvirt-dbus.yaml | 2 -- jenkins/projects/libvirt.yaml | 1 - jenkins/projects/osinfo-db-tools.yaml | 1 - jenkins/projects/virt-manager.yaml | 3 --- 6 files changed, 10 deletions(-) diff --git a/jenkins/jobs/defaults.yaml b/jenkins/jobs/defaults.yaml index 9232d42..676ecbf 100644 --- a/jenkins/jobs/defaults.yaml +++ b/jenkins/jobs/defaults.yaml @@ -4,7 +4,6 @@ node: libvirt all_machines: - libvirt-centos-7 - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -14,7 +13,6 @@ - libvirt-freebsd-12 rpm_machines: - libvirt-centos-7 - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/libosinfo.yaml b/jenkins/projects/libosinfo.yaml index cc7e024..819c5ac 100644 --- a/jenkins/projects/libosinfo.yaml +++ b/jenkins/projects/libosinfo.yaml @@ -15,7 +15,6 @@ # RPM build is still not possible on CentOS7 as it does not # have the needed RPM macros for meson. machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/libvirt-dbus.yaml b/jenkins/projects/libvirt-dbus.yaml index e71e2f9..dfc159c 100644 --- a/jenkins/projects/libvirt-dbus.yaml +++ b/jenkins/projects/libvirt-dbus.yaml @@ -15,7 +15,6 @@ # Python3 version in Ubuntu 16.04 and python3-pytest version # in CentOS 7 are too old. machines: - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -26,7 +25,6 @@ # RPM build is still not possible on CentOS7 as it does not # have the needed RPM macros for meson. machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/libvirt.yaml b/jenkins/projects/libvirt.yaml index fa8fb89..fdc24bc 100644 --- a/jenkins/projects/libvirt.yaml +++ b/jenkins/projects/libvirt.yaml @@ -14,7 +14,6 @@ # commands with more arguments than FreeBSD supports machines: - libvirt-centos-7 - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 diff --git a/jenkins/projects/osinfo-db-tools.yaml b/jenkins/projects/osinfo-db-tools.yaml index 7831df4..f28e72f 100644 --- a/jenkins/projects/osinfo-db-tools.yaml +++ b/jenkins/projects/osinfo-db-tools.yaml @@ -15,7 +15,6 @@ # RPM build is still not possible on CentOS7 as it does not # have the needed RPM macros for meson. machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide diff --git a/jenkins/projects/virt-manager.yaml b/jenkins/projects/virt-manager.yaml index 9c4c3bf..4524831 100644 --- a/jenkins/projects/virt-manager.yaml +++ b/jenkins/projects/virt-manager.yaml @@ -3,7 +3,6 @@ name: virt-manager # CentOS 7 and Ubuntu 16.04 have Python 3 but not the libxml2 bindings machines: - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -27,7 +26,6 @@ # so skip the test suite there for the time being. See # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224902 machines: - - libvirt-centos-8 - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 @@ -36,7 +34,6 @@ - python-distutils-rpm-job: parent_jobs: 'virt-manager-check' machines: - - libvirt-centos-8 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide -- 2.23.0

3 5

[libvirt] [PATCH v2 0/1] qemu: fix crash bug in snapshot revert
by Pavel Mores 12 Dec '19

12 Dec '19

This is a significant rework of v1 as - patch 1 was dropped because an equivalent change was accidentally committed in the meantime in 4c53267b70fc5c548b6530113c3f96870d8d7fc1 - patch 2 was dropped as it was just a mostly formal clean-up of patch 1 - patch 3 was redone using a different approach. Patch 3 now takes the approach that was hinted at in the last paragraph of v1's cover letter, more specifically it now fixes qemuProcessStop() rather than its caller. Digging into git history I located the commit that introduced qemuProcessStop()'s problematic behaviour and after consulting with Michal, we agreed that fixing qemuProcessStop() seems safe enough, and definitely a better solution conceptually. Pavel Mores (1): qemu: fix concurrency crash bug in snapshot revert src/qemu/qemu_domain.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) -- 2.21.0

3 3

[libvirt] [libvirt-tck PATCH] Add cases for nvram
by Dan Zheng 12 Dec '19

12 Dec '19

This is to add the tests for below flags: - Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM - Sys::Virt::Domain::UNDEFINE_NVRAM Signed-off-by: Dan Zheng <dzheng(a)redhat.com> --- scripts/domain/401-ovmf-nvram.t | 143 ++++++++++++++++++++++++++++++++ 1 file changed, 143 insertions(+) create mode 100644 scripts/domain/401-ovmf-nvram.t diff --git a/scripts/domain/401-ovmf-nvram.t b/scripts/domain/401-ovmf-nvram.t new file mode 100644 index 0000000..5310dd0 --- /dev/null +++ b/scripts/domain/401-ovmf-nvram.t @@ -0,0 +1,143 @@ +# -*- perl -*- +# +# Copyright (C) 2009 Red Hat, Inc. +# Copyright (C) 2018 Dan Zheng (dzheng(a)redhat.com) +# +# This program is free software; You can redistribute it and/or modify +# it under the GNU General Public License as published by the Free +# Software Foundation; either version 2, or (at your option) any +# later version +# +# The file "LICENSE" distributed along with this file provides full +# details of the terms and conditions +# + +=pod + +=head1 NAME + +domain/401-ovmf-nvram.t - Test OVMF related functions and flags + +=head1 DESCRIPTION + +The test cases validates OVMF related APIs and flags + +Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM +Sys::Virt::Domain::UNDEFINE_NVRAM + +=cut + +use strict; +use warnings; + +use Test::More tests => 8; + +use Sys::Virt::TCK; +use File::stat; +use File::Copy; + + +my $tck = Sys::Virt::TCK->new(); +my $conn = eval { $tck->setup(); }; +BAIL_OUT "failed to setup test harness: $@" if $@; +END { $tck->cleanup if $tck; } + + +sub setup_nvram { + +my $loader_path = shift; +my $nvram_template = shift; +my $nvram_path = shift; + +# Install OVMF and check the two files should exist +# - /usr/share/OVMF/OVMF_CODE.secboot.fd +# - /usr/share/OVMF/OVMF_VARS.fd + +my $ret = `yum install -y OVMF`; +diag "yum install OVMF: $ret"; +my $st = stat($loader_path); +ok($st, "path $loader_path exists after OVMF is installed"); +$st = stat($nvram_template); +ok($st, "path $nvram_template exists after OVMF is installed"); + +# Ensure the sample nvram file exists +copy($nvram_template, $nvram_path) or die "Copy failed: $!"; + +# Use 'q35' as machine type and add below lines to guest xml +# <loader readonly='yes' secure='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.secboot.fd</loader> +# <nvram template='/usr/share/OVMF/OVMF_VARS.fd'>/var/lib/libvirt/qemu/nvram/test_VARS.fd</nvram> + +my $xml = $tck->generic_domain(name => "tck")->as_xml; +my $xp = XML::XPath->new($xml); +diag $xp->getNodeText("/domain/os/type/\@machine"); + +diag "Changing guest machine type to q35"; +$xp->setNodeText("/domain/os/type/\@machine", "q35"); + +my $loader_node = XML::XPath::Node::Element->new('loader'); +my $loader_text = XML::XPath::Node::Text->new($loader_path); +my $attr_ro = XML::XPath::Node::Attribute->new('readonly'); +my $attr_secure = XML::XPath::Node::Attribute->new('secure'); +my $attr_type = XML::XPath::Node::Attribute->new('type'); + +$attr_ro -> setNodeValue('yes'); +$attr_secure -> setNodeValue('yes'); +$attr_type -> setNodeValue('pflash'); + +$loader_node->appendChild($loader_text); +$loader_node->appendAttribute($attr_ro); +$loader_node->appendAttribute($attr_secure); +$loader_node->appendAttribute($attr_type); + +my $nvram_node = XML::XPath::Node::Element->new('nvram'); +my $nvram_text = XML::XPath::Node::Text->new($nvram_path); +my $attr_template = XML::XPath::Node::Attribute->new('template'); + +$attr_template -> setNodeValue($nvram_template); + +$nvram_node->appendChild($nvram_text); +$nvram_node->appendAttribute($attr_template); + +my $smm_node = XML::XPath::Node::Element->new('smm'); +my $attr_state = XML::XPath::Node::Attribute->new('state'); +$attr_state -> setNodeValue("on"); +$smm_node -> appendAttribute($attr_state); + +my ($root) = $xp->findnodes('/domain/os'); +$root->appendChild($loader_node); +$root->appendChild($nvram_node); +($root) = $xp->findnodes('/domain/features'); +$root->appendChild($smm_node); + +$xml = $xp->findnodes_as_string('/'); +diag $xml; +return $xml; +} + +diag "Defining an inactive domain config with nvram"; +my $loader_file_path = '/usr/share/OVMF/OVMF_CODE.secboot.fd'; +my $nvram_file_template = '/usr/share/OVMF/OVMF_VARS.fd'; +my $nvram_file_path = '/var/lib/libvirt/qemu/nvram/test_VARS.fd'; + +my $xml = setup_nvram($loader_file_path, $nvram_file_template, $nvram_file_path); +my $dom; + +diag "Test Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +diag "Checking nvram file already exists"; +my $st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' exists as expected"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_KEEP_NVRAM); +diag "Checking nvram file still exists"; +$st = stat($nvram_file_path); +ok($st, "File '$nvram_file_path' still exists as expected"); + +diag "Test Sys::Virt::Domain::UNDEFINE_NVRAM"; +ok_domain(sub { $dom = $conn->define_domain($xml) }, "defined domain with nvram configure"); +$dom->undefine(Sys::Virt::Domain::UNDEFINE_NVRAM); +diag "Checking nvram file removed"; +$st = stat($nvram_file_path); +ok(!$st, "File '$nvram_file_path' is removed"); + +ok_error(sub { $conn->get_domain_by_name("tck") }, "NO_DOMAIN error raised from missing domain", + Sys::Virt::Error::ERR_NO_DOMAIN); -- 2.18.1

1 0

[libvirt] [PATCH] ci: Fix VPATH builds
by Andrea Bolognani 12 Dec '19

12 Dec '19

The CI build machinery is intentionally not handled by autotools, so for VPATH builds - which are mandatory now - we need to make sure we're looking into $(srcdir). Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index 15df6ed68e..4edb3fdd43 100644 --- a/Makefile.am +++ b/Makefile.am @@ -148,4 +148,4 @@ gen-AUTHORS: fi ci-%: - $(MAKE) -C ci/ $@ + $(MAKE) -C $(srcdir)/ci/ $@ -- 2.23.0

2 1

[libvirt] [dockerfiles PATCH] Add CentOS 8 Dockerfiles
by Andrea Bolognani 12 Dec '19

12 Dec '19

The corresponding libvirt-jenkins-ci commit is b7cd4b07a064. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. Text diff follows. buildenv-libosinfo-centos-8.zip | Bin 0 -> 578 bytes buildenv-libvirt-centos-8.zip | Bin 0 -> 781 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 buildenv-libosinfo-centos-8.zip create mode 100644 buildenv-libvirt-centos-8.zip diff --git a/buildenv-libosinfo-centos-8.zip b/buildenv-libosinfo-centos-8.zip new file mode 100644 index 0000000..e739059 --- /dev/null +++ b/buildenv-libosinfo-centos-8.zip @@ -0,0 +1,55 @@ +FROM centos:centos8 + +RUN dnf update -y && \ + dnf install 'dnf-command(config-manager)' -y && \ + dnf config-manager --set-enabled PowerTools -y && \ + dnf install -y epel-release && \ + dnf install -y \ + autoconf \ + automake \ + bash \ + bash-completion \ + ca-certificates \ + check-devel \ + chrony \ + gcc \ + gdb \ + gettext \ + gettext-devel \ + git \ + glib2-devel \ + glibc-devel \ + gobject-introspection-devel \ + gtk-doc \ + hwdata \ + intltool \ + json-glib-devel \ + libarchive-devel \ + libsoup-devel \ + libtool \ + libxml2 \ + libxml2-devel \ + libxslt-devel \ + lsof \ + make \ + meson \ + net-tools \ + ninja-build \ + patch \ + perl \ + pkgconfig \ + python3 \ + python3-lxml \ + python3-pytest \ + python3-requests \ + python3-setuptools \ + rpm-build \ + screen \ + strace \ + sudo \ + vala \ + vim && \ + dnf autoremove -y && \ + dnf clean all -y + +ENV LANG "en_US.UTF-8" diff --git a/buildenv-libvirt-centos-8.zip b/buildenv-libvirt-centos-8.zip new file mode 100644 index 0000000..5410201 --- /dev/null +++ b/buildenv-libvirt-centos-8.zip @@ -0,0 +1,93 @@ +FROM centos:centos8 + +RUN dnf update -y && \ + dnf install 'dnf-command(config-manager)' -y && \ + dnf config-manager --set-enabled PowerTools -y && \ + dnf install -y epel-release && \ + dnf install -y \ + audit-libs-devel \ + augeas \ + autoconf \ + automake \ + avahi-devel \ + bash \ + bash-completion \ + ca-certificates \ + chrony \ + cyrus-sasl-devel \ + dbus-devel \ + device-mapper-devel \ + dnsmasq \ + ebtables \ + fuse-devel \ + gcc \ + gdb \ + gettext \ + gettext-devel \ + git \ + glib2-devel \ + glibc-devel \ + glusterfs-api-devel \ + gnutls-devel \ + iproute \ + iproute-tc \ + iscsi-initiator-utils \ + kmod \ + libacl-devel \ + libattr-devel \ + libblkid-devel \ + libcap-ng-devel \ + libcurl-devel \ + libiscsi-devel \ + libnl3-devel \ + libpcap-devel \ + libpciaccess-devel \ + librbd-devel \ + libselinux-devel \ + libssh-devel \ + libtirpc-devel \ + libtool \ + libudev-devel \ + libwsman-devel \ + libxml2 \ + libxml2-devel \ + libxslt \ + lsof \ + lvm2 \ + make \ + meson \ + ncurses-devel \ + net-tools \ + netcf-devel \ + nfs-utils \ + ninja-build \ + numactl-devel \ + numad \ + parted \ + parted-devel \ + patch \ + perl \ + pkgconfig \ + polkit \ + python3 \ + python3-docutils \ + python3-flake8 \ + python3-setuptools \ + qemu-img \ + radvd \ + readline-devel \ + rpcgen \ + rpm-build \ + sanlock-devel \ + screen \ + scrub \ + strace \ + sudo \ + systemtap-sdt-devel \ + vim \ + xfsprogs-devel \ + yajl-devel && \ + dnf autoremove -y && \ + dnf clean all -y + +ENV LANG "en_US.UTF-8" -- 2.23.0

1 0

[libvirt] [dockerfiles PATCH] Refresh Dockerfiles after dropping Python 2 support
by Andrea Bolognani 12 Dec '19

12 Dec '19

The corresponding libvirt-jenkins-ci commit is 8c30b5e1782b. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. Text diff follows. buildenv-libosinfo-centos-7.zip | Bin 575 -> 572 bytes buildenv-libvirt-centos-7.zip | Bin 765 -> 761 bytes 2 files changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libosinfo-centos-7.zip b/buildenv-libosinfo-centos-7.zip index c9dd791..b91f3aa 100644 --- a/buildenv-libosinfo-centos-7.zip +++ b/buildenv-libosinfo-centos-7.zip @@ -36,7 +36,6 @@ RUN yum update -y && \ patch \ perl \ pkgconfig \ - python2-setuptools \ python3 \ python3-pip \ python3-setuptools \ diff --git a/buildenv-libvirt-centos-7.zip b/buildenv-libvirt-centos-7.zip index 5fc4f71..4e9c3db 100644 --- a/buildenv-libvirt-centos-7.zip +++ b/buildenv-libvirt-centos-7.zip @@ -67,7 +67,6 @@ RUN yum update -y && \ perl \ pkgconfig \ polkit \ - python2-setuptools \ python3 \ python3-pip \ python3-setuptools \ -- 2.23.0

1 0

[libvirt] [jenkins-ci PATCH] Run the virt-manager test suite on FreeBSD
by Andrea Bolognani 12 Dec '19

12 Dec '19

The bug affecting python3-libxml2 has been fixed in FreeBSD, and virt-manager itself has recently tweaked its test suite so that it works correctly on that platform as well. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/build/projects/virt-manager.yml | 6 +++--- jenkins/projects/virt-manager.yaml | 5 ++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/guests/playbooks/build/projects/virt-manager.yml b/guests/playbooks/build/projects/virt-manager.yml index 9184a74..9286931 100644 --- a/guests/playbooks/build/projects/virt-manager.yml +++ b/guests/playbooks/build/projects/virt-manager.yml @@ -23,9 +23,6 @@ $PYTHON ./setup.py configure --prefix=$VIRT_PREFIX - include: '{{ playbook_base }}/jobs/python-distutils-check-job.yml' vars: - # libxml2's Python 3 bindings don't work properly on FreeBSD, - # so skip the test suite there for the time being. See - # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224902 machines: - libvirt-debian-9 - libvirt-debian-10 @@ -33,6 +30,9 @@ - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 + - libvirt-freebsd-current - libvirt-ubuntu-1804 - include: '{{ playbook_base }}/jobs/python-distutils-rpm-job.yml' vars: diff --git a/jenkins/projects/virt-manager.yaml b/jenkins/projects/virt-manager.yaml index 4524831..b027f21 100644 --- a/jenkins/projects/virt-manager.yaml +++ b/jenkins/projects/virt-manager.yaml @@ -22,15 +22,14 @@ $PYTHON ./setup.py configure --prefix=$VIRT_PREFIX - python-distutils-check-job: parent_jobs: 'virt-manager-build' - # libxml2's Python 3 bindings don't work properly on FreeBSD, - # so skip the test suite there for the time being. See - # https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224902 machines: - libvirt-debian-9 - libvirt-debian-10 - libvirt-fedora-30 - libvirt-fedora-31 - libvirt-fedora-rawhide + - libvirt-freebsd-11 + - libvirt-freebsd-12 - python-distutils-rpm-job: parent_jobs: 'virt-manager-check' machines: -- 2.23.0

2 1

[libvirt] [PATCH] docs: ensure outputfile is deleted if rst2html/rst2man fail
by Daniel P. Berrangé 11 Dec '19

11 Dec '19

This avoids leaving a zero length or partially generated output file on errors. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/Makefile.am | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/Makefile.am b/docs/Makefile.am index eb8de80b9c..9a1f7a6117 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -259,21 +259,21 @@ man8_MANS = $(manpages8_rst:%.rst=%.8) grep -v '^\.\. contents::' < $< | \ sed -e 's|SYSCONFDIR|$(sysconfdir)|g' \ -e 's|RUNSTATEDIR|$(runstatedir)|g' | \ - $(RST2MAN) > $@ + $(RST2MAN) > $@ || { rm $@ && exit 1; } %.7: %.rst $(AM_V_GEN)$(MKDIR_P) `dirname $@` && \ grep -v '^\.\. contents::' < $< | \ sed -e 's|SYSCONFDIR|$(sysconfdir)|g' \ -e 's|RUNSTATEDIR|$(runstatedir)|g' | \ - $(RST2MAN) > $@ + $(RST2MAN) > $@ || { rm $@ && exit 1; } %.8: %.rst $(AM_V_GEN)$(MKDIR_P) `dirname $@` && \ grep -v '^\.\. contents::' < $< | \ sed -e 's|SYSCONFDIR|$(sysconfdir)|g' \ -e 's|RUNSTATEDIR|$(runstatedir)|g' | \ - $(RST2MAN) > $@ + $(RST2MAN) > $@ || { rm $@ && exit 1; } manpages/virkeycode-%.rst: $(top_srcdir)/src/keycodemapdb/data/keymaps.csv \ $(top_srcdir)/src/keycodemapdb/tools/keymap-gen Makefile.am @@ -414,11 +414,11 @@ manpages/%.html.in: manpages/%.rst grep -v '^:Manual ' < $< | \ sed -e 's|SYSCONFDIR|$(sysconfdir)|g' \ -e 's|RUNSTATEDIR|$(runstatedir)|g' | \ - $(RST2HTML) > $@ + $(RST2HTML) > $@ || { rm $@ && exit 1; } %.html.in: %.rst $(AM_V_GEN)$(MKDIR_P) `dirname $@` && \ - $(RST2HTML) $< > $@ + $(RST2HTML) $< > $@ || { rm $@ && exit 1; } %.html.tmp: %.html.in site.xsl subsite.xsl page.xsl \ $(acl_generated) -- 2.23.0

2 3

[libvirt] [PATCH] doc: vtpm only support secrets by UUID at this point
by marcandre.lureau＠redhat.com 11 Dec '19

11 Dec '19

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Support by usage name can be considered separately (with a 'usage' attribute?). Cc: Stefan Berger <stefanb(a)linux.ibm.com> Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- docs/formatsecret.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/formatsecret.html.in b/docs/formatsecret.html.in index 8d0630a7c3..8f5383cf64 100644 --- a/docs/formatsecret.html.in +++ b/docs/formatsecret.html.in @@ -334,8 +334,8 @@ Secret value set of the vTPM. The <code><usage type='vtpm'></code> element must contain a single <code>name</code> element that specifies a usage name - for the secret. The vTPM secret can then be used by UUID or by - this usage name via the <code><encryption></code> element of + for the secret. The vTPM secret can then be used by UUID + via the <code><encryption></code> element of a <a href="formatdomain.html#elementsTpm">tpm</a> when using an emulator. <span class="since">Since 5.6.0</span>. The following is an example -- 2.24.0.308.g228f53135a

4 3

[libvirt] [PATCH] travis: Update name for Ubuntu 18.04 image
by Andrea Bolognani 11 Dec '19

11 Dec '19

The corresponding libvirt-jenkins-ci commit is f289e64a5fd9. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b47f54553e..44ff5e9898 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,7 +21,7 @@ matrix: - services: - docker env: - - IMAGE="ubuntu-18" + - IMAGE="ubuntu-1804" - MAKE_ARGS="syntax-check distcheck" script: - make -C ci/ ci-build@$IMAGE CI_MAKE_ARGS="$MAKE_ARGS" -- 2.23.0

1 0

[libvirt] [PATCH] qemu: keep capabilities when running QEMU as root
by Daniel P. Berrangé 11 Dec '19

11 Dec '19

When QEMU uid/gid is set to non-root this is pointless as if we just used a regular setuid/setgid call, the process will have all its capabilities cleared anyway by the kernel. When QEMU uid/gid is set to root, this is almost (always?) never what people actually want. People make QEMU run as root in order to access some privileged resource that libvirt doesn't support yet and this often requires capabilities. As a result they have to go find the qemu.conf param to turn this off. This is not viable for libguestfs - they want to control everything via the XML security label to request running as root regardless of the qemu.conf settings for user/group. Clearing capabilities was implemented originally because there was a proposal in Fedora to change permissions such that root, with no capabilities would not be able to compromise the system. ie a locked down root account. This never went anywhere though, and as a result clearing capabilities when running as root does not really get us any security benefit AFAICT. The root user can easily do something like create a cronjob, which will then faithfully be run with full capabilities, trivially bypassing the restriction we place. IOW, our clearing of capabilities is both useless from a security POV, and breaks valid use cases when people need to run as root. This removes the clear_emulator_capabilities configuration option from qemu.conf, and always runs QEMU with capabilities when root. The behaviour when non-root is unchanged. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/drvqemu.html.in | 46 +++++++++++------------------- src/qemu/libvirtd_qemu.aug | 8 +++++- src/qemu/qemu.conf | 11 ------- src/qemu/qemu_conf.c | 4 --- src/qemu/qemu_conf.h | 1 - src/qemu/qemu_domain.c | 3 +- src/qemu/qemu_process.c | 5 ---- src/qemu/test_libvirtd_qemu.aug.in | 1 - 8 files changed, 25 insertions(+), 54 deletions(-) diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in index 294117ee1f..8beb28655c 100644 --- a/docs/drvqemu.html.in +++ b/docs/drvqemu.html.in @@ -187,41 +187,29 @@ chmod o+x /path/to/directory </li> </ul> - <h3><a id="securitycap">Linux process capabilities</a></h3> - <p> - The libvirt QEMU driver has a build time option allowing it to use - the <a href="http://people.redhat.com/sgrubb/libcap-ng/index.html">libcap-ng</a> - library to manage process capabilities. If this build option is - enabled, then the QEMU driver will use this to ensure that all - process capabilities are dropped before executing a QEMU virtual - machine. Process capabilities are what gives the 'root' account - its high power, in particular the CAP_DAC_OVERRIDE capability - is what allows a process running as 'root' to access files owned - by any user. + The libvirt maintainers <strong>strongly recommend against</strong> + running QEMU as the root user/group. This should not be required + in most supported usage scenarios, as libvirt will generally do the + right thing to grant QEMU access to files it is permitted to + use when it is running non-root. </p> + <h3><a id="securitycap">Linux process capabilities</a></h3> + <p> - If the QEMU driver is configured to run virtual machines as non-root, - then they will already lose all their process capabilities at time - of startup. The Linux capability feature is thus aimed primarily at - the scenario where the QEMU processes are running as root. In this - case, before launching a QEMU virtual machine, libvirtd will use - libcap-ng APIs to drop all process capabilities. It is important - for administrators to note that this implies the QEMU process will - <strong>only</strong> be able to access files owned by root, and - not files owned by any other user. + In versions of libvirt prior to 6.0.0, even if QEMU was configured + to run as the root user / group, libvirt would strip all process + capabilities. This meant that QEMU could only read/write files + owned by root, or with open permissions. In reality, stripping + capabilities did not have any security benefit, as it was trivial + to get commands to run in another context with full capabilities, + for example, by creating a cronjob. </p> - <p> - Thus, if a vendor / distributor has configured their libvirt package - to run as 'qemu' by default, a number of changes will be required - before an administrator can change a host to run guests as root. - In particular it will be necessary to change ownership on the - directories <code>/var/run/libvirt/qemu/</code>, - <code>/var/lib/libvirt/qemu/</code> and - <code>/var/cache/libvirt/qemu/</code> back to root, in addition - to changing the <code>/etc/libvirt/qemu.conf</code> settings. + Thus since 6.0.0, if QEMU is running as root, it will keep all + process capabilities. Behaviour when QEMU is running non-root + is unchanged, it still has no capabilities. </p> <h3><a id="securityselinux">SELinux basic confinement</a></h3> diff --git a/src/qemu/libvirtd_qemu.aug b/src/qemu/libvirtd_qemu.aug index 7d7844dc09..86bea2a32a 100644 --- a/src/qemu/libvirtd_qemu.aug +++ b/src/qemu/libvirtd_qemu.aug @@ -86,7 +86,6 @@ module Libvirtd_qemu = | bool_entry "auto_start_bypass_cache" let process_entry = str_entry "hugetlbfs_mount" - | bool_entry "clear_emulator_capabilities" | str_entry "bridge_helper" | str_entry "pr_helper" | str_entry "slirp_helper" @@ -129,6 +128,12 @@ module Libvirtd_qemu = let swtpm_entry = str_entry "swtpm_user" | str_entry "swtpm_group" + (* Entries that used to exist in the config which are now + * deleted. We keep on parsing them so we don't break + * ability to parse old configs after upgrade + *) + let obsolete_entry = bool_entry "clear_emulator_capabilities" + let capability_filters_entry = str_array_entry "capability_filters" (* Each entry in the config is one of the following ... *) @@ -153,6 +158,7 @@ module Libvirtd_qemu = | nbd_entry | swtpm_entry | capability_filters_entry + | obsolete_entry let comment = [ label "#comment" . del /#[ \t]*/ "# " . store /([^ \t\n][^\n]*)?/ . del /\n/ "\n" ] let empty = [ label "#empty" . eol ] diff --git a/src/qemu/qemu.conf b/src/qemu/qemu.conf index 7a056b037e..b6805ffc41 100644 --- a/src/qemu/qemu.conf +++ b/src/qemu/qemu.conf @@ -583,17 +583,6 @@ #bridge_helper = "/usr/libexec/qemu-bridge-helper" - -# If clear_emulator_capabilities is enabled, libvirt will drop all -# privileged capabilities of the QEMU/KVM emulator. This is enabled by -# default. -# -# Warning: Disabling this option means that a compromised guest can -# exploit the privileges and possibly do damage to the host. -# -#clear_emulator_capabilities = 1 - - # If enabled, libvirt will have QEMU set its process name to # "qemu:VM_NAME", where VM_NAME is the name of the VM. The QEMU # process will appear as "qemu:VM_NAME" in process listings and diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 30637b21ac..0e14d60bc9 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -234,8 +234,6 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged) cfg->prHelperName = g_strdup(QEMU_PR_HELPER); cfg->slirpHelperName = g_strdup(QEMU_SLIRP_HELPER); - cfg->clearEmulatorCapabilities = true; - cfg->securityDefaultConfined = true; cfg->securityRequireConfined = false; @@ -602,8 +600,6 @@ virQEMUDriverConfigLoadProcessEntry(virQEMUDriverConfigPtr cfg, } } - if (virConfGetValueBool(conf, "clear_emulator_capabilities", &cfg->clearEmulatorCapabilities) < 0) - return -1; if (virConfGetValueString(conf, "bridge_helper", &cfg->bridgeHelperName) < 0) return -1; diff --git a/src/qemu/qemu_conf.h b/src/qemu/qemu_conf.h index 95b33a1093..a641bbd983 100644 --- a/src/qemu/qemu_conf.h +++ b/src/qemu/qemu_conf.h @@ -161,7 +161,6 @@ struct _virQEMUDriverConfig { bool relaxedACS; bool vncAllowHostAudio; bool nogfxAllowHostAudio; - bool clearEmulatorCapabilities; bool setProcessName; unsigned int maxProcesses; diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 470d342afc..0dadca4894 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -9345,8 +9345,7 @@ void qemuDomainObjCheckTaint(virQEMUDriverPtr driver, bool custom_hypervisor_feat = false; if (virQEMUDriverIsPrivileged(driver) && - (!cfg->clearEmulatorCapabilities || - cfg->user == 0 || + (cfg->user == 0 || cfg->group == 0)) qemuDomainObjTaint(driver, obj, VIR_DOMAIN_TAINT_HIGH_PRIVILEGES, logCtxt); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 75ee3893c6..979ea36f0f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6811,11 +6811,6 @@ qemuProcessLaunch(virConnectPtr conn, if (qemuDomainCreateNamespace(driver, vm) < 0) goto cleanup; - VIR_DEBUG("Clear emulator capabilities: %d", - cfg->clearEmulatorCapabilities); - if (cfg->clearEmulatorCapabilities) - virCommandClearCaps(cmd); - VIR_DEBUG("Setting up raw IO"); if (qemuProcessSetupRawIO(driver, vm, cmd) < 0) goto cleanup; diff --git a/src/qemu/test_libvirtd_qemu.aug.in b/src/qemu/test_libvirtd_qemu.aug.in index b9cf8d6688..dd90edf687 100644 --- a/src/qemu/test_libvirtd_qemu.aug.in +++ b/src/qemu/test_libvirtd_qemu.aug.in @@ -72,7 +72,6 @@ module Test_libvirtd_qemu = { "auto_start_bypass_cache" = "0" } { "hugetlbfs_mount" = "/dev/hugepages" } { "bridge_helper" = "/usr/libexec/qemu-bridge-helper" } -{ "clear_emulator_capabilities" = "1" } { "set_process_name" = "1" } { "max_processes" = "0" } { "max_files" = "0" } -- 2.21.0

2 3

[libvirt] [jenkins-ci PATCH v2 0/3] Enable building of the VZ driver on CentOS 7
by Daniel P. Berrangé 11 Dec '19

11 Dec '19

The VZ driver in libvirt periodically gets broken by refactoring in libvirt. This is not noticed either before or after merge because none of our CI tests nor common developer build hosts includ the deps needed for the VZ driver. The OpenVZ project, however, does provide builds of the required packages for RHEL-7. We can use these packages in our CentOS 7 CI VMs to enable build testing of the VZ driver. This closes the only hole we have in driver build coverage for CI. Changed in v2: - Enable GPG verification - Use older repo avoid temporary deps problem - Setup repos in dockerfile too. Daniel P. Berrangé (3): guests: add openvz repository on CentOS 7 guests: define mapping for the libprlsdk package guests: add libprlsdk package to libvirt project guests/lcitool | 22 ++++++++++++++++ guests/playbooks/update/tasks/base.yml | 25 +++++++++++++++++++ guests/playbooks/update/templates/openvz.key | 20 +++++++++++++++ .../playbooks/update/templates/openvz.repo.j2 | 9 +++++++ guests/vars/mappings.yml | 4 +++ guests/vars/projects/libvirt.yml | 1 + 6 files changed, 81 insertions(+) create mode 100644 guests/playbooks/update/templates/openvz.key create mode 100644 guests/playbooks/update/templates/openvz.repo.j2 -- 2.23.0

2 7

[libvirt] [dockerfiles PATCH] Rename Ubuntu Dockerfiles
by Andrea Bolognani 11 Dec '19

11 Dec '19

The corresponding libvirt-jenkins-ci commit is f289e64a5fd9. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed as trivial. ...ntu-16.zip => buildenv-libosinfo-ubuntu-1604.zip | Bin ...ntu-18.zip => buildenv-libosinfo-ubuntu-1804.zip | Bin ...buntu-16.zip => buildenv-libvirt-ubuntu-1604.zip | Bin ...buntu-18.zip => buildenv-libvirt-ubuntu-1804.zip | Bin 4 files changed, 0 insertions(+), 0 deletions(-) rename buildenv-libosinfo-ubuntu-16.zip => buildenv-libosinfo-ubuntu-1604.zip (100%) rename buildenv-libosinfo-ubuntu-18.zip => buildenv-libosinfo-ubuntu-1804.zip (100%) rename buildenv-libvirt-ubuntu-16.zip => buildenv-libvirt-ubuntu-1604.zip (100%) rename buildenv-libvirt-ubuntu-18.zip => buildenv-libvirt-ubuntu-1804.zip (100%) diff --git a/buildenv-libosinfo-ubuntu-16.zip b/buildenv-libosinfo-ubuntu-1604.zip similarity index 100% rename from buildenv-libosinfo-ubuntu-16.zip rename to buildenv-libosinfo-ubuntu-1604.zip diff --git a/buildenv-libosinfo-ubuntu-18.zip b/buildenv-libosinfo-ubuntu-1804.zip similarity index 100% rename from buildenv-libosinfo-ubuntu-18.zip rename to buildenv-libosinfo-ubuntu-1804.zip diff --git a/buildenv-libvirt-ubuntu-16.zip b/buildenv-libvirt-ubuntu-1604.zip similarity index 100% rename from buildenv-libvirt-ubuntu-16.zip rename to buildenv-libvirt-ubuntu-1604.zip diff --git a/buildenv-libvirt-ubuntu-18.zip b/buildenv-libvirt-ubuntu-1804.zip similarity index 100% rename from buildenv-libvirt-ubuntu-18.zip rename to buildenv-libvirt-ubuntu-1804.zip -- 2.23.0

1 0