- Devel - libvirt List Archives

Entering freeze for libvirt-6.2.0
by Daniel Veillard 27 Mar '20

27 Mar '20

I forgot to announce plans, sorry about this, entering freeze now I hope there isn't too many pending patchestargetting this release. The plan would be to push the RC2 on Tuesday with a release on April 2nd if everything goes fine. You can find the signed tarball and source rpm at the usual place: https://libvirt.org/sources/ the rc1 is also tagged in git. Please give it a try, so we can have a normal release, in those time of pandemy, take care, stay safe, thanks ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt PATCH 0/5] QEMU: support QEMU built without TCG
by Tobin Feldman-Fitzthum 27 Mar '20

27 Mar '20

Since version 2.10, QEMU can be built without TCG. This patch adds capabillity QEMU_CAPS_TCG_DISABLED that allows libvirt to use a QEMU built without TCG. Rather than create a capability that is set whenever TCG is enabled (almost always), QEMU_CAPS_TCG_DISABLED is set only when the TCG is not available. This avoids some issues with backwards compatability. For a domain that was created using QEMU >= 2.10 with KVM, there is no information in the cached XML file that says whether or not TCG was enabled. Versions of QEMU older than 2.10 do not have a QMP interface for determining whether QEMU is available. Since QEMU_CAPS_TCG_DISABLED is set only when TCG is disabled, we do not have to do any extra work to infer an appropriate value in either of these cases. QEMU_CAPS_TCG_DISABLED is set via QMP command qom-list-types. Tobin Feldman-Fitzthum (5): add QEMU_CAPS_TCG_DISABLED and probe conditionally add virQEMUCapsGetVirtType convenience function add virQEMUCapsProbeQMPTCGState function to set QEMU_CAPS_TCG_DISABLED use new functions when probing Add second qom-list-types call to test data. src/qemu/qemu_capabilities.c | 80 +- src/qemu/qemu_capabilities.h | 3 + .../caps_2.10.0.aarch64.replies | 2695 ++- .../caps_2.10.0.ppc64.replies | 2799 ++- .../caps_2.10.0.s390x.replies | 1027 +- .../caps_2.10.0.x86_64.replies | 1702 +- .../caps_2.11.0.s390x.replies | 1063 +- .../caps_2.11.0.x86_64.replies | 1688 +- .../caps_2.12.0.aarch64.replies | 2960 +++- .../caps_2.12.0.ppc64.replies | 2947 +++- .../caps_2.12.0.s390x.replies | 1087 +- .../caps_2.12.0.x86_64.replies | 1827 +- .../caps_3.0.0.ppc64.replies | 2979 +++- .../caps_3.0.0.s390x.replies | 1117 +- .../caps_3.0.0.x86_64.replies | 1843 +- .../caps_3.1.0.ppc64.replies | 2999 +++- .../caps_3.1.0.x86_64.replies | 1863 +- .../caps_4.0.0.aarch64.replies | 3223 +++- .../caps_4.0.0.ppc64.replies | 3211 +++- .../caps_4.0.0.s390x.replies | 1259 +- .../caps_4.0.0.x86_64.replies | 1975 ++- .../caps_4.1.0.x86_64.replies | 2207 ++- .../caps_4.2.0.aarch64.replies | 3409 +++- .../caps_4.2.0.ppc64.replies | 3248 +++- .../caps_4.2.0.s390x.replies | 1259 +- .../caps_4.2.0.x86_64.replies | 2296 ++- .../caps_5.0.0.aarch64.replies | 3445 +++- .../caps_5.0.0.ppc64.replies | 14002 +++++++++------- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1220 +- .../caps_5.0.0.x86_64.replies | 2319 ++- 30 files changed, 65235 insertions(+), 8517 deletions(-) -- 2.20.1 (Apple Git-117)

1 5

[libvirt PATCH 0/2] gitlab: Improve make handling
by Andrea Bolognani 27 Mar '20

27 Mar '20

Andrea Bolognani (2): gitlab: Add and use 'environment' template gitlab: Define $MAKEFLAGS in environment .gitlab-ci.yml | 28 ++++++++++++++++++++-------- 1 file changed, 20 insertions(+), 8 deletions(-) -- 2.25.1

2 4

[PATCH 0/2] Two trivial syntax-check fixes
by Michal Privoznik 27 Mar '20

27 Mar '20

While reviewing patches [1] I've found two problems with syntax-check which are trivial to fix. These are the patches I've pushed. 1: https://www.redhat.com/archives/libvir-list/2020-March/msg01124.html Michal Prívozník (2): syntax-check: Disallow plain fork() in src/libvirt.c syntax-check.mk: Drop needless _src2 variable build-aux/syntax-check.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.24.1

2 4

[PATCH 0/4] Introduce shared daemon startup code
by Rafael Fonseca 27 Mar '20

27 Mar '20

Libvirt ships several daemons (libvirtd, virtlogd, virtlockd) that all have similar code around general daemon startup. Right now the code is duplicated for each daemon, but it could be shared, like in a new file src/util/virdaemon.c. Rafael Fonseca (4): util: introduce shared daemon startup code locking: use shared daemon startup code logging: use shared daemon startup code remote: use shared daemon startup code src/libvirt_private.syms | 6 + src/locking/lock_daemon.c | 251 ++++------------------------------- src/logging/log_daemon.c | 239 ++++----------------------------- src/remote/remote_daemon.c | 263 +++---------------------------------- src/util/Makefile.inc.am | 2 + src/util/virdaemon.c | 255 +++++++++++++++++++++++++++++++++++ src/util/virdaemon.h | 74 +++++++++++ 7 files changed, 410 insertions(+), 680 deletions(-) create mode 100644 src/util/virdaemon.c create mode 100644 src/util/virdaemon.h -- 2.25.1

2 6

[libvirt PATCH] scripts: avoid error in DCO check on empty branches
by Daniel P. Berrangé 27 Mar '20

27 Mar '20

If the DCO check is run on an empty branch (ie one which has no commits different from master), it throws an error due to trying to interpret the empty string as a git commit SHA. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/require-dco.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/require-dco.py b/scripts/require-dco.py index 9fe13823a9..ae94393319 100755 --- a/scripts/require-dco.py +++ b/scripts/require-dco.py @@ -46,7 +46,10 @@ print("\nChecking for 'Signed-off-by: NAME <EMAIL>' on all commits since %s...\n log = subprocess.check_output(["git", "log", "--format=%H %s", ancestor + "..."], universal_newlines=True) -commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")] +if log == "": + commits = [] +else: + commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")] for sha, subject in commits: -- 2.24.1

2 1

[libvirt PATCH] gitlab: don't run the DCO check on git master
by Daniel P. Berrangé 27 Mar '20

27 Mar '20

The "only: branches" does not in fact exclude "master", so it must be excluded explicitly. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix since the DCO check fails on master .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d8b316d618..1e3675ace0 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -228,3 +228,4 @@ dco: - branches except: - /^v.*-maint$/ + - master -- 2.24.1

1 0

[PATCH 1/1] qemu_domain.c: remove unneeded size check in NVDIMM alignment
by Daniel Henrique Barboza 27 Mar '20

27 Mar '20

Commit 5540acb9a2b added a minimum size verification for the target size of ppc64 NVDIMMs but forgot to remove a MAX() size check that was being used in earlier reviews of that commit. The size verification makes this check unneeded since we're making sure that guestArea will always be at least equal to ppc64AlignSize. Fixes: 5540acb9a2bd33fb97a7446a610b602c9e8629a3 Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/qemu/qemu_domain.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2c9fb47d17..2c52778515 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -12639,8 +12639,6 @@ qemuDomainNVDimmAlignSizePseries(virDomainDefPtr def, } guestArea = (guestArea/ppc64AlignSize) * ppc64AlignSize; - guestArea = MAX(guestArea, ppc64AlignSize); - mem->size = guestArea + mem->labelsize; return 0; -- 2.25.1

2 1

[PATCH 0/2] Accept http cookies with quoted value
by Peter Krempa 27 Mar '20

27 Mar '20

The validator didn't accept the quoted version of the cookie value. Add a test and fix the issue. Peter Krempa (2): qemuxml2xmltest: Wire up 'disk-network-http' case virStorageSourceNetCookieValidate: Accept quoted cookie value docs/schemas/domaincommon.rng | 2 +- src/util/virstoragefile.c | 19 ++++- .../disk-network-http.x86_64-latest.args | 4 +- tests/qemuxml2argvdata/disk-network-http.xml | 4 +- .../disk-network-http.x86_64-latest.xml | 71 +++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 6 files changed, 96 insertions(+), 6 deletions(-) create mode 100644 tests/qemuxml2xmloutdata/disk-network-http.x86_64-latest.xml -- 2.24.1

2 3

[PATCHv2 1/1] qemu_agent.c: Use g_autofree in qemu_agent.c
by Seeteena Thoufeek 27 Mar '20

27 Mar '20

This is the only instance of g_autofree change applicable for qemu_agent.c Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/qemu/qemu_agent.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 95a7d9b..d7fcc86 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -332,9 +332,8 @@ static int qemuAgentIOProcessData(qemuAgentPtr agent, size_t i = 0; #if DEBUG_IO # if DEBUG_RAW_IO - char *str1 = qemuAgentEscapeNonPrintable(data); + g_autofree char *str1 = qemuAgentEscapeNonPrintable(data); VIR_ERROR(_("[%s]"), str1); - VIR_FREE(str1); # else VIR_DEBUG("Data %zu bytes [%s]", len, data); # endif @@ -377,12 +376,10 @@ qemuAgentIOProcess(qemuAgentPtr agent) #if DEBUG_IO # if DEBUG_RAW_IO - char *str1 = qemuAgentEscapeNonPrintable(msg ? msg->txBuffer : ""); - char *str2 = qemuAgentEscapeNonPrintable(agent->buffer); + g_autofree char *str1 = qemuAgentEscapeNonPrintable(msg ? msg->txBuffer : ""); + g_autofree char *str2 = qemuAgentEscapeNonPrintable(agent->buffer); VIR_ERROR(_("Process %zu %p %p [[[%s]]][[[%s]]]"), agent->bufferOffset, agent->msg, msg, str1, str2); - VIR_FREE(str1); - VIR_FREE(str2); # else VIR_DEBUG("Process %zu", agent->bufferOffset); # endif @@ -1083,7 +1080,7 @@ qemuAgentCommandFull(qemuAgentPtr agent, { int ret = -1; qemuAgentMessage msg; - char *cmdstr = NULL; + g_autofree char *cmdstr = NULL; int await_event = agent->await_event; *reply = NULL; @@ -1133,7 +1130,6 @@ qemuAgentCommandFull(qemuAgentPtr agent, ret = qemuAgentCheckError(cmd, *reply, report_unsupported); cleanup: - VIR_FREE(cmdstr); VIR_FREE(msg.txBuffer); agent->await_event = QEMU_AGENT_EVENT_NONE; -- 1.8.3.1

2 2

[PATCH 0/5] Introduce getHost support for ARM cpus
by Zhenyu Zheng 27 Mar '20

27 Mar '20

Introduce getHost support for ARM cpus. First add some common ARM server models to cpu_map, then add some helper methods to parse and load them. The 'lscpu' command from 'util-linux' provides very good data for cpu information, we can parse them directly. Signed-of-by: Zhenyu Zheng <zhengzhenyulixi(a)gmail.com> Zhenyu Zheng (5): cpu_map: Introduce arm CPU models cpu: Introduce virCPUarmData to virCPUData cpu: Introduce arm related structs cpu: Add helper functions to parse vendor and model for ARM cpu: Introduce getHost supoort for ARM src/cpu/cpu.h | 2 + src/cpu/cpu_arm.c | 412 +++++++++++++++++++++++++++++- src/cpu/cpu_arm_data.h | 32 +++ src/cpu_map/Makefile.inc.am | 7 + src/cpu_map/arm_Falkor.xml | 15 ++ src/cpu_map/arm_Kunpeng-920.xml | 23 ++ src/cpu_map/arm_ThunderX299xx.xml | 15 ++ src/cpu_map/arm_cortex-a53.xml | 15 ++ src/cpu_map/arm_cortex-a57.xml | 14 + src/cpu_map/arm_cortex-a72.xml | 14 + src/cpu_map/arm_vendors.xml | 14 + src/cpu_map/index.xml | 16 ++ 12 files changed, 577 insertions(+), 2 deletions(-) create mode 100644 src/cpu/cpu_arm_data.h create mode 100644 src/cpu_map/arm_Falkor.xml create mode 100644 src/cpu_map/arm_Kunpeng-920.xml create mode 100644 src/cpu_map/arm_ThunderX299xx.xml create mode 100644 src/cpu_map/arm_cortex-a53.xml create mode 100644 src/cpu_map/arm_cortex-a57.xml create mode 100644 src/cpu_map/arm_cortex-a72.xml create mode 100644 src/cpu_map/arm_vendors.xml -- 2.26.0.windows.1

1 1

[PATCH 0/5] Introduce getHost support for ARM cpus
by Zhenyu Zheng 27 Mar '20

27 Mar '20

Introduce getHost support for ARM cpus. First add some common ARM server models to cpu_map, then add some helper methods to parse and load them. The 'lscpu' command from 'util-linux' provides very good data for cpu information, we can parse them directly. Zhenyu Zheng (5): cpu_map: Introduce arm CPU models cpu: Introduce virCPUarmData to virCPUData cpu: Introduce arm related structs cpu: Add helper functions to parse vendor and model for ARM cpu: Introduce getHost supoort for ARM src/cpu/cpu.h | 2 + src/cpu/cpu_arm.c | 412 +++++++++++++++++++++++++++++- src/cpu/cpu_arm_data.h | 32 +++ src/cpu_map/Makefile.inc.am | 7 + src/cpu_map/arm_Falkor.xml | 15 ++ src/cpu_map/arm_Kunpeng-920.xml | 23 ++ src/cpu_map/arm_ThunderX299xx.xml | 15 ++ src/cpu_map/arm_cortex-a53.xml | 15 ++ src/cpu_map/arm_cortex-a57.xml | 14 + src/cpu_map/arm_cortex-a72.xml | 14 + src/cpu_map/arm_vendors.xml | 14 + src/cpu_map/index.xml | 16 ++ 12 files changed, 577 insertions(+), 2 deletions(-) create mode 100644 src/cpu/cpu_arm_data.h create mode 100644 src/cpu_map/arm_Falkor.xml create mode 100644 src/cpu_map/arm_Kunpeng-920.xml create mode 100644 src/cpu_map/arm_ThunderX299xx.xml create mode 100644 src/cpu_map/arm_cortex-a53.xml create mode 100644 src/cpu_map/arm_cortex-a57.xml create mode 100644 src/cpu_map/arm_cortex-a72.xml create mode 100644 src/cpu_map/arm_vendors.xml -- 2.26.0.windows.1

1 1

[PATCH 0/5] Introduce getHost support for ARM cpus
by KevinZ 27 Mar '20

27 Mar '20

Introduce getHost support for ARM cpus. First add some common ARM server models to cpu_map, then add some helper methods to parse and load them. The 'lscpu' command from 'util-linux' provides very good data for cpu information, we can parse them directly. Zhenyu Zheng (5):   cpu_map: Introduce arm CPU models   cpu: Introduce virCPUarmData to virCPUData   cpu: Introduce arm related structs   cpu: Add helper functions to parse vendor and model for ARM   cpu: Introduce getHost supoort for ARM  src/cpu/cpu.h                     |   2 +  src/cpu/cpu_arm.c                 | 412 +++++++++++++++++++++++++++++-  src/cpu/cpu_arm_data.h            |  32 +++  src/cpu_map/Makefile.inc.am       |   7 +  src/cpu_map/arm_Falkor.xml        |  15 ++  src/cpu_map/arm_Kunpeng-920.xml   |  23 ++  src/cpu_map/arm_ThunderX299xx.xml |  15 ++  src/cpu_map/arm_cortex-a53.xml    |  15 ++  src/cpu_map/arm_cortex-a57.xml    |  14 +  src/cpu_map/arm_cortex-a72.xml    |  14 +  src/cpu_map/arm_vendors.xml       |  14 +  src/cpu_map/index.xml             |  16 ++  12 files changed, 577 insertions(+), 2 deletions(-)  create mode 100644 src/cpu/cpu_arm_data.h  create mode 100644 src/cpu_map/arm_Falkor.xml  create mode 100644 src/cpu_map/arm_Kunpeng-920.xml  create mode 100644 src/cpu_map/arm_ThunderX299xx.xml  create mode 100644 src/cpu_map/arm_cortex-a53.xml  create mode 100644 src/cpu_map/arm_cortex-a57.xml  create mode 100644 src/cpu_map/arm_cortex-a72.xml  create mode 100644 src/cpu_map/arm_vendors.xml -- 2.26.0.windows.1

1 0

[libvirt] [PATCH 0/3] qemu: support -overcommit cpu-pm=on|off
by Menno Lageman 27 Mar '20

27 Mar '20

QEMU introduced a CPU power management feature with commit 6f131f13e68d ("kvm: support -overcommit cpu-pm=on|off"). With this flag, kvm allows guest to control host CPU power state. This increases latency for other processes using same host CPU in an unpredictable way, but if decreases idle entry/exit times for the running VCPU, so to use it QEMU needs a hint about whether host CPU is overcommitted, hence the flag name. This patch series adds a new kvm feature 'cpu-pm' for controlling "-overcommit cpu-pm=[on|off]" <features> <kvm> <cpu-pm state='on'/> </kvm> </features> Menno Lageman (2): qemu: introduce qemuBuildOvercommitCommandLine() tests: add tests for cpu-pm feature Wim ten Have (1): qemu: add hypervisor feature cpu-pm support for kvm docs/formatdomain.html.in | 7 ++++ docs/schemas/domaincommon.rng | 5 +++ src/conf/domain_conf.c | 4 ++ src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 39 +++++++++++++++++-- src/qemu/qemu_domain.c | 25 ++++++++---- tests/qemuxml2argvdata/kvm-features-off.args | 2 +- tests/qemuxml2argvdata/kvm-features-off.xml | 1 + tests/qemuxml2argvdata/kvm-features.args | 2 +- tests/qemuxml2argvdata/kvm-features.xml | 1 + tests/qemuxml2argvtest.c | 4 +- tests/qemuxml2xmloutdata/kvm-features-off.xml | 1 + tests/qemuxml2xmloutdata/kvm-features.xml | 1 + 14 files changed, 79 insertions(+), 15 deletions(-) -- 2.21.0

3 7

[PATCH] qemu_agent.c: Use g_autofree in qemu_agent.c
by Seeteena Thoufeek 26 Mar '20

26 Mar '20

This is the only instance of g_autofree change applicable for qemu_agent.c Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/qemu/qemu_agent.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 95a7d9b..c74bd0e 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1083,7 +1083,7 @@ qemuAgentCommandFull(qemuAgentPtr agent, { int ret = -1; qemuAgentMessage msg; - char *cmdstr = NULL; + g_autofree char *cmdstr = NULL; int await_event = agent->await_event; *reply = NULL; @@ -1133,7 +1133,6 @@ qemuAgentCommandFull(qemuAgentPtr agent, ret = qemuAgentCheckError(cmd, *reply, report_unsupported); cleanup: - VIR_FREE(cmdstr); VIR_FREE(msg.txBuffer); agent->await_event = QEMU_AGENT_EVENT_NONE; -- 1.8.3.1

2 1

[PATCH] bhyve: fix typo in struct field accessor
by Daniel P. Berrangé 26 Mar '20

26 Mar '20

This fixes a FreeBSD build error from commit a11a0e6e8473fec6127b263a33f892135097648f Author: Rafael Fonseca <r4f4rfs(a)gmail.com> Date: Tue Mar 24 17:14:30 2020 +0100 bhyve: move video default logic to driver Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as build fix src/bhyve/bhyve_domain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index 40ee461b19..95d6ffd31c 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -162,8 +162,8 @@ bhyveDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, } if (dev->type == VIR_DOMAIN_DEVICE_VIDEO && - dev->data.video.type == VIR_DOMAIN_VIDEO_TYPE_DEFAULT) { - dev->data.video.type = VIR_DOMAIN_VIDEO_TYPE_GOP; + dev->data.video->type == VIR_DOMAIN_VIDEO_TYPE_DEFAULT) { + dev->data.video->type = VIR_DOMAIN_VIDEO_TYPE_GOP; } return 0; -- 2.24.1

1 0

[PATCH] qemuCheckpointCreateXML: Check VM liveness first
by Peter Krempa 26 Mar '20

26 Mar '20

Move the liveness check prior to the capability check. If the VM is offline the capabilities are not initialized and thus we'd report the wrong error. https://bugzilla.redhat.com/show_bug.cgi?id=1812531 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_checkpoint.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_checkpoint.c b/src/qemu/qemu_checkpoint.c index 62b6e87b53..3a510c9780 100644 --- a/src/qemu/qemu_checkpoint.c +++ b/src/qemu/qemu_checkpoint.c @@ -647,15 +647,15 @@ qemuCheckpointCreateXML(virDomainPtr domain, update_current = false; } - if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { + if (!virDomainObjIsActive(vm)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("incremental backup is not supported yet")); + _("cannot create checkpoint for inactive domain")); return NULL; } - if (!virDomainObjIsActive(vm)) { + if (!virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_INCREMENTAL_BACKUP)) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("cannot create checkpoint for inactive domain")); + _("incremental backup is not supported yet")); return NULL; } -- 2.24.1

2 2

[PATCH 0/2] Two incremental backup related fixes
by Peter Krempa 26 Mar '20

26 Mar '20

Peter Krempa (2): qemuCheckpointDelete: Check VM liveness first qemuBackupBegin: Fix monitor access when rolling back due to failure src/qemu/qemu_backup.c | 2 +- src/qemu/qemu_checkpoint.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) -- 2.24.1

2 5

[libvirt-dockerfiles PATCH] trigger: Fetch Dockerfiles from GitLab
by Andrea Bolognani 26 Mar '20

26 Mar '20

We're moving libvirt development to GitLab, so it makes sense that we'd fetch Dockerfiles from there rather than GitHub going forward. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- trigger | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trigger b/trigger index d2e853d..4e71d32 100755 --- a/trigger +++ b/trigger @@ -16,7 +16,7 @@ test "$outfile" || usage while read zip do repository="${zip%.zip}" - url="https://github.com/libvirt/libvirt-dockerfiles/raw/master/$zip" + url="https://gitlab.com/libvirt/libvirt-dockerfiles/-/raw/master/$zip" "$QUAYADMIN" create-build libvirt "$repository" "$url" -- 2.25.1

2 1

[libvirt-dockerfiles PATCH] Refresh after adding ccache and dwarves to CentOS
by Andrea Bolognani 26 Mar '20

26 Mar '20

The corresponding libvirt-jenkins-ci commit is cb8a5cc98818. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the Dockerfile refresh rule. buildenv-libosinfo-centos-7.zip | Bin 1659 -> 1665 bytes buildenv-libosinfo-centos-8.zip | Bin 589 -> 594 bytes buildenv-libvirt-centos-7.zip | Bin 1878 -> 1888 bytes buildenv-libvirt-centos-8.zip | Bin 793 -> 802 bytes 4 files changed, 0 insertions(+), 0 deletions(-) diff --git a/buildenv-libosinfo-centos-7.zip b/buildenv-libosinfo-centos-7.zip index 454ce5c..e4f5b87 100644 --- a/buildenv-libosinfo-centos-7.zip +++ b/buildenv-libosinfo-centos-7.zip @@ -38,6 +38,7 @@ WEiJKtQrZDJloqtyi/mmRa1VsV7RYR0VPJjhK/R8EQ7Ysshy\n\ bash \ bash-completion \ ca-certificates \ + ccache \ check-devel \ chrony \ gcc \ diff --git a/buildenv-libosinfo-centos-8.zip b/buildenv-libosinfo-centos-8.zip index 11621ba..53a49d0 100644 --- a/buildenv-libosinfo-centos-8.zip +++ b/buildenv-libosinfo-centos-8.zip @@ -10,6 +10,7 @@ RUN dnf install 'dnf-command(config-manager)' -y && \ bash \ bash-completion \ ca-certificates \ + ccache \ check-devel \ chrony \ gcc \ diff --git a/buildenv-libvirt-centos-7.zip b/buildenv-libvirt-centos-7.zip index c50693d..96cd758 100644 --- a/buildenv-libvirt-centos-7.zip +++ b/buildenv-libvirt-centos-7.zip @@ -41,11 +41,13 @@ WEiJKtQrZDJloqtyi/mmRa1VsV7RYR0VPJjhK/R8EQ7Ysshy\n\ bash \ bash-completion \ ca-certificates \ + ccache \ chrony \ cyrus-sasl-devel \ dbus-devel \ device-mapper-devel \ dnsmasq \ + dwarves \ ebtables \ fuse-devel \ gcc \ diff --git a/buildenv-libvirt-centos-8.zip b/buildenv-libvirt-centos-8.zip index a81abce..a63524b 100644 --- a/buildenv-libvirt-centos-8.zip +++ b/buildenv-libvirt-centos-8.zip @@ -13,11 +13,13 @@ RUN dnf install 'dnf-command(config-manager)' -y && \ bash \ bash-completion \ ca-certificates \ + ccache \ chrony \ cyrus-sasl-devel \ dbus-devel \ device-mapper-devel \ dnsmasq \ + dwarves \ ebtables \ fuse-devel \ gcc \ -- 2.25.1

1 0

[libvirt PATCH v2 0/9] gitlab: expand the CI job coverage (RESEND)
by Daniel P. Berrangé 26 Mar '20

26 Mar '20

There are main goals with this series - Introduce a minimal job building the website and publishing an artifact which can be deployed onto libvirt.org - Introduce a minimal job building the libvirt.pot for import into Weblate (only runs on git master branch) - Expanding CI jobs to get coverage closer to Travis/Jenkins - Reducing cross-build jobs to just interesting variants, since the full set hasn't shown value in detecting failures The Linux native job coverage is now a superset of that achieved by Travis/Jenkins. For post-merge testing the full set of jobs are run on git master (measured approx 50 minutes total duration) For pre-merge testing the Linux job count is reduced for quicker turnaround time for developers (measured ~35 minutes total duration) Changed in v2: - Add more native test jobs to run on git master - Restrict git clone depth - User variable for "make" command name - Add test job to build the master pot file - Remove extra configure args for website job - Re-ordered patches to reduce repeated changes Daniel P. Berrangé (9): gitlab: use CI for building website contents gitlab: reduce number of cross-build CI jobs gitlab: group jobs into stages gitlab: rename the cross build jobs gitlab: add mingw cross build CI jobs gitlab: add x86_64 native CI jobs gitlab: add variable for make command name gitlab: restrict git history to 100 commits gitlab: add job for building latest potfile .gitlab-ci.yml | 178 ++++++++++++++++++++++++++++++++++++++++--------- 1 file changed, 148 insertions(+), 30 deletions(-) -- 2.24.1

3 44

Question: building libvirt into the buildroot. Error *** No rule to make target `keycodemapdb/data/keymaps.csv'
by Komarov Egor 26 Mar '20

26 Mar '20

Hello! I'm tying to build libvirt into the buildroot project. When I build libvirt I have an error make[3]: Entering directory `/home/zoadmin/BRAIN4NET/buildroot/buildroot-2018.02.2/output/build/libvirt-v6.1.0/src' make[3]: *** No rule to make target `keycodemapdb/data/keymaps.csv', needed by `util/virkeycodetable_linux.h'. Stop. Please, Help me) What I do incorrect ? I tried build branch 6.1 and master. Completely build.log in attach. Thank you! P.S. My package/libvirt/libvirt.mk into the buildroot [zoadmin@BuildPC-SPECOS buildroot-2018.02.2]$ cat package/libvirt/libvirt.mk ###################################################################### # # # libvirt # # ##################################################################### LIBVIRT_VERSION = v6.1.0 #LIBVIRT_SOURCE = LIBVIRT_SITE = https://github.com/libvirt/libvirt LIBVIRT_SITE_METHOD = git LIBVIRT_AUTORECONF = YES LIBVIRT_CONF_OPTS = -prefix=/usr --sysconfdir=/etc --localstatedir=/var --with-storage-mpath=no LIBVIRT_INSTALL_TARGET = YES LIBVIRT_DEPENDENCIES = gnutls kvmtool qemu linux libxml2 libpciaccess libxslt libnl host-libxslt host-python-rst2html5 host-python-docutils host-python3 define LIBVIRT_PRE_CONFIGURE_GNU cd $(@D); ./bootstrap endef define LIBVIRT_PRE_CONFIGURE_DELETE_STRING cd $(@D); sed -i "21,24d" ./configure.ac # sed -i "3413,3416d" ./configure endef #LIBVIRT_PRE_CONFIGURE_HOOKS += LIBVIRT_PRE_CONFIGURE_GNU LIBVIRT_PRE_CONFIGURE_HOOKS += LIBVIRT_PRE_CONFIGURE_DELETE_STRING $(eval $(autotools-package)) fd ______________________________________________________________________________________ С уважением, Комаров Егор Инженер Департамента специальных работ (ДСР), АО <ЭЛВИС-ПЛЮС> тел. +7 (495) 276-02-11 доб.175 [cid:image003.jpg@01D602B6.5C6B7D20] www.elvis.ru<http://www.elvis.ru/>

2 5

[jenkins-ci PATCH] guests: enable ccache on CentOS installs
by Daniel P. Berrangé 26 Mar '20

26 Mar '20

Since we enabled use of EPEL in our CentOS installs, we should pull in the ccache package to speed up builds. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 9833856..0f7af48 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -111,7 +111,6 @@ mappings: ccache: default: ccache - CentOS: check: default: check -- 2.24.1

2 1

[PATCH] rng: Interleave elements in source
by Han Han 26 Mar '20

26 Mar '20

Signed-off-by: Han Han <hhan(a)redhat.com> --- docs/schemas/domaincommon.rng | 350 ++++++++++++++++++---------------- 1 file changed, 186 insertions(+), 164 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index d79dee65..96eccaad 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1642,21 +1642,23 @@ </optional> <optional> <element name="source"> - <optional> - <attribute name="file"> - <ref name="absFilePath"/> - </attribute> - </optional> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> - <zeroOrMore> - <ref name='devSeclabel'/> - </zeroOrMore> + <interleave> + <optional> + <attribute name="file"> + <ref name="absFilePath"/> + </attribute> + </optional> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + <zeroOrMore> + <ref name='devSeclabel'/> + </zeroOrMore> + </interleave> </element> </optional> </define> @@ -1667,24 +1669,26 @@ </attribute> <optional> <element name="source"> - <optional> - <attribute name="dev"> - <ref name="absFilePath"/> - </attribute> - </optional> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="reservations"/> - </optional> - <zeroOrMore> - <ref name='devSeclabel'/> - </zeroOrMore> + <interleave> + <optional> + <attribute name="dev"> + <ref name="absFilePath"/> + </attribute> + </optional> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="reservations"/> + </optional> + <zeroOrMore> + <ref name='devSeclabel'/> + </zeroOrMore> + </interleave> </element> </optional> </define> @@ -1695,17 +1699,19 @@ </attribute> <optional> <element name="source"> - <attribute name="dir"> - <ref name="absFilePath"/> - </attribute> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> - <empty/> + <interleave> + <attribute name="dir"> + <ref name="absFilePath"/> + </attribute> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + <empty/> + </interleave> </element> </optional> </define> @@ -1856,138 +1862,152 @@ <define name="diskSourceNetworkProtocolHTTPS"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>https</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolSSLVerify"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolHTTPCookies"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>https</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolSSLVerify"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolHTTPCookies"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolHTTP"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>http</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolHTTPCookies"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>http</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolHTTPCookies"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolFTPS"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>ftps</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <optional> - <ref name="diskSourceNetworkProtocolSSLVerify"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>ftps</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <optional> + <ref name="diskSourceNetworkProtocolSSLVerify"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolSimple"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>sheepdog</value> - <value>ftp</value> - <value>tftp</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> - <ref name="diskSourceNetworkProtocolPropsCommon"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>sheepdog</value> + <value>ftp</value> + <value>tftp</value> + </choice> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + <ref name="diskSourceNetworkProtocolPropsCommon"/> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolNBD"> <element name="source"> - <attribute name="protocol"> - <value>nbd</value> - </attribute> - <optional> - <attribute name="name"/> - </optional> - <optional> - <attribute name="tls"> - <ref name="virYesNo"/> + <interleave> + <attribute name="protocol"> + <value>nbd</value> </attribute> - </optional> - <ref name="diskSourceCommon"/> - <ref name="diskSourceNetworkHost"/> - <optional> - <ref name="encryption"/> - </optional> + <optional> + <attribute name="name"/> + </optional> + <optional> + <attribute name="tls"> + <ref name="virYesNo"/> + </attribute> + </optional> + <ref name="diskSourceCommon"/> + <ref name="diskSourceNetworkHost"/> + <optional> + <ref name="encryption"/> + </optional> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolGluster"> <element name="source"> - <attribute name="protocol"> - <value>gluster</value> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <oneOrMore> - <ref name="diskSourceNetworkHost"/> - </oneOrMore> - <optional> - <ref name="encryption"/> - </optional> + <interleave> + <attribute name="protocol"> + <value>gluster</value> + </attribute> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <oneOrMore> + <ref name="diskSourceNetworkHost"/> + </oneOrMore> + <optional> + <ref name="encryption"/> + </optional> + </interleave> </element> </define> <define name="diskSourceNetworkProtocolVxHS"> <element name="source"> - <attribute name="protocol"> - <choice> - <value>vxhs</value> - </choice> - </attribute> - <attribute name="name"/> - <ref name="diskSourceCommon"/> - <optional> - <attribute name="tls"> - <ref name="virYesNo"/> + <interleave> + <attribute name="protocol"> + <choice> + <value>vxhs</value> + </choice> </attribute> - </optional> - <ref name="diskSourceNetworkHost"/> + <attribute name="name"/> + <ref name="diskSourceCommon"/> + <optional> + <attribute name="tls"> + <ref name="virYesNo"/> + </attribute> + </optional> + <ref name="diskSourceNetworkHost"/> + </interleave> </element> </define> @@ -2048,27 +2068,29 @@ </attribute> <optional> <element name="source"> - <attribute name="type"> - <value>pci</value> - </attribute> - <attribute name="namespace"> - <ref name="uint32"/> - </attribute> - <optional> - <attribute name="managed"> - <ref name="virYesNo"/> + <interleave> + <attribute name="type"> + <value>pci</value> </attribute> - </optional> - <element name="address"> - <ref name="pciaddress"/> - </element> - <ref name="diskSourceCommon"/> - <optional> - <ref name="storageStartupPolicy"/> - </optional> - <optional> - <ref name="encryption"/> - </optional> + <attribute name="namespace"> + <ref name="uint32"/> + </attribute> + <optional> + <attribute name="managed"> + <ref name="virYesNo"/> + </attribute> + </optional> + <element name="address"> + <ref name="pciaddress"/> + </element> + <ref name="diskSourceCommon"/> + <optional> + <ref name="storageStartupPolicy"/> + </optional> + <optional> + <ref name="encryption"/> + </optional> + </interleave> </element> </optional> </define> -- 2.25.0

2 1

[PATCH 0/9] Another round of qemu:///embed fixes
by Michal Privoznik 26 Mar '20

26 Mar '20

After my first round of patches got merged [1], some new problems arose. They are not as serious (except maybe for 7/9) but they are still problematic for sure. Mostly in scenarios where a mgmt application uses the embedded driver and has multiple forks/instances sharing essentially the same config (e.g. it writes the same qemu.conf into different roots). Thing is, we may generate conflicting paths across these instances. What I've done here is, I looked at what paths can be set from qemu.conf and on their usage. Then I've grepped for virDomainDefGetShortName() and looked at its usages, because that has proven to be common denominator in patches 7-9. Some usages of the function are safe though. When the usage involves a path that is derived from the root and can't be overridden in qemu.conf it is safe. For instance, qemuDBusGetAddress() calls virDomainDefGetShortName() to construct a path to a UNIX socket. But the path has cfg->dbusStateDir prefix which is derived from cfg->stateDir which in turn is derived from the root. At the same time, neither of these paths can be overridden in qemu.conf. Therefore, no conflicts can occur. Michal Prívozník (9): tests: Fix virQEMUDriverConfigNew() calling with respect to @root conf: Move virDomainGenerateMachineName to hypervisor/ virDomainDriverGenerateMachineName: Factor out embed path hashing qemu: Introduce virQEMUDriverGetEmbedRoot qemuDomainGetMachineName: Access embeddedRoot from driver rather than cfg Revert "qemu_conf: Track embed root dir" qemu: Make hugepages path generation embed driver aware qemu: Make memory path generation embed driver aware qemu: Make auto dump path generation embed driver aware src/conf/domain_conf.c | 72 ---------------------------- src/conf/domain_conf.h | 7 --- src/hypervisor/domain_driver.c | 88 ++++++++++++++++++++++++++++++++++ src/hypervisor/domain_driver.h | 11 +++++ src/libvirt_private.syms | 3 +- src/lxc/lxc_domain.c | 3 +- src/qemu/qemu_command.c | 19 ++++---- src/qemu/qemu_conf.c | 64 ++++++++++++++++++------- src/qemu/qemu_conf.h | 23 ++++----- src/qemu/qemu_domain.c | 9 ++-- src/qemu/qemu_driver.c | 10 +++- src/qemu/qemu_process.c | 7 ++- tests/domaincapstest.c | 2 +- tests/testutilsqemu.c | 2 +- tests/virsystemdtest.c | 5 +- 15 files changed, 191 insertions(+), 134 deletions(-) -- 2.24.1

4 18

[PATCH] docs: fix typo in domcaps host-model CPU description
by Jim Fehlig 25 Mar '20

25 Mar '20

The domain capabilities documentation contains a small but confusing error in the host-model CPU description, referencing the element <mode> instead of <model>. Fix this small typo. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I only found this small typo (well, I'm pretty sure it's a typo :-)) by tring to understand a more confusing observation. On a machine where capabilities reports CascaseLake-Server, domcapabilities reports <mode name='host-model' supported='yes'> <model fallback='forbid'>Cascadelake-Server</model> <vendor>Intel</vendor> <feature policy='require' name='ss'/> <feature policy='require' name='hypervisor'/> <feature policy='require' name='tsc_adjust'/> <feature policy='require' name='umip'/> <feature policy='require' name='pku'/> <feature policy='require' name='md-clear'/> <feature policy='require' name='stibp'/> <feature policy='require' name='arch-capabilities'/> <feature policy='require' name='xsaves'/> <feature policy='require' name='invtsc'/> </mode> <mode name='custom' supported='yes'> ... <model usable='no'>Cascadelake-Server</model> </mode> So using host-model will result in a CascadeLake-Server CPU, but it is not supported when specifying a custom CPU? Interestingly, I see something similar from domcapabilities on machine where capabilities reports Skylake-Server-IBRS <mode name='host-model' supported='yes'> <model fallback='forbid'>Cascadelake-Server</model> <vendor>Intel</vendor> <feature policy='require' name='ss'/> <feature policy='require' name='hypervisor'/> <feature policy='require' name='tsc_adjust'/> <feature policy='require' name='umip'/> <feature policy='require' name='md-clear'/> <feature policy='require' name='stibp'/> <feature policy='require' name='arch-capabilities'/> <feature policy='require' name='xsaves'/> <feature policy='require' name='invtsc'/> <feature policy='disable' name='pku'/> <feature policy='disable' name='avx512vnni'/> </mode> <mode name='custom' supported='yes'> ... <model usable='no'>Skylake-Server-IBRS</model> <model usable='no'>Skylake-Server</model> <model usable='no'>Cascadelake-Server</model> </mode> This seems contradictory to me but perhaps I'm overlooking something? docs/formatdomaincaps.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index 66e758501b..7fd1f91f73 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -232,7 +232,7 @@ <dt><code>host-model</code></dt> <dd> If <code>host-model</code> is supported by the hypervisor, the - <code>mode</code> describes the guest CPU which will be used when + <code>model</code> describes the guest CPU which will be used when starting a domain with <code>host-model</code> CPU. The hypervisor specifics (such as unsupported CPU models or features, machine type, etc.) may be accounted for in this guest CPU specification and thus -- 2.25.0

2 4

[PATCH 1/2] gobject: Fix typo in documentation of gvir_domain_save_to_file_async
by Felipe Borges 25 Mar '20

25 Mar '20

Signed-off-by: Felipe Borges <feborges(a)redhat.com> --- libvirt-gobject/libvirt-gobject-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index 399b118..0a16cb4 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -777,7 +777,7 @@ gvir_domain_save_to_file_helper(GTask *task, * @filename: path to output file * @custom_conf: (allow-none): configuration for domain or NULL * @flags: the flags - * @cancellable: (allow-none) (transfer none): cancallation object + * @cancellable: (allow-none) (transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback * -- 2.24.1

3 3

[PATCH] qemu: capabilities: update qemu-4.2 capabilities for s390x
by Bjoern Walk 25 Mar '20

25 Mar '20

Update s390x capabilities for QEMU 4.2 with the actual GA version for QEMU and on the latest z15 machine. This picks up the new blockdev capability, so we need to refresh a bunch of test cases as well. Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Signed-off-by: Bjoern Walk <bwalk(a)linux.ibm.com> --- I have stripped the replies file to save some bandwidth on the mailing list. Full patch can be found here: https://gitlab.com/bwalk/libvirt/-/commit/5fc05853f2cc6d191a07f897cdd4e12fa… tests/domaincapsdata/qemu_4.2.0.s390x.xml | 47 +- .../caps_4.2.0.s390x.replies | 3230 +++++++++-------- .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 216 +- ...default-video-type-s390x.s390x-latest.args | 8 +- .../fs9p-ccw.s390x-latest.args | 7 +- ...othreads-virtio-scsi-ccw.s390x-latest.args | 14 +- ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 8 +- .../s390x-ccw-graphics.s390x-latest.args | 8 +- .../s390x-ccw-headless.s390x-latest.args | 8 +- .../vhost-vsock-ccw-auto.s390x-latest.args | 7 +- .../vhost-vsock-ccw.s390x-latest.args | 7 +- 11 files changed, 1871 insertions(+), 1689 deletions(-) diff --git a/tests/domaincapsdata/qemu_4.2.0.s390x.xml b/tests/domaincapsdata/qemu_4.2.0.s390x.xml index fbb3905f..6b87e450 100644 --- a/tests/domaincapsdata/qemu_4.2.0.s390x.xml +++ b/tests/domaincapsdata/qemu_4.2.0.s390x.xml @@ -27,9 +27,17 @@ <cpu> <mode name='host-passthrough' supported='yes'/> <mode name='host-model' supported='yes'> - <model fallback='forbid'>z13.2-base</model> + <model fallback='forbid'>gen15a-base</model> <feature policy='require' name='aen'/> + <feature policy='require' name='cmmnt'/> + <feature policy='require' name='vxpdeh'/> <feature policy='require' name='aefsi'/> + <feature policy='require' name='csske'/> + <feature policy='require' name='mepoch'/> + <feature policy='require' name='msa9'/> + <feature policy='require' name='msa8'/> + <feature policy='require' name='msa7'/> + <feature policy='require' name='msa6'/> <feature policy='require' name='msa5'/> <feature policy='require' name='msa4'/> <feature policy='require' name='msa3'/> @@ -38,15 +46,26 @@ <feature policy='require' name='sthyi'/> <feature policy='require' name='edat'/> <feature policy='require' name='ri'/> + <feature policy='require' name='deflate'/> <feature policy='require' name='edat2'/> + <feature policy='require' name='etoken'/> <feature policy='require' name='vx'/> <feature policy='require' name='ipter'/> + <feature policy='require' name='mepochptff'/> <feature policy='require' name='ap'/> + <feature policy='require' name='vxeh'/> + <feature policy='require' name='vxpd'/> <feature policy='require' name='esop'/> + <feature policy='require' name='msa9_pckmo'/> + <feature policy='require' name='vxeh2'/> + <feature policy='require' name='esort'/> + <feature policy='require' name='apqi'/> <feature policy='require' name='apft'/> + <feature policy='require' name='iep'/> <feature policy='require' name='apqci'/> <feature policy='require' name='cte'/> <feature policy='require' name='bpb'/> + <feature policy='require' name='gs'/> <feature policy='require' name='ppa15'/> <feature policy='require' name='zpci'/> <feature policy='require' name='sea_esop2'/> @@ -58,8 +77,8 @@ <model usable='yes'>z890.2-base</model> <model usable='yes'>z9EC.2</model> <model usable='yes'>z13.2</model> - <model usable='yes'>z990.5-base</model> <model usable='yes'>z9BC-base</model> + <model usable='yes'>z990.5-base</model> <model usable='yes'>z890.2</model> <model usable='yes'>z890</model> <model usable='yes'>z9BC</model> @@ -69,9 +88,9 @@ <model usable='yes'>z990.3</model> <model usable='yes'>z13s-base</model> <model usable='yes'>z9EC</model> - <model usable='no'>gen15a</model> - <model usable='no'>z14ZR1-base</model> - <model usable='no'>z14.2-base</model> + <model usable='yes'>gen15a</model> + <model usable='yes'>z14ZR1-base</model> + <model usable='yes'>z14.2-base</model> <model usable='yes'>z900.3-base</model> <model usable='yes'>z13.2-base</model> <model usable='yes'>z196.2-base</model> @@ -86,18 +105,18 @@ <model usable='yes'>z10EC.2</model> <model usable='yes'>z10EC-base</model> <model usable='yes'>z900.3</model> - <model usable='no'>z14ZR1</model> + <model usable='yes'>z14ZR1</model> <model usable='yes'>z10BC</model> <model usable='yes'>z10BC.2-base</model> - <model usable='yes'>z9BC.2</model> <model usable='yes'>z990.2</model> + <model usable='yes'>z9BC.2</model> <model usable='yes'>z990</model> - <model usable='no'>z14</model> - <model usable='no'>gen15b-base</model> + <model usable='yes'>z14</model> + <model usable='yes'>gen15b-base</model> <model usable='yes'>z990.4</model> <model usable='yes'>max</model> <model usable='yes'>z10EC.2-base</model> - <model usable='no'>gen15a-base</model> + <model usable='yes'>gen15a-base</model> <model usable='yes'>z800</model> <model usable='yes'>zEC12.2</model> <model usable='yes'>z10EC</model> @@ -111,12 +130,12 @@ <model usable='yes'>z196-base</model> <model usable='yes'>z9EC.2-base</model> <model usable='yes'>z196.2</model> - <model usable='no'>z14.2</model> + <model usable='yes'>z14.2</model> <model usable='yes'>z990-base</model> <model usable='yes'>z900.2</model> <model usable='yes'>z890-base</model> <model usable='yes'>z10EC.3</model> - <model usable='no'>z14-base</model> + <model usable='yes'>z14-base</model> <model usable='yes'>z990.4-base</model> <model usable='yes'>z10EC.3-base</model> <model usable='yes'>z10BC-base</model> @@ -126,7 +145,7 @@ <model usable='yes'>zBC12</model> <model usable='yes'>z890.3-base</model> <model usable='yes'>z990.5</model> - <model usable='no'>gen15b</model> + <model usable='yes'>gen15b</model> <model usable='no'>qemu</model> </mode> </cpu> @@ -198,7 +217,7 @@ <gic supported='no'/> <vmcoreinfo supported='no'/> <genid supported='no'/> - <backingStoreInput supported='no'/> + <backingStoreInput supported='yes'/> <backup supported='no'/> <sev supported='no'/> </features> diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.replies b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.replies index be709b3c..82b60bf0 100644 --- a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.replies +++ b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.replies @@ -17,11 +17,11 @@ [...] diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml index 37776e1b..e46259e6 100644 --- a/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml +++ b/tests/qemucapabilitiesdata/caps_4.2.0.s390x.xml @@ -8,12 +8,14 @@ <flag name='virtio-blk-pci.ioeventfd'/> <flag name='virtio-blk-pci.event_idx'/> <flag name='virtio-net-pci.event_idx'/> + <flag name='usb-redir'/> <flag name='virtio-blk-pci.scsi'/> <flag name='scsi-disk.channel'/> <flag name='scsi-block'/> <flag name='dump-guest-memory'/> <flag name='virtio-scsi-pci'/> <flag name='blockio'/> + <flag name='usb-redir.filter'/> <flag name='scsi-disk.wwn'/> <flag name='seccomp-sandbox'/> <flag name='reboot-timeout'/> @@ -49,6 +51,7 @@ <flag name='gic-version'/> <flag name='incoming-defer'/> <flag name='virtio-gpu'/> + <flag name='virtio-gpu.virgl'/> <flag name='virtio-keyboard'/> <flag name='virtio-mouse'/> <flag name='virtio-tablet'/> @@ -115,6 +118,7 @@ <flag name='chardev-fd-pass'/> <flag name='egl-headless'/> <flag name='vfio-pci.display'/> + <flag name='blockdev'/> <flag name='vfio-ap'/> <flag name='zpci'/> <flag name='memory-backend-memfd'/> @@ -134,18 +138,28 @@ <flag name='query-cpu-model-baseline'/> <flag name='query-cpu-model-comparison'/> <flag name='blockdev-file-dynamic-auto-read-only'/> + <flag name='savevm-monitor-nodes'/> <flag name='drive-nvme'/> <flag name='smp-dies'/> <flag name='rng-builtin'/> + <flag name='virtio-net.failover'/> <flag name='vhost-user-fs'/> - <version>4001050</version> + <version>4002000</version> <kvmVersion>0</kvmVersion> <microcodeVersion>39100242</microcodeVersion> - <package>v4.1.0-1686-g419af24e7e-dirty</package> + <package>qemu-4.2.0-20200115.0.1e4aa2da.fc31</package> <arch>s390x</arch> - <hostCPU type='kvm' model='z13.2-base' migratability='no'> + <hostCPU type='kvm' model='gen15a-base' migratability='no'> <property name='aen' type='boolean' value='true'/> + <property name='cmmnt' type='boolean' value='true'/> + <property name='vxpdeh' type='boolean' value='true'/> <property name='aefsi' type='boolean' value='true'/> + <property name='csske' type='boolean' value='true'/> + <property name='mepoch' type='boolean' value='true'/> + <property name='msa9' type='boolean' value='true'/> + <property name='msa8' type='boolean' value='true'/> + <property name='msa7' type='boolean' value='true'/> + <property name='msa6' type='boolean' value='true'/> <property name='msa5' type='boolean' value='true'/> <property name='msa4' type='boolean' value='true'/> <property name='msa3' type='boolean' value='true'/> @@ -154,15 +168,26 @@ <property name='sthyi' type='boolean' value='true'/> <property name='edat' type='boolean' value='true'/> <property name='ri' type='boolean' value='true'/> + <property name='deflate' type='boolean' value='true'/> <property name='edat2' type='boolean' value='true'/> + <property name='etoken' type='boolean' value='true'/> <property name='vx' type='boolean' value='true'/> <property name='ipter' type='boolean' value='true'/> + <property name='mepochptff' type='boolean' value='true'/> <property name='ap' type='boolean' value='true'/> + <property name='vxeh' type='boolean' value='true'/> + <property name='vxpd' type='boolean' value='true'/> <property name='esop' type='boolean' value='true'/> + <property name='msa9_pckmo' type='boolean' value='true'/> + <property name='vxeh2' type='boolean' value='true'/> + <property name='esort' type='boolean' value='true'/> + <property name='apqi' type='boolean' value='true'/> <property name='apft' type='boolean' value='true'/> + <property name='iep' type='boolean' value='true'/> <property name='apqci' type='boolean' value='true'/> <property name='cte' type='boolean' value='true'/> <property name='bpb' type='boolean' value='true'/> + <property name='gs' type='boolean' value='true'/> <property name='ppa15' type='boolean' value='true'/> <property name='zpci' type='boolean' value='true'/> <property name='sea_esop2' type='boolean' value='true'/> @@ -173,8 +198,8 @@ <cpu type='kvm' name='z890.2-base' typename='z890.2-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z9EC.2' typename='z9EC.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z13.2' typename='z13.2-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='z990.5-base' typename='z990.5-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z9BC-base' typename='z9BC-base-s390x-cpu' usable='yes'/> + <cpu type='kvm' name='z990.5-base' typename='z990.5-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z890.2' typename='z890.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z890' typename='z890-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z9BC' typename='z9BC-s390x-cpu' usable='yes'/> @@ -185,46 +210,9 @@ <cpu type='kvm' name='z990.3' typename='z990.3-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z13s-base' typename='z13s-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z9EC' typename='z9EC-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='gen15a' typename='gen15a-s390x-cpu' usable='no'> - <blocker name='etoken'/> - <blocker name='vxpdeh'/> - <blocker name='vxeh2'/> - <blocker name='mepoch'/> - <blocker name='vxeh'/> - <blocker name='vxpd'/> - <blocker name='gs'/> - <blocker name='iep'/> - <blocker name='minste3'/> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='deflate'/> - <blocker name='mepochptff'/> - <blocker name='msa9_pckmo'/> - <blocker name='msa9'/> - <blocker name='msa8'/> - <blocker name='msa7'/> - <blocker name='msa6'/> - <blocker name='type'/> - </cpu> - <cpu type='kvm' name='z14ZR1-base' typename='z14ZR1-base-s390x-cpu' usable='no'> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='type'/> - </cpu> - <cpu type='kvm' name='z14.2-base' typename='z14.2-base-s390x-cpu' usable='no'> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='type'/> - </cpu> + <cpu type='kvm' name='gen15a' typename='gen15a-s390x-cpu' usable='yes'/> + <cpu type='kvm' name='z14ZR1-base' typename='z14ZR1-base-s390x-cpu' usable='yes'/> + <cpu type='kvm' name='z14.2-base' typename='z14.2-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z900.3-base' typename='z900.3-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z13.2-base' typename='z13.2-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z196.2-base' typename='z196.2-base-s390x-cpu' usable='yes'/> @@ -239,66 +227,18 @@ <cpu type='kvm' name='z10EC.2' typename='z10EC.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10EC-base' typename='z10EC-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z900.3' typename='z900.3-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='z14ZR1' typename='z14ZR1-s390x-cpu' usable='no'> - <blocker name='mepoch'/> - <blocker name='vxeh'/> - <blocker name='vxpd'/> - <blocker name='gs'/> - <blocker name='iep'/> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='mepochptff'/> - <blocker name='msa8'/> - <blocker name='msa7'/> - <blocker name='msa6'/> - <blocker name='type'/> - </cpu> + <cpu type='kvm' name='z14ZR1' typename='z14ZR1-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10BC' typename='z10BC-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10BC.2-base' typename='z10BC.2-base-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='z9BC.2' typename='z9BC.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z990.2' typename='z990.2-s390x-cpu' usable='yes'/> + <cpu type='kvm' name='z9BC.2' typename='z9BC.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z990' typename='z990-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='z14' typename='z14-s390x-cpu' usable='no'> - <blocker name='mepoch'/> - <blocker name='vxeh'/> - <blocker name='vxpd'/> - <blocker name='gs'/> - <blocker name='iep'/> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='mepochptff'/> - <blocker name='msa8'/> - <blocker name='msa7'/> - <blocker name='msa6'/> - <blocker name='type'/> - </cpu> - <cpu type='kvm' name='gen15b-base' typename='gen15b-base-s390x-cpu' usable='no'> - <blocker name='minste3'/> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='type'/> - </cpu> + <cpu type='kvm' name='z14' typename='z14-s390x-cpu' usable='yes'/> + <cpu type='kvm' name='gen15b-base' typename='gen15b-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z990.4' typename='z990.4-s390x-cpu' usable='yes'/> <cpu type='kvm' name='max' typename='max-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10EC.2-base' typename='z10EC.2-base-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='gen15a-base' typename='gen15a-base-s390x-cpu' usable='no'> - <blocker name='minste3'/> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='type'/> - </cpu> + <cpu type='kvm' name='gen15a-base' typename='gen15a-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z800' typename='z800-s390x-cpu' usable='yes'/> <cpu type='kvm' name='zEC12.2' typename='zEC12.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10EC' typename='z10EC-s390x-cpu' usable='yes'/> @@ -312,35 +252,12 @@ <cpu type='kvm' name='z196-base' typename='z196-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z9EC.2-base' typename='z9EC.2-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z196.2' typename='z196.2-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='z14.2' typename='z14.2-s390x-cpu' usable='no'> - <blocker name='mepoch'/> - <blocker name='vxeh'/> - <blocker name='vxpd'/> - <blocker name='gs'/> - <blocker name='iep'/> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='mepochptff'/> - <blocker name='msa8'/> - <blocker name='msa7'/> - <blocker name='msa6'/> - <blocker name='type'/> - </cpu> + <cpu type='kvm' name='z14.2' typename='z14.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z990-base' typename='z990-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z900.2' typename='z900.2-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z890-base' typename='z890-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10EC.3' typename='z10EC.3-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='z14-base' typename='z14-base-s390x-cpu' usable='no'> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='type'/> - </cpu> + <cpu type='kvm' name='z14-base' typename='z14-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z990.4-base' typename='z990.4-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10EC.3-base' typename='z10EC.3-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z10BC-base' typename='z10BC-base-s390x-cpu' usable='yes'/> @@ -350,30 +267,7 @@ <cpu type='kvm' name='zBC12' typename='zBC12-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z890.3-base' typename='z890.3-base-s390x-cpu' usable='yes'/> <cpu type='kvm' name='z990.5' typename='z990.5-s390x-cpu' usable='yes'/> - <cpu type='kvm' name='gen15b' typename='gen15b-s390x-cpu' usable='no'> - <blocker name='etoken'/> - <blocker name='vxpdeh'/> - <blocker name='vxeh2'/> - <blocker name='mepoch'/> - <blocker name='vxeh'/> - <blocker name='vxpd'/> - <blocker name='gs'/> - <blocker name='iep'/> - <blocker name='minste3'/> - <blocker name='tsi'/> - <blocker name='sema'/> - <blocker name='minste2'/> - <blocker name='eec'/> - <blocker name='opc'/> - <blocker name='deflate'/> - <blocker name='mepochptff'/> - <blocker name='msa9_pckmo'/> - <blocker name='msa9'/> - <blocker name='msa8'/> - <blocker name='msa7'/> - <blocker name='msa6'/> - <blocker name='type'/> - </cpu> + <cpu type='kvm' name='gen15b' typename='gen15b-s390x-cpu' usable='yes'/> <cpu type='kvm' name='qemu' typename='qemu-s390x-cpu' usable='no'> <blocker name='ais'/> </cpu> @@ -593,7 +487,7 @@ <blocker name='gen13ptff'/> <blocker name='tods'/> </cpu> - <cpu type='tcg' name='z990.5-base' typename='z990.5-base-s390x-cpu' usable='no'> + <cpu type='tcg' name='z9BC-base' typename='z9BC-base-s390x-cpu' usable='no'> <blocker name='klmd-sha-1'/> <blocker name='kimd-sha-1'/> <blocker name='km-tdea-192'/> @@ -605,9 +499,13 @@ <blocker name='kmac-tdea-192'/> <blocker name='kmac-tdea-128'/> <blocker name='kmac-dea'/> + <blocker name='dateh2'/> + <blocker name='hfpue'/> <blocker name='hfpm'/> + <blocker name='asnlxr'/> + <blocker name='tods'/> </cpu> - <cpu type='tcg' name='z9BC-base' typename='z9BC-base-s390x-cpu' usable='no'> + <cpu type='tcg' name='z990.5-base' typename='z990.5-base-s390x-cpu' usable='no'> <blocker name='klmd-sha-1'/> <blocker name='kimd-sha-1'/> <blocker name='km-tdea-192'/> @@ -619,11 +517,7 @@ <blocker name='kmac-tdea-192'/> <blocker name='kmac-tdea-128'/> <blocker name='kmac-dea'/> - <blocker name='dateh2'/> - <blocker name='hfpue'/> <blocker name='hfpm'/> - <blocker name='asnlxr'/> - <blocker name='tods'/> </cpu> <cpu type='tcg' name='z890.2' typename='z890.2-s390x-cpu' usable='no'> <blocker name='klmd-sha-1'/> @@ -1867,7 +1761,7 @@ <blocker name='asnlxr'/> <blocker name='tods'/> </cpu> - <cpu type='tcg' name='z9BC.2' typename='z9BC.2-s390x-cpu' usable='no'> + <cpu type='tcg' name='z990.2' typename='z990.2-s390x-cpu' usable='no'> <blocker name='klmd-sha-1'/> <blocker name='kimd-sha-1'/> <blocker name='km-tdea-192'/> @@ -1879,16 +1773,9 @@ <blocker name='kmac-tdea-192'/> <blocker name='kmac-tdea-128'/> <blocker name='kmac-dea'/> - <blocker name='cmm'/> - <blocker name='dateh2'/> - <blocker name='sthyi'/> - <blocker name='hfpue'/> <blocker name='hfpm'/> - <blocker name='asnlxr'/> - <blocker name='msa1'/> - <blocker name='tods'/> </cpu> - <cpu type='tcg' name='z990.2' typename='z990.2-s390x-cpu' usable='no'> + <cpu type='tcg' name='z9BC.2' typename='z9BC.2-s390x-cpu' usable='no'> <blocker name='klmd-sha-1'/> <blocker name='kimd-sha-1'/> <blocker name='km-tdea-192'/> @@ -1900,7 +1787,14 @@ <blocker name='kmac-tdea-192'/> <blocker name='kmac-tdea-128'/> <blocker name='kmac-dea'/> + <blocker name='cmm'/> + <blocker name='dateh2'/> + <blocker name='sthyi'/> + <blocker name='hfpue'/> <blocker name='hfpm'/> + <blocker name='asnlxr'/> + <blocker name='msa1'/> + <blocker name='tods'/> </cpu> <cpu type='tcg' name='z990' typename='z990-s390x-cpu' usable='no'> <blocker name='klmd-sha-1'/> diff --git a/tests/qemuxml2argvdata/default-video-type-s390x.s390x-latest.args b/tests/qemuxml2argvdata/default-video-type-s390x.s390x-latest.args index 934c5d59..47818085 100644 --- a/tests/qemuxml2argvdata/default-video-type-s390x.s390x-latest.args +++ b/tests/qemuxml2argvdata/default-video-type-s390x.s390x-latest.args @@ -13,9 +13,11 @@ QEMU_AUDIO_DRV=none \ -object secret,id=masterKey0,format=raw,\ file=/tmp/lib/domain--1-default-video-type-s/master-key.aes \ -machine s390-ccw-virtio,accel=kvm,usb=off,dump-guest-core=off \ --cpu z13.2-base,aen=on,aefsi=on,msa5=on,msa4=on,msa3=on,msa2=on,msa1=on,\ -sthyi=on,edat=on,ri=on,edat2=on,vx=on,ipter=on,ap=on,esop=on,apft=on,apqci=on,\ -cte=on,bpb=on,ppa15=on,zpci=on,sea_esop2=on,te=on,cmm=on \ +-cpu gen15a-base,aen=on,cmmnt=on,vxpdeh=on,aefsi=on,csske=on,mepoch=on,msa9=on,\ +msa8=on,msa7=on,msa6=on,msa5=on,msa4=on,msa3=on,msa2=on,msa1=on,sthyi=on,\ +edat=on,ri=on,deflate=on,edat2=on,etoken=on,vx=on,ipter=on,mepochptff=on,ap=on,\ +vxeh=on,vxpd=on,esop=on,msa9_pckmo=on,vxeh2=on,esort=on,apqi=on,apft=on,iep=on,\ +apqci=on,cte=on,bpb=on,gs=on,ppa15=on,zpci=on,sea_esop2=on,te=on,cmm=on \ -m 1024 \ -overcommit mem-lock=off \ -smp 1,sockets=1,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvdata/fs9p-ccw.s390x-latest.args b/tests/qemuxml2argvdata/fs9p-ccw.s390x-latest.args index 4a93ee37..50d4bc42 100644 --- a/tests/qemuxml2argvdata/fs9p-ccw.s390x-latest.args +++ b/tests/qemuxml2argvdata/fs9p-ccw.s390x-latest.args @@ -26,8 +26,11 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ -rtc base=utc \ -no-shutdown \ -boot strict=on \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-virtio-disk0 \ --device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,\ +-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1",\ +"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"raw",\ +"file":"libvirt-1-storage"}' \ +-device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=libvirt-1-format,\ id=virtio-disk0,bootindex=1 \ -fsdev local,security_model=passthrough,id=fsdev-fs0,path=/export/to/guest \ -device virtio-9p-ccw,id=fs0,fsdev=fsdev-fs0,mount_tag=/import/from/host,\ diff --git a/tests/qemuxml2argvdata/iothreads-virtio-scsi-ccw.s390x-latest.args b/tests/qemuxml2argvdata/iothreads-virtio-scsi-ccw.s390x-latest.args index bdc060aa..20288f2a 100644 --- a/tests/qemuxml2argvdata/iothreads-virtio-scsi-ccw.s390x-latest.args +++ b/tests/qemuxml2argvdata/iothreads-virtio-scsi-ccw.s390x-latest.args @@ -29,12 +29,18 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ -no-shutdown \ -boot strict=on \ -device virtio-scsi-ccw,iothread=iothread2,id=scsi0,devno=fe.0.0001 \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-virtio-disk0 \ +-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1",\ +"node-name":"libvirt-2-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-2-format","read-only":false,"driver":"raw",\ +"file":"libvirt-2-storage"}' \ -device virtio-blk-ccw,iothread=iothread1,scsi=off,devno=fe.0.0000,\ -drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1 \ --drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,id=drive-scsi0-0-2-0 \ +drive=libvirt-2-format,id=virtio-disk0,bootindex=1 \ +-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest2",\ +"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"raw",\ +"file":"libvirt-1-storage"}' \ -device scsi-hd,bus=scsi0.0,channel=0,scsi-id=2,lun=0,\ -device_id=drive-scsi0-0-2-0,drive=drive-scsi0-0-2-0,id=scsi0-0-2-0 \ +device_id=drive-scsi0-0-2-0,drive=libvirt-1-format,id=scsi0-0-2-0 \ -device virtio-balloon-ccw,id=balloon0,devno=fe.0.000a \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,\ resourcecontrol=deny \ diff --git a/tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-4.2.s390x-latest.args b/tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-4.2.s390x-latest.args index 03860194..35093d4f 100644 --- a/tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-4.2.s390x-latest.args +++ b/tests/qemuxml2argvdata/s390-default-cpu-kvm-ccw-virtio-4.2.s390x-latest.args @@ -13,9 +13,11 @@ QEMU_AUDIO_DRV=none \ -object secret,id=masterKey0,format=raw,\ file=/tmp/lib/domain--1-test/master-key.aes \ -machine s390-ccw-virtio-4.2,accel=kvm,usb=off,dump-guest-core=off \ --cpu z13.2-base,aen=on,aefsi=on,msa5=on,msa4=on,msa3=on,msa2=on,msa1=on,\ -sthyi=on,edat=on,ri=on,edat2=on,vx=on,ipter=on,ap=on,esop=on,apft=on,apqci=on,\ -cte=on,bpb=on,ppa15=on,zpci=on,sea_esop2=on,te=on,cmm=on \ +-cpu gen15a-base,aen=on,cmmnt=on,vxpdeh=on,aefsi=on,csske=on,mepoch=on,msa9=on,\ +msa8=on,msa7=on,msa6=on,msa5=on,msa4=on,msa3=on,msa2=on,msa1=on,sthyi=on,\ +edat=on,ri=on,deflate=on,edat2=on,etoken=on,vx=on,ipter=on,mepochptff=on,ap=on,\ +vxeh=on,vxpd=on,esop=on,msa9_pckmo=on,vxeh2=on,esort=on,apqi=on,apft=on,iep=on,\ +apqci=on,cte=on,bpb=on,gs=on,ppa15=on,zpci=on,sea_esop2=on,te=on,cmm=on \ -m 256 \ -overcommit mem-lock=off \ -smp 1,sockets=1,cores=1,threads=1 \ diff --git a/tests/qemuxml2argvdata/s390x-ccw-graphics.s390x-latest.args b/tests/qemuxml2argvdata/s390x-ccw-graphics.s390x-latest.args index 8f72b20b..5850b265 100644 --- a/tests/qemuxml2argvdata/s390x-ccw-graphics.s390x-latest.args +++ b/tests/qemuxml2argvdata/s390x-ccw-graphics.s390x-latest.args @@ -26,9 +26,11 @@ file=/tmp/lib/domain--1-guest/master-key.aes \ -no-shutdown \ -boot strict=on \ -device virtio-serial-ccw,id=virtio-serial0,devno=fe.0.0003 \ --drive file=/var/lib/libvirt/images/guest.qcow2,format=qcow2,if=none,\ -id=drive-virtio-disk0 \ --device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,\ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/guest.qcow2",\ +"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"qcow2",\ +"file":"libvirt-1-storage"}' \ +-device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=libvirt-1-format,\ id=virtio-disk0,bootindex=1 \ -netdev user,id=hostnet0 \ -device virtio-net-ccw,netdev=hostnet0,id=net0,mac=52:54:00:09:1a:29,\ diff --git a/tests/qemuxml2argvdata/s390x-ccw-headless.s390x-latest.args b/tests/qemuxml2argvdata/s390x-ccw-headless.s390x-latest.args index 95caf9e9..211cc24b 100644 --- a/tests/qemuxml2argvdata/s390x-ccw-headless.s390x-latest.args +++ b/tests/qemuxml2argvdata/s390x-ccw-headless.s390x-latest.args @@ -27,9 +27,11 @@ file=/tmp/lib/domain--1-guest/master-key.aes \ -no-shutdown \ -boot strict=on \ -device virtio-serial-ccw,id=virtio-serial0,devno=fe.0.0002 \ --drive file=/var/lib/libvirt/images/guest.qcow2,format=qcow2,if=none,\ -id=drive-virtio-disk0 \ --device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,\ +-blockdev '{"driver":"file","filename":"/var/lib/libvirt/images/guest.qcow2",\ +"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"qcow2",\ +"file":"libvirt-1-storage"}' \ +-device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=libvirt-1-format,\ id=virtio-disk0,bootindex=1 \ -netdev user,id=hostnet0 \ -device virtio-net-ccw,netdev=hostnet0,id=net0,mac=52:54:00:09:a4:37,\ diff --git a/tests/qemuxml2argvdata/vhost-vsock-ccw-auto.s390x-latest.args b/tests/qemuxml2argvdata/vhost-vsock-ccw-auto.s390x-latest.args index 17b5ded6..4c5542d8 100644 --- a/tests/qemuxml2argvdata/vhost-vsock-ccw-auto.s390x-latest.args +++ b/tests/qemuxml2argvdata/vhost-vsock-ccw-auto.s390x-latest.args @@ -26,8 +26,11 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ -rtc base=utc \ -no-shutdown \ -boot strict=on \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-virtio-disk0 \ --device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,\ +-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1",\ +"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"raw",\ +"file":"libvirt-1-storage"}' \ +-device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=libvirt-1-format,\ id=virtio-disk0,bootindex=1 \ -device virtio-balloon-ccw,id=balloon0,devno=fe.0.0001 \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,\ diff --git a/tests/qemuxml2argvdata/vhost-vsock-ccw.s390x-latest.args b/tests/qemuxml2argvdata/vhost-vsock-ccw.s390x-latest.args index 81a6b8cb..de229bd0 100644 --- a/tests/qemuxml2argvdata/vhost-vsock-ccw.s390x-latest.args +++ b/tests/qemuxml2argvdata/vhost-vsock-ccw.s390x-latest.args @@ -26,8 +26,11 @@ file=/tmp/lib/domain--1-QEMUGuest1/master-key.aes \ -rtc base=utc \ -no-shutdown \ -boot strict=on \ --drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-virtio-disk0 \ --device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=drive-virtio-disk0,\ +-blockdev '{"driver":"host_device","filename":"/dev/HostVG/QEMUGuest1",\ +"node-name":"libvirt-1-storage","auto-read-only":true,"discard":"unmap"}' \ +-blockdev '{"node-name":"libvirt-1-format","read-only":false,"driver":"raw",\ +"file":"libvirt-1-storage"}' \ +-device virtio-blk-ccw,scsi=off,devno=fe.0.0000,drive=libvirt-1-format,\ id=virtio-disk0,bootindex=1 \ -device virtio-balloon-ccw,id=balloon0,devno=fe.0.0001 \ -sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,\ -- 2.24.1

3 2

[PATCH v2 0/4] APIC-EOI, pvspinlock, hyperv and PMU changes
by Daniel Henrique Barboza 25 Mar '20

25 Mar '20

Changes in v2: - changed patch series name to reflect the new approach - Make APIC-EIO exclusive to x86 - Make pvspinlock exclusive to x86 - Make hyperv exclusive to x86 and aarch64 - allow PMU to be declared as 'on' for ppc64 - previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg00718.html Daniel Henrique Barboza (4): qemu: avoid launching non-x86 guests with APIC-EOI setting qemu: avoid launching non-x86 guests with 'pvspinlock' setting qemu: make Hyperv settings exclusive to x86 and aarch64 qemu: allow PMU feature to be enabled for ppc64 guests src/qemu/qemu_command.c | 4 ++- src/qemu/qemu_domain.c | 55 ++++++++++++++++++++++++++++++++++++++--- 2 files changed, 54 insertions(+), 5 deletions(-) -- 2.25.1

2 8

[PATCH 00/12] qemu: More fixes for qemuDomainGetGuestInfo
by Peter Krempa 25 Mar '20

25 Mar '20

This fixes other issues pointed out in the review of my previous fix for crash in qemuDomainGetGuestInfo. Peter Krempa (12): qemuDomainGetGuestInfo: don't assign NULL hostname qemuDomainGetGuestInfo: Validate supported information types qemuAgentCheckError: use g_autofree qemuAgentCommand: Wire up suppressing of error reporting for unsupported commands qemuAgentGetUsers: Fix return value on success qemuAgentGetHostname: Refactor to remove cleanup section qemuAgentGetHostname: expose 'report_unsupported' argument qemuAgentGetUsers: expose 'report_unsupported' argument qemuAgentGetOSInfo: expose 'report_unsupported' argument qemuAgentGetTimezone: expose 'report_unsupported' argument qemuAgentGetFSInfo: expose 'report_unsupported' argument qemuDomainGetGuestInfo: Suppress non-fatal errors src/qemu/qemu_agent.c | 194 ++++++++++++++++++++--------------------- src/qemu/qemu_agent.h | 16 ++-- src/qemu/qemu_driver.c | 89 ++++++++++--------- tests/qemuagenttest.c | 14 +-- 4 files changed, 162 insertions(+), 151 deletions(-) -- 2.24.1

2 24

[PATCH 0/7] Move video default logic to individual drivers
by Rafael Fonseca 25 Mar '20

25 Mar '20

The logic setting a device default should be in the post parse function of individual driver code, not in `src/conf/domain_conf.c`. Rafael Fonseca (7): bhyve: move video default logic to driver libxl: move video default logic to driver vz: openvz: move video default logic to driver vmx: vmware: move video default logic to driver test: move video default logic to driver vbox: move video default logic to driver conf: domain_conf: remove virDomainVideoDefaultType src/bhyve/bhyve_domain.c | 5 ++++ src/conf/domain_conf.c | 52 +++------------------------------ src/conf/domain_conf.h | 1 - src/libvirt_private.syms | 1 - src/libxl/libxl_domain.c | 60 +++++++++++++++++++++++--------------- src/openvz/openvz_conf.c | 8 +++++ src/test/test_driver.c | 23 +++++++++++++++ src/vbox/vbox_common.c | 16 ++++++++++ src/vmware/vmware_driver.c | 4 +++ src/vmx/vmx.c | 4 +++ src/vz/vz_driver.c | 8 +++++ 11 files changed, 108 insertions(+), 74 deletions(-) -- 2.25.1

2 8

[libvirt PATCH] util: keep the pidfile locked
by marcandre.lureau＠redhat.com 25 Mar '20

25 Mar '20

From: Marc-André Lureau <marcandre.lureau(a)redhat.com> Unfortunately, advisory record locking lose the lock if any fd refering to the file is closed. There doesn't seem to be a way to preserve the lock atomically. We could eventually retake the lock if low pidfilefd is required. This fixes processes being leaked, as they are not killed in virPidFileForceCleanupPath() if the lock can be taken. Here also, we may consider this is not good enough, as a process may leak by simply closing the pidfilefd. Fixes commit d146105f1e4a9e0ab179f0b78c070ea38b9d5334 ("virCommand: Actually acquire pidfile instead of just writing it") Signed-off-by: Marc-André Lureau <marcandre.lureau(a)redhat.com> --- src/util/vircommand.c | 12 ++---------- tests/commanddata/test4.log | 2 +- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 77078d09fb..b84fb40948 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -797,8 +797,7 @@ virExec(virCommandPtr cmd) virProcessSetMaxCoreSize(0, cmd->maxCore) < 0) goto fork_error; if (cmd->pidfile) { - VIR_AUTOCLOSE pidfilefd = -1; - int newpidfilefd = -1; + int pidfilefd = -1; char c; pidfilefd = virPidFileAcquirePath(cmd->pidfile, false, getpid()); @@ -818,14 +817,7 @@ virExec(virCommandPtr cmd) VIR_FORCE_CLOSE(pipesync[0]); VIR_FORCE_CLOSE(pipesync[1]); - /* This is here only to move the pidfilefd - * to the lowest possible number. */ - if ((newpidfilefd = dup(pidfilefd)) < 0) { - virReportSystemError(errno, "%s", _("Unable to dup FD")); - goto fork_error; - } - - /* newpidfilefd is intentionally leaked. */ + /* pidfilefd is intentionally leaked. */ } if (cmd->hook) { diff --git a/tests/commanddata/test4.log b/tests/commanddata/test4.log index 5820f28307..24a37a7e96 100644 --- a/tests/commanddata/test4.log +++ b/tests/commanddata/test4.log @@ -9,7 +9,7 @@ ENV:USER=test FD:0 FD:1 FD:2 -FD:3 +FD:5 DAEMON:yes CWD:/ UMASK:0022 -- 2.26.0.rc2.42.g98cedd0233

2 1

[libvirt] [PATCH v4 0/2] introduction of migration_version attribute for VFIO live migration
by Yan Zhao 25 Mar '20

25 Mar '20

This patchset introduces a migration_version attribute under sysfs of VFIO Mediated devices. This migration_version attribute is used to check migration compatibility between two mdev devices of the same mdev type. Patch 1 defines migration_version attribute in Documentation/vfio-mediated-device.txt Patch 2 uses GVT as an example to show how to expose migration_version attribute and check migration compatibility in vendor driver. v4: 1. fixed indentation/spell errors, reworded several error messages 2. added a missing memory free for error handling in patch 2 v3: 1. renamed version to migration_version 2. let errno to be freely defined by vendor driver 3. let checking mdev_type be prerequisite of migration compatibility check 4. reworded most part of patch 1 5. print detailed error log in patch 2 and generate migration_version string at init time v2: 1. renamed patched 1 2. made definition of device version string completely private to vendor driver 3. reverted changes to sample mdev drivers 4. described intent and usage of version attribute more clearly. Yan Zhao (2): vfio/mdev: add migration_version attribute for mdev device drm/i915/gvt: export migration_version to mdev sysfs for Intel vGPU Documentation/vfio-mediated-device.txt | 113 +++++++++++++ drivers/gpu/drm/i915/gvt/Makefile | 2 +- drivers/gpu/drm/i915/gvt/gvt.c | 39 +++++ drivers/gpu/drm/i915/gvt/gvt.h | 5 + drivers/gpu/drm/i915/gvt/migration_version.c | 168 +++++++++++++++++++ drivers/gpu/drm/i915/gvt/vgpu.c | 13 +- 6 files changed, 337 insertions(+), 3 deletions(-) create mode 100644 drivers/gpu/drm/i915/gvt/migration_version.c -- 2.17.1

3 9

[libvirt PATCH] docs: news: fix typo
by Ján Tomko 24 Mar '20

24 Mar '20

s/ommited/omitted/ Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial docs/news.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/news.xml b/docs/news.xml index 504cf52738..bcec1d81e9 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -51,7 +51,7 @@ <description> QEMU 5.0 implements NVDIMM memory support for pSeries guests. This is done by adding an 'uuid' element in the memory XML, which can - either be provided in the XML or, if ommited, generated + either be provided in the XML or, if omitted, generated automatically. </description> </change> -- 2.25.1

1 0

[PATCH] qemu: softfail for TCG capabilities probe
by Tobin Feldman-Fitzthum 24 Mar '20

24 Mar '20

As of version 2.10, QEMU can be built without the TCG. When libvirt determines that capabilities of a QEMU binary using QMP, it launches a QEMU process with KVM acceleration and TCG as a fallback. If QEMU supports KVM, a second probe is performed, forcing QEMU to use only TCG. This causes an error if the QEMU binary was built without TCG. This patch allows execution to continue when the second probe fails. Thus libvirt can be used with QEMU built without TCG. First patch. Feedback appreciated. If better solution, please advise. Signed-off-by: Tobin Feldman-Fitzthum <tobin(a)linux.vnet.ibm.com> --- src/qemu/qemu_capabilities.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index a95a60c36a..f303171cc4 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5100,9 +5100,6 @@ virQEMUCapsInitQMPSingle(virQEMUCapsPtr qemuCaps, ret = virQEMUCapsInitQMPMonitor(qemuCaps, proc->mon); cleanup: - if (ret < 0) - virQEMUCapsLogProbeFailure(qemuCaps->binary); - qemuProcessQMPFree(proc); return ret; } @@ -5114,17 +5111,18 @@ virQEMUCapsInitQMP(virQEMUCapsPtr qemuCaps, uid_t runUid, gid_t runGid) { - if (virQEMUCapsInitQMPSingle(qemuCaps, libDir, runUid, runGid, false) < 0) + if (virQEMUCapsInitQMPSingle(qemuCaps, libDir, runUid, runGid, false) < 0) { + virQEMUCapsLogProbeFailure(qemuCaps->binary); return -1; + } /* * If KVM was enabled during the first probe, we need to explicitly probe * for TCG capabilities by asking the same binary again and turning KVM * off. */ - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM) && - virQEMUCapsInitQMPSingle(qemuCaps, libDir, runUid, runGid, true) < 0) - return -1; + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM)) + virQEMUCapsInitQMPSingle(qemuCaps, libDir, runUid, runGid, true); return 0; } -- 2.20.1 (Apple Git-117)

2 1

[libvirt PATCH 0/5] gitlab: expand the CI job coverage (RESEND)
by Daniel P. Berrangé 24 Mar '20

24 Mar '20

There are two main goals with this series - Introduce a minimal job building the website and publishing an artifact which can be deployed onto libvirt.org - Expanding CI jobs to get coverage closer to Travis/Jenkins Previous posting lost last two mails due to transient SMTP problem Daniel P. Berrangé (5): gitlab: use CI for building website contents gitlab: reduce number of cross-build CI jobs gitlab: group jobs into stages gitlab: add several native CI jobs gitlab: rename the cross build jobs .gitlab-ci.yml | 105 +++++++++++++++++++++++++++++++++++-------------- 1 file changed, 75 insertions(+), 30 deletions(-) -- 2.24.1

3 29

[PATCH v1 0/4] Prevent ppc64 guest launch with broken features
by Daniel Henrique Barboza 24 Mar '20

24 Mar '20

Hi, This work was intended to fix a bug with APIC-EOI setting only (patch 1). I decided to take a closer look and ended up handling more cases. I consider the first 3 patches to be straightforward: those are conditions that QEMU will complain about and I'm simply refusing to launch while giving a better error message than the one QEMU provides. Patch 4 is more debatable. <hyperv><hyperv/> declaration in the XML is benign, but any of the 14 features being declared will cause QEMU errors. Instead of putting more code (i.e. a switch with 14 features in the middle of the code) to prevent any of those features to be enabled, I made a call to simply refuse to launch with any <hyperv> setting in the XML. This is not because I have a beef with Windows or MS or anything. This is about making an educated guess that it's highly unlikable that anyone is running ppc64 guests with <hyperv> declared in the XML, and it's not worth all the code to support it. But I'm all ears to hear otherwise. After this series, these are the features that aren't supported by ppc64 but can be declared in a ppc64 guest without resulting in a failed launch: <features> <acpi/> <apic/> (without 'eoi' setting) <pae/> <hap state='on|off'/> <viridian/> </features> Daniel Henrique Barboza (4): qemu_domain.c: do not launch ppc64 guests with APIC-EOI setting qemu_domain.c: do not launch ppc64 guests with 'pvspinlock' setting qemu_domain.c: do not launch ppc64 guests with 'pmu' setting qemu_domain.c: do not launch ppc64 guests with Hyperv settings src/qemu/qemu_domain.c | 49 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 45 insertions(+), 4 deletions(-) -- 2.25.1

3 18

[PATCH] qemu_monitor_text.c: Use g_autofree
by Seeteena Thoufeek 24 Mar '20

24 Mar '20

Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/qemu/qemu_monitor_text.c | 85 ++++++++++++++++---------------------------- 1 file changed, 30 insertions(+), 55 deletions(-) diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index 9135a11..5a890af 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -36,27 +36,26 @@ VIR_LOG_INIT("qemu.qemu_monitor_text"); int qemuMonitorTextAddDrive(qemuMonitorPtr mon, const char *drivestr) { - char *cmd = NULL; - char *reply = NULL; - int ret = -1; + g_autofree char *cmd = NULL; + g_autofree char *reply = NULL; /* 'dummy' here is just a placeholder since there is no PCI * address required when attaching drives to a controller */ cmd = g_strdup_printf("drive_add dummy %s", drivestr); if (qemuMonitorJSONHumanCommand(mon, cmd, &reply) < 0) - goto cleanup; + return -1; if (strstr(reply, "unknown command:")) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("drive hotplug is not supported")); - goto cleanup; + return -1; } if (strstr(reply, "could not open disk image")) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("open disk image file failed")); - goto cleanup; + return -1; } if (strstr(reply, "Could not open")) { @@ -66,48 +65,41 @@ int qemuMonitorTextAddDrive(qemuMonitorPtr mon, virReportError(VIR_ERR_OPERATION_FAILED, "%s", reply); - goto cleanup; + return -1; } if (strstr(reply, "Image is not in")) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", _("Incorrect disk format")); - goto cleanup; + return -1; } if (strstr(reply, "IOMMU") || strstr(reply, "VFIO")) { virReportError(VIR_ERR_OPERATION_FAILED, "%s", reply); - goto cleanup; + return -1; } - ret = 0; - - cleanup: - VIR_FREE(cmd); - VIR_FREE(reply); - return ret; + return 0; } int qemuMonitorTextDriveDel(qemuMonitorPtr mon, const char *drivestr) { - char *cmd = NULL; - char *reply = NULL; - int ret = -1; + g_autofree char *cmd = NULL; + g_autofree char *reply = NULL; cmd = g_strdup_printf("drive_del %s", drivestr); if (qemuMonitorJSONHumanCommand(mon, cmd, &reply) < 0) - goto cleanup; + return -1; if (strstr(reply, "unknown command:")) { VIR_ERROR(_("deleting drive is not supported. " "This may leak data if disk is reassigned")); - ret = 1; - goto cleanup; + return 1; /* (qemu) drive_del wark * Device 'wark' not found */ @@ -117,15 +109,10 @@ int qemuMonitorTextDriveDel(qemuMonitorPtr mon, } else if (STRNEQ(reply, "")) { virReportError(VIR_ERR_OPERATION_FAILED, _("deleting %s drive failed: %s"), drivestr, reply); - goto cleanup; + return -1; } - ret = 0; - - cleanup: - VIR_FREE(cmd); - VIR_FREE(reply); - return ret; + return 0; } int @@ -159,28 +146,27 @@ qemuMonitorTextCreateSnapshot(qemuMonitorPtr mon, int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name) { - char *cmd = NULL; - char *reply = NULL; - int ret = -1; + g_autofree char *cmd = NULL; + g_autofree char *reply = NULL; cmd = g_strdup_printf("loadvm \"%s\"", name); if (qemuMonitorJSONHumanCommand(mon, cmd, &reply)) - goto cleanup; + return -1; if (strstr(reply, "No block device supports snapshots")) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("this domain does not have a device to load snapshots")); - goto cleanup; + return -1; } else if (strstr(reply, "Could not find snapshot")) { virReportError(VIR_ERR_OPERATION_INVALID, _("the snapshot '%s' does not exist, and was not loaded"), name); - goto cleanup; + return -1; } else if (strstr(reply, "Snapshots not supported on device")) { virReportError(VIR_ERR_OPERATION_INVALID, _("Failed to load snapshot: %s"), reply); - goto cleanup; + return -1; } else if (strstr(reply, "Could not open VM state file") || strstr(reply, "Error: ") || (strstr(reply, "Error") && @@ -188,46 +174,35 @@ int qemuMonitorTextLoadSnapshot(qemuMonitorPtr mon, const char *name) strstr(reply, "while activating snapshot on")))) { virReportError(VIR_ERR_OPERATION_FAILED, _("Failed to load snapshot: %s"), reply); - goto cleanup; + return -1; } - ret = 0; - - cleanup: - VIR_FREE(cmd); - VIR_FREE(reply); - return ret; + return 0; } int qemuMonitorTextDeleteSnapshot(qemuMonitorPtr mon, const char *name) { - char *cmd = NULL; - char *reply = NULL; - int ret = -1; + g_autofree char *cmd = NULL; + g_autofree char *reply = NULL; cmd = g_strdup_printf("delvm \"%s\"", name); if (qemuMonitorJSONHumanCommand(mon, cmd, &reply)) - goto cleanup; + return -1; if (strstr(reply, "No block device supports snapshots")) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("this domain does not have a device to delete snapshots")); - goto cleanup; + return -1; } else if (strstr(reply, "Snapshots not supported on device")) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", reply); - goto cleanup; + return -1; } else if (strstr(reply, "Error: ") || (strstr(reply, "Error") && strstr(reply, "while deleting snapshot"))) { virReportError(VIR_ERR_OPERATION_FAILED, _("Failed to delete snapshot: %s"), reply); - goto cleanup; + return -1; } - ret = 0; - - cleanup: - VIR_FREE(cmd); - VIR_FREE(reply); - return ret; + return 0; } -- 1.8.3.1

3 2

[PATCH] commandtest: Fix test28 error detection
by Michal Privoznik 24 Mar '20

24 Mar '20

As a part of c799d150d5e9dae I've introduced a test case that tests whether passing error object between processes works. The test spawns a child which reports a system error, parent process then reads the error and compares with expected output. Problem with this approach is that error message contains stringified errno which is not portable. FreeBSD has generally different messages than Linux. Therefore, use g_strerror() to do the errno to string translation for us. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/commandtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/commandtest.c b/tests/commandtest.c index f4a2c67c05..d5092b7dd0 100644 --- a/tests/commandtest.c +++ b/tests/commandtest.c @@ -1272,6 +1272,7 @@ test28(const void *unused G_GNUC_UNUSED) /* Not strictly a virCommand test, but this is the easiest place * to test this lower-level interface. */ virErrorPtr err; + g_autofree char *msg = g_strdup_printf("some error message: %s", g_strerror(ENODATA)); if (virProcessRunInFork(test28Callback, NULL) != -1) { fprintf(stderr, "virProcessRunInFork did not fail\n"); @@ -1285,10 +1286,10 @@ test28(const void *unused G_GNUC_UNUSED) if (!(err->code == VIR_ERR_SYSTEM_ERROR && err->domain == 0 && - STREQ(err->message, "some error message: No data available") && + STREQ(err->message, msg) && err->level == VIR_ERR_ERROR && STREQ(err->str1, "%s") && - STREQ(err->str2, "some error message: No data available") && + STREQ(err->str2, msg) && err->int1 == ENODATA && err->int2 == -1)) { fprintf(stderr, "Unexpected error object\n"); -- 2.24.1

2 1

[PATCH 0/6] Couple of qemu NS improvements
by Michal Privoznik 24 Mar '20

24 Mar '20

The most important patch is 6/6 which relies on 5/6. The rest is just a few small nits I've noticed and had stuck on my local branch. Michal Prívozník (6): qemuDomainCreateDeviceRecursive: Report error if mkdir() fails qemuDomainBuildNamespace: Try harder to remove temp directories qemuDomainBuildNamespace: Make @devPath const virfile: Handle directories in virFileBindMountDevice() virprocess: Passthru error from virProcessRunInForkHelper security: Try harder to run transactions build-aux/syntax-check.mk | 2 +- src/qemu/qemu_domain.c | 13 +++++++-- src/security/security_dac.c | 16 ++++++++--- src/security/security_selinux.c | 16 ++++++++--- src/util/virfile.c | 13 +++++++-- src/util/virprocess.c | 51 ++++++++++++++++++++++++++++++--- tests/commandtest.c | 43 +++++++++++++++++++++++++++ 7 files changed, 136 insertions(+), 18 deletions(-) -- 2.24.1

6 16

[PATCH 00/14] qemu: Fix 'backing store' string generator for -blockdev
by Peter Krempa 24 Mar '20

24 Mar '20

QEMU doesn't like the backing store string generated by libvirt with -blockdev. Luckily we are able to parse them back and with blockdev they would no longer be used by qemu directly. Fix the generator an da few issues noticed along. Peter Krempa (14): conf: rename 'namespace' property of struct _virStorageSourceNVMeDef qemublocktest: xml->json: Add test for NVMe virDomainDiskSourceNVMeFormat: Format only valid 'managed' values qemublocktest: xml->json: Refactor cleanup in test case functions testQemuDiskXMLToPropsValidateFileSrcOnly: Move together with rest of xml->json code qemuBlockGetBackingStoreString: Add 'pretty' argument testQemuDiskXMLToProps: Store all per-image data in one structure qemublocktest: Test backing store strings qemuBlockGetBackingStoreString: Remove 'ret' variable storage: Implement backing store support for "fat:" prefix qemuBlockGetBackingStoreString: Add extra wrapping object to JSON strings qemu: block: Extract formatting of cookie string qemuBlockGetBackingStoreString: Properly handle 'http/s' with cookies and others storage: Parse 'nvme' disk source properties from json:{} pseudo-uri src/conf/domain_conf.c | 17 +- src/hypervisor/virhostdev.c | 2 +- src/qemu/qemu_block.c | 64 +++-- src/qemu/qemu_block.h | 6 +- src/qemu/qemu_domain.c | 13 +- src/qemu/qemu_driver.c | 4 +- src/util/virstoragefile.c | 43 +++- src/util/virstoragefile.h | 2 +- tests/qemublocktest.c | 232 ++++++++++-------- .../qcow2-backing-qcow2-slice.json | 2 +- .../imagecreate/qcow2-backing-raw-slice.json | 2 +- .../xml2json/block-raw-noopts-srconly.json | 13 +- .../block-raw-reservations-srconly.json | 13 +- .../xml2json/dir-fat-cache-srconly.json | 15 +- .../xml2json/dir-fat-floppy-srconly.json | 15 +- .../xml2json/dir-fat-readonly-srconly.json | 15 +- ...ile-backing_basic-aio_threads-srconly.json | 68 +++-- ...acking_basic-cache-directsync-srconly.json | 68 +++-- ...file-backing_basic-cache-none-srconly.json | 68 +++-- ...le-backing_basic-cache-unsafe-srconly.json | 68 +++-- ...backing_basic-cache-writeback-srconly.json | 68 +++-- ...king_basic-cache-writethrough-srconly.json | 68 +++-- .../file-backing_basic-detect-srconly.json | 68 +++-- .../file-backing_basic-noopts-srconly.json | 52 ++-- ...le-backing_basic-unmap-detect-srconly.json | 68 +++-- ...le-backing_basic-unmap-ignore-srconly.json | 68 +++-- .../file-backing_basic-unmap-srconly.json | 68 +++-- .../xml2json/file-bochs-noopts-srconly.json | 13 +- .../xml2json/file-cloop-noopts-srconly.json | 13 +- .../xml2json/file-dmg-noopts-srconly.json | 13 +- .../xml2json/file-ploop-noopts-srconly.json | 13 +- ...cow2-backing-chain-encryption-srconly.json | 26 +- ...le-qcow2-backing-chain-noopts-srconly.json | 130 +++++++--- ...w2-backing-chain-unterminated-srconly.json | 26 +- .../xml2json/file-raw-aio_native-srconly.json | 13 +- .../xml2json/file-raw-luks-srconly.json | 13 +- .../xml2json/file-raw-noopts-srconly.json | 13 +- .../xml2json/file-vdi-noopts-srconly.json | 13 +- .../xml2json/file-vhd-noopts-srconly.json | 13 +- .../xml2json/file-vpc-noopts-srconly.json | 13 +- .../network-http-curlopts-srconly.json | 17 ++ .../xml2json/network-http-curlopts.json | 15 ++ .../xml2json/network-http-curlopts.xml | 20 ++ .../xml2json/network-http-noopts-srconly.json | 9 + .../xml2json/network-http-noopts.json | 14 ++ .../xml2json/network-http-noopts.xml | 15 ++ .../xml2json/network-nbd-tls-srconly.json | 19 +- ...w2-backing-chain-cache-unsafe-srconly.json | 69 ++++-- ...backing-chain-encryption_auth-srconly.json | 69 ++++-- .../xml2json/nvme-raw-noopts-srconly.json | 15 ++ .../xml2json/nvme-raw-noopts.json | 14 ++ .../xml2json/nvme-raw-noopts.xml | 13 + tests/virstoragetest.c | 10 + 53 files changed, 1226 insertions(+), 575 deletions(-) create mode 100644 tests/qemublocktestdata/xml2json/network-http-curlopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/network-http-curlopts.json create mode 100644 tests/qemublocktestdata/xml2json/network-http-curlopts.xml create mode 100644 tests/qemublocktestdata/xml2json/network-http-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/network-http-noopts.json create mode 100644 tests/qemublocktestdata/xml2json/network-http-noopts.xml create mode 100644 tests/qemublocktestdata/xml2json/nvme-raw-noopts-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/nvme-raw-noopts.json create mode 100644 tests/qemublocktestdata/xml2json/nvme-raw-noopts.xml -- 2.24.1

2 17

[PATCH RESEND 0/5] virCommand: fix approach to pidfiles
by Michal Privoznik 24 Mar '20

24 Mar '20

The original series doesn't apply cleanly anymore: https://www.redhat.com/archives/libvir-list/2020-March/msg00499.html Here's the rebased one. Michal Prívozník (5): virCommand: Actually acquire pidfile instead of just writing it qemuProcessStartManagedPRDaemon: Don't pass -f pidfile to the daemon qemuSlirpStop: Simplify helper kill qemuVirtioFSStop: Simplify daemon kill bridge_driver: Replace and drop networkKillDaemon docs/internals/command.html.in | 4 +- src/network/bridge_driver.c | 106 ++++++--------------------------- src/qemu/qemu_process.c | 9 --- src/qemu/qemu_slirp.c | 16 ++--- src/qemu/qemu_virtiofs.c | 21 +++---- src/util/vircommand.c | 56 ++++++++++++++--- tests/commanddata/test4.log | 1 + 7 files changed, 81 insertions(+), 132 deletions(-) -- 2.24.1

3 12

[PATCH] util: virhostcpu: Fail when fetching CPU Stats for invalid cpu
by Mauro S. M. Rodrigues 24 Mar '20

24 Mar '20

virHostCPUGetStatsLinux walks through every cpu in /proc/stat until it finds cpu%cpuNum that matches with the requested cpu. If none is found it logs the error but it should return -1, instead of 0. Otherwise virsh nodecpustats --cpu <invalid cpu number> and API bindings don't fail properly, printing a blank line instead of an error message. This patch also includes an additional test for virhostcputest to avoid this regression to happen again in the future. Reported-by: Satheesh Rajendran <satheera(a)in.ibm.com> Signed-off-by: Mauro S. M. Rodrigues <maurosr(a)linux.vnet.ibm.com> --- src/util/virhostcpu.c | 2 +- tests/virhostcputest.c | 9 ++++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/util/virhostcpu.c b/src/util/virhostcpu.c index 81293eea8c..20c8d0ce6c 100644 --- a/src/util/virhostcpu.c +++ b/src/util/virhostcpu.c @@ -847,7 +847,7 @@ virHostCPUGetStatsLinux(FILE *procstat, _("Invalid cpuNum in %s"), __FUNCTION__); - return 0; + return -1; } diff --git a/tests/virhostcputest.c b/tests/virhostcputest.c index 7865b61578..2f569d8bd4 100644 --- a/tests/virhostcputest.c +++ b/tests/virhostcputest.c @@ -258,14 +258,17 @@ mymain(void) if (virTestRun(nodeData[i].testName, linuxTestHostCPU, &nodeData[i]) != 0) ret = -1; -# define DO_TEST_CPU_STATS(name, ncpus) \ +# define DO_TEST_CPU_STATS(name, ncpus, shouldFail) \ do { \ static struct nodeCPUStatsData data = { name, ncpus }; \ - if (virTestRun("CPU stats " name, linuxTestNodeCPUStats, &data) < 0) \ + if ((virTestRun("CPU stats " name, \ + linuxTestNodeCPUStats, \ + &data) < 0) != shouldFail) \ ret = -1; \ } while (0) - DO_TEST_CPU_STATS("24cpu", 24); + DO_TEST_CPU_STATS("24cpu", 24, false); + DO_TEST_CPU_STATS("24cpu", 25, true); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 2.24.1

3 2

Hot unplug disabling on pci-pci bridge
by Ani Sinha 24 Mar '20

24 Mar '20

Hi All : I have been playing with Qemu trying to disable hot-unplug capability for conventional PCI. I have discussed this briefly on IRC and the plan is to have an option on the pci-pci bridge that would disable SHPC and ACPI hotplug capability for all the slots on that bus. I am _not_ trying to implement a per slot capability for conventional PCI as was previously posted for PCIE slots in this patch : https://lists.gnu.org/archive/html/qemu-devel/2020-03/msg01833.html (we do not need this atm). I am following the conversations which happened few weeks back here: https://lists.gnu.org/archive/html/qemu-devel/2020-02/msg00985.html To that end, I have been experimenting with Qemu using the patch I mention below. I have attached the virtio balloon driver with bus 1 which is attached to the pci bridge. <controller type='pci' index='0' model='pci-root'> <alias name='pci.0'/> </controller> <controller type='pci' index='1' model='pci-bridge'> <model name='pci-bridge'/> <target chassisNr='1'/> <alias name='pci.1'/> <address type='pci' domain='0x0000' bus='0x00' slot='0x05' function='0x0'/> </controller> <memballoon model='virtio'> <stats period='30'/> <alias name='balloon0'/> <address type='pci' domain='0x0000' bus='0x02' slot='0x01' function='0x0'/> </memballoon> I am using a windows guest and from the guest I can see that the balloon driver is indeed attached to the pci bridge (see attached screenshot). I still find Windows giving me an option to hot eject the pci balloon driver. So what am I doing wrong here? [cid:87E6C01C-8B8C-4E24-AC4B-C0D746C2F605] The patch I am experimenting with (which is currently a hack) is attached below. It is based off libvirt 4.5 and not the latest mainline. --- hw/pci-bridge/pci_bridge_dev.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c b/hw/pci-bridge/pci_bridge_dev.c index b2d861d..e706d49 100644 --- a/hw/pci-bridge/pci_bridge_dev.c +++ b/hw/pci-bridge/pci_bridge_dev.c @@ -58,7 +58,7 @@ static void pci_bridge_dev_realize(PCIDevice *dev, Error **errp) pci_bridge_initfn(dev, TYPE_PCI_BUS); - if (bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) { + if (0) {//bridge_dev->flags & (1 << PCI_BRIDGE_DEV_F_SHPC_REQ)) { dev->config[PCI_INTERRUPT_PIN] = 0x1; memory_region_init(&bridge_dev->bar, OBJECT(dev), "shpc-bar", shpc_bar_size(dev)); @@ -161,7 +161,7 @@ static Property pci_bridge_dev_properties[] = { DEFINE_PROP_ON_OFF_AUTO(PCI_BRIDGE_DEV_PROP_MSI, PCIBridgeDev, msi, ON_OFF_AUTO_AUTO), DEFINE_PROP_BIT(PCI_BRIDGE_DEV_PROP_SHPC, PCIBridgeDev, flags, - PCI_BRIDGE_DEV_F_SHPC_REQ, true), + PCI_BRIDGE_DEV_F_SHPC_REQ, false), DEFINE_PROP_END_OF_LIST(), }; @@ -181,7 +181,7 @@ static const VMStateDescription pci_bridge_dev_vmstate = { VMSTATE_END_OF_LIST() } }; - +#if 0 static void pci_bridge_dev_hotplug_cb(HotplugHandler *hotplug_dev, DeviceState *dev, Error **errp) { @@ -208,12 +208,12 @@ static void pci_bridge_dev_hot_unplug_request_cb(HotplugHandler *hotplug_dev, } shpc_device_hot_unplug_request_cb(hotplug_dev, dev, errp); } - +#endif static void pci_bridge_dev_class_init(ObjectClass *klass, void *data) { DeviceClass *dc = DEVICE_CLASS(klass); PCIDeviceClass *k = PCI_DEVICE_CLASS(klass); - HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass); + //HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(klass); k->realize = pci_bridge_dev_realize; k->exit = pci_bridge_dev_exitfn; @@ -227,8 +227,8 @@ static void pci_bridge_dev_class_init(ObjectClass *klass, void *data) dc->props = pci_bridge_dev_properties; dc->vmsd = &pci_bridge_dev_vmstate; set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); - hc->plug = pci_bridge_dev_hotplug_cb; - hc->unplug_request = pci_bridge_dev_hot_unplug_request_cb; + //hc->plug = pci_bridge_dev_hotplug_cb; + //hc->unplug_request = pci_bridge_dev_hot_unplug_request_cb; } static const TypeInfo pci_bridge_dev_info = { @@ -238,7 +238,7 @@ static const TypeInfo pci_bridge_dev_info = { .class_init = pci_bridge_dev_class_init, .instance_finalize = pci_bridge_dev_instance_finalize, .interfaces = (InterfaceInfo[]) { - { TYPE_HOTPLUG_HANDLER }, + //{ TYPE_HOTPLUG_HANDLER }, { INTERFACE_CONVENTIONAL_PCI_DEVICE }, { } } -- 1.9.4

2 2

[libvirt-tck] scripts: fix disk media change test
by Jim Fehlig 24 Mar '20

24 Mar '20

Since the introduction of the 'index' attribute of a disk's <source> element, test 207-disk-media-change.t is failing. The test is a bit flawed in that it compares initial and final domXML after changing the media of a cdrom disk device. The test only needs to check the final domXML to ensure the correct <source> path exists at the end of the test. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- scripts/domain/207-disk-media-change.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/domain/207-disk-media-change.t b/scripts/domain/207-disk-media-change.t index dfef7c9..7a43afc 100644 --- a/scripts/domain/207-disk-media-change.t +++ b/scripts/domain/207-disk-media-change.t @@ -98,5 +98,5 @@ EOF my $finalxml = $dom->get_xml_description; - is($initialxml, $finalxml, "final XML matches initial XML"); + ok($finalxml =~ m|$path1|, "final XML has properly updated media"); } -- 2.25.0

3 2

[PATCH v4 0/6] NVDIMM suport for pSeries guests
by Daniel Henrique Barboza 24 Mar '20

24 Mar '20

changes in v4: - moved label size requirement from virDomainMemoryDefParseXML() to virDomainMemoryDefValidate() Previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg00769.html Daniel Henrique Barboza (6): qemu: capabilities: update qemu-5.0.0 capabilities for ppc64 conf: Introduce optional 'uuid' element for NVDIMM memory formatdomain.html.in: document the new 'uuid' NVDIMM element conf, qemu: enable NVDIMM support for ppc64 formatdomain.html.in: document NVDIMM 'label' requirement for pSeries news.xml: document the new NVDIMM support for Pseries guests docs/formatdomain.html.in | 24 +- docs/news.xml | 11 + docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 49 +- src/conf/domain_conf.h | 3 + src/qemu/qemu_command.c | 7 + src/qemu/qemu_domain.c | 63 +- src/qemu/qemu_domain.h | 4 +- src/qemu/qemu_hotplug.c | 6 +- tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 2 +- .../caps_5.0.0.ppc64.replies | 10949 +++++++++------- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1216 +- ...default-video-type-ppc64.ppc64-latest.args | 2 - .../memory-hotplug-nvdimm-ppc64.args | 32 + ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 36 + .../memory-hotplug-nvdimm-ppc64.xml | 50 + ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 10 +- ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 10 +- ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 10 +- ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 10 +- .../ppc64-pseries-graphics.ppc64-latest.args | 10 +- .../ppc64-pseries-headless.ppc64-latest.args | 10 +- .../tpm-emulator-spapr.ppc64-latest.args | 9 +- tests/qemuxml2argvtest.c | 1 + .../memory-hotplug-nvdimm-ppc64.xml | 50 + tests/qemuxml2xmltest.c | 2 + 28 files changed, 7028 insertions(+), 5573 deletions(-) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.ppc64-latest.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-ppc64.xml -- 2.25.1

2 7

Propose to extend the capability of arm cpu driver
by Zhenyu Zheng 24 Mar '20

24 Mar '20

Hello Libvirt, With more and more ARM servers on the market and increasing amount of users, we got reported alot that Libvirt cannot provide as much function on ARM platform as on other platforms(mainly x86), some basic founctions are missing, such as showing cpu model details and features using ``virsh capabilities``, comparing cpus etc. So I would like to propose to extend the capability of ARM cpu driver. Since I'm quite new here, I searched through the mailing list and did not find much information on this, so I would like to know that will this be something that I could work on? BR, Zhenyu Zheng

2 6

TCK regression from blockdev change
by Jim Fehlig 24 Mar '20

24 Mar '20

Hi all, I noticed libvirt-tck test 207-disk-media-change.t is failing with 6.1.0, although I _think_ the failure has actually been around since the change to using blockdev in the qemu driver. The test essentially creates a minimal domain with a cdrom disk device, then calls attach_device a few times, changing the <source> of the disk. The last attach_device uses the same <source> as when the domain was created and expects the initial and final XML to be the same. For reference, here's a link to the test https://libvirt.org/git/?p=libvirt-tck.git;a=blob;f=scripts/domain/207-disk… However the test fails since the 'index' attribute of the <source> element is not the same between initial XML (index='1') and final XML (index='5'). Indeed with each attach operation the index is incremented. Should libvirt be fixed to always provide an index of 1 for this disk config? Or should we adjust the test case? I'm not so familiar with this functionality but I lean towards the former since attaching a disk with a missing source (no media) results in odd looking disk config <disk type='file' device='cdrom'> <driver name='qemu' type='raw' cache='none'/> <source index='4'/> <target dev='hdc' bus='ide'/> <readonly/> <alias name='ide0-1-0'/> <address type='drive' controller='0' bus='1' target='0' unit='0'/> </disk> Regards, Jim

2 2

[PATCH v2 0/5] NVDIMM suport for pSeries guests
by Daniel Henrique Barboza 23 Mar '20

23 Mar '20

changes in v2, all of them affecting just pSeries guests: - added 'label' requirement - added code to align down the NVDIMM device previous version: https://www.redhat.com/archives/libvir-list/2020-March/msg00165.html This patch series adds NVDIMM suport for ppc64 guests, which consists on adding an extra 'uuid' element in the nvdimm command line and the target label size must always be provided in the memory definition. No changes were made in the existing NVDIMM support for x86 and other archs. Daniel Henrique Barboza (5): conf: Introduce optional 'uuid' element for NVDIMM memory formatdomain.html.in: document the new 'uuid' NVDIMM element conf, qemu: enable NVDIMM support for ppc64 formatdomain.html.in: document NVDIMM 'label' requirement for pSeries news.xml: document the new NVDIMM support for Pseries guests docs/formatdomain.html.in | 24 +++++++-- docs/news.xml | 11 ++++ docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 44 ++++++++++++++-- src/conf/domain_conf.h | 3 ++ src/qemu/qemu_command.c | 7 +++ src/qemu/qemu_domain.c | 47 +++++++++++++++-- .../memory-hotplug-nvdimm-ppc64.args | 32 ++++++++++++ .../memory-hotplug-nvdimm-ppc64.xml | 50 +++++++++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../memory-hotplug-nvdimm-ppc64.xml | 50 +++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 12 files changed, 268 insertions(+), 11 deletions(-) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.args create mode 100644 tests/qemuxml2argvdata/memory-hotplug-nvdimm-ppc64.xml create mode 100644 tests/qemuxml2xmloutdata/memory-hotplug-nvdimm-ppc64.xml -- 2.24.1

3 10

[libvirt PATCH 0/4] qemu: virtiofs fixes
by Ján Tomko 23 Mar '20

23 Mar '20

Shorten some paths and kill the whole process group instead of just the parent. Ján Tomko (4): qemu: virtiofs: kill the whole process group when stopping qemu: virtiofs: shorten pid filename qemu: virtiofs: shorten socket filename qemu: virtiofs: use a .log.fs suffix for logs src/qemu/qemu_virtiofs.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) -- 2.25.1

3 12