- Devel - libvirt List Archives

[PATCH] doc/python: Update to Python 3
by Philipp Hahn 20 Apr '20

20 Apr '20

Convert the simple example to Python 3 syntax: - print() is a function - do not use bare except - libvirt.open*() does not return None but raises an exception The referenced source for the example was removed with 5bb2a245abbde4c0a407f631660e2f2c81bc4c02 --- docs/python.html.in | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/docs/python.html.in b/docs/python.html.in index e6e8cfade9..0f804da8c3 100644 --- a/docs/python.html.in +++ b/docs/python.html.in @@ -38,24 +38,24 @@ specificities in their argument conversions: is replaced by <code>virDomain::info()</code> which returns a list of <ol><li>state: one of the state values (virDomainState)</li><li>maxMemory: the maximum memory used by the domain</li><li>memory: the current amount of memory used by the domain</li><li>nbVirtCPU: the number of virtual CPU</li><li>cpuTime: the time used by the domain in nanoseconds</li></ol></li> </ul> - So let's look at a simple example inspired from the <code>basic.py</code> -test found in <code>python/tests/</code> in the source tree: + So let's look at a simple example: <pre>import libvirt import sys -conn = libvirt.openReadOnly(None) -if conn == None: - print 'Failed to open connection to the hypervisor' +try: + conn = libvirt.openReadOnly(None) +except libvirt.libvirtError: + print('Failed to open connection to the hypervisor') sys.exit(1) try: dom0 = conn.lookupByName("Domain-0") -except: - print 'Failed to find the main domain' +except libvirt.libvirtError: + print('Failed to find the main domain') sys.exit(1) -print "Domain 0: id %d running %s" % (dom0.ID(), dom0.OSType()) -print dom0.info()</pre> +print("Domain 0: id %d running %s" % (dom0.ID(), dom0.OSType())) +print(dom0.info())</pre> There is not much to comment about it, it really is a straight mapping from the C API, the only points to notice are: <ul> -- 2.20.1

2 3

[libvirt] [python] WIP-FYI: mypy annotations for libvirt-python
by Philipp Hahn 20 Apr '20

20 Apr '20

Hello, Maybe you already have heads about mypy <http://mypy-lang.org/>, which "is an experimental optional static type checker for Python that aims to combine the benefits of dynamic (or "duck") typing and static typing". I started to write a manual annotation file for the Python binding of libvirt. I've attached my current version, so others can benefit from it, too. It is far from complete, but it already helped my to find some errors in my code. (My latest version is also available at <https://github.com/univention/typeshed/blob/libvirt/third_party/2and3/libvi…>) Long-term it probably would be better to teach the Python binding "generator.py" to add the type information (PEP 484 <https://www.python.org/dev/peps/pep-0484/>) directly into the generated "libvirt.py" file, but that's for another day. If someone else is interested in helping with that, please feel free to get in contact. Philipp -- Philipp Hahn Open Source Software Engineer Univention GmbH be open. Mary-Somerville-Str. 1 D-28359 Bremen Tel.: +49 421 22232-0 Fax : +49 421 22232-99 hahn(a)univention.de http://www.univention.de/ Geschäftsführer: Peter H. Ganten HRB 20755 Amtsgericht Bremen Steuer-Nr.: 71-597-02876

2 2

[PATCH 0/4] Support new qemu aio interface io_uring
by Han Han 20 Apr '20

20 Apr '20

The io_uring mode requires QEMU 5.0.0 and Linux 5.1 above. Han Han (4): qemu_capabilities: Introduce QEMU_CAPS_AIO_IO_URING qemu: Implement the aio mode io_uring tests: Tests for io mode io_uring docs: Docs and news for io mode io_uring docs/formatdomain.html.in | 3 +- docs/news.xml | 9 +++ docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 1 + src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 8 +++ tests/qemublocktest.c | 1 + ...le-backing_basic-aio_io_uring-srconly.json | 44 +++++++++++++ .../file-backing_basic-aio_io_uring.json | 66 +++++++++++++++++++ .../file-backing_basic-aio_io_uring.xml | 47 +++++++++++++ .../caps_5.0.0.aarch64.replies | 3 +- .../caps_5.0.0.aarch64.xml | 1 + .../caps_5.0.0.ppc64.replies | 3 +- .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.x86_64.replies | 3 +- .../caps_5.0.0.x86_64.xml | 1 + .../disk-aio-io_uring.x86_64-latest.args | 40 +++++++++++ tests/qemuxml2argvdata/disk-aio-io_uring.xml | 30 +++++++++ tests/qemuxml2argvtest.c | 1 + .../disk-aio-io_uring.x86_64-latest.xml | 39 +++++++++++ tests/qemuxml2xmltest.c | 1 + 23 files changed, 303 insertions(+), 4 deletions(-) create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-aio_io_uring-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-aio_io_uring.json create mode 100644 tests/qemublocktestdata/xml2json/file-backing_basic-aio_io_uring.xml create mode 100644 tests/qemuxml2argvdata/disk-aio-io_uring.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-aio-io_uring.xml create mode 100644 tests/qemuxml2xmloutdata/disk-aio-io_uring.x86_64-latest.xml -- 2.25.0

2 9

[PATCH libvirt-python] examples: Fix connection error handling
by Philipp Hahn 20 Apr '20

20 Apr '20

libvirt.open*() does not return None but raises an exception Signed-off-by: Philipp Hahn <hahn(a)univention.de> --- examples/dominfo.py | 5 +++-- examples/domrestore.py | 5 +++-- examples/domsave.py | 5 +++-- examples/domstart.py | 5 +++-- examples/esxlist.py | 6 +++--- 5 files changed, 15 insertions(+), 11 deletions(-) diff --git a/examples/dominfo.py b/examples/dominfo.py index 0a39f4c..fcfb8ed 100755 --- a/examples/dominfo.py +++ b/examples/dominfo.py @@ -34,8 +34,9 @@ if len(sys.argv) != 2: name = sys.argv[1] # Connect to libvirt -conn = libvirt.openReadOnly(None) -if conn is None: +try: + conn = libvirt.openReadOnly(None) +except libvirt.libvirtError: print('Failed to open connection to the hypervisor') sys.exit(1) diff --git a/examples/domrestore.py b/examples/domrestore.py index 96f4955..7fd5c8e 100755 --- a/examples/domrestore.py +++ b/examples/domrestore.py @@ -20,8 +20,9 @@ if len(sys.argv) != 2: dir = sys.argv[1] imgs = os.listdir(dir) -conn = libvirt.open(None) -if conn is None: +try: + conn = libvirt.open(None) +except libvirt.libvirtError: print('Failed to open connection to the hypervisor') sys.exit(1) diff --git a/examples/domsave.py b/examples/domsave.py index 4940cce..f8922d6 100755 --- a/examples/domsave.py +++ b/examples/domsave.py @@ -18,8 +18,9 @@ if len(sys.argv) != 2: dir = sys.argv[1] -conn = libvirt.open(None) -if conn is None: +try: + conn = libvirt.open(None) +except libvirt.libvirtError: print('Failed to open connection to the hypervisor') sys.exit(1) diff --git a/examples/domstart.py b/examples/domstart.py index 7ff6cb9..f342e95 100755 --- a/examples/domstart.py +++ b/examples/domstart.py @@ -32,8 +32,9 @@ if len(sys.argv) != 2: (name, xmldesc) = read_domain(sys.argv[1]) -conn = libvirt.open(None) -if conn is None: +try: + conn = libvirt.open(None) +except libvirt.libvirtError: print('Failed to open connection to the hypervisor') sys.exit(1) diff --git a/examples/esxlist.py b/examples/esxlist.py index d86e064..caeced1 100755 --- a/examples/esxlist.py +++ b/examples/esxlist.py @@ -97,9 +97,9 @@ uri = "esx://%s/?no_verify=1" % hostname # in order to log into the vCenter auth = [[libvirt.VIR_CRED_AUTHNAME, libvirt.VIR_CRED_NOECHOPROMPT], request_credentials, None] -conn = libvirt.openAuth(uri, auth, 0) - -if conn is None: +try: + conn = libvirt.openAuth(uri, auth, 0) +except libvirt.libvirtError: print("Failed to open connection to %s" % hostname) sys.exit(1) -- 2.20.1

2 1

[libvirt-ci PATCH] lcitool: Don't set root shell
by Andrea Bolognani 20 Apr '20

20 Apr '20

Being able to log in as root is critical to recover from failures, so using bash might not always be the best idea: this is especially true for FreeBSD, where bash is installed via ports and might break on update from time to time, rendering the system inaccessible without jumping through additional hoops. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- guests/playbooks/update/tasks/users.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/playbooks/update/tasks/users.yml b/guests/playbooks/update/tasks/users.yml index a07349f..28ee96a 100644 --- a/guests/playbooks/update/tasks/users.yml +++ b/guests/playbooks/update/tasks/users.yml @@ -3,7 +3,6 @@ user: name: root password: '{{ lookup("file", root_password_file)|password_hash("sha512") }}' - shell: '{{ bash }}' - name: 'root: Configure ssh access' authorized_key: -- 2.25.3

2 1

[libvirt PATCH 00/10] vbox: update to support newer versions and drop eol versions
by Daniel P. Berrangé 20 Apr '20

20 Apr '20

This is the bare minimum patches required to let libvirt compile with the latest virtualbox SDK for 6.0 and 6.1. Since I do not use virtualbox this is compile tested only. This will at least give users something to try and provide feedback on. In addition currently EOL versions of virtualbox are dropped. Daniel P. Berrangé (10): vbox: remove support for version 5.0 API vbox: remove version 5.0 CAPI header vbox: remove support for version 5.1 API vbox: remove version 5.1 CAPI header vbox: remove unused support for Windows MSCOM vbox: add version 6.0 CAPI header vbox: add support for version 6.0 SDK vbox: add version 6.1 CAPI header vbox: add support for version 6.1 SDK docs: add news about virtualbox version support changes docs/news.xml | 22 + po/POTFILES.in | 1 - src/vbox/Makefile.inc.am | 16 +- .../{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h} | 14959 +++--- .../{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h} | 37642 +++++++++------- src/vbox/vbox_MSCOMGlue.c | 779 - src/vbox/vbox_MSCOMGlue.h | 45 - src/vbox/{vbox_V5_0.c => vbox_V6_0.c} | 6 +- src/vbox/{vbox_V5_1.c => vbox_V6_1.c} | 6 +- src/vbox/vbox_XPCOMCGlue.h | 2 +- src/vbox/vbox_common.h | 10 +- src/vbox/vbox_driver.c | 2 +- src/vbox/vbox_glue.c | 28 - src/vbox/vbox_glue.h | 28 - src/vbox/vbox_storage.c | 10 +- src/vbox/vbox_tmpl.c | 104 +- src/vbox/vbox_uniformed_api.h | 6 +- 17 files changed, 31851 insertions(+), 21815 deletions(-) rename src/vbox/{vbox_CAPI_v5_1.h => vbox_CAPI_v6_0.h} (85%) rename src/vbox/{vbox_CAPI_v5_0.h => vbox_CAPI_v6_1.h} (73%) delete mode 100644 src/vbox/vbox_MSCOMGlue.c delete mode 100644 src/vbox/vbox_MSCOMGlue.h rename src/vbox/{vbox_V5_0.c => vbox_V6_0.c} (68%) rename src/vbox/{vbox_V5_1.c => vbox_V6_1.c} (68%) delete mode 100644 src/vbox/vbox_glue.c delete mode 100644 src/vbox/vbox_glue.h -- 2.25.2

2 11

[PATCH 0/3] Enable net devices in node-dev driver again
by Michal Privoznik 20 Apr '20

20 Apr '20

If the kernel doesn't have CONFIG_NET_DEVLINK then net devices are not listed in nodedev-list. See 2/3 for more info. Michal Prívozník (3): virNetDevGetFamilyId: Change signature virNetDevSwitchdevFeature: Make failure to get 'family_id' non-fatal virnetdev.c: Use g_auto*() src/util/virnetdev.c | 412 +++++++++++++++++-------------------------- 1 file changed, 157 insertions(+), 255 deletions(-) -- 2.25.3

2 6

[PATCH 0/2] Include lease time option into DHCP settings
by Julio Faracco 20 Apr '20

20 Apr '20

This series is based on latest series from Alberto. It includes a new entry called <leasetime/> under <dhcp/> scope to add a default lease time for range and host options for dnsmasq. There is no point to configure both separately. If they are defined (range and/or host), they should have the same lease time value. This series includes some test cases to cover lease time XML syntax also. Julio Faracco (2): conf: Add <leasetime/> option for <dhcp/> settings tests: Add tests for <leasetime/> to cover dnsmasq settings docs/schemas/basictypes.rng | 9 +++ docs/schemas/network.rng | 11 ++++ src/conf/network_conf.c | 62 ++++++++++++++++++- src/conf/network_conf.h | 14 +++++ src/libvirt_private.syms | 2 + src/network/bridge_driver.c | 37 ++++++++++- src/util/virdnsmasq.c | 40 ++++++------ src/util/virdnsmasq.h | 1 + .../networkxml2confdata/leasetime-hours.conf | 16 +++++ tests/networkxml2confdata/leasetime-hours.xml | 12 ++++ .../leasetime-infinite.conf | 16 +++++ .../leasetime-infinite.xml | 12 ++++ .../leasetime-minutes.conf | 16 +++++ .../networkxml2confdata/leasetime-minutes.xml | 12 ++++ .../leasetime-seconds.conf | 16 +++++ .../networkxml2confdata/leasetime-seconds.xml | 12 ++++ tests/networkxml2conftest.c | 4 ++ tests/networkxml2xmlin/leasetime-hours.xml | 12 ++++ tests/networkxml2xmlin/leasetime-infinite.xml | 12 ++++ tests/networkxml2xmlin/leasetime-minutes.xml | 12 ++++ tests/networkxml2xmlin/leasetime-seconds.xml | 12 ++++ tests/networkxml2xmlout/leasetime-hours.xml | 14 +++++ .../networkxml2xmlout/leasetime-infinite.xml | 14 +++++ tests/networkxml2xmlout/leasetime-minutes.xml | 14 +++++ tests/networkxml2xmlout/leasetime-seconds.xml | 14 +++++ tests/networkxml2xmltest.c | 4 ++ 26 files changed, 376 insertions(+), 24 deletions(-) create mode 100644 tests/networkxml2confdata/leasetime-hours.conf create mode 100644 tests/networkxml2confdata/leasetime-hours.xml create mode 100644 tests/networkxml2confdata/leasetime-infinite.conf create mode 100644 tests/networkxml2confdata/leasetime-infinite.xml create mode 100644 tests/networkxml2confdata/leasetime-minutes.conf create mode 100644 tests/networkxml2confdata/leasetime-minutes.xml create mode 100644 tests/networkxml2confdata/leasetime-seconds.conf create mode 100644 tests/networkxml2confdata/leasetime-seconds.xml create mode 100644 tests/networkxml2xmlin/leasetime-hours.xml create mode 100644 tests/networkxml2xmlin/leasetime-infinite.xml create mode 100644 tests/networkxml2xmlin/leasetime-minutes.xml create mode 100644 tests/networkxml2xmlin/leasetime-seconds.xml create mode 100644 tests/networkxml2xmlout/leasetime-hours.xml create mode 100644 tests/networkxml2xmlout/leasetime-infinite.xml create mode 100644 tests/networkxml2xmlout/leasetime-minutes.xml create mode 100644 tests/networkxml2xmlout/leasetime-seconds.xml -- 2.24.1

3 7

[libvirt-ci PATCH] README: Fix "maintainance" typo
by Erik Skultety 20 Apr '20

20 Apr '20

Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed as trivial. guests/README.markdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/guests/README.markdown b/guests/README.markdown index ed9be06..7dbefed 100644 --- a/guests/README.markdown +++ b/guests/README.markdown @@ -18,7 +18,7 @@ There are two steps to bringing up a guest: post-installation configuration steps required to make the newly-created guest usable and ready to be used for building `$project`; -Once those steps have been performed, maintainance will involve running: +Once those steps have been performed, maintenance will involve running: lcitool update $guest $project -- 2.25.2

1 0

[PATCH] Add 'permissive' option for PCI devices
by Marek Marczykowski-Górecki 19 Apr '20

19 Apr '20

From: Simon Gaiser <simon(a)invisiblethingslab.com> By setting the permissive flag the guest access to the PCI config space is not filtered. This might be a security risk, but it's required for some devices and the IOMMU and interrupt remapping should (mostly?) contain it. Signed-off-by: Simon Gaiser <simon(a)invisiblethingslab.com> Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com> --- docs/formatdomain.html.in | 3 +++ docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 12 ++++++++++++ src/conf/domain_conf.h | 1 + src/libxl/libxl_conf.c | 1 + 5 files changed, 22 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6f43976815..79a5176ccd 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5051,6 +5051,9 @@ or hot-plugging the device and <code>virNodeDeviceReAttach</code> (or <code>virsh nodedev-reattach</code>) after hot-unplug or stopping the guest. + When <code>permissive</code> is "yes" the pci config space access + will not be filtered. This might be a security issue. The default + is "no". </dd> <dt><code>scsi</code></dt> <dd>For SCSI devices, user is responsible to make sure the device diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 65d6580434..9389eec3d8 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -3064,6 +3064,11 @@ <ref name="virYesNo"/> </attribute> </optional> + <optional> + <attribute name="permissive"> + <ref name="virYesNo"/> + </attribute> + </optional> <interleave> <element name="source"> <optional> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8e8146374c..607cae61d4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8419,6 +8419,7 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, virDomainHostdevSubsysSCSIVHostPtr scsihostsrc = &def->source.subsys.u.scsi_host; virDomainHostdevSubsysMediatedDevPtr mdevsrc = &def->source.subsys.u.mdev; g_autofree char *managed = NULL; + g_autofree char *permissive = NULL; g_autofree char *sgio = NULL; g_autofree char *rawio = NULL; g_autofree char *backendStr = NULL; @@ -8434,6 +8435,11 @@ virDomainHostdevDefParseXMLSubsys(xmlNodePtr node, if ((managed = virXMLPropString(node, "managed")) != NULL) ignore_value(virStringParseYesNo(managed, &def->managed)); + if ((permissive = virXMLPropString(node, "permissive")) != NULL) { + if (STREQ(permissive, "yes")) + def->permissive = true; + } + sgio = virXMLPropString(node, "sgio"); rawio = virXMLPropString(node, "rawio"); model = virXMLPropString(node, "model"); @@ -25942,6 +25948,8 @@ virDomainActualNetDefFormat(virBufferPtr buf, virDomainHostdevDefPtr hostdef = virDomainNetGetActualHostdev(def); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAddLit(buf, " permissive='yes'"); } if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", @@ -26130,6 +26138,8 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferAsprintf(buf, "<interface type='%s'", typeStr); if (hostdef && hostdef->managed) virBufferAddLit(buf, " managed='yes'"); + if (hostdef && hostdef->permissive) + virBufferAddLit(buf, " permissive='yes'"); if (def->trustGuestRxFilters) virBufferAsprintf(buf, " trustGuestRxFilters='%s'", virTristateBoolTypeToString(def->trustGuestRxFilters)); @@ -27914,6 +27924,8 @@ virDomainHostdevDefFormat(virBufferPtr buf, if (def->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virBufferAsprintf(buf, " managed='%s'", def->managed ? "yes" : "no"); + if (def->permissive) + virBufferAddLit(buf, " permissive='yes'"); if (def->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI && scsisrc->sgio) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index aad3f82db7..b81a3ce901 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -345,6 +345,7 @@ struct _virDomainHostdevDef { bool missing; bool readonly; bool shareable; + bool permissive; union { virDomainHostdevSubsys subsys; virDomainHostdevCaps caps; diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index b3f67f817a..55f2a09e3e 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -2249,6 +2249,7 @@ libxlMakePCI(virDomainHostdevDefPtr hostdev, libxl_device_pci *pcidev) pcidev->bus = pcisrc->addr.bus; pcidev->dev = pcisrc->addr.slot; pcidev->func = pcisrc->addr.function; + pcidev->permissive = hostdev->permissive; return 0; } -- 2.21.1

2 1

[libvirt PATCH] util: Do not include sys/wait.h on Win32
by Jiri Denemark 17 Apr '20

17 Apr '20

This fixes build on mingw broken by my previous commit 36e125296a. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed. src/util/virdaemon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c index 6182ca3c21..31cc24e703 100644 --- a/src/util/virdaemon.c +++ b/src/util/virdaemon.c @@ -22,7 +22,9 @@ #include <sys/types.h> #include <sys/stat.h> -#include <sys/wait.h> +#ifndef WIN32 +# include <sys/wait.h> +#endif #include <fcntl.h> #include <unistd.h> #include <stdbool.h> -- 2.26.1

1 0

[PATCH v2 0/2] docs: Further adjustments to pci-addresses.rst
by Boris Fiuczynski 17 Apr '20

17 Apr '20

Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (1): docs: Improve zPCI section in pci-addresses.rst docs/pci-addresses.rst | 31 ++++++++++++++++++------------- 1 file changed, 18 insertions(+), 13 deletions(-) -- 2.25.1

3 5

[PATCH 0/3] qemu: Fix restoring a domain from a block device
by Michal Privoznik 17 Apr '20

17 Apr '20

*** BLURB HERE *** Michal Prívozník (3): selinux: Don't remember label for restore path security: Introduce virSecurityManagerDomainSetIncomingPathLabel qemu: Label restore path outside of secdriver transactions src/libvirt_private.syms | 1 + src/qemu/qemu_security.c | 7 +++++++ src/security/security_driver.h | 4 ++++ src/security/security_manager.c | 29 +++++++++++++++++++++++++++++ src/security/security_manager.h | 4 ++++ src/security/security_selinux.c | 23 +++++++++++++++++------ src/security/security_stack.c | 21 +++++++++++++++++++++ 7 files changed, 83 insertions(+), 6 deletions(-) -- 2.24.1

2 8

[PATCH 0/2] docs: Further adjustments to pci-addresses.rst
by Boris Fiuczynski 17 Apr '20

17 Apr '20

Andrea Bolognani (1): docs: Update introduction in pci-addresses.rst Boris Fiuczynski (2): docs: Improve zPCI section in pci-addresses.rst docs/pci-addresses.rst | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) -- 2.25.1

3 11

[libvirt PATCH] util: Fix virDaemonForkIntoBackground
by Jiri Denemark 17 Apr '20

17 Apr '20

This commit partially reverts commit c360ea28dc267802690e129fbad08ca2f22a44e9 Refs: v6.2.0-rc1-1-gc360ea28dc Author: Rafael Fonseca <r4f4rfs(a)gmail.com> AuthorDate: Fri Mar 27 18:40:47 2020 +0100 Commit: Michal Prívozník <mprivozn(a)redhat.com> CommitDate: Mon Mar 30 09:48:22 2020 +0200 util: virdaemon: fix compilation on mingw The daemons are not supported on Win32 and therefore were not compiled in that platform. However, with the daemon code sharing, all the code in utils *is* compiled and it failed because `waitpid`, `fork`, and `setsid` are not available. So, as before, let's not build them on Win32 and make the code more portable by using existing vir* wrappers. Not compiling virDaemonForkIntoBackground on Win32 is good, but the second part of the original patch incorrectly replaced waitpid and fork with our virProcessWait and virFork APIs. These APIs are more than just simple wrappers and we don't want any of the extra functionality. Especially virFork would reset any setup made before virDaemonForkIntoBackground is called, such as logging, signal handling, etc. As a result of the change the additional fix in v6.2.0-67-ga87e4788d2 (util: virdaemon: fix waiting for child processes) is no longer needed and it is effectively reverted by this commit. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virdaemon.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/util/virdaemon.c b/src/util/virdaemon.c index 99530fd146..6182ca3c21 100644 --- a/src/util/virdaemon.c +++ b/src/util/virdaemon.c @@ -20,7 +20,9 @@ #include <config.h> +#include <sys/types.h> #include <sys/stat.h> +#include <sys/wait.h> #include <fcntl.h> #include <unistd.h> #include <stdbool.h> @@ -30,8 +32,6 @@ #include "virfile.h" #include "virlog.h" #include "viralloc.h" -#include "virprocess.h" -#include "vircommand.h" #include "configmake.h" @@ -44,7 +44,7 @@ virDaemonForkIntoBackground(const char *argv0) if (virPipeQuiet(statuspipe) < 0) return -1; - pid_t pid = virFork(); + pid_t pid = fork(); switch (pid) { case 0: { @@ -73,7 +73,7 @@ virDaemonForkIntoBackground(const char *argv0) if (setsid() < 0) goto cleanup; - nextpid = virFork(); + nextpid = fork(); switch (nextpid) { case 0: /* grandchild */ return statuspipe[1]; @@ -97,14 +97,15 @@ virDaemonForkIntoBackground(const char *argv0) default: { /* parent */ - int exitstatus = 0; + int got, exitstatus = 0; int ret; char status; VIR_FORCE_CLOSE(statuspipe[1]); /* We wait to make sure the first child forked successfully */ - if (virProcessWait(pid, &exitstatus, 0) < 0 || + if ((got = waitpid(pid, &exitstatus, 0)) < 0 || + got != pid || exitstatus != 0) { goto error; } -- 2.26.1

2 1

[PATCH 0/5] qemu: Support rbd namespace attribute
by Han Han 17 Apr '20

17 Apr '20

QEMU introduced rbd namespace blockdev args since v5.0.0[1]. Implement rbd namespace to libvirt. It could be used for tenant isolation with in a pool after Ceph Nautilus. Note that since the aarch64 qemu capabilities replies is not updated for the namespace args, I didn't add capabilities test for this arch. The capabilities test will be updateid after the updated replies. https://bugzilla.redhat.com/show_bug.cgi?id=1816909 [1]: https://lists.gnu.org/archive/html/qemu-devel/2019-12/msg04344.html Han Han (5): qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE conf: Support to parse rbd namespace attribute qemu: Implement rbd namespace attribute doc: rng schemas and html doc for rbd namespace attribute news: qemu: Support rbd namespace docs/formatdomain.html.in | 5 +++ docs/news.xml | 9 ++++ docs/schemas/domaincommon.rng | 3 ++ src/conf/domain_conf.c | 4 ++ src/qemu/qemu_block.c | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 14 ++++++- src/util/virstoragefile.h | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + ...k-network-rbd-namespace.x86_64-latest.args | 41 +++++++++++++++++++ .../disk-network-rbd-namespace.xml | 33 +++++++++++++++ tests/qemuxml2argvtest.c | 1 + ...sk-network-rbd-namespace.x86_64-latest.xml | 41 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 16 files changed, 158 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml -- 2.25.0

2 7

[libvirt PATCH] docs: kbase: add a page about debugging
by Ján Tomko 16 Apr '20

16 Apr '20

Migrate the following wiki articles: https://wiki.libvirt.org/page/DebugLogs https://wiki.libvirt.org/page/Debugging With the syntax changed to rST and rewrapped. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- I might've changed an article or two, too. Or rather: the article 'the'. docs/kbase.html.in | 3 + docs/kbase/debugging.rst | 303 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 306 insertions(+) create mode 100644 docs/kbase/debugging.rst diff --git a/docs/kbase.html.in b/docs/kbase.html.in index c586e0f676..1a50428805 100644 --- a/docs/kbase.html.in +++ b/docs/kbase.html.in @@ -36,6 +36,9 @@ <dt><a href="kbase/virtiofs.html">Virtio-FS</a></dt> <dd>Share a filesystem between the guest and the host</dd> + + <dt><a href="kbase/debugging.html">Debugging libvirt</a></dt> + <dd>How to capture debug logs and use a debugger on libvirt</dd> </dl> </div> diff --git a/docs/kbase/debugging.rst b/docs/kbase/debugging.rst new file mode 100644 index 0000000000..a9bc02aa55 --- /dev/null +++ b/docs/kbase/debugging.rst @@ -0,0 +1,303 @@ +================= +Debugging libvirt +================= + +.. contents:: + + +If you `report a bug <https://libvirt.org/bugs.html>`_ against libvirt, in most +cases you will be asked to attach debug logs. These are bare text files which +tracks transition between different states of libvirtd, what it has tried to +achieve, etc. Because of client -- server schema used in libvirt, the logs can +be either client or server too. Usually, it's server side that matters as +nearly all interesting work takes place there. Moreover, libvirt catches stderr +of all running domains. These can be useful as well. + + +How to turn on debug logs for libvirt +===================================== + +Persistent setting +------------------ + +The daemon configuration files location is dependent on the `connection URI +<http://libvirt.org/uri.html>`_. For ``qemu:///system``: + +* open ``/etc/libvirt/libvirtd.conf`` in your favourite editor +* find & replace, or set these variables:: + + # LEGACY SETTINGS PRIOR LIBVIRT 4.4.0 SEE BELOW! # + log_level = 1 + log_filters="1:qemu 3:remote 4:event 3:util.json 3:rpc" + log_outputs="1:file:/var/log/libvirt/libvirtd.log" + + + # PREFERRED SETTINGS AFTER LIBVIRT 4.4.0 # + log_filters="3:remote 4:event 3:util.json 3:rpc 1:*" + log_outputs="1:file:/var/log/libvirt/libvirtd.log" + +* save and exit +* restart libvirtd service:: + + systemctl restart libvirtd.service + +In the config variables above, we have set logging level to 1 (debug level), +set some filters (to filter out noise), e.g. from rpc only warnings (=level 3) +and above will be reported. The logs are saved into +``/var/log/libvirt/libvirtd.log``. Since libvirt *4.4.0* log filters +support shell globbing, therefore the usage of ``log_level`` is considered +deprecated in favour of pure usage of ``log_filters``. + +In case you want to get the client logs, you need to set this environment variable:: + + export LIBVIRT_LOG_OUTPUTS="1:file:/tmp/libvirt_client.log" + +However, when you are using the session mode ``qemu:///session`` or you run the +``libvirtd`` as unprivileged user you will find configuration file under +``$XDG_CONFIG_HOME/libvirt/libvirt.conf``. + + +Runtime setting +--------------- + +Debugging anomalies can be very painful, especially when trying to reproduce it +after the daemon restarts, since the new session can make the anomaly +"disappear". Therefore, it's possible to enable the debug logs during runtime +using libvirt administration API. To use it conveniently, there's a ``virt-admin`` +client provided by the ``libvirt-admin`` package. Use the package manager provided +by your distribution to install this package. Once you have it installed, run +the following as root to see the set of log filters currently being active:: + + # virt-admin daemon-log-filters + Logging filters: 3:remote 4:util.json 4:rpc + +In order to change this set, run the same command as root, this time with your own set of filters:: + + ## LEGACY APPROACH ENUMERATING ALL THE DESIRED MODULES ## + # virt-admin daemon-log-filters "1:util 1:libvirt 1:storage 1:network 1:nodedev 1:qemu" + + ## CURRENT APPROACH USING SHELL GLOBBING ## + # virt-admin daemon-log-filters "3:remote 4:util.json 4:rpc 1:*" + +Analogically, the same procedure can be performed with log outputs:: + + # virt-admin daemon-log-outputs + Logging outputs: 3:syslog:libvirtd + # virt-admin daemon-log-outputs "1:file:/var/log/libvirt/libvirtd.log" + +NOTE: It's always good practice to return the settings to the original state +once you're finished debugging, just remember to save the original sets of +filters and outputs and restore them at the end the same way as described +above. + + +Removing filters and outputs +---------------------------- + +It's also possible to remove all the filters and produce an enormous log file, +but it is not recommended since some of libvirt's modules can produce a large +amount of noise. However, should you really want to do this, you can specify an +empty set of filters:: + + # virt-admin daemon-log-filters "" + Logging filters: + +The situation is a bit different with outputs, since libvirt always has to log +somewhere and resetting the outputs to an empty set will restore the default +setting which depends on the host configuration, ''journald'' in our case:: + + # virt-admin daemon-log-outputs + Logging outputs: 1:file:/var/log/libvirt/libvirtd.log + # virt-admin daemon-log-outputs "" + Logging outputs: 2:journald + + +What to attach? +--------------- + +Now you should go and reproduce the bug. Once you're finished, attach: + +* ``/var/log/libvirt/libvirtd.log`` or whatever path you set for the daemon logs. +* If the problem is related to a domain attach ``/var/log/libvirt/qemu/$dom.log`` + then. Or substitute ``qemu`` with whatever hypervisor you are using. +* If you are asked for client logs, ``/tmp/libvirt_client.log``. + + +Using a debugger +================ + +When trying to figure out what libvirt does, debug logs might not always be +enough. And sometimes you might want to get some information from a user, but +you do not want to waste both your and their time by explaining how to do stuff +in gdb to, for example, get a backtrace. Here are some useful tips that you +might use. + + +Prerequisites +------------- + +In cases where you want to see details of what is happening, you need to have +debugging symbols installed, at least for the package you are trying to debug. +Although having debugging symbols for all dependent libraries is usually +helpful as well. Usually ``gdb`` will tell you what you need to do in order to +get the proper data to your machine when you run it with a binary. + +=== Example: === + +Running this command on 32bit Fedora 29 tells us what to install in order to +get the proper debugging symbols:: + + # gdb $(which libvirtd) + GNU gdb (GDB) Fedora 8.2-6.fc29 + ... + Reading symbols from /usr/sbin/libvirtd...(no debugging symbols found)...done. + Missing separate debuginfos, use: dnf debuginfo-install libvirt-daemon-4.7.0-1.fc29.i686 + +When the package is installed, we can break on main and run until then (gdb's +command ``start`` is perfect for this):: + + # gdb $(which libvirtd) + GNU gdb (GDB) Fedora 8.2-6.fc29 + ... + Reading symbols from /usr/sbin/libvirtd...Reading symbols from /usr/lib/debug/usr/sbin/libvirtd-4.7.0-1.fc29.i386.debug...done. + done. + (gdb) start + Temporary breakpoint 1 at 0x18fc0: file remote/remote_daemon.c, line 1030. + Starting program: /usr/sbin/libvirtd + Missing separate debuginfos, use: dnf debuginfo-install glibc-2.28-26.fc29.i686 + Missing separate debuginfo for /lib/libvirt-lxc.so.0 + Try: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/4d/16496b686ec54ca4201bd769b04293f6c756b3.debug + Missing separate debuginfo for /lib/libvirt-qemu.so.0 + Try: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/ea/91d5346bd3e265ffb12ae641ca93643443e6e7.debug + Missing separate debuginfo for /lib/libvirt.so.0 + Try: dnf --enablerepo='*debug*' install /usr/lib/debug/.build-id/02/af3a96fc6227ed5e3a447344bcbb672bde14ba.debug + ... + Temporary breakpoint 1, main (argc=1, argv=0xbffff614) at remote/remote_daemon.c:1030 + 1030 int main(int argc, char **argv) { + Missing separate debuginfos, use: dnf debuginfo-install audit-libs-3.0-0.5.20181218gitbdb72c0.fc29.i686 avahi-libs-0.7-16.fc29.i686 brotli-1.0.5-1.fc29.i686 cyrus-sasl-lib-2.1.27-0.3rc7.fc29.i686 dbus-libs-1.12.12-1.fc29.i686 device-mapper-libs-1.02.154-1.fc29.i686 gmp-6.1.2-9.fc29.i686 gnutls-3.6.6-1.fc29.i686 keyutils-libs-1.5.10-8.fc29.i686 krb5-libs-1.16.1-25.fc29.i686 libacl-2.2.53-2.fc29.i686 libattr-2.4.48-3.fc29.i686 libblkid-2.32.1-1.fc29.i686 libcap-2.25-12.fc29.i686 libcap-ng-0.7.9-5.fc29.i686 libcom_err-1.44.4-1.fc29.i686 libcurl-7.61.1-10.fc29.i686 libffi-3.1-18.fc29.i686 libgcrypt-1.8.4-1.fc29.i686 libidn2-2.1.1a-1.fc29.i686 libmount-2.32.1-1.fc29.i686 libnghttp2-1.34.0-1.fc29.i686 libnl3-3.4.0-6.fc29.i686 libpsl-0.20.2-5.fc29.i686 libselinux-2.8-6.fc29.i686 libsepol-2.8-3.fc29.i686 libssh-0.8.7-1.fc29.i686 libssh2-1.8.1-1.fc29.i686 libtirpc-1.1.4-2.rc2.fc29.i686 libunistring-0.9.10-4.fc29.i686 libuuid-2.32.1-1.fc29.i686 libwsman1-2.6.5-8.fc29.i686 libxcrypt-4.4.4-2.fc29.i686 libxml2-2.9.8-5.fc29.i686 lz4-libs-1.8.3-1.fc29.i686 numactl-libs-2.0.12-1.fc29.i686 openldap-2.4.46-10.fc29.i686 openssl-libs-1.1.1b-3.fc29.i686 p11-kit-0.23.15-2.fc29.i686 pcre2-10.32-8.fc29.i686 xz-libs-5.2.4-3.fc29.i686 yajl-2.1.0-11.fc29.i686 zlib-1.2.11-14.fc29.i686 + +You might need to run the above commands for more complete output. It is very +dependent on the actually problem, whether you need this or not, but it will +never hurt to actually have all the data installed. + + +When libvirt hangs +------------------ + +When a process hangs, we usually ask for a backtrace. To avoid problems with +paging and so on, it is usually very helpful to just get a backtrace for one +instance of the particular process. For that you can use something like this:: + + # gdb -batch -p $(pidof libvirtd) -ex 't a a bt f' + +This command will attach to currently running libvirtd process and run ``t a a +bt f``, which is short for ``thread apply all backtrace full``, feel free to +combine with ``sudo`` for users. If you are using this for virsh, or any other +binary which might have multiple processes running, then make sure you supply +the right pid for the ``-p`` option. For more info, read below about how to +automate gdb. + + +When libvirt crashes +-------------------- + +Different distros have different mechanisms of catching and reporting crashes. +The automated ones are usually enabled only for the packaged binaries, but that +should be enough for users. Developers will have their own way of doing things +anyway. + +* **systemd-coredump** -- ``coredumpctl show`` shows all needed information + (even a backtrace) of the last crash, use ``coredumpctl ls`` to list all + crashes cordumpctl knows about. + +* **abrt** -- ``abrt-cli`` works similarly to the above (TBD: how to get the + backtrace using abrt-cli) + +* **setup your own** -- you can do one of these things: + + * set the ulimit for the service (depends on your init system) and look for + the file that gets created + * set kernel.core_pattern using sysctl to a command (rather than a filename + template) that gets ran with each core dump. This one does not need any + ulimit setting, but you need to know what to specify there. + +For more information see related documentation. + + +Automating gdb +-------------- + +When you need more specific behaviour from gdb, you can automate that, but for +multiline commands you need an input redirection or execute them from the file. + + +Multiline example +----------------- + +Simple example that will print backtrace when ``abort()`` is reached:: + + $ cat >/var/lib/libvirt/gdbabortscript <<EOF + start + break abort + commands + t a a bt full + end + continue + EOF + +This file instructs gdb to ``start`` the program (run until ``main()``), that +will load all the libraries so that we can setup a breakpoint for (p[retty +much) any existing function. It then sets up a breakpoint for the ``abort()`` +function and immediately sets up a list of ``commands`` that will run when that +breakpoint is hit (list of commands ends with ``end``). After that it allows +the process to ``continue`` its execution. + + +Systemd example +--------------- + +Let's say you need to debug an issue which happens only when the daemon is run +as a service as it does not happen when run manually. Ideally you would +connect to a running instance, but if the issue happens right after starting +the daemon. One option would be utilizing ``systemtap`` to add a ``sleep()`` +in one of the early functions (TBD: add an automated way of doing that or +remove this tip if it's not worth it). Another idea is to make the init system +run the gdb command we need. + +In systemd world we can do this easily by overriding the ``ExecStart`` parameter:: + + # cat >/etc/systemd/system/libvirtd.service.d/override.conf <<EOF + [Service] + ExecStart= + ExecStart=/usr/bin/gdb --batch -x /var/lib/libvirt/gdbabortscript /usr/sbin/libvirtd $LIBVIRTD_ARGS + EOF + +Daemon needs to be reloaded to know about this file:: + + # systemctl daemon-reload + +We also need to make sure that the file we created will be readable by the +service. DAC should be fine, SELinux might get tricky. By placing the file +under ``/var/lib/libvirt`` this should be readable by both the init system and +the libvirt daemon, but we need to make sure it has a proper context:: + + # restorecon -F /var/lib/libvirt/gdbabortscript /etc/systemd/system/libvirtd.service.d/override.conf + +We actually do not need this to be read by the init system, but gdb will most +probably run under the same SELinux context as init, the context for libvirtd +gets changed by a transition rule which depends on the current runnning context +and the context of the binary being executed, so that whould apply only when +libvirtd is being started. This ''should'' work most of the time. If it does +not work for you, please figure out a way and add it here. + +Now we need to restart the daemon:: + + # systemctl restart libvirtd.service + +Beware, the command will not end until libvirtd itself ends as systemd is +waiting for ``sd_notify()`` from gdb's PID, but that function is being called +by libvirtd. + +You should get the full backtrace in the output of:: + + # journalctl -u libvirtd.service -- 2.25.1

3 2

[libvirt PATCH] docs: Add section about code blocks to styleguide.rst
by Andrea Bolognani 16 Apr '20

16 Apr '20

Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/styleguide.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/docs/styleguide.rst b/docs/styleguide.rst index 2998e90963..3162868fb7 100644 --- a/docs/styleguide.rst +++ b/docs/styleguide.rst @@ -24,6 +24,18 @@ Whitespace Blocks should be indented with 3 spaces, and no tabs +Code blocks +=========== + +Code blocks should be created using + +:: + + This is regular text. + + :: + + This is a code block. Headings ======== -- 2.25.2

2 1

[libvirt PATCH 0/4] docs: A few adjustments to pci-addresses.rst
by Andrea Bolognani 16 Apr '20

16 Apr '20

Andrea Bolognani (4): docs: Use consistent style in pci-addresses.rst docs: Move sections around in pci-addresses.rst docs: Remove MAC addresses from pci-addresses.rst docs: Remove one example from pci-addresses.rst docs/pci-addresses.rst | 102 +++++++++++++++++------------------------ 1 file changed, 42 insertions(+), 60 deletions(-) -- 2.25.2

5 17

[PATCH] conf: Trivial comment fix
by Leonid Bloch 16 Apr '20

16 Apr '20

Trivial comment fix, reflecting the changes in 4ee2b31804f4d3477ee83bac28d9991afb0c3393. Signed-off-by: Leonid Bloch <lb.workbox(a)gmail.com> --- src/conf/domain_conf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index aad3f82db7..7d8f1aa31b 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2084,7 +2084,7 @@ struct _virDomainTimerDef { virDomainTimerCatchupDef catchup; /* track is only valid for name='platform|rtc' */ - int track; /* host|guest */ + int track; /* boot|guest|wall */ /* frequency & mode are only valid for name='tsc' */ unsigned long frequency; /* in Hz, unspecified = 0 */ -- 2.26.1

2 2

[libvirt PATCH 0/3] docs: misc fixes to static asset handling
by Daniel P. Berrangé 16 Apr '20

16 Apr '20

When looking at switching libvirt.org to use files output from gitlab CI I discovered some missing static assets Daniel P. Berrangé (3): docs: fix handling of static assets in build dir docs: add missing files to static asset list docs: remove old unused favicon file docs/32favicon.png | Bin 783 -> 0 bytes docs/Makefile.am | 41 ++++++++++++++++++++++++----------------- 2 files changed, 24 insertions(+), 17 deletions(-) delete mode 100644 docs/32favicon.png -- 2.25.2

2 5

[PATCH] bhyve: add missing param to virDomainPCIAddressBusSetModel
by Daniel P. Berrangé 16 Apr '20

16 Apr '20

Fixes build error introduced in commit aa15e9259f1f246e69fb9742581ced720c88695d Author: Laine Stump <laine(a)redhat.com> Date: Sun Apr 5 22:40:37 2020 -0400 qemu/conf: set HOTPLUGGABLE connect flag during PCI address set init Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a CI fix src/bhyve/bhyve_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_device.c b/src/bhyve/bhyve_device.c index 13261e9935..fc52280361 100644 --- a/src/bhyve/bhyve_device.c +++ b/src/bhyve/bhyve_device.c @@ -71,7 +71,8 @@ bhyveDomainPCIAddressSetCreate(virDomainDefPtr def, unsigned int nbuses) return NULL; if (virDomainPCIAddressBusSetModel(&addrs->buses[0], - VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT) < 0) + VIR_DOMAIN_CONTROLLER_MODEL_PCI_ROOT, + true) < 0) goto error; if (virDomainDeviceInfoIterate(def, bhyveCollectPCIAddress, addrs) < 0) -- 2.24.1

1 0

[PATCH] docs: add zpci information to pci-addresses.rst
by Cornelia Huck 16 Apr '20

16 Apr '20

Add some information on how pci address work on s390x. Signed-off-by: Cornelia Huck <cohuck(a)redhat.com> --- docs/pci-addresses.rst | 63 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 63 insertions(+) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index 923783a151b0..9e241a24fcfb 100644 --- a/docs/pci-addresses.rst +++ b/docs/pci-addresses.rst @@ -184,3 +184,66 @@ guest OS rather than as ``0001:08:00.1``, which is the address of the device on the host. Of course, all the rules and behaviors described above still apply. + +zPCI addresses +============== + +For s390x machines, PCI addresses are handled yet differently. No +topology information is relayed in the PCI addresses; instead, the +``fid`` and ``uid`` elements of the ``zpci`` device convey information. +In the simplest case, the following XML snippet + +:: + + <controller type='pci' index='0' model='pci-root'/> + <controller type='pci' index='1' model='pci-bridge'> + <model name='pci-bridge'/> + <target chassisNr='1'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'> + <zpci uid='0x0002' fid='0x00000001'/> + </address> + </controller> + <interface type='bridge'> + <mac address='02:ca:fe:fa:ce:04'/> + <source bridge='virbr0'/> + <model type='virtio'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'> + <zpci uid='0x0001' fid='0x00000000'/> + </address> + </interface> + +will result in the following in a Linux guest:: + + 0001:00:00.0 Ethernet controller: Red Hat, Inc. Virtio network device + +Note that the PCI bridge is not visible in the guest; s390x always has a flat +topology. + +Neither are any changes in the PCI address visible in the guest; replacing +the PCI address for the virtio-net device with + +:: + + <address type='pci' domain='0x0000' bus='0x01' slot='0x07' function='0x3'> + +will result in the exactly same view in the guest, as the addresses there +are generated from the information provided via the ``zpci`` element (in +fact, from the ``uid``). + +Therefore, replacing the virtio-net device definition with the following XML +snippet + +:: + + <interface type='bridge'> + <mac address='02:ca:fe:fa:ce:04'/> + <source bridge='virbr0'/> + <model type='virtio'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x07' function='0x3'> + <zpci uid='0x0007' fid='0x00000003'/> + </address> + </interface> + +will yield the following result in a Linux guest:: + + 0007:00:00.0 Ethernet controller: Red Hat, Inc. Virtio network device -- 2.21.1

4 12

[libvirt PATCH] docs: fix mistaken description of the read-only socket units
by Daniel P. Berrangé 16 Apr '20

16 Apr '20

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/daemons.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/daemons.rst b/docs/daemons.rst index 13c244de7b..e0b95105e4 100644 --- a/docs/daemons.rst +++ b/docs/daemons.rst @@ -145,7 +145,7 @@ Libvirt ships a number of unit files for controlling ``libvirtd``: UNIX socket ``/var/run/libvirt/libvirt-sock``. This socket is recommended to be started on boot by default. -* ``libvirtd-ro.socket`` - the unit file corresponding to the main read-write +* ``libvirtd-ro.socket`` - the unit file corresponding to the main read-only UNIX socket ``/var/run/libvirt/libvirt-sock-ro``. This socket is recommended to be started on boot by default. @@ -316,7 +316,7 @@ Libvirt ships a number of unit files for controlling ``virt${DRIVER}d``: recommended to be started on boot by default. * ``virt${DRIVER}d-ro.socket`` - the unit file corresponding to the main - read-write UNIX socket ``/var/run/libvirt/virt${DRIVER}d-sock-ro``. This + read-only UNIX socket ``/var/run/libvirt/virt${DRIVER}d-sock-ro``. This socket is recommended to be started on boot by default. * ``virt${DRIVER}d-admin.socket`` - the unit file corresponding to the @@ -471,7 +471,7 @@ Libvirt ships a number of unit files for controlling ``virtproxyd``: UNIX socket ``/var/run/libvirt/libvirt-sock``. This socket is recommended to be started on boot by default. -* ``virtproxyd-ro.socket`` - the unit file corresponding to the main read-write +* ``virtproxyd-ro.socket`` - the unit file corresponding to the main read-only UNIX socket ``/var/run/libvirt/libvirt-sock-ro``. This socket is recommended to be started on boot by default. -- 2.25.2

2 1

[RFC] Adding docker driver to libvirt
by nshirokovskiy 16 Apr '20

16 Apr '20

Hi, all. Does it make sense to add such a driver? I can't say I have a big picture of docker functionality in mind but at least container lifecycle management and container networking are common to both. Nikolay

7 10

[PATCH] qemuDomainDefPostParse: Fail if unable to fill machine type
by Michal Privoznik 16 Apr '20

16 Apr '20

Previously, we used virCapabilitiesDomainDataLookup() to fill machine type in post parse callback if none was provided in the domain XML. If machine type couldn't be filled in an error was reported. After 4a4132b4625 we've changed it to virQEMUCapsGetPreferredMachine() which returns NULL, but we no longer report an error and proceed with the post parse callbacks processing. This may lead to a crash because the code later on assumes def->os.machine is not NULL. Fixes: 4a4132b4625 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_domain.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 91e234d644..98ffd23a71 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -4973,6 +4973,14 @@ qemuDomainDefPostParse(virDomainDefPtr def, if (!def->os.machine) { const char *machine = virQEMUCapsGetPreferredMachine(qemuCaps, def->virtType); + if (!machine) { + virReportError(VIR_ERR_INVALID_ARG, + _("could not get preferred machine for %s type=%s"), + def->emulator, + virDomainVirtTypeToString(def->virtType)); + return -1; + } + def->os.machine = g_strdup(machine); } -- 2.25.3

2 1

Re: [libvirt-php] libvirt_domain_interface_addresses causing segfault
by Fernando Casas Schössow 16 Apr '20

16 Apr '20

I think I found the problem and it seems to affect only Windows guests. I'm not sure about the cause tough. Possible causes: 1- Network interface names containing white spaces. 2- One of the interfaces not reporting a MAC address. As an example here is the output of the equivalent virsh command for a Windows guest: Name MAC address Protocol Address ------------------------------------------------------------------------------- Ethernet 2 52:54:00:99:b5:62 ipv6 fe80::71fd:2467:8755:cb0b%13/64 Ethernet 2 52:54:00:99:b5:62 ipv4 192.168.0.77/26 Loopback Pseudo-Interface 1 ipv6 ::1/128 Loopback Pseudo-Interface 1 ipv4 127.0.0.1/8 isatap.{974B556C-9BAF-4A84-A1B1-9D1FDABEC29B} 00:00:00:00:00:00 ipv6 fe80::5efe:192.168.7.21%12/128 Please note the name containing white spaces: "Ethernet 2", "Loopback Pseudo-Interface 1". And also interface "Loopback Pseudo-Interface 1" not reporting a MAC address. Hope this additional information helps. Thanks. Fernando On mié, abr 15, 2020 at 11:41 PM, Fernando Casas Schössow <casasfernando(a)outlook.com> wrote: > Hi, > > While executing libvirt_domain_interface_addresses() with the > qemu-agent running in the guest as the source, the function causes > PHP to segfault. If I change the source to either dhcp or arp, the > function executes correctly. > > Example: > > $netdetails = libvirt_domain_interface_addresses($vmres, 0); <-- > executes correctly (dhcp source) > $netdetails = libvirt_domain_interface_addresses($vmres, 1); <-- > segfault (qemu agent source) > $netdetails = libvirt_domain_interface_addresses($vmres, 2); <-- > executes correctly (arp source) > > I tested the equivalent function using virsh against the same host > and it executes correctly with any source. > I have a php-cgi core file that I can share if that may help on > finding the problem. > > gdb output: > > GNU gdb (Debian 9.1-2) 9.1 > Copyright (C) 2020 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > <http://gnu.org/licenses/gpl.html> > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > Type "show copying" and "show warranty" for details. > This GDB was configured as "x86_64-linux-gnu". > Type "show configuration" for configuration details. > For bug reporting instructions, please see: > <http://www.gnu.org/software/gdb/bugs/>. > Find the GDB manual and other documentation resources online at: > <http://www.gnu.org/software/gdb/documentation/>. > > For help, type "help". > Type "apropos word" to search for commands related to "word"... > Reading symbols from /usr/bin/php-cgi... > (No debugging symbols found in /usr/bin/php-cgi) > [New LWP 2594] > [Thread debugging using libthread_db enabled] > Using host libthread_db library > "/lib/x86_64-linux-gnu/libthread_db.so.1". > Core was generated by `php-cgi index.php'. > Program terminated with signal SIGSEGV, Segmentation fault. > #0 __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:85 > 85 ../sysdeps/x86_64/multiarch/../strlen.S: No such file or directory. > (gdb) bt > #0 __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:85 > #1 0x000055c6a4ceacd2 in add_assoc_string_ex () > #2 0x00007f4d36175253 in ?? () from > /usr/lib/php/20180731/libvirt-php.so > #3 0x000055c6a4d6b477 in execute_ex () > #4 0x000055c6a4d705c7 in zend_execute () > #5 0x000055c6a4ce8ed4 in zend_execute_scripts () > #6 0x000055c6a4c8be38 in php_execute_script () > #7 0x000055c6a4b53da8 in ?? () > #8 0x00007f4d39efce0b in __libc_start_main (main=0x55c6a4b51cf0, > argc=2, argv=0x7fff35718588, init=<optimized out>, fini=<optimized > out>, > rtld_fini=<optimized out>, stack_end=0x7fff35718578) at > ../csu/libc-start.c:308 > #9 0x000055c6a4b544ca in _start () > > > System information: > > OS: Debian Bullseye > PHP version (fast cgi): 7.3.15 > Libvirt PHP version: 0.5.5 > Libvirt version: 6.0.0 > > KVM host libvirt version: 5.9.0 > > If you need any other information please let me know. > > Thanks. > > Fernando

2 4

FYI: upstream bug reporting now using https://gitlab.com/libvirt
by Daniel P. Berrangé 16 Apr '20

16 Apr '20

In keeping with our general aim to consolidate libvirt project infrastructure services on GitLab, we now wish to have issues for upstream libvirt projects reported on the appropriate https://gitlab.com/libvirt/ repository issue tracker. For further details see: https://libvirt.org/bugs.html Bugs against OS distro provided binary packages should continue to be filed against the OS distros' own bug trackers unless the problem is known to also affect current upstream libvirt versions. Note that as part of this change, the "Virtualization Tools" component on bugzilla.redhat.com has been updated to remove the ability to file new bugs against libvirt related components. Existing bugs there still exist in bugzilla, but new bugs can only be filed against gitlab.com. Over time we hope to triage old bugs and close those that are either invalid, or those not likely to be addressed given current maintainer resources available. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

Re: [libvirt-php] libvirt_domain_interface_addresses() only returns only on IP address for NICs with multiple IPs
by Fernando Casas Schössow 16 Apr '20

16 Apr '20

Forgot to add the output of the equivalent virsh command for the same VM: Name MAC address Protocol Address ------------------------------------------------------------------------------- lo 00:00:00:00:00:00 ipv4 127.0.0.1/8 lo 00:00:00:00:00:00 ipv6 ::1/128 eth0 52:54:00:12:b9:22 ipv4 192.168.7.31/26 eth0 52:54:00:12:b9:22 ipv6 fe80::5054:ff:fe12:b922/64 eth1 52:54:00:8e:b0:35 ipv4 192.168.1.34/24 eth1 52:54:00:8e:b0:35 ipv6 fe80::5054:ff:fe8e:b035/64 Thanks, Fernando On jue, abr 16, 2020 at 12:58 AM, Fernando Casas Schössow <casasfernando(a)outlook.com> wrote: > Hi, > > While using the function libvirt_domain_interface_addresses() with > qemu guest agent as the source, for interfaces with more than one IP > address, the function will only return one IP. > > Example code: > > $netdetails = libvirt_domain_interface_addresses($vmres, 2); > foreach ($netdetails as $nic) { > print_r($nic); > } > > > Example output: > > Array > ( > [name] => eth0 > [hwaddr] => 52:54:00:12:b9:22 > [naddrs] => 2 > [addrs] => Array > ( > [addr] => fe80::5054:ff:fe12:b922 > [prefix] => 64 > [type] => 1 > ) > > ) > Array > ( > [name] => eth1 > [hwaddr] => 52:54:00:8e:b0:35 > [naddrs] => 2 > [addrs] => Array > ( > [addr] => fe80::5054:ff:fe8e:b035 > [prefix] => 64 > [type] => 1 > ) > > ) > > As you can see for this guest the function returns two interfaces > (eth0 and eth1). For both interfaces naddrs => 2 which is correct > because both interfaces have an ipv4 and an ipv6 address but the > addrs array only contains the ipv6 address information while the ipv4 > address information is missing. > > System information: > > OS: Debian Bullseye > PHP version (fast cgi): 7.3.15 > Libvirt PHP version: 0.5.5 > Libvirt version: 6.0.0 > > KVM host libvirt version: 5.9.0 > > If you need any other information please let me know. > > Thanks. > > Fernando

2 1

[PATCH v2] qemu: Revoke access to mirror on failed blockcopy
by Michal Privoznik 16 Apr '20

16 Apr '20

When preparing to do a blockcopy, the mirror image is modified so that QEMU can access it. For instance, the mirror has seclabels set, if it is a NVMe disk it is detached from the host and so on. And usually, the restore is done upon successful finish of the blockcopy operation. But, if something fails then we need to explicitly revoke the access to the mirror image (and thus reattach NVMe disk back to the host). Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1822538 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v1: - Fix call of qemuDomainStorageSourceChainAccessRevoke() so that it is called even if data = crdata = NULL. src/qemu/qemu_driver.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 31f199fdef..dfe0adaad8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17950,6 +17950,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, virDomainDiskDefPtr disk = NULL; int ret = -1; bool need_unlink = false; + bool need_revoke = false; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); const char *format = NULL; bool mirror_reuse = !!(flags & VIR_DOMAIN_BLOCK_COPY_REUSE_EXT); @@ -18124,6 +18125,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, if (qemuDomainStorageSourceChainAccessAllow(driver, vm, mirror) < 0) goto endjob; + need_revoke = true; if (blockdev) { if (mirror_reuse) { @@ -18232,14 +18234,17 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, endjob: if (ret < 0 && - virDomainObjIsActive(vm) && - (data || crdata)) { - qemuDomainObjEnterMonitor(driver, vm); - if (data) - qemuBlockStorageSourceChainDetach(priv->mon, data); - if (crdata) - qemuBlockStorageSourceAttachRollback(priv->mon, crdata->srcdata[0]); - ignore_value(qemuDomainObjExitMonitor(driver, vm)); + virDomainObjIsActive(vm)) { + if (data || crdata) { + qemuDomainObjEnterMonitor(driver, vm); + if (data) + qemuBlockStorageSourceChainDetach(priv->mon, data); + if (crdata) + qemuBlockStorageSourceAttachRollback(priv->mon, crdata->srcdata[0]); + ignore_value(qemuDomainObjExitMonitor(driver, vm)); + } + if (need_revoke) + qemuDomainStorageSourceChainAccessRevoke(driver, vm, mirror); } if (need_unlink && virStorageFileUnlink(mirror) < 0) VIR_WARN("%s", _("unable to remove just-created copy target")); -- 2.25.3

2 1

[libvirt] [PATCH] qemu: fix hang in p2p + xbzrle compression + parallel migration
by Lin Ma 16 Apr '20

16 Apr '20

When we do parallel migration, The multifd-channels migration parameter needs to be set on the destination side as well before incoming migration URI, unless we accept the default number of connections(2). Usually, This can be correctly handled by libvirtd. But in this case if we use p2p + xbzrle compression without parameter '--comp-xbzrle-cache', qemuMigrationParamsDump returns too early, The corresponding migration parameter will not be set on the destination side, It results QEMU hangs. Reproducer: virsh migrate --live --p2p --comp-methods xbzrle \ --parallel --parallel-connections 3 GUEST qemu+ssh://dsthost/system or virsh migrate --live --p2p --compressed \ --parallel --parallel-connections 3 GUEST qemu+ssh://dsthost/system Signed-off-by: Lin Ma <lma(a)suse.com> --- src/qemu/qemu_migration_params.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_migration_params.c b/src/qemu/qemu_migration_params.c index dd5e2ce1b6..810199370f 100644 --- a/src/qemu/qemu_migration_params.c +++ b/src/qemu/qemu_migration_params.c @@ -630,7 +630,6 @@ qemuMigrationParamsDump(qemuMigrationParamsPtr migParams, if (migParams->compMethods == 1ULL << QEMU_MIGRATION_COMPRESS_XBZRLE && !migParams->params[QEMU_MIGRATION_PARAM_XBZRLE_CACHE_SIZE].set) { *flags |= VIR_MIGRATE_COMPRESSED; - return 0; } for (i = 0; i < QEMU_MIGRATION_COMPRESS_LAST; ++i) { -- 2.23.0

2 1

[libvirt-php] libvirt_domain_interface_addresses() only returns only on IP address for NICs with multiple IPs
by Fernando Casas Schössow 16 Apr '20

16 Apr '20

Hi, While using the function libvirt_domain_interface_addresses() with qemu guest agent as the source, for interfaces with more than one IP address, the function will only return one IP. Example code: $netdetails = libvirt_domain_interface_addresses($vmres, 2); foreach ($netdetails as $nic) { print_r($nic); } Example output: Array ( [name] => eth0 [hwaddr] => 52:54:00:12:b9:22 [naddrs] => 2 [addrs] => Array ( [addr] => fe80::5054:ff:fe12:b922 [prefix] => 64 [type] => 1 ) ) Array ( [name] => eth1 [hwaddr] => 52:54:00:8e:b0:35 [naddrs] => 2 [addrs] => Array ( [addr] => fe80::5054:ff:fe8e:b035 [prefix] => 64 [type] => 1 ) ) As you can see for this guest the function returns two interfaces (eth0 and eth1). For both interfaces naddrs => 2 which is correct because both interfaces have an ipv4 and an ipv6 address but the addrs array only contains the ipv6 address information while the ipv4 address information is missing. System information: OS: Debian Bullseye PHP version (fast cgi): 7.3.15 Libvirt PHP version: 0.5.5 Libvirt version: 6.0.0 KVM host libvirt version: 5.9.0 If you need any other information please let me know. Thanks. Fernando

1 0

[libvirt-php] libvirt_domain_interface_addresses causing segfault
by Fernando Casas Schössow 15 Apr '20

15 Apr '20

Hi, While executing libvirt_domain_interface_addresses() with the qemu-agent running in the guest as the source, the function causes PHP to segfault. If I change the source to either dhcp or arp, the function executes correctly. Example: $netdetails = libvirt_domain_interface_addresses($vmres, 0); <-- executes correctly (dhcp source) $netdetails = libvirt_domain_interface_addresses($vmres, 1); <-- segfault (qemu agent source) $netdetails = libvirt_domain_interface_addresses($vmres, 2); <-- executes correctly (arp source) I tested the equivalent function using virsh against the same host and it executes correctly with any source. I have a php-cgi core file that I can share if that may help on finding the problem. gdb output: GNU gdb (Debian 9.1-2) 9.1 Copyright (C) 2020 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details. This GDB was configured as "x86_64-linux-gnu". Type "show configuration" for configuration details. For bug reporting instructions, please see: <http://www.gnu.org/software/gdb/bugs/>. Find the GDB manual and other documentation resources online at: <http://www.gnu.org/software/gdb/documentation/>. For help, type "help". Type "apropos word" to search for commands related to "word"... Reading symbols from /usr/bin/php-cgi... (No debugging symbols found in /usr/bin/php-cgi) [New LWP 2594] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `php-cgi index.php'. Program terminated with signal SIGSEGV, Segmentation fault. #0 __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:85 85 ../sysdeps/x86_64/multiarch/../strlen.S: No such file or directory. (gdb) bt #0 __strlen_sse2 () at ../sysdeps/x86_64/multiarch/../strlen.S:85 #1 0x000055c6a4ceacd2 in add_assoc_string_ex () #2 0x00007f4d36175253 in ?? () from /usr/lib/php/20180731/libvirt-php.so #3 0x000055c6a4d6b477 in execute_ex () #4 0x000055c6a4d705c7 in zend_execute () #5 0x000055c6a4ce8ed4 in zend_execute_scripts () #6 0x000055c6a4c8be38 in php_execute_script () #7 0x000055c6a4b53da8 in ?? () #8 0x00007f4d39efce0b in __libc_start_main (main=0x55c6a4b51cf0, argc=2, argv=0x7fff35718588, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fff35718578) at ../csu/libc-start.c:308 #9 0x000055c6a4b544ca in _start () System information: OS: Debian Bullseye PHP version (fast cgi): 7.3.15 Libvirt PHP version: 0.5.5 Libvirt version: 6.0.0 KVM host libvirt version: 5.9.0 If you need any other information please let me know. Thanks. Fernando

1 0

[libvirt PATCH 0/3] travis: Drop xcode10.3 build, clean up
by Andrea Bolognani 15 Apr '20

15 Apr '20

Andrea Bolognani (3): travis: Deduplicate build instructions travis: Reduce test matrix travis: Remove usage of 'sudo' .travis.yml | 52 ++++++++++++++++++---------------------------------- 1 file changed, 18 insertions(+), 34 deletions(-) -- 2.25.2

2 10

[libvirt PATCH 0/2] gitlab: Clean up and improve ccache usage
by Andrea Bolognani 15 Apr '20

15 Apr '20

Test pipeline: https://gitlab.com/abologna/libvirt/pipelines/131128028 Andrea Bolognani (2): gitlab: Don't define $MAKE gitlab: Enable improved ccache usage .gitlab-ci.yml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) -- 2.25.1

2 6

[PATCH] qemu: Revoke access to mirror on failed blockcopy
by Michal Privoznik 15 Apr '20

15 Apr '20

When preparing to do a blockcopy, the mirror image is modified so that QEMU can access it. For instance, the mirror has seclabels set, if it is a NVMe disk it is detached from the host and so on. And usually, the restore is done upon successful finish of the blockcopy operation. But, if something fails then we need to explicitly revoke the access to the mirror image (and thus reattach NVMe disk back to the host). Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1822538 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_driver.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 31f199fdef..9475235f01 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17950,6 +17950,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, virDomainDiskDefPtr disk = NULL; int ret = -1; bool need_unlink = false; + bool need_revoke = false; g_autoptr(virQEMUDriverConfig) cfg = virQEMUDriverGetConfig(driver); const char *format = NULL; bool mirror_reuse = !!(flags & VIR_DOMAIN_BLOCK_COPY_REUSE_EXT); @@ -18124,6 +18125,7 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, if (qemuDomainStorageSourceChainAccessAllow(driver, vm, mirror) < 0) goto endjob; + need_revoke = true; if (blockdev) { if (mirror_reuse) { @@ -18240,6 +18242,8 @@ qemuDomainBlockCopyCommon(virDomainObjPtr vm, if (crdata) qemuBlockStorageSourceAttachRollback(priv->mon, crdata->srcdata[0]); ignore_value(qemuDomainObjExitMonitor(driver, vm)); + if (need_revoke) + qemuDomainStorageSourceChainAccessRevoke(driver, vm, mirror); } if (need_unlink && virStorageFileUnlink(mirror) < 0) VIR_WARN("%s", _("unable to remove just-created copy target")); -- 2.24.1

3 3

what a correct use for virConnectDomainEventRegisterAny API, how to Obtain a stable expected result
by thomas.kuang 15 Apr '20

15 Apr '20

HI, everyone: My target deal with network hotplug use virDomainDetachDeviceFlags. Because when the API return ,the network maybe doesn’t remove from my vm guest os. So I use virConnectDomainEventRegisterAny to register an event ID: VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED , my process as follow: cb_para->call_id=virConnectDomainEventRegisterAny(cb_para->conn,cb_para->dom,VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED, VIR_DOMAIN_EVENT_CALLBACK(vnf_control_del_network_cb), cb_para, vnf_control_del_network_cb_free); flags |= VIR_DOMAIN_AFFECT_CONFIG; if (virDomainIsActive(dom) == 1) { flags |= VIR_DOMAIN_AFFECT_LIVE; } ret = virDomainDetachDeviceFlags(dom, xml, flags); above code write in thread loop ,then in the same loop : while (1) { mission = vnf_mission_queue_get(task); if (mission == NULL) { sleep(1); continue; } vnf_op_process(&mission->info); // this will deal with network hotplug,will call virConnectDomainEventRegisterAny then call virDomainDetachDeviceFlags if (mission) { vnf_mission_free(mission); } if(virEventRunDefaultImpl() < 0) { // at here process the registered callback for event-registered printf();.... } } My problem is: some time , the virEventRunDefaultImpl can trigger the vnf_control_del_network_cb callback ,but some time there is nothing ,as if the VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED has lost. what cause the Unpredictable behavior ? what is a correct use for virConnectDomainEventRegisterAny ? if can't trigger the vnf_control_del_network_cb callback , the memory :cb_para will mem-leak, so in order to deal the execpt ,i register a timer to process the VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED timeout cb_para->timer_id = virEventAddTimeout(cb_para->time_out, vnf_control_del_network_timeout_cb, cb_para, vnf_control_del_network_cb_free); thought use the timer ,can i avoid the cb_para mem-leak, but fail to achive hotplug network .

2 2

[PATCH 00/43] Replace virMutex & co. by the Glib equivalent
by Rafael Fonseca 15 Apr '20

15 Apr '20

This patch series replaces virMutex and virRWLock by GMutex and GRWLock, respectively. And because virCond usage is connected to virCond, it also replaces the latter by GCond. Rafael Fonseca (43): admin: convert virMutex to GMutex bhyve: convert virMutex to GMutex conf: nwfilter_ipaddrmap: convert virMutex to GMutex conf: virchrdev: convert virMutex to GMutex esx: convert virMutex to GMutex util: virtpm: convert virMutex to GMutex vbox: convert virMutex to GMutex util: virnodesuspend: convert virMutex to GMutex libxl: convert virMutex to GMutex in libxlPrivate vz: vz_driver: convert virMutex to GMutex locking: convert virMutex to GMutex logging: convert virMutex to GMutex conf: nwfilter_conf: convert virRWLock to GRWLock util: virlog: convert virMutex to GMutex test: convert virMutex to GMutex nwfilter: nwfilter_dhcpsnoop: convert virMutex to GMutex nwfilter: nwfilter_gentech_driver: convert virMutex to GRecMutex lxc: lxc_fuse: convert virMutex to GMutex lxc: convert virMutex to GMutex network: bridge_driver: convert virMutex to GMutex node_device: convert virMutex to GMutex vmware: convert virMutex to GMutex tests: qemusecuritymock: convert virMutex to GMutex tests: qemumonitortestutils: convert virMutex to GMutex qemu: convert virMutex to GMutex remote: remote_driver: convert virMutex to GMutex nwfilter: convert virMutex to GMutex openvz: convert virMutex to GMutex storage: convert virMutex to GMutex secret: convert virMutex to GMutex remote: convert virMutex to GMutex in daemonClientPrivate util: virfirewall: convert virMutex to GMutex util: virlockspace: convert virMutex to GMutex util: virnetdevmacvlan: convert virMutex to GMutex util: virnetdevveth: convert virMutex to GMutex util: virnetlink: convert virMutex to GMutex tools: virsh: convert virMutex to GMutex nwfilter: nwfilter_learnipaddr: convert virMutex to GMutex util: virthreadpool: convert virMutex to GMutex util: virObjectRWLockable: convert virRWLock to GRWLock util: virthread: remove virRWLock util: virObjectLockable: convert virMutex to GMutex util: virthread: remove GMutex and Gcond examples/systemtap/lock-debug.stp | 4 +- src/admin/admin_server_dispatch.c | 13 +-- src/bhyve/bhyve_driver.c | 11 +- src/bhyve/bhyve_utils.h | 2 +- src/conf/domain_conf.c | 27 +---- src/conf/domain_conf.h | 5 +- src/conf/nwfilter_conf.c | 21 ++-- src/conf/nwfilter_conf.h | 5 +- src/conf/nwfilter_ipaddrmap.c | 14 +-- src/conf/virchrdev.c | 27 ++--- src/conf/virdomainobjlist.c | 35 +++--- src/conf/virinterfaceobj.c | 18 +-- src/conf/virnetworkobj.c | 20 ++-- src/conf/virnodedeviceobj.c | 16 +-- src/conf/virnodedeviceobj.h | 4 +- src/conf/virnwfilterbindingobjlist.c | 14 +-- src/conf/virnwfilterobj.c | 15 +-- src/conf/virnwfilterobj.h | 2 +- src/conf/virsecretobj.c | 16 +-- src/conf/virstorageobj.c | 50 ++++----- src/conf/virstorageobj.h | 2 +- src/esx/esx_stream.c | 25 ++--- src/esx/esx_vi.c | 68 ++++------- src/esx/esx_vi.h | 6 +- src/libvirt_private.syms | 22 +--- src/libxl/libxl_conf.h | 6 +- src/libxl/libxl_domain.c | 18 +-- src/libxl/libxl_domain.h | 2 +- src/libxl/libxl_driver.c | 9 +- src/locking/lock_daemon.c | 32 ++---- src/locking/lock_daemon.h | 2 +- src/locking/lock_daemon_dispatch.c | 32 ++---- src/logging/log_daemon.c | 26 +---- src/logging/log_daemon.h | 2 +- src/lxc/lxc_conf.h | 6 +- src/lxc/lxc_controller.c | 25 ++--- src/lxc/lxc_domain.c | 18 +-- src/lxc/lxc_domain.h | 2 +- src/lxc/lxc_driver.c | 11 +- src/lxc/lxc_fuse.c | 13 +-- src/lxc/lxc_fuse.h | 2 +- src/network/bridge_driver.c | 11 +- src/network/bridge_driver_platform.h | 2 +- src/node_device/node_device_driver.c | 11 +- src/node_device/node_device_hal.c | 20 +--- src/node_device/node_device_udev.c | 43 ++----- src/nwfilter/nwfilter_dhcpsnoop.c | 48 ++++---- src/nwfilter/nwfilter_driver.c | 15 ++- src/nwfilter/nwfilter_gentech_driver.c | 40 +++---- src/nwfilter/nwfilter_learnipaddr.c | 43 ++++--- src/openvz/openvz_conf.h | 2 +- src/openvz/openvz_driver.c | 4 +- src/qemu/qemu_agent.c | 50 ++++----- src/qemu/qemu_conf.c | 4 +- src/qemu/qemu_conf.h | 2 +- src/qemu/qemu_domain.c | 95 +++++++--------- src/qemu/qemu_domain.h | 4 +- src/qemu/qemu_driver.c | 21 ++-- src/qemu/qemu_hotplug.c | 28 ++--- src/qemu/qemu_hotplug.h | 2 +- src/qemu/qemu_migration.c | 2 +- src/qemu/qemu_monitor.c | 27 ++--- src/qemu/qemu_process.c | 4 +- src/remote/remote_daemon.h | 2 +- src/remote/remote_daemon_dispatch.c | 100 ++++------------- src/remote/remote_daemon_stream.c | 29 ++--- src/remote/remote_driver.c | 15 +-- src/rpc/virnetclient.c | 25 ++--- src/secret/secret_driver.c | 13 +-- src/storage/storage_driver.c | 11 +- src/test/test_driver.c | 12 +- src/util/virfdstream.c | 26 ++--- src/util/virfirewall.c | 6 +- src/util/virlockspace.c | 83 ++++---------- src/util/virlog.c | 9 +- src/util/virnetdevmacvlan.c | 20 ++-- src/util/virnetdevveth.c | 6 +- src/util/virnetlink.c | 15 +-- src/util/virnodesuspend.c | 6 +- src/util/virobject.c | 40 +++---- src/util/virobject.h | 10 +- src/util/virthread.c | 134 ---------------------- src/util/virthread.h | 57 ---------- src/util/virthreadpool.c | 149 +++++++++---------------- src/util/virtpm.c | 18 +-- src/vbox/vbox_common.c | 12 +- src/vmware/vmware_conf.c | 2 +- src/vmware/vmware_conf.h | 2 +- src/vmware/vmware_driver.c | 7 +- src/vz/vz_driver.c | 26 ++--- src/vz/vz_utils.c | 41 ++----- src/vz/vz_utils.h | 6 +- tests/qemuhotplugmock.c | 6 +- tests/qemuhotplugtest.c | 2 + tests/qemumonitortestutils.c | 42 +++---- tests/qemusecuritymock.c | 30 ++--- tests/qemusecuritytest.c | 10 +- tests/qemuxml2argvtest.c | 1 + tests/testutilslxc.c | 9 +- tests/testutilsqemu.c | 5 +- tests/testutilsxen.c | 9 +- tools/virsh-console.c | 23 +--- tools/virsh.c | 11 +- tools/virt-admin.c | 11 +- tools/vsh.c | 4 +- tools/vsh.h | 2 +- 106 files changed, 747 insertions(+), 1426 deletions(-) -- 2.25.2

5 64

Wiki page audit - possible page deleteion
by Daniel P. Berrangé 15 Apr '20

15 Apr '20

Ideally I would like to decomission the current wiki.libvirt.org site. It is based on mediawiki running on openshift and has myself as a single point of failure. GitLab provides a wiki, but I don't think we need to use that either, as I think that it is desirable to bring the content into our main website. By putting an "edit this page" link on each page of our website, users can quickly see what source to change. There is still the burden of submitting a merge request & having review feedback, but I think we could mitigate this by having the reviewer actually make the changes they want directly, avoiding the tedious back & forth updates in easy cases. GitLab allows this if the person opening the merge request selects the option to allow maintainers to edit code. In any case, to remove wiki.libvirt.org we need to do something with its current content. The majority of content was first created 5-10 years ago, only a handful of pages get frequent edits right now: https://wiki.libvirt.org/index.php?title=Special:RecentChanges&limit=500&da… Looking at the pages I see some key groups, so I'll talk about them separately... A set of "Troubleshooting" guides supposedly describing common problems and their suggested solution. Some of these still apply but others will be outdated, so we need to decide which to keep. Yes we really do have multiple spellings of the same page in many cases After import a guest from an existing disk image using virt-install, the guest starting stalls with "No boot device" Common XML errors Could not add rule to fixup DHCP response checksums on network 'default' Creating VMWare ESXi domain failed with error "this function is not supported by the connection driver: virDomainCreateXML" Determining version information Determining version information, dealing with "unknown procedure" Different Processor Model Determined Different processor model determined Domain cannot be installed Domain starting fails with Error "monitor socket did not show up" Error "internal error cannot find character device" when trying to connect a domain's console Failed to connect to the hypervisor Guest can reach host, but can't reach outside network Guest can reach outside network, but can't reach host (macvtap) Guest won't start - warning: could not open /dev/net/tun ('generic ethernet' interface) I created an external snapshot, but libvirt will not let me delete or revert to it I created an external snapshot, but libvirt won't let me delete or revert to it Libvirt daemon is not listening on tcp ports although configured to Libvirt identifies host processor as a different model from the hardware documentation Migration fails because disk image cannot be found Migration fails with "Unable to resolve address" error No guest machines are present PXE boot (or dhcp) on guest failed The daemon cannot be started The domain cannot be started when specifying different processor TroubleshootMacvtapHostFail Troubleshooting Unable to add bridge br0 port vnet0: No such device Unable to connect to console of a running domain Virtual network "default" has not been started Virtual network 'default' has not been started Some illustrated guides to TLS cert creation. We already have a page https://libvirt.org/tlscerts.html and the wiki duplicates much of the info there. One difference is that the wiki also describes the gtk-vnc/spice-gtk/qemu cert setup, not merely libvirt. We should really consolidate into our main website though, as its confusing to have two separate docs for the same tasks TLSCreateCACert TLSCreateCACertSteps TLSCreateClientCerts TLSCreateServerCerts TLSDaemonConfiguration TLSFurtherReferences TLSSetup HostCommTLSSetup VNCTLSSetup Various GSoC pages, the per-year pages, and for 2016 only some reports from the contributors. Most of the latter is outdated info that's no longer really relevant, so I'd probablyjust delete the last 4 pages, and move the rest to the main site. Google Summer of Code 2016 Google Summer of Code 2017 Google Summer of Code 2018 Google Summer of Code 2019 Google Summer of Code FAQ Google Summer of Code Ideas Google Summer of Code 2016/Abstracting device address allocation Google Summer of Code 2016/Asynchronous lifecycle events for storage objects Google Summer of Code 2016/Making virsh more bash like Google Summer of Code 2016/lxc migration Some graphically illustrated guides to virtmanager. These never belonged here, and should be part of virt-manager website if they're really still desired. The screenshots are from an ancient version though, so I figure we can just delete them. TaskIsolatedNetworkSetupVirtManager TaskNATSetupVirtManager TaskRoutedNetworkSetupVirtManager CreatingNewVM in VirtualMachineManager DeletingVirtualMachine in VirtualMachineManager VirtualNetworking SSHSetup Some old pages containing a "todo" list, which we stopped updating a long time ago. Many of the ideas are not things we'd want to implement today so serve to mislead people. Propose to delete them all Todo TodoAMQPAgent TodoAsynchronousJobs TodoAvahiTXTSupport TodoConcurrentConnectionPtr TodoDaemonMultithreading TodoDaemonRestart TodoDriverKVM TodoEvents TodoFineGrainedSecurity TodoHostDevicePassthru TodoHostDevices TodoModules TodoNICBonding TodoNICMultipath TodoNetworkTopologyDiscovery TodoPackages TodoPoolBasedConfigs TodoPreMigrationChecks TodoSecureMigration TodoStorageSCSI TodoVMSnapshots TodoVirtViewerSecurity TodoWindowsSupport Stuff related to Cimtest, largely pages containing results form test runs from ancient distros. I propose to delete all of this as its irrelevant even if someone was still interested in cimtest today. Cimtest Cimtest buglist Cimtest setup Cimtest test info Cimtest testruns Cimtest todo KVM F10 KVM F11 KVM F12 KVM F13 KVM F9 KVM current KVM current Fedora rawhide KVM current SLES11 KVM current sources on RHEL5.4 KVM on current sources - older test results LXC current XenFV current XenFV current 53 XenFV current Fedora XenFV rpm XenPV current XenPV current 53 XenPV current Fedora XenPV rpm XenPV rpm 54 Various misc pages that I've not spent too much time looking at each page, but as a rough approx I'd keep the following list, pulling it into the main website BiteSizedTasks DebugLogs Debugging FAQ Libvirt-snmp Libvirtd and dnsmasq Live-disk-backup-with-active-blockcommit Live-merge-an-entire-disk-image-chain-including-current-active-disk Maintenance Releases NPIV in libvirt Net.bridge-nf-call and sysctl.conf Net.bridge.bridge-nf-call and sysctl.conf Networking Qemu guest agent SSHPolicyKitSetup VM lifecycle Vhost-scsi target And probably delete the following (though some might want preserving upon closer inspection) AprilFools' AreasToFocusOnTesting DocsToDo Features/virSimple HowToPopulateLibosinfoDB IntroductoryGuides KVMGapPriorityList Libvirt-CIM Libvirt-CIM/Issues Libvirt-cim setup Libvirt-gconfig Libvirt-qpid LibvirtCim/Bugs LibvirtConsoleManagement Main Page Making virsh more bash like NBD storage migration OVS and PVLANS OldTodo QEMUSwitchToLibvirt SVGImages Snapshots Stable Releases StorageDocsPerfectWorldScenario Tips UbuntuKVMWalkthrough VirshHelpV2 Virtio Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

4 5

[libvirt PATCH] docs: Add pci-addresses.rst
by Andrea Bolognani 15 Apr '20

15 Apr '20

This document describes the relationship between PCI addresses as seen in the domain XML and by the guest OS, which is a topic that people get confused by time and time again. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/formatdomain.html.in | 6 +- docs/pci-addresses.rst | 184 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 189 insertions(+), 1 deletion(-) create mode 100644 docs/pci-addresses.rst diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 6f43976815..0077666862 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4286,7 +4286,11 @@ element with no other attributes as an explicit request to assign a PCI address for the device rather than some other type of address that may also be appropriate for that same - device (e.g. virtio-mmio). + device (e.g. virtio-mmio). + The relationship between the PCI addresses configured in the domain + XML and those seen by the guest OS can sometime seem confusing: a + separate document describes <a href="pci-addresses.html">how PCI + addresses work</a> in more detail. </dd> <dt><code>drive</code></dt> <dd>Drive addresses have the following additional diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst new file mode 100644 index 0000000000..96c6466899 --- /dev/null +++ b/docs/pci-addresses.rst @@ -0,0 +1,184 @@ +======================================== +PCI addresses in domain XML and guest OS +======================================== + +.. contents:: + +When discussing PCI addresses, it's important to understand the the +relationship between the addresses that can be seen in the domain XML +and those that are visible inside the guest OS. + + +Simple cases +============ + +When the PCI topology of the VM is very simple, the PCI addresses +will usually match. + +For example, the domain XML snippet + +:: + + <controller type='pci' index='0' model='pcie-root'/> + <controller type='pci' index='1' model='pcie-root-port'> + <model name='pcie-root-port'/> + <target chassis='1' port='0x8'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> + </controller> + <interface type='network'> + <source network='default'/> + <model type='virtio'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> + </interface> + +will result in the PCI topology + +:: + + 0000:00:00.0 Host bridge: Intel Corporation 82G33/G31/P35/P31 Express DRAM Controller + 0000:00:01.0 PCI bridge: Red Hat, Inc. QEMU PCIe Root port + 0000:01:00.0 Ethernet controller: Red Hat, Inc. Virtio network device (rev 01) + +showing up in the guest OS. + +The PCI address of the ``virtio-net`` adapter, ``0000:01:00.0``, is +the same in both cases, so there's no confusion. + + +More complex cases +================== + +In more complex cases, the PCI address visible in the domain XML will +correlate to the one seen by the guest OS in a less obvious way. + +pcie-expander-bus +----------------- + +This fairly uncommon device, which can be used with ``x86_64/q35`` +guests, will help illustrate one such scenario. + +For example, the domain XML snippet + +:: + + <controller type='pci' index='0' model='pcie-root'/> + <controller type='pci' index='1' model='pcie-expander-bus'> + <model name='pxb-pcie'/> + <target busNr='254'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> + </controller> + <controller type='pci' index='2' model='pcie-root-port'> + <model name='pcie-root-port'/> + <target chassis='2' port='0x0'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> + </controller> + <interface type='network'> + <source network='default'/> + <model type='virtio'/> + <address type='pci' domain='0x0000' bus='0x02' slot='0x00' function='0x0'/> + </interface> + +will result in the PCI topology + +:: + + 0000:00:00.0 Host bridge: Intel Corporation 82G33/G31/P35/P31 Express DRAM Controller + 0000:00:01.0 Host bridge: Red Hat, Inc. QEMU PCIe Expander bridge + 0000:fe:00.0 PCI bridge: Red Hat, Inc. QEMU PCIe Root port + 0000:ff:00.0 Ethernet controller: Red Hat, Inc. Virtio network device (rev 01) + +showing up in the guest OS. + +This time the addresses don't match: this is because the ``busNr`` +property for the ``pcie-expander-bus`` controller causes it to show +up as bus 254 (``0xfe`` in hexadecimal) instead of bus 1 as one might +expect based on its ``index`` property. + +How can the domain XML shown above work at all, then? Surely the +``pcie-root-port`` controller and the ``virtio-net`` adapter should +use ``bus=0xfe`` and ``bus=0xff`` respectively for the configuration +to be accepted by libvirt? + +As it turns out, that's not the case. The reason for this is that +QEMU, and consequently libvirt, uses the ``bus`` property of a +device's PCI address only to match it with the PCI controller that +has the same ``index`` property, and not to set the actual PCI +address, which is decided by the guest OS. + +So, by looking at the XML snippet above, we can see that the +``virtio-net`` adapter plugs into the ``pcie-root-port`` controller, +which plugs into the ``pcie-expander-bus`` controller, which plugs +into ``pcie-root``: the guest OS sees the same topology, but assigns +different PCI addresses to some of its component. + +The takeaway is that the *relationship* between controllers are the +very same whether you look at the domain XML or at the guest OS, but +the *actual PCI addresses* are not guaranteed to match and in fact, +except for the very simplest cases, they usually will not. + +spapr-pci-host-bridge +--------------------- + +This device, which is unique to ``ppc64/pseries`` guests, will help +illustrate another scenario. + +For example, the domain XML snippet + +:: + + <controller type='pci' index='0' model='pci-root'> + <model name='spapr-pci-host-bridge'/> + <target index='0'/> + </controller> + <controller type='pci' index='1' model='pci-root'> + <model name='spapr-pci-host-bridge'/> + <target index='1'/> + </controller> + <interface type='network'> + <source network='default'/> + <model type='virtio'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x01' function='0x0'/> + </interface> + +will result in the PCI topology + +:: + + 0001:00:01.0 Ethernet controller: Red Hat, Inc. Virtio network device + +showing up in the guest OS. Note that the two +``spapr-pci-host-bridge`` controllers are not listed. + +This time, in addition to the bus not matching just like in the +previous example, the interesting part is that the domain doesn't +match either: this is because each ``spapr-pci-host-bridge`` +controller creates a separate PCI domain. + +Once again, while the PCI addresses seen in the domain XML and those +seen by the guest OS do not match, the relationships between the +various devices are preserved. + + +Device assignment +================= + +When using VFIO to assign host devices to a guest, an additional +caveat to keep in mind that the guest OS will base its decisions upon +the *target address* rather than the *source address*. + +For example, the domain XML snippet + +:: + + <hostdev mode='subsystem' type='pci' managed='yes'> + <driver name='vfio'/> + <source> + <address domain='0x0001' bus='0x08' slot='0x00' function='0x0'/> + </source> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0'/> + </hostdev> + +will result in the device showing up as ``0000:00:01.0`` in the +guest OS rather than as ``0001:08:00.1``. + +Of course, all the rules and behaviors described above still apply. -- 2.25.2

4 5

[libvirt PATCH] docs: Fix word repetition in pci-addresses.rst
by Andrea Bolognani 15 Apr '20

15 Apr '20

Fixes: 2923e7a3dd984c46202703d390dce3ff4ea4048c Reported-by: Ján Tomko <jtomko(a)redhat.com> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Pushed under the build fix rule. docs/pci-addresses.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/pci-addresses.rst b/docs/pci-addresses.rst index 991cb84aa1..923783a151 100644 --- a/docs/pci-addresses.rst +++ b/docs/pci-addresses.rst @@ -4,7 +4,7 @@ PCI addresses in domain XML and guest OS .. contents:: -When discussing PCI addresses, it's important to understand the the +When discussing PCI addresses, it's important to understand the relationship between the addresses that can be seen in the domain XML and those that are visible inside the guest OS. -- 2.25.2

1 0

[PATCH v2] apparmor: avoid denials on libpmem initialization
by Christian Ehrhardt 15 Apr '20

15 Apr '20

With libpmem support compiled into qemu it will trigger the following denials on every startup. apparmor="DENIED" operation="open" name="/" apparmor="DENIED" operation="open" name="/sys/bus/nd/devices/" This is due to [1] that tries to auto-detect if the platform supports auto flush for all region. Once we know all the paths that are potentially needed if this feature is really used we can add them conditionally in virt-aa-helper and labelling calls in case </pmem> is enabled. But until then the change here silences the denial warnings seen above. [1]: https://github.com/pmem/pmdk/blob/master/src/libpmem2/auto_flush_linux.c#L1… Bug: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1871354 Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/apparmor/libvirt-qemu | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/security/apparmor/libvirt-qemu b/src/security/apparmor/libvirt-qemu index 80986aec61..1a4b226612 100644 --- a/src/security/apparmor/libvirt-qemu +++ b/src/security/apparmor/libvirt-qemu @@ -227,3 +227,8 @@ # required for sasl GSSAPI plugin /etc/gss/mech.d/ r, /etc/gss/mech.d/* r, + + # required by libpmem init to fts_open()/fts_read() the symlinks in + # /sys/bus/nd/devices + / r, # harmless on any lsb compliant system + /sys/bus/nd/devices/{,**/} r, -- 2.26.0

2 2

[PATCH] libxl: enable Xen's e820_host setting
by Jim Fehlig 15 Apr '20

15 Apr '20

Hotplugging PCI devices to Xen PV guests is only possible if the libxl_domain_build_info struct has the e820_host field enabled when the guest is created. By default it is disabled but libxl will automatically enable e820_host if the config contains one or more PCI devices, in which case hotplugging additional PCI devices later works. According to xl.cfg(5) man page it is safe to unconditionally enable the PV-only e820_host setting. Furthermore xen.git commits 414979ba85 and f92337d949, which introduce the setting with a default of disabled, claim the setting can be enabled or even removed "once the auto-ballooning of guests with PCI devices works". Those commits are from May 2011 so I think it is safe to say the issues have been resolved in the meantime. Regardless, we should avoid exposing a Xen setting in libvirt that could be removed later. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- See related thread on the ML https://www.redhat.com/archives/libvir-list/2020-April/msg00376.html src/libxl/libxl_conf.c | 5 +++++ tests/libxlxml2domconfigdata/basic-pv.json | 3 ++- tests/libxlxml2domconfigdata/multiple-ip.json | 3 ++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index be5fc505fe..f6280157fb 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -288,6 +288,11 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, #endif } else { libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PV); + /* + * e820_host is a PV-only setting and according to xl.cfg(5) it + * should be safe to unconditionally enable it. + */ + libxl_defbool_set(&b_info->u.pv.e820_host, true); } b_info->max_vcpus = virDomainDefGetVcpusMax(def); diff --git a/tests/libxlxml2domconfigdata/basic-pv.json b/tests/libxlxml2domconfigdata/basic-pv.json index b71c3b0f49..2cb95feff8 100644 --- a/tests/libxlxml2domconfigdata/basic-pv.json +++ b/tests/libxlxml2domconfigdata/basic-pv.json @@ -19,7 +19,8 @@ }, "type.pv": { - "bootloader": "pygrub" + "bootloader": "pygrub", + "e820_host": "True" }, "arch_arm": { diff --git a/tests/libxlxml2domconfigdata/multiple-ip.json b/tests/libxlxml2domconfigdata/multiple-ip.json index 2db98b82f6..01bb169cdc 100644 --- a/tests/libxlxml2domconfigdata/multiple-ip.json +++ b/tests/libxlxml2domconfigdata/multiple-ip.json @@ -19,7 +19,8 @@ }, "type.pv": { - "bootloader": "pygrub" + "bootloader": "pygrub", + "e820_host": "True" }, "arch_arm": { -- 2.26.0

3 7

[PATCH v2 0/4] libxl: add e820_host option to the libvirt config
by Marek Marczykowski-Górecki 15 Apr '20

15 Apr '20

Context: - old thread on xen-devel: http://xen.markmail.org/thread/awcswnywzei4s65e - new thread here: https://www.redhat.com/archives/libvir-list/2020-April/msg00447.html Marek Marczykowski-Górecki (4): conf: add xen specific feature: e820_host libxl: make use of e820_host feature xenconfig: parse e820_host option tests: check e820_host option handling docs/formatdomain.html.in | 20 ++++- docs/schemas/domaincommon.rng | 16 +++- src/conf/domain_conf.c | 102 ++++++++++++++++++- src/conf/domain_conf.h | 9 ++- src/libxl/libxl_conf.c | 14 ++- src/libxl/xen_common.c | 13 ++- src/qemu/qemu_validate.c | 1 +- tests/xlconfigdata/test-paravirt-e820_host.cfg | 13 ++- tests/xlconfigdata/test-paravirt-e820_host.xml | 37 +++++++- tests/xlconfigtest.c | 1 +- 10 files changed, 226 insertions(+) create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.cfg create mode 100644 tests/xlconfigdata/test-paravirt-e820_host.xml base-commit: 7118bdee1550b6022e7362402ca8204add4cf80b -- git-series 0.9.1

2 5

[PATCH 0/2] backup: Fix docs and add schema for LUKS encrypted backups
by Peter Krempa 14 Apr '20

14 Apr '20

Peter Krempa (2): docs: backup: Remove references to push backup to network disk backup: Allow 'encryption' of backups and scratch images docs/formatbackup.html.in | 19 ++++-- docs/schemas/domainbackup.rng | 65 +++++++++++++++---- .../backup-pull-encrypted.xml | 30 +++++++++ .../backup-push-encrypted.xml | 29 +++++++++ .../backup-pull-encrypted.xml | 30 +++++++++ .../backup-push-encrypted.xml | 29 +++++++++ tests/genericxml2xmltest.c | 3 + 7 files changed, 187 insertions(+), 18 deletions(-) create mode 100644 tests/domainbackupxml2xmlin/backup-pull-encrypted.xml create mode 100644 tests/domainbackupxml2xmlin/backup-push-encrypted.xml create mode 100644 tests/domainbackupxml2xmlout/backup-pull-encrypted.xml create mode 100644 tests/domainbackupxml2xmlout/backup-push-encrypted.xml -- 2.26.0

4 7

[libvirt PATCH] README: rewrite in rst
by Ján Tomko 14 Apr '20

14 Apr '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- README | 2 +- README.md => README.rst | 53 +++++++++++++++++++++-------------------- 2 files changed, 28 insertions(+), 27 deletions(-) rename README.md => README.rst (65%) diff --git a/README b/README index 42061c01a1..92cacd2853 120000 --- a/README +++ b/README @@ -1 +1 @@ -README.md \ No newline at end of file +README.rst \ No newline at end of file diff --git a/README.md b/README.rst similarity index 65% rename from README.md rename to README.rst index 44b0dd87c5..222ba55e78 100644 --- a/README.md +++ b/README.rst @@ -1,6 +1,11 @@ -[![Build Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/l… - [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/355/badge)… +.. image:: https://travis-ci.org/libvirt/libvirt.svg + :alt: Build Status + :target: https://travis-ci.org/libvirt/libvirt +.. image:: https://bestpractices.coreinfrastructure.org/projects/355/badge + :alt: CII Best Practices + :target: https://bestpractices.coreinfrastructure.org/projects/355 +============================== Libvirt API for virtualization ============================== @@ -21,60 +26,56 @@ mappings into object systems such as GObject, CIM and SNMP. Further information about the libvirt project can be found on the website: -[https://libvirt.org](https://libvirt.org) +https://libvirt.org License -------- +======= The libvirt C API is distributed under the terms of GNU Lesser General Public License, version 2.1 (or later). Some parts of the code that are not part of the C library may have the more restrictive GNU General -Public License, version 2.0 (or later). See the files `COPYING.LESSER` -and `COPYING` for full license terms & conditions. +Public License, version 2.0 (or later). See the files ``COPYING.LESSER`` +and ``COPYING`` for full license terms & conditions. Installation ------------- +============ Libvirt uses the GNU Autotools build system, so in general can be built and installed with the usual commands, however, we mandate to have the build directory different than the source directory. For example, to build -in a manner that is suitable for installing as root, use: +in a manner that is suitable for installing as root, use:: -``` -$ mkdir build && cd build -$ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var -$ make -$ sudo make install -``` + $ mkdir build && cd build + $ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var + $ make + $ sudo make install -While to build & install as an unprivileged user +While to build & install as an unprivileged user:: -``` -$ mkdir build && cd build -$ ../configure --prefix=$HOME/usr -$ make -$ make install -``` + $ mkdir build && cd build + $ ../configure --prefix=$HOME/usr + $ make + $ make install The libvirt code relies on a large number of 3rd party libraries. These will -be detected during execution of the `configure` script and a summary printed +be detected during execution of the ``configure`` script and a summary printed which lists any missing (optional) dependencies. Contributing ------------- +============ The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list. Further guidance on this can be found on the website: -[https://libvirt.org/contribute.html](https://libvirt.org/contribute.html) +https://libvirt.org/contribute.html Contact -------- +======= The libvirt project has two primary mailing lists: @@ -83,4 +84,4 @@ The libvirt project has two primary mailing lists: Further details on contacting the project are available on the website: -[https://libvirt.org/contact.html](https://libvirt.org/contact.html) +https://libvirt.org/contact.html -- 2.25.1

2 1

[libvirt PATCH] Convert all remaining Markdown files to reStructuredText
by Andrea Bolognani 14 Apr '20

14 Apr '20

We've adopted reStructuredText as the primary markup language for our documentation and, given that both GitLab and GitHub can render documents in this format just fine, it makes sense to get rid of the few last remaining bits of Markdown and standardize on reStructuredText across the board. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Note that I've taken a few liberties during the conversion when it comes to formatting, with the goal of staying close to the style used for existing reStructuredText documents, but I have not altered the contents beyond that. ABOUT-NLS | 2 +- Makefile.am | 2 +- README | 2 +- README.md => README.rst | 55 ++++++++++++----------- docs/Makefile.am | 2 +- docs/fonts/{LICENSE.md => LICENSE.rst} | 30 +++++++++---- libvirt.spec.in | 2 +- po/{README.md => README.rst} | 32 ++++++++----- tools/wireshark/{README.md => README.rst} | 28 ++++++++---- 9 files changed, 97 insertions(+), 58 deletions(-) rename README.md => README.rst (65%) rename docs/fonts/{LICENSE.md => LICENSE.rst} (94%) rename po/{README.md => README.rst} (86%) rename tools/wireshark/{README.md => README.rst} (52%) diff --git a/ABOUT-NLS b/ABOUT-NLS index b583e276a7..91a3266ed6 120000 --- a/ABOUT-NLS +++ b/ABOUT-NLS @@ -1 +1 @@ -po/README.md \ No newline at end of file +po/README.rst \ No newline at end of file diff --git a/Makefile.am b/Makefile.am index 5590c88e4d..06475344c1 100644 --- a/Makefile.am +++ b/Makefile.am @@ -43,7 +43,7 @@ EXTRA_DIST = \ autogen.sh \ GNUmakefile \ run.in \ - README.md \ + README.rst \ AUTHORS.in \ scripts/apibuild.py \ scripts/augeas-gentest.py \ diff --git a/README b/README index 42061c01a1..92cacd2853 120000 --- a/README +++ b/README @@ -1 +1 @@ -README.md \ No newline at end of file +README.rst \ No newline at end of file diff --git a/README.md b/README.rst similarity index 65% rename from README.md rename to README.rst index 44b0dd87c5..663fba4510 100644 --- a/README.md +++ b/README.rst @@ -1,6 +1,9 @@ -[![Build Status](https://travis-ci.org/libvirt/libvirt.svg)](https://travis-ci.org/l… - [![CII Best Practices](https://bestpractices.coreinfrastructure.org/projects/355/badge)… +.. image:: https://travis-ci.org/libvirt/libvirt.svg + :alt: Travis CI Build Status +.. image:: https://bestpractices.coreinfrastructure.org/projects/355/badge + :alt: CII Best Practices +============================== Libvirt API for virtualization ============================== @@ -21,66 +24,66 @@ mappings into object systems such as GObject, CIM and SNMP. Further information about the libvirt project can be found on the website: -[https://libvirt.org](https://libvirt.org) +https://libvirt.org License -------- +======= The libvirt C API is distributed under the terms of GNU Lesser General Public License, version 2.1 (or later). Some parts of the code that are not part of the C library may have the more restrictive GNU General -Public License, version 2.0 (or later). See the files `COPYING.LESSER` -and `COPYING` for full license terms & conditions. +Public License, version 2.0 (or later). See the files ``COPYING.LESSER`` +and ``COPYING`` for full license terms & conditions. Installation ------------- +============ Libvirt uses the GNU Autotools build system, so in general can be built and installed with the usual commands, however, we mandate to have the build directory different than the source directory. For example, to build in a manner that is suitable for installing as root, use: -``` -$ mkdir build && cd build -$ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var -$ make -$ sudo make install -``` +:: + + $ mkdir build && cd build + $ ../configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var + $ make + $ sudo make install While to build & install as an unprivileged user -``` -$ mkdir build && cd build -$ ../configure --prefix=$HOME/usr -$ make -$ make install -``` +:: + + $ mkdir build && cd build + $ ../configure --prefix=$HOME/usr + $ make + $ make install The libvirt code relies on a large number of 3rd party libraries. These will -be detected during execution of the `configure` script and a summary printed +be detected during execution of the ``configure`` script and a summary printed which lists any missing (optional) dependencies. Contributing ------------- +============ The libvirt project welcomes contributions in many ways. For most components the best way to contribute is to send patches to the primary development mailing list. Further guidance on this can be found on the website: -[https://libvirt.org/contribute.html](https://libvirt.org/contribute.html) +https://libvirt.org/contribute.html Contact -------- +======= The libvirt project has two primary mailing lists: - * libvirt-users(a)redhat.com (**for user discussions**) - * libvir-list(a)redhat.com (**for development only**) +* libvirt-users(a)redhat.com (**for user discussions**) +* libvir-list(a)redhat.com (**for development only**) Further details on contacting the project are available on the website: -[https://libvirt.org/contact.html](https://libvirt.org/contact.html) +https://libvirt.org/contact.html diff --git a/docs/Makefile.am b/docs/Makefile.am index 404121a2a2..6860efc888 100644 --- a/docs/Makefile.am +++ b/docs/Makefile.am @@ -118,7 +118,7 @@ javascriptdir = $(HTML_DIR)/js javascript_DATA = $(javascript) fonts = \ - fonts/LICENSE.md \ + fonts/LICENSE.rst \ fonts/stylesheet.css \ fonts/overpass-bold-italic.woff \ fonts/overpass-bold.woff \ diff --git a/docs/fonts/LICENSE.md b/docs/fonts/LICENSE.rst similarity index 94% rename from docs/fonts/LICENSE.md rename to docs/fonts/LICENSE.rst index 9520f30f73..4e32b1a1d3 100644 --- a/docs/fonts/LICENSE.md +++ b/docs/fonts/LICENSE.rst @@ -1,18 +1,24 @@ -## License +======= +License +======= Copyright (C) 2015 Red Hat, Inc., This Font Software is licensed under the SIL Open Font License, Version 1.1. This license is copied below, and is also available with a FAQ at: + http://scripts.sil.org/OFL -#### SIL OPEN FONT LICENSE +===================== +SIL OPEN FONT LICENSE +===================== + Version 1.1 - 26 February 2007 ---- +PREAMBLE +======== -#### PREAMBLE The goals of the Open Font License (OFL) are to stimulate worldwide development of collaborative font projects, to support the font creation efforts of academic and linguistic communities, and to provide a free and open framework @@ -27,7 +33,9 @@ any other type of license. The requirement for fonts to remain under this license does not apply to any document created using the fonts or their derivatives. -#### DEFINITIONS +DEFINITIONS +=========== + “Font Software” refers to the set of files released by the Copyright Holder(s) under this license and clearly marked as such. This may include source files, build scripts and documentation. @@ -45,7 +53,9 @@ by changing formats or by porting the Font Software to a new environment. “Author” refers to any designer, engineer, programmer, technical writer or other person who contributed to the Font Software. -#### PERMISSION & CONDITIONS +PERMISSION & CONDITIONS +======================= + Permission is hereby granted, free of charge, to any person obtaining a copy of the Font Software, to use, study, copy, merge, embed, modify, redistribute, and sell modified and unmodified copies of the Font Software, subject to the @@ -76,10 +86,14 @@ distributed entirely under this license, and must not be distributed under any other license. The requirement for fonts to remain under this license does not apply to any document created using the Font Software. -#### TERMINATION +TERMINATION +=========== + This license becomes null and void if any of the above conditions are not met. -#### DISCLAIMER +DISCLAIMER +========== + THE FONT SOFTWARE IS PROVIDED “AS IS”, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO ANY WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT OF COPYRIGHT, PATENT, diff --git a/libvirt.spec.in b/libvirt.spec.in index 6061a26497..6abf97df85 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1505,7 +1505,7 @@ exit 0 %files %files docs -%doc AUTHORS ChangeLog NEWS README README.md +%doc AUTHORS ChangeLog NEWS README README.rst %doc %{_vpath_builddir}/libvirt-docs/* %files daemon diff --git a/po/README.md b/po/README.rst similarity index 86% rename from po/README.md rename to po/README.rst index 2f77c5d48c..2e234547ca 100644 --- a/po/README.md +++ b/po/README.rst @@ -1,3 +1,4 @@ +=========================== Libvirt Message Translation =========================== @@ -7,6 +8,7 @@ file formats, in combination with the Zanata web service. python-zanata-client is required in order to use make to pull/push translations from/to Zanata server. + Source repository ================= @@ -14,21 +16,25 @@ The libvirt GIT repository does NOT store the master "libvirt.pot" file, nor does it store full "po" files for translations. The master "libvirt.pot" file can be generated at any time using - make libvirt.pot +:: + + $ make libvirt.pot The translations are kept in minimized files that are the same file format as normal po files but with all redundant information stripped and messages re-ordered. The key differences between the ".mini.po" files in GIT and the full ".po" files are - - msgids with no current translation are omitted - - msgids are sorted in alphabetical order not source file order - - msgids with a msgstr marked "fuzzy" are discarded - - source file locations are omitted +* msgids with no current translation are omitted +* msgids are sorted in alphabetical order not source file order +* msgids with a msgstr marked "fuzzy" are discarded +* source file locations are omitted The full po files can be created at any time using - make update-po +:: + + $ make update-po This merges the "libvirt.pot" with the "$LANG.mini.po" for each language, to create the "$LANG.po" files. These are included in the release archives created @@ -37,7 +43,9 @@ by "make dist". When a full po file is updated, changes can be propagated back into the minimized po files using - make update-mini-po +:: + + $ make update-mini-po Note, however, that this is generally not something that should be run by developers normally, as it is triggered by 'make pull-po' when refreshing @@ -50,7 +58,7 @@ Zanata web service The translation of libvirt messages has been outsourced to the Fedora translation team using the Zanata web service: - https://fedora.zanata.org/project/view/libvirt +https://fedora.zanata.org/project/view/libvirt As such, changes to translations will generally NOT be accepted as patches directly to libvirt GIT. Any changes made to "$LANG.mini.po" files in libvirt @@ -59,12 +67,16 @@ GIT will be overwritten and lost the next time content is imported from Zanata. The master "libvirt.pot" file is periodically pushed to Zanata to provide the translation team with content changes, using - make push-pot +:: + + $ make push-pot New translated text is then periodically pulled down from Zanata to update the minimized po files, using - make pull-po +:: + + $ make pull-po Sometimes the translators make mistakes, most commonly with handling printf format specifiers. The "pull-po" command re-generates the .gmo files to try to diff --git a/tools/wireshark/README.md b/tools/wireshark/README.rst similarity index 52% rename from tools/wireshark/README.md rename to tools/wireshark/README.rst index b7f40d0954..919b89d32a 100644 --- a/tools/wireshark/README.md +++ b/tools/wireshark/README.rst @@ -1,5 +1,7 @@ +===== About ===== + This is the project of Google Summer of Code 2013 accepted by QEMU.org and libvirt community. The goal of this project is, provide Wireshark dissector for Libvirt RPC protocol. It will provide Libvirt packet overview/detail analysing @@ -8,24 +10,32 @@ definition placed in Libvirt source tree to support latest protocol specification. See also: -- http://www.google-melange.com/gsoc/project/google/gsoc2013/kawamuray/7001 -- https://wiki.qemu.org/Features/LibvirtWiresharkDissector + +* http://www.google-melange.com/gsoc/project/google/gsoc2013/kawamuray/7001 +* https://wiki.qemu.org/Features/LibvirtWiresharkDissector + Installation ============= -Run ./configure with --with-wireshark-dissector option enabled. + +Run ``./configure`` with ``--with-wireshark-dissector`` option enabled. Then dissector will compiled with libvirt itself. Add/Remove protocol from dissector's support -------------------------------------------- -Modify variable WS\_DISSECTOR\_PROTO\_FILES in tools/wireshark/src/Makefile.am. + +Modify variable ``WS_DISSECTOR_PROTO_FILES`` +in ``tools/wireshark/src/Makefile.am``. Changing installation directory ------------------------------- -You can change installation directory of pluggable shared object(libvirt.so) by -specifying --with-ws-plugindir=<path>. -You can install libvirt.so into your local wireshark plugin directory: +You can change installation directory of pluggable shared +object(``libvirt.so``) by specifying ``--with-ws-plugindir=<path>``. + +You can install ``libvirt.so`` into your local wireshark plugin directory: + +:: - ./configure --with-wireshark-dissector \ - --with-ws-plugindir=$HOME/.wireshark/plugins + $ ./configure --with-wireshark-dissector \ + --with-ws-plugindir=$HOME/.wireshark/plugins -- 2.25.2

2 4

[PATCH 0/2] Fix formatting of http cookies into XML
by Peter Krempa 14 Apr '20

14 Apr '20

See 2/2. Peter Krempa (2): virstoragetest: testBackingParse: Use VIR_DOMAIN_DEF_FORMAT_SECURE when formatting xml conf: Don't format http cookies unless VIR_DOMAIN_DEF_FORMAT_SECURE is used src/conf/domain_conf.c | 8 ++++++-- tests/virstoragetest.c | 3 ++- 2 files changed, 8 insertions(+), 3 deletions(-) -- 2.26.0

2 4

libvirt python console
by PunkGeek 14 Apr '20

14 Apr '20

Hello, I see this example about VM console serial, Which I could connect to the guest VM successfully. however, I could not understand how to send commands to the guest VM? https://github.com/libvirt/libvirt-python/blob/master/examples/consolecallb… Best regards

2 1

[PATCH] libvirt-stream.c: Use g_autofree
by Seeteena Thoufeek 14 Apr '20

14 Apr '20

Signed-off-by: Seeteena Thoufeek <s1seetee(a)linux.vnet.ibm.com> --- src/libvirt-stream.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/src/libvirt-stream.c b/src/libvirt-stream.c index 6f6bb5d..41b9cc1 100644 --- a/src/libvirt-stream.c +++ b/src/libvirt-stream.c @@ -573,7 +573,7 @@ virStreamSendAll(virStreamPtr stream, virStreamSourceFunc handler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; int ret = -1; VIR_DEBUG("stream=%p, handler=%p, opaque=%p", stream, handler, opaque); @@ -616,8 +616,6 @@ virStreamSendAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; @@ -706,7 +704,7 @@ int virStreamSparseSendAll(virStreamPtr stream, virStreamSourceSkipFunc skipHandler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t bufLen = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; int ret = -1; unsigned long long dataLen = 0; @@ -787,8 +785,6 @@ int virStreamSparseSendAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; @@ -847,7 +843,7 @@ virStreamRecvAll(virStreamPtr stream, virStreamSinkFunc handler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; int ret = -1; VIR_DEBUG("stream=%p, handler=%p, opaque=%p", stream, handler, opaque); @@ -892,8 +888,6 @@ virStreamRecvAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; @@ -964,7 +958,7 @@ virStreamSparseRecvAll(virStreamPtr stream, virStreamSinkHoleFunc holeHandler, void *opaque) { - char *bytes = NULL; + g_autofree char *bytes = NULL; size_t want = VIR_NET_MESSAGE_LEGACY_PAYLOAD_MAX; const unsigned int flags = VIR_STREAM_RECV_STOP_AT_HOLE; int ret = -1; @@ -1025,8 +1019,6 @@ virStreamSparseRecvAll(virStreamPtr stream, ret = 0; cleanup: - VIR_FREE(bytes); - if (ret != 0) { virErrorPtr orig_err; -- 1.8.3.1

2 1