- Devel - libvirt List Archives

[PATCH] numa_conf: Properly check for caches in virDomainNumaDefValidate()
by Michal Privoznik 18 Aug '20

18 Aug '20

When adding support for HMAT, in f0611fe8830 I've introduced a check which aims to validate /domain/cpu/numa/interconnects. As a part of that, there is a loop which checks whether all <latency/> with @cache attribute refer to an existing cache level. For instance: <cpu mode='host-model' check='partial'> <numa> <cell id='0' cpus='0-5' memory='512000' unit='KiB' discard='yes'> <cache level='1' associativity='direct' policy='writeback'> <size value='8' unit='KiB'/> <line value='5' unit='B'/> </cache> </cell> <interconnects> <latency initiator='0' target='0' cache='1' type='access' value='5'/> <bandwidth initiator='0' target='0' type='access' value='204800' unit='KiB'/> </interconnects> </numa> </cpu> This XML defines that accessing L1 cache of node #0 from node #0 has latency of 5ns. However, the loop was not written properly. Well, the check in it, as it was always checking for the first cache in the target node and not the rest. Therefore, the following example errors out: <cpu mode='host-model' check='partial'> <numa> <cell id='0' cpus='0-5' memory='512000' unit='KiB' discard='yes'> <cache level='3' associativity='direct' policy='writeback'> <size value='10' unit='KiB'/> <line value='8' unit='B'/> </cache> <cache level='1' associativity='direct' policy='writeback'> <size value='8' unit='KiB'/> <line value='5' unit='B'/> </cache> </cell> <interconnects> <latency initiator='0' target='0' cache='1' type='access' value='5'/> <bandwidth initiator='0' target='0' type='access' value='204800' unit='KiB'/> </interconnects> </numa> </cpu> This errors out even though it is a valid configuration. The L1 cache under node #0 is still present. Fixes: f0611fe8830 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Is this trivial enough to be pushed as such? ;-) src/conf/numa_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 50d57ba8f6..9305e125b7 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -1421,7 +1421,7 @@ virDomainNumaDefValidate(const virDomainNuma *def) if (l->cache > 0) { for (j = 0; j < def->mem_nodes[l->target].ncaches; j++) { - const virDomainNumaCache *cache = def->mem_nodes[l->target].caches; + const virDomainNumaCache *cache = &def->mem_nodes[l->target].caches[j]; if (l->cache == cache->level) break; -- 2.26.2

2 1

[libvirt PATCH 0/2] meson augeas test fixes
by Pavel Hrdina 18 Aug '20

18 Aug '20

Pavel Hrdina (2): src/meson: introduce srcdir and builddir into augeas_test_data dictionary meson/src: add missing augeas tests src/bhyve/meson.build | 3 +++ src/libxl/meson.build | 3 +++ src/locking/meson.build | 9 +++++++ src/logging/meson.build | 3 +++ src/lxc/meson.build | 3 +++ src/meson.build | 52 +++++++++++++++++++++++++++-------------- src/qemu/meson.build | 3 +++ 7 files changed, 58 insertions(+), 18 deletions(-) -- 2.26.2

2 4

[libvirt PATCH 00/16] Add support for persistent mediated devices
by Jonathon Jongsma 18 Aug '20

18 Aug '20

This patch series follows the previously-merged series which added support for transient mediated devices. This series expands mdev support to include persistent device definitions. Again, it relies on mdevctl as the backend. It follows the common libvirt pattern of APIs by adding the following new APIs for node devices: - virNodeDeviceDefineXML() - defines a persistent device - virNodeDeviceUndefine() - undefines a persistent device - virNodeDeviceCreate() - starts a previously-defined device It also adds virsh commands mapping to these new APIs: nodedev-define, nodedev-undefine, and nodedev-start. The method of staying up-to-date with devices defined by mdevctl is currently a little bit crude due to the fact that mdevctl does not emit any events when new devices are added or removed. As a workaround, we create a file monitor for the mdevctl config directory and re-query mdevctl when we detect changes within that directory. In the future, mdevctl may introduce a more elegant solution. Jonathon Jongsma (16): tests: remove extra trailing semicolon nodedev: introduce concept of 'active' node devices nodedev: Add ability to filter by active state virsh: Add --active, --inactive, --all to nodedev-list nodedev: add ability to list and parse defined mdevs nodedev: add STOPPED/STARTED lifecycle events nodedev: add mdevctl devices to node device list nodedev: handle mdevs that disappear from mdevctl nodedev: add an mdevctl thread api: add virNodeDeviceDefineXML() virsh: add nodedev-define command api: add virNodeDeviceUndefine() virsh: Factor out function to find node device virsh: add nodedev-undefine command api: add virNodeDeviceCreate() virsh: add "nodedev-start" command examples/c/misc/event-test.c | 4 + include/libvirt/libvirt-nodedev.h | 19 +- src/conf/node_device_conf.h | 9 + src/conf/virnodedeviceobj.c | 24 + src/conf/virnodedeviceobj.h | 7 + src/driver-nodedev.h | 14 + src/libvirt-nodedev.c | 115 ++++ src/libvirt_private.syms | 2 + src/libvirt_public.syms | 6 + src/node_device/node_device_driver.c | 522 +++++++++++++++++- src/node_device/node_device_driver.h | 38 ++ src/node_device/node_device_udev.c | 275 ++++++++- src/remote/remote_driver.c | 3 + src/remote/remote_protocol.x | 40 +- src/remote_protocol-structs | 16 + src/rpc/gendispatch.pl | 1 + ...19_36ea_4111_8f0a_8c9a70e21366-define.argv | 1 + ...19_36ea_4111_8f0a_8c9a70e21366-define.json | 1 + ...39_495e_4243_ad9f_beb3f14c23d9-define.argv | 1 + ...39_495e_4243_ad9f_beb3f14c23d9-define.json | 1 + ...16_1ca8_49ac_b176_871d16c13076-define.argv | 1 + ...16_1ca8_49ac_b176_871d16c13076-define.json | 1 + tests/nodedevmdevctldata/mdevctl-create.argv | 1 + .../mdevctl-list-defined.argv | 1 + .../mdevctl-list-multiple-parents.json | 59 ++ .../mdevctl-list-multiple-parents.out.xml | 39 ++ .../mdevctl-list-multiple.json | 59 ++ .../mdevctl-list-multiple.out.xml | 39 ++ .../mdevctl-list-single-noattr.json | 11 + .../mdevctl-list-single-noattr.out.xml | 8 + .../mdevctl-list-single.json | 31 ++ .../mdevctl-list-single.out.xml | 14 + .../nodedevmdevctldata/mdevctl-undefine.argv | 1 + tests/nodedevmdevctltest.c | 226 +++++++- tools/virsh-nodedev.c | 281 ++++++++-- 35 files changed, 1783 insertions(+), 88 deletions(-) create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-define.argv create mode 100644 tests/nodedevmdevctldata/mdev_d069d019_36ea_4111_8f0a_8c9a70e21366-define.json create mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-define.argv create mode 100644 tests/nodedevmdevctldata/mdev_d2441d39_495e_4243_ad9f_beb3f14c23d9-define.json create mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871d16c13076-define.argv create mode 100644 tests/nodedevmdevctldata/mdev_fedc4916_1ca8_49ac_b176_871d16c13076-define.json create mode 100644 tests/nodedevmdevctldata/mdevctl-create.argv create mode 100644 tests/nodedevmdevctldata/mdevctl-list-defined.argv create mode 100644 tests/nodedevmdevctldata/mdevctl-list-multiple-parents.json create mode 100644 tests/nodedevmdevctldata/mdevctl-list-multiple-parents.out.xml create mode 100644 tests/nodedevmdevctldata/mdevctl-list-multiple.json create mode 100644 tests/nodedevmdevctldata/mdevctl-list-multiple.out.xml create mode 100644 tests/nodedevmdevctldata/mdevctl-list-single-noattr.json create mode 100644 tests/nodedevmdevctldata/mdevctl-list-single-noattr.out.xml create mode 100644 tests/nodedevmdevctldata/mdevctl-list-single.json create mode 100644 tests/nodedevmdevctldata/mdevctl-list-single.out.xml create mode 100644 tests/nodedevmdevctldata/mdevctl-undefine.argv -- 2.21.3

3 20

[PATCH] doCoreDump: fix return value not expect as result
by Hao Wang 18 Aug '20

18 Aug '20

From: Hao Wang <wanghao232(a)huawei.com> Subject: [PATCH] doCoreDump: fix return value not expect as result In a case that qemuDumpToFd() return zero while VIR_CLOSE(fd) fails, codes will go to "cleanup" with "ret=0", resulting in unexpected return value. Fix that. Signed-off-by: Hao Wang <wanghao232(a)huawei.com> --- src/qemu/qemu_driver.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 0f98243fe4..8dfb9a38bf 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3796,6 +3796,7 @@ doCoreDump(virQEMUDriverPtr driver, { int fd = -1; int ret = -1; + int rc = -1; virFileWrapperFdPtr wrapperFd = NULL; int directFlag = 0; unsigned int flags = VIR_FILE_WRAPPER_NON_BLOCKING; @@ -3843,8 +3844,8 @@ doCoreDump(virQEMUDriverPtr driver, if (STREQ(memory_dump_format, "elf")) memory_dump_format = NULL; - ret = qemuDumpToFd(driver, vm, fd, QEMU_ASYNC_JOB_DUMP, - memory_dump_format); + rc = qemuDumpToFd(driver, vm, fd, QEMU_ASYNC_JOB_DUMP, + memory_dump_format); } else { if (dumpformat != VIR_DOMAIN_CORE_DUMP_FORMAT_RAW) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", @@ -3856,11 +3857,11 @@ doCoreDump(virQEMUDriverPtr driver, if (!qemuMigrationSrcIsAllowed(driver, vm, false, 0)) goto cleanup; - ret = qemuMigrationSrcToFile(driver, vm, fd, compressor, - QEMU_ASYNC_JOB_DUMP); + rc = qemuMigrationSrcToFile(driver, vm, fd, compressor, + QEMU_ASYNC_JOB_DUMP); } - if (ret < 0) + if (rc < 0) goto cleanup; if (VIR_CLOSE(fd) < 0) { -- 2.23.0

2 1

[PATCH] NEWS: Document recent virdevmapper fix
by Michal Privoznik 18 Aug '20

18 Aug '20

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 63ca689b43..b80e72f8c6 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -17,6 +17,13 @@ v6.7.0 (unreleased) * **Bug fixes** + * virdevmapper: Deal with kernels without DM support + + In the previous release libvirt dropped libdevmapper in favor of its own + implementation. However, it forgot to deal with kernels that either don't + have device mapper enabled or the dm-mod module is not loaded yet. This is + now fixed. + v6.6.0 (2020-08-02) =================== -- 2.26.2

2 1

[PATCH 0/3] Avoid some GCC 10 warnings
by Boris Fiuczynski 18 Aug '20

18 Aug '20

Caught these when switching to F32 using GCC v10.2.1 on s390x. Boris Fiuczynski (3): qemu: avoid maybe-uninitialized warning by GCC 10 tools: avoid potential null pointer dereference by GCC 10 storage: avoid maybe-uninitialized warning by GCC 10 src/qemu/qemu_migration.c | 2 +- src/storage/storage_backend_iscsi_direct.c | 8 ++++---- tools/vsh.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.25.1

3 5

[PATCH 0/2] virdevmapper: Deal with kernels without DM support
by Michal Privoznik 18 Aug '20

18 Aug '20

*** BLURB HERE *** Michal Prívozník (2): virdevmapper: Don't error on kernels without DM support virdevmapper: Deal with unloading dm module src/util/virdevmapper.c | 59 ++++++++++++++++++++++++++++++++--------- 1 file changed, 47 insertions(+), 12 deletions(-) -- 2.26.2

5 14

[PATCH] docs: build: Fix links to 'edit this page' for kbase/manpages/internals
by Peter Krempa 18 Aug '20

18 Aug '20

Commit 862cf2ace4f04dadc175caacc74448e96c625ccb modified the generator to base edit links in the root of the repository but forgot to add the 'docs/' prefix to the code generating kbase articles, manpages and the internals documentation. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/internals/meson.build | 2 +- docs/kbase/meson.build | 2 +- docs/manpages/meson.build | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/internals/meson.build b/docs/internals/meson.build index 169cc5d5f0..5d008dec5b 100644 --- a/docs/internals/meson.build +++ b/docs/internals/meson.build @@ -24,7 +24,7 @@ foreach name : internals_in_files subsite_xsl, '@INPUT@', '@OUTPUT@', - 'internals' / html_in_file, + 'docs/internals' / html_in_file, ], depends: [ aclperms_gen ], depend_files: [ page_xsl ], diff --git a/docs/kbase/meson.build b/docs/kbase/meson.build index d7f254e163..e836a8a022 100644 --- a/docs/kbase/meson.build +++ b/docs/kbase/meson.build @@ -37,7 +37,7 @@ foreach name : docs_kbase_files subsite_xsl, '@INPUT@', '@OUTPUT@', - 'kbase' / rst_file, + 'docs/kbase' / rst_file, ], depends: [ aclperms_gen ], depend_files: [ page_xsl ], diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index 8295e9e5ea..3888bb8efe 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -118,7 +118,7 @@ foreach data : docs_man_files subsite_xsl, '@INPUT@', '@OUTPUT@', - 'manpages' / rst_in_file, + 'docs/manpages' / rst_in_file, ], depends: [ aclperms_gen ], depend_files: [ page_xsl ], -- 2.25.4

2 1

[libvirt PATCH] docs: improve auth service listing
by Pino Toscano 17 Aug '20

17 Aug '20

Slightly improve the list of known authentication service types: - reword 'ssh' to mention it is used for the ssh driver (for remote QEMU), and stop mentioning the removed Phyp driver - add 'hyperv', used by the HyperV driver - alphabetically sort the list - use a bulletted list instead of a numbered one Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- docs/auth.html.in | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/docs/auth.html.in b/docs/auth.html.in index 6f8805b6f5..9964313776 100644 --- a/docs/auth.html.in +++ b/docs/auth.html.in @@ -122,17 +122,19 @@ credentials=defgrp</pre> <p> - The following service types are known to libvirt + The following service types are known to libvirt: </p> - <ol> - <li><code>libvirt</code> - used for connections to a libvirtd - server, which is configured with SASL auth</li> - <li><code>ssh</code> - used for connections to a Phyp server - over SSH, but the Phyp driver has been removed</li> + <ul> <li><code>esx</code> - used for connections to an ESX or VirtualCenter server</li> - </ol> + <li><code>hyperv</code> - used for connections to an HyperV + server</li> + <li><code>libvirt</code> - used for connections to a libvirtd + server, which is configured with SASL auth</li> + <li><code>ssh</code> - used for connections to a remote QEMU driver + over SSH</li> + </ul> <p> Applications using libvirt are free to use this same configuration -- 2.26.2

2 1

[libvirt PATCH] build-aux: Get rid of 'make syntax-check' reference
by Erik Skultety 17 Aug '20

17 Aug '20

Change the 'make syntax-check' reference after the switch to meson/ninja. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- This is a follow-up to https://www.redhat.com/archives/libvir-list/2020-August/msg00328.html. Pushed as trivial. build-aux/syntax-check.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 6eb59cf90e..16c70750e8 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -675,7 +675,7 @@ msg_gen_function += virReportErrorHelper msg_gen_function += virReportSystemError msg_gen_function += virLastErrorPrefixMessage -# Uncomment the following and run "make syntax-check" to see diagnostics +# Uncomment the following and run "ninja test" to see diagnostics # that are not yet marked for translation, but that need to be rewritten # so that they are translatable. # msg_gen_function += fprintf -- 2.26.2

1 0

[PATCH 0/4] remove 'make check' references from code
by Daniel Henrique Barboza 17 Aug '20

17 Aug '20

Simple series that removes the references of the now former 'make check', replacing it to 'ninja test'. Daniel Henrique Barboza (4): docs: get rid of 'make check' references ci/Makefile: get rid of 'make check' references tests: get rid of 'make check' references vbox_XPCOMCGlue.c: get rid of 'make check' reference ci/Makefile | 6 +++--- docs/advanced-tests.rst | 2 +- docs/api_extension.html.in | 9 ++++----- docs/testsuites.html.in | 3 ++- src/vbox/vbox_XPCOMCGlue.c | 2 +- tests/domaincapstest.c | 2 +- tests/qemucapabilitiestest.c | 2 +- tests/test-lib.sh | 2 +- 8 files changed, 14 insertions(+), 14 deletions(-) -- 2.26.2

2 5

[PATCH V3 0/3] Xen: Support PCI permissive setting with writeFiltering attribute
by Jim Fehlig 14 Aug '20

14 Aug '20

This is V3 of Marek's series to support the xl.cfg(5) permissive setting on PCI devices. V2 can be found here https://www.redhat.com/archives/libvir-list/2020-April/msg01230.html Changes from V2: Instead of using a permisssive attribute on the <hostdev> element, use a writeFiltering attribute on the <hostdev>'s <source> element. Rational being that the filtering of writes to the PCI config space is done at the source. Jim Fehlig (3): Xen: Add writeFiltering option for PCI devices Xen: Add support for writeFiltering in config converter News: Advertise support for writeFiltering attribute of PCI hostdevs NEWS.rst | 7 +++ docs/formatdomain.rst | 7 ++- docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 14 +++++ src/conf/domain_conf.h | 1 + src/libxl/libxl_conf.c | 1 + src/libxl/xen_common.c | 52 ++++++++++++++++-- .../libxlxml2domconfigdata/moredevs-hvm.json | 6 +++ tests/libxlxml2domconfigdata/moredevs-hvm.xml | 5 ++ tests/xlconfigdata/test-fullvirt-pci.cfg | 25 +++++++++ tests/xlconfigdata/test-fullvirt-pci.xml | 53 +++++++++++++++++++ tests/xlconfigtest.c | 1 + 12 files changed, 171 insertions(+), 6 deletions(-) create mode 100644 tests/xlconfigdata/test-fullvirt-pci.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-pci.xml -- 2.28.0

1 3

[PATCH 0/3] batch: don't require checking retvalue of some bitmap ops
by Nikolay Shirokovskiy 13 Aug '20

13 Aug '20

Most of bitmap setBit/clearBit/getBit users know that the bitmap index is not out of bound and thus don't check the return value. More precisely the stats is next: Method all check =================================== virBitmapSetBit 85 14 virBitmapClearBit 15 3 virBitmapGetBit 15 6 where 'all' is the number of all occurences of the method and 'check' is the number of occurences with 'if (method' pattern. Thus keeping the retvalue checking requirement produces more noise then helps. I guess we even can make these function return void as users can simply compare the index with the bitmap size. The removing of ignore_value was done by sed together with several manual editings where methods calls were splitted across two lines. FILES=`git grep -l 'ignore_value(virBitmapGetBit('` sed -ibak -re 's/ignore_value$virBitmapGetBit\((.*)$\);/virBitmapGetBit(\1\);/' "$FILES" Nikolay Shirokovskiy (3): batch: don't require checking retvalue for virBitmapSetBit batch: don't require checking retvalue for virBitmapClearBit batch: don't require checking retvalue for virBitmapGetBit src/conf/capabilities.c | 2 +- src/conf/checkpoint_conf.c | 2 +- src/conf/domain_addr.c | 8 ++++---- src/conf/domain_conf.c | 9 ++++----- src/conf/node_device_conf.c | 2 +- src/conf/snapshot_conf.c | 2 +- src/conf/storage_conf.c | 2 +- src/libxl/libxl_capabilities.c | 2 +- src/network/bridge_driver.c | 6 +++--- src/qemu/qemu_capabilities.c | 4 ++-- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain_address.c | 4 ++-- src/qemu/qemu_driver.c | 8 ++++---- src/qemu/qemu_hotplug.c | 6 +++--- src/qemu/qemu_migration_cookie.c | 8 ++++---- src/qemu/qemu_migration_params.c | 28 +++++++++++++--------------- src/qemu/qemu_monitor.c | 2 +- src/qemu/qemu_slirp.c | 2 +- src/test/test_driver.c | 2 +- src/util/virbitmap.h | 6 +++--- src/util/vircommand.c | 2 +- src/util/virdnsmasq.c | 2 +- src/util/virhostcpu.c | 2 +- src/util/virjson.c | 2 +- src/util/virnetdev.c | 10 +++++----- src/util/virnuma.c | 4 ++-- src/util/virprocess.c | 4 ++-- src/util/virresctrl.c | 2 +- src/util/virstoragefile.c | 2 +- src/vmx/vmx.c | 2 +- tests/qemumonitorjsontest.c | 2 +- tests/testutils.c | 2 +- tests/virbitmaptest.c | 28 ++++++++++++++-------------- tools/virsh-domain.c | 4 ++-- tools/virt-host-validate-common.c | 2 +- 35 files changed, 87 insertions(+), 90 deletions(-) -- 1.8.3.1

2 7

[PATCH 1/2] apparmor: allow adding permanent per guest rules
by Christian Ehrhardt 13 Aug '20

13 Aug '20

The design of apparmor in libvirt always had a way to define custom per-guest rules as described in docs/drvqemu.html and [1]. A fix meant to clean the profiles after guest shutdown was a bit overzealous and accidentially removed this important admin feature as well. Therefore reduce the --delete option of virt-aa-helper to only delete the .files that would be re-generated in any case. Users/Admins are always free to clean the profiles themselve if they prefer a clean directory - they will be regenerated as needed. But libvirt should never remove the base profile meant to allow per-guest overrides and thereby break a documented feature. [1]: https://gitlab.com/apparmor/apparmor/-/wikis/Libvirt#advanced-usage Fixes: eba2225b "apparmor: delete profile on VM shutdown" Signed-off-by: Christian Ehrhardt <christian.ehrhardt(a)canonical.com> --- src/security/virt-aa-helper.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index dadb9d1614..4b66422b8f 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -99,7 +99,7 @@ vah_usage(void) " Modes:\n" " -a | --add load profile\n" " -c | --create create profile from template\n" - " -D | --delete unload and delete profile\n" + " -D | --delete unload profile and delete generated rules\n" " -r | --replace reload profile\n" " -R | --remove unload profile\n" " Options:\n" @@ -1491,7 +1491,6 @@ main(int argc, char **argv) rc = parserRemove(ctl->uuid); if (ctl->cmd == 'D') { unlink(include_file); - unlink(profile); } } else if (ctl->cmd == 'c' || ctl->cmd == 'r') { char *included_files = NULL; -- 2.27.0

2 5

Plans for the next release
by Jiri Denemark 13 Aug '20

13 Aug '20

I'm sending this quite early this month as I'm on vacation tomorrow and next week and I wanted to make sure the plan for the release is advertised earlier than just a day or two before the freeze. To aim for the release on Sep 01 I suggest entering the freeze in two weeks on Wednesday Aug 26 and tagging RC2 on Friday Aug 28 in the afternoon. I hope this works for everyone. Jirka

1 0

[libvirt PATCH] qemu: fix crash in qemuDomainSetBlkioParameters without cgroups
by Pavel Hrdina 12 Aug '20

12 Aug '20

If we don't have cgroups available and user tries to update blkio parameters for running VM it will crash. It should have been protected by the virCgroupHasController() check but it was never called if the API was executed without any flags. We call virDomainObjGetDefs() which sets `def` and `persistentDef` based on the flags and these two variables should be used to figure out if we need to update LIVE, CONFIG or both states. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1808293 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 07e9518a9b..8008da6d16 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9356,7 +9356,7 @@ qemuDomainSetBlkioParameters(virDomainPtr dom, if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0) goto endjob; - if (flags & VIR_DOMAIN_AFFECT_LIVE) { + if (def) { if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_BLKIO)) { virReportError(VIR_ERR_OPERATION_INVALID, "%s", _("blkio cgroup isn't mounted")); -- 2.26.2

2 1

[libvirt PATCH] docs: formatdomain: fix superscripts
by Ján Tomko 12 Aug '20

12 Aug '20

There needs to be a space before the :sup: directive. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. docs/formatdomain.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 218f0c1718..8365fc8bbb 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -896,12 +896,12 @@ Memory Allocation hotplugged later. The units for this value are determined by the optional attribute ``unit``, which defaults to "KiB" (kibibytes, 2\ :sup:`10` or blocks of 1024 bytes). Valid units are "b" or "bytes" for bytes, "KB" for - kilobytes (10:sup:`3` or 1,000 bytes), "k" or "KiB" for kibibytes (1024 - bytes), "MB" for megabytes (10:sup:`6` or 1,000,000 bytes), "M" or "MiB" for - mebibytes (2:sup:`20` or 1,048,576 bytes), "GB" for gigabytes (10:sup:`9` or - 1,000,000,000 bytes), "G" or "GiB" for gibibytes (2:sup:`30` or 1,073,741,824 - bytes), "TB" for terabytes (10:sup:`12` or 1,000,000,000,000 bytes), or "T" - or "TiB" for tebibytes (2:sup:`40` or 1,099,511,627,776 bytes). However, the + kilobytes (10\ :sup:`3` or 1,000 bytes), "k" or "KiB" for kibibytes (1024 + bytes), "MB" for megabytes (10\ :sup:`6` or 1,000,000 bytes), "M" or "MiB" for + mebibytes (2\ :sup:`20` or 1,048,576 bytes), "GB" for gigabytes (10\ :sup:`9` or + 1,000,000,000 bytes), "G" or "GiB" for gibibytes (2\ :sup:`30` or 1,073,741,824 + bytes), "TB" for terabytes (10\ :sup:`12` or 1,000,000,000,000 bytes), or "T" + or "TiB" for tebibytes (2\ :sup:`40` or 1,099,511,627,776 bytes). However, the value will be rounded up to the nearest kibibyte by libvirt, and may be further rounded to the granularity supported by the hypervisor. Some hypervisors also enforce a minimum, such as 4000KiB. In case -- 2.26.2

1 0

[libvirt PATCH v2] kbase: sev: Provide more details on virtio-net configuration
by Erik Skultety 11 Aug '20

11 Aug '20

With virtio-net we also need to disable the iPXE option ROM otherwise a SEV-enabled guest would not boot. While at it, fix the full machine XML examples accordingly. Reported-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com> Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- since v1: - ditched any mentions of vhost, since we can assume all the supported distros to have the latest QEMU-2.12 build containing the bugfix to make vhost work with SEV docs/kbase/launch_security_sev.rst | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst index cfdc2a6120..4a37c0c379 100644 --- a/docs/kbase/launch_security_sev.rst +++ b/docs/kbase/launch_security_sev.rst @@ -291,8 +291,9 @@ can still perform DoS on each other. Virtio ------ -In order to make virtio devices work, we need to enable emulated IOMMU -on the devices so that virtual DMA can work. +In order to make virtio devices work, we need to use +``<driver iommu='on'/>`` inside the given device XML element in order +to enable DMA API in the virtio driver. :: @@ -337,6 +338,26 @@ model, which means that virtio GPU cannot be used. ... </domain> +Virtio-net +~~~~~~~~~~ +With virtio-net it's also necessary to disable the iPXE option ROM as +iPXE is not aware of SEV (at the time of this writing). This translates to the +following XML: + +:: + + <domain> + ... + <interface type='network'> + ... + <model type='virtio'/> + <driver iommu='on'/> + <rom enabled='no'/> + </interface> + ... + <domain> + + Checking SEV from within the guest ================================== @@ -424,6 +445,7 @@ Q35 machine <source network='default'/> <model type='virtio'/> <driver iommu='on'/> + <rom enabled='no'/> </interface> <graphics type='spice' autoport='yes'> <listen type='address'/> @@ -496,6 +518,8 @@ PC-i440fx machine <mac address='52:54:00:d8:96:c8'/> <source network='default'/> <model type='virtio-non-transitional'/> + <driver iommu='on'/> + <rom enabled='no'/> </interface> <serial type='pty'> <target type='isa-serial' port='0'> -- 2.26.2

2 1

[libvirt PATCH] vircgroupv2devices: fix counting entries in BPF map
by Pavel Hrdina 11 Aug '20

11 Aug '20

BPF syscall BPF_MAP_GET_NEXT_KEY returns -1 if something fails but it will also return -1 if trying to get next key using the last key in the map with errno set to ENOENT. If there are VMs running and libvirtd is restarted and user tries to call some cgroup devices operation on a VM we need to get the count of entries in BPF map and it fails which will result in error when trying to attach/detech devices. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1833321 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/vircgroupv2devices.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/vircgroupv2devices.c b/src/util/vircgroupv2devices.c index d62ee12a05..234e0f2278 100644 --- a/src/util/vircgroupv2devices.c +++ b/src/util/vircgroupv2devices.c @@ -342,7 +342,7 @@ virCgroupV2DevicesCountMapEntries(int mapfd) prevKey = key; } - if (rc < 0) + if (rc < 0 && errno != ENOENT) return -1; return ret; -- 2.26.2

2 1

[libvirt PATCH] kbase: sev: Provide more details on virtio-net configuration
by Erik Skultety 11 Aug '20

11 Aug '20

With virtio-net further configuration settings are required, so document them and while at it, fix the Q35 machine XML example which wouldn't work with SEV because of not disabling vhost and the option boot ROM. Reported-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com> Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- docs/kbase/launch_security_sev.rst | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/docs/kbase/launch_security_sev.rst b/docs/kbase/launch_security_sev.rst index cfdc2a6120..9df4178aac 100644 --- a/docs/kbase/launch_security_sev.rst +++ b/docs/kbase/launch_security_sev.rst @@ -291,8 +291,9 @@ can still perform DoS on each other. Virtio ------ -In order to make virtio devices work, we need to enable emulated IOMMU -on the devices so that virtual DMA can work. +In order to make virtio devices work, we need to use +``<driver iommu='on'/>`` inside the given device XML element in order +to enable DMA API in the virtio driver. :: @@ -337,6 +338,26 @@ model, which means that virtio GPU cannot be used. ... </domain> +Virtio-net +~~~~~~~~~~ +With virtio-net it's also necessary to disable the iPXE option ROM on the +device as well as disable the vhost protocol as SEV doesn't support either +(at the time of this writing). This translates to the following XML: + +:: + + <domain> + ... + <interface type='network'> + ... + <model type='virtio'/> + <driver name='qemu' iommu='on'/> + <rom enabled='no'/> + </interface> + ... + <domain> + + Checking SEV from within the guest ================================== @@ -423,7 +444,8 @@ Q35 machine <mac address='52:54:00:cc:56:90'/> <source network='default'/> <model type='virtio'/> - <driver iommu='on'/> + <driver name='qemu' iommu='on'/> + <rom enabled='no'/> </interface> <graphics type='spice' autoport='yes'> <listen type='address'/> -- 2.26.2

2 2

[PATCH] meson: fix some FreeBSD checks regressions
by Roman Bogorodskiy 10 Aug '20

10 Aug '20

* Add missing prerequisite headers for checking link_addr(3) in net/if_dl.h, * Add missing prerequisite headers for checking BRDGSFD, BRDGADD, BRDGDEL in net/if_bridgevar.h, * When checking for ifconfig(8), set not only IFCONFIG value, but also IFCONFIG_PATH as it's used in util/virnetdevip.c. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- meson.build | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/meson.build b/meson.build index 19b4795527..0913308bec 100644 --- a/meson.build +++ b/meson.build @@ -770,7 +770,7 @@ symbols = [ [ 'linux/if_vlan.h', 'GET_VLAN_VID_CMD' ], # Check for BSD approach for setting MAC addr - [ 'net/if_dl.h', 'link_addr' ], + [ 'net/if_dl.h', 'link_addr', '#include <sys/types.h>\n#include <sys/socket.h>' ], ] if host_machine.system() == 'linux' @@ -791,15 +791,18 @@ if host_machine.system() == 'linux' endif foreach symbol : symbols - if cc.has_header_symbol(symbol[0], symbol[1], args: '-D_GNU_SOURCE') + if cc.has_header_symbol(symbol[0], symbol[1], args: '-D_GNU_SOURCE', prefix: symbol.get(2, '')) conf.set('HAVE_DECL_@0@'.format(symbol[1].to_upper()), 1) endif endforeach # Check for BSD approach for bridge management -if (cc.has_header_symbol('net/if_bridgevar.h', 'BRDGSFD') and - cc.has_header_symbol('net/if_bridgevar.h', 'BRDGADD') and - cc.has_header_symbol('net/if_bridgevar.h', 'BRDGDEL')) +brd_required_headers = '''#include <stdint.h> +#include <net/if.h> +#include <net/ethernet.h>''' +if (cc.has_header_symbol('net/if_bridgevar.h', 'BRDGSFD', prefix: brd_required_headers) and + cc.has_header_symbol('net/if_bridgevar.h', 'BRDGADD', prefix: brd_required_headers) and + cc.has_header_symbol('net/if_bridgevar.h', 'BRDGDEL', prefix: brd_required_headers)) conf.set('HAVE_BSD_BRIDGE_MGMT', 1) endif @@ -900,6 +903,7 @@ foreach name : required_programs prog = find_program(name, required: true, dirs: libvirt_sbin_path) varname = name.underscorify() conf.set_quoted(varname.to_upper(), prog.path()) + conf.set_quoted('@0@_PATH'.format(varname.to_upper()), prog.path()) set_variable('@0@_prog'.format(varname), prog) endforeach -- 2.27.0

2 2

[libvirt PATCH 00/20] Use SPDX-License-Identifier
by Ján Tomko 10 Aug '20

10 Aug '20

Replace the license blurb in every single file with: SPDX-License-Identifier: <human-readable-string> Coincidentally, this is also machine readable. This identifies the few places that use GPL-3.0 (syntax-check), some places that mistakenly changed the blurb (patches 1/20 and 4/20). The other variations were period vs. semicolon at various places and double vs. single space before 'If not, write...' Fabricated by calling: git ls-tree -r HEAD: | grep ^100 | cut -f2 | xargs bash ~/rp Where ~/rp is a bash script doing: perl -077 -i -pe 's|LICENSE_BLURB|SPDX-License-Identifier: BLABLA-or-later|' $@ (with some escaping done in the LICENSE_BLURB) https://gitlab.com/jano.tomko/libvirt/-/pipelines/174244608 Ján Tomko (20): Use SPDX-License-Identifier for GPL-2.0-or-later-WITHEXP Use SPDX-License-Identifier for GPL-2.0-or-later Use SPDX-License-Identifier for GPL-3.0-or-later Use SPDX-License-Identifier for LGPL-2.1-or-later-double Use SPDX-License-Identifier for LGPL-2.1-or-later in non-C files conf: Use SPDX-License-Identifier for LGPL-2.1-or-later qemu: Use SPDX-License-Identifier for LGPL-2.1-or-later storage: Use SPDX-License-Identifier for LGPL-2.1-or-later util: Use SPDX-License-Identifier for LGPL-2.1-or-later tests: Use SPDX-License-Identifier for LGPL-2.1-or-later tools: Use SPDX-License-Identifier for LGPL-2.1-or-later include: Use SPDX-License-Identifier for LGPL-2.1-or-later bhyve: Use SPDX-License-Identifier for LGPL-2.1-or-later cpu: Use SPDX-License-Identifier for LGPL-2.1-or-later libxl: Use SPDX-License-Identifier for LGPL-2.1-or-later esx: Use SPDX-License-Identifier for LGPL-2.1-or-later locking: Use SPDX-License-Identifier for LGPL-2.1-or-later lxc: Use SPDX-License-Identifier for LGPL-2.1-or-later rpc: Use SPDX-License-Identifier for LGPL-2.1-or-later Use SPDX-License-Identifier for LGPL-2.1-or-later build-aux/Makefile.nonreentrant | 14 +------------- build-aux/check-spacing.pl | 14 +------------- build-aux/syntax-check.mk | 14 +------------- build-aux/useless-if-before-free | 13 +------------ build-aux/vc-list-files | 13 +------------ config.h | 14 +------------- examples/c/domain/dommigrate.c | 14 +------------- examples/c/domain/domtop.c | 14 +------------- examples/c/domain/rename.c | 14 +------------- examples/c/domain/suspend.c | 14 +------------- examples/sh/virt-lxc-convert | 14 +------------- examples/systemtap/events.stp | 14 +------------- examples/systemtap/qemu-monitor.stp | 14 +------------- examples/systemtap/rpc-monitor.stp | 14 +------------- include/libvirt/libvirt-admin.h | 14 +------------- include/libvirt/libvirt-common.h.in | 14 +------------- include/libvirt/libvirt-domain-checkpoint.h | 14 +------------- include/libvirt/libvirt-domain-snapshot.h | 14 +------------- include/libvirt/libvirt-domain.h | 14 +------------- include/libvirt/libvirt-event.h | 14 +------------- include/libvirt/libvirt-host.h | 14 +------------- include/libvirt/libvirt-interface.h | 14 +------------- include/libvirt/libvirt-lxc.h | 14 +------------- include/libvirt/libvirt-network.h | 14 +------------- include/libvirt/libvirt-nodedev.h | 14 +------------- include/libvirt/libvirt-nwfilter.h | 14 +------------- include/libvirt/libvirt-qemu.h | 14 +------------- include/libvirt/libvirt-secret.h | 14 +------------- include/libvirt/libvirt-storage.h | 14 +------------- include/libvirt/libvirt-stream.h | 14 +------------- include/libvirt/libvirt.h | 14 +------------- include/libvirt/virterror.h | 14 +------------- run.in | 14 +------------- scripts/augeas-gentest.py | 14 +------------- scripts/check-aclperms.py | 14 +------------- scripts/check-aclrules.py | 14 +------------- scripts/check-driverimpls.py | 14 +------------- scripts/check-drivername.py | 14 +------------- scripts/check-file-access.py | 14 +------------- scripts/check-remote-protocol.py | 14 +------------- scripts/check-symfile.py | 14 +------------- scripts/check-symsorting.py | 14 +------------- scripts/cocci-macro-file.h | 14 +------------- scripts/dtrace2systemtap.py | 14 +------------- scripts/esx_vi_generator.py | 14 +------------- scripts/genaclperms.py | 14 +------------- scripts/genpolkit.py | 14 +------------- scripts/gensystemtap.py | 14 +------------- scripts/group-qemu-caps.py | 14 +------------- scripts/header-ifdef.py | 14 +------------- scripts/hvsupport.py | 14 +------------- scripts/hyperv_wmi_generator.py | 14 +------------- scripts/mock-noinline.py | 14 +------------- scripts/prohibit-duplicate-header.py | 14 +------------- scripts/test-wrap-argv.py | 14 +------------- src/access/viraccessdriver.h | 14 +------------- src/access/viraccessdrivernop.c | 14 +------------- src/access/viraccessdrivernop.h | 14 +------------- src/access/viraccessdriverpolkit.c | 14 +------------- src/access/viraccessdriverpolkit.h | 14 +------------- src/access/viraccessdriverstack.c | 14 +------------- src/access/viraccessdriverstack.h | 14 +------------- src/access/viraccessmanager.c | 14 +------------- src/access/viraccessmanager.h | 14 +------------- src/access/viraccessperm.c | 14 +------------- src/access/viraccessperm.h | 14 +------------- src/admin/admin_protocol.x | 14 +------------- src/admin/admin_remote.c | 14 +------------- src/admin/admin_server.c | 14 +------------- src/admin/admin_server.h | 14 +------------- src/admin/admin_server_dispatch.c | 14 +------------- src/admin/admin_server_dispatch.h | 14 +------------- src/admin/libvirt-admin.c | 14 +------------- src/bhyve/bhyve_capabilities.c | 14 +------------- src/bhyve/bhyve_capabilities.h | 14 +------------- src/bhyve/bhyve_command.c | 14 +------------- src/bhyve/bhyve_command.h | 14 +------------- src/bhyve/bhyve_conf.c | 14 +------------- src/bhyve/bhyve_conf.h | 14 +------------- src/bhyve/bhyve_device.c | 14 +------------- src/bhyve/bhyve_device.h | 14 +------------- src/bhyve/bhyve_domain.c | 14 +------------- src/bhyve/bhyve_domain.h | 14 +------------- src/bhyve/bhyve_driver.c | 14 +------------- src/bhyve/bhyve_driver.h | 14 +------------- src/bhyve/bhyve_monitor.c | 14 +------------- src/bhyve/bhyve_monitor.h | 14 +------------- src/bhyve/bhyve_parse_command.c | 14 +------------- src/bhyve/bhyve_parse_command.h | 14 +------------- src/bhyve/bhyve_process.c | 14 +------------- src/bhyve/bhyve_process.h | 14 +------------- src/bhyve/bhyve_utils.h | 14 +------------- src/conf/backup_conf.c | 14 +------------- src/conf/backup_conf.h | 14 +------------- src/conf/capabilities.c | 14 +------------- src/conf/capabilities.h | 14 +------------- src/conf/checkpoint_conf.c | 14 +------------- src/conf/checkpoint_conf.h | 14 +------------- src/conf/cpu_conf.c | 14 +------------- src/conf/cpu_conf.h | 14 +------------- src/conf/device_conf.c | 14 +------------- src/conf/device_conf.h | 14 +------------- src/conf/domain_addr.c | 14 +------------- src/conf/domain_addr.h | 14 +------------- src/conf/domain_audit.c | 14 +------------- src/conf/domain_audit.h | 14 +------------- src/conf/domain_capabilities.c | 14 +------------- src/conf/domain_capabilities.h | 14 +------------- src/conf/domain_conf.c | 14 +------------- src/conf/domain_conf.h | 14 +------------- src/conf/domain_event.c | 14 +------------- src/conf/domain_event.h | 14 +------------- src/conf/domain_nwfilter.c | 14 +------------- src/conf/domain_nwfilter.h | 14 +------------- src/conf/interface_conf.c | 14 +------------- src/conf/interface_conf.h | 14 +------------- src/conf/moment_conf.c | 14 +------------- src/conf/moment_conf.h | 14 +------------- src/conf/netdev_bandwidth_conf.c | 14 +------------- src/conf/netdev_bandwidth_conf.h | 14 +------------- src/conf/netdev_vlan_conf.c | 14 +------------- src/conf/netdev_vlan_conf.h | 14 +------------- src/conf/netdev_vport_profile_conf.c | 14 +------------- src/conf/netdev_vport_profile_conf.h | 14 +------------- src/conf/network_conf.c | 14 +------------- src/conf/network_conf.h | 14 +------------- src/conf/network_event.c | 14 +------------- src/conf/network_event.h | 14 +------------- src/conf/networkcommon_conf.c | 14 +------------- src/conf/networkcommon_conf.h | 14 +------------- src/conf/node_device_conf.c | 14 +------------- src/conf/node_device_conf.h | 14 +------------- src/conf/node_device_event.c | 14 +------------- src/conf/node_device_event.h | 14 +------------- src/conf/node_device_util.c | 14 +------------- src/conf/node_device_util.h | 14 +------------- src/conf/numa_conf.c | 14 +------------- src/conf/numa_conf.h | 14 +------------- src/conf/nwfilter_conf.c | 14 +------------- src/conf/nwfilter_conf.h | 14 +------------- src/conf/nwfilter_ipaddrmap.c | 14 +------------- src/conf/nwfilter_ipaddrmap.h | 14 +------------- src/conf/nwfilter_params.c | 14 +------------- src/conf/nwfilter_params.h | 14 +------------- src/conf/object_event.c | 14 +------------- src/conf/object_event.h | 14 +------------- src/conf/object_event_private.h | 14 +------------- src/conf/secret_conf.c | 14 +------------- src/conf/secret_conf.h | 14 +------------- src/conf/secret_event.c | 14 +------------- src/conf/secret_event.h | 14 +------------- src/conf/snapshot_conf.c | 14 +------------- src/conf/snapshot_conf.h | 14 +------------- src/conf/snapshot_conf_priv.h | 14 +------------- src/conf/storage_adapter_conf.c | 14 +------------- src/conf/storage_adapter_conf.h | 14 +------------- src/conf/storage_capabilities.c | 14 +------------- src/conf/storage_capabilities.h | 14 +------------- src/conf/storage_conf.c | 14 +------------- src/conf/storage_conf.h | 14 +------------- src/conf/storage_event.c | 14 +------------- src/conf/storage_event.h | 14 +------------- src/conf/virchrdev.c | 14 +------------- src/conf/virchrdev.h | 14 +------------- src/conf/virconftypes.h | 14 +------------- src/conf/virdomaincheckpointobjlist.c | 14 +------------- src/conf/virdomaincheckpointobjlist.h | 14 +------------- src/conf/virdomainmomentobjlist.c | 14 +------------- src/conf/virdomainmomentobjlist.h | 14 +------------- src/conf/virdomainobjlist.c | 14 +------------- src/conf/virdomainobjlist.h | 14 +------------- src/conf/virdomainsnapshotobjlist.c | 14 +------------- src/conf/virdomainsnapshotobjlist.h | 14 +------------- src/conf/virinterfaceobj.c | 14 +------------- src/conf/virinterfaceobj.h | 14 +------------- src/conf/virnetworkobj.c | 14 +------------- src/conf/virnetworkobj.h | 14 +------------- src/conf/virnetworkportdef.c | 14 +------------- src/conf/virnetworkportdef.h | 14 +------------- src/conf/virnodedeviceobj.c | 14 +------------- src/conf/virnodedeviceobj.h | 14 +------------- src/conf/virnwfilterbindingdef.c | 14 +------------- src/conf/virnwfilterbindingdef.h | 14 +------------- src/conf/virnwfilterbindingobj.c | 14 +------------- src/conf/virnwfilterbindingobj.h | 14 +------------- src/conf/virnwfilterbindingobjlist.c | 14 +------------- src/conf/virnwfilterbindingobjlist.h | 14 +------------- src/conf/virnwfilterobj.c | 14 +------------- src/conf/virnwfilterobj.h | 14 +------------- src/conf/virsavecookie.c | 14 +------------- src/conf/virsavecookie.h | 14 +------------- src/conf/virsecretobj.c | 14 +------------- src/conf/virsecretobj.h | 14 +------------- src/conf/virstorageobj.c | 14 +------------- src/conf/virstorageobj.h | 14 +------------- src/cpu/cpu.c | 14 +------------- src/cpu/cpu.h | 14 +------------- src/cpu/cpu_arm.c | 14 +------------- src/cpu/cpu_arm.h | 14 +------------- src/cpu/cpu_arm_data.h | 14 +------------- src/cpu/cpu_map.c | 14 +------------- src/cpu/cpu_map.h | 14 +------------- src/cpu/cpu_ppc64.c | 14 +------------- src/cpu/cpu_ppc64.h | 14 +------------- src/cpu/cpu_ppc64_data.h | 14 +------------- src/cpu/cpu_s390.c | 14 +------------- src/cpu/cpu_s390.h | 14 +------------- src/cpu/cpu_x86.c | 14 +------------- src/cpu/cpu_x86.h | 14 +------------- src/cpu/cpu_x86_data.h | 14 +------------- src/datatypes.c | 14 +------------- src/datatypes.h | 14 +------------- src/driver-hypervisor.h | 14 +------------- src/driver-interface.h | 14 +------------- src/driver-network.h | 14 +------------- src/driver-nodedev.h | 14 +------------- src/driver-nwfilter.h | 14 +------------- src/driver-secret.h | 14 +------------- src/driver-state.h | 14 +------------- src/driver-storage.h | 14 +------------- src/driver-stream.h | 14 +------------- src/driver.c | 14 +------------- src/driver.h | 14 +------------- src/esx/esx_driver.c | 14 +------------- src/esx/esx_driver.h | 14 +------------- src/esx/esx_interface_driver.c | 14 +------------- src/esx/esx_interface_driver.h | 14 +------------- src/esx/esx_network_driver.c | 14 +------------- src/esx/esx_network_driver.h | 14 +------------- src/esx/esx_private.h | 14 +------------- src/esx/esx_storage_backend_iscsi.c | 14 +------------- src/esx/esx_storage_backend_iscsi.h | 14 +------------- src/esx/esx_storage_backend_vmfs.c | 14 +------------- src/esx/esx_storage_backend_vmfs.h | 14 +------------- src/esx/esx_storage_driver.c | 14 +------------- src/esx/esx_storage_driver.h | 14 +------------- src/esx/esx_stream.c | 14 +------------- src/esx/esx_stream.h | 14 +------------- src/esx/esx_util.c | 14 +------------- src/esx/esx_util.h | 14 +------------- src/esx/esx_vi.c | 14 +------------- src/esx/esx_vi.h | 14 +------------- src/esx/esx_vi_methods.c | 14 +------------- src/esx/esx_vi_methods.h | 14 +------------- src/esx/esx_vi_types.c | 14 +------------- src/esx/esx_vi_types.h | 14 +------------- src/hyperv/hyperv_driver.c | 14 +------------- src/hyperv/hyperv_driver.h | 14 +------------- src/hyperv/hyperv_private.h | 14 +------------- src/hyperv/hyperv_util.c | 14 +------------- src/hyperv/hyperv_util.h | 14 +------------- src/hyperv/hyperv_wmi.c | 14 +------------- src/hyperv/hyperv_wmi.h | 14 +------------- src/hyperv/hyperv_wmi_classes.c | 14 +------------- src/hyperv/hyperv_wmi_classes.h | 14 +------------- src/hyperv/openwsman.h | 14 +------------- src/hypervisor/domain_cgroup.c | 14 +------------- src/hypervisor/domain_cgroup.h | 14 +------------- src/hypervisor/domain_driver.c | 14 +------------- src/hypervisor/domain_driver.h | 14 +------------- src/hypervisor/virclosecallbacks.c | 14 +------------- src/hypervisor/virclosecallbacks.h | 14 +------------- src/hypervisor/virhostdev.c | 14 +------------- src/hypervisor/virhostdev.h | 14 +------------- src/interface/interface_backend_netcf.c | 14 +------------- src/interface/interface_backend_udev.c | 14 +------------- src/interface/interface_driver.c | 14 +------------- src/interface/interface_driver.h | 14 +------------- src/internal.h | 14 +------------- src/libvirt-domain-checkpoint.c | 14 +------------- src/libvirt-domain-snapshot.c | 14 +------------- src/libvirt-domain.c | 14 +------------- src/libvirt-host.c | 14 +------------- src/libvirt-interface.c | 14 +------------- src/libvirt-lxc.c | 14 +------------- src/libvirt-network.c | 14 +------------- src/libvirt-nodedev.c | 14 +------------- src/libvirt-nwfilter.c | 14 +------------- src/libvirt-qemu.c | 14 +------------- src/libvirt-secret.c | 14 +------------- src/libvirt-storage.c | 14 +------------- src/libvirt-stream.c | 14 +------------- src/libvirt.c | 14 +------------- src/libvirt_internal.h | 14 +------------- src/libxl/libxl_capabilities.c | 14 +------------- src/libxl/libxl_capabilities.h | 14 +------------- src/libxl/libxl_conf.c | 14 +------------- src/libxl/libxl_conf.h | 14 +------------- src/libxl/libxl_domain.c | 14 +------------- src/libxl/libxl_domain.h | 14 +------------- src/libxl/libxl_driver.c | 14 +------------- src/libxl/libxl_driver.h | 14 +------------- src/libxl/libxl_logger.c | 14 +------------- src/libxl/libxl_logger.h | 14 +------------- src/libxl/libxl_migration.c | 14 +------------- src/libxl/libxl_migration.h | 14 +------------- src/libxl/xen_common.c | 14 +------------- src/libxl/xen_common.h | 14 +------------- src/libxl/xen_xl.c | 14 +------------- src/libxl/xen_xl.h | 14 +------------- src/libxl/xen_xm.c | 14 +------------- src/libxl/xen_xm.h | 14 +------------- src/libxl/xenxs_private.h | 14 +------------- src/locking/domain_lock.c | 14 +------------- src/locking/domain_lock.h | 14 +------------- src/locking/lock_daemon.c | 14 +------------- src/locking/lock_daemon.h | 14 +------------- src/locking/lock_daemon_config.c | 14 +------------- src/locking/lock_daemon_config.h | 14 +------------- src/locking/lock_daemon_dispatch.c | 14 +------------- src/locking/lock_daemon_dispatch.h | 14 +------------- src/locking/lock_driver.h | 14 +------------- src/locking/lock_driver_lockd.c | 14 +------------- src/locking/lock_driver_lockd.h | 14 +------------- src/locking/lock_driver_nop.c | 14 +------------- src/locking/lock_driver_nop.h | 14 +------------- src/locking/lock_driver_sanlock.c | 14 +------------- src/locking/lock_manager.c | 14 +------------- src/locking/lock_manager.h | 14 +------------- src/logging/log_daemon.c | 14 +------------- src/logging/log_daemon.h | 14 +------------- src/logging/log_daemon_config.c | 14 +------------- src/logging/log_daemon_config.h | 14 +------------- src/logging/log_daemon_dispatch.c | 14 +------------- src/logging/log_daemon_dispatch.h | 14 +------------- src/logging/log_handler.c | 14 +------------- src/logging/log_handler.h | 14 +------------- src/logging/log_manager.c | 14 +------------- src/logging/log_manager.h | 14 +------------- src/lxc/lxc_cgroup.c | 14 +------------- src/lxc/lxc_cgroup.h | 14 +------------- src/lxc/lxc_conf.c | 14 +------------- src/lxc/lxc_conf.h | 14 +------------- src/lxc/lxc_container.c | 14 +------------- src/lxc/lxc_container.h | 14 +------------- src/lxc/lxc_controller.c | 14 +------------- src/lxc/lxc_domain.c | 14 +------------- src/lxc/lxc_domain.h | 14 +------------- src/lxc/lxc_driver.c | 14 +------------- src/lxc/lxc_driver.h | 14 +------------- src/lxc/lxc_fuse.c | 14 +------------- src/lxc/lxc_fuse.h | 14 +------------- src/lxc/lxc_hostdev.c | 14 +------------- src/lxc/lxc_hostdev.h | 14 +------------- src/lxc/lxc_monitor.c | 14 +------------- src/lxc/lxc_monitor.h | 14 +------------- src/lxc/lxc_native.c | 14 +------------- src/lxc/lxc_native.h | 14 +------------- src/lxc/lxc_process.c | 14 +------------- src/lxc/lxc_process.h | 14 +------------- src/network/bridge_driver.c | 14 +------------- src/network/bridge_driver.h | 14 +------------- src/network/bridge_driver_linux.c | 14 +------------- src/network/bridge_driver_nop.c | 14 +------------- src/network/bridge_driver_platform.c | 14 +------------- src/network/bridge_driver_platform.h | 14 +------------- src/network/leaseshelper.c | 14 +------------- src/node_device/node_device_driver.c | 14 +------------- src/node_device/node_device_driver.h | 14 +------------- src/node_device/node_device_hal.c | 14 +------------- src/node_device/node_device_hal.h | 14 +------------- src/node_device/node_device_udev.c | 14 +------------- src/node_device/node_device_udev.h | 14 +------------- src/nwfilter/nwfilter_dhcpsnoop.c | 14 +------------- src/nwfilter/nwfilter_dhcpsnoop.h | 14 +------------- src/nwfilter/nwfilter_driver.c | 14 +------------- src/nwfilter/nwfilter_driver.h | 14 +------------- src/nwfilter/nwfilter_ebiptables_driver.c | 14 +------------- src/nwfilter/nwfilter_ebiptables_driver.h | 14 +------------- src/nwfilter/nwfilter_gentech_driver.c | 14 +------------- src/nwfilter/nwfilter_gentech_driver.h | 14 +------------- src/nwfilter/nwfilter_learnipaddr.c | 14 +------------- src/nwfilter/nwfilter_learnipaddr.h | 14 +------------- src/nwfilter/nwfilter_tech_driver.h | 14 +------------- src/openvz/openvz_conf.c | 14 +------------- src/openvz/openvz_conf.h | 14 +------------- src/openvz/openvz_driver.c | 14 +------------- src/openvz/openvz_driver.h | 14 +------------- src/openvz/openvz_util.c | 14 +------------- src/openvz/openvz_util.h | 14 +------------- src/qemu/qemu_agent.c | 14 +------------- src/qemu/qemu_agent.h | 14 +------------- src/qemu/qemu_alias.c | 14 +------------- src/qemu/qemu_alias.h | 14 +------------- src/qemu/qemu_backup.c | 14 +------------- src/qemu/qemu_backup.h | 14 +------------- src/qemu/qemu_block.c | 14 +------------- src/qemu/qemu_block.h | 14 +------------- src/qemu/qemu_blockjob.c | 14 +------------- src/qemu/qemu_blockjob.h | 14 +------------- src/qemu/qemu_capabilities.c | 14 +------------- src/qemu/qemu_capabilities.h | 14 +------------- src/qemu/qemu_capspriv.h | 14 +------------- src/qemu/qemu_cgroup.c | 14 +------------- src/qemu/qemu_cgroup.h | 14 +------------- src/qemu/qemu_checkpoint.c | 14 +------------- src/qemu/qemu_checkpoint.h | 14 +------------- src/qemu/qemu_command.c | 14 +------------- src/qemu/qemu_command.h | 14 +------------- src/qemu/qemu_conf.c | 14 +------------- src/qemu/qemu_conf.h | 14 +------------- src/qemu/qemu_dbus.c | 14 +------------- src/qemu/qemu_dbus.h | 14 +------------- src/qemu/qemu_domain.c | 14 +------------- src/qemu/qemu_domain.h | 14 +------------- src/qemu/qemu_domain_address.c | 14 +------------- src/qemu/qemu_domain_address.h | 14 +------------- src/qemu/qemu_domainjob.c | 14 +------------- src/qemu/qemu_domainjob.h | 14 +------------- src/qemu/qemu_driver.c | 14 +------------- src/qemu/qemu_driver.h | 14 +------------- src/qemu/qemu_extdevice.c | 14 +------------- src/qemu/qemu_extdevice.h | 14 +------------- src/qemu/qemu_firmware.c | 14 +------------- src/qemu/qemu_firmware.h | 14 +------------- src/qemu/qemu_hostdev.c | 14 +------------- src/qemu/qemu_hostdev.h | 14 +------------- src/qemu/qemu_hotplug.c | 14 +------------- src/qemu/qemu_hotplug.h | 14 +------------- src/qemu/qemu_interface.c | 14 +------------- src/qemu/qemu_interface.h | 14 +------------- src/qemu/qemu_interop_config.c | 14 +------------- src/qemu/qemu_interop_config.h | 14 +------------- src/qemu/qemu_migration.c | 14 +------------- src/qemu/qemu_migration.h | 14 +------------- src/qemu/qemu_migration_cookie.c | 14 +------------- src/qemu/qemu_migration_cookie.h | 14 +------------- src/qemu/qemu_migration_params.c | 14 +------------- src/qemu/qemu_migration_params.h | 14 +------------- src/qemu/qemu_migration_paramspriv.h | 14 +------------- src/qemu/qemu_monitor.c | 14 +------------- src/qemu/qemu_monitor.h | 14 +------------- src/qemu/qemu_monitor_json.c | 14 +------------- src/qemu/qemu_monitor_json.h | 14 +------------- src/qemu/qemu_monitor_priv.h | 14 +------------- src/qemu/qemu_monitor_text.c | 14 +------------- src/qemu/qemu_monitor_text.h | 14 +------------- src/qemu/qemu_namespace.c | 14 +------------- src/qemu/qemu_namespace.h | 14 +------------- src/qemu/qemu_process.c | 14 +------------- src/qemu/qemu_process.h | 14 +------------- src/qemu/qemu_processpriv.h | 14 +------------- src/qemu/qemu_qapi.c | 14 +------------- src/qemu/qemu_qapi.h | 14 +------------- src/qemu/qemu_security.c | 14 +------------- src/qemu/qemu_security.h | 14 +------------- src/qemu/qemu_shim.c | 14 +------------- src/qemu/qemu_slirp.c | 14 +------------- src/qemu/qemu_slirp.h | 14 +------------- src/qemu/qemu_tpm.c | 14 +------------- src/qemu/qemu_tpm.h | 14 +------------- src/qemu/qemu_validate.c | 14 +------------- src/qemu/qemu_validate.h | 14 +------------- src/qemu/qemu_vhost_user.c | 14 +------------- src/qemu/qemu_vhost_user.h | 14 +------------- src/qemu/qemu_vhost_user_gpu.c | 14 +------------- src/qemu/qemu_vhost_user_gpu.h | 14 +------------- src/qemu/qemu_virtiofs.c | 14 +------------- src/qemu/qemu_virtiofs.h | 14 +------------- src/remote/libvirtd.policy | 14 +------------- src/remote/lxc_protocol.x | 14 +------------- src/remote/qemu_protocol.x | 14 +------------- src/remote/remote_daemon.c | 14 +------------- src/remote/remote_daemon.h | 14 +------------- src/remote/remote_daemon_config.c | 14 +------------- src/remote/remote_daemon_config.h | 14 +------------- src/remote/remote_daemon_dispatch.c | 14 +------------- src/remote/remote_daemon_dispatch.h | 14 +------------- src/remote/remote_daemon_stream.c | 14 +------------- src/remote/remote_daemon_stream.h | 14 +------------- src/remote/remote_driver.c | 14 +------------- src/remote/remote_driver.h | 14 +------------- src/remote/remote_protocol.x | 14 +------------- src/rpc/gendispatch.pl | 14 +------------- src/rpc/genprotocol.pl | 14 +------------- src/rpc/virkeepalive.c | 14 +------------- src/rpc/virkeepalive.h | 14 +------------- src/rpc/virnetclient.c | 14 +------------- src/rpc/virnetclient.h | 14 +------------- src/rpc/virnetclientprogram.c | 14 +------------- src/rpc/virnetclientprogram.h | 14 +------------- src/rpc/virnetclientstream.c | 14 +------------- src/rpc/virnetclientstream.h | 14 +------------- src/rpc/virnetdaemon.c | 14 +------------- src/rpc/virnetdaemon.h | 14 +------------- src/rpc/virnetlibsshsession.c | 14 +------------- src/rpc/virnetlibsshsession.h | 14 +------------- src/rpc/virnetmessage.c | 14 +------------- src/rpc/virnetmessage.h | 14 +------------- src/rpc/virnetprotocol.x | 14 +------------- src/rpc/virnetsaslcontext.c | 14 +------------- src/rpc/virnetsaslcontext.h | 14 +------------- src/rpc/virnetserver.c | 14 +------------- src/rpc/virnetserver.h | 14 +------------- src/rpc/virnetserverclient.c | 14 +------------- src/rpc/virnetserverclient.h | 14 +------------- src/rpc/virnetserverprogram.c | 14 +------------- src/rpc/virnetserverprogram.h | 14 +------------- src/rpc/virnetserverservice.c | 14 +------------- src/rpc/virnetserverservice.h | 14 +------------- src/rpc/virnetsocket.c | 14 +------------- src/rpc/virnetsocket.h | 14 +------------- src/rpc/virnetsshsession.c | 14 +------------- src/rpc/virnetsshsession.h | 14 +------------- src/rpc/virnettlscontext.c | 14 +------------- src/rpc/virnettlscontext.h | 14 +------------- src/secret/secret_driver.c | 14 +------------- src/secret/secret_driver.h | 14 +------------- src/security/security_apparmor.c | 14 +------------- src/security/security_apparmor.h | 14 +------------- src/security/security_dac.c | 14 +------------- src/security/security_dac.h | 14 +------------- src/security/security_driver.c | 14 +------------- src/security/security_driver.h | 14 +------------- src/security/security_manager.c | 14 +------------- src/security/security_manager.h | 14 +------------- src/security/security_nop.c | 14 +------------- src/security/security_nop.h | 14 +------------- src/security/security_selinux.c | 14 +------------- src/security/security_selinux.h | 14 +------------- src/security/security_stack.c | 14 +------------- src/security/security_stack.h | 14 +------------- src/security/security_util.c | 14 +------------- src/security/security_util.h | 14 +------------- src/security/virt-aa-helper.c | 14 +------------- src/storage/parthelper.c | 14 +------------- src/storage/storage_backend.c | 14 +------------- src/storage/storage_backend.h | 14 +------------- src/storage/storage_backend_disk.c | 14 +------------- src/storage/storage_backend_disk.h | 14 +------------- src/storage/storage_backend_fs.c | 14 +------------- src/storage/storage_backend_fs.h | 14 +------------- src/storage/storage_backend_gluster.c | 14 +------------- src/storage/storage_backend_gluster.h | 14 +------------- src/storage/storage_backend_iscsi.c | 14 +------------- src/storage/storage_backend_iscsi.h | 14 +------------- src/storage/storage_backend_iscsi_direct.c | 14 +------------- src/storage/storage_backend_iscsi_direct.h | 14 +------------- src/storage/storage_backend_logical.c | 14 +------------- src/storage/storage_backend_logical.h | 14 +------------- src/storage/storage_backend_mpath.c | 14 +------------- src/storage/storage_backend_mpath.h | 14 +------------- src/storage/storage_backend_rbd.c | 14 +------------- src/storage/storage_backend_rbd.h | 14 +------------- src/storage/storage_backend_scsi.c | 14 +------------- src/storage/storage_backend_scsi.h | 14 +------------- src/storage/storage_backend_sheepdog.c | 14 +------------- src/storage/storage_backend_sheepdog.h | 14 +------------- src/storage/storage_backend_sheepdog_priv.h | 14 +------------- src/storage/storage_backend_vstorage.h | 14 +------------- src/storage/storage_backend_zfs.c | 14 +------------- src/storage/storage_backend_zfs.h | 14 +------------- src/storage/storage_driver.c | 14 +------------- src/storage/storage_driver.h | 14 +------------- src/storage/storage_file_fs.c | 14 +------------- src/storage/storage_file_fs.h | 14 +------------- src/storage/storage_file_gluster.c | 14 +------------- src/storage/storage_file_gluster.h | 14 +------------- src/storage/storage_util.c | 14 +------------- src/storage/storage_util.h | 14 +------------- src/test/test_driver.c | 14 +------------- src/test/test_driver.h | 14 +------------- src/util/glibcompat.c | 14 +------------- src/util/glibcompat.h | 14 +------------- src/util/iohelper.c | 14 +------------- src/util/viralloc.c | 14 +------------- src/util/viralloc.h | 14 +------------- src/util/virarch.c | 14 +------------- src/util/virarch.h | 14 +------------- src/util/virarptable.c | 14 +------------- src/util/virarptable.h | 14 +------------- src/util/viraudit.c | 14 +------------- src/util/viraudit.h | 14 +------------- src/util/virauth.c | 14 +------------- src/util/virauth.h | 14 +------------- src/util/virauthconfig.c | 14 +------------- src/util/virauthconfig.h | 14 +------------- src/util/virbitmap.c | 14 +------------- src/util/virbitmap.h | 14 +------------- src/util/virbpf.c | 14 +------------- src/util/virbpf.h | 14 +------------- src/util/virbuffer.c | 14 +------------- src/util/virbuffer.h | 14 +------------- src/util/vircgroup.c | 14 +------------- src/util/vircgroup.h | 14 +------------- src/util/vircgroupbackend.c | 14 +------------- src/util/vircgroupbackend.h | 14 +------------- src/util/vircgrouppriv.h | 14 +------------- src/util/vircgroupv1.c | 14 +------------- src/util/vircgroupv1.h | 14 +------------- src/util/vircgroupv2.c | 14 +------------- src/util/vircgroupv2.h | 14 +------------- src/util/vircgroupv2devices.c | 14 +------------- src/util/vircgroupv2devices.h | 14 +------------- src/util/vircommand.c | 14 +------------- src/util/vircommand.h | 14 +------------- src/util/vircommandpriv.h | 14 +------------- src/util/virconf.c | 14 +------------- src/util/virconf.h | 14 +------------- src/util/vircrypto.c | 14 +------------- src/util/vircrypto.h | 14 +------------- src/util/virdaemon.c | 14 +------------- src/util/virdaemon.h | 14 +------------- src/util/virdbus.c | 14 +------------- src/util/virdbus.h | 14 +------------- src/util/virdbuspriv.h | 14 +------------- src/util/virdevmapper.c | 14 +------------- src/util/virdevmapper.h | 14 +------------- src/util/virdnsmasq.c | 14 +------------- src/util/virdnsmasq.h | 14 +------------- src/util/virebtables.c | 14 +------------- src/util/virebtables.h | 14 +------------- src/util/virendian.h | 14 +------------- src/util/virenum.c | 14 +------------- src/util/virenum.h | 14 +------------- src/util/virerror.c | 14 +------------- src/util/virerror.h | 14 +------------- src/util/virerrorpriv.h | 14 +------------- src/util/virevent.c | 14 +------------- src/util/virevent.h | 14 +------------- src/util/vireventglib.c | 14 +------------- src/util/vireventglib.h | 14 +------------- src/util/vireventglibwatch.c | 14 +------------- src/util/vireventglibwatch.h | 14 +------------- src/util/vireventthread.c | 14 +------------- src/util/vireventthread.h | 14 +------------- src/util/virfcp.c | 14 +------------- src/util/virfcp.h | 14 +------------- src/util/virfdstream.c | 14 +------------- src/util/virfdstream.h | 14 +------------- src/util/virfile.c | 14 +------------- src/util/virfile.h | 14 +------------- src/util/virfilecache.c | 14 +------------- src/util/virfilecache.h | 14 +------------- src/util/virfirewall.c | 14 +------------- src/util/virfirewall.h | 14 +------------- src/util/virfirewalld.c | 14 +------------- src/util/virfirewalld.h | 14 +------------- src/util/virfirewalldpriv.h | 14 +------------- src/util/virfirewallpriv.h | 14 +------------- src/util/virfirmware.c | 14 +------------- src/util/virfirmware.h | 14 +------------- src/util/virgettext.c | 14 +------------- src/util/virgettext.h | 14 +------------- src/util/virgic.c | 14 +------------- src/util/virgic.h | 14 +------------- src/util/virhashcode.c | 14 +------------- src/util/virhashcode.h | 14 +------------- src/util/virhook.c | 14 +------------- src/util/virhook.h | 14 +------------- src/util/virhostcpu.c | 14 +------------- src/util/virhostcpu.h | 14 +------------- src/util/virhostcpupriv.h | 14 +------------- src/util/virhostmem.c | 14 +------------- src/util/virhostmem.h | 14 +------------- src/util/virhostuptime.c | 14 +------------- src/util/virhostuptime.h | 14 +------------- src/util/viridentity.c | 14 +------------- src/util/viridentity.h | 14 +------------- src/util/virinitctl.c | 14 +------------- src/util/virinitctl.h | 14 +------------- src/util/viriptables.c | 14 +------------- src/util/viriptables.h | 14 +------------- src/util/viriscsi.c | 14 +------------- src/util/viriscsi.h | 14 +------------- src/util/virjson.c | 14 +------------- src/util/virjson.h | 14 +------------- src/util/virkeycode.c | 14 +------------- src/util/virkeycode.h | 14 +------------- src/util/virkmod.c | 14 +------------- src/util/virkmod.h | 14 +------------- src/util/virlease.c | 14 +------------- src/util/virlease.h | 14 +------------- src/util/virlockspace.c | 14 +------------- src/util/virlockspace.h | 14 +------------- src/util/virlog.c | 14 +------------- src/util/virlog.h | 14 +------------- src/util/virmacaddr.c | 14 +------------- src/util/virmacaddr.h | 14 +------------- src/util/virmacmap.c | 14 +------------- src/util/virmacmap.h | 14 +------------- src/util/virmdev.c | 14 +------------- src/util/virmdev.h | 14 +------------- src/util/virmodule.c | 14 +------------- src/util/virmodule.h | 14 +------------- src/util/virnetdev.c | 14 +------------- src/util/virnetdev.h | 14 +------------- src/util/virnetdevbandwidth.c | 14 +------------- src/util/virnetdevbandwidth.h | 14 +------------- src/util/virnetdevbridge.c | 14 +------------- src/util/virnetdevbridge.h | 14 +------------- src/util/virnetdevip.c | 14 +------------- src/util/virnetdevip.h | 14 +------------- src/util/virnetdevmacvlan.c | 14 +------------- src/util/virnetdevmacvlan.h | 14 +------------- src/util/virnetdevmidonet.c | 14 +------------- src/util/virnetdevmidonet.h | 14 +------------- src/util/virnetdevopenvswitch.c | 14 +------------- src/util/virnetdevopenvswitch.h | 14 +------------- src/util/virnetdevtap.c | 14 +------------- src/util/virnetdevtap.h | 14 +------------- src/util/virnetdevveth.c | 14 +------------- src/util/virnetdevveth.h | 14 +------------- src/util/virnetdevvlan.c | 14 +------------- src/util/virnetdevvlan.h | 14 +------------- src/util/virnetdevvportprofile.c | 14 +------------- src/util/virnetdevvportprofile.h | 14 +------------- src/util/virnetlink.c | 14 +------------- src/util/virnetlink.h | 14 +------------- src/util/virnodesuspend.c | 14 +------------- src/util/virnodesuspend.h | 14 +------------- src/util/virnuma.c | 14 +------------- src/util/virnuma.h | 14 +------------- src/util/virnvme.c | 14 +------------- src/util/virnvme.h | 14 +------------- src/util/virobject.c | 14 +------------- src/util/virobject.h | 14 +------------- src/util/virpci.c | 14 +------------- src/util/virpci.h | 14 +------------- src/util/virperf.c | 14 +------------- src/util/virperf.h | 14 +------------- src/util/virpidfile.c | 14 +------------- src/util/virpidfile.h | 14 +------------- src/util/virpolkit.c | 14 +------------- src/util/virpolkit.h | 14 +------------- src/util/virportallocator.c | 14 +------------- src/util/virportallocator.h | 14 +------------- src/util/virprobe.h | 14 +------------- src/util/virprocess.c | 14 +------------- src/util/virprocess.h | 14 +------------- src/util/virqemu.c | 14 +------------- src/util/virqemu.h | 14 +------------- src/util/virrandom.c | 14 +------------- src/util/virrandom.h | 14 +------------- src/util/virresctrl.c | 14 +------------- src/util/virresctrl.h | 14 +------------- src/util/virresctrlpriv.h | 14 +------------- src/util/virrotatingfile.c | 14 +------------- src/util/virrotatingfile.h | 14 +------------- src/util/virscsi.c | 14 +------------- src/util/virscsi.h | 14 +------------- src/util/virscsihost.c | 14 +------------- src/util/virscsihost.h | 14 +------------- src/util/virscsivhost.c | 14 +------------- src/util/virscsivhost.h | 14 +------------- src/util/virseclabel.c | 14 +------------- src/util/virseclabel.h | 14 +------------- src/util/virsecret.c | 14 +------------- src/util/virsecret.h | 14 +------------- src/util/virsocket.c | 14 +------------- src/util/virsocket.h | 14 +------------- src/util/virsocketaddr.c | 14 +------------- src/util/virsocketaddr.h | 14 +------------- src/util/virstorageencryption.c | 14 +------------- src/util/virstorageencryption.h | 14 +------------- src/util/virstoragefile.c | 14 +------------- src/util/virstoragefile.h | 14 +------------- src/util/virstoragefilebackend.c | 14 +------------- src/util/virstoragefilebackend.h | 14 +------------- src/util/virstring.c | 14 +------------- src/util/virstring.h | 14 +------------- src/util/virsysinfo.c | 14 +------------- src/util/virsysinfo.h | 14 +------------- src/util/virsysinfopriv.h | 14 +------------- src/util/virsystemd.c | 14 +------------- src/util/virsystemd.h | 14 +------------- src/util/virsystemdpriv.h | 14 +------------- src/util/virthread.c | 14 +------------- src/util/virthread.h | 14 +------------- src/util/virthreadjob.c | 14 +------------- src/util/virthreadjob.h | 14 +------------- src/util/virthreadpool.c | 14 +------------- src/util/virthreadpool.h | 14 +------------- src/util/virtime.c | 14 +------------- src/util/virtime.h | 14 +------------- src/util/virtpm.c | 14 +------------- src/util/virtpm.h | 14 +------------- src/util/virtypedparam-public.c | 14 +------------- src/util/virtypedparam.c | 14 +------------- src/util/virtypedparam.h | 14 +------------- src/util/viruri.c | 14 +------------- src/util/viruri.h | 14 +------------- src/util/virusb.c | 14 +------------- src/util/virusb.h | 14 +------------- src/util/virutil.c | 14 +------------- src/util/virutil.h | 14 +------------- src/util/viruuid.c | 14 +------------- src/util/viruuid.h | 14 +------------- src/util/virvhba.c | 14 +------------- src/util/virvhba.h | 14 +------------- src/util/virvsock.c | 14 +------------- src/util/virvsock.h | 14 +------------- src/util/virxdrdefs.h | 14 +------------- src/util/virxml.c | 14 +------------- src/util/virxml.h | 14 +------------- src/vbox/vbox_common.c | 14 +------------- src/vbox/vbox_common.h | 14 +------------- src/vbox/vbox_get_driver.h | 14 +------------- src/vbox/vbox_network.c | 14 +------------- src/vbox/vbox_snapshot_conf.c | 14 +------------- src/vbox/vbox_snapshot_conf.h | 14 +------------- src/vbox/vbox_storage.c | 14 +------------- src/vbox/vbox_uniformed_api.h | 14 +------------- src/vmware/vmware_conf.c | 14 +------------- src/vmware/vmware_conf.h | 14 +------------- src/vmware/vmware_driver.c | 14 +------------- src/vmware/vmware_driver.h | 14 +------------- src/vmx/vmx.c | 14 +------------- src/vmx/vmx.h | 14 +------------- src/vz/vz_driver.c | 14 +------------- src/vz/vz_driver.h | 14 +------------- src/vz/vz_sdk.c | 14 +------------- src/vz/vz_sdk.h | 14 +------------- src/vz/vz_utils.c | 14 +------------- src/vz/vz_utils.h | 14 +------------- tests/commandhelper.c | 14 +------------- tests/commandtest.c | 14 +------------- tests/cputest.c | 14 +------------- tests/domaincapsmock.c | 14 +------------- tests/domaincapstest.c | 14 +------------- tests/domainconftest.c | 14 +------------- tests/eventtest.c | 14 +------------- tests/fchosttest.c | 14 +------------- tests/fdstreamtest.c | 14 +------------- tests/libxlmock.c | 14 +------------- tests/libxlxml2domconfigtest.c | 14 +------------- tests/metadatatest.c | 14 +------------- tests/networkxml2firewalltest.c | 14 +------------- tests/nsslinktest.c | 14 +------------- tests/nssmock.c | 14 +------------- tests/nsstest.c | 14 +------------- tests/nwfilterebiptablestest.c | 14 +------------- tests/nwfilterxml2firewalltest.c | 14 +------------- tests/objecteventtest.c | 14 +------------- tests/qemuagenttest.c | 14 +------------- tests/qemublocktest.c | 14 +------------- tests/qemucapabilitiestest.c | 14 +------------- tests/qemucaps2xmlmock.c | 14 +------------- tests/qemucaps2xmltest.c | 14 +------------- tests/qemucapsprobe.c | 14 +------------- tests/qemucapsprobemock.c | 14 +------------- tests/qemucommandutiltest.c | 14 +------------- tests/qemucpumock.c | 14 +------------- tests/qemuhotplugmock.c | 14 +------------- tests/qemuhotplugtest.c | 14 +------------- tests/qemumigparamstest.c | 14 +------------- tests/qemumonitorjsontest.c | 14 +------------- tests/qemumonitortestutils.c | 14 +------------- tests/qemumonitortestutils.h | 14 +------------- tests/qemusecuritymock.c | 14 +------------- tests/qemusecuritytest.c | 14 +------------- tests/qemusecuritytest.h | 14 +------------- tests/qemuxml2argvmock.c | 14 +------------- tests/scsihosttest.c | 14 +------------- tests/securityselinuxhelper.c | 14 +------------- tests/securityselinuxlabeltest.c | 15 +-------------- tests/securityselinuxtest.c | 14 +------------- tests/shunloadhelper.c | 14 +------------- tests/shunloadtest.c | 14 +------------- tests/sockettest.c | 14 +------------- tests/ssh.c | 14 +------------- tests/storagebackendsheepdogtest.c | 14 +------------- tests/storagepoolcapstest.c | 14 +------------- tests/sysinfotest.c | 14 +------------- tests/test-lib.sh | 14 +------------- tests/testutils.c | 14 +------------- tests/testutils.h | 14 +------------- tests/testutilshostcpus.h | 14 +------------- tests/testutilslxc.h | 14 +------------- tests/testutilsqemu.h | 14 +------------- tests/testutilsqemuschema.c | 14 +------------- tests/testutilsqemuschema.h | 14 +------------- tests/testutilsxen.h | 14 +------------- tests/viralloctest.c | 14 +------------- tests/virauthconfigtest.c | 14 +------------- tests/virbitmaptest.c | 14 +------------- tests/vircaps2xmltest.c | 14 +------------- tests/vircapstest.c | 14 +------------- tests/vircgroupmock.c | 14 +------------- tests/vircgrouptest.c | 14 +------------- tests/virconftest.c | 14 +------------- tests/vircryptotest.c | 14 +------------- tests/virdbusmock.c | 14 +------------- tests/virdbustest.c | 14 +------------- tests/virdeterministichashmock.c | 14 +------------- tests/virdriverconnvalidatetest.c | 14 +------------- tests/virdrivermoduletest.c | 14 +------------- tests/virendiantest.c | 14 +------------- tests/virerrortest.c | 14 +------------- tests/virfilecachemock.c | 14 +------------- tests/virfilecachetest.c | 14 +------------- tests/virfilemock.c | 14 +------------- tests/virfiletest.c | 14 +------------- tests/virfilewrapper.c | 14 +------------- tests/virfilewrapper.h | 14 +------------- tests/virfirewalltest.c | 14 +------------- tests/virhashdata.h | 14 +------------- tests/virhostcpumock.c | 14 +------------- tests/virhostdevtest.c | 14 +------------- tests/viridentitytest.c | 14 +------------- tests/viriscsitest.c | 14 +------------- tests/virkeycodetest.c | 14 +------------- tests/virkmodtest.c | 14 +------------- tests/virlockspacetest.c | 14 +------------- tests/virlogtest.c | 14 +------------- tests/virmacmaptest.c | 14 +------------- tests/virmock.h | 14 +------------- tests/virmockstathelpers.c | 14 +------------- tests/virnetdaemonmock.c | 14 +------------- tests/virnetdaemontest.c | 14 +------------- tests/virnetdevbandwidthmock.c | 14 +------------- tests/virnetdevbandwidthtest.c | 14 +------------- tests/virnetdevmock.c | 14 +------------- tests/virnetdevopenvswitchtest.c | 14 +------------- tests/virnetdevtest.c | 14 +------------- tests/virnetmessagetest.c | 14 +------------- tests/virnetserverclientmock.c | 14 +------------- tests/virnetserverclienttest.c | 14 +------------- tests/virnetsockettest.c | 14 +------------- tests/virnettlscontexttest.c | 14 +------------- tests/virnettlshelpers.c | 14 +------------- tests/virnettlshelpers.h | 14 +------------- tests/virnettlssessiontest.c | 14 +------------- tests/virnetworkportxml2xmltest.c | 14 +------------- tests/virnumamock.c | 14 +------------- tests/virnwfilterbindingxml2xmltest.c | 14 +------------- tests/virpcimock.c | 14 +------------- tests/virpcitest.c | 14 +------------- tests/virpolkittest.c | 14 +------------- tests/virportallocatormock.c | 14 +------------- tests/virportallocatortest.c | 14 +------------- tests/virprocessmock.c | 14 +------------- tests/virrandommock.c | 14 +------------- tests/virrotatingfiletest.c | 14 +------------- tests/virschematest.c | 14 +------------- tests/virscsitest.c | 14 +------------- tests/virsh-auth | 14 +------------- tests/virsh-checkpoint | 14 +------------- tests/virsh-cpuset | 14 +------------- tests/virsh-optparse | 14 +------------- tests/virsh-read-bufsiz | 14 +------------- tests/virsh-read-non-seekable | 14 +------------- tests/virsh-schedinfo | 14 +------------- tests/virsh-self-test | 14 +------------- tests/virsh-snapshot | 14 +------------- tests/virsh-start | 14 +------------- tests/virsh-undefine | 14 +------------- tests/virsh-vcpupin | 14 +------------- tests/virstoragetest.c | 14 +------------- tests/virstorageutiltest.c | 14 +------------- tests/virstringtest.c | 14 +------------- tests/virsystemdtest.c | 14 +------------- tests/virtestmock.c | 14 +------------- tests/virtimetest.c | 14 +------------- tests/virtypedparamtest.c | 14 +------------- tests/viruritest.c | 14 +------------- tests/virusbmock.c | 14 +------------- tests/virusbtest.c | 14 +------------- tests/vmwarevertest.c | 14 +------------- tests/vshtabletest.c | 14 +------------- tests/xlconfigtest.c | 14 +------------- tests/xmconfigtest.c | 14 +------------- tools/libvirt-guests.sh.in | 14 +------------- tools/nss/libvirt_nss.c | 14 +------------- tools/nss/libvirt_nss.h | 14 +------------- tools/nss/libvirt_nss_leases.c | 14 +------------- tools/nss/libvirt_nss_leases.h | 14 +------------- tools/nss/libvirt_nss_macs.c | 14 +------------- tools/nss/libvirt_nss_macs.h | 14 +------------- tools/virsh-backup.c | 14 +------------- tools/virsh-backup.h | 14 +------------- tools/virsh-checkpoint.c | 14 +------------- tools/virsh-checkpoint.h | 14 +------------- tools/virsh-completer-checkpoint.c | 14 +------------- tools/virsh-completer-checkpoint.h | 14 +------------- tools/virsh-completer-domain.c | 14 +------------- tools/virsh-completer-domain.h | 14 +------------- tools/virsh-completer-host.c | 14 +------------- tools/virsh-completer-host.h | 14 +------------- tools/virsh-completer-interface.c | 14 +------------- tools/virsh-completer-interface.h | 14 +------------- tools/virsh-completer-network.c | 14 +------------- tools/virsh-completer-network.h | 14 +------------- tools/virsh-completer-nodedev.c | 14 +------------- tools/virsh-completer-nodedev.h | 14 +------------- tools/virsh-completer-nwfilter.c | 14 +------------- tools/virsh-completer-nwfilter.h | 14 +------------- tools/virsh-completer-pool.c | 14 +------------- tools/virsh-completer-pool.h | 14 +------------- tools/virsh-completer-secret.c | 14 +------------- tools/virsh-completer-secret.h | 14 +------------- tools/virsh-completer-snapshot.c | 14 +------------- tools/virsh-completer-snapshot.h | 14 +------------- tools/virsh-completer-volume.c | 14 +------------- tools/virsh-completer-volume.h | 14 +------------- tools/virsh-completer.c | 14 +------------- tools/virsh-completer.h | 14 +------------- tools/virsh-console.c | 14 +------------- tools/virsh-console.h | 14 +------------- tools/virsh-domain-monitor.c | 14 +------------- tools/virsh-domain-monitor.h | 14 +------------- tools/virsh-domain.c | 14 +------------- tools/virsh-domain.h | 14 +------------- tools/virsh-edit.c | 14 +------------- tools/virsh-host.c | 14 +------------- tools/virsh-host.h | 14 +------------- tools/virsh-interface.c | 14 +------------- tools/virsh-interface.h | 14 +------------- tools/virsh-network.c | 14 +------------- tools/virsh-network.h | 14 +------------- tools/virsh-nodedev.c | 14 +------------- tools/virsh-nodedev.h | 14 +------------- tools/virsh-nwfilter.c | 14 +------------- tools/virsh-nwfilter.h | 14 +------------- tools/virsh-pool.c | 14 +------------- tools/virsh-pool.h | 14 +------------- tools/virsh-secret.c | 14 +------------- tools/virsh-secret.h | 14 +------------- tools/virsh-snapshot.c | 14 +------------- tools/virsh-snapshot.h | 14 +------------- tools/virsh-util.c | 14 +------------- tools/virsh-util.h | 14 +------------- tools/virsh-volume.c | 14 +------------- tools/virsh-volume.h | 14 +------------- tools/virsh.c | 14 +------------- tools/virsh.h | 14 +------------- tools/virt-admin-completer.c | 14 +------------- tools/virt-admin-completer.h | 14 +------------- tools/virt-admin.c | 14 +------------- tools/virt-admin.h | 14 +------------- tools/virt-host-validate-bhyve.c | 14 +------------- tools/virt-host-validate-bhyve.h | 14 +------------- tools/virt-host-validate-common.c | 14 +------------- tools/virt-host-validate-common.h | 14 +------------- tools/virt-host-validate-lxc.c | 14 +------------- tools/virt-host-validate-lxc.h | 14 +------------- tools/virt-host-validate-qemu.c | 14 +------------- tools/virt-host-validate-qemu.h | 14 +------------- tools/virt-host-validate.c | 14 +------------- tools/virt-login-shell-helper.c | 14 +------------- tools/virt-login-shell.c | 14 +------------- tools/virt-pki-validate.in | 14 +------------- tools/virt-sanlock-cleanup.in | 14 +------------- tools/virt-xml-validate.in | 13 +------------ tools/vsh-table.c | 14 +------------- tools/vsh-table.h | 14 +------------- tools/vsh.c | 14 +------------- tools/vsh.h | 14 +------------- tools/wireshark/src/packet-libvirt.c | 14 +------------- tools/wireshark/src/packet-libvirt.h | 14 +------------- tools/wireshark/util/genxdrstub.pl | 14 +------------- 1051 files changed, 1051 insertions(+), 13661 deletions(-) -- 2.26.2

5 28

[PATCH 0/4] Don't leak /dev/mapper/control to QEMU
by Michal Privoznik 10 Aug '20

10 Aug '20

These were sent to the libvirt-security list, where they were reviewed. And before that, I've sent them to the public list: https://www.redhat.com/archives/libvir-list/2020-July/msg01500.html Anyway, I'm resending here for future reference. Patches are merged so no need to review. We are still using libdevmapper after these in src/storage/storage_backend_mpath.c and thus I'm not removing configure check. But in time for the next release I will look into it. Michal Prívozník (4): virdevmapper.c: Join two WITH_DEVMAPPER sections together virDevMapperGetTargetsImpl: Use VIR_AUTOSTRINGLIST virdevmapper: Don't use libdevmapper to obtain dependencies virDevMapperGetTargets: Don't ignore EBADF po/POTFILES.in | 1 + src/qemu/qemu_cgroup.c | 2 +- src/qemu/qemu_domain.c | 4 +- src/util/virdevmapper.c | 337 +++++++++++++++++++++++++++------------- 4 files changed, 232 insertions(+), 112 deletions(-) -- 2.26.2

4 8

[PATCH v2 0/5] Further Debian/Ubuntu Apparmor Delta
by Christian Ehrhardt 10 Aug '20

10 Aug '20

Hi, I don't even remember which number of submissions that is #5 maybe? Anyway - I'm hereby continuing to bring Debian and Ubuntu apparmor Delta into upstream libvirt. I have kept out all patches that are either Distro-specific or we ran into trouble/discussions in the past. But there are enough left for a new submission. I have kept the most-original (read the earliest - as some patches appeared in Ubuntu and later with a different Author in Debian) patch author that I could find intact and git-send-email should auto-cc them. I added some more bug links and descriptions so one can understand the case a commit tries to fix without knowing too much context. Update since v1: - drop a few commits that in discussion turned out to be not/no-more needed - fixed a few typos - added the ack's that I received by Jamie Strandboge Christian Ehrhardt (1): apparmor: let qemu load old shared objects after upgrades Jamie Strandboge (1): apparmor: read only access to overcommit_memory Sam Hartman (1): apparmor: allow default pki path Stefan Bader (2): apparmor: allow libvirtd to call pygrub apparmor: qemu access to @{PROC}/*/auxv for hw_cap src/security/apparmor/libvirt-qemu | 10 ++++++++++ src/security/apparmor/usr.sbin.libvirtd.in | 1 + 2 files changed, 11 insertions(+) -- 2.27.0

2 8

[PATCH] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer
by Jin Yan 10 Aug '20

10 Aug '20

From 55fce33e9cf2d5ea58ebc44b4d78f9c12122fdcb Mon Sep 17 00:00:00 2001 From: Jin Yan <jinyan12(a)huawei.com> Date: Fri, 7 Aug 2020 15:59:45 +0800 Subject: [PATCH] virnetserver: fix some memory leaks in virNetTLSContextReloadForServer These leaks were introduced in commit 15d280fa97b0, use g_autofree for all cert_path pointers. Signed-off-by: Jin Yan <jinyan12(a)huawei.com> --- src/rpc/virnettlscontext.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/rpc/virnettlscontext.c b/src/rpc/virnettlscontext.c index 168f3010ae..37564db14e 100644 --- a/src/rpc/virnettlscontext.c +++ b/src/rpc/virnettlscontext.c @@ -921,10 +921,10 @@ int virNetTLSContextReloadForServer(virNetTLSContextPtr ctxt, { gnutls_certificate_credentials_t x509credBak; int err; - char *cacert = NULL; - char *cacrl = NULL; - char *cert = NULL; - char *key = NULL; + g_autofree char *cacert = NULL; + g_autofree char *cacrl = NULL; + g_autofree char *cert = NULL; + g_autofree char *key = NULL; x509credBak = ctxt->x509cred; ctxt->x509cred = NULL; -- 2.23.0

2 2

[PATCH 0/2] qemu: Add a last-resort warning if object-add/device_add are QAPIfied
by Peter Krempa 08 Aug '20

08 Aug '20

See patch 2/2. Peter Krempa (2): testutilsqemuschema: Add template checker for schema entries qemumonitorjsontest: Add a last-resort warning if object-add/device_add are QAPIfied tests/qemumonitorjsontest.c | 53 +++++++++++++++++ tests/testutilsqemuschema.c | 115 ++++++++++++++++++++++++++++++++++++ tests/testutilsqemuschema.h | 5 ++ 3 files changed, 173 insertions(+) -- 2.26.2

2 3

[libvirt PATCH] Adds e1000e/vmxnet3 Vnet_hdr suuport
by Patrick Magauran 08 Aug '20

08 Aug '20

Libvirt bases its decision about whether to apply the vnet_hdr flag to the tap interface on whether or not the selected model is VirtIO. Originally, VirtIO was the only model to support the vnet_hdr in QEMU; however, the e1000e & vmxnet3 adapters also support it(seemingly from introduction based on commits). This passes the whole packet to the host, reducing emulation overhead and improving performance. Signed-off-by: Patrick Magauran <patmagauran.j(a)gmail.com> --- src/conf/domain_conf.c | 8 +++++++- src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 1 + src/qemu/qemu_interface.c | 8 ++++---- 4 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 69e0439e7e..cb184110f7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -30981,7 +30981,13 @@ virDomainNetIsVirtioModel(const virDomainNetDef *net) net->model == VIR_DOMAIN_NET_MODEL_VIRTIO_TRANSITIONAL || net->model == VIR_DOMAIN_NET_MODEL_VIRTIO_NON_TRANSITIONAL); } - +bool +virDomainNetIsVnetCompatModel(const virDomainNetDef *net) +{ + return (virDomainNetIsVirtioModel(net) || + net->model == VIR_DOMAIN_NET_MODEL_E1000E || + net->model == VIR_DOMAIN_NET_MODEL_VMXNET3); +} /* Return listens[i] from the appropriate union for the graphics * type, or NULL if this is an unsuitable type, or the index is out of diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 011bf66cb4..cbc46fdf78 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -3371,6 +3371,7 @@ const char *virDomainNetGetModelString(const virDomainNetDef *net); int virDomainNetSetModelString(virDomainNetDefPtr et, const char *model); bool virDomainNetIsVirtioModel(const virDomainNetDef *net); +bool virDomainNetIsVnetCompatModel(const virDomainNetDef *net); int virDomainNetAppendIPAddress(virDomainNetDefPtr def, const char *address, int family, diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 01c2e710cd..2b64042dd2 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -525,6 +525,7 @@ virDomainNetGetActualVlan; virDomainNetGetModelString; virDomainNetInsert; virDomainNetIsVirtioModel; +virDomainNetIsVnetCompatModel; virDomainNetModelTypeFromString; virDomainNetModelTypeToString; virDomainNetNotifyActualDevice; diff --git a/src/qemu/qemu_interface.c b/src/qemu/qemu_interface.c index ffec992596..8397ed8645 100644 --- a/src/qemu/qemu_interface.c +++ b/src/qemu/qemu_interface.c @@ -255,7 +255,7 @@ qemuInterfaceDirectConnect(virDomainDefPtr def, virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); unsigned int macvlan_create_flags = VIR_NETDEV_MACVLAN_CREATE_WITH_TAP; - if (virDomainNetIsVirtioModel(net)) + if (virDomainNetIsVnetCompatModel(net)) macvlan_create_flags |= VIR_NETDEV_MACVLAN_VNET_HDR; if (virNetDevMacVLanCreateWithVPortProfile(net->ifname, @@ -417,7 +417,7 @@ qemuInterfaceEthernetConnect(virDomainDefPtr def, } } - if (virDomainNetIsVirtioModel(net)) + if (virDomainNetIsVnetCompatModel(net)) tap_create_flags |= VIR_NETDEV_TAP_CREATE_VNET_HDR; if (net->managed_tap == VIR_TRISTATE_BOOL_NO) { @@ -436,7 +436,7 @@ qemuInterfaceEthernetConnect(virDomainDefPtr def, if (virNetDevMacVLanTapOpen(net->ifname, tapfd, tapfdSize) < 0) goto cleanup; if (virNetDevMacVLanTapSetup(tapfd, tapfdSize, - virDomainNetIsVirtioModel(net)) < 0) { + virDomainNetIsVnetCompatModel(net)) < 0) { goto cleanup; } } else { @@ -559,7 +559,7 @@ qemuInterfaceBridgeConnect(virDomainDefPtr def, template_ifname = true; } - if (virDomainNetIsVirtioModel(net)) + if (virDomainNetIsVnetCompatModel(net)) tap_create_flags |= VIR_NETDEV_TAP_CREATE_VNET_HDR; if (driver->privileged) { -- 2.26.2

4 3

[libvirt PATCH 0/3] some vcpupin/emulatorpin/iothreadpin fixes
by Pavel Hrdina 07 Aug '20

07 Aug '20

We should really unify the code and create helpers used by all of these to prevent all of the bugs fixed by this series. It started by failing libvirt-dbus test suite. After fixing it I checked other relevant APIs and drivers and managed to find other issues. Pavel Hrdina (3): conf: fix detection of available host CPUs for vcpupin test: fix emulator pin info in test driver qemu: consider available CPUs in iothread info output src/conf/domain_conf.c | 18 +++++------------- src/conf/domain_conf.h | 4 ++-- src/libxl/libxl_driver.c | 7 ++++++- src/qemu/qemu_driver.c | 13 ++++++------- src/test/test_driver.c | 12 ++++++++---- 5 files changed, 27 insertions(+), 27 deletions(-) -- 2.26.2

2 6

[PATCH] remote: use SocketMode=0600 when polkit is not compiled
by Daniel P. Berrangé 07 Aug '20

07 Aug '20

The systemd .socket unit files we ship for libvirt daemons use SocketMode=0666 on the assumption that libvirt is built with polkit which provides access control. Some people, however, may have explicitly turned off polkit at build time and not realize that leaves them insecure unless they also change the SocketMode. This addresses that problem by making the SocketMode default to 0600 when polkit is disabled at compile time. Note we cannot automatically fix the case where the user compiles polkit, but then overrides the libvirtd.conf defaults to disable polkit. This is what lead to CVE-2020-15708 in Ubuntu 20.10. We can at least improve the inline comments in the config file to give a clearer warning though, which may have helped avoid the mistaken config. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/meson.build | 5 +++++ src/remote/libvirtd.conf.in | 38 ++++++++++++++++++++++++++--------- src/remote/libvirtd.socket.in | 2 +- 3 files changed, 35 insertions(+), 10 deletions(-) diff --git a/src/meson.build b/src/meson.build index b1c9993bc0..fd23fc55a8 100644 --- a/src/meson.build +++ b/src/meson.build @@ -776,6 +776,11 @@ if conf.has('WITH_LIBVIRTD') unit_conf.set('service', unit['service']) unit_conf.set('sockprefix', unit['sockprefix']) unit_conf.set('deps', unit.get('deps', '')) + if conf.has('WITH_POLKIT') + unit_conf.set('mode', '0666') + else + unit_conf.set('mode', '0600') + endif configure_file( input: unit['service_in'], diff --git a/src/remote/libvirtd.conf.in b/src/remote/libvirtd.conf.in index 2607fbad86..1615f33502 100644 --- a/src/remote/libvirtd.conf.in +++ b/src/remote/libvirtd.conf.in @@ -127,6 +127,8 @@ # # Authentication. # +# There are choices available: +# # - none: do not perform auth checks. If you can connect to the # socket you are allowed. This is suitable if there are # restrictions on connecting to the socket (eg, UNIX @@ -144,21 +146,39 @@ # full read/write access (aka sudo like), while anyone # is allowed read/only access. # + # Set an authentication scheme for UNIX read-only sockets +# # By default socket permissions allow anyone to connect # -# To restrict monitoring of domains you may wish to enable -# an authentication mechanism here +# If libvirt was compiled without support for 'polkit', then +# no access control checks are done, but libvirt still only +# allows execution of APIs which don't change state. +# +# If libvirt was compiled with support for 'polkit', then +# the libvirt socket will perform a check with polkit after +# connections. The default policy still allows any local +# user access. +# +# To restrict monitoring of domains you may wish to either +# enable 'sasl' here, or change the polkit policy definition. #auth_unix_ro = "none" -# Set an authentication scheme for UNIX read-write sockets -# By default socket permissions only allow root. If PolicyKit -# support was compiled into libvirt, the default will be to -# use 'polkit' auth. +# Set an authentication scheme for UNIX read-write sockets. +# +# If libvirt was compiled without support for 'polkit', then +# the systemd .socket files will use SocketMode=0600 by default +# thus only allowing root user to connect, and 'auth_unix_rw' +# will default to 'none'. +# +# If libvirt was compiled with support for 'polkit', then +# the systemd .socket files will use SocketMode=0666 which +# allows any user to connect and 'auth_iunix_rw' will default +# to 'polkit'. If you disable use of 'polkit' here, then it +# is essential to change the systemd SocketMode parameter +# back to 0600, to avoid an insecure configuration. # -# If the unix_sock_rw_perms are changed you may wish to enable -# an authentication mechanism here -#auth_unix_rw = "none" +#auth_unix_rw = "polkit" @CUT_ENABLE_IP@ # Change the authentication scheme for TCP sockets. diff --git a/src/remote/libvirtd.socket.in b/src/remote/libvirtd.socket.in index df36df2125..85b4aa800a 100644 --- a/src/remote/libvirtd.socket.in +++ b/src/remote/libvirtd.socket.in @@ -8,7 +8,7 @@ Before=@service@.service # when using systemd version < 227 ListenStream=@runstatedir@/libvirt/@sockprefix@-sock Service=@service@.service -SocketMode=0666 +SocketMode=@mode@ [Install] WantedBy=sockets.target -- 2.25.4

2 1

[PATCH] qemu: remove use of gettid() syscall
by Daniel P. Berrangé 07 Aug '20

07 Aug '20

This is not expose in most historical versions of glibc, nor non-glibc impls. We must use our wrapper API instead. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as build fix src/qemu/qemu_shim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_shim.c b/src/qemu/qemu_shim.c index 4c06f15779..ef0ba086b5 100644 --- a/src/qemu/qemu_shim.c +++ b/src/qemu/qemu_shim.c @@ -176,8 +176,8 @@ int main(int argc, char **argv) } if (verbose) - g_printerr("%s: %lld: initializing libvirt %d\n", - argv[0], deltams(), gettid()); + g_printerr("%s: %lld: initializing libvirt %llu\n", + argv[0], deltams(), virThreadSelfID()); if (virInitialize() < 0) { g_printerr("%s: cannot initialize libvirt\n", argv[0]); -- 2.25.4

1 0

[PATCH v3 0/5] qemu: Support rbd namespace attribute
by Han Han 07 Aug '20

07 Aug '20

Diff from v2: - rebase to master - update some qemu capabilities tests Test results of this patch series on qemu-5.0.0 and librbd1-14.2.8: disk xml: <disk type='network' device='disk'> <driver name='qemu' type='raw'/> <auth username='admin'> <secret type='ceph' usage='ceph_example'/> </auth> <source protocol='rbd' name='rbd/1' namespace='hhan'> <host name='CEPH_MON'/> </source> <target dev='vde' bus='virtio'/> </disk> Live attach and detach the disk: ➜ ~ virsh attach-device new /tmp/ceph-ns.xml Device attached successfully ➜ ~ virsh dumpxml new|xmllint --xpath //disk - <disk type="file" device="disk"> <driver name="qemu" type="qcow2"/> <source file="/var/lib/libvirt/images/new.qcow2" index="2"/> <backingStore/> <target dev="vda" bus="virtio"/> <serial>WD-WMAP9A966149</serial> <alias name="virtio-disk0"/> <address type="pci" domain="0x0000" bus="0x02" slot="0x00" function="0x0"/> </disk><disk type="network" device="disk"> <driver name="qemu" type="raw"/> <auth username="admin"> <secret type="ceph" usage="ceph_example"/> </auth> <source protocol="rbd" name="rbd/1" namespace="hhan" index="3"> <host name="CEPH_MON"/> </source> <target dev="vde" bus="virtio"/> <alias name="virtio-disk4"/> <address type="pci" domain="0x0000" bus="0x03" slot="0x00" function="0x0"/> </disk> ➜ ~ virsh detach-device new /tmp/ceph-ns.xml Device detached successfully ➜ ~ virsh dumpxml new|xmllint --xpath //disk - <disk type="file" device="disk"> <driver name="qemu" type="qcow2"/> <source file="/var/lib/libvirt/images/new.qcow2" index="2"/> <backingStore/> <target dev="vda" bus="virtio"/> <serial>WD-WMAP9A966149</serial> <alias name="virtio-disk0"/> <address type="pci" domain="0x0000" bus="0x02" slot="0x00" function="0x0"/> </disk> It also works when start VM with this disk. And tests pass when it is tested with -blockdev disabled: <domain type='kvm' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> [...] <qemu:capabilities> <qemu:del capability='blockdev'/> <qemu:add capability='drive'/> </qemu:capabilities> </domain> v2: https://www.redhat.com/archives/libvir-list/2020-April/msg00972.html Han Han (5): qemu_capabilities: Add QEMU_CAPS_RBD_NAMESPACE conf: Support to parse rbd namespace attribute qemu: Implement rbd namespace attribute doc: rng schemas and html doc for rbd namespace attribute news: qemu: Support rbd namespace NEWS.rst | 6 +++ docs/formatdomain.rst | 5 ++- docs/schemas/domaincommon.rng | 3 ++ src/conf/domain_conf.c | 4 ++ src/qemu/qemu_block.c | 1 + src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 3 ++ src/qemu/qemu_command.c | 7 +++- src/util/virstoragefile.h | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + ...k-network-rbd-namespace.x86_64-latest.args | 41 +++++++++++++++++++ .../disk-network-rbd-namespace.xml | 33 +++++++++++++++ tests/qemuxml2argvtest.c | 1 + ...sk-network-rbd-namespace.x86_64-latest.xml | 41 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 19 files changed, 154 insertions(+), 2 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-network-rbd-namespace.xml create mode 100644 tests/qemuxml2xmloutdata/disk-network-rbd-namespace.x86_64-latest.xml -- 2.27.0

2 12

[PATCH 0/3] qemu: implementation of transient option for qcow2 file
by Masayoshi Mizuma 07 Aug '20

07 Aug '20

Hello, This patchset tries to implement transient option for qcow2 file. It gets user available to set <transient/> to the domain xml file like as: <disk type='file' device='disk'> <driver name='qemu' type='qcow2'/> <source file='/var/lib/libvirt/images/guest.qcow2'/> <target dev='vda' bus='virtio'/> <transient/> </disk> Any changes which the Guest does to the disk is dropped when the Guest is shutdowned. Masayoshi Mizuma (3): qemu: implementation of transient option for qcow2 file testutilsqemu: Assign qemu-img path to driver->qemuImgBinary qemublocktest: add test of transient option for qcow2 file src/qemu/qemu_block.c | 71 +++++++++++++++++++ src/qemu/qemu_block.h | 7 ++ src/qemu/qemu_domain.c | 4 ++ src/qemu/qemu_process.c | 3 + src/qemu/qemu_validate.c | 2 +- tests/qemublocktest.c | 10 +++ .../xml2json/qcow2-transient-srconly.json | 9 +++ .../xml2json/qcow2-transient.json | 13 ++++ .../xml2json/qcow2-transient.xml | 13 ++++ tests/testutilsqemu.c | 6 +- 10 files changed, 136 insertions(+), 2 deletions(-) create mode 100644 tests/qemublocktestdata/xml2json/qcow2-transient-srconly.json create mode 100644 tests/qemublocktestdata/xml2json/qcow2-transient.json create mode 100644 tests/qemublocktestdata/xml2json/qcow2-transient.xml -- 2.27.0

3 12

Is the default discard mode to ignore?
by Chris Murphy 07 Aug '20

07 Aug '20

virt-manager 'Discard Mode" defaults to "Hypervisor default" but I'm not sure if there's ever a case where this could translate into on/unmap? What problems could result if the guest OS file system mount option were to default to 'discard'? Is it reasonable to expect discards will be inhibited by default because of Discard Mode's default setting? What I'm concerned about is the use case of either raw or qcow2 backing files that have been fully preallocated. If discards pass through to the backing file, they become sparse files, which may be suboptimal due to ensuing fragmentation. Of course it's a trade off, you also gain efficient storage of the backing file - it consumes only what the guest uses. But I think the more compatible behavior is to not do discards out of the box. Someone who wants sparse backing files, I expect, will (a) create sparse backing files and (b) set discard mode to unmap. Background and genesis of all of this: RFE: kickstart option to control discard configuration https://bugzilla.redhat.com/show_bug.cgi?id=1860720 Thanks, -- Chris Murphy

2 1

[libvirt PATCH 000/351] port libvirt to Meson build system
by Pavel Hrdina 05 Aug '20

05 Aug '20

So I was finally able to produce the patches to port libvirt to Meson. Obviously, it is a lot of changes. It might look that some of the patches could be squashed together but I would rather have it as separated as possible to make the review not that difficult. Once we are done with review I suggest to squash all patches to single patch as it doesn't make sense to keep them separated as it will not be possible to build complete libvirt code by any of the build systems. Trying to achieve that would be even more challenging and the review would me more difficult. The reasoning behind taking this approach is to have 1:1 conversion from autotools to Meson where each patch removes that part from autotools. It serves as a check that nothing is skipped and to make sure that the conversion is complete. As probably most of us know Meson is completely different build system and one of the most challenging things was to deal with the fact that meson doesn't allow user functions and that everything has to be defined before it is used. Patches are available in my Gitlab repo as well: git clone -b meson https://gitlab.com/phrdina/libvirt.git and link to Giltab pipeline: https://gitlab.com/phrdina/libvirt/-/pipelines/167276632 The pipeline is not for the latest version is I tweaked some commit messages. Pavel Hrdina (351): meson: ci: increase git clone depth to 1000 meson: remove automake specific directives meson: drop driver_module configure argument meson: drop loader_nvram build option meson: Makefile: drop cov target meson: syntax-check: drop Makefile and m4 related checks meson: m4: drop not relevant m4 files meson: src/util/virfile: rewrite virFileActivateDirOverrideForProg meson: tests: remove '.libs' from all relevant paths meson: introduce meson build files meson: build everything with PIE meson: move content from config-post.h to config.h meson: set windows variables for AI_ADDRCONFIG meson: generate configmake.h meson: add packager build options meson: add test_suite build option meson: add expensive_tests build option meson: add test_coverage build option meson: add static analysis detection meson: add manywarnings meson: add compiler warnings meson: add linker checks meson: add scripts directory meson: add include directory meson: add functions check meson: add headers check meson: add symbols check meson: add types check meson: add members check meson: add sizeof check meson: add programs checks meson: add iscsiadm as optional program meson: add acl build dependency meson: add AppArmor build dependency meson: add attr build option meson: add audit build dependency meson: add readline build option meson: add bash_completion build options meson: add blkid build dependency meson: add capng build dependency meson: add curl build dependency meson: add dbus build dependency meson: add devmapper build dependency meson: add dlopen build dependency meson: add firewalld build option meson: add firewalld_zone build option meson: add fuse build dependency meson: add GLib dependency meson: add glusterfs build dependency meson: add GnuTLS build dependency meson: add hal build dependency meson: add kvm build dependency meson: add libiscsi build dependency meson: add macvtap build option meson: add libnl build dependency meson: add libparted dependency meson: add libpcap build option meson: add libssh build dependency meson: add libssh2 build dependency meson: add libxml build dependency meson: add netcf build options meson: add nls build dependency meson: add numactl build dependency meson: add openwsman build dependency meson: add parallels-sdk build check meson: add pciaccess build option meson: add polkit build option meson: add rbd build dependency meson: add sanlock build option meson: add sasl build dependency meson: add SELinux build dependency meson: add thread build dependency meson: add udev build options meson: add util build dependency meson: add virtualport build dependency meson: add win32 build dependency meson: add wireshark build dependency meson: add xdr build dependency meson: add yajl build dependency meson: add driver_remote build option meson: add libvirtd driver build option meson: add BHyVe build option meson: add ESX driver build option meson: add Hyper-V driver build option meson: add libxl driver build option meson: add LXC driver build option meson: add OpenVZ driver build option meson: add qemu driver build options meson: add test driver build option meson: add vbox driver build options meson: add VMWare driver build option meson: add Virtuozzo driver build option meson: add secdriver build options meson: add network driver build option meson: add interface driver build option meson: add secrets driver build option meson: add node_device driver check meson: add storage build check meson: add storage dir build option meson: add storage disk build option meson: add storage fs driver build option meson: add storage gluster build option meson: add storage iscsi build option meson: add storage iscsi-direct build option meson: add storage lvm build options meson: add storage mpath build options meson: add storage rbd build option meson: add storage SCSI build option meson: add storage sheepdog build option meson: add storage vstorage build option meson: add storage ZFS build option meson: add chrdev_lock_files build option meson: add debug_logs build option meson: add default_editor build option meson: add driver_modules build check meson: add dtrace build dependency meson: add host_validate build option meson: add init_script build option meson: add login_shell build option meson: add nss build option meson: add numad build option meson: add nwfilter build check meson: add pm_utils build option meson: add sysctl_config build option meson: add tls_priority option meson: add runutf8 env vars and meson-python.sh script meson: introduce src directory meson: src: define secdriver_dep meson: src: build dtrace files meson: src: build libvirt_util.a static lib meson: src: build libvirt_conf.a static lib meson: src: build libvirt_rpc static libs meson: src: build libvirt_access.a static library meson: src: build libvirt_driver_admin.a static lib meson: src: build libvirt_cpu.a static library meson: src: build libvirt_vmx.a static library meson: src: build libvirt_vmware.a static library meson: src: build libvirt_driver_esx.a static library meson: src: build libvirt_driver_hyperv.a static library meson: src: build libvirt_hypervisor.a static library meson: src: build libvirt_openvz.a static library meson: src: build libvirt_test.a static library meson: src: build libvirt_driver_lock.a static library meson: src: build libvirt_driver_log.a static library meson: src: build libvirt_driver_remote.a static library meson: src: build libvirt_security_manager.a static library meson: introduce datatypes sources meson: src: build libvirt_driver.a static library meson: scripts: introduce gen-def-files.sh script meson: scripts: introduce gen-sym-files.sh script meson: src: build libvirt.syms and libvirt.def symbol files meson: src: build libvirt.so library meson: src: install cpu_map data meson: src: build libvirt-qemu.so library meson: src: build libvirt-lxc.so library meson: src: build libvirt-admin.so library meson: src: build libvirt_driver_bhyve_impl.a static library meson: src: build libvirt_driver_libxl_impl.a static library meson: src: build liblockd_impl.a static library meson: src: build libvirt_driver_lxc_impl.a static library meson: src: build libvirt_driver_network_impl.a static library meson: src: build libvirt_driver_nodedev_impl.a static library meson: src: build libvirt_driver_nwfilter_impl.a static library meson: src: build libvirt_driver_qemu_impl.a static library meson: src: build libvirt_storage_driver_impl.a static library meson: src: build libvirt_driver_vbox_impl.a static library meson: src: build libvirt_driver_vz_impl.a static library meson: src: add code to build shared modules meson: src: build libvirt_driver_bhyve.so shared module meson: src: build libvirt_driver_interface.so shared module meson: src: build libvirt_driver_libxl.so shared module meson: src: build libvirt_driver_lxc.so shared module meson: src: build libvirt_driver_network.so shared module meson: src: build libvirt_driver_nodedev.so shared module meson: src: build libvirt_driver_nwfilter.so shared module meson: src: build libvirt_driver_qemu.so shared module meson: src: build libvirt_driver_secret.so shared module meson: src: build libvirt_driver_vbox.so shared module meson: src: build libvirt_driver_vz.so shared module meson: src: build lockd.so shared module meson: src: build sanlock.so shared module meson: src: build libvirt_storage_driver.so shared module meson: src: build libvirt_storage_backedn_fs.so shared module meson: src: build libvirt_storage_file_fs.so shared module meson: src: build libvirt_storage_backend_logical.so shared module meson: src: build libvirt_storage_backend_iscsi.so shared module meson: src: build libvirt_storage_backend_iscsi_direct.so shared module meson: src: build libvirt_storage_backend_scsi.so shared module meson: src: build libvirt_storage_backend_mpath.so shared module meson: src: build libvirt_storage_backend_disk.so shared module meson: src: build libvirt_storage_backend_rbd.so shared module meson: src: build libvirt_storage_backend_sheepdog.so shared module meson: src: build libvirt_storage_*_gluster.so shared modules meson: src: build libvirt_storage_backend_zfs.so shared module meson: src: build libvirt_storage_backend_vstorage.so shared module meson: src: prepare sources for libvirt daemons meson: src: add support for building daemon binaries meson: src: build virtbhyved daemon binary meson: src: build virtinterfaced daemon binary meson: src: build virtxend daemon binary meson: src: build virtlockd daemon binary meson: src: build virtlogd daemon binary meson: src: build virtlxcd daemon binary meson: src: build virtnetworkd daemon binary meson: src: build virtnodedevd daemon binary meson: src: build virtnwfilterd daemon binary meson: src: build virtqemud daemon binary meson: src: build libvirtd daemon binary meson: src: build virtproxyd daemon binary meson: src: build virtsecretd daemon binary meson: src: build virtstoraged daemon binary meson: src: build virtvboxd daemon binary meson: src: build virtvzd daemon binary meson: src: add support for building helpers meson: src: build libvirt_sanlock_helper binary meson: src: build libvirt_lxc binary meson: src: build libvirt_leaseshelper binary meson: src: build virt-qemu-run binary meson: src: build virt-aa-helper binary meson: src: build libvirt_parthelper binary meson: src: build libvirt_iohelper binary meson: src: add support for installing libvirt conf and augeas files meson: src: install libvirt daemon conf and augeas files meson: src: generate libvirt daemon augeas test files meson: src: generate libvirt daemon conf and augeas files meson: src: generate systemd unit files for libvirt daemons meson: src: generate openrc init files meson: src: install libvirt daemon sysconf files meson: src: install empty directories meson: src: generate logrotate files meson: src/access: generate org.libvirt.api.policy meson: src/access: generate libvirt_access*.xml files meson: src/network: install default network xml meson: src/network: install firewalld zone file meson: src/nwfilter: install nwfilter XML files meson: src/remote: install libvirt sysctl config file meson: src/remote: install polkit files meson: src/remote: install libvirtd sasl file meson: src/security: install apparmor profile files meson: src: add check-symfile test meson: src: add check-symsorting meson: src: add check-drivername test meson: src: add check-driverimpls test meson: src: add check-aclrules test meson: src/access: add check-aclperms test meson: src: add check-augeas test meson: src: build libvirt_functions.stp meson: src: add check*protocol tests meson: src: add check-admin-symfile test meson: src: add check-admin-symsorting test meson: src: add check-admin-drivername test meson: src: configure pkg-config files used by run script meson: add tools directory meson: tools: build libvirt_shell.a static library meson: tools: build virt-host-validate binary meson: tools: build virt-login-shell binary meson: tools: build virt-login-shell-helper binary meson: tools: build virsh_win_icon object file meson: tools: build virsh binary meson: tools: build virt-admin binary meson: tools: generate virt-xml-validate script meson: tools: generate virt-pki-validate script meson: tools: generate virt-sanlock-cleanup script meson: tools: generate libvirt-guests.sh script meson: tools: install virt-login-shell.conf meson: tools: install libvirt-guests sysconf file meson: tools: generate libvirt-guests.service systemd unit meson: tools: install bash-completion files meson: tools: introduce nss directory meson: tools: build libnss_libvirt_impl.a static library meson: tools: build libnss_libvirt_guest_impl.a static library meson: tools: build libnss_libvirt.so shared library meson: tools: build libnss_libvirt_guest.so shared_library meson: tools: introduce wireshark directory meson: tools: modify genxdrstub to work with meson meson: tools/wireshark: generate protocol header files meson: tools/wireshark: build libvirt.so wireshark module meson: introduce tests directory meson: tests: build mock shared modules meson: tests: built utils static libraries meson: tests: build commandhelper binary meson: tests: build fake ssh binary meson: tests: add test environment variables meson: tests: build shared libraries meson: tests: add test binaries build support meson: tests: introduce generic tests meson: tests: add linux specific tests meson: tests: add bhyve specific tests meson: tests: add dbus specific tests meson: tests: add ESX specific tests meson: tests: add libvirtd specific tests meson: tests: add libxl specific tests meson: tests: add lxc specific tests meson: tests: add network specific tests meson: tests: add node device specific tests meson: tests: add nss specific tests meson: tests: add nwfilter specific tests meson: tests: add openvz specific tests meson: tests: add qemu specific tests meson: tests: add remote specific tests meson: tests: add selinux specific tests meson: tests: add storage specific tests meson: tests: add storage_fs specific tests meson: tests: add storage_sheepdog specific tests meson: tests: add vbox specific tests meson: tests: add vmware specific tests meson: tests: add vmx specific tests meson: tests: add yajl specific tests meson: tests: add helper binaries build support meson: tests: build helper binaries meson: tests: add test scripts meson: tests: add file access test setup meson: tests: add valgrind test setup meson: examples: build and install example files meson: po: introduce libvirt translation meson: docs: introduce docs directory meson: docs: build api XML files meson: docs: generate docs timestamp meson: docs: generate aclperms.htmlinc meson: docs: introduce docs_rst2html_gen generator meson: docs: introduce meson-html-gen.py helper meson: docs: introduce XSL files meson: docs: build *.html files from *.html.in files meson: docs: build *.html files from *.rst files meson: docs: build hvsupport.html meson: docs: build news.html from news.xml meson: docs: copy asset data to build dir meson: docs/fonts: install font files meson: docs/html: generate libvirt API documentation meson: docs/html: generate admin,lxc and qemu API documentation meson: docs/internals: build html files meson: docs/js: install javascript files meson: docs/kbase: build html files meson: docs/logos: install logo files meson: docs/manpages: install man pages meson: docs/schemas: install RNG schemas meson: docs/html: add html test meson: install pkgconfig files meson: generate and distribute spec files and AUTHORS meson: generate run helper meson: generate developer tooling files meson: add syntax-check meson: update spec file to use meson meson: add rule to build and install only web documentation meson: drop remaining bits from Makefile.am meson: remove unused bits from GNUmakefile meson: drop all unused bits from configure.ac meson: now we can drop all autoconf related gitignore lines meson: adjust our documentation to mention meson instead of autoconf meson: update .gitlab-ci.yml file meson: .gitlab-ci.yml: switch armv7l build to Debian 10 .gitignore | 21 - .gitlab-ci.yml | 71 +- CONTRIBUTING.rst | 9 +- GNUmakefile | 74 - Makefile.am | 180 -- autogen.sh | 53 - build-aux/Makefile.in | 9 + .../Makefile.nonreentrant | 0 build-aux/meson.build | 30 + build-aux/syntax-check.mk | 120 +- ci/aarch64-linux-gnu.meson | 11 + ci/arm-linux-gnueabi.meson | 11 + ci/arm-linux-gnueabihf.meson | 11 + ci/cirrus/build.yml | 12 +- ci/cirrus/libvirt-freebsd-12.vars | 4 +- ci/cirrus/libvirt-macos-1015.vars | 4 +- ci/containers/libvirt-centos-7.Dockerfile | 2 +- ci/containers/libvirt-centos-8.Dockerfile | 4 +- .../libvirt-centos-stream.Dockerfile | 4 +- ...libvirt-debian-10-cross-aarch64.Dockerfile | 5 +- .../libvirt-debian-10-cross-armv6l.Dockerfile | 6 +- .../libvirt-debian-10-cross-armv7l.Dockerfile | 6 +- .../libvirt-debian-10-cross-i686.Dockerfile | 5 +- .../libvirt-debian-10-cross-mips.Dockerfile | 5 +- ...ibvirt-debian-10-cross-mips64el.Dockerfile | 5 +- .../libvirt-debian-10-cross-mipsel.Dockerfile | 5 +- ...libvirt-debian-10-cross-ppc64le.Dockerfile | 5 +- .../libvirt-debian-10-cross-s390x.Dockerfile | 5 +- ci/containers/libvirt-debian-10.Dockerfile | 4 +- ...ibvirt-debian-sid-cross-aarch64.Dockerfile | 5 +- ...libvirt-debian-sid-cross-armv6l.Dockerfile | 6 +- ...libvirt-debian-sid-cross-armv7l.Dockerfile | 6 +- .../libvirt-debian-sid-cross-i686.Dockerfile | 5 +- ...bvirt-debian-sid-cross-mips64el.Dockerfile | 5 +- ...libvirt-debian-sid-cross-mipsel.Dockerfile | 6 +- ...ibvirt-debian-sid-cross-ppc64le.Dockerfile | 5 +- .../libvirt-debian-sid-cross-s390x.Dockerfile | 5 +- ci/containers/libvirt-debian-sid.Dockerfile | 4 +- ci/containers/libvirt-fedora-31.Dockerfile | 4 +- ci/containers/libvirt-fedora-32.Dockerfile | 4 +- ...rt-fedora-rawhide-cross-mingw32.Dockerfile | 4 +- ...rt-fedora-rawhide-cross-mingw64.Dockerfile | 4 +- .../libvirt-fedora-rawhide.Dockerfile | 4 +- ci/containers/libvirt-opensuse-151.Dockerfile | 2 +- ci/containers/libvirt-ubuntu-1804.Dockerfile | 2 +- ci/containers/libvirt-ubuntu-2004.Dockerfile | 4 +- ci/i686-linux-gnu.meson | 11 + ci/mips-linux-gnu.meson | 11 + ci/mips64el-linux-gnuabi64.meson | 11 + ci/mipsel-linux-gnu.meson | 11 + ci/powerpc64le-linux-gnu.meson | 11 + ci/s390x-linux-gnu.meson | 11 + config-post.h => config.h | 25 +- configmake.h.in | 16 + configure.ac | 1063 ------- docs/Makefile.am | 522 ---- docs/advanced-tests.rst | 14 +- docs/best-practices.rst | 2 +- docs/committer-guidelines.rst | 6 +- docs/compiling.html.in | 40 +- docs/fonts/meson.build | 24 + docs/hacking.rst | 4 +- docs/html/meson.build | 101 + docs/internals/meson.build | 35 + docs/js/meson.build | 13 + docs/kbase/meson.build | 44 + docs/logging.html.in | 2 +- docs/logos/meson.build | 31 + docs/manpages/{index.rst => index.rst.in} | 0 .../{libvirtd.rst => libvirtd.rst.in} | 0 docs/manpages/meson.build | 129 + docs/manpages/{virsh.rst => virsh.rst.in} | 0 .../{virt-admin.rst => virt-admin.rst.in} | 0 ...validate.rst => virt-host-validate.rst.in} | 0 ...ogin-shell.rst => virt-login-shell.rst.in} | 0 ...-validate.rst => virt-pki-validate.rst.in} | 0 ...virt-qemu-run.rst => virt-qemu-run.rst.in} | 0 ...leanup.rst => virt-sanlock-cleanup.rst.in} | 0 ...-validate.rst => virt-xml-validate.rst.in} | 0 .../{virtlockd.rst => virtlockd.rst.in} | 0 .../{virtlogd.rst => virtlogd.rst.in} | 0 docs/meson.build | 319 +++ docs/schemas/meson.build | 26 + docs/strategy.html.in | 27 +- docs/windows.html.in | 18 +- examples/Makefile.am | 135 - examples/c/admin/meson.build | 27 + examples/c/domain/meson.build | 24 + examples/c/meson.build | 3 + examples/c/misc/meson.build | 22 + examples/meson.build | 7 + examples/polkit/meson.build | 1 + examples/sh/meson.build | 1 + examples/systemtap/lock-debug.stp | 2 +- examples/systemtap/meson.build | 9 + examples/xml/meson.build | 2 + examples/xml/storage/meson.build | 15 + examples/xml/test/meson.build | 14 + include/libvirt/Makefile.am | 28 - include/libvirt/meson.build | 36 + include/meson.build | 3 + libvirt.spec.in | 203 +- m4/virt-acl.m4 | 37 - m4/virt-apparmor.m4 | 41 - m4/virt-arg.m4 | 154 -- m4/virt-attr.m4 | 13 - m4/virt-audit.m4 | 31 - m4/virt-bash-completion.m4 | 70 - m4/virt-blkid.m4 | 30 - m4/virt-capng.m4 | 30 - m4/virt-chrdev-lock-files.m4 | 52 - m4/virt-compile-pie.m4 | 35 - m4/virt-compile-warnings.m4 | 255 -- m4/virt-curl.m4 | 38 - m4/virt-dbus.m4 | 41 - m4/virt-debug.m4 | 33 - m4/virt-default-editor.m4 | 32 - m4/virt-devmapper.m4 | 32 - m4/virt-dlopen.m4 | 45 - m4/virt-driver-bhyve.m4 | 56 - m4/virt-driver-esx.m4 | 57 - m4/virt-driver-hyperv.m4 | 47 - m4/virt-driver-interface.m4 | 49 - m4/virt-driver-libvirtd.m4 | 33 - m4/virt-driver-libxl.m4 | 74 - m4/virt-driver-lxc.m4 | 74 - m4/virt-driver-modules.m4 | 53 - m4/virt-driver-network.m4 | 51 - m4/virt-driver-openvz.m4 | 42 - m4/virt-driver-qemu.m4 | 132 - m4/virt-driver-remote.m4 | 48 - m4/virt-driver-test.m4 | 33 - m4/virt-driver-vbox.m4 | 44 - m4/virt-driver-vmware.m4 | 33 - m4/virt-driver-vz.m4 | 47 - m4/virt-dtrace.m4 | 45 - m4/virt-external-programs.m4 | 106 - m4/virt-firewalld-zone.m4 | 45 - m4/virt-firewalld.m4 | 43 - m4/virt-fuse.m4 | 30 - m4/virt-glib.m4 | 36 - m4/virt-gluster.m4 | 32 - m4/virt-gnutls.m4 | 30 - m4/virt-hal.m4 | 30 - m4/virt-host-validate.m4 | 43 - m4/virt-init-script.m4 | 61 - m4/virt-lib.m4 | 386 --- m4/virt-libiscsi.m4 | 30 - m4/virt-libnl.m4 | 47 - m4/virt-libpcap.m4 | 62 - m4/virt-libssh.m4 | 51 - m4/virt-libxml.m4 | 36 - m4/virt-linker-no-indirect.m4 | 32 - m4/virt-linker-no-undefined.m4 | 32 - m4/virt-linker-relro.m4 | 35 - m4/virt-loader-nvram.m4 | 49 - m4/virt-login-shell.m4 | 43 - m4/virt-macvtap.m4 | 56 - m4/virt-manywarnings.m4 | 339 --- m4/virt-netcf.m4 | 30 - m4/virt-nls.m4 | 72 - m4/virt-nss.m4 | 86 - m4/virt-numactl.m4 | 34 - m4/virt-numad.m4 | 58 - m4/virt-nwfilter.m4 | 32 - m4/virt-openwsman.m4 | 30 - m4/virt-parted.m4 | 38 - m4/virt-pciaccess.m4 | 30 - m4/virt-pm-utils.m4 | 45 - m4/virt-polkit.m4 | 62 - m4/virt-pthread.m4 | 58 - m4/virt-readline.m4 | 86 - m4/virt-result.m4 | 42 - m4/virt-sanlock.m4 | 47 - m4/virt-sasl.m4 | 30 - m4/virt-secdriver-apparmor.m4 | 50 - m4/virt-secdriver-selinux.m4 | 43 - m4/virt-selinux.m4 | 47 - m4/virt-ssh2.m4 | 30 - m4/virt-storage-dir.m4 | 33 - m4/virt-storage-disk.m4 | 58 - m4/virt-storage-fs.m4 | 89 - m4/virt-storage-gluster.m4 | 43 - m4/virt-storage-iscsi-direct.m4 | 44 - m4/virt-storage-iscsi.m4 | 50 - m4/virt-storage-lvm.m4 | 90 - m4/virt-storage-mpath.m4 | 53 - m4/virt-storage-rbd.m4 | 62 - m4/virt-storage-scsi.m4 | 36 - m4/virt-storage-sheepdog.m4 | 56 - m4/virt-storage-vstorage.m4 | 73 - m4/virt-storage-zfs.m4 | 56 - m4/virt-sysctl.m4 | 43 - m4/virt-tls-priority.m4 | 33 - m4/virt-udev.m4 | 36 - m4/virt-virtualport.m4 | 65 - m4/virt-warnings.m4 | 115 - m4/virt-win-common.m4 | 42 - m4/virt-win-mingw.m4 | 28 - m4/virt-win-symbols.m4 | 40 - m4/virt-win-windres.m4 | 36 - m4/virt-wireshark.m4 | 71 - m4/virt-xdr.m4 | 40 - m4/virt-yajl.m4 | 42 - meson.build | 2461 +++++++++++++++++ meson_options.txt | 104 + po/Makefile.am | 94 - po/meson.build | 35 + run.in | 4 +- scripts/apibuild.py | 26 +- scripts/check-augeas.sh | 12 + scripts/check-file-access.py | 24 +- scripts/check-remote-protocol.py | 75 +- scripts/gen-def-files.sh | 5 + scripts/gen-sym-files.sh | 15 + scripts/install-dirs.sh | 5 + scripts/install-symlink.sh | 7 + scripts/meson-change-perms.sh | 6 + scripts/meson-dist.sh | 6 + scripts/meson-gen-authors.sh | 4 + scripts/meson-html-gen.py | 49 + scripts/meson-install-web.py | 10 + scripts/meson-python.sh | 3 + scripts/meson-timestamp.sh | 8 + scripts/meson.build | 40 + src/Makefile.am | 693 ----- src/access/Makefile.inc.am | 153 - src/access/meson.build | 121 + src/admin/Makefile.inc.am | 146 - src/admin/meson.build | 114 + src/bhyve/Makefile.inc.am | 106 - src/bhyve/meson.build | 62 + src/conf/Makefile.inc.am | 191 -- src/conf/meson.build | 110 + src/cpu/Makefile.inc.am | 27 - src/cpu/meson.build | 21 + src/cpu_map/Makefile.inc.am | 80 - src/cpu_map/meson.build | 75 + src/driver.c | 2 +- src/esx/Makefile.inc.am | 91 - src/esx/meson.build | 67 + src/hyperv/Makefile.inc.am | 59 - src/hyperv/meson.build | 43 + src/hypervisor/Makefile.inc.am | 20 - src/hypervisor/meson.build | 23 + src/interface/Makefile.inc.am | 125 - src/interface/meson.build | 64 + src/libvirt-lxc.pc.in | 2 +- src/libvirt-qemu.pc.in | 2 +- src/libvirt.pc.in | 2 +- src/libxl/Makefile.inc.am | 163 -- src/libxl/meson.build | 89 + src/locking/Makefile.inc.am | 298 -- src/locking/lock_manager.c | 2 +- src/locking/meson.build | 249 ++ src/logging/Makefile.inc.am | 147 - src/logging/meson.build | 100 + src/lxc/Makefile.inc.am | 293 -- src/lxc/meson.build | 190 ++ src/meson.build | 969 +++++++ src/network/Makefile.inc.am | 197 -- src/network/{default.xml => default.xml.in} | 0 src/network/meson.build | 129 + src/node_device/Makefile.inc.am | 151 - src/node_device/meson.build | 77 + src/nwfilter/Makefile.inc.am | 134 - src/nwfilter/meson.build | 73 + src/nwfilter/xml/meson.build | 22 + src/openvz/Makefile.inc.am | 30 - src/openvz/meson.build | 28 + src/qemu/Makefile.inc.am | 268 -- src/{ => qemu}/libvirt_qemu_probes.d | 0 src/qemu/meson.build | 173 ++ src/remote/Makefile.inc.am | 490 ---- src/remote/meson.build | 288 ++ ...n.target.in => virt-guest-shutdown.target} | 0 src/rpc/Makefile.inc.am | 144 - src/rpc/meson.build | 136 + src/secret/Makefile.inc.am | 110 - src/secret/meson.build | 53 + src/security/Makefile.inc.am | 142 - src/security/apparmor/meson.build | 38 + .../usr.lib.libvirt.virt-aa-helper.local | 1 + src/security/meson.build | 57 + src/storage/Makefile.inc.am | 476 ---- src/storage/meson.build | 306 ++ src/storage/storage_backend.c | 2 +- src/test/Makefile.inc.am | 28 - src/test/meson.build | 26 + src/util/Makefile.inc.am | 318 --- src/util/meson.build | 212 ++ src/util/virfile.c | 34 +- src/util/virstoragefilebackend.c | 2 +- src/vbox/Makefile.inc.am | 138 - src/vbox/meson.build | 78 + src/vmware/Makefile.inc.am | 29 - src/vmware/meson.build | 26 + src/vmx/Makefile.inc.am | 24 - src/vmx/meson.build | 28 + src/vz/Makefile.inc.am | 117 - src/vz/meson.build | 68 + tests/Makefile.am | 1571 ----------- tests/meson.build | 686 +++++ tests/securityselinuxlabeltest.c | 2 +- tests/securityselinuxtest.c | 2 +- tests/shunloadtest.c | 4 +- tests/testutils.c | 2 +- tests/testutils.h | 2 +- tests/viridentitytest.c | 2 +- tests/virsh-optparse | 58 +- tests/virsh-schedinfo | 12 +- tests/virt-aa-helper-test | 2 +- tests/virtestmock.c | 2 +- tools/Makefile.am | 529 ---- tools/bash-completion/meson.build | 13 + tools/meson.build | 292 ++ tools/nss/meson.build | 92 + tools/wireshark/meson.build | 3 + tools/wireshark/src/libvirt/meson.build | 20 + tools/wireshark/src/meson.build | 17 + tools/wireshark/util/genxdrstub.pl | 9 +- 321 files changed, 9526 insertions(+), 15979 deletions(-) delete mode 100644 GNUmakefile delete mode 100644 Makefile.am delete mode 100755 autogen.sh create mode 100644 build-aux/Makefile.in rename Makefile.nonreentrant => build-aux/Makefile.nonreentrant (100%) create mode 100644 build-aux/meson.build create mode 100644 ci/aarch64-linux-gnu.meson create mode 100644 ci/arm-linux-gnueabi.meson create mode 100644 ci/arm-linux-gnueabihf.meson create mode 100644 ci/i686-linux-gnu.meson create mode 100644 ci/mips-linux-gnu.meson create mode 100644 ci/mips64el-linux-gnuabi64.meson create mode 100644 ci/mipsel-linux-gnu.meson create mode 100644 ci/powerpc64le-linux-gnu.meson create mode 100644 ci/s390x-linux-gnu.meson rename config-post.h => config.h (65%) create mode 100644 configmake.h.in delete mode 100644 configure.ac delete mode 100644 docs/Makefile.am create mode 100644 docs/fonts/meson.build create mode 100644 docs/html/meson.build create mode 100644 docs/internals/meson.build create mode 100644 docs/js/meson.build create mode 100644 docs/kbase/meson.build create mode 100644 docs/logos/meson.build rename docs/manpages/{index.rst => index.rst.in} (100%) rename docs/manpages/{libvirtd.rst => libvirtd.rst.in} (100%) create mode 100644 docs/manpages/meson.build rename docs/manpages/{virsh.rst => virsh.rst.in} (100%) rename docs/manpages/{virt-admin.rst => virt-admin.rst.in} (100%) rename docs/manpages/{virt-host-validate.rst => virt-host-validate.rst.in} (100%) rename docs/manpages/{virt-login-shell.rst => virt-login-shell.rst.in} (100%) rename docs/manpages/{virt-pki-validate.rst => virt-pki-validate.rst.in} (100%) rename docs/manpages/{virt-qemu-run.rst => virt-qemu-run.rst.in} (100%) rename docs/manpages/{virt-sanlock-cleanup.rst => virt-sanlock-cleanup.rst.in} (100%) rename docs/manpages/{virt-xml-validate.rst => virt-xml-validate.rst.in} (100%) rename docs/manpages/{virtlockd.rst => virtlockd.rst.in} (100%) rename docs/manpages/{virtlogd.rst => virtlogd.rst.in} (100%) create mode 100644 docs/meson.build create mode 100644 docs/schemas/meson.build delete mode 100644 examples/Makefile.am create mode 100644 examples/c/admin/meson.build create mode 100644 examples/c/domain/meson.build create mode 100644 examples/c/meson.build create mode 100644 examples/c/misc/meson.build create mode 100644 examples/meson.build create mode 100644 examples/polkit/meson.build create mode 100644 examples/sh/meson.build create mode 100644 examples/systemtap/meson.build create mode 100644 examples/xml/meson.build create mode 100644 examples/xml/storage/meson.build create mode 100644 examples/xml/test/meson.build delete mode 100644 include/libvirt/Makefile.am create mode 100644 include/libvirt/meson.build create mode 100644 include/meson.build delete mode 100644 m4/virt-acl.m4 delete mode 100644 m4/virt-apparmor.m4 delete mode 100644 m4/virt-arg.m4 delete mode 100644 m4/virt-attr.m4 delete mode 100644 m4/virt-audit.m4 delete mode 100644 m4/virt-bash-completion.m4 delete mode 100644 m4/virt-blkid.m4 delete mode 100644 m4/virt-capng.m4 delete mode 100644 m4/virt-chrdev-lock-files.m4 delete mode 100644 m4/virt-compile-pie.m4 delete mode 100644 m4/virt-compile-warnings.m4 delete mode 100644 m4/virt-curl.m4 delete mode 100644 m4/virt-dbus.m4 delete mode 100644 m4/virt-debug.m4 delete mode 100644 m4/virt-default-editor.m4 delete mode 100644 m4/virt-devmapper.m4 delete mode 100644 m4/virt-dlopen.m4 delete mode 100644 m4/virt-driver-bhyve.m4 delete mode 100644 m4/virt-driver-esx.m4 delete mode 100644 m4/virt-driver-hyperv.m4 delete mode 100644 m4/virt-driver-interface.m4 delete mode 100644 m4/virt-driver-libvirtd.m4 delete mode 100644 m4/virt-driver-libxl.m4 delete mode 100644 m4/virt-driver-lxc.m4 delete mode 100644 m4/virt-driver-modules.m4 delete mode 100644 m4/virt-driver-network.m4 delete mode 100644 m4/virt-driver-openvz.m4 delete mode 100644 m4/virt-driver-qemu.m4 delete mode 100644 m4/virt-driver-remote.m4 delete mode 100644 m4/virt-driver-test.m4 delete mode 100644 m4/virt-driver-vbox.m4 delete mode 100644 m4/virt-driver-vmware.m4 delete mode 100644 m4/virt-driver-vz.m4 delete mode 100644 m4/virt-dtrace.m4 delete mode 100644 m4/virt-external-programs.m4 delete mode 100644 m4/virt-firewalld-zone.m4 delete mode 100644 m4/virt-firewalld.m4 delete mode 100644 m4/virt-fuse.m4 delete mode 100644 m4/virt-glib.m4 delete mode 100644 m4/virt-gluster.m4 delete mode 100644 m4/virt-gnutls.m4 delete mode 100644 m4/virt-hal.m4 delete mode 100644 m4/virt-host-validate.m4 delete mode 100644 m4/virt-init-script.m4 delete mode 100644 m4/virt-lib.m4 delete mode 100644 m4/virt-libiscsi.m4 delete mode 100644 m4/virt-libnl.m4 delete mode 100644 m4/virt-libpcap.m4 delete mode 100644 m4/virt-libssh.m4 delete mode 100644 m4/virt-libxml.m4 delete mode 100644 m4/virt-linker-no-indirect.m4 delete mode 100644 m4/virt-linker-no-undefined.m4 delete mode 100644 m4/virt-linker-relro.m4 delete mode 100644 m4/virt-loader-nvram.m4 delete mode 100644 m4/virt-login-shell.m4 delete mode 100644 m4/virt-macvtap.m4 delete mode 100644 m4/virt-manywarnings.m4 delete mode 100644 m4/virt-netcf.m4 delete mode 100644 m4/virt-nls.m4 delete mode 100644 m4/virt-nss.m4 delete mode 100644 m4/virt-numactl.m4 delete mode 100644 m4/virt-numad.m4 delete mode 100644 m4/virt-nwfilter.m4 delete mode 100644 m4/virt-openwsman.m4 delete mode 100644 m4/virt-parted.m4 delete mode 100644 m4/virt-pciaccess.m4 delete mode 100644 m4/virt-pm-utils.m4 delete mode 100644 m4/virt-polkit.m4 delete mode 100644 m4/virt-pthread.m4 delete mode 100644 m4/virt-readline.m4 delete mode 100644 m4/virt-result.m4 delete mode 100644 m4/virt-sanlock.m4 delete mode 100644 m4/virt-sasl.m4 delete mode 100644 m4/virt-secdriver-apparmor.m4 delete mode 100644 m4/virt-secdriver-selinux.m4 delete mode 100644 m4/virt-selinux.m4 delete mode 100644 m4/virt-ssh2.m4 delete mode 100644 m4/virt-storage-dir.m4 delete mode 100644 m4/virt-storage-disk.m4 delete mode 100644 m4/virt-storage-fs.m4 delete mode 100644 m4/virt-storage-gluster.m4 delete mode 100644 m4/virt-storage-iscsi-direct.m4 delete mode 100644 m4/virt-storage-iscsi.m4 delete mode 100644 m4/virt-storage-lvm.m4 delete mode 100644 m4/virt-storage-mpath.m4 delete mode 100644 m4/virt-storage-rbd.m4 delete mode 100644 m4/virt-storage-scsi.m4 delete mode 100644 m4/virt-storage-sheepdog.m4 delete mode 100644 m4/virt-storage-vstorage.m4 delete mode 100644 m4/virt-storage-zfs.m4 delete mode 100644 m4/virt-sysctl.m4 delete mode 100644 m4/virt-tls-priority.m4 delete mode 100644 m4/virt-udev.m4 delete mode 100644 m4/virt-virtualport.m4 delete mode 100644 m4/virt-warnings.m4 delete mode 100644 m4/virt-win-common.m4 delete mode 100644 m4/virt-win-mingw.m4 delete mode 100644 m4/virt-win-symbols.m4 delete mode 100644 m4/virt-win-windres.m4 delete mode 100644 m4/virt-wireshark.m4 delete mode 100644 m4/virt-xdr.m4 delete mode 100644 m4/virt-yajl.m4 create mode 100644 meson.build create mode 100644 meson_options.txt delete mode 100644 po/Makefile.am create mode 100644 po/meson.build create mode 100644 scripts/check-augeas.sh create mode 100755 scripts/gen-def-files.sh create mode 100755 scripts/gen-sym-files.sh create mode 100644 scripts/install-dirs.sh create mode 100644 scripts/install-symlink.sh create mode 100644 scripts/meson-change-perms.sh create mode 100755 scripts/meson-dist.sh create mode 100755 scripts/meson-gen-authors.sh create mode 100755 scripts/meson-html-gen.py create mode 100755 scripts/meson-install-web.py create mode 100755 scripts/meson-python.sh create mode 100755 scripts/meson-timestamp.sh create mode 100644 scripts/meson.build delete mode 100644 src/Makefile.am delete mode 100644 src/access/Makefile.inc.am create mode 100644 src/access/meson.build delete mode 100644 src/admin/Makefile.inc.am create mode 100644 src/admin/meson.build delete mode 100644 src/bhyve/Makefile.inc.am create mode 100644 src/bhyve/meson.build delete mode 100644 src/conf/Makefile.inc.am create mode 100644 src/conf/meson.build delete mode 100644 src/cpu/Makefile.inc.am create mode 100644 src/cpu/meson.build delete mode 100644 src/cpu_map/Makefile.inc.am create mode 100644 src/cpu_map/meson.build delete mode 100644 src/esx/Makefile.inc.am create mode 100644 src/esx/meson.build delete mode 100644 src/hyperv/Makefile.inc.am create mode 100644 src/hyperv/meson.build delete mode 100644 src/hypervisor/Makefile.inc.am create mode 100644 src/hypervisor/meson.build delete mode 100644 src/interface/Makefile.inc.am create mode 100644 src/interface/meson.build delete mode 100644 src/libxl/Makefile.inc.am create mode 100644 src/libxl/meson.build delete mode 100644 src/locking/Makefile.inc.am create mode 100644 src/locking/meson.build delete mode 100644 src/logging/Makefile.inc.am create mode 100644 src/logging/meson.build delete mode 100644 src/lxc/Makefile.inc.am create mode 100644 src/lxc/meson.build create mode 100644 src/meson.build delete mode 100644 src/network/Makefile.inc.am rename src/network/{default.xml => default.xml.in} (100%) create mode 100644 src/network/meson.build delete mode 100644 src/node_device/Makefile.inc.am create mode 100644 src/node_device/meson.build delete mode 100644 src/nwfilter/Makefile.inc.am create mode 100644 src/nwfilter/meson.build create mode 100644 src/nwfilter/xml/meson.build delete mode 100644 src/openvz/Makefile.inc.am create mode 100644 src/openvz/meson.build delete mode 100644 src/qemu/Makefile.inc.am rename src/{ => qemu}/libvirt_qemu_probes.d (100%) create mode 100644 src/qemu/meson.build delete mode 100644 src/remote/Makefile.inc.am create mode 100644 src/remote/meson.build rename src/remote/{virt-guest-shutdown.target.in => virt-guest-shutdown.target} (100%) delete mode 100644 src/rpc/Makefile.inc.am create mode 100644 src/rpc/meson.build delete mode 100644 src/secret/Makefile.inc.am create mode 100644 src/secret/meson.build delete mode 100644 src/security/Makefile.inc.am create mode 100644 src/security/apparmor/meson.build create mode 100644 src/security/apparmor/usr.lib.libvirt.virt-aa-helper.local create mode 100644 src/security/meson.build delete mode 100644 src/storage/Makefile.inc.am create mode 100644 src/storage/meson.build delete mode 100644 src/test/Makefile.inc.am create mode 100644 src/test/meson.build delete mode 100644 src/util/Makefile.inc.am create mode 100644 src/util/meson.build delete mode 100644 src/vbox/Makefile.inc.am create mode 100644 src/vbox/meson.build delete mode 100644 src/vmware/Makefile.inc.am create mode 100644 src/vmware/meson.build delete mode 100644 src/vmx/Makefile.inc.am create mode 100644 src/vmx/meson.build delete mode 100644 src/vz/Makefile.inc.am create mode 100644 src/vz/meson.build delete mode 100644 tests/Makefile.am create mode 100644 tests/meson.build delete mode 100644 tools/Makefile.am create mode 100644 tools/bash-completion/meson.build create mode 100644 tools/meson.build create mode 100644 tools/nss/meson.build create mode 100644 tools/wireshark/meson.build create mode 100644 tools/wireshark/src/libvirt/meson.build create mode 100644 tools/wireshark/src/meson.build -- 2.26.2

11 544

[libvirt PATCH] meson: fix readline detection if there is no pkg-config file
by Pavel Hrdina 05 Aug '20

05 Aug '20

Commit <74416b1d4849ef77ef31de5344dd75f03094434b> added check for rl_completion_quote_character to make sure we have correct readline library. Commit <a9443bc9a9ef451b46306e66ed3b706756fc1414> added inaccurate comment that it's a function. We need to check for generic symbol instead of checking for function. In addition the readline/readline.h file requires stdio.h to by included beforehand which was done in autotools but I dropped it in meson. And lastly the final condition to print error or disable readline was broken as well by replacing the readline_dep every time if readline was not explicitly enabled. Reported-by: Erik Skultety <eskultet(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- meson.build | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index ad269640ba..19b4795527 100644 --- a/meson.build +++ b/meson.build @@ -1268,17 +1268,19 @@ if not readline_dep.found() readline_dep = cc.find_library('readline', required: get_option('readline')) if readline_dep.found() - # This function is present in all reasonable (5.0+) readline versions; + # This variable is present in all reasonable (5.0+) readline versions; # however, the macOS base system contains a library called libedit which # takes over the readline name despite lacking many of its features. We # want to make sure we only enable readline support when linking against # the actual readline library, and the availability of this specific - # functions is as good a witness for that fact as any. - correct_rl = cc.has_function('rl_completion_quote_character', prefix: '#include <readline/readline.h>') - if not correct_rl and get_option('readline').enabled() - error('readline is missing rl_completion_quote_character') - else - readline_dep = dependency('', required: false) + # variable is as good a witness for that fact as any. + correct_rl = cc.has_header_symbol('readline/readline.h', 'rl_completion_quote_character', prefix: '#include <stdio.h>') + if not correct_rl + if get_option('readline').enabled() + error('readline is missing rl_completion_quote_character') + else + readline_dep = dependency('', required: false) + endif endif endif endif -- 2.26.2

2 3

[libvirt PATCH] docs/manpages/meson: fix sanlock detection
by Pavel Hrdina 05 Aug '20

05 Aug '20

In meson.build we define sanlock_dep only if it is available but in addition we add 'WITH_SANLOCK' into conf. Use the presence of 'WITH_SANLOCK' in conf to figure out if we need to install virt-sanlock-cleanup man page. Reported-by: Michal Privoznik <mprivozn(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- docs/manpages/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index 97133adf3a..8295e9e5ea 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -17,7 +17,7 @@ docs_man_files = [ { 'name': 'virt-xml-validate', 'section': '1', 'install': true }, { 'name': 'libvirtd', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, - { 'name': 'virt-sanlock-cleanup', 'section': '8', 'install': sanlock_dep.found() }, + { 'name': 'virt-sanlock-cleanup', 'section': '8', 'install': conf.has('WITH_SANLOCK') }, { 'name': 'virtlockd', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, { 'name': 'virtlogd', 'section': '8', 'install': conf.has('WITH_LIBVIRTD') }, ] -- 2.26.2

2 1

[PATCH] news: Mention the encrypted TLS keys of VxHS are supported in v6.6.0
by Han Han 05 Aug '20

05 Aug '20

Signed-off-by: Han Han <hhan(a)redhat.com> --- NEWS.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index 63ca689b43..1887177b0e 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -47,7 +47,7 @@ v6.6.0 (2020-08-02) Specifying a virtualHW version greater or equal to 7 (ESXi 4.0) will allow you to use up to 10 NICs instead of 4 as it was previously. - * qemu: Support encrypted TLS keys for NBD disks + * qemu: Support encrypted TLS keys for NBD and VxHS disks The secret key used for disks can now be encrypted similarly to TLS keys used for migration, chardev and others. -- 2.27.0

3 3

[libvirt PATCH] tests: fix license blurb in virsh-undefine
by Ján Tomko 05 Aug '20

05 Aug '20

Assume commit 0466ff28f2 used case-insensitive replace s/OUT/EXP/ by mistake and this file is still licensed under GPLv2.0+ Undo the change. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> FIxes: 0466ff28f23f4c430906efd5859f87672cf08782 Cc: Cole Robinson <crobinso(a)redhat.com> Cc: Eric Blake <eblake(a)redhat.com> Cc: Pino Toscano <ptoscano(a)redhat.com> --- tests/virsh-undefine | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virsh-undefine b/tests/virsh-undefine index 4a9f68dd39..998d4d3268 100755 --- a/tests/virsh-undefine +++ b/tests/virsh-undefine @@ -9,7 +9,7 @@ # (at your option) any later version. # This program is distributed in the hope that it will be useful, -# but WITHEXP ANY WARRANTY; without even the implied warranty of +# but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. -- 2.26.2

4 3

[libvirt PATCH v2] scripts: Fix meson-install-symlink.py overwriting existing links
by Erik Skultety 05 Aug '20

05 Aug '20

By default, symlink re-creation fails if the link already exists, more specifically in case of meson-install-symlink.py: Traceback (most recent call last): File "/<path_to_libvirt_repo>/scripts/meson-install-symlink.py", line 15, in <module> os.symlink(target, link) FileExistsError: File exists: '../default.xml' -> 'default.xml' Unfortunately, Python can't mimic "ln -sf", so we have to fix this differently - remove the existing link first and then try re-creating it. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- This version suffers from the same problem as v1, but I didn't bother putting that into the commit message anymore as the consensus seems to be that we don't care. scripts/meson-install-symlink.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/scripts/meson-install-symlink.py b/scripts/meson-install-symlink.py index e38507072d..d8817fb9be 100644 --- a/scripts/meson-install-symlink.py +++ b/scripts/meson-install-symlink.py @@ -12,4 +12,8 @@ workdir = os.path.join(destdir, dirname.strip(os.sep)) os.makedirs(workdir, exist_ok=True) os.chdir(workdir) + +if os.path.exists(link): + os.remove(link) + os.symlink(target, link) -- 2.26.2

2 1

[libvirt PATCH] scripts: Fix meson-install-symlink.py overwriting existing links
by Erik Skultety 05 Aug '20

05 Aug '20

By default, symlink re-creation fails if the link already exists, more specifically in case of meson-install-symlink.py: Traceback (most recent call last): File "/<path_to_libvirt_repo>/scripts/meson-install-symlink.py", line 15, in <module> os.symlink(target, link) FileExistsError: File exists: '../default.xml' -> 'default.xml' Unfortunately, Python can't mimic "ln -sf", so we have to fix this differently - create a temporary name which is then going to be used for the temporary link followed by a rename with the original link's name. Note that this solution is racy as mktemp() doesn't guarantee atomicity in link creation, so theoretically another process could come and create a file with the same name as the temporary link name, but a proper solution would be longer and not as elegant. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- scripts/meson-install-symlink.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/meson-install-symlink.py b/scripts/meson-install-symlink.py index e38507072d..630dfc079f 100644 --- a/scripts/meson-install-symlink.py +++ b/scripts/meson-install-symlink.py @@ -2,6 +2,7 @@ import os import sys +import tempfile destdir = os.environ.get('DESTDIR', os.sep) dirname = sys.argv[1] @@ -12,4 +13,7 @@ workdir = os.path.join(destdir, dirname.strip(os.sep)) os.makedirs(workdir, exist_ok=True) os.chdir(workdir) -os.symlink(target, link) + +templink = tempfile.mktemp(dir=workdir) +os.symlink(target, templink) +os.replace(templink, link) -- 2.26.2

4 5

[libvirt PATCH] util: Fix logic in virFileSetCOW
by Jiri Denemark 05 Aug '20

05 Aug '20

When COW is not explicitly requested to be disabled or enabled, the function is supposed to do nothing on non-BTRFS file systems. Fixes commit 7230bc95aa78379c9ee20cf59394c5fc4305b75b. https://bugzilla.redhat.com/show_bug.cgi?id=1866157 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 6ada3a708c..7f22884b07 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -4522,7 +4522,7 @@ virFileSetCOW(const char *path, } if (buf.f_type != BTRFS_SUPER_MAGIC) { - if (state == VIR_TRISTATE_BOOL_ABSENT) { + if (state != VIR_TRISTATE_BOOL_ABSENT) { virReportSystemError(ENOSYS, _("unable to control COW flag on '%s', not btrfs"), path); -- 2.27.0

2 1

[libvirt PATCH 0/3] Random fixes
by Ján Tomko 05 Aug '20

05 Aug '20

I found that I forgot to send the bhyve patch with the rest of the cppcheck patches. And I also found some other patches. Ján Tomko (3): bhyve: fix NULL pointer check position virbitmap: remove redundant mem_alloc util: bitmap: use g_new0/g_free src/bhyve/bhyve_parse_command.c | 14 +++++++------- src/util/virbitmap.c | 32 +++++++++----------------------- 2 files changed, 16 insertions(+), 30 deletions(-) -- 2.26.2

5 10

Re: [RFC v2 1/1] memory: Delete assertion in memory_region_unregister_iommu_notifier
by Jason Wang 05 Aug '20

05 Aug '20

On 2020/6/30 下午11:39, Peter Xu wrote: > On Tue, Jun 30, 2020 at 10:41:10AM +0800, Jason Wang wrote: >>> /* According to ATS spec table 2.4: >>> * S = 0, bits 15:12 = xxxx range size: 4K >>> * S = 1, bits 15:12 = xxx0 range size: 8K >>> * S = 1, bits 15:12 = xx01 range size: 16K >>> * S = 1, bits 15:12 = x011 range size: 32K >>> * S = 1, bits 15:12 = 0111 range size: 64K >>> * ... >>> */ >> >> Right, but the comment is probably misleading here, since it's for the PCI-E >> transaction between IOMMU and device not for the device IOTLB invalidation >> descriptor. >> >> For device IOTLB invalidation descriptor, spec allows a [0, ~0ULL] >> invalidation: >> >> " >> >> 6.5.2.5 Device-TLB Invalidate Descriptor >> >> ... >> >> Size (S): The size field indicates the number of consecutive pages targeted >> by this invalidation >> request. If S field is zero, a single page at page address specified by >> Address [63:12] is requested >> to be invalidated. If S field is Set, the least significant bit in the >> Address field with value 0b >> indicates the invalidation address range. For example, if S field is Set and >> Address[12] is Clear, it >> indicates an 8KB invalidation address range with base address in Address >> [63:13]. If S field and >> Address[12] is Set and bit 13 is Clear, it indicates a 16KB invalidation >> address range with base >> address in Address [63:14], etc. >> >> " >> >> So if we receive an address whose [63] is 0 and the rest is all 1, it's then >> a [0, ~0ULL] invalidation. > Yes. I think invalidating the whole range is always fine. It's still not > arbitrary, right? E.g., we can't even invalidate (0x1000, 0x3000) with > device-iotlb because of the address mask, not to say sub-pages. Yes. > >> >>>>>> How about just convert to use a range [start, end] for any notifier and move >>>>>> the checks (e.g the assert) into the actual notifier implemented (vhost or >>>>>> vfio)? >>>>> IOMMUTLBEntry itself is the abstraction layer of TLB entry. Hardware TLB entry >>>>> is definitely not arbitrary range either (because AFAICT the hardware should >>>>> only cache PFN rather than address, so at least PAGE_SIZE aligned). >>>>> Introducing this flag will already make this trickier just to avoid introducing >>>>> another similar struct to IOMMUTLBEntry, but I really don't want to make it a >>>>> default option... Not to mention I probably have no reason to urge the rest >>>>> iommu notifier users (tcg, vfio) to change their existing good code to suite >>>>> any of the backend who can cooperate with arbitrary address ranges... >>>> Ok, so it looks like we need a dedicated notifiers to device IOTLB. >>> Or we can also make a new flag for device iotlb just like current UNMAP? Then >>> we replace the vhost type from UNMAP to DEVICE_IOTLB. But IMHO using the >>> ARBITRARY_LENGTH flag would work in a similar way. DEVICE_IOTLB flag could >>> also allow virtio/vhost to only receive one invalidation (now IIUC it'll >>> receive both iotlb and device-iotlb for unmapping a page when ats=on), but then >>> ats=on will be a must and it could break some old (misconfiged) qemu because >>> afaict previously virtio/vhost could even work with vIOMMU (accidentally) even >>> without ats=on. >> >> That's a bug and I don't think we need to workaround mis-configurated qemu >> :) > IMHO it depends on the strictness we want on the qemu cmdline API. :) > > We should at least check libvirt to make sure it's using ats=on always, then I > agree maybe we can avoid considering the rest... > > Thanks, Cc libvirt list, but I think we should fix libvirt if they don't provide "ats=on". Thanks

3 23

[PATCH 0/4] Xen: Add support for qemu commandline passthrough
by Jim Fehlig 05 Aug '20

05 Aug '20

This patch series introduces support for qemu commandline passthrough to the xen driver. ATM it uses the same schema extension as the qemu driver, but it could be changed to something like xmlns:xen='http://libvirt.org/schemas/domain/xen/1.0' if desired. I didn't see an immediate benefit to that, other than following the pattern used by qemu, bhyve, and lxc. Using the same namespace and schema could be a bit confusing to users, but on the other hand it is just qemu under the covers. Since Xen does not support passing environment vars or adjusting qemu's capabilities, the parser will flag attempts at setting those as errors. The patch to NEWS.rst is just a reminder for me to create a news entry and will need rebased once 6.6.0 is out. Thanks in advance for your comments! Regards, Jim Jim Fehlig (4): Expose virStringListCopy in libvirt_private.syms Xen: Add support for qemu command-line passthrough Xen: Add support for qemu commandline passthrough to config converter news: Mention support for qemu commandline passthrough in Xen NEWS.rst | 6 ++ docs/drvxen.html.in | 35 +++++++ src/libvirt_private.syms | 1 + src/libxl/libxl_conf.c | 11 ++- src/libxl/libxl_conf.h | 8 ++ src/libxl/libxl_domain.c | 99 ++++++++++++++++++++ src/libxl/libxl_domain.h | 1 + src/libxl/xen_xl.c | 88 +++++++++++++++++ tests/xlconfigdata/test-qemu-passthrough.cfg | 26 +++++ tests/xlconfigdata/test-qemu-passthrough.xml | 53 +++++++++++ tests/xlconfigtest.c | 4 + 11 files changed, 331 insertions(+), 1 deletion(-) create mode 100644 tests/xlconfigdata/test-qemu-passthrough.cfg create mode 100644 tests/xlconfigdata/test-qemu-passthrough.xml -- 2.26.2

2 8

[libvirt PATCH] docs: formatdomain: fyx a tipo
by Ján Tomko 04 Aug '20

04 Aug '20

s/hystorical/historical/ Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. Sorry if this was an easter egg. It was too painful to look at. docs/formatdomain.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 3275d1b39e..218f0c1718 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -6070,7 +6070,7 @@ below <#elementCharSerialAndConsole>`__. Relationship between serial ports and consoles '''''''''''''''''''''''''''''''''''''''''''''' -Due to hystorical reasons, the ``serial`` and ``console`` elements have +Due to historical reasons, the ``serial`` and ``console`` elements have partially overlapping scopes. In general, both elements are used to configure one or more serial consoles to -- 2.26.2

1 0

[libvirt PATCH] src: add G_GNUC_NO_INLINE annotations for mocked symbols
by Daniel P. Berrangé 04 Aug '20

04 Aug '20

We should prevent inlining of symbols from the driver .so files that are mocked, as well as those in the main libvirt.so This isn't fixing any currently known problem, just trying to prevent future issues. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- scripts/mock-noinline.py | 2 +- src/libxl/libxl_capabilities.h | 2 +- src/qemu/qemu_command.h | 4 ++-- src/qemu/qemu_hotplug.h | 2 +- src/qemu/qemu_interface.h | 2 +- src/qemu/qemu_monitor.h | 2 +- src/qemu/qemu_monitor_json.h | 2 +- src/qemu/qemu_process.h | 4 ++-- 8 files changed, 10 insertions(+), 10 deletions(-) diff --git a/scripts/mock-noinline.py b/scripts/mock-noinline.py index a8b7680c11..69cf0b4b99 100644 --- a/scripts/mock-noinline.py +++ b/scripts/mock-noinline.py @@ -59,7 +59,7 @@ def scan_overrides(filename): m = re.search(r'''^\w+\s*(?:\*\s*)?(\w+)\(''', line) if m is not None: name = m.group(1) - if name.startswith("vir"): + if name.startswith("vir") or name.startswith("qemu") or name.startswith("libxl"): mocked[name] = "%s:%d" % (filename, lineno) diff --git a/src/libxl/libxl_capabilities.h b/src/libxl/libxl_capabilities.h index 9efb836429..4e8e2bb59b 100644 --- a/src/libxl/libxl_capabilities.h +++ b/src/libxl/libxl_capabilities.h @@ -39,7 +39,7 @@ * by libvirt for Xen, and cannot be used for a persistent network name. */ #define LIBXL_GENERATED_PREFIX_XEN "vif" -bool libxlCapsHasPVUSB(void); +bool libxlCapsHasPVUSB(void) G_GNUC_NO_INLINE; virCapsPtr libxlMakeCapabilities(libxl_ctx *ctx); diff --git a/src/qemu/qemu_command.h b/src/qemu/qemu_command.h index b579817b44..89d99b111f 100644 --- a/src/qemu/qemu_command.h +++ b/src/qemu/qemu_command.h @@ -82,7 +82,7 @@ int qemuBuildTLSx509BackendProps(const char *tlspath, /* Open a UNIX socket for chardev FD passing */ int -qemuOpenChrChardevUNIXSocket(const virDomainChrSourceDef *dev); +qemuOpenChrChardevUNIXSocket(const virDomainChrSourceDef *dev) G_GNUC_NO_INLINE; /* Generate '-device' string for chardev device */ int @@ -254,4 +254,4 @@ qemuBuildTPMOpenBackendFDs(const char *tpmdev, int *tpmfd, int *cancelfd) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) - ATTRIBUTE_NONNULL(4); + ATTRIBUTE_NONNULL(4) G_GNUC_NO_INLINE; diff --git a/src/qemu/qemu_hotplug.h b/src/qemu/qemu_hotplug.h index 4a49e04a15..6287c5b5e8 100644 --- a/src/qemu/qemu_hotplug.h +++ b/src/qemu/qemu_hotplug.h @@ -151,7 +151,7 @@ int qemuDomainSetVcpuInternal(virQEMUDriverPtr driver, virBitmapPtr vcpus, bool state); -unsigned long long qemuDomainGetUnplugTimeout(virDomainObjPtr vm); +unsigned long long qemuDomainGetUnplugTimeout(virDomainObjPtr vm) G_GNUC_NO_INLINE; int qemuHotplugAttachDBusVMState(virQEMUDriverPtr driver, virDomainObjPtr vm, diff --git a/src/qemu/qemu_interface.h b/src/qemu/qemu_interface.h index 0464b903d7..3dcefc6a12 100644 --- a/src/qemu/qemu_interface.h +++ b/src/qemu/qemu_interface.h @@ -54,7 +54,7 @@ int qemuInterfaceBridgeConnect(virDomainDefPtr def, int qemuInterfaceOpenVhostNet(virDomainDefPtr def, virDomainNetDefPtr net, int *vhostfd, - size_t *vhostfdSize); + size_t *vhostfdSize) G_GNUC_NO_INLINE; qemuSlirpPtr qemuInterfacePrepareSlirp(virQEMUDriverPtr driver, virDomainNetDefPtr net); diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 1c1b0c9b89..d20a15c202 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -408,7 +408,7 @@ int qemuMonitorSetLink(qemuMonitorPtr mon, /* These APIs are for use by the internal Text/JSON monitor impl code only */ char *qemuMonitorNextCommandID(qemuMonitorPtr mon); int qemuMonitorSend(qemuMonitorPtr mon, - qemuMonitorMessagePtr msg); + qemuMonitorMessagePtr msg) G_GNUC_NO_INLINE; virJSONValuePtr qemuMonitorGetOptions(qemuMonitorPtr mon) ATTRIBUTE_NONNULL(1); void qemuMonitorSetOptions(qemuMonitorPtr mon, virJSONValuePtr options) diff --git a/src/qemu/qemu_monitor_json.h b/src/qemu/qemu_monitor_json.h index 84fea25983..098ab857be 100644 --- a/src/qemu/qemu_monitor_json.h +++ b/src/qemu/qemu_monitor_json.h @@ -30,7 +30,7 @@ int qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon, const char *line, - qemuMonitorMessagePtr msg); + qemuMonitorMessagePtr msg) G_GNUC_NO_INLINE; int qemuMonitorJSONIOProcess(qemuMonitorPtr mon, const char *data, diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h index 125508f9fe..dbd989c321 100644 --- a/src/qemu/qemu_process.h +++ b/src/qemu/qemu_process.h @@ -203,9 +203,9 @@ int qemuProcessRefreshDisks(virQEMUDriverPtr driver, virDomainObjPtr vm, qemuDomainAsyncJob asyncJob); -int qemuProcessStartManagedPRDaemon(virDomainObjPtr vm); +int qemuProcessStartManagedPRDaemon(virDomainObjPtr vm) G_GNUC_NO_INLINE; -void qemuProcessKillManagedPRDaemon(virDomainObjPtr vm); +void qemuProcessKillManagedPRDaemon(virDomainObjPtr vm) G_GNUC_NO_INLINE; typedef struct _qemuProcessQMP qemuProcessQMP; typedef qemuProcessQMP *qemuProcessQMPPtr; -- 2.26.2

2 1

[PATCH] tests: qemublocktest: fix crashing with SIGBUS
by Roman Bogorodskiy 04 Aug '20

04 Aug '20

Commit bcbb026993 converted qemublocktest to use g_autoptr for virQEMUCaps. To prevent it from crashing, don't explicitly call virObjectUnref() on this object. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- tests/qemublocktest.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemublocktest.c b/tests/qemublocktest.c index fb5319d7bd..0685b703a1 100644 --- a/tests/qemublocktest.c +++ b/tests/qemublocktest.c @@ -1394,7 +1394,6 @@ mymain(void) cleanup: qemuTestDriverFree(&driver); VIR_FREE(capslatest_x86_64); - virObjectUnref(caps_x86_64); return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -- 2.27.0

3 2

[libvirt PATCH] docs: fix libvirt go-import metadata in pages
by Daniel P. Berrangé 04 Aug '20

04 Aug '20

The meson conversion lost the <meta> tags providing the go-import, because the "$pagename" variable lost the .html suffix. Rather than fix that, just change to using "$pagesrc" instead, as it is a better fit. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/newapi.xsl | 2 -- docs/page.xsl | 7 +++---- docs/site.xsl | 3 +-- docs/subsite.xsl | 1 - scripts/meson-html-gen.py | 4 ---- 5 files changed, 4 insertions(+), 13 deletions(-) diff --git a/docs/newapi.xsl b/docs/newapi.xsl index 0dc4f7ae52..7ac8caa35d 100644 --- a/docs/newapi.xsl +++ b/docs/newapi.xsl @@ -835,7 +835,6 @@ indent="yes" encoding="UTF-8"> <xsl:apply-templates select="exsl:node-set($mainpage)" mode="page"> - <xsl:with-param name="pagename" select="concat($htmldir, '', $indexfile)"/> <xsl:with-param name="timestamp" select="$timestamp"/> </xsl:apply-templates> </xsl:document> @@ -851,7 +850,6 @@ indent="yes" encoding="UTF-8"> <xsl:apply-templates select="exsl:node-set($subpage)" mode="page"> - <xsl:with-param name="pagename" select="concat($htmldir, '/libvirt-', @name, '.html')"/> <xsl:with-param name="timestamp" select="$timestamp"/> </xsl:apply-templates> </xsl:document> diff --git a/docs/page.xsl b/docs/page.xsl index bdd57ba2e0..9ab8d3dd69 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -76,14 +76,13 @@  <xsl:template match="/" mode="page"> - <xsl:param name="pagename"/> <xsl:param name="pagesrc"/> <xsl:param name="timestamp"/> <xsl:text disable-output-escaping="yes"><!DOCTYPE html> </xsl:text> <html> <xsl:comment> - This file is autogenerated from <xsl:value-of select="$pagename"/>.in + This file is autogenerated from <xsl:value-of select="$pagesrc"/> Do not edit this file. Changes will be lost. </xsl:comment> <xsl:comment> @@ -100,10 +99,10 @@ <meta name="theme-color" content="#ffffff"/> <title>libvirt: <xsl:value-of select="html:html/html:body//html:h1"/></title> <meta name="description" content="libvirt, virtualization, virtualization API"/> - <xsl:if test="$pagename = 'libvirt-go.html'"> + <xsl:if test="$pagesrc = 'docs/libvirt-go.rst'"> <meta name="go-import" content="libvirt.org/libvirt-go git https://libvirt.org/git/libvirt-go.git"/> </xsl:if> - <xsl:if test="$pagename = 'libvirt-go-xml.html'"> + <xsl:if test="$pagesrc = 'docs/libvirt-go-xml.rst'"> <meta name="go-import" content="libvirt.org/libvirt-go-xml git https://libvirt.org/git/libvirt-go-xml.git"/> </xsl:if> <xsl:apply-templates select="/html:html/html:head/html:script" mode="content"/> diff --git a/docs/site.xsl b/docs/site.xsl index 73ddd8ca6b..931e26272f 100644 --- a/docs/site.xsl +++ b/docs/site.xsl @@ -15,7 +15,7 @@ <xsl:variable name="href_base"> <xsl:choose> - <xsl:when test="$pagename = '404.html'"> + <xsl:when test="$pagesrc = 'docs/404.html.in'"> <xsl:value-of select="'/'"/> </xsl:when> <xsl:otherwise> @@ -26,7 +26,6 @@ <xsl:template match="/"> <xsl:apply-templates select="." mode="page"> - <xsl:with-param name="pagename" select="$pagename"/> <xsl:with-param name="pagesrc" select="$pagesrc"/> <xsl:with-param name="timestamp" select="$timestamp"/> </xsl:apply-templates> diff --git a/docs/subsite.xsl b/docs/subsite.xsl index bfd34eebd2..2bdfcbb9b1 100644 --- a/docs/subsite.xsl +++ b/docs/subsite.xsl @@ -16,7 +16,6 @@ <xsl:template match="/"> <xsl:apply-templates select="." mode="page"> - <xsl:with-param name="pagename" select="$pagename"/> <xsl:with-param name="pagesrc" select="$pagesrc"/> <xsl:with-param name="timestamp" select="$timestamp"/> </xsl:apply-templates> diff --git a/scripts/meson-html-gen.py b/scripts/meson-html-gen.py index dbf238de54..2731d734a7 100755 --- a/scripts/meson-html-gen.py +++ b/scripts/meson-html-gen.py @@ -1,7 +1,6 @@ #!/usr/bin/env python3 import argparse -import os import subprocess parser = argparse.ArgumentParser() @@ -15,12 +14,9 @@ parser.add_argument("htmlfile", type=str, help="path to generated HTML file") parser.add_argument("pagesrc", type=str, default="", nargs='?', help="(optional) path to source file used for edit this page") args = parser.parse_args() -name = os.path.basename(args.htmlfile).replace('.html', '') - html_tmp = subprocess.run( [ args.xsltproc, - '--stringparam', 'pagename', name, '--stringparam', 'pagesrc', args.pagesrc, '--stringparam', 'builddir', args.builddir, '--stringparam', 'timestamp', args.timestamp, -- 2.26.2

2 1

[PATCH-for-5.1] .travis.yml: Deprecate it in favor of GitLab CI
by Philippe Mathieu-Daudé 04 Aug '20

04 Aug '20

As of QEMU 5.2 we prefer to focus our CI development on GitLab. Mark Travis-CI as deprecated (adding a big warning). Signed-off-by: Philippe Mathieu-Daudé <philmd(a)redhat.com> --- docs/system/deprecated.rst | 11 +++++++++++ .travis.yml | 7 +++++++ 2 files changed, 18 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 851dbdeb8a..c17a5b0896 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -17,6 +17,17 @@ they were first deprecated in the 2.10.0 release. What follows is a list of all features currently marked as deprecated. +Build and test automation +------------------------- + +``Travis-CI`` (Since 5.2) +''''''''''''''''''''''''' + +``Travis-CI`` is deprecated in favor of GitLab-CI. + +The '.travis.yml' configuration should only be modified to remove jobs +when equivalent exist on GitLab-CI. Adding new jobs is not allowed. + System emulator command line arguments -------------------------------------- diff --git a/.travis.yml b/.travis.yml index 6695c0620f..4ad243f511 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,3 +1,10 @@ +# WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING +# +# As of QEMU 5.2, this file is now deprecated in favor of GitLab CI. +# Do not modify, except to remove jobs ported to GitLab CI. +# +# WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING + # The current Travis default is a VM based 16.04 Xenial on GCE # Additional builds with specific requirements for a full VM need to # be added as additional matrix: entries later on -- 2.21.3

4 3

[libvirt PATCH] build-aux: remove some syntax-check cruft
by Daniel P. Berrangé 04 Aug '20

04 Aug '20

sc_proper_name_utf8_requires_ICONV looks for Makefile.am files, so is not going to work correctly with meson. The 'today' variable is not referenced anywhere. The 'writable-files' target is not used anywhere sc_prohibit_reversed_compare_failure only checks 'init.sh' which does not exist in libvirt. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- build-aux/syntax-check.mk | 54 --------------------------------------- 1 file changed, 54 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 9256532ab3..6eb59cf90e 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -72,10 +72,6 @@ VC_LIST_EXCEPT = \ | $(GREP) -Ev -e '($(VC_LIST_ALWAYS_EXCLUDE_REGEX)|$(_sc_excl))' \ $(_prepend_srcdir_prefix) -# Override this in syntax-check.mk if you are using a different format in your -# NEWS file. -today = $(shell date +%Y-%m-%d) - # Prevent programs like 'sort' from considering distinct strings to be equal. # Doing it here saves us from having to set LC_ALL elsewhere in this file. export LC_ALL = C @@ -1744,29 +1740,6 @@ sc_prohibit_test_double_equal: halt='use "test x = x", not "test x =''= x"' \ $(_sc_search_regexp) -# Each program that uses proper_name_utf8 must link with one of the -# ICONV libraries. Otherwise, some ICONV library must appear in LDADD. -# The perl -0777 invocation below extracts the possibly-multi-line -# definition of LDADD from the appropriate Makefile.am and exits 0 -# when it contains "ICONV". -sc_proper_name_utf8_requires_ICONV: - @progs=$$($(VC_LIST_EXCEPT) \ - | xargs $(GREP) -l 'proper_name_utf8 ''("'); \ - if test "x$$progs" != x; then \ - fail=0; \ - for p in $$progs; do \ - dir=$$(dirname "$$p"); \ - perl -0777 \ - -ne 'exit !(/^LDADD =(.+?[^\\]\n)/ms && $$1 =~ /ICONV/)' \ - $$dir/Makefile.am && continue; \ - base=$$(basename "$$p" .c); \ - $(GREP) "$${base}_LDADD.*ICONV)" $$dir/Makefile.am > /dev/null \ - || { fail=1; echo 1>&2 "$(ME): $$p uses proper_name_utf8"; }; \ - done; \ - test $$fail = 1 && \ - { echo 1>&2 '$(ME): the above do not link with any ICONV library'; \ - exit 1; } || :; \ - fi # Warn about "c0nst struct Foo const foo[]", # but not about "char const *const foo" or "#define const const". @@ -1828,33 +1801,6 @@ sc_po_check: rm -f $@-1 $@-2; \ fi -# Check that 'make alpha' will not fail at the end of the process, -# i.e., when pkg-M.N.tar.xz already exists (either in "." or in ../release) -# and is read-only. -writable-files: - $(AM_V_GEN)if test -d $(release_archive_dir); then \ - for file in $(DIST_ARCHIVES); do \ - for p in ./ $(release_archive_dir)/; do \ - test -e $$p$$file || continue; \ - test -w $$p$$file \ - || { echo ERROR: $$p$$file is not writable; fail=1; }; \ - done; \ - done; \ - test "$$fail" && exit 1 || : ; \ - else :; \ - fi - - -# BRE regex of file contents to identify a test script. -_test_script_regex ?= \<init\.sh\> - -# In tests, use "compare expected actual", not the reverse. -sc_prohibit_reversed_compare_failure: - @prohibit='\<compare [^ ]+ ([^ ]*exp|/dev/null)' \ - containing='$(_test_script_regex)' \ - halt='reversed compare arguments' \ - $(_sc_search_regexp) - # #if HAVE_... will evaluate to false for any non numeric string. # That would be flagged by using -Wundef, however gnulib currently # tests many undefined macros, and so we can't enable that option. -- 2.26.2

2 1