- Devel - libvirt List Archives

[PULL v4 09/48] cphp: remove deprecated cpu-add command(s)
by Michael S. Tsirkin 29 Sep '20

29 Sep '20

From: Igor Mammedov <imammedo(a)redhat.com> These were deprecated since 4.0, remove both HMP and QMP variants. Users should use device_add command instead. To get list of possible CPUs and options, use 'info hotpluggable-cpus' HMP or query-hotpluggable-cpus QMP command. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> Reviewed-by: Thomas Huth <thuth(a)redhat.com> Acked-by: Dr. David Alan Gilbert <dgilbert(a)redhat.com> Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com> Acked-by: Cornelia Huck <cohuck(a)redhat.com> Message-Id: <20200915120403.1074579-1-imammedo(a)redhat.com> Reviewed-by: Michael S. Tsirkin <mst(a)redhat.com> Signed-off-by: Michael S. Tsirkin <mst(a)redhat.com> --- qapi/machine.json | 24 --------- include/hw/boards.h | 1 - include/hw/i386/pc.h | 1 - include/monitor/hmp.h | 1 - hw/core/machine-hmp-cmds.c | 12 ----- hw/core/machine-qmp-cmds.c | 12 ----- hw/i386/pc.c | 27 ---------- hw/i386/pc_piix.c | 1 - hw/s390x/s390-virtio-ccw.c | 12 ----- tests/qtest/cpu-plug-test.c | 100 ++++-------------------------------- tests/qtest/test-hmp.c | 1 - docs/system/deprecated.rst | 25 +++++---- hmp-commands.hx | 15 ------ 13 files changed, 21 insertions(+), 211 deletions(-) diff --git a/qapi/machine.json b/qapi/machine.json index 0ac1880e4a..d8ed096e9a 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -307,30 +307,6 @@ ## { 'command': 'query-cpus-fast', 'returns': [ 'CpuInfoFast' ] } -## -# @cpu-add: -# -# Adds CPU with specified ID. -# -# @id: ID of CPU to be created, valid values [0..max_cpus) -# -# Features: -# @deprecated: This command is deprecated. Use `device_add` instead. -# See the `query-hotpluggable-cpus` command for details. -# -# Returns: Nothing on success -# -# Since: 1.5 -# -# Example: -# -# -> { "execute": "cpu-add", "arguments": { "id": 2 } } -# <- { "return": {} } -# -## -{ 'command': 'cpu-add', 'data': {'id': 'int'}, - 'features': [ 'deprecated' ] } - ## # @MachineInfo: # diff --git a/include/hw/boards.h b/include/hw/boards.h index 56aa1ca335..482d2833f6 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -168,7 +168,6 @@ struct MachineClass { void (*init)(MachineState *state); void (*reset)(MachineState *state); void (*wakeup)(MachineState *state); - void (*hot_add_cpu)(MachineState *state, const int64_t id, Error **errp); int (*kvm_type)(MachineState *machine, const char *arg); void (*smp_parse)(MachineState *ms, QemuOpts *opts); diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index b2da2c8d2b..c71b02cafd 100644 --- a/include/hw/i386/pc.h +++ b/include/hw/i386/pc.h @@ -132,7 +132,6 @@ extern int fd_bootchk; void pc_acpi_smi_interrupt(void *opaque, int irq, int level); -void pc_hot_add_cpu(MachineState *ms, const int64_t id, Error **errp); void pc_smp_parse(MachineState *ms, QemuOpts *opts); void pc_guest_info_init(PCMachineState *pcms); diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h index c986cfd28b..642e9e91f9 100644 --- a/include/monitor/hmp.h +++ b/include/monitor/hmp.h @@ -89,7 +89,6 @@ void hmp_chardev_add(Monitor *mon, const QDict *qdict); void hmp_chardev_change(Monitor *mon, const QDict *qdict); void hmp_chardev_remove(Monitor *mon, const QDict *qdict); void hmp_chardev_send_break(Monitor *mon, const QDict *qdict); -void hmp_cpu_add(Monitor *mon, const QDict *qdict); void hmp_object_add(Monitor *mon, const QDict *qdict); void hmp_object_del(Monitor *mon, const QDict *qdict); void hmp_info_memdev(Monitor *mon, const QDict *qdict); diff --git a/hw/core/machine-hmp-cmds.c b/hw/core/machine-hmp-cmds.c index 39999c47c5..f4092b98cc 100644 --- a/hw/core/machine-hmp-cmds.c +++ b/hw/core/machine-hmp-cmds.c @@ -46,18 +46,6 @@ void hmp_info_cpus(Monitor *mon, const QDict *qdict) qapi_free_CpuInfoFastList(cpu_list); } -void hmp_cpu_add(Monitor *mon, const QDict *qdict) -{ - int cpuid; - Error *err = NULL; - - error_report("cpu_add is deprecated, please use device_add instead"); - - cpuid = qdict_get_int(qdict, "id"); - qmp_cpu_add(cpuid, &err); - hmp_handle_error(mon, err); -} - void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict) { Error *err = NULL; diff --git a/hw/core/machine-qmp-cmds.c b/hw/core/machine-qmp-cmds.c index 21551221ad..5362c80a18 100644 --- a/hw/core/machine-qmp-cmds.c +++ b/hw/core/machine-qmp-cmds.c @@ -284,18 +284,6 @@ HotpluggableCPUList *qmp_query_hotpluggable_cpus(Error **errp) return machine_query_hotpluggable_cpus(ms); } -void qmp_cpu_add(int64_t id, Error **errp) -{ - MachineClass *mc; - - mc = MACHINE_GET_CLASS(current_machine); - if (mc->hot_add_cpu) { - mc->hot_add_cpu(current_machine, id, errp); - } else { - error_setg(errp, "Not supported"); - } -} - void qmp_set_numa_node(NumaOptions *cmd, Error **errp) { if (!runstate_check(RUN_STATE_PRECONFIG)) { diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 1e2ab5ebe7..50e8317342 100644 --- a/hw/i386/pc.c +++ b/hw/i386/pc.c @@ -769,32 +769,6 @@ void pc_smp_parse(MachineState *ms, QemuOpts *opts) } } -void pc_hot_add_cpu(MachineState *ms, const int64_t id, Error **errp) -{ - X86MachineState *x86ms = X86_MACHINE(ms); - int64_t apic_id = x86_cpu_apic_id_from_index(x86ms, id); - Error *local_err = NULL; - - if (id < 0) { - error_setg(errp, "Invalid CPU id: %" PRIi64, id); - return; - } - - if (apic_id >= ACPI_CPU_HOTPLUG_ID_LIMIT) { - error_setg(errp, "Unable to add CPU: %" PRIi64 - ", resulting APIC ID (%" PRIi64 ") is too large", - id, apic_id); - return; - } - - - x86_cpu_new(X86_MACHINE(ms), apic_id, &local_err); - if (local_err) { - error_propagate(errp, local_err); - return; - } -} - static void pc_machine_done(Notifier *notifier, void *data) { @@ -1691,7 +1665,6 @@ static void pc_machine_class_init(ObjectClass *oc, void *data) mc->auto_enable_numa_with_memdev = true; mc->has_hotpluggable_cpus = true; mc->default_boot_order = "cad"; - mc->hot_add_cpu = pc_hot_add_cpu; mc->smp_parse = pc_smp_parse; mc->block_default_type = IF_IDE; mc->max_cpus = 255; diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 6f3e78bb60..2d8413a0ce 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -752,7 +752,6 @@ static void pc_i440fx_1_4_machine_options(MachineClass *m) { pc_i440fx_1_5_machine_options(m); m->hw_version = "1.4.0"; - m->hot_add_cpu = NULL; compat_props_add(m->compat_props, pc_compat_1_4, pc_compat_1_4_len); } diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 3106bbea33..28266a3a35 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -553,17 +553,6 @@ static HotplugHandler *s390_get_hotplug_handler(MachineState *machine, return NULL; } -static void s390_hot_add_cpu(MachineState *machine, - const int64_t id, Error **errp) -{ - ObjectClass *oc; - - g_assert(machine->possible_cpus->cpus[0].cpu); - oc = OBJECT_CLASS(CPU_GET_CLASS(machine->possible_cpus->cpus[0].cpu)); - - s390x_new_cpu(object_class_get_name(oc), id, errp); -} - static void s390_nmi(NMIState *n, int cpu_index, Error **errp) { CPUState *cs = qemu_get_cpu(cpu_index); @@ -604,7 +593,6 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data) s390mc->hpage_1m_allowed = true; mc->init = ccw_init; mc->reset = s390_machine_reset; - mc->hot_add_cpu = s390_hot_add_cpu; mc->block_default_type = IF_VIRTIO; mc->no_cdrom = 1; mc->no_floppy = 1; diff --git a/tests/qtest/cpu-plug-test.c b/tests/qtest/cpu-plug-test.c index e8ffbbce4b..a1c689414b 100644 --- a/tests/qtest/cpu-plug-test.c +++ b/tests/qtest/cpu-plug-test.c @@ -25,54 +25,6 @@ struct PlugTestData { }; typedef struct PlugTestData PlugTestData; -static void test_plug_with_cpu_add(gconstpointer data) -{ - const PlugTestData *s = data; - char *args; - QDict *response; - unsigned int i; - - args = g_strdup_printf("-machine %s -cpu %s " - "-smp 1,sockets=%u,cores=%u,threads=%u,maxcpus=%u", - s->machine, s->cpu_model, - s->sockets, s->cores, s->threads, s->maxcpus); - qtest_start(args); - - for (i = 1; i < s->maxcpus; i++) { - response = qmp("{ 'execute': 'cpu-add'," - " 'arguments': { 'id': %d } }", i); - g_assert(response); - g_assert(!qdict_haskey(response, "error")); - qobject_unref(response); - } - - qtest_end(); - g_free(args); -} - -static void test_plug_without_cpu_add(gconstpointer data) -{ - const PlugTestData *s = data; - char *args; - QDict *response; - - args = g_strdup_printf("-machine %s -cpu %s " - "-smp 1,sockets=%u,cores=%u,threads=%u,maxcpus=%u", - s->machine, s->cpu_model, - s->sockets, s->cores, s->threads, s->maxcpus); - qtest_start(args); - - response = qmp("{ 'execute': 'cpu-add'," - " 'arguments': { 'id': %d } }", - s->sockets * s->cores * s->threads); - g_assert(response); - g_assert(qdict_haskey(response, "error")); - qobject_unref(response); - - qtest_end(); - g_free(args); -} - static void test_plug_with_device_add(gconstpointer data) { const PlugTestData *td = data; @@ -144,36 +96,13 @@ static void add_pc_test_case(const char *mname) data->cores = 3; data->threads = 2; data->maxcpus = data->sockets * data->cores * data->threads; - if (g_str_has_suffix(mname, "-1.4") || - (strcmp(mname, "pc-1.3") == 0) || - (strcmp(mname, "pc-1.2") == 0) || - (strcmp(mname, "pc-1.1") == 0) || - (strcmp(mname, "pc-1.0") == 0)) { - path = g_strdup_printf("cpu-plug/%s/init/%ux%ux%u&maxcpus=%u", - mname, data->sockets, data->cores, - data->threads, data->maxcpus); - qtest_add_data_func_full(path, data, test_plug_without_cpu_add, - test_data_free); - g_free(path); - } else { - PlugTestData *data2 = g_memdup(data, sizeof(PlugTestData)); - data2->machine = g_strdup(data->machine); - data2->device_model = g_strdup(data->device_model); - - path = g_strdup_printf("cpu-plug/%s/cpu-add/%ux%ux%u&maxcpus=%u", - mname, data->sockets, data->cores, - data->threads, data->maxcpus); - qtest_add_data_func_full(path, data, test_plug_with_cpu_add, - test_data_free); - g_free(path); - path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", - mname, data2->sockets, data2->cores, - data2->threads, data2->maxcpus); - qtest_add_data_func_full(path, data2, test_plug_with_device_add, - test_data_free); - g_free(path); - } + path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", + mname, data->sockets, data->cores, + data->threads, data->maxcpus); + qtest_add_data_func_full(path, data, test_plug_with_device_add, + test_data_free); + g_free(path); } static void add_pseries_test_case(const char *mname) @@ -205,7 +134,7 @@ static void add_pseries_test_case(const char *mname) static void add_s390x_test_case(const char *mname) { char *path; - PlugTestData *data, *data2; + PlugTestData *data; if (!g_str_has_prefix(mname, "s390-ccw-virtio-")) { return; @@ -220,21 +149,10 @@ static void add_s390x_test_case(const char *mname) data->threads = 1; data->maxcpus = data->sockets * data->cores * data->threads; - data2 = g_memdup(data, sizeof(PlugTestData)); - data2->machine = g_strdup(data->machine); - data2->device_model = g_strdup(data->device_model); - - path = g_strdup_printf("cpu-plug/%s/cpu-add/%ux%ux%u&maxcpus=%u", + path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", mname, data->sockets, data->cores, data->threads, data->maxcpus); - qtest_add_data_func_full(path, data, test_plug_with_cpu_add, - test_data_free); - g_free(path); - - path = g_strdup_printf("cpu-plug/%s/device-add/%ux%ux%u&maxcpus=%u", - mname, data2->sockets, data2->cores, - data2->threads, data2->maxcpus); - qtest_add_data_func_full(path, data2, test_plug_with_device_add, + qtest_add_data_func_full(path, data, test_plug_with_device_add, test_data_free); g_free(path); } diff --git a/tests/qtest/test-hmp.c b/tests/qtest/test-hmp.c index aea1384bac..94a8023173 100644 --- a/tests/qtest/test-hmp.c +++ b/tests/qtest/test-hmp.c @@ -27,7 +27,6 @@ static const char *hmp_cmds[] = { "chardev-change testchardev1 ringbuf", "chardev-remove testchardev1", "commit all", - "cpu-add 1", "cpu 0", "device_add ?", "device_add usb-mouse,id=mouse1", diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 17aa74531c..5326141cee 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -272,13 +272,6 @@ The ``query-cpus`` command is replaced by the ``query-cpus-fast`` command. The ``arch`` output member of the ``query-cpus-fast`` command is replaced by the ``target`` output member. -``cpu-add`` (since 4.0) -''''''''''''''''''''''' - -Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See -documentation of ``query-hotpluggable-cpus`` for additional -details. - ``query-events`` (since 4.0) '''''''''''''''''''''''''''' @@ -294,12 +287,6 @@ the 'wait' field, which is only applicable to sockets in server mode Human Monitor Protocol (HMP) commands ------------------------------------- -``cpu-add`` (since 4.0) -''''''''''''''''''''''' - -Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See -documentation of ``query-hotpluggable-cpus`` for additional details. - ``acl_show``, ``acl_reset``, ``acl_policy``, ``acl_add``, ``acl_remove`` (since 4.0.0) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' @@ -517,6 +504,12 @@ QEMU Machine Protocol (QMP) commands The "autoload" parameter has been ignored since 2.12.0. All bitmaps are automatically loaded from qcow2 images. +``cpu-add`` (removed in 5.2) +'''''''''''''''''''''''''''' + +Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See +documentation of ``query-hotpluggable-cpus`` for additional details. + Human Monitor Protocol (HMP) commands ------------------------------------- @@ -526,6 +519,12 @@ The ``hub_id`` parameter of ``hostfwd_add`` / ``hostfwd_remove`` (removed in 5.0 The ``[hub_id name]`` parameter tuple of the 'hostfwd_add' and 'hostfwd_remove' HMP commands has been replaced by ``netdev_id``. +``cpu-add`` (removed in 5.2) +'''''''''''''''''''''''''''' + +Use ``device_add`` for hotplugging vCPUs instead of ``cpu-add``. See +documentation of ``query-hotpluggable-cpus`` for additional details. + Guest Emulator ISAs ------------------- diff --git a/hmp-commands.hx b/hmp-commands.hx index 27c4bbe0f2..1088d64503 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@ -1761,21 +1761,6 @@ SRST Executes a qemu-io command on the given block device. ERST - { - .name = "cpu-add", - .args_type = "id:i", - .params = "id", - .help = "add cpu (deprecated, use device_add instead)", - .cmd = hmp_cpu_add, - }, - -SRST -``cpu-add`` *id* - Add CPU with id *id*. This command is deprecated, please - +use ``device_add`` instead. For details, refer to - 'docs/cpu-hotplug.rst'. -ERST - { .name = "qom-list", .args_type = "path:s?", -- MST

1 0

handling Hyper-V automatic startup values
by Matt Coleman 28 Sep '20

28 Sep '20

Hello, I’m implementing some new functionality in the Hyper-V driver and could use some input on how I should handle automatic startup values. Microsoft’s Msvm_VirtualSystemSettingData class stores this setting in a property named AutomaticStartupAction: https://docs.microsoft.com/en-us/windows/win32/hyperv_v2/msvm-virtualsystem… This property has several possible values with different meanings: * 2 means “None.”, which represents that the VM will not automatically start at boot. This corresponds to libvirt’s domainGetAutostart outputting boolean false. * 3 means “Restart if previously active.” This will start the machine at boot if it was running when the host was shut down or unexpectedly powered off. It appears libvirt does not have a way to represent this. * 4 means “Always start.” This corresponds to libvirt’s domainGetAutostart outputting boolean true. * 5 through 32768 are reserved. I’m unsure how to handle the value 3, since libvirt treats this setting as a boolean... The domainGetAutostart function places the value in an int: * https://gitlab.com/libvirt/libvirt/-/blob/master/src/driver-hypervisor.h#L1… * https://gitlab.com/libvirt/libvirt/-/blob/master/src/driver-hypervisor.h#L4… However, virDomainGetAutostart’s docblock says that it will be treated as a boolean: https://gitlab.com/libvirt/libvirt/-/blob/master/src/libvirt-domain.c#L6690… Its usage in `virsh dominfo` confirms that: https://gitlab.com/libvirt/libvirt/-/blob/master/tools/virsh-domain-monitor… I haven’t investigated how other languages' bindings treat the field. Currently, my code treats anything over 2 as autostart being enabled (although, perhaps I should ignore 5+). I feel like that pretty closely represents the VM’s configuration, since it will autostart in certain cases and it definitely isn’t configured to never autostart. For 3 (“Restart if previously active.”), it could be argued that libvirt should only say that autostart is enabled when the VM is running. This would more closely represent what the VM’s runtime behavior will be, since `virsh list —autostart` would show you which VMs would boot if the hypervisor rebooted at that point in time. However, it could be considered confusing because the VM’s configuration would appear to change depending on whether or not it was running. Ultimately, it seems like libvirt’s concept of autostart functionality needs to be extended. Along those lines, it was pointed out on IRC that libvirt lacks the ability to represent hypervisors’ host shutdown activities: > danpb: we should introduce a <on_hoststop>..</on_hoststop> lifecycle action in the XML to express what actions to take on host shutdown and one of those actions can be “stop-and-restart-on-next-boot” Hyper-V has a separate setting, AutomaticShutdownAction, which governs the actions taken when the host stops: * 2 means “Turn off.” This abruptly powers off the VM. * 3 means “Save state.” This saves the running VM’s state to disk. * 4 means “Shutdown.” The performs a clean shutdown of the VM. * 5 through 32768 are reserved. It seems to me that the two settings complement each other but cover different functionality. I feel like 3 (“Restart if previously active.”) is more closely related to startup activities than the host stopping. Since it seems like more pervasive changes are needed, I’d prefer to commit something “good enough” for the Hyper-V driver and then refine it along with the rest of the drivers. Should I make domainGetAutostart only output true for Hyper-V VMs configured with AutomaticStartupAction=3 when they are running? Or, should I leave it as I currently have it (2 = autostart is disabled; 3+ = autostart is enabled)? Thanks for your time and input, and apologies for how long this got. Matt

2 2

[PATCH] tests: qemucapabilities: Update capabilities for qemu-5.2 dev cycle
by Peter Krempa 28 Sep '20

28 Sep '20

Mid-cycle caps resync. Notable change is that virtio-blk enables multiqueue by default and the addition of 'calc-dirty-rate'/'query-dirty-rate' QMP commands. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- .../caps_5.2.0.x86_64.replies | 2898 +++++++++-------- 1 file changed, 1494 insertions(+), 1404 deletions(-) diff --git a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies index fb6f6477d9..a4b723ceb6 100644 --- a/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies +++ b/tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies @@ -240,6 +240,12 @@ { "name": "transaction" }, + { + "name": "query-dirty-rate" + }, + { + "name": "calc-dirty-rate" + }, { "name": "migrate-pause" }, @@ -625,6 +631,10 @@ "name": "vhost-user-vsock-device", "parent": "vhost-vsock-common" }, + { + "name": "virtio-blk-pci-transitional", + "parent": "virtio-blk-pci-base" + }, { "name": "pcie-pci-bridge", "parent": "base-pci-bridge" @@ -633,10 +643,6 @@ "name": "pc-q35-2.11-machine", "parent": "generic-pc-machine" }, - { - "name": "virtio-crypto-device", - "parent": "virtio-device" - }, { "name": "isa-applesmc", "parent": "isa-device" @@ -654,16 +660,16 @@ "parent": "bus" }, { - "name": "Denverton-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "virtio-crypto-device", + "parent": "virtio-device" }, { "name": "chardev-testdev", "parent": "chardev" }, { - "name": "usb-wacom-tablet", - "parent": "usb-device" + "name": "Denverton-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "pci-ipmi-bt", @@ -682,8 +688,8 @@ "parent": "netfilter" }, { - "name": "Icelake-Server-v1-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "usb-wacom-tablet", + "parent": "usb-device" }, { "name": "ich9-usb-uhci6", @@ -721,14 +727,14 @@ "name": "sev-guest", "parent": "object" }, - { - "name": "core2duo-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "ich9-usb-uhci5", "parent": "pci-uhci-usb" }, + { + "name": "core2duo-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "pcm3680_pci", "parent": "pci-device" @@ -773,6 +779,10 @@ "name": "usb-hub", "parent": "usb-device" }, + { + "name": "chardev-serial", + "parent": "chardev-fd" + }, { "name": "virtio-blk-device", "parent": "virtio-device" @@ -813,30 +823,26 @@ "name": "qtest-accel", "parent": "accel" }, - { - "name": "chardev-serial", - "parent": "chardev-fd" - }, { "name": "vhost-user-vsock-pci", "parent": "vhost-user-vsock-pci-base" }, { - "name": "Icelake-Client-v2-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "ich9-usb-uhci1", + "parent": "pci-uhci-usb" }, { "name": "pc-i440fx-5.0-machine", "parent": "generic-pc-machine" }, - { - "name": "ich9-usb-uhci1", - "parent": "pci-uhci-usb" - }, { "name": "scsi-generic", "parent": "scsi-device" }, + { + "name": "Icelake-Client-v2-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "kvmclock", "parent": "sys-bus-device" @@ -897,6 +903,10 @@ "name": "virtio-serial-bus", "parent": "bus" }, + { + "name": "vhost-scsi-pci", + "parent": "vhost-scsi-pci-base" + }, { "name": "usb-host", "parent": "usb-device" @@ -922,8 +932,8 @@ "parent": "generic-pc-machine" }, { - "name": "vhost-scsi-pci", - "parent": "vhost-scsi-pci-base" + "name": "acpi-ged", + "parent": "sys-bus-device" }, { "name": "isa-ipmi-bt", @@ -941,14 +951,14 @@ "name": "pci-ipmi-kcs", "parent": "pci-device" }, - { - "name": "xio3130-downstream", - "parent": "pcie-slot" - }, { "name": "intel-iommu-iommu-memory-region", "parent": "qemu:iommu-memory-region" }, + { + "name": "xio3130-downstream", + "parent": "pcie-slot" + }, { "name": "vhost-user-vsock-pci-non-transitional", "parent": "vhost-user-vsock-pci-base" @@ -957,14 +967,14 @@ "name": "pc-i440fx-2.3-machine", "parent": "generic-pc-machine" }, - { - "name": "microvm-machine", - "parent": "x86-machine" - }, { "name": "PCI", "parent": "bus" }, + { + "name": "microvm-machine", + "parent": "x86-machine" + }, { "name": "sdhci-bus", "parent": "sd-bus" @@ -1121,10 +1131,6 @@ "name": "i82557b", "parent": "pci-device" }, - { - "name": "chardev-memory", - "parent": "chardev-ringbuf" - }, { "name": "i82557a", "parent": "pci-device" @@ -1137,6 +1143,10 @@ "name": "vmmouse", "parent": "isa-device" }, + { + "name": "chardev-udp", + "parent": "chardev" + }, { "name": "pc-q35-2.8-machine", "parent": "generic-pc-machine" @@ -1162,8 +1172,8 @@ "parent": "x86_64-cpu" }, { - "name": "chardev-udp", - "parent": "chardev" + "name": "chardev-memory", + "parent": "chardev-ringbuf" }, { "name": "EPYC-Rome-v1-x86_64-cpu", @@ -1213,14 +1223,14 @@ "name": "virtio-9p-pci-non-transitional", "parent": "virtio-9p-pci-base" }, - { - "name": "memory-backend-file", - "parent": "memory-backend" - }, { "name": "Nehalem-v2-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "memory-backend-file", + "parent": "memory-backend" + }, { "name": "vhost-vsock-device", "parent": "vhost-vsock-common" @@ -1281,6 +1291,10 @@ "name": "tcg-accel", "parent": "accel" }, + { + "name": "piix4-ide", + "parent": "pci-ide" + }, { "name": "virtio-balloon-pci", "parent": "virtio-balloon-pci-base" @@ -1305,6 +1319,14 @@ "name": "athlon-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "acpi-ged-x86", + "parent": "acpi-ged" + }, + { + "name": "ES1370", + "parent": "pci-device" + }, { "name": "i82551", "parent": "pci-device" @@ -1322,8 +1344,8 @@ "parent": "x86_64-cpu" }, { - "name": "pc-i440fx-2.6-machine", - "parent": "generic-pc-machine" + "name": "nvme", + "parent": "pci-device" }, { "name": "SandyBridge-x86_64-cpu", @@ -1334,17 +1356,13 @@ "parent": "pci-device" }, { - "name": "piix4-ide", - "parent": "pci-ide" + "name": "pc-i440fx-2.6-machine", + "parent": "generic-pc-machine" }, { "name": "mioe3680_pci", "parent": "pci-device" }, - { - "name": "nvme", - "parent": "pci-device" - }, { "name": "vhost-user-backend", "parent": "object" @@ -1358,17 +1376,13 @@ "parent": "base-xhci" }, { - "name": "ES1370", - "parent": "pci-device" + "name": "kvm-apic", + "parent": "apic-common" }, { "name": "Conroe-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "kvm-apic", - "parent": "apic-common" - }, { "name": "isa-pit", "parent": "pit-common" @@ -1405,14 +1419,14 @@ "name": "virtio-crypto-pci", "parent": "virtio-crypto-pci-base-type" }, - { - "name": "i8042", - "parent": "isa-device" - }, { "name": "iothread", "parent": "object" }, + { + "name": "i8042", + "parent": "isa-device" + }, { "name": "virtio-iommu-pci-transitional", "parent": "virtio-iommu-device-base" @@ -1449,6 +1463,10 @@ "name": "core2duo-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "virtio-rng-pci-non-transitional", + "parent": "virtio-rng-pci-base" + }, { "name": "cirrus-vga", "parent": "pci-device" @@ -1465,17 +1483,13 @@ "name": "pc-i440fx-2.1-machine", "parent": "generic-pc-machine" }, - { - "name": "virtio-serial-pci", - "parent": "virtio-serial-pci-base" - }, { "name": "i82559er", "parent": "pci-device" }, { - "name": "virtio-rng-pci-non-transitional", - "parent": "virtio-rng-pci-base" + "name": "virtio-serial-pci", + "parent": "virtio-serial-pci-base" }, { "name": "Skylake-Client-x86_64-cpu", @@ -1485,10 +1499,6 @@ "name": "Opteron_G3-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "isa-ide", - "parent": "isa-device" - }, { "name": "container", "parent": "object" @@ -1513,6 +1523,10 @@ "name": "vmport", "parent": "isa-device" }, + { + "name": "isa-ide", + "parent": "isa-device" + }, { "name": "am53c974", "parent": "pci-device" @@ -1533,14 +1547,14 @@ "name": "e1000-82545em", "parent": "e1000-base" }, - { - "name": "pxb-pcie-bus", - "parent": "PCIE" - }, { "name": "sdhci-pci", "parent": "pci-device" }, + { + "name": "pxb-pcie-bus", + "parent": "PCIE" + }, { "name": "vhost-user-scsi", "parent": "vhost-scsi-common" @@ -1838,8 +1852,8 @@ "parent": "x86_64-cpu" }, { - "name": "qio-net-listener", - "parent": "object" + "name": "qio-channel-websock", + "parent": "qio-channel" }, { "name": "pc-q35-4.1-machine", @@ -1862,8 +1876,8 @@ "parent": "x86_64-cpu" }, { - "name": "qio-channel-websock", - "parent": "qio-channel" + "name": "qio-net-listener", + "parent": "object" }, { "name": "edu", @@ -1942,8 +1956,8 @@ "parent": "chardev" }, { - "name": "clock", - "parent": "object" + "name": "virtio-net-device", + "parent": "virtio-device" }, { "name": "Haswell-v2-x86_64-cpu", @@ -1978,8 +1992,8 @@ "parent": "sys-bus-device" }, { - "name": "secret", - "parent": "secret_common" + "name": "clock", + "parent": "object" }, { "name": "virtconsole", @@ -2002,8 +2016,8 @@ "parent": "scsi-disk-base" }, { - "name": "Cascadelake-Server-noTSX-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "secret", + "parent": "secret_common" }, { "name": "usb-kbd", @@ -2014,20 +2028,20 @@ "parent": "isa-device" }, { - "name": "virtio-net-device", - "parent": "virtio-device" + "name": "usb-mtp", + "parent": "usb-device" }, { "name": "filter-replay", "parent": "netfilter" }, { - "name": "input-linux", - "parent": "object" + "name": "Cascadelake-Server-noTSX-x86_64-cpu", + "parent": "x86_64-cpu" }, { - "name": "usb-mtp", - "parent": "usb-device" + "name": "input-linux", + "parent": "object" }, { "name": "pc-q35-2.9-machine", @@ -2181,14 +2195,14 @@ "name": "pc-dimm", "parent": "device" }, - { - "name": "virtio-net-pci-transitional", - "parent": "virtio-net-pci-base" - }, { "name": "virtio-balloon-pci-non-transitional", "parent": "virtio-balloon-pci-base" }, + { + "name": "virtio-net-pci-transitional", + "parent": "virtio-net-pci-base" + }, { "name": "ipmi-bmc-sim", "parent": "ipmi-bmc" @@ -2249,14 +2263,14 @@ "name": "colo-compare", "parent": "object" }, - { - "name": "virtio-mmio", - "parent": "sys-bus-device" - }, { "name": "pxb-bus", "parent": "PCI" }, + { + "name": "virtio-mmio", + "parent": "sys-bus-device" + }, { "name": "pentium2-x86_64-cpu", "parent": "x86_64-cpu" @@ -2297,6 +2311,10 @@ "name": "Nehalem-v1-x86_64-cpu", "parent": "x86_64-cpu" }, + { + "name": "authz-simple", + "parent": "authz" + }, { "name": "Opteron_G2-x86_64-cpu", "parent": "x86_64-cpu" @@ -2309,14 +2327,14 @@ "name": "vhost-user-blk-pci", "parent": "vhost-user-blk-pci-base" }, - { - "name": "authz-simple", - "parent": "authz" - }, { "name": "fw_cfg_io", "parent": "fw_cfg" }, + { + "name": "pc-1.1-machine", + "parent": "generic-pc-machine" + }, { "name": "intel-iommu", "parent": "x86-iommu" @@ -2334,8 +2352,8 @@ "parent": "x86_64-cpu" }, { - "name": "pc-1.1-machine", - "parent": "generic-pc-machine" + "name": "u2f-passthru", + "parent": "u2f-key" }, { "name": "Snowridge-x86_64-cpu", @@ -2473,14 +2491,14 @@ "name": "vhost-user-gpu", "parent": "virtio-gpu-base" }, - { - "name": "pentium-v1-x86_64-cpu", - "parent": "x86_64-cpu" - }, { "name": "hda-duplex", "parent": "hda-audio" }, + { + "name": "pentium-v1-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "amd-iommu-iommu-memory-region", "parent": "qemu:iommu-memory-region" @@ -2489,6 +2507,10 @@ "name": "can-bus", "parent": "object" }, + { + "name": "virtio-balloon-device", + "parent": "virtio-device" + }, { "name": "cfi.pflash01", "parent": "sys-bus-device" @@ -2501,10 +2523,6 @@ "name": "Cooperlake-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "virtio-balloon-device", - "parent": "virtio-device" - }, { "name": "isa-parallel", "parent": "isa-device" @@ -2558,20 +2576,20 @@ "parent": "rng-backend" }, { - "name": "ivshmem-doorbell", - "parent": "ivshmem-common" + "name": "Cascadelake-Server-x86_64-cpu", + "parent": "x86_64-cpu" }, { "name": "i82558b", "parent": "pci-device" }, { - "name": "qxl-vga", - "parent": "pci-qxl" + "name": "ivshmem-doorbell", + "parent": "ivshmem-common" }, { - "name": "Cascadelake-Server-x86_64-cpu", - "parent": "x86_64-cpu" + "name": "qxl-vga", + "parent": "pci-qxl" }, { "name": "virtio-iommu-device", @@ -2753,16 +2771,16 @@ "name": "kvm64-v1-x86_64-cpu", "parent": "x86_64-cpu" }, - { - "name": "scsi-block", - "parent": "scsi-disk-base" - }, { "name": "mptsas1068", "parent": "pci-device" }, { - "name": "Snowridge-v1-x86_64-cpu", + "name": "scsi-block", + "parent": "scsi-disk-base" + }, + { + "name": "Snowridge-v1-x86_64-cpu", "parent": "x86_64-cpu" }, { @@ -2849,14 +2867,14 @@ "name": "qio-channel-tls", "parent": "qio-channel" }, - { - "name": "virtio-blk-pci-transitional", - "parent": "virtio-blk-pci-base" - }, { "name": "virtio-vga", "parent": "virtio-vga-base-type" }, + { + "name": "Icelake-Server-v1-x86_64-cpu", + "parent": "x86_64-cpu" + }, { "name": "authz-pam", "parent": "authz" @@ -3045,7 +3063,7 @@ "type": "uint32" }, { - "default-value": 1, + "default-value": 65535, "name": "num-queues", "type": "uint16" }, @@ -3778,7 +3796,7 @@ "type": "bool" }, { - "default-value": 1, + "default-value": 4294967295, "name": "num_queues", "type": "uint32" }, @@ -4458,6 +4476,11 @@ "name": "disable_s3", "type": "uint8" }, + { + "default-value": true, + "name": "acpi-root-pci-hotplug", + "type": "bool" + }, { "default-value": true, "name": "memory-hotplug-support", @@ -4553,33 +4576,37 @@ "name": "x-config-reg-migration-enabled", "type": "bool" }, + { + "name": "pci-hole-end", + "type": "uint32" + }, { "default-value": 2147483648, "name": "pci-hole64-size", "type": "size" }, + { + "name": "pci-hole64-start", + "type": "uint64" + }, { "default-value": 0, "name": "short_root_bus", "type": "uint32" }, + { + "name": "pci-hole64-end", + "type": "uint64" + }, { "default-value": true, "name": "x-pci-hole64-fix", "type": "bool" }, { - "name": "pci-hole-end", + "name": "pci-hole-start", "type": "uint32" }, - { - "name": "pci-hole64-start", - "type": "uint64" - }, - { - "name": "pci-hole64-end", - "type": "uint64" - }, { "name": "pci-conf-idx[0]", "type": "child<qemu:memory-region>" @@ -4587,10 +4614,6 @@ { "name": "pci-conf-data[0]", "type": "child<qemu:memory-region>" - }, - { - "name": "pci-hole-start", - "type": "uint32" } ], "id": "libvirt-18" @@ -6484,6 +6507,10 @@ "name": "memory", "type": "link<qemu:memory-region>" }, + { + "name": "start-powered-off", + "type": "bool" + }, { "name": "legacy-memory", "type": "str" @@ -8144,6 +8171,14 @@ "deprecated": false, "default-ram-id": "pc.ram" }, + { + "hotpluggable-cpus": false, + "name": "none", + "numa-mem-supported": false, + "cpu-max": 1, + "deprecated": false, + "default-ram-id": "ram" + }, { "hotpluggable-cpus": true, "name": "pc-1.1", @@ -8153,14 +8188,6 @@ "deprecated": true, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": false, - "name": "none", - "numa-mem-supported": false, - "cpu-max": 1, - "deprecated": false, - "default-ram-id": "ram" - }, { "hotpluggable-cpus": true, "name": "pc-i440fx-2.7", @@ -10284,13 +10311,97 @@ }, { "parameters": [ + { + "name": "audiodev", + "type": "string" + }, + { + "name": "non-adaptive", + "type": "boolean" + }, + { + "name": "lossy", + "type": "boolean" + }, + { + "name": "sasl-authz", + "type": "string" + }, + { + "name": "tls-authz", + "type": "string" + }, + { + "name": "acl", + "type": "boolean" + }, + { + "name": "sasl", + "type": "boolean" + }, + { + "name": "key-delay-ms", + "type": "number" + }, + { + "name": "lock-key-sync", + "type": "boolean" + }, + { + "name": "reverse", + "type": "boolean" + }, + { + "name": "password", + "type": "boolean" + }, + { + "name": "ipv6", + "type": "boolean" + }, + { + "name": "ipv4", + "type": "boolean" + }, + { + "name": "to", + "type": "number" + }, + { + "name": "connections", + "type": "number" + }, + { + "name": "head", + "type": "number" + }, + { + "name": "display", + "type": "string" + }, + { + "name": "share", + "type": "string" + }, + { + "name": "tls-creds", + "type": "string" + }, + { + "name": "websocket", + "type": "string" + }, + { + "name": "vnc", + "type": "string" + } ], - "option": "acpi" + "option": "vnc" }, { "parameters": [ ], - "option": "smbios" + "option": "acpi" }, { "parameters": [ @@ -10421,6 +10532,36 @@ ], "option": "spice" }, + { + "parameters": [ + { + "name": "resourcecontrol", + "type": "string" + }, + { + "name": "spawn", + "type": "string" + }, + { + "name": "elevateprivileges", + "type": "string" + }, + { + "name": "obsolete", + "type": "string" + }, + { + "name": "enable", + "type": "boolean" + } + ], + "option": "sandbox" + }, + { + "parameters": [ + ], + "option": "smbios" + }, { "parameters": [ { @@ -10613,192 +10754,78 @@ { "parameters": [ { - "name": "audiodev", + "name": "gen_id", + "help": "Sets id of the object generating the fw_cfg blob to be inserted", "type": "string" }, { - "name": "non-adaptive", - "type": "boolean" - }, - { - "name": "lossy", - "type": "boolean" + "name": "string", + "help": "Sets content of the blob to be inserted from a string", + "type": "string" }, { - "name": "sasl-authz", + "name": "file", + "help": "Sets the name of the file from which the fw_cfg blob will be loaded", "type": "string" }, { - "name": "tls-authz", + "name": "name", + "help": "Sets the fw_cfg name of the blob to be inserted", "type": "string" - }, + } + ], + "option": "fw_cfg" + }, + { + "parameters": [ + ], + "option": "" + }, + { + "parameters": [ { - "name": "acl", - "type": "boolean" + "name": "rrsnapshot", + "type": "string" }, { - "name": "sasl", - "type": "boolean" + "name": "rrfile", + "type": "string" }, { - "name": "key-delay-ms", - "type": "number" + "name": "rr", + "type": "string" }, { - "name": "lock-key-sync", + "name": "sleep", "type": "boolean" }, { - "name": "reverse", + "name": "align", "type": "boolean" }, { - "name": "password", - "type": "boolean" - }, + "name": "shift", + "type": "string" + } + ], + "option": "icount" + }, + { + "parameters": [ + ], + "option": "numa" + }, + { + "parameters": [ { - "name": "ipv6", + "name": "debug-threads", + "help": "When enabled, name the individual threads; defaults off.\nNOTE: The thread names are for debugging and not a\nstable API.", "type": "boolean" }, { - "name": "ipv4", - "type": "boolean" - }, - { - "name": "to", - "type": "number" - }, - { - "name": "connections", - "type": "number" - }, - { - "name": "head", - "type": "number" - }, - { - "name": "display", - "type": "string" - }, - { - "name": "share", - "type": "string" - }, - { - "name": "tls-creds", - "type": "string" - }, - { - "name": "websocket", - "type": "string" - }, - { - "name": "vnc", - "type": "string" - } - ], - "option": "vnc" - }, - { - "parameters": [ - { - "name": "resourcecontrol", - "type": "string" - }, - { - "name": "spawn", - "type": "string" - }, - { - "name": "elevateprivileges", - "type": "string" - }, - { - "name": "obsolete", - "type": "string" - }, - { - "name": "enable", - "type": "boolean" - } - ], - "option": "sandbox" - }, - { - "parameters": [ - { - "name": "gen_id", - "help": "Sets id of the object generating the fw_cfg blob to be inserted", - "type": "string" - }, - { - "name": "string", - "help": "Sets content of the blob to be inserted from a string", - "type": "string" - }, - { - "name": "file", - "help": "Sets the name of the file from which the fw_cfg blob will be loaded", - "type": "string" - }, - { - "name": "name", - "help": "Sets the fw_cfg name of the blob to be inserted", - "type": "string" - } - ], - "option": "fw_cfg" - }, - { - "parameters": [ - ], - "option": "" - }, - { - "parameters": [ - { - "name": "rrsnapshot", - "type": "string" - }, - { - "name": "rrfile", - "type": "string" - }, - { - "name": "rr", - "type": "string" - }, - { - "name": "sleep", - "type": "boolean" - }, - { - "name": "align", - "type": "boolean" - }, - { - "name": "shift", - "type": "string" - } - ], - "option": "icount" - }, - { - "parameters": [ - ], - "option": "numa" - }, - { - "parameters": [ - { - "name": "debug-threads", - "help": "When enabled, name the individual threads; defaults off.\nNOTE: The thread names are for debugging and not a\nstable API.", - "type": "boolean" - }, - { - "name": "process", - "help": "Sets the name of the QEMU process, as shown in top etc", - "type": "string" + "name": "process", + "help": "Sets the name of the QEMU process, as shown in top etc", + "type": "string" }, { "name": "guest", @@ -12562,44 +12589,56 @@ "arg-type": "150" }, { - "name": "transaction", + "name": "calc-dirty-rate", "ret-type": "0", "meta-type": "command", "arg-type": "151" }, + { + "name": "query-dirty-rate", + "ret-type": "152", + "meta-type": "command", + "arg-type": "0" + }, + { + "name": "transaction", + "ret-type": "0", + "meta-type": "command", + "arg-type": "153" + }, { "name": "trace-event-get-state", - "ret-type": "[153]", + "ret-type": "[155]", "meta-type": "command", - "arg-type": "152" + "arg-type": "154" }, { "name": "trace-event-set-state", "ret-type": "0", "meta-type": "command", - "arg-type": "154" + "arg-type": "156" }, { "name": "qmp_capabilities", "ret-type": "0", "meta-type": "command", - "arg-type": "155" + "arg-type": "157" }, { "name": "query-version", - "ret-type": "156", + "ret-type": "158", "meta-type": "command", "arg-type": "0" }, { "name": "query-commands", - "ret-type": "[157]", + "ret-type": "[159]", "meta-type": "command", "arg-type": "0" }, { "name": "query-events", - "ret-type": "[158]", + "ret-type": "[160]", "meta-type": "command", "arg-type": "0", "features": [ @@ -12614,78 +12653,78 @@ }, { "name": "query-qmp-schema", - "ret-type": "[159]", + "ret-type": "[161]", "meta-type": "command", "arg-type": "0" }, { "name": "qom-list", - "ret-type": "[161]", + "ret-type": "[163]", "meta-type": "command", - "arg-type": "160" + "arg-type": "162" }, { "name": "qom-get", "ret-type": "any", "meta-type": "command", - "arg-type": "162" + "arg-type": "164" }, { "name": "qom-set", "ret-type": "0", "meta-type": "command", - "arg-type": "163" + "arg-type": "165" }, { "name": "qom-list-types", - "ret-type": "[165]", + "ret-type": "[167]", "meta-type": "command", - "arg-type": "164" + "arg-type": "166" }, { "name": "qom-list-properties", - "ret-type": "[161]", + "ret-type": "[163]", "meta-type": "command", - "arg-type": "166" + "arg-type": "168" }, { "name": "object-add", "ret-type": "0", "meta-type": "command", - "arg-type": "167" + "arg-type": "169" }, { "name": "object-del", "ret-type": "0", "meta-type": "command", - "arg-type": "168" + "arg-type": "170" }, { "name": "device-list-properties", - "ret-type": "[161]", + "ret-type": "[163]", "meta-type": "command", - "arg-type": "169" + "arg-type": "171" }, { "name": "device_add", "ret-type": "0", "meta-type": "command", - "arg-type": "170" + "arg-type": "172" }, { "name": "device_del", "ret-type": "0", "meta-type": "command", - "arg-type": "171" + "arg-type": "173" }, { "name": "DEVICE_DELETED", "meta-type": "event", - "arg-type": "172" + "arg-type": "174" }, { "name": "query-cpus", - "ret-type": "[173]", + "ret-type": "[175]", "meta-type": "command", "arg-type": "0", "features": [ @@ -12694,7 +12733,7 @@ }, { "name": "query-cpus-fast", - "ret-type": "[174]", + "ret-type": "[176]", "meta-type": "command", "arg-type": "0" }, @@ -12702,38 +12741,38 @@ "name": "cpu-add", "ret-type": "0", "meta-type": "command", - "arg-type": "175", + "arg-type": "177", "features": [ "deprecated" ] }, { "name": "query-machines", - "ret-type": "[176]", + "ret-type": "[178]", "meta-type": "command", "arg-type": "0" }, { "name": "query-current-machine", - "ret-type": "177", + "ret-type": "179", "meta-type": "command", "arg-type": "0" }, { "name": "query-target", - "ret-type": "178", + "ret-type": "180", "meta-type": "command", "arg-type": "0" }, { "name": "query-memdev", - "ret-type": "[179]", + "ret-type": "[181]", "meta-type": "command", "arg-type": "0" }, { "name": "query-hotpluggable-cpus", - "ret-type": "[180]", + "ret-type": "[182]", "meta-type": "command", "arg-type": "0" }, @@ -12741,17 +12780,17 @@ "name": "set-numa-node", "ret-type": "0", "meta-type": "command", - "arg-type": "181" + "arg-type": "183" }, { "name": "query-cpu-model-expansion", - "ret-type": "187", + "ret-type": "189", "meta-type": "command", - "arg-type": "186" + "arg-type": "188" }, { "name": "query-cpu-definitions", - "ret-type": "[188]", + "ret-type": "[190]", "meta-type": "command", "arg-type": "0" }, @@ -12759,46 +12798,46 @@ "name": "add_client", "ret-type": "0", "meta-type": "command", - "arg-type": "189" + "arg-type": "191" }, { "name": "query-name", - "ret-type": "190", + "ret-type": "192", "meta-type": "command", "arg-type": "0" }, { "name": "query-kvm", - "ret-type": "191", + "ret-type": "193", "meta-type": "command", "arg-type": "0" }, { "name": "query-uuid", - "ret-type": "192", + "ret-type": "194", "meta-type": "command", "arg-type": "0" }, { "name": "query-iothreads", - "ret-type": "[193]", + "ret-type": "[195]", "meta-type": "command", "arg-type": "0" }, { "name": "query-balloon", - "ret-type": "194", + "ret-type": "196", "meta-type": "command", "arg-type": "0" }, { "name": "BALLOON_CHANGE", "meta-type": "event", - "arg-type": "195" + "arg-type": "197" }, { "name": "query-pci", - "ret-type": "[196]", + "ret-type": "[198]", "meta-type": "command", "arg-type": "0" }, @@ -12824,13 +12863,13 @@ "name": "memsave", "ret-type": "0", "meta-type": "command", - "arg-type": "197" + "arg-type": "199" }, { "name": "pmemsave", "ret-type": "0", "meta-type": "command", - "arg-type": "198" + "arg-type": "200" }, { "name": "cont", @@ -12860,13 +12899,13 @@ "name": "balloon", "ret-type": "0", "meta-type": "command", - "arg-type": "199" + "arg-type": "201" }, { "name": "human-monitor-command", "ret-type": "str", "meta-type": "command", - "arg-type": "200", + "arg-type": "202", "features": [ "savevm-monitor-nodes" ] @@ -12875,7 +12914,7 @@ "name": "change", "ret-type": "0", "meta-type": "command", - "arg-type": "201", + "arg-type": "203", "features": [ "deprecated" ] @@ -12884,93 +12923,93 @@ "name": "xen-set-global-dirty-log", "ret-type": "0", "meta-type": "command", - "arg-type": "202" + "arg-type": "204" }, { "name": "getfd", "ret-type": "0", "meta-type": "command", - "arg-type": "203" + "arg-type": "205" }, { "name": "closefd", "ret-type": "0", "meta-type": "command", - "arg-type": "204" + "arg-type": "206" }, { "name": "query-memory-size-summary", - "ret-type": "205", + "ret-type": "207", "meta-type": "command", "arg-type": "0" }, { "name": "add-fd", - "ret-type": "207", + "ret-type": "209", "meta-type": "command", - "arg-type": "206" + "arg-type": "208" }, { "name": "remove-fd", "ret-type": "0", "meta-type": "command", - "arg-type": "208" + "arg-type": "210" }, { "name": "query-fdsets", - "ret-type": "[209]", + "ret-type": "[211]", "meta-type": "command", "arg-type": "0" }, { "name": "query-command-line-options", - "ret-type": "[211]", + "ret-type": "[213]", "meta-type": "command", - "arg-type": "210" + "arg-type": "212" }, { "name": "query-memory-devices", - "ret-type": "[212]", + "ret-type": "[214]", "meta-type": "command", "arg-type": "0" }, { "name": "MEMORY_DEVICE_SIZE_CHANGE", "meta-type": "event", - "arg-type": "213" + "arg-type": "215" }, { "name": "MEM_UNPLUG_ERROR", "meta-type": "event", - "arg-type": "214" + "arg-type": "216" }, { "name": "query-acpi-ospm-status", - "ret-type": "[215]", + "ret-type": "[217]", "meta-type": "command", "arg-type": "0" }, { "name": "ACPI_DEVICE_OST", "meta-type": "event", - "arg-type": "216" + "arg-type": "218" }, { "name": "xen-load-devices-state", "ret-type": "0", "meta-type": "command", - "arg-type": "217" + "arg-type": "219" }, { "name": "query-vm-generation-id", - "ret-type": "218", + "ret-type": "220", "meta-type": "command", "arg-type": "0" }, { "name": "RTC_CHANGE", "meta-type": "event", - "arg-type": "219" + "arg-type": "221" }, { "name": "rtc-reset-reinjection", @@ -12980,19 +13019,19 @@ }, { "name": "query-sev", - "ret-type": "220", + "ret-type": "222", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-launch-measure", - "ret-type": "221", + "ret-type": "223", "meta-type": "command", "arg-type": "0" }, { "name": "query-sev-capabilities", - "ret-type": "222", + "ret-type": "224", "meta-type": "command", "arg-type": "0" }, @@ -13015,7 +13054,7 @@ }, { "name": "status", - "type": "225" + "type": "227" } ], "meta-type": "object" @@ -13029,7 +13068,7 @@ }, { "name": "reason", - "type": "226" + "type": "228" } ], "meta-type": "object" @@ -13043,7 +13082,7 @@ }, { "name": "reason", - "type": "226" + "type": "228" } ], "meta-type": "object" @@ -13053,7 +13092,7 @@ "members": [ { "name": "action", - "type": "227" + "type": "229" } ], "meta-type": "object" @@ -13063,7 +13102,7 @@ "members": [ { "name": "action", - "type": "227" + "type": "229" } ], "meta-type": "object" @@ -13073,12 +13112,12 @@ "members": [ { "name": "action", - "type": "228" + "type": "230" }, { "name": "info", "default": null, - "type": "229" + "type": "231" } ], "meta-type": "object" @@ -13088,12 +13127,12 @@ "members": [ { "name": "action", - "type": "228" + "type": "230" }, { "name": "info", "default": null, - "type": "229" + "type": "231" } ], "meta-type": "object" @@ -13236,7 +13275,7 @@ { "name": "read-only-mode", "default": null, - "type": "230" + "type": "232" } ], "meta-type": "object" @@ -13458,12 +13497,12 @@ { "name": "io-status", "default": null, - "type": "231" + "type": "233" }, { "name": "dirty-bitmaps", "default": null, - "type": "[232]", + "type": "[234]", "features": [ "deprecated" ] @@ -13507,12 +13546,12 @@ }, { "name": "stats", - "type": "233" + "type": "235" }, { "name": "driver-specific", "default": null, - "type": "234" + "type": "236" }, { "name": "parent", @@ -13565,7 +13604,7 @@ }, { "name": "io-status", - "type": "231" + "type": "233" }, { "name": "ready", @@ -13573,7 +13612,7 @@ }, { "name": "status", - "type": "235" + "type": "237" }, { "name": "auto-finalize", @@ -13661,7 +13700,7 @@ { "name": "mode", "default": null, - "type": "236" + "type": "238" } ], "meta-type": "object" @@ -13749,7 +13788,7 @@ { "name": "on-error", "default": null, - "type": "237" + "type": "239" }, { "name": "filter-node-name", @@ -13783,7 +13822,7 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "speed", @@ -13798,7 +13837,7 @@ { "name": "bitmap-mode", "default": null, - "type": "239" + "type": "241" }, { "name": "compress", @@ -13808,12 +13847,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "auto-finalize", @@ -13842,7 +13881,7 @@ { "name": "mode", "default": null, - "type": "236" + "type": "238" } ], "meta-type": "object" @@ -13861,7 +13900,7 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "speed", @@ -13876,7 +13915,7 @@ { "name": "bitmap-mode", "default": null, - "type": "239" + "type": "241" }, { "name": "compress", @@ -13886,12 +13925,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "auto-finalize", @@ -13973,7 +14012,7 @@ }, { "name": "detect_zeroes", - "type": "240" + "type": "242" }, { "name": "bps", @@ -14001,7 +14040,7 @@ }, { "name": "image", - "type": "241" + "type": "243" }, { "name": "bps_max", @@ -14075,7 +14114,7 @@ }, { "name": "cache", - "type": "242" + "type": "244" }, { "name": "write_threshold", @@ -14084,7 +14123,7 @@ { "name": "dirty-bitmaps", "default": null, - "type": "[232]" + "type": "[234]" } ], "meta-type": "object" @@ -14094,11 +14133,11 @@ "members": [ { "name": "nodes", - "type": "[243]" + "type": "[245]" }, { "name": "edges", - "type": "[244]" + "type": "[246]" } ], "meta-type": "object" @@ -14136,12 +14175,12 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "mode", "default": null, - "type": "236" + "type": "238" }, { "name": "speed", @@ -14161,12 +14200,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "unmap", @@ -14176,7 +14215,7 @@ { "name": "copy-mode", "default": null, - "type": "245" + "type": "247" }, { "name": "auto-finalize", @@ -14247,7 +14286,7 @@ }, { "name": "bitmaps", - "type": "[246]" + "type": "[248]" } ], "meta-type": "object" @@ -14285,7 +14324,7 @@ }, { "name": "sync", - "type": "238" + "type": "240" }, { "name": "speed", @@ -14305,12 +14344,12 @@ { "name": "on-source-error", "default": null, - "type": "237" + "type": "239" }, { "name": "on-target-error", "default": null, - "type": "237" + "type": "239" }, { "name": "filter-node-name", @@ -14320,7 +14359,7 @@ { "name": "copy-mode", "default": null, - "type": "245" + "type": "247" }, { "name": "auto-finalize", @@ -14370,7 +14409,7 @@ { "name": "on-error", "default": null, - "type": "237" + "type": "239" }, { "name": "auto-finalize", @@ -14470,169 +14509,169 @@ "variants": [ { "case": "blkdebug", - "type": "250" + "type": "252" }, { "case": "blklogwrites", - "type": "251" + "type": "253" }, { "case": "blkverify", - "type": "252" + "type": "254" }, { "case": "blkreplay", - "type": "253" + "type": "255" }, { "case": "bochs", - "type": "254" + "type": "256" }, { "case": "cloop", - "type": "254" + "type": "256" }, { "case": "compress", - "type": "254" + "type": "256" }, { "case": "copy-on-read", - "type": "254" + "type": "256" }, { "case": "dmg", - "type": "254" + "type": "256" }, { "case": "file", - "type": "255" + "type": "257" }, { "case": "ftp", - "type": "256" + "type": "258" }, { "case": "ftps", - "type": "257" + "type": "259" }, { "case": "gluster", - "type": "258" + "type": "260" }, { "case": "host_cdrom", - "type": "255" + "type": "257" }, { "case": "host_device", - "type": "255" + "type": "257" }, { "case": "http", - "type": "259" + "type": "261" }, { "case": "https", - "type": "260" + "type": "262" }, { "case": "iscsi", - "type": "261" + "type": "263" }, { "case": "luks", - "type": "262" + "type": "264" }, { "case": "nbd", - "type": "263" + "type": "265" }, { "case": "nfs", - "type": "264" + "type": "266" }, { "case": "null-aio", - "type": "265" + "type": "267" }, { "case": "null-co", - "type": "265" + "type": "267" }, { "case": "nvme", - "type": "266" + "type": "268" }, { "case": "parallels", - "type": "254" + "type": "256" }, { "case": "qcow2", - "type": "267" + "type": "269" }, { "case": "qcow", - "type": "268" + "type": "270" }, { "case": "qed", - "type": "269" + "type": "271" }, { "case": "quorum", - "type": "270" + "type": "272" }, { "case": "raw", - "type": "271" + "type": "273" }, { "case": "rbd", - "type": "272" + "type": "274" }, { "case": "replication", - "type": "273" + "type": "275" }, { "case": "sheepdog", - "type": "274" + "type": "276" }, { "case": "ssh", - "type": "275" + "type": "277" }, { "case": "throttle", - "type": "276" + "type": "278" }, { "case": "vdi", - "type": "254" + "type": "256" }, { "case": "vhdx", - "type": "254" + "type": "256" }, { "case": "vmdk", - "type": "269" + "type": "271" }, { "case": "vpc", - "type": "254" + "type": "256" }, { "case": "vvfat", - "type": "277" + "type": "279" } ], "members": [ { "name": "driver", - "type": "247" + "type": "249" }, { "name": "node-name", @@ -14642,12 +14681,12 @@ { "name": "discard", "default": null, - "type": "248" + "type": "250" }, { "name": "cache", "default": null, - "type": "249" + "type": "251" }, { "name": "read-only", @@ -14667,7 +14706,7 @@ { "name": "detect-zeroes", "default": null, - "type": "240" + "type": "242" } ], "meta-type": "object" @@ -14691,7 +14730,7 @@ }, { "name": "options", - "type": "278" + "type": "280" } ], "meta-type": "object" @@ -14709,7 +14748,7 @@ }, { "name": "options", - "type": "279" + "type": "281" }, { "name": "force", @@ -14766,11 +14805,11 @@ }, { "name": "operation", - "type": "280" + "type": "282" }, { "name": "action", - "type": "281" + "type": "283" }, { "name": "nospace", @@ -14789,7 +14828,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "device", @@ -14820,7 +14859,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "device", @@ -14850,11 +14889,11 @@ }, { "name": "operation", - "type": "280" + "type": "282" }, { "name": "action", - "type": "281" + "type": "283" } ], "meta-type": "object" @@ -14864,7 +14903,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "device", @@ -14890,7 +14929,7 @@ "members": [ { "name": "type", - "type": "282" + "type": "284" }, { "name": "id", @@ -14960,7 +14999,7 @@ }, { "name": "iothread", - "type": "283" + "type": "285" }, { "name": "force", @@ -14975,7 +15014,7 @@ "members": [ { "name": "addr", - "type": "284" + "type": "286" }, { "name": "tls-creds", @@ -15030,7 +15069,7 @@ { "name": "mode", "default": null, - "type": "285" + "type": "287" } ], "meta-type": "object" @@ -15058,7 +15097,7 @@ "members": [ { "name": "type", - "type": "286" + "type": "288" }, { "name": "error", @@ -15157,7 +15196,7 @@ }, { "name": "status", - "type": "235" + "type": "237" } ], "meta-type": "object" @@ -15236,11 +15275,11 @@ }, { "name": "type", - "type": "282" + "type": "284" }, { "name": "status", - "type": "235" + "type": "237" }, { "name": "current-progress", @@ -15310,7 +15349,7 @@ { "name": "format", "default": null, - "type": "287" + "type": "289" } ], "meta-type": "object" @@ -15329,7 +15368,7 @@ { "name": "format", "default": null, - "type": "287" + "type": "289" } ], "meta-type": "object" @@ -15348,7 +15387,7 @@ }, { "name": "backend", - "type": "288" + "type": "290" } ], "meta-type": "object" @@ -15373,7 +15412,7 @@ }, { "name": "backend", - "type": "288" + "type": "290" } ], "meta-type": "object" @@ -15441,7 +15480,7 @@ { "name": "format", "default": null, - "type": "289" + "type": "291" } ], "meta-type": "object" @@ -15451,7 +15490,7 @@ "members": [ { "name": "status", - "type": "290" + "type": "292" }, { "name": "completed", @@ -15484,7 +15523,7 @@ "members": [ { "name": "formats", - "type": "[289]" + "type": "[291]" } ], "meta-type": "object" @@ -15509,47 +15548,47 @@ "variants": [ { "case": "nic", - "type": "292" + "type": "294" }, { "case": "user", - "type": "293" + "type": "295" }, { "case": "tap", - "type": "294" + "type": "296" }, { "case": "l2tpv3", - "type": "295" + "type": "297" }, { "case": "socket", - "type": "296" + "type": "298" }, { "case": "vde", - "type": "297" + "type": "299" }, { "case": "bridge", - "type": "298" + "type": "300" }, { "case": "hubport", - "type": "299" + "type": "301" }, { "case": "netmap", - "type": "300" + "type": "302" }, { "case": "vhost-user", - "type": "301" + "type": "303" }, { "case": "vhost-vdpa", - "type": "302" + "type": "304" }, { "case": "none", @@ -15563,7 +15602,7 @@ }, { "name": "type", - "type": "291" + "type": "293" } ], "meta-type": "object" @@ -15607,15 +15646,15 @@ }, { "name": "multicast", - "type": "303" + "type": "305" }, { "name": "unicast", - "type": "303" + "type": "305" }, { "name": "vlan", - "type": "303" + "type": "305" }, { "name": "broadcast-allowed", @@ -15791,11 +15830,11 @@ }, { "name": "duplex", - "type": "304" + "type": "306" }, { "name": "autoneg", - "type": "305" + "type": "307" } ], "meta-type": "object" @@ -15833,15 +15872,15 @@ }, { "name": "key", - "type": "306" + "type": "308" }, { "name": "mask", - "type": "307" + "type": "309" }, { "name": "action", - "type": "308" + "type": "310" } ], "meta-type": "object" @@ -15980,7 +16019,7 @@ }, { "name": "options", - "type": "309" + "type": "311" } ], "meta-type": "object" @@ -16076,12 +16115,12 @@ }, { "name": "mouse-mode", - "type": "310" + "type": "312" }, { "name": "channels", "default": null, - "type": "[311]" + "type": "[313]" } ], "meta-type": "object" @@ -16091,11 +16130,11 @@ "members": [ { "name": "server", - "type": "312" + "type": "314" }, { "name": "client", - "type": "312" + "type": "314" } ], "meta-type": "object" @@ -16105,11 +16144,11 @@ "members": [ { "name": "server", - "type": "313" + "type": "315" }, { "name": "client", - "type": "311" + "type": "313" } ], "meta-type": "object" @@ -16119,11 +16158,11 @@ "members": [ { "name": "server", - "type": "312" + "type": "314" }, { "name": "client", - "type": "312" + "type": "314" } ], "meta-type": "object" @@ -16143,7 +16182,7 @@ { "name": "family", "default": null, - "type": "314" + "type": "316" }, { "name": "service", @@ -16158,7 +16197,7 @@ { "name": "clients", "default": null, - "type": "[315]" + "type": "[317]" } ], "meta-type": "object" @@ -16177,20 +16216,20 @@ }, { "name": "server", - "type": "[316]" + "type": "[318]" }, { "name": "clients", - "type": "[315]" + "type": "[317]" }, { "name": "auth", - "type": "317" + "type": "319" }, { "name": "vencrypt", "default": null, - "type": "318" + "type": "320" }, { "name": "display", @@ -16215,11 +16254,11 @@ "members": [ { "name": "server", - "type": "319" + "type": "321" }, { "name": "client", - "type": "320" + "type": "322" } ], "meta-type": "object" @@ -16229,11 +16268,11 @@ "members": [ { "name": "server", - "type": "319" + "type": "321" }, { "name": "client", - "type": "315" + "type": "317" } ], "meta-type": "object" @@ -16243,11 +16282,11 @@ "members": [ { "name": "server", - "type": "319" + "type": "321" }, { "name": "client", - "type": "315" + "type": "317" } ], "meta-type": "object" @@ -16284,7 +16323,7 @@ "members": [ { "name": "keys", - "type": "[321]" + "type": "[323]" }, { "name": "hold-time", @@ -16309,7 +16348,7 @@ }, { "name": "events", - "type": "[322]" + "type": "[324]" } ], "meta-type": "object" @@ -16320,15 +16359,15 @@ "variants": [ { "case": "gtk", - "type": "325" + "type": "327" }, { "case": "curses", - "type": "326" + "type": "328" }, { "case": "egl-headless", - "type": "327" + "type": "329" }, { "case": "default", @@ -16354,7 +16393,7 @@ "members": [ { "name": "type", - "type": "323" + "type": "325" }, { "name": "full-screen", @@ -16374,7 +16413,7 @@ { "name": "gl", "default": null, - "type": "324" + "type": "326" } ], "meta-type": "object" @@ -16385,22 +16424,22 @@ { "name": "status", "default": null, - "type": "328" + "type": "330" }, { "name": "ram", "default": null, - "type": "329" + "type": "331" }, { "name": "disk", "default": null, - "type": "329" + "type": "331" }, { "name": "xbzrle-cache", "default": null, - "type": "330" + "type": "332" }, { "name": "total-time", @@ -16445,12 +16484,12 @@ { "name": "compression", "default": null, - "type": "331" + "type": "333" }, { "name": "socket-address", "default": null, - "type": "[332]" + "type": "[334]" } ], "meta-type": "object" @@ -16475,7 +16514,7 @@ "members": [ { "name": "capability", - "type": "333" + "type": "335" }, { "name": "state", @@ -16550,17 +16589,17 @@ { "name": "tls-creds", "default": null, - "type": "283" + "type": "285" }, { "name": "tls-hostname", "default": null, - "type": "283" + "type": "285" }, { "name": "tls-authz", "default": null, - "type": "283" + "type": "285" }, { "name": "max-bandwidth", @@ -16605,7 +16644,7 @@ { "name": "multifd-compression", "default": null, - "type": "334" + "type": "336" }, { "name": "multifd-zlib-level", @@ -16620,7 +16659,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[335]" + "type": "[337]" } ], "meta-type": "object" @@ -16746,7 +16785,7 @@ { "name": "multifd-compression", "default": null, - "type": "334" + "type": "336" }, { "name": "multifd-zlib-level", @@ -16761,7 +16800,7 @@ { "name": "block-bitmap-mapping", "default": null, - "type": "[335]" + "type": "[337]" } ], "meta-type": "object" @@ -16800,7 +16839,7 @@ "members": [ { "name": "status", - "type": "328" + "type": "330" } ], "meta-type": "object" @@ -16820,11 +16859,11 @@ "members": [ { "name": "mode", - "type": "336" + "type": "338" }, { "name": "reason", - "type": "337" + "type": "339" } ], "meta-type": "object" @@ -16834,7 +16873,7 @@ "members": [ { "name": "state", - "type": "328" + "type": "330" } ], "meta-type": "object" @@ -16968,15 +17007,15 @@ "members": [ { "name": "mode", - "type": "336" + "type": "338" }, { "name": "last-mode", - "type": "336" + "type": "338" }, { "name": "reason", - "type": "337" + "type": "339" } ], "meta-type": "object" @@ -17003,21 +17042,53 @@ }, { "name": "151", + "members": [ + { + "name": "calc-time", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "152", + "members": [ + { + "name": "dirty-rate", + "type": "int" + }, + { + "name": "status", + "type": "340" + }, + { + "name": "start-time", + "type": "int" + }, + { + "name": "calc-time", + "type": "int" + } + ], + "meta-type": "object" + }, + { + "name": "153", "members": [ { "name": "actions", - "type": "[338]" + "type": "[341]" }, { "name": "properties", "default": null, - "type": "339" + "type": "342" } ], "meta-type": "object" }, { - "name": "152", + "name": "154", "members": [ { "name": "name", @@ -17032,12 +17103,12 @@ "meta-type": "object" }, { - "name": "[153]", - "element-type": "153", + "name": "[155]", + "element-type": "155", "meta-type": "array" }, { - "name": "153", + "name": "155", "members": [ { "name": "name", @@ -17045,7 +17116,7 @@ }, { "name": "state", - "type": "340" + "type": "343" }, { "name": "vcpu", @@ -17055,7 +17126,7 @@ "meta-type": "object" }, { - "name": "154", + "name": "156", "members": [ { "name": "name", @@ -17079,22 +17150,22 @@ "meta-type": "object" }, { - "name": "155", + "name": "157", "members": [ { "name": "enable", "default": null, - "type": "[341]" + "type": "[344]" } ], "meta-type": "object" }, { - "name": "156", + "name": "158", "members": [ { "name": "qemu", - "type": "342" + "type": "345" }, { "name": "package", @@ -17104,12 +17175,12 @@ "meta-type": "object" }, { - "name": "[157]", - "element-type": "157", + "name": "[159]", + "element-type": "159", "meta-type": "array" }, { - "name": "157", + "name": "159", "members": [ { "name": "name", @@ -17119,12 +17190,12 @@ "meta-type": "object" }, { - "name": "[158]", - "element-type": "158", + "name": "[160]", + "element-type": "160", "meta-type": "array" }, { - "name": "158", + "name": "160", "members": [ { "name": "name", @@ -17134,41 +17205,41 @@ "meta-type": "object" }, { - "name": "[159]", - "element-type": "159", + "name": "[161]", + "element-type": "161", "meta-type": "array" }, { - "name": "159", + "name": "161", "tag": "meta-type", "variants": [ { "case": "builtin", - "type": "344" + "type": "347" }, { "case": "enum", - "type": "345" + "type": "348" }, { "case": "array", - "type": "346" + "type": "349" }, { "case": "object", - "type": "347" + "type": "350" }, { "case": "alternate", - "type": "348" + "type": "351" }, { "case": "command", - "type": "349" + "type": "352" }, { "case": "event", - "type": "350" + "type": "353" } ], "members": [ @@ -17178,7 +17249,7 @@ }, { "name": "meta-type", - "type": "343" + "type": "346" }, { "name": "features", @@ -17189,7 +17260,7 @@ "meta-type": "object" }, { - "name": "160", + "name": "162", "members": [ { "name": "path", @@ -17199,12 +17270,12 @@ "meta-type": "object" }, { - "name": "[161]", - "element-type": "161", + "name": "[163]", + "element-type": "163", "meta-type": "array" }, { - "name": "161", + "name": "163", "members": [ { "name": "name", @@ -17228,7 +17299,7 @@ "meta-type": "object" }, { - "name": "162", + "name": "164", "members": [ { "name": "path", @@ -17247,7 +17318,7 @@ "meta-type": "builtin" }, { - "name": "163", + "name": "165", "members": [ { "name": "path", @@ -17265,7 +17336,7 @@ "meta-type": "object" }, { - "name": "164", + "name": "166", "members": [ { "name": "implements", @@ -17281,12 +17352,12 @@ "meta-type": "object" }, { - "name": "[165]", - "element-type": "165", + "name": "[167]", + "element-type": "167", "meta-type": "array" }, { - "name": "165", + "name": "167", "members": [ { "name": "name", @@ -17306,7 +17377,7 @@ "meta-type": "object" }, { - "name": "166", + "name": "168", "members": [ { "name": "typename", @@ -17316,7 +17387,7 @@ "meta-type": "object" }, { - "name": "167", + "name": "169", "members": [ { "name": "qom-type", @@ -17335,7 +17406,7 @@ "meta-type": "object" }, { - "name": "168", + "name": "170", "members": [ { "name": "id", @@ -17345,7 +17416,7 @@ "meta-type": "object" }, { - "name": "169", + "name": "171", "members": [ { "name": "typename", @@ -17355,7 +17426,7 @@ "meta-type": "object" }, { - "name": "170", + "name": "172", "members": [ { "name": "driver", @@ -17375,7 +17446,7 @@ "meta-type": "object" }, { - "name": "171", + "name": "173", "members": [ { "name": "id", @@ -17385,7 +17456,7 @@ "meta-type": "object" }, { - "name": "172", + "name": "174", "members": [ { "name": "device", @@ -17400,41 +17471,41 @@ "meta-type": "object" }, { - "name": "[173]", - "element-type": "173", + "name": "[175]", + "element-type": "175", "meta-type": "array" }, { - "name": "173", + "name": "175", "tag": "arch", "variants": [ { "case": "x86", - "type": "353" + "type": "356" }, { "case": "sparc", - "type": "354" + "type": "357" }, { "case": "ppc", - "type": "355" + "type": "358" }, { "case": "mips", - "type": "356" + "type": "359" }, { "case": "tricore", - "type": "357" + "type": "360" }, { "case": "s390", - "type": "358" + "type": "361" }, { "case": "riscv", - "type": "359" + "type": "362" }, { "case": "other", @@ -17465,27 +17536,27 @@ { "name": "props", "default": null, - "type": "351" + "type": "354" }, { "name": "arch", - "type": "352" + "type": "355" } ], "meta-type": "object" }, { - "name": "[174]", - "element-type": "174", + "name": "[176]", + "element-type": "176", "meta-type": "array" }, { - "name": "174", + "name": "176", "tag": "target", "variants": [ { "case": "s390x", - "type": "358" + "type": "361" }, { "case": "aarch64", @@ -17632,24 +17703,24 @@ { "name": "props", "default": null, - "type": "351" + "type": "354" }, { "name": "arch", - "type": "352", + "type": "355", "features": [ "deprecated" ] }, { "name": "target", - "type": "360" + "type": "363" } ], "meta-type": "object" }, { - "name": "175", + "name": "177", "members": [ { "name": "id", @@ -17659,12 +17730,12 @@ "meta-type": "object" }, { - "name": "[176]", - "element-type": "176", + "name": "[178]", + "element-type": "178", "meta-type": "array" }, { - "name": "176", + "name": "178", "members": [ { "name": "name", @@ -17710,7 +17781,7 @@ "meta-type": "object" }, { - "name": "177", + "name": "179", "members": [ { "name": "wakeup-suspend-support", @@ -17720,22 +17791,22 @@ "meta-type": "object" }, { - "name": "178", + "name": "180", "members": [ { "name": "arch", - "type": "360" + "type": "363" } ], "meta-type": "object" }, { - "name": "[179]", - "element-type": "179", + "name": "[181]", + "element-type": "181", "meta-type": "array" }, { - "name": "179", + "name": "181", "members": [ { "name": "id", @@ -17764,18 +17835,18 @@ }, { "name": "policy", - "type": "361" + "type": "364" } ], "meta-type": "object" }, { - "name": "[180]", - "element-type": "180", + "name": "[182]", + "element-type": "182", "meta-type": "array" }, { - "name": "180", + "name": "182", "members": [ { "name": "type", @@ -17787,7 +17858,7 @@ }, { "name": "props", - "type": "351" + "type": "354" }, { "name": "qom-path", @@ -17798,69 +17869,69 @@ "meta-type": "object" }, { - "name": "181", + "name": "183", "tag": "type", "variants": [ { "case": "node", - "type": "363" + "type": "366" }, { "case": "dist", - "type": "364" + "type": "367" }, { "case": "cpu", - "type": "365" + "type": "368" }, { "case": "hmat-lb", - "type": "366" + "type": "369" }, { "case": "hmat-cache", - "type": "367" + "type": "370" } ], "members": [ { "name": "type", - "type": "362" + "type": "365" } ], "meta-type": "object" }, { - "name": "186", + "name": "188", "members": [ { "name": "type", - "type": "370" + "type": "373" }, { "name": "model", - "type": "368" + "type": "371" } ], "meta-type": "object" }, { - "name": "187", + "name": "189", "members": [ { "name": "model", - "type": "368" + "type": "371" } ], "meta-type": "object" }, { - "name": "[188]", - "element-type": "188", + "name": "[190]", + "element-type": "190", "meta-type": "array" }, { - "name": "188", + "name": "190", "members": [ { "name": "name", @@ -17893,7 +17964,7 @@ "meta-type": "object" }, { - "name": "189", + "name": "191", "members": [ { "name": "protocol", @@ -17917,7 +17988,7 @@ "meta-type": "object" }, { - "name": "190", + "name": "192", "members": [ { "name": "name", @@ -17928,7 +17999,7 @@ "meta-type": "object" }, { - "name": "191", + "name": "193", "members": [ { "name": "enabled", @@ -17942,7 +18013,7 @@ "meta-type": "object" }, { - "name": "192", + "name": "194", "members": [ { "name": "UUID", @@ -17952,12 +18023,12 @@ "meta-type": "object" }, { - "name": "[193]", - "element-type": "193", + "name": "[195]", + "element-type": "195", "meta-type": "array" }, { - "name": "193", + "name": "195", "members": [ { "name": "id", @@ -17983,7 +18054,7 @@ "meta-type": "object" }, { - "name": "194", + "name": "196", "members": [ { "name": "actual", @@ -17993,7 +18064,7 @@ "meta-type": "object" }, { - "name": "195", + "name": "197", "members": [ { "name": "actual", @@ -18003,12 +18074,12 @@ "meta-type": "object" }, { - "name": "[196]", - "element-type": "196", + "name": "[198]", + "element-type": "198", "meta-type": "array" }, { - "name": "196", + "name": "198", "members": [ { "name": "bus", @@ -18016,13 +18087,13 @@ }, { "name": "devices", - "type": "[371]" + "type": "[374]" } ], "meta-type": "object" }, { - "name": "197", + "name": "199", "members": [ { "name": "val", @@ -18045,7 +18116,7 @@ "meta-type": "object" }, { - "name": "198", + "name": "200", "members": [ { "name": "val", @@ -18063,7 +18134,7 @@ "meta-type": "object" }, { - "name": "199", + "name": "201", "members": [ { "name": "value", @@ -18073,7 +18144,7 @@ "meta-type": "object" }, { - "name": "200", + "name": "202", "members": [ { "name": "command-line", @@ -18088,7 +18159,7 @@ "meta-type": "object" }, { - "name": "201", + "name": "203", "members": [ { "name": "device", @@ -18107,7 +18178,7 @@ "meta-type": "object" }, { - "name": "202", + "name": "204", "members": [ { "name": "enable", @@ -18117,7 +18188,7 @@ "meta-type": "object" }, { - "name": "203", + "name": "205", "members": [ { "name": "fdname", @@ -18127,7 +18198,7 @@ "meta-type": "object" }, { - "name": "204", + "name": "206", "members": [ { "name": "fdname", @@ -18137,7 +18208,7 @@ "meta-type": "object" }, { - "name": "205", + "name": "207", "members": [ { "name": "base-memory", @@ -18152,7 +18223,7 @@ "meta-type": "object" }, { - "name": "206", + "name": "208", "members": [ { "name": "fdset-id", @@ -18168,7 +18239,7 @@ "meta-type": "object" }, { - "name": "207", + "name": "209", "members": [ { "name": "fdset-id", @@ -18182,7 +18253,7 @@ "meta-type": "object" }, { - "name": "208", + "name": "210", "members": [ { "name": "fdset-id", @@ -18197,12 +18268,12 @@ "meta-type": "object" }, { - "name": "[209]", - "element-type": "209", + "name": "[211]", + "element-type": "211", "meta-type": "array" }, { - "name": "209", + "name": "211", "members": [ { "name": "fdset-id", @@ -18210,13 +18281,13 @@ }, { "name": "fds", - "type": "[372]" + "type": "[375]" } ], "meta-type": "object" }, { - "name": "210", + "name": "212", "members": [ { "name": "option", @@ -18227,12 +18298,12 @@ "meta-type": "object" }, { - "name": "[211]", - "element-type": "211", + "name": "[213]", + "element-type": "213", "meta-type": "array" }, { - "name": "211", + "name": "213", "members": [ { "name": "option", @@ -18240,47 +18311,47 @@ }, { "name": "parameters", - "type": "[373]" + "type": "[376]" } ], "meta-type": "object" }, { - "name": "[212]", - "element-type": "212", + "name": "[214]", + "element-type": "214", "meta-type": "array" }, { - "name": "212", + "name": "214", "tag": "type", "variants": [ { "case": "dimm", - "type": "375" + "type": "378" }, { "case": "nvdimm", - "type": "375" + "type": "378" }, { "case": "virtio-pmem", - "type": "376" + "type": "379" }, { "case": "virtio-mem", - "type": "377" + "type": "380" } ], "members": [ { "name": "type", - "type": "374" + "type": "377" } ], "meta-type": "object" }, { - "name": "213", + "name": "215", "members": [ { "name": "id", @@ -18295,7 +18366,7 @@ "meta-type": "object" }, { - "name": "214", + "name": "216", "members": [ { "name": "device", @@ -18309,12 +18380,12 @@ "meta-type": "object" }, { - "name": "[215]", - "element-type": "215", + "name": "[217]", + "element-type": "217", "meta-type": "array" }, { - "name": "215", + "name": "217", "members": [ { "name": "device", @@ -18327,7 +18398,7 @@ }, { "name": "slot-type", - "type": "378" + "type": "381" }, { "name": "source", @@ -18341,17 +18412,17 @@ "meta-type": "object" }, { - "name": "216", + "name": "218", "members": [ { "name": "info", - "type": "215" + "type": "217" } ], "meta-type": "object" }, { - "name": "217", + "name": "219", "members": [ { "name": "filename", @@ -18361,7 +18432,7 @@ "meta-type": "object" }, { - "name": "218", + "name": "220", "members": [ { "name": "guid", @@ -18371,7 +18442,7 @@ "meta-type": "object" }, { - "name": "219", + "name": "221", "members": [ { "name": "offset", @@ -18381,7 +18452,7 @@ "meta-type": "object" }, { - "name": "220", + "name": "222", "members": [ { "name": "enabled", @@ -18405,7 +18476,7 @@ }, { "name": "state", - "type": "379" + "type": "382" }, { "name": "handle", @@ -18415,7 +18486,7 @@ "meta-type": "object" }, { - "name": "221", + "name": "223", "members": [ { "name": "data", @@ -18425,7 +18496,7 @@ "meta-type": "object" }, { - "name": "222", + "name": "224", "members": [ { "name": "pdh", @@ -18452,7 +18523,7 @@ "meta-type": "builtin" }, { - "name": "225", + "name": "227", "meta-type": "enum", "values": [ "debug", @@ -18475,7 +18546,7 @@ ] }, { - "name": "226", + "name": "228", "meta-type": "enum", "values": [ "none", @@ -18491,7 +18562,7 @@ ] }, { - "name": "227", + "name": "229", "meta-type": "enum", "values": [ "reset", @@ -18504,7 +18575,7 @@ ] }, { - "name": "228", + "name": "230", "meta-type": "enum", "values": [ "pause", @@ -18513,28 +18584,28 @@ ] }, { - "name": "229", + "name": "231", "tag": "type", "variants": [ { "case": "hyper-v", - "type": "381" + "type": "384" }, { "case": "s390", - "type": "382" + "type": "385" } ], "members": [ { "name": "type", - "type": "380" + "type": "383" } ], "meta-type": "object" }, { - "name": "230", + "name": "232", "meta-type": "enum", "values": [ "retain", @@ -18548,7 +18619,7 @@ "meta-type": "array" }, { - "name": "231", + "name": "233", "meta-type": "enum", "values": [ "ok", @@ -18557,12 +18628,12 @@ ] }, { - "name": "[232]", - "element-type": "232", + "name": "[234]", + "element-type": "234", "meta-type": "array" }, { - "name": "232", + "name": "234", "members": [ { "name": "name", @@ -18587,7 +18658,7 @@ }, { "name": "status", - "type": "383", + "type": "386", "features": [ "deprecated" ] @@ -18605,7 +18676,7 @@ "meta-type": "object" }, { - "name": "233", + "name": "235", "members": [ { "name": "rd_bytes", @@ -18714,37 +18785,37 @@ }, { "name": "timed_stats", - "type": "[384]" + "type": "[387]" }, { "name": "rd_latency_histogram", "default": null, - "type": "385" + "type": "388" }, { "name": "wr_latency_histogram", "default": null, - "type": "385" + "type": "388" }, { "name": "flush_latency_histogram", "default": null, - "type": "385" + "type": "388" } ], "meta-type": "object" }, { - "name": "234", + "name": "236", "tag": "driver", "variants": [ { "case": "file", - "type": "386" + "type": "389" }, { "case": "host_device", - "type": "386" + "type": "389" }, { "case": "blkdebug", @@ -18902,13 +18973,13 @@ "members": [ { "name": "driver", - "type": "247" + "type": "249" } ], "meta-type": "object" }, { - "name": "235", + "name": "237", "meta-type": "enum", "values": [ "undefined", @@ -18925,7 +18996,7 @@ ] }, { - "name": "236", + "name": "238", "meta-type": "enum", "values": [ "existing", @@ -18933,7 +19004,7 @@ ] }, { - "name": "237", + "name": "239", "meta-type": "enum", "values": [ "report", @@ -18944,7 +19015,7 @@ ] }, { - "name": "238", + "name": "240", "meta-type": "enum", "values": [ "top", @@ -18955,7 +19026,7 @@ ] }, { - "name": "239", + "name": "241", "meta-type": "enum", "values": [ "on-success", @@ -18964,7 +19035,7 @@ ] }, { - "name": "240", + "name": "242", "meta-type": "enum", "values": [ "off", @@ -18973,7 +19044,7 @@ ] }, { - "name": "241", + "name": "243", "members": [ { "name": "filename", @@ -19035,18 +19106,18 @@ { "name": "backing-image", "default": null, - "type": "241" + "type": "243" }, { "name": "format-specific", "default": null, - "type": "387" + "type": "390" } ], "meta-type": "object" }, { - "name": "242", + "name": "244", "members": [ { "name": "writeback", @@ -19064,12 +19135,12 @@ "meta-type": "object" }, { - "name": "[243]", - "element-type": "243", + "name": "[245]", + "element-type": "245", "meta-type": "array" }, { - "name": "243", + "name": "245", "members": [ { "name": "id", @@ -19077,7 +19148,7 @@ }, { "name": "type", - "type": "388" + "type": "391" }, { "name": "name", @@ -19087,12 +19158,12 @@ "meta-type": "object" }, { - "name": "[244]", - "element-type": "244", + "name": "[246]", + "element-type": "246", "meta-type": "array" }, { - "name": "244", + "name": "246", "members": [ { "name": "parent", @@ -19108,17 +19179,17 @@ }, { "name": "perm", - "type": "[389]" + "type": "[392]" }, { "name": "shared-perm", - "type": "[389]" + "type": "[392]" } ], "meta-type": "object" }, { - "name": "245", + "name": "247", "meta-type": "enum", "values": [ "background", @@ -19126,12 +19197,12 @@ ] }, { - "name": "[246]", - "element-type": "246", + "name": "[248]", + "element-type": "248", "meta-type": "array" }, { - "name": "246", + "name": "248", "members": [ { "type": "str" @@ -19143,7 +19214,7 @@ "meta-type": "alternate" }, { - "name": "247", + "name": "249", "meta-type": "enum", "values": [ "blkdebug", @@ -19189,7 +19260,7 @@ ] }, { - "name": "248", + "name": "250", "meta-type": "enum", "values": [ "ignore", @@ -19197,7 +19268,7 @@ ] }, { - "name": "249", + "name": "251", "members": [ { "name": "direct", @@ -19213,11 +19284,11 @@ "meta-type": "object" }, { - "name": "250", + "name": "252", "members": [ { "name": "image", - "type": "390" + "type": "393" }, { "name": "config", @@ -19257,36 +19328,36 @@ { "name": "inject-error", "default": null, - "type": "[391]" + "type": "[394]" }, { "name": "set-state", "default": null, - "type": "[392]" + "type": "[395]" }, { "name": "take-child-perms", "default": null, - "type": "[389]" + "type": "[392]" }, { "name": "unshare-child-perms", "default": null, - "type": "[389]" + "type": "[392]" } ], "meta-type": "object" }, { - "name": "251", + "name": "253", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "log", - "type": "390" + "type": "393" }, { "name": "log-sector-size", @@ -19307,41 +19378,41 @@ "meta-type": "object" }, { - "name": "252", + "name": "254", "members": [ { "name": "test", - "type": "390" + "type": "393" }, { "name": "raw", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "253", + "name": "255", "members": [ { "name": "image", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "254", + "name": "256", "members": [ { "name": "file", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "255", + "name": "257", "members": [ { "name": "filename", @@ -19355,12 +19426,12 @@ { "name": "locking", "default": null, - "type": "393" + "type": "396" }, { "name": "aio", "default": null, - "type": "394" + "type": "397" }, { "name": "drop-cache", @@ -19379,7 +19450,7 @@ ] }, { - "name": "256", + "name": "258", "members": [ { "name": "url", @@ -19419,7 +19490,7 @@ "meta-type": "object" }, { - "name": "257", + "name": "259", "members": [ { "name": "url", @@ -19464,7 +19535,7 @@ "meta-type": "object" }, { - "name": "258", + "name": "260", "members": [ { "name": "volume", @@ -19476,7 +19547,7 @@ }, { "name": "server", - "type": "[332]" + "type": "[334]" }, { "name": "debug", @@ -19492,7 +19563,7 @@ "meta-type": "object" }, { - "name": "259", + "name": "261", "members": [ { "name": "url", @@ -19542,7 +19613,7 @@ "meta-type": "object" }, { - "name": "260", + "name": "262", "members": [ { "name": "url", @@ -19597,11 +19668,11 @@ "meta-type": "object" }, { - "name": "261", + "name": "263", "members": [ { "name": "transport", - "type": "395" + "type": "398" }, { "name": "portal", @@ -19634,7 +19705,7 @@ { "name": "header-digest", "default": null, - "type": "396" + "type": "399" }, { "name": "timeout", @@ -19645,11 +19716,11 @@ "meta-type": "object" }, { - "name": "262", + "name": "264", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "key-secret", @@ -19660,11 +19731,11 @@ "meta-type": "object" }, { - "name": "263", + "name": "265", "members": [ { "name": "server", - "type": "332" + "type": "334" }, { "name": "export", @@ -19690,11 +19761,11 @@ "meta-type": "object" }, { - "name": "264", + "name": "266", "members": [ { "name": "server", - "type": "397" + "type": "400" }, { "name": "path", @@ -19734,7 +19805,7 @@ "meta-type": "object" }, { - "name": "265", + "name": "267", "members": [ { "name": "size", @@ -19755,7 +19826,7 @@ "meta-type": "object" }, { - "name": "266", + "name": "268", "members": [ { "name": "device", @@ -19769,16 +19840,16 @@ "meta-type": "object" }, { - "name": "267", + "name": "269", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "backing", "default": null, - "type": "398" + "type": "401" }, { "name": "lazy-refcounts", @@ -19803,7 +19874,7 @@ { "name": "overlap-check", "default": null, - "type": "399" + "type": "402" }, { "name": "cache-size", @@ -19833,53 +19904,53 @@ { "name": "encrypt", "default": null, - "type": "400" + "type": "403" }, { "name": "data-file", "default": null, - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "268", + "name": "270", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "backing", "default": null, - "type": "398" + "type": "401" }, { "name": "encrypt", "default": null, - "type": "401" + "type": "404" } ], "meta-type": "object" }, { - "name": "269", + "name": "271", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "backing", "default": null, - "type": "398" + "type": "401" } ], "meta-type": "object" }, { - "name": "270", + "name": "272", "members": [ { "name": "blkverify", @@ -19888,7 +19959,7 @@ }, { "name": "children", - "type": "[390]" + "type": "[393]" }, { "name": "vote-threshold", @@ -19902,17 +19973,17 @@ { "name": "read-pattern", "default": null, - "type": "402" + "type": "405" } ], "meta-type": "object" }, { - "name": "271", + "name": "273", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "offset", @@ -19928,7 +19999,7 @@ "meta-type": "object" }, { - "name": "272", + "name": "274", "members": [ { "name": "pool", @@ -19961,7 +20032,7 @@ { "name": "auth-client-required", "default": null, - "type": "[403]" + "type": "[406]" }, { "name": "key-secret", @@ -19971,21 +20042,21 @@ { "name": "server", "default": null, - "type": "[404]" + "type": "[407]" } ], "meta-type": "object" }, { - "name": "273", + "name": "275", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "mode", - "type": "405" + "type": "408" }, { "name": "top-id", @@ -19996,11 +20067,11 @@ "meta-type": "object" }, { - "name": "274", + "name": "276", "members": [ { "name": "server", - "type": "332" + "type": "334" }, { "name": "vdi", @@ -20020,11 +20091,11 @@ "meta-type": "object" }, { - "name": "275", + "name": "277", "members": [ { "name": "server", - "type": "406" + "type": "409" }, { "name": "path", @@ -20038,13 +20109,13 @@ { "name": "host-key-check", "default": null, - "type": "407" + "type": "410" } ], "meta-type": "object" }, { - "name": "276", + "name": "278", "members": [ { "name": "throttle-group", @@ -20052,13 +20123,13 @@ }, { "name": "file", - "type": "390" + "type": "393" } ], "meta-type": "object" }, { - "name": "277", + "name": "279", "members": [ { "name": "dir", @@ -20088,68 +20159,68 @@ "meta-type": "object" }, { - "name": "278", + "name": "280", "tag": "driver", "variants": [ { "case": "file", - "type": "408" + "type": "411" }, { "case": "gluster", - "type": "409" + "type": "412" }, { "case": "luks", - "type": "410" + "type": "413" }, { "case": "nfs", - "type": "411" + "type": "414" }, { "case": "parallels", - "type": "412" + "type": "415" }, { "case": "qcow", - "type": "413" + "type": "416" }, { "case": "qcow2", - "type": "414" + "type": "417" }, { "case": "qed", - "type": "415" + "type": "418" }, { "case": "rbd", - "type": "416" + "type": "419" }, { "case": "sheepdog", - "type": "417" + "type": "420" }, { "case": "ssh", - "type": "418" + "type": "421" }, { "case": "vdi", - "type": "419" + "type": "422" }, { "case": "vhdx", - "type": "420" + "type": "423" }, { "case": "vmdk", - "type": "421" + "type": "424" }, { "case": "vpc", - "type": "422" + "type": "425" }, { "case": "blkdebug", @@ -20255,22 +20326,22 @@ "members": [ { "name": "driver", - "type": "247" + "type": "249" } ], "meta-type": "object" }, { - "name": "279", + "name": "281", "tag": "driver", "variants": [ { "case": "luks", - "type": "423" + "type": "426" }, { "case": "qcow2", - "type": "424" + "type": "427" }, { "case": "blkdebug", @@ -20428,13 +20499,13 @@ "members": [ { "name": "driver", - "type": "247" + "type": "249" } ], "meta-type": "object" }, { - "name": "280", + "name": "282", "meta-type": "enum", "values": [ "read", @@ -20442,7 +20513,7 @@ ] }, { - "name": "281", + "name": "283", "meta-type": "enum", "values": [ "ignore", @@ -20451,7 +20522,7 @@ ] }, { - "name": "282", + "name": "284", "meta-type": "enum", "values": [ "commit", @@ -20463,7 +20534,7 @@ ] }, { - "name": "283", + "name": "285", "members": [ { "type": "str" @@ -20475,36 +20546,36 @@ "meta-type": "alternate" }, { - "name": "284", + "name": "286", "tag": "type", "variants": [ { "case": "inet", - "type": "426" + "type": "429" }, { "case": "unix", - "type": "427" + "type": "430" }, { "case": "vsock", - "type": "428" + "type": "431" }, { "case": "fd", - "type": "429" + "type": "432" } ], "members": [ { "name": "type", - "type": "425" + "type": "428" } ], "meta-type": "object" }, { - "name": "285", + "name": "287", "meta-type": "enum", "values": [ "safe", @@ -20512,7 +20583,7 @@ ] }, { - "name": "286", + "name": "288", "meta-type": "enum", "values": [ "read", @@ -20521,7 +20592,7 @@ ] }, { - "name": "287", + "name": "289", "meta-type": "enum", "values": [ "utf8", @@ -20529,100 +20600,100 @@ ] }, { - "name": "288", + "name": "290", "tag": "type", "variants": [ { "case": "file", - "type": "431" + "type": "434" }, { "case": "serial", - "type": "432" + "type": "435" }, { "case": "parallel", - "type": "432" + "type": "435" }, { "case": "pipe", - "type": "432" + "type": "435" }, { "case": "socket", - "type": "433" + "type": "436" }, { "case": "udp", - "type": "434" + "type": "437" }, { "case": "pty", - "type": "435" + "type": "438" }, { "case": "null", - "type": "435" + "type": "438" }, { "case": "mux", - "type": "436" + "type": "439" }, { "case": "msmouse", - "type": "435" + "type": "438" }, { "case": "wctablet", - "type": "435" + "type": "438" }, { "case": "braille", - "type": "435" + "type": "438" }, { "case": "testdev", - "type": "435" + "type": "438" }, { "case": "stdio", - "type": "437" + "type": "440" }, { "case": "console", - "type": "435" + "type": "438" }, { "case": "spicevmc", - "type": "438" + "type": "441" }, { "case": "spiceport", - "type": "439" + "type": "442" }, { "case": "vc", - "type": "440" + "type": "443" }, { "case": "ringbuf", - "type": "441" + "type": "444" }, { "case": "memory", - "type": "441" + "type": "444" } ], "members": [ { "name": "type", - "type": "430" + "type": "433" } ], "meta-type": "object" }, { - "name": "289", + "name": "291", "meta-type": "enum", "values": [ "elf", @@ -20633,7 +20704,7 @@ ] }, { - "name": "290", + "name": "292", "meta-type": "enum", "values": [ "none", @@ -20643,12 +20714,12 @@ ] }, { - "name": "[289]", - "element-type": "289", + "name": "[291]", + "element-type": "291", "meta-type": "array" }, { - "name": "291", + "name": "293", "meta-type": "enum", "values": [ "none", @@ -20666,7 +20737,7 @@ ] }, { - "name": "292", + "name": "294", "members": [ { "name": "netdev", @@ -20697,7 +20768,7 @@ "meta-type": "object" }, { - "name": "293", + "name": "295", "members": [ { "name": "hostname", @@ -20757,7 +20828,7 @@ { "name": "dnssearch", "default": null, - "type": "[442]" + "type": "[445]" }, { "name": "domainname", @@ -20797,12 +20868,12 @@ { "name": "hostfwd", "default": null, - "type": "[442]" + "type": "[445]" }, { "name": "guestfwd", "default": null, - "type": "[442]" + "type": "[445]" }, { "name": "tftp-server-name", @@ -20813,7 +20884,7 @@ "meta-type": "object" }, { - "name": "294", + "name": "296", "members": [ { "name": "ifname", @@ -20894,7 +20965,7 @@ "meta-type": "object" }, { - "name": "295", + "name": "297", "members": [ { "name": "src", @@ -20967,7 +21038,7 @@ "meta-type": "object" }, { - "name": "296", + "name": "298", "members": [ { "name": "fd", @@ -21003,7 +21074,7 @@ "meta-type": "object" }, { - "name": "297", + "name": "299", "members": [ { "name": "sock", @@ -21029,7 +21100,7 @@ "meta-type": "object" }, { - "name": "298", + "name": "300", "members": [ { "name": "br", @@ -21045,7 +21116,7 @@ "meta-type": "object" }, { - "name": "299", + "name": "301", "members": [ { "name": "hubid", @@ -21060,7 +21131,7 @@ "meta-type": "object" }, { - "name": "300", + "name": "302", "members": [ { "name": "ifname", @@ -21075,7 +21146,7 @@ "meta-type": "object" }, { - "name": "301", + "name": "303", "members": [ { "name": "chardev", @@ -21095,7 +21166,7 @@ "meta-type": "object" }, { - "name": "302", + "name": "304", "members": [ { "name": "vhostdev", @@ -21111,7 +21182,7 @@ "meta-type": "object" }, { - "name": "303", + "name": "305", "meta-type": "enum", "values": [ "normal", @@ -21125,7 +21196,7 @@ "meta-type": "array" }, { - "name": "304", + "name": "306", "meta-type": "enum", "values": [ "half", @@ -21133,7 +21204,7 @@ ] }, { - "name": "305", + "name": "307", "meta-type": "enum", "values": [ "off", @@ -21141,7 +21212,7 @@ ] }, { - "name": "306", + "name": "308", "members": [ { "name": "priority", @@ -21200,7 +21271,7 @@ "meta-type": "object" }, { - "name": "307", + "name": "309", "members": [ { "name": "in-pport", @@ -21241,7 +21312,7 @@ "meta-type": "object" }, { - "name": "308", + "name": "310", "members": [ { "name": "goto-tbl", @@ -21277,28 +21348,28 @@ "meta-type": "object" }, { - "name": "309", + "name": "311", "tag": "type", "variants": [ { "case": "passthrough", - "type": "444" + "type": "447" }, { "case": "emulator", - "type": "445" + "type": "448" } ], "members": [ { "name": "type", - "type": "443" + "type": "446" } ], "meta-type": "object" }, { - "name": "310", + "name": "312", "meta-type": "enum", "values": [ "client", @@ -21307,12 +21378,12 @@ ] }, { - "name": "[311]", - "element-type": "311", + "name": "[313]", + "element-type": "313", "meta-type": "array" }, { - "name": "311", + "name": "313", "members": [ { "name": "host", @@ -21324,7 +21395,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "connection-id", @@ -21346,7 +21417,7 @@ "meta-type": "object" }, { - "name": "312", + "name": "314", "members": [ { "name": "host", @@ -21358,13 +21429,13 @@ }, { "name": "family", - "type": "314" + "type": "316" } ], "meta-type": "object" }, { - "name": "313", + "name": "315", "members": [ { "name": "host", @@ -21376,7 +21447,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "auth", @@ -21387,7 +21458,7 @@ "meta-type": "object" }, { - "name": "314", + "name": "316", "meta-type": "enum", "values": [ "ipv4", @@ -21398,12 +21469,12 @@ ] }, { - "name": "[315]", - "element-type": "315", + "name": "[317]", + "element-type": "317", "meta-type": "array" }, { - "name": "315", + "name": "317", "members": [ { "name": "host", @@ -21415,7 +21486,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21435,12 +21506,12 @@ "meta-type": "object" }, { - "name": "[316]", - "element-type": "316", + "name": "[318]", + "element-type": "318", "meta-type": "array" }, { - "name": "316", + "name": "318", "members": [ { "name": "host", @@ -21452,7 +21523,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21460,18 +21531,18 @@ }, { "name": "auth", - "type": "317" + "type": "319" }, { "name": "vencrypt", "default": null, - "type": "318" + "type": "320" } ], "meta-type": "object" }, { - "name": "317", + "name": "319", "meta-type": "enum", "values": [ "none", @@ -21486,7 +21557,7 @@ ] }, { - "name": "318", + "name": "320", "meta-type": "enum", "values": [ "plain", @@ -21501,7 +21572,7 @@ ] }, { - "name": "319", + "name": "321", "members": [ { "name": "host", @@ -21513,7 +21584,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21528,7 +21599,7 @@ "meta-type": "object" }, { - "name": "320", + "name": "322", "members": [ { "name": "host", @@ -21540,7 +21611,7 @@ }, { "name": "family", - "type": "314" + "type": "316" }, { "name": "websocket", @@ -21550,67 +21621,67 @@ "meta-type": "object" }, { - "name": "[321]", - "element-type": "321", + "name": "[323]", + "element-type": "323", "meta-type": "array" }, { - "name": "321", + "name": "323", "tag": "type", "variants": [ { "case": "number", - "type": "447" + "type": "450" }, { "case": "qcode", - "type": "448" + "type": "451" } ], "members": [ { "name": "type", - "type": "446" + "type": "449" } ], "meta-type": "object" }, { - "name": "[322]", - "element-type": "322", + "name": "[324]", + "element-type": "324", "meta-type": "array" }, { - "name": "322", + "name": "324", "tag": "type", "variants": [ { "case": "key", - "type": "450" + "type": "453" }, { "case": "btn", - "type": "451" + "type": "454" }, { "case": "rel", - "type": "452" + "type": "455" }, { "case": "abs", - "type": "452" + "type": "455" } ], "members": [ { "name": "type", - "type": "449" + "type": "452" } ], "meta-type": "object" }, { - "name": "323", + "name": "325", "meta-type": "enum", "values": [ "default", @@ -21624,7 +21695,7 @@ ] }, { - "name": "324", + "name": "326", "meta-type": "enum", "values": [ "off", @@ -21634,7 +21705,7 @@ ] }, { - "name": "325", + "name": "327", "members": [ { "name": "grab-on-hover", @@ -21650,7 +21721,7 @@ "meta-type": "object" }, { - "name": "326", + "name": "328", "members": [ { "name": "charset", @@ -21661,7 +21732,7 @@ "meta-type": "object" }, { - "name": "327", + "name": "329", "members": [ { "name": "rendernode", @@ -21672,7 +21743,7 @@ "meta-type": "object" }, { - "name": "328", + "name": "330", "meta-type": "enum", "values": [ "none", @@ -21692,7 +21763,7 @@ ] }, { - "name": "329", + "name": "331", "members": [ { "name": "transferred", @@ -21754,7 +21825,7 @@ "meta-type": "object" }, { - "name": "330", + "name": "332", "members": [ { "name": "cache-size", @@ -21788,7 +21859,7 @@ "meta-type": "object" }, { - "name": "331", + "name": "333", "members": [ { "name": "pages", @@ -21814,41 +21885,41 @@ "meta-type": "object" }, { - "name": "[332]", - "element-type": "332", + "name": "[334]", + "element-type": "334", "meta-type": "array" }, { - "name": "332", + "name": "334", "tag": "type", "variants": [ { "case": "inet", - "type": "406" + "type": "409" }, { "case": "unix", - "type": "454" + "type": "457" }, { "case": "vsock", - "type": "455" + "type": "458" }, { "case": "fd", - "type": "442" + "type": "445" } ], "members": [ { "name": "type", - "type": "453" + "type": "456" } ], "meta-type": "object" }, { - "name": "333", + "name": "335", "meta-type": "enum", "values": [ "xbzrle", @@ -21872,7 +21943,7 @@ ] }, { - "name": "334", + "name": "336", "meta-type": "enum", "values": [ "none", @@ -21880,12 +21951,12 @@ ] }, { - "name": "[335]", - "element-type": "335", + "name": "[337]", + "element-type": "337", "meta-type": "array" }, { - "name": "335", + "name": "337", "members": [ { "name": "node-name", @@ -21897,13 +21968,13 @@ }, { "name": "bitmaps", - "type": "[456]" + "type": "[459]" } ], "meta-type": "object" }, { - "name": "336", + "name": "338", "meta-type": "enum", "values": [ "none", @@ -21912,7 +21983,7 @@ ] }, { - "name": "337", + "name": "339", "meta-type": "enum", "values": [ "none", @@ -21927,84 +21998,93 @@ "meta-type": "builtin" }, { - "name": "[338]", - "element-type": "338", + "name": "340", + "meta-type": "enum", + "values": [ + "unstarted", + "measuring", + "measured" + ] + }, + { + "name": "[341]", + "element-type": "341", "meta-type": "array" }, { - "name": "338", + "name": "341", "tag": "type", "variants": [ { "case": "abort", - "type": "458" + "type": "461" }, { "case": "block-dirty-bitmap-add", - "type": "459" + "type": "462" }, { "case": "block-dirty-bitmap-remove", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-clear", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-enable", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-disable", - "type": "460" + "type": "463" }, { "case": "block-dirty-bitmap-merge", - "type": "461" + "type": "464" }, { "case": "blockdev-backup", - "type": "462" + "type": "465" }, { "case": "blockdev-snapshot", - "type": "463" + "type": "466" }, { "case": "blockdev-snapshot-internal-sync", - "type": "464" + "type": "467" }, { "case": "blockdev-snapshot-sync", - "type": "465" + "type": "468" }, { "case": "drive-backup", - "type": "466" + "type": "469" } ], "members": [ { "name": "type", - "type": "457" + "type": "460" } ], "meta-type": "object" }, { - "name": "339", + "name": "342", "members": [ { "name": "completion-mode", "default": null, - "type": "467" + "type": "470" } ], "meta-type": "object" }, { - "name": "340", + "name": "343", "meta-type": "enum", "values": [ "unavailable", @@ -22013,19 +22093,19 @@ ] }, { - "name": "[341]", - "element-type": "341", + "name": "[344]", + "element-type": "344", "meta-type": "array" }, { - "name": "341", + "name": "344", "meta-type": "enum", "values": [ "oob" ] }, { - "name": "342", + "name": "345", "members": [ { "name": "major", @@ -22043,7 +22123,7 @@ "meta-type": "object" }, { - "name": "343", + "name": "346", "meta-type": "enum", "values": [ "builtin", @@ -22056,17 +22136,17 @@ ] }, { - "name": "344", + "name": "347", "members": [ { "name": "json-type", - "type": "468" + "type": "471" } ], "meta-type": "object" }, { - "name": "345", + "name": "348", "members": [ { "name": "values", @@ -22076,7 +22156,7 @@ "meta-type": "object" }, { - "name": "346", + "name": "349", "members": [ { "name": "element-type", @@ -22086,11 +22166,11 @@ "meta-type": "object" }, { - "name": "347", + "name": "350", "members": [ { "name": "members", - "type": "[469]" + "type": "[472]" }, { "name": "tag", @@ -22100,23 +22180,23 @@ { "name": "variants", "default": null, - "type": "[470]" + "type": "[473]" } ], "meta-type": "object" }, { - "name": "348", + "name": "351", "members": [ { "name": "members", - "type": "[471]" + "type": "[474]" } ], "meta-type": "object" }, { - "name": "349", + "name": "352", "members": [ { "name": "arg-type", @@ -22135,7 +22215,7 @@ "meta-type": "object" }, { - "name": "350", + "name": "353", "members": [ { "name": "arg-type", @@ -22145,7 +22225,7 @@ "meta-type": "object" }, { - "name": "351", + "name": "354", "members": [ { "name": "node-id", @@ -22176,7 +22256,7 @@ "meta-type": "object" }, { - "name": "352", + "name": "355", "meta-type": "enum", "values": [ "x86", @@ -22190,7 +22270,7 @@ ] }, { - "name": "353", + "name": "356", "members": [ { "name": "pc", @@ -22200,7 +22280,7 @@ "meta-type": "object" }, { - "name": "354", + "name": "357", "members": [ { "name": "pc", @@ -22214,7 +22294,7 @@ "meta-type": "object" }, { - "name": "355", + "name": "358", "members": [ { "name": "nip", @@ -22224,7 +22304,7 @@ "meta-type": "object" }, { - "name": "356", + "name": "359", "members": [ { "name": "PC", @@ -22234,7 +22314,7 @@ "meta-type": "object" }, { - "name": "357", + "name": "360", "members": [ { "name": "PC", @@ -22244,17 +22324,17 @@ "meta-type": "object" }, { - "name": "358", + "name": "361", "members": [ { "name": "cpu-state", - "type": "472" + "type": "475" } ], "meta-type": "object" }, { - "name": "359", + "name": "362", "members": [ { "name": "pc", @@ -22264,7 +22344,7 @@ "meta-type": "object" }, { - "name": "360", + "name": "363", "meta-type": "enum", "values": [ "aarch64", @@ -22303,7 +22383,7 @@ ] }, { - "name": "361", + "name": "364", "meta-type": "enum", "values": [ "default", @@ -22313,7 +22393,7 @@ ] }, { - "name": "362", + "name": "365", "meta-type": "enum", "values": [ "node", @@ -22324,7 +22404,7 @@ ] }, { - "name": "363", + "name": "366", "members": [ { "name": "nodeid", @@ -22355,7 +22435,7 @@ "meta-type": "object" }, { - "name": "364", + "name": "367", "members": [ { "name": "src", @@ -22373,7 +22453,7 @@ "meta-type": "object" }, { - "name": "365", + "name": "368", "members": [ { "name": "node-id", @@ -22404,7 +22484,7 @@ "meta-type": "object" }, { - "name": "366", + "name": "369", "members": [ { "name": "initiator", @@ -22416,11 +22496,11 @@ }, { "name": "hierarchy", - "type": "473" + "type": "476" }, { "name": "data-type", - "type": "474" + "type": "477" }, { "name": "latency", @@ -22436,7 +22516,7 @@ "meta-type": "object" }, { - "name": "367", + "name": "370", "members": [ { "name": "node-id", @@ -22452,11 +22532,11 @@ }, { "name": "associativity", - "type": "475" + "type": "478" }, { "name": "policy", - "type": "476" + "type": "479" }, { "name": "line", @@ -22466,7 +22546,7 @@ "meta-type": "object" }, { - "name": "368", + "name": "371", "members": [ { "name": "name", @@ -22481,7 +22561,7 @@ "meta-type": "object" }, { - "name": "369", + "name": "372", "meta-type": "enum", "values": [ "incompatible", @@ -22491,7 +22571,7 @@ ] }, { - "name": "370", + "name": "373", "meta-type": "enum", "values": [ "static", @@ -22499,12 +22579,12 @@ ] }, { - "name": "[371]", - "element-type": "371", + "name": "[374]", + "element-type": "374", "meta-type": "array" }, { - "name": "371", + "name": "374", "members": [ { "name": "bus", @@ -22520,11 +22600,11 @@ }, { "name": "class_info", - "type": "477" + "type": "480" }, { "name": "id", - "type": "478" + "type": "481" }, { "name": "irq", @@ -22542,22 +22622,22 @@ { "name": "pci_bridge", "default": null, - "type": "479" + "type": "482" }, { "name": "regions", - "type": "[480]" + "type": "[483]" } ], "meta-type": "object" }, { - "name": "[372]", - "element-type": "372", + "name": "[375]", + "element-type": "375", "meta-type": "array" }, { - "name": "372", + "name": "375", "members": [ { "name": "fd", @@ -22572,12 +22652,12 @@ "meta-type": "object" }, { - "name": "[373]", - "element-type": "373", + "name": "[376]", + "element-type": "376", "meta-type": "array" }, { - "name": "373", + "name": "376", "members": [ { "name": "name", @@ -22585,7 +22665,7 @@ }, { "name": "type", - "type": "481" + "type": "484" }, { "name": "help", @@ -22601,7 +22681,7 @@ "meta-type": "object" }, { - "name": "374", + "name": "377", "meta-type": "enum", "values": [ "dimm", @@ -22611,37 +22691,37 @@ ] }, { - "name": "375", + "name": "378", "members": [ { "name": "data", - "type": "482" + "type": "485" } ], "meta-type": "object" }, { - "name": "376", + "name": "379", "members": [ { "name": "data", - "type": "483" + "type": "486" } ], "meta-type": "object" }, { - "name": "377", + "name": "380", "members": [ { "name": "data", - "type": "484" + "type": "487" } ], "meta-type": "object" }, { - "name": "378", + "name": "381", "meta-type": "enum", "values": [ "DIMM", @@ -22649,7 +22729,7 @@ ] }, { - "name": "379", + "name": "382", "meta-type": "enum", "values": [ "uninit", @@ -22661,7 +22741,7 @@ ] }, { - "name": "380", + "name": "383", "meta-type": "enum", "values": [ "hyper-v", @@ -22669,7 +22749,7 @@ ] }, { - "name": "381", + "name": "384", "members": [ { "name": "arg1", @@ -22695,7 +22775,7 @@ "meta-type": "object" }, { - "name": "382", + "name": "385", "members": [ { "name": "core", @@ -22711,13 +22791,13 @@ }, { "name": "reason", - "type": "485" + "type": "488" } ], "meta-type": "object" }, { - "name": "383", + "name": "386", "meta-type": "enum", "values": [ "active", @@ -22728,12 +22808,12 @@ ] }, { - "name": "[384]", - "element-type": "384", + "name": "[387]", + "element-type": "387", "meta-type": "array" }, { - "name": "384", + "name": "387", "members": [ { "name": "interval_length", @@ -22787,7 +22867,7 @@ "meta-type": "object" }, { - "name": "385", + "name": "388", "members": [ { "name": "boundaries", @@ -22801,7 +22881,7 @@ "meta-type": "object" }, { - "name": "386", + "name": "389", "members": [ { "name": "discard-nb-ok", @@ -22824,32 +22904,32 @@ "meta-type": "array" }, { - "name": "387", + "name": "390", "tag": "type", "variants": [ { "case": "qcow2", - "type": "487" + "type": "490" }, { "case": "vmdk", - "type": "488" + "type": "491" }, { "case": "luks", - "type": "489" + "type": "492" } ], "members": [ { "name": "type", - "type": "486" + "type": "489" } ], "meta-type": "object" }, { - "name": "388", + "name": "391", "meta-type": "enum", "values": [ "block-backend", @@ -22858,12 +22938,12 @@ ] }, { - "name": "[389]", - "element-type": "389", + "name": "[392]", + "element-type": "392", "meta-type": "array" }, { - "name": "389", + "name": "392", "meta-type": "enum", "values": [ "consistent-read", @@ -22874,7 +22954,7 @@ ] }, { - "name": "390", + "name": "393", "members": [ { "type": "48" @@ -22886,16 +22966,16 @@ "meta-type": "alternate" }, { - "name": "[391]", - "element-type": "391", + "name": "[394]", + "element-type": "394", "meta-type": "array" }, { - "name": "391", + "name": "394", "members": [ { "name": "event", - "type": "490" + "type": "493" }, { "name": "state", @@ -22905,7 +22985,7 @@ { "name": "iotype", "default": null, - "type": "491" + "type": "494" }, { "name": "errno", @@ -22931,16 +23011,16 @@ "meta-type": "object" }, { - "name": "[392]", - "element-type": "392", + "name": "[395]", + "element-type": "395", "meta-type": "array" }, { - "name": "392", + "name": "395", "members": [ { "name": "event", - "type": "490" + "type": "493" }, { "name": "state", @@ -22955,7 +23035,7 @@ "meta-type": "object" }, { - "name": "393", + "name": "396", "meta-type": "enum", "values": [ "auto", @@ -22964,7 +23044,7 @@ ] }, { - "name": "394", + "name": "397", "meta-type": "enum", "values": [ "threads", @@ -22973,7 +23053,7 @@ ] }, { - "name": "395", + "name": "398", "meta-type": "enum", "values": [ "tcp", @@ -22981,7 +23061,7 @@ ] }, { - "name": "396", + "name": "399", "meta-type": "enum", "values": [ "crc32c", @@ -22991,11 +23071,11 @@ ] }, { - "name": "397", + "name": "400", "members": [ { "name": "type", - "type": "492" + "type": "495" }, { "name": "host", @@ -23005,7 +23085,7 @@ "meta-type": "object" }, { - "name": "398", + "name": "401", "members": [ { "type": "48" @@ -23020,62 +23100,62 @@ "meta-type": "alternate" }, { - "name": "399", + "name": "402", "members": [ { - "type": "493" + "type": "496" }, { - "type": "494" + "type": "497" } ], "meta-type": "alternate" }, { - "name": "400", + "name": "403", "tag": "format", "variants": [ { "case": "aes", - "type": "496" + "type": "499" }, { "case": "luks", - "type": "497" + "type": "500" } ], "members": [ { "name": "format", - "type": "495" + "type": "498" } ], "meta-type": "object" }, { - "name": "401", + "name": "404", "tag": "format", "variants": [ { "case": "aes", - "type": "496" + "type": "499" } ], "members": [ { "name": "format", - "type": "498" + "type": "501" } ], "meta-type": "object" }, { - "name": "[390]", - "element-type": "390", + "name": "[393]", + "element-type": "393", "meta-type": "array" }, { - "name": "402", + "name": "405", "meta-type": "enum", "values": [ "quorum", @@ -23083,12 +23163,12 @@ ] }, { - "name": "[403]", - "element-type": "403", + "name": "[406]", + "element-type": "406", "meta-type": "array" }, { - "name": "403", + "name": "406", "meta-type": "enum", "values": [ "cephx", @@ -23096,12 +23176,12 @@ ] }, { - "name": "[404]", - "element-type": "404", + "name": "[407]", + "element-type": "407", "meta-type": "array" }, { - "name": "404", + "name": "407", "members": [ { "name": "host", @@ -23115,7 +23195,7 @@ "meta-type": "object" }, { - "name": "405", + "name": "408", "meta-type": "enum", "values": [ "primary", @@ -23123,7 +23203,7 @@ ] }, { - "name": "406", + "name": "409", "members": [ { "name": "host", @@ -23162,12 +23242,12 @@ "meta-type": "object" }, { - "name": "407", + "name": "410", "tag": "mode", "variants": [ { "case": "hash", - "type": "500" + "type": "503" }, { "case": "none", @@ -23181,13 +23261,13 @@ "members": [ { "name": "mode", - "type": "499" + "type": "502" } ], "meta-type": "object" }, { - "name": "408", + "name": "411", "members": [ { "name": "filename", @@ -23200,7 +23280,7 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" }, { "name": "nocow", @@ -23216,11 +23296,11 @@ "meta-type": "object" }, { - "name": "409", + "name": "412", "members": [ { "name": "location", - "type": "258" + "type": "260" }, { "name": "size", @@ -23229,13 +23309,13 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" } ], "meta-type": "object" }, { - "name": "410", + "name": "413", "members": [ { "name": "key-secret", @@ -23245,27 +23325,27 @@ { "name": "cipher-alg", "default": null, - "type": "502" + "type": "505" }, { "name": "cipher-mode", "default": null, - "type": "503" + "type": "506" }, { "name": "ivgen-alg", "default": null, - "type": "504" + "type": "507" }, { "name": "ivgen-hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "iter-time", @@ -23274,7 +23354,7 @@ }, { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23283,17 +23363,17 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" } ], "meta-type": "object" }, { - "name": "411", + "name": "414", "members": [ { "name": "location", - "type": "264" + "type": "266" }, { "name": "size", @@ -23303,11 +23383,11 @@ "meta-type": "object" }, { - "name": "412", + "name": "415", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23322,11 +23402,11 @@ "meta-type": "object" }, { - "name": "413", + "name": "416", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23340,28 +23420,33 @@ { "name": "encrypt", "default": null, - "type": "506" + "type": "509" } ], "meta-type": "object" }, { - "name": "414", + "name": "417", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "data-file", "default": null, - "type": "390" + "type": "393" }, { "name": "data-file-raw", "default": null, "type": "bool" }, + { + "name": "extended-l2", + "default": null, + "type": "bool" + }, { "name": "size", "type": "int" @@ -23369,7 +23454,7 @@ { "name": "version", "default": null, - "type": "507" + "type": "510" }, { "name": "backing-file", @@ -23379,12 +23464,12 @@ { "name": "backing-fmt", "default": null, - "type": "247" + "type": "249" }, { "name": "encrypt", "default": null, - "type": "506" + "type": "509" }, { "name": "cluster-size", @@ -23394,7 +23479,7 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" }, { "name": "lazy-refcounts", @@ -23409,17 +23494,17 @@ { "name": "compression-type", "default": null, - "type": "508" + "type": "511" } ], "meta-type": "object" }, { - "name": "415", + "name": "418", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23433,7 +23518,7 @@ { "name": "backing-fmt", "default": null, - "type": "247" + "type": "249" }, { "name": "cluster-size", @@ -23449,11 +23534,11 @@ "meta-type": "object" }, { - "name": "416", + "name": "419", "members": [ { "name": "location", - "type": "272" + "type": "274" }, { "name": "size", @@ -23468,11 +23553,11 @@ "meta-type": "object" }, { - "name": "417", + "name": "420", "members": [ { "name": "location", - "type": "274" + "type": "276" }, { "name": "size", @@ -23486,12 +23571,12 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" }, { "name": "redundancy", "default": null, - "type": "509" + "type": "512" }, { "name": "object-size", @@ -23502,11 +23587,11 @@ "meta-type": "object" }, { - "name": "418", + "name": "421", "members": [ { "name": "location", - "type": "275" + "type": "277" }, { "name": "size", @@ -23516,11 +23601,11 @@ "meta-type": "object" }, { - "name": "419", + "name": "422", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23529,17 +23614,17 @@ { "name": "preallocation", "default": null, - "type": "501" + "type": "504" } ], "meta-type": "object" }, { - "name": "420", + "name": "423", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23558,7 +23643,7 @@ { "name": "subformat", "default": null, - "type": "510" + "type": "513" }, { "name": "block-state-zero", @@ -23569,11 +23654,11 @@ "meta-type": "object" }, { - "name": "421", + "name": "424", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23582,12 +23667,12 @@ { "name": "extents", "default": null, - "type": "[390]" + "type": "[393]" }, { "name": "subformat", "default": null, - "type": "511" + "type": "514" }, { "name": "backing-file", @@ -23597,7 +23682,7 @@ { "name": "adapter-type", "default": null, - "type": "512" + "type": "515" }, { "name": "hwversion", @@ -23613,11 +23698,11 @@ "meta-type": "object" }, { - "name": "422", + "name": "425", "members": [ { "name": "file", - "type": "390" + "type": "393" }, { "name": "size", @@ -23626,7 +23711,7 @@ { "name": "subformat", "default": null, - "type": "513" + "type": "516" }, { "name": "force-size", @@ -23637,11 +23722,11 @@ "meta-type": "object" }, { - "name": "423", + "name": "426", "members": [ { "name": "state", - "type": "514" + "type": "517" }, { "name": "new-secret", @@ -23672,12 +23757,12 @@ "meta-type": "object" }, { - "name": "424", + "name": "427", "members": [ { "name": "encrypt", "default": null, - "type": "515" + "type": "518" } ], "meta-type": "object" @@ -23688,7 +23773,7 @@ "meta-type": "builtin" }, { - "name": "425", + "name": "428", "meta-type": "enum", "values": [ "inet", @@ -23698,47 +23783,47 @@ ] }, { - "name": "426", + "name": "429", "members": [ { "name": "data", - "type": "406" + "type": "409" } ], "meta-type": "object" }, { - "name": "427", + "name": "430", "members": [ { "name": "data", - "type": "454" + "type": "457" } ], "meta-type": "object" }, { - "name": "428", + "name": "431", "members": [ { "name": "data", - "type": "455" + "type": "458" } ], "meta-type": "object" }, { - "name": "429", + "name": "432", "members": [ { "name": "data", - "type": "442" + "type": "445" } ], "meta-type": "object" }, { - "name": "430", + "name": "433", "meta-type": "enum", "values": [ "file", @@ -23764,122 +23849,122 @@ ] }, { - "name": "431", + "name": "434", "members": [ { "name": "data", - "type": "516" + "type": "519" } ], "meta-type": "object" }, { - "name": "432", + "name": "435", "members": [ { "name": "data", - "type": "517" + "type": "520" } ], "meta-type": "object" }, { - "name": "433", + "name": "436", "members": [ { "name": "data", - "type": "518" + "type": "521" } ], "meta-type": "object" }, { - "name": "434", + "name": "437", "members": [ { "name": "data", - "type": "519" + "type": "522" } ], "meta-type": "object" }, { - "name": "435", + "name": "438", "members": [ { "name": "data", - "type": "520" + "type": "523" } ], "meta-type": "object" }, { - "name": "436", + "name": "439", "members": [ { "name": "data", - "type": "521" + "type": "524" } ], "meta-type": "object" }, { - "name": "437", + "name": "440", "members": [ { "name": "data", - "type": "522" + "type": "525" } ], "meta-type": "object" }, { - "name": "438", + "name": "441", "members": [ { "name": "data", - "type": "523" + "type": "526" } ], "meta-type": "object" }, { - "name": "439", + "name": "442", "members": [ { "name": "data", - "type": "524" + "type": "527" } ], "meta-type": "object" }, { - "name": "440", + "name": "443", "members": [ { "name": "data", - "type": "525" + "type": "528" } ], "meta-type": "object" }, { - "name": "441", + "name": "444", "members": [ { "name": "data", - "type": "526" + "type": "529" } ], "meta-type": "object" }, { - "name": "[442]", - "element-type": "442", + "name": "[445]", + "element-type": "445", "meta-type": "array" }, { - "name": "442", + "name": "445", "members": [ { "name": "str", @@ -23889,7 +23974,7 @@ "meta-type": "object" }, { - "name": "443", + "name": "446", "meta-type": "enum", "values": [ "passthrough", @@ -23897,27 +23982,27 @@ ] }, { - "name": "444", + "name": "447", "members": [ { "name": "data", - "type": "527" + "type": "530" } ], "meta-type": "object" }, { - "name": "445", + "name": "448", "members": [ { "name": "data", - "type": "528" + "type": "531" } ], "meta-type": "object" }, { - "name": "446", + "name": "449", "meta-type": "enum", "values": [ "number", @@ -23925,7 +24010,7 @@ ] }, { - "name": "447", + "name": "450", "members": [ { "name": "data", @@ -23935,17 +24020,17 @@ "meta-type": "object" }, { - "name": "448", + "name": "451", "members": [ { "name": "data", - "type": "529" + "type": "532" } ], "meta-type": "object" }, { - "name": "449", + "name": "452", "meta-type": "enum", "values": [ "key", @@ -23955,37 +24040,37 @@ ] }, { - "name": "450", + "name": "453", "members": [ { "name": "data", - "type": "530" + "type": "533" } ], "meta-type": "object" }, { - "name": "451", + "name": "454", "members": [ { "name": "data", - "type": "531" + "type": "534" } ], "meta-type": "object" }, { - "name": "452", + "name": "455", "members": [ { "name": "data", - "type": "532" + "type": "535" } ], "meta-type": "object" }, { - "name": "453", + "name": "456", "meta-type": "enum", "values": [ "inet", @@ -23995,7 +24080,7 @@ ] }, { - "name": "454", + "name": "457", "members": [ { "name": "path", @@ -24015,7 +24100,7 @@ "meta-type": "object" }, { - "name": "455", + "name": "458", "members": [ { "name": "cid", @@ -24029,12 +24114,12 @@ "meta-type": "object" }, { - "name": "[456]", - "element-type": "456", + "name": "[459]", + "element-type": "459", "meta-type": "array" }, { - "name": "456", + "name": "459", "members": [ { "name": "name", @@ -24048,7 +24133,7 @@ "meta-type": "object" }, { - "name": "457", + "name": "460", "meta-type": "enum", "values": [ "abort", @@ -24066,17 +24151,17 @@ ] }, { - "name": "458", + "name": "461", "members": [ { "name": "data", - "type": "533" + "type": "536" } ], "meta-type": "object" }, { - "name": "459", + "name": "462", "members": [ { "name": "data", @@ -24086,7 +24171,7 @@ "meta-type": "object" }, { - "name": "460", + "name": "463", "members": [ { "name": "data", @@ -24096,7 +24181,7 @@ "meta-type": "object" }, { - "name": "461", + "name": "464", "members": [ { "name": "data", @@ -24106,7 +24191,7 @@ "meta-type": "object" }, { - "name": "462", + "name": "465", "members": [ { "name": "data", @@ -24116,7 +24201,7 @@ "meta-type": "object" }, { - "name": "463", + "name": "466", "members": [ { "name": "data", @@ -24126,7 +24211,7 @@ "meta-type": "object" }, { - "name": "464", + "name": "467", "members": [ { "name": "data", @@ -24136,7 +24221,7 @@ "meta-type": "object" }, { - "name": "465", + "name": "468", "members": [ { "name": "data", @@ -24146,7 +24231,7 @@ "meta-type": "object" }, { - "name": "466", + "name": "469", "members": [ { "name": "data", @@ -24156,7 +24241,7 @@ "meta-type": "object" }, { - "name": "467", + "name": "470", "meta-type": "enum", "values": [ "individual", @@ -24164,7 +24249,7 @@ ] }, { - "name": "468", + "name": "471", "meta-type": "enum", "values": [ "string", @@ -24178,12 +24263,12 @@ ] }, { - "name": "[469]", - "element-type": "469", + "name": "[472]", + "element-type": "472", "meta-type": "array" }, { - "name": "469", + "name": "472", "members": [ { "name": "name", @@ -24207,12 +24292,12 @@ "meta-type": "object" }, { - "name": "[470]", - "element-type": "470", + "name": "[473]", + "element-type": "473", "meta-type": "array" }, { - "name": "470", + "name": "473", "members": [ { "name": "case", @@ -24226,12 +24311,12 @@ "meta-type": "object" }, { - "name": "[471]", - "element-type": "471", + "name": "[474]", + "element-type": "474", "meta-type": "array" }, { - "name": "471", + "name": "474", "members": [ { "name": "type", @@ -24241,7 +24326,7 @@ "meta-type": "object" }, { - "name": "472", + "name": "475", "meta-type": "enum", "values": [ "uninitialized", @@ -24252,7 +24337,7 @@ ] }, { - "name": "473", + "name": "476", "meta-type": "enum", "values": [ "memory", @@ -24262,7 +24347,7 @@ ] }, { - "name": "474", + "name": "477", "meta-type": "enum", "values": [ "access-latency", @@ -24274,7 +24359,7 @@ ] }, { - "name": "475", + "name": "478", "meta-type": "enum", "values": [ "none", @@ -24283,7 +24368,7 @@ ] }, { - "name": "476", + "name": "479", "meta-type": "enum", "values": [ "none", @@ -24292,7 +24377,7 @@ ] }, { - "name": "477", + "name": "480", "members": [ { "name": "desc", @@ -24307,7 +24392,7 @@ "meta-type": "object" }, { - "name": "478", + "name": "481", "members": [ { "name": "device", @@ -24331,27 +24416,27 @@ "meta-type": "object" }, { - "name": "479", + "name": "482", "members": [ { "name": "bus", - "type": "534" + "type": "537" }, { "name": "devices", "default": null, - "type": "[371]" + "type": "[374]" } ], "meta-type": "object" }, { - "name": "[480]", - "element-type": "480", + "name": "[483]", + "element-type": "483", "meta-type": "array" }, { - "name": "480", + "name": "483", "members": [ { "name": "bar", @@ -24383,7 +24468,7 @@ "meta-type": "object" }, { - "name": "481", + "name": "484", "meta-type": "enum", "values": [ "string", @@ -24393,7 +24478,7 @@ ] }, { - "name": "482", + "name": "485", "members": [ { "name": "id", @@ -24432,7 +24517,7 @@ "meta-type": "object" }, { - "name": "483", + "name": "486", "members": [ { "name": "id", @@ -24455,7 +24540,7 @@ "meta-type": "object" }, { - "name": "484", + "name": "487", "members": [ { "name": "id", @@ -24494,7 +24579,7 @@ "meta-type": "object" }, { - "name": "485", + "name": "488", "meta-type": "enum", "values": [ "unknown", @@ -24505,7 +24590,7 @@ ] }, { - "name": "486", + "name": "489", "meta-type": "enum", "values": [ "qcow2", @@ -24514,37 +24599,37 @@ ] }, { - "name": "487", + "name": "490", "members": [ { "name": "data", - "type": "535" + "type": "538" } ], "meta-type": "object" }, { - "name": "488", + "name": "491", "members": [ { "name": "data", - "type": "536" + "type": "539" } ], "meta-type": "object" }, { - "name": "489", + "name": "492", "members": [ { "name": "data", - "type": "537" + "type": "540" } ], "meta-type": "object" }, { - "name": "490", + "name": "493", "meta-type": "enum", "values": [ "l1_update", @@ -24598,7 +24683,7 @@ ] }, { - "name": "491", + "name": "494", "meta-type": "enum", "values": [ "read", @@ -24610,19 +24695,19 @@ ] }, { - "name": "492", + "name": "495", "meta-type": "enum", "values": [ "inet" ] }, { - "name": "493", + "name": "496", "members": [ { "name": "template", "default": null, - "type": "494" + "type": "497" }, { "name": "main-header", @@ -24673,7 +24758,7 @@ "meta-type": "object" }, { - "name": "494", + "name": "497", "meta-type": "enum", "values": [ "none", @@ -24683,7 +24768,7 @@ ] }, { - "name": "495", + "name": "498", "meta-type": "enum", "values": [ "aes", @@ -24691,7 +24776,7 @@ ] }, { - "name": "496", + "name": "499", "members": [ { "name": "key-secret", @@ -24702,7 +24787,7 @@ "meta-type": "object" }, { - "name": "497", + "name": "500", "members": [ { "name": "key-secret", @@ -24713,14 +24798,14 @@ "meta-type": "object" }, { - "name": "498", + "name": "501", "meta-type": "enum", "values": [ "aes" ] }, { - "name": "499", + "name": "502", "meta-type": "enum", "values": [ "none", @@ -24729,11 +24814,11 @@ ] }, { - "name": "500", + "name": "503", "members": [ { "name": "type", - "type": "538" + "type": "541" }, { "name": "hash", @@ -24743,7 +24828,7 @@ "meta-type": "object" }, { - "name": "501", + "name": "504", "meta-type": "enum", "values": [ "off", @@ -24753,7 +24838,7 @@ ] }, { - "name": "502", + "name": "505", "meta-type": "enum", "values": [ "aes-128", @@ -24771,7 +24856,7 @@ ] }, { - "name": "503", + "name": "506", "meta-type": "enum", "values": [ "ecb", @@ -24781,7 +24866,7 @@ ] }, { - "name": "504", + "name": "507", "meta-type": "enum", "values": [ "plain", @@ -24790,7 +24875,7 @@ ] }, { - "name": "505", + "name": "508", "meta-type": "enum", "values": [ "md5", @@ -24803,28 +24888,28 @@ ] }, { - "name": "506", + "name": "509", "tag": "format", "variants": [ { "case": "qcow", - "type": "496" + "type": "499" }, { "case": "luks", - "type": "540" + "type": "543" } ], "members": [ { "name": "format", - "type": "539" + "type": "542" } ], "meta-type": "object" }, { - "name": "507", + "name": "510", "meta-type": "enum", "values": [ "v2", @@ -24832,35 +24917,35 @@ ] }, { - "name": "508", + "name": "511", "meta-type": "enum", "values": [ "zlib" ] }, { - "name": "509", + "name": "512", "tag": "type", "variants": [ { "case": "full", - "type": "542" + "type": "545" }, { "case": "erasure-coded", - "type": "543" + "type": "546" } ], "members": [ { "name": "type", - "type": "541" + "type": "544" } ], "meta-type": "object" }, { - "name": "510", + "name": "513", "meta-type": "enum", "values": [ "dynamic", @@ -24868,7 +24953,7 @@ ] }, { - "name": "511", + "name": "514", "meta-type": "enum", "values": [ "monolithicSparse", @@ -24879,7 +24964,7 @@ ] }, { - "name": "512", + "name": "515", "meta-type": "enum", "values": [ "ide", @@ -24889,7 +24974,7 @@ ] }, { - "name": "513", + "name": "516", "meta-type": "enum", "values": [ "dynamic", @@ -24897,7 +24982,7 @@ ] }, { - "name": "514", + "name": "517", "meta-type": "enum", "values": [ "active", @@ -24905,12 +24990,12 @@ ] }, { - "name": "515", + "name": "518", "tag": "format", "variants": [ { "case": "luks", - "type": "544" + "type": "547" }, { "case": "qcow", @@ -24920,13 +25005,13 @@ "members": [ { "name": "format", - "type": "539" + "type": "542" } ], "meta-type": "object" }, { - "name": "516", + "name": "519", "members": [ { "name": "logfile", @@ -24956,7 +25041,7 @@ "meta-type": "object" }, { - "name": "517", + "name": "520", "members": [ { "name": "logfile", @@ -24976,7 +25061,7 @@ "meta-type": "object" }, { - "name": "518", + "name": "521", "members": [ { "name": "logfile", @@ -24990,7 +25075,7 @@ }, { "name": "addr", - "type": "284" + "type": "286" }, { "name": "tls-creds", @@ -25041,7 +25126,7 @@ "meta-type": "object" }, { - "name": "519", + "name": "522", "members": [ { "name": "logfile", @@ -25055,18 +25140,18 @@ }, { "name": "remote", - "type": "284" + "type": "286" }, { "name": "local", "default": null, - "type": "284" + "type": "286" } ], "meta-type": "object" }, { - "name": "520", + "name": "523", "members": [ { "name": "logfile", @@ -25082,7 +25167,7 @@ "meta-type": "object" }, { - "name": "521", + "name": "524", "members": [ { "name": "logfile", @@ -25102,7 +25187,7 @@ "meta-type": "object" }, { - "name": "522", + "name": "525", "members": [ { "name": "logfile", @@ -25123,7 +25208,7 @@ "meta-type": "object" }, { - "name": "523", + "name": "526", "members": [ { "name": "logfile", @@ -25143,7 +25228,7 @@ "meta-type": "object" }, { - "name": "524", + "name": "527", "members": [ { "name": "logfile", @@ -25163,7 +25248,7 @@ "meta-type": "object" }, { - "name": "525", + "name": "528", "members": [ { "name": "logfile", @@ -25199,7 +25284,7 @@ "meta-type": "object" }, { - "name": "526", + "name": "529", "members": [ { "name": "logfile", @@ -25220,7 +25305,7 @@ "meta-type": "object" }, { - "name": "527", + "name": "530", "members": [ { "name": "path", @@ -25236,7 +25321,7 @@ "meta-type": "object" }, { - "name": "528", + "name": "531", "members": [ { "name": "chardev", @@ -25246,7 +25331,7 @@ "meta-type": "object" }, { - "name": "529", + "name": "532", "meta-type": "enum", "values": [ "unmapped", @@ -25400,11 +25485,11 @@ ] }, { - "name": "530", + "name": "533", "members": [ { "name": "key", - "type": "321" + "type": "323" }, { "name": "down", @@ -25414,11 +25499,11 @@ "meta-type": "object" }, { - "name": "531", + "name": "534", "members": [ { "name": "button", - "type": "545" + "type": "548" }, { "name": "down", @@ -25428,11 +25513,11 @@ "meta-type": "object" }, { - "name": "532", + "name": "535", "members": [ { "name": "axis", - "type": "546" + "type": "549" }, { "name": "value", @@ -25442,13 +25527,13 @@ "meta-type": "object" }, { - "name": "533", + "name": "536", "members": [ ], "meta-type": "object" }, { - "name": "534", + "name": "537", "members": [ { "name": "number", @@ -25464,21 +25549,21 @@ }, { "name": "io_range", - "type": "547" + "type": "550" }, { "name": "memory_range", - "type": "547" + "type": "550" }, { "name": "prefetchable_range", - "type": "547" + "type": "550" } ], "meta-type": "object" }, { - "name": "535", + "name": "538", "members": [ { "name": "compat", @@ -25494,6 +25579,11 @@ "default": null, "type": "bool" }, + { + "name": "extended-l2", + "default": null, + "type": "bool" + }, { "name": "lazy-refcounts", "default": null, @@ -25511,22 +25601,22 @@ { "name": "encrypt", "default": null, - "type": "548" + "type": "551" }, { "name": "bitmaps", "default": null, - "type": "[549]" + "type": "[552]" }, { "name": "compression-type", - "type": "508" + "type": "511" } ], "meta-type": "object" }, { - "name": "536", + "name": "539", "members": [ { "name": "create-type", @@ -25542,34 +25632,34 @@ }, { "name": "extents", - "type": "[241]" + "type": "[243]" } ], "meta-type": "object" }, { - "name": "537", + "name": "540", "members": [ { "name": "cipher-alg", - "type": "502" + "type": "505" }, { "name": "cipher-mode", - "type": "503" + "type": "506" }, { "name": "ivgen-alg", - "type": "504" + "type": "507" }, { "name": "ivgen-hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "hash-alg", - "type": "505" + "type": "508" }, { "name": "payload-offset", @@ -25585,13 +25675,13 @@ }, { "name": "slots", - "type": "[550]" + "type": "[553]" } ], "meta-type": "object" }, { - "name": "538", + "name": "541", "meta-type": "enum", "values": [ "md5", @@ -25599,7 +25689,7 @@ ] }, { - "name": "539", + "name": "542", "meta-type": "enum", "values": [ "qcow", @@ -25607,7 +25697,7 @@ ] }, { - "name": "540", + "name": "543", "members": [ { "name": "key-secret", @@ -25617,27 +25707,27 @@ { "name": "cipher-alg", "default": null, - "type": "502" + "type": "505" }, { "name": "cipher-mode", "default": null, - "type": "503" + "type": "506" }, { "name": "ivgen-alg", "default": null, - "type": "504" + "type": "507" }, { "name": "ivgen-hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "hash-alg", "default": null, - "type": "505" + "type": "508" }, { "name": "iter-time", @@ -25648,7 +25738,7 @@ "meta-type": "object" }, { - "name": "541", + "name": "544", "meta-type": "enum", "values": [ "full", @@ -25656,7 +25746,7 @@ ] }, { - "name": "542", + "name": "545", "members": [ { "name": "copies", @@ -25666,7 +25756,7 @@ "meta-type": "object" }, { - "name": "543", + "name": "546", "members": [ { "name": "data-strips", @@ -25680,11 +25770,11 @@ "meta-type": "object" }, { - "name": "544", + "name": "547", "members": [ { "name": "state", - "type": "514" + "type": "517" }, { "name": "new-secret", @@ -25715,7 +25805,7 @@ "meta-type": "object" }, { - "name": "545", + "name": "548", "meta-type": "enum", "values": [ "left", @@ -25728,7 +25818,7 @@ ] }, { - "name": "546", + "name": "549", "meta-type": "enum", "values": [ "x", @@ -25736,7 +25826,7 @@ ] }, { - "name": "547", + "name": "550", "members": [ { "name": "base", @@ -25750,12 +25840,12 @@ "meta-type": "object" }, { - "name": "548", + "name": "551", "tag": "format", "variants": [ { "case": "luks", - "type": "537" + "type": "540" }, { "case": "aes", @@ -25765,18 +25855,18 @@ "members": [ { "name": "format", - "type": "495" + "type": "498" } ], "meta-type": "object" }, { - "name": "[549]", - "element-type": "549", + "name": "[552]", + "element-type": "552", "meta-type": "array" }, { - "name": "549", + "name": "552", "members": [ { "name": "name", @@ -25788,23 +25878,23 @@ }, { "name": "flags", - "type": "[551]" + "type": "[554]" } ], "meta-type": "object" }, { - "name": "[241]", - "element-type": "241", + "name": "[243]", + "element-type": "243", "meta-type": "array" }, { - "name": "[550]", - "element-type": "550", + "name": "[553]", + "element-type": "553", "meta-type": "array" }, { - "name": "550", + "name": "553", "members": [ { "name": "active", @@ -25828,12 +25918,12 @@ "meta-type": "object" }, { - "name": "[551]", - "element-type": "551", + "name": "[554]", + "element-type": "554", "meta-type": "array" }, { - "name": "551", + "name": "554", "meta-type": "enum", "values": [ "in-use", @@ -29482,6 +29572,14 @@ "deprecated": false, "default-ram-id": "pc.ram" }, + { + "hotpluggable-cpus": false, + "name": "none", + "numa-mem-supported": false, + "cpu-max": 1, + "deprecated": false, + "default-ram-id": "ram" + }, { "hotpluggable-cpus": true, "name": "pc-1.1", @@ -29491,14 +29589,6 @@ "deprecated": true, "default-ram-id": "pc.ram" }, - { - "hotpluggable-cpus": false, - "name": "none", - "numa-mem-supported": false, - "cpu-max": 1, - "deprecated": false, - "default-ram-id": "ram" - }, { "hotpluggable-cpus": true, "name": "pc-i440fx-2.7", -- 2.26.2

2 1

recommendations for handling Hyper-V version number
by Matt Coleman 28 Sep '20

28 Sep '20

Hello again, Hyper-V version numbers are not compatible with the encoding used in virParseVersionString: https://gitlab.com/libvirt/libvirt/-/blob/master/src/util/virutil.c#L246 For example, the Windows Server 2016 Hyper-V version is 10.0.14393.0, so its “micro” is over 14 times larger than the encoding allows. My current workaround is to truncate it to something that works (E.G. 10.0.143), but that's clearly less than ideal. Is the output of virParseVersionString stored on disk at any point? Would changing its output type from unsigned long to unsigned long long cause any compatibility issues? That would allow “minor” and “micro” to be up to 6 digits each and would be a quick, easy change. Thanks, Matt

4 6

[PATCH v4 00/11] qemu: Add <transient/> disk support
by Peter Krempa 25 Sep '20

25 Sep '20

This version: - is rebased on top of current refactors - has more strict rules in the validation - adds tests - fixes bug with disk-unplug Masayoshi Mizuma (5): qemu: Block blockjobs when transient disk option is enabled qemu: Block disk hotplug when transient disk option is enabled qemu: Block migration when transient disk option is enabled qemu: process: Handle transient disks on VM startup qemu: validate: Allow <transient/> disks Peter Krempa (6): virDomainSnapshotDiskDefFree: Export and register as autoptr func qemu: prepare cleanup for <transient/> disk overlays qemu: snapshot: Introduce helpers for creating overlays on <transient/> disks qemu: hotplug: Remove overlay of <transient> disk on disk unplug tests: qemuxml2argv: Fix and enable 'disk-transient' case TODO: Add news entry TODO | 0 docs/formatdomain.rst | 5 +- src/conf/snapshot_conf.h | 5 + src/conf/snapshot_conf_priv.h | 3 - src/qemu/qemu_domain.c | 9 ++ src/qemu/qemu_domain.h | 4 + src/qemu/qemu_hotplug.c | 15 +++ src/qemu/qemu_migration.c | 10 ++ src/qemu/qemu_process.c | 27 ++++++ src/qemu/qemu_snapshot.c | 91 ++++++++++++++++++- src/qemu/qemu_snapshot.h | 5 + src/qemu/qemu_validate.c | 56 ++++++++++-- .../disk-transient.x86_64-4.1.0.err | 1 + .../disk-transient.x86_64-latest.args | 42 +++++++++ tests/qemuxml2argvdata/disk-transient.xml | 4 +- tests/qemuxml2argvtest.c | 2 + 16 files changed, 265 insertions(+), 14 deletions(-) create mode 100644 TODO create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-4.1.0.err create mode 100644 tests/qemuxml2argvdata/disk-transient.x86_64-latest.args -- 2.26.2

4 21

[PATCH] NEWS: Mention qcow2 cluster size being preserved accross snapshots and iSCSI hostdev fixes
by Peter Krempa 25 Sep '20

25 Sep '20

Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e992fbe471..97417033f4 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -55,8 +55,20 @@ v6.8.0 (unreleased) the previous behavior with an improvement: it also reflects the auto-aligned value in the domain XML. + * qemu: Preserve qcow2 cluster size after external snapshots + + The new overlay image which is installed on top of the current chain when + taking an external snapshot now preserves the cluser size of the original + top image to preserve any performance tuning done on the original image. + * **Bug fixes** + * qemu: Various (i)SCSI backed hostdev fixes + + (i)SCSI backed hostdevs now work again with an arbitrarily long + user-specified device alias and also honor the 'readonly' property after a + recent rewrite. + * **Removed features** * node_device: Remove HAL node device backend -- 2.26.2

2 1

[PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization
by Bihong Yu 25 Sep '20

25 Sep '20

>From c328ff62b11d58553fd2032a85fd3295e009b3d3 Mon Sep 17 00:00:00 2001 From: Bihong Yu <yubihong(a)huawei.com> Date: Fri, 17 Jul 2020 16:55:12 +0800 Subject: [PATCH] qemu: clear residual QMP caps processes during QEMU driver initialization In some cases, the QMP capabilities processes possible residue. So we need to clear the residual QMP caps processes during starting libvirt. Signed-off-by:Bihong Yu <yubihong(a)huawei.com> --- src/qemu/qemu_driver.c | 2 ++ src/qemu/qemu_process.c | 40 ++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_process.h | 2 ++ 3 files changed, 44 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d185666..d627fd7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -889,6 +889,8 @@ qemuStateInitialize(bool privileged, run_gid = cfg->group; } + qemuProcessQMPClear(cfg->libDir); + qemu_driver->qemuCapsCache = virQEMUCapsCacheNew(cfg->libDir, cfg->cacheDir, run_uid, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 70fc24b..d545e3e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -8312,6 +8312,46 @@ static qemuMonitorCallbacks callbacks = { }; +/** + * qemuProcessQMPClear + * + * Try to kill residual QMP caps processes + */ +void +qemuProcessQMPClear(const char *libDir) +{ + virErrorPtr orig_err; + DIR *dirp = NULL; + struct dirent *dp; + + if (!virFileExists(libDir)) + return; + + if (virDirOpen(&dirp, libDir) < 0) + return; + + virErrorPreserveLast(&orig_err); + while (virDirRead(dirp, &dp, libDir) > 0) { + g_autofree char *qmp_uniqDir = NULL; + g_autofree char *qmp_pidfile = NULL; + + if (!STRPREFIX(dp->d_name, "qmp-")) + continue; + + qmp_uniqDir = g_strdup_printf("%s/%s", libDir, dp->d_name); + qmp_pidfile = g_strdup_printf("%s/%s", qmp_uniqDir, "qmp.pid"); + + ignore_value(virPidFileForceCleanupPath(qmp_pidfile)); + + if (qmp_uniqDir) + rmdir(qmp_uniqDir); + } + virErrorRestore(&orig_err); + + VIR_DIR_CLOSE(dirp); +} + + static void qemuProcessQMPStop(qemuProcessQMPPtr proc) { diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h index 15e67b9..b039e6c 100644 --- a/src/qemu/qemu_process.h +++ b/src/qemu/qemu_process.h @@ -233,6 +233,8 @@ qemuProcessQMPPtr qemuProcessQMPNew(const char *binary, gid_t runGid, bool forceTCG); +void qemuProcessQMPClear(const char *libDir); + void qemuProcessQMPFree(qemuProcessQMPPtr proc); int qemuProcessQMPStart(qemuProcessQMPPtr proc); -- 1.8.3.1

3 7

Help on Meson build Error
by Wei Wang 25 Sep '20

25 Sep '20

Seems it didn't appear on the mailing list, resent it. Hi folks, I'm trying to build libvirt using meson with the latest upstream libvirt, but the compilation fails: (followed on https://libvirt.org/compiling.html, not sure if any dependencies are missed. I checked, src/util/libvirt_util.a.p does not exist.) FAILED: src/util/libvirt_util.a.p/glibcompat.c.o .... In file included from ../src/util/glibcompat.c:19: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/virfirmware.c.o In file included from ../src/util/virarch.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/viraudit.c.o In file included from ../src/util/viraudit.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory Any help is appreciated. Thanks, Wei

4 20

[libvirt PATCH] gitdm: add more individual contributors
by Pino Toscano 25 Sep '20

25 Sep '20

Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- docs/gitdm/groups/unaffiliated | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/docs/gitdm/groups/unaffiliated b/docs/gitdm/groups/unaffiliated index 5f867fc5e4..1ca7eee81f 100644 --- a/docs/gitdm/groups/unaffiliated +++ b/docs/gitdm/groups/unaffiliated @@ -14,6 +14,7 @@ gmx.de googlemail.com hotmail.com mail.ru +mailbox.org outlook.com pobox.com protonmail.com @@ -43,11 +44,14 @@ cky(a)cky.nz contact(a)puzio.waw.pl d.herrendoerfer(a)herrendoerfer.name dan(a)danny.cz +davem(a)davemloft.net debfx(a)fobos.de eike(a)sf-mail.de exo(a)tty.sk +fedora(a)borsoi.fr fritz(a)fritz-elfert.de gene(a)czarc.net +git(a)ryandesign.com gordon(a)dragonsdawn.net gregor(a)kopka.net heathpetersen(a)kandre.com @@ -59,9 +63,11 @@ jaak(a)ristioja.ee james410(a)cowgill.org.uk james(a)shubin.ca jasper(a)humppa.nl +jean-baptiste(a)holcroft.fr jeremy(a)goop.org jk(a)ozlabs.org jwm(a)horde.net +kevin(a)kevinlocke.name klaus(a)ethgen.de lacos(a)caesar.elte.hu lenaic(a)lhuard.fr.eu.org @@ -71,6 +77,7 @@ marti(a)juffo.org max(a)rfc2324.org michael(a)ellerman.id.au mike(a)very.puzzling.org +milo(a)milo.name n0ano(a)n0ano.com neil(a)aldur.co.uk nobody(a)nowhere.ws @@ -81,11 +88,14 @@ richard(a)nod.at rmy(a)tigress.co.uk ruben(a)rubenkerkhof.com rufo(a)rufoa.com +scott-libvirt(a)shambarger.net +shemminger(a)vyatta.com slawek(a)kaplonski.pl soulxu(a)soulxu-thinkpad-t410.(none) stybla(a)turnovfree.net tai(a)rakugaki.org thomas(a)scripty.at +toscano.pino(a)tiscali.it v.tolstov(a)selfip.ru ville.skytta(a)iki.fi vincent(a)bernat.im -- 2.26.2

2 1

[libvirt PATCH] meson: drop HTML4 variants of rst2html
by Daniel P. Berrangé 25 Sep '20

25 Sep '20

We stopped supportin Ubuntu 16.04 earlier in the year, so there is no reason to keep the HTML4 variants of rst2html around. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- meson.build | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/meson.build b/meson.build index bc52079809..2e57a435df 100644 --- a/meson.build +++ b/meson.build @@ -898,8 +898,7 @@ required_programs = [ required_programs_groups = [ {'name':'rpcgen', 'prog':['rpcgen', 'portable-rpcgen']}, - # Drop the rst2html (aka HTML4) variants once we stop supporting Ubuntu 16.04 (Xenial) - {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3', 'rst2html', 'rst2html.py', 'rst2html-3']}, + {'name':'rst2html', 'prog':['rst2html5', 'rst2html5.py', 'rst2html5-3']}, {'name':'rst2man', 'prog':['rst2man', 'rst2man.py', 'rst2man-3']}, ] -- 2.26.2

3 2

[PATCH] meson: don't check for libutil.h except on FreeBSD
by Daniel P. Berrangé 25 Sep '20

25 Sep '20

The libutil.h we are after is explicitly only something we want on FreeBSD, we don't want to accidentally pick up this header on other platforms as it can lead to build failures. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 4d42468a51..bc52079809 100644 --- a/meson.build +++ b/meson.build @@ -685,7 +685,6 @@ headers = [ 'asm/hwcap.h', 'ifaddrs.h', 'libtasn1.h', - 'libutil.h', 'linux/kvm.h', 'linux/magic.h', 'mntent.h', @@ -711,6 +710,10 @@ if host_machine.system() == 'linux' headers += 'linux/devlink.h' endif +if host_machine.system() == 'freebsd' + headers += 'libutil.h' +endif + foreach name : headers if cc.has_header(name) conf.set('WITH_@0@'.format(name.underscorify().to_upper()), 1) -- 2.26.2

3 2

[libvirt PATCH 0/5] Use g_new0 more (glib chronicles)
by Ján Tomko 24 Sep '20

24 Sep '20

Remove VIR_ALLOC* from tools/ (with the exception of vsh*alloc, which will be cleaned up later) and some random subdirs from src/ Ján Tomko (5): node_device: use g_new0 instead of VIR_ALLOC* openvz: use g_new0 instead of VIR_ALLOC* secret: use g_new0 instead of VIR_ALLOC* security: use g_new0 instead of VIR_ALLOC* tools: use g_new0 instead of VIR_ALLOC* src/node_device/node_device_udev.c | 27 +++++++++------------------ src/openvz/openvz_conf.c | 12 ++++-------- src/openvz/openvz_driver.c | 3 +-- src/secret/secret_driver.c | 3 +-- src/security/security_apparmor.c | 3 +-- src/security/security_dac.c | 9 +++------ src/security/security_manager.c | 14 +++++--------- src/security/security_selinux.c | 9 +++------ src/security/security_stack.c | 6 ++---- tools/virsh-domain-monitor.c | 11 +++-------- tools/virsh-domain.c | 26 ++++++++------------------ tools/virt-admin-completer.c | 12 +----------- tools/virt-login-shell-helper.c | 13 ++++--------- tools/vsh-table.c | 21 +++++++-------------- tools/vsh.c | 5 +---- 15 files changed, 53 insertions(+), 121 deletions(-) -- 2.26.2

2 10

[PATCH FOR 6.8.0] libxl: Don't free def member of virDomainObj
by Jim Fehlig 24 Sep '20

24 Sep '20

The refactoring in commit de49d5bad3 accidentally dropped the statement setting def to NULL after successfully adding it to the virDomainObjList, causing it to be freed while still in use. The resulting memory corruption caused unpredictable behavior, often resulting in a libvirtd crash. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- Unpredictable is an understatement! When running monolithic libvirtd with both qemu and xen drviers enabled, qemu crashed while initializing. Recall it is initialized after xen. Thread 17 "daemon-init" received signal SIGSEGV, Segmentation fault. #0 0x00007f32e5fbe9e3 in _int_malloc () at /lib64/libc.so.6 #1 0x00007f32e5fbf6e0 in _int_realloc () at /lib64/libc.so.6 #2 0x00007f32e5fc0729 in realloc () at /lib64/libc.so.6 #3 0x00007f32e6dc21b8 in g_realloc () at /usr/lib64/libglib-2.0.so.0 #4 0x00007f32e7532090 in virReallocN (ptrptr=0x7f329affcad8, size=1, count=1403) at ../src/util/viralloc.c:91 #5 0x00007f32e75530c7 in virCommandProcessIO (cmd=0x7f328807ff40) at ../src/util/vircommand.c:2271 #6 0x00007f32e7553a6a in virCommandRun (cmd=0x7f328807ff40, exitstatus=0x0) at ../src/util/vircommand.c:2451 #7 0x00007f32e75dde73 in virSysinfoReadDMI () at ../src/util/virsysinfo.c:1237 #8 0x00007f32e75de0cb in virSysinfoRead () at ../src/util/virsysinfo.c:1294 #9 0x00007f32a240b69d in qemuStateInitialize (privileged=true, root=0x0, callback=0x56453a0b3e97 <daemonInhibitCallback>, opaque=0x56453b000030) at ../src/qemu/qemu_driver.c:658 #10 0x00007f32e7832350 in virStateInitialize (privileged=true, mandatory=false, root=0x0, callback=0x56453a0b3e97 <daemonInhibitCallback>, opaque=0x56453b000030) at ../src/libvirt.c:656 #11 0x000056453a0b4175 in daemonRunStateInit (opaque=0x56453b000030) at ../src/remote/remote_daemon.c:596 src/libxl/libxl_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 083738871d..571b70f982 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -627,6 +627,7 @@ libxlAddDom0(libxlDriverPrivatePtr driver) NULL))) goto cleanup; + def = NULL; vm->persistent = 1; virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); } -- 2.28.0

3 2

[RFC DOCUMENT 00/12] kubevirt-and-kvm: Add documents
by Andrea Bolognani 24 Sep '20

24 Sep '20

Hello there! Several weeks ago, a group of Red Hatters working on the virtualization stack (primarily QEMU and libvirt) started a conversation with developers from the KubeVirt project with the goal of better understanding and documenting the interactions between the two. Specifically, we were interested in integration pain points, with the underlying ideas being that only once those issues are understood it becomes possible to look for solutions, and that better communication would naturally lead to improvements on both sides. This series of documents was born out of that conversation. We're sharing them with the QEMU and libvirt communities in the hope that they can be a valuable resource for understanding how the projects they're working on are consumed by higher-level tools, and what challenges are encountered in the process. Note that, while the documents describe a number of potential directions for things like development of new components, that's all just brainstorming that naturally occurred as we were learning new things: the actual design process should, and will, happen on the upstream lists. Right now the documents live in their own little git repository[1], but the expectation is that eventually they will find a suitable long-term home. The most likely candidate right now is the main KubeVirt repository, but if you have other locations in mind please do speak up! I'm also aware of the fact that this delivery mechanism is fairly unconventional, but I thought it would be the best way to spark a discussion around these topics with the QEMU and libvirt developers. Last but not least, please keep in mind that the documents are a work in progress, and polish has been applied to them unevenly: while the information presented is, to the best of our knowledge, all accurate, some parts are in a rougher state than others. Improvements will hopefully come over time - and if you feel like helping out in making that happen, it would certainly be appreciated! Looking forward to your feedback :) [1] https://gitlab.com/abologna/kubevirt-and-kvm -- Andrea Bolognani / Red Hat / Virtualization

2 14

[libvirt PATCH] news: document recent esx API implementations
by Pino Toscano 24 Sep '20

24 Sep '20

Signed-off-by: Pino Toscano <ptoscano(a)redhat.com> --- NEWS.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e992fbe471..7c723e6610 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -32,6 +32,13 @@ v6.8.0 (unreleased) can now be passed using the ``passwd`` attribute on the ``<graphics>`` element. + * esx: implement few APIs + + The ``virConnectListAllNetworks()``, ``virDomainGetHostname()``, and + ``virDomainInterfaceAddresses()`` (only for + ``VIR_DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT`` source) APIs were implemented + in the esx driver. + * **Improvements** * qemu: Allow migration over UNIX sockets -- 2.26.2

2 1

[libvirt PATCH] news: add note about new virt-ssh-helper binary
by Daniel P. Berrangé 24 Sep '20

24 Sep '20

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- NEWS.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index e992fbe471..13d2ff1d2f 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -32,6 +32,19 @@ v6.8.0 (unreleased) can now be passed using the ``passwd`` attribute on the ``<graphics>`` element. + * remote: ``virt-ssh-helper`` replaces ``nc`` for SSH tunnelling + + Libvirt now provides a ``virt-ssh-helper`` binary on the server + side. The libvirt remote client will use this binary for setting + up an SSH tunnelled connection to hosts. If not present, it will + transparently fallback to the traditional ``nc`` tunnel. The new + binary makes it possible for libvirt to transparently connect + across hosts even if libvirt is built with a different installation + prefix on the client vs server. It also enables remote access to + the unprivileged per-user libvirt daemons(eg using a URI such as + ``qemu+ssh://hostname/session``. The only requirement is that + ``virt-ssh-helper`` is present in $PATH of the remote host. + * **Improvements** * qemu: Allow migration over UNIX sockets -- 2.26.2

2 1

[libvirt PATCH v4 00/11] remote: introduce a custom netcat impl for ssh tunnelling
by Daniel P. Berrangé 24 Sep '20

24 Sep '20

We have long had a problem with use of netcat for ssh tunnelling because there's no guarantee the UNIX socket path the client builds will match the UNIX socket path the remote host uses. We don't even allow session mode SSH tunnelling for this reason. We also can't easily auto-spawn libvirtd in session mode. With the introduction of modular daemons we also have potential for two completely different UNIX socket paths even for system mode, and the client can't know which to use. The solution to all these problems is to introduce a custom netcat impl. Instead passing the UNIX socket path, we pass the libvirt driver URI. The custom netcat then decides which socket path to use based on the remote build host environment. We still have to support netcat for interoperability with legacy libvirt versions, but we can default to the new virt-nc. v4: Now with many fixed bugs to make it actually work v3: Now with more meson and less autotools ! Daniel P. Berrangé (11): rpc: merge logic for generating remote SSH shell script remote: push logic for default netcat binary into common helper remote: split off enums into separate source file remote: split out function for parsing URI scheme remote: parse the remote transport string earlier remote: split out function for constructing socket path remote: extract logic for determining daemon to connect to remote: introduce virt-ssh-helper binary rpc: switch order of args in virNetClientNewSSH rpc: use new virt-ssh-helper binary for remote tunnelling remote: fix error reporting for invalid daemon mode build-aux/syntax-check.mk | 2 +- docs/uri.html.in | 24 +- libvirt.spec.in | 2 + po/POTFILES.in | 2 + src/libvirt_remote.syms | 1 + src/remote/meson.build | 18 ++ src/remote/remote_driver.c | 331 +++++-------------------- src/remote/remote_sockets.c | 277 +++++++++++++++++++++ src/remote/remote_sockets.h | 70 ++++++ src/remote/remote_ssh_helper.c | 425 +++++++++++++++++++++++++++++++++ src/rpc/virnetclient.c | 167 +++++++++---- src/rpc/virnetclient.h | 29 ++- src/rpc/virnetsocket.c | 37 +-- src/rpc/virnetsocket.h | 4 +- tests/virnetsockettest.c | 12 +- 15 files changed, 1030 insertions(+), 371 deletions(-) create mode 100644 src/remote/remote_sockets.c create mode 100644 src/remote/remote_sockets.h create mode 100644 src/remote/remote_ssh_helper.c -- 2.26.2

3 14

[PATCH V3] Modify virCPUarmCompare to perform compare actions
by Zhenyu Zheng 24 Sep '20

24 Sep '20

Modify virCPUarmCompare in cpu_arm.c to perform compare action. This patch only adds host to host CPU compare, the rest cases remains the same. This is useful for source and destination host compare during migrations to avoid migration between different CPU models that have different CPU freatures. Signed-off-by: Zhenyu Zheng <zheng.zhenyu(a)outlook.com> --- src/cpu/cpu_arm.c | 43 +++++++++++++++++++++++++++++++++++++++---- 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/src/cpu/cpu_arm.c b/src/cpu/cpu_arm.c index 939a3b8390..b420b14e86 100644 --- a/src/cpu/cpu_arm.c +++ b/src/cpu/cpu_arm.c @@ -463,11 +463,46 @@ virCPUarmBaseline(virCPUDefPtr *cpus, } static virCPUCompareResult -virCPUarmCompare(virCPUDefPtr host G_GNUC_UNUSED, - virCPUDefPtr cpu G_GNUC_UNUSED, - bool failMessages G_GNUC_UNUSED) +virCPUarmCompare(virCPUDefPtr host, + virCPUDefPtr cpu, + bool failIncompatible +) { - return VIR_CPU_COMPARE_IDENTICAL; + virCPUCompareResult ret = VIR_CPU_COMPARE_IDENTICAL; + + /* Only support host to host CPU compare for ARM*/ + if (cpu->type != VIR_CPU_TYPE_HOST) + return ret; + + if (!host || !host->model) { + if (failIncompatible) { + virReportError(VIR_ERR_CPU_INCOMPATIBLE, "%s", + _("unknown host CPU")); + ret = VIR_CPU_COMPARE_ERROR; + } else { + VIR_WARN("unknown host CPU"); + ret = VIR_CPU_COMPARE_INCOMPATIBLE; + } + return ret; + } + + /* Compare vendor and model to check if CPUs are identical */ + if (STRNEQ(host->vendor, cpu->vendor) || + STRNEQ(host->model, cpu->model)) { + VIR_DEBUG("Host CPU model does not match required CPU model %s", + cpu->model); + + if (failIncompatible) { + ret = VIR_CPU_COMPARE_ERROR; + virReportError(VIR_ERR_CPU_INCOMPATIBLE, + _("Host CPU model does not match required CPU model %s"), + cpu->model); + } else { + ret = VIR_CPU_COMPARE_INCOMPATIBLE; + } + } + + return ret; } static int -- 2.20.1

3 3

[PATCH v1 1/2] qemu: driver: use model name "host" for mode "host-passthrough"
by Collin Walling 24 Sep '20

24 Sep '20

When executing the hypervisor-cpu-compare/baseline commands and the XML file contains a CPU definition using host-passthrough and no model name, the commands will fail and return an error message from the QMP response. Let's fix this by checking for host-passthrough and a missing model name after the CPU definition has been converted from XML. If these conditions are matched, then the CPU definition's model name will be set to "host". Signed-off-by: Collin Walling <walling(a)linux.ibm.com> --- src/qemu/qemu_driver.c | 41 +++++++++++++++++++++++++++++++---------- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 1cecef01f7..427d2419f3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12281,6 +12281,26 @@ qemuConnectCPUModelComparison(virQEMUCapsPtr qemuCaps, } +static int +qemuConnectCheckCPUModel(virCPUDefPtr cpu) +{ + if (!cpu->model) { + /* + * On some architectures a model name is never present + * for the host-passthrough mode, so default it to "host" + */ + if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { + cpu->model = g_strdup("host"); + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("cpu parameter is missing a model name")); + return -1; + } + } + return 0; +} + + static int qemuConnectCompareHypervisorCPU(virConnectPtr conn, const char *emulator, @@ -12336,15 +12356,9 @@ qemuConnectCompareHypervisorCPU(virConnectPtr conn, if (virCPUDefParseXMLString(xmlCPU, VIR_CPU_TYPE_AUTO, &cpu) < 0) goto cleanup; - if (!cpu->model) { - if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { - cpu->model = g_strdup("host"); - } else { - virReportError(VIR_ERR_INVALID_ARG, "%s", - _("cpu parameter is missing a model name")); - goto cleanup; - } - } + if (qemuConnectCheckCPUModel(cpu) < 0) + goto cleanup; + ret = qemuConnectCPUModelComparison(qemuCaps, cfg->libDir, cfg->user, cfg->group, hvCPU, cpu, failIncompatible); @@ -12470,10 +12484,17 @@ qemuConnectCPUModelBaseline(virQEMUCapsPtr qemuCaps, if (VIR_ALLOC(baseline) < 0) return NULL; - if (virCPUDefCopyModel(baseline, cpus[0], false)) + if (qemuConnectCheckCPUModel(cpus[0]) < 0) + return NULL; + + if (virCPUDefCopyModel(baseline, cpus[0], false) < 0) return NULL; for (i = 1; i < ncpus; i++) { + + if (qemuConnectCheckCPUModel(cpus[i]) < 0) + return NULL; + if (qemuMonitorGetCPUModelBaseline(proc->mon, baseline, cpus[i], &result) < 0) return NULL; -- 2.26.2

2 4

[PATCH] virDomainNetFindIdx: add support for CCW addresses
by Cornelia Huck 24 Sep '20

24 Sep '20

Allow to match with CCW addresses in addition to PCI addresses (and MAC addresses). Signed-off-by: Cornelia Huck <cohuck(a)redhat.com> --- src/conf/device_conf.c | 12 ++++++++++++ src/conf/device_conf.h | 3 +++ src/conf/domain_conf.c | 23 ++++++++++++++++++++++- src/libvirt_private.syms | 1 + 4 files changed, 38 insertions(+), 1 deletion(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 9398191dfd84..87bf32bbc685 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -341,6 +341,18 @@ virDomainDeviceCCWAddressParseXML(xmlNodePtr node, return 0; } +bool +virDomainDeviceCCWAddressEqual(virDomainDeviceCCWAddressPtr addr1, + virDomainDeviceCCWAddressPtr addr2) +{ + if (addr1->cssid == addr2->cssid && + addr1->ssid == addr2->ssid && + addr1->devno == addr2->devno) { + return true; + } + return false; +} + int virDomainDeviceDriveAddressParseXML(xmlNodePtr node, virDomainDeviceDriveAddressPtr addr) diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index d7395f220174..a51bdf10ee6e 100644 --- a/src/conf/device_conf.h +++ b/src/conf/device_conf.h @@ -207,6 +207,9 @@ void virPCIDeviceAddressFormat(virBufferPtr buf, bool virDomainDeviceCCWAddressIsValid(virDomainDeviceCCWAddressPtr addr); int virDomainDeviceCCWAddressParseXML(xmlNodePtr node, virDomainDeviceCCWAddressPtr addr); +bool virDomainDeviceCCWAddressEqual(virDomainDeviceCCWAddressPtr addr1, + virDomainDeviceCCWAddressPtr addr2); +#define VIR_CCW_DEVICE_ADDRESS_FMT "%x.%x.%04x" int virDomainDeviceDriveAddressParseXML(xmlNodePtr node, virDomainDeviceDriveAddressPtr addr); diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8d30557bdcbe..a91dbd4aa95b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17816,6 +17816,8 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) bool MACAddrSpecified = !net->mac_generated; bool PCIAddrSpecified = virDomainDeviceAddressIsValid(&net->info, VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI); + bool CCWAddrSpecified = virDomainDeviceAddressIsValid(&net->info, + VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW); for (i = 0; i < def->nnets; i++) { if (MACAddrSpecified && @@ -17827,9 +17829,14 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) &net->info.addr.pci)) continue; + if (CCWAddrSpecified && + !virDomainDeviceCCWAddressEqual(&def->nets[i]->info.addr.ccw, + &net->info.addr.ccw)) + continue; + if (matchidx >= 0) { /* there were multiple matches on mac address, and no - * qualifying guest-side PCI address was given, so we must + * qualifying guest-side PCI/CCW address was given, so we must * fail (NB: a USB address isn't adequate, since it may * specify only vendor and product ID, and there may be * multiples of those. @@ -17859,6 +17866,14 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) net->info.addr.pci.bus, net->info.addr.pci.slot, net->info.addr.pci.function); + } else if (MACAddrSpecified && CCWAddrSpecified) { + virReportError(VIR_ERR_DEVICE_MISSING, + _("no device matching MAC address %s found on " + VIR_CCW_DEVICE_ADDRESS_FMT), + virMacAddrFormat(&net->mac, mac), + net->info.addr.ccw.cssid, + net->info.addr.ccw.ssid, + net->info.addr.ccw.devno); } else if (PCIAddrSpecified) { virReportError(VIR_ERR_DEVICE_MISSING, _("no device found on " VIR_PCI_DEVICE_ADDRESS_FMT), @@ -17866,6 +17881,12 @@ virDomainNetFindIdx(virDomainDefPtr def, virDomainNetDefPtr net) net->info.addr.pci.bus, net->info.addr.pci.slot, net->info.addr.pci.function); + } else if (CCWAddrSpecified) { + virReportError(VIR_ERR_DEVICE_MISSING, + _("no device found on " VIR_CCW_DEVICE_ADDRESS_FMT), + net->info.addr.ccw.cssid, + net->info.addr.ccw.ssid, + net->info.addr.ccw.devno); } else if (MACAddrSpecified) { virReportError(VIR_ERR_DEVICE_MISSING, _("no device matching MAC address %s found"), diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1db9970cca08..6bcbfa667d0e 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -128,6 +128,7 @@ virDeviceInfoPCIAddressIsWanted; virDomainDeviceAddressIsValid; virDomainDeviceAddressTypeToString; virDomainDeviceCcidAddressParseXML; +virDomainDeviceCCWAddressEqual; virDomainDeviceCCWAddressIsValid; virDomainDeviceCCWAddressParseXML; virDomainDeviceDriveAddressParseXML; -- 2.25.4

2 1

[PATCH] qemuxml2argvtest: Append newline to tested error messages
by Peter Krempa 24 Sep '20

24 Sep '20

'virTestCompareToFile' automatically fixes newline if it is not present in the input string but is present in the file. In this case we need to append the erorr messages with a newline so that VIR_TEST_REGENERATE_OUTPUT produces files which will pass syntax-check. Fixes: 9ec77eef2df Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/qemuxml2argvtest.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index a3c91fd5de..2b97eb80a4 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -621,9 +621,11 @@ testCompareXMLToArgv(const void *data) VIR_TEST_DEBUG("no error was reported for expected parse error"); goto cleanup; } - if (flags & FLAG_EXPECT_PARSE_ERROR && - virTestCompareToFile(err->message, info->errfile) >= 0) - goto ok; + if (flags & FLAG_EXPECT_PARSE_ERROR) { + g_autofree char *tmperr = g_strdup_printf("%s\n", NULLSTR(err->message)); + if (virTestCompareToFile(tmperr, info->errfile) >= 0) + goto ok; + } goto cleanup; } if (flags & FLAG_EXPECT_PARSE_ERROR) { @@ -663,9 +665,11 @@ testCompareXMLToArgv(const void *data) VIR_TEST_DEBUG("no error was reported for expected failure"); goto cleanup; } - if (flags & FLAG_EXPECT_FAILURE && - virTestCompareToFile(err->message, info->errfile) >= 0) - goto ok; + if (flags & FLAG_EXPECT_FAILURE) { + g_autofree char *tmperr = g_strdup_printf("%s\n", NULLSTR(err->message)); + if (virTestCompareToFile(tmperr, info->errfile) >= 0) + goto ok; + } goto cleanup; } if (flags & FLAG_EXPECT_FAILURE) { -- 2.26.2

2 1

[PATCH] cpu_map: Add EPYC-Rome model
by Markus Schade 24 Sep '20

24 Sep '20

Hi everyone, I'd like to add support for the EPYC-Rome CPU model from qemu. The following patch adds the model to cpu_map. While this allows to use the model, I am aware that some tests are required as well. However I am not certain what exactly is needed. I am happy to provide CPU flags or any required information from an EPYC 7502 system Signed-off-by: Markus Schade <markus.schade(a)hetzner.com> diff --git a/src/cpu_map/index.xml b/src/cpu_map/index.xml index 1486a29c65..fec01f324c 100644 --- a/src/cpu_map/index.xml +++ b/src/cpu_map/index.xml @@ -66,6 +66,7 @@ <include filename="x86_Opteron_G5.xml"/> <include filename="x86_EPYC.xml"/> <include filename="x86_EPYC-IBPB.xml"/> + <include filename="x86_EPYC-Rome.xml"/>  <include filename="x86_Dhyana.xml"/> diff --git a/src/cpu_map/meson.build b/src/cpu_map/meson.build index 19daa7157b..b86612b6e0 100644 --- a/src/cpu_map/meson.build +++ b/src/cpu_map/meson.build @@ -32,6 +32,7 @@ cpumap_data = [ 'x86_Dhyana.xml', 'x86_EPYC-IBPB.xml', 'x86_EPYC.xml', + 'x86_EPYC-Rome.xml', 'x86_features.xml', 'x86_Haswell-IBRS.xml', 'x86_Haswell-noTSX-IBRS.xml', diff --git a/src/cpu_map/x86_EPYC-Rome.xml b/src/cpu_map/x86_EPYC-Rome.xml new file mode 100644 index 0000000000..41d4123917 --- /dev/null +++ b/src/cpu_map/x86_EPYC-Rome.xml @@ -0,0 +1,81 @@ +<cpus> + <model name='EPYC-Rome'> + <decode host='on' guest='on'/> + <signature family='23' model='49'/> + <vendor name='AMD'/> + <feature name='3dnowprefetch'/> + <feature name='abm'/> + <feature name='adx'/> + <feature name='aes'/> + <feature name='amd-stibp'/> + <feature name='apic'/> + <feature name='arat'/> + <feature name='avx'/> + <feature name='avx2'/> + <feature name='bmi1'/> + <feature name='bmi2'/> + <feature name='clflush'/> + <feature name='clflushopt'/> + <feature name='clwb'/> + <feature name='clzero'/> + <feature name='cmov'/> + <feature name='cr8legacy'/> + <feature name='cx16'/> + <feature name='cx8'/> + <feature name='de'/> + <feature name='f16c'/> + <feature name='fma'/> + <feature name='fpu'/> + <feature name='fsgsbase'/> + <feature name='fxsr'/> + <feature name='fxsr_opt'/> + <feature name='ibpb'/> + <feature name='lahf_lm'/> + <feature name='lm'/> + <feature name='mca'/> + <feature name='mce'/> + <feature name='misalignsse'/> + <feature name='mmx'/> + <feature name='mmxext'/> + <feature name='monitor'/> + <feature name='movbe'/> + <feature name='msr'/> + <feature name='mtrr'/> + <feature name='nx'/> + <feature name='osvw'/> + <feature name='pae'/> + <feature name='pat'/> + <feature name='pclmuldq'/> + <feature name='pdpe1gb'/> + <feature name='perfctr_core'/> + <feature name='pge'/> + <feature name='pni'/> + <feature name='popcnt'/> + <feature name='pse'/> + <feature name='pse36'/> + <feature name='rdpid'/> + <feature name='rdrand'/> + <feature name='rdseed'/> + <feature name='rdtscp'/> + <feature name='sep'/> + <feature name='sha-ni'/> + <feature name='smap'/> + <feature name='smep'/> + <feature name='sse'/> + <feature name='sse2'/> + <feature name='sse4.1'/> + <feature name='sse4.2'/> + <feature name='sse4a'/> + <feature name='ssse3'/> + <feature name='svm'/> + <feature name='syscall'/> + <feature name='tsc'/> + <feature name='vme'/> + <feature name='wbnoinvd'/> + <feature name='xgetbv1'/> + <feature name='xsave'/> + <feature name='xsavec'/> + <feature name='xsaveerptr'/> + <feature name='xsaveopt'/> + </model> +</cpus>

2 1

[PATCH] util: stop probing for IFF_VNET_HDR
by Daniel P. Berrangé 24 Sep '20

24 Sep '20

This flag was added by Linux with: commit f43798c27684ab925adde7d8acc34c78c6e50df8 Author: Rusty Russell <rusty(a)rustcorp.com.au> Date: Thu Jul 3 03:48:02 2008 -0700 tun: Allow GSO using virtio_net_hdr so we can assume all Linux distros we support have this flag available and thus the compile time check is sufficient. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/util/virnetdevtap.c | 63 +---------------------------------------- 1 file changed, 1 insertion(+), 62 deletions(-) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index cbce5c71b7..77c4d1c52c 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -183,66 +183,6 @@ virNetDevTapGetRealDeviceName(char *ifname G_GNUC_UNUSED) } -/** - * virNetDevProbeVnetHdr: - * @tapfd: a tun/tap file descriptor - * - * Check whether it is safe to enable the IFF_VNET_HDR flag on the - * tap interface. - * - * Setting IFF_VNET_HDR enables QEMU's virtio_net driver to allow - * guests to pass larger (GSO) packets, with partial checksums, to - * the host. This greatly increases the achievable throughput. - * - * It is only useful to enable this when we're setting up a virtio - * interface. And it is only *safe* to enable it when we know for - * sure that a) qemu has support for IFF_VNET_HDR and b) the running - * kernel implements the TUNGETIFF ioctl(), which qemu needs to query - * the supplied tapfd. - * - * Returns 1 if VnetHdr is supported, 0 if not supported - */ -#ifdef IFF_VNET_HDR -static int -virNetDevProbeVnetHdr(int tapfd) -{ -# if defined(IFF_VNET_HDR) && defined(TUNGETFEATURES) && defined(TUNGETIFF) - unsigned int features; - struct ifreq dummy; - - if (ioctl(tapfd, TUNGETFEATURES, &features) != 0) { - VIR_INFO("Not enabling IFF_VNET_HDR; " - "TUNGETFEATURES ioctl() not implemented"); - return 0; - } - - if (!(features & IFF_VNET_HDR)) { - VIR_INFO("Not enabling IFF_VNET_HDR; " - "TUNGETFEATURES ioctl() reports no IFF_VNET_HDR"); - return 0; - } - - /* The kernel will always return -1 at this point. - * If TUNGETIFF is not implemented then errno == EBADFD. - */ - if (ioctl(tapfd, TUNGETIFF, &dummy) != -1 || errno != EBADFD) { - VIR_INFO("Not enabling IFF_VNET_HDR; " - "TUNGETIFF ioctl() not implemented"); - return 0; - } - - VIR_INFO("Enabling IFF_VNET_HDR"); - - return 1; -# else - (void) tapfd; - VIR_INFO("Not enabling IFF_VNET_HDR; disabled at build time"); - return 0; -# endif -} -#endif - - #ifdef TUNSETIFF /** * virNetDevTapGenerateName: @@ -363,8 +303,7 @@ int virNetDevTapCreate(char **ifname, } # ifdef IFF_VNET_HDR - if ((flags & VIR_NETDEV_TAP_CREATE_VNET_HDR) && - virNetDevProbeVnetHdr(fd)) + if (flags & VIR_NETDEV_TAP_CREATE_VNET_HDR) ifr.ifr_flags |= IFF_VNET_HDR; # endif -- 2.26.2

2 2

[PATCH 0/2] qemuSnapshotDiskContext(Cleanup|New): fix few bugs
by Peter Krempa 24 Sep '20

24 Sep '20

Oops. Peter Krempa (2): qemuSnapshotDiskContextCleanup: Don't leak snapctxt qemuSnapshotDiskContextNew: Don't set 'ndd' src/qemu/qemu_snapshot.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.26.2

2 3

[PATCH 0/6] qemu: snapshot: Refactors prior to introduction of <transient> disk support
by Peter Krempa 24 Sep '20

24 Sep '20

We'll be installing overlays on top of <transient> disks via the snapshot code. Prepare some aspects. Peter Krempa (6): qemu: snapshot: Rename 'qemuSnapshotCreateDiskActive' to 'qemuSnapshotCreateActiveExternalDisks' qemuSnapshotDiskUpdateSource: Extract 'driver' and 'blockdev' from 'vm' qemuSnapshotDiskPrepare/Cleanup: simplify passing of 'driver' and 'blockdev' qemu: snapshot: Introduce qemuSnapshotDiskContext qemuSnapshotCreateActiveExternalDisks: Extract actual snapshot creation to 'qemuSnapshotDiskCreate' qemuSnapshotDiskPrepare: rename to qemuSnapshotDiskPrepareActiveExternal src/qemu/qemu_snapshot.c | 215 ++++++++++++++++++++++----------------- 1 file changed, 124 insertions(+), 91 deletions(-) -- 2.26.2

2 8

[libvirt PATCH 00/14] Various cleanups
by Ján Tomko 24 Sep '20

24 Sep '20

Some reported by cppcheck, maybe even Coverity, the rest I noticed while looking at the code. Ján Tomko (14): tools: virshCheckpointListCollect: remove unused names vbox: remove VBoxCGlueTerm vbox: StartMachine: overwrite ret less often Remove pointless assignments Remove pointless initializations virsh: virshStreamSourceSkip: remove unused 'off' Do not check whether unsigned variables are negative libxl: remove unused 'bits' from struct guest_arch api: virDomainMemoryStats: use 'ret' variable storage: createFileDir: remove useless 'err' variable storage: createFileDir: use less ternary operators vbox: reduce variable scope in vboxDumpStorageControllers storage: storageBackendWipeLocal: reduce variable scope Reduce scope of some variables examples/c/admin/logging.c | 2 +- src/libvirt-domain.c | 8 ++--- src/libvirt-host.c | 4 +-- src/libxl/libxl_capabilities.c | 1 - src/libxl/libxl_driver.c | 2 +- src/node_device/node_device_driver.c | 3 +- src/openvz/openvz_driver.c | 2 +- src/storage/storage_backend_mpath.c | 3 +- src/storage/storage_util.c | 33 ++++++++++---------- src/test/test_driver.c | 2 +- src/vbox/vbox_XPCOMCGlue.c | 19 ------------ src/vbox/vbox_XPCOMCGlue.h | 1 - src/vbox/vbox_common.c | 46 +++++++++++++--------------- tests/virnumamock.c | 2 +- tests/virrandommock.c | 2 +- tools/virsh-checkpoint.c | 5 --- tools/virsh-pool.c | 3 +- tools/virsh-util.c | 3 +- 18 files changed, 53 insertions(+), 88 deletions(-) -- 2.26.2

3 30

[PATCH] tests: Adjust libxlxml2domconfigtest to work with Xen < 4.10
by Jim Fehlig 24 Sep '20

24 Sep '20

Commit f253dc90f5 introduced a test regression in environments with Xen < 4.10. The logic in libxl_conf.c correctly maps ACPI and APIC from virDomainObj to libxl_domain_conf based on LIBXL_HAVE_BUILDINFO_APIC, but the tests did not account for the different libxl_domain_conf JSON representations. One approach to fixing the test regression is to duplicate JSON test data files, having one set for Xen <= 4.9 and another for Xen 4.10 and greater. To avoid duplicate data files, this patch takes the approach of modifying the libxl_domain_conf object based on LIBXL_HAVE_BUILDINFO_APIC, before retrieving the JSON representation. It allows using the same test data files for all supported versions of Xen by adjusting the intermediate form of libxl_domain_conf object as needed. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- tests/libxlxml2domconfigtest.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tests/libxlxml2domconfigtest.c b/tests/libxlxml2domconfigtest.c index c4d5db9a7b..d58be1211b 100644 --- a/tests/libxlxml2domconfigtest.c +++ b/tests/libxlxml2domconfigtest.c @@ -97,6 +97,20 @@ testCompareXMLToDomConfig(const char *xmlfile, "Failed to create libxl_domain_config from JSON doc"); goto cleanup; } + + /* + * In order to have common test files between Xen 4.9 and newer Xen versions, + * tweak the expected libxl_domain_config object before getting a json + * representation. + */ +# ifndef LIBXL_HAVE_BUILDINFO_APIC + if (expectconfig.c_info.type == LIBXL_DOMAIN_TYPE_HVM) { + libxl_defbool_unset(&expectconfig.b_info.acpi); + libxl_defbool_set(&expectconfig.b_info.u.hvm.apic, true); + libxl_defbool_set(&expectconfig.b_info.u.hvm.acpi, true); + } +# endif + if (!(expectjson = libxl_domain_config_to_json(cfg->ctx, &expectconfig))) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", "Failed to retrieve JSON doc for libxl_domain_config"); -- 2.28.0

2 1

[libvirt PATCH v2] qemu: substitute missing model name for host-passthrough
by Tim Wiederhake 24 Sep '20

24 Sep '20

From: Collin Walling <walling(a)linux.ibm.com> Before: $ uname -m s390x $ cat passthrough-cpu.xml <cpu check="none" mode="host-passthrough" /> $ virsh hypervisor-cpu-compare passthrough-cpu.xml error: Failed to compare hypervisor CPU with passthrough-cpu.xml error: internal error: unable to execute QEMU command 'query-cpu-model-comp arison': Invalid parameter type for 'modelb.name', expected: string After: $ virsh hypervisor-cpu-compare passthrough-cpu.xml CPU described in passthrough-cpu.xml is identical to the CPU provided by hy pervisor on the host Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com> --- src/qemu/qemu_driver.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ae715c01d7..1cecef01f7 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -12336,6 +12336,15 @@ qemuConnectCompareHypervisorCPU(virConnectPtr conn, if (virCPUDefParseXMLString(xmlCPU, VIR_CPU_TYPE_AUTO, &cpu) < 0) goto cleanup; + if (!cpu->model) { + if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { + cpu->model = g_strdup("host"); + } else { + virReportError(VIR_ERR_INVALID_ARG, "%s", + _("cpu parameter is missing a model name")); + goto cleanup; + } + } ret = qemuConnectCPUModelComparison(qemuCaps, cfg->libDir, cfg->user, cfg->group, hvCPU, cpu, failIncompatible); -- 2.26.2

3 6

[PATCH] apparmor: Allow /usr/libexec for libxl-save-helper and pygrub
by Jim Fehlig 24 Sep '20

24 Sep '20

Like other distros, openSUSE Tumbleweed recently changed libexecdir from /usr/lib to /usr/libexec. Add it as an allowed path for libxl-save-helper and pygrub. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- I considered including /usr/lib64, but I don't think any distros are installing xen libexecdir targets to /usr/lib64. Happy to include it if I'm wrong :-). src/security/apparmor/usr.sbin.libvirtd.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/security/apparmor/usr.sbin.libvirtd.in b/src/security/apparmor/usr.sbin.libvirtd.in index f2030764cd..bf4563e1e8 100644 --- a/src/security/apparmor/usr.sbin.libvirtd.in +++ b/src/security/apparmor/usr.sbin.libvirtd.in @@ -86,8 +86,8 @@ profile libvirtd @sbindir@/libvirtd flags=(attach_disconnected) { /{usr/,}lib/udev/scsi_id PUx, /usr/{lib,lib64}/xen-common/bin/xen-toolstack PUx, /usr/{lib,lib64}/xen/bin/* Ux, - /usr/lib/xen-*/bin/libxl-save-helper PUx, - /usr/lib/xen-*/bin/pygrub PUx, + /usr/{lib,libexec}/xen-*/bin/libxl-save-helper PUx, + /usr/{lib,libexec}/xen-*/bin/pygrub PUx, /usr/{lib,lib64,lib/qemu,libexec}/vhost-user-gpu PUx, /usr/{lib,lib64,lib/qemu,libexec}/virtiofsd PUx, -- 2.28.0

3 6

[PATCH] RFC: fix error message in virMigrate3 if connection is broken
by Nikolay Shirokovskiy 24 Sep '20

24 Sep '20

Currently virDomainMigrate3 reports "this function is not supported by the connection driver: virDomainMigrate3" if connection to destination for example is broken. This is a bit misleading. This is a result of we treat errors as unsupported feature in VIR_DRV_SUPPORTS_FEATURE macro. So let's handle errors instead. In order to keep logic clean as before there are new helper functions virDrvSupportsFeature/virDrvNSupportsFeature. They allow to keep if/else if structure of feature tests. I guess all the other occurences of VIR_DRV_SUPPORTS_FEATURE need to be replaced with one these new helper functions so that we detect error early and not have issues similar to virDomainMigrate3. I'm going to fix the other places if this RFC is approved. --- src/datatypes.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ src/datatypes.h | 7 +++++ src/libvirt-domain.c | 76 +++++++++++++++++++++++++++++++--------------------- 3 files changed, 123 insertions(+), 30 deletions(-) diff --git a/src/datatypes.c b/src/datatypes.c index 1db38c5..3fb71f4 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -1257,3 +1257,73 @@ virAdmClientDispose(void *obj) virObjectUnref(clt->srv); } + + +/* + * Tests if feature is supported by connection. If testing failed + * due to error then function returns true as well and set @err flag + * to true. Thus positive result should be checked for an error. + * If @err is already set to true then no checking is done and + * the function returns true immediately so that previous error + * is not overwritten. + * + * Returns: + * true feature is supported or testing hit error + * false feature is not supported + */ +bool +virDrvSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err) +{ + int rc; + + if (*err) + return true; + + if (!conn->driver->connectSupportsFeature) + return false; + + if ((rc = conn->driver->connectSupportsFeature(conn, feature)) < 0) { + *err = true; + return true; + } + + return rc > 0 ? true : false; +} + + +/* + * Tests if feature is NOT supported by connection. If testing failed + * due to error then function returns true as well and set @err flag + * to true. Thus positive result should be checked for an error. + * If @err is already set to true then no checking is done and + * the function returns true immediately so that previous error + * is not overwritten. + * + * Note that this function is not merge negation of virDrvSupportsFeature. + * + * Returns: + * true feature is not supported or testing hit error + * false feature is supported + */ +bool +virDrvNSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err) +{ + int rc; + + if (*err) + return true; + + if (!conn->driver->connectSupportsFeature) + return true; + + if ((rc = conn->driver->connectSupportsFeature(conn, feature)) < 0) { + *err = true; + return true; + } + + return rc > 0 ? false : true; +} diff --git a/src/datatypes.h b/src/datatypes.h index ade3779..e468d92 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -871,3 +871,10 @@ int virAdmConnectCloseCallbackDataRegister(virAdmConnectCloseCallbackDataPtr cbd virFreeCallback freecb); int virAdmConnectCloseCallbackDataUnregister(virAdmConnectCloseCallbackDataPtr cbdata, virAdmConnectCloseFunc cb); + +bool virDrvSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err); +bool virDrvNSupportsFeature(virConnectPtr conn, + virDrvFeature feature, + bool *err); diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index cde86c7..f4f626a 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3846,6 +3846,7 @@ virDomainMigrate3(virDomainPtr domain, const char *dname = NULL; const char *dxml = NULL; unsigned long long bandwidth = 0; + bool err = false; VIR_DOMAIN_DEBUG(domain, "dconn=%p, params=%p, nparms=%u flags=0x%x", dconn, params, nparams, flags); @@ -3878,18 +3879,20 @@ virDomainMigrate3(virDomainPtr domain, } if (flags & VIR_MIGRATE_OFFLINE) { - if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("offline migration is not supported by " - "the source host")); + if (virDrvNSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_OFFLINE, &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("offline migration is not supported by " + "the source host")); goto error; } - if (!VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("offline migration is not supported by " - "the destination host")); + if (virDrvNSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_OFFLINE, &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("offline migration is not supported by " + "the destination host")); goto error; } } @@ -3900,20 +3903,25 @@ virDomainMigrate3(virDomainPtr domain, * migration from newer source to an older destination that * rejects the flag. */ if (flags & VIR_MIGRATE_CHANGE_PROTECTION && - !VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION)) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("cannot enforce change protection")); + virDrvNSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATE_CHANGE_PROTECTION, + &err)) { + if (!err) + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("cannot enforce change protection")); goto error; } flags &= ~VIR_MIGRATE_CHANGE_PROTECTION; /* Prefer extensible API but fall back to older migration APIs if params * only contains parameters which were supported by the older API. */ - if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_PARAMS) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_PARAMS)) { + if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_PARAMS, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_PARAMS, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 3 with extensible parameters"); ddomain = virDomainMigrateVersion3Params(domain, dconn, params, nparams, flags); @@ -3939,17 +3947,22 @@ virDomainMigrate3(virDomainPtr domain, goto error; } - if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V3) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V3)) { + if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V3, &err) && + virDrvSupportsFeature(dconn, VIR_DRV_FEATURE_MIGRATION_V3, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 3"); ddomain = virDomainMigrateVersion3(domain, dconn, dxml, flags, dname, uri, bandwidth); - } else if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V2) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V2)) { + } else if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V2, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_V2, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 2"); if (dxml) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -3959,10 +3972,13 @@ virDomainMigrate3(virDomainPtr domain, } ddomain = virDomainMigrateVersion2(domain, dconn, flags, dname, uri, bandwidth); - } else if (VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, - VIR_DRV_FEATURE_MIGRATION_V1) && - VIR_DRV_SUPPORTS_FEATURE(dconn->driver, dconn, - VIR_DRV_FEATURE_MIGRATION_V1)) { + } else if (virDrvSupportsFeature(domain->conn, + VIR_DRV_FEATURE_MIGRATION_V1, &err) && + virDrvSupportsFeature(dconn, + VIR_DRV_FEATURE_MIGRATION_V1, &err)) { + if (err) + goto error; + VIR_DEBUG("Using migration protocol 1"); if (dxml) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", -- 1.8.3.1

2 2

[PATCH] libxl: use b_info->{acpi,acpi} when available
by Marek Marczykowski-Górecki 24 Sep '20

24 Sep '20

b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl version (4.14) the old one seems to be broken. While libxl part should be fixed too, update the usage here and at some point drop support for the old version. b_info->acpi was added in Xen 4.8 b_info->apic was added in Xen 4.10 Xen 4.10 is the oldest version that still has security support (until December 2020). Signed-off-by: Marek Marczykowski-Górecki <marmarek(a)invisiblethingslab.com> --- src/libxl/libxl_conf.c | 13 +++++++++++++ tests/libxlxml2domconfigdata/basic-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/cpu-shares-hvm.json | 4 ++-- .../libxlxml2domconfigdata/fullvirt-acpi-slic.json | 4 ++-- .../fullvirt-cpuid-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/fullvirt-cpuid.json | 4 ++-- .../max-eventchannels-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/max-gntframes-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/moredevs-hvm.json | 4 ++-- .../libxlxml2domconfigdata/variable-clock-hvm.json | 4 ++-- .../vnuma-hvm-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/vnuma-hvm.json | 4 ++-- 12 files changed, 35 insertions(+), 22 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index befd5eb965..5b729a019a 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -508,12 +508,25 @@ libxlMakeDomBuildInfo(virDomainDefPtr def, libxl_defbool_set(&b_info->u.hvm.pae, def->features[VIR_DOMAIN_FEATURE_PAE] == VIR_TRISTATE_SWITCH_ON); +#ifdef LIBXL_HAVE_BUILDINFO_APIC + libxl_defbool_set(&b_info->apic, + def->features[VIR_DOMAIN_FEATURE_APIC] == + VIR_TRISTATE_SWITCH_ON); + /* + * Strictly speaking b_info->acpi was introduced earlier (Xen 4.8), but + * there is no separate #define in libxl.h. + */ + libxl_defbool_set(&b_info->acpi, + def->features[VIR_DOMAIN_FEATURE_ACPI] == + VIR_TRISTATE_SWITCH_ON); +#else libxl_defbool_set(&b_info->u.hvm.apic, def->features[VIR_DOMAIN_FEATURE_APIC] == VIR_TRISTATE_SWITCH_ON); libxl_defbool_set(&b_info->u.hvm.acpi, def->features[VIR_DOMAIN_FEATURE_ACPI] == VIR_TRISTATE_SWITCH_ON); +#endif /* copy SLIC table path to acpi_firmware */ if (def->os.slic_table) diff --git a/tests/libxlxml2domconfigdata/basic-hvm.json b/tests/libxlxml2domconfigdata/basic-hvm.json index ccd5853854..87f8cb7d8a 100644 --- a/tests/libxlxml2domconfigdata/basic-hvm.json +++ b/tests/libxlxml2domconfigdata/basic-hvm.json @@ -21,10 +21,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/cpu-shares-hvm.json b/tests/libxlxml2domconfigdata/cpu-shares-hvm.json index 2e647eada2..2aa97e88c5 100644 --- a/tests/libxlxml2domconfigdata/cpu-shares-hvm.json +++ b/tests/libxlxml2domconfigdata/cpu-shares-hvm.json @@ -21,10 +21,10 @@ "sched_params": { "weight": 1500 }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json index f16b4a971a..a2d46797aa 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json +++ b/tests/libxlxml2domconfigdata/fullvirt-acpi-slic.json @@ -14,10 +14,10 @@ "shadow_memkb": 5656, "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "acpi_firmware": "/path/to/slic.dat", "nographic": "True", "vga": { diff --git a/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json b/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json index 0944476151..6290655c20 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json +++ b/tests/libxlxml2domconfigdata/fullvirt-cpuid-legacy-nest.json @@ -21,10 +21,10 @@ ], "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nested_hvm": "False", "nographic": "True", "vga": { diff --git a/tests/libxlxml2domconfigdata/fullvirt-cpuid.json b/tests/libxlxml2domconfigdata/fullvirt-cpuid.json index ddc423bca7..811a4f0ac7 100644 --- a/tests/libxlxml2domconfigdata/fullvirt-cpuid.json +++ b/tests/libxlxml2domconfigdata/fullvirt-cpuid.json @@ -22,10 +22,10 @@ "sched_params": { }, "nested_hvm": "False", + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nographic": "True", "vga": { "kind": "none" diff --git a/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json b/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json index d5b351beb5..4a5b0ca65f 100644 --- a/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json +++ b/tests/libxlxml2domconfigdata/max-eventchannels-hvm.json @@ -22,10 +22,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/max-gntframes-hvm.json b/tests/libxlxml2domconfigdata/max-gntframes-hvm.json index ef602f09fc..2883d057ff 100644 --- a/tests/libxlxml2domconfigdata/max-gntframes-hvm.json +++ b/tests/libxlxml2domconfigdata/max-gntframes-hvm.json @@ -22,10 +22,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/moredevs-hvm.json b/tests/libxlxml2domconfigdata/moredevs-hvm.json index 474aa2cef6..58cf32a8d4 100644 --- a/tests/libxlxml2domconfigdata/moredevs-hvm.json +++ b/tests/libxlxml2domconfigdata/moredevs-hvm.json @@ -23,10 +23,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "hpet": "True", "vga": { "kind": "cirrus" diff --git a/tests/libxlxml2domconfigdata/variable-clock-hvm.json b/tests/libxlxml2domconfigdata/variable-clock-hvm.json index 69be9c64cb..9a25d51da2 100644 --- a/tests/libxlxml2domconfigdata/variable-clock-hvm.json +++ b/tests/libxlxml2domconfigdata/variable-clock-hvm.json @@ -23,10 +23,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json b/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json index 3b2fc5f40f..6cda8d0252 100644 --- a/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json +++ b/tests/libxlxml2domconfigdata/vnuma-hvm-legacy-nest.json @@ -109,10 +109,10 @@ "sched_params": { }, + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "nested_hvm": "True", "vga": { "kind": "cirrus" diff --git a/tests/libxlxml2domconfigdata/vnuma-hvm.json b/tests/libxlxml2domconfigdata/vnuma-hvm.json index 02c10a9deb..f578ccd3d3 100644 --- a/tests/libxlxml2domconfigdata/vnuma-hvm.json +++ b/tests/libxlxml2domconfigdata/vnuma-hvm.json @@ -110,10 +110,10 @@ }, "nested_hvm": "True", + "apic": "True", + "acpi": "True", "type.hvm": { "pae": "True", - "apic": "True", - "acpi": "True", "vga": { "kind": "cirrus" }, -- 2.25.4

5 10

Help on meson build
by Wei Wang 24 Sep '20

24 Sep '20

Hi folks, I'm trying to build libvirt using meson with the latest upstream libvirt, but the compilation fails: (followed on https://libvirt.org/compiling.html, not sure if any dependencies are missed) FAILED: src/util/libvirt_util.a.p/glibcompat.c.o .... In file included from ../src/util/glibcompat.c:19: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/virfirmware.c.o In file included from ../src/util/virarch.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory FAILED: src/util/libvirt_util.a.p/viraudit.c.o In file included from ../src/util/viraudit.c:22: ./config.h:1026:10: fatal error: config-post.h: No such file or directory Any help is appreciated. Thanks, Wei

1 0

[PATCH v2 0/6] qemu: Use memory-backend-* for regular guest memory
by Michal Privoznik 23 Sep '20

23 Sep '20

v2 of: https://www.redhat.com/archives/libvir-list/2020-September/msg00023.html diff to v1: - I've dropped the capability (patch 5/7 in the original set) and am relying on qemu providing default-ram-id. I've tested migration from a daemon with these patches to a daemon without and also vice versa and it worked. Michal Prívozník (6): qemuBuildMemoryBackendProps: Move @prealloc setting to backend agnostic part qemuBuildMemoryBackendProps: Respect //memoryBacking/allocation/@mode=immediate qemuBuildMemoryBackendProps: Prealloc mem for memfd backend qemuBuildMemoryBackendProps: Fix const correctness qemu: Track default-ram-id machine attribute qemu: Use memory-backend-* for regular guest memory src/qemu/qemu_capabilities.c | 35 +++- src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_capspriv.h | 3 +- src/qemu/qemu_command.c | 96 +++++++-- src/qemu/qemu_command.h | 4 +- src/qemu/qemu_monitor.c | 1 + src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 11 + .../caps_5.2.0.x86_64.xml | 196 +++++++++--------- .../blkdeviotune-group-num.x86_64-latest.args | 3 +- ...blkdeviotune-max-length.x86_64-latest.args | 3 +- .../blkdeviotune-max.x86_64-latest.args | 3 +- .../channel-unix-guestfwd.x86_64-latest.args | 3 +- .../console-virtio-unix.x86_64-latest.args | 3 +- .../controller-virtio-scsi.x86_64-latest.args | 3 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 3 +- .../cpu-translation.x86_64-latest.args | 3 +- .../cputune-cpuset-big-id.x86_64-latest.args | 3 +- .../disk-aio-io_uring.x86_64-latest.args | 3 +- .../disk-aio.x86_64-latest.args | 3 +- ...-backing-chains-noindex.x86_64-latest.args | 3 +- .../disk-cache.x86_64-latest.args | 4 +- .../disk-cdrom-bus-other.x86_64-latest.args | 3 +- ...m-empty-network-invalid.x86_64-latest.args | 3 +- .../disk-cdrom-network.x86_64-latest.args | 3 +- .../disk-cdrom-tray.x86_64-latest.args | 3 +- .../disk-cdrom.x86_64-latest.args | 3 +- .../disk-copy_on_read.x86_64-latest.args | 3 +- .../disk-detect-zeroes.x86_64-latest.args | 3 +- .../disk-discard.x86_64-latest.args | 3 +- .../disk-error-policy.x86_64-latest.args | 3 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 4 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 4 +- .../disk-floppy.x86_64-latest.args | 3 +- .../disk-network-gluster.x86_64-latest.args | 3 +- .../disk-network-http.x86_64-latest.args | 3 +- .../disk-network-iscsi.x86_64-latest.args | 3 +- .../disk-network-nbd.x86_64-latest.args | 3 +- .../disk-network-rbd.x86_64-latest.args | 3 +- .../disk-network-sheepdog.x86_64-latest.args | 3 +- ...isk-network-source-auth.x86_64-latest.args | 3 +- ...isk-network-tlsx509-nbd.x86_64-latest.args | 3 +- .../disk-nvme.x86_64-latest.args | 3 +- .../disk-readonly-disk.x86_64-latest.args | 3 +- .../disk-scsi-device-auto.x86_64-latest.args | 3 +- .../disk-scsi.x86_64-latest.args | 3 +- .../disk-shared.x86_64-latest.args | 3 +- .../disk-slices.x86_64-latest.args | 3 +- ...irtio-scsi-reservations.x86_64-latest.args | 3 +- .../eoi-disabled.x86_64-latest.args | 3 +- .../eoi-enabled.x86_64-latest.args | 3 +- .../floppy-drive-fat.x86_64-latest.args | 3 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 3 +- .../genid-auto.x86_64-latest.args | 3 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 3 +- ...egl-headless-rendernode.x86_64-latest.args | 3 +- .../graphics-egl-headless.x86_64-latest.args | 3 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 3 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 3 +- .../graphics-vnc-tls.x86_64-latest.args | 3 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 3 +- ...play-spice-egl-headless.x86_64-latest.args | 3 +- ...ev-display-spice-opengl.x86_64-latest.args | 3 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 3 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 3 +- .../hostdev-scsi-lsi.x86_64-latest.args | 3 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 3 +- .../qemuxml2argvdata/hugepages-memaccess.args | 30 +-- .../hugepages-memaccess2.args | 12 +- .../hugepages-numa-nodeset-part.args | 5 +- .../hugepages-numa-nodeset.args | 20 +- .../hugepages-nvdimm.x86_64-latest.args | 15 +- tests/qemuxml2argvdata/hugepages-shared.args | 24 +-- .../hyperv-off.x86_64-latest.args | 3 +- .../hyperv-panic.x86_64-latest.args | 3 +- .../hyperv-stimer-direct.x86_64-latest.args | 3 +- .../hyperv.x86_64-latest.args | 3 +- .../intel-iommu-aw-bits.x86_64-latest.args | 4 +- ...ntel-iommu-caching-mode.x86_64-latest.args | 4 +- ...ntel-iommu-device-iotlb.x86_64-latest.args | 4 +- .../intel-iommu-eim.x86_64-latest.args | 4 +- .../intel-iommu.x86_64-latest.args | 3 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 3 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 3 +- ...luks-disks-source-qcow2.x86_64-latest.args | 4 +- ...memory-default-hugepage.x86_64-latest.args | 8 +- .../memfd-memory-numa.x86_64-latest.args | 8 +- .../memory-hotplug-dimm-addr.args | 6 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 6 +- ...y-hotplug-nvdimm-access.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 8 +- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 8 +- ...ory-hotplug-nvdimm-ppc64.ppc64-latest.args | 2 +- ...hotplug-nvdimm-readonly.x86_64-latest.args | 8 +- .../memory-hotplug-nvdimm.x86_64-latest.args | 6 +- .../mlock-off.x86_64-latest.args | 3 +- .../mlock-on.x86_64-latest.args | 3 +- .../net-vhostuser.x86_64-latest.args | 3 +- .../numatune-hmat.x86_64-latest.args | 4 +- .../os-firmware-bios.x86_64-latest.args | 4 +- ...os-firmware-efi-secboot.x86_64-latest.args | 4 +- .../os-firmware-efi.x86_64-latest.args | 4 +- .../qemuxml2argvdata/pages-dimm-discard.args | 4 +- .../parallel-unix-chardev.x86_64-latest.args | 3 +- ...cie-root-port-nohotplug.x86_64-latest.args | 3 +- .../pv-spinlock-disabled.x86_64-latest.args | 3 +- .../pv-spinlock-enabled.x86_64-latest.args | 3 +- .../qemu-ns.x86_64-latest.args | 3 +- .../serial-unix-chardev.x86_64-latest.args | 3 +- ...rtcard-passthrough-unix.x86_64-latest.args | 3 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 4 +- .../tpm-emulator-tpm2.x86_64-latest.args | 4 +- .../tpm-emulator.x86_64-latest.args | 4 +- .../tpm-passthrough-crb.x86_64-latest.args | 4 +- .../tpm-passthrough.x86_64-latest.args | 4 +- .../tseg-explicit-size.x86_64-latest.args | 4 +- .../usb-redir-unix.x86_64-latest.args | 3 +- tests/qemuxml2argvdata/user-aliases.args | 16 +- ...vhost-user-fs-fd-memory.x86_64-latest.args | 4 +- ...vhost-user-fs-hugepages.x86_64-latest.args | 10 +- ...host-user-gpu-secondary.x86_64-latest.args | 3 +- .../vhost-user-vga.x86_64-latest.args | 3 +- .../vhost-vsock-auto.x86_64-latest.args | 4 +- .../vhost-vsock.x86_64-latest.args | 3 +- ...eo-bochs-display-device.x86_64-latest.args | 3 +- ...video-qxl-device-vram64.x86_64-latest.args | 3 +- ...o-qxl-sec-device-vram64.x86_64-latest.args | 3 +- ...eo-ramfb-display-device.x86_64-latest.args | 3 +- .../virtio-9p-multidevs.x86_64-latest.args | 3 +- ...virtio-non-transitional.x86_64-latest.args | 3 +- ...-options-controller-ats.x86_64-latest.args | 3 +- ...ptions-controller-iommu.x86_64-latest.args | 3 +- ...tions-controller-packed.x86_64-latest.args | 3 +- ...virtio-options-disk-ats.x86_64-latest.args | 3 +- ...rtio-options-disk-iommu.x86_64-latest.args | 3 +- ...tio-options-disk-packed.x86_64-latest.args | 3 +- .../virtio-options-fs-ats.x86_64-latest.args | 3 +- ...virtio-options-fs-iommu.x86_64-latest.args | 3 +- ...irtio-options-fs-packed.x86_64-latest.args | 3 +- ...irtio-options-input-ats.x86_64-latest.args | 3 +- ...tio-options-input-iommu.x86_64-latest.args | 3 +- ...io-options-input-packed.x86_64-latest.args | 3 +- ...-options-memballoon-ats.x86_64-latest.args | 3 +- ...ptions-memballoon-iommu.x86_64-latest.args | 3 +- ...tions-memballoon-packed.x86_64-latest.args | 3 +- .../virtio-options-net-ats.x86_64-latest.args | 3 +- ...irtio-options-net-iommu.x86_64-latest.args | 3 +- ...rtio-options-net-packed.x86_64-latest.args | 3 +- .../virtio-options-rng-ats.x86_64-latest.args | 3 +- ...irtio-options-rng-iommu.x86_64-latest.args | 3 +- ...rtio-options-rng-packed.x86_64-latest.args | 3 +- ...irtio-options-video-ats.x86_64-latest.args | 3 +- ...tio-options-video-iommu.x86_64-latest.args | 3 +- ...io-options-video-packed.x86_64-latest.args | 3 +- .../virtio-options.x86_64-latest.args | 3 +- .../virtio-rng-builtin.x86_64-latest.args | 3 +- .../virtio-rng-egd-unix.x86_64-latest.args | 3 +- .../virtio-transitional.x86_64-latest.args | 3 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 4 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 4 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 4 +- .../x86_64-pc-graphics.x86_64-latest.args | 3 +- .../x86_64-pc-headless.x86_64-latest.args | 3 +- .../x86_64-q35-graphics.x86_64-latest.args | 3 +- .../x86_64-q35-headless.x86_64-latest.args | 3 +- tests/testutilsqemu.c | 24 ++- 168 files changed, 667 insertions(+), 357 deletions(-) -- 2.26.2

2 7

[PATCH v1] qemu: monitor: substitute missing model name for host-passthrough
by Collin Walling 23 Sep '20

23 Sep '20

When executing the hypervisor-cpu-compare/baseline commands and the XML file contains a CPU definition using host-passthrough and no model name, the commands will fail and return an error message from the QMP response. Let's fix this by checking for host-passthrough and a missing model name when converting a CPU definition to a JSON object. If these conditions are matched, then the JSON object will be constructed using "host" as the model name. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1850680 Signed-off-by: Collin Walling <walling(a)linux.ibm.com> --- src/qemu/qemu_monitor_json.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3070c1e6b3..448a3a9356 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -5804,9 +5804,20 @@ qemuMonitorJSONMakeCPUModel(virCPUDefPtr cpu, { virJSONValuePtr model = virJSONValueNewObject(); virJSONValuePtr props = NULL; + const char *model_name = cpu->model; size_t i; - if (virJSONValueObjectAppendString(model, "name", cpu->model) < 0) + if (!model_name) { + if (cpu->mode == VIR_CPU_MODE_HOST_PASSTHROUGH) { + model_name = "host"; + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("cpu parameter is missing a model name")); + goto error; + } + } + + if (virJSONValueObjectAppendString(model, "name", model_name) < 0) goto error; if (cpu->nfeatures || !migratable) { -- 2.26.2

4 8

[PATCH] xen: Don't add dom0 twice on driver reload
by Jim Fehlig 23 Sep '20

23 Sep '20

When the xen driver loads, it probes libxl for some info about dom0 and adds it to the virDomainObjList. The driver then looks for any domains in stateDir and if they are still alive adds them to the list as well. This logic is a bit flawed wrt handling driver reload and causes the following error internal error: unexpected domain Domain-0 already exists A simple fix is to load all domains from stateDir first and then only add dom0 if needed. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- src/libxl/libxl_driver.c | 46 +++++++++++++++++++++++----------------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 161a6882f3..083738871d 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -604,27 +604,33 @@ libxlAddDom0(libxlDriverPrivatePtr driver) goto cleanup; } - if (!(def = virDomainDefNew())) - goto cleanup; + /* + * On a driver reload dom0 will already exist. On host restart it must + * created. + */ + if ((vm = virDomainObjListFindByID(driver->domains, 0)) == NULL) { + if (!(def = virDomainDefNew())) + goto cleanup; - def->id = 0; - def->virtType = VIR_DOMAIN_VIRT_XEN; - def->name = g_strdup("Domain-0"); + def->id = 0; + def->virtType = VIR_DOMAIN_VIRT_XEN; + def->name = g_strdup("Domain-0"); - def->os.type = VIR_DOMAIN_OSTYPE_XEN; + def->os.type = VIR_DOMAIN_OSTYPE_XEN; - if (virUUIDParse("00000000-0000-0000-0000-000000000000", def->uuid) < 0) - goto cleanup; + if (virUUIDParse("00000000-0000-0000-0000-000000000000", def->uuid) < 0) + goto cleanup; - if (!(vm = virDomainObjListAdd(driver->domains, def, - driver->xmlopt, - 0, - NULL))) - goto cleanup; - def = NULL; + if (!(vm = virDomainObjListAdd(driver->domains, def, + driver->xmlopt, + 0, + NULL))) + goto cleanup; + + vm->persistent = 1; + virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); + } - vm->persistent = 1; - virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, VIR_DOMAIN_RUNNING_BOOTED); if (virDomainDefSetVcpusMax(vm->def, d_info.vcpu_max_id + 1, driver->xmlopt)) goto cleanup; @@ -783,10 +789,6 @@ libxlStateInitialize(bool privileged, if (!(libxl_driver->xmlopt = libxlCreateXMLConf(libxl_driver))) goto error; - /* Add Domain-0 */ - if (libxlAddDom0(libxl_driver) < 0) - goto error; - /* Load running domains first. */ if (virDomainObjListLoadAllConfigs(libxl_driver->domains, cfg->stateDir, @@ -796,6 +798,10 @@ libxlStateInitialize(bool privileged, NULL, NULL) < 0) goto error; + /* Add Domain-0 */ + if (libxlAddDom0(libxl_driver) < 0) + goto error; + libxlReconnectDomains(libxl_driver); /* Then inactive persistent configs */ -- 2.28.0

2 1

[PATCH 00/13] virStorageSourceNew failure handling and virDomainSnapshotAlignDisks refactors
by Peter Krempa 23 Sep '20

23 Sep '20

A set of patches that prevent failures from virStorageSourceNew and refactor virDomainSnapshotAlignDisks for better readability. Peter Krempa (13): virStorageSourceNew: Abort on failure virStorageVolDefParseXML: Use g_steal_pointer qemuDomainBlockRebase: Replace ternary operator with if/else qemuSnapshotCreateInactiveExternal: Don't access 'idx' of snapshot virDomainSnapshotAlignDisks: Refactor cleanup virDomainSnapshotAlignDisks: Rename 'def' -> 'snapdef' virDomainSnapshotAlignDisks: Rename 'disk' -> 'snapdisk' virDomainSnapshotAlignDisks: Add 'domdef' local variable virDomainSnapshotAlignDisks: Extract domain disk definition to a local variable virDomainSnapshotAlignDisks: remove unnecessary 'tmp' variable virDomainSnapshotAlignDisks: clarify handing of snapshot location virDomainSnapshotAlignDisks: refactor extension to all disks virDomainSnapshotDiskDef: Remove 'idx' field src/conf/backup_conf.c | 7 +- src/conf/domain_conf.c | 21 ++-- src/conf/snapshot_conf.c | 160 +++++++++++--------------- src/conf/snapshot_conf.h | 1 - src/conf/storage_conf.c | 8 +- src/qemu/qemu_domain.c | 21 ++-- src/qemu/qemu_driver.c | 18 ++- src/qemu/qemu_migration.c | 7 +- src/qemu/qemu_snapshot.c | 7 +- src/storage/storage_backend_gluster.c | 5 +- src/storage/storage_backend_logical.c | 4 +- src/storage/storage_util.c | 10 +- src/util/virstoragefile.c | 32 ++---- tests/qemublocktest.c | 16 +-- tests/virstoragetest.c | 5 +- 15 files changed, 121 insertions(+), 201 deletions(-) -- 2.26.2

3 28

[libvirt PATCHv3] tests: build SELinux tests (glib chronicles?)
by Ján Tomko 23 Sep '20

23 Sep '20

We set WITH_LIBATTR in meson.build, not WITH_ATTR. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: 3ace72965c3b11fc763f781ae7ce3ca29dd36507 --- tests/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/meson.build b/tests/meson.build index 31e8d66c7a..cb720f3afe 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -477,7 +477,7 @@ if conf.has('WITH_REMOTE') endif if conf.has('WITH_SECDRIVER_SELINUX') - if conf.has('WITH_ATTR') + if conf.has('WITH_LIBATTR') tests += [ { 'name': 'securityselinuxtest' }, { 'name': 'viridentitytest' }, @@ -485,7 +485,7 @@ if conf.has('WITH_SECDRIVER_SELINUX') if conf.has('WITH_QEMU') tests += [ - { 'name': 'securityselinuxlabeltest', 'link_whole': [ test_utils_qemu_lib ] }, + { 'name': 'securityselinuxlabeltest', 'link_with': [ test_qemu_driver_lib ], 'link_whole': [ test_utils_qemu_lib ] }, ] endif endif -- 2.26.2

2 1

[libvirt PATCH] util: do not unref event thread after joining it
by Ján Tomko 23 Sep '20

23 Sep '20

==295055== Invalid read of size 4 ==295055== at 0x4DA4AE4: g_thread_unref (in /usr/lib64/libglib-2.0.so.0.6400.5) ==295055== by 0x491D5FA: vir_event_thread_finalize (vireventthread.c:47) ==295055== by 0x4E6BCFF: g_object_unref (in /usr/lib64/libgobject-2.0.so.0.6400.5) ==295055== by 0x22F35CF4: qemuProcessQMPFree (qemu_process.c:8525) ==295055== by 0x22E71B58: glib_autoptr_clear_qemuProcessQMP (qemu_process.h:237) ... ==295055== by 0x22E98A29: qemuDomainPostParseDataAlloc (qemu_domain.c:5476) ==295055== by 0x49ABF83: virDomainDefPostParse (domain_conf.c:6023) ==295055== Address 0x2acb1c68 is 24 bytes inside a block of size 88 free'd ==295055== at 0x483B9F5: free (vg_replace_malloc.c:538) ==295055== by 0x4D80A4C: g_free (in /usr/lib64/libglib-2.0.so.0.6400.5) ... ==295055== by 0x491D5F1: vir_event_thread_finalize (vireventthread.c:46) ==295055== by 0x4E6BCFF: g_object_unref (in /usr/lib64/libgobject-2.0.so.0.6400.5) ==295055== by 0x22F35CF4: qemuProcessQMPFree (qemu_process.c:8525) ==295055== by 0x22E71B58: glib_autoptr_clear_qemuProcessQMP (qemu_process.h:237) ... ==295055== Block was alloc'd at ==295055== at 0x483A809: malloc (vg_replace_malloc.c:307) ==295055== by 0x4D80958: g_malloc (in /usr/lib64/libglib-2.0.so.0.6400.5) ... ==295055== by 0x4DA4C32: g_thread_try_new (in /usr/lib64/libglib-2.0.so.0.6400.5) ==295055== by 0x491D3BC: virEventThreadStart (vireventthread.c:159) ==295055== by 0x491D3BC: virEventThreadNew (vireventthread.c:185) ... Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: f4fc3db9204407874181117085756c9ced78adad --- src/util/vireventthread.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/vireventthread.c b/src/util/vireventthread.c index 1bca2aa57a..8342f420f6 100644 --- a/src/util/vireventthread.c +++ b/src/util/vireventthread.c @@ -44,7 +44,6 @@ vir_event_thread_finalize(GObject *object) if (evt->thread) { g_main_loop_quit(evt->loop); g_thread_join(evt->thread); - g_thread_unref(evt->thread); } g_main_loop_unref(evt->loop); -- 2.26.2

2 1

[libvirt PATCH] virnetdaemon: fix memory leak in virNetDaemonCallInhibit
by Pavel Hrdina 23 Sep '20

23 Sep '20

g_variant_new() returns a weak reference which can be consumed by passing to other g_variant* functions or to g_dbus_connection_call* functions. This make it possible to call g_variant_new() directly as argument to the functions above. Because this might be confusing I explicitly call g_variant_ref_sink() to make it normal reference in both virGDBusCallMethod() and virGDBusCallMethodWithFD() so the caller is always responsible for the data. Reported-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/rpc/virnetdaemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index f3a5e9f75c..2e01244f74 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -469,7 +469,7 @@ virNetDaemonCallInhibit(virNetDaemonPtr dmn, { g_autoptr(GVariant) reply = NULL; g_autoptr(GUnixFDList) replyFD = NULL; - GVariant *message = NULL; + g_autoptr(GVariant) message = NULL; GDBusConnection *systemBus; int fd; int rc; -- 2.26.2

3 2

[libvirt PATCH] util/virgdbus: fix memory leak in virGDBusIsServiceInList
by Pavel Hrdina 23 Sep '20

23 Sep '20

g_variant_iter_loop() handles freeing all arguments unless we break out of the loop, in that case we have to free them manually. Reported-by: Peter Krempa <pkrempa(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virgdbus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index cd9ca8d5d6..4360a6acff 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -359,8 +359,10 @@ virGDBusIsServiceInList(const char *listMethod, g_variant_get(reply, "(as)", &iter); while (g_variant_iter_loop(iter, "s", &str)) { - if (STREQ(str, name)) + if (STREQ(str, name)) { + g_free(str); return 0; + } } return -2; -- 2.26.2

2 1

[libvirt PATCHv2 0/2] tests: switch to g_new0 (glib chronicles)
by Ján Tomko 23 Sep '20

23 Sep '20

2 4

[PATCH v2 0/2] block: deprecate the sheepdog driver
by Daniel P. Berrangé 23 Sep '20

23 Sep '20

2 years back I proposed dropping the sheepdog mailing list from the MAINTAINERS file, but somehow the patch never got picked up: https://lists.gnu.org/archive/html/qemu-block/2018-03/msg01048.html So here I am with the same patch again. This time I go further and deprecate the sheepdog driver entirely. See the rationale in the second patch commit message. Daniel P. Berrangé (2): block: drop moderated sheepdog mailing list from MAINTAINERS file block: deprecate the sheepdog block driver MAINTAINERS | 1 - block/sheepdog.c | 15 +++++++++++++++ configure | 5 +++-- docs/system/deprecated.rst | 9 +++++++++ 4 files changed, 27 insertions(+), 3 deletions(-) -- 2.26.2

8 14

[PATCH] docs: manpages: Strip table of contents from manpages
by Peter Krempa 23 Sep '20

23 Sep '20

After meson conversion the man pages started to contain the table of contents. In autoconf we prevented this by a 'grep -v ::contents' in the command building the manpages. A more cultured solution is to strip out the 'contents' docutils element directly. Reported-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/meson.build b/docs/manpages/meson.build index 3888bb8efe..7ed1d304a4 100644 --- a/docs/manpages/meson.build +++ b/docs/manpages/meson.build @@ -89,7 +89,8 @@ foreach data : docs_man_files man_file, input: rst_file, output: man_file, - command: [ rst2man_prog, '--strict', '@INPUT@', '@OUTPUT@' ], + # 'contents' element is the table of contents which is undesired in manpage + command: [ rst2man_prog, '--strip-elements-with-class', 'contents', '--strict', '@INPUT@', '@OUTPUT@' ], install: true, install_dir: mandir / 'man@0@'.format(data['section']), ) -- 2.26.2

4 3

[libvirt PATCH 0/4] tests: switch to g_new0 (glib chronicles)
by Ján Tomko 23 Sep '20

23 Sep '20

With the exception of viralloctest. Ján Tomko (4): tests: virNumaGetPages: use g_new0 instead of VIR_ALLOC_N tests: cpuTestLoadMultiXML: use g_new0 instead of VIR_ALLOC_N tests: use g_new0 instead of VIR_ALLOC_N tests: use g_new0 instead of VIR_ALLOC tests/commandtest.c | 7 +++---- tests/cputest.c | 4 +++- tests/domaincapstest.c | 10 ++++------ tests/fdstreamtest.c | 10 ++++------ tests/nodedevmdevctltest.c | 16 +++++----------- tests/nwfilterxml2firewalltest.c | 3 +-- tests/qemublocktest.c | 9 +++------ tests/qemuhotplugtest.c | 3 +-- tests/qemumonitorjsontest.c | 12 ++++-------- tests/qemumonitortestutils.c | 22 ++++++---------------- tests/qemusecuritymock.c | 3 +-- tests/qemuxml2argvtest.c | 3 +-- tests/securityselinuxhelper.c | 3 +-- tests/securityselinuxlabeltest.c | 3 +-- tests/securityselinuxtest.c | 6 ++---- tests/testutils.c | 8 ++------ tests/testutilsqemu.c | 6 ++---- tests/vircgrouptest.c | 3 +-- tests/vircryptotest.c | 5 ++--- tests/virhostcputest.c | 3 +-- tests/virhostdevtest.c | 3 +-- tests/virnetdaemontest.c | 3 +-- tests/virnetmessagetest.c | 15 ++++++--------- tests/virnetserverclienttest.c | 3 +-- tests/virnetsockettest.c | 6 +----- tests/virnettlshelpers.c | 3 +-- tests/virnumamock.c | 16 +++------------- tests/virstringtest.c | 8 +++----- tests/xlconfigtest.c | 3 +-- tests/xmconfigtest.c | 3 +-- 30 files changed, 67 insertions(+), 135 deletions(-) -- 2.26.2

2 9

[PATCH v2] docs/system: clarify deprecation schedule
by Stefan Hajnoczi 23 Sep '20

23 Sep '20

The sentence explaining the deprecation schedule is ambiguous. Make it clear that a feature deprecated in the Nth release is guaranteed to remain available in the N+1th release. Removal can occur in the N+2nd release or later. As an example of this in action, see commit 25956af3fe5dd0385ad8017bc768a6afe41e2a74 ("block: Finish deprecation of 'qemu-img convert -n -o'"). The feature was deprecated in QEMU 4.2.0. It was present in the 5.0.0 release and removed in the 5.1.0 release. Suggested-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Stefan Hajnoczi <stefanha(a)redhat.com> --- v2: * Use Dan's suggested wording [Daniel Berrange] --- docs/system/deprecated.rst | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 0cb8b01424..f2d5bd8ce1 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -3,10 +3,11 @@ Deprecated features In general features are intended to be supported indefinitely once introduced into QEMU. In the event that a feature needs to be removed, -it will be listed in this section. The feature will remain functional -for 2 releases prior to actual removal. Deprecated features may also -generate warnings on the console when QEMU starts up, or if activated -via a monitor command, however, this is not a mandatory requirement. +it will be listed in this section. The feature will remain functional for the +release in which it was deprecated and one further release. After these two +releases, the feature is liable to be removed. Deprecated features may also +generate warnings on the console when QEMU starts up, or if activated via a +monitor command, however, this is not a mandatory requirement. Prior to the 2.10.0 release there was no official policy on how long features would be deprecated prior to their removal, nor -- 2.26.2

3 3

[libvirt PATCH] gdbus: fix virGDBusCallMethodWithFD stub for non-UNIX
by Ján Tomko 23 Sep '20

23 Sep '20

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> Fixes: a961d93768f18c28979ca2841832cd7278bf95b8 --- Pushed as a build fix. src/util/virgdbus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index 837c8faf1f..cd9ca8d5d6 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -310,6 +310,7 @@ virGDBusCallMethodWithFD(GDBusConnection *conn, int virGDBusCallMethodWithFD(GDBusConnection *conn G_GNUC_UNUSED, GVariant **reply G_GNUC_UNUSED, + const GVariantType *replyType G_GNUC_UNUSED, GUnixFDList **replyFD G_GNUC_UNUSED, virErrorPtr error G_GNUC_UNUSED, const char *busName G_GNUC_UNUSED, -- 2.26.2

1 0

[libvirt PATCHv2 0/2] esx: fix race when building tests
by Ján Tomko 23 Sep '20

23 Sep '20

v1: https://www.redhat.com/archives/libvir-list/2020-September/msg01196.html Ján Tomko (2): esx: separate header and source file generation tests: esxutilstest: depend on esx_gen_headers scripts/esx_vi_generator.py | 161 ++++++++++++++++++++---------------- src/esx/meson.build | 34 ++++++-- tests/meson.build | 2 +- 3 files changed, 120 insertions(+), 77 deletions(-) -- 2.26.2

2 3

[libvirt PATCH] virgdbus: add DBus reply format check
by Pavel Hrdina 23 Sep '20

23 Sep '20

We used to check the format of reply data with libdbus so we should do the same with GLib DBus as well. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- At first I thought that this is not necessary as it is unlikely to happen but after Jano found the bug with firewalld getZones function and asked about checking return values I figured out that it will be better to check it because if the returned message would have different format it would be silently ignored. src/rpc/virnetdaemon.c | 1 + src/util/virfirewalld.c | 5 +++++ src/util/virgdbus.c | 8 ++++++-- src/util/virgdbus.h | 2 ++ src/util/virpolkit.c | 1 + src/util/virsystemd.c | 7 +++++++ 6 files changed, 22 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetdaemon.c b/src/rpc/virnetdaemon.c index 12d4d9bf87..f3a5e9f75c 100644 --- a/src/rpc/virnetdaemon.c +++ b/src/rpc/virnetdaemon.c @@ -487,6 +487,7 @@ virNetDaemonCallInhibit(virNetDaemonPtr dmn, rc = virGDBusCallMethodWithFD(systemBus, &reply, + G_VARIANT_TYPE("(h)"), &replyFD, NULL, "org.freedesktop.login1", diff --git a/src/util/virfirewalld.c b/src/util/virfirewalld.c index 12448f0681..a94ac7c183 100644 --- a/src/util/virfirewalld.c +++ b/src/util/virfirewalld.c @@ -95,6 +95,7 @@ virFirewallDGetVersion(unsigned long *version) if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(v)"), NULL, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1", @@ -147,6 +148,7 @@ virFirewallDGetBackend(void) if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(v)"), error, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1/config", @@ -207,6 +209,7 @@ virFirewallDGetZones(char ***zones, size_t *nzones) if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(as)"), NULL, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1", @@ -295,6 +298,7 @@ virFirewallDApplyRule(virFirewallLayer layer, if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("(s)"), error, VIR_FIREWALL_FIREWALLD_SERVICE, "/org/fedoraproject/FirewallD1", @@ -357,6 +361,7 @@ virFirewallDInterfaceSetZone(const char *iface, message = g_variant_new("(ss)", zone, iface); return virGDBusCallMethod(sysbus, + NULL, NULL, NULL, VIR_FIREWALL_FIREWALLD_SERVICE, diff --git a/src/util/virgdbus.c b/src/util/virgdbus.c index 535b19f0a4..837c8faf1f 100644 --- a/src/util/virgdbus.c +++ b/src/util/virgdbus.c @@ -181,6 +181,7 @@ virGDBusCloseSystemBus(void) * virGDBusCallMethod: * @conn: a DBus connection * @reply: pointer to receive reply message, or NULL + * @replyType: pointer to GVariantType to validate reply data, or NULL * @error: libvirt error pointer or NULL * @busName: bus identifier of the target service * @objectPath: object path of the target service @@ -198,6 +199,7 @@ virGDBusCloseSystemBus(void) int virGDBusCallMethod(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, virErrorPtr error, const char *busName, const char *objectPath, @@ -220,7 +222,7 @@ virGDBusCallMethod(GDBusConnection *conn, ifaceName, method, data, - NULL, + replyType, G_DBUS_CALL_FLAGS_NONE, VIR_DBUS_METHOD_CALL_TIMEOUT_MILIS, NULL, @@ -250,6 +252,7 @@ virGDBusCallMethod(GDBusConnection *conn, int virGDBusCallMethodWithFD(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, GUnixFDList **replyFD, virErrorPtr error, const char *busName, @@ -274,7 +277,7 @@ virGDBusCallMethodWithFD(GDBusConnection *conn, ifaceName, method, data, - NULL, + replyType, G_DBUS_CALL_FLAGS_NONE, VIR_DBUS_METHOD_CALL_TIMEOUT_MILIS, dataFD, @@ -342,6 +345,7 @@ virGDBusIsServiceInList(const char *listMethod, rc = virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(as)"), NULL, "org.freedesktop.DBus", "/org/freedesktop/DBus", diff --git a/src/util/virgdbus.h b/src/util/virgdbus.h index 6ea717eea2..ca7073e27c 100644 --- a/src/util/virgdbus.h +++ b/src/util/virgdbus.h @@ -45,6 +45,7 @@ virGDBusCloseSystemBus(void); int virGDBusCallMethod(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, virErrorPtr error, const char *busName, const char *objectPath, @@ -55,6 +56,7 @@ virGDBusCallMethod(GDBusConnection *conn, int virGDBusCallMethodWithFD(GDBusConnection *conn, GVariant **reply, + const GVariantType *replyType, GUnixFDList **replyFD, virErrorPtr error, const char *busName, diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index 2ad00fd206..aad924a065 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -104,6 +104,7 @@ int virPolkitCheckAuth(const char *actionid, if (virGDBusCallMethod(sysbus, &reply, + G_VARIANT_TYPE("((bba{ss}))"), NULL, "org.freedesktop.PolicyKit1", "/org/freedesktop/PolicyKit1/Authority", diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 32c830c002..8456085476 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -214,6 +214,7 @@ virSystemdGetMachineNameByPID(pid_t pid) if (virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(o)"), NULL, "org.freedesktop.machine1", "/org/freedesktop/machine1", @@ -236,6 +237,7 @@ virSystemdGetMachineNameByPID(pid_t pid) if (virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(v)"), NULL, "org.freedesktop.machine1", object, @@ -384,6 +386,7 @@ int virSystemdCreateMachine(const char *name, gprops); rc = virGDBusCallMethod(conn, + NULL, NULL, error, "org.freedesktop.machine1", @@ -430,6 +433,7 @@ int virSystemdCreateMachine(const char *name, gprops); rc = virGDBusCallMethod(conn, + NULL, NULL, NULL, "org.freedesktop.machine1", @@ -457,6 +461,7 @@ int virSystemdCreateMachine(const char *name, gprops); rc = virGDBusCallMethod(conn, + NULL, NULL, NULL, "org.freedesktop.systemd1", @@ -507,6 +512,7 @@ int virSystemdTerminateMachine(const char *name) VIR_DEBUG("Attempting to terminate machine via systemd"); if (virGDBusCallMethod(conn, + NULL, NULL, error, "org.freedesktop.machine1", @@ -592,6 +598,7 @@ virSystemdPMSupportTarget(const char *methodName, bool *result) if (virGDBusCallMethod(conn, &reply, + G_VARIANT_TYPE("(s)"), NULL, "org.freedesktop.login1", "/org/freedesktop/login1", -- 2.26.2

2 2

[PATCH v2] util: support PCI passthrough net device stats collection
by zhenwei pi 23 Sep '20

23 Sep '20

Collect PCI passthrough net device stats from kernel by netlink API. Currently, libvirt can not get PCI passthrough net device stats, run command: #virsh domifstat instance --interface=52:54:00:2d:b2:35 error: Failed to get interface stats instance 52:54:00:2d:b2:35 error: internal error: Interface name not provided The PCI device(usually SR-IOV virtual function device) is detached while it's used in PCI passthrough mode. And we can not parse this device from /proc/net/dev any more. In this patch, libvirt check net device is VF of not firstly, then query virNetDevVFInterfaceStats(new API). virNetDevVFInterfaceStats parses VFs info of all PFs, compares MAC address until the two MAC addresses match. '#ip -s link show' can get the same result. Instead of parsing the output result, implement this feature by libnl API. Notice that this feature deponds on driver of PF. Test on Mellanox ConnectX-4 Lx, it works well. Also test on Intel Corporation 82599ES, it works, but only get 0. (ip-link command get the same result). Signed-off-by: zhenwei pi <pizhenwei(a)bytedance.com> --- src/libvirt_private.syms | 1 + src/qemu/qemu_driver.c | 3 ++ src/util/virnetdev.c | 137 +++++++++++++++++++++++++++++++++++++++++++++++ src/util/virnetdev.h | 5 ++ 4 files changed, 146 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index bdbe3431b8..bcc40b8d69 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2585,6 +2585,7 @@ virNetDevSetRcvMulti; virNetDevSetupControl; virNetDevSysfsFile; virNetDevValidateConfig; +virNetDevVFInterfaceStats; # util/virnetdevbandwidth.h diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ae715c01d7..f554010c40 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -10196,6 +10196,9 @@ qemuDomainInterfaceStats(virDomainPtr dom, if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_VHOSTUSER) { if (virNetDevOpenvswitchInterfaceStats(net->ifname, stats) < 0) goto cleanup; + } else if (virDomainNetGetActualType(net) == VIR_DOMAIN_NET_TYPE_HOSTDEV) { + if (virNetDevVFInterfaceStats(&net->mac, stats) < 0) + goto cleanup; } else { if (virNetDevTapInterfaceStats(net->ifname, stats, !virDomainNetTypeSharesHostView(net)) < 0) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index e1a4cc2bef..377f25aae7 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1489,6 +1489,7 @@ static struct nla_policy ifla_vf_policy[IFLA_VF_MAX+1] = { .maxlen = sizeof(struct ifla_vf_mac) }, [IFLA_VF_VLAN] = { .type = NLA_UNSPEC, .maxlen = sizeof(struct ifla_vf_vlan) }, + [IFLA_VF_STATS] = { .type = NLA_NESTED }, }; @@ -2265,6 +2266,132 @@ virNetDevSetNetConfig(const char *linkdev, int vf, return 0; } +static struct nla_policy ifla_vfstats_policy[IFLA_VF_STATS_MAX+1] = { + [IFLA_VF_STATS_RX_PACKETS] = { .type = NLA_U64 }, + [IFLA_VF_STATS_TX_PACKETS] = { .type = NLA_U64 }, + [IFLA_VF_STATS_RX_BYTES] = { .type = NLA_U64 }, + [IFLA_VF_STATS_TX_BYTES] = { .type = NLA_U64 }, + [IFLA_VF_STATS_BROADCAST] = { .type = NLA_U64 }, + [IFLA_VF_STATS_MULTICAST] = { .type = NLA_U64 }, +}; + +static int +virNetDevParseVfStats(struct nlattr **tb, virMacAddrPtr mac, + virDomainInterfaceStatsPtr stats) +{ + int ret = -1, len; + struct ifla_vf_mac *vf_lladdr; + struct nlattr *nla, *t[IFLA_VF_MAX+1]; + struct nlattr *stb[IFLA_VF_STATS_MAX+1]; + + if (tb == NULL || mac == NULL || stats == NULL) { + return -1; + } + + if (!tb[IFLA_VFINFO_LIST]) + return -1; + + len = nla_len(tb[IFLA_VFINFO_LIST]); + + for (nla = nla_data(tb[IFLA_VFINFO_LIST]); nla_ok(nla, len); + nla = nla_next(nla, &len)) { + ret = nla_parse(t, IFLA_VF_MAX, nla_data(nla), nla_len(nla), + ifla_vf_policy); + if (ret < 0) + return -1; + + if (t[IFLA_VF_MAC] == NULL) { + continue; + } + + vf_lladdr = nla_data(t[IFLA_VF_MAC]); + if (virMacAddrCmpRaw(mac, vf_lladdr->mac)) { + continue; + } + + if (t[IFLA_VF_STATS]) { + ret = nla_parse_nested(stb, IFLA_VF_STATS_MAX, + t[IFLA_VF_STATS], + ifla_vfstats_policy); + if (ret < 0) + return -1; + + stats->rx_bytes = nla_get_u64(stb[IFLA_VF_STATS_RX_BYTES]); + stats->tx_bytes = nla_get_u64(stb[IFLA_VF_STATS_TX_BYTES]); + stats->rx_packets = nla_get_u64(stb[IFLA_VF_STATS_RX_PACKETS]); + stats->tx_packets = nla_get_u64(stb[IFLA_VF_STATS_TX_PACKETS]); + } + return 0; + } + + return ret; +} + +/** + * virNetDevVFInterfaceStats: + * @mac: MAC address of the VF interface + * @stats: returns stats of the VF interface + * + * Get the VF interface from kernel by netlink. + * Returns 0 on success, -1 on failure. + */ +int +virNetDevVFInterfaceStats(virMacAddrPtr mac, + virDomainInterfaceStatsPtr stats) +{ + FILE *fp; + char line[256], *colon, *ifname; + int rc = -1; + void *nlData = NULL; + struct nlattr *tb[IFLA_MAX + 1] = {NULL, }; + char *sysfsDevicePath = NULL; + + fp = fopen("/proc/net/dev", "r"); + if (!fp) { + virReportSystemError(errno, "%s", + _("Could not open /proc/net/dev")); + return -1; + } + + /* get all PCI net devices, and parse VFs list from netlink API. + * compare MAC address, collect device stats if matching. + */ + while (fgets(line, sizeof(line), fp)) { + /* The line looks like: + * " eth0:..." + * Split it at the colon. and strip blank from head. + */ + colon = strchr(line, ':'); + if (!colon) + continue; + *colon = '\0'; + ifname = line; + while ((*ifname == ' ') && (ifname < colon)) + ifname++; + + if (virNetDevSysfsFile(&sysfsDevicePath, ifname, "device") < 0) + break; + + if (virNetDevIsPCIDevice(sysfsDevicePath)) { + rc = virNetlinkDumpLink(ifname, -1, &nlData, tb, 0, 0); + if (rc < 0) { + rc = -1; + goto cleanup; + } + + rc = virNetDevParseVfStats(tb, mac, stats); + VIR_FREE(nlData); + if (rc == 0) + goto cleanup; + } + VIR_FREE(sysfsDevicePath); + } + + cleanup: + VIR_FREE(sysfsDevicePath); + VIR_FORCE_FCLOSE(fp); + return rc; +} #else /* defined(__linux__) && defined(WITH_LIBNL) && defined(IFLA_VF_MAX) */ @@ -2309,6 +2436,16 @@ virNetDevSetNetConfig(const char *linkdev G_GNUC_UNUSED, } +int +virNetDevVFInterfaceStats(virMacAddrPtr mac G_GNUC_UNUSED, + virDomainInterfaceStatsPtr stats G_GNUC_UNUSED) +{ + virReportSystemError(ENOSYS, "%s", + _("Unable to get VF net device stats on this platform")); + return -1; +} + + #endif /* defined(__linux__) && defined(WITH_LIBNL) && defined(IFLA_VF_MAX) */ VIR_ENUM_IMPL(virNetDevIfState, diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h index 5f581323ed..ff59d9d341 100644 --- a/src/util/virnetdev.h +++ b/src/util/virnetdev.h @@ -312,4 +312,9 @@ int virNetDevSysfsFile(char **pf_sysfs_device_link, int virNetDevRunEthernetScript(const char *ifname, const char *script) G_GNUC_NO_INLINE; +int virNetDevVFInterfaceStats(virMacAddrPtr mac, + virDomainInterfaceStatsPtr stats) +ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); + + G_DEFINE_AUTOPTR_CLEANUP_FUNC(virNetDevRxFilter, virNetDevRxFilterFree); -- 2.11.0

2 1

[PATCH] Remove redundant check when storage pool is mounted
by Yi Li 23 Sep '20

23 Sep '20

virFileComparePaths just return 0 or 1 after commit 7b48bb8 so break while after virFileComparePaths return 1 Signed-off-by: Yi Li <yili(a)winhong.com> --- src/storage/storage_backend_fs.c | 8 ++------ src/util/virfile.c | 1 - 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c index 536e5cf952..30c2367df4 100644 --- a/src/storage/storage_backend_fs.c +++ b/src/storage/storage_backend_fs.c @@ -245,7 +245,6 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) FILE *mtab; struct mntent ent; char buf[1024]; - int rc1, rc2; g_autofree char *src = NULL; if ((mtab = fopen(_PATH_MOUNTED, "r")) == NULL) { @@ -262,11 +261,8 @@ virStorageBackendFileSystemIsMounted(virStoragePoolObjPtr pool) /* compare both mount destinations and sources to be sure the mounted * FS pool is really the one we're looking for */ - if ((rc1 = virFileComparePaths(ent.mnt_dir, def->target.path)) < 0 || - (rc2 = virFileComparePaths(ent.mnt_fsname, src)) < 0) - goto cleanup; - - if (rc1 && rc2) { + if (virFileComparePaths(ent.mnt_dir, def->target.path) && + virFileComparePaths(ent.mnt_fsname, src)) { ret = 1; goto cleanup; } diff --git a/src/util/virfile.c b/src/util/virfile.c index 61d2c16072..e120d277d0 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -3884,7 +3884,6 @@ virFileCopyACLs(const char *src, * Returns: * 1 : Equal * 0 : Non-Equal - * -1 : Error */ int virFileComparePaths(const char *p1, const char *p2) -- 2.25.3

2 1