- Devel - libvirt List Archives

[PATCH v2] xenParseVif: Refactor parser
by Peter Krempa 12 Mar '21

12 Mar '21

Use g_strsplit to split the string and avoid use of stack'd strings. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/libxl/xen_common.c | 130 +++++++++++++---------------------------- 1 file changed, 39 insertions(+), 91 deletions(-) v2: - helper variables are made const and strings are borrowed from the array returned by g_strsplit instead of copying/freeing - second argument of xenParseVifBridge turned const to silence compiler diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index c56815d7fc..0d3a3f994a 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -1027,7 +1027,7 @@ xenParseCharDev(virConfPtr conf, virDomainDefPtr def, const char *nativeFormat) static int -xenParseVifBridge(virDomainNetDefPtr net, char *bridge) +xenParseVifBridge(virDomainNetDefPtr net, const char *bridge) { char *vlanstr; unsigned int tag; @@ -1141,104 +1141,53 @@ xenParseVif(char *entry, const char *vif_typename) { virDomainNetDefPtr net = NULL; virDomainNetDefPtr ret = NULL; - char *script = NULL; - char model[10]; - char type[10]; - char ip[128]; - char mac[18]; - char bridge[50]; - char vifname[50]; - char rate[50]; - char *key; - - bridge[0] = '\0'; - mac[0] = '\0'; - ip[0] = '\0'; - model[0] = '\0'; - type[0] = '\0'; - vifname[0] = '\0'; - rate[0] = '\0'; - - key = entry; - while (key) { - char *data; - char *nextkey = strchr(key, ','); - - if (!(data = strchr(key, '='))) + g_auto(GStrv) keyvals = NULL; + GStrv keyval; + const char *script = NULL; + const char *model = NULL; + const char *type = NULL; + const char *ip = NULL; + const char *mac = NULL; + const char *bridge = NULL; + const char *vifname = NULL; + const char *rate = NULL; + + keyvals = g_strsplit(entry, ",", 0); + + for (keyval = keyvals; keyval && *keyval; keyval++) { + const char *key = *keyval; + char *val = strchr(key, '='); + + virSkipSpaces(&key); + + if (!val) return NULL; - data++; + + val++; if (STRPREFIX(key, "mac=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(mac, data, len, sizeof(mac)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("MAC address %s too big for destination"), - data); - return NULL; - } + mac = val; } else if (STRPREFIX(key, "bridge=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(bridge, data, len, sizeof(bridge)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Bridge %s too big for destination"), - data); - return NULL; - } + bridge = val; } else if (STRPREFIX(key, "script=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - VIR_FREE(script); - script = g_strndup(data, len); + script = val; } else if (STRPREFIX(key, "model=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(model, data, len, sizeof(model)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Model %s too big for destination"), - data); - return NULL; - } + model = val; } else if (STRPREFIX(key, "type=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(type, data, len, sizeof(type)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Type %s too big for destination"), - data); - return NULL; - } + type = val; } else if (STRPREFIX(key, "vifname=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(vifname, data, len, sizeof(vifname)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Vifname %s too big for destination"), - data); - return NULL; - } + vifname = val; } else if (STRPREFIX(key, "ip=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(ip, data, len, sizeof(ip)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("IP %s too big for destination"), data); - return NULL; - } + ip = val; } else if (STRPREFIX(key, "rate=")) { - int len = nextkey ? (nextkey - data) : strlen(data); - if (virStrncpy(rate, data, len, sizeof(rate)) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("rate %s too big for destination"), data); - return NULL; - } + rate = val; } - - while (nextkey && (nextkey[0] == ',' || - nextkey[0] == ' ' || - nextkey[0] == '\t')) - nextkey++; - key = nextkey; } if (!(net = virDomainNetDefNew(NULL))) goto cleanup; - if (mac[0]) { + if (mac) { if (virMacAddrParse(mac, &net->mac) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("malformed mac address '%s'"), mac); @@ -1246,18 +1195,18 @@ xenParseVif(char *entry, const char *vif_typename) } } - if (bridge[0] || STREQ_NULLABLE(script, "vif-bridge") || + if (bridge || STREQ_NULLABLE(script, "vif-bridge") || STREQ_NULLABLE(script, "vif-vnic")) { net->type = VIR_DOMAIN_NET_TYPE_BRIDGE; } else { net->type = VIR_DOMAIN_NET_TYPE_ETHERNET; } - if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE && bridge[0]) { + if (net->type == VIR_DOMAIN_NET_TYPE_BRIDGE && bridge) { if (xenParseVifBridge(net, bridge) < 0) goto cleanup; } - if (ip[0]) { + if (ip) { char **ip_list = g_strsplit(ip, " ", 0); size_t i; @@ -1276,18 +1225,18 @@ xenParseVif(char *entry, const char *vif_typename) if (script && script[0]) net->script = g_strdup(script); - if (model[0]) { + if (model) { if (virDomainNetSetModelString(net, model) < 0) goto cleanup; } else { - if (type[0] && STREQ(type, vif_typename)) + if (type && STREQ(type, vif_typename)) net->model = VIR_DOMAIN_NET_MODEL_NETFRONT; } - if (vifname[0]) + if (vifname && vifname[0]) net->ifname = g_strdup(vifname); - if (rate[0]) { + if (rate) { virNetDevBandwidthPtr bandwidth; unsigned long long kbytes_per_sec; @@ -1304,7 +1253,6 @@ xenParseVif(char *entry, const char *vif_typename) cleanup: virDomainNetDefFree(net); - VIR_FREE(script); return ret; } -- 2.29.2

2 1

Re: [PATCH 1/6] accel: Introduce 'query-accels' QMP command
by Thomas Huth 12 Mar '21

12 Mar '21

On 12/03/2021 08.42, Marc-André Lureau wrote: > > > On Fri, Mar 12, 2021 at 3:14 AM Philippe Mathieu-Daudé <philmd(a)redhat.com > <mailto:philmd@redhat.com>> wrote: > [...] > +## > +# @AcceleratorInfo: > +# > +# Accelerator information. > +# > +# @name: The accelerator name. > +# > +# Since: 6.0 > +## > +{ 'union': 'AcceleratorInfo', > + 'base': {'name': 'Accelerator'}, > + 'discriminator': 'name', > + 'data': { } } > > + > > > Making room for future details, why not. I think we definitely need the additional data section here: For KVM on POWER, it would be good to know whether it's KVM-HV or KVM-PR, for KVM on MIPS it would be good to know whether it's KVM_VM_MIPS_VZ or KVM_VM_MIPS_TE, for KVM on x86 whether it's the AMD flavor or Intel, ... > +## > +# @query-accels: > +# > +# Get a list of AcceleratorInfo for all built-in accelerators. > +# > +# Returns: a list of @AcceleratorInfo describing each accelerator. > +# > +# Since: 6.0 > +# > +# Example: > +# > +# -> { "execute": "query-accels" } > +# <- { "return": [ > +# { > +# "type": "qtest" > +# }, > +# { > +# "type": "kvm" > +# } > +# ] } > +# > +## > +{ 'command': 'query-accels', > + 'returns': ['AcceleratorInfo'] } > > > That's nice, but how do you know which accels are actually enabled? I guess we need two commands in the end, one for querying which accelerators are available, and one for querying the data from the currently active accelerator...? Thomas

4 6

[PATCH 0/5] Document lxc.conf and libxl.conf locations
by Michal Privoznik 12 Mar '21

12 Mar '21

This is a continuation of effort started here, where I documented qemu.conf location: https://listman.redhat.com/archives/libvir-list/2021-March/msg00276.html Michal Prívozník (5): docs: Capitalize QEMU driver reference manpages: Remove reference to a session daemon for LXC docs: Document lxc.conf location manpages: Remove reference to a session daemon for libxl docs: Document libxl.conf location docs/drvlxc.html.in | 10 ++++++++++ docs/drvxen.html.in | 11 +++++++++++ docs/manpages/libvirtd.rst | 17 ++++++++++------- docs/manpages/virtlxcd.rst | 38 +++++++++++-------------------------- docs/manpages/virtqemud.rst | 2 +- docs/manpages/virtxend.rst | 38 +++++++++++-------------------------- 6 files changed, 54 insertions(+), 62 deletions(-) -- 2.26.2

2 6

[libvirt PATCH 00/18] qemu: add support for audio backend configuration
by Daniel P. Berrangé 12 Mar '21

12 Mar '21

Historically we've done almost nothing with audio backend configuration. In QEMU we merely set QEMU_AUDIO_DRV to one of sdl, spice, none depending on <graphics>. We also have the somewhat crazy ability to let QEMU inherit the QEMU_AUDIO_DRV env variable from libvirtd. Fairly recently BHyve wanted audio backend config for OSS so introduced the <audio> element. We designed that to allow QEMU to later extend it, and that's what this series does. We add <audio> types for all the QEMU backends, except the Windows only DSound which isn't relevant for libvirt. The QEMU driver is updated to use this element to configure things. QEMU has many many many more env variables for configuring audio settings, which we can now support. These are all deprecated since 4.0.0 though, so we also add support for the new -audiodev argument. Unfortunately -audiodev isn't introspectable due to limits in QEMU fixed by: https://lists.gnu.org/archive/html/qemu-devel/2021-03/msg00653.html The lack of introspection isn't critical though. We can detect existance of -audiodev by querying for '-vnc audiodev=3DNNN' argument support. We simply lack ability to determine what QEMU audio backends are compiled in. This means we have to delegate error reporting to QEMU itself, which is OK. We'll make use of the query-audiodev command at a later date to track future improvements to QEMU audiodev backends. Daniel P. Berrang=C3=A9 (18): config: cleanup some typos / baggage wrt compiler checks conf: stronger error reporting when parsing audio related params conf: don't force existance of audio child elements conf: add helper to test for sound device codec support conf: add missing iteration over audio backends conf: refactor OSS audio backend specific options conf: add coverage for all QEMU audio backend types conf: add support for audio backend for the VNC server conf: add validation of audio backend IDs conf: rename and improve virDomainDefFindAudioForSound qemu: support use of <audio> elements qemu: populate <audio> element with default config qemu: probe for -vnc audiodev property qemu: add support for generating -audiodev arguments conf: introduce support for common audio settings qemu: wire up support for common audio backend settings conf: add support for audio backend specific settings qemu: wire up support for backend specific audio settings config.h | 10 +- docs/formatdomain.rst | 322 +++++++- docs/schemas/domaincommon.rng | 384 +++++++++- src/bhyve/bhyve_command.c | 30 +- src/conf/domain_conf.c | 693 +++++++++++++++++- src/conf/domain_conf.h | 125 +++- src/conf/domain_validate.c | 67 +- src/libvirt_private.syms | 8 +- src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 484 +++++++++++- src/qemu/qemu_domain.c | 110 ++- src/qemu/qemu_validate.c | 136 +++- .../caps_4.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 1 + .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 1 + .../caps_4.2.0.x86_64.xml | 1 + .../caps_5.0.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + .../caps_5.0.0.riscv64.xml | 1 + .../caps_5.0.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 1 + .../caps_5.1.0.x86_64.xml | 1 + .../caps_5.2.0.aarch64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 1 + .../caps_5.2.0.riscv64.xml | 1 + .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 1 + .../caps_5.2.0.x86_64.xml | 1 + .../caps_6.0.0.x86_64.xml | 1 + .../redefine.xml | 1 + .../disk_snapshot_redefine.xml | 1 + .../external_vm_redefine.xml | 1 + .../full_domain.xml | 1 + .../qemudomainsnapshotxml2xmlout/metadata.xml | 1 + .../ppc64-modern-bulk-result-conf.xml | 1 + .../ppc64-modern-bulk-result-live.xml | 1 + .../ppc64-modern-individual-result-conf.xml | 1 + .../ppc64-modern-individual-result-live.xml | 1 + .../x86-modern-bulk-result-conf.xml | 1 + .../x86-modern-bulk-result-live.xml | 1 + .../x86-modern-individual-add-result-conf.xml | 1 + .../x86-modern-individual-add-result-live.xml | 1 + .../x86-old-bulk-result-conf.xml | 1 + .../x86-old-bulk-result-live.xml | 1 + .../qemuhotplug-base-ccw-live+ccw-virtio.xml | 1 + ...with-2-ccw-virtio+ccw-virtio-1-reverse.xml | 1 + ...otplug-base-ccw-live-with-2-ccw-virtio.xml | 1 + ...-with-ccw-virtio+ccw-virtio-2-explicit.xml | 1 + ...-ccw-live-with-ccw-virtio+ccw-virtio-2.xml | 1 + ...uhotplug-base-ccw-live-with-ccw-virtio.xml | 1 + .../qemuhotplug-base-ccw-live.xml | 1 + ...uhotplug-base-live+disk-scsi-multipath.xml | 1 + ...+disk-scsi-wwn+disk-scsi-duplicate-wwn.xml | 1 + .../qemuhotplug-base-live+disk-scsi.xml | 1 + .../qemuhotplug-base-live+disk-usb.xml | 1 + .../qemuhotplug-base-live+disk-virtio.xml | 1 + .../qemuhotplug-base-live+guestfwd.xml | 1 + .../qemuhotplug-base-live+hostdev-pci.xml | 1 + .../qemuhotplug-base-live+interface-vdpa.xml | 1 + ...qemuhotplug-base-live+ivshmem-doorbell.xml | 1 + .../qemuhotplug-base-live+ivshmem-plain.xml | 1 + .../qemuhotplug-base-live+qemu-agent.xml | 1 + ...uhotplug-base-live+watchdog-user-alias.xml | 1 + .../qemuhotplug-base-live+watchdog.xml | 1 + .../qemuhotplug-base-live.xml | 1 + ...hotplug-base-with-scsi-controller-live.xml | 1 + ...thout-scsi-controller-live+disk-scsi-2.xml | 1 + ...g-console-compat-2-live+console-virtio.xml | 1 + .../qemuhotplug-console-compat-2-live.xml | 1 + ...uhotplug-pseries-base-live+hostdev-pci.xml | 1 + .../qemuhotplug-pseries-base-live.xml | 1 + .../full-xml2xml-out.xml | 1 + .../qemustatusxml2xmldata/backup-pull-in.xml | 1 + .../blockjob-blockdev-in.xml | 1 + .../blockjob-mirror-in.xml | 1 + .../migration-in-params-in.xml | 1 + .../migration-out-nbd-bitmaps-in.xml | 1 + .../migration-out-nbd-out.xml | 1 + .../migration-out-nbd-tls-out.xml | 1 + .../migration-out-params-in.xml | 1 + tests/qemustatusxml2xmldata/modern-in.xml | 1 + tests/qemustatusxml2xmldata/upgrade-out.xml | 1 + .../qemustatusxml2xmldata/vcpus-multi-in.xml | 1 + ...fault-cpu-kvm-virt-4.2.aarch64-latest.args | 2 +- ...fault-cpu-tcg-virt-4.2.aarch64-latest.args | 2 +- .../aarch64-features-sve.aarch64-latest.args | 2 +- tests/qemuxml2argvdata/aarch64-gic-host.xml | 1 + tests/qemuxml2argvdata/aarch64-gic-v2.xml | 1 + tests/qemuxml2argvdata/aarch64-gic-v3.xml | 1 + ...arch64-os-firmware-efi.aarch64-latest.args | 2 +- .../aarch64-tpm.aarch64-latest.args | 2 +- .../aarch64-virt-graphics.aarch64-latest.args | 4 +- .../aarch64-virt-headless.aarch64-latest.args | 2 +- tests/qemuxml2argvdata/audio-alsa-best.args | 41 ++ .../audio-alsa-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-alsa-best.xml | 43 ++ tests/qemuxml2argvdata/audio-alsa-full.args | 29 + tests/qemuxml2argvdata/audio-alsa-full.err | 1 + .../audio-alsa-full.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-alsa-full.xml | 43 ++ .../qemuxml2argvdata/audio-alsa-minimal.args | 29 + .../audio-alsa-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-alsa-minimal.xml | 36 + .../audio-coreaudio-best.args | 41 ++ .../audio-coreaudio-best.x86_64-latest.args | 42 ++ .../qemuxml2argvdata/audio-coreaudio-best.xml | 43 ++ .../audio-coreaudio-full.args | 29 + .../qemuxml2argvdata/audio-coreaudio-full.err | 1 + .../audio-coreaudio-full.x86_64-latest.args | 43 ++ .../qemuxml2argvdata/audio-coreaudio-full.xml | 43 ++ .../audio-coreaudio-minimal.args | 29 + ...audio-coreaudio-minimal.x86_64-latest.args | 39 + .../audio-coreaudio-minimal.xml | 36 + .../audio-default-nographics.args | 29 + ...udio-default-nographics.x86_64-latest.args | 39 + .../audio-default-nographics.xml | 31 + tests/qemuxml2argvdata/audio-default-sdl.args | 31 + .../audio-default-sdl.x86_64-latest.args | 41 ++ tests/qemuxml2argvdata/audio-default-sdl.xml | 35 + .../qemuxml2argvdata/audio-default-spice.args | 30 + .../audio-default-spice.x86_64-latest.args | 40 + .../qemuxml2argvdata/audio-default-spice.xml | 35 + tests/qemuxml2argvdata/audio-default-vnc.args | 30 + .../audio-default-vnc.x86_64-latest.args | 40 + tests/qemuxml2argvdata/audio-default-vnc.xml | 35 + tests/qemuxml2argvdata/audio-file-best.args | 40 + .../audio-file-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-file-best.xml | 43 ++ tests/qemuxml2argvdata/audio-file-full.args | 29 + tests/qemuxml2argvdata/audio-file-full.err | 1 + .../audio-file-full.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-file-full.xml | 43 ++ .../qemuxml2argvdata/audio-file-minimal.args | 29 + .../audio-file-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-file-minimal.xml | 36 + tests/qemuxml2argvdata/audio-jack-full.err | 1 + .../audio-jack-full.x86_64-latest.args | 44 ++ tests/qemuxml2argvdata/audio-jack-full.xml | 43 ++ tests/qemuxml2argvdata/audio-jack-minimal.err | 1 + .../audio-jack-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-jack-minimal.xml | 36 + .../qemuxml2argvdata/audio-many-backends.err | 1 + .../audio-many-backends.x86_64-latest.args | 46 ++ .../qemuxml2argvdata/audio-many-backends.xml | 60 ++ tests/qemuxml2argvdata/audio-none-best.args | 39 + .../audio-none-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-none-best.xml | 43 ++ tests/qemuxml2argvdata/audio-none-full.args | 29 + tests/qemuxml2argvdata/audio-none-full.err | 1 + .../audio-none-full.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-none-full.xml | 43 ++ .../qemuxml2argvdata/audio-none-minimal.args | 29 + .../audio-none-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-none-minimal.xml | 36 + tests/qemuxml2argvdata/audio-oss-best.args | 44 ++ .../audio-oss-best.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-oss-best.xml | 43 ++ tests/qemuxml2argvdata/audio-oss-full.args | 31 + tests/qemuxml2argvdata/audio-oss-full.err | 1 + .../audio-oss-full.x86_64-latest.args | 44 ++ tests/qemuxml2argvdata/audio-oss-full.xml | 43 ++ tests/qemuxml2argvdata/audio-oss-minimal.args | 29 + .../audio-oss-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-oss-minimal.xml | 36 + .../audio-pulseaudio-best.args | 43 ++ .../audio-pulseaudio-best.x86_64-latest.args | 43 ++ .../audio-pulseaudio-best.xml | 43 ++ .../audio-pulseaudio-full.args | 29 + .../audio-pulseaudio-full.err | 1 + .../audio-pulseaudio-full.x86_64-latest.args | 44 ++ .../audio-pulseaudio-full.xml | 43 ++ .../audio-pulseaudio-minimal.args | 29 + ...udio-pulseaudio-minimal.x86_64-latest.args | 39 + .../audio-pulseaudio-minimal.xml | 36 + tests/qemuxml2argvdata/audio-sdl-best.args | 41 ++ .../audio-sdl-best.x86_64-latest.args | 43 ++ tests/qemuxml2argvdata/audio-sdl-best.xml | 43 ++ tests/qemuxml2argvdata/audio-sdl-full.args | 30 + tests/qemuxml2argvdata/audio-sdl-full.err | 1 + .../audio-sdl-full.x86_64-latest.args | 44 ++ tests/qemuxml2argvdata/audio-sdl-full.xml | 43 ++ tests/qemuxml2argvdata/audio-sdl-minimal.args | 29 + .../audio-sdl-minimal.x86_64-latest.args | 39 + tests/qemuxml2argvdata/audio-sdl-minimal.xml | 36 + tests/qemuxml2argvdata/audio-spice-best.args | 39 + .../audio-spice-best.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-spice-best.xml | 43 ++ tests/qemuxml2argvdata/audio-spice-full.args | 29 + tests/qemuxml2argvdata/audio-spice-full.err | 1 + .../audio-spice-full.x86_64-latest.args | 42 ++ tests/qemuxml2argvdata/audio-spice-full.xml | 43 ++ .../qemuxml2argvdata/audio-spice-minimal.args | 29 + .../audio-spice-minimal.x86_64-latest.args | 39 + .../qemuxml2argvdata/audio-spice-minimal.xml | 36 + .../blkdeviotune-group-num.x86_64-latest.args | 2 +- .../blkdeviotune-group-num.xml | 1 + ...blkdeviotune-max-length.x86_64-latest.args | 2 +- .../blkdeviotune-max-length.xml | 1 + .../blkdeviotune-max.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/blkdeviotune-max.xml | 1 + tests/qemuxml2argvdata/boot-floppy-q35.xml | 1 + .../channel-unix-guestfwd.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/clock-france.args | 2 +- tests/qemuxml2argvdata/clock-realtime.xml | 1 + .../clock-timer-armvtimer.aarch64-latest.args | 2 +- .../clock-timer-armvtimer.xml | 1 + .../console-virtio-unix.x86_64-latest.args | 2 +- .../controller-virtio-scsi.x86_64-latest.args | 2 +- ...-Icelake-Server-pconfig.x86_64-latest.args | 2 +- .../cpu-translation.x86_64-latest.args | 2 +- .../cpu-tsc-high-frequency.x86_64-latest.args | 2 +- .../cputune-cpuset-big-id.x86_64-latest.args | 2 +- ...ult-video-type-aarch64.aarch64-latest.args | 4 +- ...default-video-type-ppc64.ppc64-latest.args | 4 +- ...ult-video-type-riscv64.riscv64-latest.args | 2 +- ...default-video-type-s390x.s390x-latest.args | 4 +- .../disk-aio-io_uring.x86_64-latest.args | 2 +- .../disk-aio.x86_64-latest.args | 2 +- .../disk-arm-virtio-sd.aarch64-latest.args | 2 +- ...-backing-chains-noindex.x86_64-latest.args | 2 +- .../disk-cache.x86_64-latest.args | 2 +- .../disk-cdrom-bus-other.x86_64-latest.args | 2 +- ...m-empty-network-invalid.x86_64-latest.args | 2 +- .../disk-cdrom-network.x86_64-latest.args | 2 +- .../disk-cdrom-tray.x86_64-latest.args | 2 +- .../disk-cdrom.x86_64-latest.args | 2 +- .../disk-copy_on_read.x86_64-latest.args | 2 +- .../disk-detect-zeroes.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-detect-zeroes.xml | 1 + .../disk-discard.x86_64-latest.args | 2 +- .../disk-error-policy-s390x.s390x-latest.args | 2 +- .../disk-error-policy.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_11.x86_64-latest.args | 2 +- .../disk-floppy-q35-2_9.x86_64-latest.args | 2 +- .../disk-floppy.x86_64-latest.args | 2 +- .../disk-metadata-cache.x86_64-latest.args | 2 +- .../disk-network-gluster.x86_64-latest.args | 2 +- .../disk-network-http.x86_64-latest.args | 2 +- .../disk-network-iscsi.x86_64-latest.args | 2 +- .../disk-network-nbd.x86_64-latest.args | 2 +- .../disk-network-nfs.x86_64-latest.args | 2 +- .../disk-network-rbd.x86_64-latest.args | 2 +- .../disk-network-sheepdog.x86_64-latest.args | 2 +- ...isk-network-source-auth.x86_64-latest.args | 2 +- ...isk-network-tlsx509-nbd.x86_64-latest.args | 2 +- ...isk-network-tlsx509-vxhs.x86_64-5.0.0.args | 2 +- .../disk-nvme.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-nvme.xml | 1 + .../disk-readonly-disk.x86_64-latest.args | 2 +- .../disk-scsi-device-auto.x86_64-latest.args | 2 +- .../disk-scsi.x86_64-latest.args | 2 +- .../disk-shared.x86_64-latest.args | 2 +- .../disk-slices.x86_64-latest.args | 2 +- .../disk-transient.x86_64-latest.args | 2 +- .../disk-vhostuser.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/disk-virtio-queues.xml | 1 + ...irtio-scsi-reservations.x86_64-latest.args | 2 +- .../disk-virtio-scsi-reservations.xml | 1 + tests/qemuxml2argvdata/downscript.xml | 1 + .../qemuxml2argvdata/encrypted-disk-usage.xml | 1 + .../eoi-disabled.x86_64-latest.args | 2 +- .../eoi-enabled.x86_64-latest.args | 2 +- .../fd-memory-no-numa-topology.xml | 1 + .../fd-memory-numa-topology.xml | 1 + .../fd-memory-numa-topology2.xml | 1 + .../fd-memory-numa-topology3.xml | 1 + .../fips-enabled.x86_64-5.1.0.args | 2 +- .../fips-enabled.x86_64-latest.args | 2 +- .../floppy-drive-fat.x86_64-latest.args | 2 +- .../fs9p-ccw.s390x-latest.args | 2 +- .../qemuxml2argvdata/fs9p.x86_64-latest.args | 2 +- .../genid-auto.x86_64-latest.args | 2 +- .../qemuxml2argvdata/genid.x86_64-latest.args | 2 +- ...pice-gl-auto-rendernode.x86_64-latest.args | 2 +- .../qemuxml2argvdata/graphics-spice-sasl.args | 2 +- tests/qemuxml2argvdata/graphics-vnc-sasl.args | 2 +- ...graphics-vnc-tls-secret.x86_64-latest.args | 4 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 2 +- .../graphics-vnc-tls.x86_64-2.4.0.args | 2 +- .../graphics-vnc-tls.x86_64-latest.args | 4 +- ...tdev-mdev-display-ramfb.x86_64-latest.args | 4 +- ...play-spice-egl-headless.x86_64-latest.args | 2 +- ...ev-display-spice-opengl.x86_64-latest.args | 2 +- ...isplay-vnc-egl-headless.x86_64-latest.args | 4 +- ...ostdev-mdev-display-vnc.x86_64-latest.args | 4 +- .../hostdev-scsi-lsi.x86_64-latest.args | 2 +- ...ostdev-scsi-virtio-scsi.x86_64-latest.args | 2 +- ...tdev-subsys-mdev-vfio-ap.s390x-latest.args | 2 +- ...ubsys-mdev-vfio-ccw-boot.s390x-latest.args | 2 +- .../qemuxml2argvdata/hugepages-default-2M.xml | 1 + .../hugepages-default-system-size.xml | 1 + .../qemuxml2argvdata/hugepages-memaccess.xml | 1 + .../qemuxml2argvdata/hugepages-memaccess2.xml | 1 + .../hugepages-memaccess3.x86_64-latest.args | 2 +- .../hugepages-numa-default-dimm.xml | 1 + .../hugepages-nvdimm.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/hugepages-nvdimm.xml | 1 + .../hyperv-off.x86_64-latest.args | 2 +- .../hyperv-panic.x86_64-latest.args | 2 +- .../hyperv-stimer-direct.x86_64-latest.args | 2 +- .../hyperv.x86_64-latest.args | 2 +- .../intel-iommu-aw-bits.x86_64-latest.args | 2 +- .../qemuxml2argvdata/intel-iommu-aw-bits.xml | 1 + ...ntel-iommu-caching-mode.x86_64-latest.args | 2 +- .../intel-iommu-caching-mode.xml | 1 + ...ntel-iommu-device-iotlb.x86_64-latest.args | 2 +- .../intel-iommu-device-iotlb.xml | 1 + .../intel-iommu-eim.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/intel-iommu-eim.xml | 1 + .../intel-iommu.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/intel-iommu.xml | 1 + .../iommu-smmuv3.aarch64-latest.args | 2 +- ...othreads-virtio-scsi-ccw.s390x-latest.args | 2 +- ...threads-virtio-scsi-pci.x86_64-latest.args | 2 +- .../kvmclock+eoi-disabled.x86_64-latest.args | 2 +- ...luks-disks-source-qcow2.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/luks-disks.xml | 1 + ...memory-default-hugepage.x86_64-latest.args | 2 +- .../memfd-memory-default-hugepage.xml | 1 + .../memfd-memory-numa.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/memfd-memory-numa.xml | 1 + ...y-hotplug-nvdimm-access.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-access.xml | 1 + ...ry-hotplug-nvdimm-align.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-align.xml | 1 + ...ry-hotplug-nvdimm-label.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-label.xml | 1 + ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-pmem.xml | 1 + ...hotplug-nvdimm-readonly.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm-readonly.xml | 1 + .../memory-hotplug-nvdimm.x86_64-latest.args | 2 +- .../memory-hotplug-nvdimm.xml | 1 + .../memory-hotplug-ppc64-nonuma.xml | 1 + ...ory-hotplug-virtio-pmem.x86_64-latest.args | 2 +- .../memory-hotplug-virtio-pmem.xml | 1 + .../mlock-off.x86_64-latest.args | 2 +- .../mlock-on.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/net-user-addr.xml | 1 + .../net-vdpa.x86_64-latest.args | 2 +- .../net-vhostuser.x86_64-latest.args | 2 +- .../net-virtio-teaming-hostdev.xml | 1 + .../numatune-hmat.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/numatune-hmat.xml | 1 + tests/qemuxml2argvdata/numatune-no-vcpu.xml | 1 + .../os-firmware-bios.x86_64-latest.args | 2 +- ...os-firmware-efi-secboot.x86_64-latest.args | 2 +- .../os-firmware-efi.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/pages-dimm-discard.xml | 1 + .../pages-discard-hugepages.xml | 1 + tests/qemuxml2argvdata/pages-discard.xml | 1 + .../parallel-unix-chardev.x86_64-latest.args | 2 +- ...cie-root-port-nohotplug.x86_64-latest.args | 2 +- ...ault-cpu-kvm-pseries-2.7.ppc64-latest.args | 2 +- ...ault-cpu-kvm-pseries-3.1.ppc64-latest.args | 2 +- ...ault-cpu-kvm-pseries-4.2.ppc64-latest.args | 2 +- ...ault-cpu-tcg-pseries-2.7.ppc64-latest.args | 2 +- ...ault-cpu-tcg-pseries-3.1.ppc64-latest.args | 2 +- ...ault-cpu-tcg-pseries-4.2.ppc64-latest.args | 2 +- .../ppc64-pseries-graphics.ppc64-latest.args | 4 +- .../ppc64-pseries-headless.ppc64-latest.args | 2 +- .../ppc64-tpmproxy-single.ppc64-latest.args | 2 +- .../ppc64-tpmproxy-with-tpm.ppc64-latest.args | 2 +- .../pv-spinlock-disabled.x86_64-latest.args | 2 +- .../pv-spinlock-enabled.x86_64-latest.args | 2 +- .../qemu-ns.x86_64-latest.args | 2 +- .../riscv64-virt-graphics.riscv64-latest.args | 4 +- .../riscv64-virt-headless.riscv64-latest.args | 2 +- ...t-cpu-kvm-ccw-virtio-2.7.s390x-latest.args | 2 +- ...t-cpu-kvm-ccw-virtio-4.2.s390x-latest.args | 2 +- ...t-cpu-tcg-ccw-virtio-2.7.s390x-latest.args | 2 +- ...t-cpu-tcg-ccw-virtio-4.2.s390x-latest.args | 2 +- .../s390x-ccw-graphics.s390x-latest.args | 4 +- .../s390x-ccw-headless.s390x-latest.args | 2 +- .../serial-tcp-tlsx509-chardev-notls.xml | 1 + .../serial-unix-chardev.x86_64-latest.args | 2 +- ...rtcard-passthrough-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/smbios-type-fwcfg.xml | 1 + .../tpm-emulator-spapr.ppc64-latest.args | 2 +- .../tpm-emulator-tpm2-enc.x86_64-latest.args | 2 +- ...pm-emulator-tpm2-pstate.x86_64-latest.args | 2 +- .../tpm-emulator-tpm2.x86_64-latest.args | 2 +- .../tpm-emulator.x86_64-latest.args | 2 +- .../tpm-passthrough-crb.x86_64-latest.args | 2 +- .../tpm-passthrough.x86_64-latest.args | 2 +- .../tseg-explicit-size.x86_64-latest.args | 2 +- .../usb-redir-unix.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/user-aliases.xml | 1 + .../vcpu-placement-static.xml | 1 + ...vhost-user-fs-fd-memory.x86_64-latest.args | 2 +- .../vhost-user-fs-fd-memory.xml | 1 + ...vhost-user-fs-hugepages.x86_64-latest.args | 2 +- .../vhost-user-fs-hugepages.xml | 1 + ...host-user-gpu-secondary.x86_64-latest.args | 2 +- .../vhost-user-vga.x86_64-latest.args | 2 +- .../vhost-vsock-auto.x86_64-latest.args | 2 +- .../vhost-vsock-ccw-auto.s390x-latest.args | 2 +- .../vhost-vsock-ccw-iommu.s390x-latest.args | 2 +- .../vhost-vsock-ccw-iommu.xml | 1 + .../vhost-vsock-ccw.s390x-latest.args | 2 +- tests/qemuxml2argvdata/vhost-vsock-ccw.xml | 1 + .../vhost-vsock.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/vhost-vsock.xml | 1 + ...eo-bochs-display-device.x86_64-latest.args | 2 +- ...video-qxl-device-vram64.x86_64-latest.args | 2 +- .../qemuxml2argvdata/video-qxl-resolution.xml | 1 + ...o-qxl-sec-device-vram64.x86_64-latest.args | 2 +- ...eo-ramfb-display-device.x86_64-latest.args | 2 +- .../virtio-9p-createmode.x86_64-latest.args | 2 +- .../virtio-9p-multidevs.x86_64-latest.args | 2 +- ...virtio-non-transitional.x86_64-latest.args | 2 +- ...-options-controller-ats.x86_64-latest.args | 2 +- ...ptions-controller-iommu.x86_64-latest.args | 2 +- ...tions-controller-packed.x86_64-latest.args | 2 +- ...virtio-options-disk-ats.x86_64-latest.args | 2 +- ...rtio-options-disk-iommu.x86_64-latest.args | 2 +- ...tio-options-disk-packed.x86_64-latest.args | 2 +- .../virtio-options-fs-ats.x86_64-latest.args | 2 +- ...virtio-options-fs-iommu.x86_64-latest.args | 2 +- ...irtio-options-fs-packed.x86_64-latest.args | 2 +- ...irtio-options-input-ats.x86_64-latest.args | 2 +- ...tio-options-input-iommu.x86_64-latest.args | 2 +- ...io-options-input-packed.x86_64-latest.args | 2 +- ...-options-memballoon-ats.x86_64-latest.args | 2 +- ...loon-freepage-reporting.x86_64-latest.args | 2 +- ...ptions-memballoon-iommu.x86_64-latest.args | 2 +- ...tions-memballoon-packed.x86_64-latest.args | 2 +- .../virtio-options-net-ats.x86_64-latest.args | 2 +- ...irtio-options-net-iommu.x86_64-latest.args | 2 +- ...rtio-options-net-packed.x86_64-latest.args | 2 +- .../virtio-options-rng-ats.x86_64-latest.args | 2 +- ...irtio-options-rng-iommu.x86_64-latest.args | 2 +- ...rtio-options-rng-packed.x86_64-latest.args | 2 +- ...irtio-options-video-ats.x86_64-latest.args | 2 +- ...tio-options-video-iommu.x86_64-latest.args | 2 +- ...io-options-video-packed.x86_64-latest.args | 2 +- .../virtio-options.x86_64-latest.args | 2 +- tests/qemuxml2argvdata/virtio-options.xml | 1 + .../virtio-rng-builtin.x86_64-latest.args | 2 +- .../virtio-rng-egd-unix.x86_64-latest.args | 2 +- .../virtio-transitional.x86_64-latest.args | 2 +- ...-default-cpu-kvm-pc-4.2.x86_64-latest.args | 2 +- ...default-cpu-kvm-q35-4.2.x86_64-latest.args | 2 +- ...-default-cpu-tcg-pc-4.2.x86_64-latest.args | 2 +- ...default-cpu-tcg-q35-4.2.x86_64-latest.args | 2 +- .../x86_64-pc-graphics.x86_64-latest.args | 4 +- .../x86_64-pc-headless.x86_64-latest.args | 2 +- .../x86_64-q35-graphics.x86_64-latest.args | 4 +- .../x86_64-q35-headless.x86_64-latest.args | 2 +- tests/qemuxml2argvtest.c | 90 +++ .../aarch64-aavmf-virtio-mmio.xml | 1 + ...efault-cpu-kvm-virt-4.2.aarch64-latest.xml | 1 + ...efault-cpu-tcg-virt-4.2.aarch64-latest.xml | 1 + .../aarch64-features-sve.aarch64-latest.xml | 1 + .../aarch64-gic-none-tcg.xml | 1 + ...aarch64-os-firmware-efi.aarch64-latest.xml | 1 + .../qemuxml2xmloutdata/aarch64-pci-serial.xml | 1 + .../aarch64-traditional-pci.xml | 1 + .../aarch64-video-default.xml | 1 + .../aarch64-video-virtio-gpu-pci.xml | 1 + .../aarch64-virt-graphics.aarch64-latest.xml | 1 + .../aarch64-virt-headless.aarch64-latest.xml | 1 + .../aarch64-virtio-pci-default.xml | 1 + .../aarch64-virtio-pci-manual-addresses.xml | 1 + tests/qemuxml2xmloutdata/acpi-table.xml | 1 + tests/qemuxml2xmloutdata/audio-alsa-best.xml | 1 + tests/qemuxml2xmloutdata/audio-alsa-full.xml | 1 + .../qemuxml2xmloutdata/audio-alsa-minimal.xml | 1 + .../audio-coreaudio-best.xml | 1 + .../audio-coreaudio-full.xml | 1 + .../audio-coreaudio-minimal.xml | 1 + ...audio-default-nographics.x86_64-latest.xml | 39 + .../audio-default-nographics.xml | 1 + .../audio-default-sdl.x86_64-latest.xml | 44 ++ .../qemuxml2xmloutdata/audio-default-sdl.xml | 1 + .../audio-default-spice.x86_64-latest.xml | 46 ++ .../audio-default-spice.xml | 1 + .../audio-default-vnc.x86_64-latest.xml | 46 ++ .../qemuxml2xmloutdata/audio-default-vnc.xml | 1 + tests/qemuxml2xmloutdata/audio-file-best.xml | 1 + tests/qemuxml2xmloutdata/audio-file-full.xml | 1 + .../qemuxml2xmloutdata/audio-file-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-jack-full.xml | 1 + .../audio-many-backends.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/audio-none-best.xml | 1 + tests/qemuxml2xmloutdata/audio-none-full.xml | 1 + .../qemuxml2xmloutdata/audio-none-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-oss-best.xml | 1 + tests/qemuxml2xmloutdata/audio-oss-full.xml | 1 + .../qemuxml2xmloutdata/audio-oss-minimal.xml | 1 + .../audio-pulseaudio-best.xml | 1 + .../audio-pulseaudio-full.xml | 1 + .../audio-pulseaudio-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-sdl-best.xml | 1 + tests/qemuxml2xmloutdata/audio-sdl-full.xml | 1 + .../qemuxml2xmloutdata/audio-sdl-minimal.xml | 1 + tests/qemuxml2xmloutdata/audio-spice-best.xml | 1 + tests/qemuxml2xmloutdata/audio-spice-full.xml | 1 + .../audio-spice-minimal.xml | 1 + tests/qemuxml2xmloutdata/autoindex.xml | 1 + .../balloon-device-auto.xml | 1 + .../balloon-device-period.xml | 1 + .../bios-nvram-os-interleave.xml | 1 + tests/qemuxml2xmloutdata/bios-nvram.xml | 1 + .../blkdeviotune.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/blkiotune-device.xml | 1 + tests/qemuxml2xmloutdata/blkiotune.xml | 1 + tests/qemuxml2xmloutdata/boot-cdrom.xml | 1 + tests/qemuxml2xmloutdata/boot-floppy.xml | 1 + .../boot-menu-disable-with-timeout.xml | 1 + .../qemuxml2xmloutdata/boot-menu-disable.xml | 1 + .../boot-menu-enable-with-timeout.xml | 1 + tests/qemuxml2xmloutdata/boot-multi.xml | 1 + tests/qemuxml2xmloutdata/boot-network.xml | 1 + tests/qemuxml2xmloutdata/boot-order.xml | 1 + tests/qemuxml2xmloutdata/channel-guestfwd.xml | 1 + .../channel-unix-source-path-active.xml | 1 + .../channel-unix-source-path-inactive.xml | 1 + .../channel-virtio-auto.xml | 1 + .../channel-virtio-state-active.xml | 1 + .../channel-virtio-state-inactive.xml | 1 + tests/qemuxml2xmloutdata/channel-virtio.xml | 1 + tests/qemuxml2xmloutdata/chardev-label.xml | 1 + tests/qemuxml2xmloutdata/clock-catchup.xml | 1 + tests/qemuxml2xmloutdata/clock-localtime.xml | 1 + .../clock-timer-hyperv-rtc.xml | 1 + tests/qemuxml2xmloutdata/clock-utc.xml | 1 + .../console-compat-auto.xml | 1 + tests/qemuxml2xmloutdata/console-compat.xml | 1 + tests/qemuxml2xmloutdata/console-compat2.xml | 1 + .../console-virtio-many.xml | 1 + tests/qemuxml2xmloutdata/console-virtio.xml | 1 + .../controller-usb-order.xml | 1 + .../controller-virtio-scsi.xml | 1 + ...pu-Icelake-Server-pconfig.x86_64-3.1.0.xml | 1 + ...u-Icelake-Server-pconfig.x86_64-latest.xml | 1 + .../cpu-check-default-none.xml | 1 + .../cpu-check-default-none2.xml | 1 + .../cpu-check-default-partial.xml | 1 + .../cpu-check-default-partial2.xml | 1 + tests/qemuxml2xmloutdata/cpu-check-full.xml | 1 + tests/qemuxml2xmloutdata/cpu-check-none.xml | 1 + .../qemuxml2xmloutdata/cpu-check-partial.xml | 1 + tests/qemuxml2xmloutdata/cpu-empty.xml | 1 + tests/qemuxml2xmloutdata/cpu-eoi-disabled.xml | 1 + tests/qemuxml2xmloutdata/cpu-eoi-enabled.xml | 1 + .../qemuxml2xmloutdata/cpu-host-kvmclock.xml | 1 + .../cpu-host-model-features.xml | 1 + .../cpu-host-model-vendor.xml | 1 + .../cpu-host-passthrough-features.xml | 1 + tests/qemuxml2xmloutdata/cpu-kvmclock.xml | 1 + .../qemuxml2xmloutdata/cpu-numa-disjoint.xml | 1 + .../cpu-numa-disordered.xml | 1 + .../qemuxml2xmloutdata/cpu-numa-memshared.xml | 1 + .../cpu-numa-no-memory-element.xml | 1 + tests/qemuxml2xmloutdata/cpu-numa1.xml | 1 + tests/qemuxml2xmloutdata/cpu-numa2.xml | 1 + .../cputune-cpuset-big-id.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/cputune-iothreads.xml | 1 + .../cputune-iothreadsched-zeropriority.xml | 1 + .../cputune-iothreadsched.xml | 1 + tests/qemuxml2xmloutdata/cputune-numatune.xml | 1 + .../cputune-zero-shares.xml | 1 + tests/qemuxml2xmloutdata/cputune.xml | 1 + .../default-kvm-host-arch.xml | 1 + .../default-qemu-host-arch.xml | 1 + ...ault-video-type-aarch64.aarch64-latest.xml | 1 + .../default-video-type-ppc64.ppc64-latest.xml | 1 + ...ault-video-type-riscv64.riscv64-latest.xml | 1 + .../default-video-type-s390x.s390x-latest.xml | 1 + .../default-video-type-x86_64-caps-test-0.xml | 1 + .../default-video-type-x86_64-caps-test-1.xml | 1 + .../disk-active-commit-active.xml | 1 + .../disk-active-commit-inactive.xml | 1 + .../disk-aio-io_uring.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-aio.xml | 1 + .../disk-arm-virtio-sd.aarch64-latest.xml | 1 + .../disk-backing-chains-active.xml | 1 + .../disk-backing-chains-inactive.xml | 1 + .../disk-backing-chains-index-active.xml | 1 + .../disk-backing-chains-index-inactive.xml | 1 + .../disk-backing-chains-noindex.xml | 1 + tests/qemuxml2xmloutdata/disk-boot-cdrom.xml | 1 + tests/qemuxml2xmloutdata/disk-boot-disk.xml | 1 + .../disk-cache.x86_64-1.5.3.xml | 1 + .../disk-cache.x86_64-2.12.0.xml | 1 + .../disk-cache.x86_64-2.6.0.xml | 1 + .../disk-cache.x86_64-2.7.0.xml | 1 + .../disk-cache.x86_64-latest.xml | 1 + .../disk-cdrom-bus-other.xml | 1 + ...om-empty-network-invalid.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-cdrom.xml | 1 + .../qemuxml2xmloutdata/disk-copy_on_read.xml | 1 + .../disk-discard.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/disk-error-policy.xml | 1 + tests/qemuxml2xmloutdata/disk-floppy.xml | 1 + tests/qemuxml2xmloutdata/disk-fmt-qcow.xml | 1 + .../disk-metadata-cache.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/disk-mirror-active.xml | 1 + .../disk-mirror-inactive.xml | 1 + .../disk-mirror-old-active.xml | 1 + .../disk-mirror-old-inactive.xml | 1 + .../disk-network-gluster.xml | 1 + .../disk-network-http.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/disk-network-iscsi.xml | 1 + tests/qemuxml2xmloutdata/disk-network-nbd.xml | 1 + ...isk-network-nfs-inactive.x86_64-latest.xml | 1 + .../disk-network-nfs.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-network-rbd.xml | 1 + .../disk-network-sheepdog.xml | 1 + .../disk-network-source-auth.xml | 1 + .../disk-network-tlsx509-nbd.xml | 1 + .../disk-network-tlsx509-vxhs.xml | 1 + .../qemuxml2xmloutdata/disk-network-vxhs.xml | 1 + .../disk-scsi-device-auto.xml | 1 + .../qemuxml2xmloutdata/disk-scsi-disk-vpd.xml | 1 + .../disk-scsi-lun-passthrough-sgio.xml | 1 + .../disk-scsi.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/disk-serial.xml | 1 + .../disk-slices.x86_64-latest.xml | 1 + .../disk-source-pool-mode.xml | 1 + tests/qemuxml2xmloutdata/disk-source-pool.xml | 1 + tests/qemuxml2xmloutdata/disk-usb-device.xml | 1 + .../disk-vhostuser.x86_64-latest.xml | 1 + .../disk-virtio-s390-zpci.xml | 1 + tests/qemuxml2xmloutdata/disk-virtio.xml | 1 + tests/qemuxml2xmloutdata/encrypted-disk.xml | 1 + tests/qemuxml2xmloutdata/eoi-disabled.xml | 1 + tests/qemuxml2xmloutdata/eoi-enabled.xml | 1 + tests/qemuxml2xmloutdata/event_idx.xml | 1 + tests/qemuxml2xmloutdata/floppy-drive-fat.xml | 1 + .../genid-active.x86_64-latest.xml | 1 + .../genid-auto-active.x86_64-latest.xml | 1 + .../genid-auto-inactive.x86_64-latest.xml | 1 + .../genid-inactive.x86_64-latest.xml | 1 + .../graphics-listen-network.xml | 1 + .../graphics-listen-network2.xml | 1 + .../graphics-spice-auto-socket-cfg.xml | 1 + .../graphics-spice-auto-socket.xml | 1 + .../graphics-spice-compression.xml | 1 + .../graphics-spice-egl-headless.xml | 1 + .../graphics-spice-qxl-vga.xml | 1 + .../graphics-spice-socket.xml | 1 + .../graphics-spice-timeout.xml | 1 + tests/qemuxml2xmloutdata/graphics-spice.xml | 1 + .../graphics-vnc-auto-socket-cfg.xml | 1 + .../graphics-vnc-auto-socket.xml | 1 + .../graphics-vnc-egl-headless.xml | 1 + .../graphics-vnc-no-listen-attr.xml | 1 + ...ics-vnc-remove-generated-socket-active.xml | 1 + ...s-vnc-remove-generated-socket-inactive.xml | 1 + .../qemuxml2xmloutdata/graphics-vnc-sasl.xml | 1 + .../graphics-vnc-socket.xml | 1 + tests/qemuxml2xmloutdata/graphics-vnc-tls.xml | 1 + .../graphics-vnc-websocket.xml | 1 + tests/qemuxml2xmloutdata/graphics-vnc.xml | 1 + ...stdev-mdev-display-ramfb.x86_64-latest.xml | 1 + .../hostdev-mdev-display.xml | 1 + .../hostdev-mdev-precreated.xml | 1 + .../hostdev-pci-address-unassigned.xml | 1 + .../hostdev-pci-address.xml | 1 + .../hostdev-pci-multifunction.xml | 1 + .../hostdev-scsi-autogen-address.xml | 1 + .../hostdev-scsi-large-unit.xml | 1 + tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 1 + .../qemuxml2xmloutdata/hostdev-scsi-rawio.xml | 1 + .../qemuxml2xmloutdata/hostdev-scsi-sgio.xml | 1 + .../hostdev-scsi-shareable.xml | 1 + .../hostdev-scsi-vhost-scsi-ccw.xml | 1 + .../hostdev-scsi-vhost-scsi-pci.xml | 1 + .../hostdev-scsi-vhost-scsi-pcie.xml | 1 + .../hostdev-scsi-virtio-scsi.xml | 1 + .../hostdev-subsys-mdev-vfio-ap.xml | 1 + ...subsys-mdev-vfio-ccw-boot.s390x-latest.xml | 1 + .../hostdev-subsys-mdev-vfio-ccw.xml | 1 + .../hostdev-usb-address.xml | 1 + .../hostdev-vfio-zpci-autogenerate-fids.xml | 1 + .../hostdev-vfio-zpci-autogenerate-uids.xml | 1 + .../hostdev-vfio-zpci-autogenerate.xml | 1 + .../hostdev-vfio-zpci-boundaries.xml | 1 + .../hostdev-vfio-zpci-ccw-memballoon.xml | 1 + .../hostdev-vfio-zpci-multidomain-many.xml | 1 + .../qemuxml2xmloutdata/hostdev-vfio-zpci.xml | 1 + tests/qemuxml2xmloutdata/hostdev-vfio.xml | 1 + .../qemuxml2xmloutdata/hugepages-default.xml | 1 + .../qemuxml2xmloutdata/hugepages-nodeset.xml | 1 + .../hugepages-numa-default-2M.xml | 1 + .../hugepages-numa-nodeset-part.xml | 1 + .../hugepages-numa-nodeset.xml | 1 + tests/qemuxml2xmloutdata/hugepages-shared.xml | 1 + tests/qemuxml2xmloutdata/hyperv-off.xml | 1 + tests/qemuxml2xmloutdata/hyperv-panic.xml | 1 + .../hyperv-stimer-direct.xml | 1 + tests/qemuxml2xmloutdata/hyperv.xml | 1 + tests/qemuxml2xmloutdata/input-usbmouse.xml | 1 + tests/qemuxml2xmloutdata/input-usbtablet.xml | 1 + tests/qemuxml2xmloutdata/input-virtio-ccw.xml | 1 + .../intel-iommu.x86_64-2.6.0.xml | 1 + tests/qemuxml2xmloutdata/interface-driver.xml | 1 + tests/qemuxml2xmloutdata/interface-server.xml | 1 + .../iommu-smmuv3.aarch64-latest.xml | 1 + .../iothreads-disk-virtio-ccw.xml | 1 + tests/qemuxml2xmloutdata/iothreads-disk.xml | 1 + .../iothreads-ids-partial.xml | 1 + tests/qemuxml2xmloutdata/iothreads-ids.xml | 1 + .../iothreads-virtio-scsi-ccw.xml | 1 + .../iothreads-virtio-scsi-pci.xml | 1 + tests/qemuxml2xmloutdata/iothreads.xml | 1 + tests/qemuxml2xmloutdata/kvm-features-off.xml | 1 + tests/qemuxml2xmloutdata/kvm-features.xml | 1 + tests/qemuxml2xmloutdata/kvmclock.xml | 1 + tests/qemuxml2xmloutdata/lease.xml | 1 + .../luks-disks-source-qcow2.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/luks-disks-source.xml | 1 + .../mach-virt-console-virtio.xml | 1 + .../mach-virt-serial-compat.xml | 1 + .../mach-virt-serial-pci.xml | 1 + .../mach-virt-serial-usb.xml | 1 + tests/qemuxml2xmloutdata/machine-core-off.xml | 1 + tests/qemuxml2xmloutdata/machine-core-on.xml | 1 + ...hine-loadparm-multiple-disks-nets-s390.xml | 1 + .../memory-hotplug-dimm.xml | 1 + ...memory-hotplug-nvdimm-ppc64-abi-update.xml | 1 + .../memory-hotplug-nvdimm-ppc64.xml | 1 + ...memory-hotplug-ppc64-nonuma-abi-update.xml | 1 + tests/qemuxml2xmloutdata/memory-hotplug.xml | 1 + .../qemuxml2xmloutdata/memorybacking-set.xml | 1 + .../memorybacking-unset.xml | 1 + .../qemuxml2xmloutdata/memtune-unlimited.xml | 1 + tests/qemuxml2xmloutdata/memtune.xml | 1 + .../qemuxml2xmloutdata/metadata-duplicate.xml | 1 + tests/qemuxml2xmloutdata/metadata.xml | 1 + tests/qemuxml2xmloutdata/migrate.xml | 1 + tests/qemuxml2xmloutdata/minimal.xml | 1 + tests/qemuxml2xmloutdata/misc-acpi.xml | 1 + tests/qemuxml2xmloutdata/misc-disable-s3.xml | 1 + .../misc-disable-suspends.xml | 1 + tests/qemuxml2xmloutdata/misc-enable-s4.xml | 1 + tests/qemuxml2xmloutdata/misc-no-reboot.xml | 1 + tests/qemuxml2xmloutdata/misc-uuid.xml | 1 + tests/qemuxml2xmloutdata/net-bandwidth.xml | 1 + tests/qemuxml2xmloutdata/net-bandwidth2.xml | 1 + tests/qemuxml2xmloutdata/net-coalesce.xml | 1 + tests/qemuxml2xmloutdata/net-eth-hostip.xml | 1 + tests/qemuxml2xmloutdata/net-eth-ifname.xml | 1 + .../net-eth-unmanaged-tap.xml | 1 + tests/qemuxml2xmloutdata/net-eth.xml | 1 + .../net-hostdev-bootorder.xml | 1 + tests/qemuxml2xmloutdata/net-hostdev-vfio.xml | 1 + tests/qemuxml2xmloutdata/net-hostdev.xml | 1 + .../net-isolated-port.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/net-many-models.xml | 1 + tests/qemuxml2xmloutdata/net-midonet.xml | 1 + tests/qemuxml2xmloutdata/net-mtu.xml | 1 + tests/qemuxml2xmloutdata/net-openvswitch.xml | 1 + tests/qemuxml2xmloutdata/net-udp.xml | 1 + tests/qemuxml2xmloutdata/net-user.xml | 1 + tests/qemuxml2xmloutdata/net-vdpa.xml | 1 + tests/qemuxml2xmloutdata/net-vhostuser.xml | 1 + .../qemuxml2xmloutdata/net-virtio-device.xml | 1 + .../net-virtio-disable-offloads.xml | 1 + .../net-virtio-network-portgroup.xml | 1 + .../net-virtio-rxtxqueuesize.xml | 1 + .../net-virtio-teaming-network.xml | 1 + .../qemuxml2xmloutdata/net-virtio-teaming.xml | 1 + tests/qemuxml2xmloutdata/net-virtio.xml | 1 + tests/qemuxml2xmloutdata/nosharepages.xml | 1 + .../numad-auto-memory-vcpu-cpuset.xml | 1 + ...to-memory-vcpu-no-cpuset-and-placement.xml | 1 + .../numad-auto-vcpu-no-numatune.xml | 1 + .../numad-static-vcpu-no-numatune.xml | 1 + .../numatune-auto-prefer.xml | 1 + .../qemuxml2xmloutdata/numatune-distances.xml | 1 + .../numatune-memnode-no-memory.xml | 1 + tests/qemuxml2xmloutdata/numatune-memnode.xml | 1 + ...avcpus-topology-mismatch.x86_64-latest.xml | 1 + .../os-firmware-bios.x86_64-latest.xml | 1 + .../os-firmware-efi-secboot.x86_64-latest.xml | 1 + .../os-firmware-efi.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/panic-double.xml | 1 + tests/qemuxml2xmloutdata/panic-isa.xml | 1 + tests/qemuxml2xmloutdata/panic-no-address.xml | 1 + tests/qemuxml2xmloutdata/panic-pseries.xml | 1 + tests/qemuxml2xmloutdata/panic.xml | 1 + tests/qemuxml2xmloutdata/pci-autoadd-addr.xml | 1 + tests/qemuxml2xmloutdata/pci-autoadd-idx.xml | 1 + .../qemuxml2xmloutdata/pci-autofill-addr.xml | 1 + .../pci-bridge-many-disks.xml | 1 + tests/qemuxml2xmloutdata/pci-bridge.xml | 1 + tests/qemuxml2xmloutdata/pci-expander-bus.xml | 1 + tests/qemuxml2xmloutdata/pci-many.xml | 1 + .../pci-rom-disabled-invalid.xml | 1 + tests/qemuxml2xmloutdata/pci-rom-disabled.xml | 1 + tests/qemuxml2xmloutdata/pci-rom.xml | 1 + .../pci-serial-dev-chardev.xml | 1 + .../qemuxml2xmloutdata/pcie-expander-bus.xml | 1 + .../pcie-root-port-model-generic.xml | 1 + .../pcie-root-port-model-ioh3420.xml | 1 + ...pcie-root-port-nohotplug.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/pcie-root-port.xml | 1 + tests/qemuxml2xmloutdata/pcie-root.xml | 1 + .../pcie-switch-downstream-port.xml | 1 + .../pcie-switch-upstream-port.xml | 1 + tests/qemuxml2xmloutdata/pcihole64-gib.xml | 1 + tests/qemuxml2xmloutdata/pcihole64-none.xml | 1 + tests/qemuxml2xmloutdata/pcihole64-q35.xml | 1 + tests/qemuxml2xmloutdata/pcihole64.xml | 1 + tests/qemuxml2xmloutdata/pmu-feature-off.xml | 1 + tests/qemuxml2xmloutdata/pmu-feature.xml | 1 + ...fault-cpu-kvm-pseries-2.7.ppc64-latest.xml | 1 + ...fault-cpu-kvm-pseries-3.1.ppc64-latest.xml | 1 + ...fault-cpu-kvm-pseries-4.2.ppc64-latest.xml | 1 + ...fault-cpu-tcg-pseries-2.7.ppc64-latest.xml | 1 + ...fault-cpu-tcg-pseries-3.1.ppc64-latest.xml | 1 + ...fault-cpu-tcg-pseries-4.2.ppc64-latest.xml | 1 + .../ppc64-pseries-graphics.ppc64-latest.xml | 1 + .../ppc64-pseries-headless.ppc64-latest.xml | 1 + .../ppc64-tpmproxy-single.ppc64-latest.xml | 1 + .../ppc64-tpmproxy-with-tpm.ppc64-latest.xml | 1 + .../ppc64-usb-controller-legacy.xml | 1 + .../ppc64-usb-controller.xml | 1 + .../pseries-console-virtio.xml | 1 + .../pseries-cpu-compat-power9.xml | 1 + .../qemuxml2xmloutdata/pseries-cpu-compat.xml | 1 + .../qemuxml2xmloutdata/pseries-cpu-exact.xml | 1 + tests/qemuxml2xmloutdata/pseries-features.xml | 1 + .../qemuxml2xmloutdata/pseries-hostdevs-1.xml | 1 + .../qemuxml2xmloutdata/pseries-hostdevs-2.xml | 1 + .../qemuxml2xmloutdata/pseries-hostdevs-3.xml | 1 + .../pseries-many-buses-1.xml | 1 + .../pseries-many-buses-2.xml | 1 + .../pseries-many-devices.xml | 1 + tests/qemuxml2xmloutdata/pseries-nvram.xml | 1 + .../pseries-panic-missing.xml | 1 + .../pseries-panic-no-address.xml | 1 + .../pseries-phb-default-missing.xml | 1 + .../pseries-phb-numa-node.xml | 1 + .../qemuxml2xmloutdata/pseries-phb-simple.xml | 1 + .../pseries-serial-native.xml | 1 + .../qemuxml2xmloutdata/pseries-serial-pci.xml | 1 + .../qemuxml2xmloutdata/pseries-serial-usb.xml | 1 + .../pv-spinlock-disabled.xml | 1 + .../pv-spinlock-enabled.xml | 1 + .../q35-default-devices-only.xml | 1 + .../qemuxml2xmloutdata/q35-multifunction.xml | 1 + .../q35-pci-force-address.xml | 1 + tests/qemuxml2xmloutdata/q35-pcie-autoadd.xml | 1 + tests/qemuxml2xmloutdata/q35-pcie.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2-multi.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2-reorder.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2.xml | 1 + .../q35-virt-manager-basic.xml | 1 + tests/qemuxml2xmloutdata/q35-virtio-pci.xml | 1 + tests/qemuxml2xmloutdata/q35.xml | 1 + tests/qemuxml2xmloutdata/qemu-ns-no-env.xml | 1 + .../reboot-timeout-disabled.xml | 1 + .../reboot-timeout-enabled.xml | 1 + tests/qemuxml2xmloutdata/restore-v2.xml | 1 + .../riscv64-virt-graphics.riscv64-latest.xml | 1 + .../riscv64-virt-headless.riscv64-latest.xml | 1 + tests/qemuxml2xmloutdata/riscv64-virt-pci.xml | 1 + tests/qemuxml2xmloutdata/riscv64-virt.xml | 1 + ...lt-cpu-kvm-ccw-virtio-2.7.s390x-latest.xml | 1 + ...lt-cpu-kvm-ccw-virtio-4.2.s390x-latest.xml | 1 + ...lt-cpu-tcg-ccw-virtio-2.7.s390x-latest.xml | 1 + ...lt-cpu-tcg-ccw-virtio-4.2.s390x-latest.xml | 1 + .../s390-defaultconsole.xml | 1 + .../qemuxml2xmloutdata/s390-panic-missing.xml | 1 + .../s390-panic-no-address.xml | 1 + tests/qemuxml2xmloutdata/s390-panic.xml | 1 + tests/qemuxml2xmloutdata/s390-serial-2.xml | 1 + .../s390-serial-console.xml | 1 + tests/qemuxml2xmloutdata/s390-serial.xml | 1 + .../s390x-ccw-graphics.s390x-latest.xml | 1 + .../s390x-ccw-headless.s390x-latest.xml | 1 + .../qemuxml2xmloutdata/seclabel-dac-none.xml | 1 + .../seclabel-device-multiple.xml | 1 + .../seclabel-dynamic-baselabel-inactive.xml | 1 + .../seclabel-dynamic-labelskip-inactive.xml | 1 + ...seclabel-dynamic-none-relabel-inactive.xml | 1 + .../seclabel-dynamic-none.xml | 1 + .../seclabel-dynamic-override-inactive.xml | 1 + .../seclabel-dynamic-relabel-inactive.xml | 1 + tests/qemuxml2xmloutdata/seclabel-none.xml | 1 + .../seclabel-static-labelskip-active.xml | 1 + .../seclabel-static-labelskip-inactive.xml | 1 + tests/qemuxml2xmloutdata/seclabel-static.xml | 1 + .../serial-spiceport-nospice.xml | 1 + tests/qemuxml2xmloutdata/serial-spiceport.xml | 1 + .../serial-target-port-auto.xml | 1 + .../serial-tcp-tlsx509-chardev.xml | 1 + .../shmem-plain-doorbell.xml | 1 + tests/qemuxml2xmloutdata/shmem.xml | 1 + .../smartcard-controller.xml | 1 + .../smartcard-host-certificates-database.xml | 1 + .../smartcard-host-certificates.xml | 1 + tests/qemuxml2xmloutdata/smartcard-host.xml | 1 + .../smartcard-passthrough-spicevmc.xml | 1 + .../smartcard-passthrough-tcp.xml | 1 + .../smbios-multiple-type2.xml | 1 + tests/qemuxml2xmloutdata/smbios.xml | 1 + tests/qemuxml2xmloutdata/smp.xml | 1 + tests/qemuxml2xmloutdata/sound-device.xml | 1 + tests/qemuxml2xmloutdata/sound.xml | 1 + .../tap-vhost-incorrect.xml | 1 + tests/qemuxml2xmloutdata/tap-vhost.xml | 1 + .../tpm-emulator-tpm2-enc.x86_64-latest.xml | 1 + ...tpm-emulator-tpm2-pstate.x86_64-latest.xml | 1 + .../tpm-emulator-tpm2.x86_64-latest.xml | 1 + .../tpm-emulator.x86_64-latest.xml | 1 + .../tpm-passthrough-crb.x86_64-latest.xml | 1 + .../tpm-passthrough.x86_64-latest.xml | 1 + .../qemuxml2xmloutdata/tseg-explicit-size.xml | 1 + .../usb-controller-default-q35.xml | 1 + .../usb-controller-explicit-q35.xml | 1 + tests/qemuxml2xmloutdata/usb-controller.xml | 1 + .../qemuxml2xmloutdata/usb-ich9-ehci-addr.xml | 1 + tests/qemuxml2xmloutdata/usb-none.xml | 1 + .../usb-piix3-controller.xml | 1 + tests/qemuxml2xmloutdata/usb-port-missing.xml | 1 + .../usb-redir-filter-version.xml | 1 + tests/qemuxml2xmloutdata/usb-redir-filter.xml | 1 + tests/qemuxml2xmloutdata/usb-redir.xml | 1 + tests/qemuxml2xmloutdata/vhost-vsock-auto.xml | 1 + .../vhost-vsock-ccw-auto.xml | 1 + tests/qemuxml2xmloutdata/vhost_queues.xml | 1 + .../video-device-pciaddr-default.xml | 1 + .../qemuxml2xmloutdata/video-none-device.xml | 1 + tests/qemuxml2xmloutdata/video-qxl-heads.xml | 1 + .../qemuxml2xmloutdata/video-qxl-noheads.xml | 1 + .../video-virtio-gpu-ccw-auto.xml | 1 + .../video-virtio-gpu-ccw.xml | 1 + .../video-virtio-gpu-device.xml | 1 + .../video-virtio-gpu-secondary.xml | 1 + .../video-virtio-gpu-spice-gl.xml | 1 + .../video-virtio-gpu-virgl.xml | 1 + .../virtio-9p-createmode.x86_64-latest.xml | 1 + .../virtio-9p-multidevs.x86_64-latest.xml | 1 + .../virtio-input-passthrough.xml | 1 + tests/qemuxml2xmloutdata/virtio-input.xml | 1 + tests/qemuxml2xmloutdata/virtio-lun.xml | 1 + .../virtio-non-transitional.x86_64-latest.xml | 1 + .../virtio-rng-builtin.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/virtio-rng-egd.xml | 1 + .../qemuxml2xmloutdata/virtio-rng-random.xml | 1 + .../virtio-transitional.x86_64-latest.xml | 1 + tests/qemuxml2xmloutdata/vmcoreinfo.xml | 1 + tests/qemuxml2xmloutdata/watchdog.xml | 1 + ...4-default-cpu-kvm-pc-4.2.x86_64-latest.xml | 1 + ...-default-cpu-kvm-q35-4.2.x86_64-latest.xml | 1 + ...4-default-cpu-tcg-pc-4.2.x86_64-latest.xml | 1 + ...-default-cpu-tcg-q35-4.2.x86_64-latest.xml | 1 + .../x86_64-pc-graphics.x86_64-latest.xml | 1 + .../x86_64-pc-headless.x86_64-latest.xml | 1 + .../x86_64-q35-graphics.x86_64-latest.xml | 1 + .../x86_64-q35-headless.x86_64-latest.xml | 1 + tests/qemuxml2xmltest.c | 54 ++ 957 files changed, 6887 insertions(+), 341 deletions(-) create mode 100644 tests/qemuxml2argvdata/audio-alsa-best.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-best.xml create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.err create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-full.xml create mode 100644 tests/qemuxml2argvdata/audio-alsa-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-alsa-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-alsa-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-best.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-best.x86_64-latest= .args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-best.xml create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.err create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.x86_64-latest= .args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-full.xml create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-minimal.x86_64-lat= est.args create mode 100644 tests/qemuxml2argvdata/audio-coreaudio-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-default-nographics.args create mode 100644 tests/qemuxml2argvdata/audio-default-nographics.x86_64-la= test.args create mode 100644 tests/qemuxml2argvdata/audio-default-nographics.xml create mode 100644 tests/qemuxml2argvdata/audio-default-sdl.args create mode 100644 tests/qemuxml2argvdata/audio-default-sdl.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-default-sdl.xml create mode 100644 tests/qemuxml2argvdata/audio-default-spice.args create mode 100644 tests/qemuxml2argvdata/audio-default-spice.x86_64-latest.= args create mode 100644 tests/qemuxml2argvdata/audio-default-spice.xml create mode 100644 tests/qemuxml2argvdata/audio-default-vnc.args create mode 100644 tests/qemuxml2argvdata/audio-default-vnc.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-default-vnc.xml create mode 100644 tests/qemuxml2argvdata/audio-file-best.args create mode 100644 tests/qemuxml2argvdata/audio-file-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-file-best.xml create mode 100644 tests/qemuxml2argvdata/audio-file-full.args create mode 100644 tests/qemuxml2argvdata/audio-file-full.err create mode 100644 tests/qemuxml2argvdata/audio-file-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-file-full.xml create mode 100644 tests/qemuxml2argvdata/audio-file-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-file-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-file-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-jack-full.err create mode 100644 tests/qemuxml2argvdata/audio-jack-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-jack-full.xml create mode 100644 tests/qemuxml2argvdata/audio-jack-minimal.err create mode 100644 tests/qemuxml2argvdata/audio-jack-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-jack-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-many-backends.err create mode 100644 tests/qemuxml2argvdata/audio-many-backends.x86_64-latest.= args create mode 100644 tests/qemuxml2argvdata/audio-many-backends.xml create mode 100644 tests/qemuxml2argvdata/audio-none-best.args create mode 100644 tests/qemuxml2argvdata/audio-none-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-none-best.xml create mode 100644 tests/qemuxml2argvdata/audio-none-full.args create mode 100644 tests/qemuxml2argvdata/audio-none-full.err create mode 100644 tests/qemuxml2argvdata/audio-none-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-none-full.xml create mode 100644 tests/qemuxml2argvdata/audio-none-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-none-minimal.x86_64-latest.a= rgs create mode 100644 tests/qemuxml2argvdata/audio-none-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-oss-best.args create mode 100644 tests/qemuxml2argvdata/audio-oss-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-oss-best.xml create mode 100644 tests/qemuxml2argvdata/audio-oss-full.args create mode 100644 tests/qemuxml2argvdata/audio-oss-full.err create mode 100644 tests/qemuxml2argvdata/audio-oss-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-oss-full.xml create mode 100644 tests/qemuxml2argvdata/audio-oss-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-oss-minimal.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-oss-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-best.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-best.x86_64-lates= t.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-best.xml create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.err create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.x86_64-lates= t.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-full.xml create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-minimal.x86_64-la= test.args create mode 100644 tests/qemuxml2argvdata/audio-pulseaudio-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-sdl-best.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-best.xml create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.err create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-full.xml create mode 100644 tests/qemuxml2argvdata/audio-sdl-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-sdl-minimal.x86_64-latest.ar= gs create mode 100644 tests/qemuxml2argvdata/audio-sdl-minimal.xml create mode 100644 tests/qemuxml2argvdata/audio-spice-best.args create mode 100644 tests/qemuxml2argvdata/audio-spice-best.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-spice-best.xml create mode 100644 tests/qemuxml2argvdata/audio-spice-full.args create mode 100644 tests/qemuxml2argvdata/audio-spice-full.err create mode 100644 tests/qemuxml2argvdata/audio-spice-full.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/audio-spice-full.xml create mode 100644 tests/qemuxml2argvdata/audio-spice-minimal.args create mode 100644 tests/qemuxml2argvdata/audio-spice-minimal.x86_64-latest.= args create mode 100644 tests/qemuxml2argvdata/audio-spice-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-alsa-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-alsa-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-alsa-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-coreaudio-minimal.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-nographics.x86_64-= latest.xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-nographics.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-sdl.x86_64-latest.= xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-sdl.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-spice.x86_64-lates= t.xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-spice.xml create mode 100644 tests/qemuxml2xmloutdata/audio-default-vnc.x86_64-latest.= xml create mode 120000 tests/qemuxml2xmloutdata/audio-default-vnc.xml create mode 120000 tests/qemuxml2xmloutdata/audio-file-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-file-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-file-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-jack-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-many-backends.x86_64-lates= t.xml create mode 120000 tests/qemuxml2xmloutdata/audio-none-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-none-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-none-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-oss-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-oss-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-oss-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-pulseaudio-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-sdl-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-sdl-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-sdl-minimal.xml create mode 120000 tests/qemuxml2xmloutdata/audio-spice-best.xml create mode 120000 tests/qemuxml2xmloutdata/audio-spice-full.xml create mode 120000 tests/qemuxml2xmloutdata/audio-spice-minimal.xml --=20 2.29.2

3 25

[PATCH v4 0/4] Drop deprecated floppy config & bogus -drive if=T
by Markus Armbruster 12 Mar '21

12 Mar '21

v4: * PATCH 3: Move a declaration into a loop [Richard] * PATCH 4: Drop a superfluous call to drive_check_orphaned() [Daniel], fix comments [John] v3: * PATCH 1: New [Daniel] v2: * Rebased, straightforward conflict with commit f5d33dd51f "hw/block/fdc: Remove the check_media_rate property" resolved * PATCH 2: Commit message fixed [Kevin] Markus Armbruster (4): docs/system/deprecated: Fix note on fdc drive properties fdc: Drop deprecated floppy configuration fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() blockdev: Drop deprecated bogus -drive interface type docs/system/deprecated.rst | 33 -- docs/system/removed-features.rst | 56 +++ include/sysemu/blockdev.h | 1 - blockdev.c | 37 +- hw/block/fdc.c | 73 +--- softmmu/vl.c | 11 +- tests/qemu-iotests/172 | 31 +- tests/qemu-iotests/172.out | 562 +------------------------------ 8 files changed, 82 insertions(+), 722 deletions(-) -- 2.26.2

3 6

[PATCH] Add 'interleave' to the sub-element for video device in rng file
by Kristina Hanicova 11 Mar '21

11 Mar '21

Previously, validation of XML failed if sub-elements of video device were in different order. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1825769 Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- docs/schemas/domaincommon.rng | 216 +++++++++++++++++----------------- 1 file changed, 109 insertions(+), 107 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index f7f804adc0..e6db2f5b74 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -4009,120 +4009,122 @@ --> <define name="video"> <element name="video"> - <optional> - <element name="driver"> - <optional> - <ref name="virtioOptions"/> - </optional> - <optional> - <attribute name="name"> - <choice> - <value>qemu</value> - <value>vhostuser</value> - </choice> - </attribute> - </optional> - <optional> - <attribute name="vgaconf"> - <choice> - <value>io</value> - <value>on</value> - <value>off</value> - </choice> - </attribute> - </optional> - </element> - </optional> - <optional> - <element name="model"> - <choice> - <attribute name="type"> - <choice> - <value>vga</value> - <value>cirrus</value> - <value>vmvga</value> - <value>xen</value> - <value>vbox</value> - <value>virtio</value> - <value>gop</value> - <value>none</value> - <value>bochs</value> - <value>ramfb</value> - </choice> - </attribute> - <group> + <interleave> + <optional> + <element name="driver"> + <optional> + <ref name="virtioOptions"/> + </optional> + <optional> + <attribute name="name"> + <choice> + <value>qemu</value> + <value>vhostuser</value> + </choice> + </attribute> + </optional> + <optional> + <attribute name="vgaconf"> + <choice> + <value>io</value> + <value>on</value> + <value>off</value> + </choice> + </attribute> + </optional> + </element> + </optional> + <optional> + <element name="model"> + <choice> <attribute name="type"> - <value>qxl</value> + <choice> + <value>vga</value> + <value>cirrus</value> + <value>vmvga</value> + <value>xen</value> + <value>vbox</value> + <value>virtio</value> + <value>gop</value> + <value>none</value> + <value>bochs</value> + <value>ramfb</value> + </choice> </attribute> - <optional> - <attribute name="ram"> - <ref name="unsignedInt"/> - </attribute> - </optional> - <optional> - <attribute name="vgamem"> - <ref name="unsignedInt"/> - </attribute> - </optional> - <optional> - <attribute name="vram64"> - <ref name="unsignedInt"/> - </attribute> - </optional> - </group> - </choice> - <optional> - <attribute name="vram"> - <ref name="unsignedInt"/> - </attribute> - </optional> - <optional> - <attribute name="heads"> - <ref name="unsignedInt"/> - </attribute> - </optional> - <optional> - <attribute name="primary"> - <ref name="virYesNo"/> - </attribute> - </optional> - <optional> - <element name="acceleration"> - <optional> - <attribute name="accel3d"> - <ref name="virYesNo"/> - </attribute> - </optional> - <optional> - <attribute name="accel2d"> - <ref name="virYesNo"/> - </attribute> - </optional> - <optional> - <attribute name="rendernode"> - <ref name="absFilePath"/> + <group> + <attribute name="type"> + <value>qxl</value> </attribute> - </optional> - </element> - </optional> - <optional> - <element name="resolution"> - <attribute name="x"> + <optional> + <attribute name="ram"> + <ref name="unsignedInt"/> + </attribute> + </optional> + <optional> + <attribute name="vgamem"> + <ref name="unsignedInt"/> + </attribute> + </optional> + <optional> + <attribute name="vram64"> + <ref name="unsignedInt"/> + </attribute> + </optional> + </group> + </choice> + <optional> + <attribute name="vram"> <ref name="unsignedInt"/> </attribute> - <attribute name="y"> + </optional> + <optional> + <attribute name="heads"> <ref name="unsignedInt"/> </attribute> - </element> - </optional> - </element> - </optional> - <optional> - <ref name="alias"/> - </optional> - <optional> - <ref name="address"/> - </optional> + </optional> + <optional> + <attribute name="primary"> + <ref name="virYesNo"/> + </attribute> + </optional> + <optional> + <element name="acceleration"> + <optional> + <attribute name="accel3d"> + <ref name="virYesNo"/> + </attribute> + </optional> + <optional> + <attribute name="accel2d"> + <ref name="virYesNo"/> + </attribute> + </optional> + <optional> + <attribute name="rendernode"> + <ref name="absFilePath"/> + </attribute> + </optional> + </element> + </optional> + <optional> + <element name="resolution"> + <attribute name="x"> + <ref name="unsignedInt"/> + </attribute> + <attribute name="y"> + <ref name="unsignedInt"/> + </attribute> + </element> + </optional> + </element> + </optional> + <optional> + <ref name="alias"/> + </optional> + <optional> + <ref name="address"/> + </optional> + </interleave> </element> </define> <!-- -- 2.29.2

2 1

[libvirt PATCH] spec: Drop BuildDepends on make
by Andrea Bolognani 11 Mar '21

11 Mar '21

make is only used for the syntax-check tests, which we are explicitly skipping when building RPMs. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 1 - mingw-libvirt.spec.in | 1 - 2 files changed, 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 8d8b900fbb..f9af330186 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -266,7 +266,6 @@ BuildRequires: python3-docutils BuildRequires: gcc BuildRequires: meson >= 0.54.0 BuildRequires: ninja-build -BuildRequires: make BuildRequires: git %if 0%{?fedora} || 0%{?rhel} > 7 BuildRequires: perl-interpreter diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 0686cbaf78..288f533d52 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -54,7 +54,6 @@ BuildRequires: libxslt BuildRequires: python3 BuildRequires: perl-interpreter BuildRequires: perl(Getopt::Long) -BuildRequires: make BuildRequires: meson BuildRequires: ninja-build BuildRequires: python3-docutils -- 2.26.2

2 1

[PATCH 0/2] Properly fix backup job termination
by Peter Krempa 11 Mar '21

11 Mar '21

Peter Krempa (2): backup: Store 'apiFlags' in private section of virDomainBackupDef qemuBackupJobTerminate: Fix job termination for inactive VMs src/conf/backup_conf.h | 2 ++ src/qemu/qemu_backup.c | 33 ++++++++++++++++++--------------- src/qemu/qemu_process.c | 9 ++++++--- 3 files changed, 26 insertions(+), 18 deletions(-) -- 2.29.2

2 3

[PATCH v2 0/3] ui: add support for 'secret' object to provide VNC/SPICE passwords
by Daniel P. Berrangé 11 Mar '21

11 Mar '21

This fixes a long standing limitation of the VNC/SPICE code which was unable to securely accept passswords on the CLI, instead requiring use of separate monitor commands after startup. In v2: - Dropped patch removing ACL commands, as it will move to a bigger deprecation cleanup series - Rebased and resolved conflicts Daniel P. Berrangé (3): ui: introduce "password-secret" option for VNC servers ui: introduce "password-secret" option for SPICE server ui: deprecate "password" option for SPICE server docs/system/deprecated.rst | 8 ++++++++ qemu-options.hx | 18 ++++++++++++++++-- ui/spice-core.c | 32 ++++++++++++++++++++++++++++++-- ui/vnc.c | 23 ++++++++++++++++++++++- 4 files changed, 76 insertions(+), 5 deletions(-) -- 2.29.2

2 4

[PATCH 0/4] ui: add support for 'secret' object to provide VNC/SPICE passwords
by Daniel P. Berrangé 11 Mar '21

11 Mar '21

This fixes a long standing limitation of the VNC/SPICE code which was unable to securely accept passswords on the CLI, instead requiring use of separate monitor commands after startup. This takes the opportunity to also remove previously deprecated ACL functionality from VNC. Daniel P. Berrangé (4): ui: introduce "password-secret" option for VNC servers ui: introduce "password-secret" option for SPICE server ui: deprecate "password" option for SPICE server ui, monitor: remove deprecated VNC ACL option and HMP commands docs/system/deprecated.rst | 24 ++-- docs/system/removed-features.rst | 13 +++ hmp-commands.hx | 76 ------------- monitor/misc.c | 187 ------------------------------- qemu-options.hx | 17 ++- ui/spice-core.c | 32 +++++- ui/vnc.c | 61 ++++------ 7 files changed, 88 insertions(+), 322 deletions(-) -- 2.29.2

3 8

[PATCH 00/23] RFC: get rid of macros when dealing with block io tunes
by Nikolay Shirokovskiy 11 Mar '21

11 Mar '21

Hi, all. I started this work as adding missing parts/fixing issues/etc in block iotune code but then turned to refactoring code. We use a lot of macros in this place and if we get rid of them I belive we will have much more readable/reusable/ extendable code. Most of macros usage is for iterating over unsigned long long values. I'm talking about parsing/formating xml, converting from/to virTypedParameterPtr list etc. These places do not care about tune semantics and thus we can add tools for the said iteration. See patch [1] for the first such conversion. Patches before it partially prepare for this conversion, partially just improve code reuse and add missing parts. The work on removing macros in code handling iotunes is not finished as I wanted to get an approvement that I have taken a right direction. At the same time series shows the potential of the approach (take a look on how qemuDomainSetBlockIoTune and testDomainSetBlockIoTune are looking now!). Some places like qemuDomainSetBlockIoTuneDefaults deal with fields semantics. So we need another approach to remove macros there but it is a matter of a different RFC. Nikolay Shirokovskiy (23): qemu: pass supportGroupNameOption as expected qemu: factor out qemuValidateDomainBlkdeviotune qemu: reuse validation in qemuDomainSetBlockIoTune qemu: remove extra check for QEMU_BLOCK_IOTUNE_MAX conf: factor out virDomainBlockIoTuneValidate qemu: reuse virDomainBlockIoTuneValidate test driver: reuse virDomainBlockIoTuneValidate qemu: reset max iotune setting when needed qemu: add max iotune settings check to virDomainBlockIoTuneValidate qemu: remove iotune max checks test driver: remove iotune max checks qemu: prepare for removing qemuBlockIoTuneSetFlags qemu: use group_name instead of QEMU_BLOCK_IOTUNE_SET_GROUP_NAME qemu: remove qemuBlockIoTuneSetFlags usage in qemuDomainSetBlockIoTune qemu: remove qemuBlockIoTuneSetFlags enum completly conf: get rid of macros in virDomainDiskDefIotuneParse [1] conf: get rid of macros in virDomainDiskDefFormatIotune conf: add virDomainBlockIoTuneFromParams conf: add virDomainBlockIoTuneToEventParams qemu: qemuDomainSetBlockIoTune use functions to convert to/from params test driver: remove TEST_BLOCK_IOTUNE_MAX checks test driver: prepare to delete macros in testDomainSetBlockIoTune test driver: testDomainSetBlockIoTune: use functions to convert to/from params src/conf/domain_conf.c | 303 +++++++++++++++++++++++++++++++++-------------- src/conf/domain_conf.h | 16 +++ src/libvirt_private.syms | 3 + src/qemu/qemu_driver.c | 281 ++++++++++++------------------------------- src/qemu/qemu_validate.c | 100 +++++++++------- src/qemu/qemu_validate.h | 4 + src/test/test_driver.c | 156 ++---------------------- 7 files changed, 380 insertions(+), 483 deletions(-) -- 1.8.3.1

2 42

[PATCH v3 0/4] Drop deprecated floppy config & bogus -drive if=T
by Markus Armbruster 11 Mar '21

11 Mar '21

v3: * PATCH 1: New [Daniel] v2: * Rebased, straightforward conflict with commit f5d33dd51f "hw/block/fdc: Remove the check_media_rate property" resolved * PATCH 2: Commit message fixed [Kevin] Markus Armbruster (3): fdc: Drop deprecated floppy configuration fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() blockdev: Drop deprecated bogus -drive interface type docs/system/deprecated.rst | 33 -- docs/system/removed-features.rst | 33 ++ include/sysemu/blockdev.h | 1 - blockdev.c | 37 +- hw/block/fdc.c | 73 +--- softmmu/vl.c | 8 +- tests/qemu-iotests/172 | 31 +- tests/qemu-iotests/172.out | 562 +------------------------------ 8 files changed, 59 insertions(+), 719 deletions(-) -- 2.26.2

4 13

[PATCH v2 00/12] qemu: Prepare for QAPIfied object-add
by Peter Krempa 10 Mar '21

10 Mar '21

QEMU plans to QAPIfy object add. This series prepares for the API change (drop of 'props' wrapper for the object) and adds testing based on our qemuxml2argv test data which forces the output to JSON and validates it agains the schema. Based on Kevin's qemu patches: https://listman.redhat.com/archives/libvir-list/2021-February/msg01168.html Last patch forces more files to be processed and as the summary suggest will not be pushed. The patch updating qemucapabilitiesdata will be updated after Kevin's patches hit upstream repo. Peter Krempa (12): qemu: command: Generate commandline of 'masterKey0' secret via JSON qemu: command: Generate commandline of 'sev0' sev-guest object via JSON qemu: command: Generate commandline of iothread objects JSON qemu: capabilities: Introduce QEMU_CAPS_OBJECT_QAPIFIED tests: qemuxml2argv: Validate generation of JSON props for object-add qemu: command: Introduce raw JSON passthrough for '-object' for testing qemu: monitor: Make wrapping of 'props' of 'object-add' optional qemuMonitorCreateObjectPropsWrap: Open-code in qemuBuildMemoryBackendProps qemu: monitor: Don't add 'props' wrapper if qemu has QEMU_CAPS_OBJECT_QAPIFIED qemumonitorjsontest: Remove bomb guarding object-add tests: qemucapabilities: Update qemu caps for object-add qapification [DON'T PUSH] Force-check all configs with latest capabilities src/qemu/qemu_capabilities.c | 4 + src/qemu/qemu_capabilities.h | 3 + src/qemu/qemu_command.c | 326 +- src/qemu/qemu_monitor.c | 78 +- src/qemu/qemu_monitor.h | 4 - src/util/virqemu.c | 48 +- src/util/virqemu.h | 3 +- .../caps_6.0.0.x86_64.replies | 3238 ++++++++++++----- .../caps_6.0.0.x86_64.xml | 83 +- tests/qemumonitorjsontest.c | 14 - ...v-missing-platform-info.x86_64-2.12.0.args | 2 +- .../launch-security-sev.x86_64-2.12.0.args | 2 +- tests/qemuxml2argvtest.c | 24 +- 13 files changed, 2775 insertions(+), 1054 deletions(-) -- 2.29.2

2 18

[PATCH] XML validate that 'ramfb' has no address
by Kristina Hanicova 10 Mar '21

10 Mar '21

With this, XML fails if config video type 'ramfb' contains address, since address is not supported for 'ramfb' video devices. Previously it didn't raise error. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1891416 Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/conf/domain_validate.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index b4e09e21fe..c9c677ddf5 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -151,6 +151,14 @@ virDomainVideoDefValidate(const virDomainVideoDef *video, } } + if (video->type == VIR_DOMAIN_VIDEO_TYPE_RAMFB) { + if (video->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("address not supported for video type ramfb")); + return -1; + } + } + return 0; } -- 2.29.2

2 1

[PATCH] virQEMUCapsInitQMPArch: Refactor cleanup
by Yi Li 10 Mar '21

10 Mar '21

Switch to using the 'g_auto*' helpers. Signed-off-by: Yi Li <yili(a)winhong.com> --- src/qemu/qemu_capabilities.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 790375ac38..447cf77875 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -5044,23 +5044,18 @@ static int virQEMUCapsInitQMPArch(virQEMUCapsPtr qemuCaps, qemuMonitorPtr mon) { - char *archstr = NULL; - int ret = -1; + g_autofree char *archstr = NULL; if (!(archstr = qemuMonitorGetTargetArch(mon))) - goto cleanup; + return -1; if ((qemuCaps->arch = virQEMUCapsArchFromString(archstr)) == VIR_ARCH_NONE) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unknown QEMU arch %s"), archstr); - goto cleanup; + return -1; } - ret = 0; - - cleanup: - VIR_FREE(archstr); - return ret; + return 0; } -- 2.25.3

2 1

[PATCH 0/4] Discourage use of some GLib functions
by Michal Privoznik 10 Mar '21

10 Mar '21

See 4/4 for the list and explanation. Michal Prívozník (4): qemu_shim: Replace g_file_get_contents() with virFileReadAll() virutil: Do not use g_get_host_name() to obtain hostname syntax-check: Update list of gethostname exceptions docs: Discourage use of some glib functions build-aux/syntax-check.mk | 2 +- docs/glib-adoption.rst | 17 +++++++++++++++++ src/qemu/qemu_shim.c | 18 +++++++++++------- src/util/virutil.c | 12 +++++++++--- 4 files changed, 38 insertions(+), 11 deletions(-) -- 2.26.2

3 8

[PATCH 00/16] Improve virStrcpy and remove virStrncpy
by Peter Krempa 10 Mar '21

10 Mar '21

Peter Krempa (16): util: virstring: Always copy string in virStrcpy virProcessRunInForkHelper: Use virStrcpyStatic for static buffers sanlock: Use virStrcpy instead of virStrncpy virDevMapperGetTargetsImpl: Use virStrcpy instead of virStrncpy virFileLoopDeviceAssociate: Use virStrcpy instead of virStrncpy xenParseXMDisk: Replace g_new + virStrncpy by g_strndup test_driver: Rewrite testBuildFilename xenParseVif: Refactor parser xenParseSxprSound: Refactor parsing of model list openvzReadNetworkConf: Rework parser xenParseXLChannel: Use g_strndup instead of virStrndup xenParseXLUSBController: Avoid use of virStrndup xenParseXLUSB: Rewrite to avoid virStrncpy virNetLibsshAuthenticatePrivkeyCb: Use g_autofree for 'actual_prompt' virNetLibsshAuthenticatePrivkeyCb: Use virStrcpy instead of virStrncpy util: virstring: Remove virStrncpy docs/coding-style.rst | 13 --- src/libvirt_private.syms | 1 - src/libxl/xen_common.c | 182 +++++++++++------------------- src/libxl/xen_xl.c | 84 ++++---------- src/libxl/xen_xm.c | 9 +- src/locking/lock_driver_sanlock.c | 4 +- src/openvz/openvz_conf.c | 77 +++++-------- src/rpc/virnetlibsshsession.c | 17 +-- src/test/test_driver.c | 35 +----- src/util/virdevmapper.c | 2 +- src/util/virfile.c | 3 +- src/util/virprocess.c | 8 +- src/util/virstring.c | 54 +-------- src/util/virstring.h | 5 +- 14 files changed, 137 insertions(+), 357 deletions(-) -- 2.29.2

2 33

RFC: do we want/need the "Ptr" typedefs for internal code ?
by Daniel P. Berrangé 10 Mar '21

10 Mar '21

One of the conventions we have had since the early days of libvirt is that every struct typedef, has a corresponding "Ptr" typedef too. For example typedef struct _virDomainDef virDomainDef; typedef virDomainDef *virDomainDefPtr; Periodically someone has questioned what the purpose of these Ptr typedefs is, and we've not had an compelling answer, other than that's what we've always done. There are a few things that make me question the status quo - If we want a const pointer, we can't use const virDomainDefPtr def because that expands to "struct _virDomainDef * const", which is not what we need semantically. Instead we must write const virDomainDef *def It is not at all obvious why these two are different, but none the less they are, which is confusing to contributors To me this a compelling reason to consider the "Ptr" typedefs a waste of time, if not actively harmful. Please don't suggest adding virDomainDefConstPtr too ! - Writing 'virDomainDefPtr' is actually two characters more typing than 'virDomainDef *'. IOW these "Ptr" typedefs aren't saving us time when writing code. - This convention of having "Ptr" typedefs is atypical among C projects I've worked on. Anything that is peculiar to libvirt is another item that new contributors need to learn, so has a cost to the project that must be weighed against its benefit. We can't do anything about the use "Ptr" in the include/ files because that is public ABI. We can potentially eliminate "Ptr" types everywhere else in the codebase, even the src/libvirt*.c files corresponding to the public includes. Does anyone have suggestions for how these "Ptr" typedefs are benefiting libvirt ? Would anyone miss them ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

7 10

[PATCH 0/2] fix crash on invalid construction of a gvariant
by Peter Krempa 10 Mar '21

10 Mar '21

Peter Krempa (2): virSystemdCreateMachine: Use proper format string for uint64_t when constructing gvariant virsystemdtest: Call at least one virSystemdCreateMachine with 'maxthreads' > 0 src/util/virsystemd.c | 5 +++-- tests/virsystemdtest.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) -- 2.29.2

2 3

Libvirt has been accepted into GSoC 2021
by Michal Privoznik 10 Mar '21

10 Mar '21

Dear list, let me share great news: just like in the past years, libvirt is going to be part of Google Summer of Code also this year [1]. We can expect interested students to show up and discuss possible projects to work on. However, there are some changes made to this year's run [2]: 1) Smaller projects - with everything going on one can hardly expect students to commit to 350 hours of coding over three months. This is now reduced to 175 hours over 10 weeks, 2) More elligible students - now even PhD students and licensed coding school students can apply, 2) Halved stipends - since the amount of work is halved, so are the stipends, 3) Two evaluations - again, shorted time period requires less evaluations. Happy hacking, Michal 1: https://summerofcode.withgoogle.com/organizations/5771368592834560/ 2: https://opensource.googleblog.com/2020/10/google-summer-of-code-2021-is-bri…

1 0

[PULL 05/17] utils: Deprecate hex-with-suffix sizes
by Eric Blake 09 Mar '21

09 Mar '21

Supporting '0x20M' looks odd, particularly since we have a 'B' suffix that is ambiguous for bytes, as well as a less-frequently-used 'E' suffix for extremely large exibytes. In practice, people using hex inputs are specifying values in bytes (and would have written 0x2000000, or possibly relied on default_suffix in the case of qemu_strtosz_MiB), and the use of scaling suffixes makes the most sense for inputs in decimal (where the user would write 32M). But rather than outright dropping support for hex-with-suffix, let's follow our deprecation policy. Sadly, since qemu_strtosz() does not have an Err** parameter, and plumbing that in would be a much larger task, we instead go with just directly emitting the deprecation warning to stderr. Signed-off-by: Eric Blake <eblake(a)redhat.com> Message-Id: <20210211204438.1184395-4-eblake(a)redhat.com> Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/system/deprecated.rst | 8 ++++++++ util/cutils.c | 10 +++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index cfabe6984677..ecff6bf8c633 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -166,6 +166,14 @@ Using ``-M kernel-irqchip=off`` with x86 machine types that include a local APIC is deprecated. The ``split`` setting is supported, as is using ``-M kernel-irqchip=off`` with the ISA PC machine type. +hexadecimal sizes with scaling multipliers (since 6.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Input parameters that take a size value should only use a size suffix +(such as 'k' or 'M') when the base is written in decimal, and not when +the value is hexadecimal. That is, '0x20M' is deprecated, and should +be written either as '32M' or as '0x2000000'. + QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/util/cutils.c b/util/cutils.c index 189a184859c0..d89a40a8c325 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -250,6 +250,9 @@ static int64_t suffix_mul(char suffix, int64_t unit) * fractional portion is truncated to byte * - 0x7fEE - hexadecimal, unit determined by @default_suffix * + * The following cause a deprecation warning, and may be removed in the future + * - 0xabc{kKmMgGtTpP} - hex with scaling suffix + * * The following are intentionally not supported * - octal, such as 08 * - fractional hex, such as 0x1.8 @@ -272,7 +275,7 @@ static int do_strtosz(const char *nptr, const char **end, int retval; const char *endptr, *f; unsigned char c; - bool mul_required = false; + bool mul_required = false, hex = false; uint64_t val; int64_t mul; double fraction = 0.0; @@ -298,6 +301,7 @@ static int do_strtosz(const char *nptr, const char **end, retval = -EINVAL; goto out; } + hex = true; } else if (*endptr == '.') { /* * Input looks like a fraction. Make sure even 1.k works @@ -320,6 +324,10 @@ static int do_strtosz(const char *nptr, const char **end, c = *endptr; mul = suffix_mul(c, unit); if (mul > 0) { + if (hex) { + warn_report("Using a multiplier suffix on hex numbers " + "is deprecated: %s", nptr); + } endptr++; } else { mul = suffix_mul(default_suffix, unit); -- 2.30.1

1 0

[PATCH v4 0/1] qemu: add per-vcpu delay stats
by Aleksei Zakharov 09 Mar '21

09 Mar '21

Fixed since v3: - Report error if cannot read stats. - Don't fail if cannot read stats. - Add documentation. - Drop unnecessary checks. - Don't delete unrelated whitespace. - Make sure schedstat file is closed before returning. Fixed since v2: - Close schedstat file after use. Fixes since v1: - Collect per-vcpu stats. - Coding style errors - Use glib functions. Aleksei Zakharov (1): qemu: add per-vcpu delay stats docs/manpages/virsh.rst | 4 ++++ src/libvirt-domain.c | 4 ++++ src/qemu/qemu_driver.c | 44 +++++++++++++++++++++++++++++++++++++++-- 3 files changed, 50 insertions(+), 2 deletions(-) -- 2.17.1

3 4

[libvirt PATCH 00/17] qemu: Implement external limit manager feature
by Andrea Bolognani 09 Mar '21

09 Mar '21

This feature has been requested by KubeVirt developers and will make it possible for them to make some VFIO-related features, such as migration and hotplug, work correctly. https://bugzilla.redhat.com/show_bug.cgi?id=1916346 The first part of the series, especially the first 9 patches, is preparation work: it addresses a few annoying issues with our APIs that deal with process limits, and makes them all nice, consistent and easy to reason about while moving policy code from the generic code to the QEMU driver where it belongs. Andrea Bolognani (17): util: Document limit-related functions util: Simplify stubs util: Always pass a pid to virProcessSetMax*() util: Introduce virProcess{Get,Set}Limit() qemu: Make some minor tweaks qemu: Set all limits at the same time util: Have virCommand remember whether limits are set qemu: Set limits only when explicitly asked to do so util: Don't special-case setting a limit to zero conf: Rename original_memlock -> originalMemlock tests: Mock virProcessGetMaxMemLock() util: Try to get limits from /proc qemu: Don't ignore virProcessGetMaxMemLock() errors qemu: Refactor qemuDomainAdjustMaxMemLock() qemu: Add external_limit_manager config knob qemu: Wire up external limit manager news: Document external limit manager feature NEWS.rst | 10 + src/conf/domain_conf.h | 5 +- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 12 + src/qemu/qemu_command.c | 4 - src/qemu/qemu_conf.c | 4 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_domain.c | 47 ++-- src/qemu/qemu_migration.c | 2 + src/qemu/qemu_process.c | 30 ++- src/qemu/test_libvirtd_qemu.aug.in | 1 + src/util/vircommand.c | 21 +- src/util/virprocess.c | 340 ++++++++++++++++++++--------- src/util/virprocess.h | 2 +- tests/virprocessmock.c | 7 + 15 files changed, 354 insertions(+), 133 deletions(-) -- 2.26.2

3 42

[PATCH] domaincapstest: Return EXIT_SUCCESS / EXIT_FAILURE instead of -1
by Peter Krempa 09 Mar '21

09 Mar '21

The value is used as return value for the process itself. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/domaincapstest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/domaincapstest.c b/tests/domaincapstest.c index 7a082705c6..65d9f4c635 100644 --- a/tests/domaincapstest.c +++ b/tests/domaincapstest.c @@ -475,7 +475,7 @@ mymain(void) DO_TEST_BHYVE("fbuf", "/usr/sbin/bhyve", &bhyve_caps, VIR_DOMAIN_VIRT_BHYVE); #endif /* WITH_BHYVE */ - return ret; + return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } #if WITH_QEMU -- 2.29.2

2 1

[PATCH] qemuMigrationSrcRun: Don't jump to 'exit_monitor' from outside of the monitor
by Peter Krempa 09 Mar '21

09 Mar '21

Failure of 'qemuMigrationSetDBusVMState' would jump to 'exit_monitor' but the function isn't called inside of the monitor context. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/qemu/qemu_migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index e44931dcfa..79dcb4a15d 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4156,7 +4156,7 @@ qemuMigrationSrcRun(virQEMUDriverPtr driver, } if (qemuMigrationSetDBusVMState(driver, vm) < 0) - goto exit_monitor; + goto error; /* Before EnterMonitor, since already qemuProcessStopCPUs does that */ if (!(flags & VIR_MIGRATE_LIVE) && -- 2.29.2

2 1

[PATCH] meson: Add documentation installation directory option
by Chris Mayo 09 Mar '21

09 Mar '21

Allow the directory to be chosen at installation time, to support local conventions e.g. versioning. Signed-off-by: Chris Mayo <aklhfex(a)gmail.com> --- meson.build | 6 +++++- meson_options.txt | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 369548f127..5c7a335947 100644 --- a/meson.build +++ b/meson.build @@ -83,8 +83,12 @@ mandir = prefix / get_option('mandir') sbindir = prefix / get_option('sbindir') sharedstatedir = prefix / get_option('sharedstatedir') +docdir = get_option('docdir') +if docdir == '' + docdir = datadir / 'doc' / meson.project_name() +endif + confdir = sysconfdir / meson.project_name() -docdir = datadir / 'doc' / meson.project_name() pkgdatadir = datadir / meson.project_name() diff --git a/meson_options.txt b/meson_options.txt index e5d79c2b6b..2606648b64 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -7,6 +7,7 @@ option('expensive_tests', type: 'feature', value: 'auto', description: 'set the option('test_coverage', type: 'boolean', value: false, description: 'turn on code coverage instrumentation') option('git_werror', type: 'feature', value: 'auto', description: 'use -Werror if building from GIT') option('rpath', type: 'feature', value: 'auto', description: 'whether to include rpath information in installed binaries and libraries') +option('docdir', type: 'string', value: '', description: 'documentation installation directory') option('docs', type: 'feature', value: 'auto', description: 'whether to generate documentation') option('tests', type: 'feature', value: 'auto', description: 'whether to build tests') -- 2.28.0

3 2

[libvirt PATCH] util: Fix error reporting in virnetlink
by Andrea Bolognani 09 Mar '21

09 Mar '21

The preprocessor macro we use to check whether we're on Linux has not been spelled properly, and so we will always report the error message intended for other platforms. Fixes: 879bcee08ce0f91f556fddfe452c3fbed5318468 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- src/util/virnetlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index a06195bd00..cfb86550a5 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -1231,7 +1231,7 @@ virNetlinkEventRemoveClient(int watch, const virMacAddr *macaddr, #else -# if defined(__linux) +# if defined(__linux__) static const char *unsupported = N_("libnl was not available at build time"); # else static const char *unsupported = N_("not supported on non-linux platforms"); -- 2.26.2

2 1

[libvirt PATCH] util: don't log error if SRIOV PF has no associated netdev
by Laine Stump 09 Mar '21

09 Mar '21

Some SRIOV PFs don't have a netdev associated with them (the spec apparently doesn't require it). In most cases when libvirt is dealing with an SRIOV VF, that VF must have a PF, and the PF *must* have an associated netdev (the only way to set the MAC address of a VF is by sending a netlink message to the netdev of that VF's PF). But there are times when we don't need for the PF to have a netdev; in particular, when we're just getting the Switchdev Features for a VF, we don't need the PF netdev - the netdev of the VF (apparently) works just as well. Commit 6452e2f5 (libvirt 5.1.0) *kind of* made libvirt work around PFs with no netdevs in this case - if virNetDevGetPhysicalFunction returned an error when setting up to retrieve Switchdev feature info, it would ignore the error, and then check if the PF netdev name was NULL and, if so it would reset the error object and continue on rather than returning early with a failure. The problem is that by the time this special handling occured, the error message about missing netdev had already been logged, which was harmless to proper operation, but confused the user. Fortunately there are only 2 users of virNetDevGetPhysicalFunction, so it is easy to redefine it's API to state that a missing netdev name is *not* an error - in that case it will still return success, but the caller must be prepared for the PF netdev name to be NULL. After making this change, we can modify the two callers to behave properly with the new semantics (for one of the callers it *is* still an error, so the error message is moved there, but for the other it is okay to continue), and our spurious error messages are a thing of the past. Resolves: https://bugzilla.redhat.com/1924616 Fixes: 6452e2f5e1837bd753ee465e6607ed3c4f62b815 Signed-off-by: Laine Stump <laine(a)redhat.com> --- src/util/virnetdev.c | 31 +++++++++++++++---------------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 2b4c8b6280..7b766234ec 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -1339,7 +1339,8 @@ virNetDevGetVirtualFunctionIndex(const char *pfname, const char *vfname, * * @ifname : name of the physical function interface name * @pfname : Contains sriov physical function for interface ifname - * upon successful return + * upon successful return (might be NULL if the PF has no + * associated netdev. This is *not* an error) * * Returns 0 on success, -1 on failure * @@ -1361,15 +1362,6 @@ virNetDevGetPhysicalFunction(const char *ifname, char **pfname) return -1; } - if (!*pfname) { - /* The SRIOV standard does not require VF netdevs to have - * the netdev assigned to a PF. */ - virReportError(VIR_ERR_INTERNAL_ERROR, - _("The PF device for VF %s has no network device name"), - ifname); - return -1; - } - return 0; } @@ -1442,6 +1434,17 @@ virNetDevGetVirtualFunctionInfo(const char *vfname, char **pfname, if (virNetDevGetPhysicalFunction(vfname, pfname) < 0) return -1; + if (!*pfname) { + /* The SRIOV standard does not require VF netdevs to have the + * netdev assigned to a PF, but our method of retrieving + * VFINFO does. + */ + virReportError(VIR_ERR_INTERNAL_ERROR, + _("The PF device for VF %s has no network device name, cannot get virtual function info"), + vfname); + return -1; + } + if (virNetDevGetVirtualFunctionIndex(*pfname, vfname, vf) < 0) goto cleanup; @@ -3204,12 +3207,8 @@ virNetDevSwitchdevFeature(const char *ifname, if ((is_vf = virNetDevIsVirtualFunction(ifname)) < 0) return ret; - if (is_vf == 1) { - /* Ignore error if PF does not have netdev assigned. - * In that case pfname == NULL. */ - if (virNetDevGetPhysicalFunction(ifname, &pfname) < 0) - virResetLastError(); - } + if (is_vf == 1 && virNetDevGetPhysicalFunction(ifname, &pfname) < 0) + return ret; pci_device_ptr = pfname ? virNetDevGetPCIDevice(pfname) : virNetDevGetPCIDevice(ifname); -- 2.29.2

2 3

[PATCH] virnetdevbandwidth: Don't generate burst outside of boundaries
by Michal Privoznik 09 Mar '21

09 Mar '21

When generating TC rules for domain's outbound traffic, Libvirt will use the 'average' as the default for 'burst' - it's been this way since the feature introduction in v0.9.4-rc1~22. The reason is that 'average' considers 'burst' for policing. However, when parsing its command line TC uses an unsigned int (with overflow detection) to store the 'burst' size. This means, that the upper limit for the value is UINT_MAX, well UINT_MAX / 1024 because we are putting the value in KiB onto the command line. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1912210 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virnetdevbandwidth.c | 12 +++++++++++- tests/virnetdevbandwidthtest.c | 15 +++++++++++++++ 2 files changed, 26 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c index 612e8f985c..77a97176b0 100644 --- a/src/util/virnetdevbandwidth.c +++ b/src/util/virnetdevbandwidth.c @@ -358,7 +358,17 @@ virNetDevBandwidthSet(const char *ifname, if (rx) { average = g_strdup_printf("%llukbps", rx->average); - burst = g_strdup_printf("%llukb", rx->burst ? rx->burst : rx->average); + + if (rx->burst) { + burst = g_strdup_printf("%llukb", rx->burst); + } else { + /* Internally, tc uses uint to store burst size (in bytes). + * Therefore, the largest value we can set is UINT_MAX bytes. + * We're outputting the vale in KiB though. */ + unsigned long long avg = MIN(rx->average, UINT_MAX / 1024); + + burst = g_strdup_printf("%llukb", avg); + } virCommandFree(cmd); cmd = virCommandNew(TC); diff --git a/tests/virnetdevbandwidthtest.c b/tests/virnetdevbandwidthtest.c index 2e76af3d0c..7c236f50f3 100644 --- a/tests/virnetdevbandwidthtest.c +++ b/tests/virnetdevbandwidthtest.c @@ -156,6 +156,21 @@ mymain(void) TC " filter add dev eth0 parent ffff: protocol all u32 match u32 0 0 " "police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n")); + DO_TEST_SET(("<bandwidth>" + " <inbound average='4294967295'/>" + " <outbound average='4294967295'/>" + "</bandwidth>"), + (TC " qdisc del dev eth0 root\n" + TC " qdisc del dev eth0 ingress\n" + TC " qdisc add dev eth0 root handle 1: htb default 1\n" + TC " class add dev eth0 parent 1: classid 1:1 htb rate 4294967295kbps quantum 366503875\n" + TC " qdisc add dev eth0 parent 1:1 handle 2: sfq perturb 10\n" + TC " filter add dev eth0 parent 1:0 protocol all prio 1 handle 1 fw flowid 1\n" + TC " qdisc add dev eth0 ingress\n" + TC " filter add dev eth0 parent ffff: protocol all u32 match " + "u32 0 0 police rate 4294967295kbps burst 4194303kb mtu 64kb " + "drop flowid :1\n")); + return ret; } -- 2.26.2

2 1

[PATCH] qemu: don't raise error upon interface update without <frames/> for <rx/> in coalesce
by Kristina Hanicova 08 Mar '21

08 Mar '21

With this, incomplete XML without <frames/> for <rx/> in coalesce won't raise error as before. It will leave the coalesce parameter empty, thanks to passing it as a parameter and return an integer to indicate error state - previously it returned pointer (or NULL for both error and incomplete XML). The code went through some refactoring: * change of a condition * addition of a parameter * change of order, that allowed removal of VIR_FREE * removal of redundant labels and variables Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Signed-off-by: Kristina Hanicova <khanicov(a)redhat.com> --- src/conf/domain_conf.c | 25 ++++++++++--------------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index b731744f04..798594f520 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -7516,11 +7516,11 @@ virDomainNetIPInfoParseXML(const char *source, } -static virNetDevCoalescePtr +static int virDomainNetDefCoalesceParseXML(xmlNodePtr node, - xmlXPathContextPtr ctxt) + xmlXPathContextPtr ctxt, + virNetDevCoalescePtr *coalesce) { - virNetDevCoalescePtr ret = NULL; VIR_XPATH_NODE_AUTORESTORE(ctxt) unsigned long long tmp = 0; g_autofree char *str = NULL; @@ -7529,15 +7529,13 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node, str = virXPathString("string(./rx/frames/@max)", ctxt); if (!str) - return NULL; - - ret = g_new0(virNetDevCoalesce, 1); + return 0; if (virStrToLong_ullp(str, NULL, 10, &tmp) < 0) { virReportError(VIR_ERR_XML_DETAIL, _("cannot parse value '%s' for coalesce parameter"), str); - goto error; + return -1; } if (tmp > UINT32_MAX) { @@ -7545,15 +7543,13 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node, _("value '%llu' is too big for coalesce " "parameter, maximum is '%lu'"), tmp, (unsigned long) UINT32_MAX); - goto error; + return -1; } - ret->rx_max_coalesced_frames = tmp; - return ret; + *coalesce = g_new0(virNetDevCoalesce, 1); + (*coalesce)->rx_max_coalesced_frames = tmp; - error: - VIR_FREE(ret); - return NULL; + return 0; } static void @@ -11517,8 +11513,7 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt, node = virXPathNode("./coalesce", ctxt); if (node) { - def->coalesce = virDomainNetDefCoalesceParseXML(node, ctxt); - if (!def->coalesce) + if (virDomainNetDefCoalesceParseXML(node, ctxt, &def->coalesce) < 0) goto error; } -- 2.29.2

2 1

[libvirt PATCH 0/2] docs: less docs for insecure SASL mechanisms
by Daniel P. Berrangé 08 Mar '21

08 Mar '21

GSSAPI and SCRAM-SHA-256 are the only two SASL mechanisms we especially want people to be using. Even the latter is a little questionable due to storing passwords in cleartext on the server. Daniel P. Berrangé (2): docs: convert auth page into RST format docs: stop mentioning insecure / broken SASL mechanisms docs/auth.html.in | 368 --------------------------------------- docs/auth.rst | 323 ++++++++++++++++++++++++++++++++++ docs/meson.build | 2 +- src/remote/libvirtd.sasl | 11 +- 4 files changed, 330 insertions(+), 374 deletions(-) delete mode 100644 docs/auth.html.in create mode 100644 docs/auth.rst -- 2.29.2

2 8

[PATCH v2 0/3] Drop deprecated floppy config & bogus -drive if=T
by Markus Armbruster 08 Mar '21

08 Mar '21

v2: * Rebased, straightforward conflict with commit f5d33dd51f "hw/block/fdc: Remove the check_media_rate property" resolved * PATCH 2: Commit message fixed [Kevin] Markus Armbruster (3): fdc: Drop deprecated floppy configuration fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() blockdev: Drop deprecated bogus -drive interface type docs/system/deprecated.rst | 33 -- docs/system/removed-features.rst | 33 ++ include/sysemu/blockdev.h | 1 - blockdev.c | 37 +- hw/block/fdc.c | 73 +--- softmmu/vl.c | 8 +- tests/qemu-iotests/172 | 31 +- tests/qemu-iotests/172.out | 562 +------------------------------ 8 files changed, 59 insertions(+), 719 deletions(-) -- 2.26.2

3 12

[PATCH] virDevMapperGetTargetsImpl: Use correct length when copying into dm.name
by Michal Privoznik 08 Mar '21

08 Mar '21

For reasons unknown, when rewriting this code and dropping libdevmapper I've mistakenly used incorrect length of dm.name. In linux/dm-ioctl.h the dm_ioctl struct is defined as follows: #define DM_NAME_LEN 128 struct dm_ioctl { ... char name[DM_NAME_LEN]; /* device name */ ... }; However, when copying string into this member, DM_TABLE_DEPS was used, which is defined as follows: #define DM_TABLE_DEPS _IOWR(DM_IOCTL, DM_TABLE_DEPS_CMD, struct dm_ioctl) After decryption, this results in the following size: 3241737483. Fixes: 22494556542c676d1b9e7f1c1f2ea13ac17e1e3e Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virdevmapper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virdevmapper.c b/src/util/virdevmapper.c index fcb11e954f..2c4c2df999 100644 --- a/src/util/virdevmapper.c +++ b/src/util/virdevmapper.c @@ -240,7 +240,7 @@ virDevMapperGetTargetsImpl(int controlFD, if (!(sanitizedPath = virDMSanitizepath(path))) return 0; - if (virStrcpy(dm.name, sanitizedPath, DM_TABLE_DEPS) < 0) { + if (virStrcpy(dm.name, sanitizedPath, DM_NAME_LEN) < 0) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("Resolved device mapper name too long")); return -1; -- 2.26.2

2 1

[PATCH] meson: tools: depend on keycode generated sources
by Roman Bogorodskiy 05 Mar '21

05 Mar '21

Tools depend on keycode generated sources, so declare that as an explicit dependency, otherwise it might fail with: ../tools/virsh-completer-domain.c:35:10: fatal error: 'virkeynametable_linux.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- I noticed that build failure on FreeBSD 11.x. For some reason, it doesn't show up on newer versions. This is strange, but as the fix appears to be straight-forward, I didn't spend much time figuring out the reason. In case you're interested, a full failing build log is here: https://people.freebsd.org/~novel/misc/libvirt-7.1.0.log It doesn't seem to even try to generate these files. When I inspected filesystem state, these files were missing. src/util/meson.build | 2 ++ tools/meson.build | 1 + 2 files changed, 3 insertions(+) diff --git a/src/util/meson.build b/src/util/meson.build index 0080825bd0..cd3fe18524 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -168,6 +168,8 @@ foreach name : keyname_list ) endforeach +keycode_dep = declare_dependency(sources: keycode_gen_sources) + io_helper_sources = [ 'iohelper.c', ] diff --git a/tools/meson.build b/tools/meson.build index b8c6802f0a..42dc609439 100644 --- a/tools/meson.build +++ b/tools/meson.build @@ -186,6 +186,7 @@ executable( tools_dep, readline_dep, thread_dep, + keycode_dep, ], link_args: [ coverage_flags, -- 2.30.0

3 5

[PATCH] docs: Document qemu.conf locations
by Michal Privoznik 05 Mar '21

05 Mar '21

Surprisingly, we never documented the relationship between connection URI and the location of qemu.conf. Users might wonder what qemu.conf is loaded when they are connecting to the session daemon or embed URI. And what to do if the file doesn't exist for the URI they're using. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/drvqemu.html.in | 39 +++++++++++++++++++++++++++++++++++++ docs/manpages/libvirtd.rst | 20 +++++++++++++++++++ docs/manpages/virtqemud.rst | 22 +++++++++++++++++++++ 3 files changed, 81 insertions(+) diff --git a/docs/drvqemu.html.in b/docs/drvqemu.html.in index 31d3fee213..a784f5768c 100644 --- a/docs/drvqemu.html.in +++ b/docs/drvqemu.html.in @@ -162,6 +162,45 @@ qemu+ssh://root@example.com/system (remote access, SSH tunnelled) of libvirt, once QMP processing moves to a dedicated thread. </p> + <h2><a id="configFiles">Location of configuration files</a></h2> + + <p> + The QEMU driver comes with sane default values. However, during its + initialization it reads a configuration file which offers system + administrator or an user to override some of that default. The location + of the file depends on the connection URI, as follows: + </p> + + <table> + <tr> + <td><code>qemu:///system</code></td> + <td><code>/etc/libvirt/qemu.conf</code></td> + </tr> + <tr> + <td><code>qemu:///session</code></td> + <td><code>$XDG_CONFIG_HOME/libvirt/qemu.conf</code></td> + </tr> + <tr> + <td><code>qemu:///embed</code></td> + <td><code>$rootdir/etc/qemu.conf</code></td> + </tr> + </table> + + <p> + If <code>$XDG_CONFIG_HOME</code> is not set in the environment, it + defaults to <code>$HOME/.config</code>. For the embed URI the + <code>$rootdir</code> represents the specified root directory from + the connection URI. + </p> + + <p> + Please note, that it is very likely that the only qemu.conf file that + will exist after installing libvirt is the + <code>/etc/libvirt/qemu.conf</code>, if users of the session daemon or + the embed driver want to override a built in value, then they need to + create the file before connecting to the respective URI. + </p> + <h2><a id="security">Driver security architecture</a></h2> <p> diff --git a/docs/manpages/libvirtd.rst b/docs/manpages/libvirtd.rst index ed591f4778..6545dc58d3 100644 --- a/docs/manpages/libvirtd.rst +++ b/docs/manpages/libvirtd.rst @@ -136,6 +136,16 @@ When run as *root* The default configuration file used by ``libvirtd``, unless overridden on the command line using the ``-f`` | ``--config`` option. +If QEMU driver is installed, then the following file is also read: + +* ``@SYSCONFDIR@/libvirt/qemu.conf`` + +This file contains various knobs and default values for virtual machines +created within QEMU driver, and offers a way to override the built in defaults, +for instance (but not limited to): paths to various supplementary binaries, TLS +certificates location, graphical consoles configuration and others. Location of +this file can't be overridden by any command line switch. + * ``@RUNSTATEDIR@/libvirt/libvirt-sock`` * ``@RUNSTATEDIR@/libvirt/libvirt-sock-ro`` @@ -166,6 +176,16 @@ When run as *non-root* The default configuration file used by ``libvirtd``, unless overridden on the command line using the ``-f``|``--config`` option. +If QEMU driver is installed, then the following file is also read: + +* ``$XDG_CONFIG_HOME/libvirt/qemu.conf`` + +If the file exists, it can contain various knobs and default values for virtual +machines created within QEMU driver, and offers a way to override the built in +defaults, for instance (but not limited to): paths to various supplementary +binaries, TLS certificates location, graphical consoles configuration and +others. Location of this file can't be overridden by any command line switch. + * ``$XDG_RUNTIME_DIR/libvirt/libvirt-sock`` The socket ``libvirtd`` will use. diff --git a/docs/manpages/virtqemud.rst b/docs/manpages/virtqemud.rst index fbcc6e45fa..d82d09ee61 100644 --- a/docs/manpages/virtqemud.rst +++ b/docs/manpages/virtqemud.rst @@ -111,6 +111,17 @@ When run as *root* The default configuration file used by ``virtqemud``, unless overridden on the command line using the ``-f`` | ``--config`` option. +In addition to the default configuration file, ``virtqemud`` reads +configuration for the qemu driver from: + +* ``@SYSCONFDIR@/libvirt/qemu.conf`` + +This file contains various knobs and default values for virtual machines +created within QEMU driver, and offers a way to override the built in defaults, +for instance (but not limited to): paths to various supplementary binaries, TLS +certificates location, graphical consoles configuration and others. Location of +this file can't be overridden by any command line switch. + * ``@RUNSTATEDIR@/libvirt/virtqemud-sock`` * ``@RUNSTATEDIR@/libvirt/virtqemud-sock-ro`` * ``@RUNSTATEDIR@/libvirt/virtqemud-admin-sock`` @@ -132,6 +143,17 @@ When run as *non-root* The default configuration file used by ``virtqemud``, unless overridden on the command line using the ``-f``|``--config`` option. +In addition to the default configuration file, ``virtqemud`` reads +configuration for the qemu driver from: + +* ``$XDG_CONFIG_HOME/libvirt/qemu.conf`` + +If the file exists, it can contain various knobs and default values for virtual +machines created within QEMU driver, and offers a way to override the built in +defaults, for instance (but not limited to): paths to various supplementary +binaries, TLS certificates location, graphical consoles configuration and +others. Location of this file can't be overridden by any command line switch. + * ``$XDG_RUNTIME_DIR/libvirt/virtqemud-sock`` * ``$XDG_RUNTIME_DIR/libvirt/virtqemud-admin-sock`` -- 2.26.2

2 2

[PATCH] virFirewallApply: Fix possible NULL dereference on error
by Peter Krempa 05 Mar '21

05 Mar '21

Commit bbc25f0d03d443efd35381463efc81b01cb6ae96 juggled around some error reporting. Unfortunately virFirewallApply tries to report the errno stored in the firewall object and we'd try to do that when the firewall object is NULL too. Report EINVAL if 'firewall' is NULL. Found by Coverity. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virfirewall.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index c1b7d2268b..0dc0cecd53 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -766,8 +766,12 @@ virFirewallApply(virFirewallPtr firewall) goto cleanup; } if (!firewall || firewall->err) { - virReportSystemError(firewall->err, "%s", - _("Unable to create rule")); + int err = EINVAL; + + if (firewall) + err = firewall->err; + + virReportSystemError(err, "%s", _("Unable to create rule")); goto cleanup; } -- 2.29.2

2 1

[libvirt PATCH v2 0/1] qemuProcessUpdateGuestCPU: Check host cpu for forbidden features
by Tim Wiederhake 05 Mar '21

05 Mar '21

V1: https://listman.redhat.com/archives/libvir-list/2021-February/msg01275.ht= ml Changes since V1: * Only check for forbidden features * Check if `check` !=3D none * Renamed patch Tim Wiederhake (1): qemuProcessUpdateGuestCPU: Check host cpu for forbidden features src/qemu/qemu_process.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) --=20 2.26.2

3 3

[PATCH v6 0/5] migration/dirtyrate: Introduce APIs for getting domain memory dirty rate
by Hao Wang 05 Mar '21

05 Mar '21

V5 -> V6: split DomainGetDirtyRateInfo(domdirtyrate) API into two parts: 1. DomainStartDirtyRateCalc(domdirtyrate-calc) for starting dirty rate calculation; 2. qemuDomainGetStatsDirtyRate(domstats --dirtyrate) for querying dirty rate infomation. V4 -> V5: squash 1/7 and bits of 5/7 and 6/7 into 2/7 in v4 (to be 1/5 in v5) squash left of 5/7 into 4/7 in v4 (to be 3/5 in v5) add VIR_DOMAIN_DIRTYRATE_DEFAULT flag remove redundant error report rename virsh api to "domdirtyrate" use vshTablePtr for virsh api output add description in docs/manpages/virsh.rst other format optimize V3 -> V4: define flags to unsigned int fix some compile warnings V2 -> V3: reorganize patchset to fix compile warning V1 -> V2: replace QEMU_JOB_ASYNC with QEMU_JOB_QUERY Sometimes domain's memory dirty rate is expected by user in order to decide whether it's proper to be migrated out or not. We have already completed the QEMU part of the capability: https://patchew.org/QEMU/1600237327-33618-1-git-send-email-zhengchuan@huawe… And this serial of patches introduce the corresponding LIBVIRT part: 1. Calculating Introduce a new API DomainStartDirtyRateCalc and corresponding virsh api (domdirtyrate-calc) for starting dirty rate calculation by calling qmp 'calc-dirty-rate'. # virsh domdirtyrate-calc <domain> [--seconds <sec>] 2. Querying Introduce command 'virsh domstats --dirtyrate' for reporting memory dirty rate infomation by calling qmp 'query-dirty-rate'. The info is listed as: Domain: 'vm0' dirtyrate.calc_status=measured dirtyrate.calc_start_time=502814 dirtyrate.calc_period=1 dirtyrate.megabytes_per_second=2 Hao Wang (5): migration/dirtyrate: Introduce virDomainStartDirtyRateCalc API migration/dirtyrate: Implement qemuDomainStartDirtyRateCalc migration/dirtyrate: Introduce domdirtyrate-calc virsh api migration/dirtyrate: Implement qemuMonitorQueryDirtyRate migration/dirtyrate: Introduce command 'virsh domstats --dirtyrate' docs/manpages/virsh.rst | 33 ++++++++- include/libvirt/libvirt-domain.h | 5 ++ src/driver-hypervisor.h | 6 ++ src/libvirt-domain.c | 57 +++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_driver.c | 115 +++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 24 +++++++ src/qemu/qemu_monitor.h | 18 +++++ src/qemu/qemu_monitor_json.c | 88 +++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 8 +++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 14 +++- src/remote_protocol-structs | 6 ++ tools/virsh-domain-monitor.c | 7 ++ tools/virsh-domain.c | 63 +++++++++++++++++ 15 files changed, 447 insertions(+), 3 deletions(-) -- 2.23.0

2 10

[PATCH 0/4] Replace virFileMakePath*() with g_mkdir_with_parents()
by Michal Privoznik 04 Mar '21

04 Mar '21

2 7

[PATCH 00/33] Remove the now misleading virReportOOMError infra
by Peter Krempa 04 Mar '21

04 Mar '21

'virReportOOMError' is nowadays mostly useless since an OOM error will trigger yet another allocation failure in the logger when attempting to log the error. Additionally it was also used in few places which can fail with other failures than OOM. To prevent both errorneous usage types, let's remove it completely. In the rare case we'd want to allocate a massive buffer and want to fail gracefully we still can use virReportError with VIR_ERR_NO_MEMORY. The series starts by some cleanup, then removes error handling from places where it's now dead code as we'll abort before the reporting, then converts some real OOM scenarios to abort() directly and lastly fixes the error message for cases where other errors are possible and lastly removes virReportOOMError. Pipelines are stuck, so hopefully it will go through: https://gitlab.com/pipo.sk/libvirt/-/pipelines/261161989 Peter Krempa (33): Remove useless comments for VIR_FROM_THIS definition util: xml: Introduce autoptr cleanup support for 'xmlNode' virDomainDefSetMetadata: Avoid temporary variable for string copy virCommandAddEnv: Make stealing of argument more obvious virCommandAddArgBuffer: Simplify clearing of @buf virCPUx86DataParse: Don't check error from x86FeatureNames virhostcputest: linuxCPUStatsCompareFiles: Don't check return value of virBufferContentAndReset virBuildPath: Remove return value lxc_process: Remove OOM handling from logging setup virDomainDefSetMetadata: Rework memory handling util: vircommand: Remove OOM handling virCloseCallbacksGetForConn: Remove OOM handling virfirewall: Don't check OOM in ADD_ARG macro virfirewall: Remove OOM checks from virFirewallStartTransaction virfirewall: virFirewallAddRuleFullV: Remove OOM check from VIR_APPEND_ELEMENT virfirewall: Remove impossible OOM error reporting util: virnetlink: Add wrapper for 'nlmsg_alloc_simple' util: xml: Add virXMLBufferCreate wrapper util: xml: Add wrapper for 'xmlNewNode' Don't report OOM error on xmlCopyNode failure virXMLXPathContextNew: abort() on allocation failure virXMLParseHelper: abort() on allocation failure util: virprocess: abort() on CPU_ALLOC failure virURIFormat: abort() on failure util: iohelper: Don't handle OOM from posix_memalign hyperv: abort() failure of wsmc_fault_new() vbox: abort() on allocation failure in UTF8<->UTF16 conversion libxl: abort() on failure of libxl_cpu_bitmap_alloc() virVBoxSnapshotConfSaveVboxFile: abort() on failure to allocate xmlDoc and comment util: json: Report non-OOM error on yajl failure storage: Don't report OOM error on failure of glfs_new virVMXConvertToUTF8: Report non-OOM error on failure of xmlBufferCreateStatic util: virerror: Remove virReportOOMError build-aux/syntax-check.mk | 8 -- docs/internals/command.html.in | 8 +- src/conf/domain_conf.c | 62 ++++----- src/conf/network_conf.c | 5 +- src/cpu/cpu_x86.c | 6 +- src/hyperv/hyperv_wmi.c | 8 +- src/hypervisor/virclosecallbacks.c | 15 +-- src/libvirt_private.syms | 3 +- src/libxl/libxl_conf.c | 6 +- src/libxl/libxl_driver.c | 7 +- src/lxc/lxc_process.c | 9 +- src/storage/storage_backend_gluster.c | 3 +- .../storage_file_backend_gluster.c | 3 +- src/test/test_driver.c | 6 +- src/util/iohelper.c | 7 +- src/util/vircommand.c | 119 +++++------------- src/util/virerror.c | 22 ---- src/util/virerror.h | 8 -- src/util/virfcp.c | 3 +- src/util/virfile.c | 7 +- src/util/virfile.h | 2 +- src/util/virfirewall.c | 62 ++------- src/util/virhook.c | 14 +-- src/util/virjson.c | 6 +- src/util/virnetdev.c | 18 +-- src/util/virnetdevbridge.c | 10 +- src/util/virnetdevip.c | 15 +-- src/util/virnetdevvportprofile.c | 6 +- src/util/virnetlink.c | 38 +++--- src/util/virnetlink.h | 4 + src/util/virpci.c | 12 +- src/util/virprocess.c | 12 +- src/util/virscsi.c | 1 - src/util/virscsivhost.c | 1 - src/util/viruri.c | 8 +- src/util/virxml.c | 44 ++++--- src/util/virxml.h | 8 ++ src/vbox/vbox_common.c | 20 --- src/vbox/vbox_common.h | 15 ++- src/vbox/vbox_snapshot_conf.c | 46 ++----- src/vmx/vmx.c | 9 +- tests/virhostcputest.c | 5 +- tools/virsh-domain.c | 5 +- 43 files changed, 214 insertions(+), 462 deletions(-) -- 2.29.2

3 39

[PATCH] tests: Don't return -1 as program return value
by Peter Krempa 04 Mar '21

04 Mar '21

In cases we use -1 for failure internally we still must return EXIT_FAILURE. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/qemucommandutiltest.c | 3 +-- tests/virnetdevbandwidthtest.c | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/qemucommandutiltest.c b/tests/qemucommandutiltest.c index 6291c3b787..03947d87bc 100644 --- a/tests/qemucommandutiltest.c +++ b/tests/qemucommandutiltest.c @@ -146,8 +146,7 @@ mymain(void) "server.2.type=tcp," "server.2.host=example.com"); - return ret; - + return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } VIR_TEST_MAIN(mymain) diff --git a/tests/virnetdevbandwidthtest.c b/tests/virnetdevbandwidthtest.c index 2e76af3d0c..6d0443876c 100644 --- a/tests/virnetdevbandwidthtest.c +++ b/tests/virnetdevbandwidthtest.c @@ -156,7 +156,7 @@ mymain(void) TC " filter add dev eth0 parent ffff: protocol all u32 match u32 0 0 " "police rate 5kbps burst 7kb mtu 64kb drop flowid :1\n")); - return ret; + return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virnetdevbandwidth")) -- 2.29.2

2 1

[PATCH] conf: Rewrite network virtio driver formatting using virXMLFormatElement
by Peter Krempa 04 Mar '21

04 Mar '21

Simplify the logic picking which element form to format by using virBuffers for the partial properties and virXMLFormatElement for combining them. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/domain_conf.c | 93 ++++++++++++++++-------------------------- 1 file changed, 35 insertions(+), 58 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 05b6cb3000..0220db794e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -25428,108 +25428,97 @@ virDomainActualNetDefFormat(virBufferPtr buf, static void -virDomainVirtioNetGuestOptsFormat(char **outstr, +virDomainVirtioNetGuestOptsFormat(virBufferPtr buf, virDomainNetDefPtr def) { - g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; if (def->driver.virtio.guest.csum) { - virBufferAsprintf(&buf, "csum='%s' ", + virBufferAsprintf(buf, " csum='%s'", virTristateSwitchTypeToString(def->driver.virtio.guest.csum)); } if (def->driver.virtio.guest.tso4) { - virBufferAsprintf(&buf, "tso4='%s' ", + virBufferAsprintf(buf, " tso4='%s'", virTristateSwitchTypeToString(def->driver.virtio.guest.tso4)); } if (def->driver.virtio.guest.tso6) { - virBufferAsprintf(&buf, "tso6='%s' ", + virBufferAsprintf(buf, " tso6='%s'", virTristateSwitchTypeToString(def->driver.virtio.guest.tso6)); } if (def->driver.virtio.guest.ecn) { - virBufferAsprintf(&buf, "ecn='%s' ", + virBufferAsprintf(buf, " ecn='%s'", virTristateSwitchTypeToString(def->driver.virtio.guest.ecn)); } if (def->driver.virtio.guest.ufo) { - virBufferAsprintf(&buf, "ufo='%s' ", + virBufferAsprintf(buf, " ufo='%s'", virTristateSwitchTypeToString(def->driver.virtio.guest.ufo)); } - virBufferTrim(&buf, " "); - - *outstr = virBufferContentAndReset(&buf); } static void -virDomainVirtioNetHostOptsFormat(char **outstr, +virDomainVirtioNetHostOptsFormat(virBufferPtr buf, virDomainNetDefPtr def) { - g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; if (def->driver.virtio.host.csum) { - virBufferAsprintf(&buf, "csum='%s' ", + virBufferAsprintf(buf, " csum='%s'", virTristateSwitchTypeToString(def->driver.virtio.host.csum)); } if (def->driver.virtio.host.gso) { - virBufferAsprintf(&buf, "gso='%s' ", + virBufferAsprintf(buf, " gso='%s'", virTristateSwitchTypeToString(def->driver.virtio.host.gso)); } if (def->driver.virtio.host.tso4) { - virBufferAsprintf(&buf, "tso4='%s' ", + virBufferAsprintf(buf, " tso4='%s'", virTristateSwitchTypeToString(def->driver.virtio.host.tso4)); } if (def->driver.virtio.host.tso6) { - virBufferAsprintf(&buf, "tso6='%s' ", + virBufferAsprintf(buf, " tso6='%s'", virTristateSwitchTypeToString(def->driver.virtio.host.tso6)); } if (def->driver.virtio.host.ecn) { - virBufferAsprintf(&buf, "ecn='%s' ", + virBufferAsprintf(buf, " ecn='%s'", virTristateSwitchTypeToString(def->driver.virtio.host.ecn)); } if (def->driver.virtio.host.ufo) { - virBufferAsprintf(&buf, "ufo='%s' ", + virBufferAsprintf(buf, " ufo='%s'", virTristateSwitchTypeToString(def->driver.virtio.host.ufo)); } if (def->driver.virtio.host.mrg_rxbuf) { - virBufferAsprintf(&buf, "mrg_rxbuf='%s' ", + virBufferAsprintf(buf, " mrg_rxbuf='%s'", virTristateSwitchTypeToString(def->driver.virtio.host.mrg_rxbuf)); } - virBufferTrim(&buf, " "); - - *outstr = virBufferContentAndReset(&buf); } static void -virDomainVirtioNetDriverFormat(char **outstr, +virDomainVirtioNetDriverFormat(virBufferPtr buf, virDomainNetDefPtr def) { - g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; if (def->driver.virtio.name) { - virBufferAsprintf(&buf, " name='%s'", + virBufferAsprintf(buf, " name='%s'", virDomainNetBackendTypeToString(def->driver.virtio.name)); } if (def->driver.virtio.txmode) { - virBufferAsprintf(&buf, " txmode='%s'", + virBufferAsprintf(buf, " txmode='%s'", virDomainNetVirtioTxModeTypeToString(def->driver.virtio.txmode)); } if (def->driver.virtio.ioeventfd) { - virBufferAsprintf(&buf, " ioeventfd='%s'", + virBufferAsprintf(buf, " ioeventfd='%s'", virTristateSwitchTypeToString(def->driver.virtio.ioeventfd)); } if (def->driver.virtio.event_idx) { - virBufferAsprintf(&buf, " event_idx='%s'", + virBufferAsprintf(buf, " event_idx='%s'", virTristateSwitchTypeToString(def->driver.virtio.event_idx)); } if (def->driver.virtio.queues) - virBufferAsprintf(&buf, " queues='%u'", def->driver.virtio.queues); + virBufferAsprintf(buf, " queues='%u'", def->driver.virtio.queues); if (def->driver.virtio.rx_queue_size) - virBufferAsprintf(&buf, " rx_queue_size='%u'", + virBufferAsprintf(buf, " rx_queue_size='%u'", def->driver.virtio.rx_queue_size); if (def->driver.virtio.tx_queue_size) - virBufferAsprintf(&buf, " tx_queue_size='%u'", + virBufferAsprintf(buf, " tx_queue_size='%u'", def->driver.virtio.tx_queue_size); - virDomainVirtioOptionsFormat(&buf, def->virtio); - - *outstr = virBufferContentAndReset(&buf); + virDomainVirtioOptionsFormat(buf, def->virtio); } @@ -25834,30 +25823,18 @@ virDomainNetDefFormat(virBufferPtr buf, virBufferEscapeString(buf, "<model type='%s'/>\n", virDomainNetGetModelString(def)); if (virDomainNetIsVirtioModel(def)) { - g_autofree char *str = NULL; - g_autofree char *gueststr = NULL; - g_autofree char *hoststr = NULL; - - virDomainVirtioNetDriverFormat(&str, def); - virDomainVirtioNetGuestOptsFormat(&gueststr, def); - virDomainVirtioNetHostOptsFormat(&hoststr, def); - - if (!gueststr && !hoststr) { - if (str) - virBufferAsprintf(buf, "<driver%s/>\n", str); - } else { - if (str) - virBufferAsprintf(buf, "<driver%s>\n", str); - else - virBufferAddLit(buf, "<driver>\n"); - virBufferAdjustIndent(buf, 2); - if (hoststr) - virBufferAsprintf(buf, "<host %s/>\n", hoststr); - if (gueststr) - virBufferAsprintf(buf, "<guest %s/>\n", gueststr); - virBufferAdjustIndent(buf, -2); - virBufferAddLit(buf, "</driver>\n"); - } + g_auto(virBuffer) driverAttrBuf = VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) driverChildBuf = VIR_BUFFER_INIT_CHILD(buf); + g_auto(virBuffer) hostAttrBuf = VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) guestAttrBuf = VIR_BUFFER_INITIALIZER; + + virDomainVirtioNetDriverFormat(&driverAttrBuf, def); + virDomainVirtioNetGuestOptsFormat(&guestAttrBuf, def); + virDomainVirtioNetHostOptsFormat(&hostAttrBuf, def); + + virXMLFormatElement(&driverChildBuf, "host", &hostAttrBuf, NULL); + virXMLFormatElement(&driverChildBuf, "guest", &guestAttrBuf, NULL); + virXMLFormatElement(buf, "driver", &driverAttrBuf, &driverChildBuf); } } if (def->backend.tap || def->backend.vhost) { -- 2.29.2

2 1

[PATCH] virBufferAdd: Ensure that the buffer is initialized also when len == 0
by Peter Krempa 04 Mar '21

04 Mar '21

There's an optimization in virBufferAdd which returns early when the length of the added string is 0 (given that auto-indent is disabled). The optimization causes inconsistent behaviour between these two cases: virBufferAdd(buf, "", 0); // this doesn't initialize the buffer and virBufferAdd(buf, "", -1); //this initializes the buffer Since using an empty string is used to prime the buffer to an empty string it can be confusing. Remove the optimization. This fixes such a wrong initialization done in x86FeatureNames. Note that our code in many places expects that if no virBuffer APIs are used on a buffer object, then NULL should be retured, so we can't always prime the buffer to an empty string. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/util/virbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c index ebb4108b5d..b9ddf1f5c9 100644 --- a/src/util/virbuffer.c +++ b/src/util/virbuffer.c @@ -156,7 +156,7 @@ virBufferApplyIndent(virBufferPtr buf) void virBufferAdd(virBufferPtr buf, const char *str, int len) { - if (!str || !buf || (len == 0 && buf->indent == 0)) + if (!str || !buf) return; virBufferInitialize(buf); -- 2.29.2

2 1

[PATCH 0/6] util: virerror: Avoid stack'd buffers for error message formatting
by Peter Krempa 04 Mar '21

04 Mar '21

We don't need OOM resiliency nowadays. Peter Krempa (6): util: virerror: Don't use stack'd buffers in error report helpers util: virerror: Avoid a copy of the error messages util: virprocess: Use local maximum error message size qemuProcessReportLogError: Remove unnecessary math for max error message qemuProcessReportLogError: Don't mark "%s: %s" as translatable util: virerror: Remove VIR_ERROR_MAX_LENGTH macro src/qemu/qemu_process.c | 12 +-- src/util/virerror.c | 188 ++++++++++++++++++++++------------------ src/util/virerror.h | 2 - src/util/virprocess.c | 10 ++- 4 files changed, 116 insertions(+), 96 deletions(-) -- 2.29.2

2 8

[PATCH v2 0/6] use g_autofree and g_autoptr
by Kristina Hanicova 04 Mar '21

04 Mar '21

This is v2 from https://listman.redhat.com/archives/libvir-list/2021-February/msg01117.html I split commit 3/4 into more commits and left out autofreeing outer array as suggested by Jan Tomko. Patches 2/6 and 6/6 (previously 2/4 and 4/4) have already been reviewed-by and I am sending them for completness. This uses g_autofree (if possible) in files: vsh-table, netdev_bandwidth_conf and g_autoptr instead of virNetDevBandwidthFree where possible. Kristina Hanicova (6): vsh-table: Use g_autofree where possible netdev_bandwidth_conf: Use g_autofree where possible netdev_bandwidth_conf: Refractor virNetDevBandwidthParse() Use g_steal_pointer where possible Use g_autoptr instead of virNetDevBandwidthFree where possible netdev_bandwidth_conf: Remove redundant variables/labels src/conf/netdev_bandwidth_conf.c | 67 ++++++++++++-------------------- src/network/bridge_driver.c | 6 +-- src/qemu/qemu_driver.c | 11 ++---- src/test/test_driver.c | 3 +- src/util/virnetdevbandwidth.h | 2 + tests/virnetdevbandwidthtest.c | 3 +- tools/vsh-table.c | 13 ++----- 7 files changed, 39 insertions(+), 66 deletions(-) -- 2.29.2

2 8

[libvirt PATCH] docs: Spell out our policy concerning minor releases
by Andrea Bolognani 04 Mar '21

04 Mar '21

We've already applied this policy on multiple occasions, but it's good to have it written down so that there can be no confusion. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- docs/platforms.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/platforms.rst b/docs/platforms.rst index b0ce0c3737..6d55728625 100644 --- a/docs/platforms.rst +++ b/docs/platforms.rst @@ -44,6 +44,7 @@ for the previous major version will be dropped 2 years after the new major version is released or when the vendor itself drops support, whichever comes first. In this context, third-party efforts to extend the lifetime of a distro are not considered, even when they are endorsed by the vendor (eg. Debian LTS). +Within each major release, only the most recent minor release is considered. For the purposes of identifying supported software versions available on Linux, the project will look at CentOS, Debian, Fedora, openSUSE, RHEL, SLES and -- 2.26.2

2 1

[libvirt PATCH 0/2] glib: Avoid yet another crash due to race in event loop code
by Martin Kletzander 04 Mar '21

04 Mar '21

Similarly to commit 0db4743645b7 we need to fix the other event loop as well. To be completely honest I do not completely understand all the details in the original workaround, so I just hope this is the best way to fix the issue. Hopefully-resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1931331 Martin Kletzander (2): util: Move glib event loop workaround to glibcompat glib: Use safe glib event workaround in other event loops src/qemu/qemu_agent.c | 2 +- src/qemu/qemu_monitor.c | 2 +- src/util/glibcompat.c | 35 +++++++++++++++++++++++++++++++++++ src/util/glibcompat.h | 11 +++++++++++ src/util/vireventglib.c | 30 ------------------------------ src/util/vireventthread.c | 2 +- 6 files changed, 49 insertions(+), 33 deletions(-) -- 2.30.1

2 5

[PATCH 0/4] Refactoring node_device_conf
by Kristina Hanicova 04 Mar '21

04 Mar '21

This refactors file node_device_conf in order to remove VIR_FREE (if possible) and removes redundant variables and labels. Kristina Hanicova (4): node_device_conf: Use g_autofree where possible node_device_conf: Refactoring functions in order to remove VIR_FREE node_device_conf: use g_autoptr in virNodeDevCapPCIDevIommuGroupParseXML() node_device_conf: Remove redundant variables/labels src/conf/node_device_conf.c | 324 +++++++++++++----------------------- 1 file changed, 118 insertions(+), 206 deletions(-) -- 2.29.2

2 6

[libvirt PATCH 0/5] Some fixes in domain_conf.c: virDomainFeaturesDefParse
by Tim Wiederhake 04 Mar '21

04 Mar '21

Patches 1-4 are minor cleanups, patch 5 is the actual one that I want out of the way before continuing down my rabbit hole of the week. Tim Wiederhake (5): domain_conf: Reduce scope of tmp in virDomainFeaturesDefParse domain_conf: Reduce scope of gic_version in virDomainFeaturesDefParse domain_conf: Reduce scope of node in virDomainFeaturesDefParse domain_conf: Add missing break in switch domain_conf: Fix check for hyperv stimer src/conf/domain_conf.c | 36 ++++++++++++++---------------------- 1 file changed, 14 insertions(+), 22 deletions(-) -- 2.26.2

2 7

[libvirt PATCH] cpu_map: Fix spelling of svme-addr-chk feature
by Jiri Denemark 04 Mar '21

04 Mar '21

Commit a208176ca1d9eedf8aa6bf12fde6a7a9579ab549 introduced this feature with an incorrect "svme-addr-check" spelling. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu_map/sync_qemu_i386.py | 2 +- src/cpu_map/x86_EPYC-Milan.xml | 2 +- src/cpu_map/x86_features.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cpu_map/sync_qemu_i386.py b/src/cpu_map/sync_qemu_i386.py index 3febecdfd1..1a98fa70d7 100755 --- a/src/cpu_map/sync_qemu_i386.py +++ b/src/cpu_map/sync_qemu_i386.py @@ -142,7 +142,7 @@ def translate_feature(name): "CPUID_SS": "ss", "CPUID_SVM_NPT": "npt", "CPUID_SVM_NRIPSAVE": "nrip-save", - "CPUID_SVM_SVME_ADDR_CHK": "svme-addr-check", + "CPUID_SVM_SVME_ADDR_CHK": "svme-addr-chk", "CPUID_TSC": "tsc", "CPUID_VME": "vme", "CPUID_XSAVE_XGETBV1": "xgetbv1", diff --git a/src/cpu_map/x86_EPYC-Milan.xml b/src/cpu_map/x86_EPYC-Milan.xml index 53f0cd6aac..3055e175fa 100644 --- a/src/cpu_map/x86_EPYC-Milan.xml +++ b/src/cpu_map/x86_EPYC-Milan.xml @@ -76,7 +76,7 @@ <feature name='sse4a'/> <feature name='ssse3'/> <feature name='svm'/> - <feature name='svme-addr-check'/> + <feature name='svme-addr-chk'/> <feature name='syscall'/> <feature name='tsc'/> <feature name='umip'/> diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index c43520d08f..e98b84f3ef 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -554,7 +554,7 @@ <feature name='pfthreshold'> <cpuid eax_in='0x8000000a' edx='0x00001000'/> </feature> - <feature name='svme-addr-check'> + <feature name='svme-addr-chk'> <cpuid eax_in='0x8000000a' edx='0x10000000'/> </feature> -- 2.30.0

2 1