- Devel - libvirt List Archives

[PATCH] virsh-snapshot: Don't leak @then in cmdSnapshotList()
by Michal Privoznik 23 Aug '21

23 Aug '21

The variable is used inside a loop in which it' allocated in each iteration. Bring it inside the loop so that g_autoptr() kicks in each iteration. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-snapshot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index ee99d0e061..e08ecb6910 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1439,7 +1439,6 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd) size_t i; virDomainSnapshotPtr snapshot = NULL; long long creation_longlong; - g_autoptr(GDateTime) then = NULL; bool tree = vshCommandOptBool(cmd, "tree"); bool name = vshCommandOptBool(cmd, "name"); bool from = vshCommandOptBool(cmd, "from"); @@ -1533,6 +1532,7 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd) } for (i = 0; i < snaplist->nsnaps; i++) { + g_autoptr(GDateTime) then = NULL; g_autofree gchar *thenstr = NULL; g_autoptr(xmlDoc) xml = NULL; g_autoptr(xmlXPathContext) ctxt = NULL; -- 2.31.1

2 1

[PATCH 0/5] Allow freepage/allocpages on numactl-less builds
by Michal Privoznik 23 Aug '21

23 Aug '21

See 3/5 for explanation. Michal Prívozník (5): conf: Introduce virCapabilitiesHostNUMAGetMaxNode() virhostmem: Let caller pass max NUMA node to virHostMemGetFreePages virhostmem: Let caller pass max NUMA node to virHostMemAllocPages virhostmem: Handle numactl-less build in hugepages allocation/reporting rpm: Enable numactl on s390x libvirt.spec.in | 2 +- src/conf/capabilities.c | 9 +++++++++ src/conf/capabilities.h | 2 ++ src/libvirt_private.syms | 1 + src/lxc/lxc_driver.c | 23 +++++++++++++++++++++-- src/qemu/qemu_driver.c | 23 +++++++++++++++++++++-- src/util/virhostmem.c | 24 ++++++++++++++++++------ src/util/virhostmem.h | 2 ++ src/vbox/vbox_common.c | 20 +++++++++++++++++--- 9 files changed, 92 insertions(+), 14 deletions(-) -- 2.31.1

2 6

[PATCH v2 0/3] docs/about: some documentation clean-up/fix
by Yanan Wang 23 Aug '21

23 Aug '21

This series makes some clean-up and fix for docs/about, including removing the duplicated section, unifying the subject format, and adding the missed release record in the subject. v1->v2: - update the commit message, combined with Cornelia's comment - add the missing release record in the subject (patch #3) - v1: https://lore.kernel.org/qemu-devel/20210820015628.173532-1-wangyanan55@huaw… Yanan Wang (3): docs/about: Remove the duplicated doc docs/about: Unify the subject format docs/about: Add the missing release record in the subject docs/about/deprecated.rst | 56 ++++++++++++++++----------------- docs/about/removed-features.rst | 45 ++++++++++---------------- 2 files changed, 44 insertions(+), 57 deletions(-) -- 2.19.1

3 9

[libvirt][PATCH v6 0/6] Support query and use SGX
by Haibin Huang 23 Aug '21

23 Aug '21

This patch series provides support for enabling Intel's Software Guard Extensions (SGX) feature in guest VM. Giving the SGX support in QEMU is still pending for reviewing, this patch series is not submmited for code review, but only describe the SGX enabling solution design that contains changes to virConnectGetDomainCapabilities API response and domain definition. All comments/suggestions would be highly appreciated. Intel Software Guard Extensions (Intel® SGX) is a set of instructions that increases the security of application code and data, giving them more protection from disclosure or modification. Developers can partition sensitive information into enclaves, which are areas of execution in memory with more security protection. The typical flow looks below at very high level: 1. Calls virConnectGetDomainCapabilities API to domain capabilities that includes the following SGX information. <feature> ... <sgx supported='yes'> <epc_size unit=’KiB’>N</epc_size> </sgx> </feature> 2. User requests to start a guest calling virCreateXML() with SGX requirement. It should contain <devices> ... <memory model='sgx-epc'> <target> <size unit='KiB'>N</size> </target> </memory> ... </devices> Haibin Huang (3): Support to query SGX capability Add dommaincaps unit test add qemu capabilities version 5.2.0 Lin Yang (3): conf: Introduce SGX EPC element into device memory xml qemu: Add command-line to generate SGX EPC memory backend Add unit tests for guest VM creation command with SGX EPC docs/schemas/domaincaps.rng | 17 + docs/schemas/domaincommon.rng | 1 + src/conf/domain_capabilities.c | 29 + src/conf/domain_capabilities.h | 13 + src/conf/domain_conf.c | 4 + src/conf/domain_conf.h | 1 + src/libvirt_private.syms | 2 +- src/qemu/qemu_alias.c | 8 +- src/qemu/qemu_capabilities.c | 146 + src/qemu/qemu_capabilities.h | 6 + src/qemu/qemu_command.c | 42 +- src/qemu/qemu_domain.c | 10 +- src/qemu/qemu_monitor.c | 10 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 91 + src/qemu/qemu_monitor_json.h | 3 + src/security/security_apparmor.c | 1 + src/security/security_dac.c | 2 + src/security/security_selinux.c | 2 + tests/domaincapsdata/bhyve_basic.x86_64.xml | 1 + tests/domaincapsdata/bhyve_fbuf.x86_64.xml | 1 + tests/domaincapsdata/bhyve_uefi.x86_64.xml | 1 + tests/domaincapsdata/empty.xml | 1 + tests/domaincapsdata/libxl-xenfv.xml | 1 + tests/domaincapsdata/libxl-xenpv.xml | 1 + .../domaincapsdata/qemu_1.5.3-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_1.5.3-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_1.5.3.x86_64.xml | 1 + .../domaincapsdata/qemu_1.6.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_1.6.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_1.6.0.x86_64.xml | 1 + .../domaincapsdata/qemu_1.7.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_1.7.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_1.7.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.1.1-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.1.1-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.1.1.x86_64.xml | 1 + .../domaincapsdata/qemu_2.10.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.10.0-tcg.x86_64.xml | 1 + .../qemu_2.10.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.10.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.10.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.11.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.11.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.11.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.12.0-tcg.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.12.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.12.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.4.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.4.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.5.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.5.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.6.0-tcg.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.6.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.7.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.7.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.7.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.8.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.8.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.8.0.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_2.9.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_2.9.0.s390x.xml | 1 + tests/domaincapsdata/qemu_2.9.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.0.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_3.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_3.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_3.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.0.0-tcg.x86_64.xml | 1 + .../qemu_4.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.0.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_4.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_4.2.0-tcg.x86_64.xml | 1 + .../qemu_4.2.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_4.2.0.s390x.xml | 1 + tests/domaincapsdata/qemu_4.2.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.0.0-tcg.x86_64.xml | 1 + .../qemu_5.0.0-virt.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.aarch64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.ppc64.xml | 1 + tests/domaincapsdata/qemu_5.0.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_5.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_5.1.0.x86_64.xml | 1 + .../domaincapsdata/qemu_5.2.0-q35.x86_64.xml | 207 + .../domaincapsdata/qemu_5.2.0-tcg.x86_64.xml | 201 + tests/domaincapsdata/qemu_5.2.0.x86_64.xml | 207 + .../caps_5.2.0.x86_64.replies | 29649 ++++++++++++++++ .../caps_5.2.0.x86_64.xml | 3189 ++ .../sgx-epc.x86_64-5.1.0.args | 41 + tests/qemuxml2argvdata/sgx-epc.xml | 40 + tests/qemuxml2argvtest.c | 1 + 123 files changed, 34013 insertions(+), 9 deletions(-) create mode 100644 tests/domaincapsdata/qemu_5.2.0-q35.x86_64.xml create mode 100644 tests/domaincapsdata/qemu_5.2.0-tcg.x86_64.xml create mode 100644 tests/domaincapsdata/qemu_5.2.0.x86_64.xml create mode 100644 tests/qemucapabilitiesdata/caps_5.2.0.x86_64.replies create mode 100644 tests/qemucapabilitiesdata/caps_5.2.0.x86_64.xml create mode 100644 tests/qemuxml2argvdata/sgx-epc.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/sgx-epc.xml -- 2.17.1

3 11

Questions about the ownership of /var/cache/libvirt/qemu
by Peng Liang 23 Aug '21

23 Aug '21

Hi all, When we change the user for QEMU process (change "user" and "group" in /etc/libvirt/qemu.conf) to a normal user, we found that libvirtd will also change the ownership of /var/cache/libvirt/qemu but will keep the ownership of /var/cache/libvirt/qemu/capabilities as root. Is it secure to put files/directories owned by root in a directory owned by a normal user? Could the normal user replace the root's file with a new one? Does it need to set sticky bit on /var/cache/libvirt/qemu or keep the ownership of /var/cache/libvirt/qemu as root?

2 2

[PATCH 0/2] docs/about: some documentation clean-up
by Yanan Wang 23 Aug '21

23 Aug '21

These two patches (one of which has been reviewed) originally come from [1]. Here resend them separately as a short doc clean-up series. [1] https://lore.kernel.org/qemu-devel/20210819031027.41104-1-wangyanan55@huawe… Yanan Wang (2): docs/about: Remove the duplicated doc docs/about: Unify the subject format docs/about/deprecated.rst | 56 ++++++++++++++++----------------- docs/about/removed-features.rst | 41 +++++++++--------------- 2 files changed, 42 insertions(+), 55 deletions(-) -- 2.19.1

3 4

[libvirt PATCH 0/9] tests: cputest: use g_auto more (glib chronicles)
by Ján Tomko 20 Aug '21

20 Aug '21

Also improve the compilation times (unoptimized optimization routines take too long when there are too many branches in a function, which is the case of cputest's main) and switch qemuxml2* to use the same approach. Ján Tomko (9): qemu: monitor: define cleanup function for qemuMonitorCPUModelInfo tests: use g_auto in cpuTestMakeQEMUCaps tests: cputest: use g_auto for virQEMUCaps tests: cputest: use g_auto for virCPUData tests: cputest: use g_auto for virCPUDef tests: cputest: use g_autofree tests: cputest: remove unnecessary labels tests: cputests: introduce and use virTestRunLog tests: qemuxml2*test: switch to virRunTestLog src/qemu/qemu_monitor.h | 1 + tests/cputest.c | 239 +++++++++++----------------------- tests/qemustatusxml2xmltest.c | 3 +- tests/qemuxml2argvtest.c | 10 +- tests/qemuxml2xmltest.c | 9 +- tests/testutils.c | 30 +++++ tests/testutils.h | 4 + tests/testutilsqemu.h | 1 - 8 files changed, 114 insertions(+), 183 deletions(-) -- 2.31.1

2 10

[libvirt PATCH 0/5] virnetdevopenvswitch: fix overindented label (glib chronicles)
by Ján Tomko 20 Aug '21

20 Aug '21

By removing it, of course. Patch 1/5 also has the potential to fix the build on FreeBSD, but it failed with an internal server error for me. Ján Tomko (5): build: only build virnetdevopenvswitchtest on Linux tests: virnetdevopenvswitch: use g_auto tests: virnetdevbandwidthtest: use g_auto tests: introduce testVirNetDevBandwidthParse tests: virnetdev*: remove unnecessary labels tests/meson.build | 6 ++- tests/virnetdevbandwidthtest.c | 56 ++++++++++++------------- tests/virnetdevopenvswitchtest.c | 70 ++++++++++++++------------------ 3 files changed, 61 insertions(+), 71 deletions(-) -- 2.31.1

2 6

[PATCH 0/6] nwfilter define: add support for validation against schema
by Kristina Hanicova 20 Aug '21

20 Aug '21

Kristina Hanicova (6): api: add public virNWFilterDefineXMLFlags() and remote protocol nwfilter: add nwfilterDefineXMLFlags() api: add virNWFilterDefineFlags nwfilter_conf: add validation against schema in define nwfilter_driver: allow VIR_NWFILTER_DEFINE_VALIDATE flag virsh: add support for '--validate' option in define nwfilter docs/manpages/virsh.rst | 5 +++- include/libvirt/libvirt-nwfilter.h | 7 +++++ src/conf/nwfilter_conf.c | 13 +++++---- src/conf/nwfilter_conf.h | 3 ++- src/driver-nwfilter.h | 6 +++++ src/libvirt-nwfilter.c | 43 ++++++++++++++++++++++++++++++ src/libvirt_public.syms | 5 ++++ src/nwfilter/nwfilter_driver.c | 21 ++++++++++++--- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 18 ++++++++++++- src/remote_protocol-structs | 8 ++++++ tools/virsh-nwfilter.c | 13 ++++++++- 12 files changed, 130 insertions(+), 13 deletions(-) -- 2.31.1

2 10

[PATCH 0/4] interface define: add support for validation against schema
by Kristina Hanicova 20 Aug '21

20 Aug '21

Kristina Hanicova (4): api: add virInterfaceDefineFlags conf: add validation and propagate flags into virInterfaceDefParse() src: allow validation flag in interface define virsh: add support for '--validate' option in define interface docs/manpages/virsh.rst | 5 +++-- include/libvirt/libvirt-interface.h | 4 ++++ src/conf/interface_conf.c | 14 ++++++++------ src/conf/interface_conf.h | 3 ++- src/conf/virinterfaceobj.c | 2 +- src/interface/interface_backend_netcf.c | 6 +++--- src/libvirt-interface.c | 2 +- src/test/test_driver.c | 4 ++-- tests/interfacexml2xmltest.c | 2 +- tools/virsh-interface.c | 10 +++++++++- 10 files changed, 34 insertions(+), 18 deletions(-) -- 2.31.1

2 6

[PATCH 0/4] secret define: add support for validation against schema
by Kristina Hanicova 20 Aug '21

20 Aug '21

Kristina Hanicova (4): api: add virSecretDefineFlags secret_conf: add validation against schema in define secret_driver: allow VIR_SECRET_DEFINE_VALIDATE flag virsh: add support for '--validate' option in define secret docs/manpages/virsh.rst | 4 +++- include/libvirt/libvirt-secret.h | 5 +++++ src/conf/secret_conf.c | 13 ++++++++----- src/conf/secret_conf.h | 2 +- src/libvirt-secret.c | 2 +- src/secret/secret_driver.c | 4 ++-- tools/virsh-secret.c | 10 +++++++++- 7 files changed, 29 insertions(+), 11 deletions(-) -- 2.31.1

2 5

[PATCH v2 00/12] Implement detach device related APIs for test driver
by Luke Yue 20 Aug '21

20 Aug '21

v2: - Extract DetachXXXDeviceConfig functions from drivers and use them - Add a trial implementation of detach memballoon and TPM, if they are fine, more device support will be added to test driver in the future - Add expectError to testCompareOutputLit for some "fail on purpose" tests - Refine tests Luke Yue (12): conf: Introduce virDomainInputDefRemove and fix memory leak domain_driver: extract DetachXXXDeviceConfig related functions and use them test_driver: Implement virDomainDetachDeviceFlags test_driver: Implement virDomainDetachDeviceAlias test_driver: Implement virDomainDetachDevice conf: Add tpm helpers for future use test_driver: add TPM support for testDomainDetachDeviceLiveAndConfig conf: Add a memballoon helper for future use test_driver: add memballoon support for testDomainDetachDeviceLiveAndConfig examples: xml: test: add xml for testing devices related APIs virshtest: add expectError parameter to testCompareOutputLit tests: Test detach-device and detach-device-alias for test driver examples/xml/test/testdevcontroller.xml | 1 + examples/xml/test/testdevdiskcdrom.xml | 5 + examples/xml/test/testdevfs.xml | 6 + examples/xml/test/testdevhostdev.xml | 5 + examples/xml/test/testdevif.xml | 6 + examples/xml/test/testdevinput.xml | 1 + examples/xml/test/testdevlease.xml | 5 + examples/xml/test/testdevmem.xml | 6 + examples/xml/test/testdevmemballoon.xml | 3 + examples/xml/test/testdevrng.xml | 4 + examples/xml/test/testdevshmem.xml | 4 + examples/xml/test/testdevsound.xml | 3 + examples/xml/test/testdevtpm.xml | 5 + examples/xml/test/testdevvsock.xml | 3 + examples/xml/test/testdevwatchdog.xml | 1 + examples/xml/test/testdomfc5.xml | 54 +++++ examples/xml/test/testnodeinline.xml | 54 +++++ src/conf/domain_conf.c | 103 ++++++++ src/conf/domain_conf.h | 12 + src/hypervisor/domain_driver.c | 303 ++++++++++++++++++++++++ src/hypervisor/domain_driver.h | 47 ++++ src/libvirt_private.syms | 20 ++ src/libxl/libxl_driver.c | 41 +--- src/lxc/lxc_driver.c | 37 +-- src/qemu/qemu_driver.c | 124 ++-------- src/test/test_driver.c | 239 +++++++++++++++++++ tests/virshtest.c | 131 ++++++++-- 27 files changed, 1033 insertions(+), 190 deletions(-) create mode 100644 examples/xml/test/testdevcontroller.xml create mode 100644 examples/xml/test/testdevdiskcdrom.xml create mode 100644 examples/xml/test/testdevfs.xml create mode 100644 examples/xml/test/testdevhostdev.xml create mode 100644 examples/xml/test/testdevif.xml create mode 100644 examples/xml/test/testdevinput.xml create mode 100644 examples/xml/test/testdevlease.xml create mode 100644 examples/xml/test/testdevmem.xml create mode 100644 examples/xml/test/testdevmemballoon.xml create mode 100644 examples/xml/test/testdevrng.xml create mode 100644 examples/xml/test/testdevshmem.xml create mode 100644 examples/xml/test/testdevsound.xml create mode 100644 examples/xml/test/testdevtpm.xml create mode 100644 examples/xml/test/testdevvsock.xml create mode 100644 examples/xml/test/testdevwatchdog.xml -- 2.33.0

1 12

[libvirt PATCH 0/2] tests: use g_auto more (glib chronicles)
by Ján Tomko 20 Aug '21

20 Aug '21

Convert two more functions to use automatic cleanup. Ján Tomko (2): tests: use g_auto in testQemuGetCaps tests: use g_auto in qemuTestParseCapabilitiesArch tests/qemucaps2xmltest.c | 16 ++++++---------- tests/testutilsqemu.c | 10 +++------- 2 files changed, 9 insertions(+), 17 deletions(-) -- 2.31.1

3 4

[PATCH 0/2] qemu: block: Use correct format name when formatting overlay of qcow2+luks
by Peter Krempa 20 Aug '21

20 Aug '21

see 1/2 Peter Krempa (2): qemu: block: Use correct format name when formatting overlay of qcow2+luks qemublocktest: Add test for creating a qcow2 on top of an luks-encrypted qcow2 src/qemu/qemu_block.c | 3 ++- tests/qemublocktest.c | 1 + .../imagecreate/qcow2-backing-qcow2luks.json | 15 +++++++++++++++ .../imagecreate/qcow2-backing-qcow2luks.xml | 1 + 4 files changed, 19 insertions(+), 1 deletion(-) create mode 100644 tests/qemublocktestdata/imagecreate/qcow2-backing-qcow2luks.json create mode 120000 tests/qemublocktestdata/imagecreate/qcow2-backing-qcow2luks.xml -- 2.31.1

2 3

[PATCH] virsocket: Don't preserve errno in virSocketRecvFD()
by Michal Privoznik 20 Aug '21

20 Aug '21

When setting O_CLOEXEC flag on received FD fails the FD is closed using VIR_FORCE_CLOSE(). But the call is wrapped in errno save which is not necessary because VIR_FORCE_CLOSE() preservers errno value. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virsocket.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/util/virsocket.c b/src/util/virsocket.c index b971da16e3..a6f185114d 100644 --- a/src/util/virsocket.c +++ b/src/util/virsocket.c @@ -477,9 +477,7 @@ virSocketRecvFD(int sock, int fdflags) /* set close-on-exec flag */ if (!MSG_CMSG_CLOEXEC && (fdflags & O_CLOEXEC)) { if (virSetCloseExec(fd) < 0) { - int saved_errno = errno; VIR_FORCE_CLOSE(fd); - errno = saved_errno; return -1; } } -- 2.31.1

2 1

[PATCH RFC v6 00/12] Add riscv kvm accel support
by Yifei Jiang 20 Aug '21

20 Aug '21

This series adds both riscv32 and riscv64 kvm support, and implements migration based on riscv. It is based on temporarily unaccepted kvm: https://github.com/kvm-riscv/linux (lastest version v19). This series depends on above pending changes which haven't yet been accepted, so this QEMU patch series is treated as RFC patches until that dependency has been dealt with. Several steps to use this: 1. Build emulation $ ./configure --target-list=riscv64-softmmu $ make -j$(nproc) 2. Build kernel https://github.com/kvm-riscv/linux 3. Build QEMU VM Cross built in riscv toolchain. $ PKG_CONFIG_LIBDIR=<toolchain pkgconfig path> $ export PKG_CONFIG_SYSROOT_DIR=<toolchain sysroot path> $ ./configure --target-list=riscv64-softmmu --enable-kvm \ --cross-prefix=riscv64-linux-gnu- --disable-libiscsi --disable-glusterfs \ --disable-libusb --disable-usb-redir --audio-drv-list= --disable-opengl \ --disable-libxml2 $ make -j$(nproc) 4. Start emulation $ ./qemu-system-riscv64 -M virt -m 4096M -cpu rv64,x-h=true -nographic \ -name guest=riscv-hyp,debug-threads=on \ -smp 4 \ -bios ./fw_jump.bin \ -kernel ./Image \ -drive file=./hyp.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" 5. Start kvm-acceled QEMU VM in emulation $ ./qemu-system-riscv64 -M virt,accel=kvm -m 1024M -cpu host -nographic \ -name guest=riscv-guset \ -smp 2 \ -bios none \ -kernel ./Image \ -drive file=./guest.img,format=raw,id=hd0 \ -device virtio-blk-device,drive=hd0 \ -append "root=/dev/vda rw console=ttyS0 earlycon=sbi" Changes since RFC v5 - Rebase on QEMU v6.1.0-rc1 and kvm-riscv linux v19. - Move kvm interrupt setting to riscv_cpu_update_mip(). - Replace __u64 with uint64_t. Changes since RFC v4 - Rebase on QEMU v6.0.0-rc2 and kvm-riscv linux v17. - Remove time scaling support as software solution is incomplete. Because it will cause unacceptable performance degradation. and We will post a better solution. - Revise according to Alistair's review comments. - Remove compile time XLEN checks in kvm_riscv_reg_id - Surround TYPE_RISCV_CPU_HOST definition by CONFIG_KVM and share it between RV32 and RV64. - Add kvm-stub.c for reduce unnecessary compilation checks. - Add riscv_setup_direct_kernel() to direct boot kernel for KVM. Changes since RFC v3 - Rebase on QEMU v5.2.0-rc2 and kvm-riscv linux v15. - Add time scaling support(New patches 13, 14 and 15). - Fix the bug that guest vm can't reboot. Changes since RFC v2 - Fix checkpatch error at target/riscv/sbi_ecall_interface.h. - Add riscv migration support. Changes since RFC v1 - Add separate SBI ecall interface header. - Add riscv32 kvm accel support. Yifei Jiang (12): linux-header: Update linux/kvm.h target/riscv: Add target/riscv/kvm.c to place the public kvm interface target/riscv: Implement function kvm_arch_init_vcpu target/riscv: Implement kvm_arch_get_registers target/riscv: Implement kvm_arch_put_registers target/riscv: Support start kernel directly by KVM target/riscv: Support setting external interrupt by KVM target/riscv: Handle KVM_EXIT_RISCV_SBI exit target/riscv: Add host cpu type target/riscv: Add kvm_riscv_get/put_regs_timer target/riscv: Implement virtual time adjusting with vm state changing target/riscv: Support virtual time context synchronization hw/riscv/boot.c | 11 + hw/riscv/virt.c | 7 + include/hw/riscv/boot.h | 1 + linux-headers/linux/kvm.h | 8 + meson.build | 2 + target/riscv/cpu.c | 57 +++ target/riscv/cpu.h | 10 + target/riscv/cpu_helper.c | 27 -- target/riscv/kvm-stub.c | 30 ++ target/riscv/kvm.c | 605 +++++++++++++++++++++++++++++ target/riscv/kvm_riscv.h | 25 ++ target/riscv/machine.c | 14 + target/riscv/meson.build | 1 + target/riscv/sbi_ecall_interface.h | 72 ++++ 14 files changed, 843 insertions(+), 27 deletions(-) create mode 100644 target/riscv/kvm-stub.c create mode 100644 target/riscv/kvm.c create mode 100644 target/riscv/kvm_riscv.h create mode 100644 target/riscv/sbi_ecall_interface.h -- 2.19.1

3 14

[PATCH] fix error in printf format string
by Zhenyu Ye 19 Aug '21

19 Aug '21

Use %s to print NULLSTR(duri). Reported-by: Peng Liang <liangpeng10(a)huawei.com> Signed-off-by: Zhenyu Ye <yezhenyu2(a)huawei.com> --- src/libvirt-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 4eb14d4176..3c4204e563 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -4215,7 +4215,7 @@ virDomainMigrateToURI(virDomainPtr domain, const char *dconnuri = NULL; const char *miguri = NULL; - VIR_DOMAIN_DEBUG(domain, "duri=%p, flags=0x%lx, dname=%s, bandwidth=%lu", + VIR_DOMAIN_DEBUG(domain, "duri=%s, flags=0x%lx, dname=%s, bandwidth=%lu", NULLSTR(duri), flags, NULLSTR(dname), bandwidth); virResetLastError(); -- 2.27.0

2 1

[libvirt PATCH 0/5] Waste less CPU on syntax-check
by Ján Tomko 19 Aug '21

19 Aug '21

Use 'git ls-tree' directly instead of a wrapper script that can possibly handle all the other versioning systems we do not use. Instead of adding, removing, then re-adding the absolute path prefix, only add it once per every syntax check rule. Delete the useless-if-before-free check since we've been ignoring its output anyway. This speeds up 'ninja test' on my 8-core laptop from: 19.781 s ± 0.174 s to 15.476 s ± 1.302 s Ján Tomko (5): syntax-check: assume we're using git syntax-check: use VC_LIST_EXCEPT instead of VC_LIST syntax-check: replace vc-list-files syntax-check: drop useless useless-if-before-free syntax-check: remove _test_script_regex build-aux/syntax-check.mk | 218 ++--------------------------- build-aux/useless-if-before-free | 226 ------------------------------- build-aux/vc-list-files | 113 ---------------- 3 files changed, 9 insertions(+), 548 deletions(-) delete mode 100755 build-aux/useless-if-before-free delete mode 100755 build-aux/vc-list-files -- 2.31.1

2 6

[libvirt PATCH] ch: monitor: unref mon->vm before vm
by Ján Tomko 19 Aug '21

19 Aug '21

Do not access 'mon' after unref'ing it. Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- src/ch/ch_monitor.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c index 1648d05017..0f8752d1ed 100644 --- a/src/ch/ch_monitor.c +++ b/src/ch/ch_monitor.c @@ -543,9 +543,8 @@ void virCHMonitorClose(virCHMonitor *mon) g_free(mon->socketpath); } + virObjectUnref(mon->vm); virObjectUnref(mon); - if (mon->vm) - virObjectUnref(mon->vm); } static int -- 2.31.1

2 1

[PATCHv2 0/6] virDomain: fix problems when setting qos on ovs managed
by jx8zjs 19 Aug '21

19 Aug '21

--- diff to v1: - Modify commit message to no longer then 80 characters. - Split patch into several commits - Add notes on some function and defination - Extract common code block to a single function Thanks to Pavel Hrdina for helping to review these patches. Two problems are found and fixed below: 1. Ingress rules is not clean on previous version of virNetDevOpenvswitchInterfaceClearQos. 2. If errors occurs when removing inbound qos on multi interfaces vm, some rules may not be delete as aspected. Fix by: 1.Instead of cleaning all qos rules each time new qos is set, tx and rx's qos are set or cleaned respectively. 2.Replace virReportError with VIR_WARN to let the cleaning process continue when error occurs. 3.Add ifname into ovs querying statements, which will reduce failure of removing qos on the other interfaces of the same vm. Test virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos with dryrun method. Since commands in tests are not actually run, it is difficult to emulate some complex senario, such as set and then update qos. So basic tests are added in patches. Jinsheng Zhang (6): virnetdevovs: Add vmuuid notes on virNetDevOpenvswitchInterfaceSetQos virnetdevovs: Extract conversion parameters between virNetDevBandwidth and ovs virnetdevovs: Extract common code block to a single function virnetdevovs: Introduce virNetDevOpenvswitchInterfaceClearTxQos and virNetDevOpenvswitchInterfaceClearRxQos virnetdevovs: Fix qos cleaning residual on multi interfaces tests: add test on virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos src/libvirt_private.syms | 2 + src/util/virnetdevopenvswitch.c | 142 ++++++++++++++-------- src/util/virnetdevopenvswitch.h | 14 +++ tests/virnetdevopenvswitchtest.c | 196 ++++++++++++++++++++++++++++++- 4 files changed, 302 insertions(+), 52 deletions(-) -- 2.30.2.windows.1

2 11

[PATCH v2 0/3] Implement some blkio related APIs for test driver
by Luke Yue 19 Aug '21

19 Aug '21

v2: - Rebase to current master branch - Refine the tests Luke Yue (3): test_driver: Implement virDomainGetBlkioParameters test_driver: Implement virDomainSetBlkioParameters tests: Test BlkioParameters related functions for test driver examples/xml/test/testdomfv0.xml | 11 ++++ examples/xml/test/testnodeinline.xml | 11 ++++ src/test/meson.build | 1 + src/test/test_driver.c | 96 ++++++++++++++++++++++++++++ tests/virshtest.c | 55 ++++++++++++++++ 5 files changed, 174 insertions(+) -- 2.33.0

2 6

[PATCH] tests: Add missing test cases to vmx2xmltest
by Martin Kletzander 19 Aug '21

19 Aug '21

Commit 42b2f35d36a9e was meant to test all four combinations of serial-pipe-{server,client}-{app,vm} files, but did only add the files and by mistake duplicated the tests. Those were later removed as duplicates, so add them back in. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- This is based on top of this series: https://listman.redhat.com/archives/libvir-list/2021-August/msg00533.html For completeness sake (and CI testing) the branch is also available here: https://gitlab.com/nertpinx/libvirt/-/tree/vmx tests/vmx2xmldata/serial-pipe-client-vm.xml | 1 + tests/vmx2xmldata/serial-pipe-server-app.xml | 1 + tests/vmx2xmltest.c | 2 ++ 3 files changed, 4 insertions(+) create mode 120000 tests/vmx2xmldata/serial-pipe-client-vm.xml create mode 120000 tests/vmx2xmldata/serial-pipe-server-app.xml diff --git a/tests/vmx2xmldata/serial-pipe-client-vm.xml b/tests/vmx2xmldata/serial-pipe-client-vm.xml new file mode 120000 index 000000000000..44e3e1ee6e77 --- /dev/null +++ b/tests/vmx2xmldata/serial-pipe-client-vm.xml @@ -0,0 +1 @@ +serial-pipe.xml \ No newline at end of file diff --git a/tests/vmx2xmldata/serial-pipe-server-app.xml b/tests/vmx2xmldata/serial-pipe-server-app.xml new file mode 120000 index 000000000000..44e3e1ee6e77 --- /dev/null +++ b/tests/vmx2xmldata/serial-pipe-server-app.xml @@ -0,0 +1 @@ +serial-pipe.xml \ No newline at end of file diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index c97c4c045e95..33bf24371743 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -271,6 +271,8 @@ mymain(void) DO_TEST("serial-file"); DO_TEST("serial-device"); DO_TEST("serial-pipe-client-app"); + DO_TEST("serial-pipe-client-vm"); + DO_TEST("serial-pipe-server-app"); DO_TEST("serial-pipe-server-vm"); DO_TEST("serial-network-server"); DO_TEST("serial-network-client"); -- 2.32.0

2 1

[PATCH 0/6] qemu: Fixes and capability update for 6.1 release
by Peter Krempa 19 Aug '21

19 Aug '21

full version is at: git fetch https://gitlab.com/pipo.sk/libvirt.git qemu-caps-bump Posting this one early since it's updating tests to prevent spurious changes and improve testing of host-model cpus. Peter Krempa (6): qemuxml2argvdata: Don't use 'host-model' cpu in 'hugepages-memaccess3' qemuxml2argvtest: Unify 'cpu-tsc-frequency' and 'cpu-tsc-high-frequency' case qemuxml2argvtest: Slightly modernize "cpu-host-model" case qemuxml2argvtest: Add 'cpu-host-model' cases for all x86-64 real qemu caps versions qemucapabilitiesdata: Update qemu caps dump for 6.1.0 release qemuxml2argvtest: Add LATEST version of 'cpu-host-model' .../domaincapsdata/qemu_6.1.0-q35.x86_64.xml | 4 +- tests/domaincapsdata/qemu_6.1.0.x86_64.xml | 4 +- .../caps_6.1.0.x86_64.replies | 508 +++++++++--------- .../caps_6.1.0.x86_64.xml | 12 +- tests/qemuxml2argvdata/cpu-host-model.args | 14 +- .../cpu-host-model.x86_64-2.11.0.args | 35 ++ .../cpu-host-model.x86_64-2.12.0.args | 35 ++ .../cpu-host-model.x86_64-3.0.0.args | 35 ++ .../cpu-host-model.x86_64-3.1.0.args | 35 ++ .../cpu-host-model.x86_64-4.0.0.args | 35 ++ .../cpu-host-model.x86_64-4.1.0.args | 35 ++ .../cpu-host-model.x86_64-4.2.0.args | 35 ++ .../cpu-host-model.x86_64-5.0.0.args | 35 ++ .../cpu-host-model.x86_64-5.1.0.args | 35 ++ .../cpu-host-model.x86_64-5.2.0.args | 36 ++ ....args => cpu-host-model.x86_64-6.0.0.args} | 11 +- .../cpu-host-model.x86_64-6.1.0.args | 36 ++ .../cpu-host-model.x86_64-latest.args | 36 ++ tests/qemuxml2argvdata/cpu-host-model.xml | 14 +- tests/qemuxml2argvdata/cpu-tsc-frequency.args | 2 +- .../cpu-tsc-frequency.x86_64-4.0.0.args | 2 +- tests/qemuxml2argvdata/cpu-tsc-frequency.xml | 2 +- .../cpu-tsc-high-frequency.xml | 35 -- .../hugepages-memaccess3.x86_64-latest.args | 2 +- .../qemuxml2argvdata/hugepages-memaccess3.xml | 3 - tests/qemuxml2argvtest.c | 28 +- 26 files changed, 740 insertions(+), 324 deletions(-) create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-2.11.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-2.12.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-3.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-3.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-4.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-4.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-4.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-5.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-5.2.0.args rename tests/qemuxml2argvdata/{cpu-tsc-high-frequency.x86_64-latest.args => cpu-host-model.x86_64-6.0.0.args} (72%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-tsc-high-frequency.xml -- 2.31.1

2 7

[PATCH 0/3] vmx: Drop useless prefix for test cases
by Michal Privoznik 19 Aug '21

19 Aug '21

You can find these also here: https://gitlab.com/MichalPrivoznik/libvirt/-/tree/vmx_floppy Michal Prívozník (3): vmx2xmltest: Drop duplicate testcases vmx2xmltest: Deduplicate DO_TEST*() arguments tests: Drop vmx2xml- prefix for vmx2xml test cases ...{vmx2xml-annotation.vmx => annotation.vmx} | 0 ...{vmx2xml-annotation.xml => annotation.xml} | 0 ...sensitive-1.vmx => case-insensitive-1.vmx} | 0 ...sensitive-1.xml => case-insensitive-1.xml} | 0 ...sensitive-2.vmx => case-insensitive-2.vmx} | 0 ...sensitive-2.xml => case-insensitive-2.xml} | 0 ...om-ide-device.vmx => cdrom-ide-device.vmx} | 0 ...om-ide-device.xml => cdrom-ide-device.xml} | 0 ...-ide-empty-2.vmx => cdrom-ide-empty-2.vmx} | 0 ...-ide-empty-2.xml => cdrom-ide-empty-2.xml} | 0 ...drom-ide-empty.vmx => cdrom-ide-empty.vmx} | 0 ...drom-ide-empty.xml => cdrom-ide-empty.xml} | 0 ...x => cdrom-ide-file-missing-datastore.vmx} | 0 .../cdrom-ide-file-missing-datastore.xml | 1 + ...le.vmx => cdrom-ide-file-missing-file.vmx} | 0 .../cdrom-ide-file-missing-file.xml | 1 + ...-cdrom-ide-file.vmx => cdrom-ide-file.vmx} | 0 ...-cdrom-ide-file.xml => cdrom-ide-file.xml} | 0 ...tect.vmx => cdrom-ide-raw-auto-detect.vmx} | 0 ...tect.xml => cdrom-ide-raw-auto-detect.xml} | 0 ...aw-device.vmx => cdrom-ide-raw-device.vmx} | 0 ...aw-device.xml => cdrom-ide-raw-device.xml} | 0 ...-scsi-device.vmx => cdrom-scsi-device.vmx} | 0 ...-scsi-device.xml => cdrom-scsi-device.xml} | 0 ...om-scsi-empty.vmx => cdrom-scsi-empty.vmx} | 0 ...om-scsi-empty.xml => cdrom-scsi-empty.xml} | 0 ...drom-scsi-file.vmx => cdrom-scsi-file.vmx} | 0 ...drom-scsi-file.xml => cdrom-scsi-file.xml} | 0 ...i-passthru.vmx => cdrom-scsi-passthru.vmx} | 0 ...i-passthru.xml => cdrom-scsi-passthru.xml} | 0 ...ect.vmx => cdrom-scsi-raw-auto-detect.vmx} | 0 ...ect.xml => cdrom-scsi-raw-auto-detect.xml} | 0 ...w-device.vmx => cdrom-scsi-raw-device.vmx} | 0 ...w-device.xml => cdrom-scsi-raw-device.xml} | 0 ...-datacenterpath.vmx => datacenterpath.vmx} | 0 ...-datacenterpath.xml => datacenterpath.xml} | 0 ...n-the-wild-1.vmx => esx-in-the-wild-1.vmx} | 0 ...n-the-wild-1.xml => esx-in-the-wild-1.xml} | 0 ...the-wild-10.vmx => esx-in-the-wild-10.vmx} | 0 ...the-wild-10.xml => esx-in-the-wild-10.xml} | 0 ...the-wild-11.vmx => esx-in-the-wild-11.vmx} | 0 ...the-wild-11.xml => esx-in-the-wild-11.xml} | 0 ...n-the-wild-2.vmx => esx-in-the-wild-2.vmx} | 0 ...n-the-wild-2.xml => esx-in-the-wild-2.xml} | 0 ...n-the-wild-3.vmx => esx-in-the-wild-3.vmx} | 0 ...n-the-wild-3.xml => esx-in-the-wild-3.xml} | 0 ...n-the-wild-4.vmx => esx-in-the-wild-4.vmx} | 0 ...n-the-wild-4.xml => esx-in-the-wild-4.xml} | 0 ...n-the-wild-5.vmx => esx-in-the-wild-5.vmx} | 0 ...n-the-wild-5.xml => esx-in-the-wild-5.xml} | 0 ...n-the-wild-6.vmx => esx-in-the-wild-6.vmx} | 0 ...n-the-wild-6.xml => esx-in-the-wild-6.xml} | 0 ...n-the-wild-7.vmx => esx-in-the-wild-7.vmx} | 0 ...n-the-wild-7.xml => esx-in-the-wild-7.xml} | 0 ...n-the-wild-8.vmx => esx-in-the-wild-8.vmx} | 0 ...n-the-wild-8.xml => esx-in-the-wild-8.xml} | 0 ...n-the-wild-9.vmx => esx-in-the-wild-9.vmx} | 0 ...n-the-wild-9.xml => esx-in-the-wild-9.xml} | 0 ...ernet-bridged.vmx => ethernet-bridged.vmx} | 0 ...ernet-bridged.xml => ethernet-bridged.xml} | 0 ...thernet-custom.vmx => ethernet-custom.vmx} | 0 ...thernet-custom.xml => ethernet-custom.xml} | 0 ...-ethernet-e1000.vmx => ethernet-e1000.vmx} | 0 ...-ethernet-e1000.xml => ethernet-e1000.xml} | 0 ...t-generated.vmx => ethernet-generated.vmx} | 0 ...t-generated.xml => ethernet-generated.xml} | 0 ...2xml-ethernet-nat.vmx => ethernet-nat.vmx} | 0 ...2xml-ethernet-nat.xml => ethernet-nat.xml} | 0 ...-ethernet-other.vmx => ethernet-other.vmx} | 0 ...-ethernet-other.xml => ethernet-other.xml} | 0 ...thernet-static.vmx => ethernet-static.vmx} | 0 ...thernet-static.xml => ethernet-static.xml} | 0 ...ernet-vmxnet2.vmx => ethernet-vmxnet2.vmx} | 0 ...ernet-vmxnet2.xml => ethernet-vmxnet2.xml} | 0 ...2xml-ethernet-vpx.vmx => ethernet-vpx.vmx} | 0 ...2xml-ethernet-vpx.xml => ethernet-vpx.xml} | 0 ...2xml-firmware-efi.vmx => firmware-efi.vmx} | 0 ...2xml-firmware-efi.xml => firmware-efi.xml} | 0 ...ml-floppy-device.vmx => floppy-device.vmx} | 0 ...ml-floppy-device.xml => floppy-device.xml} | 0 ...mx2xml-floppy-file.vmx => floppy-file.vmx} | 0 ...mx2xml-floppy-file.xml => floppy-file.xml} | 0 ...he-wild-1.vmx => fusion-in-the-wild-1.vmx} | 0 ...he-wild-1.xml => fusion-in-the-wild-1.xml} | 0 ...2xml-graphics-vnc.vmx => graphics-vnc.vmx} | 0 ...2xml-graphics-vnc.xml => graphics-vnc.xml} | 0 ...n-the-wild-1.vmx => gsx-in-the-wild-1.vmx} | 0 ...n-the-wild-1.xml => gsx-in-the-wild-1.xml} | 0 ...n-the-wild-2.vmx => gsx-in-the-wild-2.vmx} | 0 ...n-the-wild-2.xml => gsx-in-the-wild-2.xml} | 0 ...n-the-wild-3.vmx => gsx-in-the-wild-3.vmx} | 0 ...n-the-wild-3.xml => gsx-in-the-wild-3.xml} | 0 ...n-the-wild-4.vmx => gsx-in-the-wild-4.vmx} | 0 ...n-the-wild-4.xml => gsx-in-the-wild-4.xml} | 0 ...> harddisk-ide-file-missing-datastore.vmx} | 0 ...isk-ide-file.vmx => harddisk-ide-file.vmx} | 0 ...isk-ide-file.xml => harddisk-ide-file.xml} | 0 ...mx => harddisk-scsi-file-missing-file.vmx} | 0 ...k-scsi-file.vmx => harddisk-scsi-file.vmx} | 0 ...k-scsi-file.xml => harddisk-scsi-file.xml} | 0 ...k-transient.vmx => harddisk-transient.vmx} | 0 ...k-transient.xml => harddisk-transient.xml} | 0 ...ml-minimal-64bit.vmx => minimal-64bit.vmx} | 0 ...ml-minimal-64bit.xml => minimal-64bit.xml} | 0 .../{vmx2xml-minimal.vmx => minimal.vmx} | 0 .../{vmx2xml-minimal.xml => minimal.xml} | 0 ...arallel-device.vmx => parallel-device.vmx} | 0 ...arallel-device.xml => parallel-device.xml} | 0 ...ml-parallel-file.vmx => parallel-file.vmx} | 0 ...ml-parallel-file.xml => parallel-file.xml} | 0 ...mx2xml-scsi-driver.vmx => scsi-driver.vmx} | 0 ...mx2xml-scsi-driver.xml => scsi-driver.xml} | 0 ...writethrough.vmx => scsi-writethrough.vmx} | 0 ...writethrough.xml => scsi-writethrough.xml} | 0 ...ml-serial-device.vmx => serial-device.vmx} | 0 ...ml-serial-device.xml => serial-device.xml} | 0 ...mx2xml-serial-file.vmx => serial-file.vmx} | 0 ...mx2xml-serial-file.xml => serial-file.xml} | 0 ...k-client.vmx => serial-network-client.vmx} | 0 ...k-client.xml => serial-network-client.xml} | 0 ...k-server.vmx => serial-network-server.vmx} | 0 ...k-server.xml => serial-network-server.xml} | 0 ...ent-app.vmx => serial-pipe-client-app.vmx} | 0 tests/vmx2xmldata/serial-pipe-client-app.xml | 1 + ...lient-vm.vmx => serial-pipe-client-vm.vmx} | 0 ...ver-app.vmx => serial-pipe-server-app.vmx} | 0 ...erver-vm.vmx => serial-pipe-server-vm.vmx} | 0 tests/vmx2xmldata/serial-pipe-server-vm.xml | 1 + ...mx2xml-serial-pipe.xml => serial-pipe.xml} | 0 ...2xml-sharedfolder.vmx => sharedfolder.vmx} | 0 ...2xml-sharedfolder.xml => sharedfolder.xml} | 0 .../{vmx2xml-smbios.vmx => smbios.vmx} | 0 .../{vmx2xml-smbios.xml => smbios.xml} | 0 .../{vmx2xml-svga.vmx => svga.vmx} | 0 .../{vmx2xml-svga.xml => svga.xml} | 0 ...in-the-wild-1.vmx => ws-in-the-wild-1.vmx} | 0 ...in-the-wild-1.xml => ws-in-the-wild-1.xml} | 0 ...in-the-wild-2.vmx => ws-in-the-wild-2.vmx} | 0 ...in-the-wild-2.xml => ws-in-the-wild-2.xml} | 0 tests/vmx2xmltest.c | 206 +++++++++--------- 140 files changed, 105 insertions(+), 105 deletions(-) rename tests/vmx2xmldata/{vmx2xml-annotation.vmx => annotation.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-annotation.xml => annotation.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-case-insensitive-1.vmx => case-insensitive-1.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-case-insensitive-1.xml => case-insensitive-1.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-case-insensitive-2.vmx => case-insensitive-2.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-case-insensitive-2.xml => case-insensitive-2.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-device.vmx => cdrom-ide-device.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-device.xml => cdrom-ide-device.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-empty-2.vmx => cdrom-ide-empty-2.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-empty-2.xml => cdrom-ide-empty-2.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-empty.vmx => cdrom-ide-empty.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-empty.xml => cdrom-ide-empty.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-file-missing-datastore.vmx => cdrom-ide-file-missing-datastore.vmx} (100%) create mode 120000 tests/vmx2xmldata/cdrom-ide-file-missing-datastore.xml rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-file-missing-file.vmx => cdrom-ide-file-missing-file.vmx} (100%) create mode 120000 tests/vmx2xmldata/cdrom-ide-file-missing-file.xml rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-file.vmx => cdrom-ide-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-file.xml => cdrom-ide-file.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-raw-auto-detect.vmx => cdrom-ide-raw-auto-detect.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-raw-auto-detect.xml => cdrom-ide-raw-auto-detect.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-raw-device.vmx => cdrom-ide-raw-device.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-ide-raw-device.xml => cdrom-ide-raw-device.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-device.vmx => cdrom-scsi-device.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-device.xml => cdrom-scsi-device.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-empty.vmx => cdrom-scsi-empty.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-empty.xml => cdrom-scsi-empty.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-file.vmx => cdrom-scsi-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-file.xml => cdrom-scsi-file.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-passthru.vmx => cdrom-scsi-passthru.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-passthru.xml => cdrom-scsi-passthru.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-raw-auto-detect.vmx => cdrom-scsi-raw-auto-detect.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-raw-auto-detect.xml => cdrom-scsi-raw-auto-detect.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-raw-device.vmx => cdrom-scsi-raw-device.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-cdrom-scsi-raw-device.xml => cdrom-scsi-raw-device.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-datacenterpath.vmx => datacenterpath.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-datacenterpath.xml => datacenterpath.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-1.vmx => esx-in-the-wild-1.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-1.xml => esx-in-the-wild-1.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-10.vmx => esx-in-the-wild-10.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-10.xml => esx-in-the-wild-10.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-11.vmx => esx-in-the-wild-11.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-11.xml => esx-in-the-wild-11.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-2.vmx => esx-in-the-wild-2.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-2.xml => esx-in-the-wild-2.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-3.vmx => esx-in-the-wild-3.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-3.xml => esx-in-the-wild-3.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-4.vmx => esx-in-the-wild-4.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-4.xml => esx-in-the-wild-4.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-5.vmx => esx-in-the-wild-5.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-5.xml => esx-in-the-wild-5.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-6.vmx => esx-in-the-wild-6.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-6.xml => esx-in-the-wild-6.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-7.vmx => esx-in-the-wild-7.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-7.xml => esx-in-the-wild-7.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-8.vmx => esx-in-the-wild-8.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-8.xml => esx-in-the-wild-8.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-9.vmx => esx-in-the-wild-9.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-esx-in-the-wild-9.xml => esx-in-the-wild-9.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-bridged.vmx => ethernet-bridged.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-bridged.xml => ethernet-bridged.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-custom.vmx => ethernet-custom.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-custom.xml => ethernet-custom.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-e1000.vmx => ethernet-e1000.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-e1000.xml => ethernet-e1000.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-generated.vmx => ethernet-generated.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-generated.xml => ethernet-generated.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-nat.vmx => ethernet-nat.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-nat.xml => ethernet-nat.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-other.vmx => ethernet-other.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-other.xml => ethernet-other.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-static.vmx => ethernet-static.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-static.xml => ethernet-static.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-vmxnet2.vmx => ethernet-vmxnet2.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-vmxnet2.xml => ethernet-vmxnet2.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-vpx.vmx => ethernet-vpx.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ethernet-vpx.xml => ethernet-vpx.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-firmware-efi.vmx => firmware-efi.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-firmware-efi.xml => firmware-efi.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-floppy-device.vmx => floppy-device.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-floppy-device.xml => floppy-device.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-floppy-file.vmx => floppy-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-floppy-file.xml => floppy-file.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-fusion-in-the-wild-1.vmx => fusion-in-the-wild-1.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-fusion-in-the-wild-1.xml => fusion-in-the-wild-1.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-graphics-vnc.vmx => graphics-vnc.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-graphics-vnc.xml => graphics-vnc.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-1.vmx => gsx-in-the-wild-1.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-1.xml => gsx-in-the-wild-1.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-2.vmx => gsx-in-the-wild-2.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-2.xml => gsx-in-the-wild-2.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-3.vmx => gsx-in-the-wild-3.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-3.xml => gsx-in-the-wild-3.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-4.vmx => gsx-in-the-wild-4.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-gsx-in-the-wild-4.xml => gsx-in-the-wild-4.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-ide-file-missing-datastore.vmx => harddisk-ide-file-missing-datastore.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-ide-file.vmx => harddisk-ide-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-ide-file.xml => harddisk-ide-file.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-scsi-file-missing-file.vmx => harddisk-scsi-file-missing-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-scsi-file.vmx => harddisk-scsi-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-scsi-file.xml => harddisk-scsi-file.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-transient.vmx => harddisk-transient.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-harddisk-transient.xml => harddisk-transient.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-minimal-64bit.vmx => minimal-64bit.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-minimal-64bit.xml => minimal-64bit.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-minimal.vmx => minimal.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-minimal.xml => minimal.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-parallel-device.vmx => parallel-device.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-parallel-device.xml => parallel-device.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-parallel-file.vmx => parallel-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-parallel-file.xml => parallel-file.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-scsi-driver.vmx => scsi-driver.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-scsi-driver.xml => scsi-driver.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-scsi-writethrough.vmx => scsi-writethrough.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-scsi-writethrough.xml => scsi-writethrough.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-device.vmx => serial-device.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-device.xml => serial-device.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-file.vmx => serial-file.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-file.xml => serial-file.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-network-client.vmx => serial-network-client.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-network-client.xml => serial-network-client.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-network-server.vmx => serial-network-server.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-network-server.xml => serial-network-server.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-pipe-client-app.vmx => serial-pipe-client-app.vmx} (100%) create mode 120000 tests/vmx2xmldata/serial-pipe-client-app.xml rename tests/vmx2xmldata/{vmx2xml-serial-pipe-client-vm.vmx => serial-pipe-client-vm.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-pipe-server-app.vmx => serial-pipe-server-app.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-serial-pipe-server-vm.vmx => serial-pipe-server-vm.vmx} (100%) create mode 120000 tests/vmx2xmldata/serial-pipe-server-vm.xml rename tests/vmx2xmldata/{vmx2xml-serial-pipe.xml => serial-pipe.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-sharedfolder.vmx => sharedfolder.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-sharedfolder.xml => sharedfolder.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-smbios.vmx => smbios.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-smbios.xml => smbios.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-svga.vmx => svga.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-svga.xml => svga.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ws-in-the-wild-1.vmx => ws-in-the-wild-1.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ws-in-the-wild-1.xml => ws-in-the-wild-1.xml} (100%) rename tests/vmx2xmldata/{vmx2xml-ws-in-the-wild-2.vmx => ws-in-the-wild-2.vmx} (100%) rename tests/vmx2xmldata/{vmx2xml-ws-in-the-wild-2.xml => ws-in-the-wild-2.xml} (100%) -- 2.31.1

3 6

[libvirt PATCH] ci: mark unstable sid containers as optional
by Ján Tomko 18 Aug '21

18 Aug '21

Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- .gitlab-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d1609c260d..5e61de3ad8 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -260,7 +260,7 @@ s390x-debian-10-container: NAME: debian-10-cross-s390x aarch64-debian-sid-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-sid-cross-aarch64 @@ -275,12 +275,12 @@ armv7l-debian-sid-container: NAME: debian-sid-cross-armv7l i686-debian-sid-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-sid-cross-i686 mips64el-debian-sid-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-sid-cross-mips64el @@ -295,7 +295,7 @@ ppc64le-debian-sid-container: NAME: debian-sid-cross-ppc64le s390x-debian-sid-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-sid-cross-s390x -- 2.31.1

3 5

[PATCH 0/3] Implement some BlkioParameters related APIs for test driver
by Luke Yue 18 Aug '21

18 Aug '21

- Implement virDomainGetBlkioParameters - Implement virDomainSetBlkioParameters - Add tests for these APIs Luke Yue (3): test_driver: Implement virDomainGetBlkioParameters test_driver: Implement virDomainSetBlkioParameters tests: Test BlkioParameters related functions for test driver examples/xml/test/testdomfv0.xml | 11 ++++ examples/xml/test/testnodeinline.xml | 11 ++++ src/test/meson.build | 1 + src/test/test_driver.c | 96 ++++++++++++++++++++++++++++ tests/virshtest.c | 36 +++++++++++ 5 files changed, 155 insertions(+) -- 2.32.0

2 6

[libvirt PATCH v2] ci: Shuffle builds between Debian 10 and Debian sid
by Andrea Bolognani 18 Aug '21

18 Aug '21

Debian sid is currently broken on mips64el and s390x, so use Debian 10 for those specific builds and move other architectures (armv7l and ppc64le) from Debian 10 to Debian sid to maintain the rough 1:1 split. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/355069168 Still running, but all Debian builds have already completed successfully. Changes from [v1]: * also swap s390x and ppc64le. [v1] https://listman.redhat.com/archives/libvir-list/2021-August/msg00515.html .gitlab-ci.yml | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d1609c260d..a7197b557c 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -225,7 +225,7 @@ armv6l-debian-10-container: NAME: debian-10-cross-armv6l armv7l-debian-10-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-10-cross-armv7l @@ -240,7 +240,7 @@ mips-debian-10-container: NAME: debian-10-cross-mips mips64el-debian-10-container: - extends: .container_optional_job + extends: .container_job variables: NAME: debian-10-cross-mips64el @@ -250,12 +250,12 @@ mipsel-debian-10-container: NAME: debian-10-cross-mipsel ppc64le-debian-10-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-10-cross-ppc64le s390x-debian-10-container: - extends: .container_optional_job + extends: .container_job variables: NAME: debian-10-cross-s390x @@ -270,7 +270,7 @@ armv6l-debian-sid-container: NAME: debian-sid-cross-armv6l armv7l-debian-sid-container: - extends: .container_optional_job + extends: .container_job variables: NAME: debian-sid-cross-armv7l @@ -280,7 +280,7 @@ i686-debian-sid-container: NAME: debian-sid-cross-i686 mips64el-debian-sid-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-sid-cross-mips64el @@ -290,12 +290,12 @@ mipsel-debian-sid-container: NAME: debian-sid-cross-mipsel ppc64le-debian-sid-container: - extends: .container_optional_job + extends: .container_job variables: NAME: debian-sid-cross-ppc64le s390x-debian-sid-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-sid-cross-s390x @@ -473,12 +473,12 @@ armv6l-debian-10: NAME: debian-10 CROSS: armv6l -armv7l-debian-10: +armv7l-debian-sid: extends: .cross_build_job needs: - - armv7l-debian-10-container + - armv7l-debian-sid-container variables: - NAME: debian-10 + NAME: debian-sid CROSS: armv7l i686-debian-sid: @@ -497,12 +497,12 @@ mips-debian-10: NAME: debian-10 CROSS: mips -mips64el-debian-sid: +mips64el-debian-10: extends: .cross_build_job needs: - - mips64el-debian-sid-container + - mips64el-debian-10-container variables: - NAME: debian-sid + NAME: debian-10 CROSS: mips64el mipsel-debian-10: @@ -513,20 +513,20 @@ mipsel-debian-10: NAME: debian-10 CROSS: mipsel -ppc64le-debian-10: +ppc64le-debian-sid: extends: .cross_build_job needs: - - ppc64le-debian-10-container + - ppc64le-debian-sid-container variables: - NAME: debian-10 + NAME: debian-sid CROSS: ppc64le -s390x-debian-sid: +s390x-debian-10: extends: .cross_build_job needs: - - s390x-debian-sid-container + - s390x-debian-10-container variables: - NAME: debian-sid + NAME: debian-10 CROSS: s390x mingw32-fedora-rawhide: -- 2.31.1

2 3

[PATCH] virsh: Support vhostuser in attach-interface
by Michal Privoznik 18 Aug '21

18 Aug '21

Recently, I wanted to attach an vhost-user interface but found out that attach-interface command doesn't support it. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/manpages/virsh.rst | 11 ++++++++++- tools/virsh-completer-domain.c | 19 +++++++++++++++++++ tools/virsh-completer-domain.h | 5 +++++ tools/virsh-domain.c | 32 ++++++++++++++++++++++++++++++-- tools/virsh-domain.h | 8 ++++++++ 5 files changed, 72 insertions(+), 3 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 20936994ce..8a875d0d2e 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4676,6 +4676,7 @@ attach-interface [--target target] [--mac mac] [--script script] [--model model] [--inbound average,peak,burst,floor] [--outbound average,peak,burst] [--alias alias] [--managed] [--print-xml] + [--source-mode mode] Attach a new network interface to the domain. @@ -4689,7 +4690,9 @@ Attach a new network interface to the domain. interfaces or bridges, *hostdev* to indicate connection using a passthrough of PCI device -on the host. +on the host, + +*vhostuser* to indicate connection using a virtio transport protocol. ``source`` indicates the source of the connection. The source depends on the type of the interface: @@ -4703,6 +4706,8 @@ on the type of the interface: *hostdev* the PCI address of the host's interface formatted as domain:bus:slot.function. +*vhostuser* the path to UNIX socket (control plane) + ``--target`` is used to specify the tap/macvtap device to be used to connect the domain to the source. Names starting with 'vnet' are considered as auto-generated and are blanked out/regenerated each @@ -4737,6 +4742,10 @@ Network XML documentation at that the interface should be managed, which means detached and reattached from/to the host by libvirt. +``--source-mode`` is mandatory for *vhostuser* interface and accepts values +*server* and *client* that control whether hypervisor waits for the other +process to connect, or initiates connection, respectively. + If ``--print-xml`` is specified, then the XML of the interface that would be attached is printed instead. diff --git a/tools/virsh-completer-domain.c b/tools/virsh-completer-domain.c index c86d8e8156..3ef6c82388 100644 --- a/tools/virsh-completer-domain.c +++ b/tools/virsh-completer-domain.c @@ -372,6 +372,25 @@ virshDomainInterfaceAddrSourceCompleter(vshControl *ctl G_GNUC_UNUSED, } +char ** +virshDomainInterfaceSourceModeCompleter(vshControl *ctl G_GNUC_UNUSED, + const vshCmd *cmd G_GNUC_UNUSED, + unsigned int flags) +{ + char **ret = NULL; + size_t i; + + virCheckFlags(0, NULL); + + ret = g_new0(char *, VIRSH_DOMAIN_INTERFACE_SOURCE_MODE_LAST); + + for (i = 0; i < VIRSH_DOMAIN_INTERFACE_SOURCE_MODE_LAST; i++) + ret[i] = g_strdup(virshDomainInterfaceSourceModeTypeToString(i)); + + return ret; +} + + char ** virshDomainHostnameSourceCompleter(vshControl *ctl G_GNUC_UNUSED, const vshCmd *cmd G_GNUC_UNUSED, diff --git a/tools/virsh-completer-domain.h b/tools/virsh-completer-domain.h index 45380906f9..39cedf0141 100644 --- a/tools/virsh-completer-domain.h +++ b/tools/virsh-completer-domain.h @@ -59,6 +59,11 @@ virshDomainInterfaceAddrSourceCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); +char ** +virshDomainInterfaceSourceModeCompleter(vshControl *ctl, + const vshCmd *cmd, + unsigned int flags); + char ** virshDomainHostnameSourceCompleter(vshControl *ctl, const vshCmd *cmd, unsigned int flags); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 62912aaf01..e5bd1fdd75 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -831,9 +831,19 @@ static const vshCmdOptDef opts_attach_interface[] = { .type = VSH_OT_BOOL, .help = N_("libvirt will automatically detach/attach the device from/to host") }, + {.name = "source-mode", + .type = VSH_OT_STRING, + .completer = virshDomainInterfaceSourceModeCompleter, + .help = N_("mode attribute of <source/> element") + }, {.name = NULL} }; +VIR_ENUM_IMPL(virshDomainInterfaceSourceMode, + VIRSH_DOMAIN_INTERFACE_SOURCE_MODE_LAST, + "server", + "client"); + /* parse inbound and outbound which are in the format of * 'average,peak,burst,floor', in which peak and burst are optional, * thus 'average,,burst' and 'average,peak' are also legal. */ @@ -881,6 +891,8 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) const char *mac = NULL, *target = NULL, *script = NULL, *type = NULL, *source = NULL, *model = NULL, *inboundStr = NULL, *outboundStr = NULL, *alias = NULL; + const char *sourceModeStr = NULL; + int sourceMode = -1; virNetDevBandwidthRate inbound, outbound; virDomainNetType typ; int ret; @@ -911,7 +923,8 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) vshCommandOptStringReq(ctl, cmd, "model", &model) < 0 || vshCommandOptStringReq(ctl, cmd, "alias", &alias) < 0 || vshCommandOptStringReq(ctl, cmd, "inbound", &inboundStr) < 0 || - vshCommandOptStringReq(ctl, cmd, "outbound", &outboundStr) < 0) + vshCommandOptStringReq(ctl, cmd, "outbound", &outboundStr) < 0 || + vshCommandOptStringReq(ctl, cmd, "source-mode", &sourceModeStr) < 0) return false; /* check interface type */ @@ -921,6 +934,12 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) return false; } + if (sourceModeStr && + (sourceMode = virshDomainInterfaceSourceModeTypeFromString(sourceModeStr)) < 0) { + vshError(ctl, _("Invalid source mode: %s"), sourceModeStr); + return false; + } + if (inboundStr) { memset(&inbound, 0, sizeof(inbound)); if (virshParseRateStr(ctl, inboundStr, &inbound) < 0) @@ -981,9 +1000,18 @@ cmdAttachInterface(vshControl *ctl, const vshCmd *cmd) break; } + case VIR_DOMAIN_NET_TYPE_VHOSTUSER: + if (sourceMode < 0) { + vshError(ctl, _("source-mode is mandatory")); + return false; + } + virBufferAsprintf(&buf, "<source type='unix' path='%s' mode='%s'/>\n", + source, + virshDomainInterfaceSourceModeTypeToString(sourceMode)); + break; + case VIR_DOMAIN_NET_TYPE_USER: case VIR_DOMAIN_NET_TYPE_ETHERNET: - case VIR_DOMAIN_NET_TYPE_VHOSTUSER: case VIR_DOMAIN_NET_TYPE_SERVER: case VIR_DOMAIN_NET_TYPE_CLIENT: case VIR_DOMAIN_NET_TYPE_MCAST: diff --git a/tools/virsh-domain.h b/tools/virsh-domain.h index a1ac1cf1d4..cf5ce28825 100644 --- a/tools/virsh-domain.h +++ b/tools/virsh-domain.h @@ -38,6 +38,14 @@ typedef enum { VIR_ENUM_DECL(virshDomainHostnameSource); +typedef enum { + VIRSH_DOMAIN_INTERFACE_SOURCE_MODE_SERVER, + VIRSH_DOMAIN_INTERFACE_SOURCE_MODE_CLIENT, + VIRSH_DOMAIN_INTERFACE_SOURCE_MODE_LAST +} virshDomainInterfaceSourceMode; + +VIR_ENUM_DECL(virshDomainInterfaceSourceMode); + extern const vshCmdDef domManagementCmds[]; VIR_ENUM_DECL(virshDomainProcessSignal); -- 2.31.1

2 1

[libvirt PATCH] ci: Swap mips64el and armv7l builds
by Andrea Bolognani 18 Aug '21

18 Aug '21

Debian sid is currently broken on mips64el, so use Debian 10 for that specific build and move a different architecture (armv7l) from Debian 10 to Debian sid to maintain the rough 1:1 split. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/355057402 Just started, but I'm optimistic about the outcome :) .gitlab-ci.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d1609c260d..c1bca36a93 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -225,7 +225,7 @@ armv6l-debian-10-container: NAME: debian-10-cross-armv6l armv7l-debian-10-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-10-cross-armv7l @@ -240,7 +240,7 @@ mips-debian-10-container: NAME: debian-10-cross-mips mips64el-debian-10-container: - extends: .container_optional_job + extends: .container_job variables: NAME: debian-10-cross-mips64el @@ -270,7 +270,7 @@ armv6l-debian-sid-container: NAME: debian-sid-cross-armv6l armv7l-debian-sid-container: - extends: .container_optional_job + extends: .container_job variables: NAME: debian-sid-cross-armv7l @@ -280,7 +280,7 @@ i686-debian-sid-container: NAME: debian-sid-cross-i686 mips64el-debian-sid-container: - extends: .container_job + extends: .container_optional_job variables: NAME: debian-sid-cross-mips64el @@ -473,12 +473,12 @@ armv6l-debian-10: NAME: debian-10 CROSS: armv6l -armv7l-debian-10: +armv7l-debian-sid: extends: .cross_build_job needs: - - armv7l-debian-10-container + - armv7l-debian-sid-container variables: - NAME: debian-10 + NAME: debian-sid CROSS: armv7l i686-debian-sid: @@ -497,12 +497,12 @@ mips-debian-10: NAME: debian-10 CROSS: mips -mips64el-debian-sid: +mips64el-debian-10: extends: .cross_build_job needs: - - mips64el-debian-sid-container + - mips64el-debian-10-container variables: - NAME: debian-sid + NAME: debian-10 CROSS: mips64el mipsel-debian-10: -- 2.31.1

1 1

[PATCH v2 00/23] tests: qemu: Don't crash when capability file can't be parsed
by Peter Krempa 18 Aug '21

18 Aug '21

The original patch was replaced. A nice side effect of this series is substantial improvement of compile times for: qemuxml2xmltest 15.8s -> 1.3s qemuxml2argvtest 6.4s -> 1.8s In addition this also cleans up the messy parsing of fake caps and removes the somewhat ambiguous NONE macro. Peter Krempa (23): qemu: capabilities: Remove virQEMUCapsSetList qemuxml2argvtest: Add 'ARG_END' from higher level macros qemuxml2argvtest: Fix broken invocation of "pseries-spaprvio-invalid" qemuxml2argvtest: Fix broken invocation of "aarch64-tpm-wrong-model" testQemuInfoSetArgs: Always allocate 'info->qemuCaps' qemustatusxml2xmltest: Remove hack for qemuCaps allocation qemuxml2argvtest: Add QEMU_CAPS_LAST in places where ARG_QEMU_CAPS is used qemuxml2argvtest: Rename DO_TEST_INTERNAL to DO_TEST_FULL and fix users qemuxml2argvtest: Add 'DO_TEST_NOCAPS' to replace 'DO_TEST("blah", NONE);' qemuxml2argvtest: Add 'DO_TEST_PARSE_ERROR_NOCAPS' to replace 'DO_TEST_PARSE_ERROR("blah", NONE);' qemuxml2argvtest: Add 'DO_TEST_FAILURE_NOCAPS' to replace 'DO_TEST_FAILURE("blah", NONE);' qemuxml2xmltest: Add 'ARG_END' from higher level macros qemuxml2xmltest: Rename DO_TEST_INTERNAL to DO_TEST_FULL and fix users qemuxml2xmltest: Remove hack for qemuCaps allocation qemuxml2xmltest: Add 'DO_TEST_NOCAPS' to replace 'DO_TEST("blah", NONE);' qemuxml2xmltest: Remove 'NONE' macro testutilsqemu: Ensure that ARG_* macros are out of range of QEMU_CAPS_* testQemuInfoSetArgs: Remove hack for double QEMU_CAPS_LAST in caps list testQemuInfoSetArgs: Move argument fetching to the loop testutilsqemu: Introduce struct to hold data valid for all test runs testutilsqemu: Improve error propagation from 'testQemuInfoSetArgs' qemuxml2argvtest: Avoid conditions in test macro qemuxml2xmltesttest: Avoid conditions in test macro src/qemu/qemu_capabilities.c | 13 - src/qemu/qemu_capabilities.h | 2 - tests/qemustatusxml2xmltest.c | 21 +- tests/qemuxml2argvtest.c | 666 +++++++++++++++++----------------- tests/qemuxml2xmltest.c | 578 ++++++++++++++--------------- tests/testutilsqemu.c | 140 ++++--- tests/testutilsqemu.h | 30 +- 7 files changed, 706 insertions(+), 744 deletions(-) -- 2.31.1

2 24

[RFC PATCH] add support for two global pm options that controls acpi hotplug on q35/i440fx
by Ani Sinha 17 Aug '21

17 Aug '21

'acpi-pci-hotplug-with-bridge-support' and 'acpi-root-pci-hotplug' are two pm options in qemu that governs acpi hotplug support. This is a WIP patch that tries to implement support for both these two global qemu options. 'acpi-pci-hotplug-with-bridge-support' applies both for q35 as well as i440fx platforms. The 'acpi-root-pci-hotplug' only applies for i440fx. 'acpi-pci-hotplug-with-bridge-support' can be turned off by providing the following xml snippet: <pm> <acpi-hotplug-bridge enabled='no'> </pm> Similarly, 'acpi-root-pci-hotplug' can be turned off by providing the following xml snippet: <pm> <acpi-root-hotplug enabled='no'> </pm> This change adds no unit tests. It will be added later on. It it sent for initial comments and suggestions. Signed-off-by: Ani Sinha <ani(a)anisinha.ca> --- src/conf/domain_conf.c | 10 ++++++++++ src/conf/domain_conf.h | 2 ++ src/qemu/qemu_capabilities.c | 9 +++++++++ src/qemu/qemu_capabilities.h | 5 +++++ src/qemu/qemu_command.c | 28 ++++++++++++++++++++++++++++ src/qemu/qemu_validate.c | 21 +++++++++++++++++++++ 6 files changed, 75 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 06c1fcf5e5..512973e6f4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19351,6 +19351,16 @@ virDomainDefLifecycleParse(virDomainDef *def, &def->pm.s4) < 0) goto error; + if (virDomainPMStateParseXML(ctxt, + "string(./pm/acpi-hotplug-bridge/@enabled)", + &def->pm.acpi_hp_bridge) < 0) + goto error; + + if (virDomainPMStateParseXML(ctxt, + "string(./pm/acpi-root-hotplug/@enabled)", + &def->pm.acpi_root_hp) < 0) + goto error; + return 0; error: diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ca21082624..94283cbb04 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2643,6 +2643,8 @@ struct _virDomainPowerManagement { /* These options are of type enum virTristateBool */ int s3; int s4; + int acpi_hp_bridge; + int acpi_root_hp; }; struct _virDomainPerfDef { diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 9558938866..8dad4a6351 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -637,6 +637,11 @@ VIR_ENUM_IMPL(virQEMUCaps, "confidential-guest-support", "query-display-options", "s390-pv-guest", + "piix4-acpi-hotplug-bridge", + "piix4-acpi-root-hotplug-en", + + /* 410 */ + "ich9-acpi-hotplug-bridge", ); @@ -1467,6 +1472,9 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsIDEDrive[] = { static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsPiix4PM[] = { { "disable_s3", QEMU_CAPS_PIIX_DISABLE_S3, NULL }, { "disable_s4", QEMU_CAPS_PIIX_DISABLE_S4, NULL }, + { "acpi-pci-hotplug-with-bridge-support", QEMU_CAPS_PIIX_ACPI_HOTPLUG_BRIDGE, NULL }, + { "acpi-root-pci-hotplug", QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG, NULL }, + }; static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsUSBRedir[] = { @@ -1519,6 +1527,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsVirtioGpu[] = { static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsICH9[] = { { "disable_s3", QEMU_CAPS_ICH9_DISABLE_S3, NULL }, { "disable_s4", QEMU_CAPS_ICH9_DISABLE_S4, NULL }, + { "acpi-pci-hotplug-with-bridge-support", QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE, NULL }, }; static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsUSBNECXHCI[] = { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 2b1bb57a49..e988527f39 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -617,6 +617,11 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */ QEMU_CAPS_MACHINE_CONFIDENTAL_GUEST_SUPPORT, /* -machine confidential-guest-support */ QEMU_CAPS_QUERY_DISPLAY_OPTIONS, /* 'query-display-options' qmp command present */ QEMU_CAPS_S390_PV_GUEST, /* -object s390-pv-guest,... */ + QEMU_CAPS_PIIX_ACPI_HOTPLUG_BRIDGE, /* -M pc PIIX4_PM.acpi-pci-hotplug-with-bridge-support */ + QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG, /* -M pc PIIX4_PM.acpi-root-pci-hotplug */ + + /* 410 */ + QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE, /* -M q35 PIIX4_PM.acpi-pci-hotplug-with-bridge-support */ QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 156af4caee..5a7a23d5b9 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6171,6 +6171,34 @@ qemuBuildPMCommandLine(virCommand *cmd, pm_object, def->pm.s4 == VIR_TRISTATE_BOOL_NO); } + if (def->pm.acpi_hp_bridge) { + const char *pm_object = "PIIX4_PM"; + const char *switch_str = "on"; + + if (def->pm.acpi_hp_bridge == VIR_TRISTATE_BOOL_NO) + switch_str = "off"; + + if (qemuDomainIsQ35(def) && + virQEMUCapsGet(qemuCaps, QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE)) + pm_object = "ICH9-LPC"; + + virCommandAddArg(cmd, "-global"); + virCommandAddArgFormat(cmd, "%s.acpi-pci-hotplug-with-bridge-support=%s", + pm_object, switch_str); + } + + if (def->pm.acpi_root_hp) { + const char *pm_object = "PIIX4_PM"; + const char *switch_str = "on"; + + if (def->pm.acpi_hp_bridge == VIR_TRISTATE_BOOL_NO) + switch_str = "off"; + + virCommandAddArg(cmd, "-global"); + virCommandAddArgFormat(cmd, "%s.acpi-root-pci-hotplug=%s", + pm_object, switch_str); + } + return 0; } diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index a964c8593d..22403e6d01 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -560,6 +560,27 @@ qemuValidateDomainDefPM(const virDomainDef *def, } } + if (def->pm.acpi_hp_bridge) { + bool q35ICH9_pcihpbr = q35Dom && + virQEMUCapsGet(qemuCaps, + QEMU_CAPS_ICH9_ACPI_HOTPLUG_BRIDGE); + + if (!q35ICH9_pcihpbr && !virQEMUCapsGet(qemuCaps, + QEMU_CAPS_PIIX_ACPI_HOTPLUG_BRIDGE)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", _("setting ACPI hotplug bridge not supported")); + return -1; + } + } + + if (def->pm.acpi_root_hp) { + if (!q35Dom && !virQEMUCapsGet(qemuCaps, QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + "%s", _("setting ACPI root pci hotplug not supported")); + return -1; + } + } + return 0; } -- 2.25.1

1 1

Add support for two i386 pm options which control acpi hotplug
by Ani Sinha 17 Aug '21

17 Aug '21

Hi : The previous patch I sent was half baked and had issues. I am sending the fixed patch complete with added unit tests for the new libvirt xml options. The first patch in the series is the actual change. It also adds related schema modifications. Additionally, it makes the necessary capability additions as well. The second patch in the series is the related unit tests for this feature. The unit tests all pass when run. [PATCH 1/2] pm/i386: add support for two options that controls acpi [PATCH 2/2] tests: add unit tests to exercize pm options that control I hope I shall get some traction on this. Please provide feedback and suggestions. Thanks ani

1 2

[libvirt PATCH] vircgroup: fix build on non-linux systems
by Pavel Hrdina 17 Aug '21

17 Aug '21

virCgroupGetInode needs to be in '#ifdef __linux__'. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/vircgroup.c | 70 ++++++++++++++++++++++++-------------------- 1 file changed, 39 insertions(+), 31 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 4c9445340e..dc040a4822 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -3005,6 +3005,37 @@ virCgroupControllerAvailable(int controller) return virCgroupHasController(cgroup, controller); } + +/** + * virCgroupGetInode: + * + * @cgroup: the cgroup to get inode for + * + * Get the @cgroup inode and return its value to the caller. + * + * Returns inode on success, -1 on error with error message reported. + */ +int +virCgroupGetInode(virCgroup *cgroup) +{ + struct stat st; + int controller = virCgroupGetAnyController(cgroup); + g_autofree char *path = NULL; + + if (controller < 0) + return -1; + + if (virCgroupPathOfController(cgroup, controller, "", &path) < 0) + return -1; + + if (stat(path, &st) < 0) { + virReportSystemError(errno, _("failed to get stat for '%s'"), path); + return -1; + } + + return st.st_ino; +} + #else /* !__linux__ */ bool @@ -3769,6 +3800,14 @@ virCgroupControllerAvailable(int controller G_GNUC_UNUSED) { return false; } + +int +virCgroupGetInode(virCgroup *cgroup) +{ + virReportSystemError(ENOSYS, "%s", + _("Control groups not supported on this platform")); + return -1; +} #endif /* !__linux__ */ @@ -3973,34 +4012,3 @@ virCgroupGetCpuPeriodQuota(virCgroup *cgroup, unsigned long long *period, return 0; } - - -/** - * virCgroupGetInode: - * - * @cgroup: the cgroup to get inode for - * - * Get the @cgroup inode and return its value to the caller. - * - * Returns inode on success, -1 on error with error message reported. - */ -int -virCgroupGetInode(virCgroup *cgroup) -{ - struct stat st; - int controller = virCgroupGetAnyController(cgroup); - g_autofree char *path = NULL; - - if (controller < 0) - return -1; - - if (virCgroupPathOfController(cgroup, controller, "", &path) < 0) - return -1; - - if (stat(path, &st) < 0) { - virReportSystemError(errno, _("failed to get stat for '%s'"), path); - return -1; - } - - return st.st_ino; -} -- 2.31.1

3 3

[PATCH 0/5] Implement detach device related APIs for test driver
by Luke Yue 17 Aug '21

17 Aug '21

Luke Yue (5): test_driver: Implement virDomainDetachDeviceFlags test_driver: Implement virDomainDetachDeviceAlias test_driver: Implement virDomainDetachDevice examples: xml: test: add xml for testing devices related APIs tests: Test detach-device and detach-device-alias for test driver examples/xml/test/testdevcontroller.xml | 1 + examples/xml/test/testdevdiskcdrom.xml | 5 + examples/xml/test/testdevfs.xml | 6 + examples/xml/test/testdevhostdev.xml | 5 + examples/xml/test/testdevif.xml | 6 + examples/xml/test/testdevinput.xml | 1 + examples/xml/test/testdevlease.xml | 5 + examples/xml/test/testdevmem.xml | 6 + examples/xml/test/testdevnetif.xml | 6 + examples/xml/test/testdevrng.xml | 4 + examples/xml/test/testdevshmem.xml | 4 + examples/xml/test/testdevsound.xml | 3 + examples/xml/test/testdevvsock.xml | 3 + examples/xml/test/testdevwatchdog.xml | 1 + examples/xml/test/testdomfc5.xml | 46 ++++ examples/xml/test/testnodeinline.xml | 46 ++++ src/test/test_driver.c | 290 ++++++++++++++++++++++++ tests/virshtest.c | 24 ++ 18 files changed, 462 insertions(+) create mode 100644 examples/xml/test/testdevcontroller.xml create mode 100644 examples/xml/test/testdevdiskcdrom.xml create mode 100644 examples/xml/test/testdevfs.xml create mode 100644 examples/xml/test/testdevhostdev.xml create mode 100644 examples/xml/test/testdevif.xml create mode 100644 examples/xml/test/testdevinput.xml create mode 100644 examples/xml/test/testdevlease.xml create mode 100644 examples/xml/test/testdevmem.xml create mode 100644 examples/xml/test/testdevnetif.xml create mode 100644 examples/xml/test/testdevrng.xml create mode 100644 examples/xml/test/testdevshmem.xml create mode 100644 examples/xml/test/testdevsound.xml create mode 100644 examples/xml/test/testdevvsock.xml create mode 100644 examples/xml/test/testdevwatchdog.xml -- 2.32.0

2 12

[libvirt PATCH 0/6] Use g_auto for more libxml2 functions (glib chronicles)
by Ján Tomko 17 Aug '21

17 Aug '21

Use g_auto for the remaining users of xmlFreeDoc and xmlXPathFreeContext. Also, remove redundant labels where easily possible. Ján Tomko (6): conf: virCPUDefListParse: reduce scope of variables conf: refactor virNetworkLoadState Use g_auto for xmlXPathContext everywhere Use g_auto for xmlFreeDoc everywhere Use g_autofree in affected functions Remove redundant labels src/conf/checkpoint_conf.c | 3 +-- src/conf/cpu_conf.c | 30 ++++++++------------------ src/conf/domain_conf.c | 6 ++---- src/conf/interface_conf.c | 3 +-- src/conf/node_device_conf.c | 3 +-- src/conf/nwfilter_conf.c | 3 +-- src/conf/secret_conf.c | 3 +-- src/conf/snapshot_conf.c | 3 +-- src/conf/storage_conf.c | 6 ++---- src/conf/virnetworkobj.c | 37 +++++++++++--------------------- src/conf/virnetworkportdef.c | 16 +++++--------- src/conf/virnwfilterbindingdef.c | 16 +++++--------- src/conf/virnwfilterbindingobj.c | 16 +++++--------- src/conf/virsavecookie.c | 20 ++++++----------- src/conf/virstorageobj.c | 21 +++++++----------- src/esx/esx_vi.c | 4 +--- src/libxl/libxl_migration.c | 14 ++++-------- src/qemu/qemu_capabilities.c | 6 ++---- src/qemu/qemu_migration_cookie.c | 15 ++++--------- src/security/virt-aa-helper.c | 23 +++++++------------- src/storage/storage_util.c | 23 +++++++------------- src/test/test_driver.c | 17 +++++---------- src/util/virxml.c | 3 +-- src/vbox/vbox_snapshot_conf.c | 21 ++++++------------ src/vz/vz_driver.c | 10 +++------ src/vz/vz_sdk.c | 6 ++---- tests/cputest.c | 35 +++++++++++------------------- tests/metadatatest.c | 22 ++++++------------- tests/qemucaps2xmltest.c | 8 ++----- tests/virnetdevbandwidthtest.c | 6 ++---- 30 files changed, 129 insertions(+), 270 deletions(-) -- 2.31.1

3 8

[PATCH v2 0/4] Implement some job related APIs for test driver
by Luke Yue 17 Aug '21

17 Aug '21

v2: - Change to priv->jobState to store job type directly instead of using time - Use priv->jobOperation to store job operation for virDomainGetJobStats Luke Yue (4): test_driver: Implement virDomainGetJobInfo test_driver: Implement virDomainGetJobStats test_driver: Implement virDomainAbortJob virshtest: add test for domjobinfo src/test/test_driver.c | 223 +++++++++++++++++++++++++++++++++++++++++ tests/virshtest.c | 11 ++ 2 files changed, 234 insertions(+) -- 2.32.0

2 10

[libvirt PATCH v4 0/5] add support for Fibre Channel VMID
by Pavel Hrdina 17 Aug '21

17 Aug '21

changes in v4: - documentation fixes - allow only printable characters to be used in appid - properly check inode in qemuSetupCgroupAppid changes in v3: - rename the XML attribute to appid as technically what user provides is not VMID, that is created by kernel changes in v2: - refactor of resource parsing and formatting code - use <fibrechannel vmid=''/> element - use stat() directly - report only single system error Pavel Hrdina (5): vircgroup: introduce virCgroupGetInode function conf: refactor virDomainResourceDefParse conf: refactor virDomainResourceDefFormat conf: introduce support for Fibre Channel VMID qemu: implement support for Fibre Channel VMID docs/formatdomain.rst | 21 ++++++++++ docs/schemas/domaincommon.rng | 22 ++++++++-- src/conf/domain_conf.c | 42 +++++++++++-------- src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 34 +++++++++++++++ src/libvirt_private.syms | 1 + src/qemu/qemu_cgroup.c | 30 +++++++++++++ src/util/vircgroup.c | 31 ++++++++++++++ src/util/vircgroup.h | 2 + .../fibrechannel-appid.xml | 21 ++++++++++ tests/genericxml2xmltest.c | 2 + 11 files changed, 186 insertions(+), 21 deletions(-) create mode 100644 tests/genericxml2xmlindata/fibrechannel-appid.xml -- 2.31.1

2 8

[libvirt PATCH v3 0/5] add support for Fibre Channel VMID
by Pavel Hrdina 17 Aug '21

17 Aug '21

changes in v3: - rename the XML attribute to appid as technically what user provides is not VMID, that is created by kernel changes in v2: - refactor of resource parsing and formatting code - use <fibrechannel vmid=''/> element - use stat() directly - report only single system error Pavel Hrdina (5): vircgroup: introduce virCgroupGetInode function conf: refactor virDomainResourceDefParse conf: refactor virDomainResourceDefFormat conf: introduce support for Fibre Channel VMID qemu: implement support for Fibre Channel VMID docs/formatdomain.rst | 21 ++++++++++ docs/schemas/domaincommon.rng | 21 ++++++++-- src/conf/domain_conf.c | 42 +++++++++++-------- src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 19 +++++++++ src/libvirt_private.syms | 1 + src/qemu/qemu_cgroup.c | 27 ++++++++++++ src/util/vircgroup.c | 31 ++++++++++++++ src/util/vircgroup.h | 2 + .../fibrechannel-appid.xml | 21 ++++++++++ tests/genericxml2xmltest.c | 2 + 11 files changed, 167 insertions(+), 21 deletions(-) create mode 100644 tests/genericxml2xmlindata/fibrechannel-appid.xml -- 2.31.1

2 10

[PATCH] security: fix use-after-free in virSecuritySELinuxReserveLabel
by Zhenyu Ye 17 Aug '21

17 Aug '21

commit 2e668a61d5ae4("Fix error handling when adding MCS labels") uses the 'pctx' in virReportError after it has been freed. Fix it. Fixes: 2e668a61d5ae4cbd6f79e096d0c394f186e132bd Signed-off-by: eillon <yezhenyu2(a)huawei.com> --- src/security/security_selinux.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/security/security_selinux.c b/src/security/security_selinux.c index 9ff35a7be5..0e5ea0366d 100644 --- a/src/security/security_selinux.c +++ b/src/security/security_selinux.c @@ -967,7 +967,6 @@ virSecuritySELinuxReserveLabel(virSecurityManager *mgr, } ctx = context_new(pctx); - freecon(pctx); if (!ctx) goto error; @@ -985,11 +984,13 @@ virSecuritySELinuxReserveLabel(virSecurityManager *mgr, goto error; } + freecon(pctx); context_free(ctx); return 0; error: + freecon(pctx); context_free(ctx); return -1; } -- 2.27.0

2 3

[PATCH 00/22] qemu: Capability probing from 'query-command-line-options' (part 1?)
by Peter Krempa 16 Aug '21

16 Aug '21

Hi, this series started as an exploration in how we use 'query-command-line-options' and the way to possibly step away from using it. The main problem is that query-command-line-options is using old-style command line parsing infra in qemu and thus doesn't scale. In an effor to help qemu developers identify what we still need to query using the command I set to clean up the parsing. This series consists of: - removal of unneeded tests (covered by other cases or pointless) - adding of comments which simplify lookup of capability string from enum value name - grouping of the queries by name - refactor of probing of stuff which can be probed differently - removal of some other probes - cleanups of the driver code In general we've got the following cases: - good ones: - can be queried differently - this patchset has converted (probably) all of them - the "bad" ones: - stuff we can't replace yet and we need to probe it, few examples are: - pressence of seccomp - support of 'fd=' for chardevs - various VNC and spice config options - the possibly "ugly": - these are options which are supported by all qemu versions and are unlikely to be removed, but there's no different way to probe them, we can always assume them - those are the QEMU_CAPS_NAME* and QEMU_CAPS_MSG_TIMESTAMP at the end, these patches are RFC as it may be considered a backwards step just to assume it's supported Note that the removal of probing of -drive throttling caps can be replaced in case something gets deprecated via probing the 'throttling' object. This was added recently though. Since it's unlikely that pieces would be removed in the groups they were added removal of these caps is classified in the 'good' part. Peter Krempa (22): qemuxml2argvtest: Remove negative tests for (aes|dea)keywrap (s390) property virQEMUCapsCommandLine: Group by commandline argument name alphabetically virQEMUCapsQMPSchemaQueries: Group by queried object name scripts: group-qemu-caps: Add capability name as comment to capability string qemu: capabilities: Note that basing probing on 'query-command-line-options' should be avoided qemu: capabilities: Probe 'reconnect', 'logfile' and 'append' from 'chardev-add' qemu: capabilities: Rename QEMU_CAPS_CHARDEV_FD_PASS to QEMU_CAPS_CHARDEV_FD_PASS_COMMANDLINE qemu: capabilities: Probe 'discard' and 'detect-zeroes' from 'blockdev-add' qemu: capabilities: Probe QEMU_CAPS_SMP_DIES from the QMP schema qemu: Always assume that qemu supports drive throttling qemu: capabilties: Retire QEMU_CAPS_DRIVE_IOTUNE_* caps qemuMonitorJSONSetBlockIoThrottle: Refactor cleanup qemuMonitorJSONSetBlockIoThrottle: Switch to standard error reporting qemuMonitorSetBlockIoThrottle: Remove booleans controlling used fields qemu: capabilities: Add alternative detection of QEMU_CAPS_NUMA qemuxml2argvtest: Remove 'debug-threads' case qemuxml2argvtest: Remove 'minimal-msg-timestamp' qemuxml2argvtest: Remove 'minimal-sandbox' case qemu: command: Always assume support for '-name guest=' and '-name debug-threads=on' qemu: capabilities: Retire QEMU_CAPS_NAME* qemu: command: Always assume support for '-msg timestamp=on' qemu: capabilities: Retire QEMU_CAPS_MSG_TIMESTAMP scripts/group-qemu-caps.py | 43 +- src/qemu/qemu_capabilities.c | 888 +++++++++--------- src/qemu/qemu_capabilities.h | 14 +- src/qemu/qemu_command.c | 17 +- src/qemu/qemu_driver.c | 55 +- src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_monitor.c | 10 +- src/qemu/qemu_monitor.h | 5 +- src/qemu/qemu_monitor_json.c | 119 +-- src/qemu/qemu_monitor_json.h | 5 +- src/qemu/qemu_process.c | 9 +- src/qemu/qemu_validate.c | 33 +- .../caps_2.11.0.s390x.xml | 6 - .../caps_2.11.0.x86_64.xml | 6 - .../caps_2.12.0.aarch64.xml | 6 - .../caps_2.12.0.ppc64.xml | 6 - .../caps_2.12.0.s390x.xml | 6 - .../caps_2.12.0.x86_64.xml | 6 - .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 6 - .../caps_3.0.0.riscv32.xml | 6 - .../caps_3.0.0.riscv64.xml | 6 - .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 6 - .../caps_3.0.0.x86_64.xml | 6 - .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 6 - .../caps_3.1.0.x86_64.xml | 6 - .../caps_4.0.0.aarch64.xml | 6 - .../qemucapabilitiesdata/caps_4.0.0.ppc64.xml | 6 - .../caps_4.0.0.riscv32.xml | 6 - .../caps_4.0.0.riscv64.xml | 6 - .../qemucapabilitiesdata/caps_4.0.0.s390x.xml | 6 - .../caps_4.0.0.x86_64.xml | 6 - .../caps_4.1.0.x86_64.xml | 6 - .../caps_4.2.0.aarch64.xml | 6 - .../qemucapabilitiesdata/caps_4.2.0.ppc64.xml | 6 - .../qemucapabilitiesdata/caps_4.2.0.s390x.xml | 6 - .../caps_4.2.0.x86_64.xml | 6 - .../caps_5.0.0.aarch64.xml | 6 - .../qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 6 - .../caps_5.0.0.riscv64.xml | 6 - .../caps_5.0.0.x86_64.xml | 6 - .../qemucapabilitiesdata/caps_5.1.0.sparc.xml | 6 - .../caps_5.1.0.x86_64.xml | 6 - .../caps_5.2.0.aarch64.xml | 6 - .../qemucapabilitiesdata/caps_5.2.0.ppc64.xml | 6 - .../caps_5.2.0.riscv64.xml | 6 - .../qemucapabilitiesdata/caps_5.2.0.s390x.xml | 6 - .../caps_5.2.0.x86_64.xml | 6 - .../caps_6.0.0.aarch64.xml | 6 - .../qemucapabilitiesdata/caps_6.0.0.s390x.xml | 6 - .../caps_6.0.0.x86_64.xml | 6 - .../caps_6.1.0.x86_64.xml | 6 - tests/qemumonitorjsontest.c | 3 +- .../aarch64-aavmf-virtio-mmio.args | 5 +- tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 5 +- .../aarch64-cpu-passthrough.args | 5 +- tests/qemuxml2argvdata/aarch64-gic-host.args | 5 +- .../aarch64-gic-none-tcg.args | 5 +- tests/qemuxml2argvdata/aarch64-gic-v2.args | 5 +- tests/qemuxml2argvdata/aarch64-gic-v3.args | 5 +- .../aarch64-kvm-32-on-64.args | 5 +- .../aarch64-noacpi-nouefi.args | 5 +- .../qemuxml2argvdata/aarch64-noacpi-uefi.args | 5 +- .../qemuxml2argvdata/aarch64-pci-serial.args | 5 +- .../aarch64-traditional-pci.args | 5 +- .../aarch64-usb-controller-nec-xhci.args | 5 +- .../aarch64-usb-controller-qemu-xhci.args | 5 +- .../aarch64-video-default.args | 5 +- .../aarch64-video-virtio-gpu-pci.args | 5 +- .../aarch64-virt-2.6-virtio-pci-default.args | 5 +- .../aarch64-virt-default-nic.args | 5 +- .../qemuxml2argvdata/aarch64-virt-virtio.args | 5 +- .../aarch64-virtio-pci-default.args | 5 +- .../aarch64-virtio-pci-manual-addresses.args | 5 +- tests/qemuxml2argvdata/acpi-table.args | 5 +- .../arm-vexpressa9-basic.args | 5 +- .../arm-vexpressa9-nodevs.args | 5 +- .../arm-vexpressa9-virtio.args | 5 +- tests/qemuxml2argvdata/arm-virt-virtio.args | 5 +- tests/qemuxml2argvdata/audio-alsa-best.args | 5 +- .../qemuxml2argvdata/audio-alsa-minimal.args | 5 +- .../audio-coreaudio-best.args | 5 +- .../audio-coreaudio-minimal.args | 5 +- .../audio-default-nographics.args | 5 +- tests/qemuxml2argvdata/audio-default-sdl.args | 5 +- .../qemuxml2argvdata/audio-default-spice.args | 5 +- tests/qemuxml2argvdata/audio-default-vnc.args | 5 +- tests/qemuxml2argvdata/audio-file-best.args | 5 +- .../qemuxml2argvdata/audio-file-minimal.args | 5 +- tests/qemuxml2argvdata/audio-none-best.args | 5 +- .../qemuxml2argvdata/audio-none-minimal.args | 5 +- tests/qemuxml2argvdata/audio-oss-best.args | 5 +- tests/qemuxml2argvdata/audio-oss-minimal.args | 5 +- .../audio-pulseaudio-best.args | 5 +- .../audio-pulseaudio-minimal.args | 5 +- tests/qemuxml2argvdata/audio-sdl-best.args | 5 +- tests/qemuxml2argvdata/audio-sdl-minimal.args | 5 +- tests/qemuxml2argvdata/audio-spice-best.args | 5 +- .../qemuxml2argvdata/audio-spice-minimal.args | 5 +- tests/qemuxml2argvdata/autoindex.args | 5 +- .../qemuxml2argvdata/balloon-ccw-deflate.args | 5 +- .../qemuxml2argvdata/balloon-device-auto.args | 5 +- .../balloon-device-deflate-off.args | 5 +- .../balloon-device-deflate.args | 5 +- .../balloon-device-period.args | 5 +- tests/qemuxml2argvdata/balloon-device.args | 5 +- .../balloon-mmio-deflate.args | 5 +- tests/qemuxml2argvdata/bios-nvram-secure.args | 5 +- tests/qemuxml2argvdata/bios-nvram.args | 5 +- tests/qemuxml2argvdata/bios.args | 5 +- tests/qemuxml2argvdata/blkiotune-device.args | 5 +- tests/qemuxml2argvdata/blkiotune.args | 5 +- tests/qemuxml2argvdata/boot-cdrom.args | 5 +- tests/qemuxml2argvdata/boot-complex.args | 5 +- tests/qemuxml2argvdata/boot-floppy-q35.args | 5 +- tests/qemuxml2argvdata/boot-floppy.args | 5 +- .../boot-menu-disable-drive.args | 5 +- tests/qemuxml2argvdata/boot-menu-disable.args | 5 +- .../boot-menu-enable-with-timeout.args | 5 +- tests/qemuxml2argvdata/boot-menu-enable.args | 5 +- tests/qemuxml2argvdata/boot-multi.args | 5 +- tests/qemuxml2argvdata/boot-network.args | 5 +- tests/qemuxml2argvdata/boot-order.args | 5 +- tests/qemuxml2argvdata/boot-strict.args | 5 +- tests/qemuxml2argvdata/channel-guestfwd.args | 5 +- tests/qemuxml2argvdata/channel-spicevmc.args | 5 +- .../qemuxml2argvdata/channel-virtio-auto.args | 5 +- .../channel-virtio-autoadd.args | 5 +- .../channel-virtio-autoassign.args | 5 +- .../channel-virtio-default.args | 5 +- .../channel-virtio-state.args | 5 +- .../qemuxml2argvdata/channel-virtio-unix.args | 5 +- tests/qemuxml2argvdata/channel-virtio.args | 5 +- tests/qemuxml2argvdata/chardev-reconnect.args | 5 +- tests/qemuxml2argvdata/clock-catchup.args | 5 +- tests/qemuxml2argvdata/clock-france.args | 5 +- tests/qemuxml2argvdata/clock-hpet-off.args | 5 +- .../clock-localtime-basis-localtime.args | 5 +- tests/qemuxml2argvdata/clock-localtime.args | 5 +- tests/qemuxml2argvdata/clock-realtime.args | 5 +- .../clock-timer-hyperv-rtc.args | 5 +- tests/qemuxml2argvdata/clock-utc.args | 5 +- tests/qemuxml2argvdata/clock-variable.args | 5 +- .../qemuxml2argvdata/console-compat-auto.args | 5 +- .../console-compat-chardev.args | 5 +- tests/qemuxml2argvdata/console-compat.args | 5 +- .../qemuxml2argvdata/console-virtio-ccw.args | 5 +- .../qemuxml2argvdata/console-virtio-many.args | 5 +- tests/qemuxml2argvdata/console-virtio.args | 5 +- tests/qemuxml2argvdata/controller-order.args | 5 +- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 5 +- tests/qemuxml2argvdata/cpu-Haswell.args | 5 +- tests/qemuxml2argvdata/cpu-Haswell2.args | 5 +- tests/qemuxml2argvdata/cpu-Haswell3.args | 5 +- tests/qemuxml2argvdata/cpu-cache-disable.args | 5 +- .../qemuxml2argvdata/cpu-cache-disable2.args | 5 +- .../qemuxml2argvdata/cpu-cache-disable3.args | 5 +- .../cpu-cache-emulate-l3.args | 5 +- .../cpu-cache-passthrough.args | 5 +- .../cpu-cache-passthrough2.args | 5 +- .../cpu-check-default-none.args | 5 +- .../cpu-check-default-none2.args | 5 +- .../cpu-check-default-partial.args | 5 +- .../cpu-check-default-partial2.args | 5 +- tests/qemuxml2argvdata/cpu-check-none.args | 5 +- tests/qemuxml2argvdata/cpu-eoi-disabled.args | 5 +- tests/qemuxml2argvdata/cpu-eoi-enabled.args | 5 +- tests/qemuxml2argvdata/cpu-exact1.args | 5 +- .../cpu-exact2-nofallback.args | 5 +- tests/qemuxml2argvdata/cpu-exact2.args | 5 +- tests/qemuxml2argvdata/cpu-fallback.args | 5 +- tests/qemuxml2argvdata/cpu-host-kvmclock.args | 5 +- .../qemuxml2argvdata/cpu-host-model-cmt.args | 5 +- .../cpu-host-model-fallback.args | 5 +- .../cpu-host-model-vendor.args | 5 +- tests/qemuxml2argvdata/cpu-host-model.args | 5 +- .../cpu-host-passthrough-features.args | 5 +- .../cpu-host-passthrough.args | 5 +- .../qemuxml2argvdata/cpu-hotplug-startup.args | 5 +- tests/qemuxml2argvdata/cpu-kvmclock.args | 5 +- tests/qemuxml2argvdata/cpu-minimum1.args | 5 +- tests/qemuxml2argvdata/cpu-minimum2.args | 5 +- .../cpu-no-removed-features.args | 5 +- tests/qemuxml2argvdata/cpu-numa-disjoint.args | 5 +- .../qemuxml2argvdata/cpu-numa-memshared.args | 5 +- .../cpu-numa-no-memory-element.args | 5 +- tests/qemuxml2argvdata/cpu-numa1.args | 5 +- tests/qemuxml2argvdata/cpu-numa2.args | 5 +- tests/qemuxml2argvdata/cpu-s390-features.args | 5 +- tests/qemuxml2argvdata/cpu-s390-zEC12.args | 5 +- tests/qemuxml2argvdata/cpu-strict1.args | 5 +- tests/qemuxml2argvdata/cpu-topology1.args | 5 +- tests/qemuxml2argvdata/cpu-topology2.args | 5 +- tests/qemuxml2argvdata/cpu-topology3.args | 5 +- tests/qemuxml2argvdata/cpu-tsc-frequency.args | 5 +- tests/qemuxml2argvdata/cputune-numatune.args | 5 +- .../qemuxml2argvdata/cputune-zero-shares.args | 5 +- tests/qemuxml2argvdata/cputune.args | 5 +- tests/qemuxml2argvdata/debug-threads.args | 29 - tests/qemuxml2argvdata/debug-threads.xml | 34 - .../default-kvm-host-arch.args | 5 +- .../default-qemu-host-arch.args | 5 +- tests/qemuxml2argvdata/disk-aio.args | 5 +- tests/qemuxml2argvdata/disk-blockio.args | 5 +- tests/qemuxml2argvdata/disk-boot-cdrom.args | 5 +- tests/qemuxml2argvdata/disk-boot-disk.args | 5 +- .../qemuxml2argvdata/disk-cdrom-network.args | 5 +- tests/qemuxml2argvdata/disk-cdrom-tray.args | 5 +- tests/qemuxml2argvdata/disk-cdrom.args | 5 +- tests/qemuxml2argvdata/disk-copy_on_read.args | 5 +- tests/qemuxml2argvdata/disk-error-policy.args | 5 +- tests/qemuxml2argvdata/disk-floppy-tray.args | 5 +- tests/qemuxml2argvdata/disk-floppy.args | 5 +- tests/qemuxml2argvdata/disk-fmt-qcow.args | 5 +- tests/qemuxml2argvdata/disk-geometry.args | 5 +- tests/qemuxml2argvdata/disk-ide-split.args | 5 +- tests/qemuxml2argvdata/disk-ide-wwn.args | 5 +- tests/qemuxml2argvdata/disk-ioeventfd.args | 5 +- tests/qemuxml2argvdata/disk-iscsi.args | 5 +- .../disk-network-gluster.args | 5 +- .../disk-network-iscsi-modern.args | 5 +- .../qemuxml2argvdata/disk-network-iscsi.args | 5 +- tests/qemuxml2argvdata/disk-network-nbd.args | 5 +- .../disk-network-sheepdog.args | 5 +- .../disk-network-source-auth.args | 5 +- tests/qemuxml2argvdata/disk-network-vxhs.args | 5 +- tests/qemuxml2argvdata/disk-no-boot.args | 5 +- tests/qemuxml2argvdata/disk-order.args | 5 +- .../qemuxml2argvdata/disk-readonly-disk.args | 5 +- tests/qemuxml2argvdata/disk-sata-device.args | 5 +- .../disk-scsi-disk-split.args | 5 +- .../qemuxml2argvdata/disk-scsi-disk-vpd.args | 5 +- .../qemuxml2argvdata/disk-scsi-disk-wwn.args | 5 +- .../disk-scsi-lun-passthrough.args | 5 +- tests/qemuxml2argvdata/disk-serial.args | 5 +- tests/qemuxml2argvdata/disk-snapshot.args | 5 +- .../disk-source-pool-mode.args | 5 +- tests/qemuxml2argvdata/disk-source-pool.args | 5 +- .../disk-usb-device-removable.args | 5 +- tests/qemuxml2argvdata/disk-usb-device.args | 5 +- .../disk-virtio-ccw-many.args | 5 +- tests/qemuxml2argvdata/disk-virtio-ccw.args | 5 +- .../qemuxml2argvdata/disk-virtio-queues.args | 5 +- .../disk-virtio-s390-zpci.args | 5 +- tests/qemuxml2argvdata/disk-virtio.args | 5 +- .../encrypted-disk-usage.args | 5 +- tests/qemuxml2argvdata/encrypted-disk.args | 5 +- tests/qemuxml2argvdata/event_idx.args | 5 +- .../fd-memory-no-numa-topology.args | 5 +- .../fd-memory-numa-topology.args | 5 +- .../fd-memory-numa-topology2.args | 5 +- .../fd-memory-numa-topology3.args | 5 +- tests/qemuxml2argvdata/floppy-drive-fat.args | 5 +- tests/qemuxml2argvdata/fs9p-ccw.args | 5 +- tests/qemuxml2argvdata/fs9p.args | 5 +- .../graphics-egl-headless.args | 5 +- .../graphics-sdl-fullscreen.args | 5 +- tests/qemuxml2argvdata/graphics-sdl.args | 5 +- .../graphics-spice-agent-file-xfer.args | 5 +- .../graphics-spice-agentmouse.args | 5 +- .../graphics-spice-auto-socket-cfg.args | 5 +- .../graphics-spice-auto-socket.args | 5 +- .../graphics-spice-compression.args | 5 +- .../graphics-spice-egl-headless.args | 5 +- .../graphics-spice-no-args.args | 5 +- .../graphics-spice-qxl-vga.args | 5 +- .../qemuxml2argvdata/graphics-spice-sasl.args | 5 +- .../graphics-spice-socket.args | 5 +- .../graphics-spice-timeout.args | 5 +- .../graphics-spice-usb-redir.args | 5 +- tests/qemuxml2argvdata/graphics-spice.args | 5 +- .../graphics-vnc-auto-socket-cfg.args | 5 +- .../graphics-vnc-auto-socket.args | 5 +- .../graphics-vnc-egl-headless.args | 5 +- .../graphics-vnc-no-listen-attr.args | 5 +- tests/qemuxml2argvdata/graphics-vnc-none.args | 5 +- .../qemuxml2argvdata/graphics-vnc-policy.args | 5 +- .../graphics-vnc-remove-generated-socket.args | 5 +- tests/qemuxml2argvdata/graphics-vnc-sasl.args | 5 +- .../graphics-vnc-socket-new-cmdline.args | 5 +- .../qemuxml2argvdata/graphics-vnc-socket.args | 5 +- tests/qemuxml2argvdata/graphics-vnc-tls.args | 5 +- .../graphics-vnc-websocket.args | 5 +- tests/qemuxml2argvdata/graphics-vnc.args | 5 +- .../hostdev-mdev-precreated.args | 5 +- .../hostdev-pci-address-device.args | 5 +- .../hostdev-pci-address-unassigned.args | 5 +- .../qemuxml2argvdata/hostdev-pci-address.args | 5 +- .../hostdev-pci-multifunction.args | 5 +- .../hostdev-scsi-vhost-scsi-ccw.args | 5 +- .../hostdev-scsi-vhost-scsi-pci.args | 5 +- .../hostdev-scsi-vhost-scsi-pcie.args | 5 +- .../hostdev-subsys-mdev-vfio-ccw.args | 5 +- .../hostdev-usb-address-device-boot.args | 5 +- .../hostdev-usb-address-device.args | 5 +- .../qemuxml2argvdata/hostdev-usb-address.args | 5 +- .../hostdev-vfio-multidomain.args | 5 +- .../hostdev-vfio-zpci-autogenerate-fids.args | 5 +- .../hostdev-vfio-zpci-autogenerate-uids.args | 5 +- .../hostdev-vfio-zpci-autogenerate.args | 5 +- .../hostdev-vfio-zpci-boundaries.args | 5 +- .../hostdev-vfio-zpci-ccw-memballoon.args | 5 +- .../hostdev-vfio-zpci-multidomain-many.args | 5 +- tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 5 +- tests/qemuxml2argvdata/hostdev-vfio.args | 5 +- tests/qemuxml2argvdata/hotplug-base.args | 5 +- .../hugepages-default-2M.args | 5 +- .../hugepages-default-system-size.args | 5 +- tests/qemuxml2argvdata/hugepages-default.args | 5 +- .../qemuxml2argvdata/hugepages-memaccess.args | 5 +- .../hugepages-memaccess2.args | 5 +- tests/qemuxml2argvdata/hugepages-nodeset.args | 5 +- .../hugepages-numa-default-2M.args | 5 +- .../hugepages-numa-default-dimm.args | 5 +- .../hugepages-numa-default.args | 5 +- .../hugepages-numa-nodeset-part.args | 5 +- .../hugepages-numa-nodeset.args | 5 +- tests/qemuxml2argvdata/hugepages-shared.args | 5 +- .../qemuxml2argvdata/input-usbmouse-addr.args | 5 +- tests/qemuxml2argvdata/input-usbmouse.args | 5 +- tests/qemuxml2argvdata/input-usbtablet.args | 5 +- tests/qemuxml2argvdata/input-virtio-ccw.args | 5 +- .../iothreads-disk-virtio-ccw.args | 5 +- tests/qemuxml2argvdata/iothreads-disk.args | 5 +- .../iothreads-ids-partial.args | 5 +- tests/qemuxml2argvdata/iothreads-ids.args | 5 +- tests/qemuxml2argvdata/iothreads.args | 5 +- tests/qemuxml2argvdata/kvm-features-off.args | 5 +- tests/qemuxml2argvdata/kvm-features.args | 5 +- tests/qemuxml2argvdata/kvm-pit-delay.args | 5 +- tests/qemuxml2argvdata/kvm-pit-discard.args | 5 +- tests/qemuxml2argvdata/kvmclock.args | 5 +- .../luks-disks-source-qcow2.args | 5 +- tests/qemuxml2argvdata/luks-disks-source.args | 5 +- tests/qemuxml2argvdata/luks-disks.args | 5 +- .../mach-virt-console-virtio.args | 5 +- .../mach-virt-serial-native.args | 5 +- .../mach-virt-serial-pci.args | 5 +- .../mach-virt-serial-usb.args | 5 +- .../machine-aeskeywrap-off-cap.args | 5 +- .../machine-aeskeywrap-off-cap.err | 1 - .../machine-aeskeywrap-off-caps.args | 5 +- .../machine-aeskeywrap-off-caps.err | 1 - .../machine-aeskeywrap-on-cap.args | 5 +- .../machine-aeskeywrap-on-cap.err | 1 - .../machine-aeskeywrap-on-caps.args | 5 +- .../machine-aeskeywrap-on-caps.err | 1 - tests/qemuxml2argvdata/machine-aliases1.args | 5 +- tests/qemuxml2argvdata/machine-aliases2.args | 5 +- tests/qemuxml2argvdata/machine-core-off.args | 5 +- tests/qemuxml2argvdata/machine-core-on.args | 5 +- .../machine-deakeywrap-off-cap.args | 5 +- .../machine-deakeywrap-off-cap.err | 1 - .../machine-deakeywrap-off-caps.args | 5 +- .../machine-deakeywrap-off-caps.err | 1 - .../machine-deakeywrap-on-cap.args | 5 +- .../machine-deakeywrap-on-cap.err | 1 - .../machine-deakeywrap-on-caps.args | 5 +- .../machine-deakeywrap-on-caps.err | 1 - .../machine-keywrap-none-caps.args | 5 +- .../machine-keywrap-none.args | 5 +- ...ine-loadparm-multiple-disks-nets-s390.args | 5 +- .../machine-loadparm-net-s390.args | 5 +- .../machine-loadparm-s390.args | 5 +- tests/qemuxml2argvdata/machine-smm-opt.args | 5 +- .../qemuxml2argvdata/machine-vmport-opt.args | 5 +- tests/qemuxml2argvdata/master-key.args | 5 +- .../memory-hotplug-dimm-addr.args | 5 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 5 +- ...emory-hotplug-nvdimm-ppc64-abi-update.args | 5 +- .../memory-hotplug-nvdimm-ppc64.args | 5 +- ...emory-hotplug-ppc64-nonuma-abi-update.args | 5 +- .../memory-hotplug-ppc64-nonuma.args | 5 +- tests/qemuxml2argvdata/memory-hotplug.args | 5 +- tests/qemuxml2argvdata/memtune-unlimited.args | 5 +- tests/qemuxml2argvdata/memtune.args | 5 +- .../migrate-numa-unaligned.args | 5 +- tests/qemuxml2argvdata/migrate.args | 5 +- .../minimal-msg-timestamp.args | 30 - .../minimal-msg-timestamp.xml | 32 - tests/qemuxml2argvdata/minimal-sandbox.args | 30 - tests/qemuxml2argvdata/minimal-sandbox.xml | 34 - tests/qemuxml2argvdata/minimal.args | 5 +- tests/qemuxml2argvdata/misc-acpi.args | 5 +- tests/qemuxml2argvdata/misc-disable-s3.args | 5 +- .../misc-disable-suspends.args | 5 +- tests/qemuxml2argvdata/misc-enable-s4.args | 5 +- tests/qemuxml2argvdata/misc-no-reboot.args | 5 +- tests/qemuxml2argvdata/misc-uuid.args | 5 +- tests/qemuxml2argvdata/monitor-json.args | 5 +- .../multifunction-pci-device.args | 5 +- tests/qemuxml2argvdata/name-escape.args | 3 +- tests/qemuxml2argvdata/net-client.args | 5 +- tests/qemuxml2argvdata/net-eth-hostip.args | 5 +- tests/qemuxml2argvdata/net-eth-ifname.args | 5 +- tests/qemuxml2argvdata/net-eth-names.args | 5 +- .../net-eth-unmanaged-tap.args | 5 +- tests/qemuxml2argvdata/net-eth.args | 5 +- .../net-hostdev-bootorder.args | 5 +- .../net-hostdev-multidomain.args | 5 +- .../net-hostdev-vfio-multidomain.args | 5 +- tests/qemuxml2argvdata/net-hostdev-vfio.args | 5 +- tests/qemuxml2argvdata/net-hostdev.args | 5 +- tests/qemuxml2argvdata/net-many-models.args | 5 +- tests/qemuxml2argvdata/net-mcast.args | 5 +- tests/qemuxml2argvdata/net-server.args | 5 +- tests/qemuxml2argvdata/net-udp.args | 5 +- tests/qemuxml2argvdata/net-user-addr.args | 5 +- tests/qemuxml2argvdata/net-user.args | 5 +- .../net-vhostuser-multiq.args | 5 +- tests/qemuxml2argvdata/net-vhostuser.args | 5 +- tests/qemuxml2argvdata/net-virtio-ccw.args | 5 +- tests/qemuxml2argvdata/net-virtio-device.args | 5 +- .../net-virtio-disable-offloads.args | 5 +- tests/qemuxml2argvdata/net-virtio-netdev.args | 5 +- .../net-virtio-rxtxqueuesize.args | 5 +- .../net-virtio-teaming-hostdev.args | 5 +- .../qemuxml2argvdata/net-virtio-teaming.args | 5 +- tests/qemuxml2argvdata/net-virtio.args | 5 +- tests/qemuxml2argvdata/nosharepages.args | 5 +- .../numad-auto-memory-vcpu-cpuset.args | 5 +- ...o-memory-vcpu-no-cpuset-and-placement.args | 5 +- .../numad-auto-vcpu-static-numatune.args | 5 +- .../numad-static-memory-auto-vcpu.args | 5 +- tests/qemuxml2argvdata/numad.args | 5 +- .../numatune-auto-nodeset-invalid.args | 5 +- .../numatune-auto-prefer.args | 5 +- .../qemuxml2argvdata/numatune-distances.args | 5 +- .../numatune-memnode-no-memory.args | 5 +- tests/qemuxml2argvdata/numatune-memnode.args | 5 +- tests/qemuxml2argvdata/numatune-memory.args | 5 +- tests/qemuxml2argvdata/numatune-no-vcpu.args | 5 +- .../qemuxml2argvdata/pages-dimm-discard.args | 5 +- .../pages-discard-hugepages.args | 5 +- tests/qemuxml2argvdata/pages-discard.args | 5 +- tests/qemuxml2argvdata/panic-double.args | 5 +- tests/qemuxml2argvdata/panic-no-address.args | 5 +- tests/qemuxml2argvdata/panic.args | 5 +- .../parallel-parport-chardev.args | 5 +- .../parallel-tcp-chardev.args | 5 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 5 +- tests/qemuxml2argvdata/pci-autoadd-idx.args | 5 +- tests/qemuxml2argvdata/pci-autofill-addr.args | 5 +- .../pci-bridge-many-disks.args | 5 +- tests/qemuxml2argvdata/pci-bridge.args | 5 +- tests/qemuxml2argvdata/pci-expander-bus.args | 5 +- tests/qemuxml2argvdata/pci-many.args | 5 +- tests/qemuxml2argvdata/pci-rom-disabled.args | 5 +- tests/qemuxml2argvdata/pci-rom.args | 5 +- .../pci-serial-dev-chardev.args | 5 +- tests/qemuxml2argvdata/pcie-expander-bus.args | 5 +- .../pcie-root-port-model-generic.args | 5 +- .../pcie-root-port-model-ioh3420.args | 5 +- tests/qemuxml2argvdata/pcie-root-port.args | 5 +- tests/qemuxml2argvdata/pcie-root.args | 5 +- .../pcie-switch-downstream-port.args | 5 +- .../pcie-switch-upstream-port.args | 5 +- tests/qemuxml2argvdata/pcihole64-q35.args | 5 +- tests/qemuxml2argvdata/pcihole64.args | 5 +- tests/qemuxml2argvdata/pmu-feature-off.args | 5 +- tests/qemuxml2argvdata/pmu-feature.args | 5 +- tests/qemuxml2argvdata/ppc-dtb.args | 5 +- .../ppc64-usb-controller-legacy.args | 5 +- .../ppc64-usb-controller-qemu-xhci.args | 5 +- .../ppc64-usb-controller.args | 5 +- tests/qemuxml2argvdata/ppce500-serial.args | 5 +- tests/qemuxml2argvdata/pseries-basic.args | 5 +- .../pseries-console-virtio.args | 5 +- .../pseries-cpu-compat-power9.args | 5 +- .../qemuxml2argvdata/pseries-cpu-compat.args | 5 +- tests/qemuxml2argvdata/pseries-cpu-exact.args | 5 +- tests/qemuxml2argvdata/pseries-cpu-le.args | 5 +- tests/qemuxml2argvdata/pseries-features.args | 5 +- .../qemuxml2argvdata/pseries-hostdevs-1.args | 5 +- .../qemuxml2argvdata/pseries-hostdevs-2.args | 5 +- .../qemuxml2argvdata/pseries-hostdevs-3.args | 5 +- .../pseries-machine-max-cpu-compat.args | 5 +- .../pseries-many-buses-1.args | 5 +- .../pseries-many-buses-2.args | 5 +- .../pseries-many-devices.args | 5 +- tests/qemuxml2argvdata/pseries-nvram.args | 5 +- .../pseries-panic-missing.args | 5 +- .../pseries-panic-no-address.args | 5 +- .../pseries-phb-default-missing.args | 5 +- .../pseries-phb-numa-node.args | 5 +- .../qemuxml2argvdata/pseries-phb-simple.args | 5 +- .../pseries-serial-native.args | 5 +- .../qemuxml2argvdata/pseries-serial-pci.args | 5 +- .../qemuxml2argvdata/pseries-serial-usb.args | 5 +- .../qemuxml2argvdata/pseries-usb-default.args | 5 +- tests/qemuxml2argvdata/pseries-usb-kbd.args | 5 +- tests/qemuxml2argvdata/pseries-usb-multi.args | 5 +- .../pseries-vio-user-assigned.args | 5 +- tests/qemuxml2argvdata/pseries-vio.args | 5 +- tests/qemuxml2argvdata/q35-acpi-nouefi.args | 5 +- tests/qemuxml2argvdata/q35-acpi-uefi.args | 5 +- .../q35-default-devices-only.args | 5 +- tests/qemuxml2argvdata/q35-multifunction.args | 5 +- tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 5 +- .../q35-pci-force-address.args | 5 +- tests/qemuxml2argvdata/q35-pcie-autoadd.args | 5 +- tests/qemuxml2argvdata/q35-pcie.args | 5 +- .../q35-pm-disable-fallback.args | 5 +- tests/qemuxml2argvdata/q35-pm-disable.args | 5 +- tests/qemuxml2argvdata/q35-usb2-multi.args | 5 +- tests/qemuxml2argvdata/q35-usb2-reorder.args | 5 +- tests/qemuxml2argvdata/q35-usb2.args | 5 +- .../q35-virt-manager-basic.args | 5 +- tests/qemuxml2argvdata/q35-virtio-pci.args | 5 +- tests/qemuxml2argvdata/q35.args | 5 +- tests/qemuxml2argvdata/qemu-ns-alt.args | 5 +- .../qemu-ns-commandline-ns0.args | 6 +- .../qemu-ns-commandline-ns1.args | 6 +- .../qemuxml2argvdata/qemu-ns-commandline.args | 6 +- .../qemu-ns-domain-commandline-ns0.args | 6 +- .../qemu-ns-domain-commandline.args | 6 +- .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 6 +- tests/qemuxml2argvdata/qemu-ns-no-env.args | 5 +- .../reboot-timeout-disabled.args | 5 +- .../reboot-timeout-enabled.args | 5 +- tests/qemuxml2argvdata/restore-v2-fd.args | 5 +- tests/qemuxml2argvdata/restore-v2.args | 5 +- tests/qemuxml2argvdata/riscv64-virt-pci.args | 5 +- tests/qemuxml2argvdata/riscv64-virt.args | 5 +- .../qemuxml2argvdata/s390-panic-missing.args | 5 +- .../s390-panic-no-address.args | 5 +- tests/qemuxml2argvdata/s390-serial-2.args | 5 +- .../qemuxml2argvdata/s390-serial-console.args | 5 +- tests/qemuxml2argvdata/s390-serial.args | 5 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 5 +- .../seclabel-dynamic-baselabel.args | 5 +- .../seclabel-dynamic-labelskip.args | 5 +- .../seclabel-dynamic-override.args | 5 +- .../seclabel-dynamic-relabel.args | 5 +- tests/qemuxml2argvdata/seclabel-dynamic.args | 5 +- tests/qemuxml2argvdata/seclabel-none.args | 5 +- .../seclabel-static-labelskip.args | 5 +- .../seclabel-static-relabel.args | 5 +- tests/qemuxml2argvdata/seclabel-static.args | 5 +- .../serial-dev-chardev-iobase.args | 5 +- .../qemuxml2argvdata/serial-dev-chardev.args | 5 +- .../qemuxml2argvdata/serial-file-chardev.args | 5 +- tests/qemuxml2argvdata/serial-file-log.args | 5 +- .../qemuxml2argvdata/serial-many-chardev.args | 5 +- .../qemuxml2argvdata/serial-pty-chardev.args | 5 +- .../serial-spiceport-nospice.args | 5 +- tests/qemuxml2argvdata/serial-spiceport.args | 5 +- .../qemuxml2argvdata/serial-tcp-chardev.args | 5 +- .../serial-tcp-telnet-chardev.args | 5 +- .../serial-tcp-tlsx509-chardev-notls.args | 5 +- .../serial-tcp-tlsx509-chardev-verify.args | 5 +- .../serial-tcp-tlsx509-chardev.args | 5 +- .../serial-tcp-tlsx509-secret-chardev.args | 5 +- .../qemuxml2argvdata/serial-udp-chardev.args | 5 +- .../qemuxml2argvdata/serial-unix-chardev.args | 5 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 5 +- .../shmem-plain-doorbell.args | 5 +- tests/qemuxml2argvdata/shmem.args | 5 +- .../smartcard-controller.args | 5 +- .../smartcard-host-certificates-database.args | 5 +- .../smartcard-host-certificates.args | 5 +- tests/qemuxml2argvdata/smartcard-host.args | 5 +- .../smartcard-passthrough-spicevmc.args | 5 +- .../smartcard-passthrough-tcp.args | 5 +- tests/qemuxml2argvdata/smbios-type-fwcfg.args | 5 +- tests/qemuxml2argvdata/smbios.args | 5 +- tests/qemuxml2argvdata/smp-dies.args | 5 +- tests/qemuxml2argvdata/smp.args | 5 +- tests/qemuxml2argvdata/sound-device.args | 5 +- tests/qemuxml2argvdata/sound.args | 5 +- tests/qemuxml2argvdata/sparc-minimal.args | 5 +- .../usb-controller-default-q35.args | 5 +- .../usb-controller-explicit-q35.args | 5 +- .../usb-controller-qemu-xhci.args | 5 +- .../qemuxml2argvdata/usb-controller-xhci.args | 5 +- tests/qemuxml2argvdata/usb-controller.args | 5 +- .../usb-hub-autoadd-deluxe.args | 5 +- tests/qemuxml2argvdata/usb-hub-autoadd.args | 5 +- tests/qemuxml2argvdata/usb-hub.args | 5 +- .../qemuxml2argvdata/usb-ich9-autoassign.args | 5 +- .../qemuxml2argvdata/usb-ich9-companion.args | 5 +- .../qemuxml2argvdata/usb-ich9-ehci-addr.args | 5 +- .../qemuxml2argvdata/usb-long-port-path.args | 5 +- tests/qemuxml2argvdata/usb-none.args | 5 +- .../usb-piix3-controller.args | 5 +- .../qemuxml2argvdata/usb-port-autoassign.args | 5 +- tests/qemuxml2argvdata/usb-port-missing.args | 5 +- tests/qemuxml2argvdata/usb-ports.args | 5 +- tests/qemuxml2argvdata/usb-redir-boot.args | 5 +- .../usb-redir-filter-version.args | 5 +- tests/qemuxml2argvdata/usb-redir-filter.args | 5 +- tests/qemuxml2argvdata/usb-redir.args | 5 +- .../qemuxml2argvdata/usb-xhci-autoassign.args | 5 +- tests/qemuxml2argvdata/usb1-usb2.args | 5 +- tests/qemuxml2argvdata/user-aliases-usb.args | 5 +- tests/qemuxml2argvdata/user-aliases.args | 5 +- .../vcpu-placement-static.args | 5 +- .../video-device-pciaddr-default.args | 5 +- tests/qemuxml2argvdata/video-none-device.args | 5 +- .../video-qxl-device-vgamem.args | 5 +- tests/qemuxml2argvdata/video-qxl-device.args | 5 +- tests/qemuxml2argvdata/video-qxl-heads.args | 5 +- tests/qemuxml2argvdata/video-qxl-noheads.args | 5 +- .../video-qxl-resolution.args | 5 +- .../video-qxl-sec-device-vgamem.args | 5 +- .../video-qxl-sec-device.args | 5 +- .../video-vga-device-vgamem.args | 5 +- tests/qemuxml2argvdata/video-vga-device.args | 5 +- .../qemuxml2argvdata/video-vga-qxl-heads.args | 5 +- .../video-virtio-gpu-ccw.args | 5 +- .../video-virtio-gpu-device.args | 5 +- .../video-virtio-gpu-sdl-gl.args | 5 +- .../video-virtio-gpu-secondary.args | 5 +- .../video-virtio-gpu-spice-gl.args | 5 +- .../video-virtio-gpu-virgl.args | 5 +- tests/qemuxml2argvdata/video-virtio-vga.args | 5 +- .../virtio-input-passthrough.args | 5 +- tests/qemuxml2argvdata/virtio-input.args | 5 +- tests/qemuxml2argvdata/virtio-lun.args | 5 +- tests/qemuxml2argvdata/virtio-rng-ccw.args | 5 +- .../qemuxml2argvdata/virtio-rng-default.args | 5 +- tests/qemuxml2argvdata/virtio-rng-egd.args | 5 +- .../qemuxml2argvdata/virtio-rng-multiple.args | 5 +- tests/qemuxml2argvdata/virtio-rng-random.args | 5 +- tests/qemuxml2argvdata/vmcoreinfo.args | 5 +- tests/qemuxml2argvdata/watchdog-device.args | 5 +- tests/qemuxml2argvdata/watchdog-dump.args | 5 +- .../qemuxml2argvdata/watchdog-injectnmi.args | 5 +- tests/qemuxml2argvdata/watchdog.args | 5 +- tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 5 +- tests/qemuxml2argvtest.c | 34 +- 630 files changed, 2232 insertions(+), 2259 deletions(-) delete mode 100644 tests/qemuxml2argvdata/debug-threads.args delete mode 100644 tests/qemuxml2argvdata/debug-threads.xml delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-off-cap.err delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-off-caps.err delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-on-cap.err delete mode 100644 tests/qemuxml2argvdata/machine-aeskeywrap-on-caps.err delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-off-cap.err delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-off-caps.err delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-on-cap.err delete mode 100644 tests/qemuxml2argvdata/machine-deakeywrap-on-caps.err delete mode 100644 tests/qemuxml2argvdata/minimal-msg-timestamp.args delete mode 100644 tests/qemuxml2argvdata/minimal-msg-timestamp.xml delete mode 100644 tests/qemuxml2argvdata/minimal-sandbox.args delete mode 100644 tests/qemuxml2argvdata/minimal-sandbox.xml -- 2.31.1

3 30

build broken!
by Ani Sinha 16 Aug '21

16 Aug '21

Hi : getting this strange build error here. Googling did not help. Anyone has any ideas as to what I am missing? I am on Ubuntu 20.04 LTS. FAILED: src/libvirt-admin.so.0.7006.0 cc -o src/libvirt-admin.so.0.7006.0 src/libvirt-admin.so.0.7006.0.p/meson-generated_.._admin_admin_protocol.c.o src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o src/libvirt-admin.so.0.7006.0.p/datatypes.c.o -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,libvirt-admin.so.0 '-Wl,-rpath,$ORIGIN/:XXXXXXXXXXXXXXXXXXXXXXX' -Wl,-rpath-link,/home/anisinha/workspace/libvirt/build/src src/libvirt.so.0.7006.0 -Wl,--version-script=/home/anisinha/workspace/libvirt/build/src/admin/libvirt_admin.syms -Wl,-z,nodelete /usr/lib/x86_64-linux-gnu/libcap-ng.so /usr/lib/x86_64-linux-gnu/libgnutls.so -Wl,-z,relro -Wl,-z,now -Wl,--no-copy-dt-needed-entries /usr/lib/x86_64-linux-gnu/libglib-2.0.so /usr/lib/x86_64-linux-gnu/libgobject-2.0.so /usr/lib/x86_64-linux-gnu/libgio-2.0.so /usr/lib/x86_64-linux-gnu/libxml2.so -Wl,--end-group /usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in function `callFull': /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:99: undefined reference to `virNetClientProgramCall' /usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in function `remoteAdminConnectClose': /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:197: undefined reference to `virNetClientSetCloseCallback' /usr/bin/ld: /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:199: undefined reference to `virNetClientClose' /usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in function `remoteAdminPrivNew': /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:225: undefined reference to `virNetClientNewUNIX' /usr/bin/ld: /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:228: undefined reference to `virNetClientProgramNew' /usr/bin/ld: /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:233: undefined reference to `virNetClientAddProgram' /usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in function `remoteAdminConnectOpen': /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:159: undefined reference to `virNetClientRegisterAsyncIO' /usr/bin/ld: /home/anisinha/workspace/libvirt/build/../src/admin/admin_remote.c:166: undefined reference to `virNetClientSetCloseCallback' /usr/bin/ld: src/libvirt-admin.so.0.7006.0.p/admin_libvirt-admin.c.o: in function `virAdmConnectIsAlive': /home/anisinha/workspace/libvirt/build/../src/admin/libvirt-admin.c:397: undefined reference to `virNetClientIsOpen' Thanks ani

2 5

Issue report: Snapshot-create-as block while the vm's process is killed out.
by 13520781732＠189.cn 16 Aug '21

16 Aug '21

Hello, I have meet one issues while using snapshot-create-as with external file. Centos 8, Libivirt 7.0.0 Qemu: 5.2.0 While making one snapshot with memory and disk extaernal file, and killing the process of the vm qemu same time mostly, the snapshot-create-as command blocked. So it will failed to start the vm again for "cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML)". The log is as bellow: 2021-08-12 10:27:38.373+0000: 4344: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected 2021-08-12 10:27:38.573+0000: 4340: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected 2021-08-12 10:27:38.757+0000: 128211: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected 2021-08-12 10:27:39.397+0000: 4341: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected 2021-08-12 10:27:39.887+0000: 4309: error : virNetSocketReadWire:1817 : End of file while reading data: Input/output error 2021-08-12 10:27:53.735+0000: 4340: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected 2021-08-12 10:27:54.822+0000: 4344: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected 2021-08-12 10:27:55.230+0000: 4340: error : qemuDomainAgentAvailable:8125 : Guest agent is not responding: QEMU guest agent is not connected 2021-08-12 10:46:40.994+0000: 4344: warning : qemuDomainObjTaint:6187 : Domain id=95 name='vm_6_135' uuid=b2812e01-331a-4e65-912b-73be5ace2271 is tainted: high-privileges 2021-08-12 10:48:05.785+0000: 4309: error : virNetSocketReadWire:1817 : End of file while reading data: Input/output error 2021-08-12 10:49:50.440+0000: 1643666: error : qemuMonitorIO:583 : internal error: End of file from qemu monitor 2021-08-12 10:50:13.809+0000: 4341: warning : qemuDomainObjTaint:6187 : Domain id=96 name='vm_6_135' uuid=b2812e01-331a-4e65-912b-73be5ace2271 is tainted: high-privileges 2021-08-12 10:51:21.587+0000: 1646757: error : qemuMonitorIO:583 : internal error: End of file from qemu monitor 2021-08-12 10:52:28.421+0000: 4342: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 67s) 2021-08-12 10:52:28.421+0000: 4342: error : qemuDomainObjBeginJobInternal:975 : Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML) 2021-08-12 10:53:10.522+0000: 4342: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 109s) 2021-08-12 10:53:10.522+0000: 4342: error : qemuDomainObjBeginJobInternal:975 : Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML) 2021-08-12 10:53:17.821+0000: 128211: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 117s) 2021-08-12 10:53:17.821+0000: 128211: error : qemuDomainObjBeginJobInternal:975 : Timed out during operation: cannot acquire state change lock (held by monitor=remoteDispatchDomainSnapshotCreateXML) ... ... 2021-08-13 05:49:41.240+0000: 4342: warning : qemuDomainObjBeginJobInternal:953 : Cannot start job (none, none, start) for domain vm_6_135; current job is (none, none, snapshot) owned by (0 <null>, 0 <null>, 4340 remoteDispatchDomainSnapshotCreateXML (flags=0x280)) for (0s, 0s, 68300s) Gdb attach the proces of the libvirt, found there are two suspicious threads, stack as below: gdb) bt #0 0x00007f8f91a492fc in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0 #1 0x00007f8f9574ed7a in virCondWait () from /lib64/libvirt.so.0 #2 0x00007f8f95784ef5 in virDomainObjWait () from /lib64/libvirt.so.0 #3 0x00007f8f422eb26d in qemuMigrationSrcWaitForCompletion () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #4 0x00007f8f422ee5d3 in qemuMigrationSrcToFile () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #5 0x00007f8f42331caa in qemuSaveImageCreate () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #6 0x00007f8f42336ac0 in qemuSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #7 0x00007f8f422b6ac1 in qemuDomainSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #8 0x00007f8f9591f604 in virDomainSnapshotCreateXML () from /lib64/libvirt.so.0 #9 0x0000562390841b81 in remoteDispatchDomainSnapshotCreateXMLHelper () #10 0x00007f8f9580e807 in virNetServerProgramDispatch () from /lib64/libvirt.so.0 #11 0x00007f8f95813b26 in virNetServerHandleJob () from /lib64/libvirt.so.0 #12 0x00007f8f9574f85f in virThreadPoolWorker () from /lib64/libvirt.so.0 #13 0x00007f8f9574eecb in virThreadHelper () from /lib64/libvirt.so.0 #14 0x00007f8f91a4314a in start_thread () from /lib64/libpthread.so.0 #15 0x00007f8f941f1f23 in clone () from /lib64/libc.so.6 (gdb) bt #0 0x00007f8f91a492fc in pthread_cond_wait@@GLIBC_2.3.2 () from /lib64/libpthread.so.0 #1 0x00007f8f9574ed7a in virCondWait () from /lib64/libvirt.so.0 #2 0x00007f8f95784ef5 in virDomainObjWait () from /lib64/libvirt.so.0 #3 0x00007f8f42257ac8 in qemuBlockStorageSourceCreateGeneric () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #4 0x00007f8f4225b88d in qemuBlockStorageSourceCreate () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #5 0x00007f8f423346ee in qemuSnapshotDiskPrepareOne () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #6 0x00007f8f423353f8 in qemuSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #7 0x00007f8f422b6ac1 in qemuDomainSnapshotCreateXML () from /usr/lib64/libvirt/connection-driver/libvirt_driver_qemu.so #8 0x00007f8f9591f604 in virDomainSnapshotCreateXML () from /lib64/libvirt.so.0 #9 0x0000562390841b81 in remoteDispatchDomainSnapshotCreateXMLHelper () #10 0x00007f8f9580e807 in virNetServerProgramDispatch () from /lib64/libvirt.so.0 #11 0x00007f8f95813b26 in virNetServerHandleJob () from /lib64/libvirt.so.0 #12 0x00007f8f9574f85f in virThreadPoolWorker () from /lib64/libvirt.so.0 #13 0x00007f8f9574eecb in virThreadHelper () from /lib64/libvirt.so.0 #14 0x00007f8f91a4314a in start_thread () from /lib64/libpthread.so.0 #15 0x00007f8f941f1f23 in clone () from /lib64/libc.so.6 (gdb) The call work flow one is: qemuSnapshotCreateActiveExternal -> qemuSaveImageCreate -> qemuMigrationSrcToFile -> qemuMigrationSrcWaitForCompletion -> virDomainObjWait The others is similar : qemuSnapshotCreateXML 　－＞　．．． It may be resume after the restart libvirtd.service. Is it correct that the stat change lock should be unlocked while the vm is terminal or shutdown and how to fix it? Thanks! 13520781732(a)189.cn

2 2

[PATCH] tests: qemu: Don't crash when capability file can't be parsed
by Peter Krempa 16 Aug '21

16 Aug '21

In case the test directory contains invalid XML (this doesn't happen upstream, but can when developing, e.g. by forgetting git conflict markers) the tests would crash as in case when 'testQemuInfoSetArgs' fails we'd still invoke the test in qemuxml2argv and qemuxml2xml tests. Add a 'break' statement to avoid invocation of the test and add a debug message. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- tests/qemuxml2argvtest.c | 4 +++- tests/qemuxml2xmltest.c | 1 + tests/testutilsqemu.c | 4 +++- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index b552f5deed..3f43e76842 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -943,8 +943,10 @@ mymain(void) }; \ info.qapiSchemaCache = qapiSchemaCache; \ if (testQemuInfoSetArgs(&info, capscache, capslatest, \ - __VA_ARGS__, ARG_END) < 0) \ + __VA_ARGS__, ARG_END) < 0) { \ ret = -1; \ + break; \ + } \ testInfoSetPaths(&info, _suffix); \ if (virTestRun("QEMU XML-2-ARGV " _name _suffix, \ testCompareXMLToArgv, &info) < 0) \ diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 9652d2a7ce..3b453f9746 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -157,6 +157,7 @@ mymain(void) qemuTestCapsCacheInsert(driver.qemuCapsCache, info.qemuCaps) < 0) { \ VIR_TEST_DEBUG("Failed to generate test data for '%s'", _name); \ ret = -1; \ + break; \ } \ \ if (when & WHEN_INACTIVE) { \ diff --git a/tests/testutilsqemu.c b/tests/testutilsqemu.c index 9a0666724a..f166eaf502 100644 --- a/tests/testutilsqemu.c +++ b/tests/testutilsqemu.c @@ -785,8 +785,10 @@ testQemuInfoSetArgs(struct testQemuInfo *info, } if (!g_hash_table_lookup_extended(capscache, capsfile, NULL, (void **) &cachedcaps)) { - if (!(qemuCaps = qemuTestParseCapabilitiesArch(info->arch, capsfile))) + if (!(qemuCaps = qemuTestParseCapabilitiesArch(info->arch, capsfile))) { + VIR_TEST_VERBOSE("failed to parse capabilities file '%s'", capsfile); goto cleanup; + } cachedcaps = qemuCaps; -- 2.31.1

2 3

[libvirt PATCH] util: Fix memory leak when clearing Open vSwitch QoS
by Jiri Denemark 16 Aug '21

16 Aug '21

No need to overwrite vmid_ex_id with a pointer to another copy of the same string when the original is still alive. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/util/virnetdevopenvswitch.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index 7a64a8dbe6..f6a8ed4a31 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -824,7 +824,6 @@ virNetDevOpenvswitchInterfaceClearQos(const char *ifname, /* find queue */ virCommandFree(cmd); cmd = virNetDevOpenvswitchCreateCmd(); - vmid_ex_id = g_strdup_printf("external-ids:vm-id=\"%s\"", vmuuidstr); virCommandAddArgList(cmd, "--no-heading", "--columns=_uuid", "find", "queue", vmid_ex_id, NULL); virCommandSetOutputBuffer(cmd, &queue_uuid); if (virCommandRun(cmd, NULL) < 0) { -- 2.32.0

2 1

[PATCH v2] libxl: remove conditionals from discard configuration
by Olaf Hering 13 Aug '21

13 Aug '21

LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0 Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- src/libxl/libxl_conf.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 56cb9abd5d..9f0739e1fa 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -923,13 +923,12 @@ libxlMakeVnumaList(virDomainDef *def, return ret; } -static int -libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard) +static void +libxlDiskSetDiscard(libxl_device_disk *x_disk, virDomainDiskDiscard discard) { if (!x_disk->readwrite) - return 0; -#if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE) - switch ((virDomainDiskDiscard)discard) { + return; + switch (discard) { case VIR_DOMAIN_DISK_DISCARD_DEFAULT: case VIR_DOMAIN_DISK_DISCARD_LAST: break; @@ -940,15 +939,6 @@ libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard) libxl_defbool_set(&x_disk->discard_enable, false); break; } - return 0; -#else - if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT) - return 0; - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("This version of libxenlight does not support " - "disk 'discard' option passing")); - return -1; -#endif } static char * @@ -1189,8 +1179,7 @@ libxlMakeDisk(virDomainDiskDef *l_disk, libxl_device_disk *x_disk) x_disk->removable = 1; x_disk->readwrite = !l_disk->src->readonly; x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0; - if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0) - return -1; + libxlDiskSetDiscard(x_disk, l_disk->discard); /* An empty CDROM must have the empty format, otherwise libxl fails. */ if (x_disk->is_cdrom && !x_disk->pdev_path) x_disk->format = LIBXL_DISK_FORMAT_EMPTY;

2 1

[PATCH v1] libxl: remove conditionals from discard configuration
by Olaf Hering 13 Aug '21

13 Aug '21

LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE exists since Xen 4.5.0 Signed-off-by: Olaf Hering <olaf(a)aepfle.de> --- src/libxl/libxl_conf.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 3de2f9f57a..e275996cab 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -923,13 +923,12 @@ libxlMakeVnumaList(virDomainDef *def, return ret; } -static int -libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard) +static void +libxlDiskSetDiscard(libxl_device_disk *x_disk, virDomainDiskDiscard discard) { if (!x_disk->readwrite) - return 0; -#if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE) - switch ((virDomainDiskDiscard)discard) { + return; + switch (discard) { case VIR_DOMAIN_DISK_DISCARD_DEFAULT: case VIR_DOMAIN_DISK_DISCARD_LAST: break; @@ -940,15 +939,6 @@ libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard) libxl_defbool_set(&x_disk->discard_enable, false); break; } - return 0; -#else - if (discard == VIR_DOMAIN_DISK_DISCARD_DEFAULT) - return 0; - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("This version of libxenlight does not support " - "disk 'discard' option passing")); - return -1; -#endif } static void @@ -1209,8 +1199,7 @@ libxlMakeDisk(virDomainDiskDef *l_disk, libxl_device_disk *x_disk) x_disk->removable = 1; x_disk->readwrite = !l_disk->src->readonly; x_disk->is_cdrom = l_disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM ? 1 : 0; - if (libxlDiskSetDiscard(x_disk, l_disk->discard) < 0) - return -1; + libxlDiskSetDiscard(x_disk, l_disk->discard); libxlDiskSetScript(x_disk, src); /* An empty CDROM must have the empty format, otherwise libxl fails. */

2 3

[libvirt PATCH 00/12] tools: virsh: use g_auto more (glib chronicles)
by Ján Tomko 12 Aug '21

12 Aug '21

Incomprehensive series removing many cleanup sections. Patch 1/12 is common with my other series: [libvirt PATCH 0/3] xml: use g_auto for xmlXPathObject Ján Tomko (12): util: define cleanup func for xmlXPathObject tools: virsh: split variable declarations tools: virsh: cmdDominfo: rename 'ostype' variable tools: virsh: use automatic cleanup for virDomainObj tools: virsh: use automatic cleanup for xmlXPathContext tools: virsh: use automatic cleanup for xmlXPathObject tools: virsh: use automatic cleanup for xmlDoc tools: virsh: use automatic cleanup for vshTable tools: virsh: reduce variable scope to use automatic cleanup tools: virsh: use automatic cleanup for char ** tools: virsh: use g_autofree tools: virsh: remove redundant labels src/util/virxml.h | 1 + tools/virsh-completer-checkpoint.c | 4 +- tools/virsh-completer-domain.c | 57 +- tools/virsh-completer-snapshot.c | 3 +- tools/virsh-domain-monitor.c | 256 ++---- tools/virsh-domain.c | 1225 ++++++++++------------------ tools/virsh-host.c | 212 ++--- tools/virsh-interface.c | 21 +- tools/virsh-network.c | 24 +- tools/virsh-nodedev.c | 27 +- tools/virsh-nwfilter.c | 15 +- tools/virsh-pool.c | 34 +- tools/virsh-secret.c | 9 +- tools/virsh-util.c | 3 +- tools/virsh-volume.c | 35 +- tools/virsh.c | 3 +- tools/virt-admin.c | 6 +- tools/vsh.c | 11 +- 18 files changed, 660 insertions(+), 1286 deletions(-) -- 2.31.1

2 15

[PATCH 0/6] virsh: Some fixes noted when reviewing Jan's series
by Peter Krempa 12 Aug '21

12 Aug '21

Peter Krempa (6): virsh: Un-document 'virsh echo' virshtest: Don't use both '--xml' and '--shell' for 'virsh echo' virsh: cmdEcho: Make '--xml' and '--shell' mutually exclusive virsh: cmdEcho: Rewrite with new buffer helpers virsh: Add testing for vshStringToArray vshStringToArray: Rewrite using 'g_strsplit' docs/manpages/virsh.rst | 17 ------ tests/virshtest.c | 20 +++++-- tools/vsh.c | 115 +++++++++++++++++++--------------------- 3 files changed, 69 insertions(+), 83 deletions(-) -- 2.31.1

3 9

[libvirt PATCH] vsh: steal pointer in vshEditWriteToTempFile
by Ján Tomko 12 Aug '21

12 Aug '21

Fixes: 13896b5ad1d7f157273b6e49106df1f33958a9ed Signed-off-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed as trivial. Ears of shame were applied. tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index f9600bafba..96b3ced0ca 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2377,7 +2377,7 @@ vshEditWriteToTempFile(vshControl *ctl, const char *doc) } /* Temporary filename: caller frees. */ - return ret; + return g_steal_pointer(&ret); } /* Characters permitted in $EDITOR environment variable and temp filename. */ -- 2.31.1

1 0

[PATCH v3 00/11] Implement IOThreads related APIs for test driver
by Luke Yue 12 Aug '21

12 Aug '21

v3: - Rebase to current master branch - Fix compilation - Fix tests Luke Yue (11): domain_driver.c: Introduce and use virDomainDriverAddIOThreadCheck() test_driver: Introduce testIOThreadInfo and generate IOThread infos test_driver: Implement virDomainAddIOThread test_driver: Implement virDomainDelIOThread domain_driver.c: Introduce and use virDomainDriverGetIOThreadsConfig() test_driver: Implement virDomainGetIOThreadInfo test_driver: Implement virDomainPinIOThread test_driver: Implement testDomainSetIOThreadParams test_driver: Implement virConnectGetAllDomainStats test_driver: Introduce testDomainGetStatsIOThread tests: Test IOThread related functions for test driver examples/xml/test/testdomfc4.xml | 5 + src/hypervisor/domain_driver.c | 132 ++++++++ src/hypervisor/domain_driver.h | 10 + src/libvirt_private.syms | 3 + src/qemu/qemu_driver.c | 113 +------ src/test/meson.build | 1 + src/test/test_driver.c | 515 +++++++++++++++++++++++++++++++ tests/virshtest.c | 90 ++++++ 8 files changed, 761 insertions(+), 108 deletions(-) -- 2.32.0

1 12