- Devel - libvirt List Archives

[PATCH] qemuxml2argvtest: Fix tests failing on none x86 host CPUs
by Boris Fiuczynski 14 Sep '23

14 Sep '23

Since commit 54257ed51b51 on S390x qemuxml2argvtest fails with the following errors: 144) QEMU XML-2-ARGV cpu-kvmclock.x86_64-latest ... libvirt: CPU Driver error : the CPU is incompatible with host CPU: Host CPU does not provide required features: monitor FAILED 2023-09-14 13:01:23.883+0000: 4113077: info : libvirt version: 9.8.0 2023-09-14 13:01:23.883+0000: 4113077: info : hostname: a46lp61.lnxne.boe 2023-09-14 13:01:23.883+0000: 4113077: error : virCPUx86Compare:1954 : the CPU is incompatible with host CPU: Host CPU does not provide required features: monitor 1059) QEMU XML-2-ARGV cpu-check-partial.x86_64-latest ... libvirt: CPU Driver error : the CPU is incompatible with host CPU: Host CPU does not provide required features: monitor FAILED 2023-09-14 13:01:23.885+0000: 4113077: error : virCPUx86Compare:1954 : the CPU is incompatible with host CPU: Host CPU does not provide required features: monitor 1064) QEMU XML-2-ARGV cpu-check-default-partial2.x86_64-latest ... libvirt: CPU Driver error : the CPU is incompatible with host CPU: Host CPU does not provide required features: monitor FAILED 2023-09-14 13:01:23.885+0000: 4113077: error : virCPUx86Compare:1954 : the CPU is incompatible with host CPU: Host CPU does not provide required features: monitor 3 tests failed. Fixes: 54257ed51b5132032cedb7e1e7b8c34b9ae52115 Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- tests/qemuxml2argvtest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 0dd10f1fab..c3f05e83b9 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -1035,7 +1035,7 @@ mymain(void) DO_TEST_CAPS_VER("clock-hpet-off", "7.2.0"); DO_TEST_CAPS_LATEST("clock-hpet-off"); DO_TEST_CAPS_LATEST("clock-catchup"); - DO_TEST_CAPS_LATEST("cpu-kvmclock"); + DO_TEST_CAPS_ARCH_LATEST_FULL("cpu-kvmclock", "x86_64", ARG_CAPS_HOST_CPU_MODEL, QEMU_CPU_DEF_HASWELL); DO_TEST_CAPS_LATEST("cpu-host-kvmclock"); DO_TEST_CAPS_LATEST("kvmclock"); DO_TEST_CAPS_LATEST("clock-timer-hyperv-rtc"); @@ -2201,13 +2201,13 @@ mymain(void) DO_TEST_CAPS_LATEST("memfd-memory-default-hugepage"); DO_TEST_CAPS_LATEST("cpu-check-none"); - DO_TEST_CAPS_LATEST("cpu-check-partial"); + DO_TEST_CAPS_ARCH_LATEST_FULL("cpu-check-partial", "x86_64", ARG_CAPS_HOST_CPU_MODEL, QEMU_CPU_DEF_HASWELL); DO_TEST_CAPS_LATEST("cpu-check-full"); DO_TEST_CAPS_LATEST("cpu-check-default-none"); DO_TEST_CAPS_LATEST("cpu-check-default-none2"); /* this test case uses 'cpu="host-model"', run it with Haswell host cpu to prevent test case churn */ DO_TEST_CAPS_ARCH_LATEST_FULL("cpu-check-default-partial", "x86_64", ARG_CAPS_HOST_CPU_MODEL, QEMU_CPU_DEF_HASWELL); - DO_TEST_CAPS_LATEST("cpu-check-default-partial2"); + DO_TEST_CAPS_ARCH_LATEST_FULL("cpu-check-default-partial2", "x86_64", ARG_CAPS_HOST_CPU_MODEL, QEMU_CPU_DEF_HASWELL); DO_TEST_CAPS_LATEST("cpu-cache-disable"); /* this test case uses 'cpu="host-model"', run it with Haswell host cpu to prevent test case churn */ -- 2.41.0

2 1

[PATCH 00/20] Misc cleanups (pt. 1)
by Michal Privoznik 14 Sep '23

14 Sep '23

I had these sitting on a local branch for a while. My initial plan was to use virXMLPropEnum() more and while working on that I found one bug (patch 01/20), one improvement (patch 02/20) and a couple of useless typecats. Michal Prívozník (20): lxc_controller: Access correct union member in virLXCControllerSetupHostdevCaps() src: Access hostdev->source.subsys iff VIR_DOMAIN_HOSTDEV_MODE_SUBSYS qemu_domain_address: Drop needless typecast in qemuDomainDeviceCalculatePCIConnectFlags() qemu: Drop needless typecast to virDomainFSDriverType src: Drop needless typecast to virDomainDeviceType qemu_domain_address: Drop needless typecast to virDomainDiskModel src: Drop needless typecast to virDomainDiskBus virDomainHostdevSubsysSCSI: Convert 'protocol' field to proper enum type virDomainHostdevSubsysSCSIVHost: Convert 'protocol' field to proper enum type virDomainHostdevDef: Convert 'mode' field to proper enum type virDomainHostdevCaps: Convert 'type' field to proper enum type virDomainHostdevSubsys: Convert 'type' field to proper enum type virDomainControllerDef: Convert 'type' field to proper enum type virDomainRNGDef: Convert 'model' field to proper enum type virDomainRNGDef: Convert 'backend' field to proper enum type virDomainWatchdogDef: Convert 'model' field to proper enum type virDomainWatchdogDef: Convert 'action' field to proper enum type virDomainDeviceInfo: Convert 'type' field to proper enum type virStorageNetHostDef: Convert 'transport' field to proper enum type virDomainDiskSourceNVMeParse: Use virXMLPropULongLong() src/ch/ch_domain.c | 2 +- src/conf/device_conf.c | 12 +- src/conf/device_conf.h | 4 +- src/conf/domain_audit.c | 10 +- src/conf/domain_conf.c | 291 ++++++++---------- src/conf/domain_conf.h | 29 +- src/conf/domain_postparse.c | 2 +- src/conf/domain_validate.c | 9 +- src/conf/storage_source_conf.h | 2 +- src/libxl/libxl_driver.c | 12 + src/lxc/lxc_cgroup.c | 3 + src/lxc/lxc_controller.c | 9 +- src/lxc/lxc_driver.c | 16 + src/lxc/lxc_hostdev.c | 7 + src/qemu/qemu_alias.c | 2 +- src/qemu/qemu_backup.c | 2 +- src/qemu/qemu_block.c | 2 +- src/qemu/qemu_command.c | 26 +- src/qemu/qemu_domain.c | 18 +- src/qemu/qemu_domain_address.c | 28 +- src/qemu/qemu_driver.c | 6 +- src/qemu/qemu_hotplug.c | 22 +- src/qemu/qemu_migration.c | 4 +- src/qemu/qemu_monitor.c | 12 + src/qemu/qemu_monitor_json.c | 2 +- src/qemu/qemu_namespace.c | 2 +- src/qemu/qemu_validate.c | 18 +- src/security/security_apparmor.c | 2 +- src/security/security_dac.c | 4 +- src/security/security_selinux.c | 10 +- src/security/virt-aa-helper.c | 7 + .../storage_file_backend_gluster.c | 2 +- .../storage_source_backingstore.c | 15 +- src/vbox/vbox_common.c | 4 +- 34 files changed, 333 insertions(+), 263 deletions(-) -- 2.41.0

2 22

[libvirt PATCHv1 0/8] support running virtiofsd in session mode
by Ján Tomko 13 Sep '23

13 Sep '23

https://bugzilla.redhat.com/show_bug.cgi?id=2034630 https://gitlab.com/libvirt/libvirt/-/issues/535 https://gitlab.gnome.org/GNOME/gnome-boxes/-/issues/292 Ján Tomko (8): qemu: fix indentation conf: move idmap definition earlier conf: move idmap parsing earlier conf: add idmap element to filesystem qemu: format uid/gid map for virtiofs qemu: virtiofs: do not force UID 0 qemu: allow running virtiofsd in session mode docs: virtiofs: add section about ID remapping docs/formatdomain.rst | 7 + docs/kbase/virtiofs.rst | 29 ++++ src/conf/domain_conf.c | 149 ++++++++++++------ src/conf/domain_conf.h | 29 ++-- src/conf/schemas/domaincommon.rng | 3 + src/qemu/qemu_validate.c | 25 ++- src/qemu/qemu_virtiofs.c | 17 +- .../vhost-user-fs-fd-memory.xml | 4 + 8 files changed, 181 insertions(+), 82 deletions(-) -- 2.41.0

3 20

[libvirt PATCH] ci: jobs.sh: Add back '--no-suite syntax-check --print-errorlogs'
by Erik Skultety 13 Sep '23

13 Sep '23

Commit f688a53a converted .gitlab-ci.yml to the usage of ci/jobs.sh functions, but in doing that our test options '--no-suite syntax-check --print-errorlogs' got lost in the process and since commit 8e660c52 didn't introduce them in the first place, it caused a behavioral regression. This patch adds them back. Fixes: 8e660c5286d7e2d07dd61681074bf1555955552d Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Technically this is a build breaker fix, but sending for review anyway to see if there's an agreement on this approach. ci/jobs.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ci/jobs.sh b/ci/jobs.sh index abd695e231..eb4a4e29cf 100644 --- a/ci/jobs.sh +++ b/ci/jobs.sh @@ -39,7 +39,10 @@ run_dist() { } run_test() { + TEST_ARGS="${TEST_ARGS:=--no-suite syntax-check --print-errorlogs}" + test -f $GIT_ROOT/build/build.ninja || run_meson_setup + run_cmd meson test -C build $TEST_ARGS } -- 2.41.0

2 1

[libvirt PATCH v2 0/5] Add support for vDPA block devices
by Jonathon Jongsma 13 Sep '23

13 Sep '23

see https://bugzilla.redhat.com/show_bug.cgi?id=1900770. Changes in v2: - Don't use virStorageSource->path for vdpa device path to avoid clashing with existing path functionality - Move vdpa device opening to the qemuProcessPrepareHostStorageSource() function rather than the qemuDomainPrepareStorageSource() function. This also required some additional support in the tests for setting up the objects properly for testing. - rebased to latest master branch Jonathon Jongsma (5): conf: add ability to configure a vdpa block disk device qemu: add virtio-blk-vhost-vdpa capability qemu: make vdpa connect function more generic qemu: consider vdpa block devices for memlock limits qemu: Implement support for vDPA block devices docs/formatdomain.rst | 19 +++++++++- src/ch/ch_monitor.c | 1 + src/conf/domain_conf.c | 8 ++++ src/conf/schemas/domaincommon.rng | 13 +++++++ src/conf/storage_source_conf.c | 7 +++- src/conf/storage_source_conf.h | 2 + src/libxl/xen_xl.c | 1 + src/qemu/qemu_block.c | 20 ++++++++++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 24 +++++++++++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 12 +++++- src/qemu/qemu_interface.c | 23 ------------ src/qemu/qemu_interface.h | 2 - src/qemu/qemu_migration.c | 2 + src/qemu/qemu_process.c | 34 +++++++++++++++++ src/qemu/qemu_snapshot.c | 4 ++ src/qemu/qemu_validate.c | 33 +++++++++++++++-- src/storage_file/storage_source.c | 1 + .../caps_8.1.0_x86_64.xml | 1 + tests/qemuhotplugmock.c | 4 +- .../disk-vhostvdpa.x86_64-latest.args | 37 +++++++++++++++++++ tests/qemuxml2argvdata/disk-vhostvdpa.xml | 21 +++++++++++ tests/qemuxml2argvmock.c | 2 +- tests/qemuxml2argvtest.c | 34 +++++++++++++++++ tests/testutilsqemu.c | 11 ++++++ tests/testutilsqemu.h | 2 + 28 files changed, 285 insertions(+), 37 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-vhostvdpa.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-vhostvdpa.xml -- 2.41.0

4 11

[libvirt PATCH v2 00/35] ci: Unify the GitLab CI jobs with local executions && adopt lcitool container executions
by Erik Skultety 13 Sep '23

13 Sep '23

since v2 [1]: - moved the custom meson.build directory check before running setup to individual callers for better robustness, but actually let meson deal with an existing setup directory most of the time - drops the ci/Makefile - only set our verbose env variables when running without a TTY - switched the bright yellow (93m) color to green (32m) - added KeyboardInterrupt handling in the ci/helper Python code The changes above require the following lcitool MR to be merged first as they're built on top of it [2] [1] https://listman.redhat.com/archives/libvir-list/2023-August/241471.html [2] https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/431 Erik Skultety (35): ci: build.sh: Add variables from .gitlab-ci.yml ci: build.sh: Add GIT_ROOT env helper variable ci: build.sh: Don't mention that MESON_ARGS are available via CLI ci: build.sh: Add a wrapper function executing 'shell' commands ci: build.sh: Add a wrapper function over meson's setup ci: build.sh: Add a wrapper function over the 'build' job ci: build.sh: Add a helper function to create the dist tarball ci: build.sh: Add a wrapper function over the 'test' job ci: build.sh: Add a wrapper function over the 'codestyle' job ci: build.sh: Add a wrapper function over the 'potfile' job ci: build.sh: Add a wrapper function over the 'rpmbuild' job ci: build.sh: Add a wrapper function over the 'website' job ci: build.sh: Drop changing working directory to CI_CONT_DIR ci: build.sh: Drop direct invocation of meson/ninja commands ci: build.sh: Drop MESON_ARGS definition from global level ci: Rename build.sh -> jobs.sh .gitlab-ci.yml: Add 'after_script' stage to prep for artifact collection .gitlab-ci.yml: Convert the native build job to the build.sh usage .gitlab-ci.yml: Convert the cross build job to the build.sh usage .gitlab-ci.yml: Convert the website build job to the build.sh usage .gitlab-ci.yml: Convert the codestyle job to the build.sh usage .gitlab-ci.yml: Convert the potfile job to the build.sh usage ci: helper: Drop _lcitool_get_targets method ci: helper: Don't make ':' literal a static part of the image tag ci: helper: Add --lcitool-path CLI option ci: helper: Add a required_deps higher order helper/decorator ci: helper: Add Python code hangling git clones ci: helper: Add a helper to create a local repo clone Pythonic way ci: helper: Rework _lcitool_run method logic ci: helper: Add an action to run the container workload via lcitool ci: helper: Add a job argparse subparser ci: helper: Drop original actions ci: helper: Drop the --meson-args/--ninja-args CLI options ci: helper: Drop the _make_run method ci: Drop the now unused Makefile .gitlab-ci.yml | 47 +++++----- ci/Makefile | 245 ------------------------------------------------- ci/build.sh | 23 ----- ci/helper | 181 +++++++++++++++++++++--------------- ci/jobs.sh | 79 ++++++++++++++++ 5 files changed, 211 insertions(+), 364 deletions(-) delete mode 100644 ci/Makefile delete mode 100644 ci/build.sh create mode 100644 ci/jobs.sh -- 2.41.0

2 50

[PATCH (pushed)] virStorageSourceClear: Clear 'vdpadev' field
by Peter Krempa 13 Sep '23

13 Sep '23

Release memory for the recently added field. Fixes: 1df106cc20a4cc6417cfbaf01860f465ec3dd915 Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- src/conf/storage_source_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/storage_source_conf.c b/src/conf/storage_source_conf.c index f57cb3241d..f7f62c3966 100644 --- a/src/conf/storage_source_conf.c +++ b/src/conf/storage_source_conf.c @@ -1143,6 +1143,7 @@ virStorageSourceClear(virStorageSource *def) VIR_FREE(def->path); VIR_FREE(def->fdgroup); VIR_FREE(def->volume); + VIR_FREE(def->vdpadev); VIR_FREE(def->snapshot); VIR_FREE(def->configFile); VIR_FREE(def->query); -- 2.41.0

1 0

[PATCH 0/2] Check for capng_*() retvals
by Michal Privoznik 11 Sep '23

11 Sep '23

There's a commit inside of (yet-unreleased) libcap-ng which marks some functions as 'warned unused result'. Fedora rawhide already picked up the commit, but since we are not checking for all retvals we got a build failure on rawhide. https://src.fedoraproject.org/rpms/libcap-ng/c/fed9b23c8d0020e07c937a3ac0d6… Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-/pipelines/999435445 Michal Prívozník (2): lxc_container: Check retval of capng_get_caps_process() virutil: Check retval of capng_apply() src/lxc/lxc_container.c | 8 +++++++- src/util/virutil.c | 8 ++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) -- 2.41.0

3 4

[libvirt PATCH v4] ch: Fix cloud-hypervisor version processing
by Praveen K Paladugu 11 Sep '23

11 Sep '23

Refactor the version processing logic in ch driver to support versions from non-release cloud-hypervisor binaries. This version also supports versions with branch prefixes in them. Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> --- src/ch/ch_conf.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index a8565d9537..f421af5121 100644 --- a/src/ch/ch_conf.c +++ b/src/ch/ch_conf.c @@ -172,6 +172,29 @@ virCHDriverConfigDispose(void *obj) #define MIN_VERSION ((15 * 1000000) + (0 * 1000) + (0)) +/** + * chPreProcessVersionString: + * + * Returns: a pointer to numerical version without branch/commit info + */ +static char * +chPreProcessVersionString(char *version) +{ + char *tmp = strrchr(version, '/'); + + if (tmp) + version = tmp + 1; + + if (version[0] == 'v') + version++; + + tmp = strchr(version, '-'); + if (tmp) + *tmp = '\0'; + + return version; +} + int chExtractVersion(virCHDriver *driver) { @@ -193,13 +216,20 @@ chExtractVersion(virCHDriver *driver) tmp = help; - /* expected format: cloud-hypervisor v<major>.<minor>.<micro> */ - if ((tmp = STRSKIP(tmp, "cloud-hypervisor v")) == NULL) { + /* Below are example version formats and expected outputs: + * cloud-hypervisor v32.0.0 (expected: 32.0.0) + * cloud-hypervisor v33.0-104-ge0e3779e-dirty (expected: 33.0) + * cloud-hypervisor testing/v32.0.131-1-ga5d6db5c-dirty (expected: 32.0.131) + */ + if ((tmp = STRSKIP(tmp, "cloud-hypervisor ")) == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unexpected output of cloud-hypervisor binary")); return -1; } + tmp = chPreProcessVersionString(tmp); + VIR_DEBUG("Cloud-Hypervisor version detected: %s", tmp); + if (virStringParseVersion(&version, tmp, true) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unable to parse cloud-hypervisor version: %1$s"), tmp); -- 2.41.0

2 1

[PATCH v2] interface: fix udev_device_get_sysattr_value return value check
by Dmitry Frolov 11 Sep '23

11 Sep '23

Reviewing the code I found that return value of function udev_device_get_sysattr_value() is dereferenced without a check. udev_device_get_sysattr_value() may return NULL by number of reasons. v2: VIR_DEBUG added, replaced STREQ(NULLSTR()) with STREQ_NULLABLE() Signed-off-by: Dmitry Frolov <frolov(a)swemel.ru> --- src/interface/interface_backend_udev.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index a0485ddd21..df7066727e 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -23,6 +23,7 @@ #include <dirent.h> #include <libudev.h> +#include "virlog.h" #include "virerror.h" #include "virfile.h" #include "datatypes.h" @@ -40,6 +41,8 @@ #define VIR_FROM_THIS VIR_FROM_INTERFACE +VIR_LOG_INIT("interface.interface_backend_udev"); + struct udev_iface_driver { struct udev *udev; /* pid file FD, ensures two copies of the driver can't use the same root */ @@ -355,10 +358,13 @@ udevConnectListAllInterfaces(virConnectPtr conn, g_autoptr(virInterfaceDef) def = NULL; path = udev_list_entry_get_name(dev_entry); - dev = udev_device_new_from_syspath(udev, path); + if (!(dev = udev_device_new_from_syspath(udev, path))) { + VIR_DEBUG("Skipping interface '%s'", NULLSTR(path)); + continue; + } name = udev_device_get_sysname(dev); macaddr = udev_device_get_sysattr_value(dev, "address"); - status = STREQ(udev_device_get_sysattr_value(dev, "operstate"), "up"); + status = STREQ_NULLABLE(udev_device_get_sysattr_value(dev, "operstate"), "up"); def = udevGetMinimalDefForDevice(dev); if (!virConnectListAllInterfacesCheckACL(conn, def)) { @@ -964,9 +970,9 @@ udevGetIfaceDef(struct udev *udev, const char *name) /* MTU */ mtu_str = udev_device_get_sysattr_value(dev, "mtu"); - if (virStrToLong_ui(mtu_str, NULL, 10, &mtu) < 0) { + if (!mtu_str || virStrToLong_ui(mtu_str, NULL, 10, &mtu) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Could not parse MTU value '%1$s'"), mtu_str); + _("Could not parse MTU value '%1$s'"), NULLSTR(mtu_str)); goto error; } ifacedef->mtu = mtu; @@ -1089,7 +1095,7 @@ udevInterfaceIsActive(virInterfacePtr ifinfo) goto cleanup; /* Check if it's active or not */ - status = STREQ(udev_device_get_sysattr_value(dev, "operstate"), "up"); + status = STREQ_NULLABLE(udev_device_get_sysattr_value(dev, "operstate"), "up"); udev_device_unref(dev); -- 2.34.1

2 1

[libvirt PATCH 0/5] Add support for vDPA block devices
by Jonathon Jongsma 08 Sep '23

08 Sep '23

see https://bugzilla.redhat.com/show_bug.cgi?id=1900770. Jonathon Jongsma (5): conf: add ability to configure a vdpa block disk device qemu: add virtio-blk-vhost-vdpa capability qemu: make vdpa connect function more generic qemu: consider vdpa block devices for memlock limits qemu: Implement support for vDPA block devices docs/formatdomain.rst | 19 ++++++++- src/ch/ch_monitor.c | 1 + src/conf/domain_conf.c | 7 ++++ src/conf/schemas/domaincommon.rng | 13 +++++++ src/conf/storage_source_conf.c | 6 ++- src/conf/storage_source_conf.h | 1 + src/libxl/xen_xl.c | 1 + src/qemu/qemu_block.c | 20 ++++++++++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 24 +++++++++++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 37 +++++++++++++++++- src/qemu/qemu_interface.c | 23 ----------- src/qemu/qemu_interface.h | 2 - src/qemu/qemu_migration.c | 2 + src/qemu/qemu_snapshot.c | 4 ++ src/qemu/qemu_validate.c | 45 +++++++++++++++++++--- src/storage_file/storage_source.c | 1 + tests/qemuhotplugmock.c | 4 +- tests/qemuxml2argvdata/disk-vhostvdpa.args | 35 +++++++++++++++++ tests/qemuxml2argvdata/disk-vhostvdpa.xml | 21 ++++++++++ tests/qemuxml2argvmock.c | 2 +- tests/qemuxml2argvtest.c | 2 + 24 files changed, 235 insertions(+), 39 deletions(-) create mode 100644 tests/qemuxml2argvdata/disk-vhostvdpa.args create mode 100644 tests/qemuxml2argvdata/disk-vhostvdpa.xml -- 2.40.1

3 22

[PATCH] interface: fix udev_device_get_sysattr_value return value check
by Dmitry Frolov 08 Sep '23

08 Sep '23

Reviewing the code I found that return value of function udev_device_get_sysattr_value() is dereferenced without a check. udev_device_get_sysattr_value() may return NULL by number of reasons. Signed-off-by: Dmitry Frolov <frolov(a)swemel.ru> --- src/interface/interface_backend_udev.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index a0485ddd21..c820b3ccdf 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -355,10 +355,11 @@ udevConnectListAllInterfaces(virConnectPtr conn, g_autoptr(virInterfaceDef) def = NULL; path = udev_list_entry_get_name(dev_entry); - dev = udev_device_new_from_syspath(udev, path); + if (!(dev = udev_device_new_from_syspath(udev, path))) + continue; name = udev_device_get_sysname(dev); macaddr = udev_device_get_sysattr_value(dev, "address"); - status = STREQ(udev_device_get_sysattr_value(dev, "operstate"), "up"); + status = STREQ(NULLSTR(udev_device_get_sysattr_value(dev, "operstate")), "up"); def = udevGetMinimalDefForDevice(dev); if (!virConnectListAllInterfacesCheckACL(conn, def)) { @@ -964,9 +965,9 @@ udevGetIfaceDef(struct udev *udev, const char *name) /* MTU */ mtu_str = udev_device_get_sysattr_value(dev, "mtu"); - if (virStrToLong_ui(mtu_str, NULL, 10, &mtu) < 0) { + if (!mtu_str || virStrToLong_ui(mtu_str, NULL, 10, &mtu) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Could not parse MTU value '%1$s'"), mtu_str); + _("Could not parse MTU value '%1$s'"), NULLSTR(mtu_str)); goto error; } ifacedef->mtu = mtu; @@ -1089,7 +1090,7 @@ udevInterfaceIsActive(virInterfacePtr ifinfo) goto cleanup; /* Check if it's active or not */ - status = STREQ(udev_device_get_sysattr_value(dev, "operstate"), "up"); + status = STREQ(NULLSTR(udev_device_get_sysattr_value(dev, "operstate")), "up"); udev_device_unref(dev); -- 2.34.1

2 1

[PATCH] virnetdevopenvswitch: Propagate OVS error messages
by Michal Privoznik 08 Sep '23

08 Sep '23

When configuring OVS interfaces/bridges we spawn 'ovs-vsctl' with appropriate arguments and if it exited with a non-zero status we report a generic error message, like "Unable to add port vnet0 to OVS bridge ovsbr0". This is all cool, but the real reason why operation failed is hidden in (debug) logs because that's where virCommandRun() reports it unless caller requested otherwise. This is a bit clumsy because then we have to ask users to turn on debug logs and reproduce the problem again, e.g. [1]. Therefore, in cases where an error is reported to the user - just read ovs-vsctl's stderr and include it in the error message. For other cases (like VIR_DEBUG/VIR_WARN) - well they are meant to end up in (debug) logs anyway. 1: https://mail.openvswitch.org/pipermail/ovs-discuss/2023-September/052640.ht… Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virnetdevopenvswitch.c | 93 ++++++++++++++++++++------------- 1 file changed, 58 insertions(+), 35 deletions(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index 8dad6ed2bd..d836d05845 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -54,10 +54,14 @@ virNetDevOpenvswitchSetTimeout(unsigned int timeout) } static virCommand * -virNetDevOpenvswitchCreateCmd(void) +virNetDevOpenvswitchCreateCmd(char **errbuf) { virCommand *cmd = virCommandNew(OVS_VSCTL); + virCommandAddArgFormat(cmd, "--timeout=%u", virNetDevOpenvswitchTimeout); + if (errbuf) + virCommandSetErrorBuffer(cmd, errbuf); + return cmd; } @@ -137,6 +141,7 @@ int virNetDevOpenvswitchAddPort(const char *brname, const char *ifname, char ifuuidstr[VIR_UUID_STRING_BUFLEN]; char vmuuidstr[VIR_UUID_STRING_BUFLEN]; g_autoptr(virCommand) cmd = NULL; + g_autofree char *errbuf = NULL; g_autofree char *attachedmac_ex_id = NULL; g_autofree char *ifaceid_ex_id = NULL; g_autofree char *profile_ex_id = NULL; @@ -157,7 +162,7 @@ int virNetDevOpenvswitchAddPort(const char *brname, const char *ifname, ovsport->profileID); } - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(&errbuf); virCommandAddArgList(cmd, "--", "--may-exist", "add-port", brname, ifname, NULL); @@ -185,8 +190,8 @@ int virNetDevOpenvswitchAddPort(const char *brname, const char *ifname, if (virCommandRun(cmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to add port %1$s to OVS bridge %2$s"), - ifname, brname); + _("Unable to add port %1$s to OVS bridge %2$s: %3$s"), + ifname, brname, NULLSTR(errbuf)); return -1; } @@ -203,13 +208,15 @@ int virNetDevOpenvswitchAddPort(const char *brname, const char *ifname, */ int virNetDevOpenvswitchRemovePort(const char *brname G_GNUC_UNUSED, const char *ifname) { - g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(); + g_autofree char *errbuf = NULL; + g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(&errbuf); virCommandAddArgList(cmd, "--", "--if-exists", "del-port", ifname, NULL); if (virCommandRun(cmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to delete port %1$s from OVS"), ifname); + _("Unable to delete port %1$s from OVS: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -228,7 +235,8 @@ int virNetDevOpenvswitchRemovePort(const char *brname G_GNUC_UNUSED, const char int virNetDevOpenvswitchGetMigrateData(char **migrate, const char *ifname) { size_t len; - g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(); + g_autofree char *errbuf = NULL; + g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(&errbuf); virCommandAddArgList(cmd, "--if-exists", "get", "Interface", ifname, "external_ids:PortData", NULL); @@ -238,8 +246,8 @@ int virNetDevOpenvswitchGetMigrateData(char **migrate, const char *ifname) /* Run the command */ if (virCommandRun(cmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to run command to get OVS port data for interface %1$s"), - ifname); + _("Unable to run command to get OVS port data for interface %1$s: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -263,21 +271,22 @@ int virNetDevOpenvswitchGetMigrateData(char **migrate, const char *ifname) int virNetDevOpenvswitchSetMigrateData(char *migrate, const char *ifname) { g_autoptr(virCommand) cmd = NULL; + g_autofree char *errbuf = NULL; if (!migrate) { VIR_DEBUG("No OVS port data for interface %s", ifname); return 0; } - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(&errbuf); virCommandAddArgList(cmd, "set", "Interface", ifname, NULL); virCommandAddArgFormat(cmd, "external_ids:PortData=%s", migrate); /* Run the command */ if (virCommandRun(cmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to run command to set OVS port data for interface %1$s"), - ifname); + _("Unable to run command to set OVS port data for interface %1$s: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -371,7 +380,8 @@ int virNetDevOpenvswitchInterfaceStats(const char *ifname, virDomainInterfaceStatsPtr stats) { - g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(); + g_autofree char *errbuf = NULL; + g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(&errbuf); g_autofree char *output = NULL; virCommandAddArgList(cmd, "--if-exists", "--format=list", "--data=json", @@ -390,8 +400,9 @@ virNetDevOpenvswitchInterfaceStats(const char *ifname, if (virCommandRun(cmd, NULL) < 0 || STREQ_NULLABLE(output, "")) { /* no ovs-vsctl or interface 'ifname' doesn't exists in ovs */ - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Interface not found")); + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Interface not found: %1$s"), + NULLSTR(errbuf)); return -1; } @@ -433,7 +444,8 @@ virNetDevOpenvswitchInterfaceStats(const char *ifname, int virNetDevOpenvswitchInterfaceGetMaster(const char *ifname, char **master) { - g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(); + g_autofree char *errbuf = NULL; + g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(&errbuf); int exitstatus; *master = NULL; @@ -443,8 +455,8 @@ virNetDevOpenvswitchInterfaceGetMaster(const char *ifname, char **master) if (virCommandRun(cmd, &exitstatus) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to run command to get OVS master for interface %1$s"), - ifname); + _("Unable to run command to get OVS master for interface %1$s: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -546,7 +558,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path, return 0; } - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(NULL); if (server) { virCommandAddArgList(cmd, "--no-headings", "--columns=name", "find", @@ -600,7 +612,8 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path, int virNetDevOpenvswitchUpdateVlan(const char *ifname, const virNetDevVlan *virtVlan) { - g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(); + g_autofree char *errbuf = NULL; + g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(&errbuf); virCommandAddArgList(cmd, "--", "--if-exists", "clear", "Port", ifname, "tag", @@ -614,7 +627,8 @@ int virNetDevOpenvswitchUpdateVlan(const char *ifname, if (virCommandRun(cmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to set vlan configuration on port %1$s"), ifname); + _("Unable to set vlan configuration on port %1$s: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -629,7 +643,7 @@ virNetDevOpenvswitchFindUUID(const char *table, g_autoptr(virCommand) cmd = NULL; char *uuid = NULL; - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(NULL); virCommandAddArgList(cmd, "--no-heading", "--columns=_uuid", "find", table, vmid_ex_id, ifname_ex_id, NULL); virCommandSetOutputBuffer(cmd, &uuid); @@ -673,7 +687,7 @@ virNetDevOpenvswitchInterfaceClearTxQos(const char *ifname, if (!*line) { continue; } - listcmd = virNetDevOpenvswitchCreateCmd(); + listcmd = virNetDevOpenvswitchCreateCmd(NULL); virCommandAddArgList(listcmd, "--no-heading", "--columns=_uuid", "--if-exists", "list", "port", ifname, "qos", NULL); virCommandSetOutputBuffer(listcmd, &port_qos); @@ -681,13 +695,13 @@ virNetDevOpenvswitchInterfaceClearTxQos(const char *ifname, VIR_WARN("Unable to remove port qos on port %s", ifname); } if (port_qos && *port_qos) { - g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(); + g_autoptr(virCommand) cmd = virNetDevOpenvswitchCreateCmd(NULL); virCommandAddArgList(cmd, "remove", "port", ifname, "qos", line, NULL); if (virCommandRun(cmd, NULL) < 0) { VIR_WARN("Unable to remove port qos on port %s", ifname); } } - destroycmd = virNetDevOpenvswitchCreateCmd(); + destroycmd = virNetDevOpenvswitchCreateCmd(NULL); virCommandAddArgList(destroycmd, "destroy", "qos", line, NULL); if (virCommandRun(destroycmd, NULL) < 0) { VIR_WARN("Unable to destroy qos on port %s", ifname); @@ -706,7 +720,7 @@ virNetDevOpenvswitchInterfaceClearTxQos(const char *ifname, continue; } - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(NULL); virCommandAddArgList(cmd, "destroy", "queue", line, NULL); if (virCommandRun(cmd, NULL) < 0) { VIR_WARN("Unable to destroy queue on port %s", ifname); @@ -722,15 +736,17 @@ static int virNetDevOpenvswitchInterfaceClearRxQos(const char *ifname) { g_autoptr(virCommand) cmd = NULL; + g_autofree char *errbuf = NULL; - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(&errbuf); virCommandAddArgList(cmd, "set", "Interface", ifname, NULL); virCommandAddArgFormat(cmd, "ingress_policing_rate=%llu", 0llu); virCommandAddArgFormat(cmd, "ingress_policing_burst=%llu", 0llu); if (virCommandRun(cmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to reset ingress on port %1$s"), ifname); + _("Unable to reset ingress on port %1$s: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } @@ -754,6 +770,7 @@ virNetDevOpenvswitchInterfaceSetTxQos(const char *ifname, { char vmuuidstr[VIR_UUID_STRING_BUFLEN]; g_autoptr(virCommand) cmd = NULL; + g_autofree char *errbuf = NULL; g_autofree char *vmid_ex_id = NULL; g_autofree char *ifname_ex_id = NULL; g_autofree char *average = NULL; @@ -777,7 +794,7 @@ virNetDevOpenvswitchInterfaceSetTxQos(const char *ifname, qos_uuid = virNetDevOpenvswitchFindUUID("qos", vmid_ex_id, ifname_ex_id); /* create qos and set */ - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(&errbuf); if (queue_uuid && *queue_uuid) { g_auto(GStrv) lines = g_strsplit(queue_uuid, "\n", 0); virCommandAddArgList(cmd, "set", "queue", lines[0], NULL); @@ -806,17 +823,20 @@ virNetDevOpenvswitchInterfaceSetTxQos(const char *ifname, if (virCommandRun(cmd, NULL) < 0) { if (queue_uuid && *queue_uuid) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to set queue configuration on port %1$s"), ifname); + _("Unable to set queue configuration on port %1$s: %2$s"), + ifname, NULLSTR(errbuf)); } else { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to create and set qos configuration on port %1$s"), ifname); + _("Unable to create and set qos configuration on port %1$s: %2$s"), + ifname, NULLSTR(errbuf)); } return -1; } if (qos_uuid && *qos_uuid) { g_auto(GStrv) lines = g_strsplit(qos_uuid, "\n", 0); - g_autoptr(virCommand) qoscmd = virNetDevOpenvswitchCreateCmd(); + g_autofree char *qoserrbuf = NULL; + g_autoptr(virCommand) qoscmd = virNetDevOpenvswitchCreateCmd(&qoserrbuf); virCommandAddArgList(qoscmd, "set", "qos", lines[0], NULL); virCommandAddArgFormat(qoscmd, "other_config:min-rate=%s", average); @@ -829,7 +849,8 @@ virNetDevOpenvswitchInterfaceSetTxQos(const char *ifname, virCommandAddArgList(qoscmd, vmid_ex_id, ifname_ex_id, NULL); if (virCommandRun(qoscmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to set qos configuration on port %1$s"), ifname); + _("Unable to set qos configuration on port %1$s: %2$s"), + ifname, NULLSTR(qoserrbuf)); return -1; } } @@ -842,8 +863,9 @@ virNetDevOpenvswitchInterfaceSetRxQos(const char *ifname, const virNetDevBandwidthRate *rx) { g_autoptr(virCommand) cmd = NULL; + g_autofree char *errbuf = NULL; - cmd = virNetDevOpenvswitchCreateCmd(); + cmd = virNetDevOpenvswitchCreateCmd(&errbuf); virCommandAddArgList(cmd, "set", "Interface", ifname, NULL); virCommandAddArgFormat(cmd, "ingress_policing_rate=%llu", rx->average * VIR_NETDEV_RX_TO_OVS); @@ -853,7 +875,8 @@ virNetDevOpenvswitchInterfaceSetRxQos(const char *ifname, if (virCommandRun(cmd, NULL) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to set vlan configuration on port %1$s"), ifname); + _("Unable to set vlan configuration on port %1$s: %2$s"), + ifname, NULLSTR(errbuf)); return -1; } -- 2.41.0

2 1

Error : virHostCPUGetKVMMaxVCPUs:1228 : KVM is not supported on this platform: Function not implemented.
by Mario Marietto 07 Sep '23

07 Sep '23

Hello. I'm running Debian bookworm on my ARM Chromebook,model "xe303c12" and I've recompiled the kernel (5.4) to enable KVM,so now my system sounds like this : $ lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 12 (bookworm) Release: 12 Codename: bookworm $ uname -a Linux chromarietto 5.4.244-stb-cbe #8 SMP PREEMPT Sat Aug 19 22:19:32 UTC 2023 armv7l GNU/Linux $ uname -r 5.4.244-stb-cbe $ kvm-ok INFO: /dev/kvm exists KVM acceleration can be used $ qemu-system-arm --version QEMU emulator version 5.1.0 (v5.1.0-dirty) Copyright (c) 2003-2020 Fabrice Bellard and the QEMU Project developers $ python3 --version Python 3.11.2 I have installed libvirt 9.7.0,qemu 5.1 and virt-manager from source code with the final goal to be able to connect qemu,kvm and libvirt together to virtualize FreeBSD 13.2 for arm 32 bit. Some useful informations about my platform : root@chromarietto:/home/marietto/Desktop# virt-host-validate QEMU: Checking if device /dev/kvm exists : PASS QEMU: Checking if device /dev/kvm is accessible : PASS QEMU: Checking if device /dev/vhost-net exists : PASS QEMU: Checking if device /dev/net/tun exists : PASS QEMU: Checking for cgroup 'cpu' controller support : PASS QEMU: Checking for cgroup 'cpuacct' controller support : PASS QEMU: Checking for cgroup 'cpuset' controller support : PASS QEMU: Checking for cgroup 'memory' controller support : PASS QEMU: Checking for cgroup 'devices' controller support : PASS QEMU: Checking for cgroup 'blkio' controller support : PASS QEMU: Checking for device assignment IOMMU support : WARN (No ACPI IORT table found, IOMMU not supported by this hardware platform) QEMU: Checking for secure guest support : WARN (Unknown if this platform has Secure Guest support) LXC: Checking for Linux >= 2.6.26 : PASS LXC: Checking for namespace ipc : PASS LXC: Checking for namespace mnt : PASS LXC: Checking for namespace pid : PASS LXC: Checking for namespace uts : PASS LXC: Checking for namespace net : PASS LXC: Checking for namespace user : PASS LXC: Checking for cgroup 'cpu' controller support : PASS LXC: Checking for cgroup 'cpuacct' controller support : PASS LXC: Checking for cgroup 'cpuset' controller support : PASS LXC: Checking for cgroup 'memory' controller support : PASS LXC: Checking for cgroup 'devices' controller support : PASS LXC: Checking for cgroup 'freezer' controller support : FAIL (Enable 'freezer' in kernel Kconfig file or mount/enable cgroup controller in your system) LXC: Checking for cgroup 'blkio' controller support : PASS LXC: Checking if device /sys/fs/fuse/connections exists : PASS # lsmod | grep kvm no errors (I have embedded the options needed to enable KVM inside the kernel) # virsh --connect qemu:///system capabilities | grep baselabel <baselabel type='kvm'>+1002:+1002</baselabel> <baselabel type='qemu'>+1002:+1002</baselabel> The error that I'm not able to fix is the following one : root@chromarietto:~# virsh domcapabilities --machine virt --emulatorbin /usr/local/bin/qemu-system-arm 2023-08-29 10:17:59.110+0000: 1763: error : virHostCPUGetKVMMaxVCPUs:1228 : KVM is not supported on this platform: Function not implemented ; error: failed to get emulator capabilities error: KVM is not supported on this platform: Function not implemented and this is the log that I've got when I ran libvirtd with the debug option enabled root@chromarietto:~# libvirtd --debug [Tue, 29 Aug 2023 10:10:11 virt-manager 2141] DEBUG (createvm:494) UEFI found, setting it as default. [Tue, 29 Aug 2023 10:10:11 virt-manager 2141] DEBUG (createvm:728) Guest type set to os_type=hvm, arch=armv7l, dom_type=kvm [Tue, 29 Aug 2023 10:10:11 virt-manager 2141] DEBUG (guest:546) Prefer EFI => True 2023-08-29 10:10:12.972+0000: 1765: error : virHostCPUGetKVMMaxVCPUs:1228 : KVM is not supported on this platform: Function not implemented [Tue, 29 Aug 2023 10:10:12 virt-manager 2141] DEBUG (domcapabilities:250) Error fetching domcapabilities XML Traceback (most recent call last): File "/usr/local/share/virt-manager/virtinst/domcapabilities.py", line 245, in build_from_params xml = conn.getDomainCapabilities(emulator, arch, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/libvirt.py", line 4612, in getDomainCapabilities raise libvirtError('virConnectGetDomainCapabilities() failed') libvirt.libvirtError: KVM is not supported on this platform: Function not implemented *2023-08-29 10:10:14.157+0000: 1762: error : virHostCPUGetKVMMaxVCPUs:1228 : KVM is not supported on this platform: Function not implemented* [Tue, 29 Aug 2023 10:10:14 virt-manager 2141] DEBUG (domcapabilities:250) Error fetching domcapabilities XML Traceback (most recent call last): File "/usr/local/share/virt-manager/virtinst/domcapabilities.py", line 245, in build_from_params xml = conn.getDomainCapabilities(emulator, arch, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/lib/python3/dist-packages/libvirt.py", line 4612, in getDomainCapabilities raise libvirtError('virConnectGetDomainCapabilities() failed') libvirt.libvirtError: KVM is not supported on this platform: Function not implemented [Tue, 29 Aug 2023 10:10:14 virt-manager 2141] DEBUG (createvm:497) Error checking for UEFI default Traceback (most recent call last): File "/usr/local/share/virt-manager/virtManager/createvm.py", line 491, in _set_caps_state guest.enable_uefi() File "/usr/local/share/virt-manager/virtinst/guest.py", line 589, in enable_uefi path = self._lookup_default_uefi_path() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/share/virt-manager/virtinst/guest.py", line 848, in _lookup_default_uefi_path raise RuntimeError(_("Libvirt version does not support UEFI.")) RuntimeError: Libvirt version does not support UEFI Does anyone know how to fix that error ? -- Mario.

3 6

[libvirt PATCH v3] ch: Fix cloud-hypervisor version processing
by Praveen K Paladugu 07 Sep '23

07 Sep '23

Refactor the version processing logic in ch driver to support versions from non-release cloud-hypervisor binaries. This version also supports versions with branch prefixes in them. Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> --- src/ch/ch_conf.c | 42 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 40 insertions(+), 2 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index a8565d9537..5573119b23 100644 --- a/src/ch/ch_conf.c +++ b/src/ch/ch_conf.c @@ -172,6 +172,37 @@ virCHDriverConfigDispose(void *obj) #define MIN_VERSION ((15 * 1000000) + (0 * 1000) + (0)) +/** + * chPreProcessVersionString: + * + * Returns: a pointer to numerical version without branch/commit info + */ +static char * +chPreProcessVersionString(char *version) +{ + char *tmp_version = version; + g_autofree char *ret_version = NULL; + char *sub_string; + + if ((sub_string = strrchr(version, '/')) != NULL) { + tmp_version = sub_string + 1; + } + + if (tmp_version[0] == 'v') { + tmp_version = tmp_version + 1; + } + + // Duplicate the string in both cases. This would allow the calling method + // free the returned string in a consistent manner. + if ((sub_string = strchr(tmp_version, '-')) != NULL) { + ret_version = g_strndup(tmp_version, sub_string - tmp_version); + } else{ + ret_version = g_strdup(tmp_version); + } + + return g_steal_pointer(&ret_version); + +} int chExtractVersion(virCHDriver *driver) { @@ -193,13 +224,20 @@ chExtractVersion(virCHDriver *driver) tmp = help; - /* expected format: cloud-hypervisor v<major>.<minor>.<micro> */ - if ((tmp = STRSKIP(tmp, "cloud-hypervisor v")) == NULL) { + /* Below are some example version formats and expected outputs: + * cloud-hypervisor v32.0.0 (expected: 32.0.0) + * cloud-hypervisor v33.0-104-ge0e3779e-dirty (expected: 33.0) + * cloud-hypervisor testing/v32.0.131-1-ga5d6db5c-dirty (expected: 32.0.131) + */ + if ((tmp = STRSKIP(tmp, "cloud-hypervisor ")) == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unexpected output of cloud-hypervisor binary")); return -1; } + tmp = chPreProcessVersionString(tmp); + VIR_DEBUG("Cloud-Hypervisor version detected: %s", tmp); + if (virStringParseVersion(&version, tmp, true) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unable to parse cloud-hypervisor version: %1$s"), tmp); -- 2.41.0

3 2

Re: [libvirt PATCH v3] ch: Fix cloud-hypervisor version processing
by Praveen Paladugu 07 Sep '23

07 Sep '23

On Thu, Sep 07, 2023 at 09:02:44AM +0200, Jiri Denemark wrote: > On Wed, Sep 06, 2023 at 10:50:30 -0500, Praveen K Paladugu wrote: > > Refactor the version processing logic in ch driver to support versions > > from non-release cloud-hypervisor binaries. This version also supports > > versions with branch prefixes in them. > > > > Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> > > --- > > src/ch/ch_conf.c | 42 ++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 40 insertions(+), 2 deletions(-) > > > > diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c > > index a8565d9537..5573119b23 100644 > > --- a/src/ch/ch_conf.c > > +++ b/src/ch/ch_conf.c > > @@ -172,6 +172,37 @@ virCHDriverConfigDispose(void *obj) > > > > #define MIN_VERSION ((15 * 1000000) + (0 * 1000) + (0)) > > > > +/** > > + * chPreProcessVersionString: > > + * > > + * Returns: a pointer to numerical version without branch/commit info > > + */ > > +static char * > > +chPreProcessVersionString(char *version) > > +{ > > + char *tmp_version = version; > > + g_autofree char *ret_version = NULL; > > As Daniel pointed out in previous version this g_autofree and > g_steal_pointer below are useless as there is no path that actually free > the string here. > Thanks Jirka, I expected "autofree" attribute to be carried to "tmp" in the calling method, which would be freed when tmp goes out of scope. So, I implemented it this way. With some experimentation, I confirmed the correct behavior. I will fix this in my next version. > > + char *sub_string; > > + > > + if ((sub_string = strrchr(version, '/')) != NULL) { > > + tmp_version = sub_string + 1; > > + } > > + > > + if (tmp_version[0] == 'v') { > > + tmp_version = tmp_version + 1; > > + } > > + > > + // Duplicate the string in both cases. This would allow the calling method > > + // free the returned string in a consistent manner. > > Our coding style document says we prefer /* ... */ comments. > > > + if ((sub_string = strchr(tmp_version, '-')) != NULL) { > > + ret_version = g_strndup(tmp_version, sub_string - tmp_version); > > + } else{ > > + ret_version = g_strdup(tmp_version); > > + } > > + > > + return g_steal_pointer(&ret_version); > > + > > +} > > int > > chExtractVersion(virCHDriver *driver) > > { > > @@ -193,13 +224,20 @@ chExtractVersion(virCHDriver *driver) > > > > tmp = help; > > > > - /* expected format: cloud-hypervisor v<major>.<minor>.<micro> */ > > - if ((tmp = STRSKIP(tmp, "cloud-hypervisor v")) == NULL) { > > + /* Below are some example version formats and expected outputs: > > + * cloud-hypervisor v32.0.0 (expected: 32.0.0) > > + * cloud-hypervisor v33.0-104-ge0e3779e-dirty (expected: 33.0) > > + * cloud-hypervisor testing/v32.0.131-1-ga5d6db5c-dirty (expected: 32.0.131) > > + */ > > + if ((tmp = STRSKIP(tmp, "cloud-hypervisor ")) == NULL) { > > virReportError(VIR_ERR_INTERNAL_ERROR, "%s", > > _("Unexpected output of cloud-hypervisor binary")); > > return -1; > > } > > > > + tmp = chPreProcessVersionString(tmp); > > So chPreProcessVersionString returns an allocated string that will never > be freed because you assign it to tmp that's only used to point inside > other buffers and thus is (correctly) not freed anywhere. You need to > make sure the pointer returned here is freed before chExtractVersion > exits. Understood. > > > + VIR_DEBUG("Cloud-Hypervisor version detected: %s", tmp); > > + > > if (virStringParseVersion(&version, tmp, true) < 0) { > > virReportError(VIR_ERR_INTERNAL_ERROR, > > _("Unable to parse cloud-hypervisor version: %1$s"), tmp); > > Jirka

1 0

[PATCH] manpage: virsh: Note that 'virsh undefine --remove-all-storage' doesn't remove backing images
by Peter Krempa 07 Sep '23

07 Sep '23

Removing a backing image could break other image chains as it's theoretically possible to share backing chains. As --storage/--remove-all-storage is fully implemented in virsh as a helper option, which enumerates and deletes VM's volumes. We do not plan to make it any more complicated. Document that backing chains are not removed. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- docs/manpages/virsh.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 91e1d5de37..4ae3bb4d93 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4614,12 +4614,13 @@ undefined; if not all of the requested volumes could be deleted, the error message indicates what still remains behind. If a volume path is not found in the domain definition, it's treated as if the volume was successfully deleted. Only volumes managed by libvirt in storage pools can be removed this -way. +way. Note that this also removes only the top level image of a backing chain, +any backing stores of the image are kept as they may be shared. (See ``domblklist`` for list of target names associated to a domain). Example: --storage vda,/path/to/storage.img The *--remove-all-storage* flag specifies that all of the domain's storage -volumes should be deleted. +volumes should be deleted as if they were specified via *--storage*. The *--delete-storage-volume-snapshots* (previously *--delete-snapshots*) flag specifies that any snapshots associated with -- 2.41.0

2 1

[PATCH] virsh-snapshot: Avoid passing NULL to qsort() in virshSnapshotListCollect()
by Michal Privoznik 07 Sep '23

07 Sep '23

If a domain has no snapshots and 'virsh snapshot-list' is called, this gets all the way down to virshSnapshotListCollect() which then collects all snapshots (none), and passes them to qsort() which doesn't like being called with NULL: extern void qsort (void *__base, size_t __nmemb, size_t __size, __compar_fn_t __compar) __nonnull ((1, 4)); Resolves: https://gitlab.com/libvirt/libvirt/-/issues/533 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/virsh-snapshot.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index d7889a38e4..ecb935b2b4 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1310,9 +1310,11 @@ virshSnapshotListCollect(vshControl *ctl, virDomainPtr dom, } } } - if (!(orig_flags & VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL)) + if (!(orig_flags & VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL) && + snaplist->snaps) { qsort(snaplist->snaps, snaplist->nsnaps, sizeof(*snaplist->snaps), virshSnapSorter); + } snaplist->nsnaps -= deleted; ret = g_steal_pointer(&snaplist); -- 2.41.0

2 1

[PATCH] lxc: fix lxcContainerMountAllFS() DEREF_BEFORE_CHECK
by Dmitry Frolov 07 Sep '23

07 Sep '23

Reviewing the sources, I found, that in function lxcContainerMountAllFS() pointers vmDef->fss[i]->src and vmDef->fss[i]->src->path are checked for NULL after dereferencing in VIR_DEBUG() macro. Fixes: 57487085dc ("lxc: don't try to reference NULL when mounting filesystems") --- src/lxc/lxc_container.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index 21220661f7..58a6695458 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -1467,13 +1467,15 @@ static int lxcContainerMountAllFS(virDomainDef *vmDef, if (STREQ(vmDef->fss[i]->dst, "/")) continue; + if (!(vmDef->fss[i]->src && vmDef->fss[i]->src->path)) + return -1; + VIR_DEBUG("Mounting '%s' -> '%s'", vmDef->fss[i]->src->path, vmDef->fss[i]->dst); if (lxcContainerResolveSymlinks(vmDef->fss[i], false) < 0) return -1; - if (!(vmDef->fss[i]->src && vmDef->fss[i]->src->path && - STRPREFIX(vmDef->fss[i]->src->path, vmDef->fss[i]->dst)) && + if (!STRPREFIX(vmDef->fss[i]->src->path, vmDef->fss[i]->dst) && lxcContainerUnmountSubtree(vmDef->fss[i]->dst, false) < 0) return -1; -- 2.34.1

4 4

[PATCH Libvirt v3 00/10] Support dirty page rate upper limit
by ~hyman 07 Sep '23

07 Sep '23

Hi, This is the latest version for the series, please review. Thanks, Yong v3: - rebase on master and fix conflicts - refactor the comments and update the version tag v2: The patch set introduce a new API virDomainSetVcpuDirtyLimit to allow upper Apps to set upper limits of dirty page rate for virtual CPUs, the corresponding virsh API as follows: limit-dirty-page-rate <domain> <rate> [--vcpu <number>] \ [--config] [--live] [--current] We put the dirty limit persistent info with the "vcpus" element in domain XML and extend dirtylimit statistics for domGetStats: <domain> ... <vcpu current='2'>3</vcpu> <vcpus> <vcpu id='0' hotpluggable='no' dirty_limit='10' order='1'.../> <vcpu id='1' hotpluggable='yes' dirty_limit='10' order='2'.../> </vcpus> ... </domain> If --vcpu option is not passed in the virsh command, set all virtual CPUs; if rate is set to zero, cancel the upper limit. Examples: To set the dirty page rate upper limit 10 MB/s for all virtual CPUs in c81_node1, use: # virsh limit-dirty-page-rate c81_node1 --rate 10 --live Set dirty page rate limit 10(MB/s) for all virtual CPUs successfully # virsh dumpxml c81_node1 | grep dirty_limit <vcpu id='0' enabled='yes' hotpluggable='no' order='1' dirty_limit='10'/> <vcpu id='1' enabled='yes' hotpluggable='no' order='2' dirty_limit='10'/> <vcpu id='2' enabled='yes' hotpluggable='no' order='3' dirty_limit='10'/> <vcpu id='3' enabled='no' hotpluggable='yes' dirty_limit='10'/> <vcpu id='4' enabled='no' hotpluggable='yes' dirty_limit='10'/> ...... Query the dirty limit info dynamically: # virsh domstats c81_node1 --dirtylimit Domain: 'c81_node1' dirtylimit.vcpu.0.limit=10 dirtylimit.vcpu.0.current=0 dirtylimit.vcpu.1.limit=10 dirtylimit.vcpu.1.current=0 dirtylimit.vcpu.2.limit=10 dirtylimit.vcpu.2.current=0 dirtylimit.vcpu.3.limit=10 dirtylimit.vcpu.3.current=0 dirtylimit.vcpu.4.limit=10 dirtylimit.vcpu.4.current=0 ...... To cancel the upper limit, use: # virsh limit-dirty-page-rate c81_node1 --rate 0 --live Cancel dirty page rate limit for all virtual CPUs successfully # virsh dumpxml c81_node1 | grep dirty_limit # virsh domstats c81_node1 --dirtylimit Domain: 'c81_node1' The dirty limit uses the QEMU dirty-limit feature introduced since 7.1.0, this feature allows CPU to be throttled as needed to keep their dirty page rate within the limit. It could, in some scenes, be used to provide quality-of-service in the aspect of the memory workload for virtual CPUs and QEMU itself use the feature to implement the dirty-limit throttle algorithm and apply it on the live migration, which improve responsiveness of large guests during live migration and can result in more stable read performance. The other application scenarios remain unexplored, before that, Libvirt could provide the basic API. Hyman Huang(黄勇) (10): qemu_capabilities: Introduce QEMU_CAPS_VCPU_DIRTY_LIMIT capability conf: Introduce XML for dirty limit configuration libvirt: Add virDomainSetVcpuDirtyLimit API qemu_driver: Implement qemuDomainSetVcpuDirtyLimit domain_validate: Export virDomainDefHasDirtyLimitStartupVcpus symbol qemu_process: Setup dirty limit after launching VM virsh: Introduce limit-dirty-page-rate api qemu_monitor: Implement qemuMonitorQueryVcpuDirtyLimit qemu_driver: Extend dirtlimit statistics for domGetStats virsh: Introduce command 'virsh domstats --dirtylimit' docs/formatdomain.rst | 7 +- docs/manpages/virsh.rst | 38 +++- include/libvirt/libvirt-domain.h | 5 + src/conf/domain_conf.c | 26 +++ src/conf/domain_conf.h | 8 + src/conf/domain_validate.c | 33 ++++ src/conf/domain_validate.h | 2 + src/conf/schemas/domaincommon.rng | 5 + src/driver-hypervisor.h | 7 + src/libvirt-domain.c | 68 +++++++ src/libvirt_private.syms | 1 + src/libvirt_public.syms | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 181 ++++++++++++++++++ src/qemu/qemu_monitor.c | 25 +++ src/qemu/qemu_monitor.h | 22 +++ src/qemu/qemu_monitor_json.c | 107 +++++++++++ src/qemu/qemu_monitor_json.h | 9 + src/qemu/qemu_process.c | 44 +++++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 18 +- src/remote_protocol-structs | 7 + .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_riscv64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + tools/virsh-domain-monitor.c | 7 + tools/virsh-domain.c | 109 +++++++++++ 34 files changed, 739 insertions(+), 4 deletions(-) -- 2.38.5

4 17

[libvirt PATCH v2] ch: Fix cloud-hypervisor version processing
by Praveen K Paladugu 06 Sep '23

06 Sep '23

Refactor the version processing logic in ch driver to support versions from non-release cloud-hypervisor binaries. This version also supports versions with branch prefixes in them. Signed-off-by: Praveen K Paladugu <prapal(a)linux.microsoft.com> --- src/ch/ch_conf.c | 39 ++++++++++++++++++++++++++++++++++++--- 1 file changed, 36 insertions(+), 3 deletions(-) diff --git a/src/ch/ch_conf.c b/src/ch/ch_conf.c index a8565d9537..a0849bfbd6 100644 --- a/src/ch/ch_conf.c +++ b/src/ch/ch_conf.c @@ -172,6 +172,33 @@ virCHDriverConfigDispose(void *obj) #define MIN_VERSION ((15 * 1000000) + (0 * 1000) + (0)) +/** + * chPreProcessVersionString - crop branch, commit info and return just the version + */ +static char * +chPreProcessVersionString(char *version) +{ + g_autofree char *new_version = version; + char *tmp_version; + + if ((tmp_version = strrchr(version, '/')) != NULL) { + new_version = tmp_version + 1; + } + + if (new_version[0] == 'v') { + new_version = new_version + 1; + } + // Duplicate the string in both cases. This would allow the calling method + // free the returned string in a consistent manner. + if ((tmp_version = strchr(new_version, '-')) != NULL) { + new_version = g_strndup(new_version, tmp_version - new_version); + } else{ + new_version = g_strdup(new_version); + } + + return g_steal_pointer(&new_version); + +} int chExtractVersion(virCHDriver *driver) { @@ -193,19 +220,25 @@ chExtractVersion(virCHDriver *driver) tmp = help; - /* expected format: cloud-hypervisor v<major>.<minor>.<micro> */ - if ((tmp = STRSKIP(tmp, "cloud-hypervisor v")) == NULL) { + /* Below are some example version formats and expected outputs: + * cloud-hypervisor v32.0.0 (expected: 32.0.0) + * cloud-hypervisor v33.0-104-ge0e3779e-dirty (expected: 33.0) + * cloud-hypervisor testing/v32.0.131-1-ga5d6db5c-dirty (expected: 32.0.131) + */ + if ((tmp = STRSKIP(tmp, "cloud-hypervisor ")) == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Unexpected output of cloud-hypervisor binary")); return -1; } + tmp = chPreProcessVersionString(tmp); + VIR_DEBUG("Cloud-Hypervisor version detected: %s", tmp); + if (virStringParseVersion(&version, tmp, true) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unable to parse cloud-hypervisor version: %1$s"), tmp); return -1; } - if (version < MIN_VERSION) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Cloud-Hypervisor version is too old (v15.0 is the minimum supported version)")); -- 2.41.0

3 2

[libvirt PATCH 0/2] Add cpu model for EPYC Genoa
by Tim Wiederhake 06 Sep '23

06 Sep '23

Plus one drive-by improvement to sync_qemu_features_i386.py. Tim Wiederhake (2): cpu_map: Ignore all vmx-* features in sync_qemu_features_i386.py cpu_map: Add cpu model EPYC Genoa src/cpu_map/index.xml | 1 + src/cpu_map/meson.build | 1 + src/cpu_map/sync_qemu_features_i386.py | 90 +------------- src/cpu_map/x86_EPYC-Genoa.xml | 115 ++++++++++++++++++ .../domaincapsdata/qemu_8.1.0-q35.x86_64.xml | 1 + .../domaincapsdata/qemu_8.1.0-tcg.x86_64.xml | 1 + tests/domaincapsdata/qemu_8.1.0.x86_64.xml | 1 + 7 files changed, 121 insertions(+), 89 deletions(-) create mode 100644 src/cpu_map/x86_EPYC-Genoa.xml -- 2.39.2

2 3

[libvirt PATCH] rpm: Drop obsolete Obsoletes
by Andrea Bolognani 06 Sep '23

06 Sep '23

All platforms we target come with at least libvirt 6.0.0, so none of the Obsoletes referring to earlier versions are useful at this point. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- libvirt.spec.in | 7 ------- 1 file changed, 7 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b471afebb1..3e68961fb9 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -250,9 +250,6 @@ Requires: libvirt-daemon-driver-lxc = %{version}-%{release} %if %{with_qemu} Requires: libvirt-daemon-driver-qemu = %{version}-%{release} %endif -# We had UML driver, but we've removed it. -Obsoletes: libvirt-daemon-driver-uml <= 5.0.0 -Obsoletes: libvirt-daemon-uml <= 5.0.0 %if %{with_vbox} Requires: libvirt-daemon-driver-vbox = %{version}-%{release} %endif @@ -608,9 +605,6 @@ Requires: util-linux # From QEMU RPMs Requires: /usr/bin/qemu-img %endif -%if !%{with_storage_rbd} -Obsoletes: libvirt-daemon-driver-storage-rbd < 5.2.0 -%endif Obsoletes: libvirt-daemon-driver-storage-sheepdog < 8.8.0 %description daemon-driver-storage-core @@ -812,7 +806,6 @@ VirtualBox Summary: Libxl driver plugin for the libvirtd daemon Requires: libvirt-daemon-common = %{version}-%{release} Requires: libvirt-libs = %{version}-%{release} -Obsoletes: libvirt-daemon-driver-xen < 4.3.0 %description daemon-driver-libxl The Libxl driver plugin for the libvirtd daemon, providing -- 2.41.0

2 6

virDomainGetJobStats not populating VIR_DOMAIN_JOB_DISK_BPS
by João Vilaça 06 Sep '23

06 Sep '23

Hello, I'm using https://gitlab.com/libvirt/libvirt-go-module and executing 'GetJobStats' to get information about the progress of a VM with a disk migration in KubeVirt. Everything works correctly and the migration is successful, with the disk correctly copied. Across multiple executions of 'GetJobStats' while copying the disk, I get the information about data: *DataTotal:151592960 DataProcessedSet:true DataProcessed:163080901 DataRemainingSet:true DataRemaining:266240* about disk total values: *DiskTotal:21037056 DiskProcessedSet:true DiskProcessed:13631488 DiskRemainingSet:true DiskRemaining:7405568* but '*DiskBpsSet:false *' and '*DiskBps:0 *' are always false and 0. Even when I run 'virsh domjobinfo', I get Data and File absolute values, but not the throughput. Is QEMU not reporting this data? Can this be a bug? -- kind regards, João Vilaça

2 1

[PATCH 00/51] Finish conversion of all test cases in qemuxml2argvtest to real capabilities
by Peter Krempa 06 Sep '23

06 Sep '23

This series converts all outstanding test cases to use real capabilities. In the process few cases of pointless tests or features which are supported by every version of qemu were identified and addressed. To simplify the bulk of the conversion I've opted to simply set the most common capabilities in DO_TEST and DO_TEST_NOCAPS in addition to what the test asked for. This is done in a handful of patches and allows then a bulk conversion of many tests with no changes in the output files. I've payed special attention to CPU tests were I've ensured that they are semantically testing what they were before. Peter Krempa (51): qemu: Always assume support for QEMU_CAPS_PIIX_DISABLE_S* and QEMU_CAPS_ICH9_DISABLE_S* qemu: capabilities: Retire QEMU_CAPS_ICH9_DISABLE_S* and QEMU_CAPS_ICH9_DISABLE_S* capabilities qemu: capabilities: Preserve location of the default machine type when stripping aliases for tests qemuxml2argvtest: Clean up host CPU if overriden qemuxml2argvtest: testAddCPUModels: Remove non-x86_64 fake cpu models qemuxml2argvtest: Drop 'monitor-json' case qemu: Always assume support for QEMU_CAPS_CPU_CACHE qemu: capabilities: Retire QEMU_CAPS_CPU_CACHE qemu: Always assume support for QEMU_CAPS_DEVICE_VFIO_PCI qemu_capabilities: Retire QEMU_CAPS_DEVICE_VFIO_PCI qemuxml2argvtest: Add missing versioned test cases for 'cpu-host-model' qemuxml2argvtest: Remove old chardev tests qemuxml2argvtest: Simplify invocation of GIC tests qemuxml2argvtest: Remove duplicated test invocations qemuxml2argvtest: Remove fake-caps invocations of tests which also real caps version qemuxml2argvtest: Use proper version in negative 'virtio-options-memballoon-freepage-reporting' case qemuxml2argvtest: Use real caps for 'cpu-host-model-fallback' test case qemuxml2argvtest: Use real caps for 'cpu-host-model-nofallback' test case qemuxml2argvtest: Remove FLAG_SKIP_LEGACY_CPUS qemuxml2argvtest: Enable JSON syntax for -device, -object, and -netdev for all fake-caps tests virQEMUCapsAddCPUDefinitions: Fill in cpu type in data and node it's used only in tests qemuxml2argvtest: Modernize negative testing for hugepages qemuxml2argvtest: Modernize 'numatune' tests testutilsqemu: Always populate default ram id, default cpu, ACPI support for fake machines qemuxml2argvtest: Enable 'seccomp' sandbox in all fake caps tests qemuxml2argvtest: Consolidate tests for usb controllers qemuxml2argvtest: Add tests for auto-added USB controllers qemuxml2argvtest: Improve default usb controller testing qemuxml2argvtest: Consolidate testing of 'xhci' controllers qemuxml2argvtest: Assume QEMU_CAPS_PIIX3_USB_UHCI for all fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_DEVICE_PCIE_ROOT_PORT for fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_CPU_MIGRATABLE and QEMU_CAPS_SMP_DIES for fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_USB_HOST_HOSTDEVICE and QEMU_CAPS_DEVICE_QEMU_XHCI for fake-caps tests qemuxml2argvtest: Assume QEMU_CAPS_QXL_VRAM64, QEMU_CAPS_(QXL|VGA)_VGAMEM for fake-caps tests qemuxml2argvtest: Properly modernize 'clock-hpet-off' test case qemuxml2argvtest: Modernize migration/restore tests qemuxml2argvtest: Consolidate and modernize CPU topology testing qemuxml2argvtest: Modernize test cases using 'host-model' CPU qemuxml2argvtest: Modernize 'cpu-Haswell' test cases qemuxml2argvtest: Modernize 'cpu-minimum' cases qemuxml2argvtest: Modernize 'cpu-strict' case qemuxml2argvtest: Modernize 'cpu-(no)fallback' test qemuxml2argvtest: Modernize 'cpu-exact' cases qemuxml2argvtest: Modernize rest of the test cases testutilsqemu: Drop fake machine capability data for 'x86_64' qemustatusxml2xmltest: Remove capabilities infrastructure testutilsqemu: Drop infrastructure for fake-caps testing testutilsqemu: Unexport 'testQemuCapsInit' qemu: capabilities: Unexport 'virQEMUCapsAddMachine' qemuxml2argvtest: Remove cpu model faking for fake-caps tests qemu: capabilities: Remove 'virQEMUCapsAddCPUDefinitions' src/qemu/qemu_capabilities.c | 81 +- src/qemu/qemu_capabilities.h | 17 +- src/qemu/qemu_capspriv.h | 14 - src/qemu/qemu_command.c | 46 +- src/qemu/qemu_domain.c | 11 +- src/qemu/qemu_validate.c | 43 +- .../caps_4.2.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0_ppc64.xml | 1 - .../qemucapabilitiesdata/caps_4.2.0_s390x.xml | 1 - .../caps_4.2.0_x86_64.xml | 6 - .../caps_5.0.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.0.0_ppc64.xml | 1 - .../caps_5.0.0_riscv64.xml | 1 - .../caps_5.0.0_x86_64.xml | 6 - .../caps_5.1.0_x86_64.xml | 6 - .../caps_5.2.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0_ppc64.xml | 1 - .../caps_5.2.0_riscv64.xml | 1 - .../qemucapabilitiesdata/caps_5.2.0_s390x.xml | 1 - .../caps_5.2.0_x86_64.xml | 6 - .../caps_6.0.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.0.0_s390x.xml | 1 - .../caps_6.0.0_x86_64.xml | 6 - .../caps_6.1.0_x86_64.xml | 6 - .../caps_6.2.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 3 - .../caps_6.2.0_x86_64.xml | 6 - .../caps_7.0.0_aarch64+hvf.xml | 1 - .../caps_7.0.0_aarch64.xml | 1 - .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 3 - .../caps_7.0.0_x86_64.xml | 6 - .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 3 - .../caps_7.1.0_x86_64.xml | 6 - tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 3 - .../caps_7.2.0_x86_64+hvf.xml | 6 - .../caps_7.2.0_x86_64.xml | 6 - .../caps_8.0.0_riscv64.xml | 1 - .../caps_8.0.0_x86_64.xml | 6 - .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 - .../caps_8.1.0_x86_64.xml | 6 - tests/qemustatusxml2xmltest.c | 17 +- ...fx-ide-address-conflict.x86_64-latest.err} | 0 ...err => 440fx-wrong-root.x86_64-latest.err} | 0 ...ch64-gic-default-both.aarch64-latest.args} | 0 ...arch64-gic-default-v2.aarch64-latest.args} | 0 ...arch64-gic-default-v3.aarch64-latest.args} | 0 ...s => aarch64-gic-host.aarch64-latest.args} | 0 ...aarch64-gic-none-both.aarch64-latest.args} | 0 ... aarch64-gic-none-tcg.aarch64-latest.args} | 0 ...> aarch64-gic-none-v2.aarch64-latest.args} | 0 ...> aarch64-gic-none-v3.aarch64-latest.args} | 0 ...rgs => aarch64-gic-v2.aarch64-latest.args} | 0 ...rgs => aarch64-gic-v3.aarch64-latest.args} | 0 ...off.args => acpi-table.x86_64-latest.args} | 14 +- tests/qemuxml2argvdata/autoindex.args | 63 - .../autoindex.x86_64-latest.args | 65 + .../balloon-device-auto.x86_64-latest.args | 36 + ...loon-device-deflate-off.x86_64-latest.args | 36 + .../balloon-device-deflate.x86_64-latest.args | 36 + .../balloon-device-period.x86_64-latest.args | 36 + .../balloon-device.x86_64-latest.args | 36 + tests/qemuxml2argvdata/blkiotune-device.args | 34 - .../blkiotune-device.x86_64-latest.args | 36 + tests/qemuxml2argvdata/blkiotune.args | 34 - .../blkiotune.x86_64-latest.args | 36 + ...gs => channel-guestfwd.x86_64-latest.args} | 16 +- ...gs => channel-spicevmc.x86_64-latest.args} | 20 +- .../qemuxml2argvdata/channel-virtio-auto.args | 49 - .../channel-virtio-auto.x86_64-latest.args | 51 + .../channel-virtio-autoadd.args | 48 - .../channel-virtio-autoadd.x86_64-latest.args | 50 + .../channel-virtio-autoassign.args | 48 - ...annel-virtio-autoassign.x86_64-latest.args | 50 + .../channel-virtio-default.args | 41 - .../channel-virtio-default.x86_64-latest.args | 43 + .../channel-virtio-state.x86_64-latest.args | 43 + ...=> channel-virtio-unix.x86_64-latest.args} | 24 +- tests/qemuxml2argvdata/channel-virtio.args | 37 - ...args => channel-virtio.x86_64-latest.args} | 22 +- ...econnect-generated-path.x86_64-latest.err} | 0 ...connect-invalid-timeout.x86_64-latest.err} | 0 tests/qemuxml2argvdata/chardev-reconnect.args | 44 - .../chardev-reconnect.x86_64-latest.args | 46 + ....args => clock-catchup.x86_64-latest.args} | 14 +- ...e.args => clock-france.x86_64-latest.args} | 14 +- ....args => clock-hpet-off.x86_64-7.2.0.args} | 14 +- .../clock-hpet-off.x86_64-latest.args | 37 + ...altime-basis-localtime.x86_64-latest.args} | 14 +- ...rgs => clock-localtime.x86_64-latest.args} | 14 +- ...clock-timer-hyperv-rtc.x86_64-latest.args} | 11 +- ...-off.args => clock-utc.x86_64-latest.args} | 13 +- ...args => clock-variable.x86_64-latest.args} | 14 +- .../qemuxml2argvdata/console-compat-auto.args | 36 - .../console-compat-chardev.args | 36 - tests/qemuxml2argvdata/console-compat.args | 35 - ...=> console-virtio-many.x86_64-latest.args} | 24 +- ...args => console-virtio.x86_64-latest.args} | 18 +- tests/qemuxml2argvdata/controller-order.args | 52 - .../controller-order.x86_64-latest.args | 55 + ...s => cpu-Haswell-noTSX.x86_64-latest.args} | 11 +- ...ll.args => cpu-Haswell.x86_64-latest.args} | 11 +- ...2.args => cpu-Haswell2.x86_64-latest.args} | 11 +- ...3.args => cpu-Haswell3.x86_64-latest.args} | 11 +- .../cpu-cache-disable.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-cache-disable2.xml | 20 - .../cpu-cache-disable3.x86_64-latest.args | 33 + ...=> cpu-cache-emulate-l2.x86_64-latest.err} | 0 ...> cpu-cache-emulate-l3.x86_64-latest.args} | 13 +- ...pu-cache-passthrough-l3.x86_64-latest.err} | 0 .../cpu-cache-passthrough.args | 32 - ... cpu-cache-passthrough.x86_64-latest.args} | 13 +- .../cpu-cache-passthrough2.args | 32 - .../cpu-cache-passthrough2.xml | 20 - ... cpu-cache-passthrough3.x86_64-latest.err} | 0 .../cpu-check-default-none.args | 32 - .../cpu-check-default-none.x86_64-latest.args | 33 + ...pu-check-default-none2.x86_64-latest.args} | 11 +- .../cpu-check-default-partial.args | 32 - ...u-check-default-partial.x86_64-latest.args | 33 + ...check-default-partial2.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-check-full.args | 1 - .../cpu-check-full.x86_64-latest.args | 1 + ...args => cpu-check-none.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-check-partial.args | 1 - .../cpu-check-partial.x86_64-latest.args | 1 + ...ct1.args => cpu-exact1.x86_64-latest.args} | 11 +- ... cpu-exact2-nofallback.x86_64-latest.args} | 11 +- ...ct2.args => cpu-exact2.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-fallback.args | 32 - ...er.args => cpu-fallback.x86_64-5.2.0.args} | 9 +- .../cpu-fallback.x86_64-8.0.0.args | 33 + tests/qemuxml2argvdata/cpu-fallback.xml | 15 +- tests/qemuxml2argvdata/cpu-host-kvmclock.args | 32 - .../cpu-host-kvmclock.x86_64-latest.args | 33 + ... => cpu-host-model-cmt.x86_64-latest.args} | 11 +- ...cpu-host-model-fallback.x86_64-4.2.0.args} | 7 +- ...cpu-host-model-fallback.x86_64-5.0.0.args} | 7 +- .../cpu-host-model-fallback.x86_64-5.1.0.args | 33 + .../cpu-host-model-fallback.x86_64-5.2.0.args | 34 + .../cpu-host-model-fallback.x86_64-6.0.0.args | 34 + .../cpu-host-model-fallback.x86_64-6.1.0.args | 34 + .../cpu-host-model-fallback.x86_64-6.2.0.args | 34 + .../cpu-host-model-fallback.x86_64-7.0.0.args | 34 + .../cpu-host-model-fallback.x86_64-7.1.0.args | 34 + .../cpu-host-model-fallback.x86_64-7.2.0.args | 34 + .../cpu-host-model-fallback.x86_64-8.0.0.args | 33 + ...cpu-host-model-fallback.x86_64-latest.args | 33 + .../cpu-host-model-nofallback.err | 1 - ...pu-host-model-nofallback.x86_64-4.2.0.args | 33 + ...pu-host-model-nofallback.x86_64-5.0.0.args | 33 + ...pu-host-model-nofallback.x86_64-5.1.0.args | 33 + ...pu-host-model-nofallback.x86_64-5.2.0.args | 34 + ...pu-host-model-nofallback.x86_64-6.0.0.args | 34 + ...pu-host-model-nofallback.x86_64-6.1.0.args | 34 + ...pu-host-model-nofallback.x86_64-6.2.0.args | 34 + ...pu-host-model-nofallback.x86_64-7.0.0.args | 34 + ...pu-host-model-nofallback.x86_64-7.1.0.args | 34 + ...pu-host-model-nofallback.x86_64-7.2.0.args | 34 + ...pu-host-model-nofallback.x86_64-8.0.0.args | 33 + ...u-host-model-nofallback.x86_64-latest.args | 33 + .../cpu-host-model-vendor.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-host-model.args | 40 - .../cpu-host-model.x86_64-6.2.0.args | 39 + .../cpu-host-model.x86_64-7.0.0.args | 39 + .../cpu-host-model.x86_64-7.1.0.args | 39 + .../cpu-host-model.x86_64-7.2.0.args | 39 + .../cpu-host-model.x86_64-8.0.0.args | 38 + ...t-passthrough-features.x86_64-latest.args} | 14 +- .../cpu-host-passthrough.args | 32 - .../cpu-host-passthrough.x86_64-latest.args | 33 + ...k.args => cpu-kvmclock.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-minimum1.args | 32 - .../cpu-minimum1.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-minimum2.args | 32 - .../cpu-minimum2.x86_64-latest.args | 33 + ...pu-no-removed-features.x86_64-latest.args} | 11 +- tests/qemuxml2argvdata/cpu-nofallback.err | 1 - .../cpu-nofallback.x86_64-5.2.0.err | 1 + .../cpu-nofallback.x86_64-8.0.0.args | 33 + tests/qemuxml2argvdata/cpu-nofallback.xml | 15 +- tests/qemuxml2argvdata/cpu-numa-disjoint.args | 33 - .../cpu-numa-disjoint.x86_64-latest.args | 36 + .../cpu-numa-memshared.x86_64-latest.args | 36 + .../cpu-numa-no-memory-element.args | 33 - ...numa-no-memory-element.x86_64-latest.args} | 17 +- tests/qemuxml2argvdata/cpu-numa1.args | 33 - .../cpu-numa1.x86_64-latest.args | 36 + tests/qemuxml2argvdata/cpu-numa2.args | 33 - .../cpu-numa2.x86_64-latest.args | 36 + ...-numa3.err => cpu-numa3.x86_64-latest.err} | 0 .../cpu-phys-bits-emulate.args | 32 - ... cpu-phys-bits-emulate.x86_64-latest.args} | 13 +- .../cpu-phys-bits-emulate2.args | 32 - .../cpu-phys-bits-emulate2.x86_64-latest.args | 33 + .../cpu-phys-bits-passthrough.args | 32 - ...-phys-bits-passthrough.x86_64-latest.args} | 13 +- ...-phys-bits-passthrough2.x86_64-latest.err} | 0 ...u-qemu-host-passthrough.x86_64-latest.err} | 0 tests/qemuxml2argvdata/cpu-strict1.args | 32 - .../cpu-strict1.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-strict1.xml | 12 +- tests/qemuxml2argvdata/cpu-topology1.args | 31 - ....args => cpu-topology1.x86_64-latest.args} | 17 +- tests/qemuxml2argvdata/cpu-topology1.xml | 4 +- tests/qemuxml2argvdata/cpu-topology2.args | 32 - .../cpu-topology2.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-topology2.xml | 5 +- tests/qemuxml2argvdata/cpu-topology3.args | 31 - .../cpu-topology3.x86_64-latest.args | 33 + tests/qemuxml2argvdata/cpu-topology3.xml | 2 +- .../cpu-topology4.x86_64-latest.args | 33 + .../{monitor-json.xml => cpu-topology4.xml} | 18 +- ...s => cpu-tsc-frequency.x86_64-latest.args} | 11 +- ... default-kvm-host-arch.x86_64-latest.args} | 12 +- ...default-qemu-host-arch.x86_64-latest.args} | 12 +- .../graphics-egl-headless.args | 33 - ...raphics-sdl-fullscreen.x86_64-latest.args} | 14 +- ...l.args => graphics-sdl.x86_64-latest.args} | 14 +- ...isplay-missing-graphics.x86_64-latest.err} | 0 ... hostdev-mdev-duplicate.x86_64-latest.err} | 0 ...-invalid-target-address.x86_64-latest.err} | 0 ...ostdev-mdev-precreated.x86_64-latest.args} | 12 +- ...dev-src-address-invalid.x86_64-latest.err} | 0 .../hostdev-pci-address-unassigned.args | 34 - ...-pci-address-unassigned.x86_64-latest.args | 36 + ...> hostdev-pci-duplicate.x86_64-latest.err} | 0 .../hostdev-pci-multifunction.args | 38 - ...stdev-pci-multifunction.x86_64-latest.args | 40 + ... hostdev-scsi-duplicate.x86_64-latest.err} | 0 ...ev-scsi-vhost-scsi-pci.x86_64-latest.args} | 22 +- ...> hostdev-usb-duplicate.x86_64-latest.err} | 0 ...stdev-vfio-multidomain.x86_64-latest.args} | 17 +- ...ev-vfio-zpci-wrong-arch.x86_64-latest.err} | 0 tests/qemuxml2argvdata/hostdev-vfio.args | 35 - ...n.args => hostdev-vfio.x86_64-latest.args} | 16 +- ...e.args => hotplug-base.x86_64-latest.args} | 13 +- ...s-default-1G-nodeset-2M.x86_64-latest.err} | 0 ...pages-memaccess-invalid.x86_64-latest.err} | 0 ... => hugepages-memaccess3.x86_64-5.1.0.err} | 0 .../qemuxml2argvdata/input-usbmouse-addr.args | 35 - .../input-usbmouse-addr.x86_64-latest.args | 37 + .../input-usbmouse.x86_64-latest.args | 36 + tests/qemuxml2argvdata/input-usbtablet.args | 34 - .../input-usbtablet.x86_64-latest.args | 36 + ....args => kvm-pit-delay.x86_64-latest.args} | 14 +- ...rgs => kvm-pit-discard.x86_64-latest.args} | 14 +- ...clock.args => kvmclock.x86_64-latest.args} | 9 +- tests/qemuxml2argvdata/machine-aliases1.args | 34 - .../machine-aliases1.x86_64-latest.args | 36 + ...gs => machine-aliases2.x86_64-latest.args} | 15 +- .../machine-core-off.x86_64-latest.args | 35 + tests/qemuxml2argvdata/machine-core-on.args | 33 - ...rgs => machine-core-on.x86_64-latest.args} | 13 +- ...dparm-s390-char-invalid.x86_64-latest.err} | 0 ...adparm-s390-len-invalid.x86_64-latest.err} | 0 .../qemuxml2argvdata/machine-vmport-opt.args | 34 - .../machine-vmport-opt.x86_64-latest.args | 36 + ...rr => memory-align-fail.x86_64-latest.err} | 0 .../memory-hotplug-dimm.x86_64-latest.args | 41 + ...plug-invalid-targetnode.x86_64-latest.err} | 0 ...> memory-hotplug-nonuma.x86_64-latest.err} | 0 tests/qemuxml2argvdata/memory-hotplug.args | 35 - ...args => memory-hotplug.x86_64-latest.args} | 22 +- tests/qemuxml2argvdata/memtune-unlimited.args | 34 - .../memtune-unlimited.x86_64-latest.args | 36 + tests/qemuxml2argvdata/memtune.args | 34 - .../memtune.x86_64-latest.args | 36 + ...migrate-numa-unaligned.x86_64-latest.args} | 17 +- ...igrate.args => migrate.x86_64-latest.args} | 12 +- ...rr => minimal-no-memory.x86_64-latest.err} | 0 tests/qemuxml2argvdata/minimal.args | 34 - .../minimal.x86_64-latest.args | 36 + tests/qemuxml2argvdata/misc-acpi.args | 32 - ...late.args => misc-acpi.x86_64-latest.args} | 13 +- ...rgs => misc-disable-s3.x86_64-latest.args} | 12 +- ... misc-disable-suspends.x86_64-latest.args} | 12 +- tests/qemuxml2argvdata/misc-enable-s4.err | 1 - ...args => misc-enable-s4.x86_64-latest.args} | 12 +- tests/qemuxml2argvdata/misc-uuid.args | 32 - ...auto.args => misc-uuid.x86_64-latest.args} | 13 +- tests/qemuxml2argvdata/monitor-json.args | 34 - .../multifunction-pci-device.args | 43 - ...ultifunction-pci-device.x86_64-latest.args | 45 + ...s.args => nosharepages.x86_64-latest.args} | 12 +- .../numad-auto-memory-vcpu-cpuset.args | 34 - ...auto-memory-vcpu-cpuset.x86_64-latest.args | 36 + ...o-memory-vcpu-no-cpuset-and-placement.args | 34 - ...no-cpuset-and-placement.x86_64-latest.args | 36 + ...tic-numatune-no-nodeset.x86_64-latest.err} | 0 .../numad-auto-vcpu-static-numatune.args | 34 - ...to-vcpu-static-numatune.x86_64-latest.args | 36 + .../numad-static-memory-auto-vcpu.args | 34 - ...static-memory-auto-vcpu.x86_64-latest.args | 36 + tests/qemuxml2argvdata/numad.args | 34 - .../qemuxml2argvdata/numad.x86_64-latest.args | 36 + .../numatune-auto-nodeset-invalid.args | 34 - ...ne-auto-nodeset-invalid.x86_64-latest.args | 36 + ...> numatune-auto-prefer.x86_64-latest.args} | 14 +- ... => numatune-distances.x86_64-latest.args} | 28 +- ...ne-memnode-invalid-mode.x86_64-latest.err} | 0 ...tune-memnode-no-memory.x86_64-latest.args} | 15 +- ... numatune-memnode-nocpu.x86_64-latest.err} | 0 tests/qemuxml2argvdata/numatune-memnode.args | 37 - ...ne-memnodes-problematic.x86_64-latest.err} | 0 ...-memory-invalid-nodeset.x86_64-latest.err} | 0 tests/qemuxml2argvdata/numatune-memory.args | 34 - tests/qemuxml2argvdata/numatune-memory.xml | 31 - ...nodeset-exceed-hostnode.x86_64-latest.err} | 0 .../parallel-parport-chardev.args | 36 - .../parallel-tcp-chardev.args | 36 - tests/qemuxml2argvdata/pci-autoadd-addr.args | 41 - .../pci-autoadd-addr.x86_64-latest.args | 44 + tests/qemuxml2argvdata/pci-autoadd-idx.args | 42 - .../pci-autoadd-idx.x86_64-latest.args | 45 + ...s => pci-autofill-addr.x86_64-latest.args} | 16 +- ...-bridge-duplicate-index.x86_64-latest.err} | 0 ... pci-bridge-many-disks.x86_64-latest.args} | 224 ++-- ...-negative-index-invalid.x86_64-latest.err} | 0 tests/qemuxml2argvdata/pci-bridge.args | 101 -- .../pci-bridge.x86_64-latest.args | 104 ++ ....err => pci-bus-invalid.x86_64-latest.err} | 0 ...r => pci-domain-invalid.x86_64-latest.err} | 0 ...ci-expander-bus-bad-bus.x86_64-latest.err} | 0 ...xpander-bus-bad-machine.x86_64-latest.err} | 0 ...i-expander-bus-bad-node.x86_64-latest.err} | 0 tests/qemuxml2argvdata/pci-expander-bus.args | 98 -- .../pci-expander-bus.x86_64-latest.args | 101 ++ ...=> pci-function-invalid.x86_64-latest.err} | 0 ...-many.args => pci-many.x86_64-latest.args} | 71 +- .../pci-rom-disabled-invalid.args | 1 - ...ci-rom-disabled-invalid.x86_64-latest.args | 1 + ...gs => pci-rom-disabled.x86_64-latest.args} | 12 +- .../pci-rom.x86_64-latest.args | 42 + ...err => pci-root-address.x86_64-latest.err} | 0 ... pci-root-nonzero-index.x86_64-latest.err} | 0 .../pci-serial-dev-chardev.args | 36 - ...err => pci-slot-invalid.x86_64-latest.err} | 0 ...ie-expander-bus-bad-bus.x86_64-latest.err} | 0 ...xpander-bus-bad-machine.x86_64-latest.err} | 0 tests/qemuxml2argvdata/pcie-expander-bus.args | 135 -- .../pcie-expander-bus.x86_64-latest.args | 140 ++ ...oot-port-model-generic.x86_64-latest.args} | 14 +- ...oot-port-model-ioh3420.x86_64-latest.args} | 14 +- ...pcie-root-port-too-many.x86_64-latest.err} | 0 ...args => pcie-root-port.x86_64-latest.args} | 17 +- ...root.args => pcie-root.x86_64-latest.args} | 11 +- .../pcie-switch-downstream-port.args | 45 - ...-switch-downstream-port.x86_64-latest.args | 48 + .../pcie-switch-upstream-port.args | 39 - ...ie-switch-upstream-port.x86_64-latest.args | 43 + ....args => pcihole64-q35.x86_64-latest.args} | 15 +- ...le64.args => pcihole64.x86_64-latest.args} | 12 +- ...rgs => pmu-feature-off.x86_64-latest.args} | 8 +- ...re.args => pmu-feature.x86_64-latest.args} | 8 +- ...eatures-invalid-machine.x86_64-latest.err} | 0 ...-serial-invalid-machine.x86_64-latest.err} | 0 ...=> q35-dmi-bad-address1.x86_64-latest.err} | 0 ...=> q35-dmi-bad-address2.x86_64-latest.err} | 0 .../q35-pci-force-address.args | 38 - .../q35-pci-force-address.x86_64-latest.args | 40 + .../q35-pm-disable-fallback.args | 37 - .../q35-pm-disable-fallback.xml | 18 - tests/qemuxml2argvdata/q35-pm-disable.args | 37 - tests/qemuxml2argvdata/q35-pm-disable.xml | 18 - tests/qemuxml2argvdata/q35-usb2-multi.args | 49 - .../q35-usb2-multi.x86_64-latest.args | 51 + tests/qemuxml2argvdata/q35-usb2-reorder.args | 49 - .../q35-usb2-reorder.x86_64-latest.args | 51 + .../q35-usb2.x86_64-latest.args | 43 + ...t.err => q35-wrong-root.x86_64-latest.err} | 0 tests/qemuxml2argvdata/q35.args | 39 - .../{q35-usb2.args => q35.x86_64-latest.args} | 23 +- tests/qemuxml2argvdata/q35.xml | 4 + ...nv.args => qemu-ns-alt.x86_64-latest.args} | 15 +- .../qemu-ns-commandline-ns0.args | 34 - ...qemu-ns-commandline-ns0.x86_64-latest.args | 36 + .../qemu-ns-commandline-ns1.args | 34 - ...qemu-ns-commandline-ns1.x86_64-latest.args | 36 + .../qemuxml2argvdata/qemu-ns-commandline.args | 34 - .../qemu-ns-commandline.x86_64-latest.args | 36 + .../qemu-ns-domain-commandline-ns0.args | 34 - ...-domain-commandline-ns0.x86_64-latest.args | 36 + .../qemu-ns-domain-commandline.args | 34 - ...u-ns-domain-commandline.x86_64-latest.args | 36 + .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 34 - .../qemu-ns-domain-ns0.x86_64-latest.args | 36 + ...args => qemu-ns-no-env.x86_64-latest.args} | 15 +- ...eboot-timeout-disabled.x86_64-latest.args} | 10 +- ...reboot-timeout-enabled.x86_64-latest.args} | 10 +- ....args => restore-v2-fd.x86_64-latest.args} | 14 +- ...-v2.args => restore-v2.x86_64-latest.args} | 12 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 34 - .../seclabel-dac-none.x86_64-latest.args | 36 + ...label-device-duplicates.x86_64-latest.err} | 0 ...-device-relabel-invalid.x86_64-latest.err} | 0 .../seclabel-dynamic-baselabel.args | 34 - ...label-dynamic-baselabel.x86_64-latest.args | 36 + .../seclabel-dynamic-labelskip.args | 34 - ...label-dynamic-labelskip.x86_64-latest.args | 36 + ...label-dynamic-override.x86_64-latest.args} | 16 +- .../seclabel-dynamic-relabel.args | 34 - ...eclabel-dynamic-relabel.x86_64-latest.args | 36 + tests/qemuxml2argvdata/seclabel-dynamic.args | 34 - .../seclabel-dynamic.x86_64-latest.args | 36 + ...rr => seclabel-multiple.x86_64-latest.err} | 0 tests/qemuxml2argvdata/seclabel-none.args | 34 - .../seclabel-none.x86_64-latest.args | 36 + .../seclabel-static-labelskip.args | 34 - ...clabel-static-labelskip.x86_64-latest.args | 36 + .../seclabel-static-relabel.args | 34 - ...seclabel-static-relabel.x86_64-latest.args | 36 + tests/qemuxml2argvdata/seclabel-static.args | 34 - .../seclabel-static.x86_64-latest.args | 36 + .../serial-dev-chardev-iobase.args | 36 - .../qemuxml2argvdata/serial-dev-chardev.args | 36 - .../qemuxml2argvdata/serial-file-chardev.args | 37 - tests/qemuxml2argvdata/serial-file-log.args | 37 - .../qemuxml2argvdata/serial-many-chardev.args | 39 - .../qemuxml2argvdata/serial-pty-chardev.args | 36 - tests/qemuxml2argvdata/serial-spiceport.args | 38 - .../qemuxml2argvdata/serial-tcp-chardev.args | 36 - .../serial-tcp-telnet-chardev.args | 36 - .../serial-tcp-tlsx509-chardev-verify.args | 39 - .../serial-tcp-tlsx509-chardev.args | 39 - .../serial-tcp-tlsx509-secret-chardev.args | 40 - .../qemuxml2argvdata/serial-udp-chardev.args | 38 - tests/qemuxml2argvdata/serial-vc-chardev.args | 36 - .../smartcard-controller.x86_64-latest.args | 35 + ...t-certificates-database.x86_64-latest.args | 35 + .../smartcard-host-certificates.args | 33 - ...tcard-host-certificates.x86_64-latest.args | 35 + tests/qemuxml2argvdata/smartcard-host.args | 33 - .../smartcard-host.x86_64-latest.args | 35 + ...d-passthrough-spicevmc.x86_64-latest.args} | 18 +- ...rtcard-passthrough-tcp.x86_64-latest.args} | 16 +- ...date.err => smbios-date.x86_64-latest.err} | 0 ...rr => smbios-uuid-match.x86_64-latest.err} | 0 ...{smbios.args => smbios.x86_64-latest.args} | 14 +- tests/qemuxml2argvdata/smp-dies.args | 33 - tests/qemuxml2argvdata/smp.args | 33 - ... tpm-no-backend-invalid.x86_64-latest.err} | 0 ....err => usb-bus-missing.x86_64-latest.err} | 0 ...troller-default-i440fx.x86_64-latest.args} | 14 +- ....xml => usb-controller-default-i440fx.xml} | 0 ...controller-default-isapc.x86_64-latest.err | 1 + .../usb-controller-default-isapc.xml | 16 + ...controller-default-q35.x86_64-latest.args} | 10 +- ...ult-unavailable-i440fx.x86_64-latest.args} | 12 +- ...-controller-default-unavailable-i440fx.xml | 1 + ...default-unavailable-q35.x86_64-latest.err} | 0 ...sb-controller-explicit-unavailable-q35.xml | 1 - ...troller-ich9-autoassign.x86_64-latest.args | 41 + ...xml => usb-controller-ich9-autoassign.xml} | 0 ...ntroller-ich9-companion.x86_64-latest.args | 36 + ....xml => usb-controller-ich9-companion.xml} | 0 ...ntroller-ich9-ehci-addr.x86_64-latest.args | 44 + ....xml => usb-controller-ich9-ehci-addr.xml} | 0 ...oller-ich9-no-companion.x86_64-latest.err} | 0 ...l => usb-controller-ich9-no-companion.xml} | 0 ...roller-implicit-i440fx.x86_64-latest.args} | 13 +- ...xml => usb-controller-implicit-i440fx.xml} | 1 - ...troller-implicit-isapc.x86_64-latest.args} | 8 +- .../usb-controller-implicit-isapc.xml | 15 + ...controller-implicit-q35.x86_64-latest.args | 36 + .../usb-controller-implicit-q35.xml | 15 + ...ntroller-nec-xhci-limit.x86_64-latest.err} | 0 ....xml => usb-controller-nec-xhci-limit.xml} | 0 ...er-nec-xhci-unavailable.x86_64-latest.err} | 0 .../usb-controller-nec-xhci-unavailable.xml | 1 + ...sb-controller-nec-xhci.x86_64-latest.args} | 10 +- ...it-q35.xml => usb-controller-nec-xhci.xml} | 0 ...ler-nex-xhci-autoassign.x86_64-latest.args | 37 + ...=> usb-controller-nex-xhci-autoassign.xml} | 0 ...> usb-controller-piix3.x86_64-latest.args} | 15 +- ...ontroller.xml => usb-controller-piix3.xml} | 0 ...troller-qemu-xhci-limit.x86_64-latest.err} | 0 .../usb-controller-qemu-xhci-unavailable.err | 1 - .../usb-controller-qemu-xhci-unavailable.xml | 1 - .../usb-controller-qemu-xhci.args | 30 - ...b-controller-qemu-xhci.x86_64-latest.args} | 15 +- .../qemuxml2argvdata/usb-controller-xhci.args | 30 - tests/qemuxml2argvdata/usb-controller.args | 31 - .../usb-hub-autoadd-deluxe.args | 50 - .../usb-hub-autoadd-deluxe.x86_64-latest.args | 52 + tests/qemuxml2argvdata/usb-hub-autoadd.args | 36 - .../usb-hub-autoadd.x86_64-latest.args | 38 + ...err => usb-hub-conflict.x86_64-latest.err} | 0 ... => usb-hub-nonexistent.x86_64-latest.err} | 0 tests/qemuxml2argvdata/usb-hub.args | 32 - .../usb-hub.x86_64-latest.args | 34 + .../qemuxml2argvdata/usb-ich9-autoassign.args | 39 - .../qemuxml2argvdata/usb-ich9-companion.args | 34 - .../qemuxml2argvdata/usb-ich9-ehci-addr.args | 42 - .../qemuxml2argvdata/usb-long-port-path.args | 35 - .../usb-long-port-path.x86_64-latest.args | 37 + ...hub.err => usb-none-hub.x86_64-latest.err} | 0 ...r.err => usb-none-other.x86_64-latest.err} | 0 ...r => usb-none-usbtablet.x86_64-latest.err} | 0 tests/qemuxml2argvdata/usb-none.args | 30 - .../usb-none.x86_64-latest.args | 32 + .../qemuxml2argvdata/usb-port-autoassign.args | 36 - .../usb-port-autoassign.x86_64-latest.args | 38 + tests/qemuxml2argvdata/usb-port-missing.args | 34 - .../usb-port-missing.x86_64-latest.args | 36 + ... usb-ports-out-of-range.x86_64-latest.err} | 0 tests/qemuxml2argvdata/usb-ports.args | 36 - .../usb-ports.x86_64-latest.args | 38 + tests/qemuxml2argvdata/usb-redir-boot.args | 39 - .../usb-redir-boot.x86_64-latest.args | 41 + .../usb-redir-filter-version.args | 36 - ...sb-redir-filter-version.x86_64-latest.args | 38 + tests/qemuxml2argvdata/usb-redir-filter.args | 39 - .../usb-redir-filter.x86_64-latest.args | 41 + tests/qemuxml2argvdata/usb-redir.args | 39 - .../usb-redir.x86_64-latest.args | 41 + ...-long-port-path-invalid.x86_64-latest.err} | 0 .../qemuxml2argvdata/usb-xhci-autoassign.args | 35 - tests/qemuxml2argvdata/usb1-usb2.args | 43 - .../usb1-usb2.x86_64-latest.args | 45 + ...=> vhost_queues-invalid.x86_64-latest.err} | 0 .../virtio-input-passthrough.args | 32 - ...irtio-input-passthrough.x86_64-latest.args | 34 + tests/qemuxml2argvdata/virtio-input.args | 34 - .../virtio-input.x86_64-latest.args | 36 + ...lloon-freepage-reporting.x86_64-5.0.0.err} | 0 .../qemuxml2argvdata/virtio-rng-default.args | 33 - .../virtio-rng-default.x86_64-latest.args | 35 + ...=> virtio-rng-egd-crash.x86_64-latest.err} | 0 ...args => virtio-rng-egd.x86_64-latest.args} | 16 +- .../qemuxml2argvdata/virtio-rng-multiple.args | 36 - .../virtio-rng-multiple.x86_64-latest.args | 38 + tests/qemuxml2argvdata/virtio-rng-random.args | 33 - .../virtio-rng-random.x86_64-latest.args | 35 + tests/qemuxml2argvdata/vmcoreinfo.args | 35 - .../vmcoreinfo.x86_64-latest.args | 37 + tests/qemuxml2argvtest.c | 1189 ++++++----------- .../default-kvm-host-arch.x86_64-latest.xml | 2 +- .../default-qemu-host-arch.x86_64-latest.xml | 2 +- .../qemuxml2xmloutdata/q35.x86_64-latest.xml | 4 + ...ntroller-default-i440fx.x86_64-latest.xml} | 0 ...ault-unavailable-i440fx.x86_64-latest.xml} | 22 +- ...ntroller-ich9-ehci-addr.x86_64-latest.xml} | 0 ...troller-implicit-i440fx.x86_64-latest.xml} | 12 +- ...ntroller-implicit-isapc.x86_64-latest.xml} | 18 +- ...-controller-implicit-q35.x86_64-latest.xml | 43 + ...usb-controller-nec-xhci.x86_64-latest.xml} | 0 ...=> usb-controller-piix3.x86_64-latest.xml} | 0 tests/qemuxml2xmltest.c | 14 +- tests/testutilsqemu.c | 159 +-- tests/testutilsqemu.h | 6 +- 550 files changed, 6870 insertions(+), 7188 deletions(-) rename tests/qemuxml2argvdata/{440fx-ide-address-conflict.err => 440fx-ide-address-conflict.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{440fx-wrong-root.err => 440fx-wrong-root.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-default-both.args => aarch64-gic-default-both.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-default-v2.args => aarch64-gic-default-v2.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-default-v3.args => aarch64-gic-default-v3.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-host.args => aarch64-gic-host.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-both.args => aarch64-gic-none-both.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-tcg.args => aarch64-gic-none-tcg.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-v2.args => aarch64-gic-none-v2.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-none-v3.args => aarch64-gic-none-v3.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-v2.args => aarch64-gic-v2.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{aarch64-gic-v3.args => aarch64-gic-v3.aarch64-latest.args} (100%) rename tests/qemuxml2argvdata/{machine-core-off.args => acpi-table.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/autoindex.args create mode 100644 tests/qemuxml2argvdata/autoindex.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-auto.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-deflate-off.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-deflate.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device-period.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/balloon-device.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/blkiotune-device.args create mode 100644 tests/qemuxml2argvdata/blkiotune-device.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/blkiotune.args create mode 100644 tests/qemuxml2argvdata/blkiotune.x86_64-latest.args rename tests/qemuxml2argvdata/{channel-guestfwd.args => channel-guestfwd.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{channel-spicevmc.args => channel-spicevmc.x86_64-latest.args} (55%) delete mode 100644 tests/qemuxml2argvdata/channel-virtio-auto.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-auto.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/channel-virtio-autoadd.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-autoadd.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/channel-virtio-autoassign.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-autoassign.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/channel-virtio-default.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-default.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/channel-virtio-state.x86_64-latest.args rename tests/qemuxml2argvdata/{channel-virtio-unix.args => channel-virtio-unix.x86_64-latest.args} (50%) delete mode 100644 tests/qemuxml2argvdata/channel-virtio.args rename tests/qemuxml2argvdata/{channel-virtio-state.args => channel-virtio.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{chardev-reconnect-generated-path.err => chardev-reconnect-generated-path.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{chardev-reconnect-invalid-timeout.err => chardev-reconnect-invalid-timeout.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/chardev-reconnect.args create mode 100644 tests/qemuxml2argvdata/chardev-reconnect.x86_64-latest.args rename tests/qemuxml2argvdata/{clock-catchup.args => clock-catchup.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{clock-localtime.args => clock-france.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{clock-hpet-off.args => clock-hpet-off.x86_64-7.2.0.args} (60%) create mode 100644 tests/qemuxml2argvdata/clock-hpet-off.x86_64-latest.args rename tests/qemuxml2argvdata/{clock-localtime-basis-localtime.args => clock-localtime-basis-localtime.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{clock-france.args => clock-localtime.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{clock-timer-hyperv-rtc.args => clock-timer-hyperv-rtc.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{balloon-device-deflate-off.args => clock-utc.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{clock-variable.args => clock-variable.x86_64-latest.args} (61%) delete mode 100644 tests/qemuxml2argvdata/console-compat-auto.args delete mode 100644 tests/qemuxml2argvdata/console-compat-chardev.args delete mode 100644 tests/qemuxml2argvdata/console-compat.args rename tests/qemuxml2argvdata/{console-virtio-many.args => console-virtio-many.x86_64-latest.args} (52%) rename tests/qemuxml2argvdata/{console-virtio.args => console-virtio.x86_64-latest.args} (56%) delete mode 100644 tests/qemuxml2argvdata/controller-order.args create mode 100644 tests/qemuxml2argvdata/controller-order.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-Haswell-noTSX.args => cpu-Haswell-noTSX.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{cpu-Haswell.args => cpu-Haswell.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{cpu-Haswell2.args => cpu-Haswell2.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{cpu-Haswell3.args => cpu-Haswell3.x86_64-latest.args} (60%) create mode 100644 tests/qemuxml2argvdata/cpu-cache-disable.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-cache-disable2.xml create mode 100644 tests/qemuxml2argvdata/cpu-cache-disable3.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-cache-emulate-l2.err => cpu-cache-emulate-l2.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{cpu-cache-disable.args => cpu-cache-emulate-l3.x86_64-latest.args} (56%) rename tests/qemuxml2argvdata/{cpu-cache-passthrough-l3.err => cpu-cache-passthrough-l3.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-cache-passthrough.args rename tests/qemuxml2argvdata/{cpu-cache-disable2.args => cpu-cache-passthrough.x86_64-latest.args} (56%) delete mode 100644 tests/qemuxml2argvdata/cpu-cache-passthrough2.args delete mode 100644 tests/qemuxml2argvdata/cpu-cache-passthrough2.xml rename tests/qemuxml2argvdata/{cpu-cache-passthrough3.err => cpu-cache-passthrough3.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-check-default-none.args create mode 100644 tests/qemuxml2argvdata/cpu-check-default-none.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-check-default-none2.args => cpu-check-default-none2.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-check-default-partial.args create mode 100644 tests/qemuxml2argvdata/cpu-check-default-partial.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-check-default-partial2.args => cpu-check-default-partial2.x86_64-latest.args} (60%) delete mode 120000 tests/qemuxml2argvdata/cpu-check-full.args create mode 120000 tests/qemuxml2argvdata/cpu-check-full.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-check-none.args => cpu-check-none.x86_64-latest.args} (60%) delete mode 120000 tests/qemuxml2argvdata/cpu-check-partial.args create mode 120000 tests/qemuxml2argvdata/cpu-check-partial.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-exact1.args => cpu-exact1.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{cpu-exact2-nofallback.args => cpu-exact2-nofallback.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{cpu-exact2.args => cpu-exact2.x86_64-latest.args} (63%) delete mode 100644 tests/qemuxml2argvdata/cpu-fallback.args rename tests/qemuxml2argvdata/{usb-piix3-controller.args => cpu-fallback.x86_64-5.2.0.args} (73%) create mode 100644 tests/qemuxml2argvdata/cpu-fallback.x86_64-8.0.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-kvmclock.args create mode 100644 tests/qemuxml2argvdata/cpu-host-kvmclock.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-host-model-cmt.args => cpu-host-model-cmt.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{cpu-host-model-fallback.args => cpu-host-model-fallback.x86_64-4.2.0.args} (63%) rename tests/qemuxml2argvdata/{cpu-host-model-vendor.args => cpu-host-model-fallback.x86_64-5.0.0.args} (63%) create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-6.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-8.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-fallback.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.err create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-4.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-5.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-5.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-5.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-6.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-6.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-8.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-nofallback.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model-vendor.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-host-model.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-6.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-7.0.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-7.1.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-7.2.0.args create mode 100644 tests/qemuxml2argvdata/cpu-host-model.x86_64-8.0.0.args rename tests/qemuxml2argvdata/{machine-aliases2.args => cpu-host-passthrough-features.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-host-passthrough.args create mode 100644 tests/qemuxml2argvdata/cpu-host-passthrough.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-kvmclock.args => cpu-kvmclock.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-minimum1.args create mode 100644 tests/qemuxml2argvdata/cpu-minimum1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-minimum2.args create mode 100644 tests/qemuxml2argvdata/cpu-minimum2.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-no-removed-features.args => cpu-no-removed-features.x86_64-latest.args} (60%) delete mode 100644 tests/qemuxml2argvdata/cpu-nofallback.err create mode 100644 tests/qemuxml2argvdata/cpu-nofallback.x86_64-5.2.0.err create mode 100644 tests/qemuxml2argvdata/cpu-nofallback.x86_64-8.0.0.args delete mode 100644 tests/qemuxml2argvdata/cpu-numa-disjoint.args create mode 100644 tests/qemuxml2argvdata/cpu-numa-disjoint.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-numa-memshared.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-numa-no-memory-element.args rename tests/qemuxml2argvdata/{cpu-numa-memshared.args => cpu-numa-no-memory-element.x86_64-latest.args} (56%) delete mode 100644 tests/qemuxml2argvdata/cpu-numa1.args create mode 100644 tests/qemuxml2argvdata/cpu-numa1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-numa2.args create mode 100644 tests/qemuxml2argvdata/cpu-numa2.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-numa3.err => cpu-numa3.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate.args rename tests/qemuxml2argvdata/{cpu-cache-disable3.args => cpu-phys-bits-emulate.x86_64-latest.args} (57%) delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.args create mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-emulate2.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-phys-bits-passthrough.args rename tests/qemuxml2argvdata/{cpu-cache-emulate-l3.args => cpu-phys-bits-passthrough.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{cpu-phys-bits-passthrough2.err => cpu-phys-bits-passthrough2.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{cpu-qemu-host-passthrough.err => cpu-qemu-host-passthrough.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/cpu-strict1.args create mode 100644 tests/qemuxml2argvdata/cpu-strict1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-topology1.args rename tests/qemuxml2argvdata/{balloon-device.args => cpu-topology1.x86_64-latest.args} (55%) delete mode 100644 tests/qemuxml2argvdata/cpu-topology2.args create mode 100644 tests/qemuxml2argvdata/cpu-topology2.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/cpu-topology3.args create mode 100644 tests/qemuxml2argvdata/cpu-topology3.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/cpu-topology4.x86_64-latest.args rename tests/qemuxml2argvdata/{monitor-json.xml => cpu-topology4.xml} (51%) rename tests/qemuxml2argvdata/{cpu-tsc-frequency.args => cpu-tsc-frequency.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{default-kvm-host-arch.args => default-kvm-host-arch.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{default-qemu-host-arch.args => default-qemu-host-arch.x86_64-latest.args} (59%) delete mode 100644 tests/qemuxml2argvdata/graphics-egl-headless.args rename tests/qemuxml2argvdata/{graphics-sdl-fullscreen.args => graphics-sdl-fullscreen.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{graphics-sdl.args => graphics-sdl.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{hostdev-mdev-display-missing-graphics.err => hostdev-mdev-display-missing-graphics.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-mdev-duplicate.err => hostdev-mdev-duplicate.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-mdev-invalid-target-address.err => hostdev-mdev-invalid-target-address.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-mdev-precreated.args => hostdev-mdev-precreated.x86_64-latest.args} (55%) rename tests/qemuxml2argvdata/{hostdev-mdev-src-address-invalid.err => hostdev-mdev-src-address-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-address-unassigned.x86_64-latest.args rename tests/qemuxml2argvdata/{hostdev-pci-duplicate.err => hostdev-pci-duplicate.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.args create mode 100644 tests/qemuxml2argvdata/hostdev-pci-multifunction.x86_64-latest.args rename tests/qemuxml2argvdata/{hostdev-scsi-duplicate.err => hostdev-scsi-duplicate.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-rom.args => hostdev-scsi-vhost-scsi-pci.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{hostdev-usb-duplicate.err => hostdev-usb-duplicate.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hostdev-scsi-vhost-scsi-pci.args => hostdev-vfio-multidomain.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{hostdev-vfio-zpci-wrong-arch.err => hostdev-vfio-zpci-wrong-arch.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/hostdev-vfio.args rename tests/qemuxml2argvdata/{hostdev-vfio-multidomain.args => hostdev-vfio.x86_64-latest.args} (58%) rename tests/qemuxml2argvdata/{hotplug-base.args => hotplug-base.x86_64-latest.args} (55%) rename tests/qemuxml2argvdata/{hugepages-default-1G-nodeset-2M.err => hugepages-default-1G-nodeset-2M.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hugepages-memaccess-invalid.err => hugepages-memaccess-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{hugepages-memaccess3.err => hugepages-memaccess3.x86_64-5.1.0.err} (100%) delete mode 100644 tests/qemuxml2argvdata/input-usbmouse-addr.args create mode 100644 tests/qemuxml2argvdata/input-usbmouse-addr.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/input-usbmouse.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/input-usbtablet.args create mode 100644 tests/qemuxml2argvdata/input-usbtablet.x86_64-latest.args rename tests/qemuxml2argvdata/{kvm-pit-delay.args => kvm-pit-delay.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{kvm-pit-discard.args => kvm-pit-discard.x86_64-latest.args} (62%) rename tests/qemuxml2argvdata/{kvmclock.args => kvmclock.x86_64-latest.args} (64%) delete mode 100644 tests/qemuxml2argvdata/machine-aliases1.args create mode 100644 tests/qemuxml2argvdata/machine-aliases1.x86_64-latest.args rename tests/qemuxml2argvdata/{cpu-host-passthrough-features.args => machine-aliases2.x86_64-latest.args} (61%) create mode 100644 tests/qemuxml2argvdata/machine-core-off.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/machine-core-on.args rename tests/qemuxml2argvdata/{balloon-device-period.args => machine-core-on.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{machine-loadparm-s390-char-invalid.err => machine-loadparm-s390-char-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{machine-loadparm-s390-len-invalid.err => machine-loadparm-s390-len-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/machine-vmport-opt.args create mode 100644 tests/qemuxml2argvdata/machine-vmport-opt.x86_64-latest.args rename tests/qemuxml2argvdata/{memory-align-fail.err => memory-align-fail.x86_64-latest.err} (100%) create mode 100644 tests/qemuxml2argvdata/memory-hotplug-dimm.x86_64-latest.args rename tests/qemuxml2argvdata/{memory-hotplug-invalid-targetnode.err => memory-hotplug-invalid-targetnode.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{memory-hotplug-nonuma.err => memory-hotplug-nonuma.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/memory-hotplug.args rename tests/qemuxml2argvdata/{memory-hotplug-dimm.args => memory-hotplug.x86_64-latest.args} (58%) delete mode 100644 tests/qemuxml2argvdata/memtune-unlimited.args create mode 100644 tests/qemuxml2argvdata/memtune-unlimited.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/memtune.args create mode 100644 tests/qemuxml2argvdata/memtune.x86_64-latest.args rename tests/qemuxml2argvdata/{migrate-numa-unaligned.args => migrate-numa-unaligned.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{migrate.args => migrate.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{minimal-no-memory.err => minimal-no-memory.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/minimal.args create mode 100644 tests/qemuxml2argvdata/minimal.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/misc-acpi.args rename tests/qemuxml2argvdata/{balloon-device-deflate.args => misc-acpi.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{misc-disable-s3.args => misc-disable-s3.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{misc-disable-suspends.args => misc-disable-suspends.x86_64-latest.args} (65%) delete mode 100644 tests/qemuxml2argvdata/misc-enable-s4.err rename tests/qemuxml2argvdata/{misc-enable-s4.args => misc-enable-s4.x86_64-latest.args} (65%) delete mode 100644 tests/qemuxml2argvdata/misc-uuid.args rename tests/qemuxml2argvdata/{balloon-device-auto.args => misc-uuid.x86_64-latest.args} (64%) delete mode 100644 tests/qemuxml2argvdata/monitor-json.args delete mode 100644 tests/qemuxml2argvdata/multifunction-pci-device.args create mode 100644 tests/qemuxml2argvdata/multifunction-pci-device.x86_64-latest.args rename tests/qemuxml2argvdata/{nosharepages.args => nosharepages.x86_64-latest.args} (64%) delete mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-cpuset.args create mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-cpuset.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-no-cpuset-and-placement.args create mode 100644 tests/qemuxml2argvdata/numad-auto-memory-vcpu-no-cpuset-and-placement.x86_64-latest.args rename tests/qemuxml2argvdata/{numad-auto-vcpu-static-numatune-no-nodeset.err => numad-auto-vcpu-static-numatune-no-nodeset.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/numad-auto-vcpu-static-numatune.args create mode 100644 tests/qemuxml2argvdata/numad-auto-vcpu-static-numatune.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numad-static-memory-auto-vcpu.args create mode 100644 tests/qemuxml2argvdata/numad-static-memory-auto-vcpu.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numad.args create mode 100644 tests/qemuxml2argvdata/numad.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/numatune-auto-nodeset-invalid.args create mode 100644 tests/qemuxml2argvdata/numatune-auto-nodeset-invalid.x86_64-latest.args rename tests/qemuxml2argvdata/{numatune-auto-prefer.args => numatune-auto-prefer.x86_64-latest.args} (56%) rename tests/qemuxml2argvdata/{numatune-distances.args => numatune-distances.x86_64-latest.args} (60%) rename tests/qemuxml2argvdata/{numatune-memnode-invalid-mode.err => numatune-memnode-invalid-mode.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{numatune-memnode-no-memory.args => numatune-memnode-no-memory.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{numatune-memnode-nocpu.err => numatune-memnode-nocpu.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/numatune-memnode.args rename tests/qemuxml2argvdata/{numatune-memnodes-problematic.err => numatune-memnodes-problematic.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{numatune-memory-invalid-nodeset.err => numatune-memory-invalid-nodeset.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/numatune-memory.args delete mode 100644 tests/qemuxml2argvdata/numatune-memory.xml rename tests/qemuxml2argvdata/{numatune-static-nodeset-exceed-hostnode.err => numatune-static-nodeset-exceed-hostnode.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/parallel-parport-chardev.args delete mode 100644 tests/qemuxml2argvdata/parallel-tcp-chardev.args delete mode 100644 tests/qemuxml2argvdata/pci-autoadd-addr.args create mode 100644 tests/qemuxml2argvdata/pci-autoadd-addr.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/pci-autoadd-idx.args create mode 100644 tests/qemuxml2argvdata/pci-autoadd-idx.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-autofill-addr.args => pci-autofill-addr.x86_64-latest.args} (57%) rename tests/qemuxml2argvdata/{pci-bridge-duplicate-index.err => pci-bridge-duplicate-index.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-bridge-many-disks.args => pci-bridge-many-disks.x86_64-latest.args} (68%) rename tests/qemuxml2argvdata/{pci-bridge-negative-index-invalid.err => pci-bridge-negative-index-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pci-bridge.args create mode 100644 tests/qemuxml2argvdata/pci-bridge.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-bus-invalid.err => pci-bus-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-domain-invalid.err => pci-domain-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-expander-bus-bad-bus.err => pci-expander-bus-bad-bus.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-expander-bus-bad-machine.err => pci-expander-bus-bad-machine.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-expander-bus-bad-node.err => pci-expander-bus-bad-node.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pci-expander-bus.args create mode 100644 tests/qemuxml2argvdata/pci-expander-bus.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-function-invalid.err => pci-function-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-many.args => pci-many.x86_64-latest.args} (67%) delete mode 120000 tests/qemuxml2argvdata/pci-rom-disabled-invalid.args create mode 120000 tests/qemuxml2argvdata/pci-rom-disabled-invalid.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-rom-disabled.args => pci-rom-disabled.x86_64-latest.args} (58%) create mode 100644 tests/qemuxml2argvdata/pci-rom.x86_64-latest.args rename tests/qemuxml2argvdata/{pci-root-address.err => pci-root-address.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pci-root-nonzero-index.err => pci-root-nonzero-index.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pci-serial-dev-chardev.args rename tests/qemuxml2argvdata/{pci-slot-invalid.err => pci-slot-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pcie-expander-bus-bad-bus.err => pcie-expander-bus-bad-bus.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pcie-expander-bus-bad-machine.err => pcie-expander-bus-bad-machine.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/pcie-expander-bus.args create mode 100644 tests/qemuxml2argvdata/pcie-expander-bus.x86_64-latest.args rename tests/qemuxml2argvdata/{pcie-root-port-model-ioh3420.args => pcie-root-port-model-generic.x86_64-latest.args} (51%) rename tests/qemuxml2argvdata/{pcie-root-port-model-generic.args => pcie-root-port-model-ioh3420.x86_64-latest.args} (55%) rename tests/qemuxml2argvdata/{pcie-root-port-too-many.err => pcie-root-port-too-many.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pcie-root-port.args => pcie-root-port.x86_64-latest.args} (53%) rename tests/qemuxml2argvdata/{pcie-root.args => pcie-root.x86_64-latest.args} (55%) delete mode 100644 tests/qemuxml2argvdata/pcie-switch-downstream-port.args create mode 100644 tests/qemuxml2argvdata/pcie-switch-downstream-port.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/pcie-switch-upstream-port.args create mode 100644 tests/qemuxml2argvdata/pcie-switch-upstream-port.x86_64-latest.args rename tests/qemuxml2argvdata/{pcihole64-q35.args => pcihole64-q35.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{pcihole64.args => pcihole64.x86_64-latest.args} (59%) rename tests/qemuxml2argvdata/{pmu-feature-off.args => pmu-feature-off.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{pmu-feature.args => pmu-feature.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{pseries-features-invalid-machine.err => pseries-features-invalid-machine.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{pseries-serial-invalid-machine.err => pseries-serial-invalid-machine.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{q35-dmi-bad-address1.err => q35-dmi-bad-address1.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{q35-dmi-bad-address2.err => q35-dmi-bad-address2.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/q35-pci-force-address.args create mode 100644 tests/qemuxml2argvdata/q35-pci-force-address.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable-fallback.args delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable-fallback.xml delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable.args delete mode 100644 tests/qemuxml2argvdata/q35-pm-disable.xml delete mode 100644 tests/qemuxml2argvdata/q35-usb2-multi.args create mode 100644 tests/qemuxml2argvdata/q35-usb2-multi.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/q35-usb2-reorder.args create mode 100644 tests/qemuxml2argvdata/q35-usb2-reorder.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/q35-usb2.x86_64-latest.args rename tests/qemuxml2argvdata/{q35-wrong-root.err => q35-wrong-root.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/q35.args rename tests/qemuxml2argvdata/{q35-usb2.args => q35.x86_64-latest.args} (51%) rename tests/qemuxml2argvdata/{qemu-ns-no-env.args => qemu-ns-alt.x86_64-latest.args} (61%) delete mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns0.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns0.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns1.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline-ns1.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-commandline.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline-ns0.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline-ns0.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-commandline.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-ns0.args create mode 100644 tests/qemuxml2argvdata/qemu-ns-domain-ns0.x86_64-latest.args rename tests/qemuxml2argvdata/{qemu-ns-alt.args => qemu-ns-no-env.x86_64-latest.args} (65%) rename tests/qemuxml2argvdata/{reboot-timeout-disabled.args => reboot-timeout-disabled.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{reboot-timeout-enabled.args => reboot-timeout-enabled.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{restore-v2-fd.args => restore-v2-fd.x86_64-latest.args} (61%) rename tests/qemuxml2argvdata/{restore-v2.args => restore-v2.x86_64-latest.args} (65%) delete mode 100644 tests/qemuxml2argvdata/seclabel-dac-none.args create mode 100644 tests/qemuxml2argvdata/seclabel-dac-none.x86_64-latest.args rename tests/qemuxml2argvdata/{seclabel-device-duplicates.err => seclabel-device-duplicates.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{seclabel-device-relabel-invalid.err => seclabel-device-relabel-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-baselabel.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-baselabel.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-labelskip.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-labelskip.x86_64-latest.args rename tests/qemuxml2argvdata/{seclabel-dynamic-override.args => seclabel-dynamic-override.x86_64-latest.args} (63%) delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-relabel.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic-relabel.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-dynamic.args create mode 100644 tests/qemuxml2argvdata/seclabel-dynamic.x86_64-latest.args rename tests/qemuxml2argvdata/{seclabel-multiple.err => seclabel-multiple.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/seclabel-none.args create mode 100644 tests/qemuxml2argvdata/seclabel-none.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-static-labelskip.args create mode 100644 tests/qemuxml2argvdata/seclabel-static-labelskip.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-static-relabel.args create mode 100644 tests/qemuxml2argvdata/seclabel-static-relabel.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/seclabel-static.args create mode 100644 tests/qemuxml2argvdata/seclabel-static.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/serial-dev-chardev-iobase.args delete mode 100644 tests/qemuxml2argvdata/serial-dev-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-file-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-file-log.args delete mode 100644 tests/qemuxml2argvdata/serial-many-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-pty-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-spiceport.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-telnet-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev-verify.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-tcp-tlsx509-secret-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-udp-chardev.args delete mode 100644 tests/qemuxml2argvdata/serial-vc-chardev.args create mode 100644 tests/qemuxml2argvdata/smartcard-controller.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates-database.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates.args create mode 100644 tests/qemuxml2argvdata/smartcard-host-certificates.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/smartcard-host.args create mode 100644 tests/qemuxml2argvdata/smartcard-host.x86_64-latest.args rename tests/qemuxml2argvdata/{smartcard-passthrough-spicevmc.args => smartcard-passthrough-spicevmc.x86_64-latest.args} (52%) rename tests/qemuxml2argvdata/{smartcard-passthrough-tcp.args => smartcard-passthrough-tcp.x86_64-latest.args} (54%) rename tests/qemuxml2argvdata/{smbios-date.err => smbios-date.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{smbios-uuid-match.err => smbios-uuid-match.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{smbios.args => smbios.x86_64-latest.args} (70%) delete mode 100644 tests/qemuxml2argvdata/smp-dies.args delete mode 100644 tests/qemuxml2argvdata/smp.args rename tests/qemuxml2argvdata/{tpm-no-backend-invalid.err => tpm-no-backend-invalid.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-bus-missing.err => usb-bus-missing.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{clock-utc.args => usb-controller-default-i440fx.x86_64-latest.args} (59%) rename tests/qemuxml2argvdata/{usb-controller.xml => usb-controller-default-i440fx.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-default-isapc.x86_64-latest.err create mode 100644 tests/qemuxml2argvdata/usb-controller-default-isapc.xml rename tests/qemuxml2argvdata/{usb-controller-default-q35.args => usb-controller-default-q35.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{smartcard-controller.args => usb-controller-default-unavailable-i440fx.x86_64-latest.args} (63%) create mode 120000 tests/qemuxml2argvdata/usb-controller-default-unavailable-i440fx.xml rename tests/qemuxml2argvdata/{usb-controller-default-unavailable-q35.err => usb-controller-default-unavailable-q35.x86_64-latest.err} (100%) delete mode 120000 tests/qemuxml2argvdata/usb-controller-explicit-unavailable-q35.xml create mode 100644 tests/qemuxml2argvdata/usb-controller-ich9-autoassign.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ich9-autoassign.xml => usb-controller-ich9-autoassign.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-ich9-companion.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ich9-companion.xml => usb-controller-ich9-companion.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-ich9-ehci-addr.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ich9-ehci-addr.xml => usb-controller-ich9-ehci-addr.xml} (100%) rename tests/qemuxml2argvdata/{usb-ich9-no-companion.err => usb-controller-ich9-no-companion.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-ich9-no-companion.xml => usb-controller-ich9-no-companion.xml} (100%) rename tests/qemuxml2argvdata/{smartcard-host-certificates-database.args => usb-controller-implicit-i440fx.x86_64-latest.args} (63%) rename tests/qemuxml2argvdata/{usb-controller-xhci.xml => usb-controller-implicit-i440fx.xml} (86%) rename tests/qemuxml2argvdata/{acpi-table.args => usb-controller-implicit-isapc.x86_64-latest.args} (67%) create mode 100644 tests/qemuxml2argvdata/usb-controller-implicit-isapc.xml create mode 100644 tests/qemuxml2argvdata/usb-controller-implicit-q35.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/usb-controller-implicit-q35.xml rename tests/qemuxml2argvdata/{usb-controller-xhci-limit.err => usb-controller-nec-xhci-limit.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-controller-xhci-limit.xml => usb-controller-nec-xhci-limit.xml} (100%) rename tests/qemuxml2argvdata/{usb-controller-explicit-unavailable-q35.err => usb-controller-nec-xhci-unavailable.x86_64-latest.err} (100%) create mode 120000 tests/qemuxml2argvdata/usb-controller-nec-xhci-unavailable.xml rename tests/qemuxml2argvdata/{usb-controller-explicit-q35.args => usb-controller-nec-xhci.x86_64-latest.args} (64%) rename tests/qemuxml2argvdata/{usb-controller-explicit-q35.xml => usb-controller-nec-xhci.xml} (100%) create mode 100644 tests/qemuxml2argvdata/usb-controller-nex-xhci-autoassign.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-xhci-autoassign.xml => usb-controller-nex-xhci-autoassign.xml} (100%) rename tests/qemuxml2argvdata/{input-usbmouse.args => usb-controller-piix3.x86_64-latest.args} (59%) rename tests/qemuxml2argvdata/{usb-piix3-controller.xml => usb-controller-piix3.xml} (100%) rename tests/qemuxml2argvdata/{usb-controller-qemu-xhci-limit.err => usb-controller-qemu-xhci-limit.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-controller-qemu-xhci-unavailable.err delete mode 120000 tests/qemuxml2argvdata/usb-controller-qemu-xhci-unavailable.xml delete mode 100644 tests/qemuxml2argvdata/usb-controller-qemu-xhci.args rename tests/qemuxml2argvdata/{serial-unix-chardev.args => usb-controller-qemu-xhci.x86_64-latest.args} (63%) delete mode 100644 tests/qemuxml2argvdata/usb-controller-xhci.args delete mode 100644 tests/qemuxml2argvdata/usb-controller.args delete mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.args create mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd-deluxe.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd.args create mode 100644 tests/qemuxml2argvdata/usb-hub-autoadd.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-hub-conflict.err => usb-hub-conflict.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-hub-nonexistent.err => usb-hub-nonexistent.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-hub.args create mode 100644 tests/qemuxml2argvdata/usb-hub.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-ich9-autoassign.args delete mode 100644 tests/qemuxml2argvdata/usb-ich9-companion.args delete mode 100644 tests/qemuxml2argvdata/usb-ich9-ehci-addr.args delete mode 100644 tests/qemuxml2argvdata/usb-long-port-path.args create mode 100644 tests/qemuxml2argvdata/usb-long-port-path.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-none-hub.err => usb-none-hub.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-none-other.err => usb-none-other.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{usb-none-usbtablet.err => usb-none-usbtablet.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-none.args create mode 100644 tests/qemuxml2argvdata/usb-none.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-port-autoassign.args create mode 100644 tests/qemuxml2argvdata/usb-port-autoassign.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-port-missing.args create mode 100644 tests/qemuxml2argvdata/usb-port-missing.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-ports-out-of-range.err => usb-ports-out-of-range.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-ports.args create mode 100644 tests/qemuxml2argvdata/usb-ports.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir-boot.args create mode 100644 tests/qemuxml2argvdata/usb-redir-boot.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir-filter-version.args create mode 100644 tests/qemuxml2argvdata/usb-redir-filter-version.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir-filter.args create mode 100644 tests/qemuxml2argvdata/usb-redir-filter.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/usb-redir.args create mode 100644 tests/qemuxml2argvdata/usb-redir.x86_64-latest.args rename tests/qemuxml2argvdata/{usb-too-long-port-path-invalid.err => usb-too-long-port-path-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/usb-xhci-autoassign.args delete mode 100644 tests/qemuxml2argvdata/usb1-usb2.args create mode 100644 tests/qemuxml2argvdata/usb1-usb2.x86_64-latest.args rename tests/qemuxml2argvdata/{vhost_queues-invalid.err => vhost_queues-invalid.x86_64-latest.err} (100%) delete mode 100644 tests/qemuxml2argvdata/virtio-input-passthrough.args create mode 100644 tests/qemuxml2argvdata/virtio-input-passthrough.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/virtio-input.args create mode 100644 tests/qemuxml2argvdata/virtio-input.x86_64-latest.args rename tests/qemuxml2argvdata/{virtio-options-memballoon-freepage-reporting.err => virtio-options-memballoon-freepage-reporting.x86_64-5.0.0.err} (100%) delete mode 100644 tests/qemuxml2argvdata/virtio-rng-default.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-default.x86_64-latest.args rename tests/qemuxml2argvdata/{virtio-rng-egd-crash.err => virtio-rng-egd-crash.x86_64-latest.err} (100%) rename tests/qemuxml2argvdata/{virtio-rng-egd.args => virtio-rng-egd.x86_64-latest.args} (54%) delete mode 100644 tests/qemuxml2argvdata/virtio-rng-multiple.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-multiple.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/virtio-rng-random.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-random.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/vmcoreinfo.args create mode 100644 tests/qemuxml2argvdata/vmcoreinfo.x86_64-latest.args rename tests/qemuxml2xmloutdata/{usb-controller.x86_64-latest.xml => usb-controller-default-i440fx.x86_64-latest.xml} (100%) rename tests/{qemuxml2argvdata/smp.xml => qemuxml2xmloutdata/usb-controller-default-unavailable-i440fx.x86_64-latest.xml} (57%) rename tests/qemuxml2xmloutdata/{usb-ich9-ehci-addr.x86_64-latest.xml => usb-controller-ich9-ehci-addr.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{smp.x86_64-latest.xml => usb-controller-implicit-i440fx.x86_64-latest.xml} (65%) rename tests/{qemuxml2argvdata/smp-dies.xml => qemuxml2xmloutdata/usb-controller-implicit-isapc.x86_64-latest.xml} (50%) create mode 100644 tests/qemuxml2xmloutdata/usb-controller-implicit-q35.x86_64-latest.xml rename tests/qemuxml2xmloutdata/{usb-controller-explicit-q35.x86_64-latest.xml => usb-controller-nec-xhci.x86_64-latest.xml} (100%) rename tests/qemuxml2xmloutdata/{usb-piix3-controller.x86_64-latest.xml => usb-controller-piix3.x86_64-latest.xml} (100%) -- 2.41.0

3 58