- Devel - libvirt List Archives

[libvirt] [PATCH] Fix memory leak in virSCSIDeviceListDel()
by Nehal J Wani 26 Feb '14

26 Feb '14

While running virscsitest, it was found that valgrind pointed out the following memory leak: ==320== 5 bytes in 1 blocks are definitely lost in loss record 4 of 37 ==320== at 0x4A069EE: malloc (vg_replace_malloc.c:270) ==320== by 0x3E6CE81171: strdup (strdup.c:43) ==320== by 0x4CB28DF: virStrdup (virstring.c:554) ==320== by 0x4CAC987: virSCSIDeviceSetUsedBy (virscsi.c:289) ==320== by 0x402321: test2 (virscsitest.c:100) ==320== by 0x403231: virtTestRun (testutils.c:199) ==320== by 0x402121: mymain (virscsitest.c:180) ==320== by 0x4039AD: virtTestMain (testutils.c:782) ==320== by 0x3E6CE1ED1C: (below main) (libc-start.c:226) ==320== --- src/util/virscsi.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/util/virscsi.c b/src/util/virscsi.c index acc3815..2f469f2 100644 --- a/src/util/virscsi.c +++ b/src/util/virscsi.c @@ -435,6 +435,7 @@ virSCSIDeviceListDel(virSCSIDeviceListPtr list, for (i = 0; i < dev->n_used_by; i++) { if (STREQ_NULLABLE(dev->used_by[i], name)) { if (dev->n_used_by > 1) { + VIR_FREE(dev->used_by[i]); VIR_DELETE_ELEMENT(dev->used_by, i, dev->n_used_by); } else { tmp = virSCSIDeviceListSteal(list, dev); -- 1.7.1

2 1

[libvirt] [question] doubt about cpu model 'qemu64'
by Wangyufei (James) 26 Feb '14

26 Feb '14

Hello, Recently I noticed that if I gave no model to qemu, then I would get 'qemu64' as default cpu model. Model 'qemu64' defined in qemu and defined in libvirt both support feature 'svm'. And if I start a VM with 'qemu64' as the qemu default model, I can get no 'svm' feature in the GuestOS: fpu de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht pni cx16 popcnt hypervisor syscall nx lm lahf_lm My host cpu is intel E5620, and it doesn't support 'svm' feature: 'fpu', 'vme', 'de', 'pse', 'tsc', 'msr', 'pae', 'mce', 'cx8', 'apic', 'sep', 'mtrr', 'pge', 'mca', 'cmov', 'pat', 'pse36', 'clflush', 'ds', 'acpi', 'mmx', 'fxsr', 'sse', 'sse2', 'ss', 'ht', 'tm', 'pbe', 'pni', 'pclmulqdq', 'dtes64', 'monitor', 'ds_cpl', 'vmx', 'smx', 'est', 'tm2', 'ssse3', 'cx16', 'xtpr', 'pdcm', 'pcid', 'dca', 'sse4.1', 'sse4.2', 'popcnt', 'aes', 'syscall', 'nx', 'pdpe1gb', 'rdtscp', 'lm', 'lahf_lm', 'dts', 'arat', 'constant_tsc' I can get the same result with libvirt API compareCPU on the host: model:qemu64; ret:0 model:Conroe; ret:2 model:Penryn; ret:2 model:Nehalem; ret:2 model:Westmere; ret:2 model:SandyBridge; ret:0 model:Haswell; ret:0 Isn't it strange that the host cpu doesn't support 'qemu64' model, but we can still start a VM with 'qemu64' as the default model on it? Best Regards, -WangYufei

1 0

[libvirt] Entering freeze for libvirt-1.2.2
by Daniel Veillard 26 Feb '14

26 Feb '14

As planned I tagged a release candidate 1 version in git and made tarballs and rpms available at the usual place: ftp://libvirt.org/libvirt/ it seems to work well in my limited testing, but let's spend some time this week making more tests and checking it compiles on other systems and architectures. if all goes well I will probably push the release next week-end, with an rc2 on Wednesday based on feedback, thanks ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 4

[libvirt] [PATCH 0/2] fix mingw build
by Eric Blake 26 Feb '14

26 Feb '14

I hit some issues while running ./autobuild.sh on a machine set up for a mingw cross build; pushing this series under the build-breaker rule. Eric Blake (2): build: fix cgroups on non-Linux build: avoid ld_preload tests on mingw src/util/vircgroup.c | 27 +++++++++++++++++++++++++- tests/Makefile.am | 7 ++++--- tests/virportallocatortest.c | 45 +++++++++++++++++++++++++++----------------- 3 files changed, 58 insertions(+), 21 deletions(-) -- 1.8.5.3

1 2

[libvirt] [PATCH] virNetDevVethCreate: Serialize callers
by Michal Privoznik 25 Feb '14

25 Feb '14

Consider dozen of LXC domains, each of them having this type of interface: <interface type='network'> <mac address='52:54:00:a7:05:4b'/> <source network='default'/> </interface> When starting these domain in parallel, all workers may meet in virNetDevVethCreate() where a race starts. Race over allocating veth pairs because allocation requires two steps: 1) find first nonexistent '/sys/class/net/vnet%d/' 2) run 'ip link add ...' command Now consider two threads. Both of them find N as the first unused veth index but only one of them succeeds allocating it. The other one fails. For such cases, we are running the allocation in a loop with 10 rounds. However this is very flaky synchronization. It should be rather used when libvirt is competing with other process than when libvirt threads fight each other. Therefore, internally we should use mutex to serialize callers, and do the allocation in loop (just in case we are competing with a different process). By the way we have something similar already since 1cf97c87. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virnetdevveth.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/src/util/virnetdevveth.c b/src/util/virnetdevveth.c index 25eb282..e698ce2 100644 --- a/src/util/virnetdevveth.c +++ b/src/util/virnetdevveth.c @@ -39,6 +39,19 @@ /* Functions */ +virMutex virNetDevVethCreateMutex; + +static int virNetDevVethCreateMutexOnceInit(void) +{ + if (virMutexInit(&virNetDevVethCreateMutex) < 0) { + virReportSystemError(errno, "%s", _("unable to init mutex")); + return -1; + } + return 0; +} + +VIR_ONCE_GLOBAL_INIT(virNetDevVethCreateMutex); + static int virNetDevVethExists(int devNum) { int ret; @@ -117,6 +130,10 @@ int virNetDevVethCreate(char** veth1, char** veth2) * We might race with other containers, but this is reasonably * unlikely, so don't do too many retries for device creation */ + if (virNetDevVethCreateMutexInitialize() < 0) + return -1; + + virMutexLock(&virNetDevVethCreateMutex); #define MAX_VETH_RETRIES 10 for (i = 0; i < MAX_VETH_RETRIES; i++) { @@ -179,6 +196,7 @@ int virNetDevVethCreate(char** veth1, char** veth2) MAX_VETH_RETRIES); cleanup: + virMutexUnlock(&virNetDevVethCreateMutex); virCommandFree(cmd); VIR_FREE(veth1auto); VIR_FREE(veth2auto); -- 1.9.0

2 1

[libvirt] Question about building libvirt.so
by vikhyath reddy 25 Feb '14

25 Feb '14

Hi, Thanks for libvirt. It is a life saver. I am in the process of writing some custom wrappers for libvirt so that it can be easily accessed from nodejs using the nodejs-ffi interfacing (basically describes a way to convert nodejs to c calls). I did write the wrapper on the lines of the examples provided. But I am unable to see my new functions in the libvirt.so file (which nodejs interfacing needs). Which means that my wrappers under <libvirt>/wrappers/ are not getting into libvirt.so like the ones at <libvirt>/examples Can you please guide me as to where I am going wrong? I was able to do a successful configure + make and I thought this will regenerate the new libvirt.so (which it does, but I cant see my new wrapper methods in it). Much appreciated, Thanks, vik.

5 7

[libvirt] libvirt iSCSI target discovery
by Sijo Jose 25 Feb '14

25 Feb '14

Hi, Is it possible to discover iSCSI targets using libvirt API..? OR is it possible to get the similar results of below commands using libvirtAPI..? iscsiadm --mode discovery --type sendtargets --portal server1.example.com sudo iscsiadm -m discovery -t st -p 192.168.0.10 Regards Sijo

2 1

[libvirt] [PATCH V2] libxl: queue domain event earlier in shutdown handler
by Jim Fehlig 25 Feb '14

25 Feb '14

The shutdown handler may restart a domain when handling a reboot event or when <on_*> is set to 'restart'. Restarting consists of calling libxlVmCleanup followed by libxlVmStart. libxlVmStart will emit a VIR_DOMAIN_EVENT_STARTED event, but the SHUTDOWN event is not emitted until exiting the shutdown handler, after the STARTED event. This patch changes the logic a bit to queue the event at the start of the shutdown action, ensuring it is queued before any subsequent events that may be generated while executing the shutdown action. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- V2: Enqueue any pending events at the beginning of the shutdown action labels, as suggested by Michal Privoznik https://www.redhat.com/archives/libvir-list/2014-February/msg01446.html src/libxl/libxl_driver.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index f7379b5..a79efcb 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -473,6 +473,10 @@ libxlDomainShutdownThread(void *opaque) } destroy: + if (dom_event) { + libxlDomainEventQueue(driver, dom_event); + dom_event = NULL; + } libxl_domain_destroy(ctx, vm->def->id, NULL); if (libxlVmCleanupJob(driver, vm, reason)) { if (!vm->persistent) { @@ -483,6 +487,10 @@ destroy: goto cleanup; restart: + if (dom_event) { + libxlDomainEventQueue(driver, dom_event); + dom_event = NULL; + } libxl_domain_destroy(ctx, vm->def->id, NULL); libxlVmCleanupJob(driver, vm, VIR_DOMAIN_SHUTOFF_SHUTDOWN); libxlVmStart(driver, vm, 0, -1); -- 1.8.1.4

2 2

[libvirt] [PATCH libvirt-java] spec: Depend on java-headless for Fedora 21+
by Cole Robinson 25 Feb '14

25 Feb '14

Details: https://bugzilla.redhat.com/show_bug.cgi?id=1068369 --- libvirt-java.spec.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libvirt-java.spec.in b/libvirt-java.spec.in index 137af83..d07b998 100644 --- a/libvirt-java.spec.in +++ b/libvirt-java.spec.in @@ -12,7 +12,11 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root Requires: jna Requires: libvirt-client >= @libvirt.required@ +%if 0%{?fedora} >= 21 +Requires: java-headless >= @java.required@ +%else Requires: java >= @java.required@ +%endif Requires: jpackage-utils BuildRequires: ant BuildRequires: jna -- 1.8.5.3

2 2

[libvirt] Compiling libvirt RPC client library for QNX
by Panday Ritesh Sharma (rpanday) 25 Feb '14

25 Feb '14

HI Team, I have downloaded the libvirt source code from libvirt_0.9.8.orig.tar.gz<https://launchpad.net/ubuntu/+archive/primary/+files/libvirt_0.9.8.orig.tar…> . I just wanted libvirt RPC client library to be compiled for QNX. My remote box which is running QNX would like to establish libvirt connection with linux box to launch virtual domains/VMs and would also like to get lifecycle events. Could you please let me know what all directory/files I need to compile which I have got from libvirt_0.9.8.orig.tar.gz<https://launchpad.net/ubuntu/+archive/primary/+files/libvirt_0.9.8.orig.tar…> ? While browsing through net I found the files available under src/util, src/conf, src/rpc, src/remote, are sufficient for client RPC library? Is this correct or I need to include any other files ? Is there any instruction or help available which I can use to compile this library for QNX ? Regards Ritesh Sharma

4 14

[libvirt] [PATCH 0/3] Couple of libvirt-guests fixes
by Michal Privoznik 25 Feb '14

25 Feb '14

*** BLURB HERE *** Michal Privoznik (3): virSystemdCreateMachine: Set dependencies for slices libvirt-guests: Wait for libirtd to initialize virNetServerRun: Notify systemd that we're accepting clients configure.ac | 2 ++ daemon/libvirtd.service.in | 1 + m4/virt-systemd-daemon.m4 | 34 ++++++++++++++++++++++++++++++++++ src/Makefile.am | 4 ++-- src/libvirt_private.syms | 1 + src/rpc/virnetserver.c | 7 +++++++ src/util/virsystemd.c | 18 ++++++++++++++++-- src/util/virsystemd.h | 2 ++ tools/libvirt-guests.sh.in | 19 +++++++++++++------ 9 files changed, 78 insertions(+), 10 deletions(-) create mode 100644 m4/virt-systemd-daemon.m4 -- 1.9.0

5 15

[libvirt] [PATCH 0/7] network: include plugged interface XML in "plugged" network hook
by Laine Stump 25 Feb '14

25 Feb '14

Although the immediate reason for all these patches is $subject, it really is something that should have been done a long time ago (I just hadn't convinced myself it was the right thing to do). These patches will allow a management application to easily learn exactly what physical hardware is being used by a domain's interface, which wasn't previously possible (e.g., it will be simple to learn which SRIOV VF is being used by a domain interface that is configured as <interface type='network'> where the network is a pool of VFs). Laine Stump (7): conf: clarify what is returned for actual bandwidth and vlan conf: handle null pointer in virNetDevVlanFormat conf: make virDomainNetDefFormat a public function conf: re-situate <bandwidth> element in <interface> conf: new function virDomainActualNetDefContentsFormat conf: output actual netdev status in <interface> XML network: include plugged interface XML in "plugged" network hook src/conf/domain_conf.c | 303 +++++++++++++-------- src/conf/domain_conf.h | 4 + src/conf/netdev_vlan_conf.c | 4 +- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 48 ++-- ...qemuhotplug-console-compat-2+console-virtio.xml | 4 +- .../qemuxml2argv-console-compat-2.xml | 4 +- .../qemuxml2argv-net-bandwidth.xml | 2 +- 8 files changed, 233 insertions(+), 137 deletions(-) -- 1.8.5.3

4 20

[libvirt] [PATCH 0/3] Multiple fixes related to lookup of gluster volumes
by Peter Krempa 25 Feb '14

25 Feb '14

Peter Krempa (3): storage: Don't lie about path used to look up in error message util: file: Don't sanitize URI protocol separator in virFileSanitizePath gluster: Fix "key" attribute for gluster volumes src/storage/storage_backend_gluster.c | 10 ++++++++-- src/storage/storage_driver.c | 12 +++++++++--- src/util/virfile.c | 12 ++++++++++++ 3 files changed, 29 insertions(+), 5 deletions(-) -- 1.8.5.5

3 11

[libvirt] [PATCH 0/3] Various RBD storage pool changes
by Wido den Hollander 25 Feb '14

25 Feb '14

This series of patches changes a couple of things in the RBD storage pool driver. The first change is that it includes the return status of librados and librbd in log and debug messages making it easier for users to track down the real cause of the problem. The second patch simplifies some code. The third patch leverages the new timeout options from librados. Should the backing Ceph cluster not respond for any reason librados will timeout. This prevents libvirt from handing on a rados_* or rbd_* call and locking up libvirt. If the librados version on the system does not support these timeout options nothing happens. libvirt compiles and runs just fine, but the timeout simply won't work. Wido den Hollander (3): rbd: Include return statusses from librados/librbd in logging rbd: Simplify opening RADOS IoCTX rbd: Set timeout options for librados src/storage/storage_backend_rbd.c | 137 ++++++++++++++++++++++--------------- 1 file changed, 80 insertions(+), 57 deletions(-) -- 1.7.9.5

2 8

[libvirt] [PATCH] virsh: initialize str to NULL for solving a build issue
by Chen Hanxiao 25 Feb '14

25 Feb '14

Fix a -Werror=maybe-uninitialized issue. Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com> --- tools/virsh-domain-monitor.c | 2 +- tools/virsh-domain.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index c67b833..1192565 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -218,7 +218,7 @@ VIR_ENUM_IMPL(vshDomainPMSuspendedReason, static const char * vshDomainStateReasonToString(int state, int reason) { - const char *str; + const char *str = NULL; switch ((virDomainState) state) { case VIR_DOMAIN_NOSTATE: str = vshDomainNostateReasonTypeToString(reason); diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 8e42300..3e73340 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10399,7 +10399,7 @@ VIR_ENUM_IMPL(vshDomainEventCrashed, static const char * vshDomainEventDetailToString(int event, int detail) { - const char *str; + const char *str = NULL; switch ((virDomainEventType) event) { case VIR_DOMAIN_EVENT_DEFINED: str = vshDomainEventDefinedTypeToString(detail); -- 1.8.5.3

2 1

[libvirt] [PATCH] virsh: mark CPU usage field names as translatable
by Ján Tomko 25 Feb '14

25 Feb '14

My commit ac75801 removed the translation markers when moving the field names into an array. --- tools/virsh-host.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 502203b..6a04f9d 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -352,12 +352,12 @@ VIR_ENUM_IMPL(vshCPUStats, VSH_CPU_LAST, VIR_NODE_CPU_STATS_UTILIZATION); const char *vshCPUOutput[] = { - "user:", - "system:", - "idle:", - "iowait:", - "intr:", - "usage:" + N_("user:"), + N_("system:"), + N_("idle:"), + N_("iowait:"), + N_("intr:"), + N_("usage:") }; static bool -- 1.8.3.2

2 2

[libvirt] [PATCH v1 0/2] support dumping guest memory in compressed format
by Qiao Nuohan 25 Feb '14

25 Feb '14

dumping guest's memroy is introduced without compression supported, and this is a freature regression of 'virsh dump --memory-only'. This patchset is used to add support in libvirt side to make qemu dump guest's memory in kdump-compressed format and please refer the following address to see implementation of the qemu side, the lastest version of qemu side is v9(ready for being queued). http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg03016.html qiaonuohan (2): make qemu dump memory in kdump-compressed format add dump_memory_format in qemu.conf include/libvirt/libvirt.h.in | 19 ++++++++++---- src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 13 +++++++++- src/qemu/qemu_conf.c | 3 +++ src/qemu/qemu_conf.h | 2 ++ src/qemu/qemu_driver.c | 51 +++++++++++++++++++++++++++++++++++--- src/qemu/qemu_monitor.c | 6 ++--- src/qemu/qemu_monitor.h | 3 ++- src/qemu/qemu_monitor_json.c | 4 ++- src/qemu/qemu_monitor_json.h | 3 ++- src/qemu/test_libvirtd_qemu.aug.in | 1 + tests/qemumonitorjsontest.c | 2 +- tools/virsh-domain.c | 42 +++++++++++++++++++++++++++++++ 13 files changed, 133 insertions(+), 17 deletions(-)

2 5

[libvirt] QEMU accepted for Google Summer of Code 2014
by Stefan Hajnoczi 24 Feb '14

24 Feb '14

Great news: the organizations for Google Summer of Code 2014 have been announced and QEMU is participating again this year! If you are a student who is interested in a 12-week full-time project working on QEMU, KVM, or libvirt this summer, head over to our project ideas page: http://qemu-project.org/Google_Summer_of_Code_2014 Student applications are open from March 10th to March 21st. See the Google Summer of Code timeline for details: https://www.google-melange.com/gsoc/events/google/gsoc2014 Also be sure to read the FAQs on the Summer of Code website to find out about eligibility, time requirements, and how the process works: https://www.google-melange.com/gsoc/document/show/gsoc_program/google/gsoc2… Thanks to our mentors for posting their project ideas on time, thus helping us produce a good organization application. I will send a private email to mentors to kickstart the process for GSoC 2014. Stefan

1 0

[libvirt] [PATCH 0/2] virsh cleanups
by Eric Blake 24 Feb '14

24 Feb '14

Followups written based on review to my 'virsh event' addition. Eric Blake (2): virsh: use more compact VIR_ENUM_IMPL virsh: kill over-engineered asprintf failure recovery tools/virsh-domain-monitor.c | 280 +++++++++++++++------------------- tools/virsh-domain.c | 347 ++++++++++++++++++------------------------- tools/virsh-network.c | 36 ++--- tools/virsh-pool.c | 139 ++++++----------- tools/virsh-volume.c | 104 ++++--------- 5 files changed, 358 insertions(+), 548 deletions(-) -- 1.8.5.3

2 7

[libvirt] [PATCH 0/4] libxl: improve domain lifecycle event support
by Jim Fehlig 24 Feb '14

24 Feb '14

This series is the result of a report from Kim Larry [1] about missing shutdown events in the libxl driver. Kim's report revealed that the libxl driver was ignoring the <on_*> domain lifecycle event configuration! Patch1 adds support for the four standard actions (destroy, restart, preserve, and rename-restart) of <on_*>. Patch2 queues the shutdown event earlier in the shutdown handler, to avoid it being delivered after the a start event in the case of a restart. Patches 3 and 4 add support for the extra <on_crash> actions coredump-destroy and coredump-restart. [1] https://www.redhat.com/archives/libvir-list/2014-February/msg01121.html Jim Fehlig (4): libxl: honor domain lifecycle event configuration libxl: queue domain event earlier in shutdown handler libxl: add dump dir to libxlDriverConfig object libxl: handle on_crash coredump actions src/libxl/libxl_conf.c | 3 + src/libxl/libxl_conf.h | 2 + src/libxl/libxl_driver.c | 148 ++++++++++++++++++++++++++++++++++++++--------- 3 files changed, 125 insertions(+), 28 deletions(-) -- 1.8.1.4

3 14

[libvirt] [PATCH] Document the keyboard as a valid input type
by Ján Tomko 24 Feb '14

24 Feb '14

Commit bc18373 added a new input type, but didn't change the documentation. --- docs/formatdomain.html.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index ea1a97b..400de07 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3847,15 +3847,16 @@ qemu-kvm -net nic,model=? /dev/null ... <devices> <input type='mouse' bus='usb'/> + <input type='keyboard' bus='usb'/> </devices> ...</pre> <dl> <dt><code>input</code></dt> <dd>The <code>input</code> element has one mandatory attribute, - the <code>type</code> whose value can be either 'mouse' or - 'tablet'. The latter provides absolute - cursor movement, while the former uses relative movement. The optional + the <code>type</code> whose value can be 'mouse', 'tablet' or + 'keyboard'. The tablet provides absolute cursor movement, + while the mouse uses relative movement. The optional <code>bus</code> attribute can be used to refine the exact device type. It takes values "xen" (paravirtualized), "ps2" and "usb".</dd> </dl> -- 1.8.3.2

2 2

[libvirt] [PATCH] virsh: Don't leak buffer if GetFDs fails in cmdCreate
by Ján Tomko 24 Feb '14

24 Feb '14

Change the logic of the function to return false by default and move the freeing of the buffer to the cleanup section. https://bugzilla.redhat.com/show_bug.cgi?id=1067338 --- tools/virsh-domain.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 00ace11..59e843f 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -6518,7 +6518,7 @@ cmdCreate(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; const char *from = NULL; - bool ret = true; + bool ret = false; char *buffer; #ifndef WIN32 bool console = vshCommandOptBool(cmd, "console"); @@ -6534,7 +6534,7 @@ cmdCreate(vshControl *ctl, const vshCmd *cmd) return false; if (cmdStartGetFDs(ctl, cmd, &nfds, &fds) < 0) - return false; + goto cleanup; if (vshCommandOptBool(cmd, "paused")) flags |= VIR_DOMAIN_START_PAUSED; @@ -6545,20 +6545,23 @@ cmdCreate(vshControl *ctl, const vshCmd *cmd) dom = virDomainCreateXMLWithFiles(ctl->conn, buffer, nfds, fds, flags); else dom = virDomainCreateXML(ctl->conn, buffer, flags); - VIR_FREE(buffer); - if (dom != NULL) { - vshPrint(ctl, _("Domain %s created from %s\n"), - virDomainGetName(dom), from); -#ifndef WIN32 - if (console) - cmdRunConsole(ctl, dom, NULL, 0); -#endif - virDomainFree(dom); - } else { + if (!dom) { vshError(ctl, _("Failed to create domain from %s"), from); - ret = false; + goto cleanup; } + + vshPrint(ctl, _("Domain %s created from %s\n"), + virDomainGetName(dom), from); +#ifndef WIN32 + if (console) + cmdRunConsole(ctl, dom, NULL, 0); +#endif + virDomainFree(dom); + ret = true; + +cleanup: + VIR_FREE(buffer); VIR_FREE(fds); return ret; } -- 1.8.3.2

2 2

[libvirt] [PATCH] Fix memory leak when lookup pool list with invalid type option
by shyu 24 Feb '14

24 Feb '14

There will be memory leak when lookup pool list with invalid type option https://bugzilla.redhat.com/show_bug.cgi?id=1069068 ==23060== Memcheck, a memory error detector ==23060== Copyright (C) 2002-2012, and GNU GPL'd, by Julian Seward et al. ==23060== Using Valgrind-3.8.1 and LibVEX; rerun with -h for copyright info ==23060== Command: virsh pool-list --type invalid ==23060== error: Invalid pool type ==23060== ==23060== HEAP SUMMARY: ==23060== in use at exit: 138,383 bytes in 1,559 blocks ==23060== total heap usage: 4,199 allocs, 2,640 frees, 21,372,544 bytes allocated ==23060== ==23060== LEAK SUMMARY: ==23060== definitely lost: 8 bytes in 1 blocks ==23060== indirectly lost: 0 bytes in 0 blocks ==23060== possibly lost: 0 bytes in 0 blocks ==23060== still reachable: 138,375 bytes in 1,558 blocks ==23060== suppressed: 0 bytes in 0 blocks ==23060== Rerun with --leak-check=full to see details of leaked memory ==23060== ==23060== For counts of detected and suppressed errors, rerun with: -v ==23060== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 8 from 6) Signed-off-by: shyu <shyu(a)redhat.com> --- tools/virsh-pool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index 642b078..db4d3ae 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -859,6 +859,7 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) for (i = 0; i < npoolTypes; i++) { if ((poolType = virStoragePoolTypeFromString(poolTypes[i])) < 0) { vshError(ctl, "%s", _("Invalid pool type")); + VIR_FREE(*poolTypes); VIR_FREE(poolTypes); return false; } -- 1.7.1

3 3

[libvirt] block pull/commit for non-local storage
by Peter Krempa 24 Feb '14

24 Feb '14

Hi, with my recent work into snapshots with native libgfapi support I've run into an issue with libvirt APIs used to delete snapshots by management apps. The management apps use the APIs to do the job: int virDomainBlockCommit(virDomainPtr dom, const char *disk, const char *base, const char *top, unsigned long bandwidth, unsigned int flags) int virDomainBlockPull(virDomainPtr dom, const char *disk, unsigned long bandwidth, unsigned int flags) int virDomainBlockRebase(virDomainPtr dom, const char *disk, const char *base, unsigned long bandwidth, unsigned int flags) As you can see in the prototypes of these functions (and from the docs for them which I'm not going to copy here) the user can provide the disk specification in two possible options: 1) a full path if it's unambiguous - this is file centric and requires the file to be in the local filesystem 2) a disk name "vda" - this is selected automatically by libvirt but allows to specify only the top image. For systems that want to use remote storage without local representation such as gluster+libgfapi, this doesn't allow to use the APIs to start block jobs. To solve this issue we need a way to specify paths on remote storage in some way. Below are two options we've discussed on IRC. 1) Use URIs along with the file path to specify disk images. This option would add a new, possibly well documented URIs to specify paths for disk images. These would be libvirt defined URIs (but surprisingly "similar" to qemu URIS) so that hypervisors with different storage specification would need a conversion. This would allow to specify the targets as: vda - disk name /path/to/file - legacy way, path file:///path/to/file - new way of file paths block:///dev/blah - new way, block devs gluster://server/vol/img - new way, remote images ... Possible caveats: RBD for example allows to use multiple hosts and we'd need to introduce a possibility to specify it if we'd add support for this on rbd. 2) Export the image chain in the XML and allow to use indexed disk names This option would require to export the backing chain in the XML in some way, either the existing disk source specification in multiple elements (which I don't like as it is a bit convoluted), or possibly again via URIs. Then the user would be allowed to specify vda[2] for the second backing image of the vda disk. With this the internal representations of the backing chain would be used without the need for the user to specify path. A possible caveat here is that if backing chains for some reason will be converted to backing trees, this approach will be invalid. 3) ? anyone suggesting something better? :) Thanks in advance for suggestions and/or new ideas. Peter

4 7

[libvirt] [PATCH] cpu: break out when a right cpuCandidate found
by Wangyufei (James) 24 Feb '14

24 Feb '14

>From 8123c5d64f940fa0fb0de32fc5e68035980b6b01 Mon Sep 17 00:00:00 2001 From: WangYufei <james.wangyufei(a)huawei.com> Date: Thu, 13 Feb 2014 07:17:11 +0000 Subject: [PATCH] cpu: break out when a right cpuCandidate found In function x86Decode there's a code segment in while cycle like this: if (cpuModel == NULL || cpuModel->nfeatures > cpuCandidate->nfeatures) { virCPUDefFree(cpuModel); cpuModel = cpuCandidate; cpuData = candidate->data; } else { virCPUDefFree(cpuCandidate); } when it finds the right cpuCandidate, it doesn't break out the cycle, but continues run in it, and cpuModel will never get a new value, it's meaningless. It should break out when a right cpuCndidate found. Signed-off-by: WangYufei <james.wangyufei(a)huawei.com> --- src/cpu/cpu_x86.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 56080ef..546b757 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -1558,6 +1558,7 @@ x86Decode(virCPUDefPtr cpu, virCPUDefFree(cpuModel); cpuModel = cpuCandidate; cpuData = candidate->data; + break; } else { virCPUDefFree(cpuCandidate); } -- 1.7.12.4 Best Regards, -WangYufei

4 4