- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/3] bhyve: implement PCI address allocation
by Roman Bogorodskiy 06 May '14

06 May '14

The first attempt to share PCI allocation code from qemu driver with bhyve. To this point it went pretty smooth and I didn't have to make any changes to the implementation of the extracted PCI code. The only slight change I made is extracing virDomainPCIAddressSetAlloc() from DomainPCIAddressSetCreate() to perform the actual memory allocation, just because having virDomainPCIAddressSetFree() without Alloc() felt a little inconsistent. During testing I spotted only one problem (so far): the domain defined on libvirtd without new PCI allocation doesn't start on a new version because the definition didn't have addresses auto-assigned. Also, I guess, there could be cases where bhyve code will trigger something from PCI allocation code that is not supported by bhyve (e.g.: pci bridge). I'm not sure how to properly test all the cases like that. Changes from v2: - Base on PCI allocation code from Qemu driver Changes from v1: - Reserve slot 1 for LPC PCI-ISA bridge, used by console device - Respect addresses provided by user in domain xml file - Fix tests so 'make check' passes Roman Bogorodskiy (3): qemu: extract PCI handling structs qemu: extract common PCI handling functions bhyve: implement PCI address allocation Roman Bogorodskiy (3): qemu: extract PCI handling structs qemu: extract common PCI handling functions bhyve: implement PCI address allocation po/POTFILES.in | 1 + src/Makefile.am | 6 +- src/bhyve/bhyve_command.c | 131 ++-- src/bhyve/bhyve_device.c | 174 +++++ src/bhyve/bhyve_device.h | 38 ++ src/bhyve/bhyve_domain.c | 75 +++ src/bhyve/bhyve_domain.h | 39 ++ src/bhyve/bhyve_driver.c | 9 +- src/libvirt_private.syms | 14 + src/qemu/qemu_command.c | 749 +++------------------ src/qemu/qemu_command.h | 40 +- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_domain.h | 5 +- src/qemu/qemu_hotplug.c | 8 +- src/qemu/qemu_process.c | 2 +- src/util/virpci.c | 532 +++++++++++++++ src/util/virpci.h | 121 ++++ .../bhyvexml2argvdata/bhyvexml2argv-acpiapic.args | 2 +- tests/bhyvexml2argvdata/bhyvexml2argv-acpiapic.xml | 2 + tests/bhyvexml2argvdata/bhyvexml2argv-base.args | 2 +- tests/bhyvexml2argvdata/bhyvexml2argv-base.xml | 2 + tests/bhyvexml2argvdata/bhyvexml2argv-console.args | 4 +- tests/bhyvexml2argvdata/bhyvexml2argv-console.xml | 2 + .../bhyvexml2argv-disk-virtio.args | 2 +- .../bhyvexml2argv-disk-virtio.xml | 2 + tests/bhyvexml2argvdata/bhyvexml2argv-macaddr.args | 2 +- tests/bhyvexml2argvdata/bhyvexml2argv-macaddr.xml | 2 + tests/bhyvexml2argvdata/bhyvexml2argv-serial.args | 4 +- tests/bhyvexml2argvdata/bhyvexml2argv-serial.xml | 2 + tools/Makefile.am | 1 + 30 files changed, 1205 insertions(+), 770 deletions(-) create mode 100644 src/bhyve/bhyve_device.c create mode 100644 src/bhyve/bhyve_device.h create mode 100644 src/bhyve/bhyve_domain.c create mode 100644 src/bhyve/bhyve_domain.h -- 1.9.0

4 6

[libvirt] [PATCH] Fix build wihout macvtap or virtualport
by Ján Tomko 06 May '14

06 May '14

Commit 1b14c44 broke the build on FreeBSD by changing the signature of a few functions without updating the corresponding stubs that are used when WITH_MACVTAP or WITH_VIRTUALPORT is not defined. --- Pushed under the build-breaker rule. src/util/virnetdevmacvlan.c | 8 ++++---- src/util/virnetdevvportprofile.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index 56a5f6b..cb85b74 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -1068,13 +1068,13 @@ int virNetDevMacVLanDelete(const char *ifname ATTRIBUTE_UNUSED) int virNetDevMacVLanCreateWithVPortProfile(const char *ifname ATTRIBUTE_UNUSED, const virMacAddr *macaddress ATTRIBUTE_UNUSED, const char *linkdev ATTRIBUTE_UNUSED, - enum virNetDevMacVLanMode mode ATTRIBUTE_UNUSED, + virNetDevMacVLanMode mode ATTRIBUTE_UNUSED, bool withTap ATTRIBUTE_UNUSED, int vnet_hdr ATTRIBUTE_UNUSED, const unsigned char *vmuuid ATTRIBUTE_UNUSED, virNetDevVPortProfilePtr virtPortProfile ATTRIBUTE_UNUSED, char **res_ifname ATTRIBUTE_UNUSED, - enum virNetDevVPortProfileOp vmop ATTRIBUTE_UNUSED, + virNetDevVPortProfileOp vmop ATTRIBUTE_UNUSED, char *stateDir ATTRIBUTE_UNUSED, virNetDevBandwidthPtr bandwidth ATTRIBUTE_UNUSED) { @@ -1100,7 +1100,7 @@ int virNetDevMacVLanRestartWithVPortProfile(const char *cr_ifname ATTRIBUTE_UNUS const char *linkdev ATTRIBUTE_UNUSED, const unsigned char *vmuuid ATTRIBUTE_UNUSED, virNetDevVPortProfilePtr virtPortProfile ATTRIBUTE_UNUSED, - enum virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED) + virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Cannot create macvlan devices on this platform")); @@ -1112,7 +1112,7 @@ int virNetDevMacVLanVPortProfileRegisterCallback(const char *ifname ATTRIBUTE_UN const char *linkdev ATTRIBUTE_UNUSED, const unsigned char *vmuuid ATTRIBUTE_UNUSED, virNetDevVPortProfilePtr virtPortProfile ATTRIBUTE_UNUSED, - enum virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED) + virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Cannot create macvlan devices on this platform")); diff --git a/src/util/virnetdevvportprofile.c b/src/util/virnetdevvportprofile.c index 7354b2c..0f43b02 100644 --- a/src/util/virnetdevvportprofile.c +++ b/src/util/virnetdevvportprofile.c @@ -1248,7 +1248,7 @@ int virNetDevVPortProfileAssociate(const char *macvtap_ifname ATTRIBUTE_UNUSED, const char *linkdev ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, const unsigned char *vmuuid ATTRIBUTE_UNUSED, - enum virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED, + virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED, bool setlink_only ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", @@ -1261,7 +1261,7 @@ int virNetDevVPortProfileDisassociate(const char *macvtap_ifname ATTRIBUTE_UNUSE const virMacAddr *macvtap_macaddr ATTRIBUTE_UNUSED, const char *linkdev ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, - enum virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED) + virNetDevVPortProfileOp vmOp ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", _("Virtual port profile association not supported on this platform")); -- 1.8.3.2

1 0

[libvirt] libvirt 1.2.4 and virt-manager 0.9.0 are not incompatible
by xeon_feng 06 May '14

06 May '14

Hello everyone I encountered a problem when I completed the update of libvirt from 0.10 to 1.2.4 . The problem was that virt-manager(version 0.9.0) could not start and reported error : "ImportError: /usr/lib64/libvirt.so.0: version 'LIBVIRT_PRIVIATE_0.10.2' not found (required by /usr/lib64/python2.6/site-packages/libvirtmod.so)". I found the libvirt.so.0 link file just in the /usr/lib64/ directory , but it was linking to libvirt.so.0.1002.4 .not to the libvirt.so.0.10.2 I made libvirt.so.0 to link to libvirt.so.0.10.2 and restarted virt-manager , virt-manager started normally then restarted libvirtd failure, reporting error:l “ibvirtd: /usr/lib64/libvirt.so.0: version 'LIBVIRT_1.2.3' not found (require by libvirtd) .....” I made libvirt.so.0 to link to libvirt.so.0.1002.4 and restart libvirtd , libvirtd started normally again. Please help me to resolve the problem and give me some advise.... Thanks a lot.. Xeon.Feng

2 1

[libvirt] [PATCH] docs: fix a typo in formatdomain
by Chen Hanxiao 06 May '14

06 May '14

s/virual/virtual Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com> --- docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index b1be724..4f19473 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4787,7 +4787,7 @@ qemu-kvm -net nic,model=? /dev/null The nmdm device driver, available on FreeBSD, provides two - tty devices connected together by a virual null modem cable. + tty devices connected together by a virtual null modem cable. Since 1.2.4 -- 1.9.0

2 1

[libvirt] Question about QCOW2 and Libvirt Storage Pools
by Solly Ross 05 May '14

05 May '14

Hi, I'm doing some work getting libvirt storage pools into OpenStack, as they definitely make certain operations much easier for the Nova libvirt driver. However, one thing I noticed is that since storage pools automatically refresh on reboot, initial creation information gets lost. This poses a problem, since libvirt probes for file type for the filesystem-based pools (dir, fs, netfs, etc), and can erroneously detect a RAW file as another file type (for instance, QCOW2). Is there a reason libvirt doesn't have an option to persist (to disk) the unchanging parts of the volume XML? Best Regards, Solly Ross P.S. we currently deal with a similar problem in OpenStack by saving the file type to disk the first time we use the image file. However, it would be nice if libvirt could handle this for us, at some point, as it seems like it would be a good thing to have in libvirt.

2 1

[libvirt] [PATCH 1/2] virsh: Replace list element to defined variable
by Li Yang 05 May '14

05 May '14

Signed-off-by: Li Yang <liyang.fnst(a)cn.fujitsu.com> --- tools/virsh-secret.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 47974fe..e996c72 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -558,7 +558,7 @@ cmdSecretList(vshControl *ctl, const vshCmd *cmd ATTRIBUTE_UNUSED) const char *usageStr = virSecretUsageTypeTypeToString(usageType); char uuid[VIR_UUID_STRING_BUFLEN]; - if (virSecretGetUUIDString(list->secrets[i], uuid) < 0) { + if (virSecretGetUUIDString(sec, uuid) < 0) { vshError(ctl, "%s", _("Failed to get uuid of secret")); goto cleanup; } -- 1.7.1

3 3

Re: [libvirt] [virt-tools-list] [virt-manager PATCH] test: Fix tests with latest libvirt
by Cole Robinson 05 May '14

05 May '14

On 05/04/2014 10:59 PM, Chen Hanxiao wrote: > Signed-off-by: Chen Hanxiao <chenhanxiao(a)cn.fujitsu.com> > --- > tests/cli-test-xml/compare/virt-clone-clone-auto1.xml | 6 ++++++ > tests/cli-test-xml/compare/virt-clone-clone-auto2.xml | 1 + > 2 files changed, 7 insertions(+) > > diff --git a/tests/cli-test-xml/compare/virt-clone-clone-auto1.xml b/tests/cli-test-xml/compare/virt-clone-clone-auto1.xml > index b9fde61..03b7b5c 100644 > --- a/tests/cli-test-xml/compare/virt-clone-clone-auto1.xml > +++ b/tests/cli-test-xml/compare/virt-clone-clone-auto1.xml > @@ -22,16 +22,19 @@ > <disk type="block" device="floppy"> > <driver type="vmdk"/> > <source dev="/dev/disk-pool/diskvol1-clone"/> > + <backingStore/> > <target dev="fda" bus="fdc"/> > <address type="drive" controller="0" bus="0" target="0" unit="0"/> > </disk> > <disk type="block" device="disk"> > <source dev="/dev/disk-pool/diskvol2"/> > + <backingStore/> > <target dev="sda" bus="scsi"/> > <readonly/> > <address type="drive" controller="0" bus="0" target="0" unit="0"/> > </disk> > <disk type="block" device="cdrom"> > + <backingStore/> > <target dev="sdb" bus="scsi"/> > <readonly/> > <address type="drive" controller="0" bus="0" target="0" unit="1"/> > @@ -39,6 +42,7 @@ > <disk type="block" device="disk"> > <driver type="qcow2"/> > <source dev="/dev/default-pool/collidevol1.img"/> > + <backingStore/> > <target dev="sdc" bus="scsi"/> > <readonly/> > <shareable/> > @@ -46,11 +50,13 @@ > </disk> > <disk type="file" device="disk"> > <source file="/dev/default-pool/default-vol-clone"/> > + <backingStore/> > <target dev="hda" bus="ide"/> > <address type="drive" controller="0" bus="0" target="0" unit="0"/> > </disk> > <disk type="file" device="disk"> > <source file="/dev/default-pool/testvol2-clone.img"/> > + <backingStore/> > <target dev="hdb" bus="ide"/> > <address type="drive" controller="0" bus="0" target="0" unit="1"/> > </disk> > diff --git a/tests/cli-test-xml/compare/virt-clone-clone-auto2.xml b/tests/cli-test-xml/compare/virt-clone-clone-auto2.xml > index fb78434..bbbde76 100644 > --- a/tests/cli-test-xml/compare/virt-clone-clone-auto2.xml > +++ b/tests/cli-test-xml/compare/virt-clone-clone-auto2.xml > @@ -22,6 +22,7 @@ > <disk type="file" device="disk"> > <driver type="qcow2"/> > <source file="/dev/default-pool/newvm.img"/> > + <backingStore/> > <target dev="hda" bus="ide"/> > <address type="drive" controller="0" bus="0" target="0" unit="0"/> > </disk> > Hmm, what is actually going on here? I know latest libvirt added backingStore chain XML to the domain XML, but what does a bare <backingStore/> mean here? Anyone on the libvirt side know if this is intentional? - Cole

2 2

[libvirt] [PATCH V2 0/3] support flags in libxlDomain{Shutdown, Reboot}
by Jim Fehlig 05 May '14

05 May '14

This small series is a V2 of https://www.redhat.com/archives/libvir-list/2014-April/msg00837.html Patch 1 adds VIR_DOMAIN_SHUTDOWN_PARAVIRT and VIR_REBOOT_SHUTDOWN_PARAVIRT flags to the API as requested by danpb. Patch 2 makes use of the shutdown flags in libxlDomainShutdownFlags. Patch 3 does the same for libxlDomainReboot. Jim Fehlig (3): Introduce a new flag for controlling shutdown/reboot libxl: support PARAVIRT and ACPI shutdown flags libxl: support PARAVIRT and ACPI reboot flags include/libvirt/libvirt.h.in | 2 ++ src/libxl/libxl_driver.c | 64 +++++++++++++++++++++++++++++++++++--------- tools/virsh-domain.c | 14 +++++++--- tools/virsh.pod | 8 +++--- 4 files changed, 68 insertions(+), 20 deletions(-) -- 1.8.1.4

3 13

[libvirt] [PATCH 0/2] virstoragefile cleanups
by Eric Blake 05 May '14

05 May '14

I found these cleanups while trying to solve the regression that John identified, where we are losing the correct capacity read from a qcow2 header when it comes time to dump a volume's xml. I still plan to get that regression fixed before 1.2.4 goes out the door, but this was worth posting in the meantime. Eric Blake (2): conf: avoid null deref during storage probe conf: drop extra storage probe src/libvirt_private.syms | 1 - src/storage/storage_backend_fs.c | 8 -------- src/storage/storage_backend_gluster.c | 5 ----- src/util/virstoragefile.c | 37 ++++++++++++++++------------------- src/util/virstoragefile.h | 7 ++----- 5 files changed, 19 insertions(+), 39 deletions(-) -- 1.9.0

2 6

[libvirt] [PATCH] bhyve: report cpuTime in bhyveDomainGetInfo
by Roman Bogorodskiy 05 May '14

05 May '14

Add a helper function virBhyveGetDomainTotalCpuStats() to obtain process CPU time using kvm (kernel memory interface) and use it to set cpuTime field of the virDomainInfo struct in bhyveDomainGetInfo(). --- configure.ac | 7 +++++++ src/bhyve/bhyve_driver.c | 9 +++++++++ src/bhyve/bhyve_process.c | 40 ++++++++++++++++++++++++++++++++++++++++ src/bhyve/bhyve_process.h | 3 +++ 4 files changed, 59 insertions(+) diff --git a/configure.ac b/configure.ac index 12338d4..2e5fa1a 100644 --- a/configure.ac +++ b/configure.ac @@ -2684,6 +2684,13 @@ AC_CHECK_DECLS([cpuset_getaffinity], #include <sys/cpuset.h> ]) +# Check for BSD kvm (kernel memory interface) +if test $with_freebsd = yes; then + AC_CHECK_LIB([kvm], [kvm_getprocs], [], + [AC_MSG_ERROR([BSD kernel memory interface library is required to build on FreeBSD])] + ) +fi + # Check if we need to look for ifconfig if test "$want_ifconfig" = "yes"; then AC_PATH_PROG([IFCONFIG_PATH], [ifconfig]) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 6d681fd..0780e74 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -268,6 +268,15 @@ bhyveDomainGetInfo(virDomainPtr domain, virDomainInfoPtr info) if (virDomainGetInfoEnsureACL(domain->conn, vm->def) < 0) goto cleanup; + if (virDomainObjIsActive(vm)) { + if (virBhyveGetDomainTotalCpuStats(vm, &(info->cpuTime)) < 0) { + virReportError(VIR_ERR_OPERATION_FAILED, + "%s", _("Cannot read cputime for domain")); + goto cleanup; + } + } else + info->cpuTime = 0; + info->state = virDomainObjGetState(vm, NULL); info->maxMem = vm->def->mem.max_balloon; info->nrVirtCpu = vm->def->vcpus; diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index a557bc5..b6f0f2c 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -22,7 +22,11 @@ #include <config.h> #include <fcntl.h> +#include <kvm.h> +#include <sys/param.h> #include <sys/types.h> +#include <sys/sysctl.h> +#include <sys/user.h> #include <sys/ioctl.h> #include <net/if.h> #include <net/if_tap.h> @@ -246,3 +250,39 @@ virBhyveProcessStop(bhyveConnPtr driver, virCommandFree(cmd); return ret; } + +int +virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, + unsigned long long *cpustats) +{ + struct kinfo_proc *kp; + kvm_t *kd; + char errbuf[_POSIX2_LINE_MAX]; + int nprocs; + int ret = -1; + + if ((kd = kvm_openfiles(NULL, NULL, NULL, O_RDONLY, errbuf)) == NULL) { + virReportError(VIR_ERR_SYSTEM_ERROR, + _("Unable to get kvm descriptor: %s"), + errbuf); + return -1; + + } + + kp = kvm_getprocs(kd, KERN_PROC_PID, vm->pid, &nprocs); + if (kp == NULL || nprocs != 1) { + virReportError(VIR_ERR_SYSTEM_ERROR, + _("Unable to obtain information about pid: %d"), + (int)vm->pid); + goto cleanup; + } + + *cpustats = kp->ki_runtime * 1000ull; + + ret = 0; + + cleanup: + kvm_close(kd); + + return ret; +} diff --git a/src/bhyve/bhyve_process.h b/src/bhyve/bhyve_process.h index f91504e..3049ad0 100644 --- a/src/bhyve/bhyve_process.h +++ b/src/bhyve/bhyve_process.h @@ -34,6 +34,9 @@ int virBhyveProcessStop(bhyveConnPtr driver, virDomainObjPtr vm, virDomainShutoffReason reason); +int virBhyveGetDomainTotalCpuStats(virDomainObjPtr vm, + unsigned long long *cpustats); + typedef enum { VIR_BHYVE_PROCESS_START_AUTODESTROY = 1 << 0, } bhyveProcessStartFlags; -- 1.9.0

2 4

[libvirt] [PATCH v3] storageVolCreateXMLFrom: Allow multiple accesses to origvol
by Michal Privoznik 05 May '14

05 May '14

When creating a new volume, it is possible to copy data into it from another already existing volume (referred to as @origvol). Obviously, the read-only access to @origvol is required, which is thread safe (probably not performance-wise though). However, with current code both @newvol and @origvol are marked as building for the time of copying data from the @origvol to @newvol. The rationale behind is to disallow some operations on both @origvol and @newvol, e.g. vol-wipe, vol-delete, vol-download. While it makes sense to not allow such operations on partly copied mirror, but it doesn't make sense to disallow vol-create on the source (@origvol). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v2: - changed the error message if volume is in use - reworded commit message src/conf/storage_conf.h | 1 + src/storage/storage_driver.c | 32 ++++++++++++++++++++++++++++++-- 2 files changed, 31 insertions(+), 2 deletions(-) diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index 9ad38e1..eae959c 100644 --- a/src/conf/storage_conf.h +++ b/src/conf/storage_conf.h @@ -64,6 +64,7 @@ struct _virStorageVolDef { int type; /* enum virStorageVolType */ unsigned int building; + unsigned int in_use; virStorageVolSource source; virStorageSource target; diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 2cb8347..542b382 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1640,6 +1640,13 @@ storageVolDelete(virStorageVolPtr obj, if (virStorageVolDeleteEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; + if (vol->in_use) { + virReportError(VIR_ERR_OPERATION_INVALID, + _("volume '%s' is still in use."), + vol->name); + goto cleanup; + } + if (vol->building) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), @@ -1912,8 +1919,8 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, /* Drop the pool lock during volume allocation */ pool->asyncjobs++; - origvol->building = 1; newvol->building = 1; + origvol->in_use++; virStoragePoolObjUnlock(pool); if (origpool) { @@ -1929,7 +1936,7 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, virStoragePoolObjLock(origpool); storageDriverUnlock(driver); - origvol->building = 0; + origvol->in_use--; newvol->building = 0; allocation = newvol->target.allocation; pool->asyncjobs--; @@ -2076,6 +2083,13 @@ storageVolUpload(virStorageVolPtr obj, if (virStorageVolUploadEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; + if (vol->in_use) { + virReportError(VIR_ERR_OPERATION_INVALID, + _("volume '%s' is still in use."), + vol->name); + goto cleanup; + } + if (vol->building) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), @@ -2167,6 +2181,13 @@ storageVolResize(virStorageVolPtr obj, if (virStorageVolResizeEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; + if (vol->in_use) { + virReportError(VIR_ERR_OPERATION_INVALID, + _("volume '%s' is still in use."), + vol->name); + goto cleanup; + } + if (vol->building) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), @@ -2474,6 +2495,13 @@ storageVolWipePattern(virStorageVolPtr obj, if (virStorageVolWipePatternEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; + if (vol->in_use) { + virReportError(VIR_ERR_OPERATION_INVALID, + _("volume '%s' is still in use."), + vol->name); + goto cleanup; + } + if (vol->building) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), -- 1.9.0

2 1

[libvirt] Some odd quriks of libvirt and xen on fedora 20.
by Alvin Starr 05 May '14

05 May '14

I am using xen 4.3 on Fedora 20. For PV systems the vnc console display is on the correct port with the following call do qeum-dm libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -domain-name libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: paravirt libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -vnc libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: 127.0.0.1:1 but for HV systems xl is being passed libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -domain-name libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: fullvirt libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -vnc libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: 127.0.0.1:0 libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -vncunused libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -serial libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: pty libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: -videoram libxl: debug: libxl_dm.c:1213:libxl__spawn_local_dm: 8 Where would I look to correct this? -- Alvin Starr || voice: (905)513-7688 Netvel Inc. || Cell: (416)806-0133 alvin(a)netvel.net ||

3 4

[libvirt] [PATCH] typos: fix s/it/is/ where applicable
by Martin Kletzander 05 May '14

05 May '14

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Notes: pushed as trivial docs/drvesx.html.in | 4 ++-- src/esx/esx_driver.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/drvesx.html.in b/docs/drvesx.html.in index 0816baf..d1e67d0 100644 --- a/docs/drvesx.html.in +++ b/docs/drvesx.html.in @@ -148,7 +148,7 @@ vpx://example-vcenter.com/folder1/dc1/folder2/example-esx.com </td> <td> If set to 1, this disables libcurl client checks of the server's - SSL certificate. The default value it 0. See the + SSL certificate. The default value is 0. See the <a href="#certificates">Certificates for HTTPS</a> section for details. </td> @@ -164,7 +164,7 @@ vpx://example-vcenter.com/folder1/dc1/folder2/example-esx.com If set to 1, the driver answers all <a href="#questions">questions</a> with the default answer. If set to 0, questions are reported as errors. The default - value it 0. Since 0.7.5. + value is 0. Since 0.7.5. </td> </tr> <tr> diff --git a/src/esx/esx_driver.c b/src/esx/esx_driver.c index d082927..5dd0a63 100644 --- a/src/esx/esx_driver.c +++ b/src/esx/esx_driver.c @@ -889,11 +889,11 @@ esxConnectToVCenter(esxPrivate *priv, * it. If the ESX host is not managed by a vCenter an error is reported. * * If the no_verify parameter is set to 1, this disables libcurl client checks - * of the server's certificate. The default value it 0. + * of the server's certificate. The default value is 0. * * If the auto_answer parameter is set to 1, the driver will respond to all * virtual machine questions with the default answer, otherwise virtual machine - * questions will be reported as errors. The default value it 0. + * questions will be reported as errors. The default value is 0. * * The proxy parameter allows to specify a proxy for to be used by libcurl. * The default for the optional <type> part is http and socks is synonymous for -- 1.9.2

1 0

[libvirt] [PATCH v2 0/2] bhyve: implement connectDomainXMLToNative
by Roman Bogorodskiy 04 May '14

04 May '14

Changes from v1: - Return both bhyveload and bhyve commands, not only bhyve. Roman Bogorodskiy (2): bhyve: improve bhyve_command.c testability bhyve: implement connectDomainXMLToNative src/bhyve/bhyve_command.c | 85 +++++++++++++++++++++++++---------------------- src/bhyve/bhyve_command.h | 8 +++-- src/bhyve/bhyve_driver.c | 59 ++++++++++++++++++++++++++++++++ src/bhyve/bhyve_process.c | 10 +++--- tests/bhyvexml2argvtest.c | 2 +- 5 files changed, 117 insertions(+), 47 deletions(-) -- 1.9.0

2 6

[libvirt] [PATCH] Fix vlan ID detection in udev interface driver
by Ján Tomko 04 May '14

04 May '14

Instead of guessing it from the interface name, look into /proc/net/vlan/<interface>. This works for devices not named <real_device>.<vlan ID>, avoiding an error flood when virt-manager keeps asking about them every second: https://bugzilla.redhat.com/show_bug.cgi?id=966329 --- src/interface/interface_backend_udev.c | 67 ++++++++++++++++++++++++++-------- 1 file changed, 51 insertions(+), 16 deletions(-) diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index b05ac0e..bec8c45 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -20,11 +20,13 @@ */ #include <config.h> +#include <ctype.h> #include <errno.h> #include <dirent.h> #include <libudev.h> #include "virerror.h" +#include "virfile.h" #include "c-ctype.h" #include "datatypes.h" #include "domain_conf.h" @@ -966,31 +968,64 @@ udevGetIfaceDefVlan(struct udev *udev ATTRIBUTE_UNUSED, const char *name, virInterfaceDef *ifacedef) { - const char *vid; + char *procpath = NULL; + char *buf = NULL; + char *vid_pos, *dev_pos; + size_t vid_len, dev_len; + const char *vid_prefix = "VID: "; + const char *dev_prefix = "\nDevice: "; + int ret = -1; + + if (virAsprintf(&procpath, "/proc/net/vlan/%s", name) < 0) + goto cleanup; + + if (virFileReadAll(procpath, BUFSIZ, &buf) < 0) + goto cleanup; - /* Find the DEVICE.VID again */ - vid = strrchr(name, '.'); - if (!vid) { + if ((vid_pos = strstr(buf, vid_prefix)) == NULL) { virReportError(VIR_ERR_INTERNAL_ERROR, _("failed to find the VID for the VLAN device '%s'"), name); - return -1; + goto cleanup; } + vid_pos += strlen(vid_prefix); - /* Set the VLAN specifics */ - if (VIR_STRDUP(ifacedef->data.vlan.tag, vid + 1) < 0) - goto error; - if (VIR_STRNDUP(ifacedef->data.vlan.devname, - name, (vid - name)) < 0) - goto error; + if ((vid_len = strspn(vid_pos, "0123456789")) == 0 || + !isspace(vid_pos[vid_len])) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("failed to find the VID for the VLAN device '%s'"), + name); + goto cleanup; + } - return 0; + if ((dev_pos = strstr(vid_pos + vid_len, dev_prefix)) == NULL) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("failed to find the real device for the VLAN device '%s'"), + name); + goto cleanup; + } + dev_pos += strlen(dev_prefix); - error: - VIR_FREE(ifacedef->data.vlan.tag); - VIR_FREE(ifacedef->data.vlan.devname); + if ((dev_len = strcspn(dev_pos, "\n")) == 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("failed to find the real device for the VLAN device '%s'"), + name); + goto cleanup; + } - return -1; + if (VIR_STRNDUP(ifacedef->data.vlan.tag, vid_pos, vid_len) < 0) + goto cleanup; + if (VIR_STRNDUP(ifacedef->data.vlan.devname, dev_pos, dev_len) < 0) { + VIR_FREE(ifacedef->data.vlan.tag); + goto cleanup; + } + + ret = 0; + + cleanup: + VIR_FREE(procpath); + VIR_FREE(buf); + return ret; } static virInterfaceDef * ATTRIBUTE_NONNULL(1) -- 1.8.3.2

4 6

[libvirt] [PATCH] Bump version to 1.2.5 for new dev cycle
by John Ferlan 04 May '14

04 May '14

Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed already just sending note. configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 12338d4..fef99af 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [1.2.4], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [1.2.5], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) -- 1.9.0

1 0

[libvirt] Release of libvirt-1.2.4
by Daniel Veillard 04 May '14

04 May '14

As planned I tagged the release in git and pushed the tarball and signed rpms to the usual place: ftp://libvirt.org/libvirt/ I also generated those for python too even if the only change is a spec file update, they are in the python subdir. This is a smaller than average release, with most of the changes on code refactoring, portability and bug fixes, so no big features here but general improvements: Documentation: - Device{Attach,Detach}: Document S4 limitations (Michal Privoznik) - Add a new example to illustrate domain migration (Sahid Orentino Ferdjaoui) - update docs for setting the QEMU BIOS path (Chen Hanxiao) - document nmdm type console (Roman Bogorodskiy) - Fix typos in src/* (Nehal J Wani) - document that vfio is default for hostdev networks too (Laine Stump) - cpu: Add documentation for CPU driver APIs (Jiri Denemark) - virsh: Fix comment of vshCmdInfo (Li Yang) Portability: - Explicitly link virfirewalltest and virsystemdtest against dbus (Guido Günther) - qemuxml2argvtest: Don't use privileged mode upfront (Guido Günther) - tests: skip virfirewalltest on non-Linux systems (Roman Bogorodskiy) - tests: don't fail with newer gnutls (Martin Kletzander) - fix build with older gcc (Ján Tomko) - storage: reject negative indices (Eric Blake) - networkxml2firewalltest: fix build failure on freebsd (Pavel Hrdina) - virfirewall: fix build on freebsd (Pavel Hrdina) - Disable libvirtd by default when building on Win32 (Daniel P. Berrange) - Don't use SO_REUSEADDR on Win32 platforms (Daniel P. Berrange) - Conditionalize include of dlfcn.h in virmock.h (Daniel P. Berrange) - build: avoid 'index' as variable name (Eric Blake) - build: Don't use code with dbus_message_unref when built without dbus (Martin Kletzander) - tests: Fix systemd test with --without-driver-modules (Jiri Denemark) - Fix build on mingw32 (Ján Tomko) - build: avoid compiler warning on shadowed name (Jean-Baptiste Rouault) - tests: link against libxml2 (Guido Günther) - tests: build viridentitytest only WITH_ATTR. (Jincheng Miao) - maint: Correctly detect wether "gluster" cli tool is accessible (Peter Krempa) - libvirt-guests: avoid bashism (Guido Günther) - Use the force flag for mkfs -t xfs (Ján Tomko) Bug Fixes: - Restore skipping of setting capacity (John Ferlan) - qemu: fix crash when removing <filterref> from interface with update-device (Laine Stump) - storage: Clear all data allocated about backing store before reparsing (Peter Krempa) - nwfilter: Tear down temp. filters when tearing all filters (Stefan Berger) - Set mknod permission in device ACL for LXC USB devices (Daniel P. Berrange) - conf: avoid null deref during storage probe (Eric Blake) - qemu: properly quit migration with abort_on_error (Martin Kletzander) - qemu: don't call virFileExists() for network type disks (Martin Kletzander) - storage_backend_rbd: Correct argument order to rbd_create3 (Steven McDonald) - xen: ensure /usr/sbin/xend exists before checking status (Jim Fehlig) - Remove bogus ATTRIBUTE_NONNULL from virFirewallAddRuleFull (Daniel P. Berrange) - Make autostart of virtlockd actually work (Daniel P. Berrange) - Fix leak on OOM in virNWFilterVarValueCreateSimpleCopyValue (Daniel P. Berrange) - qemu: Avoid overflow when setting migration speed on inactive domains (Jiri Denemark) - qemu: don't check for backing chains for formats w/o snapshot support (Martin Kletzander) - Fix pci bus naming for PPC (Daniel P. Berrange) - Document behavior of setvcpus during guest boot (Ján Tomko) - Save domain status after cpu hotplug (Ján Tomko) - Fix error for out of range vcpu in qemuDomainPinVcpuFlags (Ján Tomko) - Properly free vcpupin info for unplugged CPUs (Ján Tomko) - Only set QEMU_CAPS_NO_HPET on x86 (Ján Tomko) - Fix Memory Leak in virStorageFileGetMetadataRecurse() (Nehal J Wani) - qemu: Unlock the NWFilter update lock by leaving via the cleanup label (Stefan Berger) - storage: netfs: Handle backend errors (John Ferlan) - conf: fix omission of <driver> in domain dumpxml (Eric Blake) - Fix virsystemdtest without SYSTEMD_DAEMON (Ján Tomko) - qemu: Avoid overflow when setting migration speed (Jiri Denemark) - bhyve: fix domain management (Wojciech Macek) - Check maximum startcpu value correctly (Ján Tomko) - storage: Don't update pool available/allocation if buildVol fails (John Ferlan) - LXC: Fix return code evaulation in lxcCheckNetNsSupport() (Richard Weinberger) - Fix incorrect values in redirdev ABI check error (Ján Tomko) - virNetDev{Replace,Restore}MacAddress: Fix memory leak (Wangrui K) - bhyveConnectGetCapabilities: Fix double caps unref (Michal Privoznik) - Simplify bhyveDriverGetCapabilities() (Michal Privoznik) - bhyve_capabilities: Add Semihalf to Copyright (Michal Privoznik) - tests: Don't crash when creating the config object fails (Guido Günther) - conf: avoid memleak on NULL path (Eric Blake) - lxc conf2xml: don't let current vcpus at 0: define won't like it (Cédric Bosdonnat) - QoS: make tc filters match all traffic (Antoni S. Puimedon) - NFS storage pool: Fix libvirtd crash due to refactor edit (John Ferlan) - Define CPUINFO_FILE_LEN and fix maxlen of cpuinfo file for all uses (Olivia Yin) - Fix Memory Leak in daemon/libvirtd.c (Nehal J Wani) - qemu: make sure agent returns error when required data are missing (Martin Kletzander) - Fix coverity-reported leak in virSecurityManagerGenLabel (Ján Tomko) - phyp: fix logic error on volume creation (Eric Blake) - qemu: cleanup error checking on agent replies (Martin Kletzander) Improvements - util: new stricter unsigned int parsing (Eric Blake) - util: fix uint parsing on 64-bit platforms (Eric Blake) - Misc error reporting bugs in QEMU cli builder (Daniel P. Berrange) - nwfilter: Validate rule after parsing (Stefan Berger) - Add support for QEMU migration to use SASL authentication (Sahid Orentino Ferdjaoui) - enforce sane readdir usage (Eric Blake) - network: use virDirRead in networkMigrateStateFiles (Laine Stump) - storage: use virDirRead API (Eric Blake) - drivers: use virDirRead API (Eric Blake) - util: use virDirRead API (Eric Blake) - conf: use virDirRead API (Eric Blake) - nodeinfo: use virDirRead API (Natanael Copa) - util: introduce virDirRead wrapper for readdir (Natanael Copa) - tests: remove hostdevmgr directory on cleanup (Martin Kletzander) - Use virFileFindResource to locate virtlockd daemon (Daniel P. Berrange) - Use virFileFindResource to locate libvirtd daemon (Daniel P. Berrange) - Recheck disk backing chains after snapshot (Jiri Denemark) - network: centralize check for active network during interface attach (Laine Stump) - network: set macvtap/hostdev networks active if their state file exists (Laine Stump) - network: change location of network state xml files (Laine Stump) - network: create statedir during driver initialization (Laine Stump) - network: fix virNetworkObjAssignDef and persistence (Laine Stump) - build: -avoid-version on libvirt_driver_nwfilter (Dwight Engen) - libxl: Support PV consoles (Ian Campbell) - build: add nwfilterxml2firewalldata to dist (Dwight Engen) - Add a test suite for nwfilter ebiptables tech driver (Daniel P. Berrange) - Remove last trace of direct firewall command exection (Daniel P. Berrange) - Convert ebiptablesDriverProbeStateMatch to virFirewall (Daniel P. Berrange) - Convert nwfilter ebiptablesApplyNewRules to virFirewall (Daniel P. Berrange) - Convert nwfilter ebtablesApplyDropAllRules to virFirewall (Daniel P. Berrange) - Convert nwfilter ebtablesApplyDHCPOnlyRules to virFirewall (Daniel P. Berrange) - Convert nwfilter ebtablesApplyBasicRules to virFirewall (Daniel P. Berrange) - Convert nwfilter ebiptablesTearNewRules to virFirewall (Daniel P. Berrange) - Convert nwfilter ebtablesRemoveBasicRules to virFirewall (Daniel P. Berrange) - Convert nwfilter ebiptablesTearOldRules to virFirewall (Daniel P. Berrange) - Convert nwfilter ebiptablesAllTeardown to virFirewall (Daniel P. Berrange) - Convert ebtables code over to use firewall APIs (Daniel P. Berrange) - Add test for converting network XML to iptables rules (Daniel P. Berrange) - Replace virNetworkObjPtr with virNetworkDefPtr in network platform APIs (Daniel P. Berrange) - Convert bridge driver over to use new firewall APIs (Daniel P. Berrange) - Introduce an object for managing firewall rulesets (Daniel P. Berrange) - Preserve error when tearing down nwfilter rules (Daniel P. Berrange) - Remove two-stage construction of commands in nwfilter (Daniel P. Berrange) - Merge nwfilter createRuleInstance driver into applyNewRules (Daniel P. Berrange) - Push virNWFilterRuleInstPtr out of (eb|ip)tablesCreateRuleInstance (Daniel P. Berrange) - Add helper methods for determining what protocol layer is used (Daniel P. Berrange) - Remove nwfilter tech driver 'displayRuleInstance' callback (Daniel P. Berrange) - Remove nwfilter tech driver 'removeRules' callback (Daniel P. Berrange) - Remove pointless storage of var names in virNWFilterHashTable (Daniel P. Berrange) - Remove virDomainNetType parameter from nwfilter drivers (Daniel P. Berrange) - Move virNWFilterTechDriver struct out of nwfilter_conf.h (Daniel P. Berrange) - Use virFileFindResource to locate CPU map XML (Daniel P. Berrange) - Use virFileFindResource to locate driver plugins (Daniel P. Berrange) - Use virFileFindResource to locate lock manager plugins (Daniel P. Berrange) - Use virFileFindResource to locate iohelper for fdstream (Nehal J Wani) - Use virFileFindResource to locate parthelper for storage backend (Nehal J Wani) - Use virFileFindResource to locate libvirt_lxc for capabilities (Nehal J Wani) - Use virFileFindResource to locate iohelper for virFileWrapperFdNew (Nehal J Wani) - Activate build dir overrides in libvirtd, virtlockd, virsh & tests (Daniel P. Berrange) - Add helpers for resolving path to resources in build tree (Daniel P. Berrange) - Add test suite for viralloc APIs (Daniel P. Berrange) - Add support for addressing backing stores by index (Jiri Denemark) - virStorageFileChainLookup: Return virStorageSourcePtr (Jiri Denemark) - qemuDomainBlockCommit: Track virStorageSourcePtr for base (Jiri Denemark) - qemuDomainBlockCommit: Don't track top_canon path separately (Jiri Denemark) - tests: Test backing store XML formatting and parsing (Jiri Denemark) - tests: More output options for xml2xml tests (Jiri Denemark) - conf: Format and parse backing chains in domain XML (Jiri Denemark) - conf: Output disk backing store details in domain XML (Jiri Denemark) - util: storage: Invert the way recursive metadata retrieval works (Peter Krempa) - util: virstoragefile: Don't mangle data stored about directories (Peter Krempa) - storage: Move disk->backingChain to the recursive disk->src.backingStore (Peter Krempa) - util: virstoragefile: Rename backingMeta to backingStore (Peter Krempa) - util: virstorage: Kill struct virStorageFileMetadata (Peter Krempa) - maint: Switch over from struct virStorageFileMetadata to virStorageSource (Peter Krempa) - util: storagefile: Add fields from virStorageMetadata to virStorageSource (Peter Krempa) - util: storagefile: Add function to free a virStorageSourcePtr (Peter Krempa) - virstoragefile: Kill "backingStore" field from virStorageFileMetadata (Peter Krempa) - util: virstoragefile: Don't use "backingStore" directly (Peter Krempa) - util: storagefile: Rename "canonPath" to "path" in virStorageFileMetadata (Peter Krempa) - util: storage: Rename "path" to "relPath" in virStorageFileMetadata (Peter Krempa) - storage: util: Clean up arguments of virStorageFileGetMetadataInternal (Peter Krempa) - util: storage: Move checking of the actual backing image to the worker (Peter Krempa) - util: storage: Remove obsolete argument virStorageFileGetMetadataInternal (Peter Krempa) - util: storagefile: Always store raw backing name in the metadata (Peter Krempa) - qemu: unexport qemuDiskChainCheckBroken (Peter Krempa) - bhyve: bhyveDomainDefineXML fixes (Roman Bogorodskiy) - PPC64 prefers to set pci-ohci controller as default USB controller (Li Zhang) - Make virDomainVcpuPinDel return void (Ján Tomko) - maint: update to latest gnulib (Eric Blake) - bhyve: domainCreateXML (Wojciech Macek) - Remove QEMU_CAPS_MACHINE_USB_OPT from ComputeCmdFlags (Ján Tomko) - conf: split <disk> schema into more pieces (Eric Blake) - conf: set up for per-grammar overrides in schemas (Eric Blake) - conf: restrict external snapshots to backing store formats (Eric Blake) - conf: move storage formats to common RNG file (Eric Blake) - conf: better <disk> interleaving in schema (Eric Blake) - conf: create common storage RNG grammar file (Eric Blake) - conf: delete internal directory field (Eric Blake) - conf: tweak chain lookup internals (Eric Blake) - conf: drop redundant parameter to chain lookup (Eric Blake) - conf: report error on chain lookup failure (Eric Blake) - util: new virFileRelLinkPointsTo function (Eric Blake) - conf: test backing chain lookup (Eric Blake) - Introduce --without-pm-utils to get rid of pm-is-supported dependency (Cédric Bosdonnat) - conf: delete useless backingStoreFormat field (Eric Blake) - conf: return backing information separately from metadata (Eric Blake) - conf: delete useless backingStoreIsFile field (Eric Blake) - conf: expose probe for non-local storage (Eric Blake) - conf: provide details on network backing store (Eric Blake) - conf: make virstoragetest debug easier (Eric Blake) - cpu: Properly check input parameters (Jiri Denemark) - Clean up virCgroupGetPercpuStats (Ján Tomko) - Rename id, max_id to need_cpus, total_cpus (Ján Tomko) - Extend virCgroupGetPercpuStats to fill in vcputime too (Ján Tomko) - Fix return value of virCgroupGetPercpuStats (Ján Tomko) - Don't require domain obj in qemuDomainGetPercpuStats (Ján Tomko) - conf: test for more fields (Eric Blake) - conf: start testing contents of the new backing chain fields (Eric Blake) - conf: track more fields in backing chain metadata (Eric Blake) - conf: rename some test fields (Eric Blake) - conf: earlier allocation during backing chain crawl (Eric Blake) - conf: track user vs. canonical name through full chain lookup (Eric Blake) - qemu: Unexport qemuBuildNetworkDriveURI() (Peter Krempa) - qemu: Refactor qemuGetDriveSourceString to take virStorageSourcePtr (Peter Krempa) - storage: Refactor location of metadata for storage drive access to files (Peter Krempa) - storage: Refactor storage file initialization to use virStorageSourcePtr (Peter Krempa) - conf: Refactor helpers to retrieve actual storage type (Peter Krempa) - tests: use virBhyveCapsBuild in bhyvexml2argv test (Roman Bogorodskiy) - conf: another refactor of virstoragetest (Eric Blake) - conf: interleave virstoragetest structs (Eric Blake) - conf: test for more scenarios (Eric Blake) - conf: fix detection of infinite backing loop (Eric Blake) - vmware: set the driver version (Jean-Baptiste Rouault) - tests: add bhyve xml2xml test (Roman Bogorodskiy) - bhyve: add domain metadata support (Roman Bogorodskiy) - bhyve: fix ATTRIBUTE_NONNULL usage (Roman Bogorodskiy) - Use a static initializer for static mutexes (Daniel P. Berrange) - Add syntax check to validate capitalization of abbreviations (Daniel P. Berrange) - Replace Pci with PCI throughout (Daniel P. Berrange) - Replace Usb with USB throughout (Daniel P. Berrange) - Replace Scsi with SCSI throughout (Daniel P. Berrange) - Switch systemd test to use generic dbus mock (Daniel P. Berrange) - Create a re-usable DBus LD_PRELOAD mock library (Daniel P. Berrange) - Introduce a new set of helper macros for mocking symbols (Daniel P. Berrange) - bhyve: connectCompareCPU support (Wojciech Macek) - bhyve: create capabilities submodule (Wojciech Macek) - bhyve: support for connectBaselineCPU (Wojciech Macek) - interface: dump inactive xml when interface isn't active (Laine Stump) - hash: add common utility functions (Eric Blake) - bhyve: add xml2argv tests for console (Roman Bogorodskiy) - bhyve: add console support through nmdm device (Roman Bogorodskiy) - bhyve: domain autostart support (David Shane Holden) - conf: track when storage type is still undetermined (Eric Blake) - tests: refactor virstoragetest for less stack space (Eric Blake) - tests: use C99 initialization for storage test (Eric Blake) - libxl: Set disk format for empty cdrom device (Stefan Bader) - libxl: Use id from virDomainObj inside the driver (Stefan Bader) - Add redirdevs to ABI stability check (Ján Tomko) - virsh: Make 'exit' action same as 'quit' (Li Yang) - Include PCI address in the error in virDomainNetFindIdx (Ján Tomko) - Move error reporting into virDomainNetFindIdx (Ján Tomko) - tests: simplify storage test cleanup (Eric Blake) - storage: Report error from VolOpen by default (Cole Robinson) - conf: modify tracking of encrypted images (Eric Blake) - conf: drop redundant parameters during probe (Eric Blake) - conf: track sizes directly in source struct (Eric Blake) - conf: use common struct in storage volumes (Eric Blake) - conf: move volume structs to util/ (Eric Blake) - conf: tweak volume target struct details (Eric Blake) - conf: manage disk source by struct instead of pieces (Eric Blake) - virsh: man: delete the unexpected character in snapshot-list (Shanzhi Yu) - maint: fix spelling errors in disk pools (Eric Blake) - conf: let snapshots share disk source struct (Eric Blake) - conf: move common disk source functions (Eric Blake) - util: don't support loopback and nbd when setuid (Eric Blake) - util: move detection of shared filesystems (Eric Blake) - conf: move storage source type to util/ (Eric Blake) - conf: move storage secret type to util/ (Eric Blake) - conf: move source pool type to util/ (Eric Blake) - conf: move storage encryption type to util/ (Eric Blake) - conf: move network disk protocol type to util/ (Eric Blake) - conf: move host disk type to util/ (Eric Blake) - conf: split network host structs to util/ (Eric Blake) - conf: split security label structs to util/ (Eric Blake) - maint: ensure src/ directory includes are clean (Eric Blake) - storage: gluster: Implement storage pool lookup (Peter Krempa) - storage: netfs: Support lookup of glusterfs pool sources (Peter Krempa) - storage: netfs: Split up and tidy up NFS storage pool source function (Peter Krempa) Cleanups: - tests: drop dead code from argv2xml and xml2xml (Eric Blake) - qemu: remove unneeded forward declaration (Martin Kletzander) Thanks everybody for your contributions to this release be it with ideas, report, patches, documentation or localizations ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] ANNOUNCE: libvirt 1.1.3.5 maintenance release
by Cole Robinson 03 May '14

03 May '14

libvirt 1.1.3.5 maintenance release is now available. This is libvirt 1.1.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.1.3.5.tar.gz Changes in this version: * qemu: Introduce qemuDomainDefCheckABIStability * interface: dump inactive xml when interface isn't active * interface: Introduce netcfInterfaceObjIsActive * Ignore additional fields in iscsiadm output * qemu: fix crash when removing <filterref> from interface with update- device * Only set QEMU_CAPS_NO_HPET on x86 * Fix journald PRIORITY values * qemu: make sure agent returns error when required data are missing * qemu: remove unneeded forward declaration * qemu: cleanup error checking on agent replies * Ignore char devices in storage pools by default * Ignore missing files on pool refresh * storage: reduce number of stat calls * Fix explicit usage of default video PCI slots * virNetClientSetTLSSession: Restore original signal mask * storage: use valid XML for awkward volume names * maint: fix comma style issues: conf * virNetServerRun: Notify systemd that we're accepting clients * libvirt-guests: Wait for libvirtd to initialize * virSystemdCreateMachine: Set dependencies for slices * Add Documentation fields to systemd service files * Add a mutex to serialize updates to firewall * virt-login-shell: also build virAtomic.h * Fix conflicting types of virInitctlSetRunLevel For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH 1/3] tests: Don't crash when creating the config object fails
by Guido Günther 03 May '14

03 May '14

As observed when building in a chroot and QEMU_USER doesn't exist --- tests/qemuargv2xmltest.c | 3 +++ tests/qemuxml2argvtest.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tests/qemuargv2xmltest.c b/tests/qemuargv2xmltest.c index 6d7e23e..4cc3749 100644 --- a/tests/qemuargv2xmltest.c +++ b/tests/qemuargv2xmltest.c @@ -128,6 +128,9 @@ mymain(void) int ret = 0; driver.config = virQEMUDriverConfigNew(false); + if (driver.config == NULL) + return EXIT_FAILURE; + if ((driver.caps = testQemuCapsInit()) == NULL) return EXIT_FAILURE; diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 56854dc..13ed4f6 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -501,6 +501,9 @@ mymain(void) } driver.config = virQEMUDriverConfigNew(true); + if (driver.config == NULL) + return EXIT_FAILURE; + VIR_FREE(driver.config->spiceListen); VIR_FREE(driver.config->vncListen); -- 1.9.1

4 17

[libvirt] [PATCH] Explicitly link virfirewalltest and virsystemdtest against dbus
by Guido Günther 03 May '14

03 May '14

This fixes link failures like: CCLD virfirewalltest /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to symbol 'dbus_message_iter_init_append' --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 7ffb44e..5ef8940 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -963,7 +963,7 @@ virmockdbus_la_LDFLAGS = -module -avoid-version \ virsystemdtest_SOURCES = \ virsystemdtest.c testutils.h testutils.c virsystemdtest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) -virsystemdtest_LDADD = $(LDADDS) +virsystemdtest_LDADD = $(LDADDS) $(DBUS_LIBS) else ! WITH_DBUS EXTRA_DIST += virdbustest.c virmockdbus.c virsystemdtest.c @@ -1047,7 +1047,7 @@ virfiletest_LDADD = $(LDADDS) virfirewalltest_SOURCES = \ virfirewalltest.c testutils.h testutils.c -virfirewalltest_LDADD = $(LDADDS) +virfirewalltest_LDADD = $(LDADDS) $(DBUS_LIBS) virfirewalltest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) jsontest_SOURCES = \ -- 1.9.2

2 2

[libvirt] CPU type/flags when converting a physical machine to run on libvirt
by Richard W.M. Jones 03 May '14

03 May '14

I'm in the process of rewriting virt-p2v which is our program for converting physical machines to become virtual machines, running on top of libvirt + KVM. The physical machine has certain characteristics -- eg: - number of physical cores - amount of RAM - CPU type (eg. AMD Opteron, Intel Core i7) - CPU flags (eg. ACPI, SSE4) which it might make sense to reflect in the libvirt XML of the virtual machine we create. The old version of virt-p2v is pretty simplistic about this. It generates *only* an i386 or x86-64 VM, and the only flags it considers are 'apic', 'acpi', 'pae' and 'lm' [the latter to distinguish between 32 and 64 bit x86]. What should the new version do? Particular questions: - Should we try to reflect the CPU type of the physical machine in the virtual machine? eg. If it's an Opteron, we generate an Opteron target machine. (I believe the answer is *no*, because this is not live migration, and most guests can boot on any compatible CPU). - How can I ask libvirt to give me the best possible CPU, and not some baseline? Normally I use host-model, but I think that prevents migration. - What CPU flags should be reflected in the target libvirt XML? - Is it worth modelling CPU thread layout? (I suspect this will be a lot of work with the potential to break things rather than provide any measurable benefits.) - Is there anything else I haven't thought about? However the overriding rule is: - We *must not* end up with a target virtual machine which doesn't work! Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v

2 4

[libvirt] Reg : failing to attach iscsi disk from virsh to running VM on xen
by Prapulla Kumar 02 May '14

02 May '14

Hi , For attaching iSCSI disk I have tried like this *iscsi target side :* * 1 created an iqn number* #tgtadm --lld iscsi --op new --mode target --tid 1 -T iqn.2009-06.com.eucalyptus.cluster1:store1 * 2. added one lun to it* #tgtadm --lld iscsi --op new --mode logicalunit --tid 1 --lun 1 -b /fs.iscsi.disk * 3.To enable the target to accept any initiators, enter:* #tgtadm --lld iscsi --op bind --mode target --tid 1 -I ALL * 4.To view the current configuration, enter:* #tgtadm --lld iscsi --op show --mode target *iscsi initaitor side (where libvirt and xen is running)* * 1. to** scan for the newly created target* * #*iscsiadm -m discovery -t sendtargets -p 192.168.53.14 * 2. created pool file * <pool type="iscsi"> <name>sample3</name> <source> <host name="192.168.53.14"/> <device path="iqn.2009-06.com.eucalyptus.cluster1:store1"/> </source> <target> <path>/dev/disk/by-path</path> </target> </pool> * 3.*#virsh pool-define sample_pool.xml #virsh pool-start sample3 then it created one link like this at */dev/disk/by-path/* *ip-192.168.53.14:3260-iscsi-iqn.2009-06.com.eucalyptus.cluster1:store1-lun-1 -> ../../sdb* 4. I have attached using virsh attach-disk #virsh attach-disk 1 /dev/sdb xvdb It is attached successfully , I console in vm I have checked . But while using with eucalyptus,It is not attching. I'm using eucalyptus 3.4.2 , libvirt 1.2.3 with xen4.3.1 to attach volume to vm . eucalyptus attaching volume is done through iscsi disk , intermediate files are created while attaching volume in xml format as below. *File 1:* <?xml version="1.0" encoding="UTF-8"?> <disk type="block"> <driver cache="none" name="phy"/> <source dev="/dev/disk/by-id/scsi-1IET_00230001"/> <target dev="sdf" bus="scsi"/> <serial>vol-759A3CDB-dev-sdf</serial> </disk> *File 2:* <?xml version="1.0" encoding="UTF-8"?> <volume> <hypervisor type="xen" capability="xen+hw" bitness="64"/> <id>vol-759A3CDB</id> <user>AIDOMCCNSP7YNR7IEZEUX</user> <instancePath>/usr/local/eucalyptus/work/AIDOMCCNSP7YNR7IEZEUX/i-ED153F84</instancePath> <os platform="linux" virtioRoot="false" virtioDisk="false" virtioNetwork="false"/> <backing> <root type="image"/> </backing> <diskPath targetDeviceType="disk" targetDeviceName="sdf" targetDeviceBus="scsi" sourceType="block" serial="vol-759A3CDB-dev-sdf">/dev/disk/by-id/scsi-1IET_00230001</diskPath> </volume> *in libvirtd.log i'm getting* *error : libxlDomainAttachDeviceDiskLive:2567 : unsupported configuration: disk bus 'scsi' cannot be hotplugged.* Can u suggest how to enable or patch to scsi hotplug from libvirt which support for xen. Can u say the meaning of PATCH 11/12 what is 11/12 means. eg ; [libvirt] [PATCH 11/12] Properly support SCSI drive hotplug With Regards Prapulla Kumar R

1 0

[libvirt] qemu: managedsave vs. save
by Richard Weinberger 02 May '14

02 May '14

Hi! My KVM hosts share the same filesystem and I'm facing an issue using managedsave. If I save vmX using managedsave on hostA and restore it later using "virsh restore" in hostB the qemu process consumes 100% CPU and makes no progress. On the other hand, if I save vmX using save the restore works fine on hostB. Why can't I restore vms saved by managedsave using restore? Or is this a known issue on libvirt-0.10.X (CentOS 6)? -- Thanks, //richard

3 9

[libvirt] [PATCHv2] storageVolCreateXMLFrom: Allow multiple accesses to origvol
by Michal Privoznik 02 May '14

02 May '14

When creating a new volume, it is possible to copy data into it from another already existing volume (referred to as @origvol). Obviously, the read-only access to @origvol is required, which is thread safe (probably not performance-wise though). However, with current code both @newvol and @origvol are marked as building for the time of copying data from the @origvol to @newvol. The rationale behind is to disallow some operations on both @origvol and @newvol, e.g. vol-wipe, vol-delete, vol-download. While it makes sense to not allow such operations on partly copied mirror, but it doesn't make sense to disallow the operations on the source (@origvol). Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Diff to v1: -introduced a counter in addition to not marking origvol as building src/conf/storage_conf.h | 1 + src/storage/storage_driver.c | 14 +++++++------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/conf/storage_conf.h b/src/conf/storage_conf.h index 9ad38e1..eae959c 100644 --- a/src/conf/storage_conf.h +++ b/src/conf/storage_conf.h @@ -64,6 +64,7 @@ struct _virStorageVolDef { int type; /* enum virStorageVolType */ unsigned int building; + unsigned int in_use; virStorageVolSource source; virStorageSource target; diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 2cb8347..a953dfd 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1640,7 +1640,7 @@ storageVolDelete(virStorageVolPtr obj, if (virStorageVolDeleteEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; - if (vol->building) { + if (vol->building || vol->in_use) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), vol->name); @@ -1912,8 +1912,8 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, /* Drop the pool lock during volume allocation */ pool->asyncjobs++; - origvol->building = 1; newvol->building = 1; + origvol->in_use++; virStoragePoolObjUnlock(pool); if (origpool) { @@ -1929,7 +1929,7 @@ storageVolCreateXMLFrom(virStoragePoolPtr obj, virStoragePoolObjLock(origpool); storageDriverUnlock(driver); - origvol->building = 0; + origvol->in_use--; newvol->building = 0; allocation = newvol->target.allocation; pool->asyncjobs--; @@ -2010,7 +2010,7 @@ storageVolDownload(virStorageVolPtr obj, if (virStorageVolDownloadEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; - if (vol->building) { + if (vol->building || vol->in_use) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), vol->name); @@ -2076,7 +2076,7 @@ storageVolUpload(virStorageVolPtr obj, if (virStorageVolUploadEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; - if (vol->building) { + if (vol->building || vol->in_use) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), vol->name); @@ -2167,7 +2167,7 @@ storageVolResize(virStorageVolPtr obj, if (virStorageVolResizeEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; - if (vol->building) { + if (vol->building || vol->in_use) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), vol->name); @@ -2474,7 +2474,7 @@ storageVolWipePattern(virStorageVolPtr obj, if (virStorageVolWipePatternEnsureACL(obj->conn, pool->def, vol) < 0) goto cleanup; - if (vol->building) { + if (vol->building || vol->in_use) { virReportError(VIR_ERR_OPERATION_INVALID, _("volume '%s' is still being allocated."), vol->name); -- 1.9.0

2 1

[libvirt] [PATCH] tests: skip virfirewalltest on non-Linux systems
by Roman Bogorodskiy 02 May '14

02 May '14

Currently firewalling is supported on Linux only, so skip the virfirewalltest on other platforms. --- tests/virfirewalltest.c | 58 +++++++++++++++++++++++++++++-------------------- 1 file changed, 35 insertions(+), 23 deletions(-) diff --git a/tests/virfirewalltest.c b/tests/virfirewalltest.c index 805fa44..af74d57 100644 --- a/tests/virfirewalltest.c +++ b/tests/virfirewalltest.c @@ -24,23 +24,26 @@ #define __VIR_COMMAND_PRIV_H_ALLOW__ #include "testutils.h" -#include "virbuffer.h" -#include "vircommandpriv.h" -#include "virfirewallpriv.h" -#include "virmock.h" -#include "virdbuspriv.h" -#define VIR_FROM_THIS VIR_FROM_FIREWALL +#if defined(__linux__) -#if WITH_DBUS -# include <dbus/dbus.h> -#endif +# include "virbuffer.h" +# include "vircommandpriv.h" +# include "virfirewallpriv.h" +# include "virmock.h" +# include "virdbuspriv.h" + +# define VIR_FROM_THIS VIR_FROM_FIREWALL + +# if WITH_DBUS +# include <dbus/dbus.h> +# endif static bool fwDisabled = true; static virBufferPtr fwBuf; static bool fwError; -#define TEST_FILTER_TABLE_LIST \ +# define TEST_FILTER_TABLE_LIST \ "Chain INPUT (policy ACCEPT)\n" \ "target prot opt source destination\n" \ "\n" \ @@ -50,7 +53,7 @@ static bool fwError; "Chain OUTPUT (policy ACCEPT)\n" \ "target prot opt source destination\n" -#define TEST_NAT_TABLE_LIST \ +# define TEST_NAT_TABLE_LIST \ "Chain PREROUTING (policy ACCEPT)\n" \ "target prot opt source destination\n" \ "\n" \ @@ -63,7 +66,7 @@ static bool fwError; "Chain POSTROUTING (policy ACCEPT)\n" \ "target prot opt source destination\n" -#if WITH_DBUS +# if WITH_DBUS VIR_MOCK_IMPL_RET_ARGS(dbus_connection_send_with_reply_and_block, DBusMessage *, DBusConnection *, connection, @@ -186,7 +189,7 @@ VIR_MOCK_IMPL_RET_ARGS(dbus_connection_send_with_reply_and_block, goto cleanup; } -#endif +# endif struct testFirewallData { virFirewallBackend tryBackend; @@ -1126,7 +1129,7 @@ mymain(void) { int ret = 0; -#define RUN_TEST_DIRECT(name, method) \ +# define RUN_TEST_DIRECT(name, method) \ do { \ struct testFirewallData data; \ data.tryBackend = VIR_FIREWALL_BACKEND_AUTOMATIC; \ @@ -1141,8 +1144,8 @@ mymain(void) ret = -1; \ } while (0) -#if WITH_DBUS -# define RUN_TEST_FIREWALLD(name, method) \ +# if WITH_DBUS +# define RUN_TEST_FIREWALLD(name, method) \ do { \ struct testFirewallData data; \ data.tryBackend = VIR_FIREWALL_BACKEND_AUTOMATIC; \ @@ -1157,13 +1160,13 @@ mymain(void) ret = -1; \ } while (0) -# define RUN_TEST(name, method) \ +# define RUN_TEST(name, method) \ RUN_TEST_DIRECT(name, method); \ RUN_TEST_FIREWALLD(name, method) -#else /* ! WITH_DBUS */ -# define RUN_TEST(name, method) \ +# else /* ! WITH_DBUS */ +# define RUN_TEST(name, method) \ RUN_TEST_DIRECT(name, method) -#endif /* ! WITH_DBUS */ +# endif /* ! WITH_DBUS */ RUN_TEST("single group", testFirewallSingleGroup); RUN_TEST("remove rule", testFirewallRemoveRule); @@ -1179,8 +1182,17 @@ mymain(void) return ret == 0 ? EXIT_SUCCESS : EXIT_FAILURE; } -#if WITH_DBUS +# if WITH_DBUS VIRT_TEST_MAIN_PRELOAD(mymain, abs_builddir "/.libs/virmockdbus.so") -#else +# else VIRT_TEST_MAIN(mymain) -#endif +# endif + +#else /* ! defined (__linux__) */ + +int main(void) +{ + return EXIT_AM_SKIP; +} + +#endif /* ! defined(__linux__) */ -- 1.9.0

5 8