- Devel - libvirt List Archives

[libvirt PATCH] virt-aa-helper: replace usage of magic constant
by Pavel Hrdina 29 Jan '26

29 Jan '26

From: Pavel Hrdina <phrdina(a)redhat.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- I wonder if we should just drop that argument and use QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH inside the function directly as the only remaining caller with different value is from virstoragetest.c src/security/virt-aa-helper.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 211c34f926..443646c0a1 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -901,12 +901,12 @@ get_files(vahControl * ctl) continue; /* XXX - if we knew the qemu user:group here we could send it in * so that the open could be re-tried as that user:group. - * - * The maximum depth is limited to 200 layers similarly to the qemu - * implementation. */ - if (!disk->src->backingStore) - virStorageSourceGetMetadata(disk->src, -1, -1, 200, false); + if (!disk->src->backingStore) { + virStorageSourceGetMetadata(disk->src, -1, -1, + QEMU_DOMAIN_STORAGE_SOURCE_CHAIN_MAX_DEPTH, + false); + } /* XXX should handle open errors more careful than just ignoring them. */ -- 2.52.0

3 5

[PATCH] ci: regenerate with 'lcitool manifest'
by Michal Privoznik 29 Jan '26

29 Jan '26

From: Michal Privoznik <mprivozn(a)redhat.com> Update Alpine to 3.23. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- ci/buildenv/{alpine-322.sh => alpine-323.sh} | 0 .../{alpine-322.Dockerfile => alpine-323.Dockerfile} | 2 +- ci/gitlab/builds.yml | 8 ++++---- ci/gitlab/containers.yml | 4 ++-- ci/manifest.yml | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) rename ci/buildenv/{alpine-322.sh => alpine-323.sh} (100%) rename ci/containers/{alpine-322.Dockerfile => alpine-323.Dockerfile} (98%) diff --git a/ci/buildenv/alpine-322.sh b/ci/buildenv/alpine-323.sh similarity index 100% rename from ci/buildenv/alpine-322.sh rename to ci/buildenv/alpine-323.sh diff --git a/ci/containers/alpine-322.Dockerfile b/ci/containers/alpine-323.Dockerfile similarity index 98% rename from ci/containers/alpine-322.Dockerfile rename to ci/containers/alpine-323.Dockerfile index e3672a9788..ee1f194808 100644 --- a/ci/containers/alpine-322.Dockerfile +++ b/ci/containers/alpine-323.Dockerfile @@ -4,7 +4,7 @@ # # https://gitlab.com/libvirt/libvirt-ci -FROM docker.io/library/alpine:3.22 +FROM docker.io/library/alpine:3.23 RUN apk update && \ apk upgrade && \ diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index fe1468ff81..7e671b7d99 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -59,15 +59,15 @@ x86_64-almalinux-10-clang: TARGET_BASE_IMAGE: docker.io/library/almalinux:10 -x86_64-alpine-322: +x86_64-alpine-323: extends: .native_build_job needs: - - job: x86_64-alpine-322-container + - job: x86_64-alpine-323-container optional: true allow_failure: false variables: - NAME: alpine-322 - TARGET_BASE_IMAGE: docker.io/library/alpine:3.22 + NAME: alpine-323 + TARGET_BASE_IMAGE: docker.io/library/alpine:3.23 x86_64-alpine-edge: diff --git a/ci/gitlab/containers.yml b/ci/gitlab/containers.yml index 56b974f2a1..1fbf11b21a 100644 --- a/ci/gitlab/containers.yml +++ b/ci/gitlab/containers.yml @@ -21,11 +21,11 @@ x86_64-almalinux-10-container: NAME: almalinux-10 -x86_64-alpine-322-container: +x86_64-alpine-323-container: extends: .container_job allow_failure: false variables: - NAME: alpine-322 + NAME: alpine-323 x86_64-alpine-edge-container: diff --git a/ci/manifest.yml b/ci/manifest.yml index 2fdb764142..a673f0c413 100644 --- a/ci/manifest.yml +++ b/ci/manifest.yml @@ -32,7 +32,7 @@ targets: RPM: skip CC: clang - alpine-322: x86_64 + alpine-323: x86_64 alpine-edge: jobs: -- 2.52.0

2 1

[PATCH 0/5] qemu: migration: Always try to migrate block dirty bitmaps
by Peter Krempa 29 Jan '26

29 Jan '26

Try to migrate them always when they are not present in the destination image. While this has no change if they are present and on shared filesystem it does allow migrating them when the filesystem is not shared but we're not migrating storage. This is a special case for qcow2 overlay with data_file feature. The code uses the existing logic for offering and accepting bitmaps, just fixed a bug and enables the code for all kinds of migration. See 5/5 for more in-depth description. Peter Krempa (5): qemublocktest: Iterate all nodenames in 'testQemuDetectBitmaps' qemu: monitor: Detect list of bitmaps from 'qcow2' format specific data qemuMigrationDstPrepareAnyBlockDirtyBitmaps: Fix check for existing bitmaps qemu: migration: Always offer block dirty bitmaps during migration qemuMigrationDstPrepareAnyBlockDirtyBitmaps: Always consider offered bitmaps src/qemu/qemu_migration.c | 54 ++++++------------- src/qemu/qemu_monitor.h | 4 ++ src/qemu/qemu_monitor_json.c | 17 ++++++ tests/qemublocktest.c | 35 ++++++------ tests/qemublocktestdata/bitmap/basic.out | 1 + tests/qemublocktestdata/bitmap/empty.out | 1 + .../bitmap/snapshots-internal.out | 7 +++ tests/qemublocktestdata/bitmap/snapshots.out | 10 ++++ tests/qemublocktestdata/bitmap/synthetic.out | 9 ++++ 9 files changed, 86 insertions(+), 52 deletions(-) -- 2.52.0

2 7

[PATCH 00/20] tests: Join networkxml2xmltest and networkxml2conftest into one
by Michal Privoznik 29 Jan '26

29 Jan '26

This was inspired by seemingly unrelated patches I've sent a month ago: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/WVTY… I was adding one attribute to an element and had to change three different test XMLs. Anyway, this is also available here: https://gitlab.com/MichalPrivoznik/libvirt/-/tree/network_tests?ref_type=he… Michal Prívozník (20): tests: Avoid crossdir inclusion for networkxml2* tests network: Separate private APIs declaration to bridge_driver_priv.h network: Move decision on dnsmasq need into a separate function networkxml2conftest: Drop routed-network-no-dns test case networkxml2conftest: Fail tests where no dnsmasq would be spawned networkxml2xmltest: Update couple of test cases network: Introduce networkValidateTests() test: wire up networkValidateTests() networkxml2conftest: Avoid potential leak networkxml2conftest: Allow regenerating hosts file networkxml2conftest: Allow regenerating more in one run networkxml2xmltest: Don't recreate xmlopt object networkxml2xmltest: Introduce testRun() networkxml2xmltest: Move path generation into testRun() networkxml2xmltest: Dynamically allocate testInfo struct networkxml2xmltest: Store parsed def for future tests networkxml2xmltest: Sync test cases with networkxml2conftest networkxml2xmltest: Do conf test tests: Drop networkxml2conftest tests: Rename networkxml2xmltest to networkxmlconftest src/network/bridge_driver.c | 62 ++++- src/network/bridge_driver.h | 15 - .../{bridge_driver.h => bridge_driver_priv.h} | 33 +-- tests/meson.build | 5 +- .../networkxml2confdata/isolated-network.xml | 11 - .../nat-network-dns-hosts.xml | 15 - tests/networkxml2confdata/nat-network-mtu.xml | 22 -- tests/networkxml2confdata/nat-network.xml | 21 -- tests/networkxml2confdata/netboot-network.xml | 14 - .../netboot-proxy-network.xml | 13 - tests/networkxml2confdata/open-network.xml | 9 - tests/networkxml2confdata/routed-network.xml | 9 - tests/networkxml2conftest.c | 200 -------------- tests/networkxml2firewalltest.c | 12 +- tests/networkxml2xmlin/dnsmasq-options.xml | 15 - tests/networkxml2xmlin/hostdev.xml | 10 - tests/networkxml2xmlin/leasetime-hours.xml | 1 - tests/networkxml2xmlin/leasetime-infinite.xml | 1 - tests/networkxml2xmlin/leasetime-minutes.xml | 1 - tests/networkxml2xmlin/leasetime-seconds.xml | 1 - .../nat-network-dns-forward-plain.xml | 9 - .../nat-network-dns-forwarders.xml | 14 - .../nat-network-dns-srv-record.xml | 26 -- .../nat-network-dns-txt-record.xml | 24 -- tests/networkxml2xmlin/netboot-tftp.xml | 1 - .../routed-network-no-dns.xml | 10 - tests/networkxml2xmlout/hostdev.xml | 10 - tests/networkxml2xmlout/leasetime-hours.xml | 1 - .../networkxml2xmlout/leasetime-infinite.xml | 1 - tests/networkxml2xmlout/leasetime-minutes.xml | 1 - tests/networkxml2xmlout/leasetime-seconds.xml | 1 - .../nat-network-dns-forwarder-no-resolv.xml | 11 - tests/networkxml2xmlout/netboot-tftp.xml | 1 - .../passthrough-address-crash.xml | 7 - tests/networkxml2xmlout/passthrough-pf.xml | 9 - .../srv-record-protocol.xml | 2 +- .../nat-network-dns-hosts-modified.xml | 1 + .../nat-network-dns-more-hosts.xml | 1 + .../nat-network-dns-srv-records.xml | 6 + .../nat-network-forward-ifaces.xml | 6 + .../nat-network-no-forward-ifaces.xml | 6 + .../nat-network-no-hosts.xml | 1 + tests/networkxml2xmlupdateout/nat-network.xml | 8 + .../openvswitch-net-modified.xml | 4 +- .../openvswitch-net-more-portgroups.xml | 6 +- .../openvswitch-net-without-alice.xml | 4 +- tests/networkxml2xmlupdatetest.c | 2 +- .../8021Qbh-net.expect.xml} | 3 - .../8021Qbh-net.xml | 3 - .../bandwidth-network.conf} | 10 +- .../bandwidth-network.expect.xml} | 0 .../bandwidth-network.xml | 0 .../dhcp6-nat-network.conf | 0 .../dhcp6-nat-network.expect.xml} | 16 +- .../dhcp6-nat-network.hostsfile | 0 .../dhcp6-nat-network.xml | 0 .../dhcp6-network.conf | 0 .../dhcp6-network.expect.xml} | 5 +- .../dhcp6-network.hostsfile | 0 .../dhcp6-network.xml | 0 .../dhcp6host-routed-network.conf | 0 .../dhcp6host-routed-network.expect.xml} | 0 .../dhcp6host-routed-network.hostsfile | 0 .../dhcp6host-routed-network.xml | 0 .../direct-net.expect.xml} | 0 .../direct-net.xml | 0 .../dnsmasq-options.conf | 0 .../dnsmasq-options.expect.xml} | 1 + .../dnsmasq-options.xml | 0 .../empty-allow-ipv6.expect.xml} | 0 .../empty-allow-ipv6.xml | 0 .../host-bridge-net.expect.xml} | 0 .../host-bridge-net.xml | 0 .../host-bridge-no-flood.expect.xml} | 0 .../host-bridge-no-flood.xml | 0 .../hostdev-duplicate.xml | 0 .../hostdev-pf-driver-model.expect.xml} | 0 .../hostdev-pf-driver-model.xml | 0 .../hostdev-pf.expect.xml} | 0 .../hostdev-pf.xml | 0 .../hostdev.expect.xml} | 4 +- .../hostdev.xml} | 4 +- .../isolated-network.conf | 0 .../isolated-network.expect.xml} | 0 .../isolated-network.xml | 0 .../isolated-ports.expect.xml} | 0 .../isolated-ports.xml | 0 .../leasetime-hours.conf | 0 .../leasetime-hours.expect.xml | 1 + .../leasetime-hours.hostsfile | 0 .../leasetime-hours.xml | 1 + .../leasetime-infinite.conf | 0 .../leasetime-infinite.expect.xml | 1 + .../leasetime-infinite.hostsfile | 0 .../leasetime-infinite.xml | 1 + .../leasetime-minutes.conf | 0 .../leasetime-minutes.expect.xml | 1 + .../leasetime-minutes.hostsfile | 0 .../leasetime-minutes.xml | 1 + .../leasetime-seconds.conf | 0 .../leasetime-seconds.expect.xml | 1 + .../leasetime-seconds.hostsfile | 0 .../leasetime-seconds.xml | 1 + .../metadata.expect.xml} | 0 .../metadata.xml | 0 .../nat-network-dns-forward-plain.conf | 0 .../nat-network-dns-forward-plain.expect.xml} | 1 + .../nat-network-dns-forward-plain.xml | 0 .../nat-network-dns-forwarder-no-resolv.conf | 0 ...etwork-dns-forwarder-no-resolv.expect.xml} | 1 + .../nat-network-dns-forwarder-no-resolv.xml | 0 .../nat-network-dns-forwarders.conf | 0 .../nat-network-dns-forwarders.expect.xml} | 4 +- .../nat-network-dns-forwarders.xml | 2 +- .../nat-network-dns-hosts.conf | 0 .../nat-network-dns-hosts.expect.xml} | 2 + .../nat-network-dns-hosts.xml | 1 + .../nat-network-dns-local-domain.conf | 0 .../nat-network-dns-local-domain.expect.xml} | 3 +- .../nat-network-dns-local-domain.xml | 0 .../nat-network-dns-srv-record-minimal.conf | 2 +- ...network-dns-srv-record-minimal.expect.xml} | 3 +- ...t-network-dns-srv-record-minimal.hostsfile | 0 .../nat-network-dns-srv-record-minimal.xml | 2 +- .../nat-network-dns-srv-record.conf | 2 +- .../nat-network-dns-srv-record.expect.xml} | 7 + .../nat-network-dns-srv-record.hostsfile | 0 .../nat-network-dns-srv-record.xml | 2 +- .../nat-network-dns-srv-records.conf} | 2 + .../nat-network-dns-srv-records.expect.xml} | 1 + .../nat-network-dns-srv-records.hostsfile} | 0 .../nat-network-dns-srv-records.xml | 0 .../nat-network-dns-txt-record.conf | 0 .../nat-network-dns-txt-record.expect.xml} | 1 + .../nat-network-dns-txt-record.hostsfile | 0 .../nat-network-dns-txt-record.xml | 0 .../nat-network-explicit-flood.conf} | 0 .../nat-network-explicit-flood.expect.xml} | 1 + .../nat-network-explicit-flood.hostsfile} | 0 .../nat-network-explicit-flood.xml | 0 .../nat-network-forward-nat-address.conf} | 0 ...at-network-forward-nat-address.expect.xml} | 1 + ...nat-network-forward-nat-address.hostsfile} | 0 .../nat-network-forward-nat-address.xml | 0 .../nat-network-forward-nat-ipv6.conf} | 2 +- .../nat-network-forward-nat-ipv6.expect.xml} | 1 + .../nat-network-forward-nat-ipv6.xml | 0 .../nat-network-forward-nat-no-address.conf} | 0 ...network-forward-nat-no-address.expect.xml} | 1 + ...-network-forward-nat-no-address.hostsfile} | 0 .../nat-network-forward-nat-no-address.xml | 0 .../nat-network-mtu.conf | 0 .../nat-network-mtu.expect.xml} | 1 + .../nat-network-mtu.hostsfile | 0 .../nat-network-mtu.xml | 0 .../nat-network-name-with-quotes.conf | 0 .../nat-network-name-with-quotes.expect.xml} | 3 +- .../nat-network-name-with-quotes.hostsfile | 0 .../nat-network-name-with-quotes.xml | 0 .../nat-network.conf | 0 .../nat-network.expect.xml} | 1 + .../nat-network.hostsfile | 0 .../nat-network.xml | 0 .../netboot-network.conf | 0 .../netboot-network.expect.xml} | 1 + .../netboot-network.xml | 0 .../netboot-proxy-network.conf | 0 .../netboot-proxy-network.expect.xml} | 1 + .../netboot-proxy-network.xml | 0 .../netboot-tftp.conf | 0 .../netboot-tftp.expect.xml | 1 + .../netboot-tftp.xml | 1 + .../open-network-with-forward-dev.xml | 0 .../open-network.conf | 0 .../open-network.expect.xml} | 0 .../open-network.xml | 0 .../openvswitch-net.expect.xml} | 6 +- .../openvswitch-net.xml | 6 +- .../passthrough-address-crash.xml | 0 .../passthrough-duplicate.xml | 0 .../passthrough-pf.conf} | 4 +- .../passthrough-pf.xml | 0 .../ptr-domains-auto.conf | 0 .../ptr-domains-auto.expect.xml} | 10 +- .../ptr-domains-auto.hostsfile | 0 .../ptr-domains-auto.xml | 0 .../routed-network-no-dns-extra-elements.xml | 0 .../routed-network-no-dns.expect.xml} | 0 .../routed-network-no-dns.xml | 0 .../routed-network.conf | 0 .../routed-network.expect.xml} | 0 .../routed-network.xml | 0 .../set-mtu.conf} | 1 + .../set-mtu.expect.xml} | 0 .../set-mtu.xml | 0 .../vepa-net.expect.xml} | 0 .../vepa-net.xml | 0 ...workxml2xmltest.c => networkxmlconftest.c} | 256 +++++++++++++++--- tests/qemuxmlconftest.c | 6 +- tests/virschematest.c | 4 +- 200 files changed, 414 insertions(+), 627 deletions(-) copy src/network/{bridge_driver.h => bridge_driver_priv.h} (33%) delete mode 100644 tests/networkxml2confdata/isolated-network.xml delete mode 100644 tests/networkxml2confdata/nat-network-dns-hosts.xml delete mode 100644 tests/networkxml2confdata/nat-network-mtu.xml delete mode 100644 tests/networkxml2confdata/nat-network.xml delete mode 100644 tests/networkxml2confdata/netboot-network.xml delete mode 100644 tests/networkxml2confdata/netboot-proxy-network.xml delete mode 100644 tests/networkxml2confdata/open-network.xml delete mode 100644 tests/networkxml2confdata/routed-network.xml delete mode 100644 tests/networkxml2conftest.c delete mode 100644 tests/networkxml2xmlin/dnsmasq-options.xml delete mode 100644 tests/networkxml2xmlin/hostdev.xml delete mode 120000 tests/networkxml2xmlin/leasetime-hours.xml delete mode 120000 tests/networkxml2xmlin/leasetime-infinite.xml delete mode 120000 tests/networkxml2xmlin/leasetime-minutes.xml delete mode 120000 tests/networkxml2xmlin/leasetime-seconds.xml delete mode 100644 tests/networkxml2xmlin/nat-network-dns-forward-plain.xml delete mode 100644 tests/networkxml2xmlin/nat-network-dns-forwarders.xml delete mode 100644 tests/networkxml2xmlin/nat-network-dns-srv-record.xml delete mode 100644 tests/networkxml2xmlin/nat-network-dns-txt-record.xml delete mode 120000 tests/networkxml2xmlin/netboot-tftp.xml delete mode 100644 tests/networkxml2xmlin/routed-network-no-dns.xml delete mode 100644 tests/networkxml2xmlout/hostdev.xml delete mode 120000 tests/networkxml2xmlout/leasetime-hours.xml delete mode 120000 tests/networkxml2xmlout/leasetime-infinite.xml delete mode 120000 tests/networkxml2xmlout/leasetime-minutes.xml delete mode 120000 tests/networkxml2xmlout/leasetime-seconds.xml delete mode 100644 tests/networkxml2xmlout/nat-network-dns-forwarder-no-resolv.xml delete mode 120000 tests/networkxml2xmlout/netboot-tftp.xml delete mode 100644 tests/networkxml2xmlout/passthrough-address-crash.xml delete mode 100644 tests/networkxml2xmlout/passthrough-pf.xml rename tests/{networkxml2xmlout/8021Qbh-net.xml => networkxmlconfdata/8021Qbh-net.expect.xml} (90%) rename tests/{networkxml2xmlin => networkxmlconfdata}/8021Qbh-net.xml (90%) copy tests/{networkxml2confdata/leasetime-hours.conf => networkxmlconfdata/bandwidth-network.conf} (61%) rename tests/{networkxml2xmlout/bandwidth-network.xml => networkxmlconfdata/bandwidth-network.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/bandwidth-network.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6-nat-network.conf (100%) rename tests/{networkxml2confdata/dhcp6host-routed-network.xml => networkxmlconfdata/dhcp6-nat-network.expect.xml} (65%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6-nat-network.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6-nat-network.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6-network.conf (100%) copy tests/{networkxml2confdata/dhcp6-network.xml => networkxmlconfdata/dhcp6-network.expect.xml} (87%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6-network.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6-network.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6host-routed-network.conf (100%) rename tests/{networkxml2xmlout/dhcp6host-routed-network.xml => networkxmlconfdata/dhcp6host-routed-network.expect.xml} (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/dhcp6host-routed-network.hostsfile (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/dhcp6host-routed-network.xml (100%) rename tests/{networkxml2xmlout/direct-net.xml => networkxmlconfdata/direct-net.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/direct-net.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/dnsmasq-options.conf (100%) rename tests/{networkxml2xmlout/dnsmasq-options.xml => networkxmlconfdata/dnsmasq-options.expect.xml} (94%) rename tests/{networkxml2confdata => networkxmlconfdata}/dnsmasq-options.xml (100%) rename tests/{networkxml2xmlout/empty-allow-ipv6.xml => networkxmlconfdata/empty-allow-ipv6.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/empty-allow-ipv6.xml (100%) rename tests/{networkxml2xmlout/host-bridge-net.xml => networkxmlconfdata/host-bridge-net.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/host-bridge-net.xml (100%) rename tests/{networkxml2xmlout/host-bridge-no-flood.xml => networkxmlconfdata/host-bridge-no-flood.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/host-bridge-no-flood.xml (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/hostdev-duplicate.xml (100%) rename tests/{networkxml2xmlin/hostdev-pf-driver-model.xml => networkxmlconfdata/hostdev-pf-driver-model.expect.xml} (100%) copy tests/{networkxml2xmlout => networkxmlconfdata}/hostdev-pf-driver-model.xml (100%) rename tests/{networkxml2xmlin/hostdev-pf.xml => networkxmlconfdata/hostdev-pf.expect.xml} (100%) rename tests/{networkxml2xmlout => networkxmlconfdata}/hostdev-pf.xml (100%) copy tests/{networkxml2xmlout/hostdev-pf-driver-model.xml => networkxmlconfdata/hostdev.expect.xml} (48%) rename tests/{networkxml2xmlout/hostdev-pf-driver-model.xml => networkxmlconfdata/hostdev.xml} (48%) copy tests/{networkxml2confdata => networkxmlconfdata}/isolated-network.conf (100%) rename tests/{networkxml2xmlout/isolated-network.xml => networkxmlconfdata/isolated-network.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/isolated-network.xml (100%) rename tests/{networkxml2xmlout/isolated-ports.xml => networkxmlconfdata/isolated-ports.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/isolated-ports.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-hours.conf (100%) create mode 120000 tests/networkxmlconfdata/leasetime-hours.expect.xml rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-hours.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-hours.xml (94%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-infinite.conf (100%) create mode 120000 tests/networkxmlconfdata/leasetime-infinite.expect.xml rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-infinite.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-infinite.xml (94%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-minutes.conf (100%) create mode 120000 tests/networkxmlconfdata/leasetime-minutes.expect.xml rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-minutes.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-minutes.xml (94%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-seconds.conf (100%) create mode 120000 tests/networkxmlconfdata/leasetime-seconds.expect.xml rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-seconds.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/leasetime-seconds.xml (94%) rename tests/{networkxml2xmlout/metadata.xml => networkxmlconfdata/metadata.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/metadata.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-forward-plain.conf (100%) copy tests/{networkxml2xmlout/nat-network-dns-forward-plain.xml => networkxmlconfdata/nat-network-dns-forward-plain.expect.xml} (89%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-forward-plain.xml (100%) copy tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-forwarder-no-resolv.conf (100%) rename tests/{networkxml2xmlin/nat-network-dns-forwarder-no-resolv.xml => networkxmlconfdata/nat-network-dns-forwarder-no-resolv.expect.xml} (89%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-forwarder-no-resolv.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-forwarders.conf (100%) rename tests/{networkxml2xmlout/nat-network-dns-forwarders.xml => networkxmlconfdata/nat-network-dns-forwarders.expect.xml} (71%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-forwarders.xml (90%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-hosts.conf (100%) rename tests/{networkxml2xmlout/nat-network-dns-hosts.xml => networkxmlconfdata/nat-network-dns-hosts.expect.xml} (91%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network-dns-hosts.xml (95%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-local-domain.conf (100%) rename tests/{networkxml2xmlout/nat-network-dns-forward-plain.xml => networkxmlconfdata/nat-network-dns-local-domain.expect.xml} (76%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-local-domain.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-srv-record-minimal.conf (93%) rename tests/{networkxml2xmlout/nat-network-dns-srv-record-minimal.xml => networkxmlconfdata/nat-network-dns-srv-record-minimal.expect.xml} (88%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-srv-record-minimal.hostsfile (100%) copy tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-srv-record-minimal.xml (92%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-srv-record.conf (93%) rename tests/{networkxml2xmlout/nat-network-dns-srv-record.xml => networkxmlconfdata/nat-network-dns-srv-record.expect.xml} (58%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-srv-record.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-srv-record.xml (91%) copy tests/{networkxml2confdata/nat-network.conf => networkxmlconfdata/nat-network-dns-srv-records.conf} (90%) rename tests/{networkxml2xmlout/nat-network-dns-srv-records.xml => networkxmlconfdata/nat-network-dns-srv-records.expect.xml} (96%) copy tests/{networkxml2confdata/nat-network-dns-txt-record.hostsfile => networkxmlconfdata/nat-network-dns-srv-records.hostsfile} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network-dns-srv-records.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-txt-record.conf (100%) rename tests/{networkxml2xmlout/nat-network-dns-txt-record.xml => networkxmlconfdata/nat-network-dns-txt-record.expect.xml} (95%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-txt-record.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-dns-txt-record.xml (100%) copy tests/{networkxml2confdata/nat-network.conf => networkxmlconfdata/nat-network-explicit-flood.conf} (100%) rename tests/{networkxml2xmlout/nat-network-explicit-flood.xml => networkxmlconfdata/nat-network-explicit-flood.expect.xml} (95%) copy tests/{networkxml2confdata/nat-network-mtu.hostsfile => networkxmlconfdata/nat-network-explicit-flood.hostsfile} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network-explicit-flood.xml (100%) copy tests/{networkxml2confdata/nat-network.conf => networkxmlconfdata/nat-network-forward-nat-address.conf} (100%) rename tests/{networkxml2xmlout/nat-network-forward-nat-address.xml => networkxmlconfdata/nat-network-forward-nat-address.expect.xml} (96%) copy tests/{networkxml2confdata/nat-network-name-with-quotes.hostsfile => networkxmlconfdata/nat-network-forward-nat-address.hostsfile} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network-forward-nat-address.xml (100%) rename tests/{networkxml2confdata/nat-network-dns-forwarder-no-resolv.conf => networkxmlconfdata/nat-network-forward-nat-ipv6.conf} (90%) rename tests/{networkxml2xmlout/nat-network-forward-nat-ipv6.xml => networkxmlconfdata/nat-network-forward-nat-ipv6.expect.xml} (88%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network-forward-nat-ipv6.xml (100%) copy tests/{networkxml2confdata/nat-network.conf => networkxmlconfdata/nat-network-forward-nat-no-address.conf} (100%) rename tests/{networkxml2xmlout/nat-network-forward-nat-no-address.xml => networkxmlconfdata/nat-network-forward-nat-no-address.expect.xml} (95%) copy tests/{networkxml2confdata/nat-network.hostsfile => networkxmlconfdata/nat-network-forward-nat-no-address.hostsfile} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network-forward-nat-no-address.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-mtu.conf (100%) rename tests/{networkxml2xmlout/nat-network-mtu.xml => networkxmlconfdata/nat-network-mtu.expect.xml} (95%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-mtu.hostsfile (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network-mtu.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-name-with-quotes.conf (100%) rename tests/{networkxml2confdata/nat-network-dns-srv-record-minimal.xml => networkxmlconfdata/nat-network-name-with-quotes.expect.xml} (90%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-name-with-quotes.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network-name-with-quotes.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network.conf (100%) rename tests/{networkxml2xmlout/nat-network.xml => networkxmlconfdata/nat-network.expect.xml} (95%) rename tests/{networkxml2confdata => networkxmlconfdata}/nat-network.hostsfile (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/nat-network.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/netboot-network.conf (100%) rename tests/{networkxml2xmlout/netboot-network.xml => networkxmlconfdata/netboot-network.expect.xml} (91%) rename tests/{networkxml2xmlin => networkxmlconfdata}/netboot-network.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/netboot-proxy-network.conf (100%) rename tests/{networkxml2xmlout/netboot-proxy-network.xml => networkxmlconfdata/netboot-proxy-network.expect.xml} (91%) rename tests/{networkxml2xmlin => networkxmlconfdata}/netboot-proxy-network.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/netboot-tftp.conf (100%) create mode 120000 tests/networkxmlconfdata/netboot-tftp.expect.xml rename tests/{networkxml2confdata => networkxmlconfdata}/netboot-tftp.xml (87%) rename tests/{networkxml2xmlin => networkxmlconfdata}/open-network-with-forward-dev.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/open-network.conf (100%) rename tests/{networkxml2xmlout/open-network.xml => networkxmlconfdata/open-network.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/open-network.xml (100%) rename tests/{networkxml2xmlin/openvswitch-net.xml => networkxmlconfdata/openvswitch-net.expect.xml} (87%) rename tests/{networkxml2xmlout => networkxmlconfdata}/openvswitch-net.xml (87%) rename tests/{networkxml2xmlin => networkxmlconfdata}/passthrough-address-crash.xml (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/passthrough-duplicate.xml (100%) rename tests/{networkxml2confdata/routed-network-no-dns.conf => networkxmlconfdata/passthrough-pf.conf} (82%) rename tests/{networkxml2xmlin => networkxmlconfdata}/passthrough-pf.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/ptr-domains-auto.conf (100%) rename tests/{networkxml2xmlin/nat-network-dns-srv-record-minimal.xml => networkxmlconfdata/ptr-domains-auto.expect.xml} (76%) rename tests/{networkxml2confdata => networkxmlconfdata}/ptr-domains-auto.hostsfile (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/ptr-domains-auto.xml (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/routed-network-no-dns-extra-elements.xml (100%) rename tests/{networkxml2xmlout/routed-network-no-dns.xml => networkxmlconfdata/routed-network-no-dns.expect.xml} (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/routed-network-no-dns.xml (100%) rename tests/{networkxml2confdata => networkxmlconfdata}/routed-network.conf (100%) rename tests/{networkxml2xmlout/routed-network.xml => networkxmlconfdata/routed-network.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/routed-network.xml (100%) rename tests/{networkxml2confdata/isolated-network.conf => networkxmlconfdata/set-mtu.conf} (95%) rename tests/{networkxml2xmlout/set-mtu.xml => networkxmlconfdata/set-mtu.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/set-mtu.xml (100%) rename tests/{networkxml2xmlout/vepa-net.xml => networkxmlconfdata/vepa-net.expect.xml} (100%) rename tests/{networkxml2xmlin => networkxmlconfdata}/vepa-net.xml (100%) rename tests/{networkxml2xmltest.c => networkxmlconftest.c} (35%) -- 2.52.0

2 21

[PATCH v2 0/3] Add multitouch input device support
by Julio Faracco 28 Jan '26

28 Jan '26

This patch series implements support for multitouch input devices in libvirt, addressing the multitouch feature request in [1]. In this second version, all the commits compile independently. They are logically separated in: 1. Domain enums, qemu, and security updates. 2. Domain schema update. 3. Test cases updates for multitouch support. [1] https://gitlab.com/libvirt/libvirt/-/issues/808 Julio Faracco (3): Add support for virtio-multitouch input devices conf: Add multitouch to domain schema tests: Add multitouch support to virtio-input tests src/conf/domain_audit.c | 1 + src/conf/domain_conf.c | 2 ++ src/conf/domain_conf.h | 1 + src/conf/domain_validate.c | 9 +++++++++ src/conf/schemas/domaincommon.rng | 1 + src/qemu/qemu_capabilities.c | 3 +++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 5 +++++ src/qemu/qemu_validate.c | 5 +++++ src/security/security_dac.c | 2 ++ src/security/security_selinux.c | 2 ++ tests/qemucapabilitiesdata/caps_10.0.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_x86_64+amdsev.xml | 1 + tests/qemucapabilitiesdata/caps_10.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_10.1.0_s390x.xml | 1 + .../qemucapabilitiesdata/caps_10.1.0_x86_64+inteltdx.xml | 1 + tests/qemucapabilitiesdata/caps_10.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_10.2.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_10.2.0_x86_64+mshv.xml | 1 + tests/qemucapabilitiesdata/caps_10.2.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_11.0.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_11.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_8.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_loongarch64.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_8.2.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.0.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_riscv64.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_9.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_aarch64+hvf.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_s390x.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_x86_64+amdsev.xml | 1 + tests/qemucapabilitiesdata/caps_9.2.0_x86_64.xml | 1 + tests/qemuxmlconfdata/virtio-input.x86_64-latest.args | 1 + tests/qemuxmlconfdata/virtio-input.x86_64-latest.xml | 3 +++ tests/qemuxmlconfdata/virtio-input.xml | 1 + 42 files changed, 65 insertions(+) -- 2.52.0

2 5

[PATCH v3 0/3] esx: Switch to creating URLs using virURIFormat
by Richard W.M. Jones 27 Jan '26

27 Jan '26

v2 was here: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/XMLW… As suggested by Dan in the previous review, it'd be better to use virURI, and indeed the code is a bit nicer this way. Rich.

3 8

[PATCH v2 0/5] Fix crash when reverting/deleting external snapshots
by Peter Krempa 27 Jan '26

27 Jan '26

v2: - modified explanation of why virStorageSourceIsSameLocation was called with NULL - fixed the call to virStorageSourceGetMetadata which caused the NULL deref - fixed permission issue when calling qemu-img if files are owned by root:root after restoring seclabels - improved error message when generating snapshot path fails (not related to original bug, just annoying when I've had a messed up VM) Peter Krempa (5): qemuSnapshotDiskHasBackingDisk: Avoid call of virStorageSourceIsSameLocation with NULL argument qemuSnapshotUpdateBackingStore: Remove stale comment qemuSnapshotDiskHasBackingDisk: Use proper 'max_depth' when calling 'virStorageSourceGetMetadata' virDomainSnapshotDefAssignExternalNames: Improve error message qemuSnapshotUpdateBackingStore: Retry as curent user if qemu-img fails src/conf/snapshot_conf.c | 4 +-- src/qemu/qemu_domain.c | 2 -- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_snapshot.c | 61 ++++++++++++++++++++++++++++------------ 4 files changed, 46 insertions(+), 22 deletions(-) -- 2.52.0

2 6

[PATCH] qemu: Connect NVMe devices to PCIe bus
by Akihiko Odaki 26 Jan '26

26 Jan '26

NVMe has PCIe transport, so connect NVMe devices to PCIe bus instead of classic PCI bus if available. Signed-off-by: Akihiko Odaki <odaki(a)rsg.ci.i.u-tokyo.ac.jp> --- src/qemu/qemu_domain_address.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 7233df888c..9957f927f5 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -657,7 +657,7 @@ qemuDomainDeviceCalculatePCIConnectFlags(virDomainDeviceDef *dev, break; case VIR_DOMAIN_CONTROLLER_TYPE_NVME: - return pciFlags; + return pcieFlags; case VIR_DOMAIN_CONTROLLER_TYPE_FDC: case VIR_DOMAIN_CONTROLLER_TYPE_CCID: --- base-commit: e0dcf278af4a605d2b1178633809c495c1880381 change-id: 20260123-nvme-eecaf6b54ce0 Best regards, -- Akihiko Odaki <odaki(a)rsg.ci.i.u-tokyo.ac.jp>

2 1

[PATCH] qemu: introduce the "virtualization" feature
by Roman Bogorodskiy 26 Jan '26

26 Jan '26

The "virt" board in QEMU has a "virtualization" option that is documented like this: virtualization Set ``on``/``off`` to enable/disable emulating a guest CPU which implements the Arm Virtualization Extensions. The default is ``off``. (from system/arm/virt.rst) According to the documentation, the "virtualiaztion" option is related to the "gic-version" option. Specifically, gic version=4 requires virtualization to be enabled. And gic version=max will use version=4 when virtualization is enabled, and 3 when not. Libvirt does not currently model neither gic version "3" nor "max" though. It is also documented for the "vexpress-a(9|15)" boards, where it is also disabled by default: - QEMU defaults to providing a CPU which does not provide either TrustZone or the Virtualization Extensions: if you want these you must enable them with ``-machine secure=on`` and ``-machine virtualization=on`` (system/arm/vexpress.rst). On the command line it looks like: qemu-system-aarch64 -machine type=virt,virtualization=on .. Model it using the "virtualization" element in the "features" section: <features> <virtualization/> </features> Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- docs/formatdomain.rst | 4 ++ src/conf/domain_conf.c | 4 ++ src/conf/domain_conf.h | 1 + src/conf/schemas/domaincommon.rng | 5 +++ src/qemu/qemu_command.c | 9 ++++ src/qemu/qemu_validate.c | 1 + ...64-virt-virtualization.aarch64-latest.args | 38 ++++++++++++++++ ...h64-virt-virtualization.aarch64-latest.xml | 45 +++++++++++++++++++ .../aarch64-virt-virtualization.xml | 25 +++++++++++ tests/qemuxmlconftest.c | 2 + 10 files changed, 134 insertions(+) create mode 100644 tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/aarch64-virt-virtualization.xml diff --git a/docs/formatdomain.rst b/docs/formatdomain.rst index 04ef319a73..ad74d91950 100644 --- a/docs/formatdomain.rst +++ b/docs/formatdomain.rst @@ -2378,6 +2378,10 @@ are: one IMSIC device present per core), or ``none`` (no support for AIA). If the attribute is not defined, the hypervisor default will be used. :since:`Since 11.1.0` (QEMU/KVM and RISC-V guests only) +``virtualization`` + Enable emulating a guest CPU which implements the Arm Virtualization Extensions. + If the attribute is not defined, the hypervisor default will be used. + :since:`Since 12.1.0` (QEMU/KVM and ARM virt guests only) Time keeping ------------ diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 9ca5c2450c..1a8c5cb5b7 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -188,6 +188,7 @@ VIR_ENUM_IMPL(virDomainFeature, "ras", "ps2", "aia", + "virtualization", ); VIR_ENUM_IMPL(virDomainCapabilitiesPolicy, @@ -17480,6 +17481,7 @@ virDomainFeaturesDefParse(virDomainDef *def, case VIR_DOMAIN_FEATURE_PAE: case VIR_DOMAIN_FEATURE_VIRIDIAN: case VIR_DOMAIN_FEATURE_PRIVNET: + case VIR_DOMAIN_FEATURE_VIRTUALIZATION: def->features[val] = VIR_TRISTATE_SWITCH_ON; break; @@ -21636,6 +21638,7 @@ virDomainDefFeaturesCheckABIStability(virDomainDef *src, case VIR_DOMAIN_FEATURE_CCF_ASSIST: case VIR_DOMAIN_FEATURE_RAS: case VIR_DOMAIN_FEATURE_PS2: + case VIR_DOMAIN_FEATURE_VIRTUALIZATION: if (src->features[i] != dst->features[i]) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("State of feature '%1$s' differs: source: '%2$s', destination: '%3$s'"), @@ -28867,6 +28870,7 @@ virDomainDefFormatFeatures(virBuffer *buf, case VIR_DOMAIN_FEATURE_PAE: case VIR_DOMAIN_FEATURE_VIRIDIAN: case VIR_DOMAIN_FEATURE_PRIVNET: + case VIR_DOMAIN_FEATURE_VIRTUALIZATION: /* NOTE: This is for old style <opt/> booleans. New XML * should use the explicit state=on|off output below */ switch ((virTristateSwitch) def->features[i]) { diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index cb35ff06bd..d0f4c082fd 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2243,6 +2243,7 @@ typedef enum { VIR_DOMAIN_FEATURE_RAS, VIR_DOMAIN_FEATURE_PS2, VIR_DOMAIN_FEATURE_AIA, + VIR_DOMAIN_FEATURE_VIRTUALIZATION, VIR_DOMAIN_FEATURE_LAST } virDomainFeature; diff --git a/src/conf/schemas/domaincommon.rng b/src/conf/schemas/domaincommon.rng index 114dd3f96f..8669d8f791 100644 --- a/src/conf/schemas/domaincommon.rng +++ b/src/conf/schemas/domaincommon.rng @@ -7180,6 +7180,11 @@ <optional> <ref name="aia"/> </optional> + <optional> + <element name="virtualization"> + <empty/> + </element> + </optional> </interleave> </element> </optional> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0de0a79b46..b410daf156 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7011,6 +7011,15 @@ qemuAppendDomainFeaturesMachineParam(virBuffer *buf, } } + if (def->features[VIR_DOMAIN_FEATURE_VIRTUALIZATION] == VIR_TRISTATE_SWITCH_ON) { + if (virQEMUCapsGetArch(qemuCaps) != VIR_ARCH_AARCH64) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("virtualization option is not available with this QEMU binary")); + return -1; + } + virBufferAddLit(buf, ",virtualization=on"); + } + if (def->features[VIR_DOMAIN_FEATURE_HTM] != VIR_TRISTATE_SWITCH_ABSENT) { const char *str; str = virTristateSwitchTypeToString(def->features[VIR_DOMAIN_FEATURE_HTM]); diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 184c23d307..5474d00ecd 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -182,6 +182,7 @@ qemuValidateDomainDefFeatures(const virDomainDef *def, break; case VIR_DOMAIN_FEATURE_GIC: + case VIR_DOMAIN_FEATURE_VIRTUALIZATION: if (def->features[i] == VIR_TRISTATE_SWITCH_ON && !qemuDomainIsARMVirt(def)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, diff --git a/tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.args b/tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.args new file mode 100644 index 0000000000..be04ecc641 --- /dev/null +++ b/tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.args @@ -0,0 +1,38 @@ +LC_ALL=C \ +PATH=/bin \ +HOME=/var/lib/libvirt/qemu/domain--1-aarch64-virt-default \ +USER=test \ +LOGNAME=test \ +XDG_DATA_HOME=/var/lib/libvirt/qemu/domain--1-aarch64-virt-default/.local/share \ +XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain--1-aarch64-virt-default/.cache \ +XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain--1-aarch64-virt-default/.config \ +/usr/bin/qemu-system-aarch64 \ +-name guest=aarch64-virt-default-nic,debug-threads=on \ +-S \ +-object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/var/lib/libvirt/qemu/domain--1-aarch64-virt-default/master-key.aes"}' \ +-machine virt,usb=off,gic-version=2,virtualization=on,dump-guest-core=off,memory-backend=mach-virt.ram,acpi=off \ +-accel tcg \ +-cpu cortex-a53 \ +-m size=1048576k \ +-object '{"qom-type":"memory-backend-ram","id":"mach-virt.ram","size":1073741824}' \ +-overcommit mem-lock=off \ +-smp 1,sockets=1,cores=1,threads=1 \ +-uuid 6ba410c5-1e5c-4d57-bee7-2228e7ffa32f \ +-display none \ +-no-user-config \ +-nodefaults \ +-chardev socket,id=charmonitor,fd=1729,server=on,wait=off \ +-mon chardev=charmonitor,id=monitor,mode=control \ +-rtc base=utc \ +-no-shutdown \ +-boot strict=on \ +-kernel /aarch64.kernel \ +-initrd /aarch64.initrd \ +-append console=ttyAMA0 \ +-device '{"driver":"pcie-root-port","port":8,"chassis":1,"id":"pci.1","bus":"pcie.0","multifunction":true,"addr":"0x1"}' \ +-device '{"driver":"pcie-root-port","port":9,"chassis":2,"id":"pci.2","bus":"pcie.0","addr":"0x1.0x1"}' \ +-netdev '{"type":"user","id":"hostnet0"}' \ +-device '{"driver":"virtio-net-pci","netdev":"hostnet0","id":"net0","mac":"52:54:00:09:a4:37","bus":"pci.1","addr":"0x0"}' \ +-audiodev '{"id":"audio1","driver":"none"}' \ +-sandbox on,obsolete=deny,elevateprivileges=deny,spawn=deny,resourcecontrol=deny \ +-msg timestamp=on diff --git a/tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.xml b/tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.xml new file mode 100644 index 0000000000..7636046257 --- /dev/null +++ b/tests/qemuxmlconfdata/aarch64-virt-virtualization.aarch64-latest.xml @@ -0,0 +1,45 @@ +<domain type='qemu'> + <name>aarch64-virt-default-nic</name> + <uuid>6ba410c5-1e5c-4d57-bee7-2228e7ffa32f</uuid> + <memory unit='KiB'>1048576</memory> + <currentMemory unit='KiB'>1048576</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='aarch64' machine='virt'>hvm</type> + <kernel>/aarch64.kernel</kernel> + <initrd>/aarch64.initrd</initrd> + <cmdline>console=ttyAMA0</cmdline> + <boot dev='hd'/> + </os> + <features> + <gic version='2'/> + <virtualization/> + </features> + <cpu mode='custom' match='exact' check='none'> + <model fallback='allow'>cortex-a53</model> + </cpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-aarch64</emulator> + <controller type='pci' index='0' model='pcie-root'/> + <controller type='pci' index='1' model='pcie-root-port'> + <model name='pcie-root-port'/> + <target chassis='1' port='0x8'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x0' multifunction='on'/> + </controller> + <controller type='pci' index='2' model='pcie-root-port'> + <model name='pcie-root-port'/> + <target chassis='2' port='0x9'/> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> + </controller> + <interface type='user'> + <mac address='52:54:00:09:a4:37'/> + <model type='virtio'/> + <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/> + </interface> + <audio id='1' type='none'/> + </devices> +</domain> diff --git a/tests/qemuxmlconfdata/aarch64-virt-virtualization.xml b/tests/qemuxmlconfdata/aarch64-virt-virtualization.xml new file mode 100644 index 0000000000..ee7984a736 --- /dev/null +++ b/tests/qemuxmlconfdata/aarch64-virt-virtualization.xml @@ -0,0 +1,25 @@ +<domain type="qemu"> + <name>aarch64-virt-default-nic</name> + <uuid>6ba410c5-1e5c-4d57-bee7-2228e7ffa32f</uuid> + <memory>1048576</memory> + <currentMemory>1048576</currentMemory> + <vcpu>1</vcpu> + <cpu match='exact'> + <model>cortex-a53</model> + </cpu> + <os> + <type arch="aarch64" machine="virt">hvm</type> + <kernel>/aarch64.kernel</kernel> + <initrd>/aarch64.initrd</initrd> + <cmdline>console=ttyAMA0</cmdline> + </os> + <features> + <virtualization/> + </features> + <devices> + <emulator>/usr/bin/qemu-system-aarch64</emulator> + <interface type='user'> + <mac address='52:54:00:09:a4:37'/> + </interface> + </devices> +</domain> diff --git a/tests/qemuxmlconftest.c b/tests/qemuxmlconftest.c index 89b8ad1a35..c7c1d1da54 100644 --- a/tests/qemuxmlconftest.c +++ b/tests/qemuxmlconftest.c @@ -3322,6 +3322,8 @@ mymain(void) /* MSHV guests should not work on Linux with KVM */ DO_TEST_CAPS_LATEST_PARSE_ERROR("mshv-x86_64-q35-headless"); + DO_TEST_CAPS_ARCH_LATEST("aarch64-virt-virtualization", "aarch64"); + /* check that all input files were actually used here */ if (testConfXMLCheck(existingTestCases) < 0) ret = -1; -- 2.52.0

2 3

[PATCH v2 0/3] esx: Form URLs containing IPv6 addresses correctly
by Richard W.M. Jones 26 Jan '26

26 Jan '26

v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/YRCX… In v2, replace multiple VIR_DEBUG with just one, and add the Reported-by and Reviewed-by tags on the last commit. I'm sure this can't be the only place in libvirt that has to solve this problem (nor the "is this hostname IPv6" problem for that matter), but my searching skills are not good enough to find any other places. Rich.

3 6

[PATCH] bhyve: improve loader handling on arm64
by Roman Bogorodskiy 26 Jan '26

26 Jan '26

Bhyve on arm64 does not have the bhyveload(8) tool. That means that it cannot be used as a default if the loader is not configured for the domain. To prevent users from getting unusable configurations, handle loader configuration on arm64 like that: - if loader is specified in the domain XML, just use it - if not specified, try to check whether the default uboot loader is available on the system. In case it is, set is as the loader, otherwise fail with the error. Signed-off-by: Roman Bogorodskiy <bogorodskiy(a)gmail.com> --- src/bhyve/bhyve_domain.c | 22 +++++++++++++++++++ .../aarch64/bhyvexml2argv-base.args | 1 + .../aarch64/bhyvexml2argv-base.ldargs | 8 +------ .../aarch64/bhyvexml2argv-console.args | 1 + .../aarch64/bhyvexml2argv-console.ldargs | 8 +------ tests/bhyvexml2argvmock.c | 20 ++++++++++++++++- .../aarch64/bhyvexml2xmlout-base.xml | 1 + .../aarch64/bhyvexml2xmlout-console.xml | 1 + 8 files changed, 47 insertions(+), 15 deletions(-) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index df0a008ecd..733bacc8c1 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -27,11 +27,14 @@ #include "bhyve_domain.h" #include "bhyve_capabilities.h" #include "viralloc.h" +#include "virfile.h" #include "virlog.h" #include "virutil.h" #define VIR_FROM_THIS VIR_FROM_BHYVE +#define UBOOT_BHYVE DATADIR "/u-boot/u-boot-bhyve-arm64/u-boot.bin" + VIR_LOG_INIT("bhyve.bhyve_domain"); static void * @@ -112,6 +115,25 @@ bhyveDomainDefPostParse(virDomainDef *def, !(bhyveDriverGetBhyveCaps(driver) & BHYVE_CAP_RTC_UTC)) def->clock.offset = VIR_DOMAIN_CLOCK_OFFSET_LOCALTIME; + /* bhyve/arm64 does not provide the bhyveload(8) tool, + * so if the loader is not specified and we cannot fall back to the + * default one, then this results in an usable configuration. */ + if (ARCH_IS_ARM(def->os.arch)) { + if (def->os.loader == NULL) { + if (virFileExists(UBOOT_BHYVE)) { + def->os.loader = virDomainLoaderDefNew(); + def->os.loader->path = g_strdup(UBOOT_BHYVE); + def->os.loader->readonly = true; + def->os.loader->type = VIR_DOMAIN_LOADER_TYPE_PFLASH; + } else { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("loader is not specified and the default loader (%1$s) not found"), + UBOOT_BHYVE); + return -1; + } + } + } + return 0; } diff --git a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.args b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.args index aef3ebd017..1079beee52 100644 --- a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.args +++ b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.args @@ -2,6 +2,7 @@ bhyve \ -c 1 \ -m 214 \ -s 0:0,hostbridge \ +-o bootrom=/usr/local/share/u-boot/u-boot-bhyve-arm64/u-boot.bin \ -s 3:0,virtio-net,faketapdev,mac=52:54:00:b9:94:02 \ -s 2:0,virtio-blk,/tmp/freebsd.img \ bhyve diff --git a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.ldargs b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.ldargs index 264ae48441..421376db9e 100644 --- a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.ldargs +++ b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-base.ldargs @@ -1,7 +1 @@ -timeout \ ---foreground \ ---verbose \ --k 20s 300s bhyveload \ --m 214 \ --d /tmp/freebsd.img \ -bhyve +dummy diff --git a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.args b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.args index 4a031afb71..ea2cc15713 100644 --- a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.args +++ b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.args @@ -2,6 +2,7 @@ bhyve \ -c 1 \ -m 214 \ -s 0:0,hostbridge \ +-o bootrom=/usr/local/share/u-boot/u-boot-bhyve-arm64/u-boot.bin \ -s 3:0,virtio-net,faketapdev,mac=52:54:00:b9:94:02 \ -s 2:0,virtio-blk,/tmp/freebsd.img \ -o console=/dev/nmdm0A \ diff --git a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.ldargs b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.ldargs index 264ae48441..421376db9e 100644 --- a/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.ldargs +++ b/tests/bhyvexml2argvdata/aarch64/bhyvexml2argv-console.ldargs @@ -1,7 +1 @@ -timeout \ ---foreground \ ---verbose \ --k 20s 300s bhyveload \ --m 214 \ --d /tmp/freebsd.img \ -bhyve +dummy diff --git a/tests/bhyvexml2argvmock.c b/tests/bhyvexml2argvmock.c index fe76564d51..f4271563d7 100644 --- a/tests/bhyvexml2argvmock.c +++ b/tests/bhyvexml2argvmock.c @@ -2,7 +2,9 @@ #include <dirent.h> +#include "configmake.h" #include "viralloc.h" +#include "virfile.h" #include "virstring.h" #include "virnetdev.h" #include "virnetdevtap.h" @@ -12,11 +14,16 @@ #define VIR_FROM_THIS VIR_FROM_BHYVE static DIR * (*real_opendir)(const char *name); +static bool (*real_virFileExists)(const char *path); static void init_syms(void) { - VIR_MOCK_REAL_INIT(opendir); + if (!real_opendir) + VIR_MOCK_REAL_INIT(opendir); + + if (!real_virFileExists) + VIR_MOCK_REAL_INIT(virFileExists); } #define FAKEFIRMWAREDIR abs_srcdir "/bhyvefirmwaredata/three_firmwares" @@ -89,3 +96,14 @@ int bind(int sockfd G_GNUC_UNUSED, { return 0; } + +bool +virFileExists(const char *path) +{ + init_syms(); + + if (STREQ(path, DATADIR "/u-boot/u-boot-bhyve-arm64/u-boot.bin")) + return true; + + return real_virFileExists(path); +} diff --git a/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-base.xml b/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-base.xml index ee72370047..d6c9caa225 100644 --- a/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-base.xml +++ b/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-base.xml @@ -6,6 +6,7 @@ <vcpu placement='static'>1</vcpu> <os> <type arch='aarch64'>hvm</type> + <loader readonly='yes' type='pflash'>/usr/local/share/u-boot/u-boot-bhyve-arm64/u-boot.bin</loader> <boot dev='hd'/> </os> <clock offset='localtime'/> diff --git a/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-console.xml b/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-console.xml index d43ce8fd6f..d694ecfb8d 100644 --- a/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-console.xml +++ b/tests/bhyvexml2xmloutdata/aarch64/bhyvexml2xmlout-console.xml @@ -6,6 +6,7 @@ <vcpu placement='static'>1</vcpu> <os> <type arch='aarch64'>hvm</type> + <loader readonly='yes' type='pflash'>/usr/local/share/u-boot/u-boot-bhyve-arm64/u-boot.bin</loader> <boot dev='hd'/> </os> <clock offset='localtime'/> -- 2.52.0

2 3

[PATCH 0/3] esx: Form URLs containing IPv6 addresses correctly
by Richard W.M. Jones 26 Jan '26

26 Jan '26

https://issues.redhat.com/browse/RHEL-138300 This bug requires a further fix to allow libvirt to access ESXi servers over IPv6. The way that we constructed the URL (for fetching things from the SDK with curl) was wrong. We formed URLs like: https://1234:56:0:789a:bcde:72ff:fe0a:7baa:443/sdk but with IPv6 we need to put [...] around the IPv6 address. The first patch just adds some debugging so we can see what URLs we are passing to curl. THe second patch is a bit of abstraction so that we're only creating URLs in one place (but two functions). The third detects if the server name is an IPv6 address and adds the square brackets as appropriate. Tested by me, by connecting to an IPv6 VMware server and listing all the domains, and getting the libvirt XML of a single domain. I didn't test all possible operations in depth. The bug was reported by Ming Xie. Rich.

2 6

[PATCH v2] Standardize socket family checks
by Julio Faracco 23 Jan '26

23 Jan '26

This commit standardizes socket family checks in rpc/virnetsocket.c and util/virsocketaddr.c with macro VIR_SOCKET_ADDR_IS_FAMILY. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/rpc/virnetsocket.c | 20 ++++++++++---------- src/util/virsocketaddr.c | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index e8fc2d5f7d..22b0aa6ead 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -276,8 +276,8 @@ virNetSocketNew(virSocketAddr *localAddr, sock->unlinkUNIX = unlinkUNIX; /* Disable nagle for TCP sockets */ - if (sock->localAddr.data.sa.sa_family == AF_INET || - sock->localAddr.data.sa.sa_family == AF_INET6) { + if (VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_INET) || + VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_INET6)) { if (setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &no_slow_start, sizeof(no_slow_start)) < 0) { @@ -405,9 +405,9 @@ int virNetSocketNewListenTCP(const char *nodename, * other IP protocol */ if (port != 0 && service == NULL) { - if (addr.data.sa.sa_family == AF_INET) { + if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET)) { addr.data.inet4.sin_port = port; - } else if (addr.data.sa.sa_family == AF_INET6) { + } else if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET6)) { addr.data.inet6.sin6_port = port; } VIR_DEBUG("Used saved port %d", port); @@ -432,9 +432,9 @@ int virNetSocketNewListenTCP(const char *nodename, } if (port == 0 && service == NULL) { - if (addr.data.sa.sa_family == AF_INET) + if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET)) port = addr.data.inet4.sin_port; - else if (addr.data.sa.sa_family == AF_INET6) + else if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET6)) port = addr.data.inet6.sin6_port; VIR_DEBUG("Saved port %d", port); } @@ -1293,7 +1293,7 @@ void virNetSocketDispose(void *obj) #ifndef WIN32 /* If a server socket, then unlink UNIX path */ if (sock->unlinkUNIX && - sock->localAddr.data.sa.sa_family == AF_UNIX && + VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX) && sock->localAddr.data.un.sun_path[0] != '\0') unlink(sock->localAddr.data.un.sun_path); #endif @@ -1370,7 +1370,7 @@ bool virNetSocketIsLocal(virNetSocket *sock) { bool isLocal = false; virObjectLock(sock); - if (sock->localAddr.data.sa.sa_family == AF_UNIX) + if (VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX)) isLocal = true; virObjectUnlock(sock); return isLocal; @@ -1381,7 +1381,7 @@ bool virNetSocketHasPassFD(virNetSocket *sock) { bool hasPassFD = false; virObjectLock(sock); - if (sock->localAddr.data.sa.sa_family == AF_UNIX) + if (VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX)) hasPassFD = true; virObjectUnlock(sock); return hasPassFD; @@ -2223,7 +2223,7 @@ void virNetSocketClose(virNetSocket *sock) #ifndef WIN32 /* If a server socket, then unlink UNIX path */ if (sock->unlinkUNIX && - sock->localAddr.data.sa.sa_family == AF_UNIX && + VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX) && sock->localAddr.data.un.sun_path[0] != '\0') { if (unlink(sock->localAddr.data.un.sun_path) == 0) sock->localAddr.data.un.sun_path[0] = '\0'; diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 1f203fb50d..929dd260af 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -481,7 +481,7 @@ virSocketAddrFormatFull(const virSocketAddr *addr, /* Short-circuit since getnameinfo doesn't work * nicely for UNIX sockets */ - if (addr->data.sa.sa_family == AF_UNIX) { + if (VIR_SOCKET_ADDR_IS_FAMILY(addr, AF_UNIX)) { if (withService) { addrstr = g_strdup_printf(VIR_LOOPBACK_IPV4_ADDR "%s0", separator ? separator : ":"); @@ -634,7 +634,7 @@ virSocketAddrGetPath(virSocketAddr *addr G_GNUC_UNUSED) return NULL; } - if (addr->data.sa.sa_family != AF_UNIX) { + if (!VIR_SOCKET_ADDR_IS_FAMILY(addr, AF_UNIX)) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("UNIX socket address is required")); return NULL; -- 2.52.0

1 1

[PATCH 0/2] Fix crash when reverting/deleting external inactive snapshots around the root of the snapshot tree
by Peter Krempa 23 Jan '26

23 Jan '26

Peter Krempa (2): qemuSnapshotDiskHasBackingDisk: Avoid call of virStorageSourceIsSameLocation with NULL argument qemuSnapshotUpdateBackingStore: Remove stale comment src/qemu/qemu_snapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.52.0

2 3

[PATCH v3 0/2] Include test cases for virSocketAddrFormatWithPrefix
by Julio Faracco 23 Jan '26

23 Jan '26

Recently, we removed the masked argument in commit 6f07a8e6 from the respective function. But, in sockettest.c, we don't have any test case to cover this function. This series adds some test cases for virSocketAddrFormatWithPrefix and an extra patch to increase the testFormat debugging info. Julio Faracco (2): tests: Add tests for virSocketAddrFormatWithPrefix tests: Add debug information in testFormat() tests/sockettest.c | 77 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 76 insertions(+), 1 deletion(-) -- 2.52.0

1 2

[PATCH] Standardize socket family checks with proper macro
by Julio Faracco 23 Jan '26

23 Jan '26

There is a macro called VIR_SOCKET_ADDR_IS_FAMILY that checks the socket family. There are several occurrences of raw checks in libvirt code. This commit just standardizes the socket family checks by using its macro. Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/rpc/virnetsocket.c | 20 ++++++++++---------- src/util/virsocketaddr.c | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index e8fc2d5f7d..22b0aa6ead 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -276,8 +276,8 @@ virNetSocketNew(virSocketAddr *localAddr, sock->unlinkUNIX = unlinkUNIX; /* Disable nagle for TCP sockets */ - if (sock->localAddr.data.sa.sa_family == AF_INET || - sock->localAddr.data.sa.sa_family == AF_INET6) { + if (VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_INET) || + VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_INET6)) { if (setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &no_slow_start, sizeof(no_slow_start)) < 0) { @@ -405,9 +405,9 @@ int virNetSocketNewListenTCP(const char *nodename, * other IP protocol */ if (port != 0 && service == NULL) { - if (addr.data.sa.sa_family == AF_INET) { + if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET)) { addr.data.inet4.sin_port = port; - } else if (addr.data.sa.sa_family == AF_INET6) { + } else if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET6)) { addr.data.inet6.sin6_port = port; } VIR_DEBUG("Used saved port %d", port); @@ -432,9 +432,9 @@ int virNetSocketNewListenTCP(const char *nodename, } if (port == 0 && service == NULL) { - if (addr.data.sa.sa_family == AF_INET) + if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET)) port = addr.data.inet4.sin_port; - else if (addr.data.sa.sa_family == AF_INET6) + else if (VIR_SOCKET_ADDR_IS_FAMILY(&addr, AF_INET6)) port = addr.data.inet6.sin6_port; VIR_DEBUG("Saved port %d", port); } @@ -1293,7 +1293,7 @@ void virNetSocketDispose(void *obj) #ifndef WIN32 /* If a server socket, then unlink UNIX path */ if (sock->unlinkUNIX && - sock->localAddr.data.sa.sa_family == AF_UNIX && + VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX) && sock->localAddr.data.un.sun_path[0] != '\0') unlink(sock->localAddr.data.un.sun_path); #endif @@ -1370,7 +1370,7 @@ bool virNetSocketIsLocal(virNetSocket *sock) { bool isLocal = false; virObjectLock(sock); - if (sock->localAddr.data.sa.sa_family == AF_UNIX) + if (VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX)) isLocal = true; virObjectUnlock(sock); return isLocal; @@ -1381,7 +1381,7 @@ bool virNetSocketHasPassFD(virNetSocket *sock) { bool hasPassFD = false; virObjectLock(sock); - if (sock->localAddr.data.sa.sa_family == AF_UNIX) + if (VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX)) hasPassFD = true; virObjectUnlock(sock); return hasPassFD; @@ -2223,7 +2223,7 @@ void virNetSocketClose(virNetSocket *sock) #ifndef WIN32 /* If a server socket, then unlink UNIX path */ if (sock->unlinkUNIX && - sock->localAddr.data.sa.sa_family == AF_UNIX && + VIR_SOCKET_ADDR_IS_FAMILY(&sock->localAddr, AF_UNIX) && sock->localAddr.data.un.sun_path[0] != '\0') { if (unlink(sock->localAddr.data.un.sun_path) == 0) sock->localAddr.data.un.sun_path[0] = '\0'; diff --git a/src/util/virsocketaddr.c b/src/util/virsocketaddr.c index 4d4a6b2a0f..e8e691ce8f 100644 --- a/src/util/virsocketaddr.c +++ b/src/util/virsocketaddr.c @@ -481,7 +481,7 @@ virSocketAddrFormatFull(const virSocketAddr *addr, /* Short-circuit since getnameinfo doesn't work * nicely for UNIX sockets */ - if (addr->data.sa.sa_family == AF_UNIX) { + if (VIR_SOCKET_ADDR_IS_FAMILY(addr, AF_UNIX)) { if (withService) { addrstr = g_strdup_printf(VIR_LOOPBACK_IPV4_ADDR "%s0", separator ? separator : ":"); @@ -636,7 +636,7 @@ virSocketAddrGetPath(virSocketAddr *addr G_GNUC_UNUSED) return NULL; } - if (addr->data.sa.sa_family != AF_UNIX) { + if (!VIR_SOCKET_ADDR_IS_FAMILY(addr, AF_UNIX)) { virReportError(VIR_ERR_INVALID_ARG, "%s", _("UNIX socket address is required")); return NULL; -- 2.52.0

2 2

[PATCH v2 0/2] Remove @masked argument from virSocketAddrFormatWithPrefix
by Julio Faracco 23 Jan '26

23 Jan '26

Since its introduction in commit 426afc00, the function virSocketAddrFormatWithPrefix has never been called with argument masked=false. So, this commit proposes to remove this unnecessary argument from the function scope. This series also proposes the respective test cases for virSocketAddrFormatWithPrefix (now, without @masked argument). Julio Faracco (2): util: Remove @masked argument from virSocketAddrFormatWithPrefix tests: Add tests for virSocketAddrFormatWithPrefix src/network/network_iptables.c | 10 +++--- src/network/network_nftables.c | 10 +++--- src/util/virsocketaddr.c | 14 ++++---- src/util/virsocketaddr.h | 3 +- tests/sockettest.c | 63 ++++++++++++++++++++++++++++++++++ 5 files changed, 80 insertions(+), 20 deletions(-) -- 2.52.0

2 5

[PATCH 0/6] virtio-iommu: Support setting aw-bits and granule
by Michal Privoznik 23 Jan '26

23 Jan '26

*** BLURB HERE *** Michal Prívozník (6): qemu_capabilities: Introduce QEMU_CAPS_VIRTIO_IOMMU_AW_BITS conf: Allow aw_bits for virtio-iommu qemu_command: Generate aw_bits prop for virtio-iommu conf: Introduce granule attribute for virtio-iommu qemu_validate: Check whether granule of virtio-iommu is supported qemu_command: Generate granule prop for virtio-iommu docs/formatdomain.rst | 9 +++++- src/conf/domain_conf.c | 30 ++++++++++++++++++- src/conf/domain_conf.h | 13 ++++++++ src/conf/domain_validate.c | 18 +++++++---- src/conf/schemas/domaincommon.rng | 11 +++++++ src/libvirt_private.syms | 2 ++ src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 7 +++++ src/qemu/qemu_validate.c | 13 ++++++-- .../caps_10.0.0_aarch64.xml | 1 + .../caps_10.0.0_ppc64.xml | 1 + .../caps_10.0.0_s390x.xml | 1 + .../caps_10.0.0_x86_64+amdsev.xml | 1 + .../caps_10.0.0_x86_64.xml | 1 + .../caps_10.1.0_s390x.xml | 1 + .../caps_10.1.0_x86_64+inteltdx.xml | 1 + .../caps_10.1.0_x86_64.xml | 1 + .../caps_10.2.0_aarch64.xml | 1 + .../caps_10.2.0_x86_64+mshv.xml | 1 + .../caps_10.2.0_x86_64.xml | 1 + .../caps_11.0.0_aarch64.xml | 1 + .../caps_11.0.0_x86_64.xml | 1 + .../caps_9.0.0_x86_64.xml | 1 + .../caps_9.1.0_riscv64.xml | 1 + .../qemucapabilitiesdata/caps_9.1.0_s390x.xml | 1 + .../caps_9.1.0_x86_64.xml | 1 + .../caps_9.2.0_aarch64+hvf.xml | 1 + .../qemucapabilitiesdata/caps_9.2.0_s390x.xml | 1 + .../caps_9.2.0_x86_64+amdsev.xml | 1 + .../caps_9.2.0_x86_64.xml | 1 + .../virtio-iommu-aarch64.aarch64-latest.args | 2 +- .../virtio-iommu-aarch64.aarch64-latest.xml | 1 + .../qemuxmlconfdata/virtio-iommu-aarch64.xml | 4 ++- ...io-iommu-dma-translation.x86_64-latest.err | 2 +- 35 files changed, 124 insertions(+), 12 deletions(-) -- 2.52.0

3 18

[PATCH] Fix printf style used with virDomainIOMMUDef::aw_bits
by Michal Privoznik 22 Jan '26

22 Jan '26

From: Michal Privoznik <mprivozn(a)redhat.com> The aw_bits member of the virDomainIOMMUDef is of type unsigned int. However, in a few places (virDomainIOMMUDefCheckABIStability(), virDomainIOMMUDefFormat(), qemuBuildIOMMUCommandLine()) incorrect printf modifier is used. Fix those places. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/conf/domain_conf.c | 4 ++-- src/qemu/qemu_command.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 8b26de674e..9672168df9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22301,7 +22301,7 @@ virDomainIOMMUDefCheckABIStability(virDomainIOMMUDef *src, } if (src->aw_bits != dst->aw_bits) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Target domain IOMMU device aw_bits value '%1$d' does not match source '%2$d'"), + _("Target domain IOMMU device aw_bits value '%1$u' does not match source '%2$u'"), dst->aw_bits, src->aw_bits); return false; } @@ -28638,7 +28638,7 @@ virDomainIOMMUDefFormat(virBuffer *buf, virTristateSwitchTypeToString(iommu->iotlb)); } if (iommu->aw_bits > 0) { - virBufferAsprintf(&driverAttrBuf, " aw_bits='%d'", + virBufferAsprintf(&driverAttrBuf, " aw_bits='%u'", iommu->aw_bits); } if (iommu->dma_translation != VIR_TRISTATE_SWITCH_ABSENT) { diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0de0a79b46..e81efdfde7 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6295,7 +6295,7 @@ qemuBuildIOMMUCommandLine(virCommand *cmd, "T:caching-mode", iommu->caching_mode, "S:eim", qemuOnOffAuto(iommu->eim), "T:device-iotlb", iommu->iotlb, - "z:aw-bits", iommu->aw_bits, + "p:aw-bits", iommu->aw_bits, "T:dma-translation", iommu->dma_translation, NULL) < 0) return -1; -- 2.52.0

2 1

[RFC PATCH v5 0/5] RFC: Add Arm CCA support for getting capability information and running Realm VM
by Kazuhiro Abe 22 Jan '26

22 Jan '26

Hi, all. This patch adds Arm CCA support to QEMU driver for aarch64 system. CCA is an abbreviation for Arm Confidential Compute Architecture feature, it enhances the virtualization capabilities of the platform by separating the management of resources from access to those resources. We are not yet at the stage where we can merge this patch as host Linux/QEMU support is not yet merged, but I would like to receive reviews and comments on the overall direction. Changes in v5: - Changed the target QEMU binary (Linaro's CCA/v10 version with added QMP functionality) - Changed the following changes to the CCA QMP command definitions: - QMP command name: query-rme-guest-capabilities - CCA capabilities info - Add ARM CCA support to firmware feature. [summary] At this stage, all you can do is getting the CCA capability with the virsh domcapabilities command and start the CCA VM with the virsh create command. capability info uses QEMU QMP to query QEMU options. The option that exists now is for selecting a hash algorithm. QEMU QMP sections currently only contains a single member, but is wrapped in sections for expansion. [Capability example] Execution results of 'virsh domcapability" on QEMU <domaincapabilities> ... <features> ... </sgx> <cca supported='yes'> <enum name='measurement-algo'> <value>sha256</value> <value>sha512</value> </enum> </cca> <hyperv supported='yes'> ... </features> </domaincapabilities> [XML example] <domain> ... <launchsecurity type='cca'> <measurement-algo>sha256</measurement-algo> </launchsecurity> ... </domain> [limitations/tests] To obtain capability info, it is necessary to support the QEMU QMP command, (See "[software version]"below). The JSON file for the CCA firmware feature has not yet been provided by the distributor. For CCA support, the equivalent of the following JSON file must be placed in /usr/share/qemu: tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-aarch64-armcca.json We have confirmed that the added tests (qemucapabilitiestest, domaincapstest and qemuxmlconftest) and the CCA VM startup test (starting the CCA VM from the virsh create command) passed. The "personalization-value" and "measurement-log" parameters that exist in the current Linaro QEMU cca/latest branch will not be specified as CCA VM startup parameters with the virsh create command. [software version] I followed the steps in Linaro's blog below. https://linaro.atlassian.net/wiki/spaces/QEMU/pages/29051027459/Building+an… The QEMU used was enhanced with CCA QMP command and found at: https://gitlab.com/Linaro/dcap/qemu/-/commits/cca/latest RFC v1: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/V4S5… RFC v2: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/5VZ… RFC v3: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/LLWA… RFC v4 https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/3WAW… Signed-off-by: Kazuhiro Abe fj1078ii(a)aa.jp.fujitsu.com Akio Kakuno (3): src: Add ARM CCA support in qemu driver to launch VM src: Add ARM CCA support in domain capabilities command src: Add ARM CCA support in domain schema Kazuhiro Abe (2): src: Add ARM CCA support in firmware feature tests: Adds Arm CCA support docs/formatdomain.rst | 46 + docs/formatdomaincaps.rst | 27 +- src/conf/domain_capabilities.c | 48 + src/conf/domain_capabilities.h | 12 + src/conf/domain_conf.c | 25 + src/conf/domain_conf.h | 9 + src/conf/domain_validate.c | 1 + src/conf/schemas/domaincaps.rng | 36 + src/conf/schemas/domaincommon.rng | 26 + src/conf/virconftypes.h | 2 + src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 146 + src/qemu/qemu_capabilities.h | 4 + src/qemu/qemu_cgroup.c | 2 + src/qemu/qemu_command.c | 30 + src/qemu/qemu_driver.c | 2 + src/qemu/qemu_firmware.c | 18 + src/qemu/qemu_monitor.c | 10 + src/qemu/qemu_monitor.h | 3 + src/qemu/qemu_monitor_json.c | 111 + src/qemu/qemu_monitor_json.h | 4 + src/qemu/qemu_namespace.c | 2 + src/qemu/qemu_process.c | 4 + src/qemu/qemu_validate.c | 4 + src/security/security_dac.c | 2 + .../qemu_10.1.0-virt.aarch64+armrme.xml | 250 + .../qemu_10.1.0.aarch64+armrme.xml | 250 + tests/qemucapabilitiesdata/README.rst | 5 + .../caps_10.1.0_aarch64+armrme.replies | 37727 ++++++++++++++++ .../caps_10.1.0_aarch64+armrme.xml | 518 + .../qemu/firmware/50-edk2-aarch64-armcca.json | 24 + tests/qemufirmwaretest.c | 3 + ...ch-security-cca.aarch64-latest+armrme.args | 30 + ...nch-security-cca.aarch64-latest+armrme.xml | 24 + tests/qemuxmlconfdata/launch-security-cca.xml | 16 + tests/qemuxmlconftest.c | 2 + 36 files changed, 39423 insertions(+), 1 deletion(-) create mode 100644 tests/domaincapsdata/qemu_10.1.0-virt.aarch64+armrme.xml create mode 100644 tests/domaincapsdata/qemu_10.1.0.aarch64+armrme.xml create mode 100644 tests/qemucapabilitiesdata/caps_10.1.0_aarch64+armrme.replies create mode 100644 tests/qemucapabilitiesdata/caps_10.1.0_aarch64+armrme.xml create mode 100644 tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-aarch64-armcca.json create mode 100644 tests/qemuxmlconfdata/launch-security-cca.aarch64-latest+armrme.args create mode 100644 tests/qemuxmlconfdata/launch-security-cca.aarch64-latest+armrme.xml create mode 100644 tests/qemuxmlconfdata/launch-security-cca.xml -- 2.43.0

1 5

[PATCH v1 0/4] Adding support for client-based FD migrations.
by Tejus GK 22 Jan '26

22 Jan '26

Libvirt supports FD-based live migrations in the form of tunnelled migrations. However, this isn't as performant as of now, since it involves extra copies. This patchset proposes adding support for externally provided file descriptors for live migration. By allowing the client to supply the migration FD directly, the extra copy can be avoided, improving overall migration performance. The intent is to gather early feedback on the approach and its feasibility. Comments, concerns, and suggestions are very welcome :) regards, Tejus Tejus GK (4): qemu: fd: introduce qemuFDTuple for FD storage lib: introduce virDomainFDStore API qemu: support incoming "fd" uri qemu: add support for fd based live migrations include/libvirt/libvirt-domain.h | 9 +++ src/driver-hypervisor.h | 7 ++ src/libvirt-domain.c | 62 +++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_conf.h | 4 + src/qemu/qemu_driver.c | 41 ++++++++++ src/qemu/qemu_fd.c | 23 ++++++ src/qemu/qemu_fd.h | 14 ++++ src/qemu/qemu_migration.c | 117 +++++++++++++++++++++++++++- src/remote/remote_daemon_dispatch.c | 36 +++++++++ src/remote/remote_driver.c | 22 ++++++ src/remote/remote_protocol.x | 12 ++- 12 files changed, 348 insertions(+), 4 deletions(-) -- 2.43.7

2 11

[PATCH 0/2] src: Use device alias when ifname is unset in virDomainInterfaceAddresses()
by Michal Privoznik 21 Jan '26

21 Jan '26

*** BLURB HERE *** Michal Prívozník (2): libvirt-domain: Fix documentation of virDomainInterfaceAddresses() src: Use device alias when ifname is unset in virDomainInterfaceAddresses() src/conf/domain_conf.c | 16 ++++++++++++++-- src/libvirt-domain.c | 4 +++- 2 files changed, 17 insertions(+), 3 deletions(-) -- 2.52.0

2 3

[PATCH 0/3] Add info used by AppArmor to domstatus XML
by Wesley Hershberger 20 Jan '26

20 Jan '26

This series has two independent changes following from a thread back in November (#692) [1][2]. Broadly speaking I agree that regenerating the apparmor profile from scratch feels fragile. That said, this issue has been on my back burner for a while; it's out of scope for me to take on that (much larger) effort. I'm including the first patch for completeness' sake, as all blockcommit operations fail without it when using the AppArmor driver (#806 [3]). It was rejected in 2017 but is still carried in Ubuntu [4]. Feel free not to pull it - the solution to that issue is separate and not my primary concern. I can send a new version of patch 3 that applies without it. My understanding is that the domstatus XML is only used by libvirt internally (stored in /var/run to persist runtime info over libvirtd restarts). Since this is the case, I haven't included documentation for the new items here; please let me know if I missed where they should be documented. I'm happy to consider this a first draft; feedback is welcome. I've opened a MR to libvirt-tck with test cases that demonstrate the bugs that this fixes [5]. Those tests pass with the series applied. Thanks for your consideration. ~Wesley [1] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/QUJI… [2] https://gitlab.com/libvirt/libvirt/-/issues/692 [3] https://gitlab.com/libvirt/libvirt/-/issues/806 [4] https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/3WID… [5] https://gitlab.com/libvirt/libvirt-tck/-/merge_requests/73 --- Serge Hallyn (1): virt-aa-helper: Ask for no deny rule for readonly disk elements Wesley Hershberger (2): qemu: Store tapfd path in domstatus XML qemu: Store blockcommit permissions in domstatus XML src/conf/domain_conf.c | 17 +++++++++++++++++ src/conf/domain_conf.h | 1 + src/conf/storage_source_conf.c | 2 ++ src/conf/storage_source_conf.h | 3 +++ src/qemu/qemu_block.c | 26 ++++++++++++++++++++++++++ src/qemu/qemu_blockjob.c | 8 ++++++++ src/qemu/qemu_command.c | 9 +++++++++ src/qemu/qemu_security.c | 7 +++++++ src/security/security_apparmor.c | 1 + src/security/virt-aa-helper.c | 14 ++++++++------ 10 files changed, 82 insertions(+), 6 deletions(-) --- base-commit: 16804acf14616d7357ad6a336f2ffd6d255a8d63 change-id: 20260105-apparmor-races-d03238ee4d93 Best regards, -- Wesley Hershberger <wesley.hershberger(a)canonical.com>

3 10

[PATCH] virnetdevtap: Produce more helpful error message in virNetDevTapCreate()
by Michal Privoznik 20 Jan '26

20 Jan '26

From: Michal Privoznik <mprivozn(a)redhat.com> Since v10.8.0-rc1~133 a different error is reported from virNetDevTapCreate() when the tap device already exists (and <interface/> XML specifies managed='no'). But the change covers only one scenario: if multique was requested in <inteface/> XML BUT pre-created tap device doesn't have multi_queue flag set. The opposite scenario: if the device has the multi_queue flag set BUT no multique was specified in the XML is missing. Until now. Resolves: https://issues.redhat.com/browse/RHEL-118303 Fixes: f6fb097e11a15e390d989411b2660ead0d1a7c10 Fixes: 465a38154f0cfc31d62c4105770e1f4a9599a611 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/util/virnetdevtap.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index b709d76cc7..e3a6209642 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -230,11 +230,16 @@ int virNetDevTapCreate(char **ifname, } if (ioctl(fd, TUNSETIFF, &ifr) < 0) { - if (flags & VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING && - tapfdSize > 1) { - virReportSystemError(errno, - _("Unable to create multiple fds for tap device %1$s (maybe existing device was created without multi_queue flag)"), - *ifname); + if (flags & VIR_NETDEV_TAP_CREATE_ALLOW_EXISTING) { + if (tapfdSize > 1) { + virReportSystemError(errno, + _("Unable to create multiple fds for tap device %1$s (maybe existing device was created without multi_queue flag)"), + *ifname); + } else { + virReportSystemError(errno, + _("Unable to set tap device %1$s (maybe existing device was created with multi_queue flag but device XML lacks 'queues' greater than one)"), + *ifname); + } } else { virReportSystemError(errno, _("Unable to create tap device %1$s"), -- 2.52.0

2 1

[PATCH] esx: Allow connecting to IPv6 server
by Michal Privoznik 20 Jan '26

20 Jan '26

From: Michal Privoznik <mprivozn(a)redhat.com> When connecting to a VMWare server, the hostname from URI is resolved using esxUtil_ResolveHostname() which in turn calls getaddrinfo(). But in the hints argument, we restrict the return address to be IPv4 (AF_INET) which obviously fails if the address to resolve is an IPv6 address. Set the hint to AF_UNSPEC which allows both IPv4 and IPv6. While at it, also allow IPv4 addresses mapped in IPv6 by setting AI_V4MAPPED flag. Resolves: https://issues.redhat.com/browse/RHEL-138300 Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/esx/esx_util.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/esx/esx_util.c b/src/esx/esx_util.c index 88b3dc893f..a6275babd5 100644 --- a/src/esx/esx_util.c +++ b/src/esx/esx_util.c @@ -275,8 +275,8 @@ esxUtil_ResolveHostname(const char *hostname, char **ipAddress) int errcode; g_autofree char *address = NULL; - hints.ai_flags = AI_ADDRCONFIG; - hints.ai_family = AF_INET; + hints.ai_flags = AI_ADDRCONFIG | AI_V4MAPPED; + hints.ai_family = AF_UNSPEC; hints.ai_socktype = SOCK_STREAM; hints.ai_protocol = 0; -- 2.52.0

3 2