- Devel - libvirt List Archives

[libvirt] [PATCH] docs: clarify nat range behavior
by Ján Tomko 18 Feb '15

18 Feb '15

All the addresses from the range are used, not just those that are in use on the host. https://bugzilla.redhat.com/show_bug.cgi?id=1079917 --- docs/formatnetwork.html.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index 7cf3f69..6abed8f 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -200,6 +200,8 @@ <p><span class="since">Since 1.0.3</span> it is possible to specify a public IPv4 address and port range to be used for the NAT by using the <code><nat></code> subelement. + Note that all addresses from the range are used, not just those + that are in use on the host. The address range is set with the <code><address></code> subelements and <code>start</code> and <code>stop</code> attributes: -- 2.0.5

3 2

[libvirt] [PATCH] libvirt-guests: Allow time sync on guests resume
by Michal Privoznik 18 Feb '15

18 Feb '15

Well, imagine domains were running, and as the host went down, they were managesaved. Later, after some time, the host went up again and domains got restored. But without correct time. And depending on how long was the host shut off, it may take some time for ntp to sync the time too. But hey, wait a minute. We have an API just for that! So: 1) Introduce SYNC_TIME variable in libvirt-guests.sysconf to allow users control over the new functionality 2) Call 'virsh domtime --sync $dom' in the libvirt-guests script. Unfortunately, this is all-or-nothing approach (just like anything else with the script). Domains are required to have configured and running qemu-ga inside. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/libvirt-guests.sh.in | 6 ++++++ tools/libvirt-guests.sysconf | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/tools/libvirt-guests.sh.in b/tools/libvirt-guests.sh.in index 1b17bbe..21e39b0 100644 --- a/tools/libvirt-guests.sh.in +++ b/tools/libvirt-guests.sh.in @@ -171,7 +171,9 @@ start() { isfirst=true bypass= + sync_time=false test "x$BYPASS_CACHE" = x0 || bypass=--bypass-cache + test "x$SYNC_TIME" = x0 || sync_time=true while read uri list; do configured=false set -f @@ -206,6 +208,10 @@ start() { retval run_virsh "$uri" start $bypass "$name" \ >/dev/null && \ gettext "done"; echo + if "$sync_time"; then + retval run_virsh "$uri" domtime --sync "$name" \ + >/dev/null + fi fi fi done diff --git a/tools/libvirt-guests.sysconf b/tools/libvirt-guests.sysconf index d1f2051..03e732f 100644 --- a/tools/libvirt-guests.sysconf +++ b/tools/libvirt-guests.sysconf @@ -39,3 +39,10 @@ # restoring guests, even though this may give slower operation for # some file systems. #BYPASS_CACHE=0 + +# If non-zero, try to sync guest time on a domain resume. Be aware, that +# this requires guest agent, which, moreover, has to run under supported +# system. For instance, qemu-ga doesn't support guest time synchronization +# on Windows guests, but Linux ones. By default, this piece of +# functionality is turned off. +#SYNC_TIME=1 -- 2.0.5

3 2

[libvirt] [PATCH] Fix reporting of i/o errors by iohelper process
by Jason J. Herne 18 Feb '15

18 Feb '15

From: "Jason J. Herne" <jjherne(a)us.ibm.com> libvirt_iohelper is a helper process that is exec'ed and used to handle I/O during a Qemu managed save operation. Due to a missing call to virFileWrapperFdClose, all I/O error messages reported by iohelper are lost. This patch adds a call to virFileWrapperFdClose to the cleanup phase of qemuDomainSaveMemory. This patch also modifies virFileWrapperFdClose such that errors are only reported when the length of the err_msg buffer is > 0. Before now, the existence of the buffer would trigger error reporting in virFileWrapperFdClose. Signed-off-by: Jason J. Herne <jjherne(a)us.ibm.com> --- src/qemu/qemu_driver.c | 1 + src/util/virfile.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index ecccf6c..8d78805 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3015,6 +3015,7 @@ qemuDomainSaveMemory(virQEMUDriverPtr driver, cleanup: VIR_FORCE_CLOSE(fd); + virFileWrapperFdClose(wrapperFd); virFileWrapperFdFree(wrapperFd); VIR_FREE(xml); diff --git a/src/util/virfile.c b/src/util/virfile.c index 463064c..813b4f5 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -322,7 +322,7 @@ virFileWrapperFdClose(virFileWrapperFdPtr wfd) return 0; ret = virCommandWait(wfd->cmd, NULL); - if (wfd->err_msg) + if (wfd->err_msg && strlen(wfd->err_msg)) VIR_WARN("iohelper reports: %s", wfd->err_msg); return ret; -- 1.8.3.2

4 8

[libvirt] libxl and non-absolute paths
by Stefan Bader 18 Feb '15

18 Feb '15

Just recently we moved to libvirt 1.2.12 for the next release. Which brought up a few problems when working with configs which we and Debian used to have. A mild complaint towards the xml validation: it would be really nice of that would be a bit more specific about what exactly it complains. It took me a while to realize that "Extra element os in interleave" was trying to tell me that the string of the loader element within the os section was not an absolute path. The issue here is that with libxl, I think the goal was to rather allow the library to select the path prefix (like for pygrub where the full path got removed recently). But now the xml validation disagrees. This would go for bootloader for xenpv and loader (within os) for xenfv. And for emulator in the device section. Though for that things are a bit more complicated. The libxl driver now calls that with the help option and decides from the output whether this is the "traditional" xen forked qemu or the upstream qemu binary. Then it selects the device model depending on that outcome. Not sure whether the libxl driver could query libxl for the path prefix. Right now the most straight forward way seems to move back to a full path for the emulator. At least now, by using the standard qemu binary for everything, we got a predictable path that does not change with Xen versions. So its possible to force migrate over to put /usr/bin/qemu-system-i386 there. But for loader and bootloader, do you think it reasonable to change the templates from absFilePath to filePath? -Stefan --- libvirt-1.2.12.orig/docs/schemas/domaincommon.rng 2015-01-23 12:46:24.0000 +++ libvirt-1.2.12/docs/schemas/domaincommon.rng 2015-02-13 10:00:43.1616 @@ -258,7 +258,7 @@ </choice> </attribute> </optional> - <ref name="absFilePath"/> + <ref name="filePath"/> </element> </optional> <optional> @@ -1060,7 +1060,7 @@ <optional> <element name="bootloader"> <choice> - <ref name="absFilePath"/> + <ref name="filePath"/> <empty/> </choice> </element>

4 6

[libvirt] [Patch 0/4] PowerPC fixes for libvirt
by Prerna Saxena 18 Feb '15

18 Feb '15

This patch set addresses some miscellaneous fixes for libvirt on PowerPC. Details: Patch 1/4 : This adds 'qemu-system-ppc64' as the default emulator for ppc64 & ppc64le guests. Patch 2/4 : Fixes a small error where not specifying a CPU model leads to a NULL compat specification. Patch 3/4 : This introduces 'ppc64le' and newer pseries machine types to domain schema. Patch 4/4 : Forbids floppy devices in domain XML. Regards, -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

2 10

[libvirt] [PATCH 0/2] libxl: fix handling of fd and timer registrations
by Jim Fehlig 18 Feb '15

18 Feb '15

This small series fixes some assertions we occasionally see in the libxl driver when running libvirt-TCK. The assertions were due to races between destroying per-domain libxl_ctx and receiving fd and timer callbacks associated with them. The races are masked by setting DEBUG loglevel in libvirtd.conf, so often missed by automated test setups that want DEBUG loglevel. Patch 1 actually fixes the assertions. Patch2 fixes a stupid mistake. See the commit messages for details. Jim Fehlig (2): libxl: fix fd and timer event handling libxl: Move setup of child processing code to driver initialization src/libxl/libxl_domain.c | 244 +---------------------------------------------- src/libxl/libxl_driver.c | 212 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 212 insertions(+), 244 deletions(-) -- 1.8.4.5

2 5

[libvirt] [PATCH 0/3] Prevent removing a in-used static bridge and destroying a in-used virtual network
by Lin Ma 18 Feb '15

18 Feb '15

* Get the live state info of a virtual network through netcf in networkGetXMLDesc. * Add --system flag for net-dumpxml to show the live state info. * Check the live state info in net-destroy. * Add --force flag for net-destroy to forcibly destroy the virtual network. * Check the transient interfaces info in iface-unbridge. --- Lin Ma (3): bridge_driver: Return the live state info of a given virtual network virsh: prevent destroying a in-used network for net-destroy virsh: prevent removing a in-used bridge for iface-unbridge include/libvirt/libvirt-network.h | 1 + src/Makefile.am | 3 + src/network/bridge_driver.c | 141 ++++++++++++++++++++++++++++++++++- src/network/bridge_driver_platform.h | 7 ++ tests/Makefile.am | 4 + tools/virsh-interface.c | 25 ++++++- tools/virsh-network.c | 62 ++++++++++++++- tools/virsh.pod | 8 +- 8 files changed, 241 insertions(+), 10 deletions(-) -- 1.8.4

5 25

[libvirt] [PATCH v2 0/4] Introduce display of IOThreads Information
by John Ferlan 17 Feb '15

17 Feb '15

v1: http://www.redhat.com/archives/libvir-list/2015-February/msg00402.html Changes since v1: * Remove 'thread_id' from public display * Add --live, --config, --current flags * Adjust patch 1 to accept/check the flags, modify comments * Adjust patch 3 to handle 'Live' or 'Config' options. Moved most of v1 patch code into the *Live function and add the *Config function to generate the IOThread config data * Adjust patch 4 to allow/check live/config options and set flags John Ferlan (4): Implement public API for virDomainGetIOThreadsInfo remote: Implement the remote plumbing for virDomainGetIOThreads qemu: Implement the qemu driver fetch for IOThreads virsh: Add 'iothreads' command daemon/remote.c | 74 ++++++++++++- include/libvirt/libvirt-domain.h | 21 +++- src/driver-hypervisor.h | 8 +- src/libvirt-domain.c | 75 +++++++++++++- src/libvirt_public.syms | 6 ++ src/qemu/qemu_driver.c | 217 +++++++++++++++++++++++++++++++++++++++ src/remote/remote_driver.c | 81 ++++++++++++++- src/remote/remote_protocol.x | 28 ++++- src/remote_protocol-structs | 19 ++++ src/rpc/gendispatch.pl | 1 + tools/virsh-domain.c | 94 +++++++++++++++++ tools/virsh.pod | 12 +++ 12 files changed, 629 insertions(+), 7 deletions(-) -- 2.1.0

1 5

[libvirt] [PATCH] qemu_cgroup: initialize mem_mask to NULL
by Pavel Hrdina 17 Feb '15

17 Feb '15

If 'virNumaGetHostNodeset()' fails then the error path will try to free uninitialized pointer mem_mask. Introduced by commit af2a1f058. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under trivial rule. src/qemu/qemu_cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index fc46450..7b8eed0 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -791,32 +791,32 @@ qemuInitCgroup(virQEMUDriverPtr driver, static void qemuRestoreCgroupState(virDomainObjPtr vm) { - char *mem_mask; + char *mem_mask = NULL; int empty = -1; qemuDomainObjPrivatePtr priv = vm->privateData; virBitmapPtr all_nodes; if (!(all_nodes = virNumaGetHostNodeset())) goto error; if (!(mem_mask = virBitmapFormat(all_nodes))) goto error; if ((empty = virCgroupHasEmptyTasks(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET)) <= 0) goto error; if (virCgroupSetCpusetMems(priv->cgroup, mem_mask) < 0) goto error; cleanup: VIR_FREE(mem_mask); virBitmapFree(all_nodes); return; error: virResetLastError(); VIR_DEBUG("Couldn't restore cgroups to meaningful state"); goto cleanup; } -- 2.0.5

1 0

[libvirt] [PATCH] qemu: fix vm deadlock when try to use numatune in session mode
by Luyao Huang 17 Feb '15

17 Feb '15

https://bugzilla.redhat.com/show_bug.cgi?id=1126762 commit 43b67f introduce a deadlock issue when we use numatune to change numa settings to a vm in session mode. Jump to endjob instead of jump to cleanup. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 709f468..1bbbe9b 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9495,7 +9495,7 @@ qemuDomainSetNumaParameters(virDomainPtr dom, flags & VIR_DOMAIN_AFFECT_LIVE) { virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", _("NUMA tuning is not available in session mode")); - goto cleanup; + goto endjob; } if (flags & VIR_DOMAIN_AFFECT_LIVE) { -- 1.8.3.1

2 1

[libvirt] Fwd: libvirt 1.2.10 and latest EL6 qemu-kvm
by Franky Van Liedekerke 17 Feb '15

17 Feb '15

Since there was no reaction in the user list, I'm posting it in the devel in the hope for some guidance to the problem mentioned below (sorry about this). Franky ---------- Forwarded message ---------- From: Franky Van Liedekerke <franky(a)e-dynamics.be> Date: Wed, Feb 11, 2015 at 3:44 PM Subject: Re: libvirt 1.2.10 and latest EL6 qemu-kvm To: libvirt-users(a)redhat.com (I'm sorry, I didn't find my original message but I provide the archive link: https://www.redhat.com/archives/libvirt-users/2015-January/msg00069.html ) I just tried the latest libvirt release (1.2.12), combined with the following qemu EL6 package from centos: qemu-kvm-0.12.1.2-2.448.el6_6.x86_64 Using 1.2.12 and this version of qemu-kvm, I still get the following error when trying to start a domain: error: Failed to start domain btcab0001ap.unix.banksys.be error: internal error: unable to execute QEMU command 'qom-list': The command qom-list has not been found The older qemu package (qemu-kvm-0.12.1.2-2.415.el6_5.14.x86_64) works just fine though (I also tried the qemu-rhev-packages for el6 from ovirt, but no change). I verified the changelog from libvirt 1.2.12 and the earlier suggested fix is in there (but doesn't seem to change anything): 2015-01-14 Pavel Hrdina <phrdina(a)redhat.com> qemu_monitor: introduce new function to get QOM path Now, I have activated libvirtd debug and these are the qom-list lines (I can provide the full logfile if wanted): 2015-02-11 14:10:33.259+0000: 13280: debug : virJSONValueToString:1528 : result={"execute":"qom-list","arguments":{"path":"/machine/unattached/device[0]"},"id":"libvirt-5"} 2015-02-11 14:10:33.259+0000: 13280: debug : qemuMonitorJSONCommandWithFd:290 : Send command '{"execute":"qom-list","arguments":{"path":"/machine/unattached/device[0]"},"id":"libvirt-5"}' for write with FD -1 2015-02-11 14:10:33.259+0000: 13280: info : qemuMonitorSend:972 : QEMU_MONITOR_SEND_MSG: mon=0x7fa62801cbf0 msg={"execute":"qom-list","arguments":{"path":"/machine/unattached/device[0]"},"id":"libvirt-5"} 2015-02-11 14:10:33.260+0000: 13278: info : qemuMonitorIOWrite:503 : QEMU_MONITOR_IO_WRITE: mon=0x7fa62801cbf0 buf={"execute":"qom-list","arguments":{"path":"/machine/unattached/device[0]"},"id":"libvirt-5"} 2015-02-11 14:10:33.261+0000: 13278: info : qemuMonitorIOProcess:399 : QEMU_MONITOR_IO_PROCESS: mon=0x7fa62801cbf0 buf={"id": "libvirt-5", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2015-02-11 14:10:33.261+0000: 13278: debug : qemuMonitorJSONIOProcessLine:183 : Line [{"id": "libvirt-5", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}}] 2015-02-11 14:10:33.261+0000: 13278: debug : virJSONValueFromString:1361 : string={"id": "libvirt-5", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2015-02-11 14:10:33.261+0000: 13278: info : qemuMonitorJSONIOProcessLine:203 : QEMU_MONITOR_RECV_REPLY: mon=0x7fa62801cbf0 reply={"id": "libvirt-5", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2015-02-11 14:10:33.289+0000: 13280: debug : virJSONValueToString:1528 : result={"execute":"qom-list","arguments":{"path":"/machine/peripheral"},"id":"libvirt-7"} 2015-02-11 14:10:33.289+0000: 13280: debug : qemuMonitorJSONCommandWithFd:290 : Send command '{"execute":"qom-list","arguments":{"path":"/machine/peripheral"},"id":"libvirt-7"}' for write with FD -1 2015-02-11 14:10:33.289+0000: 13280: info : qemuMonitorSend:972 : QEMU_MONITOR_SEND_MSG: mon=0x7fa62801cbf0 msg={"execute":"qom-list","arguments":{"path":"/machine/peripheral"},"id":"libvirt-7"} 2015-02-11 14:10:33.289+0000: 13278: info : qemuMonitorIOWrite:503 : QEMU_MONITOR_IO_WRITE: mon=0x7fa62801cbf0 buf={"execute":"qom-list","arguments":{"path":"/machine/peripheral"},"id":"libvirt-7"} 2015-02-11 14:10:33.291+0000: 13278: info : qemuMonitorIOProcess:399 : QEMU_MONITOR_IO_PROCESS: mon=0x7fa62801cbf0 buf={"id": "libvirt-7", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2015-02-11 14:10:33.291+0000: 13278: debug : qemuMonitorJSONIOProcessLine:183 : Line [{"id": "libvirt-7", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}}] 2015-02-11 14:10:33.291+0000: 13278: debug : virJSONValueFromString:1361 : string={"id": "libvirt-7", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2015-02-11 14:10:33.291+0000: 13278: info : qemuMonitorJSONIOProcessLine:203 : QEMU_MONITOR_RECV_REPLY: mon=0x7fa62801cbf0 reply={"id": "libvirt-7", "error": {"class": "CommandNotFound", "desc": "The command qom-list has not been found", "data": {"name": "qom-list"}}} 2015-02-11 14:10:33.291+0000: 13280: debug : virJSONValueToString:1528 : result={"execute":"qom-list","arguments":{"path":"/machine/peripheral"},"id":"libvirt-7"} 2015-02-11 14:10:33.292+0000: 13280: debug : virJSONValueToString:1528 : result={"id":"libvirt-7","error":{"class":"CommandNotFound","desc":"The command qom-list has not been found","data":{"name":"qom-list"}}} 2015-02-11 14:10:33.292+0000: 13280: debug : qemuMonitorJSONCheckError:370 : unable to execute QEMU command {"execute":"qom-list","arguments":{"path":"/machine/peripheral"},"id":"libvirt-7"}: {"id":"libvirt-7","error":{"class":"CommandNotFound","desc":"The command qom-list has not been found","data":{"name":"qom-list"}}} 2015-02-11 14:10:33.292+0000: 13280: error : qemuMonitorJSONCheckError:381 : internal error: unable to execute QEMU command 'qom-list': The command qom-list has not been found (again: full log can be provided, but maybe that should be sent in private, I don't know if it is allowed as an attachment here). Any tips? Franky

3 3

[libvirt] Getting Introduced to the Community
by Gaurav Bansal 17 Feb '15

17 Feb '15

Hi, My name is Gaurav Bansal and I would like to introduce myself to the developers of this community. I'm (technically) a junior in the Computer Science degree program at Birla Institute of Technology and Science Pilani. I am well versed with Python, C/C++, Java, PHP and bash. I have been using the qemu tool and the virt-manager for almost 6 months now and I'm comfortable with it. I was very much fascinated with the concept of Virtualization and wanted to explore it more and what could be a better way to start off than KVM. I was having a look at the GSoC 2015 ideas <http://qemu-project.org/Google_Summer_of_Code_2015> page and the particular project of Running docker containers using virt-sandbox <http://qemu-project.org/Google_Summer_of_Code_2015#Running_docker_container…>. I have some basic information about the docker images and have worked using the libvirt API. I have also tried the proof of concept uploaded by Daniel for downloading the docker images. Could you please guide me through where should I look forward that would be helpful for the project? - Gaurav Bansal Github : https://github.com/gauravb7090 IRC : gauravb7090 LinkedIn <http://in.linkedin.com/in/gauravb7090/>

2 1

[libvirt] [PATCH] virsh: fix IP address in vncdisplay for listen type='network'
by Luyao Huang 17 Feb '15

17 Feb '15

Just like the fix for domdisplay in commit 1ba815. --- tools/virsh-domain.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index dc4a863..2506b89 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10269,6 +10269,18 @@ cmdVNCDisplay(vshControl *ctl, const vshCmd *cmd) listen_addr = virXPathString("string(/domain/devices/graphics" "[@type='vnc']/@listen)", ctxt); + if (!listen_addr) { + /* The subelement address - <listen address='xyz'/> - + * *should* have been automatically backfilled into its + * parent <graphics listen='xyz'> (which we just tried to + * retrieve into listen_addr above) but in some cases it + * isn't, so we also do an explicit check for the + * subelement (which, by the way, doesn't exist on libvirt + * < 0.9.4, so we really do need to check both places) + */ + listen_addr = virXPathString("string(/domain/devices/graphics" + "[@type='vnc']/listen/@address)", ctxt); + } if (listen_addr == NULL || STREQ(listen_addr, "0.0.0.0")) vshPrint(ctl, ":%d\n", port-5900); else -- 1.8.3.1

3 2

[libvirt] [PATCH] Comment out variables/functions that are unused.
by Gary R Hook 16 Feb '15

16 Feb '15

Avoids complaints when the compiler is configured to "warn-unused". A few files contain unnecessary code that results in the compiler erroring out when -Wunused* options are used. Comment out the code until such time as it is needed. --- src/libxl/libxl_conf.c | 2 ++ tests/virnetsockettest.c | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 0555b91..f8db4d2 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -305,7 +305,9 @@ libxlCapsInitGuests(libxl_ctx *ctx, virCapsPtr caps) regmatch_t subs[4]; char *saveptr = NULL; size_t i; +/* virArch hostarch = caps->host.arch; +*/ struct guest_arch guest_archs[32]; int nr_guest_archs = 0; diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index 5d91f26..988ab43 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -333,9 +333,10 @@ static int testSocketUNIXAddrs(const void *data ATTRIBUTE_UNUSED) return ret; } +/* static int testSocketCommandNormal(const void *data ATTRIBUTE_UNUSED) { - virNetSocketPtr csock = NULL; /* Client socket */ + virNetSocketPtr csock = NULL; / * Client socket * / char buf[100]; size_t i; int ret = -1; @@ -360,10 +361,12 @@ static int testSocketCommandNormal(const void *data ATTRIBUTE_UNUSED) virObjectUnref(csock); return ret; } +*/ +/* static int testSocketCommandFail(const void *data ATTRIBUTE_UNUSED) { - virNetSocketPtr csock = NULL; /* Client socket */ + virNetSocketPtr csock = NULL; / * Client socket * / char buf[100]; int ret = -1; virCommandPtr cmd = virCommandNewArgList("/bin/cat", "/dev/does-not-exist", NULL); @@ -383,6 +386,7 @@ static int testSocketCommandFail(const void *data ATTRIBUTE_UNUSED) virObjectUnref(csock); return ret; } +*/ struct testSSHData { const char *nodename; -- 1.9.1

2 2

[libvirt] [PATCH] qemu: check the validity of a pointer
by Matthias Gatto 16 Feb '15

16 Feb '15

In the current code if mem_mask is NULL there is a "goto error", but we freeing it without knowing if mem_mask is NULL or not, therefor I've had a check. Signed-off-by: Matthias Gatto <matthias.gatto(a)outscale.com> --- src/qemu/qemu_cgroup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index ca255c8..926726c 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -810,7 +810,8 @@ qemuRestoreCgroupState(virDomainObjPtr vm) goto error; cleanup: - VIR_FREE(mem_mask); + if (mem_mask) + VIR_FREE(mem_mask); virBitmapFree(all_nodes); return; -- 1.8.3.1

2 1

[libvirt] [PATCH 0/2] Document virtlockd
by Daniel P. Berrange 16 Feb '15

16 Feb '15

Just some docs additions wrt virtlockd Daniel P. Berrange (2): docs: split out sanlock setup docs docs: add page about virtlockd setup docs/locking-lockd.html.in | 160 +++++++++++++++++++++++++ docs/locking-sanlock.html.in | 247 ++++++++++++++++++++++++++++++++++++++ docs/locking.html.in | 277 ++++++------------------------------------- docs/sitemap.html.in | 10 ++ 4 files changed, 450 insertions(+), 244 deletions(-) create mode 100644 docs/locking-lockd.html.in create mode 100644 docs/locking-sanlock.html.in -- 2.1.0

3 4

[libvirt] [PATCH 0/3] numatune: Prefer old approach
by Michal Privoznik 16 Feb '15

16 Feb '15

Consider the following part of domain XML: <numatune> <memory mode='static' nodeset="0,2"/> </numatune> <cpu> <numa> <cell id='0' cpus='0' memory='65536' unit='KiB'/> </numa> </cpu> Yes, this have a great potential of breaking things. Especially, this will break migration between previous two or three upstream releases and current release we are working on, because libvirt started domains in more complicated way (even if not needed). After these patches, domains will be started in simpler way which is incompatible. On the other hand, we get backward compatibility with much more releases than we are about to break. Michal Privoznik (3): numatune_conf: Expose virDomainNumatuneNodeSpecified qemuxml2argvtest: Fake response from numad qemuBuildMemoryBackendStr: Report backend requirement more appropriately src/conf/numatune_conf.c | 2 +- src/conf/numatune_conf.h | 3 +++ src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 6 ++++-- tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.args | 5 +++++ tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.xml | 2 +- .../qemuxml2argvdata/qemuxml2argv-numatune-auto-prefer.args | 5 +++++ tests/qemuxml2argvtest.c | 12 +++++++++++- 8 files changed, 31 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cputune-numatune.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-numatune-auto-prefer.args -- 2.0.5

3 6

[libvirt] [PATCH 0/2] Fix virFileFindResource in VPATH
by Jiri Denemark 16 Feb '15

16 Feb '15

Jiri Denemark (2): virFileFindResource: Add support for looking in source tree Search for schemas and cpu_map.xml in source tree src/Makefile.am | 2 ++ src/conf/domain_conf.c | 6 ++--- src/cpu/cpu_map.c | 6 ++--- src/driver.c | 1 + src/libvirt_private.syms | 1 + src/locking/lock_driver_lockd.c | 1 + src/locking/lock_manager.c | 1 + src/remote/remote_driver.c | 1 + src/util/virfile.c | 49 +++++++++++++++++++++++++++++++++-------- src/util/virfile.h | 12 +++++++++- 10 files changed, 64 insertions(+), 16 deletions(-) -- 2.3.0

2 4

[libvirt] why not shutdown the src vm to avoid split-brain
by zhang bo 15 Feb '15

15 Feb '15

In func doPeer2PeerMigrate3(), in the "finish" step, it checks whether domainMigrateFinish3() returns NULL or not. if it(ddomain) is NULL, it just restarts the guest on the source. Please consider the scenario that the ddomain has already been running on the dest, but it fails to tell the source this fact, and ddomain becomes NULL. If we then restart the guest on the source, there will be 2 same guests running on both sides, and a SPLIT-BRAIN occurs. It seems much better to stop them both , rather than leaving them both running. At least, when we found the ddomain is NULL, we should probably check whether the problem is caused by keepAlive failure, if so, kill the guest on the source rather than restarting it. How do you think about that? BTW, it says that: "The lock manager plugins should take care of safety in this scenario" in the comment, with the commit 2593f9692df0f128b14cde811e18aa49c1cf3e06, I don't quite understand that: 1) If we migrate the guest with the flag VIR_MIGRATE_NON_SHARED_DISK, then nbd server may take care of the data consistency, But before it starts the cpus on the dest, the nbd server is already stopped. So, at this moment, no one takes care of this problem. 2) If we migrate the guest with a shared disk, then does it mean that the nfs or other shareing-disk schemas should prevent split-brain by themselves?

1 0

[libvirt] [PATCH 0/3] fsfreeze and fsthaw API testing
by Jincheng Miao 15 Feb '15

15 Feb '15

Added guest agent conf to domain xml in order to test API fsfreeze and fsthaw. Jincheng Miao (3): add guest agent configuration to domain xml Add domain fsfreeze and fsthaw API testing Add fsfreeze fsthaw test case to linux_domain cases/linux_domain.conf | 18 +++++ repos/domain/domain_fsfreeze.py | 76 ++++++++++++++++++++ repos/domain/domain_fsthaw.py | 49 +++++++++++++ .../domain/xmls/kvm_linux_guest_install_cdrom.xml | 4 + repos/domain/xmls/kvm_linux_guest_install_net.xml | 20 +++-- 5 files changed, 159 insertions(+), 8 deletions(-) create mode 100644 repos/domain/domain_fsfreeze.py create mode 100644 repos/domain/domain_fsthaw.py

4 8

[libvirt] Tunnelled post-copy live migration - support of bidirectional communication over the tunnel
by Vojtech Cima 14 Feb '15

14 Feb '15

Hello everyone, we are very interested about the post-copy live migration mechanism in libvirt [1] using QEMU. Mentioning post-copy in this context means the setup with the first full iteration of standard pre-copy and then switching to the post-copy. VIR_MIGRATE_ENABLE_POSTCOPY, VIR_MIGRATE_POSTCOPY_AFTER_PRECOPY together with VIR_MIGRATE_TUNNELLED flag. Recently we have noticed the issue that post-copy live migration doesn't work over the tunnel since since current tunnel implementation in libvirt supports only uni-directional communication. I spent some time trying to enable bidirectional communication over the tunnel but still facing several issues and I would appreciate any hints how to move forward. The idea is to add a function (probably a callback function) responsible for handling the traffic in the opposite direction (dest->src) reading from the virStream and writing to the QEMU [2]. To be able to do so I replaced the current 'pipe' calls with the 'socketpair' calls to create bidirectional paths. Now, trying to use tunnelled post-copy live migration, it gets initiated, there is some traffic going from source to destination (obviously the pre-copy phase) but at some point it gets stuck on the 'saferead' function [3] which is now blocking. Can this issue issue be linked with the default socket blocking policy? Trying to use standard 'read' function instead of 'saferead' results that the lower data transfers and it seems it's missing significant part of information. Another point is that we suppose that the virStream on its own supports bidirectional communication, is that correct? [1] https://github.com/orbitfp7/qemu/tree/wp3-postcopy [2] http://libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_migration.c;h=… [3] http://libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_migration.c;h=… Thank you very much for any ideas on this topic. Regards, Vojtech

2 3

[libvirt] [PATCH v2] Comment out variables/functions that are unused.
by Gary R Hook 14 Feb '15

14 Feb '15

Avoids complaints when the compiler is configured to "warn-unused". A few files contain unnecessary code that results in the compiler erroring out when -Wunused* options are used. Comment out the code until such time as it is needed. Signed-off-by: Gary R Hook <gary.hook(a)nimboxx.com> --- src/libxl/libxl_conf.c | 2 ++ tests/virnetsockettest.c | 8 ++++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 0555b91..f8db4d2 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -305,7 +305,9 @@ libxlCapsInitGuests(libxl_ctx *ctx, virCapsPtr caps) regmatch_t subs[4]; char *saveptr = NULL; size_t i; +/* virArch hostarch = caps->host.arch; +*/ struct guest_arch guest_archs[32]; int nr_guest_archs = 0; diff --git a/tests/virnetsockettest.c b/tests/virnetsockettest.c index 5d91f26..988ab43 100644 --- a/tests/virnetsockettest.c +++ b/tests/virnetsockettest.c @@ -333,9 +333,10 @@ static int testSocketUNIXAddrs(const void *data ATTRIBUTE_UNUSED) return ret; } +/* static int testSocketCommandNormal(const void *data ATTRIBUTE_UNUSED) { - virNetSocketPtr csock = NULL; /* Client socket */ + virNetSocketPtr csock = NULL; / * Client socket * / char buf[100]; size_t i; int ret = -1; @@ -360,10 +361,12 @@ static int testSocketCommandNormal(const void *data ATTRIBUTE_UNUSED) virObjectUnref(csock); return ret; } +*/ +/* static int testSocketCommandFail(const void *data ATTRIBUTE_UNUSED) { - virNetSocketPtr csock = NULL; /* Client socket */ + virNetSocketPtr csock = NULL; / * Client socket * / char buf[100]; int ret = -1; virCommandPtr cmd = virCommandNewArgList("/bin/cat", "/dev/does-not-exist", NULL); @@ -383,6 +386,7 @@ static int testSocketCommandFail(const void *data ATTRIBUTE_UNUSED) virObjectUnref(csock); return ret; } +*/ struct testSSHData { const char *nodename; -- 1.9.1

2 1

[libvirt] [PATCH 0/2] Resolve a couple of Coverity issues
by John Ferlan 14 Feb '15

14 Feb '15

One new one and one that I've seen periodically. John Ferlan (2): security: Resolve Coverity RESOURCE_LEAK libxl: Resolve Coverity CHECKED_RETURN src/libxl/libxl_domain.c | 6 +++++- src/security/security_manager.c | 17 ++++++++++++----- 2 files changed, 17 insertions(+), 6 deletions(-) -- 2.1.0

2 4

[libvirt] [PATCH v4 0/3] lxc: fix show the wrong xml when guest start failed
by John Ferlan 13 Feb '15

13 Feb '15

This is a rework of the patch Luyao Huang sent to resolve a couple of issues found in virLXCStartProcess. See explanation here: http://www.redhat.com/archives/libvir-list/2015-February/msg00433.html John Ferlan (1): lxc: Modify/add some debug messages Luyao Huang (2): lxc: Move console checks in LXCProcessStart lxc: Fix container cleanup for LXCProcessStart src/lxc/lxc_process.c | 109 ++++++++++++++++++++++++-------------------------- 1 file changed, 52 insertions(+), 57 deletions(-) -- 2.1.0

2 7

[libvirt] [PATCH v2 0/4] attach-interface: Learn net type='direct'
by Michal Privoznik 13 Feb '15

13 Feb '15

v2 Michal Privoznik (4): libvirt_private.syms: Expose virDomainNetTypeFromString virsh attach-interface: Use enum instead of arbitrary integers virsh attach-interface: Use virDomainNetType{From,To}String() virsh attach-interface: Allow macvtap hotplug src/libvirt_private.syms | 1 + tools/virsh-domain.c | 36 ++++++++++++++++++++++++++---------- tools/virsh.pod | 14 ++++++++------ 3 files changed, 35 insertions(+), 16 deletions(-) -- 2.0.5

4 7