- Devel - libvirt List Archives

[libvirt] [PATCH] storage: sheepdog: Avoid skipping variable initialization
by Peter Krempa 02 Mar '15

02 Mar '15

Commit 155ca616eb231181f6978efc9e3a1eb0eb60af8a added a error message that skips initialization of the 'cmd' variable. Fortunately it was not released. --- Pushed under the trivial && build-breaker rule. src/storage/storage_backend_sheepdog.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/storage/storage_backend_sheepdog.c b/src/storage/storage_backend_sheepdog.c index f389d9b..af15c3b 100644 --- a/src/storage/storage_backend_sheepdog.c +++ b/src/storage/storage_backend_sheepdog.c @@ -263,6 +263,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn, unsigned int flags) { int ret = -1; + virCommandPtr cmd = NULL; virCheckFlags(0, -1); @@ -272,7 +273,7 @@ virStorageBackendSheepdogBuildVol(virConnectPtr conn, goto cleanup; } - virCommandPtr cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL); + cmd = virCommandNewArgList(COLLIE, "vdi", "create", vol->name, NULL); virCommandAddArgFormat(cmd, "%llu", vol->target.capacity); virStorageBackendSheepdogAddHostArg(cmd, pool); if (virCommandRun(cmd, NULL) < 0) -- 2.2.2

1 0

[libvirt] [libvirt-test-API][PATCH 0/2] Add freepages test cases
by Jincheng Miao 02 Mar '15

02 Mar '15

Add freepages test cases. Jincheng Miao (2): Add freepage test Add freepage test case to test_connection.conf cases/test_connection.conf | 6 +++ repos/virconn/free_pages.py | 97 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 103 insertions(+), 0 deletions(-) create mode 100644 repos/virconn/free_pages.py

2 3

[libvirt] Release of libvirt-1.2.13
by Daniel Veillard 02 Mar '15

02 Mar '15

As planned I just made the release for libvirt-1.2.13, it's tagged in git, and signed tarballs and rpms are available at the usual place: ftp://libvirt.org/libvirt/ I also pushed a 1.2.13 for libvirt-python but it's really for completeness as it's virtuallyequivalent to 1.2.12. February is short, that release packs 'only' 220 commits, mostly bug fixes and a fair set of improvment, with the NUMA handling area getting a fairly large update: Features: - a lot of NUMA updates and improvments (Peter Krempa) Documentation: - Add mist.io as libvirt-based application (Michal Privoznik) - Fix typos in messages (Yuri Chornoivan) - Clarify behavior or virDomainDetachDevice (Ján Tomko) - virsh: Add missing parenthesis into man page (Martin Kletzander) - man: moved virsh command cpu-models (Daniel Hansel) - clarify nat range behavior (Ján Tomko) - add page about virtlockd setup (Daniel P. Berrange) - split out sanlock setup docs (Daniel P. Berrange) - Fix version reference in vcpu/iothread scheduling (Martin Kletzander) - S390: Documentation for ccw address type (Stefan Zimmermann) - conf: fix a minor typo (Erik Skultety) - virsh: man: Document behavior of some blkdeviotune's flags when querying (Peter Krempa) Portability: - virprocess: fix MinGW build and RHEL-5 build (Pavel Hrdina) - virutil: fix MinGW build (Pavel Hrdina) - Make tests independant of system page size (Daniel P. Berrange) Bug Fixes: - Really fix XML formatting flags in SaveImageUpdateDef (Ján Tomko) - Ignore listen attribute of <graphics> for type network listens (Ján Tomko) - util: storage: Fix error type in virStorageSourceParseBackingURI (Peter Krempa) - util: storagefile: Don't crash on gluster URIs without path (Peter Krempa) - conf: error out on invalid host id (Luyao Huang) - qemu: fix ifindex array reported to systemd (Laine Stump) - util: check for null ifname inside virNetDevBandwidthSet() (Laine Stump) - network: only clear bandwidth if it has been set (Laine Stump) - Fix error messages in virStorageFileGetMetadataFromFD (Ján Tomko) - Assign default SCSI controller model before checking attribute validity (Ján Tomko) - qemu: Use correct flags for ABI stability check in SaveImageUpdateDef (Michal Privoznik) - qemu: fix memory leak while starting a guest (Pavel Hrdina) - network_conf: Forbid commas in DNS TXT (Michal Privoznik) - qemuMigrationDriveMirror: Listen to events (Michal Privoznik) - qemu: Exit job on error path of qemuDomainSetVcpusFlags() (Peter Krempa) - daemon: Fix segfault by reloading daemon right after start (Pavel Hrdina) - qemu_cgroup: initialize mem_mask to NULL (Pavel Hrdina) - PowerPC : Forbid NULL CPU model with 'host-model' mode. (Prerna Saxena) - qemu: fix vm deadlock when try to use numatune in session mode (Luyao Huang) - virsh: fix IP address in vncdisplay for listen type='network' (Luyao Huang) - libxl: Resolve Coverity CHECKED_RETURN (John Ferlan) - security: Resolve Coverity RESOURCE_LEAK (John Ferlan) - lxc: Fix container cleanup for LXCProcessStart (Luyao Huang) - lxc: Move console checks in LXCProcessStart (Luyao Huang) - security: Refactor virSecurityManagerGenLabel (Erik Skultety) - security: introduce virSecurityManagerCheckAllLabel function (Erik Skultety) - Fix a syntax error in the description text of libvirtd.conf (Zhang Bo) - Allow shrinking of file based volumes (Daniel P. Berrange) - qemu: do upfront check for vcpupids being null when querying pinning (Daniel P. Berrange) - qemu: fix setting of VM CPU affinity with TCG (Daniel P. Berrange) - libxl: disable VNC and SDL until explicitly enabled (Marek Marczykowski-Górecki) - libxl: pass ipaddr to libxl toolstack (Marek Marczykowski-Górecki) - domain: avoid potential memory leak in virDomainGraphicsListenSet*() (Laine Stump) - domain: backfill listen address to parent <graphics> listen attribute (Laine Stump) - virsh: fix IP address in domdisplay for listen type='network' (Luyao Huang) - bhyvexml2argvmock: change int to size_t for tapfdSize (Pavel Hrdina) - qemu: fix crash when migrateuri has no scheme (Luyao Huang) - conf: Fix libvirtd crash and memory leak caused by virDomainVcpuPinDel() (Zhang Bo) - conf: forbid seclabel duplicates for domain devices (Erik Skultety) - Fix qemu job handling in SetSchedulerParameters (Ján Tomko) - conf: disallow invalid values for video attributes (Martin Kletzander) - Clear dynamic seclabels on LXCProcessStart failure (Cédric Bosdonnat) - network: don't allow multiple portgroups with the same name in a network (Laine Stump) - Error out when custom tap device path makes no sense (Ján Tomko) - Only parse custom vhost path for virtio interfaces (Ján Tomko) - Trivially support DomainHasManagedSaveImage (Ján Tomko) - libxl: update dom->id in libxlDomainCreateWithFlags (Marek Marczykowski-Górecki) - qemu: Properly report error on uuid mismatch in the migration cookie (Luyao Huang) - lxc: fix double close handshakefds[1] (Luyao Huang) - util: storage: Fix parsing of nbd:// URI without path (Peter Krempa) - conf: Properly report error of unsupported input bus type (Luyao Huang) - conf: Properly report error when an unsupported chr device name is passed (Luyao Huang) - virnetdev: fix some issues found by coverity and mingw builds (Pavel Hrdina) - storage: Need to clear pool prior to refreshPool during Autostart (John Ferlan) - qemu: command: Don't combine old and modern NUMA node creation (Peter Krempa) - xend: Don't crash in virDomainXMLDevID (Michal Privoznik) - conf: Don't mangle vcpu placement randomly (Michal Privoznik) - qemu: Don't unconditionally delete file in qemuOpenFileAs (John Ferlan) - virfile: Need to check for ENOTCONN from recvfd failure (John Ferlan) - Remove flag checking in MacVLanCreate helper stub (Ján Tomko) - storage: Check the partition name against provided name (John Ferlan) - storage: Fix check for partition type for disk backing volumes (John Ferlan) - qemu: fix cannot set graphic passwd via qemuDomainSaveImageDefineXML (Luyao Huang) - hotplug: only add a chardev to vmdef after monitor call (Ján Tomko) - systemd: don't report an error if the guest is already terminated (Daniel P. Berrange) Improvements: - conf: error out on missing dhcp host attributes (Ján Tomko) - schema: Allow interleaving the /domain/os/type element (Peter Krempa) - schema: Add virtio-mmio address type into RNG (Martin Kletzander) - cpu: Format <cpu/> properly (Michal Privoznik) - virCPUDefFormatBufFull: Use our general error handling pattern (Michal Privoznik) - util: Introduce virBufferAddBuffer (Michal Privoznik) - Rework s390 architecture checking (Stefan Zimmermann) - Prevent default creation of usb controller on s390 and s390x (Stefan Zimmermann) - po: Add config file for zanata (Daniel P. Berrange) - libvirt-guests: Allow time sync on guests resume (Michal Privoznik) - qemu: Fix AAVMF/OVMF #define names (Cole Robinson) - libxl: support backend domain setting for disk and net devices (Marek Marczykowski) - conf: support backend domain name in disk and network devices (Marek Marczykowski) - network: allow <pf> together with <interface>/<address> in network status (Laine Stump) - qemu: caps: Add capability bit for the "pc-dimm" device (Peter Krempa) - conf: Hoist validation of memory size into the post parse callback (Peter Krempa) - conf: numa: Check ABI stability of NUMA configuration (Peter Krempa) - conf: ABI: Hugepage backing definition is not guest ABI (Peter Krempa) - conf: Move all NUMA configuration to virDomainNuma (Peter Krempa) - conf: numa: Add setter/getter for NUMA node memory size (Peter Krempa) - conf: numa: Add accessor to NUMA node's memory access mode (Peter Krempa) - conf: numa: Add accessor for the NUMA node cpu mask (Peter Krempa) - conf: numa: Add helper to get guest NUMA node count and refactor users (Peter Krempa) - qemu: command: Unify retrieval of NUMA cell count in qemuBuildNumaArgStr (Peter Krempa) - conf: numa: Don't pass double pointer to virDomainNumatuneParseXML (Peter Krempa) - numa: conf: Tweak parameters of virDomainNumatuneSet (Peter Krempa) - conf: numa: Always allocate the NUMA config (Peter Krempa) - conf: Allocate domain definition with the new helper (Peter Krempa) - conf: Separate helper for creating domain objects (Peter Krempa) - conf: numa: Format <numatune> XML only if necessary (Peter Krempa) - conf: numa: Refactor logic in virDomainNumatuneParseXML (Peter Krempa) - conf: numa: Reformat virDomainNumatuneParseXML (Peter Krempa) - conf: numa: Improve error message in case a numa node doesn't have cpus (Peter Krempa) - conf: numa: Recalculate rather than remember total NUMA cpu count (Peter Krempa) - conf: Move enum virMemAccess to the NUMA code and rename it (Peter Krempa) - conf: numa: Rename virDomainNumatune to virDomainNuma (Peter Krempa) - conf: Move NUMA cell formatter to numa_conf (Peter Krempa) - conf: numa: Don't duplicate NUMA cell cpumask (Peter Krempa) - conf: Refactor virDomainNumaDefCPUParseXML (Peter Krempa) - conf: Move NUMA cell parsing code from cpu conf to numa conf (Peter Krempa) - conf: Move numatune_conf to numa_conf (Peter Krempa) - virsh: fix vcpupin info (Pavel Hrdina) - virQEMUCapsCacheLookupCopy: Filter qemuCaps based on machineType (Michal Privoznik) - virQEMUCapsCacheLookupCopy: Pass machine type (Michal Privoznik) - virsh-edit: Make force editing usable (Martin Kletzander) - parallels: Set the first HDD from XML as bootable (Mikhail Feoktistov) - parallels: Use IS_CT() macro instead of STREQ("exe") (Mikhail Feoktistov) - parallels: code aligment (Mikhail Feoktistov) - Search for schemas and cpu_map.xml in source tree (Jiri Denemark) - qemuProcessHandleBlockJob: Take status into account (Michal Privoznik) - qemuProcessHandleBlockJob: Set disk->mirrorState more often (Michal Privoznik) - PowerPC : Make 'qemu-system-ppc64' the default emulator on ppc64[le]. (Prerna Saxena) - qemuBuildMemoryBackendStr: Report backend requirement more appropriately (Michal Privoznik) - qemuxml2argvtest: Fake response from numad (Michal Privoznik) - numatune_conf: Expose virDomainNumatuneNodeSpecified (Michal Privoznik) - lxc: Modify/add some debug messages (John Ferlan) - Wire up mrg_rxbuf option for qemu (Ján Tomko) - Add mrg_rxbuf option to virtio interfaces (Ján Tomko) - virsh attach-interface: Allow macvtap hotplug (Michal Privoznik) - virsh attach-interface: Use virDomainNetType{From,To}String() (Michal Privoznik) - virsh attach-interface: Use enum instead of arbitrary integers (Michal Privoznik) - libvirt_private.syms: Expose virDomainNetTypeFromString (Michal Privoznik) - qemu: Add support for setting vCPU and I/O thread scheduler setting (Martin Kletzander) - docs, schema, conf: Add support for setting scheduler parameters of guest threads (Martin Kletzander) - util: Add virProcessSetScheduler() function for scheduler settings (Martin Kletzander) - domain: include portgroup in interface status xml (Laine Stump) - qemu: qemuOpenFileAs - set flag VIR_FILE_OPEN_FORCE_MODE (John Ferlan) - virfile: Adjust error path for virFileOpenForked (John Ferlan) - schema: allow multiple seclabel for devices in domaincommon.rng (Erik Skultety) - qemu: Implement random number generator hotunplug (Luyao Huang) - qemu: Implement random number generator hotplug (Luyao Huang) - qemu: Implement random number generator cold (un)plug (Peter Krempa) - conf: Add helpers to insert/remove/find RNG devices in domain def (Luyao Huang) - audit: export virDomainAuditRNG (Luyao Huang) - qemu: command: Refactor creation of RNG device commandline (Peter Krempa) - qemu: command: Break some very long lines in qemuBuildRNGDevStr() (Peter Krempa) - qemu: command: Shuffle around formatting of alias for RNG device backend (Peter Krempa) - qemu: command: Make RNG backend device IDs unique (Luyao Huang) - qemu: refactor qemuBuildRNGDeviceArgs to allow reuse in RNG hotplug (Luyao Huang) - qemu: Add helper to assign RNG device aliases (Luyao Huang) - conf: Introduce helper to find duplicate device address (Peter Krempa) - S390: ccw support for virsh attach-disk address parameter (Stefan Zimmermann) - maint: improve usage of autogen's --no-git (Stefan Zimmermann) - qemu: include libvirt & QEMU versions in QEMU log files (Daniel P. Berrange) - nodedev: check/add for scsi_host caps for NumOfCaps and ListCaps (John Ferlan) - nodedev: check/add for scsi_host caps for ListDevices (Shivaprasad G Bhat) - cpu: add Freescale ppc64 CPU models (Olivia Yin) - tests: virstoragetest: Switch backing chain test to use automatic numbering (Peter Krempa) - virsh-volume: add support for --reflink (Chen Hanxiao) - util: make virNetDev(Get|Set)IFFlags() static (Laine Stump) - qemu: command: Refactor NUMA backend object formatting to use JSON objs (Peter Krempa) - qemu: command: Switch to bytes when formatting size for memory backends (Peter Krempa) - qemu: command: Unify values for boolean values when formating memory backends (Peter Krempa) - qemu: command: Shuffle around formating of alias for memory backend objs (Peter Krempa) - qemu: Extract code to setup memory backing objects (Peter Krempa) - qemu: command: Add helper to format -object strings from JSON representation (Peter Krempa) - util: json: add helper to iterate JSON object key=value pairs (Peter Krempa) - util: json: Add functions to convert JSON arrays from/to virBitmaps (Peter Krempa) - util: bitmap: Add option to allocate bitmap without reporting error (Peter Krempa) - util: json: make value object creator universal by supporting adding (Peter Krempa) - test: utils: Add helpers for automatic numbering of test cases (Peter Krempa) - conf: numatune: Extract code for requesting memory nodeset from formatting (Peter Krempa) - qemu: change macvtap device options in response to NIC_RX_FILTER_CHANGED (Tony Krowiak) - util: Functions for getting/setting device options (Tony Krowiak) - qemu: Adjust EndAsyncJob for qemuDomainSaveInternal error path (John Ferlan) - schemas: Allow all generic elements and attributes for all interfaces (Michal Privoznik) - qemu: Add AAVMF to the list of known UEFIs (Michal Privoznik) - qemu: Allow UEFI paths to be specified at compile time (Michal Privoznik) - Fix syntax-check (Ján Tomko) - util: bitmap: Tolerate NULL bitmaps in virBitmapEqual (Peter Krempa) - storage: When delete extended partition, need to refresh pool (John Ferlan) - storage: Adjust how to refresh extended partition disk data (John Ferlan) - storage: Attempt error recovery in virStorageBackendDiskCreateVol (John Ferlan) - storage: Move virStorageBackendDiskDeleteVol (John Ferlan) - libvirt.spec: remove vbox storage and network .so files (Pavel Hrdina) - Split qemuDomainChrInsert into two parts (Ján Tomko) - lxc: report veth device indexes to systemd (Daniel P. Berrange) - lxc: more logging during startup paths (Daniel P. Berrange) - lxc: delay setup of cgroup until we have the init pid (Daniel P. Berrange) - lxc: only write XML once for lxc controller (Daniel P. Berrange) - lxc: re-arrange startup synchronization sequence with controller (Daniel P. Berrange) - lxc: don't build pidfile string multiple times (Daniel P. Berrange) - qemu: report TAP device indexes to systemd (Daniel P. Berrange) - Fix shadowed variable warning (Ján Tomko) - storage: add a flag to clone files on btrfs (Chen Hanxiao) - storage: introduce btrfsCloneFile() for COW copy (Chen Hanxiao) - Removing probing of secondary drivers (Daniel P. Berrange) - don't disable state driver when libvirtd is not built (Daniel P. Berrange) - Remove all secondary driver private data fields (Daniel P. Berrange) - Remove use of interfacePrivateData from udev driver (Daniel P. Berrange) - Remove use of nodeDevicePrivateData from nodeDev driver (Daniel P. Berrange) - Remove use of storagePrivateData/networkPrivateData from vbox (Daniel P. Berrange) - Remove use of nwfilterPrivateData from nwfilter driver (Daniel P. Berrange) - Remove use of secretPrivateData from secret driver (Daniel P. Berrange) - qemu: Fix job handling in qemuDomainSetMetadata (Peter Krempa) - qemu: Fix job type in qemuDomainGetBlockIoTune (Peter Krempa) - qemu: Fix job handling in qemuDomainSetSchedulerParametersFlags (Peter Krempa) - qemu: Fix job handling in qemuDomainSetMemoryParameters (Peter Krempa) - qemu: Fix job handling in qemuDomainSetAutostart (Peter Krempa) - qemu: Fix job handling in qemuDomainPinEmulator (Peter Krempa) - qemu: Fix job handling in qemuDomainPinVcpuFlags (Peter Krempa) So thanks everyone for the help with this release, be it with reports, patches, reviews or documentation ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] docs: Add mist.io as libvirt-based application
by Michal Privoznik 01 Mar '15

01 Mar '15

As reported on the libvirt-users list [1], there's new web application called mist.io which uses libvirt as one of its backends. Lets add it into our list of libivrt based applications. 1: https://www.redhat.com/archives/libvirt-users/2015-February/msg00096.html Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/apps.html.in | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/apps.html.in b/docs/apps.html.in index 4403ce6..79ee73a 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -404,6 +404,14 @@ functions, such as live migration that allows for load balancing between cluster nodes, monitoring CPU, memory. </dd> + <dt><a href="http://mist.io/">mist.io</a></dt> + <dd> + Mist.io is an open source project and a service that can assist you in + managing your virtual machines on a unified way, providing a simple + interface for all of your infrastructure (multiple public cloud + providers, OpenStack based public/private clouds, Docker servers, bare + metal servers and now KVM hypervisors). + </dd> </dl> <h2><a name="mobile">Mobile applications</a></h2> -- 2.0.5

2 2

[libvirt] new warning from ar on rawhide systems
by Eric Blake 28 Feb '15

28 Feb '15

When compiling libvirt (and probably other packages) on Fedora rawhide systems, I'm seeing a new warning message on every link line. # rpm -q libtool gcc binutils libtool-2.4.6-1.fc23.x86_64 gcc-5.0.0-0.16.fc23.x86_64 binutils-2.25-6.fc23.x86_64 For an example of the warning during a 'make V=1': > libtool: link: rm -fr .libs/libvirt_driver_qemu_impl.a .libs/libvirt_driver_qemu_impl.la > libtool: link: ar cru .libs/libvirt_driver_qemu_impl.a qemu/.libs/libvirt_driver_qemu_impl_la-qemu_agent.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_capabilities.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_command.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_domain.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_cgroup.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_hostdev.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_hotplug.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_conf.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_process.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_migration.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_monitor.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_monitor_text.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_monitor_json.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_driver.o qemu/.libs/libvirt_driver_qemu_impl_la-qemu_interface.o > ar: `u' modifier ignored since `D' is the default (see `U') > libtool: link: ranlib .libs/libvirt_driver_qemu_impl.a Reading 'man ar', it looks like a relatively new binutils invention, one that Fedora chose to flip on by default, but also one that might be worth using even when ar is built with 'U' rather than 'D' as the default: > D Operate in deterministic mode. When adding files and the archive > index use zero for UIDs, GIDs, timestamps, and use consistent file > modes for all files. When this option is used, if ar is used with > identical options and identical input files, multiple runs will > create identical output files regardless of the input files' > owners, groups, file modes, or modification times. > > If binutils was configured with --enable-deterministic-archives, > then this mode is on by default. It can be disabled with the U > modifier, below. Is it worth teaching libtool to change ARFLAGS to be 'crD' instead of 'cru' when it is detected that ar is new enough to support deterministic libraries, in part to shut up the warning message being printed on every single libtool link line? (Note that I would explicitly include 'D', because even though Fedora chose to make 'D' the default, other distros may choose to make 'U' the default). Or conversely, do we want ARFLAGS to be 'cruU', to force non-deterministic mode, since any speedups made possible by timestamp comparison ('u') are only possible in non-deterministic mode? Does the use of 'u' buy us much measurable time when repeatedly and incrementally linking large libraries, where the new 'D' mode is forced to link everything instead of just the new inputs? And of course there's the question of how easy is it to detect that ar is new enough to understand the 'D'/'U' dichotomy? Is this something I should redirect to automake instead of libtool? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

2 1

[libvirt] [PATCH 0/3] Only talk to qemu guest agent when the domain is running
by Ján Tomko 27 Feb '15

27 Feb '15

Previously, only virDomainObjIsActive() was used to check domain liveness. This includes states like 'VIR_DOMAIN_PMSUSPENDED', where QEMU is running, but the guest is not. Explicitly check the state against VIR_DOMAIN_RUNNING and refuse to communicate with the agent if it does not match. https://bugzilla.redhat.com/show_bug.cgi?id=872424 Ján Tomko (3): Check for qemu guest agent availability after getting the job Pass virDomainObjPtr to qemuDomainAgentAvailable Check if domain is running in qemuDomainAgentIsAvailable src/qemu/qemu_domain.c | 11 ++++++++++- src/qemu/qemu_domain.h | 2 +- src/qemu/qemu_driver.c | 49 +++++++++++++++++++++++++------------------------ 3 files changed, 36 insertions(+), 26 deletions(-) -- 2.0.5

2 4

Re: [libvirt] [Xen-devel] [xen-unstable test] 35257: regressions - FAIL
by Jim Fehlig 27 Feb '15

27 Feb '15

Ian Campbell wrote: > On Thu, 2015-02-26 at 20:14 +0000, xen.org wrote: > >> flight 35257 xen-unstable real [real] >> http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-armhf-armhf-libvirt 12 guest-start.2 fail REGR. vs. 34629 >> > > logs: > http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/test-armhf-armhf-lib… > > http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/test-armhf-armhf-lib… > 2015-02-23 20:21:48 Z executing ssh ... root(a)10.80.229.106 virsh domxml-from-native xen-xl /etc/xen/debian.guest.osstest.cfg > /etc/xen/debian.guest.osstest.cfg.xml > error: failed to connect to the hypervisor > error: no valid connection > error: Failed to connect socket to '/var/run/libvirt/libvirt-sock': Connection refused > > http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/test-armhf-armhf-lib… > appears to show no libvirtd process. > > http://www.chiark.greenend.org.uk/~xensrcts/logs/35257/test-armhf-armhf-lib… > says: > 2015-02-23 20:13:15.556+0000: 2133: info : libvirt version: 1.2.13 > 2015-02-23 20:13:15.556+0000: 2133: error : dnsmasqCapsRefreshInternal:726 : Cannot check dnsmasq binary dnsmasq: No such file or directory > > 2015-02-23 20:13:15.845+0000: 2133: error : > virFirewallValidateBackend:193 : direct firewall backend requested, > but /sbin/ebtables is not available: No such file or directory Odd, since ebtables was found when building checking for ebtables... /sbin/ebtables But AFAICT, that wont prevent libvirtd from starting. > > I think these are just spurious. > > 2015-02-23 20:13:15.845+0000: 2133: error : virFirewallApply:936 : out of memory > > > 2015-02-23 20:13:16.092+0000: 2133: error : virExec:491 : Cannot find 'pm-is-supported' in path: No such file or directory > 2015-02-23 20:13:16.092+0000: 2133: warning : virQEMUCapsInit:999 : Failed to get host power management capabilities > > As are these two. > > 2015-02-23 20:13:16.400+0000: 2133: error : virFirewallApply:936 : out of memory > > Has these OOM messages resulted in libvirtd exiting? No, I don't think so. The related code is int virFirewallApply(virFirewallPtr firewall) { size_t i, j; int ret = -1; virMutexLock(&ruleLock); if (!firewall || firewall->err == ENOMEM) { virReportOOMError(); goto cleanup; ... } I suspect 'firewall' is null, so OOM error is reported and the function returns -1. But I also don't see this preventing libvirtd from starting. I've cc'd the libvirt list for verification that these errors won't prevent libvirtd from starting. > I don't see any > evidence of a crash elsewhere in the logs (i.e. no "process segfaulted" > in dmesg, no OOM killing going on etc). > > We don't seem to collect dom0 freemem info, but that most likely > wouldn't help given the libvirtd process has exited. > > > Any ideas where to look next? Can you access the test environment and try starting libvirtd in the foreground? Or enable debug log level in /etc/libvirt/libvirtd.conf? Regards, Jim

2 1

[libvirt] [PATCH] Really fix XML formatting flags in SaveImageUpdateDef
by Ján Tomko 27 Feb '15

27 Feb '15

Commit cf2d4c6 used a logical or instead of bitwise or, effectively passing 1, that is VIR_DOMAIN_XML_INACTIVE. Yep, that's right. This was caught by a warning when building with clang. https://bugzilla.redhat.com/show_bug.cgi?id=1183869 --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e9aa0b5..e282464 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -5734,7 +5734,7 @@ qemuDomainSaveImageUpdateDef(virQEMUDriverPtr driver, if (!(newdef_migr = qemuDomainDefCopy(driver, newdef, - QEMU_DOMAIN_FORMAT_LIVE_FLAGS || + QEMU_DOMAIN_FORMAT_LIVE_FLAGS | VIR_DOMAIN_XML_MIGRATABLE))) goto cleanup; -- 2.0.5

3 2

[libvirt] [PATCH 0/4] add support for graphics to get a IPv6 address
by Luyao Huang 27 Feb '15

27 Feb '15

https://bugzilla.redhat.com/show_bug.cgi?id=1192318 We already support add a IPv6 address to graphics listen address and xml like this: <graphics type='spice' port='5900' autoport='yes' listen='2001b8:ca2:2::1' keymap='en-us'> <listen type='address' address='2001b8:ca2:2::1'/> </graphics> However we do not support get a IPv6 address for the network. add some helpers and rework networkGetNetworkAddress to make it can get a IPv6 address when we need. Luyao Huang (4): util: introduce a new helper for get interface IPv6 address conf: introduce new family attribute in graphics listen for chose IP family network: rework networkGetNetworkAddress to make it can get IPv6 address qemu: fix a error coverd issue in 2 place docs/formatdomain.html.in | 10 +++- docs/schemas/domaincommon.rng | 9 +++ src/conf/domain_conf.c | 21 +++++++ src/conf/domain_conf.h | 10 ++++ src/conf/network_conf.c | 2 +- src/conf/network_conf.h | 1 + src/libvirt_private.syms | 2 + src/network/bridge_driver.c | 50 +++++++++++----- src/network/bridge_driver.h | 6 +- src/qemu/qemu_command.c | 18 ++---- src/util/virnetdev.c | 70 ++++++++++++++++++++++ src/util/virnetdev.h | 2 + .../qemuxml2argv-graphics-listen-network.xml | 2 +- .../qemuxml2argv-graphics-listen-network2.xml | 2 +- .../qemuxml2xmlout-graphics-listen-network2.xml | 2 +- 15 files changed, 174 insertions(+), 33 deletions(-) -- 1.8.3.1

5 22

[libvirt] [PATCH 0/5] Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag
by Ján Tomko 27 Feb '15

27 Feb '15

Add a flag to virConnectBaselineCPU to filter out features that block migration. Ján Tomko (5): Also store features blocking migration as CPUx86Data in the cpu map Add VIR_CONNECT_BASELINE_CPU_MIGRATABLE flag Implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE in the x86 cpu driver Trivially implement VIR_CONNECT_BASELINE_CPU_MIGRATABLE for non-x86 cpus Add --migratable support to virsh cpu-baseline include/libvirt/libvirt-host.h | 1 + src/bhyve/bhyve_driver.c | 3 +- src/cpu/cpu_aarch64.c | 3 +- src/cpu/cpu_arm.c | 3 +- src/cpu/cpu_generic.c | 3 +- src/cpu/cpu_powerpc.c | 3 +- src/cpu/cpu_x86.c | 47 ++++++++++++++++++++++++- src/libvirt-host.c | 3 ++ src/qemu/qemu_driver.c | 3 +- tests/cputest.c | 6 ++++ tests/cputestdata/x86-baseline-6-migratable.xml | 10 ++++++ tests/cputestdata/x86-baseline-6-result.xml | 11 ++++++ tests/cputestdata/x86-baseline-6.xml | 37 +++++++++++++++++++ tools/virsh-domain.c | 6 ++++ tools/virsh.pod | 5 +-- 15 files changed, 135 insertions(+), 9 deletions(-) create mode 100644 tests/cputestdata/x86-baseline-6-migratable.xml create mode 100644 tests/cputestdata/x86-baseline-6-result.xml create mode 100644 tests/cputestdata/x86-baseline-6.xml -- 2.0.5

2 11

[libvirt] [PATCH] qemu: snapshot: post error when create internal system checkpoint snapshot with rbd backend
by Shanzhi Yu 27 Feb '15

27 Feb '15

When create internel system checkpoint snapshot with source file based on rbd backend, libvirt miss to check if the format of source file support internal snapshot. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1179533 Signed-off-by: Shanzhi Yu <shyu(a)redhat.com> --- src/qemu/qemu_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 26fc6a2..6dd0a5c 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -13423,8 +13423,7 @@ qemuDomainSnapshotPrepare(virConnectPtr conn, goto cleanup; if (dom_disk->src->type == VIR_STORAGE_TYPE_NETWORK && - (dom_disk->src->protocol == VIR_STORAGE_NET_PROTOCOL_SHEEPDOG || - dom_disk->src->protocol == VIR_STORAGE_NET_PROTOCOL_RBD)) { + dom_disk->src->protocol == VIR_STORAGE_NET_PROTOCOL_SHEEPDOG) { break; } if (vm->def->disks[i]->src->format > 0 && -- 2.1.0

2 2

[libvirt] [PATCH] Ignore listen attribute of <graphics> for type network listens
by Ján Tomko 27 Feb '15

27 Feb '15

Commit 6992994 started filling the listen attribute of the parent <graphics> elements from type='network' listens. When this XML is passed to UpdateDevice, parsing fails: XML error: graphics listen attribute 10.20.30.40 must match address attribute of first listen element (found none) Ignore the address in the parent <graphics> attribute when no type='address' listens are found, the same we ignore the address for the <listen> subelements when parsing inactive XML. --- src/conf/domain_conf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d95dd3e..d458195 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -9614,12 +9614,16 @@ virDomainGraphicsDefParseXML(xmlNodePtr node, break; } } - if (!matched) { + if (found && !matched) { virReportError(VIR_ERR_XML_ERROR, _("graphics listen attribute %s must match address " "attribute of first listen element (found %s)"), - listenAddr, found ? found : "none"); + listenAddr, found); goto error; + } else if (!found && !matched) { + /* quietly ignore listen address if none of the listens + * are of type address */ + VIR_FREE(listenAddr); } } } -- 2.0.5

4 9

[libvirt] [PATCH] qemu: forbid large value wraparound in balloon period collection
by Erik Skultety 27 Feb '15

27 Feb '15

We do parse and represent period collection as unsigned int in our internal structures, however commit d5c67e7f4523450023b89b69c16472582c85eeaf converts this to int, thus wrapping around inputs greater than INT_MAX which results in an error from QEMU. This patch adds a check into QEMU driver, because period attribute is only supported by QEMU. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1140958 --- src/qemu/qemu_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bec05d4..46bd880 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -2414,6 +2414,12 @@ static int qemuDomainSetMemoryStatsPeriod(virDomainPtr dom, int period, /* Set the balloon driver collection interval */ priv = vm->privateData; + if (period < 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("invalid value for collection period")); + goto endjob; + } + if (flags & VIR_DOMAIN_AFFECT_LIVE) { qemuDomainObjEnterMonitor(driver, vm); -- 1.9.3

3 4

[libvirt] [PATCH] docs: add a note that spice channel is ignoret without spice graphics
by Pavel Hrdina 26 Feb '15

26 Feb '15

To prevent a confusion about missing chardev argument in qemu command line add a note about that behavior into documentation. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- docs/formatdomain.html.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index fb0a0d1..cd179a6 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5372,6 +5372,10 @@ qemu-kvm -net nic,model=? /dev/null under a channel name specified in the <code>channel</code> attribute. <span class="since">Since 1.2.2</span> </p> + <p> + NOTE: if spice graphics is not defined the spice channel will + be ignored. + </p> <pre> ... -- 2.0.5

2 2

[libvirt] Adding timestamps for all emulator output
by Andrey Korolyov 26 Feb '15

26 Feb '15

Hello, I think it would be useful if libvirt will be able to prefix all messages from emulator pipes with the date stamping, for example I am trying to catch very rare and non-fatal race with virtio-serial-bus: Guest failure in adding device virtio-serial0.0 which is specific to the Windows guests on qemu-kvm. I have supporting infrastructure which can tell me exact times for every action upon this VM, but as bug is not frequent, the continuous monitoring looks like an overkill for a desired goal - find a correlation between emulator event and message from stderr. Patching emulator itself is barely an option, as it is ugly, requires refresh of the running code via loopback migration and completely non-universal, as every hypervisor should be modified seperately. I`d highly appreciate positive consideration for such functionality addition or can write a patch shortly, if needed. Thanks!

2 3

[libvirt] [PATCH 0/2] For 1.2.13 - Fix crash with gluster URIs
by Peter Krempa 26 Feb '15

26 Feb '15

Peter Krempa (2): util: storagefile: Don't crash on gluster URIs without path util: storage: Fix error type in virStorageSourceParseBackingURI src/util/virstoragefile.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) -- 2.2.2

2 4

[libvirt] [PATCHv2 00/10] Add support for memory hotplug
by Peter Krempa 26 Feb '15

26 Feb '15

Version 2 fixes review comments and rebases to the current state. This series applies on top of: [PATCHv2 0/7] Automaticaly fill <memory> element for NUMA enabled guests For convenience you can fetch the changes at: git fetch git://pipo.sk/pipo/libvirt.git memory-hotplug-2 Peter Krempa (10): conf: Add support for parsing and formatting max memory and slot count qemu: Implement setup of memory hotplug parameters conf: Add device address type for dimm devices conf: Add interface to parse and format memory device information qemu: memdev: Add infrastructure to load memory device information qemu: migration: Forbid migration with memory modules lacking info qemu: add support for memory devices qemu: conf: Add support for memory device cold(un)plug qemu: Implement memory device hotplug qemu: Implement memory device hotunplug docs/formatdomain.html.in | 98 ++++ docs/schemas/domaincommon.rng | 76 +++ src/bhyve/bhyve_domain.c | 9 +- src/conf/domain_conf.c | 564 ++++++++++++++++++++- src/conf/domain_conf.h | 59 +++ src/libvirt_private.syms | 7 + src/libxl/libxl_domain.c | 8 + src/lxc/lxc_domain.c | 8 + src/openvz/openvz_driver.c | 14 +- src/parallels/parallels_driver.c | 6 +- src/phyp/phyp_driver.c | 6 +- src/qemu/qemu_command.c | 166 +++++- src/qemu/qemu_command.h | 15 + src/qemu/qemu_domain.c | 80 +++ src/qemu/qemu_domain.h | 5 + src/qemu/qemu_driver.c | 29 ++ src/qemu/qemu_hotplug.c | 177 +++++++ src/qemu/qemu_hotplug.h | 6 + src/qemu/qemu_migration.c | 14 + src/qemu/qemu_monitor.c | 42 ++ src/qemu/qemu_monitor.h | 14 + src/qemu/qemu_monitor_json.c | 122 +++++ src/qemu/qemu_monitor_json.h | 5 + src/qemu/qemu_process.c | 4 + src/uml/uml_driver.c | 9 +- src/vbox/vbox_common.c | 6 +- src/vmware/vmware_driver.c | 6 +- src/vmx/vmx.c | 6 +- src/xen/xen_driver.c | 7 + src/xenapi/xenapi_driver.c | 9 +- tests/domainschemadata/maxMemory.xml | 19 + .../qemuxml2argv-memory-hotplug-dimm.args | 11 + .../qemuxml2argv-memory-hotplug-dimm.xml | 50 ++ .../qemuxml2argv-memory-hotplug-nonuma.xml | 22 + .../qemuxml2argv-memory-hotplug.args | 6 + .../qemuxml2argv-memory-hotplug.xml | 34 ++ tests/qemuxml2argvtest.c | 6 + tests/qemuxml2xmltest.c | 4 + 38 files changed, 1706 insertions(+), 23 deletions(-) create mode 100644 tests/domainschemadata/maxMemory.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-dimm.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nonuma.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug.xml -- 2.2.2

2 12

[libvirt] [PATCH] util: do not take it as wrong if no PortData is found while getting migrateData
by Zhang Bo 26 Feb '15

26 Feb '15

The function virNetDevOpenvswitchGetMigrateData() uses the cmd ovs-vsctl to get portdata. If no portdata is available, rather than failure in running the cmd, we think we should just print a warning message here, rather than taking it as wrong, because PortData is just optional for an ovs interface. If we take it as wrong anyway, in function qemuMigrationBakeCookie() it will terminate in the middle, and cookies such as NBD would not be baked, further more errors would happen, such as nbd ports get overflowed, etc. Thus, we add an if branch in virNetDevOpenvswitchGetMigrateData() to just warn if portdata is unavailable. Signed-off-by: Zhang Bo <oscar.zhangbo(a)huawei.com> Signed-off-by: Zhou Yimin <zhouyimin(a)huawei.com> --- src/util/virnetdevopenvswitch.c | 28 ++++++++++++++++++++++++---- 1 file changed, 24 insertions(+), 4 deletions(-) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index e5c87bb..6116377 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -30,9 +30,12 @@ #include "virerror.h" #include "virmacaddr.h" #include "virstring.h" +#include "virlog.h" #define VIR_FROM_THIS VIR_FROM_NONE +VIR_LOG_INIT("util.netdevopenvswitch"); + /** * virNetDevOpenvswitchAddPort: * @brname: the bridge name @@ -204,18 +207,29 @@ int virNetDevOpenvswitchRemovePort(const char *brname ATTRIBUTE_UNUSED, const ch int virNetDevOpenvswitchGetMigrateData(char **migrate, const char *ifname) { virCommandPtr cmd = NULL; + char *errbuf = NULL; int ret = -1; cmd = virCommandNewArgList(OVSVSCTL, "--timeout=5", "get", "Interface", ifname, "external_ids:PortData", NULL); virCommandSetOutputBuffer(cmd, migrate); + virCommandSetErrorBuffer(cmd, &errbuf); /* Run the command */ - if (virCommandRun(cmd, NULL) < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unable to run command to get OVS port data for " - "interface %s"), ifname); + ret = virCommandRun(cmd, NULL); + if (ret < 0) { + /*PortData is optional, thus do not take it as wrong if the PortData is not found.*/ + if (strstr(errbuf, "no key \"PortData\" in Interface record")) { + VIR_WARN("Can't find OVS port data for interface %s", ifname); + if (*migrate) + VIR_FREE(*migrate); + ret = 0; + } else { + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Unable to run command to get OVS port data for " + "interface %s"), ifname); + } goto cleanup; } @@ -223,6 +237,7 @@ int virNetDevOpenvswitchGetMigrateData(char **migrate, const char *ifname) (*migrate)[strlen(*migrate) - 1] = '\0'; ret = 0; cleanup: + VIR_FREE(errbuf); virCommandFree(cmd); return ret; } @@ -241,6 +256,11 @@ int virNetDevOpenvswitchSetMigrateData(char *migrate, const char *ifname) virCommandPtr cmd = NULL; int ret = -1; + if (NULL == migrate) { + VIR_INFO("There is no need to set OVS port data for interface %s", ifname); + return 0; + } + cmd = virCommandNewArgList(OVSVSCTL, "--timeout=5", "set", "Interface", ifname, NULL); virCommandAddArgFormat(cmd, "external_ids:PortData=%s", migrate); -- 1.7.12.4

3 4

[libvirt] [PATCH] conf: error out on missing dhcp host attributes
by Ján Tomko 26 Feb '15

26 Feb '15

In virNetworkDHCPHostDefParseXML an error is reported when partialOkay == true, and none of ip, mac, name were supplied. Add the missing goto and error out in this case. --- src/conf/network_conf.c | 1 + 1 file changed, 1 insertion(+) Pushed as trivial. diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 52fcf3d..0f4fc1e 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -746,6 +746,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName, "must be specified for static host definition " "in network '%s' "), networkName); + goto cleanup; } } else { /* normal usage - you need at least name (IPv6) or one of MAC -- 2.0.5

1 0

[libvirt] [PATCH] conf: fix not jump to cleanup when parse a host id is invalid
by Luyao Huang 26 Feb '15

26 Feb '15

https://bugzilla.redhat.com/show_bug.cgi?id=1196503 We already check whether the host id is valid or not, add a jump to forbid invalid host id. Signed-off-by: Luyao Huang <lhuang(a)redhat.com> --- src/conf/network_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 3d8bf05..52fcf3d 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -717,6 +717,7 @@ virNetworkDHCPHostDefParseXML(const char *networkName, virReportError(VIR_ERR_XML_ERROR, _("Invalid character '%c' in id '%s' of network '%s'"), *cp, id, networkName); + goto cleanup; } } -- 1.8.3.1

3 2

[libvirt] [PATCH 0/2] check for null ifname when setting/clearing bandwidth
by Laine Stump 26 Feb '15

26 Feb '15

When John Ferlan ran the Coverity static checker on my patches to fix the problem with nicindexes, it began complaining about calling the virNetDevBandwidth* functions with a null ifname. Investigation pointed out some real problems with this that are fixed by these two patches (which will be pushed *before* the nicindex fix patch). Laine Stump (2): network: only clear bandwidth if it has been set util: check for null ifname inside virNetDevBandwidthSet() src/conf/netdev_bandwidth_conf.c | 6 ++++-- src/lxc/lxc_driver.c | 7 ++++++- src/network/bridge_driver.c | 6 ++++-- src/qemu/qemu_hotplug.c | 4 +++- src/util/virnetdevbandwidth.c | 9 ++++++++- src/util/virnetdevbandwidth.h | 4 ++-- 6 files changed, 27 insertions(+), 9 deletions(-) -- 2.1.0

4 10

[libvirt] Entering freeze for libvirt-1.2.13
by Daniel Veillard 26 Feb '15

26 Feb '15

As suggested yesterday, and hearing no opposition, I have just tagged Redlease Candidate 1 for libvirt-1.2.13 in git and signed tarballs and rpms for it available at the usual place: ftp://libvirt.org/libvirt/ Based on my own but minimal testing this seems to work, but obviously please give it a try so we can squash bugs and portability issues in time. A candidate release 2 on Thursday and a final 1.2.13 release next Monday is the schedule assumeing no major issue is found, so please give it a test ! Thanks, Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 1

[libvirt] [PATCH 1/3] utils: Implement virCommandPassFDGetFDIndex
by Stefan Berger 25 Feb '15

25 Feb '15

Implement virCommandPassFDGetFDIndex to determine the index a given file descriptor will have when passed to the child process. When this function is called, a flag is set to prevent the reordering of the file descriptors. Signed-off-by: Stefan Berger <stefanb(a)linux.vnet.ibm.com> --- src/libvirt_private.syms | 1 + src/util/vircommand.c | 33 +++++++++++++++++++++++++++++++++ src/util/vircommand.h | 3 +++ 3 files changed, 37 insertions(+) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index c156b40..aadb833 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1213,6 +1213,7 @@ virCommandNewArgList; virCommandNewArgs; virCommandNonblockingFDs; virCommandPassFD; +virCommandPassFDGetFDIndex; virCommandPassListenFDs; virCommandRawStatus; virCommandRequireHandshake; diff --git a/src/util/vircommand.c b/src/util/vircommand.c index 6527d85..2616446 100644 --- a/src/util/vircommand.c +++ b/src/util/vircommand.c @@ -67,6 +67,7 @@ enum { VIR_EXEC_RUN_SYNC = (1 << 3), VIR_EXEC_ASYNC_IO = (1 << 4), VIR_EXEC_LISTEN_FDS = (1 << 5), + VIR_EXEC_FIXED_FDS = (1 << 6), }; typedef struct _virCommandFD virCommandFD; @@ -214,6 +215,12 @@ virCommandReorderFDs(virCommandPtr cmd) if (!cmd || cmd->has_error || !cmd->npassfd) return; + if ((cmd->flags & VIR_EXEC_FIXED_FDS)) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("The fds are fixed and cannot be reordered")); + goto error; + } + for (i = 0; i < cmd->npassfd; i++) maxfd = MAX(cmd->passfd[i].fd, maxfd); @@ -1019,6 +1026,32 @@ virCommandPassListenFDs(virCommandPtr cmd) cmd->flags |= VIR_EXEC_LISTEN_FDS; } +/* + * virCommandPassFDGetFDIndex: + * @cmd: pointer to virCommand + * @fd: FD to get index of + * + * Determine the index of the FD in the transfer set. + * + * Returns index >= 0 if @set contains @fd, + * -1 otherwise. + */ +int +virCommandPassFDGetFDIndex(virCommandPtr cmd, int fd) +{ + size_t i = 0; + + while (i < cmd->npassfd) { + if (cmd->passfd[i].fd == fd) { + cmd->flags |= VIR_EXEC_FIXED_FDS; + return i; + } + i++; + } + + return -1; +} + /** * virCommandSetPidFile: * @cmd: the command to modify diff --git a/src/util/vircommand.h b/src/util/vircommand.h index bf65de4..198da2f 100644 --- a/src/util/vircommand.h +++ b/src/util/vircommand.h @@ -62,6 +62,9 @@ void virCommandPassFD(virCommandPtr cmd, void virCommandPassListenFDs(virCommandPtr cmd); +int virCommandPassFDGetFDIndex(virCommandPtr cmd, + int fd); + void virCommandSetPidFile(virCommandPtr cmd, const char *pidfile) ATTRIBUTE_NONNULL(2); -- 1.9.3

3 12

[libvirt] [PATCHv2 0/2] Boot options cleanup
by Ján Tomko 25 Feb '15

25 Feb '15

Depends on the first two (ACKed) patches from: https://www.redhat.com/archives/libvir-list/2015-February/msg00662.html Patch 4/5 Rename boot_buf to boot_opts was dropped. In this version, only one virBuffer is used and just the strings are separate. Ján Tomko (2): Make -boot arg generation more readable Use virBufferTrim when generating boot options src/qemu/qemu_command.c | 59 ++++++++++++++++++++++--------------------------- 1 file changed, 26 insertions(+), 33 deletions(-) -- 2.0.5

4 7

[libvirt] [PATCH 0/2] schema: Improve schema for the <os> element
by Peter Krempa 25 Feb '15

25 Feb '15

Peter Krempa (2): schema: Visually separate <define> blocks in RNG schema: Allow interleaving the /domain/os/type element docs/schemas/domaincommon.rng | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) -- 2.2.2

2 4