- Devel - libvirt List Archives

[PATCH] tests: Don't advertise features for edk2-loongarch64
by Andrea Bolognani 07 Mar '24

07 Mar '24

The "acpi" feature is not part of the specification[1], so it will just get ignored. [1] https://gitlab.com/qemu-project/qemu/-/blob/master/docs/interop/firmware.js… Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- .../usr/share/qemu/firmware/50-edk2-loongarch64.json | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-loongarch64.json b/tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-loongarch64.json index 8251137ba9..c5a7ec5f7b 100644 --- a/tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-loongarch64.json +++ b/tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-loongarch64.json @@ -24,6 +24,5 @@ } ], "features": [ - "acpi" ] } -- 2.44.0

2 1

Raspberry Pi 5 suggestion
by K otgc 07 Mar '24

07 Mar '24

Hello, the libvirt documentation <https://libvirt.org/apps.html> has nothing on installing libvirt to Raspberry Pi 5, so the documentation says to email <https://libvirt.org/contact.html> any suggestions. Cheers, Ken.

3 3

[PATCH] docs: Update documentation of CPU models in domain caps
by Jiri Denemark 07 Mar '24

07 Mar '24

Using check='none' when starting a domain with a CPU model marked as usable is no longer needed as libvirt will do the right thing even with check='partial'. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/formatdomaincaps.rst | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/formatdomaincaps.rst b/docs/formatdomaincaps.rst index ef752a0f3a..1999112944 100644 --- a/docs/formatdomaincaps.rst +++ b/docs/formatdomaincaps.rst @@ -237,10 +237,12 @@ more details about it: using the CPU model and no additional feature elements. Models marked as usable (``usable='yes'``) can be safely used in domain XMLs with ``check='none'`` as the hypervisor guarantees the model can be used on the - current host and additional checks done by libvirt are redundant. In fact, - disabling libvirt checks via ``check='none'`` for such models is recommended - to avoid needless issues with starting domains when libvirt's definition of - a particular model differs from hypervisor's definition. The + current host and additional checks done by libvirt are redundant. + :since:`Since 10.2.0` libvirt automatically detects this situation and + avoids the redundant checks, with older releases disabling libvirt checks + via ``check='none'`` for such models is recommended to avoid needless + issues with starting domains when libvirt's definition of a particular model + differs from hypervisor's definition. The ``deprecated`` attribute reflects the hypervisor's policy on usage of this model :since:`(since 7.1.0)`. The ``vendor`` attribute :since:`(since 8.9.0)` contains the vendor of the CPU model for users who want to use CPU models -- 2.44.0

2 1

[PATCH 02/14] hw/core/machine-smp: Deprecate unsupported "parameter=1" SMP configurations
by Zhao Liu 07 Mar '24

07 Mar '24

From: Zhao Liu <zhao1.liu(a)intel.com> Currentlt, it was allowed for users to specify the unsupported topology parameter as "1". For example, x86 PC machine doesn't support drawer/book/cluster topology levels, but user could specify "-smp drawers=1,books=1,clusters=1". This is meaningless and confusing, so that the support for this kind of configurations is marked depresated since 9.0. And report warning message for such case like: qemu-system-x86_64: warning: Deprecated CPU topology (considered invalid): Unsupported clusters parameter mustn't be specified as 1 qemu-system-x86_64: warning: Deprecated CPU topology (considered invalid): Unsupported books parameter mustn't be specified as 1 qemu-system-x86_64: warning: Deprecated CPU topology (considered invalid): Unsupported drawers parameter mustn't be specified as 1 Users have to ensure that all the topology members described with -smp are supported by the target machine. Cc: devel(a)lists.libvirt.org Signed-off-by: Zhao Liu <zhao1.liu(a)intel.com> --- docs/about/deprecated.rst | 14 +++++++++ hw/core/machine-smp.c | 63 +++++++++++++++++++++++++++++---------- 2 files changed, 61 insertions(+), 16 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 872974640252..2e782e83e952 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -47,6 +47,20 @@ as short-form boolean values, and passed to plugins as ``arg_name=on``. However, short-form booleans are deprecated and full explicit ``arg_name=on`` form is preferred. +``-smp`` (Unsopported "parameter=1" SMP configurations) (since 9.0) +''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Specified CPU topology parameters must be supported by the machine. + +In the SMP configuration, users should provide the CPU topology parameters that +are supported by the target machine. + +However, historically it was allowed for users to specify the unsupported +topology parameter as "1", which is meaningless. So support for this kind of +configurations (e.g. -smp drawers=1,books=1,clusters=1 for x86 PC machine) is +marked depresated since 9.0, users have to ensure that all the topology members +described with -smp are supported by the target machine. + QEMU Machine Protocol (QMP) commands ------------------------------------ diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c index 96533886b14e..50a5a40dbc3d 100644 --- a/hw/core/machine-smp.c +++ b/hw/core/machine-smp.c @@ -112,30 +112,61 @@ void machine_parse_smp_config(MachineState *ms, /* * If not supported by the machine, a topology parameter must be - * omitted or specified equal to 1. + * omitted. */ - if (!mc->smp_props.dies_supported && dies > 1) { - error_setg(errp, "dies not supported by this machine's CPU topology"); - return; - } - if (!mc->smp_props.clusters_supported && clusters > 1) { - error_setg(errp, "clusters not supported by this machine's CPU topology"); - return; + if (!mc->smp_props.clusters_supported && config->has_clusters) { + if (config->clusters > 1) { + error_setg(errp, "clusters not supported by this " + "machine's CPU topology"); + return; + } else { + /* Here clusters only equals 1 since we've checked zero case. */ + warn_report("Deprecated CPU topology (considered invalid): " + "Unsupported clusters parameter mustn't be " + "specified as 1"); + } } + clusters = clusters > 0 ? clusters : 1; + if (!mc->smp_props.dies_supported && config->has_dies) { + if (config->dies > 1) { + error_setg(errp, "dies not supported by this " + "machine's CPU topology"); + return; + } else { + /* Here dies only equals 1 since we've checked zero case. */ + warn_report("Deprecated CPU topology (considered invalid): " + "Unsupported dies parameter mustn't be " + "specified as 1"); + } + } dies = dies > 0 ? dies : 1; - clusters = clusters > 0 ? clusters : 1; - if (!mc->smp_props.books_supported && books > 1) { - error_setg(errp, "books not supported by this machine's CPU topology"); - return; + if (!mc->smp_props.books_supported && config->has_books) { + if (config->books > 1) { + error_setg(errp, "books not supported by this " + "machine's CPU topology"); + return; + } else { + /* Here books only equals 1 since we've checked zero case. */ + warn_report("Deprecated CPU topology (considered invalid): " + "Unsupported books parameter mustn't be " + "specified as 1"); + } } books = books > 0 ? books : 1; - if (!mc->smp_props.drawers_supported && drawers > 1) { - error_setg(errp, - "drawers not supported by this machine's CPU topology"); - return; + if (!mc->smp_props.drawers_supported && config->has_drawers) { + if (config->drawers > 1) { + error_setg(errp, "drawers not supported by this " + "machine's CPU topology"); + return; + } else { + /* Here drawers only equals 1 since we've checked zero case. */ + warn_report("Deprecated CPU topology (considered invalid): " + "Unsupported drawers parameter mustn't be " + "specified as 1"); + } } drawers = drawers > 0 ? drawers : 1; -- 2.34.1

2 2

[PATCH 0/5] multiple memory backend support for CPR Live Updates
by mgalaxy＠akamai.com 06 Mar '24

06 Mar '24

From: Michael Galaxy <mgalaxy(a)akamai.com> CPR-based support for whole-hypervisor kexec-based live updates is making progress on qemu-devel. In support of this, we need NUMA to be support in these kinds of environments. To do this we use a technology called PMEM (persistent memory), which underpin the ability for CPR Live Updates to work so that QEMU memory can remain in RAM and be recovered after the kexec has completed. Our systems are highly NUMA-aware, and so this patch series enables NUMA awareness for live update and also allows live migrations to work. Further, we make a small change that allows live migrations to work between *non* PMEM-based systems and PMEM-based systems (and vice-versa). This allows for seemless upgrades from non-live-compatible systems to live-update-compatible sytems without any downtime. Michael Galaxy (5): qemu.conf changes to support multiple memory backend directories Update cleanup routines to handle multiple memory backing paths instead of just one. Implement multiple memory backing paths Support live migration between file-backed memory and anonymous memory. Update unit test to support multiple memory backends src/qemu/qemu_command.c | 8 ++- src/qemu/qemu_conf.c | 140 ++++++++++++++++++++++++++++++++++++---- src/qemu/qemu_conf.h | 14 ++-- src/qemu/qemu_domain.c | 24 +++++-- src/qemu/qemu_driver.c | 31 +++++---- src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_process.c | 45 +++++++------ src/qemu/qemu_process.h | 13 ++-- tests/testutilsqemu.c | 5 +- 9 files changed, 217 insertions(+), 69 deletions(-) -- 2.25.1

4 11

[libvirt PATCH 0/5] implement virDomainGraphicsReload
by Ján Tomko 06 Mar '24

06 Mar '24

https://issues.redhat.com/browse/RHEL-16333 Based on the patches Huawei sent back in 2021: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/LDTM… * rebased * renamed * simplified (removed virTypedParams from the API and the requirement to specify the type) Ján Tomko (1): remote: implement virDomainGraphicsReload Zheng Yan (4): qemu_capabilities: Add QEMU_CAPS_DISPLAY_RELOAD libvirt: Introduce virDomainGraphicsReload API qemu: implement qemuDomainGraphicsReload virsh: Introduce domdisplay-reload command docs/manpages/virsh.rst | 15 ++++++ include/libvirt/libvirt-domain.h | 18 +++++++ src/driver-hypervisor.h | 6 +++ src/libvirt-domain.c | 50 +++++++++++++++++ src/libvirt_public.syms | 5 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 54 +++++++++++++++++++ src/qemu/qemu_monitor.c | 10 ++++ src/qemu/qemu_monitor.h | 5 ++ src/qemu/qemu_monitor_json.c | 23 ++++++++ src/qemu/qemu_monitor_json.h | 4 ++ src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 13 ++++- src/remote_protocol-structs | 6 +++ .../caps_6.0.0_aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.0.0_s390x.xml | 1 + .../caps_6.0.0_x86_64.xml | 1 + .../caps_6.1.0_x86_64.xml | 1 + .../caps_6.2.0_aarch64.xml | 1 + .../qemucapabilitiesdata/caps_6.2.0_ppc64.xml | 1 + .../caps_6.2.0_x86_64.xml | 1 + .../caps_7.0.0_aarch64+hvf.xml | 1 + .../caps_7.0.0_aarch64.xml | 1 + .../qemucapabilitiesdata/caps_7.0.0_ppc64.xml | 1 + .../caps_7.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_7.1.0_ppc64.xml | 1 + .../caps_7.1.0_x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_7.2.0_ppc.xml | 1 + .../caps_7.2.0_x86_64+hvf.xml | 1 + .../caps_7.2.0_x86_64.xml | 1 + .../caps_8.0.0_riscv64.xml | 1 + .../caps_8.0.0_x86_64.xml | 1 + .../qemucapabilitiesdata/caps_8.1.0_s390x.xml | 1 + .../caps_8.1.0_x86_64.xml | 1 + .../caps_8.2.0_aarch64.xml | 1 + .../qemucapabilitiesdata/caps_8.2.0_s390x.xml | 1 + .../caps_8.2.0_x86_64.xml | 1 + .../caps_9.0.0_x86_64.xml | 1 + tools/virsh-domain.c | 45 ++++++++++++++++ 40 files changed, 281 insertions(+), 1 deletion(-) -- 2.43.2

2 10

[PATCH 00/25] qemu: Remove use of '-usb' to instantiate controllers
by Peter Krempa 06 Mar '24

06 Mar '24

This patchset removes the use of '-usb' legacy controller specification. For the vast majority of platforms/machines (most of the irrelevant ones) which don't actually have a concept of implicit USB qemu ignores the '-usb' argument. For the relevant platforms libvirt would already pick exactly the same controller and thus '-usb' wouldn't be used at all. There's a small handful of ARM boards 'realview' and 'versatilepb' where libvirt would pick the wrong one as default if some controllers were compiled out and thus reallistically '-usb' would have effect for those although would be unusable as libvirt's bus name for the bus is incorret and thus no devices would be usable. For the two mostly obsolete board types this series can break ABI in the aforementioned corner case. Other than that this removes all the legacy code which makes USB controller selection utterly confusing. Peter Krempa (25): tests: Replace mentions of the removed 'qemucapabilitiesnumbering' tool qemucapabilitiesdata: Document faked caps dumps testutilshostcpus: Add support for VIR_ARCH_ARMV7L qemucapabilitiestest: Add test dump for 'armv7l' architecture qemu: domain: Add checkers for 'microvm' machine type qemu: Add basic framework for 'microvm' machine type qemuxmlconfdata: Add tests for USB controller selection with 'versatilepb' machine on aarch64 qemu binary qemuxmlconfdata: Add tests for USB controller selection with 'versatilepb' machine on arm qemu binary qemuDomainDefAddDefaultDevices: Handle defaults for all ARM arches together qemuDomainControllerDefPostParse: Use proper enum value for default USB controller model qemuDomainDefAddDefaultDevices: Populate default USB for 'versatilepb' and 'realview' ARM machines qemuDomainControllerDefPostParse: Use 'pci-ohci' as last-resort fallback USB controller qemuxmlconftest: Add test for 'realview' machine qemuxmlconftest: Add test data for an ARM machine where qemu doesn't honour -usb qemuxml2conftest: Consolidate usb controller tests for 'pseries' machine qemuxmlconftest: Add test case when default USB controller for 'pseries' is compiled out qemuxmlconftest: Add test data for USB selection with 'g3beige' machine on ppc64 qemuxmlconftest: Add test data for USB selection with 'mac99' machine on ppc64 qemuxmlconftest: Add test data for USB selection with 'powernv' machine on ppc64 qemuxmlconftest: Add test data for USB selection with 'mac99' machine on ppc qemu: command: Don't downgrade to '-usb' for x86 based machines qemu: command: Don't downgrade to '-usb' with 'pseries' machines qemu: command: Don't downgrade to '-usb' for ppc based machines qemu: command: Don't downgrade to '-usb' for arm based machines qemu: command: Remove fallback '-usb' handling src/qemu/qemu_command.c | 87 +- src/qemu/qemu_domain.c | 63 +- src/qemu/qemu_domain.h | 1 + tests/domaincapsdata/qemu_8.2.0.armv7l.xml | 175 + tests/domaincapstest.c | 5 +- tests/qemucapabilitiesdata/README.rst | 18 +- .../caps_8.2.0_armv7l.replies | 35062 ++++++++++++++++ .../caps_8.2.0_armv7l.xml | 326 + tests/qemucaps2xmloutdata/caps.armv7l.xml | 26 + ...usb-minimal.aarch64-latest.abi-update.args | 30 + ...ousb-minimal.aarch64-latest.abi-update.xml | 21 + .../aarch64-nousb-minimal.aarch64-latest.args | 30 + .../aarch64-nousb-minimal.aarch64-latest.xml | 21 + .../qemuxmlconfdata/aarch64-nousb-minimal.xml | 15 + ...iew-minimal.aarch64-latest.abi-update.args | 31 + ...view-minimal.aarch64-latest.abi-update.xml | 22 + ...rch64-realview-minimal.aarch64-latest.args | 31 + ...arch64-realview-minimal.aarch64-latest.xml | 22 + .../aarch64-realview-minimal.xml | 14 + ...epb-minimal.aarch64-latest.abi-update.args | 32 + ...lepb-minimal.aarch64-latest.abi-update.xml | 25 + ...64-versatilepb-minimal.aarch64-latest.args | 32 + ...h64-versatilepb-minimal.aarch64-latest.xml | 25 + .../aarch64-versatilepb-minimal.xml | 14 + .../arm-vexpressa9-basic.aarch64-latest.args | 1 - .../arm-vexpressa9-nodevs.aarch64-latest.args | 1 - .../arm-vexpressa9-virtio.aarch64-latest.args | 1 - ...lepb-minimal.armv7l-latest.abi-update.args | 32 + ...ilepb-minimal.armv7l-latest.abi-update.xml | 27 + ...v7l-versatilepb-minimal.armv7l-latest.args | 32 + ...mv7l-versatilepb-minimal.armv7l-latest.xml | 27 + .../armv7l-versatilepb-minimal.xml | 13 + .../disk-arm-virtio-sd.aarch64-latest.args | 1 - .../microvm.x86_64-latest.args | 34 + .../qemuxmlconfdata/microvm.x86_64-latest.xml | 29 + tests/qemuxmlconfdata/microvm.xml | 20 + ...c-mac99-minimal.ppc-latest.abi-update.args | 32 + ...pc-mac99-minimal.ppc-latest.abi-update.xml | 26 + .../ppc-mac99-minimal.ppc-latest.args | 32 + .../ppc-mac99-minimal.ppc-latest.xml | 26 + tests/qemuxmlconfdata/ppc-mac99-minimal.xml | 12 + ...beige-minimal.ppc64-latest.abi-update.args | 33 + ...3beige-minimal.ppc64-latest.abi-update.xml | 29 + .../ppc64-g3beige-minimal.ppc64-latest.args | 33 + .../ppc64-g3beige-minimal.ppc64-latest.xml | 29 + .../qemuxmlconfdata/ppc64-g3beige-minimal.xml | 12 + ...mac99-minimal.ppc64-latest.abi-update.args | 33 + ...-mac99-minimal.ppc64-latest.abi-update.xml | 29 + .../ppc64-mac99-minimal.ppc64-latest.args | 33 + .../ppc64-mac99-minimal.ppc64-latest.xml | 29 + tests/qemuxmlconfdata/ppc64-mac99-minimal.xml | 12 + ...ernv9-minimal.ppc64-latest.abi-update.args | 33 + ...wernv9-minimal.ppc64-latest.abi-update.xml | 29 + .../ppc64-powernv9-minimal.ppc64-latest.args | 33 + .../ppc64-powernv9-minimal.ppc64-latest.xml | 29 + .../ppc64-powernv9-minimal.xml | 12 + .../sparc-minimal.sparc-latest.args | 1 - ...default-fallback-g3beige.ppc64-latest.args | 33 + ...-default-fallback-g3beige.ppc64-latest.xml | 34 + ...sb-controller-default-fallback-g3beige.xml | 1 + ...r-default-fallback-mac99.ppc64-latest.args | 33 + ...er-default-fallback-mac99.ppc64-latest.xml | 34 + .../usb-controller-default-fallback-mac99.xml | 1 + ...default-fallback-mac99ppc.ppc-latest.args} | 9 +- ...r-default-fallback-mac99ppc.ppc-latest.xml | 31 + ...b-controller-default-fallback-mac99ppc.xml | 1 + ...default-fallback-nousb.aarch64-latest.args | 31 + ...-default-fallback-nousb.aarch64-latest.xml | 23 + .../usb-controller-default-fallback-nousb.xml | 1 + ...efault-fallback-powernv9.ppc64-latest.args | 33 + ...default-fallback-powernv9.ppc64-latest.xml | 34 + ...b-controller-default-fallback-powernv9.xml | 1 + ...ault-fallback-realview.aarch64-latest.args | 31 + ...fault-fallback-realview.aarch64-latest.xml | 23 + ...b-controller-default-fallback-realview.xml | 1 + ...ck-versatilepb-aarch64.aarch64-latest.args | 32 + ...ack-versatilepb-aarch64.aarch64-latest.xml | 25 + ...r-default-fallback-versatilepb-aarch64.xml | 1 + ...back-versatilepb-armv7l.armv7l-latest.args | 32 + ...lback-versatilepb-armv7l.armv7l-latest.xml | 27 + ...er-default-fallback-versatilepb-armv7l.xml | 1 + ...ntroller-default-g3beige.ppc64-latest.args | 33 + ...ontroller-default-g3beige.ppc64-latest.xml | 34 + .../usb-controller-default-g3beige.xml | 23 + ...controller-default-mac99.ppc64-latest.args | 33 + ...-controller-default-mac99.ppc64-latest.xml | 34 + .../usb-controller-default-mac99.xml | 23 + ...ontroller-default-mac99ppc.ppc-latest.args | 32 + ...controller-default-mac99ppc.ppc-latest.xml | 31 + .../usb-controller-default-mac99ppc.xml | 23 + ...ntroller-default-nousb.aarch64-latest.args | 31 + ...ontroller-default-nousb.aarch64-latest.xml | 23 + .../usb-controller-default-nousb.xml | 17 + ...troller-default-powernv9.ppc64-latest.args | 33 + ...ntroller-default-powernv9.ppc64-latest.xml | 34 + .../usb-controller-default-powernv9.xml | 23 + ...ault-pseries.ppc64-latest.abi-update.args} | 0 ...fault-pseries.ppc64-latest.abi-update.xml} | 0 ...troller-default-pseries.ppc64-latest.args} | 0 ...ntroller-default-pseries.ppc64-latest.xml} | 0 ...xml => usb-controller-default-pseries.xml} | 0 ...oller-default-realview.aarch64-latest.args | 31 + ...roller-default-realview.aarch64-latest.xml | 23 + .../usb-controller-default-realview.xml | 16 + ...fault-unavailable-g3beige.ppc64-latest.err | 1 + ...fault-unavailable-g3beige.ppc64-latest.xml | 34 + ...controller-default-unavailable-g3beige.xml | 1 + ...fault-unavailable-i440fx.x86_64-latest.err | 1 + ...default-unavailable-mac99.ppc64-latest.err | 1 + ...default-unavailable-mac99.ppc64-latest.xml | 34 + ...b-controller-default-unavailable-mac99.xml | 1 + ...efault-unavailable-mac99ppc.ppc-latest.err | 1 + ...efault-unavailable-mac99ppc.ppc-latest.xml | 31 + ...ontroller-default-unavailable-mac99ppc.xml | 1 + ...ault-unavailable-nousb.aarch64-latest.args | 31 + ...fault-unavailable-nousb.aarch64-latest.xml | 23 + ...b-controller-default-unavailable-nousb.xml | 1 + ...ault-unavailable-powernv9.ppc64-latest.err | 1 + ...ault-unavailable-powernv9.ppc64-latest.xml | 34 + ...ontroller-default-unavailable-powernv9.xml | 1 + ...fault-unavailable-pseries.ppc64-latest.err | 1 + ...fault-unavailable-pseries.ppc64-latest.xml | 38 + ...controller-default-unavailable-pseries.xml | 1 + ...t-unavailable-realview.aarch64-latest.args | 31 + ...lt-unavailable-realview.aarch64-latest.xml | 23 + ...ontroller-default-unavailable-realview.xml | 1 + ...le-versatilepb-aarch64.aarch64-latest.args | 32 + ...ble-versatilepb-aarch64.aarch64-latest.xml | 25 + ...efault-unavailable-versatilepb-aarch64.xml | 1 + ...lable-versatilepb-armv7l.armv7l-latest.err | 1 + ...lable-versatilepb-armv7l.armv7l-latest.xml | 27 + ...default-unavailable-versatilepb-armv7l.xml | 1 + ...lt-versatilepb-aarch64.aarch64-latest.args | 32 + ...ult-versatilepb-aarch64.aarch64-latest.xml | 25 + ...controller-default-versatilepb-aarch64.xml | 16 + ...ault-versatilepb-armv7l.armv7l-latest.args | 32 + ...fault-versatilepb-armv7l.armv7l-latest.xml | 27 + ...-controller-default-versatilepb-armv7l.xml | 15 + ...ntroller-implicit-isapc.x86_64-latest.args | 1 - ...troller-implicit-microvm.x86_64-latest.err | 1 + ...troller-implicit-microvm.x86_64-latest.xml | 25 + .../usb-controller-implicit-microvm.xml | 17 + ...rovm-minimal.x86_64-latest.abi-update.args | 31 + ...crovm-minimal.x86_64-latest.abi-update.xml | 23 + .../x86_64-microvm-minimal.x86_64-latest.args | 31 + .../x86_64-microvm-minimal.x86_64-latest.xml | 23 + .../x86_64-microvm-minimal.xml | 14 + tests/qemuxmlconftest.c | 140 +- tests/testutilshostcpus.h | 10 + 149 files changed, 38588 insertions(+), 107 deletions(-) create mode 100644 tests/domaincapsdata/qemu_8.2.0.armv7l.xml create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_armv7l.replies create mode 100644 tests/qemucapabilitiesdata/caps_8.2.0_armv7l.xml create mode 100644 tests/qemucaps2xmloutdata/caps.armv7l.xml create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/aarch64-nousb-minimal.xml create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/aarch64-realview-minimal.xml create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/aarch64-versatilepb-minimal.xml create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.args create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.armv7l-latest.xml create mode 100644 tests/qemuxmlconfdata/armv7l-versatilepb-minimal.xml create mode 100644 tests/qemuxmlconfdata/microvm.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/microvm.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/microvm.xml create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.args create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.ppc-latest.xml create mode 100644 tests/qemuxmlconfdata/ppc-mac99-minimal.xml create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.ppc64-latest.xml create mode 100644 tests/qemuxmlconfdata/ppc64-g3beige-minimal.xml create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.ppc64-latest.xml create mode 100644 tests/qemuxmlconfdata/ppc64-mac99-minimal.xml create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.ppc64-latest.xml create mode 100644 tests/qemuxmlconfdata/ppc64-powernv9-minimal.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-g3beige.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-g3beige.ppc64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-g3beige.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99.ppc64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99.xml rename tests/qemuxmlconfdata/{usb-controller-default-unavailable-i440fx.x86_64-latest.args => usb-controller-default-fallback-mac99ppc.ppc-latest.args} (80%) create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99ppc.ppc-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-mac99ppc.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.aarch64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-nousb.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-powernv9.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-powernv9.ppc64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-powernv9.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-realview.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-realview.aarch64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-realview.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.aarch64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-aarch64.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-armv7l.armv7l-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-armv7l.armv7l-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-fallback-versatilepb-armv7l.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-g3beige.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-g3beige.ppc64-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-g3beige.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99.ppc64-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99ppc.ppc-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99ppc.ppc-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-mac99ppc.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-nousb.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-powernv9.ppc64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-powernv9.ppc64-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-powernv9.xml rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.abi-update.args => usb-controller-default-pseries.ppc64-latest.abi-update.args} (100%) rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.abi-update.xml => usb-controller-default-pseries.ppc64-latest.abi-update.xml} (100%) rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.args => usb-controller-default-pseries.ppc64-latest.args} (100%) rename tests/qemuxmlconfdata/{ppc64-usb-controller.ppc64-latest.xml => usb-controller-default-pseries.ppc64-latest.xml} (100%) rename tests/qemuxmlconfdata/{ppc64-usb-controller.xml => usb-controller-default-pseries.xml} (100%) create mode 100644 tests/qemuxmlconfdata/usb-controller-default-realview.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-realview.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-realview.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.ppc64-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.ppc64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-g3beige.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-i440fx.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.ppc64-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.ppc64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.ppc-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.ppc-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-mac99ppc.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.aarch64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-nousb.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.ppc64-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.ppc64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-powernv9.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-pseries.ppc64-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-pseries.ppc64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-pseries.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.aarch64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-realview.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.aarch64-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-aarch64.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.armv7l-latest.xml create mode 120000 tests/qemuxmlconfdata/usb-controller-default-unavailable-versatilepb-armv7l.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.aarch64-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.aarch64-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-aarch64.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-armv7l.armv7l-latest.args create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-armv7l.armv7l-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-default-versatilepb-armv7l.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-implicit-microvm.x86_64-latest.err create mode 100644 tests/qemuxmlconfdata/usb-controller-implicit-microvm.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/usb-controller-implicit-microvm.xml create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.abi-update.args create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.abi-update.xml create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.args create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.x86_64-latest.xml create mode 100644 tests/qemuxmlconfdata/x86_64-microvm-minimal.xml -- 2.43.0

4 35

[PATCH 01/14] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations
by Zhao Liu 06 Mar '24

06 Mar '24

From: Zhao Liu <zhao1.liu(a)intel.com> The "parameter=0" SMP configurations have been marked as deprecated since v6.2. For these cases, -smp currently returns the warning and adjusts the zeroed parameters to 1 by default. Remove the above compatibility logic in v9.0, and return error directly if any -smp parameter is set as 0. Cc: devel(a)lists.libvirt.org Signed-off-by: Zhao Liu <zhao1.liu(a)intel.com> Reviewed-by: Thomas Huth <thuth(a)redhat.com> Reviewed-by: Prasad Pandit <pjp(a)fedoraproject.org> --- docs/about/deprecated.rst | 16 ---------------- docs/about/removed-features.rst | 15 +++++++++++++++ hw/core/machine-smp.c | 5 +++-- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 36bd3e15ef06..872974640252 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -36,22 +36,6 @@ and will cause a warning. The replacement for the ``nodelay`` short-form boolean option is ``nodelay=on`` rather than ``delay=off``. -``-smp`` ("parameter=0" SMP configurations) (since 6.2) -''''''''''''''''''''''''''''''''''''''''''''''''''''''' - -Specified CPU topology parameters must be greater than zero. - -In the SMP configuration, users should either provide a CPU topology -parameter with a reasonable value (greater than zero) or just omit it -and QEMU will compute the missing value. - -However, historically it was implicitly allowed for users to provide -a parameter with zero value, which is meaningless and could also possibly -cause unexpected results in the -smp parsing. So support for this kind of -configurations (e.g. -smp 8,sockets=0) is deprecated since 6.2 and will -be removed in the near future, users have to ensure that all the topology -members described with -smp are greater than zero. - Plugin argument passing through ``arg=<string>`` (since 6.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 417a0e4fa1d9..f9cf874f7b1f 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -489,6 +489,21 @@ The ``-singlestep`` option has been turned into an accelerator property, and given a name that better reflects what it actually does. Use ``-accel tcg,one-insn-per-tb=on`` instead. +``-smp`` ("parameter=0" SMP configurations) (removed in 9.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Specified CPU topology parameters must be greater than zero. + +In the SMP configuration, users should either provide a CPU topology +parameter with a reasonable value (greater than zero) or just omit it +and QEMU will compute the missing value. + +However, historically it was implicitly allowed for users to provide +a parameter with zero value, which is meaningless and could also possibly +cause unexpected results in the -smp parsing. So support for this kind of +configurations (e.g. -smp 8,sockets=0) is removed since 9.0, users have +to ensure that all the topology members described with -smp are greater +than zero. User-mode emulator command line arguments ----------------------------------------- diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c index 25019c91ee36..96533886b14e 100644 --- a/hw/core/machine-smp.c +++ b/hw/core/machine-smp.c @@ -105,8 +105,9 @@ void machine_parse_smp_config(MachineState *ms, (config->has_cores && config->cores == 0) || (config->has_threads && config->threads == 0) || (config->has_maxcpus && config->maxcpus == 0)) { - warn_report("Deprecated CPU topology (considered invalid): " - "CPU topology parameters must be greater than zero"); + error_setg(errp, "Invalid CPU topology: " + "CPU topology parameters must be greater than zero"); + return; } /* -- 2.34.1

1 0

[PATCH] hw/core/machine-smp: Remove deprecated "parameter=0" SMP configurations
by Zhao Liu 06 Mar '24

06 Mar '24

From: Zhao Liu <zhao1.liu(a)intel.com> The "parameter=0" SMP configurations have been marked as deprecated since v6.2. For these cases, -smp currently returns the warning and adjusts the zeroed parameters to 1 by default. Remove the above compatibility logic in v9.0, and return error directly if any -smp parameter is set as 0. Signed-off-by: Zhao Liu <zhao1.liu(a)intel.com> --- docs/about/deprecated.rst | 16 ---------------- docs/about/removed-features.rst | 15 +++++++++++++++ hw/core/machine-smp.c | 5 +++-- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 36bd3e15ef06..872974640252 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -36,22 +36,6 @@ and will cause a warning. The replacement for the ``nodelay`` short-form boolean option is ``nodelay=on`` rather than ``delay=off``. -``-smp`` ("parameter=0" SMP configurations) (since 6.2) -''''''''''''''''''''''''''''''''''''''''''''''''''''''' - -Specified CPU topology parameters must be greater than zero. - -In the SMP configuration, users should either provide a CPU topology -parameter with a reasonable value (greater than zero) or just omit it -and QEMU will compute the missing value. - -However, historically it was implicitly allowed for users to provide -a parameter with zero value, which is meaningless and could also possibly -cause unexpected results in the -smp parsing. So support for this kind of -configurations (e.g. -smp 8,sockets=0) is deprecated since 6.2 and will -be removed in the near future, users have to ensure that all the topology -members described with -smp are greater than zero. - Plugin argument passing through ``arg=<string>`` (since 6.1) '''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst index 417a0e4fa1d9..f9cf874f7b1f 100644 --- a/docs/about/removed-features.rst +++ b/docs/about/removed-features.rst @@ -489,6 +489,21 @@ The ``-singlestep`` option has been turned into an accelerator property, and given a name that better reflects what it actually does. Use ``-accel tcg,one-insn-per-tb=on`` instead. +``-smp`` ("parameter=0" SMP configurations) (removed in 9.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Specified CPU topology parameters must be greater than zero. + +In the SMP configuration, users should either provide a CPU topology +parameter with a reasonable value (greater than zero) or just omit it +and QEMU will compute the missing value. + +However, historically it was implicitly allowed for users to provide +a parameter with zero value, which is meaningless and could also possibly +cause unexpected results in the -smp parsing. So support for this kind of +configurations (e.g. -smp 8,sockets=0) is removed since 9.0, users have +to ensure that all the topology members described with -smp are greater +than zero. User-mode emulator command line arguments ----------------------------------------- diff --git a/hw/core/machine-smp.c b/hw/core/machine-smp.c index 25019c91ee36..96533886b14e 100644 --- a/hw/core/machine-smp.c +++ b/hw/core/machine-smp.c @@ -105,8 +105,9 @@ void machine_parse_smp_config(MachineState *ms, (config->has_cores && config->cores == 0) || (config->has_threads && config->threads == 0) || (config->has_maxcpus && config->maxcpus == 0)) { - warn_report("Deprecated CPU topology (considered invalid): " - "CPU topology parameters must be greater than zero"); + error_setg(errp, "Invalid CPU topology: " + "CPU topology parameters must be greater than zero"); + return; } /* -- 2.34.1

3 9

[GSOC] Handshake
by Mostafa ali 05 Mar '24

05 Mar '24

Hello lovely people, hope you are all well! I'm looking to contribute to libvirt during the upcoming GSOC 2024, specifically to the XML fuzzing idea. Little about me: I'm a recent graduate of Cairo University, Department of Computer Engineering. I'm extremely interested in all things involving programming languages, compilers, interpreters or metaprogramming and systems programming in general. I'm currently teaching part-time at my university. After reading your GSOC FAQ and the 4 libvirt-specific requirements listed, I have compiled libvirt on my machine and the tests do seem to have run successfully if ninja's terminal logging is to be trusted. After (obviously!) subscribing to your development list, it now remains to have an upstream contribution and the interview. 1- Regarding the interview, the FAQ says it will probably be conducted over IRC. I haven't used IRC before, currently reading up on how to use it. Any specific advice/irc client/guide regarding that ? Also, will the interview be conducted before the acceptance of the contribution or after it ? 2- Regarding the required contribution, I see here https://gitlab.com/libvirt/libvirt/-/issues?label_name=bitesizedtask 2 issues that look interesting, the one about converting the json parsing library and another about switching the code to use Glib's autofree instead of malloc and free. The json one looks more interesting (and difficult!) but it looks like it was already assigned to someone else (and also that it's a whole other GSOC project ?). So is the autofree one suitable as a good first issue for me? That's all. Sorry for any inconvenience and many thanks for your time. Regards, Mostafa

2 1

[PATCH v2] storage: Upgrade default qcow2 version
by Abhiram Tilak 05 Mar '24

05 Mar '24

Change the default to modern qcow2 as it's supported by all qemu versions supported by libvirt and `qemu-img` already defaults to the new format since QEMU 1.7. Some Unittests require changes to pass, now that version 1.1 is default. Unittests like `qcow2-1.1.argv` may not be relevant anymore, but this patch doesn't affect them. Signed-off-by: Abhiram Tilak <atp.exp(a)gmail.com> Reviewed-by: Peter Krempa <pkrempa(a)redhat.com> --- src/storage/storage_util.c | 2 +- .../storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv | 2 +- .../qcow2-luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-luks.argv | 2 +- .../qcow2-nobacking-convert-prealloc-compat.argv | 2 +- .../storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv | 2 +- .../qcow2-nocapacity-convert-prealloc.argv | 2 +- tests/storagevolxml2argvdata/qcow2-nocapacity.argv | 2 +- tests/storagevolxml2argvdata/qcow2-nocow-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-zerocapacity.argv | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 7bf815d978..28d5fce4f0 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -765,7 +765,7 @@ storageBackendCreateQemuImgOpts(virStorageEncryptionInfoDef *encinfo, if (info->compat) virBufferAsprintf(&buf, "compat=%s,", info->compat); else if (info->format == VIR_STORAGE_FILE_QCOW2) - virBufferAddLit(&buf, "compat=0.10,"); + virBufferAddLit(&buf, "compat=1.1,"); if (info->clusterSize > 0) virBufferAsprintf(&buf, "cluster_size=%llu,", info->clusterSize); diff --git a/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv b/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv index 4b9ccfe8dc..705604b162 100644 --- a/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv +++ b/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv @@ -1,7 +1,7 @@ qemu-img \ create \ -f qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /var/lib/libvirt/images/sparse-qcow2.img \ 1073741824K qemu-img \ diff --git a/tests/storagevolxml2argvdata/qcow2-compat.argv b/tests/storagevolxml2argvdata/qcow2-compat.argv index bf3a50a7f3..40fbe065e0 100644 --- a/tests/storagevolxml2argvdata/qcow2-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-compat.argv @@ -2,6 +2,6 @@ qemu-img \ create \ -f qcow2 \ -b /dev/null \ --o backing_fmt=raw,compat=0.10 \ +-o backing_fmt=raw,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv b/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv index dbc7deb16a..b68da425d9 100644 --- a/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv @@ -2,6 +2,6 @@ qemu-img \ convert \ -f raw \ -O qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /dev/HostVG/Swap \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv index d89622d4a6..3068b4b38d 100644 --- a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv +++ b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv @@ -2,7 +2,7 @@ qemu-img \ create \ -f qcow2 \ --object secret,id=OtherDemoLuks.img_encrypt0,file=/path/to/secretFile \ --o encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=0.10 \ +-o encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=1.1 \ /var/lib/libvirt/images/OtherDemoLuks.img \ 5242880K qemu-img \ diff --git a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv index 4d910552d0..948e9ac66d 100644 --- a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv +++ b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv @@ -1,7 +1,7 @@ qemu-img \ create \ -f qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /var/lib/libvirt/images/sparse-qcow2.img \ 1073741824K qemu-img \ diff --git a/tests/storagevolxml2argvdata/qcow2-luks.argv b/tests/storagevolxml2argvdata/qcow2-luks.argv index 308316c90c..a3be41a406 100644 --- a/tests/storagevolxml2argvdata/qcow2-luks.argv +++ b/tests/storagevolxml2argvdata/qcow2-luks.argv @@ -3,6 +3,6 @@ create \ -f qcow2 \ -b /dev/null \ --object secret,id=OtherDemoLuks.img_encrypt0,file=/path/to/secretFile \ --o backing_fmt=raw,encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=0.10 \ +-o backing_fmt=raw,encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=1.1 \ /var/lib/libvirt/images/OtherDemoLuks.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv b/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv index 463ae26779..a130ed8894 100644 --- a/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv @@ -2,6 +2,6 @@ qemu-img \ convert \ -f raw \ -O qcow2 \ --o preallocation=metadata,compat=0.10 \ +-o preallocation=metadata,compat=1.1 \ /var/lib/libvirt/images/sparse.img \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv b/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv index 510e0c13f6..440ad8f122 100644 --- a/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv @@ -1,6 +1,6 @@ qemu-img \ create \ -f qcow2 \ --o preallocation=metadata,compat=0.10 \ +-o preallocation=metadata,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv b/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv index 0152b1efb6..3bf8613d72 100644 --- a/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv +++ b/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv @@ -2,6 +2,6 @@ qemu-img \ convert \ -f raw \ -O qcow2 \ --o preallocation=falloc,compat=0.10 \ +-o preallocation=falloc,compat=1.1 \ /var/lib/libvirt/images/sparse.img \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-nocapacity.argv b/tests/storagevolxml2argvdata/qcow2-nocapacity.argv index 047932a559..924c5c6084 100644 --- a/tests/storagevolxml2argvdata/qcow2-nocapacity.argv +++ b/tests/storagevolxml2argvdata/qcow2-nocapacity.argv @@ -2,5 +2,5 @@ qemu-img \ create \ -f qcow2 \ -b /dev/null \ --o backing_fmt=raw,compat=0.10 \ +-o backing_fmt=raw,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv b/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv index 4cc7904cfc..ae94e4e588 100644 --- a/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv @@ -2,6 +2,6 @@ qemu-img \ create \ -f qcow2 \ -b /dev/null \ --o backing_fmt=raw,nocow=on,compat=0.10 \ +-o backing_fmt=raw,nocow=on,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv b/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv index 607c642e6f..05e31509cb 100644 --- a/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv +++ b/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv @@ -1,6 +1,6 @@ qemu-img \ create \ -f qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 0K -- 2.42.1

1 0

[PATCH v2] storage: Upgrade default qcow2 version
by Abhiram Tilak 05 Mar '24

05 Mar '24

Change the default to modern qcow2 as it's supported by all qemu versions supported by libvirt and `qemu-img` already defaults to the new format since QEMU 1.7. Some Unittests require changes to pass, now that version 1.1 is default. Unittests like `qcow2-1.1.argv` may not be relevant anymore, but this patch doesn't affect them. Signed-off-by: Abhiram Tilak <atp.exp(a)gmail.com> Reviewed-by: Peter Krempa <pkrempa(a)redhat.com> --- src/storage/storage_util.c | 2 +- .../storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv | 2 +- .../qcow2-luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-luks.argv | 2 +- .../qcow2-nobacking-convert-prealloc-compat.argv | 2 +- .../storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv | 2 +- .../qcow2-nocapacity-convert-prealloc.argv | 2 +- tests/storagevolxml2argvdata/qcow2-nocapacity.argv | 2 +- tests/storagevolxml2argvdata/qcow2-nocow-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-zerocapacity.argv | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index 7bf815d978..28d5fce4f0 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -765,7 +765,7 @@ storageBackendCreateQemuImgOpts(virStorageEncryptionInfoDef *encinfo, if (info->compat) virBufferAsprintf(&buf, "compat=%s,", info->compat); else if (info->format == VIR_STORAGE_FILE_QCOW2) - virBufferAddLit(&buf, "compat=0.10,"); + virBufferAddLit(&buf, "compat=1.1,"); if (info->clusterSize > 0) virBufferAsprintf(&buf, "cluster_size=%llu,", info->clusterSize); diff --git a/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv b/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv index 4b9ccfe8dc..705604b162 100644 --- a/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv +++ b/tests/storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv @@ -1,7 +1,7 @@ qemu-img \ create \ -f qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /var/lib/libvirt/images/sparse-qcow2.img \ 1073741824K qemu-img \ diff --git a/tests/storagevolxml2argvdata/qcow2-compat.argv b/tests/storagevolxml2argvdata/qcow2-compat.argv index bf3a50a7f3..40fbe065e0 100644 --- a/tests/storagevolxml2argvdata/qcow2-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-compat.argv @@ -2,6 +2,6 @@ qemu-img \ create \ -f qcow2 \ -b /dev/null \ --o backing_fmt=raw,compat=0.10 \ +-o backing_fmt=raw,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv b/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv index dbc7deb16a..b68da425d9 100644 --- a/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv @@ -2,6 +2,6 @@ qemu-img \ convert \ -f raw \ -O qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /dev/HostVG/Swap \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv index d89622d4a6..3068b4b38d 100644 --- a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv +++ b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv @@ -2,7 +2,7 @@ qemu-img \ create \ -f qcow2 \ --object secret,id=OtherDemoLuks.img_encrypt0,file=/path/to/secretFile \ --o encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=0.10 \ +-o encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=1.1 \ /var/lib/libvirt/images/OtherDemoLuks.img \ 5242880K qemu-img \ diff --git a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv index 4d910552d0..948e9ac66d 100644 --- a/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv +++ b/tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt2fileqcow2.argv @@ -1,7 +1,7 @@ qemu-img \ create \ -f qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /var/lib/libvirt/images/sparse-qcow2.img \ 1073741824K qemu-img \ diff --git a/tests/storagevolxml2argvdata/qcow2-luks.argv b/tests/storagevolxml2argvdata/qcow2-luks.argv index 308316c90c..a3be41a406 100644 --- a/tests/storagevolxml2argvdata/qcow2-luks.argv +++ b/tests/storagevolxml2argvdata/qcow2-luks.argv @@ -3,6 +3,6 @@ create \ -f qcow2 \ -b /dev/null \ --object secret,id=OtherDemoLuks.img_encrypt0,file=/path/to/secretFile \ --o backing_fmt=raw,encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=0.10 \ +-o backing_fmt=raw,encrypt.format=luks,encrypt.key-secret=OtherDemoLuks.img_encrypt0,compat=1.1 \ /var/lib/libvirt/images/OtherDemoLuks.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv b/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv index 463ae26779..a130ed8894 100644 --- a/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-nobacking-convert-prealloc-compat.argv @@ -2,6 +2,6 @@ qemu-img \ convert \ -f raw \ -O qcow2 \ --o preallocation=metadata,compat=0.10 \ +-o preallocation=metadata,compat=1.1 \ /var/lib/libvirt/images/sparse.img \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv b/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv index 510e0c13f6..440ad8f122 100644 --- a/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv @@ -1,6 +1,6 @@ qemu-img \ create \ -f qcow2 \ --o preallocation=metadata,compat=0.10 \ +-o preallocation=metadata,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv b/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv index 0152b1efb6..3bf8613d72 100644 --- a/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv +++ b/tests/storagevolxml2argvdata/qcow2-nocapacity-convert-prealloc.argv @@ -2,6 +2,6 @@ qemu-img \ convert \ -f raw \ -O qcow2 \ --o preallocation=falloc,compat=0.10 \ +-o preallocation=falloc,compat=1.1 \ /var/lib/libvirt/images/sparse.img \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-nocapacity.argv b/tests/storagevolxml2argvdata/qcow2-nocapacity.argv index 047932a559..924c5c6084 100644 --- a/tests/storagevolxml2argvdata/qcow2-nocapacity.argv +++ b/tests/storagevolxml2argvdata/qcow2-nocapacity.argv @@ -2,5 +2,5 @@ qemu-img \ create \ -f qcow2 \ -b /dev/null \ --o backing_fmt=raw,compat=0.10 \ +-o backing_fmt=raw,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img diff --git a/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv b/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv index 4cc7904cfc..ae94e4e588 100644 --- a/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv +++ b/tests/storagevolxml2argvdata/qcow2-nocow-compat.argv @@ -2,6 +2,6 @@ qemu-img \ create \ -f qcow2 \ -b /dev/null \ --o backing_fmt=raw,nocow=on,compat=0.10 \ +-o backing_fmt=raw,nocow=on,compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 5242880K diff --git a/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv b/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv index 607c642e6f..05e31509cb 100644 --- a/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv +++ b/tests/storagevolxml2argvdata/qcow2-zerocapacity.argv @@ -1,6 +1,6 @@ qemu-img \ create \ -f qcow2 \ --o compat=0.10 \ +-o compat=1.1 \ /var/lib/libvirt/images/OtherDemo.img \ 0K -- 2.42.1

1 0

[PATCH] virsh: Fix overflow error of freepages command
by Adam Julis 05 Mar '24

05 Mar '24

Trying to print pages of a size larger than the UINT_MAX of the given platform (for example, around 4G on 64-bit intel), a system error was printed, but this is a legitimate request, fixed. vshCommandOptScaledInt requiers set maximum returning size for the variable '&bytes'. It was set as UINT_MAX, while the public API variable 'kibibytes', which loads the 'bytes' lately, is type of UINT. Since it's kibibytes, the value in bytes should be 1024* bigger and it still will works correctly. So the correct max size of bytes is UINT_MAX * 1024. Resolves: https://issues.redhat.com/browse/RHEL-23608 Signed-off-by: Adam Julis <ajulis(a)redhat.com> --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 6c14be865f..5a934d7a7f 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -335,7 +335,7 @@ cmdFreepages(vshControl *ctl, const vshCmd *cmd) VSH_EXCLUSIVE_OPTIONS_VAR(all, cellno); - if (vshCommandOptScaledInt(ctl, cmd, "pagesize", &bytes, 1024, UINT_MAX) < 0) + if (vshCommandOptScaledInt(ctl, cmd, "pagesize", &bytes, 1024, UINT_MAX * 1024ULL) < 0) goto cleanup; kibibytes = VIR_DIV_UP(bytes, 1024); -- 2.43.2

2 1

[PATCH 0/2] storage: Upgrade default qcow2 verion to 1.1
by Abhiram Tilak 05 Mar '24

05 Mar '24

Right now the default qcow2 version if not specified explicitly, defaults to 0.10. Certain features like live snapshots, cluster size specification require 1.1 to work. This patch series aims at upgrading the qcow2 default image version, and use compatibility version 1.1 unless specified. This also requires correcting multiple testcases related to this compat version. If any other locations require changing, they will be added as a part of this series. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/602 Abhiram Tilak (2): storage: change assigning qcow2 compat to 1.1 from 0.10 automatically storage: fix testcases on changing the default qcow2 compat to 1.1 src/storage/storage_util.c | 2 +- .../storagevolxml2argvdata/luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-from-logical-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-luks-convert-encrypt.argv | 2 +- .../qcow2-luks-convert-encrypt2fileqcow2.argv | 2 +- tests/storagevolxml2argvdata/qcow2-luks.argv | 2 +- .../qcow2-nobacking-convert-prealloc-compat.argv | 2 +- .../storagevolxml2argvdata/qcow2-nobacking-prealloc-compat.argv | 2 +- .../qcow2-nocapacity-convert-prealloc.argv | 2 +- tests/storagevolxml2argvdata/qcow2-nocapacity.argv | 2 +- tests/storagevolxml2argvdata/qcow2-nocow-compat.argv | 2 +- tests/storagevolxml2argvdata/qcow2-zerocapacity.argv | 2 +- 13 files changed, 13 insertions(+), 13 deletions(-) -- 2.42.1

3 4

[PATCH] qemu: Optimize CPU check='partial' for usable CPUs
by Jiri Denemark 05 Mar '24

05 Mar '24

Ideally check='partial' would check exactly the features QEMU would want to enable when asked for a specific CPU model (and features). But there is no way we could ask QEMU how a specific CPU would look like. So we use our definition from CPU map, which may slightly differ as QEMU adds or removes features from CPU models, and thus we may end up checking features which QEMU would not enable while missing some required ones. We can do better in specific cases, though. If a CPU definition uses only a model and disabled features (or none at all), we already know whether QEMU can enable all features required by the CPU model as that's what we use to set usable='yes' attribute in the list of available CPU models in domain capbilities XML. So when a usable CPU model is requested without asking for additional features (disabling features is fine) we can avoid our possible inaccurate check using our CPU map. For backward compatibility we only consider usable models. If a specified model is not usable, we still check it the old way and even let QEMU start it (and disable some features) in case our definition lacks some features compared to QEMU. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_capabilities.c | 44 ++++++++++++++++++++++++++++++++++++ src/qemu/qemu_capabilities.h | 3 +++ src/qemu/qemu_process.c | 1 + 3 files changed, 48 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index e383d85920..cb9846dfcf 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -2433,6 +2433,50 @@ virQEMUCapsIsCPUDeprecated(virQEMUCaps *qemuCaps, } +/** + * virQEMUCapsIsCPUUsable: + * @qemuCaps: QEMU capabilities + * @type: virtualization type (kvm vs tcg) + * @cpu: CPU definition to check, including explicitly configured features + * + * Checks whether @cpu is considered usable by QEMU, i.e., all features + * required by the CPU model are supported and can be enabled. If so, we can + * avoid checking the CPU according to its definition in the CPU map when + * starting a domain with check='partial'. Our checks could be inaccurate + * anyway because QEMU might have changed the definition of the CPU model + * since we added it into the CPU map. + * + * Returns true iff @cpu is usable. + */ +bool +virQEMUCapsIsCPUUsable(virQEMUCaps *qemuCaps, + virDomainVirtType type, + virCPUDef *cpu) +{ + qemuMonitorCPUDefs *defs; + size_t i; + + if (!cpu->model || + !(defs = virQEMUCapsGetAccel(qemuCaps, type)->cpuModels)) + return false; + + /* CPU model usability is valid only when CPU def does not contain any + * features or all features are disabled. + */ + for (i = 0; i < cpu->nfeatures; i++) { + if (cpu->features[i].policy != VIR_CPU_FEATURE_DISABLE) + return false; + } + + for (i = 0; i < defs->ncpus; i++) { + if (STREQ(defs->cpus[i].name, cpu->model)) + return defs->cpus[i].usable == VIR_DOMCAPS_CPU_USABLE_YES; + } + + return false; +} + + bool virQEMUCapsIsMachineDeprecated(virQEMUCaps *qemuCaps, virDomainVirtType type, diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index 486a4a6f63..ef1ad2c01c 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -770,6 +770,9 @@ const char *virQEMUCapsGetMachineDefaultCPU(virQEMUCaps *qemuCaps, bool virQEMUCapsIsCPUDeprecated(virQEMUCaps *qemuCaps, virDomainVirtType type, const char *model); +bool virQEMUCapsIsCPUUsable(virQEMUCaps *qemuCaps, + virDomainVirtType type, + virCPUDef *cpu); bool virQEMUCapsIsMachineDeprecated(virQEMUCaps *qemuCaps, virDomainVirtType type, const char *machine); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 6e51d6586b..8e35d0a73f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -6288,6 +6288,7 @@ qemuProcessUpdateGuestCPU(virDomainDef *def, g_autoptr(virDomainCapsCPUModels) cpuModels = NULL; if (def->cpu->check == VIR_CPU_CHECK_PARTIAL && + !virQEMUCapsIsCPUUsable(qemuCaps, def->virtType, def->cpu) && virCPUCompare(hostarch, virQEMUCapsGetHostModel(qemuCaps, def->virtType, VIR_QEMU_CAPS_HOST_CPU_FULL), -- 2.44.0

2 1

[PATCH] virsh: Fix overflow error of freepages command
by Adam Julis 05 Mar '24

05 Mar '24

Trying to print pages of a size larger than the UINT_MAX of the given platform, a system error was printed, but this is a legitimate request, fixed Signed-off-by: Adam Julis <ajulis(a)redhat.com> --- tools/virsh-host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 6c14be865f..dc1282e718 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -335,7 +335,7 @@ cmdFreepages(vshControl *ctl, const vshCmd *cmd) VSH_EXCLUSIVE_OPTIONS_VAR(all, cellno); - if (vshCommandOptScaledInt(ctl, cmd, "pagesize", &bytes, 1024, UINT_MAX) < 0) + if (vshCommandOptScaledInt(ctl, cmd, "pagesize", &bytes, 1024, UINT_MAX*1024ULL) < 0) goto cleanup; kibibytes = VIR_DIV_UP(bytes, 1024); -- 2.43.2

2 1

[PATCH] cpu: x86: Check for invalid CPU data from hypervisor
by Jiri Denemark 05 Mar '24

05 Mar '24

Recently a kernel bug caused QEMU to report a CPU feature as enabled while listing it in the "unavailable-features" list of features that were requested, but could not be enabled. The feature was actually enabled, but we marked it as disabled when starting a domain. Later when the domain is migrated, the destination requests the feature to be disabled, which breaks the guest ABI or if we are lucky QEMU just fails to load the migration stream. Let's make similar bugs more visible in the future by refusing to even start the domain. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu/cpu_x86.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 6b2531b360..e8409ce616 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -3019,6 +3019,14 @@ virCPUx86UpdateLive(virCPUDef *cpu, x86DataIsSubset(&modelDisabled->data, &feature->data)) expected = VIR_CPU_FEATURE_DISABLE; + if (x86DataIsSubset(&enabled, &feature->data) && + x86DataIsSubset(&disabled, &feature->data)) { + virReportError(VIR_ERR_OPERATION_FAILED, + _("hypervisor provided conflicting CPU data: feature '%1$s' is both enabled and disabled at the same time"), + feature->name); + return -1; + } + if (expected == VIR_CPU_FEATURE_DISABLE && x86DataIsSubset(&enabled, &feature->data)) { VIR_DEBUG("Feature '%s' enabled by the hypervisor", feature->name); -- 2.44.0

2 1

RE: join running core dump job
by Thanos Makatos 04 Mar '24

04 Mar '24

> -----Original Message----- > From: Thanos Makatos <thanos.makatos(a)nutanix.com> > Sent: Monday, March 4, 2024 5:24 PM > To: devel(a)lists.libvirt.org > Subject: join running core dump job > > Is there a way to programmatically wait for a previously initiated > virDomainCoreDumpWithFormat() where the process that started it died? I'm > looking at the API and don't seem to find anything relevant. I suppose I could > poll via virDomainGetJobStats(), but, ideally, I'd like a function that would join > the dump job and return when the dump job finishes. > _______________________________________________ > Devel mailing list -- devel(a)lists.libvirt.org > To unsubscribe send an email to devel-leave(a)lists.libvirt.org I see there's qemuDumpWaitForCompletion(), looks promising.

1 0

[PATCH] ci: refresh with lcitool manifest
by Daniel P. Berrangé 04 Mar '24

04 Mar '24

Picks up the switch from FreeBSD 13.2 to 13.3 Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- ci/gitlab/builds.yml | 2 +- ci/lcitool/targets/freebsd-13.yml | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) delete mode 100644 ci/lcitool/targets/freebsd-13.yml diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml index 49a0b27029..b23a3989b9 100644 --- a/ci/gitlab/builds.yml +++ b/ci/gitlab/builds.yml @@ -619,7 +619,7 @@ x86_64-freebsd-13: needs: [] allow_failure: false variables: - CIRRUS_VM_IMAGE_NAME: freebsd-13-2 + CIRRUS_VM_IMAGE_NAME: freebsd-13-3 CIRRUS_VM_IMAGE_SELECTOR: image_family CIRRUS_VM_INSTANCE_TYPE: freebsd_instance INSTALL_COMMAND: pkg install -y diff --git a/ci/lcitool/targets/freebsd-13.yml b/ci/lcitool/targets/freebsd-13.yml deleted file mode 100644 index 0337926479..0000000000 --- a/ci/lcitool/targets/freebsd-13.yml +++ /dev/null @@ -1,2 +0,0 @@ -cirrus: - image_name: freebsd-13-2 -- 2.43.0

2 1

join running core dump job
by Thanos Makatos 04 Mar '24

04 Mar '24

Is there a way to programmatically wait for a previously initiated virDomainCoreDumpWithFormat() where the process that started it died? I'm looking at the API and don't seem to find anything relevant. I suppose I could poll via virDomainGetJobStats(), but, ideally, I'd like a function that would join the dump job and return when the dump job finishes.

1 0

[PATCH 0/5] qemu: Make firmware parsing failures non-fatal
by Andrea Bolognani 01 Mar '24

01 Mar '24

See 3/5 for information. Andrea Bolognani (5): qemu: Add missing early returns qemu: Rewrite qemuFirmwareFetchParsedConfigs() qemu: Make firmware parsing failures non-fatal tests: Add firmware descriptor for edk2 on loongarch64 tests: Add invalid firmware descriptor src/qemu/qemu_firmware.c | 120 +++++++----------- .../qemu/firmware/50-edk2-loongarch64.json | 29 +++++ .../usr/share/qemu/firmware/93-invalid.json | 5 + tests/qemufirmwaretest.c | 28 ++++ 4 files changed, 107 insertions(+), 75 deletions(-) create mode 100644 tests/qemufirmwaredata/usr/share/qemu/firmware/50-edk2-loongarch64.json create mode 100644 tests/qemufirmwaredata/usr/share/qemu/firmware/93-invalid.json -- 2.43.2

2 6

[PATCH PUSHED] Fix off-by-one error in udevListInterfacesByStatus
by Martin Kletzander 01 Mar '24

01 Mar '24

Ever since this function was introduced in 2012 it could've tried filling in an extra interface name. That was made worse in 2019 when the caller functions started accepting NULL arrays of size 0. This is assigned CVE-2024-1441. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> Reported-by: Alexander Kuznetsov <kuznetsovam(a)altlinux.org> Fixes: 5a33366f5c0b18c93d161bd144f9f079de4ac8ca Fixes: d6064e2759a24e0802f363e3a810dc5a7d7ebb15 Reviewed-by: Ján Tomko <jtomko(a)redhat.com> --- Pushed after review in libvirt-security since this has a CVE. Unfortunately I forgot to split the NEWS update and the actual fix, so sorry to all back-porters. NEWS.rst | 15 +++++++++++++++ src/interface/interface_backend_udev.c | 2 +- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index ac64cf697435..69258880d2d3 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -13,6 +13,21 @@ v10.1.0 (unreleased) * **Security** + * ``CVE-2024-1441``: Fix off-by-one error leading to a crash + + In **libvirt-1.0.0** there were couple of interface listing APIs + introduced which had an off-by-one error. That error could lead to a + very rare crash if an array was passed to those functions which did + not fit all the interfaces. + + In **libvirt-5.10** a check for non-NULL arrays has been adjusted to + allow for NULL arrays with size 0 instead of rejecting all NULL + arrays. However that made the above issue significantly worse since + that off-by-one error now did not write beyond an array, but + dereferenced said NULL pointer making the crash certain in a + specific scenario in which a NULL array of size 0 was passed to the + aforementioned functions. + * **Removed features** * **New features** diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index fb6799ed9406..40914830604e 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -222,7 +222,7 @@ udevListInterfacesByStatus(virConnectPtr conn, g_autoptr(virInterfaceDef) def = NULL; /* Ensure we won't exceed the size of our array */ - if (count > names_len) + if (count >= names_len) break; path = udev_list_entry_get_name(dev_entry); -- 2.44.0

1 0

Release of libvirt-10.1.0
by Jiri Denemark 01 Mar '24

01 Mar '24

The 10.1.0 release of both libvirt and libvirt-python is tagged and signed tarballs are available at https://download.libvirt.org/ https://download.libvirt.org/python/ Thanks everybody who helped with this release by sending patches, reviewing, testing, or providing feedback. Your work is greatly appreciated. * Security * ``CVE-2024-1441``: Fix off-by-one error leading to a crash In libvirt-1.0.0 there were couple of interface listing APIs introduced which had an off-by-one error. That error could lead to a very rare crash if an array was passed to those functions which did not fit all the interfaces. In libvirt-5.10 a check for non-NULL arrays has been adjusted to allow for NULL arrays with size 0 instead of rejecting all NULL arrays. However that made the above issue significantly worse since that off-by-one error now did not write beyond an array, but dereferenced said NULL pointer making the crash certain in a specific scenario in which a NULL array of size 0 was passed to the aforementioned functions. * New features * nodedev: Support updating mdevs The node device driver has been extended to allow updating mediated node devices. Options are available to target the update against the persistent, active or both configurations of a mediated device. Note: The support is only available with at least mdevctl v1.3.0 installed. * qemu: Add support for /dev/userfaultfd On hosts with new enough kernel which supports /dev/userfaultfd libvirt will now automatically grant QEMU access to this device. It's no longer needed to set vm.unprivileged_userfaultfd sysctl. * qemu: Support clusters in CPU topology It is now possible to configure the guest CPU topology to use clusters. Additionally, if CPU clusters are present in the host topology, they will be reported as part of the capabilities XML. * network: Make virtual domains resolvable from the host When starting a virtual network with a new ``register='yes'`` attribute in the ``<domain>`` element, libvirt will configure ``systemd-resolved`` to resolve names of the connected guests using the name server started for this network. * qemu: Introduce dynamicMemslots attribute for virtio-mem QEMU now allows setting ``.dynamic-memslots`` attribute for virtio-mem-pci devices. When turned on, it allows memory exposed to guest to be split into multiple memory slots and thus smaller memory footprint (see the original commit for detailed explanation). * Improvements * nodedev: Add ability to update persistent mediated devices by defining them Existing persistent mediated devices can now also be updated by ``virNodeDeviceDefineXML()`` as long as parent and UUID remain unchanged. * ch: Enable ``ethernet`` interface mode support ``<interface type='ethernet'/>`` can now be used for CH domains. * viraccessdriverpolkit: Add missing vtpm case Secrets with ``<usage type='vtpm'>`` were left unable to be checked for in the access driver, i.e. in ACL rules. Missing code was provided. * virt-admin: Notify users to use explicit URI if connection fails ``virt-admin`` doesn't try to guess the URI of the daemon to manage so a failure to connect may be confusing for users if modular daemons are used. Add a hint to use the URI of the dameon to manage. * Bug fixes * qemu_process: Skip over non-virtio non-TAP NIC models when refreshing rx-filter If ``trustGuestRxFilters`` is enabled for a vNIC that doesn't support it, libvirt may throw an error when such domain is being started, loaded from a saved state, migrated, etc. These errors are now silenced, but make sure to fix such configurations (after previous release it is even possible to change ``trustGuestRxFilters`` value on live domains via ``virDomainUpdateDeviceFlags()`` or ``virsh device-update``). * domain: Fix check for overlapping ``<memory/>`` devices A bug was identified which caused libvirt to report two NVDIMMs as overlapping even though they weren't. This now fixed. * vmx: Accept empty fileName for cdrom-image Turns out, ``fileName`` attribute (which contains path to CDROM image) can be set to an empty string (``""``) to denote a state in which the CDROM has no medium in it. Libvirt used to reject such configuration file, but not anymore. * qemu_hotplug: Don't lose 'created' flag in qemuDomainChangeNet() When starting a domain, libvirt tracks what resources it created for it and which were pre-existing and uses this information to preserve pre-existing resources when cleaning up after said domain is shut off. But for macvtaps this information was lost after the macvtap device was changed (e.g. via ``virsh update-device``). * Fix virStream hole handling When a client sent multiple holes into a virStream it may have caused daemon hangup as the daemon stopped processing RPC from the client temporarily. This is now fixed. * nodedev: Don't generate broken XML with certain hardware A broken node device XML would be generated in a rare case when a hardware device had certain characters in the VPD fields. * qemu: Fix reservation of manually specified port for disk migration A manually specified port would not be relased after disk migration making it impossible to use it again. Enjoy. Jirka

1 0

[PATCH] NEWS: Update for release
by Peter Krempa 01 Mar '24

01 Mar '24

Mention improvement of virt-admin, and fixes for the VPD xml and disk migration port bug. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com> --- NEWS.rst | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/NEWS.rst b/NEWS.rst index d270b2397d..4a71c7d3f0 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -52,7 +52,7 @@ v10.1.0 (unreleased) * **Improvements** -* nodedev: Add ability to update persistent mediated devices by defining them + * nodedev: Add ability to update persistent mediated devices by defining them Existing persistent mediated devices can now also be updated by ``virNodeDeviceDefineXML()`` as long as parent and UUID remain unchanged. @@ -66,6 +66,12 @@ v10.1.0 (unreleased) Secrets with ``<usage type='vtpm'>`` were left unable to be checked for in the access driver, i.e. in ACL rules. Missing code was provided. + * virt-admin: Notify users to use explicit URI if connection fails + + ``virt-admin`` doesn't try to guess the URI of the daemon to manage so a + failure to connect may be confusing for users if modular daemons are used. + Add a hint to use the URI of te dameon to manage. + * **Bug fixes** * qemu_process: Skip over non-virtio non-TAP NIC models when refreshing rx-filter @@ -103,6 +109,16 @@ v10.1.0 (unreleased) daemon hangup as the daemon stopped processing RPC from the client temporarily. This is now fixed. + * nodedev: Don't generate broken XML with certain hardware + + A broken node device XML would be generated in a rare case when a hardware + device had certain characters in the VPD fields. + + * qemu: Fix reservation of manually specified port for disk migration + + A manually specified port would not be relased after disk migration making + it impossible to use it again. + v10.0.0 (2024-01-15) ==================== -- 2.43.0

3 2

[PATCH 0/9] Fix broken HTML in API docs
by Peter Krempa 01 Mar '24

01 Mar '24

While checking API docs after recent migration to gitlab-pages I've noticed that the footer is not properly rendered. A deeper dig showed that the issue is that empty <div> elements, while formatted by the XML output version of XSLT conversion is turned into the non-pair empty variant. This contradicts the HTML standard which we declare to use for our pages and thus is mis-parsed into dom, where every empty div is treated as a start of a div, thus nesting everything. This series fixes the above and also many other errors pointed out by the HTML validator at: https://validator.w3.org/ Compare: https://libvirt.org/html/libvirt-libvirt-domain.html vs https://pipo.sk.gitlab.io/-/libvirt/-/jobs/6288946946/artifacts/website/htm… and the validation: https://validator.w3.org/nu/?doc=https%3A%2F%2Flibvirt.org%2Fhtml%2Flibvirt… vs https://validator.w3.org/nu/?doc=https%3A%2F%2Fpipo.sk.gitlab.io%2F-%2Flibv… Also non-API pages validation: https://validator.w3.org/nu/?doc=https%3A%2F%2Flibvirt.org%2Fdocs.html vs https://validator.w3.org/nu/?doc=https%3A%2F%2Fpipo.sk.gitlab.io%2F-%2Flibv… Peter Krempa (9): docs: site: Don't generate '<?xml' header for HTML documents docs: page: Add 'lang="en"' for all HTML output documents docs: page: Fix declaration of main javascript source docs: index: Fix import of blog planet javascript docs: newapi: Don't generate empty <div> in template for ACL permissions docs: newapi: Avoid empty <div>s when there is no description docs: newapi: Avoid table where every row has an cell with 'colspan' docs: newapi: Properly skip ACL entries if empty docs: newapi: Fix generation of type definition tables docs/index.rst | 2 +- docs/newapi.xsl | 158 ++++++++++++++++++++++++++---------------------- docs/page.xsl | 7 ++- docs/site.xsl | 5 +- 4 files changed, 93 insertions(+), 79 deletions(-) -- 2.43.0

2 10