- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/2] qemu: add debug-threads support
by Marc-André Lureau 10 Mar '16

10 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and enable debug-threads if supported. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers v2->v3: - move -name command generation in seperate function - fix syntax-check - fix leak v1->v2: - drop the configuration, enable debug-thread automatically Marc-André Lureau (2): qemu: check for debug-threads capability qemu: enable debug threads src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 40 ++++++++++++++++++++++------ tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + 7 files changed, 39 insertions(+), 8 deletions(-) -- 2.5.0

3 5

[libvirt] [PATCH v2 0/2] qemu: add debug-threads support
by Marc-André Lureau 10 Mar '16

10 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and enable debug-threads if supported. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers v1->v2: - drop the configuration, enable debug-thread automatically Marc-André Lureau (2): qemu: check for debug-threads capability qemu: enable debug threads src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +++++++++---- tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + 7 files changed, 16 insertions(+), 4 deletions(-) -- 2.5.0

4 8

[libvirt] [PATCH] qemuxml2argvtest: Fix monitor path in serial-file-log
by Jiri Denemark 10 Mar '16

10 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: Pushed as a build-breaker. tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args b/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args index de313e5..38cad7b 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args @@ -13,7 +13,8 @@ QEMU_AUDIO_DRV=none \ -uuid c7a5fdbd-edaf-9455-926a-d65c16db1809 \ -nographic \ -nodefaults \ --chardev socket,id=charmonitor,path=/tmp/test-monitor,server,nowait \ +-chardev socket,id=charmonitor,path=/tmp/lib/domain--1-QEMUGuest1/monitor.sock,\ +server,nowait \ -mon chardev=charmonitor,id=monitor,mode=readline \ -no-acpi \ -boot c \ -- 2.7.2

1 0

[libvirt] [PATCH 0/4] docs: website: improve readability
by Cole Robinson 10 Mar '16

10 Mar '16

Some css tweaks to improve test readability and be more consistent with other sites (I was using en.wikipedia.org as a reference) First 2 bits are cleanups, latter 2 bits are actual changes. Front before: http://i.imgur.com/zvFqBa9.png Front after: http://i.imgur.com/gsHa5Pq.png List before: http://i.imgur.com/nh6hMsy.png List after: http://i.imgur.com/WxgE4y0.png Text before: http://i.imgur.com/8bvgEYg.png Text after: http://i.imgur.com/wg0hk4r.png Cole Robinson (4): docs: website: Remove the et.redhat.com footer docs: generic.css: minor cleanups docs: generic.css: font size tweaks docs: generic.css: Indentation and spacing tweaks docs/Makefile.am | 3 --- docs/et.png | Bin 9779 -> 0 bytes docs/footer_corner.png | Bin 2359 -> 0 bytes docs/footer_pattern.png | Bin 817 -> 0 bytes docs/generic.css | 57 ++++++++++++++++++++++++------------------------ docs/libvirt.css | 34 ----------------------------- docs/page.xsl | 6 ----- 7 files changed, 29 insertions(+), 71 deletions(-) delete mode 100644 docs/et.png delete mode 100644 docs/footer_corner.png delete mode 100644 docs/footer_pattern.png -- 2.5.0

3 10

[libvirt] [PATCH 0/3] storage: fix file unlink with old uid cache
by Cole Robinson 10 Mar '16

10 Mar '16

There's been several reports of issues deleting storage volumes after creating a VM with virt-manager/virt-install. These patches fix the reports, see patch descriptions for details. Patch #1 is the main fix IMO Patch #2 is a related cleanup that clarifies some remove logic Patch #3 is optional and may not be exhaustive, it's mostly for discussion Pavel's original patches and discussions: https://www.redhat.com/archives/libvir-list/2016-February/msg01224.html https://bugzilla.redhat.com/show_bug.cgi?id=1289327 https://bugzilla.redhat.com/show_bug.cgi?id=1293804 Cole Robinson (3): storage: refresh volume before deletion util: virfile: Clarify setuid usage for virFileRemove util: virfile: Only setuid for virFileRemove if on NFS src/storage/storage_driver.c | 10 ++++++++++ src/util/virfile.c | 39 +++++++++++++++++++++++++++++++++------ 2 files changed, 43 insertions(+), 6 deletions(-) -- 2.5.0

4 13

[libvirt] [PATCH v2 0/8] Use virtlogd for chardevs & support logging
by Daniel P. Berrange 10 Mar '16

10 Mar '16

This series of patches does two things * Converts the type=file chardev over to use virtlogd (assuming use of virtlogd is enabled in qemu.conf) * Adds a <log file="..."/> element to all chardev sources, allowing data to be captured to a logfile Both of these are important features wanted by openstack. The first thing fixes a long standing security issue that a guest OS can trivially exhuast host disk space by outputing lots of data to its serial port. The second thing allows OpenStack to record boot up messages for a guest's serial console, while still allowing interactive serial console ussage. ie the serial port will be configured with type=tcp, and the new <log> element used to record the data. Both these thing required changes in QEMU, which have been merged for the forthcoming QEMU 2.6 release. Changed in v2: * Split patch 4 up into 4 separate patches * Fix memory leaks * Use common function for building log manager cli args * Add missing XML docs Daniel P. Berrange (8): logging: allow inode/offset params to be NULL conf: allow use of a logfile with chardev backends qemu: add support for logging chardev output to a file qemu: don't append -chardev arg until after value is formatted qemu: move functions for handling FD passing logging: support truncation of logfiles when opening qemu: use virtlogd for character device log files qemu: support use of virtlogd with file based chardevs docs/formatdomain.html.in | 14 + docs/schemas/domaincommon.rng | 12 + src/conf/domain_conf.c | 30 +++ src/conf/domain_conf.h | 2 + src/logging/log_daemon_dispatch.c | 3 +- src/logging/log_handler.c | 6 +- src/logging/log_handler.h | 2 +- src/logging/log_manager.c | 6 +- src/logging/log_manager.h | 2 + src/logging/log_protocol.x | 4 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 282 ++++++++++++++------- src/qemu/qemu_command.h | 9 +- src/qemu/qemu_domain.c | 6 + src/qemu/qemu_domain.h | 3 + src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_process.c | 4 +- .../qemuxml2argv-serial-file-log.args | 25 ++ .../qemuxml2argv-serial-file-log.xml | 39 +++ tests/qemuxml2argvtest.c | 4 +- 21 files changed, 353 insertions(+), 105 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-file-log.xml -- 2.5.0

2 13

[libvirt] [PATCH 0/3] vcpu refactoring fixes
by Peter Krempa 10 Mar '16

10 Mar '16

My recent refactros led to a few bugs. The memory leak was not caused by me, but it looked like I might have broken it so I've fixed it. Peter Krempa (3): qemu: cpu: Don't remove pinning of cold-unplugged cpu conf: Fix off-by-one in virDomainDefGetVcpu qemu: Fix memory leak in qemuGetSchedInfo src/conf/domain_conf.c | 2 +- src/qemu/qemu_driver.c | 15 +-------------- 2 files changed, 2 insertions(+), 15 deletions(-) -- 2.6.2

3 6

[libvirt] [PATCH 0/2] qemu: add debug-threads support
by Marc-André Lureau 10 Mar '16

10 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and a qemu-conf key to enable debug-threads. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers Marc-André Lureau (2): qemu: check for debug-threads capability qemu_conf: add set_debug_threads_name configuration key src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 6 ++++++ src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 14 ++++++++++---- src/qemu/qemu_conf.c | 1 + src/qemu/qemu_conf.h | 1 + src/qemu/test_libvirtd_qemu.aug.in | 1 + tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + 12 files changed, 27 insertions(+), 4 deletions(-) -- 2.5.0

4 6

[libvirt] [PATCH v2 0/2] vcpu info refactors - part 3b
by Peter Krempa 10 Mar '16

10 Mar '16

Peter Krempa (2): qemu: vcpupin: Extract live vcpupin setting into a separate function qemu: Refactor bitmap handling in qemuDomainPinVcpuFlags src/qemu/qemu_driver.c | 163 +++++++++++++++++++++++++++---------------------- 1 file changed, 89 insertions(+), 74 deletions(-) -- 2.6.2

2 3

[libvirt] [PATCH 0/2] persistant live migration with specified XML
by Dmitry Andreev 10 Mar '16

10 Mar '16

Live migration has a bug: specified XML doesn't used for persistant configuration. https://bugzilla.redhat.com/show_bug.cgi?id=835300 This patch-set fixes this problem. Specified XML used for both active and inactive domain XML. Hope this is what it should be. Dmitry Andreev (2): qemuMigrationCookieAddPersistent: change argument type qemu: migration: use specified XML for active and inactive confguration src/qemu/qemu_migration.c | 55 ++++++++++++++++++++++++----------------------- 1 file changed, 28 insertions(+), 27 deletions(-) -- 1.8.3.1

2 3

[libvirt] [PATCH] libxl: small fix in parsing network
by Chunyan Liu 10 Mar '16

10 Mar '16

Signed-off-by: Chunyan Liu <cyliu(a)suse.com> --- src/libxl/libxl_conf.c | 2 +- src/libxl/libxl_domain.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 5133299..48b8826 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1471,7 +1471,7 @@ libxlMakeNicList(virDomainDefPtr def, libxl_domain_config *d_config) VIR_SHRINK_N(x_nics, nnics, nnics - nvnics); d_config->nics = x_nics; - d_config->num_nics = nnics; + d_config->num_nics = nvnics; return 0; diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index 632acfd..50f7eed 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -315,7 +315,7 @@ libxlDomainDeviceDefPostParse(virDomainDeviceDefPtr dev, virDomainHostdevSubsysPCIPtr pcisrc; if (dev->type == VIR_DOMAIN_DEVICE_NET) - hostdev = &(dev->data.net)->data.hostdev.def; + hostdev = &dev->data.net->data.hostdev.def; else hostdev = dev->data.hostdev; pcisrc = &hostdev->source.subsys.u.pci; -- 2.1.4

3 4

[libvirt] [PATCH 0/9] vcpu info refactors - part 3b
by Peter Krempa 09 Mar '16

09 Mar '16

Yet another continuation of the saga. In this episode we add pinning for inactive cpus. Peter Krempa (9): virsh: vcpupin: Ask for pinning info for all vCPUs conf: Extract code filling data for virDomainGetVcpuPinInfo qemu: Report pinning for all vCPUs in qemuDomainGetVcpuPinInfo conf: introduce parser feature flags conf: refactor checking for unsupported memory devices conf: extract ignoring of inactive vcpu pinning information qemu: add support for offline vcpupin qemu: vcpupin: Extract live vcpupin setting into a separate function qemu: Refactor bitmap handling in qemuDomainPinVcpuFlags src/bhyve/bhyve_domain.c | 9 +- src/conf/domain_conf.c | 157 +++++++++++++++++++++++++++--- src/conf/domain_conf.h | 20 +++- src/libvirt_private.syms | 3 +- src/libxl/libxl_domain.c | 7 -- src/libxl/libxl_driver.c | 38 +------- src/lxc/lxc_domain.c | 8 -- src/openvz/openvz_driver.c | 7 -- src/phyp/phyp_driver.c | 6 +- src/qemu/qemu_domain.c | 2 + src/qemu/qemu_driver.c | 234 +++++++++++++++++++-------------------------- src/test/test_driver.c | 38 +------- src/uml/uml_driver.c | 9 +- src/vbox/vbox_common.c | 6 +- src/vmware/vmware_driver.c | 6 +- src/vmx/vmx.c | 8 +- src/vz/vz_driver.c | 6 +- src/xen/xen_driver.c | 7 -- src/xenapi/xenapi_driver.c | 7 -- tools/virsh-domain.c | 3 +- 20 files changed, 279 insertions(+), 302 deletions(-) -- 2.6.2

2 18

[libvirt] [python PATCH] Add support for JOB_COMPLETED event
by Jiri Denemark 09 Mar '16

09 Mar '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- examples/event-test.py | 3 ++ libvirt-override-virConnect.py | 9 ++++++ libvirt-override.c | 64 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 76 insertions(+) diff --git a/examples/event-test.py b/examples/event-test.py index 615f86c..5be4978 100755 --- a/examples/event-test.py +++ b/examples/event-test.py @@ -533,6 +533,8 @@ def myDomainEventDeviceAddedCallback(conn, dom, dev, opaque): def myDomainEventMigrationIteration(conn, dom, iteration, opaque): print("myDomainEventMigrationIteration: Domain %s(%s) started migration iteration %d" % ( dom.name(), dom.ID(), iteration)) +def myDomainEventJobCompletedCallback(conn, dom, params, opaque): + print("myDomainEventJobCompletedCallback: Domain %s(%s) %s" % (dom.name(), dom.ID(), params)) ########################################################################## # Network events @@ -646,6 +648,7 @@ def main(): vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_AGENT_LIFECYCLE, myDomainEventAgentLifecycleCallback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_DEVICE_ADDED, myDomainEventDeviceAddedCallback, None) vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION, myDomainEventMigrationIteration, None) + vc.domainEventRegisterAny(None, libvirt.VIR_DOMAIN_EVENT_ID_JOB_COMPLETED, myDomainEventJobCompletedCallback, None) vc.networkEventRegisterAny(None, libvirt.VIR_NETWORK_EVENT_ID_LIFECYCLE, myNetworkEventLifecycleCallback, None) diff --git a/libvirt-override-virConnect.py b/libvirt-override-virConnect.py index 4231195..396a6ed 100644 --- a/libvirt-override-virConnect.py +++ b/libvirt-override-virConnect.py @@ -225,6 +225,15 @@ cb(self, virDomain(self, _obj=dom), iteration, opaque) return 0 + def _dispatchDomainEventJobCompletedCallback(self, dom, params, cbData): + """Dispatches event to python user domain job completed callbacks + """ + cb = cbData["cb"] + opaque = cbData["opaque"] + + cb(self, virDomain(self, _obj=dom), params, opaque) + return 0 + def domainEventDeregisterAny(self, callbackID): """Removes a Domain Event Callback. De-registering for a domain callback will disable delivery of this event type """ diff --git a/libvirt-override.c b/libvirt-override.c index 2308802..ce36280 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -6835,6 +6835,65 @@ libvirt_virConnectDomainEventMigrationIterationCallback(virConnectPtr conn ATTRI } #endif /* VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION */ +#ifdef VIR_DOMAIN_EVENT_ID_JOB_COMPLETED +static int +libvirt_virConnectDomainEventJobCompletedCallback(virConnectPtr conn ATTRIBUTE_UNUSED, + virDomainPtr dom, + virTypedParameterPtr params, + int nparams, + void *opaque) +{ + PyObject *pyobj_cbData = (PyObject*)opaque; + PyObject *pyobj_dom; + PyObject *pyobj_ret = NULL; + PyObject *pyobj_conn; + PyObject *dictKey; + PyObject *pyobj_dict = NULL; + int ret = -1; + + LIBVIRT_ENSURE_THREAD_STATE; + + pyobj_dict = getPyVirTypedParameter(params, nparams); + if (!pyobj_dict) + goto cleanup; + + if (!(dictKey = libvirt_constcharPtrWrap("conn"))) + goto cleanup; + pyobj_conn = PyDict_GetItem(pyobj_cbData, dictKey); + Py_DECREF(dictKey); + + /* Create a python instance of this virDomainPtr */ + virDomainRef(dom); + if (!(pyobj_dom = libvirt_virDomainPtrWrap(dom))) { + virDomainFree(dom); + goto cleanup; + } + Py_INCREF(pyobj_cbData); + + /* Call the Callback Dispatcher */ + pyobj_ret = PyObject_CallMethod(pyobj_conn, + (char*)"_dispatchDomainEventJobCompletedCallback", + (char*)"OOO", + pyobj_dom, pyobj_dict, pyobj_cbData); + + Py_DECREF(pyobj_cbData); + Py_DECREF(pyobj_dom); + + cleanup: + if (!pyobj_ret) { + DEBUG("%s - ret:%p\n", __FUNCTION__, pyobj_ret); + PyErr_Print(); + Py_XDECREF(pyobj_dict); + } else { + Py_DECREF(pyobj_ret); + ret = 0; + } + + LIBVIRT_RELEASE_THREAD_STATE; + return ret; +} +#endif /* VIR_DOMAIN_EVENT_ID_JOB_COMPLETED */ + static PyObject * libvirt_virConnectDomainEventRegisterAny(PyObject *self ATTRIBUTE_UNUSED, PyObject *args) @@ -6940,6 +6999,11 @@ libvirt_virConnectDomainEventRegisterAny(PyObject *self ATTRIBUTE_UNUSED, cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventMigrationIterationCallback); break; #endif /* VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION */ +#ifdef VIR_DOMAIN_EVENT_ID_JOB_COMPLETED + case VIR_DOMAIN_EVENT_ID_JOB_COMPLETED: + cb = VIR_DOMAIN_EVENT_CALLBACK(libvirt_virConnectDomainEventJobCompletedCallback); + break; +#endif /* VIR_DOMAIN_EVENT_ID_JOB_COMPLETED */ case VIR_DOMAIN_EVENT_ID_LAST: break; } -- 2.7.2

2 1

[libvirt] sVirt shouldn't let Nova do stupid things
by Matthew Booth 08 Mar '16

08 Mar '16

Nova just released a fix for this critical CVE: https://bugs.launchpad.net/nova/+bug/1548450 To summarise, it's a qcow2 backing file exploit. The user writes a malicious qcow2 header to the top of a raw disk, then triggers a bug in Nova which causes it to do format detection. If you read the bug and comments, you'll see that when I initially reported it I was fairly dismissive of its impact because it's only exploitable through libvirt, and the instance is going to be confined by SELinux. But then Dan B points out that sVirt is going to trust whatever Nova tells it to do and label it appropriately. Cue rapid ramping of severity, and it turns out this allows an unprivileged user to read anything on the host, including all raw block devices. I'm not sure exactly where, but something in this stack has failed us. Let's be clear a couple of things, though: 1. This is an egregious, stupid bug in Nova, and Nova shouldn't have egregious, stupid bugs. 2. SELinux should prevent obviously bad things from happening, even in the presence of egregious, stupid bugs. I point that out to head off: 'Well Nova shouldn't do that'. Of course it shouldn't. However, it might, and when it does, I'd like to think that SELinux has its back. It doesn't, though. As I understand it, sVirt is the mechanism libvirt uses for controlling SELinux. I wonder if the current sVirt model is enough to cover the use case where the thing connecting to libvirt is large enough to have its own serious bugs. Is there any way we could define a sane set of operations independent of Nova? Matt -- Matthew Booth Red Hat Engineering, Virtualisation Team Phone: +442070094448 (UK)

2 1

[libvirt] [PATCH v4 0/8] NSS module for libvirt
by Michal Privoznik 08 Mar '16

08 Mar '16

v4 of: https://www.redhat.com/archives/libvir-list/2016-February/msg00693.html diff to v3: - Introduced yet another test to catch linkage problems - Extended nsstest to test multiple addresses - Reworked src/libvirt_nss.la CFLAGS/LDFLAGS - dropped some dependencies - Dropped checking for lease timestamp from nss plugin implementation as it's already done by lease parsing function Michal Privoznik (8): Export virLease* functions for leases file handling virjson: Resolve const correctness Initial support for NSS plugin skeleton libvirt.spec.in: Introduce libvirt-nss package nss: Implement _nss_libvirt_gethostbyname3_r Implement _nss_libvirt_gethostbyname4_r nss: Introduce a test tests: Introduce nsslinktest cfg.mk | 2 +- config-post.h | 24 +++ configure.ac | 2 + libvirt.spec.in | 21 ++ m4/virt-nss.m4 | 51 +++++ po/POTFILES.in | 1 + src/Makefile.am | 60 ++++++ src/libvirt_private.syms | 6 + src/network/leaseshelper.c | 271 +------------------------- src/util/virfile.c | 2 +- src/util/virjson.c | 58 +++--- src/util/virjson.h | 54 +++--- src/util/virlease.c | 304 +++++++++++++++++++++++++++++ src/util/virlease.h | 44 +++++ tests/Makefile.am | 31 ++- tests/nssdata/virbr0.status | 20 ++ tests/nssdata/virbr1.status | 14 ++ tests/nsslinktest.c | 39 ++++ tests/nssmock.c | 140 ++++++++++++++ tests/nsstest.c | 195 +++++++++++++++++++ tools/Makefile.am | 44 +++++ tools/nss/libvirt_nss.c | 463 ++++++++++++++++++++++++++++++++++++++++++++ tools/nss/libvirt_nss.h | 52 +++++ tools/nss/libvirt_nss.syms | 12 ++ 24 files changed, 1580 insertions(+), 330 deletions(-) create mode 100644 m4/virt-nss.m4 create mode 100644 src/util/virlease.c create mode 100644 src/util/virlease.h create mode 100644 tests/nssdata/virbr0.status create mode 100644 tests/nssdata/virbr1.status create mode 100644 tests/nsslinktest.c create mode 100644 tests/nssmock.c create mode 100644 tests/nsstest.c create mode 100644 tools/nss/libvirt_nss.c create mode 100644 tools/nss/libvirt_nss.h create mode 100644 tools/nss/libvirt_nss.syms -- 2.4.10

2 14

[libvirt] GSoC 2016
by Tahir Ramzan 08 Mar '16

08 Mar '16

Respected Sir, I am a MS CS scholar of Virtual University of Pakistan, I want to participate in GSoC 2016 for Libvirt. Data Science, Networks, Information security, digital forensics and ethical hacking are my core areas of interest. Currently, I am working on a research project on live forensics of GPU and volatile memories like RAMs and Caches. I am looking forward your guidance to start my contribution for Libvirt, thanks in anticipation. Regards Tahir Ramzan

4 4

[libvirt] ruby-libvirt mixed storage migration
by Tim Förster - Hetzner Online AG 07 Mar '16

07 Mar '16

Heyho guys, is there any reason why mixed storage migration is restriced. I am unable to serve parameter "migrate_disks" through #migrate_to_uri3. It looks like there is a missing macro here. http://libvirt.org/git/?p=ruby-libvirt.git;a=blob;f=ext/libvirt/domain.c#l3…. Could you please verify this? regrads, tim

2 3

[libvirt] [PATCH] ruby-libvirt: Don't crash in leases_wrap() by passing NULLs to rb_str_new2()
by Dan Williams 07 Mar '16

07 Mar '16

Not all lease values are mandatory, and when they aren't supplied by the libvirt driver they get set to NULL. That makes rb_str_new2() bail out. Signed-off-by: Dan Williams <dcbw(a)redhat.com> --- For example using the qemu driver we don't get 'iaid', and that makes ruby unhappy: [{"iface"=>"virbr1", "expirytime"=>1452189569, "type"=>0, "mac"=>"52:54:00:05:2b:6f", "ipaddr"=>"192.168.121.49", "prefix"=>24, "hostname"=>"openshiftdev", "clientid"=>"ff:00:05:2b:6f:00:01:00:01:1e:21:55:ed:52:54:00:05:2b:6f"}] ext/libvirt/network.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/ext/libvirt/network.c b/ext/libvirt/network.c index 7c77d73..c250d7d 100644 --- a/ext/libvirt/network.c +++ b/ext/libvirt/network.c @@ -269,14 +269,20 @@ static VALUE leases_wrap(VALUE arg) rb_hash_aset(hash, rb_str_new2("expirytime"), LL2NUM(lease->expirytime)); rb_hash_aset(hash, rb_str_new2("type"), INT2NUM(lease->type)); - rb_hash_aset(hash, rb_str_new2("mac"), rb_str_new2(lease->mac)); - rb_hash_aset(hash, rb_str_new2("iaid"), rb_str_new2(lease->iaid)); + if (lease->mac) + rb_hash_aset(hash, rb_str_new2("mac"), rb_str_new2(lease->mac)); + if (lease->iaid) + rb_hash_aset(hash, rb_str_new2("iaid"), rb_str_new2(lease->iaid)); rb_hash_aset(hash, rb_str_new2("ipaddr"), rb_str_new2(lease->ipaddr)); rb_hash_aset(hash, rb_str_new2("prefix"), UINT2NUM(lease->prefix)); - rb_hash_aset(hash, rb_str_new2("hostname"), - rb_str_new2(lease->hostname)); - rb_hash_aset(hash, rb_str_new2("clientid"), - rb_str_new2(lease->clientid)); + if (lease->hostname) { + rb_hash_aset(hash, rb_str_new2("hostname"), + rb_str_new2(lease->hostname)); + } + if (lease->clientid) { + rb_hash_aset(hash, rb_str_new2("clientid"), + rb_str_new2(lease->clientid)); + } rb_ary_store(result, i, hash); } -- 2.4.3

3 6

[libvirt] [PATCH] Fix minor typos in messages
by Yuri Chornoivan 07 Mar '16

07 Mar '16

Hi, Attached is a patch to fix minor typos in libvirt messages. Thanks for fixing them in the repo. By the way, libvirt template has not been updated for almost 1 year on Zanata. Are the translation moved into some new location? Thanks in advance for your answers. Best regards, Yuri

2 1

[libvirt] [PATCH v2 0/7] Fix and enhance statistics of a completed job
by Jiri Denemark 07 Mar '16

07 Mar '16

Jiri Denemark (7): qemu: Store completed stats at the very end of migration qemu: Properly update completed migration stats qemu: Don't explicitly stop CPUs after migration qemu: Fix a race when computing migration downtime qemu: Do not report completed stats until the job finishes Introduce job completed event qemu: Add support for job completed event daemon/remote.c | 38 ++++++++++++++++++ include/libvirt/libvirt-domain.h | 24 ++++++++++++ src/conf/domain_event.c | 85 +++++++++++++++++++++++++++++++++++++++- src/conf/domain_event.h | 10 +++++ src/libvirt-domain.c | 4 +- src/libvirt_private.syms | 2 + src/qemu/qemu_domain.c | 24 ++++++++++++ src/qemu/qemu_domain.h | 4 ++ src/qemu/qemu_driver.c | 4 +- src/qemu/qemu_migration.c | 74 ++++++++++++++++++++++------------ src/qemu/qemu_process.c | 20 +++++++--- src/remote/remote_driver.c | 42 ++++++++++++++++++++ src/remote/remote_protocol.x | 14 ++++++- src/remote_protocol-structs | 9 +++++ tools/virsh-domain.c | 25 ++++++++++++ 15 files changed, 344 insertions(+), 35 deletions(-) -- 2.7.2

2 16

[libvirt] "opertaions" typo on wiki.
by Dennis 07 Mar '16

07 Mar '16

Hi, I tried to edit http://wiki.libvirt.org/page/Main_Page to fix a typo of the word 'operations,' (see email subject) but could not figure out how to create an account. I read on the contact page that if I am not subscribed to the mailing list I am mailing this small insignificant task won't be emailed to a large group of people and will be moderated appropriately. Thanks, Dennis O.

2 1

[libvirt] [libvirt-glib] gconfig: Fix next API version number
by Fabiano Fidêncio 07 Mar '16

07 Mar '16

Commit 01e01f2 introduced a wrong next API version number in libvirt-gconfig.sym Signed-off-by: Fabiano Fidêncio <fidencio(a)redhat.com> --- libvirt-gconfig/libvirt-gconfig.sym | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index f11f97a..5bc2e24 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -733,7 +733,7 @@ global: gvir_config_domain_video_set_vgamem; } LIBVIRT_GCONFIG_0.2.1; -LIBVIRT_GCONFIG_0.2.4 { +LIBVIRT_GCONFIG_0.2.3 { gvir_config_domain_graphics_spice_set_gl; gvir_config_domain_video_set_accel3d; } LIBVIRT_GCONFIG_0.2.2; -- 2.5.0

2 1

[libvirt] [PATCH 00/25] Final pile of qemu_command.c changes
by John Ferlan 07 Mar '16

07 Mar '16

Finishing the adventure - certainly qemuBuildCommandLine looks much cleaner now and is much shorter (~2100 lines down to ~250 lines). The downside is plowing though the changes and the reviews. John Ferlan (25): qemu: Introduce qemuBuildClockCommandLine qemu: Introduce qemuBuildPMCommandLine qemu: Introduce qemuBuildBootCommandLine qemu: Introduce qemuBuildGlobalControllerCommandLine qemu: Introduce qemuBuildControllerDevCommandLine qemu: Introduce qemuBuildHubCommandLine qemu: Introduce qemuBuildDiskDriveCommandLine qemu: Introduce qemuBuildFSDevCommandLine qemu: Introduce qemuBuildNetCommandLine qemu: Introduce qemuBuildSmartcardCommandLine qemu: Introduce qemuBuildSerialCommandLine qemu: Introduce qemuBuildParallelsCommandLine qemu: Introduce qemuBuildChannelsCommandLine qemu: Introduce qemuBuildConsoleCommandLine qemu: Modify qemuBuildTPMCommandLine qemu: Introduce qemuBuildInputCommandLine qemu: Introduce qemuBuildVideoCommandLine qemu: Introduce qemuBuildSoundCommandLine qemu: Introduce qemuBuildWatchdogCommandLine qemu: Introduce qemuBuildRedirdevCommandLine qemu: Introduce qemuBuildHostdevCommandLine qemu: Introduce qemuBuildMemballoonCommandLine qemu: Introduce qemuBuildRNGCommandLine qemu: Introduce qemuBuildNVRAMCommandLine qemu: Introduce qemuBuildPanicCommandLine src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 8 +- src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 7703 +++++++++++++++++++++------------------- src/qemu/qemu_command.h | 46 +- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_domain_address.h | 2 +- 8 files changed, 4073 insertions(+), 3706 deletions(-) -- 2.5.0

2 27

[libvirt] [PATCH] locking: Use bit shift for flag values not constant values.
by John Ferlan 07 Mar '16

07 Mar '16

So far it hasn't bitten us, but if the next value wasn't 4, then the logic used to check flag bits would have issues. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Noted this while reviewing danpb's virtlogd as chardev series. src/locking/lock_driver_lockd.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/locking/lock_driver_lockd.h b/src/locking/lock_driver_lockd.h index baf346a..6931fe7 100644 --- a/src/locking/lock_driver_lockd.h +++ b/src/locking/lock_driver_lockd.h @@ -23,8 +23,8 @@ # define __VIR_LOCK_DRIVER_LOCKD_H__ enum virLockSpaceProtocolAcquireResourceFlags { - VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = 1, - VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = 2, + VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_SHARED = (1 << 0), + VIR_LOCK_SPACE_PROTOCOL_ACQUIRE_RESOURCE_AUTOCREATE = (1 << 1), }; #endif /* __VIR_LOCK_DRIVER_LOCKD_H__ */ -- 2.5.0

2 1

[libvirt] [PATCH] _virtualboxCreateMachine: Avoid unbound stack
by Michal Privoznik 07 Mar '16

07 Mar '16

If the stars are in the right position and you're building with VBox >= 4.2.0 it will happen that compiler thinks an array allocated on the stack may be unbound: In file included from vbox/vbox_V4_2.c:13:0: vbox/vbox_tmpl.c: In function '_virtualboxCreateMachine': vbox/vbox_tmpl.c:2811:1: error: stack usage might be unbounded [-Werror=stack-usage=] _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **machine, char *uuidstr ATTRIBUTE_UNUSED) ^ Well, given how the variable is declared, I had some hard time seeing it is actually bounded. Surprisingly compiler does not complain because of -Wframe-larger-than. This is because variable length arrays do not count into that warning. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/vbox/vbox_tmpl.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c index 0fbd5b3..7a8205d 100644 --- a/src/vbox/vbox_tmpl.c +++ b/src/vbox/vbox_tmpl.c @@ -2812,7 +2812,7 @@ _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **m { vboxIID iid = VBOX_IID_INITIALIZER; PRUnichar *machineNameUtf16 = NULL; - nsresult rc; + nsresult rc = -1; VBOX_UTF8_TO_UTF16(def->name, &machineNameUtf16); vboxIIDFromUUID(&iid, def->uuid); @@ -2843,18 +2843,12 @@ _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **m override, machine); #else /* VBOX_API_VERSION >= 4002000 */ - const char *flagsUUIDPrefix = "UUID="; - const char *flagsForceOverwrite = "forceOverwrite=0"; - const char *flagsSeparator = ","; - char createFlags[strlen(flagsUUIDPrefix) + VIR_UUID_STRING_BUFLEN + strlen(flagsSeparator) + strlen(flagsForceOverwrite) + 1]; + char *createFlags = NULL; PRUnichar *createFlagsUtf16 = NULL; - snprintf(createFlags, sizeof(createFlags), "%s%s%s%s", - flagsUUIDPrefix, - uuidstr, - flagsSeparator, - flagsForceOverwrite - ); + if (virAsprintf(&createFlags, + "UUID=%s,forceOverwrite=0", uuidstr) < 0) + goto cleanup; VBOX_UTF8_TO_UTF16(createFlags, &createFlagsUtf16); rc = data->vboxObj->vtbl->CreateMachine(data->vboxObj, NULL, @@ -2864,6 +2858,8 @@ _virtualboxCreateMachine(vboxGlobalData *data, virDomainDefPtr def, IMachine **m nsnull, createFlagsUtf16, machine); + cleanup: + VIR_FREE(createFlags); #endif /* VBOX_API_VERSION >= 4002000 */ } VBOX_UTF16_FREE(machineNameUtf16); -- 2.4.10

2 1