- Devel - libvirt List Archives

[libvirt] [PATCH] qemu: Don't overwrite DomainSave errors
by Cole Robinson 15 Mar '16

15 Mar '16

These functions already report fine grained errors, there's no benefit to overwriting the error here. --- src/qemu/qemu_driver.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index edf39d9..36c8fb5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17632,8 +17632,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, ret = virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_FAILED, "%s", - _("Saving live XML config failed")); goto endjob; } @@ -17659,8 +17657,6 @@ qemuDomainSetBlockIoTune(virDomainPtr dom, conf_disk->blkdeviotune = info; ret = virDomainSaveConfig(cfg->configDir, driver->caps, persistentDef); if (ret < 0) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("Write to config file failed")); goto endjob; } } -- 2.5.0

2 2

[libvirt] [PATCH] nodedev: Shorten match condition
by Martin Kletzander 15 Mar '16

15 Mar '16

Just a cleanup I stumbled upon in one of my older branches I did when browsing through some code and forgot to send it. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- src/conf/node_device_conf.c | 41 +++++++++++++++-------------------------- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index c04739f90121..0c9c348e3793 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -1798,37 +1798,26 @@ virNodeDeviceCapMatch(virNodeDeviceObjPtr devobj, return false; } -#define MATCH(FLAG) (flags & (FLAG)) +#define MATCH(FLAG) ((flags & (VIR_CONNECT_LIST_NODE_DEVICES_CAP_ ## FLAG)) && \ + virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_ ## FLAG)) static bool virNodeDeviceMatch(virNodeDeviceObjPtr devobj, unsigned int flags) { /* filter by cap type */ - if (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP)) { - if (!((MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SYSTEM) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SYSTEM)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_PCI_DEV) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_PCI_DEV)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_USB_DEV) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_USB_DEV)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_USB_INTERFACE) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_USB_INTERFACE)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_NET) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_NET)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_HOST) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_HOST)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_TARGET) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_TARGET)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_STORAGE) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_STORAGE)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_FC_HOST) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_FC_HOST)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_VPORTS) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_VPORTS)) || - (MATCH(VIR_CONNECT_LIST_NODE_DEVICES_CAP_SCSI_GENERIC) && - virNodeDeviceCapMatch(devobj, VIR_NODE_DEV_CAP_SCSI_GENERIC)))) + if (flags & VIR_CONNECT_LIST_NODE_DEVICES_FILTERS_CAP) { + if (!(MATCH(SYSTEM) || + MATCH(PCI_DEV) || + MATCH(USB_DEV) || + MATCH(USB_INTERFACE) || + MATCH(NET) || + MATCH(SCSI_HOST) || + MATCH(SCSI_TARGET) || + MATCH(SCSI) || + MATCH(STORAGE) || + MATCH(FC_HOST) || + MATCH(VPORTS) || + MATCH(SCSI_GENERIC))) return false; } -- 2.7.3

2 1

[libvirt] [PATCH] Report error when both live and offline flags are used for migration.
by Nitesh Konkar 15 Mar '16

15 Mar '16

--- src/libvirt-domain.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 9491845..dc11945 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -3617,6 +3617,15 @@ virDomainMigrate(virDomainPtr domain, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -3841,6 +3850,15 @@ virDomainMigrate2(virDomainPtr domain, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_OFFLINE) { if (!VIR_DRV_SUPPORTS_FEATURE(domain->conn->driver, domain->conn, VIR_DRV_FEATURE_MIGRATION_OFFLINE)) { virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", @@ -4014,6 +4032,15 @@ virDomainMigrate3(virDomainPtr domain, VIR_MIGRATE_NON_SHARED_INC, error); + if (flags & VIR_MIGRATE_OFFLINE) { + if (flags & VIR_MIGRATE_LIVE) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("Live and offline migration flags are " + "mutually exclusive")); + goto error; + } + } + if (flags & VIR_MIGRATE_PEER2PEER) { virReportInvalidArg(flags, "%s", _("use virDomainMigrateToURI3 for peer-to-peer " -- 1.8.3.1

2 4

[libvirt] [PATCH 0/2] qemu: Support for QXL heads
by Martin Kletzander 15 Mar '16

15 Mar '16

So this is an old, tiny series that was posted some time ago; actually a lot of time ago. I complained because of two things. First one being that there are no tests, so this series has them in. The second one was that this could break migration from old code since the parameter was not used before. So I coded up a migration flag, handled all the special cases and then started testing it. And while testing it, I've found out that QEMU doesn't care at all about this parameter being there and there is no point in keeping it super-stable, especially when it can be changed on the fly. So I removed all that code and ended up with tiny series very similar to previous attempts by various people. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283207 Martin Kletzander (2): qemu: Check for qxl's max_outputs parameter qemu: Add support to QXL's max_outputs parameter src/qemu/qemu_capabilities.c | 4 ++ src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 8 ++++ .../qemuxml2argv-video-qxl-heads.args | 28 +++++++++++++ .../qemuxml2argv-video-qxl-heads.xml | 47 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 8 ++++ .../qemuxml2xmlout-video-qxl-heads.xml | 47 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 2 + 8 files changed, 146 insertions(+) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-video-qxl-heads.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-video-qxl-heads.xml -- 2.7.2

2 6

[libvirt] github and gitlab mirrors are far behind
by Henning Schild 14 Mar '16

14 Mar '16

Hey, as the title says the mirrors are pretty far behind, probably something is broken there. Henning

1 0

[libvirt] User Behavior Tracking defenses in VMs
by bancfc＠openmailbox.org 14 Mar '16

14 Mar '16

Intended for qemu-discuss /cc/ libvir-list, whonix-devel, tor-dev *** Hello. I work on WhonixOS an anonymity distro based on Tor. This feature request is related to the topics of privacy and anonymity. Its a complex topic and probably not in your area of focus but I think it has important implications because security and privacy are very much related in today's hostile computing environment. Virtualization is useful in presenting an identical environment and set of "hardware" for each user which goes a long way in creating an anonymity set of systems. That way a system attacker, advertisers and online trackers would not be able to fingerprint a user or their hardware. The problem: Tracking techniques have become more sophisticated with time. They advanced from simple cookies to browser/device fingerprinting (which Tor Browser focuses on defeating) to user behavior fingerprinting. The latter is about profiling how a user types on a keyboard or uses a mouse [2]. Keystroke dynamics is a super creepy way to track users based on how long they press keys (dwell time) and the time between key presses (gap time). This is extremely accurate at identifying individuals because of how unique these measurements are. Advertising networks (Google, Facebook...) that fingeprprint users on both the clearnet and Tor can deanonymize users. This technique is already actively used in the wild [6][7]. Potential Solutions: Since input devices are all emulated its a great opportunity to stop this profiling technique. * A security researcher designed a proof of concept plugin for Chrome browser that mitigates this. Implementing something like the PoC addon in [1] known as KeyBoardPrivacy. Some random delay in milliseconds in a 50 millisecond range for dwell and gap times for the emulated keyboards is enough to skew the values to render this attack useless while not affecting performance. * The changes made to Tor Borwser to make JS timers more coarse grained but constant (250ms for keyboard events) were not enough to stop keystroke dynamics fingerprinting because a malicious script can evict the cache and allow extrapolation of true timing events within 1-5ms accuracy .[3][5] Their goal is to instead add jitter to the timers [4]. A similar solution proposed in [4] can be implemented in all QEMU-KVM timers to mitigate both attacks. [1] https://paul.reviews/behavioral-profiling-the-password-you-cant-change/ [2] http://jcarlosnorte.com/security/2016/03/06/advanced-tor-browser-fingerprin… [3] https://www.lightbluetouchpaper.org/2015/07/30/double-bill-password-hashing… [4] https://trac.torproject.org/projects/tor/ticket/16110 [5] https://trac.torproject.org/projects/tor/ticket/1517 [6] http://scraping.pro/no-captcha-recaptcha-challenge/ [7] https://nakedsecurity.sophos.com/2013/11/01/facebook-to-silent-track-users-…

1 0

[libvirt] [PATCH] schema: support 'default' cache mode
by Jim Fehlig 14 Mar '16

14 Mar '16

The docs claims the cache attribute of the disk <driver> element supports 'default' as one of its permissible values, but such configuration fails virt-xml-validate. Add 'default' as one of the cache attribute choices in domaincommon.rng. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- docs/schemas/domaincommon.rng | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 67af93a..d4e375f 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1596,6 +1596,7 @@ <define name="driverCache"> <attribute name="cache"> <choice> + <value>default</value> <value>none</value> <value>writeback</value> <value>writethrough</value> -- 2.1.4

2 3

[libvirt] Storage Backend - buildVolFrom Semantics
by Richard Laager 14 Mar '16

14 Mar '16

storage_backend_rbd.c uses an RBD clone operation to implement buildVolFrom. If I'm understanding the RBD documentation correctly, you cannot delete the parent until the clone has been deleted: http://docs.ceph.com/docs/master/dev/rbd-layering/ "Before cloning a snapshot, you must mark it as protected, to prevent it from being deleted while child images refer to it:" & "To delete the parent, you must first mark it unprotected, which checks that there are no children left:" Is libvirt okay with those semantics for volumes? That is, if you clone a volume, is it acceptable that you cannot delete the parent until you delete the clone? The answer to this affects how I'll write a patch to implement buildVolFrom for storage_backend_zfs.c. -- Richard

2 1

[libvirt] [libvirt-perl][PATCH] Add VIR_ERR_NO_SERVER constant
by Michal Privoznik 14 Mar '16

14 Mar '16

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Changes | 1 + Virt.xs | 1 + lib/Sys/Virt/Error.pm | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/Changes b/Changes index 4e343d5..aa71a1e 100644 --- a/Changes +++ b/Changes @@ -7,6 +7,7 @@ Revision history for perl module Sys::Virt VIR_DOMAIN_TUNABLE_CPU_GLOBAL_PERIOD & VIR_DOMAIN_TUNABLE_CPU_GLOBAL_QUOTA constants - Add VIR_DOMAIN_EVENT_ID_JOB_COMPLETED constant and callback + - Add VIR_ERR_NO_SERVER constant 1.3.2 2016-03-01 diff --git a/Virt.xs b/Virt.xs index 6059cdc..9cb80fa 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8439,4 +8439,5 @@ BOOT: REGISTER_CONSTANT(VIR_ERR_XML_INVALID_SCHEMA, ERR_INVALID_SCHEMA); REGISTER_CONSTANT(VIR_ERR_MIGRATE_FINISH_OK, ERR_MIGRATE_FINISH_OK); REGISTER_CONSTANT(VIR_ERR_AUTH_UNAVAILABLE, ERR_AUTH_UNAVAILABLE); + REGISTER_CONSTANT(VIR_ERR_NO_SERVER, ERR_NO_SERVER); } diff --git a/lib/Sys/Virt/Error.pm b/lib/Sys/Virt/Error.pm index e1b2578..3f6b058 100644 --- a/lib/Sys/Virt/Error.pm +++ b/lib/Sys/Virt/Error.pm @@ -784,6 +784,10 @@ Migration finished but expected to return NULL domain. Authentication services were not available +=item Sys::Virt::Error::ERR_NO_SERVER + +Libvirt server was not found + =back =head1 AUTHORS -- 2.4.10

2 1

[libvirt] [PATCH] qemu: Restore error/cleanup logic for qemuBuildNetCommandLine
by John Ferlan 14 Mar '16

14 Mar '16

The virDomainConfVMNWFilterTeardown was called in the error path of qemuBuildCommandLine once network setup was partially or fully completed using the last_good_net as the basis to determine which filters needed to be torn down. Commit id 'ef2ab8fd' moved that inside the new qemuBuildNetCommandLine, so that lost the failure. Moving that cleanup back outside the call to the more general failure case. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Jan notes post push that the cleanup path after building the network command line was there for any other failures and not just the failure in building the network command line: http://www.redhat.com/archives/libvir-list/2016-March/msg00561.html Even though the teardown is called during qemuProcessStop from virDomainConfVMNWFilterTeardown, the cleanup here could still be done. The reason for moving it inside was based on a different patch where the desire was to not leak anything that could have changed inside one of the moved qemuBuild*CommandLine functions. In this case, though since it's used more generally for cleanup, it seems a good idea to return it. The other option would be to just let qemuProcessStop handle it and a different patch to remove the error reset logic. src/qemu/qemu_command.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ba8c216..2e15c05 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -7659,10 +7659,10 @@ qemuBuildNetCommandLine(virCommandPtr cmd, bool emitBootindex, size_t *nnicindexes, int **nicindexes, - int *bootHostdevNet) + int *bootHostdevNet, + int *last_good_net) { size_t i; - int last_good_net = -1; if (!def->nnets) { /* If we have -device, then we set -nodefault already */ @@ -7697,9 +7697,9 @@ qemuBuildNetCommandLine(virCommandPtr cmd, qemuCaps, vlan, bootNet, vmop, standalone, nnicindexes, nicindexes) < 0) - goto error; + return -1; - last_good_net = i; + *last_good_net = i; /* if this interface is a type='hostdev' interface and we * haven't yet added a "bootindex" parameter to an * emulated network device, save the bootindex - hostdev @@ -7714,11 +7714,6 @@ qemuBuildNetCommandLine(virCommandPtr cmd, } } return 0; - - error: - for (i = 0; last_good_net != -1 && i <= last_good_net; i++) - virDomainConfNWFilterTeardown(def->nets[i]); - return -1; } @@ -8604,6 +8599,7 @@ qemuBuildCommandLine(virConnectPtr conn, bool emitBootindex = false; virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); int bootHostdevNet = 0; + int last_good_net = -1; VIR_DEBUG("conn=%p driver=%p def=%p mon=%p json=%d " @@ -8725,7 +8721,7 @@ qemuBuildCommandLine(virConnectPtr conn, if (qemuBuildNetCommandLine(cmd, driver, def, qemuCaps, vmop, standalone, emitBootindex, nnicindexes, nicindexes, - &bootHostdevNet) < 0) + &bootHostdevNet, &last_good_net) < 0) goto error; if (qemuBuildSmartcardCommandLine(logManager, cmd, def, qemuCaps) < 0) @@ -9280,6 +9276,8 @@ qemuBuildCommandLine(virConnectPtr conn, /* free up any resources in the network driver * but don't overwrite the original error */ originalError = virSaveLastError(); + for (i = 0; last_good_net != -1 && i <= last_good_net; i++) + virDomainConfNWFilterTeardown(def->nets[i]); virSetError(originalError); virFreeError(originalError); virCommandFree(cmd); -- 2.5.0

2 1

[libvirt] [PATCH] vz: fix active domain listing
by Maxim Nestratov 14 Mar '16

14 Mar '16

Since commit 9c14a9ab we have broken active domain listing because reworked prlsdkLoadDomain doesn't set dom->def->id propely. It just looses it when a new def structure is set. Now we make prlsdkConvertDomainState function return void and move calling it after an old dom->def is replaces with a new one within prlsdkLoadDomain function. Signed-off-by: Maxim Nestratov <mnestratov(a)virtuozzo.com> --- src/vz/vz_sdk.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index de73c31..f7d769b 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -1051,7 +1051,7 @@ prlsdkAddVNCInfo(PRL_HANDLE sdkdom, virDomainDefPtr def) return -1; } -static int +static void prlsdkConvertDomainState(VIRTUAL_MACHINE_STATE domainState, PRL_UINT32 envId, virDomainObjPtr dom) @@ -1121,17 +1121,12 @@ prlsdkConvertDomainState(VIRTUAL_MACHINE_STATE domainState, dom->def->id = envId; break; case VMS_UNKNOWN: + default: virDomainObjSetState(dom, VIR_DOMAIN_NOSTATE, VIR_DOMAIN_NOSTATE_UNKNOWN); - break; - default: - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Unknown domain state: %X"), domainState); - return -1; + dom->def->id = -1; break; } - - return 0; } static int @@ -1374,9 +1369,6 @@ prlsdkLoadDomain(vzConnPtr privconn, virDomainObjPtr dom) goto error; } - if (prlsdkConvertDomainState(domainState, envId, dom) < 0) - goto error; - /* assign new virDomainDef without any checks * we can't use virDomainObjAssignDef, because it checks * for state and domain name */ @@ -1386,6 +1378,8 @@ prlsdkLoadDomain(vzConnPtr privconn, virDomainObjPtr dom) VIR_FREE(pdom->home); pdom->home = home; + prlsdkConvertDomainState(domainState, envId, dom); + if (!pdom->sdkdom) { PrlHandle_AddRef(sdkdom); pdom->sdkdom = sdkdom; @@ -1532,8 +1526,8 @@ prlsdkHandleVmStateEvent(vzConnPtr privconn, prlsdkCheckRetGoto(pret, cleanup); pdom = dom->privateData; - if (prlsdkConvertDomainState(domainState, pdom->id, dom) < 0) - goto cleanup; + + prlsdkConvertDomainState(domainState, pdom->id, dom); prlsdkNewStateToEvent(domainState, &lvEventType, -- 2.4.3

2 2

[libvirt] [REPOST PATCH 0/8] Reorganize qemu_command.c in smaller piles (round 3)
by John Ferlan 14 Mar '16

14 Mar '16

Final pile of split. Rather than hope for a review of 25 patches or creating some remote place to place a branch - I'll repost the original: http://www.redhat.com/archives/libvir-list/2016-February/msg00975.html in smaller chunks. Differences in this set of patches vs. original series includes handling merge conflicts for logManager series plus a few minor edits/tweaks for better formatting/flow. This series was based off of git head commit 'ef2ab8fdc' which is the round 1 of the split: http://www.redhat.com/archives/libvir-list/2016-March/msg00288.html This is round 2 of the split based off of commit id '95ca4fe2': http://www.redhat.com/archives/libvir-list/2016-March/msg00491.html John Ferlan (8): qemu: Introduce qemuBuildSoundCommandLine qemu: Introduce qemuBuildWatchdogCommandLine qemu: Introduce qemuBuildRedirdevCommandLine qemu: Introduce qemuBuildHostdevCommandLine qemu: Introduce qemuBuildMemballoonCommandLine qemu: Introduce qemuBuildRNGCommandLine qemu: Introduce qemuBuildNVRAMCommandLine qemu: Introduce qemuBuildPanicCommandLine src/qemu/qemu_command.c | 1346 ++++++++++++++++++++++++++--------------------- src/qemu/qemu_command.h | 25 +- 2 files changed, 743 insertions(+), 628 deletions(-) -- 2.5.0

2 9

[libvirt] [PATCH] qemuBuildVideoCommandLine: Don't access def->videos without check
by Michal Privoznik 14 Mar '16

14 Mar '16

This function can be called over a domain definition that has no video configured. The tests/qemuxml2argvdata/qemuxml2argv-minimal.xml file could serve as an example. Problem is, before the check that domain has some or none video configured, def->videos is dereferenced causing a segmentation fault in case there's none video configured. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/qemu/qemu_command.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index ba8c216..32d32b1 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -3809,7 +3809,7 @@ qemuBuildVideoCommandLine(virCommandPtr cmd, virQEMUCapsPtr qemuCaps) { size_t i; - int primaryVideoType = def->videos[0]->type; + int primaryVideoType; if (!def->nvideos) { /* If we have -device, then we set -nodefaults already */ @@ -3819,6 +3819,8 @@ qemuBuildVideoCommandLine(virCommandPtr cmd, return 0; } + primaryVideoType = def->videos[0]->type; + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY) && ((primaryVideoType == VIR_DOMAIN_VIDEO_TYPE_VGA && virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VGA)) || -- 2.4.10

3 2

[libvirt] Enhancement: Random Clock Offset
by bancfc＠openmailbox.org 14 Mar '16

14 Mar '16

For better system anonymity (to decouple VM OS timestamps leaked in traffic from host ones) a feature can be added to the clock offset variable to select randomly from a specified range of seconds from instead of a fixed number of seconds. That way a guest's clock can vary unpredictably from the host's and confuse correlation by network adversaries. Full Disclosure: I am from the Tor centric Whonix Project - whonix.org and this would be a very useful feature for us.

3 4

[libvirt] [PATCH REPOST 0/9] Reorganize qemu_command.c in smaller piles
by John Ferlan 14 Mar '16

14 Mar '16

Rather than hope for a review of 25 patches or creating some remote place to place a branch - I'll repost the original: http://www.redhat.com/archives/libvir-list/2016-February/msg00975.html in smaller chunks. No differences in these patches other than a rebase to top of tree a short while ago (commit id 'cf091094a'). There were also no conflicts from changes since initial posting. John Ferlan (9): qemu: Introduce qemuBuildClockCommandLine qemu: Introduce qemuBuildPMCommandLine qemu: Introduce qemuBuildBootCommandLine qemu: Introduce qemuBuildGlobalControllerCommandLine qemu: Introduce qemuBuildControllerDevCommandLine qemu: Introduce qemuBuildHubCommandLine qemu: Introduce qemuBuildDiskDriveCommandLine qemu: Introduce qemuBuildFSDevCommandLine qemu: Introduce qemuBuildNetCommandLine src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 8 +- src/qemu/qemu_command.c | 5488 +++++++++++++++++++++------------------- src/qemu/qemu_command.h | 15 +- src/qemu/qemu_domain_address.c | 2 +- src/qemu/qemu_domain_address.h | 2 +- 6 files changed, 2843 insertions(+), 2686 deletions(-) -- 2.5.0

3 20

[libvirt] [PATCH 0/2] Fix building with clang (again)
by Martin Kletzander 14 Mar '16

14 Mar '16

*** SOME VERY RANDOM BLURB HERE *** Martin Kletzander (2): Skip pdwtags-related tests when compiling with clang Fix build with clang src/Makefile.am | 4 +++- tests/qemuxml2argvmock.c | 28 ++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) -- 2.7.3

2 5

[libvirt] any better way to treat device-detach timeout ?
by Zhangbo (Oscar) 14 Mar '16

14 Mar '16

Hi,all: I find that we remove devices only after DEVICE_DELETED event.(patch:3fbf78bd). And it treats TIMEOUT as success. The detailed codes are shown as below: rc = qemuDomainWaitForDeviceRemoval(vm); if (rc == 0 || rc == 1) ret = qemuDomainRemoveDiskDevice(driver, vm, detach); else ret = 0; Here comes the problem: If 1. We pass flags=3(VIR_DOMAIN_AFFECT_LIVE|VIR_DOMAIN_AFFECT_CONFIG) to virDomainDetachDeviceFlags, 2. It timed out to receive DEVICE_DELETED event, virDomainDetachDeviceFlags api will return 0(succeed). Please be aware that: vm->newdef(persistent) removes the device while vm->def(transient) keeps it untouched. 3. Then we try to attach the same device with flag 3, because it differs in newDef and def, the API virDomainDetachDeviceFlags() returns ERROR. Consequent attach/detach jobs all fail after then. So, shall we make it return FAIL when it fails in qemuDomainWaitForDeviceRemoval()? Or just remove the device in def after we get the DEVICE_DELETED event? Any ideas, thanks!

2 5

[libvirt] [PATCH REPOST 0/8] Reorganize qemu_command.c in smaller piles (round 2)
by John Ferlan 11 Mar '16

11 Mar '16

Rather than hope for a review of 25 patches or creating some remote place to place a branch - I'll repost the original: http://www.redhat.com/archives/libvir-list/2016-February/msg00975.html in smaller chunks. Differences in this set of patches vs. original series includes handling merge conflicts for logManager series plus a few minor edits/tweaks for better formatting/flow. This series was based off of git head commit 'ef2ab8fdc' which is the round 1 of the split: http://www.redhat.com/archives/libvir-list/2016-March/msg00288.html John Ferlan (8): qemu: Introduce qemuBuildSmartcardCommandLine qemu: Introduce qemuBuildSerialCommandLine qemu: Introduce qemuBuildParallelsCommandLine qemu: Introduce qemuBuildChannelsCommandLine qemu: Introduce qemuBuildConsoleCommandLine qemu: Modify qemuBuildTPMCommandLine qemu: Introduce qemuBuildInputCommandLine qemu: Introduce qemuBuildVideoCommandLine src/qemu/qemu_capabilities.c | 2 +- src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 1410 +++++++++++++++++++++++------------------- src/qemu/qemu_command.h | 6 +- 4 files changed, 760 insertions(+), 660 deletions(-) -- 2.5.0

2 16

[libvirt] [PATCH] Added qt-virt-manager to Application docs.
by F1ash 11 Mar '16

11 Mar '16

*** BLURB HERE *** F1ash (1): added qt-virt-manager to Application docs; docs/apps.html.in | 4 ++++ 1 file changed, 4 insertions(+) -- 2.7.2

1 1

[libvirt] [libvirt-glib v2 0/9] gconfig: Add hostdev support
by Christophe Fergeau 11 Mar '16

11 Mar '16

Hey, While reviewing Zeeshan's libvirt-gconfig hostdev series, I fixed up a few things, and added a few additional helpers/getters in order to simplify the code/make the test case more complete. This series contains this new code. The changes I made to Zeeshan's initial patches are in separate fixup! commits to make reviewing them easier (for you Zeeshan ;). I expect these to be squashed in the main commits before being pushed. Zeeshan's commits are unchanged from v1. Christophe

2 14

[libvirt] [libvirt-glib v3 1/5] gconfig: Add gvir_config_object_has_child
by Christophe Fergeau 11 Mar '16

11 Mar '16

--- libvirt-gconfig/libvirt-gconfig-object-private.h | 2 ++ libvirt-gconfig/libvirt-gconfig-object.c | 13 +++++++++++++ 2 files changed, 15 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object-private.h b/libvirt-gconfig/libvirt-gconfig-object-private.h index e91c4ef..7a0d21f 100644 --- a/libvirt-gconfig/libvirt-gconfig-object-private.h +++ b/libvirt-gconfig/libvirt-gconfig-object-private.h @@ -117,6 +117,8 @@ GVirConfigObject *gvir_config_object_get_child(GVirConfigObject *object, GVirConfigObject *gvir_config_object_get_child_with_type(GVirConfigObject *object, const gchar *child_name, GType child_type); +gboolean gvir_config_object_has_child(GVirConfigObject *object, + const gchar *child_name); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index bf328f3..6225de2 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -970,3 +970,16 @@ gvir_config_object_get_child(GVirConfigObject *object, child_name, GVIR_CONFIG_TYPE_OBJECT); } + +G_GNUC_INTERNAL gboolean +gvir_config_object_has_child(GVirConfigObject *object, const gchar *child_name) +{ + xmlNodePtr node; + + g_return_val_if_fail(GVIR_CONFIG_IS_OBJECT(object), FALSE); + g_return_val_if_fail(child_name != NULL, FALSE); + + node = gvir_config_xml_get_element(object->priv->node, child_name, NULL); + + return (node != NULL); +} -- 2.5.0

1 4

Re: [libvirt] dist-git build problem on epel-6-x86_64 chroot
by Jean-Marc LIGER 11 Mar '16

11 Mar '16

Le 19/02/2016 11:40, Miroslav Suchý a écrit : > Dne 19.1.2016 v 17:01 Jean-Marc LIGER napsal(a): >> Hy, >> >> I'm facing the problem below on epel-6-x86_64 chroot for both from URL and upload SRPM : >> >> [2016-01-19 15:16:26,790][ INFO][PID:3241] Setting up builder: 172.25.94.167 >> [2016-01-19 15:16:27,991][ INFO][PID:3241] marking build dir with build_id, >> [2016-01-19 15:16:27,992][ INFO][PID:3241] Start build: BuildJob<id: 154509, owner: jmliger, project: virt6-upstream, >> git branch: el6, git_hash: acef5efd6153aa8f9ea760f468333e65c9b46a4e, status: 3 > >> [2016-01-19 15:16:27,993][ INFO][PID:3241] putting into minimal buildroot of epel-6-x86_64 >> [2016-01-19 15:16:28,902][ INFO][PID:3241] Cloning Dist Git repo jmliger/virt6-upstream/libvirt, branch >> acef5efd6153aa8f9ea760f468333e65c9b46a4e, hash el6 >> [2016-01-19 15:16:30,906][ ERROR][PID:3241] Failed to obtain srpm from dist-git >> Traceback (most recent call last): >> File "/usr/share/copr/backend/mockremote/builder.py", line 209, in download_job_pkg_to_builder >> self.remote_pkg_path = list(results["contacted"].values())[0][u"stdout"].split("Wrote: ")[1] >> IndexError: list index out of range >> [2016-01-19 15:16:30,911][ ERROR][PID:3241] builder.build error building pkg `libvirt`: BuildError: Failed to obtain >> srpm from dist-git: ansible results {'dark': {}, 'contacted': {'172.25.94.167': {'cmd': 'rm -rf /tmp/build_package_repo >> && mkdir /tmp/build_package_repo && cd /tmp/build_package_repo && git clone >> http://copr-dist-git.fedorainfracloud.org/git/jmliger/virt6-upstream/libvir… && cd libvirt && git checkout >> acef5efd6153aa8f9ea760f468333e65c9b46a4e && fedpkg-copr --dist el6 srpm', 'end': '2016-01-19 15:16:30.308282', 'stdout': >> 'Downloading libvirt-1.3.1.tar.gz\n\r >> 0.0%\r >> 100.0%\r######################################################################## 100.0%', 'changed': True, 'start': >> '2016-01-19 15:16:28.758321', 'delta': '0:00:01.549961', 'stderr': "Cloning into 'libvirt'...\nNote: checking out >> 'acef5efd6153aa8f9ea760f468333e65c9b46a4e'.\n\nYou are in 'detached HEAD' state. You can look around, make >> experimental\nchanges and commit them, and you can discard any commits you make in this\nstate without impacting any >> branches by performing another checkout.\n\nIf you want to create a new branch to retain commits you create, you may\ndo >> so (now or later) by using -b with the checkout command again. Example:\n\n git checkout -b <new-branch-name>\n\nHEAD >> is now at acef5ef... import_srpm\nerror: line 1800: Trigger fired by the same package is already defined in spec file: >> %post daemon-config-network\n\nerror: query of specfile /tmp/build_package_repo/libvirt/libvirt.spec failed, can't >> parse\n\nCould not execute srpm: Could not get n-v-r-e from '\\n\\n'", 'rc': 1, 'invocation': {'module_name': 'shell', >> 'module_complex_args': {}, 'module_args': u'rm -rf /tmp/build_package_repo && mkdir /tmp/build_package_repo && cd >> /tmp/build_package_repo && git clone http://copr-dist-git.fedorainfracloud.org/git/jmliger/virt6-upstream/libvir… && >> cd libvirt && git checkout acef5efd6153aa8f9ea760f468333e65c9b46a4e && fedpkg-copr --dist el6 srpm'}, 'warnings': >> ['Consider using file module with state=absent rather than running rm']}}} >> [2016-01-19 15:16:31,759][ INFO][PID:3241] End Build: BuildJob<id: 154509, owner: jmliger, project: virt6-upstream, git >> branch: el6, git_hash: acef5efd6153aa8f9ea760f468333e65c9b46a4e, status: 3 > >> >> https://copr.fedoraproject.org/coprs/jmliger/virt6-upstream/builds/ >> >> Regards, >> Jean-Marc LIGER >> >> >> _______________________________________________ >> copr-devel mailing list >> copr-devel(a)lists.fedorahosted.org >> https://lists.fedorahosted.org/admin/lists/copr-devel@lists.fedorahosted.org > It is some problem with your spec file. > You can reproduce it by installing fedpkg-copr from our Copr project and > git clone http://copr-dist-git.fedorainfracloud.org/git/jmliger/virt6-upstream/libvir… > cd libvirt > git checkout acef5efd6153aa8f9ea760f468333e65c9b46a4e > fedpkg-copr -vvv --dist el6 srpm > > Which will fails on: > > rpm --define '_sourcedir /tmp/libvirt' --define '_specdir /tmp/libvirt' --define '_builddir /tmp/libvirt' --define > '_srcrpmdir /tmp/libvirt' --define '_rpmdir /tmp/libvirt' --define 'dist .el6' --define 'rhel 6' --eval '%undefine > fedora' --define 'el6 1' --eval '%undefine fc23' -q --qf "%{NAME} %{EPOCH} %{VERSION} %{RELEASE}??" --specfile > /tmp/libvirt/libvirt.spec > > error: line 1800: Trigger fired by the same package is already defined in spec file: %post daemon-config-network > error: query of specfile /tmp/libvirt/libvirt.spec failed, can't parse > > And your spec file is so complex that I have no idea why it is failing. You may ask on RPM mailing list. > Thanks for your reply, I'm addressing this problem to the libvirt list.

1 1

[libvirt] [PATCH V3 0/2] libxl: support assignment VF to guest from a pool of SRIOV VFs
by Chunyan Liu 11 Mar '16

11 Mar '16

This patch series is to support assigning VF to guest from a pool of SRIOV VFs in libxl driver, detailed usage can be referred to: http://wiki.libvirt.org/page/Networking#Assignment_from_a_pool_of_SRIOV_VFs… Chunyan Liu (2): libxl_conf: reuse virDomainNetGetActualtype in libxlMakeNicList libxl: support assignment from a pool of SRIOV VFs src/libxl/libxl_conf.c | 3 ++- src/libxl/libxl_domain.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ src/libxl/libxl_driver.c | 12 ++++++++++++ tests/Makefile.am | 3 +++ 4 files changed, 63 insertions(+), 1 deletion(-) -- 2.1.4

3 5

[libvirt] [PATCH 0/2] RFC: qemu: aarch64 virtio-pci work
by Cole Robinson 10 Mar '16

10 Mar '16

These patches apply on top of the series I just posted: [PATCH 0/9] tests: qemu: unconditionally enable QEMU_CAPS_DEVICE https://www.redhat.com/archives/libvir-list/2016-January/msg01233.html These specific changers were discussed here: https://www.redhat.com/archives/libvir-list/2015-December/msg00217.html We need a way for apps to tell libvirt 'use virtio-pci not virtio-mmio' for aarch64 -M virt. We can't really make use this by default yet since most OS don't actually support it. So we decided the best course of interaction is to allow users to pass a manual pci controller, and libvirt will interpret that to mean it's okay to use virtio-pci. Patch #1 undoes the current behavior of unconditionally adding a q35 style PCIe controller setup for mach-virt that supports it. In the future we will probably re-enable something like this, but maybe not for a year or so until the bits proliferate to distros. Patch #2 tries to implement the manual pci controller bit. Unfortunately it's not that easy get the ideal XML to work, so this isn't ready for committing. See the commit message for more details Cole Robinson (2): qemu: aarch64: Don't add PCIe controller by default HACK: qemu: aarch64: Use virtio-pci if user specifies PCI controller src/qemu/qemu_command.c | 34 ++++++++---- src/qemu/qemu_domain.c | 4 -- ...l2argv-aarch64-pci-manual-nocontroller-fail.xml | 43 ++++++++++++++++ .../qemuxml2argv-aarch64-virtio-pci-default.args | 2 - ...l2argv-aarch64-virtio-pci-manual-addresses.args | 2 - ...ml2argv-aarch64-virtio-pci-manual-addresses.xml | 1 + ...2argv-aarch64-virtio-pci-manual-controller.args | 36 +++++++++++++ ...l2argv-aarch64-virtio-pci-manual-controller.xml | 50 ++++++++++++++++++ tests/qemuxml2argvtest.c | 22 ++++++-- .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 10 ---- ...2xmlout-aarch64-virtio-pci-manual-addresses.xml | 11 +--- ...xmlout-aarch64-virtio-pci-manual-controller.xml | 60 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 6 +++ 13 files changed, 239 insertions(+), 42 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-pci-manual-nocontroller-fail.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-controller.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-controller.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-aarch64-virtio-pci-manual-controller.xml -- 2.5.0

4 15

[libvirt] [PATCH v4 0/2] qemu: add debug-threads support
by Marc-André Lureau 10 Mar '16

10 Mar '16

QEMU (somewhere around 2.0) added a new sub-option to the -name flag -name debug-threads=on This causes the naming of individual QEMU threads to be helpful; e.g. 'CPU/KVM 0' or 'migration' these show up in top once the H key is pressed, and also show up in a core dump, making it easy to figure out which thread is which. The following 2 patches add a capability check and enable debug-threads if supported. Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1140121 cheers v3->v4: - simplify a bit command generation - added a test v2->v3: - move -name command generation in seperate function - fix syntax-check - fix leak v1->v2: - drop the configuration, enable debug-thread automatically Marc-André Lureau (2): qemu: check for debug-threads capability qemu: enable debug threads src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 34 +++++++++++++++++----- tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + .../qemuxml2argv-debug-threads.args | 22 ++++++++++++++ .../qemuxml2argv-debug-threads.xml | 34 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ 10 files changed, 91 insertions(+), 8 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-debug-threads.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-debug-threads.xml -- 2.5.0

3 4