- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] hostdev: Small usability improvements
by Andrea Bolognani 23 Mar '16

23 Mar '16

Patch 2/2 is basically https://www.redhat.com/archives/libvir-list/2016-March/msg00230.html and patch 1/2 is an implementation of the idea outlined in https://www.redhat.com/archives/libvir-list/2016-March/msg00729.html to address the flaw discovered by John. Spun off from the main series because it can be merged on its own, and I still need to rework the remaining patches a bit before posting v2 of that. Cheers. Andrea Bolognani (2): hostdev: Detect untracked inactive devices hostdev: Stop early if unmanaged devices have not been detached src/util/virhostdev.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 50 insertions(+), 3 deletions(-) -- 2.5.0

2 7

[libvirt] [RFC PATCH 0/4] Implementation of a dependency relation between domains
by Valentin BOUSSON 23 Mar '16

23 Mar '16

This patch series adds a feature that enables libvirt domains to have other domains as dependencies. One possible target is the simulation of a complex computing system composed of multiple CPUs, each of which represented by a different libvirt domain. CPUs in this example are virtualized separately, by a dedicated QEMU instance, because all of them are booting independently. Moreover, if those CPU must share some physical property (for example power supply or ACPI), it is meaningful to consider them as a group. Another possible target is Asymmetric Multi Processor (AMP) systems. Where a master processor uses one or more slave processors to offload computation. Master and slave have often different architectures. This patch series makes possible to define the slave domains as dependencies of the master domain. And the whole system to be booted with one single libvirt command. A use-case for this libvirt extension are the recent patch series in QEMU that enable modeling an AMP-like system with multiple QEMU instances. [RFC v2 0/6] SDM Interface [RFC v2 0/6] QEMU shared-memory-backend [RFC v2 1/1] backend: multi-client-socket Features : ---------- - When a domain A depends on a domain B (A=>B), signals are forward-propagated from A to B. So, when a user asks the domain A to be: - instantiated - destroyed - suspended - resumed domain B will automatically receive the same signal. - Single-level dependency: By construction domain dependencies are restricted to one single level, so to avoid wrong recursive (infinite) domain dependencies. This is also because there is no clear benefit in supporting multiple level of dependencies between domains. More specifically, given to domains, A and B, if A depends on B (A=>B), then B can not have any dependency (B => C is forbidden). How to test this patch series : ------------------------------- The source code can be downloaded by: git clone https://git.virtualopensystems.com/dev/libvirt.git \ -b domain-dependency Note: The patch series relies on the commit 95ca4fe, but with the patch proposed by Michal Privoznik, "[PATCH]qemuBuildVideoCommandLine: Don't access def->videos without check" that resolves a critical bug. To add a dependency between two domains (for example between domaninA and domainB), it suffices to add in the XML description of the first one: domainA.xml: <devices> ... <domaindependency> /absolute/path/to/the/domainB.xml </domaindependency> ... </devices> Note: The two domains mus be virtualized thanks to QEMU, and be hosted on the same filesystem. Finally, instanciate domainA with the command: virsh create domainA.xml And observe that both domains are running in the same time with: virsh list You can trigger the implemented signals and check that both domains are working as one: virsh suspend domainA virsh resume domainA virsh destroy domainA Note: as mentioned, all signals are forward-propagated, so if you manipulate the domainB directly, domainA will not be affected. This work has been sponsored by Huawei Technologies Duesseldorf GmbH. Valentin BOUSSON (4): Add XML description of the new dependency device Add the inner structure managing dependency devices Add primitives for manipulation of dependency structures Implement signal propagation to dependancy domains docs/schemas/domaincommon.rng | 5 ++ src/conf/domain_conf.c | 83 +++++++++++++++++++++++++- src/conf/domain_conf.h | 18 ++++++ src/qemu/qemu_driver.c | 135 ++++++++++++++++++++++++++++++++++++++++-- src/qemu/qemu_hotplug.c | 1 + 5 files changed, 237 insertions(+), 5 deletions(-) -- 1.9.1

2 5

[libvirt] [PATCH] qemuxml2argv: Mock virSCSIDeviceGetSgName
by Michal Privoznik 23 Mar '16

23 Mar '16

When constructing SCSI hostdev command line for qemu, the /sys/bus/scsi/devices/... dir is scanned. Unfortunately, even in the tests. This is needed to determine the name of SCSI device to passthrough to qemu, because in the domain XML we were given its address instead. Anyway, we should not be touching live system data in our test suite as it produced unpredictable results. The test is regressing from 1e9a083742efe on. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/qemuxml2argvmock.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/tests/qemuxml2argvmock.c b/tests/qemuxml2argvmock.c index 8426108..b7dfebb 100644 --- a/tests/qemuxml2argvmock.c +++ b/tests/qemuxml2argvmock.c @@ -26,6 +26,7 @@ #include "virutil.h" #include "virstring.h" #include "virtpm.h" +#include "virscsi.h" #include <time.h> #include <unistd.h> @@ -84,3 +85,16 @@ virMemoryMaxValue(bool capped ATTRIBUTE_UNUSED) { return LLONG_MAX; } + +char * +virSCSIDeviceGetSgName(const char *sysfs_prefix ATTRIBUTE_UNUSED, + const char *adapter ATTRIBUTE_UNUSED, + unsigned int bus ATTRIBUTE_UNUSED, + unsigned int target ATTRIBUTE_UNUSED, + unsigned long long unit ATTRIBUTE_UNUSED) +{ + char *ret; + + ignore_value(VIR_STRDUP(ret, "sg0")); + return ret; +} -- 2.7.3

2 1

[libvirt] [libvirt-sandbox PATCH] Ignore generated file
by Guido Günther 23 Mar '16

23 Mar '16

--- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 390d65c..83831bb 100644 --- a/.gitignore +++ b/.gitignore @@ -31,6 +31,7 @@ po/stamp-it po/libvirt-sandbox.pot po/*.gmo stamp-h1 +build-aux/test-driver INSTALL libvirt-sandbox-1.0.pc libvirt-sandbox.spec -- 2.8.0.rc3

1 0

[libvirt] [PATCH 1/3 trivial] fix typo in virt-aa-helper helptext
by Serge Hallyn 22 Mar '16

22 Mar '16

it's --dryrun not --dry-run Signed-off-by: Serge Hallyn <serge.hallyn(a)ubuntu.com> --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index a2d7226..b466626 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -107,7 +107,7 @@ vah_usage(void) " Options:\n" " -a | --add load profile\n" " -c | --create create profile from template\n" - " -d | --dry-run dry run\n" + " -d | --dryrun dry run\n" " -D | --delete unload and delete profile\n" " -f | --add-file <file> add file to profile\n" " -F | --append-file <file> append file to profile\n" -- 2.7.0

3 5

[libvirt] [libvirt-sandbox PATCH] Allow to switch to a specific user id
by Guido Günther 22 Mar '16

22 Mar '16

Useful if you want to run programs as the same user than outside the sandbox. --- bin/virt-sandbox.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/bin/virt-sandbox.c b/bin/virt-sandbox.c index 4c400d5..9495e85 100644 --- a/bin/virt-sandbox.c +++ b/bin/virt-sandbox.c @@ -24,6 +24,8 @@ #include <libvirt-sandbox/libvirt-sandbox.h> #include <glib/gi18n.h> +#include <sys/types.h> +#include <pwd.h> static gboolean do_close(GVirSandboxConsole *con G_GNUC_UNUSED, gboolean error G_GNUC_UNUSED, @@ -92,6 +94,7 @@ int main(int argc, char **argv) { gchar *kernver = NULL; gchar *kernpath = NULL; gchar *kmodpath = NULL; + gchar *switchto = NULL; gboolean verbose = FALSE; gboolean debug = FALSE; gboolean shell = FALSE; @@ -126,6 +129,8 @@ int main(int argc, char **argv) { N_("security properties"), "PATH", }, { "privileged", 'p', 0, G_OPTION_ARG_NONE, &privileged, N_("run the command privileged"), NULL }, + { "switchto", 'S', 0, G_OPTION_ARG_STRING, &switchto, + N_("swith to the given user"), "USER" }, { "shell", 'l', 0, G_OPTION_ARG_NONE, &shell, N_("start a shell"), NULL, }, { "kernver", 0, 0, G_OPTION_ARG_STRING, &kernver, @@ -139,6 +144,7 @@ int main(int argc, char **argv) { { NULL, 0, 0, G_OPTION_ARG_NONE, NULL, NULL, NULL } }; const char *help_msg = N_("Run 'virt-sandbox --help' to see a full list of available command line options"); + struct passwd *pw; setlocale(LC_ALL, ""); bindtextdomain(PACKAGE, LOCALEDIR); @@ -198,10 +204,25 @@ int main(int argc, char **argv) { if (kmodpath) gvir_sandbox_config_set_kmodpath(cfg, kmodpath); + if (privileged && switchto) { + g_printerr(_("'switchto' and 'privileged' are incompatible options\n")); + goto cleanup; + } + if (privileged) { gvir_sandbox_config_set_userid(cfg, 0); gvir_sandbox_config_set_groupid(cfg, 0); gvir_sandbox_config_set_username(cfg, "root"); + } else if (switchto) { + pw = getpwnam(switchto); + if (!pw) { + g_printerr(_("Failed to resolve user %s\n"), switchto); + goto cleanup; + } + gvir_sandbox_config_set_userid(cfg, pw->pw_uid); + gvir_sandbox_config_set_groupid(cfg, pw->pw_gid); + gvir_sandbox_config_set_username(cfg, pw->pw_name); + gvir_sandbox_config_set_homedir(cfg, pw->pw_dir); } if (envs && @@ -541,6 +562,11 @@ to this path to locate the modules. Retain root privileges inside the sandbox, rather than dropping privileges to match the current user identity. +=item B<-S USER>, B<--switchto=USER> + +Swith to the given user inside the sandbox and setup $HOME +accordingly. + =item B<-l>, B<--shell> Launch an interactive shell on a secondary console device -- 2.8.0.rc3

2 2

[libvirt] [PATCH] nss: use more strict check for automatic enabling
by Roman Bogorodskiy 22 Mar '16

22 Mar '16

Currently nss plugin is automatically enabled if nss.h header exists and --without-nss-plugin is not specified. However, presence of the nss.h header does not guarantee a compatible interface, so check for struct gaih_addrtuple to make sure it's enabled only on platforms where it could be built. --- m4/virt-nss.m4 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/m4/virt-nss.m4 b/m4/virt-nss.m4 index 3fa4ad3..bc054db 100644 --- a/m4/virt-nss.m4 +++ b/m4/virt-nss.m4 @@ -25,12 +25,14 @@ AC_DEFUN([LIBVIRT_CHECK_NSS],[ fail=0 if test "x$with_nss_plugin" != "xno" ; then - AC_CHECK_HEADERS([nss.h], [ + AC_CHECK_TYPE([struct gaih_addrtuple], [ with_nss_plugin=yes ],[ if test "x$with_nss_plugin" = "xyes" ; then fail = 1 fi + ],[ + #include <nss.h> ]) if test $fail = 1 ; then -- 2.4.6

2 3

[libvirt] Does the proposed solution belong in KVM input devices?
by bancfc＠openmailbox.org 22 Mar '16

22 Mar '16

qemu-discuss doesn't seem the best place to reach the devs. I saw most of the work on KVM input devices was done by Gerd Hoffman and Dan Berrange. Dan do you think the QEMU virtual keyboard is the right place for a solution similar to the one described below? https://paul.reviews/behavioral-profiling-the-password-you-cant-change/ Would this be considered feature creep and best implemented in its own program?

3 3

[libvirt] [libvirt-php 0/3] small improvements
by Vasiliy Tolstov 22 Mar '16

22 Mar '16

Add some more libvirt functions support to binding. Also add some checks to prevent malloc SIZE_MAX memory in case of errors Vasiliy Tolstov (3): add some checks to prevent overflow add block_commit support and needed const add libvirt_domain_block_job_info src/libvirt-php.c | 152 ++++++++++++++++++++++++++++++++++++++++++++++++------ src/libvirt-php.h | 2 + 2 files changed, 138 insertions(+), 16 deletions(-) -- 2.7.0

4 12

[libvirt] [PATCH 00/12] qemu_process cleanups and test improvement
by Pavel Hrdina 22 Mar '16

22 Mar '16

The first patch is unrelated but I've found it while working on this series. Pavel Hrdina (12): qemu_process: check for correct return value while starting domain nvram: generate it's path in qemuDomainDefPostParse tests: cleanup qemuxml2argvtest qemu_process: introduce qemuProcessPrepareDomain qemu_process: introduce qemuProcessPrepareHost qemu: update callers of qemuProcessStartValidate to use virDomainObjPtr qemu_process: move checks to qemuProcessStartValidate qemu_process: move qemuDomainSetPrivatePaths to qemuProcessInit qemu_process: introduce qemuProcessCreateCmd qemu_driver: cleanup qemuConnectDomainXMLToNative qemuxml2argvtest: use driver.config and priv for qemuDomainSetPrivatePaths qemuxml2argvtest: cleanup test src/qemu/qemu_domain.c | 10 + src/qemu/qemu_driver.c | 61 +- src/qemu/qemu_migration.c | 9 +- src/qemu/qemu_process.c | 706 +++++++++++---------- src/qemu/qemu_process.h | 26 +- .../qemuxml2argv-channel-virtio-unix.xml | 2 +- tests/qemuxml2argvtest.c | 126 ++-- tests/testutilsqemu.c | 7 + 8 files changed, 494 insertions(+), 453 deletions(-) -- 2.7.2

3 27

[libvirt] [PATCH 0/2] qemu: support SPICE+unix socket
by Cole Robinson 22 Mar '16

22 Mar '16

qemu has supported SPICE+unix socket listening since 2.3.0. Patch #1 wires it up from domain_conf.c down to qemu, patch #2 adds qemu.conf spice_auto_unix_socket option Full disclosure: this duplicates the logic of VNC socket usage, which has some pre-existing warts: - When the VM is running with graphics socket=FOO, the runtime XML still lists <listen type='address' address='127.0.0.1'/>. - If using vnc/spice auto socket, it looks like ports can still be allocated in the code, though they are never used. - In fact I suspect there's lots of issues with stray XML port/listen being parsed and ending up in the device config, but selectively being ignored later. We should probably explicitly ignore/error about those combos when parsing the XML so we never have to ignore specific values later on. - The auto socket path is set in qemu_command.c but it should probably be set in qemu_process.c with the port stuff. Though there are references to vncListen in qemu_command.c which should probably be moved as well. The issue with moving them to qemu_process.c is now there isn't any pre-existing way to test those bits like via qemuxml2argvtest for example. Though finding a way to test the graphics prep stuff would be valuable anyways - teuf suggests: converting <graphics socket=X/> to <graphics><listen type='socket' path='FOO'/></graphics> like was done with listen= address - tuef: virsh domdisplay doesn't handle sockets To avoid yet another rabbit hole I didn't touch any of the above issues, which basically means spice+unix is no less operationally worse than vnc+unix :) Cole Robinson (2): qemu: Support SPICE listen over unix socket qemu: Add qemu.conf option spice_auto_unix_socket docs/schemas/domaincommon.rng | 5 ++++ src/conf/domain_conf.c | 26 +++++++++++++-------- src/conf/domain_conf.h | 1 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 11 +++++++++ src/qemu/qemu_command.c | 15 +++++++++--- src/qemu/qemu_conf.c | 1 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_process.c | 3 +++ src/qemu/test_libvirtd_qemu.aug.in | 1 + src/security/virt-aa-helper.c | 5 ++++ .../qemuxml2argv-graphics-spice-unix-auto.args | 21 +++++++++++++++++ .../qemuxml2argv-graphics-spice-unix-auto.xml | 27 ++++++++++++++++++++++ .../qemuxml2argv-graphics-spice-unix.args | 21 +++++++++++++++++ .../qemuxml2argv-graphics-spice-unix.xml | 27 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 10 ++++++++ 16 files changed, 163 insertions(+), 13 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-unix-auto.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-unix-auto.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-unix.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-unix.xml -- 2.5.0

3 9

[libvirt] [PATCH v2] qemu-hotplug: fix eject media
by Pavel Hrdina 22 Mar '16

22 Mar '16

QEMU changed the error message to: "Tray of device 'drive-sata0-0-1' is not open" and they may change the error massage in the future. This updates the code to not depend on the text from the error message but only on error itself. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_hotplug.c | 11 +++++------ src/qemu/qemu_monitor_json.c | 12 +----------- src/qemu/qemu_monitor_text.c | 5 +---- 3 files changed, 7 insertions(+), 21 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b580283..a78bc60 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -202,15 +202,14 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, if (qemuDomainObjExitMonitor(driver, vm) < 0) goto cleanup; - if (rc == -2) { + if (rc < 0) { /* we've already tried, error out */ if (ejectRetry) goto error; - VIR_DEBUG("tray is locked, wait for the guest to unlock " - "the tray and try to eject it again"); + ejectRetry = true; - } else if (rc < 0) { - goto error; + VIR_DEBUG("tray may be locked, wait for the guest to unlock " + "the tray and try to eject it again"); } if (virTimeMillisNow(&now) < 0) @@ -220,7 +219,7 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, if (virDomainObjWaitUntil(vm, now + CHANGE_MEDIA_TIMEOUT) != 0) goto error; } - } while (ejectRetry && rc != 0); + } while (rc < 0); if (!virStorageSourceIsEmpty(newsrc)) { if (qemuGetDriveSourceString(newsrc, conn, &sourcestr) < 0) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index fe9288a..57c34f0 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2272,8 +2272,7 @@ int qemuMonitorJSONSetCPU(qemuMonitorPtr mon, * Run QMP command to eject a media from ejectable device. * * Returns: - * -2 on error, when the tray is locked - * -1 on all other errors + * -1 on error * 0 on success */ int qemuMonitorJSONEjectMedia(qemuMonitorPtr mon, @@ -2294,15 +2293,6 @@ int qemuMonitorJSONEjectMedia(qemuMonitorPtr mon, if (ret == 0) ret = qemuMonitorJSONCheckError(cmd, reply); - if (ret < 0) { - virJSONValuePtr error = virJSONValueObjectGet(reply, "error"); - if (error) { - const char *errorStr = virJSONValueObjectGetString(error, "desc"); - if (errorStr && c_strcasestr(errorStr, "is locked")) - ret = -2; - } - } - virJSONValueFree(cmd); virJSONValueFree(reply); return ret; diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index bb87397..3129427 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -1170,8 +1170,7 @@ int qemuMonitorTextSetCPU(qemuMonitorPtr mon, int cpu, bool online) * Run HMP command to eject a media from ejectable device. * * Returns: - * -2 on error, when the tray is locked - * -1 on all other errors + * -1 on error * 0 on success */ int qemuMonitorTextEjectMedia(qemuMonitorPtr mon, @@ -1192,8 +1191,6 @@ int qemuMonitorTextEjectMedia(qemuMonitorPtr mon, * device not found, device is locked ... * No message is printed on success it seems */ if (c_strcasestr(reply, "device ")) { - if (c_strcasestr(reply, "is locked")) - ret = -2; virReportError(VIR_ERR_OPERATION_FAILED, _("could not eject media on %s: %s"), dev_name, reply); goto cleanup; -- 2.7.4

2 1

[libvirt] [PATCH] qemu-hotplug: fix eject media
by Pavel Hrdina 22 Mar '16

22 Mar '16

QEMU changed the error message to: "Tray of device 'drive-sata0-0-1' is not open" and they may change the error massage in the future. This updates the code to not depend on the text from the error message but only on error itself. One more improvement is that we will store the original error in case if it's not about tray is not open. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/qemu/qemu_hotplug.c | 17 +++++++++-------- src/qemu/qemu_monitor_json.c | 12 +----------- src/qemu/qemu_monitor_text.c | 5 +---- 3 files changed, 11 insertions(+), 23 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index b580283..8122367 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -173,8 +173,8 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, qemuDomainObjPrivatePtr priv = vm->privateData; const char *format = NULL; char *sourcestr = NULL; - bool ejectRetry = false; unsigned long long now; + virErrorPtr ejectError = NULL; if (!disk->info.alias) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -202,15 +202,16 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, if (qemuDomainObjExitMonitor(driver, vm) < 0) goto cleanup; - if (rc == -2) { + if (rc < 0) { /* we've already tried, error out */ - if (ejectRetry) + if (ejectError) { + virSetError(ejectError); + virFreeError(ejectError); goto error; - VIR_DEBUG("tray is locked, wait for the guest to unlock " + } + ejectError = virSaveLastError(); + VIR_DEBUG("tray may be locked, wait for the guest to unlock " "the tray and try to eject it again"); - ejectRetry = true; - } else if (rc < 0) { - goto error; } if (virTimeMillisNow(&now) < 0) @@ -220,7 +221,7 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, if (virDomainObjWaitUntil(vm, now + CHANGE_MEDIA_TIMEOUT) != 0) goto error; } - } while (ejectRetry && rc != 0); + } while (rc < 0); if (!virStorageSourceIsEmpty(newsrc)) { if (qemuGetDriveSourceString(newsrc, conn, &sourcestr) < 0) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 8352e53..66a2922 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2272,8 +2272,7 @@ int qemuMonitorJSONSetCPU(qemuMonitorPtr mon, * Run QMP command to eject a media from ejectable device. * * Returns: - * -2 on error, when the tray is locked - * -1 on all other errors + * -1 on error * 0 on success */ int qemuMonitorJSONEjectMedia(qemuMonitorPtr mon, @@ -2294,15 +2293,6 @@ int qemuMonitorJSONEjectMedia(qemuMonitorPtr mon, if (ret == 0) ret = qemuMonitorJSONCheckError(cmd, reply); - if (ret < 0) { - virJSONValuePtr error = virJSONValueObjectGet(reply, "error"); - if (error) { - const char *errorStr = virJSONValueObjectGetString(error, "desc"); - if (errorStr && c_strcasestr(errorStr, "is locked")) - ret = -2; - } - } - virJSONValueFree(cmd); virJSONValueFree(reply); return ret; diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c index bb87397..3129427 100644 --- a/src/qemu/qemu_monitor_text.c +++ b/src/qemu/qemu_monitor_text.c @@ -1170,8 +1170,7 @@ int qemuMonitorTextSetCPU(qemuMonitorPtr mon, int cpu, bool online) * Run HMP command to eject a media from ejectable device. * * Returns: - * -2 on error, when the tray is locked - * -1 on all other errors + * -1 on error * 0 on success */ int qemuMonitorTextEjectMedia(qemuMonitorPtr mon, @@ -1192,8 +1191,6 @@ int qemuMonitorTextEjectMedia(qemuMonitorPtr mon, * device not found, device is locked ... * No message is printed on success it seems */ if (c_strcasestr(reply, "device ")) { - if (c_strcasestr(reply, "is locked")) - ret = -2; virReportError(VIR_ERR_OPERATION_FAILED, _("could not eject media on %s: %s"), dev_name, reply); goto cleanup; -- 2.7.3

2 2

[libvirt] [PATCH v4] Use-correct-pci-addresses-during-interface-detach
by Nitesh Konkar 22 Mar '16

22 Mar '16

The virsh attach virsh detach interface command fails when both live and config are set and when the interface gets attached to different pci slots on live and config xml respectively. When we attach an interface with both --live and --config, the first time they get the same PCI slots, but the second time onwards it differs and hence the virsh detach-interface --live --config command fails. This patch makes sure that when both --live --config are set , qemuDomainDetachDeviceFlags is called twice, once with config xml and once with live xml. --- Change log: v4: * Code unchanged, updated with commit message,change log and steps to reproduce the issue.. v3: * Created function vshDomainDetachInterface and called it once/twice from cmdDetachInterface depending on number of flags set (live/config/both). Passed the correct xml(live/persistent) to it. v2: * Changes only in cmdDetachInterface to pass the right domain xml depending on the flag set (live/config/both). v1: * Changes only in qemuDomainDetachDeviceFlags to set the right value in dev and dev_copy. Steps to see the issue: virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config tools/virsh-domain.c | 104 +++++++++++++++++++++++++++++++-------------------- 1 file changed, 64 insertions(+), 40 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 62acecb..a6abaf5 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10801,40 +10801,21 @@ static const vshCmdOptDef opts_detach_interface[] = { {.name = NULL} }; -static bool -cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) +static bool +vshDomainDetachInterface(char *doc, unsigned int flags, virDomainPtr dom, vshControl *ctl, const vshCmd *cmd) { - virDomainPtr dom = NULL; xmlDocPtr xml = NULL; xmlXPathObjectPtr obj = NULL; xmlXPathContextPtr ctxt = NULL; xmlNodePtr cur = NULL, matchNode = NULL; - char *detach_xml = NULL; const char *mac = NULL, *type = NULL; - char *doc = NULL; + char *detach_xml = NULL; + bool current = vshCommandOptBool(cmd, "current"); char buf[64]; int diff_mac; size_t i; int ret; bool functionReturn = false; - unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; - bool current = vshCommandOptBool(cmd, "current"); - bool config = vshCommandOptBool(cmd, "config"); - bool live = vshCommandOptBool(cmd, "live"); - bool persistent = vshCommandOptBool(cmd, "persistent"); - - VSH_EXCLUSIVE_OPTIONS_VAR(persistent, current); - - VSH_EXCLUSIVE_OPTIONS_VAR(current, live); - VSH_EXCLUSIVE_OPTIONS_VAR(current, config); - - if (config || persistent) - flags |= VIR_DOMAIN_AFFECT_CONFIG; - if (live) - flags |= VIR_DOMAIN_AFFECT_LIVE; - - if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) - return false; if (vshCommandOptStringReq(ctl, cmd, "type", &type) < 0) goto cleanup; @@ -10842,15 +10823,6 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "mac", &mac) < 0) goto cleanup; - if (persistent && - virDomainIsActive(dom) == 1) - flags |= VIR_DOMAIN_AFFECT_LIVE; - - if (flags & VIR_DOMAIN_AFFECT_CONFIG) - doc = virDomainGetXMLDesc(dom, VIR_DOMAIN_XML_INACTIVE); - else - doc = virDomainGetXMLDesc(dom, 0); - if (!doc) goto cleanup; @@ -10918,23 +10890,75 @@ cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) else ret = virDomainDetachDevice(dom, detach_xml); - if (ret != 0) { - vshError(ctl, "%s", _("Failed to detach interface")); - } else { - vshPrint(ctl, "%s", _("Interface detached successfully\n")); + if (ret == 0) functionReturn = true; - } cleanup: - VIR_FREE(doc); VIR_FREE(detach_xml); - virDomainFree(dom); + xmlFreeDoc(xml); xmlXPathFreeObject(obj); xmlXPathFreeContext(ctxt); - xmlFreeDoc(xml); return functionReturn; } +static bool +cmdDetachInterface(vshControl *ctl, const vshCmd *cmd) +{ + virDomainPtr dom = NULL; + unsigned int flags = VIR_DOMAIN_AFFECT_CURRENT; + char *doc_live = NULL, *doc_config = NULL; + bool current = vshCommandOptBool(cmd, "current"); + bool config = vshCommandOptBool(cmd, "config"); + bool live = vshCommandOptBool(cmd, "live"); + bool persistent = vshCommandOptBool(cmd, "persistent"); + bool functionReturn = false; + + VSH_EXCLUSIVE_OPTIONS_VAR(persistent, current); + + VSH_EXCLUSIVE_OPTIONS_VAR(current, live); + VSH_EXCLUSIVE_OPTIONS_VAR(current, config); + + if (config || persistent) + flags |= VIR_DOMAIN_AFFECT_CONFIG; + + if (!(dom = virshCommandOptDomain(ctl, cmd, NULL))) + return false; + + if (persistent && + virDomainIsActive(dom) == 1) + flags |= VIR_DOMAIN_AFFECT_LIVE; + + if (flags & VIR_DOMAIN_AFFECT_CONFIG) { + doc_config = virDomainGetXMLDesc(dom, VIR_DOMAIN_XML_INACTIVE); + if (!(functionReturn = vshDomainDetachInterface(doc_config, flags, dom, ctl, cmd))) + goto cleanup; + } + + if (live) + flags |= VIR_DOMAIN_AFFECT_LIVE; + + if (flags & VIR_DOMAIN_AFFECT_LIVE) { + doc_live = virDomainGetXMLDesc(dom, 0); + + if (flags & VIR_DOMAIN_AFFECT_CONFIG) + flags &= (~VIR_DOMAIN_AFFECT_CONFIG); + + functionReturn = vshDomainDetachInterface(doc_live, flags, dom, ctl, cmd); + } + + cleanup: + if (functionReturn == false) { + vshError(ctl, "%s", _("Failed to detach interface")); + } else { + vshPrint(ctl, "%s", _("Interface detached successfully\n")); + functionReturn = true; + } + VIR_FREE(doc_live); + VIR_FREE(doc_config); + virDomainFree(dom); + return functionReturn; +} + typedef enum { VIRSH_FIND_DISK_NORMAL, VIRSH_FIND_DISK_CHANGEABLE, -- 1.8.3.1

1 1

Re: [libvirt] [PATCH v5 0/5] ARM: add query-gic-capabilities SMP command
by Peter Xu 22 Mar '16

22 Mar '16

On Mon, Mar 21, 2016 at 04:56:07PM +0100, Andrea Bolognani wrote: > On Fri, 2016-03-18 at 11:27 +0800, Peter Xu wrote: > > v5 changes: > > - patch 2: moved to target-arm/monitor.c (from target-arm/machine.c) > > [Peter] > > - patch 3: splitted into three patches: [all from Peter's comments] > > - patch 3 (new): leverage kvm_arm_create_scratch_host_vcpu(), tiny > > enhancement of old one to suite our need > > - patch 4: introduce kvm_support_device() in kvm-all.c > > - patch 5: do the implementation. > > Tested on two separate aarch64 hosts, seems to work fine. Thanks Andrea! Sorry I forgot to CC libvir-list. To avoid duplication, not re-sending but CCing in this reply. If anyone interested, please review in the following link: https://lists.gnu.org/archive/html/qemu-devel/2016-03/msg04465.html (which points to exactly current thread.) Sorry for the inconvenience! -- peterx

1 0

[libvirt] virtual machine won't autostart when using LVM with cache
by David Hlacik 21 Mar '16

21 Mar '16

Hello guys, OS Fedora 23 with latest updates Recently I have switched to use LVM cache feature on logical volume /dev/hdd/windata1 to improve it performace using 32GB partition from SSD disk. However, when my computer will start, my virtual machine won't autostart Mar 21 10:48:57 brutus-coreos libvirtd[956]: Cannot access storage file '/dev/hdd/windata1' (as uid:107, gid:107): No such file or directory Mar 21 10:48:57 brutus-coreos libvirtd[956]: Failed to autostart VM 'winos1': Cannot access storage file '/dev/hdd/windata1' (as uid:107, gid:107): No such file or directory Mar 21 10:48:57 brutus-coreos libvirtd[956]: Cannot access storage file '/dev/hdd/windata1' (as uid:107, gid:107): No such file or directory It seems that when using LVM cache, one have to wait till it will inicialize? When I will manually start virtual machine afterwards, everything works OK : [root@brutus-coreos ~]# virsh start winos1 Domain winos1 started I have tried to remove LVM cache from /dev/hdd/windata1 and afterward autostart works! So it must be LVM cache related. Can you please help me to solve this ? Thanks in advance David Hlacik +420-777-307-745 | david(a)hlacik.cz [image: View David Hlacik's profile on LinkedIn] <http://cz.linkedin.com/in/hlacik>

2 2

[libvirt] [PATCH v2] nss: Make aligning look nicer
by Martin Kletzander 21 Mar '16

21 Mar '16

Every aligning requires at least one cast and it's hard to read. Let's make a function that makes sure the pointer is moved according to the alignment and use that to move throughout the data buffer. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- v2: - Initialize @idx in _nss_libvirt_gethostbyname4_r as well tools/nss/libvirt_nss.c | 53 +++++++++++++++++++++++++++++++------------------ 1 file changed, 34 insertions(+), 19 deletions(-) diff --git a/tools/nss/libvirt_nss.c b/tools/nss/libvirt_nss.c index ba3bb31b3569..218c62a64c88 100644 --- a/tools/nss/libvirt_nss.c +++ b/tools/nss/libvirt_nss.c @@ -252,17 +252,31 @@ _nss_libvirt_gethostbyname2_r(const char *name, int af, struct hostent *result, errnop, herrnop, NULL, NULL); } +static inline void * +move_and_align(void *buf, size_t len, size_t *idx) +{ + char *buffer = buf; + size_t move = ALIGN(len); + + if (!idx) + return buffer + move; + + *idx += move; + + return buffer + *idx; +} + enum nss_status _nss_libvirt_gethostbyname3_r(const char *name, int af, struct hostent *result, char *buffer, size_t buflen, int *errnop, int *herrnop, int32_t *ttlp, char **canonp) { enum nss_status ret = NSS_STATUS_UNAVAIL; - char *r_name, **r_aliases, *r_addr, **r_addr_list; + char *r_name, **r_aliases, *r_addr, *r_addr_next, **r_addr_list; leaseAddress *addr = NULL; size_t naddr, i; bool found = false; - size_t nameLen, need, idx; + size_t nameLen, need, idx = 0; int alen; int r; @@ -319,23 +333,27 @@ _nss_libvirt_gethostbyname3_r(const char *name, int af, struct hostent *result, /* First, append name */ r_name = buffer; memcpy(r_name, name, nameLen + 1); - idx = ALIGN(nameLen + 1); + + r_aliases = move_and_align(buffer, nameLen + 1, &idx); /* Second, create aliases array */ - r_aliases = (char **) buffer + idx; r_aliases[0] = NULL; - idx += sizeof(char*); /* Third, append address */ - r_addr = buffer + idx; - for (i = 0; i < naddr; i++) - memcpy(r_addr + i * ALIGN(alen), addr[i].addr, alen); - idx += naddr * ALIGN(alen); + r_addr = move_and_align(buffer, sizeof(char *), &idx); + r_addr_next = r_addr; + for (i = 0; i < naddr; i++) { + memcpy(r_addr_next, addr[i].addr, alen); + r_addr_next = move_and_align(buffer, alen, &idx); + } + r_addr_list = move_and_align(buffer, 0, &idx); + r_addr_next = r_addr; /* Third, append address pointer array */ - r_addr_list = (char **) buffer + idx; - for (i = 0; i < naddr; i++) - r_addr_list[i] = r_addr + i * ALIGN(alen); + for (i = 0; i < naddr; i++) { + r_addr_list[i] = r_addr_next; + r_addr_next = move_and_align(r_addr_next, alen, NULL); + } r_addr_list[i] = NULL; idx += (naddr + 1) * sizeof(char*); @@ -375,7 +393,7 @@ _nss_libvirt_gethostbyname4_r(const char *name, struct gaih_addrtuple **pat, size_t naddr, i; bool found = false; int r; - size_t nameLen, need, idx; + size_t nameLen, need, idx = 0; struct gaih_addrtuple *r_tuple, *r_tuple_first = NULL; char *r_name; @@ -420,25 +438,22 @@ _nss_libvirt_gethostbyname4_r(const char *name, struct gaih_addrtuple **pat, /* First, append name */ r_name = buffer; memcpy(r_name, name, nameLen + 1); - idx = ALIGN(nameLen + 1); - /* Second, append addresses */ - r_tuple_first = (struct gaih_addrtuple*) (buffer + idx); + r_tuple_first = move_and_align(buffer, nameLen + 1, &idx); for (i = 0; i < naddr; i++) { int family = addr[i].af; - r_tuple = (struct gaih_addrtuple*) (buffer + idx); + r_tuple = move_and_align(buffer, 0, &idx); if (i == naddr - 1) r_tuple->next = NULL; else - r_tuple->next = (struct gaih_addrtuple*) ((char*) r_tuple + ALIGN(sizeof(struct gaih_addrtuple))); + r_tuple->next = move_and_align(buffer, sizeof(struct gaih_addrtuple), &idx); r_tuple->name = r_name; r_tuple->family = family; r_tuple->scopeid = 0; memcpy(r_tuple->addr, addr[i].addr, FAMILY_ADDRESS_SIZE(family)); - idx += ALIGN(sizeof(struct gaih_addrtuple)); } /* At this point, idx == need */ -- 2.7.3

3 3

[libvirt] [libvirt-sandbox PATCH] sandbox-builder: Don't try g_file_enumerator_next_file if enumerator is NULL
by Guido Günther 21 Mar '16

21 Mar '16

Passing the NULL enumerator to g_file_enumerator_next_file makes us overwrite error information otherwise: $ sudo bin/virt-sandbox-service create --unitfile foo.service foo (process:18529): GLib-GIO-CRITICAL **: g_file_enumerator_next_file: assertion 'G_IS_FILE_ENUMERATOR (enumerator)' failed (process:18529): GLib-GIO-CRITICAL **: g_file_enumerator_close: assertion 'G_IS_FILE_ENUMERATOR (enumerator)' failed bin/virt-sandbox-service:318: Warning: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's code. You must ensure an error is NULL before it's set. The overwriting error message was: Error removing file: No such file or directory context.undefine() bin/virt-sandbox-service:318: Warning: g_object_unref: assertion 'G_IS_OBJECT (object)' failed context.undefine() Cleanup failed: g-io-error-quark: No such file or directory (1) bin/virt-sandbox-service: g-io-error-quark: No such file or directory (1) also make sure we don't unref NULL in this case. --- libvirt-sandbox/libvirt-sandbox-builder.c | 37 +++++++++++++++++-------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/libvirt-sandbox/libvirt-sandbox-builder.c b/libvirt-sandbox/libvirt-sandbox-builder.c index 1745c88..0c43b62 100644 --- a/libvirt-sandbox/libvirt-sandbox-builder.c +++ b/libvirt-sandbox/libvirt-sandbox-builder.c @@ -727,32 +727,35 @@ gboolean gvir_sandbox_builder_clean_post_stop(GVirSandboxBuilder *builder, errno != ENOENT) ret = FALSE; - if (!(enumerator = g_file_enumerate_children(libsFile, "*", G_FILE_QUERY_INFO_NONE, - NULL, error)) && - (*error)->code != G_IO_ERROR_NOT_FOUND) { - ret = FALSE; - goto cleanup; - } + if ((enumerator = g_file_enumerate_children(libsFile, "*", G_FILE_QUERY_INFO_NONE, + NULL, error))) { + while ((info = g_file_enumerator_next_file(enumerator, NULL, error))) { + child = g_file_enumerator_get_child(enumerator, info); + if (!g_file_delete(child, NULL, error)) + ret = FALSE; + g_object_unref(child); + child = NULL; + g_object_unref(info); + info = NULL; + } - while ((info = g_file_enumerator_next_file(enumerator, NULL, error))) { - child = g_file_enumerator_get_child(enumerator, info); - if (!g_file_delete(child, NULL, error)) + if (!g_file_enumerator_close(enumerator, NULL, error)) + ret = FALSE; + } else { + if ((*error)->code != G_IO_ERROR_NOT_FOUND) { ret = FALSE; - g_object_unref(child); - child = NULL; - g_object_unref(info); - info = NULL; + goto cleanup; + } + g_clear_error(error); } - if (!g_file_enumerator_close(enumerator, NULL, error)) - ret = FALSE; - if (!g_file_delete(libsFile, NULL, error) && (*error)->code != G_IO_ERROR_NOT_FOUND) ret = FALSE; cleanup: - g_object_unref(enumerator); + if (enumerator) + g_object_unref(enumerator); g_object_unref(libsFile); g_free(libsdir); g_free(dskfile); -- 2.7.0

2 2

[libvirt] [PATCH] tests: Produce predictable results in nsstest
by Michal Privoznik 21 Mar '16

21 Mar '16

Problem is that in the test any status file matching tests/nssdata/*.status is loaded as it contains IP addresses that are parsed. However, there's no order specified in which the files are loaded. Therefore on different systems the order may be different. This is then producing an unexpected results. Instead of defining an order in which the files are loaded, make the code that checks for missing IP addresses (or redundant ones) cope with unordered list of addresses. The reasoning behind is that the code doing the parsing is used in real NSS module where we don't care for ordering. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tests/nsstest.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/tests/nsstest.c b/tests/nsstest.c index 68f1c60..9d7bc40 100644 --- a/tests/nsstest.c +++ b/tests/nsstest.c @@ -49,7 +49,7 @@ testGetHostByName(const void *opaque) char buf[BUF_SIZE] = { 0 }; char **addrList; int rv, tmp_errno = 0, tmp_herrno = 0; - size_t i = 0; + size_t i = 0, j = 0; if (!data) goto cleanup; @@ -141,30 +141,29 @@ testGetHostByName(const void *opaque) goto cleanup; } - if (!data->ipAddr[i]) { + for (j = 0; data->ipAddr[j]; j++) { + if (STREQ(data->ipAddr[j], ipAddr)) + break; + } + + if (!data->ipAddr[j]) { virReportError(VIR_ERR_INTERNAL_ERROR, "Unexpected address %s", ipAddr); VIR_FREE(ipAddr); goto cleanup; } - - if (STRNEQ(data->ipAddr[i], ipAddr)) { - virReportError(VIR_ERR_INTERNAL_ERROR, - "Address mismatch. Expected %s got %s", - data->ipAddr[i], ipAddr); - VIR_FREE(ipAddr); - goto cleanup; - } VIR_FREE(ipAddr); addrList++; i++; } - if (data->ipAddr[i]) { + for (j = 0; data->ipAddr[j]; j++) + ; + + if (i != j) { virReportError(VIR_ERR_INTERNAL_ERROR, - "Address mismatch. Expected %s got nothing", - data->ipAddr[i]); + "Expected %zu addresses, got %zu", j, i); goto cleanup; } -- 2.7.3

3 2

[libvirt] nss build failure on arm32
by Cole Robinson 21 Mar '16

21 Mar '16

Just a note, I'm getting build failures with the nss module on Fedora 23 arm 32bit: nss/libvirt_nss.c: In function '_nss_libvirt_gethostbyname3_r': nss/libvirt_nss.c:325:17: error: cast increases required alignment of target type [-Werror=cast-align] r_aliases = (char **) buffer + idx; ^ nss/libvirt_nss.c:336:19: error: cast increases required alignment of target type [-Werror=cast-align] r_addr_list = (char **) buffer + idx; ^ nss/libvirt_nss.c: In function '_nss_libvirt_gethostbyname4_r': nss/libvirt_nss.c:427:21: error: cast increases required alignment of target type [-Werror=cast-align] r_tuple_first = (struct gaih_addrtuple*) (buffer + idx); ^ nss/libvirt_nss.c:431:19: error: cast increases required alignment of target type [-Werror=cast-align] r_tuple = (struct gaih_addrtuple*) (buffer + idx); ^ nss/libvirt_nss.c:435:29: error: cast increases required alignment of target type [-Werror=cast-align] r_tuple->next = (struct gaih_addrtuple*) ((char*) r_tuple + ALIGN(sizeof(struct gaih_addrtuple))); - Cole

2 1

[libvirt] [PATCH v2 0/2] Fixup SCSI node devices
by Bjoern Walk 21 Mar '16

21 Mar '16

SCSI targets seem to be missing proper treatment and it was actually not possible to import a SCSI target nodedev device definition because of some typo. In order to extend the test case to catch this, I found that the XML schema was missing as well. Bjoern Walk (2): conf: node_device: fix up SCSI target tests: nodedevxml2xml: add test for SCSI target docs/schemas/nodedev.rng | 11 +++++++++++ src/conf/node_device_conf.c | 2 +- tests/nodedevschemadata/scsi_target0_0_0.xml | 7 +++++++ tests/nodedevxml2xmltest.c | 1 + 4 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 tests/nodedevschemadata/scsi_target0_0_0.xml -- 2.6.5

2 3

[libvirt] [PATCH V2 0/4] Extend <hap> to a tristate
by Jim Fehlig 21 Mar '16

21 Mar '16

An expanded V2 of https://www.redhat.com/archives/libvir-list/2016-February/msg00140.html In V2, the <hap> feature is extended with a state='on|off' attribute to allow differentiating the 'on' and 'off' states with not set (or hypervisor default). Obviously post 1.3.2 material. See individual patches for details. Jim Fehlig (4): conf: add 'state' attribute to <hap> feature xenconfig: change 'hap' setting to align with Xen behavior Xen drivers: show hap enabled by default in capabilities libxl: support enabling and disabling <hap> feature docs/formatdomain.html.in | 6 ++- docs/schemas/domaincommon.rng | 6 ++- src/conf/domain_conf.c | 4 +- src/libxl/libxl_conf.c | 20 ++++++-- src/xen/xen_hypervisor.c | 2 +- src/xenconfig/xen_common.c | 14 ++--- .../test-disk-positional-parms-full.cfg | 1 - .../test-disk-positional-parms-partial.cfg | 1 - ...est-fullvirt-direct-kernel-boot-bogus-extra.cfg | 1 - .../test-fullvirt-direct-kernel-boot-extra.cfg | 1 - .../test-fullvirt-direct-kernel-boot.cfg | 1 - tests/xlconfigdata/test-fullvirt-multiusb.cfg | 1 - tests/xlconfigdata/test-fullvirt-nohap.cfg | 26 ++++++++++ tests/xlconfigdata/test-fullvirt-nohap.xml | 59 ++++++++++++++++++++++ tests/xlconfigdata/test-new-disk.cfg | 1 - tests/xlconfigdata/test-rbd-multihost-noauth.cfg | 1 - tests/xlconfigdata/test-spice-features.cfg | 1 - tests/xlconfigdata/test-spice.cfg | 1 - tests/xlconfigdata/test-vif-rate.cfg | 1 - tests/xlconfigtest.c | 1 + tests/xmconfigdata/test-escape-paths.cfg | 1 - .../xmconfigdata/test-fullvirt-default-feature.cfg | 1 - tests/xmconfigdata/test-fullvirt-force-hpet.cfg | 1 - tests/xmconfigdata/test-fullvirt-force-nohpet.cfg | 1 - tests/xmconfigdata/test-fullvirt-localtime.cfg | 1 - tests/xmconfigdata/test-fullvirt-net-netfront.cfg | 1 - tests/xmconfigdata/test-fullvirt-new-cdrom.cfg | 1 - tests/xmconfigdata/test-fullvirt-nohap.cfg | 28 ++++++++++ tests/xmconfigdata/test-fullvirt-nohap.xml | 51 +++++++++++++++++++ tests/xmconfigdata/test-fullvirt-parallel-tcp.cfg | 1 - .../test-fullvirt-serial-dev-2-ports.cfg | 1 - .../test-fullvirt-serial-dev-2nd-port.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-file.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-null.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-pipe.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-pty.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-stdio.cfg | 1 - .../test-fullvirt-serial-tcp-telnet.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-tcp.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-udp.cfg | 1 - tests/xmconfigdata/test-fullvirt-serial-unix.cfg | 1 - tests/xmconfigdata/test-fullvirt-sound.cfg | 1 - tests/xmconfigdata/test-fullvirt-usbmouse.cfg | 1 - tests/xmconfigdata/test-fullvirt-usbtablet.cfg | 1 - tests/xmconfigdata/test-fullvirt-utc.cfg | 1 - tests/xmconfigdata/test-no-source-cdrom.cfg | 1 - tests/xmconfigdata/test-pci-devs.cfg | 1 - tests/xmconfigtest.c | 1 + 48 files changed, 202 insertions(+), 52 deletions(-) create mode 100644 tests/xlconfigdata/test-fullvirt-nohap.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nohap.xml create mode 100755 tests/xmconfigdata/test-fullvirt-nohap.cfg create mode 100644 tests/xmconfigdata/test-fullvirt-nohap.xml -- 2.1.4

3 13

[libvirt] [PATCH v3 00/14] Implement post-copy migration
by Jiri Denemark 21 Mar '16

21 Mar '16

(See "Add public APIs for post-copy migration" patch for more details about post-copy migration.) Post-copy support was originally written by Cristian Klein in 2014, but no one touched the series since then. Some patches in this series are modified versions of the old patches from Cristian, some patches had to be rewritten from scratch since libvirt code changed a lot (we started using migration events), and some patches are completely new. While post-copy migration is included in QEMU 2.5.0, it didn't support everything libvirt needs. Thus you need QEMU from git to use post-copy. Luckily, the QEMU migration capability we need to enable to use post-copy is still prefixed with "x-", which means it's still considered experimental. We are pretty sure the interface QEMU provides is OK, but we'd like to wait until seamless SPICE migration is fixed for post-copy before removing the experimental prefix. This should hopefully happen in time for QEMU 2.6.0. This series applies on top of "Fix and enhance statistics of a completed job" series I sent yesterday. Both series on top of current master can be fetched from the "post-copy-migration" branch of my staging repository at https://gitlab.com/jirkade/libvirt Version 3: - VIR_DOMAIN_EVENT_SUSPENDED_POSTCOPY_FAILED will only be emitted on the destination host - discard completed stats of an incoming post-copy migration Version 2: - VIR_MIGRATE_POSTCOPY_AFTER_PRECOPY flag dropped - --postcopy-after-precopy implemented entirely in virsh Cristian Klein (6): Add public APIs for post-copy migration qemu: Add QMP functions for post-copy migration qemu: Add support for VIR_MIGRATE_POSTCOPY flag qemu: Implement virDomainMigrateStartPostCopy virsh: Add support for post-copy migration virsh: Add --postcopy-after-precopy option to migrate Jiri Denemark (8): Add event and state details for post-copy qemu: Handle postcopy-active migration state virsh: Configurable migrate --timeout action qemu: Don't kill running migrated domain on daemon restart qemu: Refactor qemuProcessRecoverMigration qemu: Handle post-copy migration failures qemu: Refuse to abort migration in post-copy mode qemu: Add flags to qemuMigrationWaitForCompletion examples/object-events/event-test.c | 9 ++ include/libvirt/libvirt-domain.h | 11 ++ src/conf/domain_conf.c | 7 +- src/driver-hypervisor.h | 5 + src/libvirt-domain.c | 141 ++++++++++++++++- src/libvirt_public.syms | 4 + src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 72 ++++++++- src/qemu/qemu_migration.c | 291 +++++++++++++++++++++++++++++++----- src/qemu/qemu_migration.h | 6 +- src/qemu/qemu_monitor.c | 16 +- src/qemu/qemu_monitor.h | 4 + src/qemu/qemu_monitor_json.c | 23 +++ src/qemu/qemu_monitor_json.h | 3 + src/qemu/qemu_process.c | 233 ++++++++++++++++++----------- src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 13 +- src/remote_protocol-structs | 5 + tools/virsh-domain-monitor.c | 7 +- tools/virsh-domain.c | 157 +++++++++++++++++-- tools/virsh.pod | 31 +++- 22 files changed, 880 insertions(+), 161 deletions(-) -- 2.7.2

2 20

[libvirt] [PATCH] conf: node_device: fix wrong XML element reference
by Bjoern Walk 21 Mar '16

21 Mar '16

When reading in a XML definition for a SCSI target device, the name property of struct scsi_target refers to the @target element. Let's fix this obvious typo. Signed-off-by: Bjoern Walk <bwalk(a)linux.vnet.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.vnet.ibm.com> --- src/conf/node_device_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c index 611045c..f74b34d 100644 --- a/src/conf/node_device_conf.c +++ b/src/conf/node_device_conf.c @@ -822,7 +822,7 @@ virNodeDevCapSCSITargetParseXML(xmlXPathContextPtr ctxt, orignode = ctxt->node; ctxt->node = node; - data->scsi_target.name = virXPathString("string(./name[1])", ctxt); + data->scsi_target.name = virXPathString("string(./target[1])", ctxt); if (!data->scsi_target.name) { virReportError(VIR_ERR_INTERNAL_ERROR, _("no target name supplied for '%s'"), -- 2.6.5

2 1

[libvirt] [libvirt-sandbox PATCH] tests: add file extension for host mounts
by Guido Günther 21 Mar '16

21 Mar '16

otherwise we fail in gvir_sandbox_util_guess_image_format with "Cannot identify file extension in '/tmp/home' --- libvirt-sandbox/tests/test-config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-sandbox/tests/test-config.c b/libvirt-sandbox/tests/test-config.c index ac10bab..71a65c8 100644 --- a/libvirt-sandbox/tests/test-config.c +++ b/libvirt-sandbox/tests/test-config.c @@ -53,7 +53,7 @@ int main(int argc, char **argv) int ret = EXIT_FAILURE; const gchar *mounts[] = { "host-bind:/var/run/hell=/tmp/home", - "host-image:/etc=/tmp/home", + "host-image:/etc=/tmp/home/img.qcow2", "host-image:/etc=/tmp/home,format=qcow2", "host-bind:/tmp=", NULL -- 2.7.0

2 1