- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] virsh: perf: Trivial fixes of a memleak and coding style
by Peter Krempa 21 Apr '16

21 Apr '16

Both are pushed under the trivial rule. Peter Krempa (2): virsh: perf: Don't leak domain virsh: perf: Remove unnecessary 'error' label tools/virsh-domain.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) -- 2.8.1

2 3

[libvirt] [PATCH 0/9] Admin API: Introduce client listing API
by Erik Skultety 21 Apr '16

21 Apr '16

This series introduces API to list all clients connected to a specific server. Clients are now identified by 64-bit wide IDs and store their connection timestamp. Along with these attributes, transport type of the connection is returned back to the caller as well. Erik Skultety (9): rpc: virnetserverclient: Identify clients by an integer ID rpc: virnetserverclient: Introduce new attribute conn_time to client admin: Introduce virAdmClient client-side object rpc: gendispatch: Tune it to support client structure rpc: virnetserver: Support retrieval of a list of clients include: admin: export connection transport constants rpc: virnetserverclient: Implement client connection transport retrieval admin: Introduce listing clients virt-admin: Introduce srv-clients-list command daemon/admin.c | 15 +++ daemon/admin_server.c | 24 ++++ daemon/admin_server.h | 4 + daemon/libvirtd.c | 4 +- include/libvirt/libvirt-admin.h | 36 ++++++ src/admin/admin_protocol.x | 29 ++++- src/admin/admin_remote.c | 6 + src/admin_protocol-structs | 19 +++ src/datatypes.c | 35 +++++ src/datatypes.h | 47 +++++++ src/libvirt-admin.c | 131 +++++++++++++++++++ src/libvirt_admin_private.syms | 3 + src/libvirt_admin_public.syms | 5 + src/libvirt_remote.syms | 2 + src/locking/lock_daemon.c | 2 +- src/logging/log_daemon.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/rpc/gendispatch.pl | 61 +++++++-- src/rpc/virnetserver.c | 64 +++++++++- src/rpc/virnetserver.h | 6 + src/rpc/virnetserverclient.c | 106 ++++++++++++++-- src/rpc/virnetserverclient.h | 10 +- tests/Makefile.am | 7 + tests/virnetdaemondata/input-data-client-ids.json | 69 ++++++++++ .../input-data-client-timestamp.json | 71 +++++++++++ .../virnetdaemondata/output-data-admin-nomdns.json | 6 + .../output-data-admin-server-names.json | 6 + .../virnetdaemondata/output-data-anon-clients.json | 3 + tests/virnetdaemondata/output-data-client-ids.json | 69 ++++++++++ .../output-data-client-timestamp.json | 71 +++++++++++ .../output-data-initial-nomdns.json | 3 + tests/virnetdaemondata/output-data-initial.json | 3 + .../output-data-no-keepalive-required.json | 6 + tests/virnetdaemonmock.c | 34 +++++ tests/virnetdaemontest.c | 13 +- tests/virnetserverclienttest.c | 2 +- tools/virt-admin.c | 141 +++++++++++++++++++++ tools/virt-admin.pod | 7 + 38 files changed, 1085 insertions(+), 39 deletions(-) create mode 100644 tests/virnetdaemondata/input-data-client-ids.json create mode 100644 tests/virnetdaemondata/input-data-client-timestamp.json create mode 100644 tests/virnetdaemondata/output-data-client-ids.json create mode 100644 tests/virnetdaemondata/output-data-client-timestamp.json create mode 100644 tests/virnetdaemonmock.c -- 2.4.11

1 9

[libvirt] [PATCH v6 0/5] vz: add migration support
by Nikolay Shirokovskiy 21 Apr '16

21 Apr '16

Difference from v5 ================== 1. managed case is implemented 2. p2p follows managed migration flow now 3. 'vz: fix const correctness case' is needed to implement managed case. 4. misc options that are always on for vz (--live, --compressed) are not required to be set explicitly. 5. --offline is not supported anymore but migration of inactive domains is possible without this option set. Nikolay Shirokovskiy (5): vz: save session uuid on login vz: fix const correctness case vz: implement managed migration vz: implement p2p migration vz: cleanup: define vz format of uuids src/vz/vz_driver.c | 555 +++++++++++++++++++++++++++++++++++++++++++++++++++++ src/vz/vz_sdk.c | 89 +++++++-- src/vz/vz_sdk.h | 6 + src/vz/vz_utils.c | 2 +- src/vz/vz_utils.h | 6 +- 5 files changed, 641 insertions(+), 17 deletions(-) -- 1.8.3.1

2 7

[libvirt] [PATCH] Bump minimum libvirt requirement to 1.2.13
by Christophe Fergeau 21 Apr '16

21 Apr '16

libvirt-php uses VIR_STORAGE_VOL_CREATE_REFLINK which was introduced in commit v1.2.12-18-g95da191 (so first available in the 1.2.13 release). --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 7a634ca..bce3de2 100644 --- a/configure.ac +++ b/configure.ac @@ -39,7 +39,7 @@ if test "$prefix" = "/usr" && test "$sysconfdir" = '${prefix}/etc' ; then sysconfdir='/etc' fi -LIBVIRT_REQUIRED=1.2.9 +LIBVIRT_REQUIRED=1.2.13 PKG_CHECK_MODULES(LIBVIRT, libvirt >= $LIBVIRT_REQUIRED) PKG_CHECK_MODULES(QEMU, libvirt-qemu) AC_SUBST([QEMU_CFLAGS]) -- 2.5.5

4 6

[libvirt] [libvirt-php][PATCH 0/4] Fix build again
by Michal Privoznik 21 Apr '16

21 Apr '16

There were some problems with my build fixes. Hopefully, these will make it work for everybody again. Michal Privoznik (4): Get php cflags at configure Get rid of $DEFINES src: Distribute config.m4 libvirt-php.so: Avoid versioning library configure.ac | 5 +++++ src/Makefile.am | 13 ++++++++----- 2 files changed, 13 insertions(+), 5 deletions(-) -- 2.7.3

2 10

[libvirt] [PATCH 0/3] Perform some minor rather cosmetic adjustments to tests
by Erik Skultety 21 Apr '16

21 Apr '16

When I was adding new admin related tests, I noticed that we have some test data leftovers in the repo, as well as having a test that isn't enabled, although it should be and that we still have some JSON test data using tabs for indentation...my bad, I got through the log history only to see that when I merged a patch to fix this, I failed to do it properly. Erik Skultety (3): tests: remove virnetservertest data leftovers tests: virnetdaemon: Replace tabs with spaces tests: virnetdaemontest: Enable testing for no-keepalive-required .../input-data-admin-server-names.json | 204 +++++++++---------- .../output-data-no-keepalive-required.json | 224 ++++++++++----------- tests/virnetdaemontest.c | 1 + .../input-data-initial-nomdns.json | 61 ------ .../output-data-initial-nomdns.json | 62 ------ 5 files changed, 215 insertions(+), 337 deletions(-) delete mode 100644 tests/virnetserverdata/input-data-initial-nomdns.json delete mode 100644 tests/virnetserverdata/output-data-initial-nomdns.json -- 2.4.11

2 5

[libvirt] [PATCH] virsh: re-fix help printing without connection
by Roman Bogorodskiy 21 Apr '16

21 Apr '16

Re-do 0217089 so it does not add regression for commit c0726e0 that allowed to print help without making a connection to the daemon. --- tools/virsh.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index e14410b..366956c 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -962,14 +962,16 @@ main(int argc, char **argv) if (!vshInit(ctl, cmdGroups, NULL)) exit(EXIT_FAILURE); - ctl->connname = vshStrdup(ctl, virGetEnvBlockSUID("VIRSH_DEFAULT_CONNECT_URI")); - if (!virshParseArgv(ctl, argc, argv) || !virshInit(ctl)) { virshDeinit(ctl); exit(EXIT_FAILURE); } + if (!ctl->connname) + ctl->connname = vshStrdup(ctl, + virGetEnvBlockSUID("VIRSH_DEFAULT_CONNECT_URI")); + if (!ctl->imode) { ret = vshCommandRun(ctl, ctl->cmd); } else { -- 2.7.4

2 2

[libvirt] Release of libvirt-php-0.5.2
by Michal Privoznik 21 Apr '16

21 Apr '16

After 5 months of development I'm more than proud to announce that libvirt-php-0.5.2 is out!It can be downloaded from http://libvirt.org/sources/php/libvirt-php-0.5.2.tar.gz This release focused on adapting to PHP7 and yet again some more bug fixes. The diff stat is rather big, but that's mostly because of all the documentation that has been added to PHP functions that we expose. I'd like to thank everybody who participated, namely Neal and Remi for proposing their patches and testing mine, Vasiliy for his valuable input. Lets make the next release even better! Michal

3 4

[libvirt] [PATCH] virsh: don't override connection URI from argv
by Roman Bogorodskiy 21 Apr '16

21 Apr '16

Currently, if a connection URI was specified on the command line by the '-c' switch, virsh connects to it, but after connecting overrides its value with the one it tries to obtain from the VIRSH_DEFAULT_CONNECT_URI environment variable. This makes virsh connecting to the wrong URI if it disconnects from the hypervisor and then tries to reconnect, and also leaks the original connname. Fix by calling virGetEnvBlockSUID() before virshParseArgv(). --- tools/virsh.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 0d8ec5c..e14410b 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -962,14 +962,14 @@ main(int argc, char **argv) if (!vshInit(ctl, cmdGroups, NULL)) exit(EXIT_FAILURE); + ctl->connname = vshStrdup(ctl, virGetEnvBlockSUID("VIRSH_DEFAULT_CONNECT_URI")); + if (!virshParseArgv(ctl, argc, argv) || !virshInit(ctl)) { virshDeinit(ctl); exit(EXIT_FAILURE); } - ctl->connname = vshStrdup(ctl, virGetEnvBlockSUID("VIRSH_DEFAULT_CONNECT_URI")); - if (!ctl->imode) { ret = vshCommandRun(ctl, ctl->cmd); } else { -- 2.7.4

3 4

[libvirt] [PATCH] virsh: blockcopy: force an absolute path
by Cole Robinson 21 Apr '16

21 Apr '16

virsh doesn't reject or absolutify a passed relative path, which can give unexpected results. Convert a relative path to an absolute one before calling the API https://bugzilla.redhat.com/show_bug.cgi?id=1300177 --- tools/virsh-domain.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index a1d4a75..7074ded 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -2256,8 +2256,9 @@ static bool cmdBlockCopy(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom = NULL; - const char *dest = NULL; + const char *dest_cli = NULL; const char *format = NULL; + char *dest = NULL; unsigned long bandwidth = 0; unsigned int granularity = 0; unsigned long long buf_size = 0; @@ -2281,7 +2282,7 @@ cmdBlockCopy(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "path", &path) < 0) return false; - if (vshCommandOptStringReq(ctl, cmd, "dest", &dest) < 0) + if (vshCommandOptStringReq(ctl, cmd, "dest", &dest_cli) < 0) return false; if (vshCommandOptStringReq(ctl, cmd, "xml", &xml) < 0) return false; @@ -2308,6 +2309,11 @@ cmdBlockCopy(vshControl *ctl, const vshCmd *cmd) if (async) abort_flags |= VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC; + if (dest_cli && virFileAbsPath(dest_cli, &dest) < 0) { + vshError(ctl, _("failed to build absolute path for %s"), dest_cli); + return false; + } + VSH_EXCLUSIVE_OPTIONS_VAR(dest, xml); VSH_EXCLUSIVE_OPTIONS_VAR(format, xml); VSH_EXCLUSIVE_OPTIONS_VAR(blockdev, xml); @@ -2462,6 +2468,7 @@ cmdBlockCopy(vshControl *ctl, const vshCmd *cmd) ret = true; cleanup: + VIR_FREE(dest); VIR_FREE(xmlstr); virTypedParamsFree(params, nparams); virDomainFree(dom); -- 2.7.3

4 3

[libvirt] [PATCH 0/4] build: Fix symbolic links usage
by Andrea Bolognani 21 Apr '16

21 Apr '16

This series fixes the build failures currently affecting FreeBSD on ci.centos.org[1] and also gets rid of some behavior deemed dangerous by the autoconf manual[2]. Tested on Fedora 23 and FreeBSD 10.3-RELEASE. [1] https://ci.centos.org/view/libvirt-project/job/libvirt-freebsd/617/console [2] https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Partic… Andrea Bolognani (4): build: Always use $(LN_S) and $(MKDIR_P) build: Add AC_PROG_LN_S to configure build: Overwrite existing symbolic links build: Use $(LN_S) safely Makefile.am | 2 +- configure.ac | 1 + src/Makefile.am | 5 ++--- tools/Makefile.am | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) -- 2.5.5

2 6

[libvirt] [PATCH 1/2] qemu: process: split out shmem startup warning
by Cole Robinson 21 Apr '16

21 Apr '16

Now we can return early and save some indentation --- src/qemu/qemu_process.c | 95 ++++++++++++++++++++++++++----------------------- 1 file changed, 51 insertions(+), 44 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c087300..10e1b5a 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4497,6 +4497,56 @@ qemuProcessMakeDir(virQEMUDriverPtr driver, } +static void +qemuProcessStartWarnShmem(virDomainObjPtr vm) +{ + size_t i; + bool check_shmem = false; + bool shmem = vm->def->nshmems; + + /* + * For vhost-user to work, the domain has to have some type of + * shared memory configured. We're not the proper ones to judge + * whether shared hugepages or shm are enough and will be in the + * future, so we'll just warn in case neither is configured. + * Moreover failing would give the false illusion that libvirt is + * really checking that everything works before running the domain + * and not only we are unable to do that, but it's also not our + * aim to do so. + */ + for (i = 0; i < vm->def->nnets; i++) { + if (virDomainNetGetActualType(vm->def->nets[i]) == + VIR_DOMAIN_NET_TYPE_VHOSTUSER) { + check_shmem = true; + break; + } + } + + if (!check_shmem) + return; + + /* + * This check is by no means complete. We merely check + * whether there are *some* hugepages enabled and *some* NUMA + * nodes with shared memory access. + */ + if (!shmem && vm->def->mem.nhugepages) { + for (i = 0; i < virDomainNumaGetNodeCount(vm->def->numa); i++) { + if (virDomainNumaGetNodeMemoryAccessMode(vm->def->numa, i) == + VIR_NUMA_MEM_ACCESS_SHARED) { + shmem = true; + break; + } + } + } + + if (!shmem) { + VIR_WARN("Detected vhost-user interface without any shared memory, " + "the interface might not be operational"); + } +} + + /** * qemuProcessStartValidate: * @vm: domain object @@ -4517,9 +4567,6 @@ qemuProcessStartValidate(virQEMUDriverPtr driver, bool snapshot, unsigned int flags) { - bool check_shmem = false; - size_t i; - if (!(flags & VIR_QEMU_PROCESS_START_PRETEND)) { if (vm->def->virtType == VIR_DOMAIN_VIRT_KVM) { VIR_DEBUG("Checking for KVM availability"); @@ -4559,47 +4606,7 @@ qemuProcessStartValidate(virQEMUDriverPtr driver, VIR_DEBUG("Checking for any possible (non-fatal) issues"); - /* - * For vhost-user to work, the domain has to have some type of - * shared memory configured. We're not the proper ones to judge - * whether shared hugepages or shm are enough and will be in the - * future, so we'll just warn in case neither is configured. - * Moreover failing would give the false illusion that libvirt is - * really checking that everything works before running the domain - * and not only we are unable to do that, but it's also not our - * aim to do so. - */ - for (i = 0; i < vm->def->nnets; i++) { - if (virDomainNetGetActualType(vm->def->nets[i]) == - VIR_DOMAIN_NET_TYPE_VHOSTUSER) { - check_shmem = true; - break; - } - } - - if (check_shmem) { - bool shmem = vm->def->nshmems; - - /* - * This check is by no means complete. We merely check - * whether there are *some* hugepages enabled and *some* NUMA - * nodes with shared memory access. - */ - if (!shmem && vm->def->mem.nhugepages) { - for (i = 0; i < virDomainNumaGetNodeCount(vm->def->numa); i++) { - if (virDomainNumaGetNodeMemoryAccessMode(vm->def->numa, i) == - VIR_NUMA_MEM_ACCESS_SHARED) { - shmem = true; - break; - } - } - } - - if (!shmem) { - VIR_WARN("Detected vhost-user interface without any shared memory, " - "the interface might not be operational"); - } - } + qemuProcessStartWarnShmem(vm); return 0; } -- 2.7.3

2 2

[libvirt] [PATCH python] spec: Don't pull in dependencies for example scripts
by Cole Robinson 21 Apr '16

21 Apr '16

If the scripts are marked as executable, RPM magic will scan them for dependencies, which can pull in python2 for the python3 package --- Taken from this commit by a fedora packager: http://pkgs.fedoraproject.org/cgit/rpms/libvirt-python.git/commit/?id=78763… libvirt-python.spec.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 8a21003..3021ebd 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -49,6 +49,11 @@ of recent versions of Linux (and other OSes). %prep %setup -q +# Unset execute bit for example scripts; it can introduce spurious +# RPM dependencies, like /usr/bin/python which can pull in python2 +# for the -python3 package +find examples -type f -exec chmod 0644 \{\} \; + %build CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build %if %{with_python3} -- 2.7.3

2 1

[libvirt] [PATCH] virsh: Don't clear old connection if 'connect $uri' fails
by Cole Robinson 21 Apr '16

21 Apr '16

virsh # list --all Id Name State ---------------------------------------------------- 1 test running virsh # connect frob error: Failed to connect to the hypervisor error: no connection driver available for frob virsh # list --all error: failed to connect to the hypervisor error: no valid connection error: no connection driver available for frob Seems sensible IMO to just not clear out the old connection state until the new virConnectOpen succeeds. https://bugzilla.redhat.com/show_bug.cgi?id=829160 --- There was an older discussion here: https://www.redhat.com/archives/libvir-list/2012-June/msg00270.html That seemed to go off into the weeds a bit, talking about caching old URIs... This approach seems fine for me to address the bug report but maybe I missed something tools/virsh.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 0d8ec5c..353a5d8 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -292,6 +292,17 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd) bool ro = vshCommandOptBool(cmd, "readonly"); const char *name = NULL; virshControlPtr priv = ctl->privData; + virConnectPtr conn; + + if (vshCommandOptStringReq(ctl, cmd, "name", &name) < 0) + return false; + + conn = virshConnect(ctl, name, ro); + + if (!conn) { + vshError(ctl, "%s", _("Failed to connect to the hypervisor")); + return false; + } if (priv->conn) { int ret; @@ -303,13 +314,10 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd) else if (ret > 0) vshError(ctl, "%s", _("One or more references were leaked after " "disconnect from the hypervisor")); - priv->conn = NULL; } + priv->conn = conn; VIR_FREE(ctl->connname); - if (vshCommandOptStringReq(ctl, cmd, "name", &name) < 0) - return false; - ctl->connname = vshStrdup(ctl, name); priv->useGetInfo = false; @@ -317,13 +325,6 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd) priv->blockJobNoBytes = false; priv->readonly = ro; - priv->conn = virshConnect(ctl, ctl->connname, priv->readonly); - - if (!priv->conn) { - vshError(ctl, "%s", _("Failed to connect to the hypervisor")); - return false; - } - if (virConnectRegisterCloseCallback(priv->conn, virshCatchDisconnect, ctl, NULL) < 0) vshError(ctl, "%s", _("Unable to register disconnect callback")); -- 2.7.3

2 1

[libvirt] [PATCH] libvirt: Fix crash on URI without scheme
by Cole Robinson 21 Apr '16

21 Apr '16

My commit 0d1579572 crashes on a URI without a scheme, like via 'virsh --connect frob' Add a check on uri->server too while we are at it, and centralize them all --- src/libvirt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 749089b..114e88c 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -935,6 +935,9 @@ virConnectGetDefaultURI(virConfPtr conf, static int virConnectCheckURIMissingSlash(const char *uristr, virURIPtr uri) { + if (!uri->scheme || !uri->path || !uri->server) + return 0; + /* To avoid false positives, only check drivers that mandate a path component in the URI, like /system or /session */ if (STRNEQ(uri->scheme, "qemu") && @@ -942,9 +945,6 @@ virConnectCheckURIMissingSlash(const char *uristr, virURIPtr uri) STRNEQ(uri->scheme, "vz")) return 0; - if (uri->path != NULL) - return 0; - if (STREQ(uri->server, "session") || STREQ(uri->server, "system")) { virReportError(VIR_ERR_INTERNAL_ERROR, -- 2.7.3

2 1

[libvirt] RFC: virtio-rng and /dev/urandom
by Cole Robinson 20 Apr '16

20 Apr '16

Libvirt currently rejects using host /dev/urandom as an input source for a virtio-rng device. The only accepted sources are /dev/random and /dev/hwrng. This is the result of discussions on qemu-devel around when the feature was first added (2013). Examples: http://lists.gnu.org/archive/html/qemu-devel/2012-09/msg02387.html https://lists.gnu.org/archive/html/qemu-devel/2013-03/threads.html#00023 libvirt's rejection of /dev/urandom has generated some complaints from users: https://bugzilla.redhat.com/show_bug.cgi?id=1074464 * cited: http://www.2uo.de/myths-about-urandom/ http://www.redhat.com/archives/libvir-list/2016-March/msg01062.html http://www.redhat.com/archives/libvir-list/2016-April/msg00186.html I think it's worth having another discussion about this, at least with a recent argument in one place so we can put it to bed. I'm CCing a bunch of people. I think the questions are: 1) is the original recommendation to never use virtio-rng+/dev/urandom correct? 2) regardless of #1, should we continue to reject that config in libvirt? Thanks, Cole

9 21

[libvirt] [PATCH 0/4] libxl: Add support for UEFI using OVMF
by Jim Fehlig 20 Apr '16

20 Apr '16

This series adds support for UEFI, via OVMF, to the libxl driver. Patch1 moves the capabilities code from libxl_conf.{ch} to the new files libxl_capabilities.{ch}. Patch2 implements connectGetDomainCapabilities, allowing advertisement of the default OVMF firmware path. Patch3 implements conversion of xl.cfg <-> libvirt domXML. And patch4 finally maps the relevant virDomainLoaderDef fields to libxl_domain_build_info. Jim Fehlig (4): libxl: introduce libxl_capabilities.{ch} libxl: implement connectGetDomainCapabilities xenconfig: support bios=ovmf xl.cfg libxl: Add support for ovmf firmware po/POTFILES.in | 1 + src/Makefile.am | 11 +- src/libxl/libxl_capabilities.c | 557 +++++++++++++++++++++ src/libxl/libxl_capabilities.h | 54 ++ src/libxl/libxl_conf.c | 423 +--------------- src/libxl/libxl_conf.h | 18 +- src/libxl/libxl_domain.c | 1 + src/libxl/libxl_driver.c | 69 +++ src/xenconfig/xen_xl.c | 50 +- tests/Makefile.am | 5 + tests/domaincapsschemadata/domaincaps-xenfv.xml | 51 ++ tests/domaincapsschemadata/domaincaps-xenpv.xml | 44 ++ tests/domaincapstest.c | 33 ++ tests/testutilsxen.h | 1 + tests/xlconfigdata/test-fullvirt-ovmf-override.cfg | 27 + tests/xlconfigdata/test-fullvirt-ovmf-override.xml | 58 +++ tests/xlconfigdata/test-fullvirt-ovmf.cfg | 26 + tests/xlconfigdata/test-fullvirt-ovmf.xml | 58 +++ tests/xlconfigtest.c | 2 + 19 files changed, 1046 insertions(+), 443 deletions(-) create mode 100644 src/libxl/libxl_capabilities.c create mode 100644 src/libxl/libxl_capabilities.h create mode 100644 tests/domaincapsschemadata/domaincaps-xenfv.xml create mode 100644 tests/domaincapsschemadata/domaincaps-xenpv.xml create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf-override.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf-override.xml create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-ovmf.xml -- 2.1.4

1 4

[libvirt] [PATCH] qemu: process: comment on min_guarantee validation
by Cole Robinson 20 Apr '16

20 Apr '16

Explain why we check it at process startup time, and not parse time where most other XML validation checks are performed --- src/qemu/qemu_process.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index c087300..628b4b6 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4550,6 +4550,8 @@ qemuProcessStartValidate(virQEMUDriverPtr driver, virDomainDefCheckDuplicateDiskInfo(vm->def) < 0) return -1; + /* Previously we silently accepted this parameter; we can't reject + it at parse time without breaking those configs, so check it here */ if (vm->def->mem.min_guarantee) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Parameter 'min_guarantee' " -- 2.7.3

2 4

[libvirt] [PATCH] docs: domain: Document network <filterref>
by Cole Robinson 20 Apr '16

20 Apr '16

The proper nwfilter docs go into full detail, but we should still have a brief bit about domain XML in the domain documentation --- docs/formatdomain.html.in | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 9bcef6a..f6ce22d 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4908,6 +4908,47 @@ qemu-kvm -net nic,model=? /dev/null <code><model></code> element is mandatory. </p> + <h5><a name="elementNwfilter">Traffic filtering with NWFilter</a></h5> + + <p> + <span class="since">Since 0.8.0</span> an <code>nwfilter</code> profile + can be assigned to an interface device, which allows configuring + traffic filter rules for the virtual machine. + + See the <a href="formatnwfilter.html">nwfilter</a> documentation for more + complete details. + </p> + +<pre> + ... + <devices> + <interface ...> + ... + <filterref filter='clean-traffic'/> + </interface> + <interface ...> + ... + <filterref filter='myfilter'> + <parameter name='IP' value='104.207.129.11'/> + <parameter name='IP6_ADDR' value='2001:19f0:300:2102::'/> + <parameter name='IP6_MASK' value='64'/> + ... + </filterref> + </interface> + </devices> + ...</pre> + + <p> + The <code><filterref></code> <code>filter</code> attribute + specifies the name of the <a href="formatnwfilter.html">nwfilter</a> + to use. Optional <code><parameter></code> values may be + specified for passing additional info to the nwfilter via the + <code>name</code> and <code>value</code> attributes. See + the <a href="formatnwfilter.html#nwfconceptsvars">nwfilter</a> + docs for info on parameters. + </p> + + <h4><a name="elementsInput">Input devices</a></h4> <p> -- 2.7.3

2 2

[libvirt] [ 0/5] netdev ethernet allow to set ip, route and peer address
by Vasiliy Tolstov 20 Apr '16

20 Apr '16

Some minor improvements and patch split as suggested by Laine Stump Vasiliy Tolstov (5): virnetdev allow to set peer address libvirt domain xml allow to set peer address lxc domain allow to set peer address bridge network ignore peer address qemu domain allow to set ip address, peer address and route docs/formatdomain.html.in | 12 +++++++++- docs/schemas/domaincommon.rng | 5 ++++ src/conf/domain_conf.c | 14 ++++++++++- src/conf/domain_conf.h | 1 + src/lxc/lxc_container.c | 2 +- src/network/bridge_driver.c | 2 +- src/qemu/qemu_interface.c | 39 +++++++++++++++++++++++++++++++ src/util/virnetdev.c | 54 ++++++++++++++++++++++++++++++------------- src/util/virnetdev.h | 1 + 9 files changed, 110 insertions(+), 20 deletions(-) -- 2.7.3

3 14

[libvirt] [PATCH 0/4] Make uninstall clean again
by Michal Privoznik 20 Apr '16

20 Apr '16

It's been a while since 'make uninstall' cleaned up everything that 'make install' created. I've noticed this while trying to figure out why some build test on *BSD is failing (fix for that is in the first patch btw). Michal Privoznik (4): nss: Try harder to uninstall examples: Try harder to uninstall nwfilter docs: Uninstall libvirt logo too docs: Don't leave any documentation behind docs/Makefile.am | 7 +++++++ examples/Makefile.am | 2 +- tools/Makefile.am | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) -- 2.7.3

3 12

[libvirt] [PATCH REBASE 0/2] vz: fix handling inputs in config
by Nikolay Shirokovskiy 20 Apr '16

20 Apr '16

Input devices are not stored in SDK but we report them on dumpxml if vnc is on. Thus we need to handle input devices on define xml as well. The latter part have some problems. Let's fix them. Nikolay Shirokovskiy (2): vz: add default input devices on post parse vz: fix config input device check src/vz/vz_driver.c | 26 +++++++++++++++++++++++++- src/vz/vz_sdk.c | 27 ++++++++++++++++++--------- 2 files changed, 43 insertions(+), 10 deletions(-) -- 1.8.3.1

2 3

[libvirt] [libvirt-php][PATCH 0/2] Fix some build issues
by Michal Privoznik 20 Apr '16

20 Apr '16

While trying to make 'distcheck' work again, this is where I got so far. Unfortunately, distcheck is still not working. Michal Privoznik (2): tools: Compile generate-api-docs into builddir configure.ac: Slightly rework configure.ac | 11 ++++++----- tools/Makefile.am | 2 +- 2 files changed, 7 insertions(+), 6 deletions(-) -- 2.7.3

2 5

[libvirt] [PATCH] virt-aa-helper: disallow VNC socket read permissions
by Cole Robinson 20 Apr '16

20 Apr '16

From: Simon Arlott <bugzilla.redhat.simon(a)arlott.org> The VM does not need read permission for its own VNC socket to create(), bind(), accept() connections or to receive(), send(), etc. on connections. https://bugzilla.redhat.com/show_bug.cgi?id=1312573 --- src/security/virt-aa-helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index 50d2a08..a4cb409 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1062,7 +1062,7 @@ get_files(vahControl * ctl) for (i = 0; i < ctl->def->ngraphics; i++) { if (ctl->def->graphics[i]->type == VIR_DOMAIN_GRAPHICS_TYPE_VNC && ctl->def->graphics[i]->data.vnc.socket && - vah_add_file(&buf, ctl->def->graphics[i]->data.vnc.socket, "rw")) + vah_add_file(&buf, ctl->def->graphics[i]->data.vnc.socket, "w")) goto cleanup; } -- 2.5.5

3 4

[libvirt] [PATCH] man: Clarify virsh vol-clone works within a single pool
by Cole Robinson 20 Apr '16

20 Apr '16

virsh vol-clone is expected to clone a volume within a single pool; it doesn't work for cloning across pools. Clarify the docs https://bugzilla.redhat.com/show_bug.cgi?id=1103714 --- tools/virsh-volume.c | 2 +- tools/virsh.pod | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 36dd0ed..9cc8e52 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -546,7 +546,7 @@ static const vshCmdInfo info_vol_clone[] = { .data = N_("clone a volume.") }, {.name = "desc", - .data = N_("Clone an existing volume.") + .data = N_("Clone an existing volume within the parent pool.") }, {.name = NULL} }; diff --git a/tools/virsh.pod b/tools/virsh.pod index 6c9d4ec..e1c0d8e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3530,10 +3530,10 @@ only slightly higher initial disk space usage. =item B<vol-clone> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path> I<name> [I<--prealloc-metadata>] [I<--reflink>] -Clone an existing volume. Less powerful, but easier to type, version of -B<vol-create-from>. +Clone an existing volume within the parent pool. Less powerful, +but easier to type, version of B<vol-create-from>. I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool to create -the volume in. +that contains the source volume, and will contain the new volume. I<vol-name-or-key-or-path> is the name or key or path of the source volume. I<name> is the name of the new volume. [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't -- 2.7.3

2 2