- Devel - libvirt List Archives

[libvirt] [PATCH 0/7] Admin API: Add support for client identity info retrieval
by Erik Skultety 04 May '16

04 May '16

This series adds support for client identity retrieval, i.e. information like remote IP (if connected remotely), uid,gid,pid, as well as username if connected locally and also information regarding authentication (if used). The series is rebased on the listing clients series, because it relies on the gendispatch stuff, so for testing purposes checkout my remote branch https://github.com/eskultety/libvirt/tree/list-clients-info-disconnect which also covers the next series about client disconnect. Erik Skultety (7): admin: Introduce virAdmServerLookupClient admin: include: Introduce some client's identity related typed params macros virnetsocket: Provide socket address format in a more standard form virneserverclient: Introduce virNetServerClientHasSASLSession virnetserverclient: Add an internal method to retrieve client's identity admin: Introduce virAdmClientGetInfo API virt-admin: Introduce command client-info daemon/admin.c | 59 ++++++++++++++++++ daemon/admin_server.c | 102 +++++++++++++++++++++++++++++++ daemon/admin_server.h | 9 +++ daemon/remote.c | 13 +++- include/libvirt/libvirt-admin.h | 130 ++++++++++++++++++++++++++++++++++++++++ include/libvirt/virterror.h | 1 + src/admin/admin_protocol.x | 34 ++++++++++- src/admin/admin_remote.c | 47 +++++++++++++++ src/admin_protocol-structs | 20 +++++++ src/libvirt-admin.c | 75 +++++++++++++++++++++++ src/libvirt_admin_private.syms | 4 ++ src/libvirt_admin_public.syms | 2 + src/remote/remote_driver.c | 7 +++ src/rpc/virnetclient.c | 10 ++++ src/rpc/virnetclient.h | 2 + src/rpc/virnetserver.c | 23 +++++++ src/rpc/virnetserver.h | 3 + src/rpc/virnetserverclient.c | 48 +++++++++++++++ src/rpc/virnetserverclient.h | 6 ++ src/rpc/virnetsocket.c | 17 +++++- src/rpc/virnetsocket.h | 2 + src/util/virerror.c | 6 ++ src/util/virsocketaddr.c | 24 ++++++-- tests/virnetsockettest.c | 10 ++-- tools/virt-admin.c | 91 ++++++++++++++++++++++++++++ 25 files changed, 731 insertions(+), 14 deletions(-) -- 2.4.11

3 15

[libvirt] [PATCH] daemon: Add VIR_ERR_NO_SERVER and VIR_ERR_NO_CLIENT to daemonErrorLogFilter
by Erik Skultety 04 May '16

04 May '16

Commits 52a2eef9 and 62be5486 forgot to add these errors to daemon's error whitelist, i.e. in order to avoid log file pollution with errors like "Domain not found" or "Server not found" in this case, since these events are valid and expected to occur. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed under trivial rule. daemon/libvirtd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index f0fdaed..cc5190f 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -333,6 +333,8 @@ static int daemonErrorLogFilter(virErrorPtr err, int priority) case VIR_ERR_NO_DOMAIN_SNAPSHOT: case VIR_ERR_OPERATION_INVALID: case VIR_ERR_NO_DOMAIN_METADATA: + case VIR_ERR_NO_SERVER: + case VIR_ERR_NO_CLIENT: return VIR_LOG_DEBUG; } -- 2.4.11

1 0

[libvirt] [PATCH v2] send default USB controller in xml to destination during migration
by Shivaprasad G Bhat 04 May '16

04 May '16

The default USB controller is not sent to destination as the older versions of libvirt(0.9.4 or earlier as I see in commit log of 409b5f54) didn't support them. For some archs where the support started much later can safely send the USB controllers without this worry. So, send the controller to destination for all archs except x86. Moreover this is not very applicable to x86 as the USB controller has model ich9_ehci1 on q35 and for pc-i440fx, there cant be any slots before USB as it is fixed on slot 1. The patch fixes a bug that, if the USB controller happens to occupy a slot after disks/interfaces and one of them is hot-unplugged, then the default USB controller added on destination takes the smallest slot number and that would lead to savestate mismatch and migration failure. Seen and verified on PPC64. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/qemu/qemu_domain.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 6262bfe..963ff35 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -2599,7 +2599,11 @@ qemuDomainDefFormatBuf(virQEMUDriverPtr driver, usb = def->controllers[i]; } } - if (usb && usb->idx == 0 && usb->model == -1) { + /* The original purpose of the check was the migration compatibility + * with libvirt <= 0.9.4. Limitation doesn't apply to other archs + * and can cause problems on PPC64. + */ + if (ARCH_IS_X86(def->os.arch) && usb && usb->idx == 0 && usb->model == -1) { VIR_DEBUG("Removing default USB controller from domain '%s'" " for migration compatibility", def->name); toremove++;

5 5

[libvirt] [PATCH] dist: ln(1) is not guaranteed to have a '-f' option
by Andrea Bolognani 04 May '16

04 May '16

According to the autoconf manual, using '$(LN_S) -f' is not portable; remove the target explicitly beforehand to work around this limitation. Adjust some slightly awkward indentation while at it. --- src/Makefile.am | 3 ++- tools/Makefile.am | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index c639e37..b71e694 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -3079,7 +3079,8 @@ if WITH_NETWORK $(DESTDIR)$(confdir)/qemu/networks/default.xml && \ rm $(DESTDIR)$(confdir)/qemu/networks/default.xml.t; } ( cd $(DESTDIR)$(confdir)/qemu/networks/autostart && \ - $(LN_S) -f ../default.xml default.xml ) + rm -f default.xml && \ + $(LN_S) ../default.xml default.xml ) endif WITH_NETWORK uninstall-local:: uninstall-init uninstall-systemd diff --git a/tools/Makefile.am b/tools/Makefile.am index e963b91..c5a6a0d 100644 --- a/tools/Makefile.am +++ b/tools/Makefile.am @@ -424,7 +424,8 @@ NSS_SO_VER = 1 install-exec-hook: ( cd $(DESTDIR)$(libdir) && \ - $(LN_S) -f libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER) ) + rm -f nss_libvirt.so.$(NSS_SO_VER) && \ + $(LN_S) libnss_libvirt.so.$(NSS_SO_VER) nss_libvirt.so.$(NSS_SO_VER) ) uninstall-local: -rm -f $(DESTDIR)$(libdir)/nss_libvirt.so.$(NSS_SO_VER) -- 2.5.5

3 3

[libvirt] [PATCH v2 0/3] Add support for virtio-scsi-{pci, ccw} iothread support
by John Ferlan 03 May '16

03 May '16

v1 here: http://www.redhat.com/archives/libvir-list/2016-May/msg00077.html (patches 1-4 were pushed already, the following are patches 5-7) Changes: Patch 1: - Clean up docs, use 1.3.5 as the version instead of 1.3.4. - Use post parse callback virDomainDeviceDefPostParseInternal to handle the controller check if iothread's are set on a controller (rather than during Controller Def parsing Patch 2: - Clean up commit message - Use the _() for message - Use 'target' not 'dst' in message (more specific) Patch 3: - No changes John Ferlan (3): conf: Add support for virtio-scsi iothreads qemu: Use switch for qemuCheckIOThreads qemu: Add 'iothread' to command line for supported controller docs/formatdomain.html.in | 21 ++++ docs/schemas/domaincommon.rng | 3 + src/conf/domain_conf.c | 32 +++++- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 115 ++++++++++++++++++--- .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 28 +++++ .../qemuxml2argv-iothreads-virtio-scsi-ccw.xml | 39 +++++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.args | 32 ++++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.xml | 47 +++++++++ tests/qemuxml2argvtest.c | 6 ++ .../qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml | 40 +++++++ .../qemuxml2xmlout-iothreads-virtio-scsi-pci.xml | 51 +++++++++ tests/qemuxml2xmltest.c | 7 ++ 13 files changed, 409 insertions(+), 13 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-pci.xml -- 2.5.5

2 4

[libvirt] [PATCH REPOST 0/7] Add support for virtio-scsi-{pci, ccw} iothread support
by John Ferlan 03 May '16

03 May '16

Repost of : http://www.redhat.com/archives/libvir-list/2016-April/msg01539.html Essentially the same patches as previous, but refreshed to current HEAD of '6620cd1ef'. I did remove patch 5 since it's not necessary. Also had to adjust one test to add the new default panic device for ccw. John Ferlan (7): qemu: Add capability for virtio-scsi iothreads docs: clarify disk iothread support docs: Reformat the Controllers description conf: Move virDomainControllerModelTypeToString conf: Add support for virtio-scsi iothreads qemu: Use switch for qemuCheckIOThreads qemu: Add 'iothread' to command line for supported controller docs/formatdomain.html.in | 87 ++++++--- docs/schemas/domaincommon.rng | 3 + src/conf/domain_conf.c | 54 ++++-- src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 9 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 115 ++++++++++-- tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 80 +++++---- tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 80 +++++---- tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_1.5.3-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_2.1.1-1.replies | 88 +++++---- tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 177 ++++++++++++++---- tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.replies | 197 +++++++++++++++++---- tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 192 ++++++++++++++++---- .../qemuxml2argv-iothreads-virtio-scsi-ccw.args | 28 +++ .../qemuxml2argv-iothreads-virtio-scsi-ccw.xml | 39 ++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.args | 32 ++++ .../qemuxml2argv-iothreads-virtio-scsi-pci.xml | 47 +++++ tests/qemuxml2argvtest.c | 6 + .../qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml | 40 +++++ .../qemuxml2xmlout-iothreads-virtio-scsi-pci.xml | 51 ++++++ tests/qemuxml2xmltest.c | 7 + 28 files changed, 1308 insertions(+), 381 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-iothreads-virtio-scsi-pci.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-iothreads-virtio-scsi-pci.xml -- 2.5.5

2 21

[libvirt] [PATCH] Allow blkdeviotune to take human readable values
by Nishith Shah 03 May '16

03 May '16

Use vshCommandOptScaledInt instead of vshCommandOptULongLong so there is no need to pass values in raw bytes, which is seldom the case. --- tools/virsh-domain.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0a6caae..3843675 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -1299,7 +1299,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) if (vshCommandOptStringReq(ctl, cmd, "device", &disk) < 0) goto cleanup; - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1308,7 +1308,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1317,7 +1317,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1326,7 +1326,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1335,7 +1335,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1344,7 +1344,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-bytes-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-bytes-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1353,7 +1353,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1362,7 +1362,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1371,7 +1371,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1380,7 +1380,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "write-iops-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "write-iops-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1389,7 +1389,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "read-iops-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "read-iops-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1398,7 +1398,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "total-iops-sec-max", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "total-iops-sec-max", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, @@ -1407,7 +1407,7 @@ cmdBlkdeviotune(vshControl *ctl, const vshCmd *cmd) goto save_error; } - if ((rv = vshCommandOptULongLong(ctl, cmd, "size-iops-sec", &value)) < 0) { + if ((rv = vshCommandOptScaledInt(ctl, cmd, "size-iops-sec", &value, 1, ULLONG_MAX)) < 0) { goto interror; } else if (rv > 0) { if (virTypedParamsAddULLong(&params, &nparams, &maxparams, -- 2.1.4

4 6

[libvirt] [PATCH] virsh: volume: Add --bytes to 'vol-info'
by Peter Krempa 03 May '16

03 May '16

--- tools/virsh-volume.c | 23 +++++++++++++++++++---- tools/virsh.pod | 4 +++- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 9cc8e52..d35fee1 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -992,6 +992,10 @@ static const vshCmdInfo info_vol_info[] = { static const vshCmdOptDef opts_vol_info[] = { VIRSH_COMMON_OPT_VOLUME_VOL, VIRSH_COMMON_OPT_POOL_OPTIONAL, + {.name = "bytes", + .type = VSH_OT_BOOL, + .help = N_("sizes are represented in bytes rather than pretty units") + }, {.name = NULL} }; @@ -1000,6 +1004,7 @@ cmdVolInfo(vshControl *ctl, const vshCmd *cmd) { virStorageVolInfo info; virStorageVolPtr vol; + bool bytes = vshCommandOptBool(cmd, "bytes"); bool ret = true; if (!(vol = virshCommandOptVol(ctl, cmd, "vol", "pool", NULL))) @@ -1014,11 +1019,21 @@ cmdVolInfo(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, "%-15s %s\n", _("Type:"), virshVolumeTypeToString(info.type)); - val = vshPrettyCapacity(info.capacity, &unit); - vshPrint(ctl, "%-15s %2.2lf %s\n", _("Capacity:"), val, unit); + if (bytes) { + vshPrint(ctl, "%-15s %llu %s\n", _("Capacity:"), + info.capacity, _("bytes")); + } else { + val = vshPrettyCapacity(info.capacity, &unit); + vshPrint(ctl, "%-15s %2.2lf %s\n", _("Capacity:"), val, unit); + } - val = vshPrettyCapacity(info.allocation, &unit); - vshPrint(ctl, "%-15s %2.2lf %s\n", _("Allocation:"), val, unit); + if (bytes) { + vshPrint(ctl, "%-15s %llu %s\n", _("Allocation:"), + info.allocation, _("bytes")); + } else { + val = vshPrettyCapacity(info.allocation, &unit); + vshPrint(ctl, "%-15s %2.2lf %s\n", _("Allocation:"), val, unit); + } } else { ret = false; } diff --git a/tools/virsh.pod b/tools/virsh.pod index 90ab47d..2a95df7 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3639,11 +3639,13 @@ is in. I<vol-name-or-key-or-path> is the name or key or path of the volume to output the XML of. =item B<vol-info> [I<--pool> I<pool-or-uuid>] I<vol-name-or-key-or-path> +[I<--bytes>] Returns basic information about the given storage volume. I<--pool> I<pool-or-uuid> is the name or UUID of the storage pool the volume is in. I<vol-name-or-key-or-path> is the name or key or path of the volume -to return information for. +to return information for. If I<--bytes> is specified the sizes are not +converted to human friendly units. =item B<vol-list> [I<--pool> I<pool-or-uuid>] [I<--details>] -- 2.8.1

2 1

[libvirt] [PATCH 0/4] configure: Fix init script choice
by Andrea Bolognani 03 May '16

03 May '16

The changes pushed yesterday have introduced an issue where systemd was turned into systemd+redhat on RHEL systems, which in turn caused RPM building to fail[1]. Patch 1/4 is the actual fix; patch 2/4 changes the code so that breaking it again is hopefully a bit harder. Patches 3/4 and 4/4 clean up a couple of barely related issues in the spec file that I've ran into while investigating this. [1] https://ci.centos.org/view/libvirt-project/job/libvirt-daemon-rpm/systems=l… Andrea Bolognani (4): configure: Change RHEL default from systemd+redhat to systemd configure: Remove nested conditionals in LIBVIRT_CHECK_INIT_SCRIPT spec: Type --with-init-script correctly spec: Rename %{init_scripts} -> %{with_init_script} libvirt.spec.in | 6 +++--- m4/virt-init-script.m4 | 21 ++++++--------------- 2 files changed, 9 insertions(+), 18 deletions(-) -- 2.5.5

2 6

[libvirt] [PATCH] maint: Ignore all .init, .service and .socket files
by Andrea Bolognani 03 May '16

03 May '16

All files with those extensions are generated, so we can have three generic rules instead of explicitly ignoring every single instance. --- Pushed as trivial. .gitignore | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/.gitignore b/.gitignore index bf9109f..ba537d8 100644 --- a/.gitignore +++ b/.gitignore @@ -11,6 +11,7 @@ *.gcov *.html *.i +*.init *.la *.lo *.loT @@ -20,6 +21,8 @@ *.pyc *.rej *.s +*.service +*.socket *.swp *~ .#* @@ -59,9 +62,7 @@ /daemon/libvirt_qemud /daemon/libvirtd /daemon/libvirtd*.logrotate -/daemon/libvirtd.init /daemon/libvirtd.policy -/daemon/libvirtd.service /daemon/test_libvirtd.aug /docs/aclperms.htmlinc /docs/apibuild.py.stamp @@ -154,13 +155,7 @@ /src/util/virkeymaps.h /src/virt-aa-helper /src/virtlockd -/src/virtlockd.init -/src/virtlockd.service -/src/virtlockd.socket /src/virtlogd -/src/virtlogd.init -/src/virtlogd.service -/src/virtlogd.socket /tests/*.log /tests/*.pid /tests/*.trs @@ -174,8 +169,6 @@ /tests/reconnect /tests/ssh /tests/test_conf -/tools/libvirt-guests.init -/tools/libvirt-guests.service /tools/libvirt-guests.sh /tools/virt-login-shell /tools/virsh -- 2.5.5

1 0

[libvirt] [PATCH] gitignore: ignore virt(log|lock)d.(service|socket)
by Cole Robinson 03 May '16

03 May '16

--- Pushed as trivial .gitignore | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.gitignore b/.gitignore index 6021403..a0de097 100644 --- a/.gitignore +++ b/.gitignore @@ -156,8 +156,12 @@ /src/virt-aa-helper /src/virtlockd /src/virtlockd.init +/src/virtlockd.service +/src/virtlockd.socket /src/virtlogd /src/virtlogd.init +/src/virtlogd.service +/src/virtlogd.socket /tests/*.log /tests/*.pid /tests/*.trs -- 2.7.4

2 3

[libvirt] [PATCH] maint: Don't ignore libvirtd.pod any longer
by Andrea Bolognani 03 May '16

03 May '16

Starting from commit 5b479f3b5b82, libvirtd.pod is a source file rather than a generated file. Update ignore patterns accordingly. --- Pushed as trivial. .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index a0de097..bf9109f 100644 --- a/.gitignore +++ b/.gitignore @@ -60,7 +60,6 @@ /daemon/libvirtd /daemon/libvirtd*.logrotate /daemon/libvirtd.init -/daemon/libvirtd.pod /daemon/libvirtd.policy /daemon/libvirtd.service /daemon/test_libvirtd.aug -- 2.5.5

1 0

[libvirt] [PATCH v3 0/2] daemon: add option to read host uuid from /etc/machine-id
by Nikolay Shirokovskiy 03 May '16

03 May '16

difference from version 2: * cleanup syms file * split patch into two * update libvirtd.conf augeas lens and tests Nikolay Shirokovskiy (2): util: factor out reading file into preallocated buffer daemon: add option to read host uuid from /etc/machine-id daemon/libvirtd-config.c | 2 ++ daemon/libvirtd-config.h | 1 + daemon/libvirtd.aug | 1 + daemon/libvirtd.c | 38 +++++++++++++++++++++++++++++++++++--- daemon/libvirtd.conf | 15 +++++++++++---- daemon/test_libvirtd.aug.in | 1 + src/libvirt_private.syms | 1 + src/util/virfile.c | 24 ++++++++++++++++++++++++ src/util/virfile.h | 2 ++ src/util/viruuid.c | 11 ++--------- 10 files changed, 80 insertions(+), 16 deletions(-) -- 1.8.3.1

2 3

[libvirt] [PATCH 0/3] qemu: support configuring usb3 controller port count
by Cole Robinson 03 May '16

03 May '16

This adds support for configuring the amount of usb ports on qemu's usb3 controller. The default port count is 4 which is kind of low, and when virt-manager starts using usb3 by default we will likely up the port count to something like 8. Cole Robinson (3): qemu: parse: Use virControllerDefNew qemu: caps: introduce QEMU_CAPS_NEC_USB_XHCI_PORTS qemu: support configuring usb3 controller port count docs/formatdomain.html.in | 6 ++-- docs/schemas/domaincommon.rng | 8 ++++- src/conf/domain_conf.c | 41 ++++++++++++++-------- src/conf/domain_conf.h | 9 +++++ src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 7 ++++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 +++++++ src/qemu/qemu_parse_command.c | 8 ++--- tests/qemucapabilitiesdata/caps_1.2.2-1.replies | 11 ++++++ tests/qemucapabilitiesdata/caps_1.3.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.3.1-1.replies | 29 +++++++++++++++ tests/qemucapabilitiesdata/caps_1.4.2-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.4.2-1.replies | 29 +++++++++++++++ tests/qemucapabilitiesdata/caps_1.5.3-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.5.3-1.replies | 29 +++++++++++++++ tests/qemucapabilitiesdata/caps_1.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.0-1.replies | 29 +++++++++++++++ tests/qemucapabilitiesdata/caps_1.6.50-1.caps | 1 + tests/qemucapabilitiesdata/caps_1.6.50-1.replies | 29 +++++++++++++++ tests/qemucapabilitiesdata/caps_2.1.1-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.1.1-1.replies | 33 +++++++++++++++++ tests/qemucapabilitiesdata/caps_2.4.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.4.0-1.replies | 41 ++++++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.5.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.5.0-1.replies | 41 ++++++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.6.0-1.caps | 1 + tests/qemucapabilitiesdata/caps_2.6.0-1.replies | 41 ++++++++++++++++++++++ .../qemuxml2argv-usb-controller-xhci.args | 22 ++++++++++++ .../qemuxml2argv-usb-controller-xhci.xml | 16 +++++++++ tests/qemuxml2argvtest.c | 3 ++ 31 files changed, 434 insertions(+), 22 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-xhci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-usb-controller-xhci.xml -- 2.7.4

2 8

Re: [libvirt] [PATCH] ppc64: get the maxvcpus from the qemu caps instead of /dev/kvm
by Cole Robinson 03 May '16

03 May '16

On 05/03/2016 02:39 AM, Shivaprasad bhat wrote: > Thanks for the reply Cole. > > On Tue, May 3, 2016 at 3:27 AM, Cole Robinson <crobinso(a)redhat.com > <mailto:crobinso@redhat.com>> wrote: > > On 05/02/2016 09:14 AM, Shivaprasad G Bhat wrote: > > On PPC64, the KVM_MAX_VCPUS is defined to be 1024 where as qemu has > > MAX_CPUMASK_BITS defined at 255 in include/sysemu/sysemu.h. > > > > virsh domacapabilities and virsh maxvcpus --type kvm return different > > maxvcpus values and is confusing as to know what actually works. > > > > Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com > <mailto:sbhat@linux.vnet.ibm.com>> > > --- > > src/qemu/qemu_driver.c | 28 ++++++++++++++++++++++++++-- > > 1 file changed, 26 insertions(+), 2 deletions(-) > > > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > > index 3d0c7c8..d84fc47 100644 > > --- a/src/qemu/qemu_driver.c > > +++ b/src/qemu/qemu_driver.c > > @@ -1255,10 +1255,34 @@ static int qemuConnectIsAlive(virConnectPtr conn > ATTRIBUTE_UNUSED) > > > > > > static int > > -kvmGetMaxVCPUs(void) > > +kvmGetMaxVCPUs(virConnectPtr conn) > > { > > int fd; > > int ret; > > + virArch arch = virArchFromHost(); > > + virQEMUCapsPtr qemuCaps = NULL; > > + virQEMUDriverPtr driver = conn->privateData; > > + > > + const char *machine; > > + > > + if (ARCH_IS_PPC64(arch)) { > > + if (!(qemuCaps = > virQEMUCapsCacheLookupByArch(driver->qemuCapsCache, > > + arch))) { > > + virReportError(VIR_ERR_INVALID_ARG, > > + _("unable to find any emulator to serve '%s' " > > + "architecture"), virArchToString(arch)); > > + return -1; > > + } > > + > > + if (!(machine = virQEMUCapsGetDefaultMachine(qemuCaps))) { > > + virObjectUnref(qemuCaps); > > + return -1; > > + } > > + > > + ret = virQEMUCapsGetMachineMaxCpus(qemuCaps, machine); > > + virObjectUnref(qemuCaps); > > + return ret; > > + } > > > > I don't really like this. > > The MaxVCPUs API sucks: it doesn't take enough parameters to give an accurate > picture of what the max VCPUs supported for your desired config is. And that's > basically unfixable. > > Hacking in a one off fix for PPC64 here doesn't seem like a good idea. If you > really want to 'fix' this I'd suggest one or more of: > > - Reflect /dev/kvm maxvcpus in the capabilities XML somehow > - Extend 'virsh maxvcpus' to take os_type+virt_type+emulator+machine_type, > look up the capabilities XML, correlate that with maxvcpus output/new > capabilities XML, and give a real value for the desired config > - Change the maxvcpus API to consistently to return capabilities output, or > cap the return value to the largest reported in capabilities output, and do it > consistently for all architectures > > > Extending maxvcpus API would make it more or less same as domcapabilities and I am > not sure if that is necessary. I feel just reporting the maxvcpus to show the > max possible > vcpus for the default machine & arch & binary is a good idea as that is what > the API > intends to return today. > > I think the third option here what you suggested seems more logical. The > maxvcpus supposed to be "minimum" of what comes out of capabilities or > /dev/kvm not the > "maximum". > > I am not sure of how the /dev/kvm and capabilties outputs differ on all archs. > For x86 I saw them to be consistent. And on PPC it was different. Hope having a > generic approach to report the "minimum" is good for all archs. Being unsure > was the > reason limiting my checks to PPC alone. > > I'll take the third approach as suggested. > Re-adding libvir-list to CC I lightly grepped kernel sources. I think PPC is the only > 255 VCPU case, if anything the other archs will be limited by their KVM support and not qemu machine type support - Cole

1 0

[libvirt] [PATCH 0/7] qemu machine cleanups
by Ján Tomko 03 May '16

03 May '16

Unify detection of machine types and clean up some return value handling. Ján Tomko (7): Use qemuDomainMachineIs helpers when adding default devices Invert condition in qemuDomainDefAddDefaultDevices Return void in qemuDomainAssignARMVirtioMMIOAddresses Remove useless variable in qemuDomainAssignAddresses Rewrite the condition in qemuDomainAssignARMVirtioMMIOAddresses Introduce qemuDomainMachineIsVirt Remove useless os.machine NULL check src/qemu/qemu_capabilities.c | 3 +-- src/qemu/qemu_command.c | 3 +-- src/qemu/qemu_domain.c | 32 +++++++++++++----------------- src/qemu/qemu_domain.h | 1 + src/qemu/qemu_domain_address.c | 45 ++++++++++++++++++++---------------------- 5 files changed, 38 insertions(+), 46 deletions(-) -- 2.7.3

3 16

[libvirt] [PATCH 0/3] Couple of qemu monitor refactors
by Michal Privoznik 03 May '16

03 May '16

The first two patches are intended to be merged. The last one is incomplete. Intentionally. It should be viewed as RFC. If upstream likes it, I can finish the work. But so far it's merely just for you guys to express your opinion. Michal Privoznik (3): qemuMonitorJSONQueryRxFilter: Validate qemu reply prior parsing it qemu_monitor_json: Drop redundant checks qemu_monitor_json: Follow our coding style src/qemu/qemu_monitor_json.c | 323 +++++++++++++++++++++---------------------- 1 file changed, 156 insertions(+), 167 deletions(-) -- 2.8.1

2 6

[libvirt] [PATCH v2 0/2] qemu: Refresh guest's RTC on daemon restart
by Michal Privoznik 03 May '16

03 May '16

v2 of: https://www.redhat.com/archives/libvir-list/2016-April/msg02001.html diff to v1: -Peter's review suggestions worked in Michal Privoznik (2): qemu: Introduce qemuMonitorGetRTCTime qemu: Refresh RTC adjustment on qemuProcessReconnect src/qemu/qemu_monitor.c | 11 +++++++++++ src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 41 +++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 3 +++ src/qemu/qemu_process.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 102 insertions(+) -- 2.8.1

2 4

[libvirt] Release of libvirt-1.3.4
by Daniel Veillard 03 May '16

03 May '16

As planned, it's out ! I tagged the release in git and pushed the signed tarball and rpms to the usual place: ftp://libvirt.org/libvirt/ I also pushed the corresponding libvirt-python release to ftp://libvirt.org/libvirt/python/ This is a rather large release especially considering that it's only a bit over 3 weeks since 1.3.3 went out. The amount of changes related to documentation and portability (especially FreeBSD and old Linuxes/gcc) is larger than usual :-) . And as usual quite a lot of incremental improvements, internal refactoring of code and bug fixes ! Features: - Lot of work on documentation (Andrea Bolognani, Cole Robinson) - Add support for migration data compression (ShaoHe Feng, Nikolay Shirokovskiy, Eli Qiao) Documentation: - Fix minor typos in messages (Yuri Chornoivan) - docs: Pass relative paths to apibuild.py (Andrea Bolognani) - man: Fix links (Andrea Bolognani) - man: Fix SYNOPSIS section (Andrea Bolognani) - man: Fix NAME section (Andrea Bolognani) - build: Standardize on .pod -> .x.in -> .x (Andrea Bolognani) - build: Perform post-processing on all man pages (Andrea Bolognani) - build: Build man pages in $(builddir) (Andrea Bolognani) - build: Extract pod from source files (Andrea Bolognani) - build: Ship virt-admin.pod (Andrea Bolognani) - docs: Fix some formatting oddities (Andrea Bolognani) - syntax-check: Enforce <code> inside <dt> elements (Andrea Bolognani) - docs: remove *other* reference to igmp for IPv6 (Laine Stump) - docs: Add bold style for <dt><code> elements (John Ferlan) - docs: Use <code> inside <dt> for symbols (Andrea Bolognani) - docs: apibuild: Fix for python 2.6 (Peter Krempa) - docs: remove reference to non-existent "igmp-ipv6" protocol (Laine Stump) - docs: domain: Document network <filterref> (Cole Robinson) - docs: Don't leave any documentation behind (Michal Privoznik) - docs: Uninstall libvirt logo too (Michal Privoznik) - man: Clarify virsh vol-clone works within a single pool (Cole Robinson) - docs: Document the new XML elements (Andrea Bolognani) - virDomain{Get,Set}PerfEvents: Tweak documentation (Michal Privoznik) - spec: Only pull in API docs with -devel package (Cole Robinson) - man: virsh: Document lxc-enter-namespace --noseclabel (Cole Robinson) - docs: formatdomain: document versions for video acceleration (Cole Robinson) - docs: domain: document blkiotune {read, write}_{bytes, iops}_sec (Cole Robinson) - docs: rewrite graphics XML documentation (Pavel Hrdina) - docs: Remove unused div.body CSS rule (Andrea Bolognani) Portability: - wireshark: Fix distcheck (Michal Privoznik) - tools: Introduce install-nss targets (Michal Privoznik) - docs: apibuild: Fix VPATH build (Peter Krempa) - build: Fix default network generation on FreeBSD (Andrea Bolognani) - dist: ln(1) is not guaranteed to have a '-f' option (Andrea Bolognani) - build: Use $(LN_S) safely (Andrea Bolognani) - Include sysmacros.h where needed (Martin Kletzander) - ploop: Fix build with gluster (Jiri Denemark) - Fix various shadowed declarations (Martin Kletzander) - build: fix build on RHEL-6 (Pavel Hrdina) - build: add GCC 6.0 -Wlogical-op workaround (Pavel Hrdina) - build: cleanup GCC < 4.6 -Wlogical-op workaround (Pavel Hrdina) - configure: Fix check for --with-login-shell on Windows (Andrea Bolognani) - qemu: fix build without gnutls installed (Roman Bogorodskiy) - nss: properly include syms files to dist (Roman Bogorodskiy) - netdev: Use the correct pointer type for virSocketAddrFormat() (Andrea Bolognani) - configure: Move check for <gnutls/crypto.h> (Andrea Bolognani) - util: move ENODATA redefine to internal.h (Roman Bogorodskiy) - qemu: Explicitly check for gnutls_rnd() (Andrea Bolognani) Bug Fixes: - rpc: Don't leak fd via CreateXMLWithFiles (Ben Gray) - vz: fix disk enumeration (Mikhail Feoktistov) - virsh: Fix support for 64 migration options (Nikolay Shirokovskiy) - qemu: Regenerate VNC socket paths (Martin Kletzander) - qemu: Error out if setting vcpu count would lead to invalid config (Peter Krempa) - qemu: conf: Set default logging approach in virQEMUDriverConfigNew (Peter Krempa) - Shorten domain name for automatic coredump (Martin Kletzander) - qemu: Unref cfg in qemuDomainDefPostParse (Martin Kletzander) - conf: Drop restrictions on rng backend path (Cole Robinson) - remote: Don't reject remote polkit if client lacks support (Cole Robinson) - spec: If installing default network, restart libvirtd (Cole Robinson) - schema: Allow space character in disk vendor/product (Cole Robinson) - qemu: fix error log in qemuAssignPCIAddresses() (Laine Stump) - virsh: host: Use bitmap size in bytes rather than bit count (Peter Krempa) - qemu: Fix off-by-one error in block I/O throttle messages (Martin Kletzander) - qemu: Limit maximum block device I/O tune values (Martin Kletzander) - virconf: Handle conf file without ending newline (Cole Robinson) - network: fix DHCPv6 on networks with prefix != 64 (Laine Stump) - virsh: Don't clear old connection if 'connect $uri' fails (Cole Robinson) - libvirt: Fix crash on URI without scheme (Cole Robinson) - virsh: perf: Don't leak domain (Peter Krempa) - virsh: don't override connection URI from argv (Roman Bogorodskiy) - vz: fix config input device check (Nikolay Shirokovskiy) - virt-aa-helper: disallow VNC socket read permissions (Simon Arlott) - Revert "daemon: use socket activation with systemd" (Cole Robinson) - tests: Fix enumeration value (Andrea Bolognani) - vz: fix boot check to use new disk id (Nikolay Shirokovskiy) - vz: fix detach disk to use new disk id (Nikolay Shirokovskiy) - network: prevent duplicate entries in network device pools (Laine Stump) - lxc: explicitly error on interface type=ethernet (Cole Robinson) - tests: Fix syntax in iSCSI auth/secret tests (John Ferlan) - Libvirt: virTypedParamsValidate: Fix detection of multiple parameters (Jason J. Herne) - Resolve a couple of memory leaks (John Ferlan) - tools: Fix memory leak (John Ferlan) - qemu: Fix qemuBuildCommandLine prototype (John Ferlan) - qemu: hotplug: Properly recalculate/reload balloon size after hot(un)plug (Peter Krempa) - storage: mpath: Don't error on target_type=NULL (Cole Robinson) - qemu: command: don't overwrite watchdog dump action (Cole Robinson) - fix build by correcting functions order and src/Makefile.am (Maxim Nestratov) - rpc: daemon: Fix virtlog/virtlock daemon reload (Cole Robinson) - qemuxml2argvtest: do not mock virCommand (Ján Tomko) - vz: fix memory leak (Nikolay Shirokovskiy) - conf: also mark the implicit video as primary (Ján Tomko) - virtlogd: Fix a couple minor memory leaks (Cole Robinson) - qemu: Free priv->machineName (Martin Kletzander) - qemu: agent: Fix incorrect and weird debug/warning log entries (Peter Krempa) - util: netdev: Don't crash in virNetDevSetIPAddress if @peer is NULL (Peter Krempa) - libxl: libxl_domain_create_restore has an extra argument (Wei Liu) - qemu: perf: Fix crash/memory corruption on failed VM start (Peter Krempa) - qemu: alias: Fix calculation of memory device aliases (Peter Krempa) - qemu: alias: Fix calculation of RNG device aliases (Peter Krempa) - Link libvirt_xenconfig instead of libvirt against libxl (Guido Günther) - libvirt-admin: do not crash on URI without a scheme (Ján Tomko) Improvements: - Unify domain name shortening (Martin Kletzander) - spec: Use proper indentation (Andrea Bolognani) - maint: Ignore all intermediate and generated man pages (Andrea Bolognani) - apibuild: Fix method call (Andrea Bolognani) - apibuild: Introduce app class (Andrea Bolognani) - apibuild: Add index.warning() method (Andrea Bolognani) - secret: Change virSecretDef variable names (John Ferlan) - secret: Introduce virSecretObjGetValue and virSecretObjGetValueSize (John Ferlan) - secret: Introduce virSecretObj{Get|Set}Def (John Ferlan) - secret: Introduce virSecretObjSave{Config|Data} (John Ferlan) - secret: Introduce virSecretObjDelete{Config|Data} (John Ferlan) - secret: Move and rename secretLoadAllConfigs (John Ferlan) - secret: Use the hashed virSecretObjList (John Ferlan) - secret: Introduce virSecretObjListGetUUIDs (John Ferlan) - secret: Introduce virSecretObjListExport (John Ferlan) - secret: Introduce virSecretObjListNumOfSecrets (John Ferlan) - secret: Introduce virSecretObjListAdd* and virSecretObjListRemove (John Ferlan) - secret: Introduce virSecretUsageIDForDef (John Ferlan) - secret: Introduce virSecretObjListFindBy{UUID|Usage} support (John Ferlan) - secret: Create virsecretobj.c and virsecretconf.h (John Ferlan) - Makefile: Enable distuninstallcheck again (Michal Privoznik) - qemuProcessCreatePretendCmd: Rework FIPS handling (Michal Privoznik) - build: Always ship virt-login-shell.conf (Andrea Bolognani) - build: Replace variables in man pages (Andrea Bolognani) - build: Ensure intermediate files are cleaned up properly (Andrea Bolognani) - build: Group files (Andrea Bolognani) - build: Never ship man pages (Andrea Bolognani) - tests: consistently source test-lib.sh in scripts (Cole Robinson) - vbox: VIR_WARN if we don't support the API version (Cole Robinson) - tests: remove 'reconnect' and 'statstest' (Cole Robinson) - tests: rename test_conf -> virconftest (Cole Robinson) - tests: consistently name virsh tests with 'virsh-' prefix (Cole Robinson) - tests: build: Remove duplicate libvirtd test list (Cole Robinson) - conf: disk: extract validation of startup policy (Peter Krempa) - conf: disk: Extract checking of removable status (Peter Krempa) - conf: disk: Move validation of disk bus vs disk type (Peter Krempa) - conf: disk: extract sgio/rawio validation (Peter Krempa) - conf: disk: Don't bother setting removable state to 0 by default (Peter Krempa) - conf: disk: Initialize closed device tray state to 0 (Peter Krempa) - conf: disk: Extract disk type and device right away (Peter Krempa) - conf: disk: Remove custom single-use temporary variables (Peter Krempa) - conf: disk: Mark VIR_DOMAIN_DISK_IO_DEFAULT as 0 and simplify parsing (Peter Krempa) - conf: disk: Sanitize parsing of disk format (Peter Krempa) - conf: disk: Avoid temporary variable when parsing driver name (Peter Krempa) - conf: disk: Split out parsing of disk <driver> element (Peter Krempa) - conf: disk: Extract verification of disk config (Peter Krempa) - daemonStreamHandleRead: Rework to follow our coding pattern (Michal Privoznik) - virNet{Client,Server}*Stream: Update comment (Michal Privoznik) - daemon stream: Remove useless empty lines from header file (Michal Privoznik) - daemon stream: Convert @tx in daemonClientStream to bool (Michal Privoznik) - daemon stream: Prefer bool over unsigned int var:1 (Michal Privoznik) - daemonClientStream: Use unsigned int to store stream @serial (Michal Privoznik) - include: common: Fix function formatting (Peter Krempa) - api: Generate docs for libvirt-common.h (Peter Krempa) - apibuild: Allow completely skipping certain macros (Peter Krempa) - include: common: Fix file header for apibuild.py (Peter Krempa) - qemu: process: split out startup XML validation (Cole Robinson) - qemu: process: split out shmem startup warning (Cole Robinson) - tests: virnetdaemontest: Enable testing for no-keepalive-required (Erik Skultety) - tests: virnetdaemon: Replace tabs with spaces (Erik Skultety) - tests: remove virnetservertest data leftovers (Erik Skultety) - virsh: re-fix help printing without connection (Roman Bogorodskiy) - build: Overwrite existing symbolic links (Andrea Bolognani) - build: Add AC_PROG_LN_S to configure (Andrea Bolognani) - build: Always use $(LN_S) and $(MKDIR_P) (Andrea Bolognani) - virsh: perf: Remove unnecessary 'error' label (Peter Krempa) - examples: Try harder to uninstall nwfilter (Michal Privoznik) - nss: Try harder to uninstall (Michal Privoznik) - vz: add default input devices on post parse (Nikolay Shirokovskiy) - storage: drop the plumbing needed for kvm-img/qcow-create (Cole Robinson) - storage: remove support for /usr/bin/kvm-img (Cole Robinson) - storage: remove support for /usr/bin/qcow-create (Cole Robinson) - network: Don't use ERR_NO_SUPPORT for invalid net-update requests (Cole Robinson) - libvirt: Use conventional function names (Cole Robinson) - qemu: Cache GIC capabilities (Andrea Bolognani) - qemu: Fill in GIC capabilities (Andrea Bolognani) - conf: Expose GIC capabilities (Andrea Bolognani) - schema: Validate GIC capabilities (Andrea Bolognani) - qemu: Probe GIC capabilities (Andrea Bolognani) - conf: Get rid of virDomainCapsDevice (Andrea Bolognani) - Explicitly error on uri=qemu://system (Cole Robinson) - vz: handle sourceless cdroms (Mikhail Feoktistov) - vz: cleanup: remove trivial function (Nikolay Shirokovskiy) - vz: introduce vzsdk disk id function (Nikolay Shirokovskiy) - test: enable testing for expected parse errors in network XML (Laine Stump) - qemu: command: drop redundant min_guarantee check (Cole Robinson) - qemu: Remove redundant DomainObjIsActive calls (Cole Robinson) - security: Rename DomainSetDirLabel to DomainSetPathLabel (Martin Kletzander) - virt-admin: Introduce srv-threadpool-info and srv-threadpool-set commands (Erik Skultety) - admin: Introduce virAdmServerSetThreadPoolParameters (Erik Skultety) - admin: Introduce virAdmServerGethreadPoolParameters (Erik Skultety) - admin: Prepare admin protocol for future worker related procedures (Erik Skultety) - util: Add more getters to threadpool parameters (Erik Skultety) - util: Use a mutex when retrieving threadpool data (Erik Skultety) - util: Report system error when virThreadCreateFull fails (Erik Skultety) - util: Refactor thread creation by introducing virThreadPoolExpand (Erik Skultety) - admin: Enable usage of typed parameters (Erik Skultety) - libvirt-host: Move virTypedParam* to libvirt-common (Erik Skultety) - event-test: Enforce domain event sync (Peter Krempa) - event-test: Add VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON (Peter Krempa) - event-test: Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED (Peter Krempa) - event-test: Add VIR_DOMAIN_EVENT_ID_JOB_COMPLETED (Peter Krempa) - event-test: Add VIR_DOMAIN_EVENT_ID_MIGRATION_ITERATION callback (Peter Krempa) - event-test: Add VIR_DOMAIN_EVENT_ID_BLOCK_JOB and VIR_DOMAIN_EVENT_ID_BLOCK_JOB_2 (Peter Krempa) - event-test: make domain event registration declarative (Peter Krempa) - event-test: warn on unhandled enum values (Peter Krempa) - event-test: make few switch statements future proof (Peter Krempa) - event-test: Use switch instead of if/else if chains for lifecycle event translation (Peter Krempa) - event-test: Use typecasted enum to convert graphics event phase (Peter Krempa) - event-test: Force compiler check in switch for connectClose callback (Peter Krempa) - lib: document fields virConnectDomainEventDiskChangeReason (Peter Krempa) - event-test: Use functions with typecasted switch to convert enums (Peter Krempa) - event-test: touch up coding style (Peter Krempa) - event-test: Remove unnecessary 'usage' function (Peter Krempa) - event-test: Get rid of useless and ambiguous VIR_DEBUG macro (Peter Krempa) - event-test: Remove forward declarations (Peter Krempa) - qemu: migration: new migration param for persistent destination XML (Dmitry Andreev) - qemuMigrationCookieAddPersistent: move it out and change argument type (Dmitry Andreev) - ZFS: Support sparse volumes (Richard Laager) - libxl: use LIBXL_API_VERSION 0x040200 (Jim Fehlig) - qemu: Label master key file (Martin Kletzander) - Add functions for handling exponential backoff loops. (Richard W.M. Jones) - storage: dir: adapt .uploadVol .dowloadVol for ploop volume (Olga Krishtal) - storage: dir: adapt .refreshVol and .refreshPool for ploop volumes (Olga Krishtal) - storage: dir: .wipeVol is left unsupported for ploop volume (Olga Krishtal) - storage: dir: .resizeVol callback for ploop volume (Olga Krishtal) - storage: dir: .deleteVol callback for ploop volume (Olga Krishtal) - storage: dir: .buildVol and .buildVolFrom callbacks for ploop (Olga Krishtal) - storage: add ploop volume type (Olga Krishtal) - cfg.mk: Get rid of quotation tricks (Andrea Bolognani) - Return error when --start <number> in cpu-stats is invalid. (Nitesh Konkar) - qemu: process: Simplify condition in qemuProcessRefreshBalloonState (Peter Krempa) - qemu: driver: Reuse qemuDomainGetMonitor in qemuDomainMemoryStats (Peter Krempa) - domain: Add helper to determine presence of memory baloon (Peter Krempa) - qemu: command: Refactor memballoon command line formatting (Peter Krempa) - qemu: command: Drop obsolete comment (Peter Krempa) - qemu: caps: Deprecate QEMU_CAPS_BALLOON (Peter Krempa) - qemu: command: Assume QEMU_CAPS_DEVICE when building memballoon args (Peter Krempa) - qemu: migration: Drop dead VNC cookie handling (Cole Robinson) - makefile: Move include/Makefile.am to include/libvirt/Makefile.am (Erik Skultety) - vz: make it possible to use shared drivers API with vz driver connection (Maxim Nestratov) - qemu: support new pci controller model "pcie-expander-bus" (Laine Stump) - conf: new pci controller model pcie-expander-bus (Laine Stump) - qemu: add capabilities bit for device "pxb-pcie" (Laine Stump) - qemu: support new pci controller model "pci-expander-bus" (Laine Stump) - conf: new pci controller model pci-expander-bus (Laine Stump) - qemu: add capabilities bit for device "pxb" (Laine Stump) - qemu: set PCI controller default modelName in a separate function (Laine Stump) - conf: utility function to convert PCI controller model into connect type (Laine Stump) - conf/qemu: change the way VIR_PCI_CONNECT_TYPE_* flags work (Laine Stump) - conf: allow use of slot 0 in a dmi-to-pci-bridge (Laine Stump) - conf: use #define instead of literal for highest slot in upstream port (Laine Stump) - schema: allow pci address attributes to be in decimal (Laine Stump) - schema: new basic type - uint16 (Laine Stump) - schema: rename uint8range/uint24range to uint8/uint24 (Laine Stump) - schema: make pci slot and function optional (Laine Stump) - util: Add virGettextInitialize, convert the code (Cole Robinson) - test: genericxml2xml: test graphics listen= compat (Cole Robinson) - tests: Enable failure testing with CompareDomXML2XML (Cole Robinson) - tests: do not overwrite return value when filling qemuCapsCache (Ján Tomko) - virsh: add compression options for migration (ShaoHe Feng) - qemu: migration: support setting compession parameters (Nikolay Shirokovskiy) - qemumonitorjsontest: add test for getting multithread compress params (Eli Qiao) - qemu: monitor: add migration parameters accessors (ShaoHe Feng) - migration: qemu: add option to select compression methods (Nikolay Shirokovskiy) - virsh: support up to 64 migration options for command (Nikolay Shirokovskiy) - libxl: support creating domain with VF assignment from a pool (Chunyan Liu) - vz: simplify getting strings from vzsdk (Nikolay Shirokovskiy) - vz: minor cleanup (Maxim Nestratov) - vz: remove vzDriverLock/Unlock function (Maxim Nestratov) - vz: implement connectGetSysinfo hypervisor callback (Maxim Nestratov) - vz: fix possible vzDomainDefineXMLFlags and prlsdkNewDomainByHandle race (Maxim Nestratov) - vz: introduce new vzDriver lockable structure and use it (Maxim Nestratov) - vz: build driver as module and don't register it on client's side (Maxim Nestratov) - vz: correct iomode check (Mikhail Feoktistov) - qemuExecuteEthernetScript: move to util (Ján Tomko) - qemu: process: Wire up ACPI OST events to notify users of failed memory unplug (Peter Krempa) - qemu: monitor: Add support for ACPI_DEVICE_OST event handling (Peter Krempa) - Add VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED event (Peter Krempa) - qemu: hotplug: Add support for signalling device unplug failure (Peter Krempa) - qemu: Use domain condition for device removal signaling (Peter Krempa) - qemu: hotplug: Refactor semantics of qemuDomainWaitForDeviceRemoval (Peter Krempa) - qemu: hotplug: Properly handle errors in qemuDomainWaitForDeviceRemoval (Peter Krempa) - qemu: assign addresses before aliases (Ján Tomko) - qemuxml2argvtest: drop FLAG_EXPECT_ERROR (Ján Tomko) - tests: clean up includes (Ján Tomko) - drop qemuBuildCommandLineCallbacks (Ján Tomko) - domain_conf: call ...ListensParseXML only for appropriate graphics (Pavel Hrdina) - domain_conf: remove unused virDomainGraphicsListenGet* (Pavel Hrdina) - use virDomainGraphicsGetListen instead of the other getters (Pavel Hrdina) - domain_conf: cleanup virDomainGraphicsGetListen (Pavel Hrdina) - domain_conf: remove unused virDomainGraphicsListenSetType (Pavel Hrdina) - domain_conf: remove virDomainGraphicsListenSetNetwork (Pavel Hrdina) - domain_conf: introduce virDomainGraphicsListenAppendAddress (Pavel Hrdina) - configure: Make virt-host-validate optional (Andrea Bolognani) - tools: Reorganize conditional bits (Andrea Bolognani) - conf: extract disk geometry parsing code (Peter Krempa) - conf: Refactor virDomainDiskDefMirrorParse (Peter Krempa) - conf: disk: Split out parsing of disk mirror data (Peter Krempa) - conf: virDomainDiskDefIotuneParse: Report malformed number errors (Peter Krempa) - conf: virDomainDiskDefIotuneParse: simplify parsing (Peter Krempa) - conf: disk: Remove error label from virDomainDiskDefIotuneParse (Peter Krempa) - conf: disk: Extract iotune parsing into a separate func (Peter Krempa) - conf: disk: Remove one unnecessary level of indentation (Peter Krempa) - conf: disk: Don't initialize fields allocated by calloc (Peter Krempa) - util: Rename and move virStrIsPrint to virStringIsPrintable (Peter Krempa) - vz: add Hypervisor prefix to vz and parallels Driver structures (Maxim Nestratov) - vz: remove drivername field from vzConn structure (Maxim Nestratov) - vz: change the order of capabilities reported (Maxim Nestratov) - virsh: report when vz driver is compiled (Maxim Nestratov) - tests: fix xen-related tests (Ján Tomko) - conf: use VIR_APPEND_ELEMENT in virDomainDefAddImplicitVideo (Ján Tomko) - conf: reduce indentation in virDomainDefAddImplicitVideo (Ján Tomko) - conf: delete useless primaryVideo variable (Ján Tomko) - conf: use insertAt instead of j (Ján Tomko) - conf: use the iterator directly when parsing video devices (Ján Tomko) - conf: move default video addition after XML parsing (Ján Tomko) - cfg.mk: Use single quotes wherever possible (Andrea Bolognani) - cfg.mk: Remove spurious whitespace (Andrea Bolognani) - util: Fix 'exempt from syntax-check' comment (Andrea Bolognani) - vz: implement memory setting functions (Nikolay Shirokovskiy) - vz: factor out config update flags checks (Nikolay Shirokovskiy) - domain_conf: fix graphics parsing (Pavel Hrdina) - host-validate: Be more careful when checking for cgroup support (Andrea Bolognani) - po: Really fix po/POTFILES.in ordering (Erik Skultety) - po: fix POTFILES.in file ordering (Erik Skultety) - nss: fix typo in configure help string (Roman Bogorodskiy) - domain_conf: cleanup error paths for graphics parser (Pavel Hrdina) - domain_conf: split graphics xml parser into multiple functions (Pavel Hrdina) - domain_conf: cleanup virDomainGraphicsListensParseXML (Pavel Hrdina) - domain_conf: introduce virDomainGraphicsListensParseXML (Pavel Hrdina) - tests: remove unwanted VIR_FREE of spice and vnc default listen (Pavel Hrdina) - qemu: support virt-2.6 machine type on arm (Ján Tomko) - host-validate: Be more careful when checking for cgroup mounts (Andrea Bolognani) - qemu domain allow to set ip address, peer address and route (Vasiliy Tolstov) - lxc domain allow to set peer address (Vasiliy Tolstov) - libvirt domain xml allow to set peer address (Vasiliy Tolstov) - virnetdev allow to set peer address (Vasiliy Tolstov) - configure: Always use old_CFLAGS and old_LIBS (Andrea Bolognani) - configure: Restore CFLAGS properly after GnuTLS checks (Andrea Bolognani) - host-validate: Improve CPU flags processing (Andrea Bolognani) - vz: support boot order in domain xml dump (Nikolay Shirokovskiy) - vz: fix disk order on load domain (Nikolay Shirokovskiy) - vz: support boot order specification on define domain (Nikolay Shirokovskiy) - secret: Introduce virSecretGetSecretString (John Ferlan) - qemu: Introduce qemuBuildMasterKeyCommandLine (John Ferlan) - qemu: Create domain master key (John Ferlan) - util: Introduce virRandomBytes (John Ferlan) - qemu: Add capability bit for qemu secret object (John Ferlan) - qemu: Tear down the cgroup before reattach device to host (John Ferlan) - qemu: Restore label before reattach device to host (John Ferlan) - virt-admin: get rid of LIBVIRT_DEFAULT_ADMIN_URI env var (Ján Tomko) - tools: remove unnecessary defaultConn variable (Ján Tomko) - virsh: read default connection uri from env later (Ján Tomko) - spec: Include KVM support on RHEL 7 ppc64 and newer (Andrea Bolognani) - conf: store bootindex as unsigned int (Peter Krempa) - conf: Pass the whole device info struct to virDomainDeviceBootParseXML (Peter Krempa) - Post-release version bump to 1.3.4 (Peter Krempa) Cleanups: - Revert "qemu domain allow to set ip address, peer address and route" (Laine Stump) - Revert "lxc domain allow to set peer address" (Laine Stump) - Revert "libvirt domain xml allow to set peer address" (Laine Stump) So thanks everybody for your contributions to this release, be it with ideas, bug reports, patches, reviews or documentation, etc. Enjoy ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

4 3

[libvirt] [PATCH v2 0/9] admin: Admin API: Introduce client listing API
by Erik Skultety 03 May '16

03 May '16

v2: - gendispatch was modified to be able to generate more client related code - Martin noticed that I added avahi-related field into my tests which caused the tests to fail for him, since he doesn't compile with avahi - fixed - coverity complained that clts might be uninitialized when calling virObjectListFreeCount in virAdmServerListClients. Turned out as a false-positive, but I wanted to silence it so I reworked the logic so that the caller-supplied pointer (initialized to NULL) isn't touched until all the memory operations succeeded. That not only didn't help, but since I removed the ugly check before virObjectListFreeCount (because the method handles NULL well), coverity started to complain that I might assign a signed value to an unsigned function argument, which, although being true, is still a false positive because the pointer will be NULL and will be handled correctly. Erik Skultety (9): rpc: virnetserverclient: Identify clients by an integer ID rpc: virnetserverclient: Introduce new attribute conn_time to client admin: Introduce virAdmClient client-side object rpc: gendispatch: Tune it to support client structure rpc: virnetserver: Support retrieval of a list of clients include: admin: export connection transport constants rpc: virnetserverclient: Implement client connection transport retrieval admin: Introduce listing clients virt-admin: Introduce srv-clients-list command daemon/admin.c | 15 +++ daemon/admin_server.c | 23 ++++ daemon/admin_server.h | 4 + daemon/libvirtd.c | 4 +- include/libvirt/libvirt-admin.h | 37 ++++++ src/admin/admin_protocol.x | 29 ++++- src/admin/admin_remote.c | 6 + src/admin_protocol-structs | 19 +++ src/datatypes.c | 35 +++++ src/datatypes.h | 47 +++++++ src/libvirt-admin.c | 131 +++++++++++++++++++ src/libvirt_admin_private.syms | 3 + src/libvirt_admin_public.syms | 5 + src/libvirt_remote.syms | 2 + src/locking/lock_daemon.c | 2 +- src/logging/log_daemon.c | 2 +- src/lxc/lxc_controller.c | 2 +- src/rpc/gendispatch.pl | 75 +++++++++-- src/rpc/virnetserver.c | 64 +++++++++- src/rpc/virnetserver.h | 6 + src/rpc/virnetserverclient.c | 106 ++++++++++++++-- src/rpc/virnetserverclient.h | 10 +- tests/Makefile.am | 7 + tests/virnetdaemondata/input-data-client-ids.json | 68 ++++++++++ .../input-data-client-timestamp.json | 70 ++++++++++ .../virnetdaemondata/output-data-admin-nomdns.json | 6 + .../output-data-admin-server-names.json | 6 + .../virnetdaemondata/output-data-anon-clients.json | 3 + tests/virnetdaemondata/output-data-client-ids.json | 68 ++++++++++ .../output-data-client-timestamp.json | 70 ++++++++++ .../output-data-initial-nomdns.json | 3 + tests/virnetdaemondata/output-data-initial.json | 3 + .../output-data-no-keepalive-required.json | 6 + tests/virnetdaemonmock.c | 34 +++++ tests/virnetdaemontest.c | 13 +- tests/virnetserverclienttest.c | 2 +- tools/virt-admin.c | 141 +++++++++++++++++++++ tools/virt-admin.pod | 7 + 38 files changed, 1095 insertions(+), 39 deletions(-) create mode 100644 tests/virnetdaemondata/input-data-client-ids.json create mode 100644 tests/virnetdaemondata/input-data-client-timestamp.json create mode 100644 tests/virnetdaemondata/output-data-client-ids.json create mode 100644 tests/virnetdaemondata/output-data-client-timestamp.json create mode 100644 tests/virnetdaemonmock.c -- 2.4.11

2 15

[libvirt] [PATCH 0/2] qemu: Refresh guest's RTC on daemon restart
by Michal Privoznik 03 May '16

03 May '16

Thing is, there are is an event that we use to keep our internal state in sync with qemu. If libvirtd is not running, our internal state gets out of sync. Therefore we must refresh it as soon as we are started. Michal Privoznik (2): qemu: Introduce qemuMonitorGetRTCTime qemu: Refresh RTC adjustment on qemuProcessReconnect src/qemu/qemu_monitor.c | 11 +++++++++++ src/qemu/qemu_monitor.h | 3 +++ src/qemu/qemu_monitor_json.c | 45 ++++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 3 +++ src/qemu/qemu_process.c | 44 +++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 106 insertions(+) -- 2.8.1

2 8

[libvirt] [PATCH v2] daemon: add option to read host uuid from /etc/machine-id
by Nikolay Shirokovskiy 03 May '16

03 May '16

Daemon config parameter switch between reading host uuid either from smbios or machine-id: host_uuid_source = "smbios|machine-id" Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- difference from version 1: * move file reading function to virfile.c and generalize it * change comments and documentation as suggested by reviewer (see NOTES) NOTES Cole, I eventually found the way you suggested to document host_uuid slightly misguided. It sounds like it is applied only if dmidecode fail. So documentation is slightly different from that is your reply. daemon/libvirtd-config.c | 2 ++ daemon/libvirtd-config.h | 1 + daemon/libvirtd.c | 38 +++++++++++++++++++++++++++++++++++--- daemon/libvirtd.conf | 15 +++++++++++---- src/libvirt_private.syms | 2 ++ src/util/virfile.c | 24 ++++++++++++++++++++++++ src/util/virfile.h | 2 ++ src/util/viruuid.c | 11 ++--------- 8 files changed, 79 insertions(+), 16 deletions(-) diff --git a/daemon/libvirtd-config.c b/daemon/libvirtd-config.c index 7a448f9..45280e9 100644 --- a/daemon/libvirtd-config.c +++ b/daemon/libvirtd-config.c @@ -374,6 +374,7 @@ daemonConfigFree(struct daemonConfig *data) VIR_FREE(data->crl_file); VIR_FREE(data->host_uuid); + VIR_FREE(data->host_uuid_source); VIR_FREE(data->log_filters); VIR_FREE(data->log_outputs); @@ -463,6 +464,7 @@ daemonConfigLoadOptions(struct daemonConfig *data, GET_CONF_UINT(conf, filename, audit_logging); GET_CONF_STR(conf, filename, host_uuid); + GET_CONF_STR(conf, filename, host_uuid_source); GET_CONF_UINT(conf, filename, log_level); GET_CONF_STR(conf, filename, log_filters); diff --git a/daemon/libvirtd-config.h b/daemon/libvirtd-config.h index 3e1971d..672e9ad 100644 --- a/daemon/libvirtd-config.h +++ b/daemon/libvirtd-config.h @@ -28,6 +28,7 @@ struct daemonConfig { char *host_uuid; + char *host_uuid_source; int listen_tls; int listen_tcp; diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 7ec02ad..a489136 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1076,6 +1076,39 @@ static int migrateProfile(void) return ret; } +static int +daemonSetupHostUUID(const struct daemonConfig *config) +{ + static const char *machine_id = "/etc/machine-id"; + char buf[VIR_UUID_STRING_BUFLEN]; + const char *uuid; + + if (config->host_uuid) { + uuid = config->host_uuid; + } else if (!config->host_uuid_source || + STREQ(config->host_uuid_source, "smbios")) { + /* smbios UUID is fetched on demand in virGetHostUUID */ + return 0; + } else if (STREQ(config->host_uuid_source, "machine-id")) { + if (virFileReadBufQuiet(machine_id, buf, sizeof(buf)) < 0) { + VIR_ERROR(_("Can't read %s"), machine_id); + return -1; + } + + uuid = buf; + } else { + VIR_ERROR(_("invalid UUID source: %s"), config->host_uuid_source); + return -1; + } + + if (virSetHostUUIDStr(uuid)) { + VIR_ERROR(_("invalid host UUID: %s"), uuid); + return -1; + } + + return 0; +} + /* Print command-line usage. */ static void daemonUsage(const char *argv0, bool privileged) @@ -1295,9 +1328,8 @@ int main(int argc, char **argv) { exit(EXIT_FAILURE); } - if (config->host_uuid && - virSetHostUUIDStr(config->host_uuid) < 0) { - VIR_ERROR(_("invalid host UUID: %s"), config->host_uuid); + if (daemonSetupHostUUID(config) < 0) { + VIR_ERROR(_("Can't setup host uuid")); exit(EXIT_FAILURE); } diff --git a/daemon/libvirtd.conf b/daemon/libvirtd.conf index d2c439c..1c1fa7f 100644 --- a/daemon/libvirtd.conf +++ b/daemon/libvirtd.conf @@ -410,10 +410,16 @@ ################################################################### # UUID of the host: -# Provide the UUID of the host here in case the command -# 'dmidecode -s system-uuid' does not provide a valid uuid. In case -# 'dmidecode' does not provide a valid UUID and none is provided here, a -# temporary UUID will be generated. +# Host UUID is read from one of the sources specified in host_uuid_source. +# +# - 'smbios': fetch the UUID from 'dmidecode -s system-uuid' +# - 'machine-id': fetch the UUID from /etc/machine-id +# +# The host_uuid_source default is 'smbios'. If 'dmidecode' does not provide +# a valid UUID a temporary UUID will be generated. +# +# Another option is to specify host UUID in host_uuid. +# # Keep the format of the example UUID below. UUID must not have all digits # be the same. @@ -421,6 +427,7 @@ # it with the output of the 'uuidgen' command and then # uncomment this entry #host_uuid = "00000000-0000-0000-0000-000000000000" +#host_uuid_source = "smbios" ################################################################### # Keepalive protocol: diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 0de35ef..98e9ac5 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1510,6 +1510,7 @@ virFileOpenTty; virFilePrintf; virFileReadAll; virFileReadAllQuiet; +virFileReadBufQuiet; virFileReadHeaderFD; virFileReadLimFD; virFileRelLinkPointsTo; @@ -2537,6 +2538,7 @@ virUUIDFormat; virUUIDGenerate; virUUIDIsValid; virUUIDParse; +virUUIDRead; # util/virxml.h diff --git a/src/util/virfile.c b/src/util/virfile.c index 730c08d..4d7b510 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -1401,6 +1401,30 @@ virFileReadAllQuiet(const char *path, int maxlen, char **buf) return len; } +/* Read @file into preallocated buffer @buf of size @len. + * Return value is -errno in case of errors and size + * of data read (no trailing zero) in case of success. + * If there is more data then @len - 1 then data will be + * truncated. */ +int +virFileReadBufQuiet(const char *file, char *buf, int len) +{ + int fd; + ssize_t sz; + + fd = open(file, O_RDONLY); + if (fd < 0) + return -errno; + + sz = saferead(fd, buf, len - 1); + VIR_FORCE_CLOSE(fd); + if (sz < 0) + return -errno; + + buf[sz] = '\0'; + return sz; +} + /* Truncate @path and write @str to it. If @mode is 0, ensure that @path exists; otherwise, use @mode if @path must be created. Return 0 for success, nonzero for failure. diff --git a/src/util/virfile.h b/src/util/virfile.h index 312f226..dc62eab 100644 --- a/src/util/virfile.h +++ b/src/util/virfile.h @@ -131,6 +131,8 @@ int virFileReadAll(const char *path, int maxlen, char **buf) ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3); int virFileReadAllQuiet(const char *path, int maxlen, char **buf) ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3); +int virFileReadBufQuiet(const char *file, char *buf, int len) + ATTRIBUTE_RETURN_CHECK ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); int virFileWriteStr(const char *path, const char *str, mode_t mode) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK; diff --git a/src/util/viruuid.c b/src/util/viruuid.c index 16e57db..3cbaae0 100644 --- a/src/util/viruuid.c +++ b/src/util/viruuid.c @@ -231,15 +231,8 @@ getDMISystemUUID(char *uuid, int len) }; while (paths[i]) { - int fd = open(paths[i], O_RDONLY); - if (fd >= 0) { - if (saferead(fd, uuid, len - 1) == len - 1) { - uuid[len - 1] = '\0'; - VIR_FORCE_CLOSE(fd); - return 0; - } - VIR_FORCE_CLOSE(fd); - } + if (virFileReadBufQuiet(paths[i], uuid, len) == len - 1) + return 0; i++; } -- 1.8.3.1

2 1

[libvirt] [PATCH 0/2] virsh: Properly handle detach-interface --live --config.
by Nitesh Konkar 03 May '16

03 May '16

The virsh attach virsh detach interface command fails when both live and config are set and when the interface gets attached to different pci slots on live and config xml respectively. When we attach an interface with both --live and --config, the first time they get the same PCI slots, but the second time onwards it differs and hence the virsh detach-interface --live --config command fails. This patch makes sure that when both --live --config are set , qemuDomainDetachDeviceFlags is called twice, once with config xml and once with live xml. Steps to see the issue: virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config virsh attach-interface --domain DomainName --type network --source default --mac 52:54:00:4b:76:5f --live --config virsh detach-interface --domain DomainName --type network --mac 52:54:00:4b:76:5f --live --config Nitesh Konkar (2): virsh: Introduce virshDomainDetachInterface function virsh: Pass the corect live/config xml to virshDomainDetachInterface. tools/virsh-domain.c | 114 +++++++++++++++++++++++++++++++-------------------- 1 file changed, 69 insertions(+), 45 deletions(-) -- 1.8.3.1

2 4

[libvirt] [PATCH] ppc64: get the maxvcpus from the qemu caps instead of /dev/kvm
by Shivaprasad G Bhat 02 May '16

02 May '16

On PPC64, the KVM_MAX_VCPUS is defined to be 1024 where as qemu has MAX_CPUMASK_BITS defined at 255 in include/sysemu/sysemu.h. virsh domacapabilities and virsh maxvcpus --type kvm return different maxvcpus values and is confusing as to know what actually works. Signed-off-by: Shivaprasad G Bhat <sbhat(a)linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 28 ++++++++++++++++++++++++++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 3d0c7c8..d84fc47 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -1255,10 +1255,34 @@ static int qemuConnectIsAlive(virConnectPtr conn ATTRIBUTE_UNUSED) static int -kvmGetMaxVCPUs(void) +kvmGetMaxVCPUs(virConnectPtr conn) { int fd; int ret; + virArch arch = virArchFromHost(); + virQEMUCapsPtr qemuCaps = NULL; + virQEMUDriverPtr driver = conn->privateData; + + const char *machine; + + if (ARCH_IS_PPC64(arch)) { + if (!(qemuCaps = virQEMUCapsCacheLookupByArch(driver->qemuCapsCache, + arch))) { + virReportError(VIR_ERR_INVALID_ARG, + _("unable to find any emulator to serve '%s' " + "architecture"), virArchToString(arch)); + return -1; + } + + if (!(machine = virQEMUCapsGetDefaultMachine(qemuCaps))) { + virObjectUnref(qemuCaps); + return -1; + } + + ret = virQEMUCapsGetMachineMaxCpus(qemuCaps, machine); + virObjectUnref(qemuCaps); + return ret; + } if ((fd = open(KVM_DEVICE, O_RDONLY)) < 0) { virReportSystemError(errno, _("Unable to open %s"), KVM_DEVICE); @@ -1323,7 +1347,7 @@ qemuConnectGetMaxVcpus(virConnectPtr conn ATTRIBUTE_UNUSED, const char *type) return 16; if (STRCASEEQ(type, "kvm")) - return kvmGetMaxVCPUs(); + return kvmGetMaxVCPUs(conn); if (STRCASEEQ(type, "kqemu")) return 1;

2 1

[libvirt] [PATCH v2 0/3] Improve init script choice
by Andrea Bolognani 02 May '16

02 May '16

Changes from [v1]: * look for systemctl(1) to detect systemd instead of relying on whether or not the /etc/systemd directory is present, as suggested by Martin * use 'systemd+redhat' instead of plain 'systemd' on RHEL * move everything to a macro tucked away in a separate file Tested on Debian sid, Fedora rawhide, FreeBSD 10.3 and CentOS 6. [v1] https://www.redhat.com/archives/libvir-list/2016-April/msg01930.html Andrea Bolognani (3): configure: Improve --with-init-script=check configure: Add systemd detection to --with-init-script=check configure: Introduce LIBVIRT_{CHECK,RESULT}_INIT_SCRIPT configure.ac | 48 ++--------------------------- m4/virt-init-script.m4 | 84 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 86 insertions(+), 46 deletions(-) create mode 100644 m4/virt-init-script.m4 -- 2.5.5

2 7