- Devel - libvirt List Archives

[libvirt] [PATCH] virsh migrate: Fix positional parameters
by Jiri Denemark 21 Jun '16

21 Jun '16

Thanks to our smart option parser which automatically assigns positional parameters the following (previously working) command fails: virsh migrate test qemu+ssh://1.2.3.4/system tcp://1.2.3.4/ error: invalid argument: Unsupported compression method 'tcp://1.2.3.4/' We need to make sure new options are added at the end of the list rather than where they logically belong. Reported by Brian Rak. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- tools/virsh-domain.c | 40 ++++++++++++++++++++-------------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 02be58f..19c40b3 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -9792,26 +9792,6 @@ static const vshCmdOptDef opts_migrate[] = { .type = VSH_OT_BOOL, .help = N_("compress repeated pages during live migration") }, - {.name = "comp-methods", - .type = VSH_OT_STRING, - .help = N_("comma separated list of compression methods to be used") - }, - {.name = "comp-mt-level", - .type = VSH_OT_INT, - .help = N_("compress level for multithread compression") - }, - {.name = "comp-mt-threads", - .type = VSH_OT_INT, - .help = N_("number of compression threads for multithread compression") - }, - {.name = "comp-mt-dthreads", - .type = VSH_OT_INT, - .help = N_("number of decompression threads for multithread compression") - }, - {.name = "comp-xbzrle-cache", - .type = VSH_OT_INT, - .help = N_("page cache size for xbzrle compression") - }, {.name = "auto-converge", .type = VSH_OT_BOOL, .help = N_("force convergence during live migration") @@ -9873,6 +9853,26 @@ static const vshCmdOptDef opts_migrate[] = { .type = VSH_OT_INT, .help = N_("port to use by target server for incoming disks migration") }, + {.name = "comp-methods", + .type = VSH_OT_STRING, + .help = N_("comma separated list of compression methods to be used") + }, + {.name = "comp-mt-level", + .type = VSH_OT_INT, + .help = N_("compress level for multithread compression") + }, + {.name = "comp-mt-threads", + .type = VSH_OT_INT, + .help = N_("number of compression threads for multithread compression") + }, + {.name = "comp-mt-dthreads", + .type = VSH_OT_INT, + .help = N_("number of decompression threads for multithread compression") + }, + {.name = "comp-xbzrle-cache", + .type = VSH_OT_INT, + .help = N_("page cache size for xbzrle compression") + }, {.name = NULL} }; -- 2.9.0

3 3

[libvirt] [PATCH] conf: limit chassisNr, and busNr to a minimum value of 1, not 0
by Laine Stump 21 Jun '16

21 Jun '16

In the case of chassisNr (used to set chassis_nr of a pci-bridge controller), 0 is reserved for / used by the pci[e]-root bus. In the base of busNr, a value of 0 would mean that the root bus had no places available to plug in new buses, including the pxb itself (the documentation I wrote for pxb even noted the limit of busNr as 1.254). NB: oddly, the "chassis" attribute, which is used for pcie-root-port and pcie-switch-downstream-port *can* be set to 0, since it's the combination of {chassis, slot} that needs to be unique, not chassis by itself (and slot 0 of pcie-root is reserved, while pcie-*-port can use *only* slot 0). This resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1342962 --- docs/formatdomain.html.in | 2 +- src/conf/domain_conf.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index d181ffa..88db3bc 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -3277,7 +3277,7 @@ control QEMU's "chassis_nr" option for the pci-bridge device (normally libvirt automatically sets this to the same value as the index attribute of the pci controller). If set, chassisNr - must be between 0 and 255. + must be between 1 and 255. </dd> <dt><code>chassis</code></dt> <dd> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 23ca236..9a6610b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8426,11 +8426,11 @@ virDomainControllerDefParseXML(xmlNodePtr node, chassisNr); goto error; } - if (def->opts.pciopts.chassisNr < 0 || + if (def->opts.pciopts.chassisNr < 1 || def->opts.pciopts.chassisNr > 255) { virReportError(VIR_ERR_XML_ERROR, _("PCI controller chassisNr '%s' out of range " - "- must be 0-255"), + "- must be 1-255"), chassisNr); goto error; } @@ -8477,11 +8477,11 @@ virDomainControllerDefParseXML(xmlNodePtr node, busNr); goto error; } - if (def->opts.pciopts.busNr < 0 || + if (def->opts.pciopts.busNr < 1 || def->opts.pciopts.busNr > 254) { virReportError(VIR_ERR_XML_ERROR, _("PCI controller busNr '%s' out of range " - "- must be 0-254"), + "- must be 1-254"), busNr); goto error; } -- 2.5.5

2 1

[libvirt] [PATCH 1/1] perf: add more perf events support
by Qiaowei Ren 21 Jun '16

21 Jun '16

With current perf framework, this patch adds support to more perf events, including cache missing, cache peference, cpu cycles, instrction, etc.. Signed-off-by: Qiaowei Ren <qiaowei.ren(a)intel.com> --- include/libvirt/libvirt-domain.h | 39 ++++++++++++++++++++++++ src/libvirt-domain.c | 8 +++++ src/qemu/qemu_driver.c | 23 +++++++------- src/util/virperf.c | 65 +++++++++++++++++++++++++++++++++++++++- src/util/virperf.h | 4 +++ 5 files changed, 126 insertions(+), 13 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index cba4fa5..99c4c48 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -1928,6 +1928,45 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); */ # define VIR_PERF_PARAM_MBML "mbml" +/** + * VIR_PERF_PARAM_CACHE_MISSES: + * + * Macro for typed parameter name that represents cache_misses perf + * event which can be used to measure the amount of cache missing by + * applications running on the platform. It corresponds to the + * "perf.cache_misses" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_CACHE_MISSES "cache_misses" + +/** + * VIR_PERF_PARAM_CACHE_REFERENCES: + * + * Macro for typed parameter name that represents cache_peferences + * perf event which can be used to measure the amount of cache hit + * by applications running on the platform. It corresponds to the + * "perf.cache_peferences" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_CACHE_REFERENCES "cache_peferences" + +/** + * VIR_PERF_PARAM_INSTRUCTIONS: + * + * Macro for typed parameter name that represents instructions perf + * event which can be used to measure the amount of instructions + * by applications running on the platform. It corresponds to the + * "perf.instructions" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_INSTRUCTIONS "instructions" + +/** + * VIR_PERF_PARAM_CPU_CYCLES: + * + * Macro for typed parameter name that represents cpu_cycles perf event + * which can be used to measure how many cycles one instruction needs. + * It corresponds to the "perf.cpu_cycles" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_CPU_CYCLES "cpu_cycles" + int virDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, int *nparams, diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 73ae369..ef71b31 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11452,6 +11452,14 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * "perf.mbml" - the amount of data (bytes/s) sent through the memory controller * on the socket as unsigned long long. It is produced by mbml * perf event. + * "perf.cache_misses" - the amount of cache missing as unsigned long long. + * It is produced by cache_misses perf event. + * "perf.cache_peferences" - the amount of cache hit as unsigned long long. + * It is produced by cache_peferences perf event. + * "perf.instructions" - the amount of instructions as unsigned long long. + * It is produced by instructions perf event. + * "perf.cpu_cycles" - the amount of cycles one instruction needs as unsigned + * long long. It is produced by cpu_cycles perf event. * * Note that entire stats groups or individual stat fields may be missing from * the output in case they are not supported by the given hypervisor, are not diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 10d3e3d..d465ec5 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9756,6 +9756,10 @@ qemuDomainSetPerfEvents(virDomainPtr dom, VIR_PERF_PARAM_CMT, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_MBMT, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_MBML, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CACHE_MISSES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CACHE_REFERENCES, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_INSTRUCTIONS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_CPU_CYCLES, VIR_TYPED_PARAM_BOOLEAN, NULL) < 0) return -1; @@ -19071,10 +19075,10 @@ qemuDomainGetStatsBlock(virQEMUDriverPtr driver, #undef QEMU_ADD_COUNT_PARAM static int -qemuDomainGetStatsPerfRdt(virPerfPtr perf, - virPerfEventType type, - virDomainStatsRecordPtr record, - int *maxparams) +qemuDomainGetStatsPerfOneEvent(virPerfPtr perf, + virPerfEventType type, + virDomainStatsRecordPtr record, + int *maxparams) { char param_name[VIR_TYPED_PARAM_FIELD_LENGTH]; uint64_t value = 0; @@ -19110,14 +19114,9 @@ qemuDomainGetStatsPerf(virQEMUDriverPtr driver ATTRIBUTE_UNUSED, if (!virPerfEventIsEnabled(priv->perf, i)) continue; - switch (i) { - case VIR_PERF_EVENT_CMT: - case VIR_PERF_EVENT_MBMT: - case VIR_PERF_EVENT_MBML: - if (qemuDomainGetStatsPerfRdt(priv->perf, i, record, maxparams) < 0) - goto cleanup; - break; - } + if (qemuDomainGetStatsPerfOneEvent(priv->perf, i, + record, maxparams) < 0) + goto cleanup; } ret = 0; diff --git a/src/util/virperf.c b/src/util/virperf.c index 450b3ba..38f2158 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -38,7 +38,9 @@ VIR_LOG_INIT("util.perf"); #define VIR_FROM_THIS VIR_FROM_PERF VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST, - "cmt", "mbmt", "mbml"); + "cmt", "mbmt", "mbml", + "cache_misses", "cache_peferences", + "instructions", "cpu_cycles"); struct virPerfEvent { int type; @@ -186,6 +188,60 @@ virPerfRdtEnable(virPerfEventPtr event, return -1; } +static int +virPerfGeneralEnable(virPerfEventPtr event, + pid_t pid) +{ + struct perf_event_attr attr; + + memset(&attr, 0, sizeof(attr)); + attr.size = sizeof(attr); + attr.inherit = 1; + attr.disabled = 1; + attr.enable_on_exec = 0; + + switch (event->type) { + case VIR_PERF_EVENT_CACHE_MISSES: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_CACHE_MISSES; + break; + case VIR_PERF_EVENT_CACHE_REFERENCES: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_CACHE_REFERENCES; + break; + case VIR_PERF_EVENT_INSTRUCTIONS: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_INSTRUCTIONS; + break; + case VIR_PERF_EVENT_CPU_CYCLES: + attr.type = PERF_TYPE_HARDWARE; + attr.config = PERF_COUNT_HW_CPU_CYCLES; + break; + } + + event->fd = syscall(__NR_perf_event_open, &attr, pid, -1, -1, 0); + if (event->fd < 0) { + virReportSystemError(errno, + _("Unable to open perf event for %s"), + virPerfEventTypeToString(event->type)); + goto error; + } + + if (ioctl(event->fd, PERF_EVENT_IOC_ENABLE) < 0) { + virReportSystemError(errno, + _("Unable to enable perf event for %s"), + virPerfEventTypeToString(event->type)); + goto error; + } + + event->enabled = true; + return 0; + + error: + VIR_FORCE_CLOSE(event->fd); + return -1; +} + int virPerfEventEnable(virPerfPtr perf, virPerfEventType type, @@ -202,6 +258,13 @@ virPerfEventEnable(virPerfPtr perf, if (virPerfRdtEnable(event, pid) < 0) return -1; break; + case VIR_PERF_EVENT_CACHE_MISSES: + case VIR_PERF_EVENT_CACHE_REFERENCES: + case VIR_PERF_EVENT_INSTRUCTIONS: + case VIR_PERF_EVENT_CPU_CYCLES: + if (virPerfGeneralEnable(event, pid) < 0) + return -1; + break; case VIR_PERF_EVENT_LAST: virReportError(VIR_ERR_INTERNAL_ERROR, _("Unexpected perf event type=%d"), type); diff --git a/src/util/virperf.h b/src/util/virperf.h index 769e85a..2cab339 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -28,6 +28,10 @@ typedef enum { VIR_PERF_EVENT_CMT, VIR_PERF_EVENT_MBMT, VIR_PERF_EVENT_MBML, + VIR_PERF_EVENT_CACHE_MISSES, + VIR_PERF_EVENT_CACHE_REFERENCES, + VIR_PERF_EVENT_INSTRUCTIONS, + VIR_PERF_EVENT_CPU_CYCLES, VIR_PERF_EVENT_LAST } virPerfEventType; -- 1.9.1

3 7

[libvirt] [PATCH] storage: Fix several issues with transient pool cleanup
by Jovanka Gulicoska 20 Jun '16

20 Jun '16

There are several cases where we do not handle transient pool destroy and cleanup correctly. For example: https://bugzilla.redhat.com/show_bug.cgi?id=1227475 Move the pool cleanup logic to a new function storagePoolSetInactive and use it consistently. --- src/storage/storage_driver.c | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index e2d729f..74af35d 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -77,6 +77,21 @@ static void storageDriverUnlock(void) } static void +storagePoolSetInactive(virStoragePoolObjPtr pool) +{ + pool->active = false; + + if (pool->configFile == NULL) { + virStoragePoolObjRemove(&driver->pools, pool); + pool = NULL; + } else if (pool->newDef) { + virStoragePoolDefFree(pool->def); + pool->def = pool->newDef; + pool->newDef = NULL; + } +} + +static void storagePoolUpdateState(virStoragePoolObjPtr pool) { bool active; @@ -143,6 +158,7 @@ storagePoolUpdateAllState(void) virStoragePoolObjPtr pool = driver->pools.objs[i]; virStoragePoolObjLock(pool); + storagePoolSetInactive(pool); storagePoolUpdateState(pool); virStoragePoolObjUnlock(pool); } @@ -198,6 +214,7 @@ storageDriverAutostart(void) unlink(stateFile); if (backend->stopPool) backend->stopPool(conn, pool); + storagePoolSetInactive(pool); virReportError(VIR_ERR_INTERNAL_ERROR, _("Failed to autostart storage pool '%s': %s"), pool->def->name, virGetLastErrorMessage()); @@ -737,7 +754,7 @@ storagePoolCreateXML(virConnectPtr conn, unlink(stateFile); if (backend->stopPool) backend->stopPool(conn, pool); - virStoragePoolObjRemove(&driver->pools, pool); + storagePoolSetInactive(pool); pool = NULL; goto cleanup; } @@ -1068,16 +1085,7 @@ storagePoolDestroy(virStoragePoolPtr obj) VIR_STORAGE_POOL_EVENT_STOPPED, 0); - pool->active = false; - - if (pool->configFile == NULL) { - virStoragePoolObjRemove(&driver->pools, pool); - pool = NULL; - } else if (pool->newDef) { - virStoragePoolDefFree(pool->def); - pool->def = pool->newDef; - pool->newDef = NULL; - } + storagePoolSetInactive(pool); ret = 0; @@ -1197,13 +1205,7 @@ storagePoolRefresh(virStoragePoolPtr obj, pool->def->uuid, VIR_STORAGE_POOL_EVENT_STOPPED, 0); - pool->active = false; - - if (pool->configFile == NULL) { - virStoragePoolObjRemove(&driver->pools, pool); - pool = NULL; - } - goto cleanup; + storagePoolSetInactive(pool); } event = virStoragePoolEventLifecycleNew(pool->def->name, -- 2.5.5

2 1

[libvirt] [PATCH] virsh: introduce name-uuid for list command
by Chen Hanxiao 20 Jun '16

20 Jun '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> This patch will show both name and UUID of domain: Id Name State UUID --------------------------------------------------------------------------------------- 3 f23 running 918f1dd6-b19f-412b-ba17-d113bad89af8 Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- tools/virsh-domain-monitor.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 0a93949..32e4ea4 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -1793,6 +1793,10 @@ static const vshCmdOptDef opts_list[] = { .type = VSH_OT_BOOL, .help = N_("show domain title") }, + {.name = "name-uuid", + .type = VSH_OT_BOOL, + .help = N_("show domain name and uuid") + }, {.name = NULL} }; @@ -1807,6 +1811,7 @@ cmdList(vshControl *ctl, const vshCmd *cmd) bool optTable = vshCommandOptBool(cmd, "table"); bool optUUID = vshCommandOptBool(cmd, "uuid"); bool optName = vshCommandOptBool(cmd, "name"); + bool optNameUuid = vshCommandOptBool(cmd, "name-uuid"); size_t i; char *title; char uuid[VIR_UUID_STRING_BUFLEN]; @@ -1844,10 +1849,10 @@ cmdList(vshControl *ctl, const vshCmd *cmd) FILTER("state-shutoff", VIR_CONNECT_LIST_DOMAINS_SHUTOFF); FILTER("state-other", VIR_CONNECT_LIST_DOMAINS_OTHER); - if (optTable + optName + optUUID > 1) { + if (optTable + optName + optUUID + optNameUuid > 1) { vshError(ctl, "%s", - _("Only one argument from --table, --name and --uuid " - "may be specified.")); + _("Only one argument from --table, --name, --uuid " + "and --name-uuid may be specified.")); return false; } @@ -1864,6 +1869,12 @@ cmdList(vshControl *ctl, const vshCmd *cmd) _("Id"), _("Name"), _("State"), _("Title"), "-----------------------------------------" "-----------------------------------------"); + else if (optNameUuid) + vshPrintExtra(ctl, " %-5s %-30s %-10s %-36s\n%s\n", + _("Id"), _("Name"), _("State"), _("UUID"), + "-----------------------------------------" + "-----------------------------------------" + "----"); else vshPrintExtra(ctl, " %-5s %-30s %s\n%s\n", _("Id"), _("Name"), _("State"), @@ -1901,6 +1912,16 @@ cmdList(vshControl *ctl, const vshCmd *cmd) title); VIR_FREE(title); + } else if (optNameUuid) { + if (virDomainGetUUIDString(dom, uuid) < 0) { + vshError(ctl, "%s", _("Failed to get domain's UUID")); + goto cleanup; + } + vshPrint(ctl, " %-5s %-30s %-10s %-36s\n", id_buf, + virDomainGetName(dom), + state == -2 ? _("saved") + : virshDomainStateToString(state), + uuid); } else { vshPrint(ctl, " %-5s %-30s %s\n", id_buf, virDomainGetName(dom), -- 1.8.3.1

4 6

[libvirt] [PATCH v3 0/4] util: Make failure to get supplementary groups non-fatal
by Peter Krempa 20 Jun '16

20 Jun '16

Changes: - New patches fixing few problems in virt-login-shell found while modifying the original patch. - split out addition of @quiet - rest of review feedback Peter Krempa (4): tools: virt-login-shell: Fix group list bounds checking tools: virt-login-shell: Fix cut'n'paste mistake in error message util: Add option not to report errors in virGetUserEnt util: Make failure to get supplementary group list for a uid non-fatal src/util/virutil.c | 49 ++++++++++++++++++++++++++++-------------------- tools/virt-login-shell.c | 9 +++++---- 2 files changed, 34 insertions(+), 24 deletions(-) -- 2.8.3

3 8

[libvirt] [PATCH 0/6] Remove 'make check' heating
by Ján Tomko 20 Jun '16

20 Jun '16

https://xkcd.com/1172/ Ján Tomko (6): Remove virsh-all tests: mock gnutls_dh_params_generate2 Introduce virsh self-test Remove virsh-synopsis Drop virrandomtest Mark virsh-optparse as expensive .gitignore | 1 + tests/Makefile.am | 8 +--- tests/virnettlscontexttest.c | 2 +- tests/virnettlssessiontest.c | 2 +- tests/virrandommock.c | 51 +++++++++++++++++++++ tests/virrandomtest.c | 86 ------------------------------------ tests/virsh-optparse | 2 + tests/{virsh-all => virsh-self-test} | 31 ++++--------- tests/virsh-synopsis | 44 ------------------ tools/virsh.c | 50 +++++++++++++++++++++ 10 files changed, 115 insertions(+), 162 deletions(-) delete mode 100644 tests/virrandomtest.c rename tests/{virsh-all => virsh-self-test} (54%) delete mode 100755 tests/virsh-synopsis -- 2.7.3

2 12

[libvirt] [PATCH 0/2] Fix leak and labels in virDomainGraphicsListensParseXML
by Peter Krempa 20 Jun '16

20 Jun '16

Peter Krempa (2): conf: Fix memory leak in graphics XML parser conf: Fix label name in virDomainGraphicsListensParseXML src/conf/domain_conf.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) -- 2.8.3

2 3

[libvirt] [PATCH v2 0/7] Redirdev attach & detach
by Michal Privoznik 20 Jun '16

20 Jun '16

v2 of: https://www.redhat.com/archives/libvir-list/2016-June/msg00615.html diff to v1: - Peter's review worked in - Pushed ACKed patches - Found one silly bug (patch 7/7) Michal Privoznik (7): domain_conf: Validate redirdev after parsing virDomainRedirdevDef: Introduce find & remove routines virDomainDeviceInfoIterateInternal: Iterate through redirdevs too qemuDomainAttachDeviceConfig: Allow redirdev coldplug qemuDomainDetachDeviceConfig: Allow cold unplug of redirdevs qemuDomainRemoveDevice: Enable live redirdev detach qemuDomainDetachDeviceFlags: Pass live device XML to live detach code src/conf/domain_conf.c | 105 ++++++++++++++++++++++++++++++++++++----------- src/conf/domain_conf.h | 4 ++ src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 35 ++++++++++++---- src/qemu/qemu_hotplug.c | 76 +++++++++++++++++++++++++++++++++- src/qemu/qemu_hotplug.h | 3 ++ 6 files changed, 193 insertions(+), 32 deletions(-) -- 2.8.4

3 16

[libvirt] gnulib and 32-bit libvirt build, rpl_canonicalize_file_name
by Ian Jackson 20 Jun '16

20 Jun '16

The Xen Project's automated test (CI) system has reported a build failure in libvirt; libvirt uses gnulib. osstest has bisected it to a specific gnulib commit. (Email from osstest is quoted below.) The error message is: ../gnulib/lib/.libs/libgnu.a(canonicalize-lgpl.o): In function `rpl_canonicalize_file_name': /home/osstest/build.95966.build-i386-libvirt/libvirt/gnulib/lib/canonicalize-lgpl.c:400: multiple definition of `rpl_canonicalize_file_name' .libs/virpcimock_la-virpcimock.o:/home/osstest/build.95966.build-i386-libvirt/libvirt/tests/virpcimock.c:954: first defined here collect2: error: ld returned 1 exit status Do you already know about this ? Would you like us to submit a patch to gnulib ? Thanks, Ian. osstest service owner writes ("[qemu-upstream-4.3-testing bisection] complete build-i386-libvirt"): > branch xen-4.3-testing > xenbranch xen-4.3-testing > job build-i386-libvirt > testid libvirt-build > > Tree: libvirt git://xenbits.xen.org/libvirt.git > Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git > Tree: qemuu git://xenbits.xen.org/qemu-xen.git > Tree: xen git://xenbits.xen.org/xen.git > > *** Found and reproduced problem changeset *** > > Bug is in tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Bug introduced: 54615b95ff238e235e806855efc46a9abad09f2e > Bug not present: e78f894d0bdc770101bc040613f4ea94e45f38f7 > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/95966/ > > > commit 54615b95ff238e235e806855efc46a9abad09f2e > Author: Paul Eggert <eggert(a)cs.ucla.edu> > Date: Sat Feb 6 18:11:48 2016 -0800 > > misc: port better to gcc -fsanitize=address > > Without these patches, ./configure CFLAGS='-fsanitize=address' > would compute incorrect values. This patch fixes some (but not all) > test failures with recent glibc, with this configuration. > * m4/acl.m4 (gl_ACL_GET_FILE): > * m4/calloc.m4 (_AC_FUNC_CALLOC_IF): > * m4/canonicalize.m4 (gl_FUNC_REALPATH_WORKS): > * m4/d-ino.m4 (gl_CHECK_TYPE_STRUCT_DIRENT_D_INO): > * m4/duplocale.m4 (gl_FUNC_DUPLOCALE): > * m4/getcwd.m4 (gl_FUNC_GETCWD_NULL): > * m4/getdelim.m4 (gl_FUNC_GETDELIM): > * m4/getgroups.m4 (gl_FUNC_GETGROUPS): > * m4/getline.m4 (gl_FUNC_GETLINE): > * m4/malloc.m4 (_AC_FUNC_MALLOC_IF): > * m4/realloc.m4 (_AC_FUNC_REALLOC_IF): > * m4/regex.m4 (gl_REGEX): > * m4/strndup.m4 (gl_FUNC_STRNDUP): > * tests/test-calloc-gnu.c (main): > * tests/test-duplocale.c (main): > * tests/test-getgroups.c (main): > * tests/test-getline.c (main): > * tests/test-inttostr.c (main): > * tests/test-localename.c (test_locale_name) > (test_locale_name_thread, test_locale_name_environ) > (test_locale_name_default): > * tests/test-regex.c (main): > * tests/test-setlocale1.c (main): > * tests/test-stat.h (test_stat_func): > Free heap-allocated storage before exiting. > * m4/asm-underscore.m4 (gl_ASM_SYMBOL_PREFIX): > Don't match *_foo symbols inserted by AddressSanitizer. > * tests/test-regex.c, tests/test-stat.c: Include stdlib.h, for 'free'. > > > For bisection revision-tuple graph see: > http://logs.test-lab.xenproject.org/osstest/results/bisect/qemu-upstream-4.… > Revision IDs in each graph node refer, respectively, to the Trees above. > > ---------------------------------------- > Running cs-bisection-step --graph-out=/home/logs/results/bisect/qemu-upstream-4.3-testing/build-i386-libvirt.libvirt-build --summary-out=tmp/95966.bisection-summary --basis-template=80927 --blessings=real,real-bisect qemu-upstream-4.3-testing build-i386-libvirt libvirt-build > Searching for failure / basis pass: > 95930 fail [host=fiano0] / 80927 [host=pinot1] 80730 [host=baroque0] 77983 [host=pinot0] 77930 [host=italia0] 77853 [host=italia1] 62112 [host=nocera1] 62045 [host=nocera1] 61805 [host=nocera1] 61729 [host=nocera0] 61620 [host=pinot1] 60903 [host=nocera1] 60700 [host=nocera0] 60676 [host=nocera0] 60159 [host=italia1] 58381 [host=pinot1] 57828 [host=nocera0] 56721 [host=nocera1] 56679 [host=nocera0] 56637 [host=nocera1] 56604 [host=nocera1] 56583 [host=italia1] 56556 [host=nocera0] 56506 [host=nocera1] 56427 [host=nocera1] 56373 [host=nocera0] 55875 [host=nocera1] 50282 [host=fiano1] 36518 [host=scape-moth] 31652 [host=lace-bug] template as basis? using template as basis. > Failure / basis pass flights: 95930 / 80927 > (tree with no url: seabios) > Tree: libvirt git://xenbits.xen.org/libvirt.git > Tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git > Tree: qemuu git://xenbits.xen.org/qemu-xen.git > Tree: xen git://xenbits.xen.org/xen.git > Latest eac167e2610d3e59b32f7ec7ba78cbc8c420a425 246b3b28808ee5f4664be674dce573af9497fc7a b96625e17169a7958575c2fb41499bb9ea2c212e 12e8fccf5b5460be7aecddc71d27eceaba6e1f15 8fa31952e2d08ef63897c43b5e8b33475ebf5d93 > Basis pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 6cc32c63e80bc1a30c521b2f07f2b54909b59892 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7-… git://git.sv.gnu.org/gnulib.git#6cc32c63e80bc1a30c521b2f07f2b54909b59892-24… git://xenbits.xen.org/qemu-xen-traditional.git#b96625e17169a7958575c2fb4149… git://xenbits.xen.org/qemu-xen.git#10c1b763c26feb645627a1639e722515f3e1e876… git://xenbits.xen.org/xen.git#ac0cc84d7bdfc111d47236356e5d06b5681a1dd6-8fa3… > adhoc-revtuple-generator: tree discontiguous: libvirt > Loaded 12327 nodes in revision graph > Searching for test results: > 80730 [host=baroque0] > 80927 [host=pinot1] > 95874 fail irrelevant > 95911 fail irrelevant > 95852 fail irrelevant > 95895 fail irrelevant > 95954 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 7ac276b42cbeb648c6b11e5637b2b05be951fd6d b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95928 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 6cc32c63e80bc1a30c521b2f07f2b54909b59892 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95957 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95934 fail irrelevant > 95959 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 54615b95ff238e235e806855efc46a9abad09f2e b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95938 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 6cc32c63e80bc1a30c521b2f07f2b54909b59892 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95941 fail irrelevant > 95960 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95943 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 fa2329eeae5ae80d0630f493b029297406b47237 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 404e83e055cb419efccbcb0c5c89476307a9ae46 > 95930 fail eac167e2610d3e59b32f7ec7ba78cbc8c420a425 246b3b28808ee5f4664be674dce573af9497fc7a b96625e17169a7958575c2fb41499bb9ea2c212e 12e8fccf5b5460be7aecddc71d27eceaba6e1f15 8fa31952e2d08ef63897c43b5e8b33475ebf5d93 > 95946 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 2b34f389a8a9a6ebfd514560369d91c9f6de7751 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95962 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 54615b95ff238e235e806855efc46a9abad09f2e b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95949 fail eac167e2610d3e59b32f7ec7ba78cbc8c420a425 246b3b28808ee5f4664be674dce573af9497fc7a b96625e17169a7958575c2fb41499bb9ea2c212e 12e8fccf5b5460be7aecddc71d27eceaba6e1f15 8fa31952e2d08ef63897c43b5e8b33475ebf5d93 > 95965 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95950 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 cd9ecca8812571fc443688d11148f2768ededfa4 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95953 pass 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 cd6a45292cdb7b3c4b628f1cb0f199a02140ea7c b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > 95966 fail 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 54615b95ff238e235e806855efc46a9abad09f2e b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > Searching for interesting versions > Result found: flight 95928 (pass), for basis pass > Result found: flight 95930 (fail), for basis failure > Repro found: flight 95938 (pass), for basis pass > Repro found: flight 95949 (fail), for basis failure > 0 revisions at 6ec319b84f67d72bf59fe7e0fd41d88ee9c393c7 e78f894d0bdc770101bc040613f4ea94e45f38f7 b96625e17169a7958575c2fb41499bb9ea2c212e 10c1b763c26feb645627a1639e722515f3e1e876 ac0cc84d7bdfc111d47236356e5d06b5681a1dd6 > No revisions left to test, checking graph state. > Result found: flight 95957 (pass), for last pass > Result found: flight 95959 (fail), for first failure > Repro found: flight 95960 (pass), for last pass > Repro found: flight 95962 (fail), for first failure > Repro found: flight 95965 (pass), for last pass > Repro found: flight 95966 (fail), for first failure > > *** Found and reproduced problem changeset *** > > Bug is in tree: libvirt_gnulib git://git.sv.gnu.org/gnulib.git > Bug introduced: 54615b95ff238e235e806855efc46a9abad09f2e > Bug not present: e78f894d0bdc770101bc040613f4ea94e45f38f7 > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/95966/ > > > commit 54615b95ff238e235e806855efc46a9abad09f2e > Author: Paul Eggert <eggert(a)cs.ucla.edu> > Date: Sat Feb 6 18:11:48 2016 -0800 > > misc: port better to gcc -fsanitize=address > > Without these patches, ./configure CFLAGS='-fsanitize=address' > would compute incorrect values. This patch fixes some (but not all) > test failures with recent glibc, with this configuration. > * m4/acl.m4 (gl_ACL_GET_FILE): > * m4/calloc.m4 (_AC_FUNC_CALLOC_IF): > * m4/canonicalize.m4 (gl_FUNC_REALPATH_WORKS): > * m4/d-ino.m4 (gl_CHECK_TYPE_STRUCT_DIRENT_D_INO): > * m4/duplocale.m4 (gl_FUNC_DUPLOCALE): > * m4/getcwd.m4 (gl_FUNC_GETCWD_NULL): > * m4/getdelim.m4 (gl_FUNC_GETDELIM): > * m4/getgroups.m4 (gl_FUNC_GETGROUPS): > * m4/getline.m4 (gl_FUNC_GETLINE): > * m4/malloc.m4 (_AC_FUNC_MALLOC_IF): > * m4/realloc.m4 (_AC_FUNC_REALLOC_IF): > * m4/regex.m4 (gl_REGEX): > * m4/strndup.m4 (gl_FUNC_STRNDUP): > * tests/test-calloc-gnu.c (main): > * tests/test-duplocale.c (main): > * tests/test-getgroups.c (main): > * tests/test-getline.c (main): > * tests/test-inttostr.c (main): > * tests/test-localename.c (test_locale_name) > (test_locale_name_thread, test_locale_name_environ) > (test_locale_name_default): > * tests/test-regex.c (main): > * tests/test-setlocale1.c (main): > * tests/test-stat.h (test_stat_func): > Free heap-allocated storage before exiting. > * m4/asm-underscore.m4 (gl_ASM_SYMBOL_PREFIX): > Don't match *_foo symbols inserted by AddressSanitizer. > * tests/test-regex.c, tests/test-stat.c: Include stdlib.h, for 'free'. > > pnmtopng: 226 colors found > Revision graph left in /home/logs/results/bisect/qemu-upstream-4.3-testing/build-i386-libvirt.libvirt-build.{dot,ps,png,html,svg}. > ---------------------------------------- > 95966: tolerable ALL FAIL > > flight 95966 qemu-upstream-4.3-testing real-bisect [real] > http://logs.test-lab.xenproject.org/osstest/logs/95966/ > > Failures :-/ but no regressions. > > Tests which did not succeed, > including tests which could not be run: > build-i386-libvirt 5 libvirt-build fail baseline untested > > > jobs: > build-i386-libvirt fail > > > ------------------------------------------------------------ > sg-report-flight on osstest.test-lab.xenproject.org > logs: /home/logs/logs > images: /home/logs/images > > Logs, config files, etc. are available at > http://logs.test-lab.xenproject.org/osstest/logs > > Explanation of these reports, and of osstest in general, is at > http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master > http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master > > Test harness code can be found at > http://xenbits.xen.org/gitweb?p=osstest.git;a=summary >

2 2

[libvirt] [PATCH] util: fix a typo
by Chen Hanxiao 20 Jun '16

20 Jun '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> s/succcess/success Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/util/virfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virfile.c b/src/util/virfile.c index 9d460b9..f47bf39 100644 --- a/src/util/virfile.c +++ b/src/util/virfile.c @@ -406,7 +406,7 @@ int virFileLock(int fd, bool shared, off_t start, off_t len, bool waitForLock) * NB the lock will also be released if any open file descriptor * pointing to the same file as @fd is closed * - * Returns 0 on succcess, or -errno on error + * Returns 0 on success, or -errno on error */ int virFileUnlock(int fd, off_t start, off_t len) { -- 1.8.3.1

2 1

[libvirt] [PATCH] docs: virsh: Added note for the dump command
by jsuchane＠redhat.com 20 Jun '16

20 Jun '16

From: Jaroslav Suchanek <jsuchane(a)redhat.com> Crash dump in a old kvmdump format is being obsolete and cannot be loaded and processed by crash utility since its version 6.1.0. A --memory-only option is required in order to produce valid ELF file which can be later processed by the crash utility. A new note is added to the dump command description. --- tools/virsh.pod | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/virsh.pod b/tools/virsh.pod index 98fed76..8e3ba69 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1355,6 +1355,11 @@ B<dump> command. I<--verbose> displays the progress of dump. NOTE: Some hypervisors may require the user to manually ensure proper permissions on file and path specified by argument I<corefilepath>. +NOTE: Crash dump in a old kvmdump format is being obsolete and cannot be loaded +and processed by crash utility since its version 6.1.0. A --memory-only option +is required in order to produce valid ELF file which can be later processed by +the crash utility. + =item B<dumpxml> I<domain> [I<--inactive>] [I<--security-info>] [I<--update-cpu>] [I<--migratable>] -- 1.8.3.1

2 1

[libvirt] [PATCH 1/7] add VirtualBox 5 C API to libvirt
by Martin Pietsch 20 Jun '16

20 Jun '16

add VirtualBox 5 C API to libvirt

1 0

[libvirt] [PATCH 2/7] add VirtualBox 5 support to vbox_tmpl.c
by Martin Pietsch 20 Jun '16

20 Jun '16

add VirtualBox 5 support to vbox_tmpl.c

1 0

[libvirt] [PATCH 3/7] add VirtualBox5 support to vbox_uniformed_api.h
by Martin Pietsch 20 Jun '16

20 Jun '16

add VirtualBox5 support to vbox_uniformed_api.h

1 0

[libvirt] [PATCH 4/7] add vbox_V5_0.c for libvirt support of VirtualBox 5
by Martin Pietsch 20 Jun '16

20 Jun '16

add vbox_V5_0.c for libvirt support of VirtualBox 5

1 0

[libvirt] [PATCH 5/7] append vbox_V5_0.c and vbox_CAPI_v5_0.h to src/Makefile.am
by Martin Pietsch 20 Jun '16

20 Jun '16

append vbox_V5_0.c and vbox_CAPI_v5_0.h to src/Makefile.am

1 0

[libvirt] [PATCH 6/7] add VirtualBox 5 support to vbox_common.h
by Martin Pietsch 20 Jun '16

20 Jun '16

add VirtualBox 5 support to vbox_common.h

1 0

[libvirt] [PATCH 7/7] add VirtualBox 5 support to vbox_storage.c
by Martin Pietsch 20 Jun '16

20 Jun '16

add VirtualBox 5 support to vbox_storage.c

1 0

[libvirt] [PATCH v2] maint: Switch to xz compressed PAX release archives
by Andrea Bolognani 20 Jun '16

20 Jun '16

This allows us to produce releases that are roughly a third in size, have no limitation on path length, and are still readable by all supported platforms. --- Changes from [v1]: * Update all references to .tar.gz, including spec files, scripts and documentation (thanks Dan) * Fix typo lenght -> length (thanks Ján) [v1] https://www.redhat.com/archives/libvir-list/2016-June/msg00974.html .gitignore | 2 +- Makefile.am | 2 +- autobuild.sh | 2 +- configure.ac | 2 +- docs/compiling.html.in | 2 +- docs/downloads.html.in | 4 ++-- libvirt.spec.in | 2 +- mingw-libvirt.spec.in | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.gitignore b/.gitignore index 7fd9963..39c0423 100644 --- a/.gitignore +++ b/.gitignore @@ -88,7 +88,7 @@ /gnulib/tests/* /include/libvirt/libvirt-common.h /libtool -/libvirt-*.tar.gz +/libvirt-*.tar.xz /libvirt-[0-9]* /libvirt*.pc /libvirt.spec diff --git a/Makefile.am b/Makefile.am index da07e6c..4b4aad3 100644 --- a/Makefile.am +++ b/Makefile.am @@ -63,7 +63,7 @@ $(top_srcdir)/HACKING: $(top_srcdir)/docs/hacking1.xsl \ > $@-t && mv $@-t $@ ; fi; rpm: clean - @(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.gz) + @(unset CDPATH ; $(MAKE) dist && rpmbuild -ta $(distdir).tar.xz) check-local: all tests diff --git a/autobuild.sh b/autobuild.sh index 4d9f616..2143479 100755 --- a/autobuild.sh +++ b/autobuild.sh @@ -56,7 +56,7 @@ exec 3>&- test "$st" = 0 test -x /usr/bin/lcov && make cov -rm -f *.tar.gz +rm -f *.tar.xz make dist if test -n "$AUTOBUILD_COUNTER" ; then diff --git a/configure.ac b/configure.ac index 0114149..7d16e5a 100644 --- a/configure.ac +++ b/configure.ac @@ -24,7 +24,7 @@ AH_BOTTOM([#include <config-post.h>]) AC_CONFIG_MACRO_DIR([m4]) dnl Make automake keep quiet about wildcards & other GNUmake-isms; also keep dnl quiet about the fact that we intentionally cater to automake 1.9 -AM_INIT_AUTOMAKE([-Wno-portability -Wno-obsolete tar-ustar subdir-objects]) +AM_INIT_AUTOMAKE([-Wno-portability -Wno-obsolete tar-pax no-dist-gzip dist-xz subdir-objects]) dnl older automake's default of ARFLAGS=cru is noisy on newer binutils; dnl we don't really need the 'u' even in older toolchains. Then there is dnl older libtool, which spelled it AR_FLAGS diff --git a/docs/compiling.html.in b/docs/compiling.html.in index aff5487..d2a3f15 100644 --- a/docs/compiling.html.in +++ b/docs/compiling.html.in @@ -13,7 +13,7 @@ </p> <pre> - $ gunzip -c libvirt-x.x.x.tar.gz | tar xvf - + $ xz -c libvirt-x.x.x.tar.xz | tar xvf - $ cd libvirt-x.x.x $ ./configure</pre> diff --git a/docs/downloads.html.in b/docs/downloads.html.in index f213b29..1a3400a 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -28,8 +28,8 @@ </p> <ul> - <li><a href="ftp://libvirt.org/libvirt/libvirt-git-snapshot.tar.gz">libvirt.org FTP server</a></li> - <li><a href="http://libvirt.org/sources/libvirt-git-snapshot.tar.gz">libvirt.org HTTP server</a></li> + <li><a href="ftp://libvirt.org/libvirt/libvirt-git-snapshot.tar.xz">libvirt.org FTP server</a></li> + <li><a href="http://libvirt.org/sources/libvirt-git-snapshot.tar.xz">libvirt.org HTTP server</a></li> </ul> <h2><a name="schedule">Primary release schedule</a></h2> diff --git a/libvirt.spec.in b/libvirt.spec.in index ee6162e..6b3e888 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -225,7 +225,7 @@ URL: http://libvirt.org/ %if %(echo %{version} | grep -o \\. | wc -l) == 3 %define mainturl stable_updates/ %endif -Source: http://libvirt.org/sources/%{?mainturl}libvirt-%{version}.tar.gz +Source: http://libvirt.org/sources/%{?mainturl}libvirt-%{version}.tar.xz Requires: libvirt-daemon = %{version}-%{release} Requires: libvirt-daemon-config-network = %{version}-%{release} diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 6f95832..e808839 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -30,7 +30,7 @@ Summary: MinGW Windows libvirt virtualization library License: LGPLv2+ Group: Development/Libraries URL: http://libvirt.org/ -Source0: ftp://libvirt.org/libvirt/libvirt-%{version}.tar.gz +Source0: ftp://libvirt.org/libvirt/libvirt-%{version}.tar.xz BuildRequires: mingw32-filesystem >= 95 BuildRequires: mingw64-filesystem >= 95 -- 2.5.5

4 11

[libvirt] [PATCH] qemu: Don't use legacy USB for aarch64 mach-virt guests
by Andrea Bolognani 20 Jun '16

20 Jun '16

The '-usb' option doesn't have any effect for aarch64 mach-virt guests, so the fact that it's currently enabled by default is not really causing any issue. However, that might change in the future (although unlikely), and having it as part of the QEMU command line can cause confusion to someone looking through the process list. Avoid it completely, like it's already happening for q35. --- This requires https://www.redhat.com/archives/libvir-list/2016-June/msg01157.html to apply cleanly, but it's not really related. Applying it on top of master instead should just be a matter of fixing a few trivial merge conflicts in the test suite. CC:ing Drew for extra assurance that doing this is indeed completely safe :) src/qemu/qemu_command.c | 1 + tests/qemuxml2argvdata/qemuxml2argv-aarch64-aavmf-virtio-mmio.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-host.args | 3 +-- tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v2.args | 3 +-- tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v3.args | 3 +-- tests/qemuxml2argvdata/qemuxml2argv-aarch64-kvm-32-on-64.args | 1 - .../qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args | 1 - .../qemuxml2argv-aarch64-virtio-pci-manual-addresses.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-arm-virt-virtio.args | 1 - tests/qemuxml2argvdata/qemuxml2argv-balloon-mmio-deflate.args | 1 - 14 files changed, 4 insertions(+), 16 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4a8def1..6944129 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -2875,6 +2875,7 @@ qemuBuildControllerDevCommandLine(virCommandPtr cmd, if (usbcontroller == 0 && !qemuDomainMachineIsQ35(def) && + !qemuDomainMachineIsVirt(def) && !ARCH_IS_S390(def->os.arch)) virCommandAddArg(cmd, "-usb"); diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-aavmf-virtio-mmio.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-aavmf-virtio-mmio.args index 3f05dfb..1de2ecf 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-aavmf-virtio-mmio.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-aavmf-virtio-mmio.args @@ -22,7 +22,6 @@ QEMU_AUDIO_DRV=none \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ -device virtio-serial-device,id=virtio-serial0 \ --usb \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args index 4ae3923..b394066 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-cpu-passthrough.args @@ -17,6 +17,5 @@ QEMU_AUDIO_DRV=none \ -nodefaults \ -monitor unix:/tmp/lib/domain--1-aarch64test/monitor.sock,server,nowait \ -boot c \ --usb \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-host.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-host.args index 61ee5af..a16b8b6 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-host.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-host.args @@ -16,5 +16,4 @@ QEMU_AUDIO_DRV=none \ -nodefaults \ -monitor unix:/tmp/lib/domain--1-aarch64test/monitor.sock,server,nowait \ -no-acpi \ --boot c \ --usb +-boot c diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v2.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v2.args index d3ac955..031a31e 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v2.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v2.args @@ -16,5 +16,4 @@ QEMU_AUDIO_DRV=none \ -nodefaults \ -monitor unix:/tmp/lib/domain--1-aarch64test/monitor.sock,server,nowait \ -no-acpi \ --boot c \ --usb +-boot c diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v3.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v3.args index 27fa1f5..f078fd8 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v3.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-gic-v3.args @@ -16,5 +16,4 @@ QEMU_AUDIO_DRV=none \ -nodefaults \ -monitor unix:/tmp/lib/domain--1-aarch64test/monitor.sock,server,nowait \ -no-acpi \ --boot c \ --usb +-boot c diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-kvm-32-on-64.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-kvm-32-on-64.args index 23bb517..284aacf 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-kvm-32-on-64.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-kvm-32-on-64.args @@ -20,7 +20,6 @@ QEMU_AUDIO_DRV=none \ -kernel /arm.kernel \ -initrd /arm.initrd \ -append 'console=ttyAMA0,115200n8 rw root=/dev/vda rootwait physmap.enabled=0' \ --usb \ -drive file=/arm.raw,format=raw,if=none,id=drive-virtio-disk0 \ -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args index 3e6bee9..6c2a908 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-2.6-virtio-pci-default.args @@ -22,7 +22,6 @@ QEMU_AUDIO_DRV=none \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ -device virtio-serial-device,id=virtio-serial0 \ --usb \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args index 06a4733..ab45209 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-default-nic.args @@ -20,6 +20,5 @@ QEMU_AUDIO_DRV=none \ -kernel /aarch64.kernel \ -initrd /aarch64.initrd \ -append console=ttyAMA0 \ --usb \ -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ -net user,vlan=0,name=hostnet0 diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args index 566bee2..1ed5462 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virt-virtio.args @@ -22,7 +22,6 @@ QEMU_AUDIO_DRV=none \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ -device virtio-serial-device,id=virtio-serial0 \ --usb \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args index 566bee2..1ed5462 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-default.args @@ -22,7 +22,6 @@ QEMU_AUDIO_DRV=none \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ -device virtio-serial-device,id=virtio-serial0 \ --usb \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-virtio-disk0 \ -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-addresses.args b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-addresses.args index 4e5dbdb..8245854 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-addresses.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-aarch64-virtio-pci-manual-addresses.args @@ -25,7 +25,6 @@ QEMU_AUDIO_DRV=none \ -device pci-bridge,chassis_nr=2,id=pci.2,bus=pci.1,addr=0x0 \ -device pci-bridge,chassis_nr=3,id=pci.3,bus=pci.1,addr=0x1 \ -device virtio-scsi-pci,id=scsi0,bus=pci.3,addr=0x1 \ --usb \ -drive file=/aarch64.raw,format=raw,if=none,id=drive-scsi0-0-0-0 \ -device scsi-disk,bus=scsi0.0,channel=0,scsi-id=0,lun=0,drive=drive-scsi0-0-0-0,\ id=scsi0-0-0-0 \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-arm-virt-virtio.args b/tests/qemuxml2argvdata/qemuxml2argv-arm-virt-virtio.args index c736f60..d3e8efc 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-arm-virt-virtio.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-arm-virt-virtio.args @@ -21,7 +21,6 @@ QEMU_AUDIO_DRV=none \ -append 'console=ttyAMA0,115200n8 rw root=/dev/vda rootwait physmap.enabled=0' \ -dtb /arm.dtb \ -device virtio-serial-device,id=virtio-serial0 \ --usb \ -drive file=/arm.raw,format=raw,if=none,id=drive-virtio-disk0 \ -device virtio-blk-device,drive=drive-virtio-disk0,id=virtio-disk0 \ -device virtio-net-device,vlan=0,id=net0,mac=52:54:00:09:a4:37 \ diff --git a/tests/qemuxml2argvdata/qemuxml2argv-balloon-mmio-deflate.args b/tests/qemuxml2argvdata/qemuxml2argv-balloon-mmio-deflate.args index 0fd9107..42709c5 100644 --- a/tests/qemuxml2argvdata/qemuxml2argv-balloon-mmio-deflate.args +++ b/tests/qemuxml2argvdata/qemuxml2argv-balloon-mmio-deflate.args @@ -21,5 +21,4 @@ QEMU_AUDIO_DRV=none \ -initrd /aarch64.initrd \ -append 'earlyprintk console=ttyAMA0,115200n8 rw root=/dev/vda rootwait' \ -dtb /aarch64.dtb \ --usb \ -device virtio-balloon-device,id=balloon0,deflate-on-oom=on -- 2.5.5

3 4

Re: [libvirt] [PATCH v2 3/3] KVM: VMX: enable guest access to LMCE related MSRs
by Eduardo Habkost 20 Jun '16

20 Jun '16

On Thu, Jun 16, 2016 at 12:04:50PM +0200, Paolo Bonzini wrote: > On 16/06/2016 08:05, Haozhong Zhang wrote: > > From: Ashok Raj <ashok.raj(a)intel.com> > > > > On Intel platforms, this patch adds LMCE to KVM MCE supported > > capabilities and handles guest access to LMCE related MSRs. > > > > Signed-off-by: Ashok Raj <ashok.raj(a)intel.com> > > [Haozhong: macro KVM_MCE_CAP_SUPPORTED => variable kvm_mce_cap_supported > > Only enable LMCE on Intel platform > > Check MSR_IA32_FEATURE_CONTROL when handling guest > > access to MSR_IA32_MCG_EXT_CTL] > > Signed-off-by: Haozhong Zhang <haozhong.zhang(a)intel.com> [...] > > @@ -6433,6 +6455,8 @@ static __init int hardware_setup(void) > > > > kvm_set_posted_intr_wakeup_handler(wakeup_handler); > > > > + kvm_mce_cap_supported |= MCG_LMCE_P; > > Ah, so virtual LMCE is available on all processors! This is > interesting, but it also makes it more complicated to handle in QEMU; a > new QEMU generally doesn't require a new kernel. > > Eduardo, any ideas? (CCing libvirt list) As we shouldn't make machine-type changes introduce new host requirements, it looks like we need to either add a new set of CPU models (unreasonable), or expect management software to explicitly enable LMCE after ensuring the host supports it. Or we could wait for a reasonable time after the feature is available in the kernel, and declare that QEMU as a whole requires a newer kernel. But how much time would be reasonable for that? Long term, I believe we should think of a better solution. I don't think it is reasonable to require new libvirt code to be written for every single low-level feature that requires a newer kernel or newer host hardware. Maybe new introspection interfaces that would allow us to drop the "no new requirements on machine-type changes" rule? -- Eduardo

3 4

[libvirt] [PATCH] qemu_hotplug: Use a helper variable consistently
by Tomasz Flendrich 20 Jun '16

20 Jun '16

--- src/qemu/qemu_hotplug.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 9aca853..f695903 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -1305,7 +1305,7 @@ int qemuDomainAttachRedirdevDevice(virQEMUDriverPtr driver, char *charAlias = NULL; char *devstr = NULL; - if (qemuAssignDeviceRedirdevAlias(vm->def, redirdev, -1) < 0) + if (qemuAssignDeviceRedirdevAlias(def, redirdev, -1) < 0) goto cleanup; if (virAsprintf(&charAlias, "char%s", redirdev->info.alias) < 0) @@ -1314,7 +1314,7 @@ int qemuDomainAttachRedirdevDevice(virQEMUDriverPtr driver, if (!(devstr = qemuBuildRedirdevDevStr(def, redirdev, priv->qemuCaps))) goto cleanup; - if (VIR_REALLOC_N(vm->def->redirdevs, vm->def->nredirdevs+1) < 0) + if (VIR_REALLOC_N(def->redirdevs, def->nredirdevs+1) < 0) goto cleanup; qemuDomainObjEnterMonitor(driver, vm); @@ -1335,7 +1335,7 @@ int qemuDomainAttachRedirdevDevice(virQEMUDriverPtr driver, if (qemuDomainObjExitMonitor(driver, vm) < 0) goto audit; - vm->def->redirdevs[vm->def->nredirdevs++] = redirdev; + def->redirdevs[def->nredirdevs++] = redirdev; ret = 0; audit: virDomainAuditRedirdev(vm, redirdev, "attach", ret == 0); @@ -1514,7 +1514,7 @@ int qemuDomainAttachChrDevice(virQEMUDriverPtr driver, if (rc == 1) need_release = true; - if (qemuBuildChrDeviceStr(&devstr, vm->def, chr, priv->qemuCaps) < 0) + if (qemuBuildChrDeviceStr(&devstr, vmdef, chr, priv->qemuCaps) < 0) goto cleanup; if (virAsprintf(&charAlias, "char%s", chr->info.alias) < 0) @@ -1533,13 +1533,13 @@ int qemuDomainAttachChrDevice(virQEMUDriverPtr driver, if (qemuDomainObjExitMonitor(driver, vm) < 0) goto audit; - qemuDomainChrInsertPreAlloced(vm->def, chr); + qemuDomainChrInsertPreAlloced(vmdef, chr); ret = 0; audit: virDomainAuditChardev(vm, NULL, chr, "attach", ret == 0); cleanup: if (ret < 0 && virDomainObjIsActive(vm)) - qemuDomainChrInsertPreAllocCleanup(vm->def, chr); + qemuDomainChrInsertPreAllocCleanup(vmdef, chr); if (ret < 0 && need_release) qemuDomainReleaseDeviceAddress(vm, &chr->info, NULL); VIR_FREE(charAlias); @@ -4066,7 +4066,7 @@ int qemuDomainDetachChrDevice(virQEMUDriverPtr driver, sa_assert(tmpChr->info.alias); - if (qemuBuildChrDeviceStr(&devstr, vm->def, chr, priv->qemuCaps) < 0) + if (qemuBuildChrDeviceStr(&devstr, vmdef, chr, priv->qemuCaps) < 0) return ret; qemuDomainMarkDeviceForRemoval(vm, &tmpChr->info); -- 2.7.4 (Apple Git-66)

2 1

[libvirt] Question: forbid dnsmasq to install IPv6 default route
by Maxim Perevedentsev 18 Jun '16

18 Jun '16

Hello guys! I got into problem with installing IPv6 default gateway on centos7 guest while running dhcpv6. === Scheme === Guest has two network interfaces. *eth0* is connected to Host-Only network over virbr0. This network has dhcpv6 set up. [root@s143 ~]# virsh net-dumpxml Host-Only <network connections='1'> <name>Host-Only</name> <uuid>11aa4e6a-9014-4dae-86b9-b13159896efe</uuid> <bridge name='virbr0' stp='off' delay='0'/> <mac address='52:54:00:1e:17:49'/> <ip family='ipv4' address='10.37.130.2' prefix='24'> <dhcp> <range start='10.37.130.1' end='10.37.130.254'/> </dhcp> </ip> <ip family='ipv6' address='fdb2:2c26:f4e4::1' prefix='64'> <dhcp> <range start='fdb2:2c26:f4e4::' end='fdb2:2c26:f4e4::ffff'/> </dhcp> </ip> </network> *eth1* is connected to Bridged network over br0 bridge on host enp4s0 interface. [root@s143 ~]# virsh net-dumpxml Bridged <network connections='1'> <name>Bridged</name> <uuid>1ffa16f9-6a52-4710-9b58-52b8463cdece</uuid> <forward mode='bridge'/> <bridge name='br0'/> </network> [root@s143 ~]# virsh iface-dumpxml br0 <interface type='bridge' name='br0'> <protocol family='ipv4'> <ip address='10.94.1.161' prefix='16'/> </protocol> <protocol family='ipv6'> <ip address='2001:aaad::a5e:a28E' prefix='64'/> <ip address='fe80::be5f:f4ff:fe44:2cbb' prefix='64'/> </protocol> <bridge> <interface type='ethernet' name='vme42460d71'> <link state='unknown'/> <mac address='fe:1c:42:46:0d:71'/> </interface> <interface type='ethernet' name='enp4s0'> <link speed='1000' state='up'/> <mac address='bc:5f:f4:44:2c:bb'/> </interface> </bridge> </interface> === Problem === Now I want to set ipv6 address 2001:aaad::a5e:a28F to guest eth1 (bridged to host) and install a default route ip -6 route add default via 2001:aaad::a5e:a290 dev eth1 // metric 1024 So I want all the IPv6 traffic w/o route to go into eth1, then through host bridge to gateway (same for host and guest). The problem is that I see following in my guest: // the metric changes somehow, but this does not matter. default via fe80::5054:ff:fe1e:1749 dev eth0 proto static metric 100 pref medium default via 2001:aaad::a5e:a290 dev eth1 metric 1024 pref medium And the first (via link-local) route is preferred on routing. [root@s143 ~]# ip -6 address show dev virbr0 6: virbr0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 inet6 fdb2:2c26:f4e4::1/64 scope global valid_lft forever preferred_lft forever inet6 fe80::5054:ff:fe1e:1749/64 scope link valid_lft forever preferred_lft forever The problem is: guest:/ # radvdump # # radvd configuration generated by radvdump 2.11 # based on Router Advertisement from fe80::5054:ff:fe1e:1749 # received by interface eth0 # interface eth0 { AdvSendAdvert on; # Note: {Min,Max}RtrAdvInterval cannot be obtained with radvdump AdvManagedFlag on; AdvOtherConfigFlag on; AdvReachableTime 0; AdvRetransTimer 0; AdvCurHopLimit 64; AdvDefaultLifetime 1800; <---------------- AdvHomeAgentFlag off; AdvDefaultPreference medium; AdvLinkMTU 1500; AdvSourceLLAddress on; prefix fdb2:2c26:f4e4::/64 { AdvValidLifetime 3600; AdvPreferredLifetime 3600; AdvOnLink on; AdvAutonomous off; AdvRouterAddr off; }; # End of prefix definition RDNSS fe80::5054:ff:fe1e:1749 { AdvRDNSSLifetime 3600; }; # End of RDNSS definition }; # End of interface definition So, dnsmasq includes its link-local address into RA and announces itself as default gateway valid for 30min. Guest sees this RA and installs a route in accordance. As a result, the default gateway requested by user is overridden and thus not used. We cannot just disable RA since we still need IPv6 address on guest eth0 (dhcp6 part of functionality). === Possible solutions === I see two possible solutions. 1) Tinker with routes. As I said, the metric of installed RA routes may change and it's difficult to override them for sure (maybe with metric 0 or 1?) Moreover, this may confuse user and requires specific knowledge (IPv6, RA, etc.). 2) Forbid guest to learn default route from RA sysctl -w net.ipv6.conf.eth0.accept_ra_defrtr=0 - This should be made for all virbr-based networks. - This may confuse user as well. 3) Forbid dnsmasq to announce virbr0 link-local address as default gateway. This can be made with adding 'ra-param=*,0,0' to /var/lib/libvirt/dnsmasq/Host-Only.conf // interface=* (any), interval=0 (default), router_lifetime=0 (I am NOT you gateway, Luke). // tested on dnsmasq-2.75-3.fc22 but should work from 2.67 now the RA looks as following: linux-bnqo:/ # radvdump # # radvd configuration generated by radvdump 2.11 # based on Router Advertisement from fe80::5054:ff:fe1e:1749 # received by interface eth0 # interface eth0 { AdvSendAdvert on; # Note: {Min,Max}RtrAdvInterval cannot be obtained with radvdump AdvManagedFlag on; AdvOtherConfigFlag on; AdvReachableTime 0; AdvRetransTimer 0; AdvCurHopLimit 64; AdvDefaultLifetime 0; AdvHomeAgentFlag off; AdvDefaultPreference medium; AdvLinkMTU 1500; AdvSourceLLAddress on; prefix fdb2:2c26:f4e4::/64 { AdvValidLifetime 3600; AdvPreferredLifetime 3600; AdvOnLink on; AdvAutonomous off; AdvRouterAddr off; }; # End of prefix definition RDNSS fe80::5054:ff:fe1e:1749 { AdvRDNSSLifetime 3600; }; # End of RDNSS definition }; # End of interface definition === Conclusion ==== Please correct me if my setup itself is wrong and causes problems. Maybe there are another solutions possible, w/o modifying libvirt/guest? Would you accept patches related to 3rd solution? Looking forward to your replies. Thanks in advance! -- Your sincerely, Maxim Perevedentsev

2 1

[libvirt] [PATCH v5] virsh: Introduce virsh-pool command
by Jovanka Gulicoska 18 Jun '16

18 Jun '16

--- tools/virsh-pool.c | 184 +++++++++++++++++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 18 ++++++ 2 files changed, 202 insertions(+) diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index f9299e2..18e218c 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -32,6 +32,7 @@ #include "virfile.h" #include "conf/storage_conf.h" #include "virstring.h" +#include "virtime.h" #define VIRSH_COMMON_OPT_POOL_FULL \ VIRSH_COMMON_OPT_POOL(N_("pool name or uuid")) \ @@ -1889,6 +1890,183 @@ cmdPoolEdit(vshControl *ctl, const vshCmd *cmd) return ret; } +/* + * "pool-event" command + */ +VIR_ENUM_DECL(virshPoolEvent) +VIR_ENUM_IMPL(virshPoolEvent, + VIR_STORAGE_POOL_EVENT_LAST, + N_("Defined"), + N_("Undefined"), + N_("Started"), + N_("Stopped"), + N_("Refreshed")) + +static const char * +virshPoolEventToString(int event) +{ + const char *str = virshPoolEventTypeToString(event); + return str ? _(str) : _("unknown"); +} + +struct virshPoolEventData { + vshControl *ctl; + bool loop; + bool timestamp; + int count; +}; +typedef struct virshPoolEventData virshPoolEventData; + +VIR_ENUM_DECL(virshPoolEventId) +VIR_ENUM_IMPL(virshPoolEventId, + VIR_STORAGE_POOL_EVENT_ID_LAST, + "lifecycle") + +static void +vshEventLifecyclePrint(virConnectPtr conn ATTRIBUTE_UNUSED, + virStoragePoolPtr pool, + int event, + int detail ATTRIBUTE_UNUSED, + void *opaque) +{ + virshPoolEventData *data = opaque; + + if (!data->loop && data->count) + return; + + if (data->timestamp) { + char timestamp[VIR_TIME_STRING_BUFLEN]; + + if (virTimeStringNowRaw(timestamp) < 0) + timestamp[0] = '\0'; + + vshPrint(data->ctl, _("%s: event 'lifecycle' for storage pool %s: %s\n"), + timestamp, + virStoragePoolGetName(pool), + virshPoolEventToString(event)); + } else { + vshPrint(data->ctl, _("event 'lifecycle' for storage pool %s: %s\n"), + virStoragePoolGetName(pool), + virshPoolEventToString(event)); + } + + data->count++; + if (!data->loop) + vshEventDone(data->ctl); +} + +static const vshCmdInfo info_pool_event[] = { + {.name = "help", + .data = N_("Storage Pool Events") + }, + {.name = "desc", + .data = N_("List event types, or wait for storage pool events to occur") + }, + {.name = NULL} +}; + +static const vshCmdOptDef opts_pool_event[] = { + {.name = "pool", + .type = VSH_OT_STRING, + .help = N_("filter by storage pool name or uuid") + }, + {.name = "event", + .type = VSH_OT_STRING, + .help = N_("which event type to wait for") + }, + {.name = "loop", + .type = VSH_OT_BOOL, + .help = N_("loop until timeout or interrupt, rather than one-shot") + }, + {.name = "timeout", + .type = VSH_OT_INT, + .help = N_("timeout seconds") + }, + {.name = "list", + .type = VSH_OT_BOOL, + .help = N_("list valid event types") + }, + {.name = "timestamp", + .type = VSH_OT_BOOL, + .help = N_("show timestamp for each printed event") + }, + {.name = NULL} +}; + +static bool +cmdPoolEvent(vshControl *ctl, const vshCmd *cmd) +{ + virStoragePoolPtr pool = NULL; + bool ret = false; + int eventId = -1; + int timeout = 0; + virshPoolEventData data; + const char *eventName = NULL; + int event; + virshControlPtr priv = ctl->privData; + + if (vshCommandOptBool(cmd, "list")) { + size_t i; + + for (i = 0; i < VIR_STORAGE_POOL_EVENT_ID_LAST; i++) + vshPrint(ctl, "%s\n", virshPoolEventIdTypeToString(i)); + return true; + } + + if (vshCommandOptStringReq(ctl, cmd, "event", &eventName) < 0) + return false; + if (!eventName) { + vshError(ctl, "%s", _("either --list or event type is required")); + return false; + } + if ((event = virshPoolEventIdTypeFromString(eventName)) < 0) { + vshError(ctl, _("unknown event type %s"), eventName); + return false; + } + + data.ctl = ctl; + data.loop = vshCommandOptBool(cmd, "loop"); + data.timestamp = vshCommandOptBool(cmd, "timestamp"); + data.count = 0; + if (vshCommandOptTimeoutToMs(ctl, cmd, &timeout) < 0) + return false; + + if (vshCommandOptBool(cmd, "pool")) + pool = virshCommandOptPool(ctl, cmd, "pool", NULL); + if (vshEventStart(ctl, timeout) < 0) + goto cleanup; + + if ((eventId = virConnectStoragePoolEventRegisterAny(priv->conn, pool, event, + VIR_STORAGE_POOL_EVENT_CALLBACK(vshEventLifecyclePrint), + &data, NULL)) < 0) + goto cleanup; + switch (vshEventWait(ctl)) { + case VSH_EVENT_INTERRUPT: + vshPrint(ctl, "%s", _("event loop interrupted\n")); + break; + case VSH_EVENT_TIMEOUT: + vshPrint(ctl, "%s", _("event loop timed out\n")); + break; + case VSH_EVENT_DONE: + break; + default: + goto cleanup; + } + vshPrint(ctl, _("events received: %d\n"), data.count); + if (data.count) + ret = true; + + cleanup: + vshEventCleanup(ctl); + if (eventId >= 0 && + virConnectStoragePoolEventDeregisterAny(priv->conn, eventId) < 0) + ret = false; + if (pool) + virStoragePoolFree(pool); + return ret; +} + + const vshCmdDef storagePoolCmds[] = { {.name = "find-storage-pool-sources-as", .handler = cmdPoolDiscoverSourcesAs, @@ -2004,5 +2182,11 @@ const vshCmdDef storagePoolCmds[] = { .info = info_pool_uuid, .flags = 0 }, + {.name = "pool-event", + .handler = cmdPoolEvent, + .opts = opts_pool_event, + .info = info_pool_event, + .flags = 0 + }, {.name = NULL} }; diff --git a/tools/virsh.pod b/tools/virsh.pod index 1e56660..e530160 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3457,6 +3457,24 @@ Undefine the configuration for an inactive I<pool>. Returns the UUID of the named I<pool>. +=item B<pool-event> {[I<pool>] I<event> [I<--loop>] [I<--timeout> +I<seconds>] [I<--timestamp>] | I<--list>} + +Wait for a class of storage pool events to occur, and print appropriate +details of events as they happen. The events can optionally be filtered +by I<pool>. Using I<--list> as the only argument will provide a list +of possible I<event> values known by this client, although the connection +might not allow registering for all these events. + +By default, this command is one-shot, and returns success once an event +occurs; you can send SIGINT (usually via C<Ctrl-C>) to quit immediately. +If I<--timeout> is specified, the command gives up waiting for events +after I<seconds> have elapsed. With I<--loop>, the command prints all +events until a timeout or interrupt key. + +When I<--timestamp> is used, a human-readable timestamp will be printed +before the event. + =back =head1 VOLUME COMMANDS -- 2.5.5

2 2