- Devel - libvirt List Archives

[libvirt] [PATCH 0/3] Alter 'source' to be virDomainChrSourceDefPtr in _virDomainChrDef
by John Ferlan 21 Oct '16

21 Oct '16

Yes, it's absolutely terrifying; however, in order to "fix" problems noted during the review of the TLS chardev TCP 'properly' making the 'source' be a pointer and then moving the 'privateData' from _virDomainChrDef to _virDomainChrSourceDef will allow for setting of the 'secinfo' for the smartcard, rng, and redirdev backends that use a TCP channel. 95% of the changes obviously fell out of build issues from a 'make check syntax-check'. The remaining 5% of the changes are from sources I don't normally build; however, those were found by using cscope on the sources and finding references of "source\.{type|data|logfile|logappend} (IOW: virDomainChrSourceDef members). John Ferlan (3): vmx: Use the allocator virDomainChrDefNew Introduce virDomainChrSourceDefNew for virDomainChrDefPtr conf: Move the privateData from virDomainChrDef to virDomainChrSourceDef src/bhyve/bhyve_command.c | 8 ++--- src/bhyve/bhyve_driver.c | 2 +- src/bhyve/bhyve_parse_command.c | 20 +++++------ src/conf/domain_audit.c | 4 +-- src/conf/domain_conf.c | 53 +++++++++++++++++---------- src/conf/domain_conf.h | 4 +-- src/libxl/libxl_conf.c | 42 +++++++++++----------- src/libxl/libxl_domain.c | 22 ++++++------ src/libxl/libxl_driver.c | 4 +-- src/lxc/lxc_driver.c | 4 +-- src/lxc/lxc_native.c | 2 +- src/lxc/lxc_process.c | 6 ++-- src/qemu/qemu_cgroup.c | 2 +- src/qemu/qemu_command.c | 28 +++++++-------- src/qemu/qemu_domain.c | 16 ++++----- src/qemu/qemu_driver.c | 8 ++--- src/qemu/qemu_hotplug.c | 6 ++-- src/qemu/qemu_parse_command.c | 4 +-- src/qemu/qemu_process.c | 28 +++++++-------- src/security/security_dac.c | 4 +-- src/security/security_selinux.c | 4 +-- src/security/virt-aa-helper.c | 70 ++++++++++++++++++------------------ src/uml/uml_conf.c | 14 ++++---- src/uml/uml_driver.c | 12 +++---- src/vbox/vbox_common.c | 46 ++++++++++++------------ src/vmx/vmx.c | 78 ++++++++++++++++++++-------------------- src/vz/vz_sdk.c | 78 ++++++++++++++++++++-------------------- src/xen/xen_driver.c | 4 +-- src/xenconfig/xen_sxpr.c | 76 +++++++++++++++++++-------------------- src/xenconfig/xen_xl.c | 14 ++++---- tests/securityselinuxlabeltest.c | 14 ++++---- 31 files changed, 346 insertions(+), 331 deletions(-) -- 2.7.4

2 8

[libvirt] [PATCH 00/15] qemu: Add QMP schema introspection and use it to add gluster debug setting
by Peter Krempa 21 Oct '16

21 Oct '16

Add support for QMP schema introspection along with test data adding and fixup and use it to detect support for gluster debug setting in qemu. Thanks to Andrea and Pavel for gathering test data for me so I don't have to compile multiple qemu versions or deal with minority architectures. (I honoured them by granting them autorship on the patches) This series also includes the gluster posting from Prasanna which I've properly split, reordered and fixed. Andrea Bolognani (5): tests: qemucaps: Update ppc64 replies for qemu 2.6.0 release tests: qemucaps: Update aarch64 gicv2 replies for qemu 2.6.0 release tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on ppc64le tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on aarch64 gicv2 tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on aarch64 gicv3 Pavel Hrdina (3): tests: qemucaps: Add QMP introspection data for qemu 2.5.0 on x86 tests: qemucaps: Add QMP introspection data for qemu 2.6.0 on x86 tests: qemucaps: Add QMP introspection data for qemu 2.7.0 on x86 Peter Krempa (4): util: json: add helper to iterate and steal members of json array qemu: monitor: Add code to retrieve and store QMP schema data tests: qemucaps: Temporarily remove 'query-qmp-schema' from test data qemu: capabilities: Add support for QMP schema introspection Prasanna Kumar Kalever (3): qemu: capabilities: Detect support for gluster debug setting qemu: conf: add option for tuning debug logging level qemu: command: Add debug option for gluster volumes src/libvirt_private.syms | 1 + src/qemu/libvirtd_qemu.aug | 3 + src/qemu/qemu.conf | 20 + src/qemu/qemu_capabilities.c | 183 + src/qemu/qemu_capabilities.h | 2 + src/qemu/qemu_command.c | 19 +- src/qemu/qemu_command.h | 1 + src/qemu/qemu_conf.c | 3 + src/qemu/qemu_conf.h | 1 + src/qemu/qemu_hotplug.c | 6 +- src/qemu/qemu_monitor.c | 11 + src/qemu/qemu_monitor.h | 2 + src/qemu/qemu_monitor_json.c | 67 + src/qemu/qemu_monitor_json.h | 3 + src/util/virjson.c | 36 + src/util/virjson.h | 6 + .../qemuargv2xml-disk-drive-network-gluster.args | 7 +- .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 7545 ++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.replies | 8036 ++++++++++++++++++- .../caps_2.6.0-gicv2.aarch64.xml | 3 +- .../caps_2.6.0-gicv3.aarch64.replies | 8007 ++++++++++++++++++- .../caps_2.6.0-gicv3.aarch64.xml | 1 + .../caps_2.6.0.ppc64le.replies | 8026 ++++++++++++++++++- tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 5 +- .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 8005 +++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 8356 ++++++++++++++++++++ tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 + .../qemuxml2argv-disk-drive-network-gluster.args | 12 +- tests/qemuxml2argvtest.c | 3 +- 31 files changed, 48326 insertions(+), 48 deletions(-) 1000:1 ratio ;) -- 2.10.0

2 31

[libvirt] [PATCH] xenFormatXLDisk: Fix commas for arguments
by Michal Privoznik 21 Oct '16

21 Oct '16

instead of: virBufferAdd(buf, "arg1,"); virBufferAdd(buf, "arg2"); lets have: virBufferAdd(buf, "arg1"); virBufferAdd(buf, ",arg2"); Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/xenconfig/xen_xl.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index 742f1ef..337f9dd 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -1022,33 +1022,33 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) virBufferAddLit(&buf, "format="); switch (format) { case VIR_STORAGE_FILE_RAW: - virBufferAddLit(&buf, "raw,"); + virBufferAddLit(&buf, "raw"); break; case VIR_STORAGE_FILE_VHD: - virBufferAddLit(&buf, "xvhd,"); + virBufferAddLit(&buf, "xvhd"); break; case VIR_STORAGE_FILE_QCOW: - virBufferAddLit(&buf, "qcow,"); + virBufferAddLit(&buf, "qcow"); break; case VIR_STORAGE_FILE_QCOW2: - virBufferAddLit(&buf, "qcow2,"); + virBufferAddLit(&buf, "qcow2"); break; /* set default */ default: - virBufferAddLit(&buf, "raw,"); + virBufferAddLit(&buf, "raw"); } /* device */ - virBufferAsprintf(&buf, "vdev=%s,", disk->dst); + virBufferAsprintf(&buf, ",vdev=%s", disk->dst); /* access */ - virBufferAddLit(&buf, "access="); + virBufferAddLit(&buf, ",access="); if (disk->src->readonly) - virBufferAddLit(&buf, "ro,"); + virBufferAddLit(&buf, "ro"); else if (disk->src->shared) - virBufferAddLit(&buf, "!,"); + virBufferAddLit(&buf, "!"); else - virBufferAddLit(&buf, "rw,"); + virBufferAddLit(&buf, "rw"); if (disk->transient) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("transient disks not supported yet")); @@ -1057,18 +1057,18 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) /* backendtype */ if (driver) { - virBufferAddLit(&buf, "backendtype="); + virBufferAddLit(&buf, ",backendtype="); if (STREQ(driver, "qemu") || STREQ(driver, "file")) - virBufferAddLit(&buf, "qdisk,"); + virBufferAddLit(&buf, "qdisk"); else if (STREQ(driver, "tap")) - virBufferAddLit(&buf, "tap,"); + virBufferAddLit(&buf, "tap"); else if (STREQ(driver, "phy")) - virBufferAddLit(&buf, "phy,"); + virBufferAddLit(&buf, "phy"); } /* devtype */ if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) - virBufferAddLit(&buf, "devtype=cdrom,"); + virBufferAddLit(&buf, ",devtype=cdrom"); /* * target @@ -1082,7 +1082,7 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) goto cleanup; if (target) - virBufferAsprintf(&buf, "target=%s", target); + virBufferAsprintf(&buf, ",target=%s", target); if (virBufferCheckError(&buf) < 0) goto cleanup; -- 2.8.4

2 3

[libvirt] [PATCH 0/2] vz: add serial number to disk devices
by Nikolay Shirokovskiy 21 Oct '16

21 Oct '16

Only the first patch is really on the subject. The second one is bugfix that is included mainly because it touches the same place (and nice to have to test first patch too...) Nikolay Shirokovskiy (2): vz: add serial number to disk devices vz: set something in disk driver name src/vz/vz_sdk.c | 16 ++++++++++++++++ src/vz/vz_utils.c | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-) -- 1.8.3.1

2 5

[libvirt] [PATCH v2 0/3] qemu: util: vz: support setting disk serial number
by Maxim Nestratov 21 Oct '16

21 Oct '16

Actually this is a combination of the two previous series https://www.redhat.com/archives/libvir-list/2016-October/msg00890.html and https://www.redhat.com/archives/libvir-list/2016-September/msg01024.html Maxim Nestratov (1): util: qemu: make qemuSafeSerialParamValue function usable by other drivers Nikolay Shirokovskiy (2): vz: set something in disk driver name vz: add serial number to disk devices src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 19 +------------------ src/util/virutil.c | 16 ++++++++++++++++ src/util/virutil.h | 2 ++ src/vz/vz_sdk.c | 24 ++++++++++++++++++++++++ src/vz/vz_utils.c | 6 +++--- 6 files changed, 47 insertions(+), 21 deletions(-) -- 2.4.11

1 4

[libvirt] [PATCH] bhyve: Need to add parameter to virDomainChrDefNew
by John Ferlan 21 Oct '16

21 Oct '16

Commit id '5f2a13278' missed this one. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as build breaker https://ci.centos.org/view/libvirt-project/job/libvirt-master-build/150/sys… src/bhyve/bhyve_parse_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_parse_command.c b/src/bhyve/bhyve_parse_command.c index fd9384d..1a7de3d 100644 --- a/src/bhyve/bhyve_parse_command.c +++ b/src/bhyve/bhyve_parse_command.c @@ -287,7 +287,7 @@ bhyveParseBhyveLPCArg(virDomainDefPtr def, /* Only support com%d */ if (STRPREFIX(type, "com") && type[4] == 0) { - if (!(chr = virDomainChrDefNew())) + if (!(chr = virDomainChrDefNew(NULL))) goto error; chr->source.type = VIR_DOMAIN_CHR_TYPE_NMDM; -- 2.7.4

1 0

[libvirt] [PATCH 0/4] qemuBuildHostNetStr cleanups
by Ján Tomko 21 Oct '16

21 Oct '16

This is not a blurb. Ján Tomko (4): qemuBuildHostNetStr: use type_sep earlier qemuBuildHostNetStr: do not start options with a comma qemuBuildHostNetStr: move stray VIR_DOMAIN_NET_TYPE_INTERNAL qemuBuildHostNetStr: remove dead code src/qemu/qemu_command.c | 49 +++++++++++++++++++++---------------------------- 1 file changed, 21 insertions(+), 28 deletions(-) -- 2.7.3

2 8

[libvirt] [PATCH v10 0/4] Add native TLS encrypted chardev TCP support
by John Ferlan 21 Oct '16

21 Oct '16

v9: http://www.redhat.com/archives/libvir-list/2016-October/msg00726.html "Theorically speaking" patch #2 is "separate" from patches 1, 3, & 4. That is patch 3 and 4 are adding the secret uuid processing handling which is different than the enable/disable property logic for patch 2. I've left them all together though since just to be consistent with previous series. Differences in v10 ... Pushed the previous series 2/5 and 3/5 since they were ACK'd ... Create a new patch 1 to have helper qemuDomainSupportTLSChardevTCP It's mostly unnecessary without patch 2 though, but it made adding or "separating" patch 2 from patches 3 & 4 a whole lot easier... ... Modified former patch 1 (now patch 2) to accommodate for a paradigm where tls='yes' and chardev_tls=0 might be possible. The new helper is used to whether to add the TLS information or not. ... Modified former patch 4 (now patch 3) to accommodate for the changes Pavel has made to the code and to generate the secalias using the "charAlias" ... Modified former patch 4 (now patch 4) to use the "charAlias" as well and merge in Pavel's changes NOTE: Even though 'yes' is a now possibility, it is an option that's assuming chardev_tls=0 so I don't feel the issues raised during review of v8 regarding needing to consider a currently running 2.3.0 domain that still needs to work when 2.4.0 is applied. I believe it will be with the way the optional property is being used, thus with respect to the points in: http://www.redhat.com/archives/libvir-list/2016-October/msg00732.html The proposed qemuProcessPrepareDomain change is invalid since haveTLS is a tristate and chardevTLS is a bistate. This is what I meant about being a bit dangerous (e.g. BOOL_NO=2, BOOL_YES=1, and BOOL_ABSENT=0); however, "chardevTLS=1" is enabled (yes) and "chardevTLS=0" is disabled (absent). While it looks good when typing, when you get down to the details sometimes you find those 'gotchas'. Even if the shorthand logic were fixed, it's not going to be good to assume that setting the domain property or disabling the domain property is the desired action. The qemuProcessAttach is for qemu-attach and not the path that libvirt uses to reconnect to running domains (which is qemuProcessReconnect). There's so much broken from the qemu-attach right now - I doubt it really works at all. With respect to the reconnect processing (since that's really what you were thinking about)... There is no "options" provided/found in that code. New code could possibly "read" the '/proc/$pid/cmdline' file and look for 'tls-creds', but the only purpose of that would be to manage 'assumptions' with how the "tls='{yes|no}'" property is used. Altering virDomainChrSourceDefParseXML and virDomainChrSourceDefFormat to manage some new boolean 'tlsFromConfig' that I'm not sure could be set properly is something I think is outside these patches. John Ferlan (4): qemu: Introduce qemuDomainSupportTLSChardevTCP domain: Add optional 'tls' attribute for TCP chardev qemu: Add a secret object to/for a chardev tcp with secret qemu: Add secret object hotplug for TCP chardev TLS docs/formatdomain.html.in | 28 +++++ docs/schemas/domaincommon.rng | 5 + src/conf/domain_conf.c | 22 +++- src/conf/domain_conf.h | 1 + src/qemu/qemu_command.c | 33 ++++- src/qemu/qemu_command.h | 1 + src/qemu/qemu_domain.c | 133 ++++++++++++++++++++- src/qemu/qemu_domain.h | 18 ++- src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 58 ++++++++- src/qemu/qemu_hotplug.h | 3 +- src/qemu/qemu_process.c | 4 +- tests/qemuhotplugtest.c | 2 +- ...uxml2argv-serial-tcp-tlsx509-chardev-notls.args | 30 +++++ ...muxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 50 ++++++++ ...xml2argv-serial-tcp-tlsx509-secret-chardev.args | 38 ++++++ ...uxml2argv-serial-tcp-tlsx509-secret-chardev.xml | 50 ++++++++ tests/qemuxml2argvtest.c | 20 ++++ ...xml2xmlout-serial-tcp-tlsx509-chardev-notls.xml | 1 + tests/qemuxml2xmltest.c | 1 + 20 files changed, 483 insertions(+), 17 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-chardev-notls.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-tlsx509-secret-chardev.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-serial-tcp-tlsx509-chardev-notls.xml -- 2.7.4

2 15

[libvirt] [PATCH] vz: set localhost as vnc address
by Mikhail Feoktistov 21 Oct '16

21 Oct '16

We should set localhost as vnc address in case of empty string. Because Virtuozzo sets 0.0.0.0 as default vnc address. --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index f2a5c96..7235172 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2967,7 +2967,7 @@ static int prlsdkApplyGraphicsParams(PRL_HANDLE sdkdom, glisten = virDomainGraphicsGetListen(gr, 0); pret = PrlVmCfg_SetVNCHostName(sdkdom, glisten && glisten->address ? - glisten->address : ""); + glisten->address : "127.0.0.1"); prlsdkCheckRetGoto(pret, cleanup); ret = 0; -- 1.8.3.1

3 2

[libvirt] [PATCH v4 0/3] Forbid new-line char in name of networks
by Sławek Kapłoński 20 Oct '16

20 Oct '16

v3: http://www.redhat.com/archives/libvir-list/2016-October/msg00627.html Differences in v4: * function to check string moved from src/util/virstring to src/util/virxml Sławek Kapłoński (3): util: Add function to check if string contains some illegal chars Use new util function to check network name Forbid new-line char in name of new networks src/conf/network_conf.c | 5 +---- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 3 +++ src/util/virxml.c | 28 ++++++++++++++++++++++++++++ src/util/virxml.h | 3 +++ 5 files changed, 36 insertions(+), 4 deletions(-) -- 2.10.0

2 8

[libvirt] [PATCH 0/2] qemu: util: vz: support setting disk serial number
by Maxim Nestratov 20 Oct '16

20 Oct '16

The first patch is a preparation moving qemuSafeSerialParamValue to util, the second implements disk serial number setting in vz driver. Maxim Nestratov (2): util: qemu: make qemuSafeSerialParamValue function usable by other drivers vz: support setting disk serial number src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 19 +------------------ src/util/virutil.c | 16 ++++++++++++++++ src/util/virutil.h | 2 ++ src/vz/vz_sdk.c | 19 +++++++++++++++++++ src/vz/vz_utils.c | 5 ----- 6 files changed, 39 insertions(+), 23 deletions(-) -- 2.4.11

2 4

[libvirt] [PATCH jenkins-ci] Remove builders for Fedora 21/22 and add 24
by Daniel P. Berrange 20 Oct '16

20 Oct '16

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a CI build fix due to RPM spec dropping 21/22 projects/libosinfo.yaml | 3 +-- projects/libvirt-cim.yaml | 3 +-- projects/libvirt-glib.yaml | 3 +-- projects/libvirt-perl.yaml | 3 +-- projects/libvirt-python.yaml | 3 +-- projects/libvirt-sandbox.yaml | 3 +-- projects/libvirt-tck.yaml | 3 +-- projects/libvirt.yaml | 9 +++------ projects/osinfo-db-tools.yaml | 3 +-- projects/osinfo-db.yaml | 3 +-- projects/virt-manager.yaml | 3 +-- projects/virt-viewer.yaml | 3 +-- 12 files changed, 14 insertions(+), 28 deletions(-) diff --git a/projects/libosinfo.yaml b/projects/libosinfo.yaml index e48b6fb..49639f3 100644 --- a/projects/libosinfo.yaml +++ b/projects/libosinfo.yaml @@ -3,9 +3,8 @@ name: libosinfo machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: libosinfo make_env: | diff --git a/projects/libvirt-cim.yaml b/projects/libvirt-cim.yaml index 58cfb1a..d1705af 100644 --- a/projects/libvirt-cim.yaml +++ b/projects/libvirt-cim.yaml @@ -4,9 +4,8 @@ machines: - libvirt-centos-6 - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: libvirt CIM jobs: diff --git a/projects/libvirt-glib.yaml b/projects/libvirt-glib.yaml index 11c0ec9..38bcded 100644 --- a/projects/libvirt-glib.yaml +++ b/projects/libvirt-glib.yaml @@ -3,9 +3,8 @@ name: libvirt-glib machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt GLib jobs: diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml index d117d0f..2bad51d 100644 --- a/projects/libvirt-perl.yaml +++ b/projects/libvirt-perl.yaml @@ -3,9 +3,8 @@ name: libvirt-perl machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt Perl jobs: diff --git a/projects/libvirt-python.yaml b/projects/libvirt-python.yaml index b4c9496..baca308 100644 --- a/projects/libvirt-python.yaml +++ b/projects/libvirt-python.yaml @@ -4,9 +4,8 @@ machines: - libvirt-centos-6 - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt Python jobs: diff --git a/projects/libvirt-sandbox.yaml b/projects/libvirt-sandbox.yaml index 0dda524..eee249c 100644 --- a/projects/libvirt-sandbox.yaml +++ b/projects/libvirt-sandbox.yaml @@ -2,9 +2,8 @@ - project: name: libvirt-sandbox machines: - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt Sandbox jobs: diff --git a/projects/libvirt-tck.yaml b/projects/libvirt-tck.yaml index 3a2e555..571f3ce 100644 --- a/projects/libvirt-tck.yaml +++ b/projects/libvirt-tck.yaml @@ -2,9 +2,8 @@ - project: name: libvirt-tck machines: - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt TCK jobs: diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml index 22a46ac..20de27c 100644 --- a/projects/libvirt.yaml +++ b/projects/libvirt.yaml @@ -4,9 +4,8 @@ machines: - libvirt-centos-6 - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Libvirt archive_format: xz @@ -17,9 +16,8 @@ - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide - libvirt-freebsd - autotools-syntax-check-job: @@ -28,9 +26,8 @@ - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide check_env: | export VIR_TEST_EXPENSIVE=1 diff --git a/projects/osinfo-db-tools.yaml b/projects/osinfo-db-tools.yaml index 9414ed8..bcb63da 100644 --- a/projects/osinfo-db-tools.yaml +++ b/projects/osinfo-db-tools.yaml @@ -3,9 +3,8 @@ name: osinfo-db-tools machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: osinfo database tools jobs: diff --git a/projects/osinfo-db.yaml b/projects/osinfo-db.yaml index 941326b..f48aa3f 100644 --- a/projects/osinfo-db.yaml +++ b/projects/osinfo-db.yaml @@ -3,9 +3,8 @@ name: osinfo-db machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: osinfo database jobs: diff --git a/projects/virt-manager.yaml b/projects/virt-manager.yaml index a66a016..737e37d 100644 --- a/projects/virt-manager.yaml +++ b/projects/virt-manager.yaml @@ -3,9 +3,8 @@ name: virt-manager machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Virtual Machine Manager jobs: diff --git a/projects/virt-viewer.yaml b/projects/virt-viewer.yaml index e4ede56..d7b7108 100644 --- a/projects/virt-viewer.yaml +++ b/projects/virt-viewer.yaml @@ -3,9 +3,8 @@ name: virt-viewer machines: - libvirt-centos-7 - - libvirt-fedora-21 - - libvirt-fedora-22 - libvirt-fedora-23 + - libvirt-fedora-24 - libvirt-fedora-rawhide title: Virt Viewer jobs: -- 2.7.4

1 0

[libvirt] [PATCH] xl: don't output (null) target in domxml-to-native
by Cédric Bosdonnat 20 Oct '16

20 Oct '16

When converting a domain xml containing a CDROM device without any attached source, don't add a target=(null) to the libxl config disk definition: xen doesn't like it at all and would fail to start the domain. --- src/xenconfig/xen_xl.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c index a06983e..db8cbf1 100644 --- a/src/xenconfig/xen_xl.c +++ b/src/xenconfig/xen_xl.c @@ -1068,7 +1068,7 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) /* devtype */ if (disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM) - virBufferAddLit(&buf, "devtype=cdrom,"); + virBufferAddLit(&buf, "devtype=cdrom"); /* * target @@ -1081,7 +1081,9 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) if (xenFormatXLDiskSrc(disk->src, &target) < 0) goto cleanup; - virBufferAsprintf(&buf, "target=%s", target); + if (target) { + virBufferAsprintf(&buf, ",target=%s", target); + } if (virBufferCheckError(&buf) < 0) goto cleanup; -- 2.10.1

4 4

[libvirt] [PATCH] support auth for qemu SCSI hotplug
by Gema Gomez 20 Oct '16

20 Oct '16

Hi all, commit fceeeda2 added support for adding key objects on hotplug based on a disk's secinfo for normal drives, but missed out SCSI drives. This patch adds the same support for SCSI drives, so that it's possible to hotplug SCSI drives requiring authentication (e.g. rbd-backed drives). Cheers, Gema Gema Gomez (1): qemu: hotplug: support auth for scsi hotplug src/qemu/qemu_hotplug.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) -- 2.10.0

2 4

[libvirt] [PATCH] cpu_conf: add comments about sockets in cpu_conf
by Chen Hanxiao 19 Oct '16

19 Oct '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> 'sockets' in output of `virsh capabilities' means the sockets per NUMA node, which is a special case. discuss in: https://www.redhat.com/archives/libvir-list/2012-March/msg01123.html Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/conf/cpu_conf.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/conf/cpu_conf.h b/src/conf/cpu_conf.h index e084392..95d6b3e 100644 --- a/src/conf/cpu_conf.h +++ b/src/conf/cpu_conf.h @@ -95,15 +95,15 @@ struct _virCPUFeatureDef { typedef struct _virCPUDef virCPUDef; typedef virCPUDef *virCPUDefPtr; struct _virCPUDef { - int type; /* enum virCPUType */ - int mode; /* enum virCPUMode */ - int match; /* enum virCPUMatch */ + int type; /* enum virCPUType */ + int mode; /* enum virCPUMode */ + int match; /* enum virCPUMatch */ virArch arch; char *model; - char *vendor_id; /* vendor id returned by CPUID in the guest */ - int fallback; /* enum virCPUFallback */ + char *vendor_id; /* vendor id returned by CPUID in the guest */ + int fallback; /* enum virCPUFallback */ char *vendor; - unsigned int sockets; + unsigned int sockets; /* sockets per NUMA node */ unsigned int cores; unsigned int threads; size_t nfeatures; -- 1.8.3.1

2 2

[libvirt] [PATCH 0/3] Make UEFI firmware config simpler
by Daniel P. Berrange 19 Oct '16

19 Oct '16

This series lets apps enabled UEFI for a guest by simply doing <loader firmware='uefi'/> with the other (existing) attributes being auto-filled with correct QEMU specific defaults. Daniel P. Berrange (3): firmware: include arch and features in firmware file list conf: add support for choosing firmware type qemu: add support for simpler UEFI config docs/formatdomain.html.in | 9 ++- docs/schemas/domaincommon.rng | 12 ++- src/conf/domain_conf.c | 70 ++++++++++++++-- src/conf/domain_conf.h | 11 +++ src/libvirt_private.syms | 1 + src/qemu/qemu.conf | 14 +++- src/qemu/qemu_command.c | 6 +- src/qemu/qemu_conf.c | 12 ++- src/qemu/qemu_conf.h | 7 ++ src/qemu/qemu_domain.c | 60 ++++++++++++-- src/qemu/test_libvirtd_qemu.aug.in | 6 +- src/util/virfirmware.c | 94 +++++++++++++++++++--- src/util/virfirmware.h | 7 ++ .../qemuxml2argv-bios-firmware.args | 26 ++++++ .../qemuxml2argv-bios-firmware.xml | 41 ++++++++++ tests/qemuxml2argvtest.c | 1 + .../qemuxml2xmlout-bios-firmware.xml | 48 +++++++++++ tests/qemuxml2xmltest.c | 1 + tests/testutilsqemu.c | 30 ++++++- 19 files changed, 412 insertions(+), 44 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-bios-firmware.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-bios-firmware.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-bios-firmware.xml -- 2.7.4

4 19

[libvirt] [PATCH v2] spec: Drop support for Fedora < 23
by Andrea Bolognani 19 Oct '16

19 Oct '16

We only claim support for OSs that are still supported by the respective vendors, which means anything older than Fedora 23 is out. Reword the comment a bit to highlight the criteria. --- Changes from v1: * drop version checks that are now obsolete (thanks Dan) libvirt.spec.in | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 00b95b8..545990c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1,9 +1,10 @@ # -*- rpm-spec -*- -# This spec file assumes you are building for Fedora 20 or newer, -# or for RHEL 6 or newer. It may need some tweaks for other distros. +# This spec file assumes you are building on a Fedora or RHEL version +# that's still supported by the vendor: that means Fedora 23 or newer, +# or RHEL 6 or newer. It may need some tweaks for other distros. # If neither fedora nor rhel was defined, try to guess them from dist -%if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6) +%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6) %define supported_platform 1 %else %define supported_platform 0 @@ -167,7 +168,7 @@ %endif # Enable wireshark plugins for all distros shipping libvirt 1.2.2 or newer -%if 0%{?fedora} >= 21 +%if 0%{?fedora} %define with_wireshark 0%{!?_without_wireshark:1} %endif @@ -209,7 +210,7 @@ %if 0%{?fedora} >= 25 %define tls_priority "@LIBVIRT,SYSTEM" %else - %if 0%{?fedora} >= 21 + %if 0%{?fedora} %define tls_priority "@SYSTEM" %else %define tls_priority "NORMAL" -- 2.7.4

2 1

[libvirt] [PATCH] spec: Drop support for Fedora < 23
by Andrea Bolognani 19 Oct '16

19 Oct '16

We only claim support for OSs that are still supported by the respective vendors, which means anything older than Fedora 23 is out. Reword the comment a bit to highlight the criteria. --- libvirt.spec.in | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 00b95b8..25dc31d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1,9 +1,10 @@ # -*- rpm-spec -*- -# This spec file assumes you are building for Fedora 20 or newer, -# or for RHEL 6 or newer. It may need some tweaks for other distros. +# This spec file assumes you are building on a Fedora or RHEL version +# that's still supported by the vendor: that means Fedora 23 or newer, +# or RHEL 6 or newer. It may need some tweaks for other distros. # If neither fedora nor rhel was defined, try to guess them from dist -%if (0%{?fedora} && 0%{?fedora} >= 20) || (0%{?rhel} && 0%{?rhel} >= 6) +%if (0%{?fedora} && 0%{?fedora} >= 23) || (0%{?rhel} && 0%{?rhel} >= 6) %define supported_platform 1 %else %define supported_platform 0 -- 2.7.4

2 2

[libvirt] [PATCH v2 0/2] New libssh transport
by Pino Toscano 19 Oct '16

19 Oct '16

Hi, this series introduces a new libssh transport in libvirt, based on the libssh C library. This library supports what libssh2 does, and more: - easier API for known_hosts handling (there's a ticket upstream to request extensions for it, but what is implemented now works well) - potential GSSAPI authentication (not enabled yet because of a libssh bug [1]) - easier API for ssh-agent support The implementation for the new transport is based on the libssh2 one, hence it shares origin and style. [1] https://red.libssh.org/issues/242 Thanks, Changes from v1 to v2: - implemented keyboard interactive - code polish, and fixes Pino Toscano (2): virNetSocket: allow to not close FD libssh_transport: add new libssh-based transport config-post.h | 2 + configure.ac | 3 + include/libvirt/virterror.h | 2 + m4/virt-libssh.m4 | 26 + src/Makefile.am | 21 +- src/libvirt_libssh.syms | 22 + src/remote/remote_driver.c | 41 ++ src/rpc/virnetclient.c | 123 ++++ src/rpc/virnetclient.h | 13 + src/rpc/virnetlibsshsession.c | 1424 +++++++++++++++++++++++++++++++++++++++++ src/rpc/virnetlibsshsession.h | 80 +++ src/rpc/virnetsocket.c | 184 +++++- src/rpc/virnetsocket.h | 13 + src/util/virerror.c | 9 +- 14 files changed, 1959 insertions(+), 4 deletions(-) create mode 100644 m4/virt-libssh.m4 create mode 100644 src/libvirt_libssh.syms create mode 100644 src/rpc/virnetlibsshsession.c create mode 100644 src/rpc/virnetlibsshsession.h -- 2.7.4

3 10

[libvirt] [RFC] make virDomainQemuMonitorCommand work in any libvirt state
by Nikolay Shirokovskiy 19 Oct '16

19 Oct '16

Hi, all. We would like to use virDomainQemuMonitorCommand to query qemu independently of libvirt state. Currenly it is not possible. This API call takes job condition just like any other call and thus is unavailable on any lengthy(or stucked) synchronous job. I've already posted this question in list, just failed to find the reference. Somebody suggested to use proxy (and even an implementation) in between qemu and libvirt that can inject commands to qemu and filter replies. It is not really convinient. This way test setups will be different from production and we can not investigate problems in production environment. I'd like to drop acquiring job condition in the call as this function does not deal with libvirt state (except for the taint but is is ok, we will not mess things up here). But this is not enough, we need to make qemu monitor deal with many qemu commands simultaneously. Looks like it is quite a big change for test/debug case. But I guess eventually normal user cases can get benefits too from this monitor changes. For example all query API calls that query qemu directly can be changed to not to wait for some synchronous job finishing.(qemuDomainGetBlockJobInfo for example). Nikolay

4 4

[libvirt] [PATCH v3 0/2] Forbid new-line char in name of networks
by Sławek Kapłoński 19 Oct '16

19 Oct '16

v2: http://www.redhat.com/archives/libvir-list/2016-October/msg00451.html Differences in v3: * function to check string moved from src/util/virxml to src/util/virstring * validation if name of network contains \n char moved from parsing XML to functions responsible for create/define new networks Sławek Kapłoński (2): util: Add function to check if string contains some chars Forbid new-line char in name of new networks src/conf/network_conf.c | 2 +- src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 6 ++++++ src/util/virstring.c | 9 +++++++++ src/util/virstring.h | 1 + 5 files changed, 18 insertions(+), 1 deletion(-) -- 2.10.0

2 8

[libvirt] How libvirt address qemu command line args
by zhunxun＠gmail.com 19 Oct '16

19 Oct '16

Now I want to add some args about TPM to domain's XML,so I can start a domain by virt-manager or other virsh command,and then ,I would like to use sVIrt security context to label vTPM and correspondingVM,But I do not know how to get these XML args in libvirt. the key problem is that how can i get and recognize these args!!! related XML content : <qemu:commandline> <qemu:arg value='-enable-kvm'/> <qemu:arg value='-drive'/> <qemu:arg value='file=/root/nvram_2.0-jin.qcow2,if=none,id=nvram0-0-0,format=qcow2'/> <qemu:arg value='-device'/> <qemu:arg value='tpm-tis,tpmdev=tpm-tpm0,id=tpm0'/> <qemu:arg value='-tpmdev'/> <qemu:arg value='libtpms,id=tpm-tpm0,nvram=nvram0-0-0,startup=clear'/> <qemu:arg value='-bios'/> <qemu:arg value='/root/xenSeabios/out/bios.bin'/> </qemu:commandline> zhunxun(a)gmail.com

3 2

[libvirt] [PATCH v2 0/3] fix hot(un)plug of chardev devices with TLS encryption
by Pavel Hrdina 19 Oct '16

19 Oct '16

Pavel Hrdina (3): qemu_alias: introduce qemuAliasChardevFromDevAlias helper qemu_command: create prefixed alias to separate variable qemu: always generate the same alias for tls-creds-x509 object src/qemu/qemu_alias.c | 16 +++++++++ src/qemu/qemu_alias.h | 3 ++ src/qemu/qemu_command.c | 41 ++++++++++++---------- src/qemu/qemu_hotplug.c | 23 +++++++----- ...xml2argv-serial-tcp-tlsx509-chardev-verify.args | 4 +-- .../qemuxml2argv-serial-tcp-tlsx509-chardev.args | 4 +-- 6 files changed, 60 insertions(+), 31 deletions(-) -- 2.10.1

2 5

[libvirt] Qemu: create empty cdrom
by Gromak Yuriy 19 Oct '16

19 Oct '16

Hello. Qemu is latest from master branch. Tryingto start a domain, which is connected toa blankcdrom: <disk type='file' device='cdrom'> <driver name='qemu' type='raw'/> <target dev='sdb' bus='scsi'/> <readonly/> <address type='drive' controller='0' target='1' bus='0' unit='0'/> </disk> But I get an error: qemu-system-x86_64: -drive if=none,id=drive-scsi0-0-1-0,readonly=on,format=raw: Can't use 'raw' as a block driver for the protocol level.

3 2

[libvirt] qemu-guest-agent windows
by Umar Draz 18 Oct '16

18 Oct '16

Hello All, I have install qemu guest agent on windows 10, but unable to get the ip address using this command virsh qemu-agent-command myvm '{ "execute": "guest-network-get-interfaces" }' I am getting the following error on above command. ibvirt: QEMU Driver error : internal error: unable to execute QEMU agent command 'guest-network-get-interfaces': this feature or command is not currently supported but the same command successfully working on linux vms. Would you please help if there any other way to get the interfaces ip of windows vm Br. Umar

4 15