- Devel - libvirt List Archives

[libvirt] [PATCH v2] libvirt.spec: Build & run tests in parallel
by Michal Privoznik 03 Nov '16

03 Nov '16

So far, the main code is built in parallel, which makes it pretty fast. But with a lots of tests we have now I've noticed this part takes too much time to build. The problem was that tests were build and run in a single job. Also, 'make' in the first hunk is useless. The test suite is not built due to 'make all' because there's no .git in the sources unpacked from a tar.xz archive. It's 'make check' which triggers tests build. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v1: - Instead of fixing 'make' in the first hunk, drop it from there. libvirt.spec.in | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 545990c..5133936 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1290,7 +1290,6 @@ rm -fr %{buildroot} %check cd tests -make # These tests don't current work in a mock build root for i in nodeinfotest seclabeltest do @@ -1299,7 +1298,7 @@ do printf '#!/bin/sh\nexit 0\n' > $i chmod +x $i done -if ! make check VIR_TEST_DEBUG=1 +if ! make %{?_smp_mflags} check VIR_TEST_DEBUG=1 then cat test-suite.log || true exit 1 -- 2.8.4

3 2

[libvirt] [PATCH v4 0/7] New libssh transport
by Pino Toscano 03 Nov '16

03 Nov '16

Hi, this series introduces a new libssh transport in libvirt, based on the libssh C library. This library supports what libssh2 does, and more: - easier API for known_hosts handling (there's a ticket upstream to request extensions for it, but what is implemented now works well) - potential GSSAPI authentication (not enabled yet because of a libssh bug [1]) - easier API for ssh-agent support The implementation for the new transport is based on the libssh2 one, hence it shares origin and style. [1] https://red.libssh.org/issues/242 Thanks, Changes from v3 to v4: - integrate most of the issues spotted by Peter Krempa - add patch #3 - minor naming changes Changes from v2 to v3: - split into more commits - integrate all the issues spotted by Daniel P. Berrange and Peter Krempa - restore the specified order of authentication methods (as in libssh2) - add a related documentation fix - minor coding fixes Changes from v1 to v2: - implemented keyboard interactive - code polish, and fixes Pino Toscano (7): virNetSocket: allow to not close FD virerror: add error for libssh transport virnetsocket: improve search for default SSH key libssh_transport: add new libssh-based transport remote: expose a new libssh transport spec: enable libssh transport on Fedora docs: fix default value for sshauth option of libssh2/libssh config-post.h | 2 + configure.ac | 3 + docs/remote.html.in | 39 +- include/libvirt/virterror.h | 2 + libvirt.spec.in | 10 + m4/virt-libssh.m4 | 26 + po/POTFILES.in | 1 + src/Makefile.am | 21 +- src/libvirt_libssh.syms | 21 + src/remote/remote_driver.c | 41 ++ src/rpc/virnetclient.c | 167 ++++- src/rpc/virnetclient.h | 13 + src/rpc/virnetlibsshsession.c | 1485 +++++++++++++++++++++++++++++++++++++++++ src/rpc/virnetlibsshsession.h | 78 +++ src/rpc/virnetsocket.c | 184 ++++- src/rpc/virnetsocket.h | 13 + src/util/virerror.c | 9 +- 17 files changed, 2082 insertions(+), 33 deletions(-) create mode 100644 m4/virt-libssh.m4 create mode 100644 src/libvirt_libssh.syms create mode 100644 src/rpc/virnetlibsshsession.c create mode 100644 src/rpc/virnetlibsshsession.h -- 2.7.4

2 11

[libvirt] [PATCH] libvirt.spec: Build & run tests in parallel
by Michal Privoznik 03 Nov '16

03 Nov '16

So far, the main code is built in parallel, which makes it pretty fast. But with a lots of tests we have now I've noticed this part takes too much time to build. The problem was that tests were build and run in a single job. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 545990c..4378d0a 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1290,7 +1290,7 @@ rm -fr %{buildroot} %check cd tests -make +make %{?_smp_mflags} # These tests don't current work in a mock build root for i in nodeinfotest seclabeltest do @@ -1299,7 +1299,7 @@ do printf '#!/bin/sh\nexit 0\n' > $i chmod +x $i done -if ! make check VIR_TEST_DEBUG=1 +if ! make %{?_smp_mflags} check VIR_TEST_DEBUG=1 then cat test-suite.log || true exit 1 -- 2.8.4

2 4

[libvirt] [PATCH v2] [glib 1/5] gconfig: Allow schema to be NULL
by Zeeshan Ali 03 Nov '16

03 Nov '16

Validation (if attempted) should just fail in this case instead of crashing. --- libvirt-gconfig/libvirt-gconfig-object.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index 6225de2..851e35c 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -209,6 +209,14 @@ void gvir_config_object_validate(GVirConfigObject *config, return; } + if (!priv->schema) { + gvir_config_set_error_literal(err, + GVIR_CONFIG_OBJECT_ERROR, + 0, + _("No XML schema associated with this config object")); + return; + } + rngParser = xmlRelaxNGNewParserCtxt(priv->schema); if (!rngParser) { gvir_config_set_error(err, -- 2.9.3

2 9

[libvirt] [PATCH RFC] virhook: Adding inotify support to virhook.
by Julio Faracco 03 Nov '16

03 Nov '16

Libvirtd only support hooks when the daemon is started. Hooks cannot be loaded when the daemon is already running. So, to load a hook you need to restart the service everytime. Now, the inotify support enables the option of create a hook and run it even if libvirtd was started. Cc: Carlos Castilho <ccasti(a)br.ibm.com> Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- daemon/libvirtd.c | 1 + src/libvirt_private.syms | 1 + src/util/virhook.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++- src/util/virhook.h | 10 +++ 4 files changed, 175 insertions(+), 2 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 95c1b1c..56175d1 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -1622,6 +1622,7 @@ int main(int argc, char **argv) { 0, "shutdown", NULL, NULL); cleanup: + virHookCleanUp(); virNetlinkEventServiceStopAll(); virObjectUnref(remoteProgram); virObjectUnref(lxcProgram); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6a77e46..c8ad816 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1648,6 +1648,7 @@ virHashValueFree; virHookCall; virHookInitialize; virHookPresent; +virHookCleanUp; # util/virhostdev.h diff --git a/src/util/virhook.c b/src/util/virhook.c index facd74a..d5fc928 100644 --- a/src/util/virhook.c +++ b/src/util/virhook.c @@ -26,6 +26,7 @@ #include <sys/types.h> #include <sys/wait.h> #include <sys/stat.h> +#include <sys/inotify.h> #include <unistd.h> #include <stdlib.h> #include <stdio.h> @@ -45,6 +46,10 @@ VIR_LOG_INIT("util.hook"); #define LIBVIRT_HOOK_DIR SYSCONFDIR "/libvirt/hooks" +#define virHookInstall(driver) virHooksFound |= (1 << driver); + +#define virHookUninstall(driver) virHooksFound ^= (1 << driver); + VIR_ENUM_DECL(virHookDriver) VIR_ENUM_DECL(virHookDaemonOp) VIR_ENUM_DECL(virHookSubop) @@ -109,6 +114,8 @@ VIR_ENUM_IMPL(virHookLibxlOp, VIR_HOOK_LIBXL_OP_LAST, static int virHooksFound = -1; +static virHookInotifyPtr virHooksInotify = NULL; + /** * virHookCheck: * @driver: the driver name "daemon", "qemu", "lxc"... @@ -153,6 +160,121 @@ virHookCheck(int no, const char *driver) return ret; } +/** + * virHookInotifyEvent: + * @fd: inotify file descriptor. + * + * Identifies file events at libvirt's hook directory. + * Install or uninstall hooks on demand. Acording file manipulation. + */ +static void +virHookInotifyEvent(int watch ATTRIBUTE_UNUSED, + int fd, + int events ATTRIBUTE_UNUSED, + void *data ATTRIBUTE_UNUSED) +{ + char buf[1024]; + struct inotify_event *e; + int got; + int driver; + char *tmp, *name; + + VIR_DEBUG("inotify event in virHookInotify()"); + +reread: + got = read(fd, buf, sizeof(buf)); + if (got == -1) { + if (errno == EINTR) + goto reread; + return; + } + + tmp = buf; + while (got) { + if (got < sizeof(struct inotify_event)) + return; + + VIR_WARNINGS_NO_CAST_ALIGN + e = (struct inotify_event *)tmp; + VIR_WARNINGS_RESET + + tmp += sizeof(struct inotify_event); + got -= sizeof(struct inotify_event); + + if (got < e->len) + return; + + tmp += e->len; + got -= e->len; + + name = (char *)&(e->name); + + /* Removing hook file. */ + if (e->mask & (IN_DELETE | IN_MOVED_FROM)) { + if ((driver = virHookDriverTypeFromString(name)) < 0) { + VIR_DEBUG("Invalid hook name for %s", name); + return; + } + + virHookUninstall(driver); + } + + /* Creating hook file. */ + if (e->mask & (IN_CREATE | IN_CLOSE_WRITE | IN_MOVED_TO)) { + if ((driver = virHookDriverTypeFromString(name)) < 0) { + VIR_DEBUG("Invalid hook name for %s", name); + return; + } + + virHookInstall(driver); + } + } +} + +/** + * virHookInotifyInit: + * + * Initialize inotify hooks support. + * Enable hooks installation on demand. + * + * Returns 0 if inotify was successfully installed, -1 in case of failure. + */ +static int +virHookInotifyInit(void) { + + if (VIR_ALLOC(virHooksInotify) < 0) + goto error; + + if ((virHooksInotify->inotifyFD = inotify_init()) < 0) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("cannot initialize inotify")); + goto error; + } + + if ((virHooksInotify->inotifyWatch = + inotify_add_watch(virHooksInotify->inotifyFD, + LIBVIRT_HOOK_DIR, + IN_CREATE | IN_MODIFY | IN_DELETE)) < 0) { + virReportSystemError(errno, _("Failed to create inotify watch on %s"), + LIBVIRT_HOOK_DIR); + goto error; + } + + if ((virHooksInotify->inotifyHandler = + virEventAddHandle(virHooksInotify->inotifyFD, + VIR_EVENT_HANDLE_READABLE, + virHookInotifyEvent, NULL, NULL)) < 0) { + VIR_DEBUG("Failed to add inotify handle in virHook."); + goto error; + } + + return 0; + +error: + virHookCleanUp(); + return -1; +} + + /* * virHookInitialize: * @@ -174,10 +296,14 @@ virHookInitialize(void) return -1; if (res == 1) { - virHooksFound |= (1 << i); + virHookInstall(i); ret++; } } + + if (virHookInotifyInit() < 0) + VIR_INFO("Disabling hooks inotify support."); + return ret; } @@ -309,7 +435,12 @@ virHookCall(int driver, if (output) virCommandSetOutputBuffer(cmd, output); - ret = virCommandRun(cmd, NULL); + ret = virHookCheck(driver, virHookDriverTypeToString(driver)); + + if (ret > 0) { + ret = virCommandRun(cmd, NULL); + } + if (ret < 0) { /* Convert INTERNAL_ERROR into known error. */ virReportError(VIR_ERR_HOOK_SCRIPT_FAILED, "%s", @@ -322,3 +453,33 @@ virHookCall(int driver, return ret; } + +/** + * virHookCall: + * + * Release all structures and data used in virhooks. + * + * Returns: 0 if the execution succeeded + */ +int +virHookCleanUp(void) +{ + if (!virHooksInotify) + return -1; + + if ((virHooksInotify->inotifyFD >= 0) && + (virHooksInotify->inotifyWatch >= 0)) + if (inotify_rm_watch(virHooksInotify->inotifyFD, + virHooksInotify->inotifyWatch) < 0) + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Cannot remove inotify watcher.")); + + if (virHooksInotify->inotifyHandler >= 0) + virEventRemoveHandle(virHooksInotify->inotifyHandler); + + VIR_FORCE_CLOSE(virHooksInotify->inotifyFD); + VIR_FREE(virHooksInotify); + + virHooksFound = -1; + + return 0; +} diff --git a/src/util/virhook.h b/src/util/virhook.h index 205249c..47a32c7 100644 --- a/src/util/virhook.h +++ b/src/util/virhook.h @@ -100,6 +100,14 @@ typedef enum { VIR_HOOK_LIBXL_OP_LAST, } virHookLibxlOpType; +struct _virHookInotify { + int inotifyFD; + int inotifyWatch; + int inotifyHandler; +}; + +typedef struct _virHookInotify *virHookInotifyPtr; + int virHookInitialize(void); int virHookPresent(int driver); @@ -107,4 +115,6 @@ int virHookPresent(int driver); int virHookCall(int driver, const char *id, int op, int sub_op, const char *extra, const char *input, char **output); +int virHookCleanUp(void); + #endif /* __VIR_HOOKS_H__ */ -- 2.7.4

2 4

[libvirt] [PATCH] docs: Add Qt Virtual machines manager and Qt Remote viewer
by F1ash 03 Nov '16

03 Nov '16

From: Alexander Vasilenko <kaperang07(a)gmail.com> --- docs/apps.html.in | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/apps.html.in b/docs/apps.html.in index 1a138b3..4efb318 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -208,6 +208,17 @@ to remote consoles supporting the VNC protocol. Also provides an optional mozilla browser plugin. </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager">qt-virt-manager</a></dt> + <dd> + The Qt GUI for create and control VMs and another virtual entities + (aka networks, storages, interfaces, secrets, network filters). + Contains integrated LXC/SPICE/VNC viewer for accessing the graphical or + text console associated with a virtual machine or container. + </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager/#virtual-machines-viewer">qt-remote-viewer</a></dt> + <dd> + The Qt VNC/SPICE viewer for access to remote desktops or VMs. + </dd> </dl> <h2><a name="iaas">Infrastructure as a Service (IaaS)</a></h2> -- 2.10.1

1 0

[libvirt] [glib 1/5] gconfig: Allow schema to be NULL
by Zeeshan Ali 03 Nov '16

03 Nov '16

Validation (if attempted) should just fail in this case instead of crashing. --- libvirt-gconfig/libvirt-gconfig-object.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-object.c b/libvirt-gconfig/libvirt-gconfig-object.c index 6225de2..851e35c 100644 --- a/libvirt-gconfig/libvirt-gconfig-object.c +++ b/libvirt-gconfig/libvirt-gconfig-object.c @@ -209,6 +209,14 @@ void gvir_config_object_validate(GVirConfigObject *config, return; } + if (!priv->schema) { + gvir_config_set_error_literal(err, + GVIR_CONFIG_OBJECT_ERROR, + 0, + _("No XML schema associated with this config object")); + return; + } + rngParser = xmlRelaxNGNewParserCtxt(priv->schema); if (!rngParser) { gvir_config_set_error(err, -- 2.9.3

3 13

[libvirt] [PATCH] qemu: Reset post-copy capability after migration
by Jiri Denemark 02 Nov '16

02 Nov '16

Unlike other migration capabilities, post-copy is also set on the destination host which means it doesn't disappear once domain is migrated. As a result of that other functionality which internally uses migration to a file (virDomainManagedSave, virDomainSave, virDomainCoreDump) may fail after migration because the post-copy capability is still set. https://bugzilla.redhat.com/show_bug.cgi?id=1374718 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Notes: We need a more generic way to store and reset migration capabilities and parameters on both sides of migration since we need to reset them in case migration fails. But it will need a little bit more work, so let's start with this simple patch fixing the most visible issue. I'll work on the generic solution later. src/qemu/qemu_migration.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 1c4a80c..d4a55d8 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -6418,6 +6418,9 @@ qemuMigrationFinish(virQEMUDriverPtr driver, */ if (inPostCopy) VIR_FREE(priv->job.completed); + + qemuMigrationSetPostCopy(driver, vm, false, + QEMU_ASYNC_JOB_MIGRATION_IN); } qemuMigrationJobFinish(driver, vm); -- 2.10.2

2 2

[libvirt] [python PATCH] Post-release version bump to 2.5.0
by Pavel Hrdina 02 Nov '16

02 Nov '16

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed as trivial. setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 683dc93..ed11e2e 100755 --- a/setup.py +++ b/setup.py @@ -307,7 +307,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '2.4.0', + version = '2.5.0', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.10.2

1 0

[libvirt] pci-assign fails with read error on config-space file
by Henning Schild 02 Nov '16

02 Nov '16

Hey, i am running an unusual setup where i assign pci devices behind the back of libvirt. I have two options to do that: 1. a wrapper script for qemu that takes care of suid-root and appends arguments for pci-assign 2. virsh qemu-monitor-command ... 'device_add pci-assign...' I know i should probably not be doing this, it is a workaround to introduce fine-grained pci-assignment in an openstack setup, where vendor and device id are not enough to pick the right device for a vm. In both cases qemu will crash with the following output: > qemu: hardware error: pci read failed, ret = 0 errno = 22 followed by the usual machine state dump. With strace i found it to be a failing read on the config space file of my device. /sys/bus/pci/devices/0000:xx:xx.x/config A few reads out of that file succeeded, as well as accesses on vendor etc. Manually launching a qemu with the pci-assign works without a problem, so i "blame" libvirt and the cgroup environment the qemu ends up in. So i put a bash into the exact same cgroup setup - next to a running qemu, expecting a dd or hexdump on the config-space file to fail. But from that bash i can read the file without a problem. Has anyone seen that problem before? Right now i do not know what i am missing, maybe qemu is hitting some limits configured for the cgroups or whatever. I can not use pci-assign from libvirt, but if i did would it configure cgroups in a different way or relax some limits? What would be a good next step to debug that? Right now i am looking at kernel event traces, but the machine is pretty big and so is the trace. That assignment used to work and i do not know how it broke, i have tried combinations of several kernels, versions of libvirt and qemu. (kernel 3.18 and 4.4, libvirt 1.3.2 and 2.0.0, and qemu 2.2.1 and 2.7) All combinations show the same problem, even the ones that work on other machines. So when it comes to software versions the problem could well be caused by a software update of another component, that i got with the package manager and did not compile myself. It is a debian 8.6 with all recent updates installed. My guess would be that systemd could have an influence on cgroups or limits causing such a problem. regards, Henning

5 7

[libvirt] [PATCH] Fill out more fields for PKG-INFO file
by Daniel P. Berrange 02 Nov '16

02 Nov '16

Ensure the description and license are set in PKG-INFO, and clarify the summary field. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- setup.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 683dc93..5ad4101 100755 --- a/setup.py +++ b/setup.py @@ -311,7 +311,13 @@ setup(name = 'libvirt-python', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', - description = 'The libvirt virtualization API', + description = 'The libvirt virtualization API python binding', + long_description = + '''The libvirt-python package provides a module that permits applications +written in the Python programming language to call the interface +supplied by the libvirt library, to manage the virtualization capabilities +of recent versions of Linux (and other OSes).''', + license = 'LGPLv2+', ext_modules = _c_modules, py_modules = _py_modules, package_dir = { -- 2.9.3

2 1

[libvirt] [PATCH v3 0/6] New libssh transport
by Pino Toscano 02 Nov '16

02 Nov '16

Hi, this series introduces a new libssh transport in libvirt, based on the libssh C library. This library supports what libssh2 does, and more: - easier API for known_hosts handling (there's a ticket upstream to request extensions for it, but what is implemented now works well) - potential GSSAPI authentication (not enabled yet because of a libssh bug [1]) - easier API for ssh-agent support The implementation for the new transport is based on the libssh2 one, hence it shares origin and style. [1] https://red.libssh.org/issues/242 Thanks, Changes from v2 to v3: - split into more commits - integrate all the issues spotted by Daniel P. Berrange and Peter Krempa - restore the specified order of authentication methods (as in libssh2) - add a related documentation fix - minor coding fixes Changes from v1 to v2: - implemented keyboard interactive - code polish, and fixes Pino Toscano (6): virNetSocket: allow to not close FD virerror: add error for libssh transport libssh_transport: add new libssh-based transport remote: expose a new libssh transport spec: enable libssh transport on Fedora docs: fix default value for sshauth option of libssh2/libssh config-post.h | 2 + configure.ac | 3 + docs/remote.html.in | 39 +- include/libvirt/virterror.h | 2 + libvirt.spec.in | 10 + m4/virt-libssh.m4 | 26 + po/POTFILES.in | 1 + src/Makefile.am | 21 +- src/libvirt_libssh.syms | 22 + src/remote/remote_driver.c | 41 ++ src/rpc/virnetclient.c | 118 ++++ src/rpc/virnetclient.h | 13 + src/rpc/virnetlibsshsession.c | 1458 +++++++++++++++++++++++++++++++++++++++++ src/rpc/virnetlibsshsession.h | 80 +++ src/rpc/virnetsocket.c | 184 +++++- src/rpc/virnetsocket.h | 13 + src/util/virerror.c | 9 +- 17 files changed, 2024 insertions(+), 18 deletions(-) create mode 100644 m4/virt-libssh.m4 create mode 100644 src/libvirt_libssh.syms create mode 100644 src/rpc/virnetlibsshsession.c create mode 100644 src/rpc/virnetlibsshsession.h -- 2.7.4

2 12

[libvirt] [PATCH v2] qemu: report block job errors from qemu to the user
by Nikolay Shirokovskiy 02 Nov '16

02 Nov '16

So that you can see nice report on migration: "error: operation failed: migration of disk sda failed: No space left on device" diff from v1: 1. drop 1 patch. Avoiding default label in switches is desired style. 2. drop 2 patch. I do not investigate enough to touch that place. 3. fix 3 patch a) as suggested by Jiri * fix leaks * s/hint/error/g * don't show <NULL> in error message * take suggested code simplifications b) extra * print error string from qemu to log in case we have to drop it Nikolay Shirokovskiy (1): qemu: report block job errors from qemu to the user src/qemu/qemu_blockjob.c | 13 +++++++++-- src/qemu/qemu_blockjob.h | 3 ++- src/qemu/qemu_domain.c | 1 + src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 4 ++-- src/qemu/qemu_migration.c | 54 +++++++++++++++++++++++++++++++------------- src/qemu/qemu_monitor.c | 5 ++-- src/qemu/qemu_monitor.h | 4 +++- src/qemu/qemu_monitor_json.c | 4 +++- src/qemu/qemu_process.c | 4 ++++ 10 files changed, 68 insertions(+), 25 deletions(-) -- 1.8.3.1

2 4

[libvirt] [PATCH] Post-release version bump to 2.5.0
by Jiri Denemark 02 Nov '16

02 Nov '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index dfc536f..9785e66 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [2.4.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [2.5.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) -- 2.10.2

1 0

[libvirt] Release of libvirt-2.4.0
by Daniel Veillard 01 Nov '16

01 Nov '16

It's out ! Not hearing any negative feedback on the release candidates I went ahead, this is tagged in git and signed tarball and rpms are now at the usual place: ftp://libvirt.org/libvirt/ I also made a libvirt-python release though it is virtually identical to 2.3.0, to be found at: ftp://libvirt.org/libvirt/python/ this release is on the small side, leass than 250 commits were pulled in, mostly bugfixes and incremental improvement. Main user visible one being the one for I/O throtling and tuning: Documentation: - docs: remove obsolete library.xen file (Daniel P. Berrange) - doc: update virsh domstats documentation for vcpu statistics (Viktor Mihajlovski) - doc: Describe the VCPU states returned by virsh vcpuinfo (Viktor Mihajlovski) - virsh: Fix typos in manpage (Nitesh Konkar) - virsh: Fix commas in manpage to enhance readability. (Nitesh Konkar) - docs: Alter descriptions of perf cpu_cycles (John Ferlan) - docs: Add PCP as monitoring application (Marko Myllynen) - docs: Fix typo in libvirt-domain.h parameter description (John Ferlan) Portability: - virLogDefineOutputs: Fix build without syslog.h (Michal Privoznik) - virt-yajl: Fix detection of yajl requirements (Martin Kletzander) Bug Fixes: - vsh: Pass correct values for command line completion (John Ferlan) - vsh: Using VSH_REQUIRE_OPTION rather than virReportError (Kothapally Madhu Pavan) - network: fix endless loop when starting network with multiple IPs and no dhcp (Laine Stump) - qemu_driver: unlink new domain cfg file when rollback (Chen Hanxiao) - qemu: Fix crash during qemuStateCleanup (Nikolay Shirokovskiy) - daemon: Fix crash during daemon cleanup (Nikolay Shirokovskiy) - qemu: Forbid pinning vCPUs for TCG domain (Chen Hanxiao) - Recreate the USB address cache at reconnect (Ján Tomko) - Fix crash on usb-serial hotplug (Ján Tomko) - virsh: Fix on_shutdown to on_poweroff (Martin Kletzander) - qemu, lxc: Raise error message when resuming running domain (Sławek Kapłoński) - qemu: Fix depedency order in qemuRemoveDiskDevice (John Ferlan) - qemu: Move TLS object remove from DetachChr to RemoveChr (John Ferlan) - libxl: fix leaking of allocated migration ports (Jim Fehlig) - domain: fix migration to older libvirt (Pavel Hrdina) - domain_conf: fix memory leak in virDomainDefAddConsoleCompat (Pavel Hrdina) - bhyve: Need to add parameter to virDomainChrDefNew (John Ferlan) - networkValidate: Forbid new-line char in network name (Sławek Kapłoński) - qemu: always generate the same alias for tls-creds-x509 object (Pavel Hrdina) - qemu_hotplug: fix crash in hot(un)plugging chardev devices (Pavel Hrdina) - util: Alter return value of virReadFCHost and fix mem leak (John Ferlan) - schema: smbios: allow any strings (Peter Krempa) - qemu: command: escape smbios entry strings (Peter Krempa) - testNodeGetCellsFreeMemory: Fix off by one error (Michal Privoznik) - virsh: vcpuinfo: Report proper vcpu numbers and data for offline VMs (Peter Krempa) - virsh: Fix xpath queries for retrieving vcpu count (Peter Krempa) - conf: Fix virDomainShmemDefFind (Martin Kletzander) - qemu: migration: Disallow migration of read only disk (Corey S. McQuay) - tests: Need to initialize data (John Ferlan) - vsh: Fix some issues in auto completion code (John Ferlan) - util: Resolve memory leaks in virLogParse{Output|Filter} (John Ferlan) - tools: Exclude Xen dom0 from libvirt-guests.sh list (Stefan Bader) - tools: Ignore newlines in libvirt-guests.sh guest list (Stefan Bader) - qemu: fix command line building for iommu devices (Daniel P. Berrange) - qemu: monitor: Properly configure backend for UDP chardevs (Peter Krempa) - qemu: attach: Close monitor socket on connection failure (Peter Krempa) - qemu: Don't strictly require JSON monitor for vCPU detection (Peter Krempa) Improvements: - qemu: Minimalize global driver accesses (Michal Privoznik) - vz: remove Bridged network name and rename Routed (Maxim Nestratov) - vz: support type=bridge network interface type correctly (Maxim Nestratov) - Do not try to release virtio serial addresses (Ján Tomko) - Return directly from qemuDomainAttachChrDeviceAssignAddr (Ján Tomko) - Introduce virDomainVirtioSerialAddrAutoAssign again (Ján Tomko) - Add 'FromCache' to virDomainVirtioSerialAddrAutoAssign (Ján Tomko) - wireshark: Rename plugindir to ws_plugindir (Andrea Bolognani) - wireshark: Inject $(prefix) at the right time (Andrea Bolognani) - wireshark: Strip prefix correctly (Andrea Bolognani) - wireshark: Hoist $ws_prefix declaration (Andrea Bolognani) - wireshark: Introduce $ws_modversion (Andrea Bolognani) - qemu: Add support for using AES secret for SCSI hotplug (Gema Gomez) - qemu: Add secret object hotplug for TCP chardev TLS (John Ferlan) - qemu: Add a secret object to/for a char source dev (John Ferlan) - qemu: Need to remove TLS object in RemoveRNGDevice (John Ferlan) - virsh: Add _length parameters to virsh output (John Ferlan) - virsh: Create macros to add IOTUNE values (John Ferlan) - qemu: Add the length options to the iotune command line (John Ferlan) - conf: Add support for blkiotune "_length" options (John Ferlan) - qemu: Add length for bps/iops throttling parameters to driver (John Ferlan) - caps: Add new capability for the bps/iops throttling length (John Ferlan) - include: Add new definitions for duration for bps/iops throttling (John Ferlan) - qemu: Introduce qemuDomainSetBlockIoTuneDefaults (John Ferlan) - qemu: Move setting of conf_disk in qemuDomainSetBlockIoTune (John Ferlan) - qemu: Return real error message for block_set_io_throttle (John Ferlan) - qemu: Create a macro to handle setting bytes/iops iotune values (John Ferlan) - virQEMUCapsReset: also clear out hostCPUModel (Ján Tomko) - qemu: add vcpu.n.halted to vcpu domain stats (Viktor Mihajlovski) - qemu: Add domain support for VCPU halted state (Viktor Mihajlovski) - qemu: Add monitor support for CPU halted state (Viktor Mihajlovski) - qemu: replace calls to virDomainPCIAddressReserveNext*() with static function (Laine Stump) - conf: make virDomainPCIAddressGetNextSlot() a local static function (Laine Stump) - qemu: use virDomainPCIAddressReserveNextAddr in qemuDomainAssignDevicePCISlots (Laine Stump) - conf: new function virDomainPCIAddressReserveNextAddr() (Laine Stump) - domain: Add optional 'tls' attribute for TCP chardev (Pavel Hrdina) - domain_conf: remove union for one member from redirdev struct (Pavel Hrdina) - qemu: Add TLS hotplug for qemuDomainAttachRNGDevice (John Ferlan) - qemu: Add TLS hotplug for qemuDomainAttachRedirdevDevice (John Ferlan) - qemu: Clean up error path in qemuDomainAttachRedirdevDevice (John Ferlan) - qemu: Introduce qemuDomainGetChardevTLSObjects for hotplug (John Ferlan) - conf: Use virDomainChrSourceDefNew for virDomainRNGDef allocation (John Ferlan) - conf: Use virDomainChrSourceDefPtr for _virDomainRedirdevDef 'source.chr' (John Ferlan) - conf: Use virDomainChrSourceDefPtr for _virDomainSmartcardDef 'passthru' (John Ferlan) - xenFormatXLDisk: Unify commas pattern for arguments (Michal Privoznik) - qemu: change first arg of qemuDomainAttachChrDeviceAssignAddr() (Laine Stump) - qemu: make error message in qemuDomainPCIAddressSetCreate more clear. (Laine Stump) - qemu: remove superfluous setting of addrs->nbuses (Laine Stump) - conf: add typedef for anonymous enum used for memballoon device model (Laine Stump) - qemu: replace "def->nets[i]" with "net" and "def->sounds[i]" with "sound" (Laine Stump) - qemu: replace a lot of "def->controllers[i]" with equivalent "cont" (Laine Stump) - conf: Move the privateData from virDomainChrDef to virDomainChrSourceDef (John Ferlan) - Introduce virDomainChrSourceDefNew for virDomainChrDefPtr (John Ferlan) - vmx: Use the allocator virDomainChrDefNew (John Ferlan) - qemuBuildHostNetStr: remove dead code (Ján Tomko) - qemuBuildHostNetStr: do not start options with a comma (Ján Tomko) - qemuBuildHostNetStr: use type_sep earlier (Ján Tomko) - vz: set something in disk driver name (Nikolay Shirokovskiy) - vz: add serial number to disk devices (Nikolay Shirokovskiy) - vz: set localhost as vnc address (Mikhail Feoktistov) - virt-wireshark.m4: Defer $(prefix) substitution (Michal Privoznik) - network: Use new util function to check name (Sławek Kapłoński) - virxml: Add function to check if string contains some illegal chars (Sławek Kapłoński) - qemu: Introduce qemuDomainChardevPrivatePtr (John Ferlan) - conf: Introduce {default|chardev}_tls_x509_secret_uuid (John Ferlan) - xl: fix 8126d870 broken test (Cédric Bosdonnat) - spec: Drop support for Fedora < 23 (Andrea Bolognani) - xl: don't output (null) target in domxml-to-native (Cédric Bosdonnat) - qemu_command: create prefixed alias to separate variable (Pavel Hrdina) - qemu_alias: introduce qemuAliasChardevFromDevAlias helper (Pavel Hrdina) - qemu: Remove unnecessary NULL arg check (John Ferlan) - qemu: Add 'verify-peer=yes' test for chardev TCP TLS (John Ferlan) - qemu: Remove unnecessary cfg fetch/unref (John Ferlan) - conf: Explain some code in more detail (Andrea Bolognani) - conf: restrict what type of buses will accept a pci-bridge (Laine Stump) - conf: Honour flags in virDomainPanicDefParseXML (Martin Kletzander) - schema: Allow alias for panic device (Martin Kletzander) - qemu_hotplug: Support interface type of vhost-user hotplug (Michal Privoznik) - qemuBuildHostNetStr: Support VIR_DOMAIN_NET_TYPE_VHOSTUSER (Michal Privoznik) - qemuBuildVhostuserCommandLine: Unify -netdev creation (Michal Privoznik) - qemuBuildVhostuserCommandLine: Reuse qemuBuildChrChardevStr (Michal Privoznik) - qemuBuildChrChardevStr: Introduce @nowait argument (Michal Privoznik) - qemuBuildHostNetStr: Explicitly enumerate net types (Michal Privoznik) - qemuDomainAttachNetDevice: Explicitly list allowed types for hotplug (Michal Privoznik) - qemuDomainAttachNetDevice: Move hostdev handling a bit further (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move from if-else forest to switch (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move vhostuser handling a bit further (Michal Privoznik) - qemuBuildInterfaceCommandLine: Move hostdev handling a bit further (Michal Privoznik) - virDomainNetGetActualType: Return type is virDomainNetType (Michal Privoznik) - virDomainNetDefParseXML: Realign (Michal Privoznik) - qemu: command: Don't bother reporting errors in smbios formatters (Peter Krempa) - qemu: command: Fix up coding style of smbios commandine formatters (Peter Krempa) - src: Treat PID as signed (Michal Privoznik) - virsh: Be explicit that vol-resize is an offline operation. (Ivan Baldo) - testOpenDefault: Rename loop variable (Michal Privoznik) - qemu_command: add support to use virtio as secondary video device (Pavel Hrdina) - qemu_command: introduce enum of secondary models for video device (Pavel Hrdina) - qemu_command: cleanup qemuBuildVideoCommandLine (Pavel Hrdina) - qemu_command: properly detect which model to use for video device (Pavel Hrdina) - qemu_capabilities: check for existence of virtio-vga (Pavel Hrdina) - qemu_command: pass only video device to qemuBuildVgaVideoCommand (Pavel Hrdina) - qemu_command: separate code for video device via -vga attribute (Pavel Hrdina) - qemu_process: always check capabilities for video devices (Pavel Hrdina) - qemu_process: move video validation out of qemu_command (Pavel Hrdina) - qemu_domain: move video validation out of qemu_command (Pavel Hrdina) - qemu_capabilities: detect properties for virtio-gpu-device (Pavel Hrdina) - qemu_capabilities: rename QEMU_CAPS_VIRTIO_GPU_VIRGL (Pavel Hrdina) - qemu_capabilities: mark QEMU_CAPS_VGA_QXL capability as deprecated (Pavel Hrdina) - qemu_capabilities: join capabilities for qxl and qxl-vga devices (Pavel Hrdina) - tests: fix some QXL capability combinations that don't make sense (Pavel Hrdina) - qemu_command: remove xenner leftover from video device code (Pavel Hrdina) - qemu_process: move qemuProcessStartValidateGraphics to correct place (Pavel Hrdina) - virsh: Extract fallback handling in cmdVcpuinfo (Peter Krempa) - virsh: Extract cpumap formatting in cmdVcpuinfo (Peter Krempa) - virsh: domain: Fix broken indentation in virshCPUCountCollect (Peter Krempa) - util: bitmap: Make bitmaps const in virBitmapNewData and virBitmapDataToString (Peter Krempa) - libvirt-guests: Weaken dependency on libvirtd (Andrea Bolognani) - qemu: Disable migration with ivshmem (Martin Kletzander) - conf: Don't complicate find loop (Martin Kletzander) - Clean timer in virObjectEventStateFlush (Martin Kletzander) - De-duplicate code into virObjectEventStateCleanupTimer() (Martin Kletzander) - Reference state when using it as opaque (Martin Kletzander) - Change virDomainEventState to virObjectLockable (Martin Kletzander) - qemu: Reuse virDomainDeGetVcpusTopology to calculate total vcpu count (Peter Krempa) - conf: Sanitize cpu topology numbers (Peter Krempa) - util: Remove need for local 'nelems' (John Ferlan) - tests: Prefer virGetLastErrorMessage in testSELinuxLabeling (John Ferlan) - conf: Remove incorrect check when encoding shmem audit message (John Ferlan) - network: add dnsmasq option 'dhcp-authoritative' (Martin Wilck) - Don't update timer if there's none. (Martin Kletzander) - examples: Distribute all systemtap scripts. (Luyao Huang) - virlog: Split parsing and setting priority (Erik Skultety) - virlog: Remove functions that aren't used anywhere anymore (Erik Skultety) - daemon: Split filter parsing and filter defining (Erik Skultety) - daemon: Split output parsing and output defining (Erik Skultety) - virlog: Introduce virLogSetFilters (Erik Skultety) - virlog: Introduce virLogSetOutputs (Erik Skultety) - virlog: Introduce virLogParseFilters (Erik Skultety) - virlog: Introduce virLogParseOutputs (Erik Skultety) - virlog: Introduce virLogParseFilter (Erik Skultety) - virlog: Introduce virLogParseOutput (Erik Skultety) - virlog: Take a special care of syslog when setting new set of log outputs (Erik Skultety) - virlog: Introduce virLogNewOutputTo* as a replacement for virLogAddOutputTo* (Erik Skultety) - virlog: Introduce virLogDefineFilters (Erik Skultety) - virlog: Introduce virLogDefineOutputs (Erik Skultety) - virlog: Introduce virLogFindOutput (Erik Skultety) - virlog: Introduce virLogFilterNew (Erik Skultety) - virlog: Introduce virLogOutputNew (Erik Skultety) - virlog: Store the journald fd within the output object (Erik Skultety) - virlog: Rename virLogParse* to virLogParseAndDefine* (Erik Skultety) - virlog: Remove unused macro IS_SPACE (Erik Skultety) - virsh domdisplay: introduce '--all' for showing all possible graphical displays (Chen Hanxiao) - util: Check/ignore already disabled event (John Ferlan) - util: Clear up some perf error messages (John Ferlan) - private_syms: add virLogFilterListFree to libvirt_private.syms (Erik Skultety) - m4: Drop PKG_PROG_PKG_CONFIG compatibility code (Andrea Bolognani) - docs/Makefile.am: build hvsupport.html earlier (Ján Tomko) - docs/Makefile.am: remove redundant variables (Ján Tomko) - qemu: monitor: Simplify construction of chardev backends (Peter Krempa) - tests: qemumonitorjsontest: Do some actual testing in qemuMonitorJSONTestAttachChardev (Peter Krempa) - tests: qemumonitorjson: Don't do multiple tests in one virTestRun (Peter Krempa) - tests: qemu: Add support for testing aguments on monitor verbatim (Peter Krempa) - conf: Sanitize formatting of UDP chardev source (Peter Krempa) - conf: Add a formatting macro for all the blkiotune values (John Ferlan) - qemu: Adjust how supportMaxOptions is used. (John Ferlan) - qemu: Convert from shorthand to longer throttling names (John Ferlan) - tests: Add blkdeviotune-max xml2xmltest (John Ferlan) - include: Update description for <iotune> max params (John Ferlan) - qemu: allow 32 slots on pcie-expander-bus, not just 1 (Laine Stump) - vsh: Fix warnings in command line completer (Jiri Denemark) - qemu: Create helper qemuMonitorJSONGetBlockDevDevice (John Ferlan) - qemu: Create helper qemuMonitorJSONGetBlockDev (John Ferlan) - qemu: Create common code for JSON "query-block" call (John Ferlan) - util: Introduce virJSONValueObjectStealArray (John Ferlan) - rbd: Move the encryption check in build (John Ferlan) - rbd: Change to using heap allocated state contexts (John Ferlan) - rbd: Change virStorageBackendRBDCloseRADOSConn to be static void (John Ferlan) - qemu: Allow making vcpus hotpluggable with virDomainSetVcpusFlags (Peter Krempa) - lib: Introduce VIR_DOMAIN_VCPU_HOTPLUGGABLE for virDomainSetVcpusFlags (Peter Krempa) - Don't drop expired lease while reading custom leases file (Nehal J Wani) - NSS: Add explicit check to not report expired lease (Nehal J Wani) - remote: Increase bound limit for virDomainGetBlockIoTune (John Ferlan) - remote: Fix erroneous usage of constant (John Ferlan) thanks everybody for your help with the release, be it patch, docs, raising issues, commenting, reviewing patches, localizations, etc... Enjoy the release ! Daniel -- Daniel Veillard | Open Source and Standards, Red Hat veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] libvirt label qemu process problem
by zhunxun＠gmail.com 01 Nov '16

01 Nov '16

I found that when using souce code to install libvirt,it labeled qemu process with label "unconfined_u:unconfined_r:svirt_t:s0:c53,c366" instead of "system_u:system_r:svirt_t:s0:c53,c366",is this a bug??can anyone explain it ?? thanks! zhunxun(a)gmail.com

2 1

[libvirt] [PATCH] docs: remove obsolete library.xen file
by Daniel P. Berrange 01 Nov '16

01 Nov '16

The library.xen file contains a braindump of thoughts dating from the very first days of libvirt, when it was briefly called libxen. This is not useful and potentially misleading or confusing for people. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- cfg.mk | 2 +- docs/library.xen | 100 ------------------------------------------------------- 2 files changed, 1 insertion(+), 101 deletions(-) delete mode 100644 docs/library.xen diff --git a/cfg.mk b/cfg.mk index 9546853..a4305a8 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1220,7 +1220,7 @@ exclude_file_name_regexp--sc_prohibit_mixed_case_abbreviations = \ ^src/(vbox/vbox_CAPI.*.h|esx/esx_vi.(c|h)|esx/esx_storage_backend_iscsi.c)$$ exclude_file_name_regexp--sc_prohibit_empty_first_line = \ - ^(README|daemon/THREADS\.txt|src/esx/README|docs/library.xen|tests/(vmwarever|virhostcpu)data/.*)$$ + ^(README|daemon/THREADS\.txt|src/esx/README|tests/(vmwarever|virhostcpu)data/.*)$$ exclude_file_name_regexp--sc_prohibit_useless_translation = \ ^tests/virpolkittest.c diff --git a/docs/library.xen b/docs/library.xen deleted file mode 100644 index 2e1b2c5..0000000 --- a/docs/library.xen +++ /dev/null @@ -1,100 +0,0 @@ - - About a libxen library - ====================== - -Functional description: ------------------------ - - Small C library to be able to control Xen Linux guest, i.e. - provide the following operations for Xen guest domains running Linux - from domain 0 code linked to the library (running as root): - - start - - stop - - suspend - - resume - - monitor - More advanced features should be allowed as future extensions, but - are not expected to be provided in first shipment. - - Open enough Licence that customers can link their apps to it (LGPL) - - Small and contained enough that we can use it as a way to - provide API and ABI stability in spite if the evolution of Xen - existing API and hypervisor calls. - -The current state of Xen userland: ----------------------------------- - - the existing Xen 3.0 userland code is mostly based on tiny C functions -using direct hypervisor calls (or /proc/xen/ interfaces) and a lot of -Python code on top driving the hypervisor. - The C code is relatively hairy, functions with 10 parameters or more -are not uncommon, and it is very low level usually without comment about -the function or its arguments. They are usually only called once in the -whole tree by the python bindings. In essence it looks like the Xen project -was not implemented with the idea of reusing that part of the code by -applications. - Indeed most of the userland code coming with Xen is built on Python, -like xend the xen daemon running on domain 0 or the xenstored daemon which -manage the state of the domains launched. - -Rebuilding a library ?: ------------------------ - - Providing a library at the C level to drive domain execution is in a -very large part a rimplementation of existing code but in a different way -and somehow with different goals for the code. The existing Licence (GPL) -makes it uneasy, we can't copy GPL code to put it in a LGPL'ed library, -and rewriting everything while looking at the Xen code will inevitably -lead to code similarities especially with this kind of system code. Plus -we will still need to run xend and probably xenstored to not diverge -completely from Xen existing code base. - -The IBM way: ------------- - - Here is supposition about code that I can't instanciate except by looking -at said code but it looks that IBM also needed a C programmatic API to -manage the Xen domain definitions. Their solution was to build (Rusty -Russell did this) an LGPL C API connecting directly to the xenstore -daemon (./tools/xenstore/*). In a way this is quite more fragile as it depends -on the whole existing stack of the Xen code, but it isolate the API -from the implementation details of the current Xen source (API in -./tools/xenstore/xs.h). The goal seems to be more about testing and controlling -the xen store daemon, but it shows a different approach to decouple client -API/ABI from the Xen existing code. - -Open question: ---------------- - - To what extent should libxen be a rewrite or an isolation layer around -some of the existing code ? - - Rewrite: - - Pros: - - avoid the GPL Licence problem potentially more users - - allow do build a cleaner more stable layer - - the existing code is frightening - Cons: - - awful lot of work debugging very hard - - will still require existing Xen code to be running - - splitting interfaces is hard politically and lower the - Open Source efforts toward the project - - Wrappers on top of existing code: - - Pros: - - much smaller code rewrite - - benefits from the bugfixes injected by other patchers upstream - Cons: - - Licence constraint GPL only for apps - - API/ABI isolation may not be easier in that way - - Potentially the API could be implemented as a layer on top of the existing -libxc C code library and then progressively migrating out the existing -dependence to Xen code as the interfaces stabilize. - -Daniel Veillard <veillard(a)redhat.com> - -Mon Oct 24 18:40:19 CEST 2005 -- 2.9.3

2 2

[libvirt] [PATCH 0/2] Add support for preallocated fd memory
by Jaroslav Safka 01 Nov '16

01 Nov '16

Hi, we would like to introduce 3 new elements source,access and allocation in memoryBacking element. <memoryBacking> <source type="file|anonymous"/> <access Mode="shared|private"/> <allocation mode="immediate|ondemand"/> </memoryBacking> If allocation is immediate then -mem-prealloc should be added to the qemu commanline. If source is file then -object memory-backend-file,id=mem,size=1024M,mem-path=/var/lib/libvirt/qemu -numa node,memdev=mem Should be added to the qemu commandline If access is shared then the share=on parameter should be added to the memory-backend-file e.g. -object memory-backend-file,id=mem,size=1024M,mem-path=/var/lib/libvirt/qemu,share=on Also token memAccess in numa cell is used (if not present, default value from memoryBacking is used) Jaroslav Safka (2): Add support for preallocated fd memory Add support for preallocated fd memory docs/schemas/domaincommon.rng | 30 ++++ src/conf/domain_conf.c | 138 +++++++++++++----- src/conf/domain_conf.h | 33 +++++ src/qemu/qemu_command.c | 156 ++++++++++++++++----- src/qemu/qemu_command.h | 4 + .../qemuxml2argv-fd-memory-no-numa-topology.args | 33 +++++ .../qemuxml2argv-fd-memory-no-numa-topology.xml | 91 ++++++++++++ .../qemuxml2argv-fd-memory-numa-topology.args | 33 +++++ .../qemuxml2argv-fd-memory-numa-topology.xml | 94 +++++++++++++ .../qemuxml2argv-fd-memory-numa-topology2.args | 36 +++++ .../qemuxml2argv-fd-memory-numa-topology2.xml | 95 +++++++++++++ .../qemuxml2argv-fd-memory-numa-topology3.args | 39 ++++++ .../qemuxml2argv-fd-memory-numa-topology3.xml | 96 +++++++++++++ .../qemuxml2argv-memorybacking-set.xml | 32 +++++ .../qemuxml2argv-memorybacking-unset.xml | 32 +++++ tests/qemuxml2argvtest.c | 42 ++++++ .../qemuxml2xmlout-memorybacking-set.xml | 40 ++++++ .../qemuxml2xmlout-memorybacking-unset.xml | 40 ++++++ tests/qemuxml2xmltest.c | 3 + 19 files changed, 1001 insertions(+), 66 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-no-numa-topology.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-no-numa-topology.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology2.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology2.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology3.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-fd-memory-numa-topology3.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-set.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-memorybacking-unset.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-set.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-memorybacking-unset.xml -- 2.7.4 -------------------------------------------------------------- Intel Research and Development Ireland Limited Registered in Ireland Registered Office: Collinstown Industrial Park, Leixlip, County Kildare Registered Number: 308263 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

2 3

[libvirt] [PATCH] domain_event.c: Fix a typo
by Kothapally Madhu Pavan 01 Nov '16

01 Nov '16

Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- src/conf/domain_event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_event.c b/src/conf/domain_event.c index 63ae9e1..f1249ad 100644 --- a/src/conf/domain_event.c +++ b/src/conf/domain_event.c @@ -1839,7 +1839,7 @@ virDomainEventDispatchDefaultFunc(virConnectPtr conn, virDomainEventJobCompletedPtr ev; ev = (virDomainEventJobCompletedPtr) event; - ((virConnectDomainEventJobCompletedCallback) cb)(conn, dom, + ((virConnectDomainEventJobCompletedCallback)cb)(conn, dom, ev->params, ev->nparams, cbopaque);

2 2

[libvirt] [PATCH v2 python 0/2] fix crash in libvirt_virDomainPin*
by Konstantin Neumoin 01 Nov '16

01 Nov '16

this small patch set: * move common logic of all libvirt_virDomainPin* functions to new helper in util module. * add check for pycpumap length. Changes since v1: - add new helper in util module. Konstantin Neumoin (2): minor clean-up for libvirt_virDomainPin* add check for pycpumap length libvirt-override.c | 131 +++++------------------------------------------------ libvirt-utils.c | 63 ++++++++++++++++++++++++++ libvirt-utils.h | 5 ++ 3 files changed, 79 insertions(+), 120 deletions(-) -- 2.5.5

2 5

[libvirt] VLAN-based direct interface
by Ed Swierk 31 Oct '16

31 Oct '16

In my setup, the network interfaces of several KVM-based VMs all communicate with the outside world via a single host interface, which is in turn connected to an external switch that handles all network policy to/from/between VMs. Traffic between the host and the switch is segregated by VLAN ID, one per vNIC. When I spin up a new VM with one vNIC assigned (say) VLAN ID 101, I run ip link add link eth0 name eth0.101 type vlan id 101. In the libvirt config I write <interface type='direct' trustGuestRxFilters='yes'> <source dev='eth0.101' mode='passthrough'/> <model type='virtio'/> </interface> This causes libvirt to create a macvtap interface attached to eth0.101 in passthrough mode. So far, so good. The guest OS thinks it has a plain old NIC on an untagged switch port. When the guest OS joins an IPv6 link-local solicited-node multicast group, QEMU tells libvirt to add the corresponding multicast MAC address to the macvtap interface. I can even run a trunk port all the way through to the VM, with traffic double-tagged through the switch-host hop. Trouble arises if I change the model from virtio to e1000, to support an application that doesn't (yet) have virtio drivers. QEMU doesn't expose state via query-rx-filter for e1000 interfaces, so libvirt can't sync multicast MAC addresses from the guest to the macvtap interface, so the guest can't talk IPv6. Ideally QEMU would support query-rx-filter for e1000 and other NIC models. But for my application all the careful syncing of guest rx filter state is overkill: I need the macvtap interface to pass all traffic between the guest and host with no filtering at all. I can achieve this simply by enabling promiscuous mode on the macvtap interface. But libvirt creates the interface, and I don't see any way to get libvirt to enable promiscuous mode and leave it enabled. It wouldn't be hard to add another configuration flag that tells libvirt to just put the macvtap interface into promiscuous mode and skip syncing guest rx filters. Perhaps add another value for trustGuestRxFilters, like 'promisc'? However just solving that minor problem seems like piling one hack on top of another: taking a normal interface and attaching a VLAN interface to it, then attaching a macvtap interface to that, and beating the mac out of the macvtap until it behaves like a dumb bridge (or, attaching a bridge to the VLAN interface, creating a tap interface, and enslaving the tap to the bridge, old-school). What I'm really after is just another kind of direct interface that attaches to a host interface, but instead of directing traffic to the guest by MAC address it uses the VLAN ID (and also adds/strips the tag). libvirt could implement this by automating all the steps I just described. Or if the kernel ever sprouts the VLAN equivalent of the macvtap driver (vlanvtap?), libvirt could just use that. Any opinions on first-class support for a VLAN-based direct interface, versus just allowing configuration of promiscuous mode on a macvtap direct interface? --Ed

1 0

[libvirt] [PATCH v3.1 00/10] Implementation of QEMU vhost-scsi
by Eric Farman 31 Oct '16

31 Oct '16

This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi controller in favor of a hostdev element instead[2]. Host setup via targetcli (SCSI LUN(s) are already defined to host): # targetcli targetcli shell version 2.1.fb35 Copyright 2011-2013 by Datera, Inc and others. For help on commands, type 'help'. /> backstores/block create write_back=false name=disk1 \ dev=/dev/disk/by-id/dm-name-36005076306ffc7630000000000002211 Created block storage object disk1 using /dev/disk/by-id/dm-name-36005076306ffc7630000000000002211. /> vhost/ create Created target naa.5001405df3e54061. Created TPG 1. /> vhost/naa.5001405df3e54061/tpg1/luns create /backstores/block/disk1 Created LUN 0. /> exit Host Filesystem Example: # ls /sys/kernel/config/target/vhost/ discovery_auth naa.5001405df3e54061 version # ls /sys/kernel/config/target/vhost/naa.5001405df3e54061/tpgt_1/lun/ lun_0 QEMU Example (snippet): -device vhost-scsi-ccw,wwpn=naa.5001405df3e54061,devno=fe.0.1000 Libvirt Example (snippet): <hostdev mode='subsystem' type='scsi_host'> <source protocol='vhost' wwpn='naa.5001405df3e54061'/> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x1000'/> </hostdev> Guest Viewpoint: # lsscsi [1:0:1:0] disk LIO-ORG disk0 4.0 /dev/sda # dmesg | grep 1: [ 6.065735] scsi host1: Virtio SCSI HBA [ 6.093892] scsi 1:0:1:0: Direct-Access LIO-ORG disk0 4.0 PQ: 0 ANSI: 5 [ 6.313615] sd 1:0:1:0: Attached scsi generic sg0 type 0 [ 6.314981] sd 1:0:1:0: [sda] 29360128 512-byte logical blocks: (15.0 GB/14.0 GiB) [ 6.317290] sd 1:0:1:0: [sda] Write Protect is off [ 6.317566] sd 1:0:1:0: [sda] Mode Sense: 43 00 10 08 [ 6.317853] sd 1:0:1:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 6.352722] sd 1:0:1:0: [sda] Attached SCSI disk Changelog: v3.1: - Rebase - Rebased to current master (31 October) - Included the prereq for the subsystem type in switch statements (oops!) v3: https://www.redhat.com/archives/libvir-list/2016-October/msg01201.html - Rebase - Rebased to current master (26 October) - Comments - Added an early patch to do some additional typecasting in the switch statements of hostdev.subsys.type - Did some reordering of patches, to hopefully flow better - Implemented an activeHostHostdevs list, which is used by the cgroup and security codepaths - doc changes -- s/2.2/2.5/ and s/HBI/HBA/ - Added a "none" protocol type for scsi_host hostdevs (which is invalid) - Restored the apparmor and selinux codepaths that got lost from v1 - Added a proper check for a valid scsi_host protocol, and saving that value within the HostdevDef struct - Fixed a compiler warning with call to virDomainPCIAddressEnsureAddr - Removed the rest of vhostfdSize, since multiple fd's are not allowed by QEMU - Fixed cleanup of vhostfd in error from building -device string - Moved the "conf" chunk from "hotplug" patch to "introduce" patch - Added xml2xml test - Added a proper calculation of "address" in virDomainAuditHostdev - Added a virFileExists check before open(/dev/vhost-scsi) - Addressed a number of lines >80 characters - Things *NOT* done (later?) - Investigation/tie-in with virsh nodedev-list stuff - Implementation of 'num_queues', 'max_sectors', and 'cmd_per_lun' (Need to research these in the virtio space, before figuring out how to apply to vhost-scsi) - Dropping the "naa." prefix of wwn - Split the "tests" patch into earlier patches - Other v2.1: https://www.redhat.com/archives/libvir-list/2016-September/msg00148.html v2: https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html [1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html [2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html Eric Farman (10): Cleanup switch statements on the hostdev subsystem type qemu: Introduce vhost-scsi capability Introduce a "scsi_host" hostdev type util: Management routines for scsi_host devices qemu: Add vhost-scsi string for -device parameter qemu: Allow hotplug of vhost-scsi device conf: Wire up the vhost-scsi connection from/to XML security: Include vhost-scsi in security labels tests: Introduce basic vhost-scsi test docs: Add vhost-scsi docs/formatdomain.html.in | 24 ++ docs/schemas/domaincommon.rng | 23 ++ src/Makefile.am | 1 + src/conf/domain_audit.c | 7 + src/conf/domain_conf.c | 102 ++++++- src/conf/domain_conf.h | 18 ++ src/libvirt_private.syms | 19 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 50 +++- src/qemu/qemu_command.c | 79 ++++++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain_address.c | 10 + src/qemu/qemu_hostdev.c | 41 +++ src/qemu/qemu_hostdev.h | 8 + src/qemu/qemu_hotplug.c | 160 +++++++++++ src/security/security_apparmor.c | 24 +- src/security/security_dac.c | 46 ++++ src/security/security_selinux.c | 51 +++- src/util/virhost.c | 301 +++++++++++++++++++++ src/util/virhost.h | 72 +++++ src/util/virhostdev.c | 155 +++++++++++ src/util/virhostdev.h | 16 ++ tests/domaincapsschemadata/full.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 ++ .../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41 +++ tests/qemuxml2argvmock.c | 9 + tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml | 1 + tests/qemuxml2xmltest.c | 3 + 41 files changed, 1294 insertions(+), 14 deletions(-) create mode 100644 src/util/virhost.c create mode 100644 src/util/virhost.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml -- 1.9.1

1 10

[libvirt] [PATCH RESEND] qemu_driver: unlink new domain cfg file when rollback
by Chen Hanxiao 31 Oct '16

31 Oct '16

From: Chen Hanxiao <chenhanxiao(a)gmail.com> If we failed to unlink old dom cfg file, we goto rollback. But inside rollback, we fogot to unlink the new dom cfg file. This patch fixes this issue. Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com> --- src/qemu/qemu_driver.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index e6f845d..3f4a2fb 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -19869,6 +19869,7 @@ qemuDomainRenameCallback(virDomainObjPtr vm, char *new_dom_name = NULL; char *old_dom_name = NULL; char *old_dom_cfg_file = NULL; + char *new_dom_cfg_file = NULL; virCheckFlags(0, ret); @@ -19882,6 +19883,11 @@ qemuDomainRenameCallback(virDomainObjPtr vm, goto cleanup; } + if (!(new_dom_cfg_file = virDomainConfigFile(cfg->configDir, + new_dom_name))) { + goto cleanup; + } + event_old = virDomainEventLifecycleNewFromObj(vm, VIR_DOMAIN_EVENT_UNDEFINED, VIR_DOMAIN_EVENT_UNDEFINED_RENAMED); @@ -19909,6 +19915,7 @@ qemuDomainRenameCallback(virDomainObjPtr vm, cleanup: VIR_FREE(old_dom_cfg_file); + VIR_FREE(new_dom_cfg_file); VIR_FREE(old_dom_name); VIR_FREE(new_dom_name); qemuDomainEventQueue(driver, event_old); @@ -19922,6 +19929,10 @@ qemuDomainRenameCallback(virDomainObjPtr vm, vm->def->name = old_dom_name; old_dom_name = NULL; } + + if (virFileExists(new_dom_cfg_file)) + unlink(new_dom_cfg_file); + goto cleanup; } -- 1.8.3.1

4 4

[libvirt] [PATCH v3 0/9] Implementation of QEMU vhost-scsi
by Eric Farman 31 Oct '16

31 Oct '16

[Author note: Apologies for an extra release or two in between versions, I was sidetracked by another project. This is probably too close to the impending freeze for 2.4, so I just updated doc to 2.5 in anticipation. In rearranging the patches, I've inserted a cleanup patch at the head that was mentioned in the v2 review, and which could go separately.] This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi controller in favor of a hostdev element instead[2]. Host Filesystem Example: # ls /sys/kernel/config/target/vhost/ discovery_auth naa.5001405df3e54061 version # ls /sys/kernel/config/target/vhost/naa.5001405df3e54061/tpgt_1/lun/ lun_0 QEMU Example (snippet): -device vhost-scsi-ccw,wwpn=naa.5001405df3e54061,devno=fe.0.1000 Libvirt Example (snippet): <hostdev mode='subsystem' type='scsi_host'> <source protocol='vhost' wwpn='naa.5001405df3e54061'/> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x1000'/> </hostdev> Guest Viewpoint: # lsscsi [1:0:1:0] disk LIO-ORG disk0 4.0 /dev/sda # dmesg | grep 1: [ 6.065735] scsi host1: Virtio SCSI HBA [ 6.093892] scsi 1:0:1:0: Direct-Access LIO-ORG disk0 4.0 PQ: 0 ANSI: 5 [ 6.313615] sd 1:0:1:0: Attached scsi generic sg0 type 0 [ 6.314981] sd 1:0:1:0: [sda] 29360128 512-byte logical blocks: (15.0 GB/14.0 GiB) [ 6.317290] sd 1:0:1:0: [sda] Write Protect is off [ 6.317566] sd 1:0:1:0: [sda] Mode Sense: 43 00 10 08 [ 6.317853] sd 1:0:1:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 6.352722] sd 1:0:1:0: [sda] Attached SCSI disk Changelog: v2.1->v3: - Rebase - Rebased to current master (26 October) - Comments - Added an early patch to do some additional typecasting in the switch statements of hostdev.subsys.type - Did some reordering of patches, to hopefully flow better - Implemented an activeHostHostdevs list, which is used by the cgroup and security codepaths - doc changes -- s/2.2/2.5/ and s/HBI/HBA/ - Added a "none" protocol type for scsi_host hostdevs (which is invalid) - Restored the apparmor and selinux codepaths that got lost from v1 - Added a proper check for a valid scsi_host protocol, and saving that value within the HostdevDef struct - Fixed a compiler warning with call to virDomainPCIAddressEnsureAddr - Removed the rest of vhostfdSize, since multiple fd's are not allowed by QEMU - Fixed cleanup of vhostfd in error from building -device string - Moved the "conf" chunk from "hotplug" patch to "introduce" patch - Added xml2xml test - Added a proper calculation of "address" in virDomainAuditHostdev - Added a virFileExists check before open(/dev/vhost-scsi) - Addressed a number of lines >80 characters - Things *NOT* done (later?) - Investigation/tie-in with virsh nodedev-list stuff - Implementation of 'num_queues', 'max_sectors', and 'cmd_per_lun' (Need to research these in the virtio space, before figuring out how to apply to vhost-scsi) - Dropping the "naa." prefix of wwn - Split the "tests" patch into earlier patches - Other v2.1: https://www.redhat.com/archives/libvir-list/2016-September/msg00148.html v2: https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html [1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html [2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html Eric Farman (9): qemu: Introduce vhost-scsi capability Introduce a "scsi_host" hostdev type util: Management routines for scsi_host devices qemu: Add vhost-scsi string for -device parameter qemu: Allow hotplug of vhost-scsi device conf: Wire up the vhost-scsi connection from/to XML security: Include vhost-scsi in security labels tests: Introduce basic vhost-scsi test docs: Add vhost-scsi docs/formatdomain.html.in | 24 ++ docs/schemas/domaincommon.rng | 23 ++ src/Makefile.am | 1 + src/conf/domain_audit.c | 7 + src/conf/domain_conf.c | 91 ++++++- src/conf/domain_conf.h | 18 ++ src/libvirt_private.syms | 19 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 39 +++ src/qemu/qemu_command.c | 79 ++++++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain_address.c | 10 + src/qemu/qemu_hostdev.c | 41 +++ src/qemu/qemu_hostdev.h | 8 + src/qemu/qemu_hotplug.c | 160 +++++++++++ src/security/security_apparmor.c | 20 ++ src/security/security_dac.c | 46 ++++ src/security/security_selinux.c | 43 +++ src/util/virhost.c | 301 +++++++++++++++++++++ src/util/virhost.h | 72 +++++ src/util/virhostdev.c | 155 +++++++++++ src/util/virhostdev.h | 16 ++ tests/domaincapsschemadata/full.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + .../qemuxml2argv-hostdev-scsi-vhost-scsi.args | 24 ++ .../qemuxml2argv-hostdev-scsi-vhost-scsi.xml | 41 +++ tests/qemuxml2argvmock.c | 9 + tests/qemuxml2argvtest.c | 3 + .../qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml | 1 + tests/qemuxml2xmltest.c | 3 + 41 files changed, 1272 insertions(+), 2 deletions(-) create mode 100644 src/util/virhost.c create mode 100644 src/util/virhost.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-vhost-scsi.xml -- 1.9.1

2 11

[libvirt] [PATCH] vsh: Pass correct values for command line completion
by John Ferlan 31 Oct '16

31 Oct '16

Commit id 'dcfdf341' passes 'opts_need_arg' and 'opts_seen' to vshCmddefGetData, but that seems to be incorrect as those values are not initialized properly (something at least one compiler found). Instead the static 'const_opts_need_arg' and 'const_opts_seen' values should be passed. By passing unitialized values leads to not finding possible options for simpler commands (domfsfreeze for example), where if you're in a virsh shell using command line completion - you'll get a list of files in your current directory instead of two options --domain and --mountpoint (as would happen with this patch applied. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/vsh.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 9558dad..17199ae 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2788,7 +2788,8 @@ vshReadlineParse(const char *text, int state) /* No -- option provided and some other token given * Try to find the default option. */ - if (!(opt = vshCmddefGetData(cmd, &opts_need_arg, &opts_seen)) + if (!(opt = vshCmddefGetData(cmd, &const_opts_need_arg, + &const_opts_seen)) || opt->type == VSH_OT_BOOL) goto error; opt_exists = true; -- 2.7.4

2 1