- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] List only online cpus for vcpupin/emulatorpin when vcpu placement static
by Nitesh Konkar 08 Nov '16

08 Nov '16

From: nitesh konkar <niteshkonkar.libvirt(a)gmail.com> Currently when the vcpu placement is static and cpuset is not specified, CPU Affinity shows 0.. CPUMAX. This patchset will result in display of only online CPU's under CPU Affinity. nitesh konkar (2): conf: List only online cpus under CPU Affinity for virsh vcpupin. conf: List only online cpus under CPU Affinity for virsh emulatorpin src/conf/domain_conf.c | 3 +++ src/qemu/qemu_driver.c | 2 ++ 2 files changed, 5 insertions(+) -- 2.1.0

2 4

[libvirt] [PATCH] Test driver should error when domain destroy twice
by Félix Bouliane 08 Nov '16

08 Nov '16

Fixes the behavior when destroying a domain more than once. VIR_ERR_OPERATION_INVALID should be raised when destroying an already destroyed domain. --- src/test/test_driver.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 51fb7c8..42adbad 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -1735,6 +1735,12 @@ static int testDomainDestroy(virDomainPtr domain) if (!(privdom = testDomObjFromDomain(domain))) goto cleanup; + if (!virDomainObjIsActive(privdom)) { + virReportError(VIR_ERR_OPERATION_INVALID, + "%s", _("domain is not running")); + goto cleanup; + } + testDomainShutdownState(domain, privdom, VIR_DOMAIN_SHUTOFF_DESTROYED); event = virDomainEventLifecycleNewFromObj(privdom, VIR_DOMAIN_EVENT_STOPPED, -- 2.9.3

2 1

[libvirt] [PATCH v2 00/11] clean up after "slot sharing" patches
by Laine Stump 07 Nov '16

07 Nov '16

(this is just a rebase of the v1 patches to make review easier) Some of the patches that enabled sharing PCI slots by multiple pcie-root-ports made the idea of reserving an entire slot obsolete. To reduce confusion and misunderstandings, this patch series gets rid of the name "Slot" in all of the functions that reserve and release PCI addresses. None of these patches affect any functional change. This is a lot of patches, but each patch is trivial, I promise - most are simply renaming a single function, or changing one argument to some calls to a function. Laine Stump (11): conf: fix fromConfig argument to virDomainPCIAddressReserveAddr() conf: fix fromConfig argument to virDomainPCIAddressValidate() conf: rename virDomainPCIAddressGetNextSlot() to ...GetNextAddr() conf: eliminate virDomainPCIAddressReserveNextSlot() qemu: replace virDomainPCIAddressReserveAddr with virDomainPCIAddressReserveSlot conf: make virDomainPCIAddressReserveAddr() a static function conf: rename virDomainPCIAddressReserveAddr() to ...Internal() conf: rename virDomainPCIAddressReserveSlot() to ...Addr() qemu: remove qemuDomainPCIAddressReserveNextAddr() qemu: rename qemuDomainPCIAddressReserveNextSlot() to ...Addr() conf: eliminate virDomainPCIAddressReleaseSlot() in favor of ...Addr() src/bhyve/bhyve_device.c | 26 ++++++---- src/conf/domain_addr.c | 60 +++++------------------ src/conf/domain_addr.h | 15 ------ src/libvirt_private.syms | 4 +- src/qemu/qemu_domain_address.c | 105 ++++++++++++++++++++--------------------- 5 files changed, 80 insertions(+), 130 deletions(-) -- 2.7.4

1 11

[libvirt] [PATCH 0/6] Add group_name support for <iotune>
by John Ferlan 07 Nov '16

07 Nov '16

https://bugzilla.redhat.com/show_bug.cgi?id=1336564 Add support for "group" name in <iotune>. The odd thing about the <iotune> group name is that support was added in qemu after the _max parameters, but before the _max_length - so when building the command line - that needs to be followed. At least it's far less complicated than the _length parameters. John Ferlan (6): include: Add new "group_name" definition for iotune throttling caps: Add new capability for the iotune group name qemu: Add support for parsing iotune group setting conf: Add support for blkiotune group_name option qemu: Add the group name option to the iotune command line virsh: Add group name to blkdeviotune output docs/formatdomain.html.in | 11 ++++ docs/schemas/domaincommon.rng | 5 ++ include/libvirt/libvirt-domain.h | 15 +++++ src/conf/domain_conf.c | 10 +++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 13 ++++ src/qemu/qemu_driver.c | 50 +++++++++++++-- src/qemu/qemu_monitor.c | 2 + src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 21 +++++- src/qemu/qemu_monitor_json.h | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemumonitorjsontest.c | 74 +++++++++++++++++----- .../qemuxml2argv-blkdeviotune-group-num.args | 32 ++++++++++ .../qemuxml2argv-blkdeviotune-group-num.xml | 61 ++++++++++++++++++ tests/qemuxml2argvtest.c | 4 ++ .../qemuxml2xmlout-blkdeviotune-group-num.xml | 1 + tests/qemuxml2xmltest.c | 1 + tools/virsh-domain.c | 17 +++++ tools/virsh.pod | 5 +- 28 files changed, 309 insertions(+), 26 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-group-num.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-blkdeviotune-group-num.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-blkdeviotune-group-num.xml -- 2.7.4

3 16

Re: [libvirt] [PATCH 1/2] vbox: add vbox 5.1 C API header file.
by Eric Blake 07 Nov '16

07 Nov '16

On 11/07/2016 03:03 PM, Dawid Zamirski wrote: > > extracted from VirutalBox SDK and reindented with cppi. > --- > src/vbox/vbox_CAPI_v5_1.h | 26117 ++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 26117 insertions(+) > create mode 100644 src/vbox/vbox_CAPI_v5_1.h 1.1 Meg of generated code is a lot to send to the mailing list. Can you compress the patch so that it isn't taxing the list server quite so hard? Or if someone with push rights agrees, send them the patch on the side and get it committed without going through the list (as there's very little that actually needs a review). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

2 1

[libvirt] [PATCH v2 0/8] aggregate multiple pcie-root-ports onto a single slot
by Laine Stump 07 Nov '16

07 Nov '16

This is just a rebase of v1 of the same series, reposted to make it easier for Andrea to review. Laine Stump (8): conf: use struct instead of int for each slot in virDomainPCIAddressBus conf: eliminate concept of "reserveEntireSlot" conf: eliminate repetitive code in virDomainPCIAddressGetNextSlot() conf: start search for next unused PCI address at same slot as previous find conf: new function virDomainPCIAddressIsMulti() qemu: use virDomainPCIAddressIsMulti() to determine multifunction setting conf: aggregate multiple devices on a slot when assigning PCI addresses conf: aggregate multiple pcie-root-ports onto a single slot src/conf/domain_addr.c | 290 ++++++++++++++------- src/conf/domain_addr.h | 48 +++- src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 16 +- src/qemu/qemu_domain_address.c | 35 ++- .../qemuxml2argv-pcie-root-port.args | 5 +- .../qemuxml2argv-pcie-switch-upstream-port.args | 5 +- .../qemuxml2argv-q35-default-devices-only.args | 7 +- .../qemuxml2argv-q35-multifunction.args | 43 +++ .../qemuxml2argv-q35-multifunction.xml | 51 ++++ .../qemuxml2argv-q35-pcie-autoadd.args | 30 ++- tests/qemuxml2argvdata/qemuxml2argv-q35-pcie.args | 28 +- .../qemuxml2argv-q35-virt-manager-basic.args | 13 +- .../qemuxml2argv-q35-virtio-pci.args | 28 +- tests/qemuxml2argvtest.c | 25 ++ .../qemuxml2xmlout-pcie-root-port.xml | 2 +- .../qemuxml2xmlout-pcie-switch-upstream-port.xml | 4 +- .../qemuxml2xmlout-q35-default-devices-only.xml | 8 +- .../qemuxml2xmlout-q35-multifunction.xml | 120 +++++++++ .../qemuxml2xmlout-q35-pcie-autoadd.xml | 52 ++-- .../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 48 ++-- .../qemuxml2xmlout-q35-virt-manager-basic.xml | 20 +- .../qemuxml2xmlout-q35-virtio-pci.xml | 48 ++-- tests/qemuxml2xmltest.c | 25 ++ 24 files changed, 676 insertions(+), 276 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-q35-multifunction.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-q35-multifunction.xml -- 2.7.4

1 8

[libvirt] [PATCH] Unbreak rebuilding docs with release tarballs
by Guido Günther 07 Nov '16

07 Nov '16

Release tarballs ship the include/libvirt/libvirt-common.h. when srcdir != builddir we end up including libvirt-common.h twice: from $top_srcdir/include/libvirt-common.h and from $builddir/include/libvirt-common.h leading to function virTypedParamsGetUInt from /tmp/buildd/libvirt-2.4.0/debian/build/docs/../include/libvirt/libvirt-common.h redeclared in /tmp/buildd/libvirt-2.4.0/docs/../include/libvirt/libvirt-common.h function virTypedParamsAddBoolean from /tmp/buildd/libvirt-2.4.0/debian/build/docs/../include/libvirt/libvirt-common.h redeclared in /tmp/buildd/libvirt-2.4.0/docs/../include/libvirt/libvirt-common.h … Only add the builddir to the search list if there is no pregenerated libvirt-common.h. Reuse the existing check that predates the libvirt.h → libvirt-common.h split and that probably was meant for exactly that. References: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842452 --- docs/apibuild.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/apibuild.py b/docs/apibuild.py index 8728b27..47f340c 100755 --- a/docs/apibuild.py +++ b/docs/apibuild.py @@ -2607,10 +2607,9 @@ class app: dirs = [srcdir + "/../src", srcdir + "/../src/util", srcdir + "/../include/libvirt"] - if builddir: + if (builddir and + not os.path.exists(srcdir + "/../include/libvirt/libvirt-common.h")): dirs.append(builddir + "/../include/libvirt") - if glob.glob(srcdir + "/../include/libvirt/libvirt.h") == [] : - dirs.append("../include/libvirt") builder = docBuilder(name, srcdir, dirs, []) elif glob.glob("src/libvirt.c") != [] : if not quiet: -- 2.10.1

2 2

[libvirt] [PATCH] spec: Run all make jobs in parallel
by Andrea Bolognani 07 Nov '16

07 Nov '16

Commit e8861f69714f changed our spec file to compile and run tests in parallel. That's a very good step forward, but why stop there? Let's run *all* make jobs in parallel and really put those expensive cores to use! On my laptop, this shaves ~10s off 'make rpm'. --- libvirt.spec.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 5133936..a2c2f2f 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1210,9 +1210,9 @@ rm -fr %{buildroot} # Avoid using makeinstall macro as it changes prefixes rather than setting # DESTDIR. Newer make_install macro would be better but it's not available # on RHEL 5, thus we need to expand it here. -make install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} +make %{?_smp_mflags} install DESTDIR=%{?buildroot} SYSTEMD_UNIT_DIR=%{_unitdir} -make -C examples distclean +make %{?_smp_mflags} -C examples distclean rm -f $RPM_BUILD_ROOT%{_libdir}/*.la rm -f $RPM_BUILD_ROOT%{_libdir}/*.a -- 2.7.4

2 2

[libvirt] [PATCH] Allow saving QEMU libvirt state to a pipe
by Roy Keene 07 Nov '16

07 Nov '16

All, Currently the "virsh save" command opens a file to save a domain's XML and memory state, does the save, and then re-opens the file to simulate seeking to the beginning to update the header to indicate that the file is complete. For pipes this is not possible, attempting to re-open the pipe will not connect you to the same consumer. Seeking is also not possible on a pipe. Attached is a patch that detects if the file being written to is not seekable, and if so writes the completed header initially, then writes the normal data, and avoids re-opening the file. This is useful to me for saving a VM state directly to Ceph RBD images without having an intermediate file. I've tested this patch successfully (against v1.3.5) for both saving and restoring a domain: # *( fifo="$(mktemp -u)"; mkfifo "${fifo}" && virsh save one-0 "${fifo}" & cat "${fifo}" | rbd import - rbd/test1234 & wait; rm -f "${fifo}" )* Domain one-0 saved to /tmp/tmp.HK4hChiQqB # # *( fifo="$(mktemp -u)"; mkfifo "${fifo}" && rbd export rbd/test1234 - > "${fifo}" & virsh restore "${fifo}" & wait; rm -f "${fifo}" ) * Exporting image: 100% complete...done. Domain restored from /tmp/tmp.0YaUZ5Y2yT # *virsh list* Id Name State ---------------------------------------------------- 11 one-0 running # -- Roy Keene Knight Point Systems, LLC Service-Disabled Veteran-Owned Business 1775 Wiehle Avenue Suite 101 | Reston, VA 20190 c: 813-956-3808 f: 571-266-3106 www.knightpoint.com DHS EAGLE II Prime Contractor: FC1 SDVOSB Track GSA Schedule 70 SDVOSB: GS-35F-0646S GSA MOBIS Schedule: GS-10F-0404Y ISO 20000 / ISO 27001 Notice: This e-mail message, including any attachments, is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, copy, use, disclosure, or distribution is STRICTLY prohibited. If you are not the intended recipient, please contact the sender by reply e-mail and destroy all copies of the original message.

3 3

[libvirt] qemu: domain notification for serial channel changes
by Matt Broadstone 07 Nov '16

07 Nov '16

Hi, I was in the process of implementing a custom qemu agent which communicates over virtio-serial channels, when I noticed that the only way to receive channel state change notifications was to poll the domstatus XML file. There does seem to be code in libvirt to monitor for serial change events (https://libvirt.org/git/?p=libvirt.git;a=blob;f=src/qemu/qemu_driver.c;h=38…) however it's hardcoded/specific to the qemu-ga (explicitly checking for ports named "org.qemu.guest_agent.0"). It occurs to me that while there was a class of events added for guest lifecycle changes, it might be a more generic solution to provide events for character device changes. Am I missing some existing functionality here? I'm a first-time poster here so I was hoping to both signal my intent to implement something more generic, as well as ping the community to see if there would be interest in this work or reasons why I shouldn't be doing this. Regards, Matt

3 6

[libvirt] [PATCH v2] bhyve: add e1000 nic support
by Roman Bogorodskiy 07 Nov '16

07 Nov '16

Changes since v1: - Fix indentation - Don't leak nic_model in bhyveBuildNetArgStr, and actually convert it to use 'goto out' to the clean up routine instead of explicit calls to VIR_FREE for every case - Add support for e1000 for argv2xml code, along with tests Roman Bogorodskiy (1): bhyve: add e1000 nic support src/bhyve/bhyve_capabilities.c | 27 ++++++++ src/bhyve/bhyve_capabilities.h | 1 + src/bhyve/bhyve_command.c | 74 ++++++++++++++-------- src/bhyve/bhyve_parse_command.c | 9 ++- tests/bhyveargv2xmldata/bhyveargv2xml-e1000.args | 8 +++ tests/bhyveargv2xmldata/bhyveargv2xml-e1000.xml | 28 ++++++++ .../bhyveargv2xmldata/bhyveargv2xml-virtio-net.xml | 2 + .../bhyveargv2xml-virtio-net4.xml | 1 + tests/bhyveargv2xmltest.c | 1 + .../bhyvexml2argvdata/bhyvexml2argv-net-e1000.args | 9 +++ .../bhyvexml2argv-net-e1000.ldargs | 3 + .../bhyvexml2argvdata/bhyvexml2argv-net-e1000.xml | 22 +++++++ tests/bhyvexml2argvtest.c | 7 +- 13 files changed, 162 insertions(+), 30 deletions(-) create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-e1000.args create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-e1000.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-net-e1000.xml -- 2.9.2

2 3

[libvirt] [PATCH 00/17] Redo website layout and branding
by Daniel P. Berrange 07 Nov '16

07 Nov '16

The current libvirt website design dates from 2008 and has not changed significantly since. Compared to contemporary open source project websites it looks pretty dated and cluttered. This series incrementally changes the website to have a completely new layout and branding. Since the original adobe illustrator files are long since lost, this series introduces a newly created variant of the libvirt logo with Inkscape as an SVG file. The libvirt logo used a specific font with angled tops to letters like "l", "b" and "t" - this is the "Overpass" font, made available by Red Hat under an open source font license. The re-branding makes use of webfont support so that we can use this font across the entire libvirt website for a consistent look. The colors of the website CSS now exactly match the colors used in the logo in most places. The bigger change is in the layout, with the huge left hand sitemap nav bar being removed to give more space to the main content. The front page now directly links to the key pages that were shown to be highly visited in the apache web logs. Most of the rest of the links are now available from the "docs.html" page linked from "Learn" in the top nav bar. Another key change is that the download page now covers all language bindings, test suites, docs released by the project, not merely the core C library. Finally a new page "contribute.html" is added as the source of information useful to people wishing to get involved in the libvirt project. View the new site here https://berrange.fedorapeople.org/libvirt-new-website/ Note that the front page includes a feed of 4 most recent blog posts, however, if visiting over https:// this will be blocked by browsers. In firefox you can tell it to allow http:// content temporarily at which point the feed will appear. I'll be doing a proper fix by getting a TLS cert for virt-tools.org website setup. Daniel P. Berrange (17): docs: use overpass font for website docs: switch to new website banner docs: redo style of front page docs: add footer to all pages docs: simplify style for headers docs: add page describing contribution to libvirt docs: add three core links in the header bar docs: remove todo page docs: remove related links page Revert "syntax-check: Enforce <code> inside <dt> elements" docs: rewrite content on front page to be more useful docs: expand downloads page to cover all modules docs: add some improved styling to contact page docs: fill out docs page with useful links docs: remove navigation sidebar from pages docs: remove outdated or duplicated content docs: add master SVG for libvirt logo cfg.mk | 20 +- docs/404.html.in | 5 - docs/Makefile.am | 50 +- docs/archdomain.html.in | 7 - docs/archnetwork.html.in | 54 - docs/archnode.html.in | 7 - docs/archstorage.html.in | 32 - docs/contact.html.in | 4 +- docs/contribute.html.in | 140 ++ docs/deployment.html.in | 50 - docs/docs.html.in | 161 +- docs/downloads.html.in | 391 ++++- docs/fonts/LICENSE.md | 90 ++ docs/fonts/hinted-Overpass-Bold.woff | Bin 0 -> 48136 bytes docs/fonts/hinted-Overpass-BoldItalic.woff | Bin 0 -> 51008 bytes docs/fonts/hinted-Overpass-Italic.woff | Bin 0 -> 51908 bytes docs/fonts/hinted-Overpass-Light.woff | Bin 0 -> 49452 bytes docs/fonts/hinted-Overpass-LightItalic.woff | Bin 0 -> 51752 bytes docs/fonts/hinted-Overpass-Reg.woff | Bin 0 -> 48144 bytes docs/fonts/stylesheet.css | 55 + docs/formatsnapshot.html.in | 6 +- docs/generic.css | 11 +- docs/hvsupport.pl | 3 - docs/index.html.in | 162 +- docs/intro.html.in | 13 - docs/js/jquery-3.1.1.min.js | 4 + docs/js/jquery.rss.min.js | 11 + docs/js/moment.min.js | 7 + docs/libvirt-header-bg.png | Bin 1136 -> 0 bytes docs/libvirt-header-logo.png | Bin 25945 -> 0 bytes docs/libvirt-net-logical.fig | 159 -- docs/libvirt-net-logical.png | Bin 11243 -> 0 bytes docs/libvirt-net-physical.fig | 139 -- docs/libvirt-net-physical.png | Bin 11336 -> 0 bytes docs/libvirt.css | 319 ++-- docs/libvirtLogo.png | Bin 33698 -> 0 bytes docs/libvirtLogo404.png | Bin 32442 -> 0 bytes docs/logo-large-banner.png | Bin 0 -> 86032 bytes docs/logo-small-banner-light.png | Bin 0 -> 19049 bytes docs/logo.svg | 2153 +++++++++++++++++++++++++++ docs/main.css | 1 + docs/page.xsl | 101 +- docs/pending.html.in | 10 - docs/relatedlinks.html.in | 88 -- docs/remote.html.in | 2 +- docs/search.php.in | 2 - docs/sitemap.html.in | 490 ------ docs/todo.cfg-example | 26 - docs/todo.pl | 125 -- 49 files changed, 3263 insertions(+), 1635 deletions(-) delete mode 100644 docs/archdomain.html.in delete mode 100644 docs/archnetwork.html.in delete mode 100644 docs/archnode.html.in delete mode 100644 docs/archstorage.html.in create mode 100644 docs/contribute.html.in delete mode 100644 docs/deployment.html.in create mode 100644 docs/fonts/LICENSE.md create mode 100644 docs/fonts/hinted-Overpass-Bold.woff create mode 100644 docs/fonts/hinted-Overpass-BoldItalic.woff create mode 100644 docs/fonts/hinted-Overpass-Italic.woff create mode 100644 docs/fonts/hinted-Overpass-Light.woff create mode 100644 docs/fonts/hinted-Overpass-LightItalic.woff create mode 100644 docs/fonts/hinted-Overpass-Reg.woff create mode 100644 docs/fonts/stylesheet.css delete mode 100644 docs/intro.html.in create mode 100644 docs/js/jquery-3.1.1.min.js create mode 100644 docs/js/jquery.rss.min.js create mode 100644 docs/js/moment.min.js delete mode 100644 docs/libvirt-header-bg.png delete mode 100644 docs/libvirt-header-logo.png delete mode 100644 docs/libvirt-net-logical.fig delete mode 100644 docs/libvirt-net-logical.png delete mode 100644 docs/libvirt-net-physical.fig delete mode 100644 docs/libvirt-net-physical.png delete mode 100644 docs/libvirtLogo.png delete mode 100644 docs/libvirtLogo404.png create mode 100644 docs/logo-large-banner.png create mode 100644 docs/logo-small-banner-light.png create mode 100644 docs/logo.svg delete mode 100644 docs/pending.html.in delete mode 100644 docs/relatedlinks.html.in delete mode 100644 docs/sitemap.html.in delete mode 100644 docs/todo.cfg-example delete mode 100755 docs/todo.pl -- 2.9.3

8 43

[libvirt] [PATCH v2 0/3] wireshark: Further build system fixes
by Andrea Bolognani 07 Nov '16

07 Nov '16

Changes from v1: * don't attempt to strip the wireshark prefix when we're building the plugindir ourselves * use exec_prefix instead of prefix everywhere (suggested by Viktor Mihajlovski) Andrea Bolognani (3): wireshark: Don't redefine ws_plugindir wireshark: Make fallback path construction more reliable wireshark: Use ${exec_prefix} instead of ${prefix} m4/virt-wireshark.m4 | 25 +++++++++++++------------ tools/Makefile.am | 1 - 2 files changed, 13 insertions(+), 13 deletions(-) -- 2.7.4

2 5

[libvirt] [RFC 0/5] Qemu: s390: Cpu Model Support
by Jason J. Herne 04 Nov '16

04 Nov '16

Thanks for all your feedback up to this point. We've made some progress on this and we also have a few questions. Please let us know if we're on the right track or if we're off in the weeds on this. Here is what we have so far. Patch #1 updates s390's cpu driver to support some operations needed for cpu model support within Libvirt's existing infrastructure. Patch #2 removes s390's hard coded "host" model string. Jiri thought it made more sense to simply leave this blank. Path #3 adds qmp query-cpu-model-expansion command. Patch #4 probes Qemu's view of the host model (query-cpu-model-expansion), caches the response and uses it to fill in qemuCaps->hostCpuModel. Archs that do not implement query-cpu-model-expansion will continue to fill in qemuCaps->hostCpuModel from caps->host.cpu. Patch #5 updates qemuBuildCpuModelArgStr's VIR_CPU_MODE_HOST_MODEL case. It seems like all archs except PPC64 do not support host model mode. We add an s390 path here and get the guest cpu model from virQEMUCapsGetHostModel() which will get the model name from qemuCaps->hostCpuModel. NOTE: I just realized we'll need need to handle the case where virQEMUCapsGetHostModel returns NULL or the model is NULL or "". We probably should just throw an error and give up in that case. Here is a list of outstanding things to do and some questions. 1. virsh domcapabilities --emulatorbin flag This works today if the command is passed --emulatorbin /usr/bin/qemu-kvm. If no emulatorbin is given then Libvirt seems to choose /usr/bin/qemu-system-s390x my system which does not have kvm enabled. A kvm session is needed for s390 to properly compute the host model. A kvm session is only available for the qemu-kvm binary. Is the answer to tell our users to always supply --emulatorbin with /usr/bin/qemu-kvm argument? Or is there a more user friendly solution to this? 2. virsh baseline and compare support. Both of these commands, for s390 at least, will need to spin up a Qemu session with monitor to compute the result. The only place I see this done today is qemu_capabilities. Rather than blindly duplicate the code, I guess we should carve out some type of api for spinning up a monitor backed Qemu instance, yes? Also, neither compare nor baseline have the --emulatorbin flag. So we'll either need to add them or find an alternate solution. Any thoughts on this? 3.Support host passthrough mode. This essentially just means passing -cpu host to qemu. We know Qemu supports this for s390 today. But Libvirt claims it is not supported due to the following: In virQEMUCapsIsCPUModeSupported, our virt "type" is VIR_DOMAIN_VIRT_QEMU, and not VIR_DOMAIN_VIRT_KVM. virttype comes from domCaps and is set here: qemuConnectGetDomainCapabilities() The relevant code is: if (qemuHostdevHostSupportsPassthroughLegacy() || qemuHostdevHostSupportsPassthroughVFIO()) virttype = VIR_DOMAIN_VIRT_KVM; else virttype = VIR_DOMAIN_VIRT_QEMU; I'll admit, I have not been able to figure out why these checks are failing in my test environment, when I suspect they should be passing. But in my case it seems as though these relate to host device passthrough. How do they apply to cpu model passthrough. What am I missing? Thanks for your time. Collin L. Walling (3): s390: Report blank host model instead of "host" qemu: qmp query-cpu-model-expansion command qemu-caps: Get host model directly from Qemu when available Jason J. Herne (2): s390: Cpu driver support for getModels, update and compare s390: qemu: Support cpu host-model mode src/cpu/cpu_s390.c | 33 +++++++++++++-- src/qemu/qemu_capabilities.c | 88 ++++++++++++++++++++++++++++++++++++++- src/qemu/qemu_command.c | 3 ++ src/qemu/qemu_monitor.c | 28 +++++++++++++ src/qemu/qemu_monitor.h | 19 +++++++++ src/qemu/qemu_monitor_json.c | 98 ++++++++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_monitor_json.h | 6 +++ 7 files changed, 271 insertions(+), 4 deletions(-) -- 1.9.1

3 19

[libvirt] [PATCH glib] Add missing dep on intltool
by Daniel P. Berrange 04 Nov '16

04 Nov '16

Libvirt-glib requires intltool at build time. Previously it was pulled in transitively via another RPM dependancy. As of Fedora 26, this no longer happens, exposing the missing RPM dep. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a build fix for rawhide libvirt-glib.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/libvirt-glib.spec.in b/libvirt-glib.spec.in index 2ec8337..a1ca11f 100644 --- a/libvirt-glib.spec.in +++ b/libvirt-glib.spec.in @@ -37,6 +37,7 @@ BuildRequires: libtool %if %{with_vala} BuildRequires: vala-tools %endif +BuildRequires: intltool %package devel Group: Development/Libraries -- 2.9.3

1 0

[libvirt] ANNOUNCE: libvirt-glib release 1.0.0
by Daniel P. Berrange 04 Nov '16

04 Nov '16

I am pleased to announce that a new release of the libvirt-glib package, version 1.0.0, is now available from ftp://libvirt.org/libvirt/glib/ The packages are GPG signed with Key fingerprint: DAF3 A6FD B26B 6291 2D0E 8E3F BE86 EBB4 1510 4FDF (4096R) Changes in this release: - Switch to new release numbering scheme, major digit incremented each year, minor for each release, micro for stable branches (if any) - Fix Libs.private variable in pkg-config file - Fix git introspection warnings - Add ability to set SPICE gl property - Add support for virtio video model - Add support for 3d accel property - Add support for querying video model - Add support for host device config for PCI devs - Add docs for more APIs - Avoid unused variable warnings - Fix check for libvirt optional features to use pkg-config - Delete manually written python binding. All apps should use PyGObject with gobjection introspection. - Add schema to be NULL on config objects - Preserve unknown devices listed in XML - Add further test coverage libvirt-glib comprises three distinct libraries: - libvirt-glib - Integrate with the GLib event loop and error handling - libvirt-gconfig - Representation of libvirt XML documents as GObjects - libvirt-gobject - Mapping of libvirt APIs into the GObject type system NB: While libvirt aims to be API/ABI stable forever, with libvirt-glib we are not currently guaranteeing that libvirt-glib libraries are permanently API/ABI stable. That said we do not expect to break the API/ABI for the forseeable future and will always strive avoid it. Follow up comments about libvirt-glib should be directed to the regular libvir-list(a)redhat.com development list. Thanks to all the people involved in contributing to this release. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|

1 0

[libvirt] [PATCH] qemu: Fix build on RHEL-6
by Jiri Denemark 04 Nov '16

04 Nov '16

Commit c29e6d4805 cause build failure on RHEL-6: ../../src/qemu/qemu_capabilities.c: In function 'virQEMUCapsIsValid': ../../src/qemu/qemu_capabilities.c:4085: error: declaration of 'ctime' shadows a global declaration [-Wshadow] /usr/include/time.h:258: error: shadowed declaration is here [-Wshadow] Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/qemu/qemu_capabilities.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index ffe7bcd..747226c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -4082,12 +4082,12 @@ virQEMUCapsNewForBinary(virCapsPtr caps, bool virQEMUCapsIsValid(virQEMUCapsPtr qemuCaps, - time_t ctime) + time_t qemuctime) { if (!qemuCaps->binary) return true; - if (!ctime) { + if (!qemuctime) { struct stat sb; if (stat(qemuCaps->binary, &sb) < 0) { @@ -4097,14 +4097,14 @@ virQEMUCapsIsValid(virQEMUCapsPtr qemuCaps, virStrerror(errno, ebuf, sizeof(ebuf))); return false; } - ctime = sb.st_ctime; + qemuctime = sb.st_ctime; } - if (ctime != qemuCaps->ctime) { + if (qemuctime != qemuCaps->ctime) { VIR_DEBUG("Outdated capabilities for '%s': QEMU binary changed " "(%lld vs %lld)", qemuCaps->binary, - (long long) ctime, (long long) qemuCaps->ctime); + (long long) qemuctime, (long long) qemuCaps->ctime); return false; } -- 2.10.2

2 1

[libvirt] [libvirt-glib] tests: Don't leak xml data in test-gconfig-device-unknown
by Christophe Fergeau 04 Nov '16

04 Nov '16

--- tests/test-gconfig.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-gconfig.c b/tests/test-gconfig.c index 9cf3f12..2c98c25 100644 --- a/tests/test-gconfig.c +++ b/tests/test-gconfig.c @@ -782,6 +782,7 @@ static void test_domain_device_unknown(void) g_list_free_full(devices, g_object_unref); g_object_unref(G_OBJECT(domain)); + g_free(xml); } -- 2.9.3

2 1

[libvirt] [PATCH v2 00/19] Avoid races with udev
by Michal Privoznik 04 Nov '16

04 Nov '16

This is v2 of: https://www.redhat.com/archives/libvir-list/2016-October/msg01151.html diff to v1: - Added udev rule (patch 18/19) - Wire the beast into spec file - Introduced a configure argument that suppress installation of this feature One of the problems here is that this requires patched udev: https://github.com/systemd/systemd/commit/4f985bd80278972912b80df1390f84d7a… This is going to be part of systemd-232 release. Therefore, in my code I've put checks for 232 version. Michal Privoznik (19): virseclabel.h: Include stdbool.h virseclabel: Introduce virSecurityDeviceLabelDefNewLabel security_dac: Pass manager to virSecurityDACSetImageLabel security_dac: Pass manager to virSecurityDACRestoreFileLabelInternal virudev: Introduce basic skeleton virudev: Implement virUdevMgrAddLabel and virUdevMgrRemoveAllLabels virudev: Introduce virUdevMgrDump tests: Introduce virudevtest virudev: Parse virUdevMgr from JSON virudev: Introduce virUdevMgrLookupLabels util: Introduce libvirt_udevhelper security: Wire up virUdevMgr qemu.conf: Introduce write_udev qemu: Wire up virUdevMgr qemu: Reload virUdevMgr on start virudevtest: Introduce device filtering qemu: Filter uninteresting paths for virUdevMgr udev: Introduce rule spec: Install udev helper/rule more cleanly daemon/99-libvirt.rules | 12 + daemon/Makefile.am | 22 +- libvirt.spec.in | 26 ++ m4/virt-udev.m4 | 26 ++ po/POTFILES.in | 2 + src/Makefile.am | 25 ++ src/libvirt_private.syms | 15 + src/qemu/libvirtd_qemu.aug | 1 + src/qemu/qemu.conf | 5 + src/qemu/qemu_conf.c | 3 + src/qemu/qemu_conf.h | 5 + src/qemu/qemu_domain.c | 12 +- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 40 +- src/qemu/qemu_hotplug.c | 35 +- src/qemu/qemu_process.c | 47 ++- src/qemu/qemu_process.h | 3 + src/qemu/test_libvirtd_qemu.aug.in | 1 + src/security/security_dac.c | 103 ++++-- src/security/security_manager.c | 16 + src/security/security_manager.h | 5 + src/security/security_selinux.c | 47 ++- src/util/udevhelper.c | 137 +++++++ src/util/virseclabel.c | 14 + src/util/virseclabel.h | 6 + src/util/virudev.c | 588 ++++++++++++++++++++++++++++++ src/util/virudev.h | 63 ++++ tests/Makefile.am | 12 + tests/virudevmock.c | 29 ++ tests/virudevtest.c | 312 ++++++++++++++++ tests/virudevtestdata/complex.json | 30 ++ tests/virudevtestdata/empty.json | 5 + tests/virudevtestdata/simple-dac.json | 13 + tests/virudevtestdata/simple-selinux.json | 13 + 34 files changed, 1619 insertions(+), 57 deletions(-) create mode 100644 daemon/99-libvirt.rules create mode 100644 src/util/udevhelper.c create mode 100644 src/util/virudev.c create mode 100644 src/util/virudev.h create mode 100644 tests/virudevmock.c create mode 100644 tests/virudevtest.c create mode 100644 tests/virudevtestdata/complex.json create mode 100644 tests/virudevtestdata/empty.json create mode 100644 tests/virudevtestdata/simple-dac.json create mode 100644 tests/virudevtestdata/simple-selinux.json -- 2.8.4

2 26

[libvirt] [glib v3] Allow unknown devices in domain XML config
by Zeeshan Ali 04 Nov '16

04 Nov '16

Changes in this version of series: In the newly added test case, ensure: * all device objects are freed * devices XML tree remains the same.

3 8

[libvirt] [PATCH] docs: Add Qt Virtual machines manager and Qt Remote viewer
by Alexander Vasilenko 04 Nov '16

04 Nov '16

--- docs/apps.html.in | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/apps.html.in b/docs/apps.html.in index 1a138b3..4efb318 100644 --- a/docs/apps.html.in +++ b/docs/apps.html.in @@ -208,6 +208,17 @@ to remote consoles supporting the VNC protocol. Also provides an optional mozilla browser plugin. </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager">qt-virt-manager</a></dt> + <dd> + The Qt GUI for create and control VMs and another virtual entities + (aka networks, storages, interfaces, secrets, network filters). + Contains integrated LXC/SPICE/VNC viewer for accessing the graphical or + text console associated with a virtual machine or container. + </dd> + <dt><a href="http://f1ash.github.io/qt-virt-manager/#virtual-machines-viewer">qt-remote-viewer</a></dt> + <dd> + The Qt VNC/SPICE viewer for access to remote desktops or VMs. + </dd> </dl> <h2><a name="iaas">Infrastructure as a Service (IaaS)</a></h2> -- 2.10.1

2 1

[libvirt] [PATCH] vshReadlineParse: Remove unused variable
by Michal Privoznik 04 Nov '16

04 Nov '16

After 06a7b1ff4 the @&opts_need_arg is not used anywhere. Well, it is set but never read: vsh.c: In function 'vshReadlineParse': vsh.c:2658:14: warning: variable 'opts_need_arg' set but not used [-Wunused-but-set-variable] uint64_t opts_need_arg, opts_seen; ^~~~~~~~~~~~~ Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- tools/vsh.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/vsh.c b/tools/vsh.c index 17199ae..f7ba070 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2655,7 +2655,7 @@ vshReadlineParse(const char *text, int state) static char **completed_list; static unsigned int completed_list_index; static uint64_t const_opts_need_arg, const_opts_required, const_opts_seen; - uint64_t opts_need_arg, opts_seen; + uint64_t opts_seen; size_t opt_index; static bool cmd_exists, opts_filled, opt_exists; static bool non_bool_opt_exists, data_complete; @@ -2728,7 +2728,6 @@ vshReadlineParse(const char *text, int state) if (vshCmddefOptParse(cmd, &const_opts_need_arg, &const_opts_required) < 0) goto error; - opts_need_arg = const_opts_need_arg; opts_seen = const_opts_seen; opts_filled = true; } else if (tkdata[0] == '-' && tkdata[1] == '-' && @@ -2793,7 +2792,6 @@ vshReadlineParse(const char *text, int state) || opt->type == VSH_OT_BOOL) goto error; opt_exists = true; - opts_need_arg = const_opts_need_arg; opts_seen = const_opts_seen; } else { /* In every other case, return NULL */ -- 2.8.4

2 1

[libvirt] Libvirt build broken
by Wei Liu 03 Nov '16

03 Nov '16

Hi Xen Project's CI system found a build failure between libvirt changes 06a7b1ff..478ddedc. I don't think this is Xen specific FWIW. The build log can be found at: http://logs.test-lab.xenproject.org/osstest/logs/101868/build-amd64-libvirt… The first error: CC libvirt_driver_la-libvirt-host.lo libvirt.c:320:15: error: variable 'virTLSThreadImpl' has initializer but incomplete type static struct gcry_thread_cbs virTLSThreadImpl = { ^ Earlier in configure: configure: gnutls: no >From the look of it configure doesn't work properly anymore. Wei.

4 4

[libvirt] [PATCH] configure: check gnutls related stuff only if gnutls was found
by Pavel Hrdina 03 Nov '16

03 Nov '16

This fixes a build issue with old gnutls. Broken by commit 680d2f49da. Reported-by: Olga Krishtal <okrishtal(a)virtuozzo.com> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under build-breaker rule. m4/virt-gnutls.m4 | 64 ++++++++++++++++++++++++++++--------------------------- 1 file changed, 33 insertions(+), 31 deletions(-) diff --git a/m4/virt-gnutls.m4 b/m4/virt-gnutls.m4 index 9e8bfb1..b850828 100644 --- a/m4/virt-gnutls.m4 +++ b/m4/virt-gnutls.m4 @@ -20,41 +20,43 @@ dnl AC_DEFUN([LIBVIRT_CHECK_GNUTLS],[ LIBVIRT_CHECK_PKG([GNUTLS], [gnutls], [2.2.0]) - dnl Double probe: gnutls >= 2.12 had a configure option for gcrypt and - dnl gnutls >= 3.0 uses only nettle. Our goal is to avoid gcrypt if we - dnl can prove gnutls uses nettle, but it is a safe fallback to use gcrypt - dnl if we can't prove anything. - - GNUTLS_GCRYPT= - if $PKG_CONFIG --exists 'gnutls >= 3.0'; then - GNUTLS_GCRYPT="no" - else - GNUTLS_GCRYPT="probe" - fi + if test "$with_gnutls" = "yes" ; then + dnl Double probe: gnutls >= 2.12 had a configure option for gcrypt and + dnl gnutls >= 3.0 uses only nettle. Our goal is to avoid gcrypt if we + dnl can prove gnutls uses nettle, but it is a safe fallback to use gcrypt + dnl if we can't prove anything. - if test "$GNUTLS_GCRYPT" = "probe"; then - case $($PKG_CONFIG --libs --static gnutls) in - *gcrypt*) GNUTLS_GCRYPT=yes ;; - *nettle*) GNUTLS_GCRYPT=no ;; - *) GNUTLS_GCRYPT=unknown ;; - esac - fi + GNUTLS_GCRYPT= + if $PKG_CONFIG --exists 'gnutls >= 3.0'; then + GNUTLS_GCRYPT="no" + else + GNUTLS_GCRYPT="probe" + fi - if test "$GNUTLS_GCRYPT" = "yes" || test "$GNUTLS_GCRYPT" = "unknown"; then - GNUTLS_LIBS="$GNUTLS_LIBS -lgcrypt" - dnl We're not using gcrypt deprecated features so define - dnl GCRYPT_NO_DEPRECATED to avoid deprecated warnings - GNUTLS_CFLAGS="$GNUTLS_CFLAGS -DGCRYPT_NO_DEPRECATED" - AC_DEFINE_UNQUOTED([WITH_GNUTLS_GCRYPT], 1, - [set to 1 if it is known or assumed that GNUTLS uses gcrypt]) - fi + if test "$GNUTLS_GCRYPT" = "probe"; then + case $($PKG_CONFIG --libs --static gnutls) in + *gcrypt*) GNUTLS_GCRYPT=yes ;; + *nettle*) GNUTLS_GCRYPT=no ;; + *) GNUTLS_GCRYPT=unknown ;; + esac + fi - AC_CHECK_HEADERS([gnutls/crypto.h], [], [], [[ - #include <gnutls/gnutls.h> - ]]) + if test "$GNUTLS_GCRYPT" = "yes" || test "$GNUTLS_GCRYPT" = "unknown"; then + GNUTLS_LIBS="$GNUTLS_LIBS -lgcrypt" + dnl We're not using gcrypt deprecated features so define + dnl GCRYPT_NO_DEPRECATED to avoid deprecated warnings + GNUTLS_CFLAGS="$GNUTLS_CFLAGS -DGCRYPT_NO_DEPRECATED" + AC_DEFINE_UNQUOTED([WITH_GNUTLS_GCRYPT], 1, + [set to 1 if it is known or assumed that GNUTLS uses gcrypt]) + fi - AC_CHECK_FUNC([gnutls_rnd]) - AC_CHECK_FUNC([gnutls_cipher_encrypt]) + AC_CHECK_HEADERS([gnutls/crypto.h], [], [], [[ + #include <gnutls/gnutls.h> + ]]) + + AC_CHECK_FUNC([gnutls_rnd]) + AC_CHECK_FUNC([gnutls_cipher_encrypt]) + fi ]) AC_DEFUN([LIBVIRT_RESULT_GNUTLS],[ -- 2.10.2

1 0

[libvirt] [PATCH] gcrypt: fix build in case we do not use gnutls and gcrypt
by Olga Krishtal 03 Nov '16

03 Nov '16

In case when we use any crypt library and gnutls make returns compilation errors. Signed-off-by: Olga Krishtal <okrishtal(a)virtuozzo.com> --- src/libvirt.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/libvirt.c b/src/libvirt.c index 52462e3..77365d1 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -269,7 +269,7 @@ virWinsockInit(void) } #endif - +#ifdef WITH_GNUTLS #ifdef WITH_GNUTLS_GCRYPT static int virTLSMutexInit(void **priv) @@ -332,6 +332,7 @@ static struct gcry_thread_cbs virTLSThreadImpl = { NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL }; #endif /* WITH_GNUTLS_GCRYPT */ +#endif /* WITH_GNUTLS */ static bool virGlobalError; @@ -357,6 +358,7 @@ virGlobalInit(void) } #endif +#ifdef WITH_GNUTLS #ifdef WITH_GNUTLS_GCRYPT /* * This sequence of API calls it copied exactly from @@ -371,13 +373,10 @@ virGlobalInit(void) gcry_control(GCRYCTL_DISABLE_SECMEM, NULL, 0); gcry_control(GCRYCTL_INITIALIZATION_FINISHED, NULL, 0); } -#endif - - virLogSetFromEnv(); - -#ifdef WITH_GNUTLS +#endif /* End of WITH_GNUTLS_GCRYPT*/ virNetTLSInit(); -#endif +#endif /* End of WITH_GNUTLS*/ + virLogSetFromEnv(); #if WITH_CURL curl_global_init(CURL_GLOBAL_DEFAULT); -- 1.8.3.1

3 4