- Devel - libvirt List Archives

[libvirt] [libvirt-ci][PATCH] Remove builders for Centos 6
by Michal Privoznik 13 Dec '16

13 Dec '16

These builds often fails with false positives due to ancient compiler found on this system. For instance it fails to see when symbol is used as a variable and when it is used as a function producing the following warnings: ../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow] /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow] Users trying to use libvirt from git on stable system are doomed to fix it themselves. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- projects/libvirt-cim.yaml | 1 - projects/libvirt-python.yaml | 1 - projects/libvirt.yaml | 3 --- 3 files changed, 5 deletions(-) diff --git a/projects/libvirt-cim.yaml b/projects/libvirt-cim.yaml index d1705af..dd40eb1 100644 --- a/projects/libvirt-cim.yaml +++ b/projects/libvirt-cim.yaml @@ -2,7 +2,6 @@ - project: name: libvirt-cim machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 diff --git a/projects/libvirt-python.yaml b/projects/libvirt-python.yaml index baca308..adf22f4 100644 --- a/projects/libvirt-python.yaml +++ b/projects/libvirt-python.yaml @@ -2,7 +2,6 @@ - project: name: libvirt-python machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml index 20de27c..2b4e5d3 100644 --- a/projects/libvirt.yaml +++ b/projects/libvirt.yaml @@ -2,7 +2,6 @@ - project: name: libvirt machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 @@ -13,7 +12,6 @@ - autotools-build-job: parent_jobs: machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - libvirt-fedora-23 @@ -23,7 +21,6 @@ - autotools-syntax-check-job: parent_jobs: 'libvirt-master-build' machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - libvirt-fedora-23 -- 2.11.0

2 3

[libvirt] [libvirt-perl][PATCH] Add PERF_PARAM_BRANCH_MISSES constant
by Michal Privoznik 13 Dec '16

13 Dec '16

Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Changes | 1 + Virt.xs | 1 + lib/Sys/Virt/Domain.pm | 7 +++++++ 3 files changed, 9 insertions(+) diff --git a/Changes b/Changes index b1248c9..ffb1911 100644 --- a/Changes +++ b/Changes @@ -4,6 +4,7 @@ Revision history for perl module Sys::Virt - Add group_name for block iotune - Add new branch instructions perf event + - Add PERF_PARAM_BRANCH_MISSES constant 2.5.0 2016-12-05 diff --git a/Virt.xs b/Virt.xs index b081793..65f4975 100644 --- a/Virt.xs +++ b/Virt.xs @@ -8302,6 +8302,7 @@ BOOT: REGISTER_CONSTANT_STR(VIR_PERF_PARAM_CPU_CYCLES, PERF_PARAM_CPU_CYCLES); REGISTER_CONSTANT_STR(VIR_PERF_PARAM_INSTRUCTIONS, PERF_PARAM_INSTRUCTIONS); REGISTER_CONSTANT_STR(VIR_PERF_PARAM_BRANCH_INSTRUCTIONS, PERF_PARAM_BRANCH_INSTRUCTIONS); + REGISTER_CONSTANT_STR(VIR_PERF_PARAM_BRANCH_MISSES, PERF_PARAM_BRANCH_MISSES); REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_AVERAGE, BANDWIDTH_IN_AVERAGE); REGISTER_CONSTANT_STR(VIR_DOMAIN_BANDWIDTH_IN_PEAK, BANDWIDTH_IN_PEAK); diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index faacc0a..3d9b106 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -2776,6 +2776,13 @@ the count of instructions by applications running on the platform. It corresponds to the "perf.branch_instructions" field in the *Stats APIs. +=item Sys::Virt::Domain::PERF_PARAM_BRANCH_MISSES + +The branch_misses perf event which can be used to measure the +count of branch misses by applications running on the platform. +It corresponds to the "perf.branch_misses" field in the *Stats +APIs. + =back =head2 VCPU FLAGS -- 2.11.0

2 1

[libvirt] [PATCH] formatnetwork: Cleanup /network/ip documentation
by Jiri Denemark 13 Dec '16

13 Dec '16

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- docs/formatnetwork.html.in | 125 ++++++++++++++++++++++----------------------- 1 file changed, 60 insertions(+), 65 deletions(-) diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in index cc7d7c7e7..9cf940052 100644 --- a/docs/formatnetwork.html.in +++ b/docs/formatnetwork.html.in @@ -968,49 +968,44 @@ </dd> <dt><code>ip</code></dt> <dd>The <code>address</code> attribute defines an IPv4 address in - dotted-decimal format, or an IPv6 address in standard - colon-separated hexadecimal format, that will be configured on - the bridge - device associated with the virtual network. To the guests this IPv4 - address will be their IPv4 default route. For IPv6, the default route is - established via Router Advertisement. - For IPv4 addresses, the <code>netmask</code> - attribute defines the significant bits of the network address, - again specified in dotted-decimal format. For IPv6 addresses, - and as an alternate method for IPv4 addresses, you can specify - the significant bits of the network address with the <code>prefix</code> - attribute, which is an integer (for example, <code>netmask='255.255.255.0'</code> - could also be given as <code>prefix='24'</code>. The <code>family</code> - attribute is used to specify the type of address - 'ipv4' or 'ipv6'; if no - <code>family</code> is given, 'ipv4' is assumed. A network can have more than - one of each family of address defined, but only a single IPv4 address can have a - <code>dhcp</code> or <code>tftp</code> element. Since 0.3.0 - IPv6, multiple addresses on a single network, <code>family</code>, and - <code>prefix</code> are support Since 0.8.7. - Similar to IPv4, one IPv6 address per network can also have - a <code>dhcp</code> definition. Since 1.0.1 + dotted-decimal format, or an IPv6 address in standard colon-separated + hexadecimal format, that will be configured on the bridge device + associated with the virtual network. To the guests this IPv4 address + will be their IPv4 default route. For IPv6, the default route is + established via Router Advertisement. For IPv4 addresses, the + <code>netmask</code> attribute defines the significant bits of the + network address, again specified in dotted-decimal format. For IPv6 + addresses, and as an alternate method for IPv4 addresses, the + significant bits of the network address can be specified with the + <code>prefix</code> attribute, which is an integer (for example, + <code>netmask='255.255.255.0'</code> could also be given as + <code>prefix='24'</code>). The <code>family</code> attribute is used + to specify the type of address — <code>ipv4</code> or + <code>ipv6</code>; if no <code>family</code> is given, + <code>ipv4</code> is assumed. More than one address of each family can + be defined for a network. The <code>ip</code> element is supported + since 0.3.0. IPv6, multiple addresses on a + single network, <code>family</code>, and <code>prefix</code> are + supported since 0.8.7. The <code>ip</code> + element may contain the following elements: <dl> <dt><code>tftp</code></dt> - <dd>Immediately within - the <code>ip</code> element there is an optional <code>tftp</code> - element. The presence of this element and of its attribute - <code>root</code> enables TFTP services. The attribute specifies - the path to the root directory served via TFTP. <code>tftp</code> is not - supported for IPv6 addresses, and can only be specified on a single IPv4 address - per network. + <dd>The optional <code>tftp</code> element and its mandatory + <code>root</code> attribute enable TFTP services. The attribute + specifies the path to the root directory served via TFTP. The + <code>tftp</code> element is not supported for IPv6 addresses, + and can only be specified on a single IPv4 address per network. Since 0.7.1 </dd> <dt><code>dhcp</code></dt> - <dd>Also within the <code>ip</code> element there is an - optional <code>dhcp</code> element. The presence of this element - enables DHCP services on the virtual network. It will further - contain one or more <code>range</code> elements. The - <code>dhcp</code> element supported for both - IPv4 Since 0.3.0 - and IPv6 Since 1.0.1, but - only for one IP address of each type per network. + <dd>The presence of this element enables DHCP services on the + virtual network. The <code>dhcp</code> element is supported for + both IPv4 (since 0.3.0) and IPv6 + (since 1.0.1), but only for one IP + address of each type per network. The following sub-elements are + supported: <dl> <dt><code>range</code></dt> <dd>The <code>start</code> and <code>end</code> attributes on the @@ -1020,39 +1015,39 @@ <code>ip</code> element. There may be zero or more <code>range</code> elements specified. Since 0.3.0 - <code>range</code> can be specified for one IPv4 address, - one IPv6 address, or both. Since 1.0.1 </dd> <dt><code>host</code></dt> - <dd>Within the <code>dhcp</code> element there may be zero or more - <code>host</code> elements. These specify hosts which will be given - names and predefined IP addresses by the built-in DHCP server. Any - IPv4 <code>host</code> element must specify the MAC address of the host to be assigned - a given name (via the <code>mac</code> attribute), the IP to be - assigned to that host (via the <code>ip</code> attribute), and the - name to be given that host by the DHCP server (via the - <code>name</code> attribute). Since 0.4.5 - An IPv6 <code>host</code> element differs slightly from that for IPv4: - there is no <code>mac</code> attribute since a MAC address has no - defined meaning in IPv6. Instead, the <code>name</code> attribute is - used to identify the host to be assigned the IPv6 address. For DHCPv6, - the name is the plain name of the client host sent by the - client to the server. Note that this method of assigning a - specific IP address can also be used instead of the <code>mac</code> - attribute for IPv4. Since 1.0.1 + <dd>Within the <code>dhcp</code> element there may be zero or + more <code>host</code> elements. These specify hosts which will + be given names and predefined IP addresses by the built-in DHCP + server. Any IPv4 <code>host</code> element must specify the MAC + address of the host to be assigned a given name (via the + <code>mac</code> attribute), the IP to be assigned to that host + (via the <code>ip</code> attribute), and the name itself (the + <code>name</code> attribute). The IPv6 <code>host</code> + element differs slightly from that for IPv4: there is no + <code>mac</code> attribute since a MAC address has no defined + meaning in IPv6. Instead, the <code>name</code> attribute is + used to identify the host to be assigned the IPv6 address. For + DHCPv6, the name is the plain name of the client host sent by the + client to the server. Note that this method of assigning a + specific IP address can also be used for IPv4 instead of the + <code>mac</code> attribute. + Since 0.4.5 </dd> <dt><code>bootp</code></dt> - <dd>The optional <code>bootp</code> - element specifies BOOTP options to be provided by the DHCP - server for IPv4 only. - Two attributes are supported: <code>file</code> is mandatory and - gives the file to be used for the boot image; <code>server</code> is - optional and gives the address of the TFTP server from which the boot - image will be fetched. <code>server</code> defaults to the same host - that runs the DHCP server, as is the case when the <code>tftp</code> - element is used. The BOOTP options currently have to be the same - for all address ranges and statically assigned addresses.Since 0.7.1 (<code>server</code> since 0.7.3). + <dd>The optional <code>bootp</code> element specifies BOOTP + options to be provided by the DHCP server for IPv4 only. Two + attributes are supported: <code>file</code> is mandatory and + gives the file to be used for the boot image; + <code>server</code> is optional and gives the address of the + TFTP server from which the boot image will be fetched. + <code>server</code> defaults to the same host that runs the + DHCP server, as is the case when the <code>tftp</code> element + is used. The BOOTP options currently have to be the same for + all address ranges and statically assigned addresses. Since 0.7.1 (<code>server</code> + since 0.7.3) </dd> </dl> </dd> -- 2.11.0

2 1

[libvirt] [PATCH v2 0/3] qemu: fix racy paths in agent related code
by Nikolay Shirokovskiy 13 Dec '16

13 Dec '16

Changes from v1: 1. patch 2: make vm def copy instead of making qemuAgentGetFSInfo independent of domain conf. 2. patch 3: provide more relevant commit message Nikolay Shirokovskiy (3): qemu: agent: fix uninitialized var case in qemuAgentGetFSInfo qemu: don't use vm when lock is dropped in qemuDomainGetFSInfo qemu: agent: take monitor lock in qemuAgentNotifyEvent src/qemu/qemu_agent.c | 5 +++++ src/qemu/qemu_driver.c | 12 +++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) -- 1.8.3.1

2 5

[libvirt] [PATCH] perf: add branch_misses perf event support
by Nitesh Konkar 12 Dec '16

12 Dec '16

This patch adds support and documentation for the branch_misses perf event. Signed-off-by: Nitesh Konkar <nitkon12(a)linux.vnet.ibm.com> --- docs/formatdomain.html.in | 6 ++++++ docs/schemas/domaincommon.rng | 1 + include/libvirt/libvirt-domain.h | 10 ++++++++++ src/libvirt-domain.c | 4 ++++ src/qemu/qemu_driver.c | 1 + src/util/virperf.c | 5 ++++- src/util/virperf.h | 1 + tests/genericxml2xmlindata/generic-perf.xml | 1 + tools/virsh.pod | 5 ++++- 9 files changed, 32 insertions(+), 2 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 9218eec..086af55 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -1928,6 +1928,7 @@ <event name='cache_references' enabled='no'/> <event name='cache_misses' enabled='no'/> <event name='branch_instructions' enabled='no'/> + <event name='branch_misses' enabled='no'/> </perf> ... </pre> @@ -1978,6 +1979,11 @@ <td>the count of branch instructions by applications running on the platform</td> <td><code>perf.branch_instructions</code></td> </tr> + <tr> + <td><code>branch_misses</code></td> + <td>the count of branch misses by applications running on the platform</td> + <td><code>perf.branch_misses</code></td> + </tr> </table> <h3><a name="elementsDevices">Devices</a></h3> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index c004233..bf8818d 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -428,6 +428,7 @@ <value>cache_references</value> <value>cache_misses</value> <value>branch_instructions</value> + <value>branch_misses</value> </choice> </attribute> <attribute name="enabled"> diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index f43c976..3290b10 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -2135,6 +2135,16 @@ void virDomainStatsRecordListFree(virDomainStatsRecordPtr *stats); */ # define VIR_PERF_PARAM_BRANCH_INSTRUCTIONS "branch_instructions" +/** + * VIR_PERF_PARAM_BRANCH_MISSES: + * + * Macro for typed parameter name that represents branch_misses + * perf event which can be used to measure the count of branch misses + * by applications running on the platform. It corresponds to the + * "perf.branch_misses" field in the *Stats APIs. + */ +# define VIR_PERF_PARAM_BRANCH_MISSES "branch_misses" + int virDomainGetPerfEvents(virDomainPtr dom, virTypedParameterPtr *params, int *nparams, diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6481abf..a91f432 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11229,6 +11229,10 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * "perf.branch_instructions" - The count of branch instructions as * unsigned long long. It is produced by * branch_instructions perf event. + * "perf.branch_misses" - The count of branch misses as + * unsigned long long. It is produced by + * branch_misses perf event. + * * * Note that entire stats groups or individual stat fields may be missing from * the output in case they are not supported by the given hypervisor, are not diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 842de0a..0f3a283 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9853,6 +9853,7 @@ qemuDomainSetPerfEvents(virDomainPtr dom, VIR_PERF_PARAM_CACHE_REFERENCES, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_CACHE_MISSES, VIR_TYPED_PARAM_BOOLEAN, VIR_PERF_PARAM_BRANCH_INSTRUCTIONS, VIR_TYPED_PARAM_BOOLEAN, + VIR_PERF_PARAM_BRANCH_MISSES, VIR_TYPED_PARAM_BOOLEAN, NULL) < 0) return -1; diff --git a/src/util/virperf.c b/src/util/virperf.c index 635faf1..7f630da 100644 --- a/src/util/virperf.c +++ b/src/util/virperf.c @@ -41,7 +41,7 @@ VIR_ENUM_IMPL(virPerfEvent, VIR_PERF_EVENT_LAST, "cmt", "mbmt", "mbml", "cpu_cycles", "instructions", "cache_references", "cache_misses", - "branch_instructions"); + "branch_instructions", "branch_misses"); struct virPerfEvent { int type; @@ -89,6 +89,9 @@ static struct virPerfEventAttr attrs[] = { {.type = VIR_PERF_EVENT_BRANCH_INSTRUCTIONS, .attrType = PERF_TYPE_HARDWARE, .attrConfig = PERF_COUNT_HW_BRANCH_INSTRUCTIONS}, + {.type = VIR_PERF_EVENT_BRANCH_MISSES, + .attrType = PERF_TYPE_HARDWARE, + .attrConfig = PERF_COUNT_HW_BRANCH_MISSES}, }; typedef struct virPerfEventAttr *virPerfEventAttrPtr; diff --git a/src/util/virperf.h b/src/util/virperf.h index 8ebc03c..7049a5b 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -38,6 +38,7 @@ typedef enum { VIR_PERF_EVENT_CACHE_MISSES, /* Cache misses by applications */ VIR_PERF_EVENT_BRANCH_INSTRUCTIONS, /* Count of branch instructions for applications */ + VIR_PERF_EVENT_BRANCH_MISSES, /* Count of branch misses for applications */ VIR_PERF_EVENT_LAST } virPerfEventType; diff --git a/tests/genericxml2xmlindata/generic-perf.xml b/tests/genericxml2xmlindata/generic-perf.xml index 92e5847..a1e4e1c 100644 --- a/tests/genericxml2xmlindata/generic-perf.xml +++ b/tests/genericxml2xmlindata/generic-perf.xml @@ -21,6 +21,7 @@ <event name='cache_references' enabled='no'/> <event name='cache_misses' enabled='no'/> <event name='branch_instructions' enabled='yes'/> + <event name='branch_misses' enabled='yes'/> </perf> <devices> </devices> diff --git a/tools/virsh.pod b/tools/virsh.pod index 869062a..74c05c9 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -946,7 +946,8 @@ I<--perf> returns the statistics of all enabled perf events: "perf.instructions" - the count of instructions, "perf.cache_references" - the count of cache hits, "perf.cache_misses" - the count of caches misses, -"perf.branch_instructions" - the count of application branch instructions +"perf.branch_instructions" - the count of branch instructions, +"perf.branch_misses" - the count of branch misses See the B<perf> command for more details about each event. @@ -2296,6 +2297,8 @@ B<Valid perf event names> branch_instructions - Provides the count of branch instructions executed by applications running on the platform. + branch_misses - Provides the count of branch misses executed + by applications running on the platform. B<Note>: The statistics can be retrieved using the B<domstats> command using the I<--perf> flag. -- 1.9.3

2 1

[libvirt] [PATCH] AppArmor policy: support merged-/usr.
by intrigeri 12 Dec '16

12 Dec '16

From: intrigeri <intrigeri(a)debian.org> --- examples/apparmor/libvirt-qemu | 8 ++++---- examples/apparmor/usr.lib.libvirt.virt-aa-helper | 2 +- examples/apparmor/usr.sbin.libvirtd | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/apparmor/libvirt-qemu b/examples/apparmor/libvirt-qemu index 11381d4..133c2eb 100644 --- a/examples/apparmor/libvirt-qemu +++ b/examples/apparmor/libvirt-qemu @@ -136,12 +136,12 @@ /usr/{lib,lib64}/qemu/block-rbd.so mr, # for save and resume - /bin/dash rmix, - /bin/dd rmix, - /bin/cat rmix, + /{usr/,}bin/dash rmix, + /{usr/,}bin/dd rmix, + /{usr/,}bin/cat rmix, # for restore - /bin/bash rmix, + /{usr/,}bin/bash rmix, # for usb access /dev/bus/usb/ r, diff --git a/examples/apparmor/usr.lib.libvirt.virt-aa-helper b/examples/apparmor/usr.lib.libvirt.virt-aa-helper index b34fb35..4a8f197 100644 --- a/examples/apparmor/usr.lib.libvirt.virt-aa-helper +++ b/examples/apparmor/usr.lib.libvirt.virt-aa-helper @@ -21,7 +21,7 @@ profile virt-aa-helper /usr/{lib,lib64}/libvirt/virt-aa-helper { /sys/devices/** r, /usr/{lib,lib64}/libvirt/virt-aa-helper mr, - /sbin/apparmor_parser Ux, + /{usr/,}sbin/apparmor_parser Ux, /etc/apparmor.d/libvirt/* r, /etc/apparmor.d/libvirt/libvirt-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]*-[0-9a-f]* rw, diff --git a/examples/apparmor/usr.sbin.libvirtd b/examples/apparmor/usr.sbin.libvirtd index 48651b2..934124b 100644 --- a/examples/apparmor/usr.sbin.libvirtd +++ b/examples/apparmor/usr.sbin.libvirtd @@ -47,12 +47,12 @@ /usr/bin/* PUx, /usr/sbin/virtlogd pix, /usr/sbin/* PUx, - /lib/udev/scsi_id PUx, + /{usr/,}lib/udev/scsi_id PUx, /usr/{lib,lib64}/xen-common/bin/xen-toolstack PUx, /usr/{lib,lib64}/xen/bin/* Ux, # force the use of virt-aa-helper - audit deny /sbin/apparmor_parser rwxl, + audit deny /{usr/,}sbin/apparmor_parser rwxl, audit deny /etc/apparmor.d/libvirt/** wxl, audit deny /sys/kernel/security/apparmor/features rwxl, audit deny /sys/kernel/security/apparmor/matching rwxl, -- 2.10.2

4 4

[libvirt] [PATCH 0/3] qemu: fix racy paths in agent related code
by Nikolay Shirokovskiy 12 Dec '16

12 Dec '16

Patch 1 is a nitpick I found when working on Patch 2. Patch 2 and 3 fix a couple of race conditions in code. A lot of changes is inherent refactorings in Patch 2 actually. Nikolay Shirokovskiy (3): qemu: agent: fix uninitialized var case in qemuAgentGetFSInfo qemu: don't use vmdef without domain lock qemu: agent: take monitor lock in qemuAgentNotifyEvent src/qemu/qemu_agent.c | 57 +++++++++++++-------- src/qemu/qemu_agent.h | 25 ++++++++- src/qemu/qemu_driver.c | 88 +++++++++++++++++++++++++++++++- tests/Makefile.am | 1 - tests/qemuagentdata/qemuagent-fsinfo.xml | 39 -------------- tests/qemuagenttest.c | 47 +++++++---------- 6 files changed, 164 insertions(+), 93 deletions(-) delete mode 100644 tests/qemuagentdata/qemuagent-fsinfo.xml -- 1.8.3.1

2 13

[libvirt] [PATCH] docs: Replace missing description for perf.cpu_cycles
by John Ferlan 11 Dec '16

11 Dec '16

Lost during merge of commit id '8546adf80' and '585ad00b5' Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as trivial src/libvirt-domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 6481abf..8b4e814 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -11226,6 +11226,9 @@ virConnectGetDomainCapabilities(virConnectPtr conn, * It is produced by cache_references perf event. * "perf.instructions" - The count of instructions as unsigned long long. * It is produced by instructions perf event. + * "perf.cpu_cycles" - The count of cpu cycles (total/elapsed) as an + * unsigned long long. It is produced by cpu_cycles + * perf event. * "perf.branch_instructions" - The count of branch instructions as * unsigned long long. It is produced by * branch_instructions perf event. -- 2.7.4

1 0

[libvirt] dpdk/vpp and cross-version migration for vhost
by Michael S. Tsirkin 09 Dec '16

09 Dec '16

Hi! So it looks like we face a problem with cross-version migration when using vhost. It's not new but became more acute with the advent of vhost user. For users to be able to migrate between different versions of the hypervisor the interface exposed to guests by hypervisor must stay unchanged. The problem is that a qemu device is connected to a backend in another process, so the interface exposed to guests depends on the capabilities of that process. Specifically, for vhost user interface based on virtio, this includes the "host features" bitmap that defines the interface, as well as more host values such as the max ring size. Adding new features/changing values to this interface is required to make progress, but on the other hand we need ability to get the old host features to be compatible. To solve this problem within qemu, qemu has a versioning system based on a machine type concept which fundamentally is a version string, by specifying that string one can get hardware compatible with a previous qemu version. QEMU also reports the latest version and list of versions supported so libvirt records the version at VM creation and then is careful to use this machine version whenever it migrates a VM. One might wonder how is this solved with a kernel vhost backend. The answer is that it mostly isn't - instead an assumption is made, that qemu versions are deployed together with the kernel - this is generally true for downstreams. Thus whenever qemu gains a new feature, it is already supported by the kernel as well. However, if one attempts migration with a new qemu from a system with a new to old kernel, one would get a failure. In the world where we have multiple userspace backends, with some of these supplied by ISVs, this seems non-realistic. IMO we need to support vhost backend versioning, ideally in a way that will also work for vhost kernel backends. So I'd like to get some input from both backend and management developers on what a good solution would look like. If we want to emulate the qemu solution, this involves adding the concept of interface versions to dpdk. For example, dpdk could supply a file (or utility printing?) with list of versions: latest and versions supported. libvirt could read that and - store latest version at vm creation - pass it around with the vm - pass it to qemu >From here, qemu could pass this over the vhost-user channel, thus making sure it's initialized with the correct compatible interface. As version here is an opaque string for libvirt and qemu, anything can be used - but I suggest either a list of values defining the interface, e.g. any_layout=on,max_ring=256 or a version including the name and vendor of the backend, e.g. "org.dpdk.v4.5.6". Note that typically the list of supported versions can only be extended, not shrunk. Also, if the host/guest interface does not change, don't change the current version as this just creates work for everyone. Thoughts? Would this work well for management? dpdk? vpp? Thanks! -- MST

8 21

[libvirt] [PATCH 0/2] Fix some storage vol formatting issues (code and doc)
by John Ferlan 09 Dec '16

09 Dec '16

While reviewing another set of changes I tripped across this. John Ferlan (2): conf: Format the "nocow" field. docs: Adjust pool/vol target output docs/formatstorage.html.in | 16 ++++++++-------- src/conf/storage_conf.c | 2 ++ tests/storagevolxml2xmlout/vol-qcow2-nocow.xml | 1 + tests/storagevolxml2xmltest.c | 1 + 4 files changed, 12 insertions(+), 8 deletions(-) -- 2.7.4

3 6

[libvirt] [PATCH] virsh: maxvcpus: Always fall back to the old command if domain caps fail
by Peter Krempa 09 Dec '16

09 Dec '16

1ec22be5 added code that detects the maximum cpu count according to domain capabilities. The code fell back to the old command only if the API was not supported. If the API fails for other reasons the command would fail. There's no point in not trying the old API in such case. https://bugzilla.redhat.com/show_bug.cgi?id=1402690 --- tools/virsh-host.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/virsh-host.c b/tools/virsh-host.c index 2fd3686..24ebde2 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -623,9 +623,6 @@ cmdMaxvcpus(vshControl *ctl, const vshCmd *cmd) ignore_value(virXPathInt("string(./vcpu[1]/@max)", ctxt, &vcpus)); } else { - if (last_error && last_error->code != VIR_ERR_NO_SUPPORT) - goto cleanup; - vshResetLibvirtError(); } -- 2.10.2

2 1

[libvirt] [PATCH 1/2] vz: set PVMT_DONT_CREATE_DISK migration flag
by Pavel Glushchak 09 Dec '16

09 Dec '16

This flag tells backend not to create instance disks making behavior the same as in qemu driver. Disk files have to be created beforehand on target host manually or by upper management layer i.e. OpenStack Nova. Signed-off-by: Pavel Glushchak <pglushchak(a)virtuozzo.com> --- src/vz/vz_sdk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index d13c86a..4cd988a 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -4740,7 +4740,7 @@ int prlsdkSwitchToSnapshot(virDomainObjPtr dom, const char *uuid, bool paused) * connection to dispatcher */ -#define PRLSDK_MIGRATION_FLAGS (PSL_HIGH_SECURITY) +#define PRLSDK_MIGRATION_FLAGS (PSL_HIGH_SECURITY | PVMT_DONT_CREATE_DISK) int prlsdkMigrate(virDomainObjPtr dom, virURIPtr uri, const unsigned char *session_uuid, -- 2.7.4

2 2

[libvirt] [PATCH 0/3] qemu: bugfixes for websocket port in graphics
by Nikolay Shirokovskiy 09 Dec '16

09 Dec '16

Patch 1 is a preparation for patch 2. Patch 3 particularly fixes next 2 cases: == A. Can not restore domain with autoconfigured websocket. domain 1 and 2 have autoconfigured websocket. 1. domain 1 is started then, saved 2. domain 2 is started 3. domain 1 restoration is failed: error: internal error: qemu unexpectedly closed the monitor: 2016-11-21T10:23:11.356687Z qemu-kvm: -vnc 0.0.0.0:2,websocket=5700: Failed to start VNC server on `(null)': Failed to bind socket: Address already in use == B. Can not migrate domain with autoconfigured websocket. domain 1 on host A, domain 2 on host B, both have autoconfigured websocket 1. domain 1 started, domain 2 started 2. domain 1 migration to host B is failed with the above error. Nikolay Shirokovskiy (3): qemu: refactor: use switch for enum in qemuProcessGraphicsReservePorts qemu: mark user defined websocket as used qemu: fix xml dump of autogenerated websocket src/conf/domain_conf.c | 5 ++++- src/conf/domain_conf.h | 1 + src/qemu/qemu_process.c | 45 ++++++++++++++++++++++++++++++++++++--------- 3 files changed, 41 insertions(+), 10 deletions(-) -- 1.8.3.1

2 14

[libvirt] [PATCH] util: Fix build with clang
by Martin Kletzander 09 Dec '16

09 Dec '16

When compiling with clang on Linux, it complains that "passing an object that undergoes default argument promotion to 'va_start' has undefined behavior". That is true according to the C standard, although I couldn't find any mention about enum->int promotion (even though it's a sensible one). The only fix I came up with was changing the layer parameter to int so that it does not undergo any default argument promotion. Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Even though this is a build-breaker, I don't see anyone (or CI) complaining about it, and the fix doesn't lok that nice, so... src/util/virfirewall.c | 4 ++-- src/util/virfirewall.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 3f976186a671..da4602aa422b 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -417,7 +417,7 @@ virFirewallAddRuleFullV(virFirewallPtr firewall, */ virFirewallRulePtr virFirewallAddRule(virFirewallPtr firewall, - virFirewallLayer layer, + int layer, ...) { virFirewallRulePtr rule; @@ -452,7 +452,7 @@ virFirewallAddRule(virFirewallPtr firewall, * Returns the new rule */ virFirewallRulePtr virFirewallAddRuleFull(virFirewallPtr firewall, - virFirewallLayer layer, + int layer, bool ignoreErrors, virFirewallQueryCallback cb, void *opaque, diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h index dbf397537fa8..51608b648633 100644 --- a/src/util/virfirewall.h +++ b/src/util/virfirewall.h @@ -45,7 +45,7 @@ virFirewallPtr virFirewallNew(void); void virFirewallFree(virFirewallPtr firewall); virFirewallRulePtr virFirewallAddRule(virFirewallPtr firewall, - virFirewallLayer layer, + int layer, ...) ATTRIBUTE_SENTINEL; @@ -54,7 +54,7 @@ typedef int (*virFirewallQueryCallback)(virFirewallPtr firewall, void *opaque); virFirewallRulePtr virFirewallAddRuleFull(virFirewallPtr firewall, - virFirewallLayer layer, + int layer, bool ignoreErrors, virFirewallQueryCallback cb, void *opaque, -- 2.11.0

3 2

[libvirt] [PATCH] virFirewallAddRule: fix build with clang
by Ján Tomko 09 Dec '16

09 Dec '16

clang complains: util/virfirewall.c:425:20: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs] __builtin_va_start(args, layer); Introduce a macro wrapper that puts a NULL pointer after the enum argument. --- Previous attempts exchanged the arguments: https://www.redhat.com/archives/libvir-list/2016-June/msg02173.html or changed the type to int: https://www.redhat.com/archives/libvir-list/2016-December/msg00379.html src/libvirt_private.syms | 2 +- src/util/virfirewall.c | 9 +++++---- src/util/virfirewall.h | 11 ++++++++--- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 867acdb..4c92dba 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1616,8 +1616,8 @@ virFindFileInPath; # util/virfirewall.h -virFirewallAddRule; virFirewallAddRuleFull; +virFirewallAddRuleInt; virFirewallApply; virFirewallFree; virFirewallNew; diff --git a/src/util/virfirewall.c b/src/util/virfirewall.c index 3f97618..c71a274 100644 --- a/src/util/virfirewall.c +++ b/src/util/virfirewall.c @@ -416,13 +416,14 @@ virFirewallAddRuleFullV(virFirewallPtr firewall, * Returns the new rule */ virFirewallRulePtr -virFirewallAddRule(virFirewallPtr firewall, - virFirewallLayer layer, - ...) +virFirewallAddRuleInt(virFirewallPtr firewall, + virFirewallLayer layer, + void *null, + ...) { virFirewallRulePtr rule; va_list args; - va_start(args, layer); + va_start(args, null); rule = virFirewallAddRuleFullV(firewall, layer, false, NULL, NULL, args); va_end(args); return rule; diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h index dbf3975..f28a421 100644 --- a/src/util/virfirewall.h +++ b/src/util/virfirewall.h @@ -44,11 +44,16 @@ virFirewallPtr virFirewallNew(void); void virFirewallFree(virFirewallPtr firewall); -virFirewallRulePtr virFirewallAddRule(virFirewallPtr firewall, - virFirewallLayer layer, - ...) +virFirewallRulePtr virFirewallAddRuleInt(virFirewallPtr firewall, + virFirewallLayer layer, + void *null, + ...) ATTRIBUTE_SENTINEL; +/* work around passing an enum to va_start */ +# define virFirewallAddRule(firewall, layer, ...) \ + virFirewallAddRuleInt(firewall, layer, NULL, __VA_ARGS__) + typedef int (*virFirewallQueryCallback)(virFirewallPtr firewall, const char *const *lines, void *opaque); -- 2.7.3

1 0

[libvirt] RFC: add recreate option to domain events conf
by Nikolay Shirokovskiy 09 Dec '16

09 Dec '16

Hi, all. Does it make sense to anybody else that rebooting and resetting a persistent domain from outside or from inside should bring upon pending configuration changes? For this purpose we can add another option to on_reboot and other events, say 'recreate'. From technical POV qemu has enough capabilities, namely -no-reboot option. Nikolay

1 1

[libvirt] [PATCH v3 0/4] Gathering network interface statistics with openvswitch
by Mehdi Abaakouk 09 Dec '16

09 Dec '16

This new version removes the virstat.c from locale configuration. It also adds a new commit to autodected the ifname of the ovs vhostuser. Mehdi Abaakouk (4): Gathering vhostuser interface stats with ovs virstat: fix signature of virstat helper Move virstat.c code to virnetdevtap.c domain_conf: autodetect vhostuser ifname po/POTFILES.in | 1 - src/Makefile.am | 1 - src/conf/domain_conf.c | 10 +++ src/libvirt_private.syms | 5 +- src/libxl/libxl_driver.c | 4 +- src/lxc/lxc_driver.c | 3 +- src/openvz/openvz_driver.c | 4 +- src/qemu/qemu_driver.c | 31 +++++-- src/uml/uml_driver.c | 1 - src/util/virnetdevopenvswitch.c | 106 ++++++++++++++++++++++++ src/util/virnetdevopenvswitch.h | 4 + src/util/virnetdevtap.c | 143 ++++++++++++++++++++++++++++++++ src/util/virnetdevtap.h | 3 + src/util/virstats.c | 178 ---------------------------------------- src/util/virstats.h | 31 ------- src/xen/xen_hypervisor.c | 4 +- 16 files changed, 298 insertions(+), 231 deletions(-) delete mode 100644 src/util/virstats.c delete mode 100644 src/util/virstats.h -- 2.10.2

2 14

[libvirt] [PATCH 0/2] Couple of trivial fixes
by Michal Privoznik 09 Dec '16

09 Dec '16

Obviously my gcc do not warn me about some uninitialized or unused variables. But fortunately we have freebsd build in the CI. Both patches pushed under trivial rule. Michal Privoznik (2): qemuGetDomainHugepagePath: Initialize @ret vsh: Mark some function arguments as unused src/qemu/qemu_conf.c | 2 +- tools/vsh.c | 10 +++++++--- 2 files changed, 8 insertions(+), 4 deletions(-) -- 2.11.0

1 2

[libvirt] [libvirt-ci] [PATCH] Add builders for Fedora 25
by Yash Mankad 09 Dec '16

09 Dec '16

Add builders for Fedora 25 to ci.centos.org Signed-off-by: Yash Mankad <ymankad(a)redhat.com> --- projects/libosinfo.yaml | 1 + projects/libvirt-cim.yaml | 1 + projects/libvirt-glib.yaml | 1 + projects/libvirt-perl.yaml | 1 + projects/libvirt-python.yaml | 1 + projects/libvirt-sandbox.yaml | 1 + projects/libvirt-tck.yaml | 1 + projects/libvirt.yaml | 3 +++ projects/osinfo-db-tools.yaml | 1 + projects/osinfo-db.yaml | 1 + projects/virt-manager.yaml | 1 + projects/virt-viewer.yaml | 1 + 12 files changed, 14 insertions(+) diff --git a/projects/libosinfo.yaml b/projects/libosinfo.yaml index 49639f3..afb2de2 100644 --- a/projects/libosinfo.yaml +++ b/projects/libosinfo.yaml @@ -5,6 +5,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: libosinfo make_env: | diff --git a/projects/libvirt-cim.yaml b/projects/libvirt-cim.yaml index d1705af..82a8127 100644 --- a/projects/libvirt-cim.yaml +++ b/projects/libvirt-cim.yaml @@ -6,6 +6,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: libvirt CIM jobs: diff --git a/projects/libvirt-glib.yaml b/projects/libvirt-glib.yaml index 38bcded..7d897ab 100644 --- a/projects/libvirt-glib.yaml +++ b/projects/libvirt-glib.yaml @@ -5,6 +5,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Libvirt GLib jobs: diff --git a/projects/libvirt-perl.yaml b/projects/libvirt-perl.yaml index 2bad51d..a9f4740 100644 --- a/projects/libvirt-perl.yaml +++ b/projects/libvirt-perl.yaml @@ -5,6 +5,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Libvirt Perl jobs: diff --git a/projects/libvirt-python.yaml b/projects/libvirt-python.yaml index baca308..c1192d0 100644 --- a/projects/libvirt-python.yaml +++ b/projects/libvirt-python.yaml @@ -6,6 +6,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Libvirt Python jobs: diff --git a/projects/libvirt-sandbox.yaml b/projects/libvirt-sandbox.yaml index eee249c..ebbc5be 100644 --- a/projects/libvirt-sandbox.yaml +++ b/projects/libvirt-sandbox.yaml @@ -4,6 +4,7 @@ machines: - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Libvirt Sandbox jobs: diff --git a/projects/libvirt-tck.yaml b/projects/libvirt-tck.yaml index 571f3ce..a7c0233 100644 --- a/projects/libvirt-tck.yaml +++ b/projects/libvirt-tck.yaml @@ -4,6 +4,7 @@ machines: - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Libvirt TCK jobs: diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml index 20de27c..b49e01f 100644 --- a/projects/libvirt.yaml +++ b/projects/libvirt.yaml @@ -6,6 +6,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Libvirt archive_format: xz @@ -18,6 +19,7 @@ - libvirt-debian - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide - libvirt-freebsd - autotools-syntax-check-job: @@ -28,6 +30,7 @@ - libvirt-debian - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide check_env: | export VIR_TEST_EXPENSIVE=1 diff --git a/projects/osinfo-db-tools.yaml b/projects/osinfo-db-tools.yaml index bcb63da..5f275ab 100644 --- a/projects/osinfo-db-tools.yaml +++ b/projects/osinfo-db-tools.yaml @@ -5,6 +5,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: osinfo database tools jobs: diff --git a/projects/osinfo-db.yaml b/projects/osinfo-db.yaml index f48aa3f..9539724 100644 --- a/projects/osinfo-db.yaml +++ b/projects/osinfo-db.yaml @@ -5,6 +5,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: osinfo database jobs: diff --git a/projects/virt-manager.yaml b/projects/virt-manager.yaml index 737e37d..4485d5f 100644 --- a/projects/virt-manager.yaml +++ b/projects/virt-manager.yaml @@ -5,6 +5,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Virtual Machine Manager jobs: diff --git a/projects/virt-viewer.yaml b/projects/virt-viewer.yaml index d7b7108..06c372b 100644 --- a/projects/virt-viewer.yaml +++ b/projects/virt-viewer.yaml @@ -5,6 +5,7 @@ - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 + - libvirt-fedora-25 - libvirt-fedora-rawhide title: Virt Viewer jobs: -- 2.7.4

3 2

[libvirt] [PATCH 0/2] Allow saving QEMU libvirt state to a pipe
by Chen Hanxiao 09 Dec '16

09 Dec '16

This series introduce flag VIR_DOMAIN_SAVE_PIPE to enable command 'save' to write to PIPE. Base upon patches from Roy Keene <rkeene(a)knightpoint.com> with some fixes. Change from original patch: 1) Check whether the specified path is a PIPE. 2) Rebase on upstream. 3) Add doc for virsh command Chen Hanxiao (2): qemu: Allow saving QEMU libvirt state to a pipe virsh: introduce flage --pipe for save command include/libvirt/libvirt-domain.h | 1 + src/qemu/qemu_driver.c | 71 ++++++++++++++++++++++++++++++---------- tools/virsh-domain.c | 6 ++++ tools/virsh.pod | 6 +++- 4 files changed, 65 insertions(+), 19 deletions(-) -- 2.7.4

2 5

[libvirt] [PATCH v4 0/9] Implementation of QEMU vhost-scsi
by Eric Farman 08 Dec '16

08 Dec '16

This patch series provides a libvirt implementation of the vhost-scsi interface in QEMU. As near as I can see, this was discussed upstream in July 2014[1], and ended in a desire to replace a vhost-scsi controller in favor of a hostdev element instead[2]. Host setup via targetcli (SCSI LUN(s) are already defined to host): # targetcli targetcli shell version 2.1.fb35 Copyright 2011-2013 by Datera, Inc and others. For help on commands, type 'help'. /> backstores/block create name=disk1 write_back=false \ dev=/dev/disk/by-id/dm-name-36005076306ffc7630000000000002211 Created block storage object disk1 using /dev/disk/by-id/dm-name-36005076306ffc7630000000000002211. /> vhost/ create Created target naa.5001405df3e54061. Created TPG 1. /> vhost/naa.5001405df3e54061/tpg1/luns create /backstores/block/disk1 Created LUN 0. /> exit Host Filesystem Example: # ls /sys/kernel/config/target/vhost/ discovery_auth naa.5001405df3e54061 version # ls /sys/kernel/config/target/vhost/naa.5001405df3e54061/tpgt_1/lun/ lun_0 QEMU Example (snippet): -device vhost-scsi-ccw,wwpn=naa.5001405df3e54061,devno=fe.0.1000 Libvirt Example (snippet): <hostdev mode='subsystem' type='scsi_host'> <source protocol='vhost' wwpn='naa.5001405df3e54061'/> <address type='ccw' cssid='0xfe' ssid='0x0' devno='0x1000'/> </hostdev> Guest Viewpoint: # lsscsi [1:0:1:0] disk LIO-ORG disk0 4.0 /dev/sda # dmesg | grep 1: [ 6.065735] scsi host1: Virtio SCSI HBA [ 6.093892] scsi 1:0:1:0: Direct-Access LIO-ORG disk0 4.0 PQ: 0 ANSI: 5 [ 6.313615] sd 1:0:1:0: Attached scsi generic sg0 type 0 [ 6.314981] sd 1:0:1:0: [sda] 29360128 512-byte logical blocks: (15.0 GB/14.0 GiB) [ 6.317290] sd 1:0:1:0: [sda] Write Protect is off [ 6.317566] sd 1:0:1:0: [sda] Mode Sense: 43 00 10 08 [ 6.317853] sd 1:0:1:0: [sda] Write cache: enabled, read cache: enabled, supports DPO and FUA [ 6.352722] sd 1:0:1:0: [sda] Attached SCSI disk Changelog: v4: - Rebase - Rebased to current master (21 November) - s/virDomainPCIAddressEnsureAddr/qemuDomainEnsurePCIAddress/ (per commit abb7a4bd) - Renaming (apologies if this list is off slightly from the code) - Per comments in v3.2, some renaming has been performed: -- virDomainHostdevSubsysHostProtocol => virDomainHostdevSubsysSCSIHostProtocol -- VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_HOST => VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI_HOST -- VIR_DOMAIN_HOSTDEV_SUBSYS_HOST_PROTOCOL_TYPE_ => VIR_DOMAIN_HOSTDEV_SUBSYS_SCSI_HOST_PROTOCOL_TYPE_ -- virDomainHostdevSubsysHost => virDomainHostdevSubsysSCSIVHost -- virDomainHostdevSubsysHost host; => virDomainHostdevSubsysSCSIVHost scsi_host; -- src/util/virhost.[ch] => src/util/virscsivhost.[ch] -- virHost... => virSCSIVHost... -- activeHostHostdevs => activeSCSIVHostHostdevs -- qemuBuildHostHostdevDevStr => qemuBuildSCSIVHostHostdevDevStr -- qemuSetupHostHostDeviceCgroup => qemuSetupHostSCSIVHostDeviceCgroup - Comments - Checked for a guest address tag that is of type PCI or CCW (it is optional, and should be calculated automatically) - Removed the array of "used by" information in hostdev utilities, since devices will not be shared - Fixed the existing tests to properly check for an address - Added a set of CCW tests in addition to the existing PCI ones - Removed protocol check in PrimeVirtioDeviceAddresses - Things *NOT* done (later?) from v2 feedback - Investigation/tie-in with virsh nodedev-list stuff - Implementation of 'num_queues', 'max_sectors', and 'cmd_per_lun' (Need to research these in the virtio space, before figuring out how to apply to vhost-scsi) - Dropping the "naa." prefix of wwn - Split the "tests" patch into earlier patches - Other v3.2: https://www.redhat.com/archives/libvir-list/2016-November/msg00454.html v3.1: https://www.redhat.com/archives/libvir-list/2016-October/msg01324.html v3: https://www.redhat.com/archives/libvir-list/2016-October/msg01201.html v2.1: https://www.redhat.com/archives/libvir-list/2016-September/msg00148.html v2: https://www.redhat.com/archives/libvir-list/2016-August/msg01028.html v1: https://www.redhat.com/archives/libvir-list/2016-July/msg01004.html [1] http://www.redhat.com/archives/libvir-list/2014-July/msg01235.html [2] http://www.redhat.com/archives/libvir-list/2014-July/msg01390.html Eric Farman (9): qemu: Introduce vhost-scsi capability Introduce framework for a hostdev SCSI_host subsystem type util: Management routines for scsi_host devices qemu: Add vhost-scsi string for -device parameter qemu: Allow hotplug of vhost-scsi device conf: Wire up the vhost-scsi connection from/to XML security: Include vhost-scsi in security labels tests: Introduce basic vhost-scsi tests docs: Add vhost-scsi docs/formatdomain.html.in | 24 ++ docs/schemas/domaincommon.rng | 23 ++ po/POTFILES.in | 1 + src/Makefile.am | 1 + src/conf/domain_audit.c | 7 + src/conf/domain_conf.c | 101 +++++++- src/conf/domain_conf.h | 18 ++ src/libvirt_private.syms | 18 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_cgroup.c | 39 +++ src/qemu/qemu_command.c | 80 ++++++ src/qemu/qemu_command.h | 5 + src/qemu/qemu_domain_address.c | 14 +- src/qemu/qemu_hostdev.c | 41 +++ src/qemu/qemu_hostdev.h | 8 + src/qemu/qemu_hotplug.c | 166 ++++++++++++ src/security/security_apparmor.c | 22 ++ src/security/security_dac.c | 50 ++++ src/security/security_selinux.c | 47 ++++ src/util/virhostdev.c | 163 ++++++++++++ src/util/virhostdev.h | 16 ++ src/util/virscsivhost.c | 288 +++++++++++++++++++++ src/util/virscsivhost.h | 65 +++++ tests/domaincapsschemadata/full.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + .../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.args | 23 ++ .../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.xml | 34 +++ .../qemuxml2argv-hostdev-scsi-vhost-scsi-pci.args | 24 ++ .../qemuxml2argv-hostdev-scsi-vhost-scsi-pci.xml | 42 +++ tests/qemuxml2argvmock.c | 9 + tests/qemuxml2argvtest.c | 6 + .../qemuxml2xmlout-hostdev-scsi-vhost-scsi-ccw.xml | 1 + .../qemuxml2xmlout-hostdev-scsi-vhost-scsi-pci.xml | 1 + tests/qemuxml2xmltest.c | 6 + 45 files changed, 1355 insertions(+), 3 deletions(-) create mode 100644 src/util/virscsivhost.c create mode 100644 src/util/virscsivhost.h create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi-pci.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-vhost-scsi-pci.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-vhost-scsi-ccw.xml create mode 120000 tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-vhost-scsi-pci.xml -- 1.9.1

4 28

[libvirt] [PATCH] news: Add description for perf.branch_instructions
by John Ferlan 08 Dec '16

08 Dec '16

Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Pushed as trivial docs/news.html.in | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/news.html.in b/docs/news.html.in index 958bdd2..faea685 100644 --- a/docs/news.html.in +++ b/docs/news.html.in @@ -28,6 +28,12 @@ </ul> </li> <li>Improvements + <ul> + <li>perf: Add perf.branch_instructions + Add support to get the count of branch instructions executed + by applications running on the platform + </li> + </ul> </li> <li>Bug fixes </li> -- 2.7.4

1 0

[libvirt] [PATCH] qemu: Don't try to find compression program for "raw" memory images
by Peter Krempa 08 Dec '16

08 Dec '16

There's nothing to compress if the requested snapshot memory format is set to 'raw' explicitly. After commit 9e14689ea libvirt would try to run /sbin/raw to process them emory stream if the qemu.conf option snapshot_image_format is set. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1402726 --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 6b177e9..4ef1860 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3300,6 +3300,9 @@ qemuGetCompressionProgram(const char *imageFormat, if ((ret = qemuSaveCompressionTypeFromString(imageFormat)) < 0) goto error; + if (ret == QEMU_SAVE_FORMAT_RAW) + return QEMU_SAVE_FORMAT_RAW; + if (!(*compresspath = virFindFileInPath(imageFormat))) goto error; -- 2.10.2

2 1

[libvirt] [PATCH 0/2] Couple of recently found Coverity issues
by John Ferlan 08 Dec '16

08 Dec '16

Nuisance for some, but both have negative repurcussions although one is "just" a test. John Ferlan (2): tests: Fix virmacmaptest when allocation fails nss: Need to check error condition on virJSONValueArraySize tests/virmacmaptest.c | 9 +++++++-- tools/nss/libvirt_nss.c | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) -- 2.7.4

2 4

[libvirt] [PATCH v2] lxc: monitor now holds a reference to the domain
by Cédric Bosdonnat 08 Dec '16

08 Dec '16

If the monitor doesn't hold a reference to the domain object the object may be destroyed before the monitor actually stops. --- v2: Moved vm ref upper, removed vm unref in error case. src/lxc/lxc_monitor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_monitor.c b/src/lxc/lxc_monitor.c index d828d528a..9cab6c203 100644 --- a/src/lxc/lxc_monitor.c +++ b/src/lxc/lxc_monitor.c @@ -175,7 +175,7 @@ virLXCMonitorPtr virLXCMonitorNew(virDomainObjPtr vm, mon->program) < 0) goto error; - mon->vm = vm; + mon->vm = virObjectRef(vm); memcpy(&mon->cb, cb, sizeof(mon->cb)); virObjectRef(mon); @@ -201,6 +201,7 @@ static void virLXCMonitorDispose(void *opaque) if (mon->cb.destroy) (mon->cb.destroy)(mon, mon->vm); virObjectUnref(mon->program); + virObjectUnref(mon->vm); } -- 2.11.0

2 1