- Devel - libvirt List Archives

[libvirt] [PATCH] Don't leak str in virDomainNetDefCoalesceParseXML
by Martin Kletzander 22 Apr '17

22 Apr '17

Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com> --- Pushed as trivial. src/conf/domain_conf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index cbeebdc56880..4a777d67bfad 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6811,6 +6811,7 @@ virDomainNetDefCoalesceParseXML(xmlNodePtr node, ret->rx_max_coalesced_frames = tmp; cleanup: + VIR_FREE(str); ctxt->node = save; return ret; -- 2.12.2

1 0

[libvirt] [PATCH v2 0/3] Add support for coalesce settings on interfaces
by Martin Kletzander 22 Apr '17

22 Apr '17

In linux this is supported since 4.11-rc3, I tested it with 4.11.0-rc5-next-20170407. The particular patch can be found here: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/commit/?… Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1414627 In this version the XML is different so that there are no underscores (and it's actually more readable, IMHO). Plus some minor adjustments needed after rebase. Martin Kletzander (3): util: Add virNetDevSetCoalesce function conf, docs: Add support for coalesce setting(s) Set coalesce settings for domain interfaces configure.ac | 3 +- docs/formatdomain.html.in | 24 ++++ docs/schemas/domaincommon.rng | 131 +++++++++++++++++++++ src/bhyve/bhyve_command.c | 2 +- src/conf/domain_conf.c | 80 +++++++++++++ src/conf/domain_conf.h | 2 + src/libvirt_private.syms | 1 + src/network/bridge_driver.c | 2 +- src/qemu/qemu_domain.c | 31 +++++ src/qemu/qemu_interface.c | 2 +- src/uml/uml_conf.c | 2 +- src/util/virnetdev.c | 83 +++++++++++++ src/util/virnetdev.h | 34 ++++++ src/util/virnetdevtap.c | 5 + src/util/virnetdevtap.h | 2 + tests/bhyvexml2argvmock.c | 1 + .../qemuxml2argvdata/qemuxml2argv-net-coalesce.xml | 68 +++++++++++ .../qemuxml2xmlout-net-coalesce.xml | 71 +++++++++++ tests/qemuxml2xmltest.c | 1 + 19 files changed, 540 insertions(+), 5 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-net-coalesce.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-net-coalesce.xml -- 2.12.2

3 8

[libvirt] [PATCH v2 0/5] Hyper-V method invocation
by Sri Ramanujam 22 Apr '17

22 Apr '17

Changes from v1: * Removed unneeded util function Sri Ramanujam (5): hyperv: Functions to work with invocation parameters. hyperv: Generate object property type information. hyperv: add hypervInvokeMethod hyperv: support virDomainSendKey hyperv: Add support for virDomainSetMemory src/hyperv/hyperv_driver.c | 182 +++++++ src/hyperv/hyperv_wmi.c | 879 ++++++++++++++++++++++++++++++++++ src/hyperv/hyperv_wmi.h | 93 +++- src/hyperv/hyperv_wmi_classes.h | 19 + src/hyperv/hyperv_wmi_generator.input | 116 +++++ src/hyperv/hyperv_wmi_generator.py | 15 +- src/hyperv/openwsman.h | 4 + 7 files changed, 1306 insertions(+), 2 deletions(-) -- 2.9.3

2 7

Re: [libvirt] creating stream
by Michal Privoznik 21 Apr '17

21 Apr '17

On 04/20/2017 03:55 PM, Vasiliy Tolstov wrote: > 2017-04-06 14:59 GMT+03:00 Michal Privoznik <mprivozn(a)redhat.com>: >> That is not going to be enough. The RPC protocol is spread among other files >> too. You really should not hook into our RPC protocol. My question is still >> unanswered though - why do you need it anyway? > > Thanks for all your help, i'm create mostly complete libvirt binding > using generator. Last problem - do you know binary representation ofr > virTypedParams? Does it xdr encoded when passed via wire or not? And > format of this field? You can see for yourself - just fire up wireshark with libvirt dissector installed and issue the API. Also, you may look at remote_typed_param_value and remote_typed_param structs defined in src/remote/remote_protocol.h. Michal

2 7

[libvirt] [PATCH v3 0/3] libxl: nestedhvm support
by Wim Ten Have 21 Apr '17

21 Apr '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch enhances host-passthrough capability to advertise the required vendor CPU virtualization feature which will be used to enable 'nestedhvm' in the libxl driver. Wim ten Have (3): libxl: set nestedhvm for mode host-passthrough xenconfig: add conversions for xen-xl xlconfigtest: add tests for 'nestedhvm' support cfg.mk | 2 +- src/libxl/libxl_conf.c | 46 ++++++++++++++-- src/libxl/libxl_conf.h | 2 +- src/libxl/libxl_domain.c | 2 +- src/xenconfig/xen_xl.c | 64 ++++++++++++++++++++++ .../test-fullvirt-nestedhvm-disabled.cfg | 26 +++++++++ .../test-fullvirt-nestedhvm-disabled.xml | 61 +++++++++++++++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.cfg | 26 +++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 59 ++++++++++++++++++++ tests/xlconfigtest.c | 2 + 10 files changed, 282 insertions(+), 8 deletions(-) create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.xml -- 2.9.3

3 8

[libvirt] [PATCH] docs: fix typo in closing HTML element
by Daniel P. Berrange 21 Apr '17

21 Apr '17

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a build fix docs/formatdomain.html.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 5469fc3..9bea3bc 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5425,7 +5425,7 @@ qemu-kvm -net nic,model=? /dev/null This element provides means of setting coalesce settings for some interface devices (currently only type <code>network</code> and <code>bridge</code>. Currently there is just one attribute, - <code>max</code>, to tweak, in element <code>frames<code> for + <code>max</code>, to tweak, in element <code>frames</code> for the <code>rx</code> group, which accepts a non-negative integer that specifies the maximum number of packets that will be received before an interrupt. -- 2.9.3

1 0

[libvirt] [PATCH] util: check ifa_addr pointer before accessing its elements
by Pavel Hrdina 21 Apr '17

21 Apr '17

Reported by Rafał Wojciechowski <it(a)rafalwojciechowski.pl>. Thread 1 (Thread 0x7f194b99d700 (LWP 5631)): 0 virNetDevGetifaddrsAddress (addr=0x7f194b99c7c0, ifname=0x7f193400e2b0 "ovirtmgmt") at util/virnetdevip.c:738 1 virNetDevIPAddrGet (ifname=0x7f193400e2b0 "ovirtmgmt", addr=addr@entry=0x7f194b99c7c0) at util/virnetdevip.c:795 2 0x00007f19467800d6 in networkGetNetworkAddress (netname=<optimized out>, netaddr=netaddr@entry=0x7f1924013f18) at network/bridge_driver.c:4780 3 0x00007f193e43a33c in qemuProcessGraphicsSetupNetworkAddress (listenAddr=0x7f19340f7650 "127.0.0.1", glisten=0x7f1924013f10) at qemu/qemu_process.c:4062 4 qemuProcessGraphicsSetupListen (vm=<optimized out>, graphics=0x7f1924014f10, cfg=0x7f1934119f00) at qemu/qemu_process.c:4133 5 qemuProcessSetupGraphics (flags=17, vm=0x7f19240155d0, driver=0x7f193411f1d0) at qemu/qemu_process.c:4196 6 qemuProcessPrepareDomain (conn=conn@entry=0x7f192c00ab50, driver=driver@entry=0x7f193411f1d0, vm=vm@entry=0x7f19240155d0, flags=flags@entry=17) at qemu/qemu_process.c:4969 7 0x00007f193e4417c0 in qemuProcessStart (conn=conn@entry=0x7f192c00ab50, driver=driver@entry=0x7f193411f1d0, vm=0x7f19240155d0,asyncJob=asyncJob@entry=QEMU_ASYNC_JOB_START, migrateFrom=migrateFrom@entry=0x0, migrateFd=migrateFd@entry=-1, migratePath=migratePath@entry=0x0,snapshot=snapshot@entry=0x0, vmop=vmop@entry=VIR_NETDEV_VPORT_PROFILE_OP_CREATE, flags=17, flags@entry=1) at qemu/qemu_process.c:5553 Man page for getifaddrs also states that the "ifa_addr" may contain a null pointer which happens if there is an existing network interface on the host without IP address. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virnetdevip.c | 7 ++++++- src/util/virnetdevtap.c | 3 +++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdevip.c b/src/util/virnetdevip.c index 726fa6c3e3..09925e1d74 100644 --- a/src/util/virnetdevip.c +++ b/src/util/virnetdevip.c @@ -902,10 +902,15 @@ virNetDevGetifaddrsAddress(const char *ifname, } for (ifa = ifap; ifa; ifa = ifa->ifa_next) { - int family = ifa->ifa_addr->sa_family; + int family; if (STRNEQ_NULLABLE(ifa->ifa_name, ifname)) continue; + + if (!ifa->ifa_addr) + continue; + family = ifa->ifa_addr->sa_family; + if (family != AF_INET6 && family != AF_INET) continue; diff --git a/src/util/virnetdevtap.c b/src/util/virnetdevtap.c index 02ef7fd240..93002b9294 100644 --- a/src/util/virnetdevtap.c +++ b/src/util/virnetdevtap.c @@ -762,6 +762,9 @@ virNetDevTapInterfaceStats(const char *ifname, } for (ifa = ifap; ifa; ifa = ifa->ifa_next) { + if (!ifa->ifa_addr) + continue; + if (ifa->ifa_addr->sa_family != AF_LINK) continue; -- 2.12.2

2 1

[libvirt] [PATCH] Use port range 5901-5999 if not set in qemu.conf, avoid port 5900
by Christophe de Dinechin 21 Apr '17

21 Apr '17

In order to avoid conflict with the default port (5900) for host VNC server (vino-server for example), or to conflict with X11 (starting at port 6000), restrict range of ports to 5901-5999 unless explicitly specified in qemu.conf. On the other hand, if port range is explicitly specified in qemu.conf, there is no reason not to allow ports 1024-5900 (system ports are below 1024). Addresses https://bugzilla.redhat.com/show_bug.cgi?id=1442235 Signed-off-by: Christophe de Dinechin <dinechin(a)redhat.com> --- src/qemu/qemu_conf.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c index 1b704da..07f3177 100644 --- a/src/qemu/qemu_conf.c +++ b/src/qemu/qemu_conf.c @@ -65,9 +65,15 @@ VIR_LOG_INIT("qemu.qemu_conf"); * This limitation is mentioned in qemu.conf, so bear in mind that the * configuration file should reflect any changes made to these values. */ -#define QEMU_REMOTE_PORT_MIN 5900 + +// Range of available ports - Avoid ports below 1024 (system ports) +#define QEMU_REMOTE_PORT_MIN 1024 #define QEMU_REMOTE_PORT_MAX 65535 +// Default min and max if not configured in qemu.conf +#define QEMU_REMOTE_PORT_MIN_DEFAULT 5901 +#define QEMU_REMOTE_PORT_MAX_DEFAULT 5999 + #define QEMU_WEBSOCKET_PORT_MIN 5700 #define QEMU_WEBSOCKET_PORT_MAX 65535 @@ -283,8 +289,8 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged) #undef SET_TLS_X509_CERT_DEFAULT - cfg->remotePortMin = QEMU_REMOTE_PORT_MIN; - cfg->remotePortMax = QEMU_REMOTE_PORT_MAX; + cfg->remotePortMin = QEMU_REMOTE_PORT_MIN_DEFAULT; + cfg->remotePortMax = QEMU_REMOTE_PORT_MAX_DEFAULT; cfg->webSocketPortMin = QEMU_WEBSOCKET_PORT_MIN; cfg->webSocketPortMax = QEMU_WEBSOCKET_PORT_MAX; -- 2.9.3

3 6

[libvirt] How to get VM memory usage
by wangyufeng＠cloudguarding.com 21 Apr '17

21 Apr '17

Hello everyone, Could you tell me how to get VM memory usage from libvirt-go? Thanks wangyufeng(a)cloudguarding.com

2 3

[libvirt] [PATCH] util: allow ignoring SIOCSIFHWADDR when errno is EPERM
by Laine Stump 21 Apr '17

21 Apr '17

From: Laine Stump <laine(a)redhat.com> Commit f4ef3a71 made a variation of virNetDevSetMAC that would return without logging an error message if errno was set to EADDRNOTAVAIL. This errno is set by some SRIOV VF drivers (in particular igbvf) when they fail to set the device's MAC address due to the PF driver refusing the request. This is useful if we want to try a different method of setting the VF MAC address before giving up (Commit 86556e16 actually does this, setting the desired MAC address to the "admin MAC in the PF, then detaching and reattaching the VF netdev driver to force a reinit of the MAC address). During testing of Bug 1442040 t was discovered that the ixgbe driver returns EPERM in this situation, so this patch changes the exception case for silent+non-terminal failure to account for this difference. Completes resolution to: https://bugzilla.redhat.com/1415609 (RHEL 7.4) https://bugzilla.redhat.com/1442040 (RHEL 7.3.z) --- src/util/virnetdev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 170e348..9aa9c9f 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -226,7 +226,8 @@ int virNetDevExists(const char *ifname) * virNetDevSetMACInternal: * @ifname: interface name to set MTU for * @macaddr: MAC address - * @quiet: true if a failure to set MAC address with errno == EADDRNOTAVAIL + * @quiet: true if a failure to set MAC address with + * errno == EADDRNOTAVAIL || errno == EPERM * should be silent (still returns error, but without log) * * This function sets the @macaddr for a given interface @ifname. @@ -258,7 +259,8 @@ virNetDevSetMACInternal(const char *ifname, if (ioctl(fd, SIOCSIFHWADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -305,7 +307,8 @@ virNetDevSetMACInternal(const char *ifname, ifr.ifr_addr.sa_len = VIR_MAC_BUFLEN; if (ioctl(s, SIOCSIFLLADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -2229,11 +2232,12 @@ virNetDevSetNetConfig(const char *linkdev, int vf, int retries = 100; /* if pfDevOrig == NULL, this isn't a VF, so we've failed */ - if (!pfDevOrig || errno != EADDRNOTAVAIL) + if (!pfDevOrig || + (errno != EADDRNOTAVAIL && errno != EPERM)) goto cleanup; /* Otherwise this is a VF, and virNetDevSetMAC failed with - * EADDRNOTAVAIL, which could be due to the + * EADDRNOTAVAIL/EPERM, which could be due to the * "administratively set" flag being set in the PF for * this VF. When this happens, we can attempt to use an * alternate method to set the VF MAC: first set it into -- 2.9.3

2 1

[libvirt] [PATCH v3 1/2] daemon: Fix domain name leak in error path
by Wang King 21 Apr '17

21 Apr '17

Domain name duplicated in make_nonnull_domain, but not freed when virTypedParamsSerialize return negative. --- daemon/remote.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 1610fea..5d726f4 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -1067,7 +1067,7 @@ remoteRelayDomainEventTunable(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TUNABLE, @@ -1075,6 +1075,10 @@ remoteRelayDomainEventTunable(virConnectPtr conn, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; + } @@ -1207,13 +1211,16 @@ remoteRelayDomainEventJobCompleted(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_JOB_COMPLETED, (xdrproc_t)xdr_remote_domain_event_callback_job_completed_msg, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; } -- 2.8.3

2 2

[libvirt] [PATCH] util: allow ignoring SIOCSIFHWADDR when errno is EPERM
by Laine Stump 20 Apr '17

20 Apr '17

From: Laine Stump <laine(a)redhat.com> Commit f4ef3a71 made a variation of virNetDevSetMAC that would return without logging an error message if errno was set to EADDRNOTAVAIL. This errno is set by some SRIOV VF drivers (in particular igbvf) when they fail to set the device's MAC address due to the PF driver refusing the request. This is useful if we want to try a different method of setting the VF MAC address before giving up (Commit 86556e16 actually does this, setting the desired MAC address to the "admin MAC in the PF, then detaching and reattaching the VF netdev driver to force a reinit of the MAC address). During testing of Bug 1442040 t was discovered that the ixgbe driver returns EPERM in this situation, so this patch changes the exception case for silent+non-terminal failure to account for this difference. Completes resolution to: https://bugzilla.redhat.com/1415609 (RHEL 7.4) https://bugzilla.redhat.com/1442040 (RHEL 7.3.z) --- NB: I could also change it to be silent on *any* error, but this could lead to situations where the actual cause of a failure to set the MAC address is obscured to the point of being unable to figure out the problem (because the error would instead show up when the kernel is trying to initialize the MAC address as it reattached the VF net driver, for example). Limiting the errno's that warrant the silent treatment allows us to give more useful error reporting in these other cases. src/util/virnetdev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 170e348..9aa9c9f 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -226,7 +226,8 @@ int virNetDevExists(const char *ifname) * virNetDevSetMACInternal: * @ifname: interface name to set MTU for * @macaddr: MAC address - * @quiet: true if a failure to set MAC address with errno == EADDRNOTAVAIL + * @quiet: true if a failure to set MAC address with + * errno == EADDRNOTAVAIL || errno == EPERM * should be silent (still returns error, but without log) * * This function sets the @macaddr for a given interface @ifname. @@ -258,7 +259,8 @@ virNetDevSetMACInternal(const char *ifname, if (ioctl(fd, SIOCSIFHWADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -305,7 +307,8 @@ virNetDevSetMACInternal(const char *ifname, ifr.ifr_addr.sa_len = VIR_MAC_BUFLEN; if (ioctl(s, SIOCSIFLLADDR, &ifr) < 0) { - if (quiet && errno == EADDRNOTAVAIL) + if (quiet && + (errno == EADDRNOTAVAIL || errno == EPERM)) goto cleanup; virReportSystemError(errno, @@ -2229,11 +2232,12 @@ virNetDevSetNetConfig(const char *linkdev, int vf, int retries = 100; /* if pfDevOrig == NULL, this isn't a VF, so we've failed */ - if (!pfDevOrig || errno != EADDRNOTAVAIL) + if (!pfDevOrig || + (errno != EADDRNOTAVAIL && errno != EPERM)) goto cleanup; /* Otherwise this is a VF, and virNetDevSetMAC failed with - * EADDRNOTAVAIL, which could be due to the + * EADDRNOTAVAIL/EPERM, which could be due to the * "administratively set" flag being set in the PF for * this VF. When this happens, we can attempt to use an * alternate method to set the VF MAC: first set it into -- 2.9.3

1 0

[libvirt] [PATCH v2 0/3] libxl: nestedhvm support
by Wim Ten Have 20 Apr '17

20 Apr '17

From: Wim ten Have <wim.ten.have(a)oracle.com> This patch enhances host-passthrough capability to advertise the required vendor CPU virtualization feature which will be used to enable 'nestedhvm' in the libxl driver. Wim ten Have (3): libxl: set nestedhvm for mode host-passthrough xenconfig: add conversions for xen-xl xlconfigtest: add tests for 'nestedhvm' support src/libxl/libxl_conf.c | 47 +++++++++++++-- src/libxl/libxl_conf.h | 2 +- src/libxl/libxl_domain.c | 2 +- src/xenconfig/xen_xl.c | 67 ++++++++++++++++++++++ .../test-fullvirt-nestedhvm-disabled.cfg | 26 +++++++++ .../test-fullvirt-nestedhvm-disabled.xml | 62 ++++++++++++++++++++ .../test-fullvirt-nestedhvm-undefined.cfg | 25 ++++++++ .../test-fullvirt-nestedhvm-undefined.xml | 58 +++++++++++++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.cfg | 26 +++++++++ tests/xlconfigdata/test-fullvirt-nestedhvm.xml | 59 +++++++++++++++++++ tests/xlconfigtest.c | 3 + 11 files changed, 370 insertions(+), 7 deletions(-) create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-disabled.xml create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-undefined.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm-undefined.xml create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.cfg create mode 100644 tests/xlconfigdata/test-fullvirt-nestedhvm.xml -- 2.9.3

3 12

[libvirt] [RFC] Add support for QEMU's l3-cache CPU property
by Jiri Denemark 20 Apr '17

20 Apr '17

Hi, Apparently, reporting a level 3 cache on a virtual CPU can dramatically increase performance in some use cases [1]. The interesting part is that l3-cache=on does not provide the real CPU cache data, it's just making it up. Anyway, we should be able to enable this via libvirt. And since there is another property which enables real CPU cache data to be passed to a guest, I suggest the following /domain/cpu/cache element equivalent to l3-cache=on: <cache level='3' mode='emulate'/> If we need to add support for passing the real CPU cache data, we can do that with <cache level='3' mode='passthrough'/> or we can even make the level attribute optional and support <cache mode='passthrough'/> Missing cache element means default behaviour of the hypervisor and we can eventually add <cache mode='disable'/> to turn off passing any CPU cache info to the guest. But I think we should now focus only on <cache level='3' mode='emulate'/> and leaving the rest for the future when we actually need it. This is how a more complete example would look like: <cpu mode='custom' match='exact'> <model>Broadwell</model> <cache level='3' mode='emulate'/> </cpu> And libvirt would translate it into -cpu Broadwell,l3-cache=on. Do you have any thoughts about the XML schema or naming? Thanks, Jirka [1] https://patchwork.kernel.org/patch/9308401/

2 5

[libvirt] [PATCH] virsh: report errors in virshInit()
by Daniel P. Berrange 20 Apr '17

20 Apr '17

There are several functions in virshInit which can fail, especially when running win32 builds under WINE. Currently virsh just exits without reporting what error happened. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- tools/virsh.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index 31e23bd..90f8125 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -358,16 +358,22 @@ virshInit(vshControl *ctl) /* set up the library error handler */ virSetErrorFunc(NULL, vshErrorHandler); - if (virEventRegisterDefaultImpl() < 0) + if (virEventRegisterDefaultImpl() < 0) { + vshReportError(ctl); return false; + } - if (virThreadCreate(&ctl->eventLoop, true, vshEventLoop, ctl) < 0) + if (virThreadCreate(&ctl->eventLoop, true, vshEventLoop, ctl) < 0) { + vshReportError(ctl); return false; + } ctl->eventLoopStarted = true; if ((ctl->eventTimerId = virEventAddTimeout(-1, vshEventTimeout, ctl, - NULL)) < 0) + NULL)) < 0) { + vshReportError(ctl); return false; + } if (ctl->connname) { /* Connecting to a named connection must succeed, but we delay -- 2.9.3

2 2

[libvirt] [PATCH] Increase default task limit for libvirtd
by Jim Fehlig 20 Apr '17

20 Apr '17

libvirtd can spawn threads/tasks when creating new domains for some hypervisors such as Xen's libxl driver, quickly reaching the cgroups pids controller default TasksMax setting of 512. When the limit is reached, attempting to create additional domains results in an error from the cgroups pids controller, e.g. kernel: [71282.213347] cgroup: fork rejected by pids controller in /system.slice/libvirtd.service Depending on domain type and configuration, anywhere from 4-7 threads/tasks may be created by libxl when starting a domain. In order to support 4096 domains, similar to commit 27cd763500, increase the TasksMax setting in libvirtd.service to 4096 * 8 = 32768 tasks. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- daemon/libvirtd.service.in | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/daemon/libvirtd.service.in b/daemon/libvirtd.service.in index 899abdf37..fbaf02f3b 100644 --- a/daemon/libvirtd.service.in +++ b/daemon/libvirtd.service.in @@ -29,6 +29,11 @@ Restart=on-failure # If changing this, also consider virtlogd.service & virtlockd.service # limits which are also related to number of guests LimitNOFILE=8192 +# The cgroups pids controller can limit the number of tasks started by +# the daemon, which can limit the number of domains for some hypervisors. +# A conservative default of 8 tasks per guest results in a TasksMax of +# 32k to support 4096 guests. +TasksMax=32768 [Install] WantedBy=multi-user.target -- 2.11.0

2 1

[libvirt] increase daemon task limit
by Jim Fehlig 20 Apr '17

20 Apr '17

I recently received a report of a libvirt+Xen installation reaching the pids cgroup controller TasksMax limit kernel: [71282.213347] cgroup: fork rejected by pids controller in /system.slice/libvirtd.service The default setting of TaskMax is 512 on this system # cat /sys/fs/cgroup/pids/system.slice/libvirtd.service/pids.max 512 Depending on domain type and configuration, I've noticed between 5-7 tasks (IO threads, qemu process, etc.) are created when starting a domain. It doesn't take too many domains before the 512 limit is reached. LimitNOFILE was recently changed by commit 27cd763500 to support 4096 domains. Following similar logic, would it be ok to increase TasksMax to 32768? That would accommodate 4096 domains with 8 tasks each. TasksMax also supports the special value of "infinity", but that seems a bit aggressive to me. Regards, Jim

2 3

[libvirt] [PATCH] Fix error reporting when poll returns POLLHUP/POLLERR
by Daniel P. Berrange 20 Apr '17

20 Apr '17

In the RPC client event loop code, if poll() returns only a POLLHUP or POLLERR status, then we end up reporting a bogus error message: error: failed to connect to the hypervisor error: An error occurred, but the cause is unknown We do actually report an error, but we virNetClientMarkClose method has already captured the error status before we report it, so the real error gets thrown away. The key fix is to report the error before calling virNetClientMarkClose(). In changing this, we also split out reporting of POLLHUP vs POLLERR to make any future bugs easier to diagnose. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/rpc/virnetclient.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index 5174614..c959747 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -1743,10 +1743,16 @@ static int virNetClientIOEventLoop(virNetClientPtr client, if (error) goto error; - if (fds[0].revents & (POLLHUP | POLLERR)) { + if (fds[0].revents & POLLHUP) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("received hangup event on socket")); virNetClientMarkClose(client, VIR_CONNECT_CLOSE_REASON_EOF); + goto error; + } + if (fds[0].revents & POLLERR) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("received hangup / error event on socket")); + _("received error event on socket")); + virNetClientMarkClose(client, VIR_CONNECT_CLOSE_REASON_ERROR); goto error; } } -- 2.9.3

2 1

[libvirt] [PATCH v2] daemon: Fix domain name leak in error path
by Wang King 20 Apr '17

20 Apr '17

Domain name duplicated in make_nonnull_domain, but not freed when virTypedParamsSerialize return negative. Remove useless error label incidentally. --- daemon/remote.c | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index 1610fea..d8a55c7 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -648,7 +648,7 @@ remoteRelayDomainEventBlockJob(virConnectPtr conn, /* build return data */ memset(&data, 0, sizeof(data)); if (VIR_STRDUP(data.path, path) < 0) - goto error; + return -1; data.type = type; data.status = status; make_nonnull_domain(&data.dom, dom); @@ -667,9 +667,6 @@ remoteRelayDomainEventBlockJob(virConnectPtr conn, } return 0; - error: - VIR_FREE(data.path); - return -1; } @@ -1025,7 +1022,7 @@ remoteRelayDomainEventBlockJob2(virConnectPtr conn, memset(&data, 0, sizeof(data)); data.callbackID = callback->callbackID; if (VIR_STRDUP(data.dst, dst) < 0) - goto error; + return -1; data.type = type; data.status = status; make_nonnull_domain(&data.dom, dom); @@ -1035,9 +1032,6 @@ remoteRelayDomainEventBlockJob2(virConnectPtr conn, (xdrproc_t)xdr_remote_domain_event_block_job_2_msg, &data); return 0; - error: - VIR_FREE(data.dst); - return -1; } @@ -1067,7 +1061,7 @@ remoteRelayDomainEventTunable(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_TUNABLE, @@ -1075,6 +1069,10 @@ remoteRelayDomainEventTunable(virConnectPtr conn, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; + } @@ -1207,13 +1205,16 @@ remoteRelayDomainEventJobCompleted(virConnectPtr conn, (virTypedParameterRemotePtr *) &data.params.params_val, &data.params.params_len, VIR_TYPED_PARAM_STRING_OKAY) < 0) - return -1; + goto error; remoteDispatchObjectEventSend(callback->client, remoteProgram, REMOTE_PROC_DOMAIN_EVENT_CALLBACK_JOB_COMPLETED, (xdrproc_t)xdr_remote_domain_event_callback_job_completed_msg, &data); return 0; + error: + VIR_FREE(data.dom.name); + return -1; } -- 2.8.3

2 1

[libvirt] [PATCH 0/2] qemu: hotplug: Write status XML only during successful vcpu hot(un)plug
by Peter Krempa 20 Apr '17

20 Apr '17

See the second patch. Peter Krempa (2): qemu: hotplug: Unexport qemuDomainHotplugDelVcpu qemu: hotplug: Don't save status XML when monitor is closed src/qemu/qemu_hotplug.c | 31 +++++++++++++++++-------------- src/qemu/qemu_hotplug.h | 3 --- 2 files changed, 17 insertions(+), 17 deletions(-) -- 2.12.2

2 3

[libvirt] [PATCH 0/9] qemu: More CPU enhancements and fixes
by Jiri Denemark 19 Apr '17

19 Apr '17

This is technically a v2 of the not yet pushed part of "qemu: Use migratable host CPU model from QEMU" series, but the patches were significantly rewritten based on the review comments and on the need for additional regression fix. Current libvirt makes a migratable host CPU model by removing features marked in cpu_map.xml with migratable='no'. This is not ideal because cpu_map.xml is a static database while feature migratability may differ depending on a hypervisor or its version. Thus we should preferably use the data we got from QEMU. And to make things even more complicated, we need to use both CPUID data we probed and data from QEMU when checking whether a guest CPU can run on the host to maintain backward compatibility with older libvirt. Thus we need to store three different views of the host CPU model with each QEMU binary. Jiri Denemark (9): qemu: Introduce virQEMUCapsSetHostModel qemu: Move qemuCaps CPU data copying into a separate function qemu: Introduce virQEMUCapsHostCPUDataClear qemu: Move qemuCaps host CPU data in a struct qemu: Prepare qemuCaps for multiple host CPU defs qemu: Pass migratable host CPU model to virCPUUpdate cpu: Drop feature filtering from virCPUUpdate cpu: Introduce virCPUGetHostIsSupported qemu: Use more data for comparing CPUs src/cpu/cpu.c | 20 +++ src/cpu/cpu.h | 3 + src/cpu/cpu_x86.c | 9 +- src/libvirt_private.syms | 1 + src/qemu/qemu_capabilities.c | 288 +++++++++++++++++++++++++++++-------------- src/qemu/qemu_capabilities.h | 16 ++- src/qemu/qemu_command.c | 3 +- src/qemu/qemu_process.c | 6 +- tests/cputest.c | 7 +- 9 files changed, 247 insertions(+), 106 deletions(-) -- 2.12.2

2 19

[libvirt] [PATCH] virt-storage-rbd: fix typo s/RDB/RBD/ in configure check
by Daniel P. Berrange 19 Apr '17

19 Apr '17

Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as trivial build fix. m4/virt-storage-rbd.m4 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/virt-storage-rbd.m4 b/m4/virt-storage-rbd.m4 index 727bd71..17e2115 100644 --- a/m4/virt-storage-rbd.m4 +++ b/m4/virt-storage-rbd.m4 @@ -36,7 +36,7 @@ AC_DEFUN([LIBVIRT_STORAGE_CHECK_RBD], [ LIBS="$old_LIBS" fi - if test "$LIBRDB_FOUND" = "yes"; then + if test "$LIBRBD_FOUND" = "yes"; then with_storage_rbd=yes AC_DEFINE_UNQUOTED([WITH_STORAGE_RBD], [1], [whether RBD backend for storage driver is enabled]) -- 2.9.3

1 0

[libvirt] [PATCH v3 0/2] default USB controller for PPC
by Pavel Hrdina 19 Apr '17

19 Apr '17

Pavel Hrdina (2): conf: add a new parse flag VIR_DOMAIN_DEF_PARSE_ABI_UPDATE_MIGRATION qemu_domain: use correct default USB controller on ppc64 src/conf/domain_conf.c | 3 ++- src/conf/domain_conf.h | 4 ++++ src/qemu/qemu_domain.c | 16 ++++++++++++---- src/qemu/qemu_migration_cookie.c | 2 +- 4 files changed, 19 insertions(+), 6 deletions(-) -- 2.12.2

2 3

[libvirt] [PATCH 0/2] autogen.sh: Rewrite and modularize
by Andrea Bolognani 19 Apr '17

19 Apr '17

This work was motivated by Dan's intention to introduce the keycodemapdb module into libvirt[1]. As it is, we have a few useful submodule-related features in our build system, but they are limited in that they assume there will be a single submodule, and it will be gnulib. This series removes such assumptions, making it possible to introduce more submodules without having to sacrifice any convenience. [1] https://www.redhat.com/archives/libvir-list/2017-March/msg00136.html Andrea Bolognani (2): autogen.sh: Rewrite autogen.sh: Modularize .gitignore | 2 +- .submodules/gnulib.functions | 65 ++++++++++ autogen.sh | 286 +++++++++++++++++++++++++++++-------------- cfg.mk | 34 ++--- 4 files changed, 265 insertions(+), 122 deletions(-) create mode 100644 .submodules/gnulib.functions -- 2.7.4

2 7

[libvirt] [PATCH] spec: Avoid RPM verification errors on nwfilter XMLs
by Jiri Denemark 19 Apr '17

19 Apr '17

/etc/libvirt/nwfilter/*.xml files are installed with no UUID, which means libvirtd will automatically alter all of them once it starts. Thus RPM verification will always fail on them. Let's use a trick similar to the default network XML and store nwfilter XMLs in /usr/share. They will be copied into /etc in %post. Additionally the /etc files are marked as %ghost so that they are uninstalled if the RPM package is removed. Note that the %post script overwrites existing files with new ones on upgrade, which is what has always been happening. https://bugzilla.redhat.com/show_bug.cgi?id=1431581 https://bugzilla.redhat.com/show_bug.cgi?id=1378774 Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 1d249851a..78c3c28e1 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1360,6 +1360,13 @@ cp $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/default.xml \ $RPM_BUILD_ROOT%{_datadir}/libvirt/networks/default.xml rm -f $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/default.xml rm -f $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/qemu/networks/autostart/default.xml + +# nwfilter files are installed in /usr/share/libvirt and copied to /etc in %post +# to avoid verification errors on changed files in /etc +install -d -m 0755 $RPM_BUILD_ROOT%{_datadir}/libvirt/nwfilter/ +cp -a $RPM_BUILD_ROOT%{_sysconfdir}/libvirt/nwfilter/*.xml \ + $RPM_BUILD_ROOT%{_datadir}/libvirt/nwfilter/ + # Strip auto-generated UUID - we need it generated per-install sed -i -e "/<uuid>/d" $RPM_BUILD_ROOT%{_datadir}/libvirt/networks/default.xml %if ! %{with_qemu} @@ -1586,6 +1593,17 @@ if test $1 -eq 1 && test ! -f %{_sysconfdir}/libvirt/qemu/networks/default.xml ; fi + +%post daemon-config-nwfilter +cp %{_datadir}/libvirt/nwfilter/*.xml %{_sysconfdir}/libvirt/nwfilter/ +# Make sure libvirt picks up the new nwfilter defininitons +%if %{with_systemd} + /bin/systemctl try-restart libvirtd.service >/dev/null 2>&1 ||: +%else + /sbin/service libvirtd condrestart > /dev/null 2>&1 || : +%endif + + %if %{with_systemd} %triggerun -- libvirt < 0.9.4 %{_bindir}/systemd-sysv-convert --save libvirtd >/dev/null 2>&1 ||: @@ -1767,7 +1785,9 @@ exit 0 %{_datadir}/libvirt/networks/default.xml %files daemon-config-nwfilter -%{_sysconfdir}/libvirt/nwfilter/*.xml +%dir %{_datadir}/libvirt/nwfilter/ +%{_datadir}/libvirt/nwfilter/*.xml +%ghost %{_sysconfdir}/libvirt/nwfilter/*.xml %files daemon-driver-interface %{_libdir}/%{name}/connection-driver/libvirt_driver_interface.so -- 2.12.2

2 4