- Devel - libvirt List Archives

[libvirt] [PATCH v2] Detect VMDK version 3 files
by Daniel P. Berrange 11 May '17

11 May '17

The metadata libvirt cares about is identical for version 3 as for previous versions, so we merely need list the new version number. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/util/virstoragefile.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index 94a77ce..b43acf6 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -113,7 +113,7 @@ enum { BACKING_STORE_ERROR, }; -#define FILE_TYPE_VERSIONS_LAST 2 +#define FILE_TYPE_VERSIONS_LAST 3 struct FileEncryptionInfo { int format; /* Encryption format to assign */ @@ -374,7 +374,7 @@ static struct FileTypeInfo const fileTypeInfo[] = { }, [VIR_STORAGE_FILE_VMDK] = { 0, "KDMV", NULL, - LV_LITTLE_ENDIAN, 4, 4, {1, 2}, + LV_LITTLE_ENDIAN, 4, 4, {1, 2, 3}, 4+4+4, 8, 512, NULL, vmdk4GetBackingStore, NULL }, }; -- 2.9.3

2 1

[libvirt] [PATCH] Add "io" option to virsh attach-disk sub-command.
by Gordon Messmer 11 May '17

11 May '17

--- tools/virsh-domain.c | 14 +++++++++++--- tools/virsh.pod | 2 ++ 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 0d19d0e..d2a2a05 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -267,6 +267,10 @@ static const vshCmdOptDef opts_attach_disk[] = { .type = VSH_OT_STRING, .help = N_("cache mode of disk device") }, + {.name = "io", + .type = VSH_OT_STRING, + .help = N_("io mode of disk device") + }, {.name = "type", .type = VSH_OT_STRING, .help = N_("target device type") @@ -504,8 +508,9 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virDomainPtr dom = NULL; const char *source = NULL, *target = NULL, *driver = NULL, *subdriver = NULL, *type = NULL, *mode = NULL, - *iothread = NULL, *cache = NULL, *serial = NULL, - *straddr = NULL, *wwn = NULL, *targetbus = NULL; + *iothread = NULL, *cache = NULL, *io = NULL, + *serial = NULL, *straddr = NULL, *wwn = NULL, + *targetbus = NULL; struct DiskAddress diskAddr; bool isFile = false, functionReturn = false; int ret; @@ -537,6 +542,7 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) vshCommandOptStringReq(ctl, cmd, "mode", &mode) < 0 || vshCommandOptStringReq(ctl, cmd, "iothread", &iothread) < 0 || vshCommandOptStringReq(ctl, cmd, "cache", &cache) < 0 || + vshCommandOptStringReq(ctl, cmd, "io", &io) < 0 || vshCommandOptStringReq(ctl, cmd, "serial", &serial) < 0 || vshCommandOptStringReq(ctl, cmd, "wwn", &wwn) < 0 || vshCommandOptStringReq(ctl, cmd, "address", &straddr) < 0 || @@ -579,7 +585,7 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAddLit(&buf, ">\n"); virBufferAdjustIndent(&buf, 2); - if (driver || subdriver || iothread || cache) { + if (driver || subdriver || iothread || cache || io) { virBufferAddLit(&buf, "<driver"); if (driver) @@ -590,6 +596,8 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAsprintf(&buf, " iothread='%s'", iothread); if (cache) virBufferAsprintf(&buf, " cache='%s'", cache); + if (io) + virBufferAsprintf(&buf, " io='%s'", io); virBufferAddLit(&buf, "/>\n"); } diff --git a/tools/virsh.pod b/tools/virsh.pod index cd1f25f..9656411 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -2860,6 +2860,8 @@ I<mode> can specify the two specific mode I<readonly> or I<shareable>. I<sourcetype> can indicate the type of source (block|file) I<cache> can be one of "default", "none", "writethrough", "writeback", "directsync" or "unsafe". +I<io> io is "threads", or "native" and selects between pthread based disk +I/O and native Linux AIO. I<iothread> is the number within the range of domain IOThreads to which this disk may be attached (QEMU only). I<serial> is the serial of disk device. I<wwn> is the wwn of disk device. -- 2.9.3

3 8

[libvirt] [PATCH 0/2] spec: Minor improvements
by Andrea Bolognani 11 May '17

11 May '17

*** BLURBY MCBLURBFACE *** Andrea Bolognani (2): spec: Support maintenance releases on mingw spec: Use HTTPS instead of HTTP libvirt.spec.in | 4 ++-- mingw-libvirt.spec.in | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) -- 2.7.4

2 3

[libvirt] [PATCH] qemu: Provide a much clearer message on device hot-plug
by Erik Skultety 11 May '17

11 May '17

Adjust the current message to make it clear, that it is the hot-plug operation that is unsupported with the given host device type. https://bugzilla.redhat.com/show_bug.cgi?id=1450072 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/qemu/qemu_hotplug.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 4ca10863c..1b8504b13 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -2674,7 +2674,7 @@ qemuDomainAttachHostDevice(virConnectPtr conn, { if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev mode '%s' not supported"), + _("hot-plug is not supported for hostdev mode '%s'"), virDomainHostdevModeTypeToString(hostdev->mode)); return -1; } @@ -2705,7 +2705,8 @@ qemuDomainAttachHostDevice(virConnectPtr conn, default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev subsys type '%s' not supported"), + _("hot-plug is not supported for hostdev subsys type " + "'%s'"), virDomainHostdevSubsysTypeToString(hostdev->source.subsys.type)); goto error; } @@ -4820,7 +4821,8 @@ qemuDomainDetachThisHostDevice(virQEMUDriverPtr driver, break; default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev subsys type '%s' not supported"), + _("hot-unplug is not supported for hostdev subsys type " + "'%s'"), virDomainHostdevSubsysTypeToString(detach->source.subsys.type)); return -1; } @@ -4852,7 +4854,7 @@ int qemuDomainDetachHostDevice(virQEMUDriverPtr driver, if (hostdev->mode != VIR_DOMAIN_HOSTDEV_MODE_SUBSYS) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("hostdev mode '%s' not supported"), + _("hot-unplug is not supported for hostdev mode '%s'"), virDomainHostdevModeTypeToString(hostdev->mode)); return -1; } -- 2.12.2

2 1

[libvirt] ANNOUNCE: libvirt 1.3.3.3 maintenance release
by Cole Robinson 11 May '17

11 May '17

libvirt 1.3.3.3 is now available. This is a maintenance release of libvirt 1.3.3 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-1.3.3.3.tar.gz Changes in this version: * virtlogd: Don't stop or restart along with libvirtd * virtlogd.socket: Tie lifecycle to libvirtd.service * schema: Don't validate paths * maint: fix syntax-check sc_prohibit_int_ijk exclude rule * util: bitmap: clarify virBitmapLastSetBit() behavior for empty bitmaps * Fix building with -Og * qemu: Only use memory-backend-file with NUMA if needed For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 2.2.1 maintenance release
by Cole Robinson 11 May '17

11 May '17

libvirt 2.2.1 is now available. This is a maintenance release of libvirt 2.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-2.2.1.tar.xz Changes in this version: * spec: Avoid RPM verification errors on nwfilter XMLs * qemu_process: spice: don't release used port * qemu: Fix crash during qemuStateCleanup * daemon: Fix crash during daemon cleanup * Fix crash on usb-serial hotplug * qemuBuildMemoryBackendStr: Don't crash if no hugetlbfs is mounted * util: fix crash in virClassIsDerivedFrom for CloseCallbacks objects * storage: driver: Remove unavailable transient pools after restart * storage: driver: Split out code fixing pool state after deactivation * qemu: Don't assume secret provided for LUKS encryption * conf: do not steal pointers from the pool source * schema: do not require name for certain pool types * virtlogd: Don't stop or restart along with libvirtd * virtlogd.socket: Tie lifecycle to libvirtd.service * spec: Update version check for maint Source URL * qemu: capabilities: Don't partially reprope caps on process reconnect * network: fix endless loop when starting network with multiple IPs and no dhcp * qemu: allow 32 slots on pcie-expander-bus, not just 1 * qemu: Only use memory-backend-file with NUMA if needed For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] ANNOUNCE: libvirt 3.2.1 maintenance release
by Cole Robinson 11 May '17

11 May '17

libvirt 3.2.1 is now available. This is a maintenance release of libvirt 3.2 with additional bugfixes that have accumulated upstream since the initial release. This release can be downloaded at: http://libvirt.org/sources/stable_updates/libvirt-3.2.1.tar.xz Changes in this version: * spec: Update version check for maint Source URL * mdev: Cleanup code after commits @daf5081b and @2739a983 * Don't use ceph-devel on Fedora * mdev: Fix mingw build by adding a check for non-NULL pointer * client: Report proper close reason * qemu: Fix persistent migration of transient domains * Fix padding of encrypted data * network: better log message when network is inactive during reconnect * qemu: don't kill qemu process on restart if networkNotify fails * conf: format only relevant attributes for graphics based on listen type * qemu: Move freeing of PCI address list to qemuProcessStop * qemu: process: Clean up priv->migTLSAlias * qemu: process: Don't leak priv->usbaddrs after VM restart * qemu: process: Clean automatic NUMA/cpu pinning information on shutdown * qemu: Remove extra messages for vhost-scsi hotplug * qemu: Remove extra messages from virtio-scsi hotplug * qemu: Check return code from qemuHostdevPrepareSCSIDevices * qemu: numa: Don't return automatic nodeset for inactive domain * qemu: Ignore missing query-migrate-parameters * daemon: Fix domain name leak in error path * qemu: fix argument of virDomainNetGetActualDirectMode * rpc: fix keep alive timer segfault * util: allow ignoring SIOCSIFHWADDR when errno is EPERM * util: check ifa_addr pointer before accessing its elements * Increase default task limit for libvirtd * Fix error reporting when poll returns POLLHUP/POLLERR * spec: Avoid RPM verification errors on nwfilter XMLs * xenconfig: avoid double free on OOM testing * xenFormatXLDomainDisks: avoid double free on OOM testing * virConfSaveValue: protect against a NULL pointer reference * conf: Add check for non scsi_host parent during vport delete * util: Fix resource leak * test: Remove unused variate @maxcpu in testDomainGetVcpus * esx: Fix memory leak * esx: Fix incorrect memory compare size in esxStoragePoolLookupByUUID * qemu: snapshot: Skip empty drives with internal snapshots * qemu: do not crash on USB address with no port and invalid bus * man: Align vol-resize arguments with the output of help * qemu: conf: Don't leak snapshot image format conf variable * qemu: Fix mdev checking for VFIO support * util: systemd: Don't strlen a possibly NULL string * interface: Fix resource leak in netcfConnectListAllInterfaces error path * virsh: don't leak @cpumap in virshVcpuPinQuery * tests: fix some resource leaks * rpc: fix resource leak * src: fix multiple resource leaks in loops * conf/domain_capabilities: fix resource leak * qemu: Fix two use-after-free situations * disk: Force usage of parted when checking disk format for "bsd" * disk: Resolve issues with disk partition build/start checks * conf: create new RemovalFailed event using correct class * qemu: fix memory leak and check mdevPath * qemu: Properly reset TLS in qemuProcessRecoverMigrationIn * Properly ignore files in build-aux directory * conf: Fix possible memleak in capabilities * Split out -Wframe-larger-than warning from WARN_CLFAGS * virISCSIGetSession: Don't leak memory * virStorageSourceClear: Don't leave dangling pointers behind * qemu: Break endless loop if qemuMigrationResetTLS fails * storage: gluster: Implement 'checkPool' method so that state is restored * docs: Document limitation of maximum vcpu count used with <topology> * qemu: Fix resource leak in qemuDomainAddChardevTLSObjects error path * qemu: Initialize 'data' argument * storage: util: Pass pool type to virStorageBackendFindGlusterPoolSources * util: ignore -Wcast-align in virNetlinkDumpCommand * qemu: hotplug: Clear vcpu ordering for coldplug of vcpus * qemu: hotplug: Fix formatting strings in qemuDomainFilterHotplugVcpuEntities * qemu: hotplug: Iterate over vcpu 0 in individual vcpu hotplug code * qemu: Add device id for mediated devices on qemu command line * storage: Fix capacity value for LUKS encrypted volumes * virNetDevIPCheckIPv6ForwardingCallback fixes * storage: driver: Remove unavailable transient pools after restart * storage: driver: Split out code fixing pool state after deactivation * storage: backend: Use correct stringifier for pool type * mdev: Fix daemon crash on domain shutdown after reconnect * util: mdev: Use a local variable instead of a direct pointer access * qemu: Fix regression when hyperv/vendor_id feature is used * vz: fix typo that breaks build For info about past maintenance releases, see: http://wiki.libvirt.org/page/Maintenance_Releases Thanks, Cole

1 0

[libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32
by Daniel P. Berrange 11 May '17

11 May '17

The Win32 platform can not do link time overrides in the same way that we can on POSIX / ELF based platforms, so we cannot build the virfilewrapper.c code reliably. Just stub it out on Win32 so it is a no-op. Tests that use this file are already written to skip on Win32. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a mingw build fix tests/virfilewrapper.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/tests/virfilewrapper.c b/tests/virfilewrapper.c index 5ea70b3..bf2fa69 100644 --- a/tests/virfilewrapper.c +++ b/tests/virfilewrapper.c @@ -18,15 +18,17 @@ #include <config.h> -#include <stdio.h> -#include <stdlib.h> -#include <fcntl.h> +#ifndef WIN32 -#include "viralloc.h" -#include "virfile.h" -#include "virfilewrapper.h" -#include "virmock.h" -#include "virstring.h" +# include <stdio.h> +# include <stdlib.h> +# include <fcntl.h> + +# include "viralloc.h" +# include "virfile.h" +# include "virfilewrapper.h" +# include "virmock.h" +# include "virstring.h" /* Mapping for prefix overrides */ @@ -139,7 +141,7 @@ virFileWrapperOverridePrefix(const char *path) } -#define PATH_OVERRIDE(newpath, path) \ +# define PATH_OVERRIDE(newpath, path) \ do { \ init_syms(); \ \ @@ -177,7 +179,7 @@ int access(const char *path, int mode) return ret; } -#ifdef HAVE___LXSTAT +# ifdef HAVE___LXSTAT int __lxstat(int ver, const char *path, struct stat *sb) { int ret = -1; @@ -191,7 +193,7 @@ int __lxstat(int ver, const char *path, struct stat *sb) return ret; } -#endif /* HAVE___LXSTAT */ +# endif /* HAVE___LXSTAT */ int lstat(const char *path, struct stat *sb) { @@ -207,7 +209,7 @@ int lstat(const char *path, struct stat *sb) return ret; } -#ifdef HAVE___XSTAT +# ifdef HAVE___XSTAT int __xstat(int ver, const char *path, struct stat *sb) { int ret = -1; @@ -221,7 +223,7 @@ int __xstat(int ver, const char *path, struct stat *sb) return ret; } -#endif /* HAVE___XSTAT */ +# endif /* HAVE___XSTAT */ int stat(const char *path, struct stat *sb) { @@ -278,3 +280,4 @@ DIR *opendir(const char *path) return ret; } +#endif -- 2.9.3

2 4

[libvirt] [PATCH] rpc: improve error message for bounds check
by Daniel P. Berrange 11 May '17

11 May '17

If we exceed a fixed limit in RPC code we get a horrible message like this, if the parameter type is a 'string', because we forgot to initialize the error message type field: $ virsh snapshot-list ostack1 error: too many remote undefineds: 1329 > 1024 It would also be useful to know which RPC call and field was exceeded. So this patch makes us report: $ virsh snapshot-list ostack1 error: too many remote undefineds: 1329 > 1024, in parameter 'names' for 'virDomainSnapshotListNames' Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/rpc/gendispatch.pl | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl index 173189c..0c5e4ba 100755 --- a/src/rpc/gendispatch.pl +++ b/src/rpc/gendispatch.pl @@ -1501,6 +1501,7 @@ elsif ($mode eq "client") { $single_ret_list_name = $1; $single_ret_list_max_var = "max$1"; $single_ret_list_max_define = $2; + $single_ret_list_error_msg_type = "string"; } elsif ($ret_member =~ m/^(admin|remote)_nonnull_string (\S+)<\S+>;/) { # error out on unannotated arrays die "$1_nonnull_string array without insert@<offset> annotation: $ret_member"; @@ -1773,7 +1774,8 @@ elsif ($mode eq "client") { print "\n"; print " if ($single_ret_list_max_var > $single_ret_list_max_define) {\n"; print " virReportError(VIR_ERR_RPC,\n"; - print " _(\"too many remote ${single_ret_list_error_msg_type}s: %d > %d\"),\n"; + print " _(\"too many remote ${single_ret_list_error_msg_type}s: %d > %d,\"\n"; + print " \"in parameter '$single_ret_list_name' for 'vir$call->{ProcName}'\"),\n"; print " $single_ret_list_max_var, $single_ret_list_max_define);\n"; print " goto done;\n"; print " }\n"; @@ -1839,7 +1841,8 @@ elsif ($mode eq "client") { $modern_ret_as_list) { print " if (ret.$single_ret_list_name.${single_ret_list_name}_len > $single_ret_list_max_var) {\n"; print " virReportError(VIR_ERR_RPC,\n"; - print " _(\"too many remote ${single_ret_list_error_msg_type}s: %d > %d\"),\n"; + print " _(\"too many remote ${single_ret_list_error_msg_type}s: %d > %d,\"\n"; + print " \"in parameter '$single_ret_list_name' for 'vir$call->{ProcName}'\"),\n"; print " ret.$single_ret_list_name.${single_ret_list_name}_len, $single_ret_list_max_var);\n"; print " goto cleanup;\n"; print " }\n"; -- 2.9.3

3 2

[libvirt] Release of libvirt-php-0.5.3
by Michal Privoznik 11 May '17

11 May '17

I just did the release of libvirt-php-0.5.3. You can download it here: http://libvirt.org/sources/php/libvirt-php-0.5.3.tar.gz There are 77 patches in this release (nearly 2x as much as in the previous release). There were several bug fixes, style conversions, etc. New features include: - New APIs - examples enhancement - build system improvements and many others. Thanks anybody who contributed! Michal

1 0

[libvirt] [PATCH] remote: increase max storage pools, nwfilters & snapshots to 16384
by Daniel P. Berrange 11 May '17

11 May '17

Most other top level objects have already had their limits increased to 16384. Increase the storage pool, nwfilter & snapshot object limits to match. For snapshots at least, we have seen hosts which exceeded the current limit Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/remote/remote_protocol.x | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/remote/remote_protocol.x b/src/remote/remote_protocol.x index 87b2bd3..4e3fa60 100644 --- a/src/remote/remote_protocol.x +++ b/src/remote/remote_protocol.x @@ -80,7 +80,7 @@ const REMOTE_NETWORK_LIST_MAX = 16384; const REMOTE_INTERFACE_LIST_MAX = 16384; /* Upper limit on lists of storage pools. */ -const REMOTE_STORAGE_POOL_LIST_MAX = 4096; +const REMOTE_STORAGE_POOL_LIST_MAX = 16384; /* Upper limit on lists of storage vols. */ const REMOTE_STORAGE_VOL_LIST_MAX = 16384; @@ -92,7 +92,7 @@ const REMOTE_NODE_DEVICE_LIST_MAX = 65536; const REMOTE_NODE_DEVICE_CAPS_LIST_MAX = 65536; /* Upper limit on lists of network filters. */ -const REMOTE_NWFILTER_LIST_MAX = 1024; +const REMOTE_NWFILTER_LIST_MAX = 16384; /* Upper limit on list of scheduler parameters. */ const REMOTE_DOMAIN_SCHEDULER_PARAMETERS_MAX = 16; @@ -137,7 +137,7 @@ const REMOTE_AUTH_TYPE_LIST_MAX = 20; const REMOTE_DOMAIN_MEMORY_STATS_MAX = 1024; /* Upper limit on lists of domain snapshots. */ -const REMOTE_DOMAIN_SNAPSHOT_LIST_MAX = 1024; +const REMOTE_DOMAIN_SNAPSHOT_LIST_MAX = 16384; /* Maximum length of a block peek buffer message. * Note applications need to be aware of this limit and issue multiple -- 2.9.3

2 1

[libvirt] [RFE] Raise enumeration limit for virDomain-{ListAllSnapshots, SnapshotListNames}?
by Kashyap Chamarthy 11 May '17

11 May '17

I've got a server with multiple guests, and wanted to quickly check how many of them had snapshots (and in turn, how many snapshots). So I quickly wrote the below script to enumerate the snapshots using the virDomainSnapshotListNames() API, and it turned out, one of the guests had 1329 snaphots (created by a script for testing): libvirt.libvirtError: too many remote undefineds: 1329 > 1024 DanPB on IRC said we could likely raise that limit: "we can likely increase that limit, since the rpc message size would allow many more before the ultimate limit is hit" He also points out the error message could be improved and is a sign of a bug: "'undefined' is a perl NULL that must come from a bug in the rpc generator" * * * Script I used to test: [ Version: libvirt-daemon-kvm-3.2.0-1.fc25.x86_64 ] ----------------------------------------------------------------------- #!/usr/bin/python import libvirt import sys conn = libvirt.openReadOnly('qemu:///system') if conn == None: print 'Failed to open connection to the hypervisor' sys.exit(1) domains = conn.listAllDomains(0) for name in domains: try: dom = conn.lookupByName(name.name()) except libvirt.libvirtError: print "Domain %s not found" % name sys.exit(1) print("Name: %s, ID: %d, OSType: %s" % (name.name(), dom.ID(), dom.OSType())) # print(dom.listAllSnapshots()) print(dom.snapshotListNames()) ----------------------------------------------------------------------- Executing the above script throws (since the 'ostack1' guest apparently had 1329 snapshots): [...] Name: cirros, ID: -1, OSType: hvm [] Name: compute, ID: -1, OSType: hvm [] Name: ostack1, ID: -1, OSType: hvm Traceback (most recent call last): File "enumerate-snapshots.py", line 23, in <module> print(dom.snapshotListNames()) File "/usr/lib64/python2.7/site-packages/libvirt.py", line 2527, in snapshotListNames if ret is None: raise libvirtError ('virDomainSnapshotListNames() failed', dom=self) libvirt.libvirtError: too many remote undefineds: 1329 > 1024 [...] -- /kashyap

1 1

[libvirt] CLI management tool
by Michal Privoznik 11 May '17

11 May '17

Dear list, you might have seen a discussion about virsh, and adding some new features to it [1]. While the feature was rejected, it got me thinking. What options do we offer for sysadmins that: a) want to stay in command line b) want higher level mgmt of their domains c) yet want to manage a single host Basically, virsh is just too low level for some operations (and using it in non-interactive mode from a script can mean hundreds of connections). Then we have virt-manager, which suits b) and c), but it's not a CLI tool. Therefore I was thinking whether we should start a new project on the top of libvirt that would fit all three points. Personally, I've never been a sysadmin, so perhaps I am not the best one to write the tool. But I'm open for suggestions. What do you think? Michal 1: https://www.redhat.com/archives/libvir-list/2017-May/msg00051.html

4 3

[libvirt] [PATCH] virsh: Add --tls description for the virsh man page
by John Ferlan 11 May '17

11 May '17

https://bugzilla.redhat.com/show_bug.cgi?id=1448806 Commit id '6a8d898d' neglected to update the man page. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- tools/virsh.pod | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index cd1f25f..727acf6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1672,7 +1672,7 @@ I<domain> I<desturi> [I<migrateuri>] [I<graphicsuri>] [I<listen-address>] [I<dna [I<--compressed>] [I<--comp-methods> B<method-list>] [I<--comp-mt-level>] [I<--comp-mt-threads>] [I<--comp-mt-dthreads>] [I<--comp-xbzrle-cache>] [I<--auto-converge>] [I<auto-converge-initial>] -[I<auto-converge-increment>] [I<--persistent-xml> B<file>] +[I<auto-converge-increment>] [I<--persistent-xml> B<file>] [I<--tls>] Migrate domain to another host. Add I<--live> for live migration; <--p2p> for peer-2-peer migration; I<--direct> for direct migration; or I<--tunnelled> @@ -1753,6 +1753,11 @@ compression. I<--comp-mt-threads> and I<--comp-mt-dthreads> set the number of compress threads on source and the number of decompress threads on target respectively. I<--comp-xbzrle-cache> sets size of page cache in bytes. +Providing I<--tls> causes the migration to use the host configured TLS setup +(see migrate_tls_x509_cert_dir in /etc/libvirt/qemu.conf) in order to perform +the migration of the domain. Usage requires proper TLS setup for both source +and target. + Running migration can be canceled by interrupting virsh (usually using C<Ctrl-C>) or by B<domjobabort> command sent from another virsh instance. -- 2.9.3

2 1

[libvirt] [libvirt-php PATCH 0/2] implement a few network API bindings
by Dawid Zamirski 11 May '17

11 May '17

Hello, The followinig two patches add a few useful API bindings for dealing with libvirt networks: * virConnectListAllNetworks - allows for better control when filtering and returns array of handles to virNetworkPtr which can then be used to get other info for each network such as name, uuid, autostart etc. * virNetworkGetUUIDString, virNetworkGetUUID, virNetworkGetName to be able to easily get said info when working with virNetworkPtr handles. Dawid Zamirski (2): implement binding for virConnectListAllNetworks. implement additional network functions. src/libvirt-php.c | 149 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ src/libvirt-php.h | 4 ++ 2 files changed, 153 insertions(+) -- 2.12.2

3 5

[libvirt] src/remote_protocol-structs file
by Vasiliy Tolstov 11 May '17

11 May '17

Hi. While i'm writing go binding for libvirt rpc api i'm parse src/remote/remote_protocol.x and generate needed code for go, but as i see libvirt have src/remote_protocol-structs file. That contains all needed data in mo simple syntax. But i don't see such files for qemu_protocol.x and lxc_protocol.x do you plan to add files for this xdr files, or src/remote_protocol-structs will be deprecated? Thanks! -- Vasiliy Tolstov, e-mail: v.tolstov(a)selfip.ru

2 2

[libvirt] [PATCH v2 0/5] Prevent losing IPv6 routes due to forwarding
by Cédric Bosdonnat 11 May '17

11 May '17

Hi Laine, all, Here is the v2 of my series. The changes are: * Add a commit to create a virNetDevGetName() function * Fix Laine's comments Cédric Bosdonnat (5): util: extract the request sending code from virNetlinkCommand() util: add virNetlinkDumpCommand() bridge_driver.c: more uses of SYSCTL_PATH util: add virNetDevGetName() function network: check accept_ra before enabling ipv6 forwarding src/libvirt_private.syms | 3 + src/network/bridge_driver.c | 25 ++++--- src/util/virnetdev.c | 19 ++++++ src/util/virnetdev.h | 2 + src/util/virnetdevip.c | 158 ++++++++++++++++++++++++++++++++++++++++++++ src/util/virnetdevip.h | 1 + src/util/virnetlink.c | 145 ++++++++++++++++++++++++++++++---------- src/util/virnetlink.h | 9 +++ 8 files changed, 319 insertions(+), 43 deletions(-) -- 2.11.0

5 23

[libvirt] [PATCH v2] libxl: report numa sibling distances on host capabilities
by Wim Ten Have 11 May '17

11 May '17

From: Wim ten Have <wim.ten.have(a)oracle.com> When running on a NUMA machine, populate the sibling node and distance information using data supplied by Xen. Wim ten Have (1): libxl: report numa sibling distances on host capabilities src/libxl/libxl_capabilities.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) -- 2.9.3

3 3

[libvirt] [PATCH] Add missing deps on virfilewrapper.h
by Daniel P. Berrange 10 May '17

10 May '17

The test programs depend on virfilewrapper.h as well as the virfilewrapper.c. Adding the dep ensures that virfilewrapper.h gets included in the dist tarball. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a build fix, since RPM build / distcheck is broken without this tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 5c77b55..7673329 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -930,7 +930,7 @@ virconftest_SOURCES = \ virconftest_LDADD = $(LDADDS) virhostcputest_SOURCES = \ - virhostcputest.c testutils.h testutils.c virfilewrapper.c + virhostcputest.c testutils.h testutils.c virfilewrapper.h virfilewrapper.c virhostcputest_LDADD = $(LDADDS) commandtest_SOURCES = \ @@ -1147,7 +1147,7 @@ virhostcpumock_la_LIBADD = $(MOCKLIBS_LIBS) if WITH_LINUX vircaps2xmltest_SOURCES = \ - vircaps2xmltest.c testutils.h testutils.c virfilewrapper.c + vircaps2xmltest.c testutils.h testutils.c virfilewrapper.h virfilewrapper.c vircaps2xmltest_LDADD = $(LDADDS) virnumamock_la_SOURCES = \ -- 2.9.3

1 0

[libvirt] [PATCH] nodedev_udev: Fix missing events when kernel report lots of udev events within a short time
by ZhiPeng Lu 10 May '17

10 May '17

From: "ning.bo" <ning.bo9(a)zte.com.cn> When create Virtual Function for Inter XL710 use below commands: for i in `seq 0 1`; do echo 63 > /sys/devices/pci0000:00/0000:00:03.2/0000:07:00.$i/sriov_numvfs done for i in `seq 0 3`; do echo 31 > /sys/devices/pci0000:80/0000:80:02.2/0000:82:00.$i/sriov_numvfs done The libvirtd will missing some udev events, the result of libvirt-python API listDevices('pci') will not list all pci devices. The reason is that the buffer of udev monitor default size cann't save all udev events reported by kernel. So we need change buffer size so that we can receive as much events as possible whitin a short time. Signed-off-by: ning.bo <ning.bo9(a)zte.com.cn> --- src/node_device/node_device_udev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c index 6e706a1..d813206 100644 --- a/src/node_device/node_device_udev.c +++ b/src/node_device/node_device_udev.c @@ -1564,6 +1564,7 @@ static int nodeStateInitialize(bool privileged, } udev_monitor_enable_receiving(priv->udev_monitor); + udev_monitor_set_receive_buffer_size(priv->udev_monitor, 128 * 1024 * 1024); /* We register the monitor with the event callback so we are * notified by udev of device changes before we enumerate existing -- 2.8.3

3 3

[libvirt] [PATCH 0/2] qemu: driver: Document and fix usage of qemuOpenFile
by Peter Krempa 10 May '17

10 May '17

Peter Krempa (2): qemu: driver: Document qemuOpenFile qemu: driver: Fix usage of qemuOpenFile src/qemu/qemu_driver.c | 29 ++++++++++++++++++++++++----- 1 file changed, 24 insertions(+), 5 deletions(-) -- 2.12.2

2 3

[libvirt] [PATCH] Don't inline virStringTrimOptionalNewline
by Daniel P. Berrange 10 May '17

10 May '17

GCC complains that inlining virStringTrimOptionalNewline is not likely on some platforms: cc1: warnings being treated as errors ../../src/util/virfile.c: In function 'virFileReadValueBitmap': ../../src/util/virstring.h:292: error: inlining failed in call to 'virStringTrimOptionalNewline': call is unlikely and code size would grow [-Winline] ../../src/util/virfile.c:3987: error: called from here [-Winline] Inlining this function is not going to be a measurable performance benefit either, since the time required to execute it is going to be dominated by running of strlen() over the string, not by the function call overhead. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- Pushed as a broken build fix src/libvirt_private.syms | 1 + src/util/virstring.c | 14 ++++++++++++++ src/util/virstring.h | 8 +------- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 4cca0ca..afb9100 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2630,6 +2630,7 @@ virStringSplitCount; virStringStripControlChars; virStringStripIPv6Brackets; virStringToUpper; +virStringTrimOptionalNewline; virStrncpy; virStrndup; virStrToDouble; diff --git a/src/util/virstring.c b/src/util/virstring.c index 69abc26..335e773 100644 --- a/src/util/virstring.c +++ b/src/util/virstring.c @@ -1180,3 +1180,17 @@ virStringEncodeBase64(const uint8_t *buf, size_t buflen) return ret; } + +/** + * virStringTrimOptionalNewline: + * @str: the string to modify in-place + * + * Modify @str to remove a single '\n' character + * from its end, if one exists. + */ +void virStringTrimOptionalNewline(char *str) +{ + char *tmp = str + strlen(str) - 1; + if (*tmp == '\n') + *tmp = '\0'; +} diff --git a/src/util/virstring.h b/src/util/virstring.h index 603650a..c545ca3 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -288,12 +288,6 @@ bool virStringBufferIsPrintable(const uint8_t *buf, size_t buflen); char *virStringEncodeBase64(const uint8_t *buf, size_t buflen); -static inline void -virStringTrimOptionalNewline(char *str) -{ - char *tmp = str + strlen(str) - 1; - if (*tmp == '\n') - *tmp = '\0'; -} +void virStringTrimOptionalNewline(char *str); #endif /* __VIR_STRING_H__ */ -- 2.9.3

2 2

[libvirt] [RFC PATCH REBASE 00/10] introduce push backups
by Nikolay Shirokovskiy 10 May '17

10 May '17

Push backup is a backup when hypervisor itself copy backup data to destination in contrast to pull backup when hypervisor exports backup data thru some interface and mgmt itself make a copy. This patch series basically adds creating backup to API/remote/qemu/virsh and initial backup XML definition. Just like other blockjobs backup creation is asynchronous. That is creation is merely a backup start and client should track backup error/completion thru blockjob events. As backup is done transactionally all individual disk backup jobs will be aborted by qemu itself in case of error, client need not to do it manually. Client can cancel the backup by aborting blockjob on any disk being backed up. Backup xml desription is similar to snapshot one with some exceptions and is described in more details in definition patch [1]. I guess good client will track progress for every disk in backup to report progress and detect hangs so it don't need extra backup complete/error event that aggregate the overall backup result. However it looks like aborting backup can be implemented in libvirt as code will be common for all clients. We need to abort some of not yet completed per disk backups and retry if job to be aborted is completed meanwhile. Of coures this series is far from being complete. Incremental backups and backup persistent metadata is to be implemented. Let's just start work in this direction. Nikolay Shirokovskiy (10): api: backup: add api to create backup api: backup: add driver based implementation remote: backup: add create backup implementation backup: qemu: monitor: add drive-backup command backup: misc: add backup block job type conf: backup: add backup xml definition [1] qemu: backup: add qemuDomainBackupCreateXML implementation qemu: backup: check backup destination before start qemu: backup: prepare backup destination virsh: backup: add backup-create command Links: In [1] we came to agreement to create distinct API to support backup operations and there is a discussion of pull backup series in [2]. The latter is blocked as some necessary operations are still experimental in qemu. [1] https://www.redhat.com/archives/libvir-list/2016-March/msg00937.html [2] https://www.redhat.com/archives/libvir-list/2016-September/msg00192.html daemon/remote.c | 8 + examples/object-events/event-test.c | 3 + include/libvirt/libvirt-domain-backup.h | 59 +++++++ include/libvirt/libvirt-domain.h | 3 + include/libvirt/libvirt.h | 1 + include/libvirt/virterror.h | 2 + po/POTFILES.in | 2 + src/Makefile.am | 3 + src/access/viraccessperm.c | 3 +- src/access/viraccessperm.h | 6 + src/conf/backup_conf.c | 299 ++++++++++++++++++++++++++++++++ src/conf/backup_conf.h | 70 ++++++++ src/conf/domain_conf.c | 2 +- src/datatypes.c | 60 +++++++ src/datatypes.h | 29 ++++ src/driver-hypervisor.h | 5 + src/libvirt-domain-backup.c | 202 +++++++++++++++++++++ src/libvirt_private.syms | 9 + src/libvirt_public.syms | 10 ++ src/qemu/qemu_conf.h | 1 + src/qemu/qemu_driver.c | 239 ++++++++++++++++++++++++- src/qemu/qemu_monitor.c | 14 ++ src/qemu/qemu_monitor.h | 5 + src/qemu/qemu_monitor_json.c | 36 ++++ src/qemu/qemu_monitor_json.h | 5 + src/remote/remote_driver.c | 7 + src/remote/remote_protocol.x | 23 ++- src/rpc/gendispatch.pl | 29 +++- src/util/virerror.c | 6 + tools/Makefile.am | 1 + tools/virsh-backup.c | 100 +++++++++++ tools/virsh-backup.h | 29 ++++ tools/virsh-domain.c | 3 +- tools/virsh-util.c | 11 ++ tools/virsh-util.h | 3 + tools/virsh.c | 2 + tools/virsh.h | 1 + 37 files changed, 1279 insertions(+), 12 deletions(-) create mode 100644 include/libvirt/libvirt-domain-backup.h create mode 100644 src/conf/backup_conf.c create mode 100644 src/conf/backup_conf.h create mode 100644 src/libvirt-domain-backup.c create mode 100644 tools/virsh-backup.c create mode 100644 tools/virsh-backup.h -- 1.8.3.1

2 14

[libvirt] [PATCH] spec: Update version check for maint Source URL
by Cole Robinson 09 May '17

09 May '17

New maint release version numbers of just A.B.C format, not the old A.B.C.D format. Adjust the check that dynamically changes the Source URL for maint releases --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b249224..734b187 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -233,7 +233,7 @@ Group: Development/Libraries BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root URL: http://libvirt.org/ -%if %(echo %{version} | grep -o \\. | wc -l) == 3 +%if %(echo %{version} | grep -q "\.0$"; echo $?) == 1 %define mainturl stable_updates/ %endif Source: http://libvirt.org/sources/%{?mainturl}libvirt-%{version}.tar.xz -- 2.9.3

2 3

[libvirt] [PATCH] conf: Check CPU cache for ABI stability
by Jiri Denemark 09 May '17

09 May '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/conf/cpu_conf.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 1b098c476..194f03faf 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -915,6 +915,16 @@ virCPUDefIsEqual(virCPUDefPtr src, } } + if ((src->cache && !dst->cache) || + (!src->cache && dst->cache) || + (src->cache && dst->cache && + (src->cache->level != dst->cache->level || + src->cache->mode != dst->cache->mode))) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + "Target CPU cache does not match source"); + goto cleanup; + } + identical = true; cleanup: -- 2.12.2

2 1