- Devel - libvirt List Archives

[libvirt] [PATCH v3 REBASE 00/16] qemu: migration: show disks stats for nbd migration
by Nikolay Shirokovskiy 30 Aug '17

30 Aug '17

diff from v2: ============ 1. Fix style issues. 2. Rework patch for fetching job info (save logic to use temporary variable when drop vm lock) 3. Update disk stats when block jobs are canceled. 4. Adress a few more corner cases. This patch series add disks stats to domain job info(stats) as well as to migration completed event in case nbd scheme is used. There is little nuisance with qcow2 disks (which is the main scenario I guess) tied to the way qemu reports stats for this type of disks. For example if we have 64G disk filled only to 1G then stats start from 63G and will grow up to 64G on completion. The same way disk stats will be reported by this patch. I guess the better way to express the situation is to say we have 64G 'total', and have 'processed' field grow from 0G to 1G, like in case of memory stats. [1] is the example of completed memory stats of empty guest domain, which show difference between processed and total. There can be a workaround like getting initial blockjob offset position as a zero but is is rather ugly and racy and like uses undocumented behaviour. Patches that were explicitly ACKed in previous review (up to style issues) marked with A. [1] memory migration stats example Memory processed: 3.307 MiB Memory remaining: 0.000 B Memory total: 1.032 GiB Nikolay Shirokovskiy (16): qemu: drop code for VIR_DOMAIN_JOB_BOUNDED and timeRemaining A qemu: introduce qemu domain job status A qemu: introduce QEMU_DOMAIN_JOB_STATUS_POSTCOPY A qemu: drop QEMU_MIGRATION_COMPLETED_UPDATE_STATS A qemu: drop excessive zero-out in qemuMigrationFetchJobStatus qemu: refactor fetching migration stats A qemu: simplify getting completed job stats qemu: fail querying destination migration statistics always qemu: start all async job with job status active qemu: introduce migrating job status qemu: always get job condition on getting job stats qemu: migrate: show disks stats on job info requests qemu: support getting disks stats during stopping block jobs qemu: migation: resolve race on getting job info and stopping block jobs qemu: migrate: copy disks stats to completed job qemu: migration: don't expose incomplete job as complete src/qemu/qemu_blockjob.c | 1 + src/qemu/qemu_domain.c | 38 +++++-- src/qemu/qemu_domain.h | 15 ++- src/qemu/qemu_driver.c | 94 ++++++++-------- src/qemu/qemu_migration.c | 236 ++++++++++++++++++++++++++------------- src/qemu/qemu_migration.h | 15 ++- src/qemu/qemu_migration_cookie.c | 7 +- src/qemu/qemu_monitor.c | 5 +- src/qemu/qemu_monitor.h | 4 +- src/qemu/qemu_monitor_json.c | 4 +- src/qemu/qemu_process.c | 11 +- tests/qemumonitorjsontest.c | 1 + 12 files changed, 272 insertions(+), 159 deletions(-) -- 1.8.3.1

2 34

[libvirt] [PATCH] Add qcow2 cache configuration
by Liu Qing 30 Aug '17

30 Aug '17

Random write IOPS will drop dramatically if qcow2 l2 cache could not cover the whole disk. This patch give libvirt user a chance to adjust the qcow2 cache configuration. Signed-off-by: Liu Qing <liuqing(a)huayun.com> --- src/conf/domain_conf.c | 30 ++++++++++++++++++++++++++++++ src/qemu/qemu_command.c | 6 ++++++ src/util/virstoragefile.c | 3 +++ src/util/virstoragefile.h | 4 ++++ 4 files changed, 43 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index d97aab4..06ca1de 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8590,6 +8590,30 @@ virDomainDiskDefDriverParseXML(virDomainDiskDefPtr def, VIR_FREE(tmp); } + if ((tmp = virXMLPropString(cur, "l2-cache-size")) && + (virStrToLong_ui(tmp, NULL, 10, &def->src->l2_cache_size) < 0)) { + virReportError(VIR_ERR_XML_ERROR, + _("Invalid l2-cache-size attribute in disk driver element: %s"), + tmp); + goto cleanup; + } + + if ((tmp = virXMLPropString(cur, "refcount-cache-size")) && + (virStrToLong_ui(tmp, NULL, 10, &def->src->refcount_cache_size) < 0)) { + virReportError(VIR_ERR_XML_ERROR, + _("Invalid refcount-cache-size attribute in disk driver element: %s"), + tmp); + goto cleanup; + } + + if ((tmp = virXMLPropString(cur, "cache-clean-interval")) && + (virStrToLong_ui(tmp, NULL, 10, &def->src->cache_clean_interval) < 0)) { + virReportError(VIR_ERR_XML_ERROR, + _("Invalid cache-clean-interval attribute in disk driver element: %s"), + tmp); + goto cleanup; + } + if ((tmp = virXMLPropString(cur, "detect_zeroes")) && (def->detect_zeroes = virDomainDiskDetectZeroesTypeFromString(tmp)) <= 0) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -21887,6 +21911,12 @@ virDomainDiskDefFormat(virBufferPtr buf, virBufferAsprintf(&driverBuf, " iothread='%u'", def->iothread); if (def->detect_zeroes) virBufferAsprintf(&driverBuf, " detect_zeroes='%s'", detect_zeroes); + if (def->src->l2_cache_size > 0) + virBufferAsprintf(&driverBuf, " l2-cache-size='%u'", def->src->l2_cache_size); + if (def->src->refcount_cache_size > 0) + virBufferAsprintf(&driverBuf, " refcount-cache-size='%u'", def->src->refcount_cache_size); + if (def->src->cache_clean_interval > 0) + virBufferAsprintf(&driverBuf, " cache-clean-interval='%u'", def->src->cache_clean_interval); virDomainVirtioOptionsFormat(&driverBuf, def->virtio); diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 9a27987..7996eed 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -1430,6 +1430,12 @@ qemuBuildDriveSourceStr(virDomainDiskDefPtr disk, qemuformat = "luks"; virBufferAsprintf(buf, "format=%s,", qemuformat); } + if (disk->src->format == VIR_STORAGE_FILE_QCOW2 && disk->src->l2_cache_size > 0) + virBufferAsprintf(buf, "l2-cache-size=%u,", disk->src->l2_cache_size); + if (disk->src->format == VIR_STORAGE_FILE_QCOW2 && disk->src->refcount_cache_size > 0) + virBufferAsprintf(buf, "refcount-cache-size=%u,", disk->src->refcount_cache_size); + if (disk->src->format == VIR_STORAGE_FILE_QCOW2 && disk->src->cache_clean_interval > 0) + virBufferAsprintf(buf, "cache-clean-interval=%u,", disk->src->cache_clean_interval); ret = 0; diff --git a/src/util/virstoragefile.c b/src/util/virstoragefile.c index fbc8245..c685331 100644 --- a/src/util/virstoragefile.c +++ b/src/util/virstoragefile.c @@ -2038,6 +2038,9 @@ virStorageSourceCopy(const virStorageSource *src, ret->physical = src->physical; ret->readonly = src->readonly; ret->shared = src->shared; + ret->l2_cache_size = src->l2_cache_size; + ret->refcount_cache_size = src->refcount_cache_size; + ret->cache_clean_interval = src->cache_clean_interval; /* storage driver metadata are not copied */ ret->drv = NULL; diff --git a/src/util/virstoragefile.h b/src/util/virstoragefile.h index 6c388b1..e7889d9 100644 --- a/src/util/virstoragefile.h +++ b/src/util/virstoragefile.h @@ -280,6 +280,10 @@ struct _virStorageSource { /* metadata that allows identifying given storage source */ char *nodeformat; /* name of the format handler object */ char *nodestorage; /* name of the storage object */ + + unsigned l2_cache_size; /* qcow2 l2 cache size */ + unsigned refcount_cache_size; /* qcow2 reference count table cache size */ + unsigned cache_clean_interval; /* clean unused cache entries interval */ }; -- 1.8.3.1

2 2

[libvirt] [PATCH for 3.7.0] docs: Document yet another limitation of tx_queue_size
by Michal Privoznik 30 Aug '17

30 Aug '17

https://bugzilla.redhat.com/show_bug.cgi?id=1484234 Turns out, only vhostuser type of interfaces are supported currently. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- I'd like to get this one in since the whole feature is being introduced in this release. docs/formatdomain.html.in | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 19e869f12..8ca7637a4 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5213,7 +5213,10 @@ qemu-kvm -net nic,model=? /dev/null The default value is hypervisor dependent and may change across its releases. Moreover, some hypervisors may pose some restrictions on actual value. For instance, QEMU - v2.9 requires value to be a power of two from [256, 1024] range. + v2.9 requires value to be a power of two from [256, 1024] + range. In addition to that, this may work only for a subset of + interface types, e.g. aforementioned QEMU enables this option + only for <code>vhostuser</code> type. Since 3.7.0 (QEMU and KVM only) In general you should leave this option alone, unless you -- 2.13.5

2 4

[libvirt] [PATCH] rpc: avoid ssh interpreting malicious hostname as arguments
by Daniel P. Berrange 30 Aug '17

30 Aug '17

Inspired by the recent GIT / Mercurial security flaws (http://blog.recurity-labs.com/2017-08-10/scm-vulns) consider someone/something manages to feed libvirt a bogus URI such as: virsh -c qemu+ssh://-oProxyCommand=gnome-calculator/system In this case, the hosname "-oProxyCommand=gnome-calculator" will get interpreted as an argument to ssh, not a hostname. Fortunately, due to the set of args we have following the hostname, SSH will then interpret our bit of shell script that runs 'nc' on the remote host as a cipher name, which is clearly invalid. This makes ssh exit during argv parsing and so it never tries to run gnome-calculator. We are lucky this time, but lets be more paranoid, by using '--' to explicitly tell SSH when it has finished seeing command line options. This forces it to interpret "-oProxyCommand=gnome-calculator" as a hostname, and thus see a fail from hostname lookup. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- src/rpc/virnetsocket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c index d228c8a8c..23089afef 100644 --- a/src/rpc/virnetsocket.c +++ b/src/rpc/virnetsocket.c @@ -868,7 +868,7 @@ int virNetSocketNewConnectSSH(const char *nodename, if (!netcat) netcat = "nc"; - virCommandAddArgList(cmd, nodename, "sh", "-c", NULL); + virCommandAddArgList(cmd, "--", nodename, "sh", "-c", NULL); virBufferEscapeShell(&buf, netcat); if (virBufferCheckError(&buf) < 0) { -- 2.13.5

3 2

[libvirt] [PATCH] Fix TLS test suites with gnutls 3.6.0
by Daniel P. Berrange 30 Aug '17

30 Aug '17

With gnutls 3.6.0, SHA1 is no longer accepted for certificate signatures. We must usw SHA256 instead. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com> --- tests/virnettlshelpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virnettlshelpers.c b/tests/virnettlshelpers.c index 531d0b907..b735c4e2f 100644 --- a/tests/virnettlshelpers.c +++ b/tests/virnettlshelpers.c @@ -384,7 +384,7 @@ testTLSGenerateCert(struct testTLSCertReq *req, * If no 'ca' is set then we are self signing * the cert. This is done for the root CA certs */ - if ((err = gnutls_x509_crt_sign(crt, ca ? ca : crt, privkey)) < 0) { + if ((err = gnutls_x509_crt_sign2(crt, ca ? ca : crt, privkey, GNUTLS_DIG_SHA256, 0)) < 0) { VIR_WARN("Failed to sign certificate %s", gnutls_strerror(err)); abort(); } -- 2.13.5

3 2

[libvirt] [PATCH] lxcStateInitialize: Don't leak driver's caps
by Michal Privoznik 30 Aug '17

30 Aug '17

Funny thing. So when initializing LXC driver's capabilities, firstly the virLXCDriverGetCapabilities() is called. This creates new capabilities, stores them under driver->caps, ref() them and return them. However, the return value is ignored. Secondly, the function is called yet again and since we have driver->caps set, they are ref()-ed again an returned. So in the end, driver's capabilities have refcount of three when in fact they should have refcount of one. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/lxc/lxc_driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 6eb88b0ba..784edad39 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -1660,7 +1660,7 @@ static int lxcStateInitialize(bool privileged, if (!(lxc_driver->hostdevMgr = virHostdevManagerGetDefault())) goto cleanup; - if ((virLXCDriverGetCapabilities(lxc_driver, true)) == NULL) + if (!(caps = virLXCDriverGetCapabilities(lxc_driver, true))) goto cleanup; if (!(lxc_driver->xmlopt = lxcDomainXMLConfInit())) @@ -1669,9 +1669,6 @@ static int lxcStateInitialize(bool privileged, if (!(lxc_driver->closeCallbacks = virCloseCallbacksNew())) goto cleanup; - if (!(caps = virLXCDriverGetCapabilities(lxc_driver, false))) - goto cleanup; - if (virFileMakePath(cfg->stateDir) < 0) { virReportSystemError(errno, _("Failed to mkdir %s"), @@ -1700,6 +1697,7 @@ static int lxcStateInitialize(bool privileged, goto cleanup; virNWFilterRegisterCallbackDriver(&lxcCallbackDriver); + virObjectUnref(caps); return 0; cleanup: -- 2.13.5

2 1

[libvirt] [PATCH v2 0/2] Yet another namespace fix, kinda
by Martin Kletzander 29 Aug '17

29 Aug '17

Fixing easy problem (patch 1) lead me to finding out that there is yet another problem that needs fixing (patch 2). For more information read the code. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1443434 Martin Kletzander (2): qemu: Don't mangle the storage format for type='dir' qemu: Also treat directories properly when using namespaces src/qemu/qemu_domain.c | 40 +++++++++++++++++++++++++++++++++++----- src/storage/storage_source.c | 12 +++++++++--- tests/virstoragetest.c | 11 +++++++++-- 3 files changed, 53 insertions(+), 10 deletions(-) -- 2.14.1

2 3

[libvirt] [PATCH v5 0/7] Add managed save XML modification APIs (pushed)
by Peter Krempa 29 Aug '17

29 Aug '17

This is the version I've pushed. I'm sending it in for a reference of the modifications I've made as part of the review. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save state domain lib: Add API to edit domain's managed save state xml configuration qemu: Implement qemuDomainManagedSaveGetXMLDesc qemu: Implement qemuDomainManagedSaveDefineXML virsh: Implement managedsave-define command virsh: Implement managedsave-dumpxml command virsh: Implement managedsave-edit command include/libvirt/libvirt-domain.h | 6 ++ src/driver-hypervisor.h | 11 +++ src/libvirt-domain.c | 106 ++++++++++++++++++++ src/libvirt_public.syms | 2 + src/qemu/qemu_driver.c | 79 +++++++++++++++ src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 30 +++++- src/remote_protocol-structs | 14 +++ tools/virsh-domain.c | 204 +++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 39 ++++++++ 10 files changed, 492 insertions(+), 1 deletion(-) -- 2.14.1

1 7

[libvirt] [PATCH v2] qemu: Honour <on_reboot/>
by Michal Privoznik 29 Aug '17

29 Aug '17

https://bugzilla.redhat.com/show_bug.cgi?id=1476866 For some reason, we completely ignore <on_reboot/> setting for domains. The implementation is simply not there. It never was. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- diff to v1: - dropped the spoofed logic - Switch from qemuProcessShutdownOrReboot() to qemuPrcoessStop() because that's what <on_crash/> impl does too. src/qemu/qemu_process.c | 27 ++++++++++++++++++++++++--- 1 file changed, 24 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index fed2bc588..3df6c320e 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -484,6 +484,7 @@ qemuProcessHandleReset(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virObjectEventPtr event; qemuDomainObjPrivatePtr priv; virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); + int ret = -1; virObjectLock(vm); @@ -495,12 +496,32 @@ qemuProcessHandleReset(qemuMonitorPtr mon ATTRIBUTE_UNUSED, if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm, driver->caps) < 0) VIR_WARN("Failed to save status on vm %s", vm->def->name); + if (vm->def->onReboot == VIR_DOMAIN_LIFECYCLE_DESTROY || + vm->def->onReboot == VIR_DOMAIN_LIFECYCLE_PRESERVE) { + + if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_MODIFY) < 0) + goto cleanup; + + if (!virDomainObjIsActive(vm)) { + VIR_DEBUG("Ignoring RESET event from inactive domain %s", + vm->def->name); + goto endjob; + } + + qemuProcessStop(driver, vm, VIR_DOMAIN_SHUTOFF_DESTROYED, + QEMU_ASYNC_JOB_NONE, 0); + virDomainAuditStop(vm, "destroyed"); + qemuDomainRemoveInactive(driver, vm); + endjob: + qemuDomainObjEndJob(driver, vm); + } + + ret = 0; + cleanup: virObjectUnlock(vm); - qemuDomainEventQueue(driver, event); - virObjectUnref(cfg); - return 0; + return ret; } -- 2.13.0

2 5

[libvirt] [PATCH 0/5] introduce reconnect feature for chardev devices
by Pavel Hrdina 29 Aug '17

29 Aug '17

Pavel Hrdina (5): qemu: introduce QEMU_CAPS_CHARDEV_RECONNECT conf: introduce reconnect element for chardev source tests: add generic xml chardev reconnect tests qemu: implement chardev source reconnect tests: add qemu chardev srouce reconnect tests docs/formatdomain.html.in | 11 ++ docs/schemas/domaincommon.rng | 12 +++ src/conf/domain_conf.c | 119 +++++++++++++++++++-- src/conf/domain_conf.h | 11 ++ src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 17 +++ src/qemu/qemu_domain.c | 101 +++++++++++++++++ .../generic-chardev-reconnect-invalid-mode.xml | 26 +++++ .../generic-chardev-reconnect-missing-timeout.xml | 26 +++++ .../generic-chardev-reconnect.xml | 32 ++++++ .../generic-chardev-reconnect.xml | 33 ++++++ tests/genericxml2xmltest.c | 5 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argv-channel-reconnect.args | 31 ++++++ ...uxml2argv-chardev-reconnect-invalid-timeout.xml | 23 ++++ .../qemuxml2argv-chardev-reconnect.args | 40 +++++++ .../qemuxml2argv-chardev-reconnect.xml | 46 ++++++++ tests/qemuxml2argvtest.c | 11 ++ 31 files changed, 552 insertions(+), 8 deletions(-) create mode 100644 tests/genericxml2xmlindata/generic-chardev-reconnect-invalid-mode.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-reconnect-missing-timeout.xml create mode 100644 tests/genericxml2xmlindata/generic-chardev-reconnect.xml create mode 100644 tests/genericxml2xmloutdata/generic-chardev-reconnect.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-channel-reconnect.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-chardev-reconnect-invalid-timeout.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-chardev-reconnect.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-chardev-reconnect.xml -- 2.13.5

3 13

[libvirt] [PATCH v2 0/2] Have qemuDomainUndefineFlags grab a job
by Michal Privoznik 29 Aug '17

29 Aug '17

This is v2 to: https://www.redhat.com/archives/libvir-list/2017-August/msg00222.html diff to v1: - Split qemuDomainRemoveInactive into two functions so that its safe to call it from places where we already have a job. Michal Privoznik (2): qemu: Introduce and use qemuDomainRemoveInactiveJob qemuDomainUndefineFlags: Grab QEMU_JOB_MODIFY src/qemu/qemu_domain.c | 36 +++++++++++++++++++++++++++--------- src/qemu/qemu_domain.h | 3 +++ src/qemu/qemu_driver.c | 47 ++++++++++++++++++++++++++--------------------- src/qemu/qemu_migration.c | 10 +++++----- src/qemu/qemu_process.c | 10 +++++----- 5 files changed, 66 insertions(+), 40 deletions(-) -- 2.13.0

2 6

[libvirt] [libvirt-php][PATCH 0/3] Couple of trivial fixes/improvements
by Michal Privoznik 29 Aug '17

29 Aug '17

*** BLURB HERE *** Michal Privoznik (3): Shut up automake libvirt-php.c: Reorder includes examples: Initialize $ret in index.php configure.ac | 4 ++++ examples/index.php | 1 + src/libvirt-php.c | 8 ++++---- 3 files changed, 9 insertions(+), 4 deletions(-) -- 2.13.5

2 6

[libvirt] [PATCH v4 0/3] Add support for Veritas HyperScale (VxHS) block device protocol
by Ashish Mittal 29 Aug '17

29 Aug '17

From: Ashish Mittal <ashish.mittal(a)veritas.com> QEMU changes for VxHS (including TLS support) are already upstream. This series of patches adds support for VxHS block devices in libvirt. Patch 1 adds the base functionality for supporting VxHS protocol. Patch 2 adds two new configuration options in qemu.conf to enable TLS for VxHS devices. Patch 3 implements the main TLS functionality. Ashish Mittal (3): Add support for Veritas HyperScale (VxHS) block device protocol conf: Introduce TLS options for VxHS block device clients Add TLS support for Veritas HyperScale (VxHS) block device protocol docs/formatdomain.html.in | 31 ++++- docs/schemas/domaincommon.rng | 18 +++ src/conf/domain_conf.c | 19 +++ src/libxl/libxl_conf.c | 1 + src/qemu/libvirtd_qemu.aug | 4 + src/qemu/qemu.conf | 23 +++ src/qemu/qemu_command.c | 155 +++++++++++++++++++++ src/qemu/qemu_conf.c | 7 + src/qemu/qemu_conf.h | 3 + src/qemu/qemu_driver.c | 3 + src/qemu/qemu_parse_command.c | 25 ++++ src/qemu/test_libvirtd_qemu.aug.in | 2 + src/util/virstoragefile.c | 77 +++++++++- src/util/virstoragefile.h | 10 ++ src/xenconfig/xen_xl.c | 1 + .../qemuargv2xml-disk-drive-network-vxhs-fail.args | 24 ++++ tests/qemuargv2xmltest.c | 17 ++- ...ml2argv-disk-drive-network-tlsx509-err-vxhs.xml | 34 +++++ ...-disk-drive-network-tlsx509-multidisk-vxhs.args | 41 ++++++ ...k-drive-network-tlsx509-multidisk-vxhs.args.new | 41 ++++++ ...v-disk-drive-network-tlsx509-multidisk-vxhs.xml | 56 ++++++++ ...muxml2argv-disk-drive-network-tlsx509-vxhs.args | 28 ++++ ...emuxml2argv-disk-drive-network-tlsx509-vxhs.xml | 34 +++++ .../qemuxml2argv-disk-drive-network-vxhs.args | 25 ++++ .../qemuxml2argv-disk-drive-network-vxhs.xml | 34 +++++ tests/qemuxml2argvtest.c | 10 ++ tests/virstoragetest.c | 30 ++++ 27 files changed, 748 insertions(+), 5 deletions(-) create mode 100644 tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-vxhs-fail.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-err-vxhs.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.args.new create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-multidisk-vxhs.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-tlsx509-vxhs.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-vxhs.xml -- 2.5.5

4 24

[libvirt] [PATCH v2 0/3] Some domain name handling improvements
by Martin Kletzander 29 Aug '17

29 Aug '17

*** BRULB THERE *** Martin Kletzander (3): conf: Properly truncate wide character names in virDomainObjGetShortName qemu: Use short domain name in qemuDomainGetPreservedMountPath docs: Update news with domain name bug fixes docs/news.xml | 20 ++++++++++++++++++++ src/conf/domain_conf.c | 45 ++++++++++++++++++++++++++++++++++++++++++--- src/qemu/qemu_domain.c | 10 ++++++++-- 3 files changed, 70 insertions(+), 5 deletions(-) -- 2.14.1

2 7

[libvirt] [PATCH 0/2] Alter refresh algorithm for volWipe
by John Ferlan 29 Aug '17

29 Aug '17

Alter wipeVol to do same refresh operation as pool refresh would do. John Ferlan (2): storage: Introduce virStorageBackendRefreshVolTargetUpdate storage: Use virStorageBackendRefreshVolTargetUpdate after wipeVol src/storage/storage_driver.c | 7 ++-- src/storage/storage_util.c | 82 +++++++++++++++++++++++++++++--------------- src/storage/storage_util.h | 3 ++ 3 files changed, 62 insertions(+), 30 deletions(-) -- 2.9.5

2 7

[libvirt] [libvirt-go PATCH] Add MigrateGetMaxDowntime API
by John Ferlan 28 Aug '17

28 Aug '17

Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- This is a "best guess" effort - basically copied some previous examples from recent comments, built, and ran the same test that the CI build test runs. domain.go | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/domain.go b/domain.go index cc786dd..f83aa31 100644 --- a/domain.go +++ b/domain.go @@ -2319,6 +2319,21 @@ func (d *Domain) MigrateSetMaxSpeed(speed uint64, flags uint32) error { return nil } +func (d *Domain) MigrateGetMaxDowntime(flags uint32) (uint64, error) { + var downtime C.ulonglong + + if C.LIBVIR_VERSION_NUMBER < 3007000 { + return 0, GetNotImplementedError("virDomainMigrateGetMaxDowntime") + } + + ret := C.virDomainMigrateGetMaxDowntime(d.ptr, &downtime, C.uint(flags)) + if ret == -1 { + return 0, GetLastError() + } + + return uint64(downtime), nil +} + func (d *Domain) MigrateSetMaxDowntime(downtime uint64, flags uint32) error { ret := C.virDomainMigrateSetMaxDowntime(d.ptr, C.ulonglong(downtime), C.uint(flags)) if ret == -1 { -- 2.9.5

1 1

[libvirt] [libvirt-python PATCH 0/2] Python bindings for virDomainMigrateGetMaxDowntime
by John Ferlan 28 Aug '17

28 Aug '17

Implement the bindings similar to previous such implementations for Compression cache (commit id's 7465d31bb and feae4e052) John Ferlan (2): Introduce virDomainMigrateGetMaxDowntime API Implement virDomainMigrateGetMaxDowntime generator.py | 1 + libvirt-override-api.xml | 7 +++++++ libvirt-override.c | 33 +++++++++++++++++++++++++++++++++ 3 files changed, 41 insertions(+) -- 2.9.5

1 3

[libvirt] [libvirt-perl PATCH] Add migrate_get_max_downtime
by John Ferlan 28 Aug '17

28 Aug '17

Add new API for 3.7 pushed code for virDomainMigrateGetMaxDowntime Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- Changes | 1 + Virt.xs | 15 +++++++++++++++ lib/Sys/Virt/Domain.pm | 6 ++++++ 3 files changed, 22 insertions(+) diff --git a/Changes b/Changes index e7f6cde..a3e507f 100644 --- a/Changes +++ b/Changes @@ -3,6 +3,7 @@ Revision history for perl module Sys::Virt 3.7.0 2017-00-00 - Add VIR_FROM_RESCTRL constant + - Add migrate_get_max_downtime 3.5.0 2017-07-06 diff --git a/Virt.xs b/Virt.xs index d3019ee..11c3d8f 100644 --- a/Virt.xs +++ b/Virt.xs @@ -5325,6 +5325,21 @@ migrate_set_max_downtime(dom, downtime, flags=0) _croak_error(); +SV * +migrate_get_max_downtime(dom, flags=0) + virDomainPtr dom; + unsigned int flags; + PREINIT: + unsigned long long downtime; + CODE: + if (virDomainMigrateGetMaxDowntime(dom, &downtime, flags) < 0) + _croak_error(); + + RETVAL = virt_newSVull(downtime); + OUTPUT: + RETVAL + + void migrate_set_max_speed(dom, bandwidth, flags=0) virDomainPtr dom; diff --git a/lib/Sys/Virt/Domain.pm b/lib/Sys/Virt/Domain.pm index 20ecf9f..030e1e3 100644 --- a/lib/Sys/Virt/Domain.pm +++ b/lib/Sys/Virt/Domain.pm @@ -1254,6 +1254,12 @@ at the cost of longer time blackout for the guest OS at the switch over point. The C<downtime> parameter is measured in milliseconds. The C<$flags> parameter is currently unused and defaults to zero. +=item $downtime = $dom->migrate_get_max_downtime($flags=0) +Get the current value of the maximum downtime allowed during a +migration of a guest. The returned <downtime> value is measured +in milliseconds. The C<$flags> parameter is currently unused and +defaults to zero. + =item $dom->migrate_set_max_speed($bandwidth, $flags=0) Set the maximum allowed bandwidth during migration of the guest. -- 2.9.5

1 1

[libvirt] [PATCH v4 0/7] Add new APIs to edit xml configuration of managed save state of a domain
by Kothapally Madhu Pavan 28 Aug '17

28 Aug '17

managedsave command offloads the user from managing the save state file. It does not need the user to specify saved state file location, all it takes is domain name to identify. This makes it much more comfortable to use in emergency where immediate shutdowm is needed. But it doesn't provide a way to edit XML description of the save state file without user going through an extra effort to search manually where the file actually exists. The series aims to overcome the above constraints by adding new APIs and commands to seemlessly edit the managed save state XML description using just the domain name. The Patches mainly make use of the save-image-edit code flow only to simplify the above use case. This patch set provides capability to Dump and Edit the XML configuration associated with a saved state file of a domain which was created by the managedsave command. The new command carry the similar options as the save-image-<XXX> commands to change the running state as to paused state or running on start. This is equivalent to: virsh managedsave-dumpxml domain-name > state-file.xml vi state-file.xml (or make changes with your other text editor) virsh managedsave-define domain-name state-file-xml or you can simply use: virsh managedsave-edit domain-name It's always better when we get more. Changes since v3: - refracted version references from 3.6.0 to 3.7.0 - fixed typo in error message. Changes since v2: - refracted version references from 3.5.0 to 3.6.0 Changes since v1: - qemu implementation called directly rather than going through driver pointer in qemuDomainManagedSaveDefineXML. - check whether the managed save state file exists and report a error if it doesn't. Kothapally Madhu Pavan (7): lib: Add API to dump xml configuration of managed save state domain lib: Add API to edit domain's managed save state xml configuration qemu: Implement qemuDomainManagedSaveGetXMLDesc qemu: Implement qemuDomainManagedSaveDefineXML virsh: Implement managedsave-define command virsh: Implement managedsave-dumpxml command virsh: Implement managedsave-edit command include/libvirt/libvirt-domain.h | 6 ++ src/driver-hypervisor.h | 11 +++ src/libvirt-domain.c | 107 ++++++++++++++++++++ src/libvirt_public.syms | 6 ++ src/qemu/qemu_driver.c | 87 ++++++++++++++++ src/remote/remote_driver.c | 2 + src/remote/remote_protocol.x | 31 +++++- src/remote_protocol-structs | 14 +++ tools/virsh-domain.c | 207 +++++++++++++++++++++++++++++++++++++++ tools/virsh.pod | 41 ++++++++ 10 files changed, 511 insertions(+), 1 deletion(-) -- 1.8.3.1

2 11

[libvirt] [PATCH] maint: correct quoting for gl_WARN_ADD
by Eric Blake 28 Aug '17

28 Aug '17

3 out of 4 uses of gl_WARN_ADD() were incorrectly adding "" around the argument, which in turn resulted in the argument being used unquoted (configure had gl_positive=""-fstack-protector-all"", rather than the intended gl_positive="-fstack-protector-all"). Signed-off-by: Eric Blake <eblake(a)redhat.com> --- m4/virt-compile-warnings.m4 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 7b56115ce6..e8f1351260 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -194,8 +194,8 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ # This should be < 256 really. Currently we're down to 4096, # but using 1024 bytes sized buffers (mostly for virStrerror) # stops us from going down further - gl_WARN_ADD(["-Wframe-larger-than=4096"], [STRICT_FRAME_LIMIT_CFLAGS]) - gl_WARN_ADD(["-Wframe-larger-than=25600"], [RELAXED_FRAME_LIMIT_CFLAGS]) + gl_WARN_ADD([-Wframe-larger-than=4096], [STRICT_FRAME_LIMIT_CFLAGS]) + gl_WARN_ADD([-Wframe-larger-than=25600], [RELAXED_FRAME_LIMIT_CFLAGS]) # Extra special flags dnl -fstack-protector stuff passes gl_WARN_ADD with gcc @@ -250,7 +250,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ *-fstack-protector-strong*) ;; *) - gl_WARN_ADD(["-fstack-protector-all"]) + gl_WARN_ADD([-fstack-protector-all]) ;; esac ;; -- 2.13.5

2 2

[libvirt] [PATCH] daemon: logging: Fix --verbose option being ignored by the daemon
by Erik Skultety 28 Aug '17

28 Aug '17

Commit 94c465d0 refactored the logging setup phase but introduced an issue, where the daemon ignores verbose mode when there are no outputs defined and the default must be used. The problem is that the default output was determined too early, thus ignoring the potential '--verbose' option taking effect. This patch postpones the creation of the default output to the very last moment when nothing else can change. Since the default output is only created during the init phase, it's safe to leave the pointer as NULL for a while, but it will be set eventually, thus not affecting runtime. Patch also adjusts both the other daemons. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1457193 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- daemon/libvirtd.c | 21 +++++++++++++-------- src/locking/lock_daemon.c | 21 +++++++++++++-------- src/logging/log_daemon.c | 21 +++++++++++++-------- src/util/virlog.c | 7 +++++++ 4 files changed, 46 insertions(+), 24 deletions(-) diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c index 7e5d7af69..589b32192 100644 --- a/daemon/libvirtd.c +++ b/daemon/libvirtd.c @@ -615,19 +615,15 @@ daemonSetupLogging(struct daemonConfig *config, * Libvirtd's order of precedence is: * cmdline > environment > config * - * The default output is applied only if there was no setting from either - * the config or the environment. Because we don't have a way to determine - * if the log level has been set, we must process variables in the opposite + * Given the precedence, we must process the variables in the opposite * order, each one overriding the previous. */ if (config->log_level != 0) virLogSetDefaultPriority(config->log_level); - if (virLogSetDefaultOutput("libvirtd.log", godaemon, privileged) < 0) - return -1; - - /* In case the config is empty, the filters become empty and outputs will - * be set to default + /* In case the config is empty, both filters and outputs will become empty, + * however we can't start with empty outputs, thus we'll need to define and + * setup a default one. */ ignore_value(virLogSetFilters(config->log_filters)); ignore_value(virLogSetOutputs(config->log_outputs)); @@ -641,6 +637,15 @@ daemonSetupLogging(struct daemonConfig *config, if ((verbose) && (virLogGetDefaultPriority() > VIR_LOG_INFO)) virLogSetDefaultPriority(VIR_LOG_INFO); + /* Define the default output. This is only applied if there was no setting + * from either the config or the environment. + */ + if (virLogSetDefaultOutput("libvirtd.log", godaemon, privileged) < 0) + return -1; + + if (virLogGetNbOutputs() == 0) + virLogSetOutputs(virLogGetDefaultOutput()); + return 0; } diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c index 12485e966..6fbbf4b3d 100644 --- a/src/locking/lock_daemon.c +++ b/src/locking/lock_daemon.c @@ -460,19 +460,15 @@ virLockDaemonSetupLogging(virLockDaemonConfigPtr config, * Libvirtd's order of precedence is: * cmdline > environment > config * - * The default output is applied only if there was no setting from either - * the config or the environment. Because we don't have a way to determine - * if the log level has been set, we must process variables in the opposite + * Given the precedence, we must process the variables in the opposite * order, each one overriding the previous. */ if (config->log_level != 0) virLogSetDefaultPriority(config->log_level); - if (virLogSetDefaultOutput("virtlockd.log", godaemon, privileged) < 0) - return -1; - - /* In case the config is empty, the filters become empty and outputs will - * be set to default + /* In case the config is empty, both filters and outputs will become empty, + * however we can't start with empty outputs, thus we'll need to define and + * setup a default one. */ ignore_value(virLogSetFilters(config->log_filters)); ignore_value(virLogSetOutputs(config->log_outputs)); @@ -486,6 +482,15 @@ virLockDaemonSetupLogging(virLockDaemonConfigPtr config, if ((verbose) && (virLogGetDefaultPriority() > VIR_LOG_INFO)) virLogSetDefaultPriority(VIR_LOG_INFO); + /* Define the default output. This is only applied if there was no setting + * from either the config or the environment. + */ + if (virLogSetDefaultOutput("virtlockd.log", godaemon, privileged) < 0) + return -1; + + if (virLogGetNbOutputs() == 0) + virLogSetOutputs(virLogGetDefaultOutput()); + return 0; } diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c index d878efa63..5a136c59d 100644 --- a/src/logging/log_daemon.c +++ b/src/logging/log_daemon.c @@ -388,19 +388,15 @@ virLogDaemonSetupLogging(virLogDaemonConfigPtr config, * Libvirtd's order of precedence is: * cmdline > environment > config * - * The default output is applied only if there was no setting from either - * the config or the environment. Because we don't have a way to determine - * if the log level has been set, we must process variables in the opposite + * Given the precedence, we must process the variables in the opposite * order, each one overriding the previous. */ if (config->log_level != 0) virLogSetDefaultPriority(config->log_level); - if (virLogSetDefaultOutput("virtlogd.log", godaemon, privileged) < 0) - return -1; - - /* In case the config is empty, the filters become empty and outputs will - * be set to default + /* In case the config is empty, both filters and outputs will become empty, + * however we can't start with empty outputs, thus we'll need to define and + * setup a default one. */ ignore_value(virLogSetFilters(config->log_filters)); ignore_value(virLogSetOutputs(config->log_outputs)); @@ -414,6 +410,15 @@ virLogDaemonSetupLogging(virLogDaemonConfigPtr config, if ((verbose) && (virLogGetDefaultPriority() > VIR_LOG_INFO)) virLogSetDefaultPriority(VIR_LOG_INFO); + /* Define the default output. This is only applied if there was no setting + * from either the config or the environment. + */ + if (virLogSetDefaultOutput("virtlogd.log", godaemon, privileged) < 0) + return -1; + + if (virLogGetNbOutputs() == 0) + virLogSetOutputs(virLogGetDefaultOutput()); + return 0; } diff --git a/src/util/virlog.c b/src/util/virlog.c index 2228cf645..d45a451a7 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1840,6 +1840,13 @@ virLogSetOutputs(const char *src) if (src && *src) outputstr = src; + /* This can only happen during daemon init when the default output is not + * determined yet. It's safe to do, since it's the only place setting the + * default output. + */ + if (!outputstr) + return 0; + if ((noutputs = virLogParseOutputs(outputstr, &outputs)) < 0) goto cleanup; -- 2.13.3

2 3

[libvirt] [PATCH v2] qemu: Handle host devices not being available better
by Andrea Bolognani 28 Aug '17

28 Aug '17

We can't retrieve the isolation group of a device that's not present in the system. However, it's very common for VFs to be created late in the boot, so they might not be present yet when libvirtd starts, which would cause the guests using them to disappear. Moreover, for other architectures and even ppc64 before isolation groups were introduced, it's considered perfectly fine to configure a guest to use a device that's not yet (or no longer) available to the host, with the obvious caveat that such a guest won't be able to start before the device is available. In order to be consistent, when a device's isolation group can't be determined fall back to not isolating it rather than erroring out or, worse, making the guest disappear. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1484254 Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- Changes from [v1]: * rewrite to always skip on error [v1] https://www.redhat.com/archives/libvir-list/2017-August/msg00729.html src/qemu/qemu_domain_address.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/src/qemu/qemu_domain_address.c b/src/qemu/qemu_domain_address.c index 16bf0cdf9..f27d0ce8e 100644 --- a/src/qemu/qemu_domain_address.c +++ b/src/qemu/qemu_domain_address.c @@ -982,8 +982,6 @@ int qemuDomainFillDeviceIsolationGroup(virDomainDefPtr def, virDomainDeviceDefPtr dev) { - int ret = -1; - /* Only host devices need their isolation group to be different from * the default. Interfaces of type hostdev are just host devices in * disguise, but we don't need to handle them separately because for @@ -1012,12 +1010,11 @@ qemuDomainFillDeviceIsolationGroup(virDomainDefPtr def, tmp = virPCIDeviceAddressGetIOMMUGroupNum(hostAddr); if (tmp < 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Can't look up isolation group for host device " - "%04x:%02x:%02x.%x"), - hostAddr->domain, hostAddr->bus, - hostAddr->slot, hostAddr->function); - goto cleanup; + VIR_WARN("Can't look up isolation group for host device " + "%04x:%02x:%02x.%x, device won't be isolated", + hostAddr->domain, hostAddr->bus, + hostAddr->slot, hostAddr->function); + goto skip; } /* The isolation group for a host device is its IOMMU group, @@ -1057,12 +1054,11 @@ qemuDomainFillDeviceIsolationGroup(virDomainDefPtr def, tmp = qemuDomainFindUnusedIsolationGroup(def); if (tmp == 0) { - virReportError(VIR_ERR_INTERNAL_ERROR, - _("Can't obtain usable isolation group for " - "interface configured to use hostdev-backed " - "network '%s'"), - iface->data.network.name); - goto cleanup; + VIR_WARN("Can't obtain usable isolation group for interface " + "configured to use hostdev-backed network '%s', " + "device won't be isolated", + iface->data.network.name); + goto skip; } info->isolationGroup = tmp; @@ -1073,10 +1069,7 @@ qemuDomainFillDeviceIsolationGroup(virDomainDefPtr def, } skip: - ret = 0; - - cleanup: - return ret; + return 0; } -- 2.13.5

2 2

[libvirt] [libvirt-php PATCH v2 00/11] Refactor into smaller components
by Dawid Zamirski 28 Aug '17

28 Aug '17

As per [1], this patch series splits up the large libvirt-php.c into components that (attempts) to resemble the structure of the libvirt project. Each patch successive patch was compile-tested while the whole series was verified with "make check" and a simple custom written PHP script. Changes from v1 [2]: * rebase on master * include PHP headers in util.h instead of libvirt-php.h this makes header inter-dependencies easier to manage/understand * also test each patch on PHP 5 [1] https://www.redhat.com/archives/libvir-list/2017-June/msg00991.html [2] https://www.redhat.com/archives/libvir-list/2017-August/msg00046.html Dawid Zamirski (11): Move PHP version compat macros to utils.h Split up the bindings for libvirt connection API Split up the bindings for libvirt node API Split up the bindings for libvirt stream API Split up the bindings for libvirt domain API Split up the bindings for libvirt network API Split up the bindings for libvirt storage API Split up the bindings for libvirt snapshot API Split up the bindings for libvirt nodedev API Split up the bindings for libvirt NWFilter API Fix is_local_connection implementation. src/Makefile.am | 11 +- src/libvirt-connection.c | 886 +++++ src/libvirt-connection.h | 81 + src/libvirt-domain.c | 3344 +++++++++++++++++ src/libvirt-domain.h | 208 ++ src/libvirt-network.c | 587 +++ src/libvirt-network.h | 73 + src/libvirt-node.c | 305 ++ src/libvirt-node.h | 23 + src/libvirt-nodedev.c | 340 ++ src/libvirt-nodedev.h | 54 + src/libvirt-nwfilter.c | 415 +++ src/libvirt-nwfilter.h | 66 + src/libvirt-php.c | 9277 ++++------------------------------------------ src/libvirt-php.h | 496 +-- src/libvirt-snapshot.c | 244 ++ src/libvirt-snapshot.h | 58 + src/libvirt-storage.c | 1130 ++++++ src/libvirt-storage.h | 137 + src/libvirt-stream.c | 230 ++ src/libvirt-stream.h | 39 + src/util.h | 200 +- 22 files changed, 9282 insertions(+), 8922 deletions(-) create mode 100644 src/libvirt-connection.c create mode 100644 src/libvirt-connection.h create mode 100644 src/libvirt-domain.c create mode 100644 src/libvirt-domain.h create mode 100644 src/libvirt-network.c create mode 100644 src/libvirt-network.h create mode 100644 src/libvirt-node.c create mode 100644 src/libvirt-node.h create mode 100644 src/libvirt-nodedev.c create mode 100644 src/libvirt-nodedev.h create mode 100644 src/libvirt-nwfilter.c create mode 100644 src/libvirt-nwfilter.h create mode 100644 src/libvirt-snapshot.c create mode 100644 src/libvirt-snapshot.h create mode 100644 src/libvirt-storage.c create mode 100644 src/libvirt-storage.h create mode 100644 src/libvirt-stream.c create mode 100644 src/libvirt-stream.h -- 2.13.3

4 17

[libvirt] Schedule for next release
by Daniel Veillard 28 Aug '17

28 Aug '17

I'm a little behind, I was on vacations last week and kind of forgot ... So I think the best will be to enter freeze tomorrow morning (29 Aug), then have an RC2 on the 31, and make the release over the week-end. I assume this works for everybody, otherwise raise your voice :-) thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH 0/3] chardev and disk source format cleanup
by Pavel Hrdina 28 Aug '17

28 Aug '17

Pavel Hrdina (3): util: introduce virBufferSetChildIndent macro util: introduce virXMLFormatElement helper conf: don't close the source element inside different function src/conf/capabilities.c | 3 +- src/conf/cpu_conf.c | 3 +- src/conf/domain_conf.c | 125 ++++++++++++--------- src/libvirt_private.syms | 1 + src/util/virbuffer.h | 9 ++ src/util/virxml.c | 47 ++++++++ src/util/virxml.h | 6 + .../qemuxml2xmlout-seclabel-dynamic-labelskip.xml | 3 +- 8 files changed, 135 insertions(+), 62 deletions(-) -- 2.13.5

2 4