- Devel - libvirt List Archives

[libvirt] [PATCH] news: Document watchdog hot-(un)plug change
by Michal Privoznik 05 Oct '17

05 Oct '17

In 361c8dc17 and 662140fa68ae0 I've implemented hot-(un)plug of watchdog devices. Document this change. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 4e8d7c940..3a01bd491 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -35,6 +35,11 @@ <libvirt> <release version="v3.9.0" date="unreleased"> <section title="New features"> + <change> + <summary> + qemu: Added support for hot-(un)plug of watchdog devices + </summary> + </change> </section> <section title="Improvements"> </section> -- 2.13.6

2 1

[libvirt] [PATCH v2 0/4] qemu: track presence of blockjobs in status XML (blockdev-add saga)
by Peter Krempa 05 Oct '17

05 Oct '17

V2: Patches 1/4 and 3/4 are new. Patch 2/4 and 4/4 were fixed to use virTristateBool. Peter Krempa (4): util: Add functions to simplify bool->virTristate(Bool|Switch) assignment qemu: domain: Mark if no blockjobs are active in the status XML qemu: process: Simplify acces to individual disk when reconnecting qemu: process: Don't redetect backing chain on reconnect src/libvirt_private.syms | 2 ++ src/qemu/qemu_domain.c | 38 ++++++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 3 +++ src/qemu/qemu_process.c | 22 +++++++++++++--------- src/util/virutil.c | 20 ++++++++++++++++++++ src/util/virutil.h | 3 +++ tests/qemuxml2xmltest.c | 44 ++++++++++++++++++++++++++++++++++++++++++++ 7 files changed, 123 insertions(+), 9 deletions(-) -- 2.14.1

2 5

[libvirt] [PATCH v3 0/3] qemu: Watchdog plug/unplug
by Michal Privoznik 05 Oct '17

05 Oct '17

v3 of: https://www.redhat.com/archives/libvir-list/2017-September/msg00974.html diff to v2: - Peter's review worked int - Dropped audit patch - More check on watchdog device Michal Privoznik (3): qemuDomainDeviceDefValidate: Validate watchdog qemu: hot-plug of watchdog qemu: hot-unplug of watchdog src/qemu/qemu_alias.c | 13 +- src/qemu/qemu_alias.h | 2 + src/qemu/qemu_command.c | 2 +- src/qemu/qemu_command.h | 4 +- src/qemu/qemu_domain.c | 51 ++++++++ src/qemu/qemu_driver.c | 14 ++- src/qemu/qemu_hotplug.c | 139 +++++++++++++++++++++ src/qemu/qemu_hotplug.h | 6 + src/qemu/qemu_monitor.c | 12 ++ src/qemu/qemu_monitor.h | 2 + src/qemu/qemu_monitor_json.c | 28 +++++ src/qemu/qemu_monitor_json.h | 3 + tests/qemuhotplugtest.c | 14 ++- .../qemuhotplug-watchdog-full.xml | 4 + .../qemuhotplug-watchdog.xml | 1 + .../qemuhotplug-base-live+watchdog.xml | 56 +++++++++ 16 files changed, 345 insertions(+), 6 deletions(-) create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog-full.xml create mode 100644 tests/qemuhotplugtestdevices/qemuhotplug-watchdog.xml create mode 100644 tests/qemuhotplugtestdomains/qemuhotplug-base-live+watchdog.xml -- 2.13.5

2 9

[libvirt] [PATCH 0/6] qemu: track presence of blockjobs in status XML (blockdev-add saga)
by Peter Krempa 05 Oct '17

05 Oct '17

Add a flag to the status XML to tell that no blockjobs are running, so that we don't have to reprobe the backing chain on libvirt restart when no jobs were running. Later on when we will be able to recover jobs we can improve that even for running jobs. Peter Krempa (6): qemu: blockjob: Always save status XML after block event qemu: blockjob: Always save config XML when a blockjob is finished qemu: driver: Save status XML when starting a block job tests: qemuxml2xml: Simplify adding to the status XML expect string generator qemu: domain: Mark if no blockjobs are active in the status XML qemu: process: Don't redetect backing chain on reconnect src/qemu/qemu_blockjob.c | 16 +++------- src/qemu/qemu_domain.c | 39 +++++++++++++++++++++++ src/qemu/qemu_domain.h | 3 ++ src/qemu/qemu_driver.c | 32 ++++++++++--------- src/qemu/qemu_process.c | 19 +++++++---- tests/qemuxml2xmltest.c | 83 +++++++++++++++++++++++++++++++++++++----------- 6 files changed, 141 insertions(+), 51 deletions(-) -- 2.14.1

2 13

[libvirt] [PATCH] news: Document domifstat and QoS changes made recently
by Michal Privoznik 05 Oct '17

05 Oct '17

In cea3715b2e9 and d86fd2402e9d2 I've fixed domifstat and QoS that was reversed for some types of interfaces. Document this in the news file. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- docs/news.xml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 72e15567c..d1117154a 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -39,6 +39,17 @@ <section title="Improvements"> </section> <section title="Bug fixes"> + <change> + <summary> + Fix swapped interface statistics and QoS + </summary> + <description> + Due to internal implementation, reported statistics for + some types of interfaces were swapped (RX appeared in + TX and vice versa). Similarly, QoS was set in reversed + way. This is fixed now. + </description> + </change> </section> </release> <release version="v3.8.0" date="2017-10-04"> -- 2.13.6

2 2

[libvirt] [PATCH v1 0/7] qemu: Assign device aliases at define time
by Michal Privoznik 05 Oct '17

05 Oct '17

Rather big change because I had to update a lot of domain XMLs under tests/. You can find the patches at mu github too: https://github.com/zippy2/libvirt/commits/aliases All the changes to the tests are result of VIR_TEST_REGENERATE_OUTPUT=1. For more reference see: https://bugzilla.redhat.com/show_bug.cgi?id=1434451 Michal Privoznik (7): qemu_command: Drop useless alias checks qemuAssignDeviceRNGAlias: Allow index to be passed qemu: Move device alias assignment to separate functions qemu: Allow regeneration of aliases domain: Add virDomainDefAssignAliasesCallback qemu: Assign device aliases at define time conf: Format device alias into inactive XML too src/conf/domain_conf.c | 14 +- src/conf/domain_conf.h | 13 ++ src/qemu/qemu_alias.c | 225 +++++++++++++++++++-- src/qemu/qemu_alias.h | 7 +- src/qemu/qemu_command.c | 21 +- src/qemu/qemu_domain.c | 24 +++ src/qemu/qemu_driver.c | 2 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_process.c | 2 +- .../disk_snapshot_redefine.xml | 21 +- .../external_vm_redefine.xml | 16 +- tests/domainsnapshotxml2xmlout/full_domain.xml | 16 +- tests/domainsnapshotxml2xmlout/metadata.xml | 16 +- tests/qemuargv2xmldata/qemuargv2xml-boot-cdrom.xml | 19 +- .../qemuargv2xmldata/qemuargv2xml-boot-floppy.xml | 24 ++- .../qemuargv2xmldata/qemuargv2xml-boot-network.xml | 19 +- .../qemuargv2xml-clock-localtime.xml | 19 +- tests/qemuargv2xmldata/qemuargv2xml-clock-utc.xml | 19 +- .../qemuargv2xml-console-compat.xml | 21 +- .../qemuargv2xml-disk-cdrom-empty.xml | 20 +- tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom.xml | 20 +- .../qemuargv2xml-disk-drive-boot-cdrom.xml | 20 +- .../qemuargv2xml-disk-drive-boot-disk.xml | 20 +- .../qemuargv2xml-disk-drive-cache-directsync.xml | 20 +- .../qemuargv2xml-disk-drive-cache-unsafe.xml | 20 +- .../qemuargv2xml-disk-drive-cache-v2-none.xml | 20 +- .../qemuargv2xml-disk-drive-cache-v2-wb.xml | 20 +- .../qemuargv2xml-disk-drive-cache-v2-wt.xml | 20 +- ...muargv2xml-disk-drive-error-policy-enospace.xml | 20 +- .../qemuargv2xml-disk-drive-error-policy-stop.xml | 20 +- ...xml-disk-drive-error-policy-wreport-rignore.xml | 20 +- .../qemuargv2xml-disk-drive-fmt-qcow.xml | 20 +- .../qemuargv2xml-disk-drive-network-gluster.xml | 19 +- .../qemuargv2xml-disk-drive-network-iscsi-auth.xml | 19 +- .../qemuargv2xml-disk-drive-network-iscsi.xml | 19 +- .../qemuargv2xml-disk-drive-network-nbd-export.xml | 20 +- ...argv2xml-disk-drive-network-nbd-ipv6-export.xml | 20 +- .../qemuargv2xml-disk-drive-network-nbd-ipv6.xml | 20 +- .../qemuargv2xml-disk-drive-network-nbd-unix.xml | 20 +- .../qemuargv2xml-disk-drive-network-nbd.xml | 20 +- .../qemuargv2xml-disk-drive-network-rbd-auth.xml | 20 +- ...emuargv2xml-disk-drive-network-rbd-ceph-env.xml | 20 +- .../qemuargv2xml-disk-drive-network-rbd-ipv6.xml | 20 +- .../qemuargv2xml-disk-drive-network-rbd.xml | 23 ++- .../qemuargv2xml-disk-drive-network-sheepdog.xml | 20 +- .../qemuargv2xmldata/qemuargv2xml-disk-floppy.xml | 25 ++- tests/qemuargv2xmldata/qemuargv2xml-disk-many.xml | 22 +- tests/qemuargv2xmldata/qemuargv2xml-disk-usb.xml | 20 +- .../qemuargv2xmldata/qemuargv2xml-disk-virtio.xml | 22 +- .../qemuargv2xml-graphics-sdl-fullscreen.xml | 20 +- .../qemuargv2xmldata/qemuargv2xml-graphics-sdl.xml | 20 +- .../qemuargv2xml-graphics-vnc-policy.xml | 20 +- .../qemuargv2xml-graphics-vnc-sasl.xml | 20 +- .../qemuargv2xml-graphics-vnc-socket.xml | 20 +- .../qemuargv2xml-graphics-vnc-tls.xml | 20 +- .../qemuargv2xml-graphics-vnc-websocket.xml | 18 +- .../qemuargv2xmldata/qemuargv2xml-graphics-vnc.xml | 20 +- .../qemuargv2xml-hostdev-pci-address.xml | 20 +- .../qemuargv2xml-hostdev-usb-address.xml | 20 +- .../qemuargv2xmldata/qemuargv2xml-hyperv-panic.xml | 17 +- tests/qemuargv2xmldata/qemuargv2xml-hyperv.xml | 17 +- .../qemuargv2xml-input-usbmouse.xml | 23 ++- .../qemuargv2xml-input-usbtablet.xml | 23 ++- .../qemuargv2xmldata/qemuargv2xml-kvm-features.xml | 17 +- tests/qemuargv2xmldata/qemuargv2xml-kvmclock.xml | 17 +- .../qemuargv2xml-machine-aeskeywrap-off-argv.xml | 4 +- .../qemuargv2xml-machine-aeskeywrap-on-argv.xml | 4 +- .../qemuargv2xml-machine-core-off.xml | 19 +- .../qemuargv2xml-machine-core-on.xml | 19 +- .../qemuargv2xml-machine-deakeywrap-off-argv.xml | 4 +- .../qemuargv2xml-machine-deakeywrap-on-argv.xml | 4 +- .../qemuargv2xml-machine-keywrap-none-argv.xml | 4 +- tests/qemuargv2xmldata/qemuargv2xml-mem-scale.xml | 19 +- tests/qemuargv2xmldata/qemuargv2xml-migrate.xml | 19 +- tests/qemuargv2xmldata/qemuargv2xml-misc-acpi.xml | 19 +- .../qemuargv2xml-misc-disable-s3.xml | 19 +- .../qemuargv2xml-misc-disable-suspends.xml | 19 +- .../qemuargv2xml-misc-enable-s4.xml | 19 +- .../qemuargv2xml-misc-no-reboot.xml | 19 +- tests/qemuargv2xmldata/qemuargv2xml-misc-uuid.xml | 19 +- .../qemuargv2xml-net-eth-ifname.xml | 20 +- tests/qemuargv2xmldata/qemuargv2xml-net-eth.xml | 20 +- tests/qemuargv2xmldata/qemuargv2xml-net-user.xml | 20 +- tests/qemuargv2xmldata/qemuargv2xml-net-virtio.xml | 20 +- .../qemuargv2xml-nographics-vga-display.xml | 19 +- .../qemuargv2xml-nographics-vga.xml | 19 +- .../qemuargv2xmldata/qemuargv2xml-nosharepages.xml | 19 +- .../qemuargv2xmldata/qemuargv2xml-parallel-tcp.xml | 20 +- .../qemuargv2xmldata/qemuargv2xml-pseries-disk.xml | 18 +- .../qemuargv2xml-pseries-nvram.xml | 6 +- .../qemuargv2xml-qemu-ns-no-env.xml | 19 +- .../qemuargv2xml-reboot-timeout-disabled.xml | 17 +- .../qemuargv2xml-reboot-timeout-enabled.xml | 17 +- tests/qemuargv2xmldata/qemuargv2xml-restore-v2.xml | 19 +- tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml | 21 +- .../qemuargv2xmldata/qemuargv2xml-serial-file.xml | 21 +- .../qemuargv2xmldata/qemuargv2xml-serial-many.xml | 22 +- tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml | 21 +- .../qemuargv2xml-serial-tcp-telnet.xml | 21 +- tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml | 21 +- tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml | 22 +- .../qemuargv2xmldata/qemuargv2xml-serial-unix.xml | 21 +- tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml | 21 +- tests/qemuargv2xmldata/qemuargv2xml-smp.xml | 19 +- tests/qemuargv2xmldata/qemuargv2xml-sound.xml | 29 ++- tests/qemuargv2xmldata/qemuargv2xml-watchdog.xml | 23 ++- tests/qemuhotplugtest.c | 2 +- .../ppc64-modern-bulk-result-conf.xml | 14 +- .../ppc64-modern-individual-result-conf.xml | 14 +- .../x86-modern-bulk-result-conf.xml | 14 +- .../x86-modern-individual-add-result-conf.xml | 14 +- .../x86-old-bulk-result-conf.xml | 14 +- .../qemuxml2argv-blkdeviotune-group-num.xml | 17 +- .../qemuxml2argv-blkdeviotune-max-length.xml | 17 +- .../qemuxml2argv-blkdeviotune-max.xml | 17 +- .../qemuxml2argv-disk-drive-detect-zeroes.xml | 17 +- .../qemuxml2argv-encrypted-disk-usage.xml | 15 +- .../qemuxml2argv-hostdev-scsi-vhost-scsi-ccw.xml | 4 + .../qemuxml2argv-hostdev-scsi-vhost-scsi-pci.xml | 18 +- .../qemuxml2argv-hugepages-memaccess.xml | 17 +- .../qemuxml2argv-hugepages-memaccess2.xml | 17 +- .../qemuxml2argv-hugepages-pages4.xml | 16 +- .../qemuxml2argv-hugepages-pages5.xml | 16 +- .../qemuxml2argv-hugepages-pages6.xml | 16 +- .../qemuxml2argv-hugepages-pages7.xml | 17 +- .../qemuxml2argv-intel-iommu-caching-mode.xml | 22 +- .../qemuxml2argv-intel-iommu-device-iotlb.xml | 17 +- .../qemuxml2argv-intel-iommu-eim.xml | 17 +- tests/qemuxml2argvdata/qemuxml2argv-luks-disks.xml | 16 +- .../qemuxml2argv-memory-hotplug-nvdimm-access.xml | 17 +- .../qemuxml2argv-memory-hotplug-nvdimm-label.xml | 17 +- .../qemuxml2argv-memory-hotplug-nvdimm.xml | 17 +- .../qemuxml2argv-net-user-addr.xml | 20 +- ...muxml2argv-serial-tcp-tlsx509-chardev-notls.xml | 19 +- .../qemuxml2argv-virtio-options.xml | 27 ++- tests/qemuxml2argvtest.c | 9 + .../qemuxml2xmlout-aarch64-aavmf-virtio-mmio.xml | 6 + .../qemuxml2xmlout-aarch64-gic-none-tcg.xml | 4 +- .../qemuxml2xmlout-aarch64-pci-serial.xml | 8 +- .../qemuxml2xmlout-aarch64-video-default.xml | 8 +- ...qemuxml2xmlout-aarch64-video-virtio-gpu-pci.xml | 8 +- .../qemuxml2xmlout-aarch64-virtio-pci-default.xml | 18 +- ...2xmlout-aarch64-virtio-pci-manual-addresses.xml | 11 +- .../qemuxml2xmlout-acpi-table.xml | 18 +- .../qemuxml2xmlout-autoindex.xml | 47 ++++- .../qemuxml2xmlout-balloon-device-auto.xml | 16 +- .../qemuxml2xmlout-balloon-device-period.xml | 16 +- .../qemuxml2xmlout-bios-nvram-os-interleave.xml | 22 +- .../qemuxml2xmlout-bios-nvram.xml | 20 +- .../qemuxml2xmlout-blkdeviotune.xml | 17 +- .../qemuxml2xmlout-blkiotune-device.xml | 16 +- .../qemuxml2xmlout-blkiotune.xml | 16 +- .../qemuxml2xmlout-boot-cdrom.xml | 19 +- .../qemuxml2xmlout-boot-floppy-q35.xml | 22 +- .../qemuxml2xmlout-boot-floppy.xml | 24 ++- ...muxml2xmlout-boot-menu-disable-with-timeout.xml | 16 +- .../qemuxml2xmlout-boot-menu-disable.xml | 16 +- ...emuxml2xmlout-boot-menu-enable-with-timeout.xml | 16 +- .../qemuxml2xmlout-boot-multi.xml | 16 +- .../qemuxml2xmlout-boot-network.xml | 19 +- .../qemuxml2xmlout-boot-order.xml | 24 ++- .../qemuxml2xmlout-bootindex-floppy-q35.xml | 22 +- .../qemuxml2xmlout-channel-guestfwd.xml | 17 +- .../qemuxml2xmlout-channel-unix-source-path.xml | 22 +- .../qemuxml2xmlout-channel-virtio-auto.xml | 25 ++- .../qemuxml2xmlout-channel-virtio-state-active.xml | 20 +- ...emuxml2xmlout-channel-virtio-state-inactive.xml | 20 +- .../qemuxml2xmlout-channel-virtio.xml | 18 +- .../qemuxml2xmlout-chardev-label.xml | 19 +- .../qemuxml2xmlout-clock-catchup.xml | 16 +- .../qemuxml2xmlout-clock-localtime.xml | 19 +- .../qemuxml2xmlout-clock-timer-hyperv-rtc.xml | 14 +- .../qemuxml2xmlout-clock-utc.xml | 19 +- .../qemuxml2xmlout-console-compat-auto.xml | 18 +- .../qemuxml2xmlout-console-compat.xml | 21 +- .../qemuxml2xmlout-console-compat2.xml | 23 ++- .../qemuxml2xmlout-console-virtio-many.xml | 22 +- .../qemuxml2xmlout-console-virtio.xml | 18 +- .../qemuxml2xmlout-controller-usb-order.xml | 16 +- .../qemuxml2xmlout-cpu-check-default-none.xml | 14 +- .../qemuxml2xmlout-cpu-check-default-none2.xml | 14 +- .../qemuxml2xmlout-cpu-check-default-partial.xml | 14 +- .../qemuxml2xmlout-cpu-check-default-partial2.xml | 14 +- .../qemuxml2xmlout-cpu-check-full.xml | 14 +- .../qemuxml2xmlout-cpu-check-none.xml | 14 +- .../qemuxml2xmlout-cpu-check-partial.xml | 14 +- .../qemuxml2xmlout-cpu-empty.xml | 14 +- .../qemuxml2xmlout-cpu-eoi-disabled.xml | 14 +- .../qemuxml2xmlout-cpu-eoi-enabled.xml | 14 +- .../qemuxml2xmlout-cpu-host-kvmclock.xml | 14 +- .../qemuxml2xmlout-cpu-host-model-features.xml | 15 +- ...emuxml2xmlout-cpu-host-passthrough-features.xml | 16 +- .../qemuxml2xmlout-cpu-kvmclock.xml | 14 +- .../qemuxml2xmlout-cpu-numa-disjoint.xml | 14 +- .../qemuxml2xmlout-cpu-numa-disordered.xml | 14 +- .../qemuxml2xmlout-cpu-numa-memshared.xml | 14 +- .../qemuxml2xmlout-cpu-numa-no-memory-element.xml | 14 +- .../qemuxml2xmlout-cpu-numa1.xml | 14 +- .../qemuxml2xmlout-cpu-numa2.xml | 14 +- .../qemuxml2xmlout-cputune-iothreads.xml | 16 +- ...l2xmlout-cputune-iothreadsched-zeropriority.xml | 16 +- .../qemuxml2xmlout-cputune-iothreadsched.xml | 16 +- .../qemuxml2xmlout-cputune-numatune.xml | 17 +- .../qemuxml2xmlout-cputune-zero-shares.xml | 16 +- .../qemuxml2xmloutdata/qemuxml2xmlout-cputune.xml | 16 +- .../qemuxml2xmlout-default-kvm-host-arch.xml | 14 +- .../qemuxml2xmlout-default-qemu-host-arch.xml | 14 +- .../qemuxml2xmlout-disk-active-commit.xml | 16 +- .../qemuxml2xmloutdata/qemuxml2xmlout-disk-aio.xml | 17 +- .../qemuxml2xmlout-disk-backing-chains-active.xml | 19 +- ...qemuxml2xmlout-disk-backing-chains-inactive.xml | 19 +- .../qemuxml2xmlout-disk-cdrom-empty.xml | 20 +- .../qemuxml2xmlout-disk-cdrom.xml | 20 +- .../qemuxml2xmlout-disk-copy_on_read.xml | 19 +- .../qemuxml2xmlout-disk-drive-boot-cdrom.xml | 20 +- .../qemuxml2xmlout-disk-drive-boot-disk.xml | 20 +- .../qemuxml2xmlout-disk-drive-cache-directsync.xml | 20 +- .../qemuxml2xmlout-disk-drive-cache-unsafe.xml | 20 +- .../qemuxml2xmlout-disk-drive-cache-v2-none.xml | 20 +- .../qemuxml2xmlout-disk-drive-cache-v2-wb.xml | 20 +- .../qemuxml2xmlout-disk-drive-cache-v2-wt.xml | 20 +- .../qemuxml2xmlout-disk-drive-copy-on-read.xml | 16 +- .../qemuxml2xmlout-disk-drive-discard.xml | 17 +- ...xml2xmlout-disk-drive-error-policy-enospace.xml | 20 +- ...qemuxml2xmlout-disk-drive-error-policy-stop.xml | 20 +- ...out-disk-drive-error-policy-wreport-rignore.xml | 20 +- .../qemuxml2xmlout-disk-drive-fmt-qcow.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-gluster.xml | 20 +- ...emuxml2xmlout-disk-drive-network-iscsi-auth.xml | 19 +- .../qemuxml2xmlout-disk-drive-network-iscsi.xml | 19 +- ...emuxml2xmlout-disk-drive-network-nbd-export.xml | 20 +- ...l2xmlout-disk-drive-network-nbd-ipv6-export.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-nbd-ipv6.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-nbd-unix.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-nbd.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-rbd-auth.xml | 20 +- ...uxml2xmlout-disk-drive-network-rbd-ceph-env.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-rbd-ipv6.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-rbd.xml | 23 ++- .../qemuxml2xmlout-disk-drive-network-sheepdog.xml | 20 +- .../qemuxml2xmlout-disk-drive-network-vxhs.xml | 18 +- .../qemuxml2xmlout-disk-floppy.xml | 25 ++- .../qemuxml2xmlout-disk-many.xml | 22 +- .../qemuxml2xmlout-disk-mirror-active.xml | 19 +- .../qemuxml2xmlout-disk-mirror-inactive.xml | 19 +- .../qemuxml2xmlout-disk-mirror-old-inactive.xml | 19 +- .../qemuxml2xmlout-disk-mirror-old.xml | 19 +- .../qemuxml2xmlout-disk-scsi-device-auto.xml | 18 +- .../qemuxml2xmlout-disk-scsi-device.xml | 18 +- .../qemuxml2xmlout-disk-scsi-disk-vpd.xml | 18 +- ...muxml2xmlout-disk-scsi-lun-passthrough-sgio.xml | 18 +- .../qemuxml2xmlout-disk-scsi-megasas.xml | 18 +- .../qemuxml2xmlout-disk-scsi-mptsas1068.xml | 18 +- .../qemuxml2xmlout-disk-scsi-virtio-scsi.xml | 18 +- .../qemuxml2xmlout-disk-scsi-vscsi.xml | 18 +- .../qemuxml2xmlout-disk-source-pool-mode.xml | 19 +- .../qemuxml2xmlout-disk-source-pool.xml | 18 +- .../qemuxml2xmlout-disk-usb-device.xml | 17 +- ...qemuxml2xmlout-disk-virtio-scsi-cmd_per_lun.xml | 16 +- .../qemuxml2xmlout-disk-virtio-scsi-ioeventfd.xml | 16 +- ...qemuxml2xmlout-disk-virtio-scsi-max_sectors.xml | 16 +- .../qemuxml2xmlout-disk-virtio-scsi-num_queues.xml | 16 +- .../qemuxml2xmlout-disk-virtio.xml | 22 +- .../qemuxml2xmlout-encrypted-disk.xml | 15 +- .../qemuxml2xmlout-eoi-disabled.xml | 14 +- .../qemuxml2xmlout-eoi-enabled.xml | 14 +- .../qemuxml2xmlout-event_idx.xml | 19 +- .../qemuxml2xmlout-floppy-drive-fat.xml | 20 +- .../qemuxml2xmlout-graphics-listen-network.xml | 17 +- .../qemuxml2xmlout-graphics-listen-network2.xml | 17 +- .../qemuxml2xmlout-graphics-sdl-fullscreen.xml | 20 +- .../qemuxml2xmlout-graphics-sdl.xml | 20 +- ...muxml2xmlout-graphics-spice-auto-socket-cfg.xml | 19 +- .../qemuxml2xmlout-graphics-spice-auto-socket.xml | 19 +- .../qemuxml2xmlout-graphics-spice-compression.xml | 18 +- .../qemuxml2xmlout-graphics-spice-qxl-vga.xml | 18 +- .../qemuxml2xmlout-graphics-spice-socket.xml | 19 +- .../qemuxml2xmlout-graphics-spice-timeout.xml | 25 ++- .../qemuxml2xmlout-graphics-spice.xml | 18 +- ...qemuxml2xmlout-graphics-vnc-auto-socket-cfg.xml | 20 +- .../qemuxml2xmlout-graphics-vnc-auto-socket.xml | 19 +- .../qemuxml2xmlout-graphics-vnc-no-listen-attr.xml | 20 +- ...graphics-vnc-remove-generated-socket-active.xml | 20 +- ...aphics-vnc-remove-generated-socket-inactive.xml | 20 +- .../qemuxml2xmlout-graphics-vnc-sasl.xml | 20 +- .../qemuxml2xmlout-graphics-vnc-socket.xml | 19 +- .../qemuxml2xmlout-graphics-vnc-tls.xml | 20 +- .../qemuxml2xmlout-graphics-vnc-websocket.xml | 18 +- .../qemuxml2xmlout-graphics-vnc.xml | 20 +- .../qemuxml2xmlout-hostdev-mdev-precreated.xml | 20 +- .../qemuxml2xmlout-hostdev-pci-address.xml | 20 +- ...qemuxml2xmlout-hostdev-scsi-autogen-address.xml | 29 ++- .../qemuxml2xmlout-hostdev-scsi-large-unit.xml | 18 +- .../qemuxml2xmlout-hostdev-scsi-lsi-iscsi-auth.xml | 19 +- .../qemuxml2xmlout-hostdev-scsi-lsi-iscsi.xml | 19 +- .../qemuxml2xmlout-hostdev-scsi-lsi.xml | 18 +- .../qemuxml2xmlout-hostdev-scsi-rawio.xml | 18 +- .../qemuxml2xmlout-hostdev-scsi-readonly.xml | 18 +- .../qemuxml2xmlout-hostdev-scsi-sgio.xml | 18 +- .../qemuxml2xmlout-hostdev-scsi-shareable.xml | 18 +- ...muxml2xmlout-hostdev-scsi-virtio-iscsi-auth.xml | 19 +- .../qemuxml2xmlout-hostdev-scsi-virtio-iscsi.xml | 19 +- .../qemuxml2xmlout-hostdev-scsi-virtio-scsi.xml | 18 +- .../qemuxml2xmlout-hostdev-usb-address.xml | 20 +- .../qemuxml2xmlout-hostdev-vfio.xml | 17 +- .../qemuxml2xmlout-hugepages-pages.xml | 16 +- .../qemuxml2xmlout-hugepages-pages2.xml | 16 +- .../qemuxml2xmlout-hugepages-pages3.xml | 16 +- .../qemuxml2xmlout-hugepages-shared.xml | 16 +- .../qemuxml2xmlout-hugepages.xml | 16 +- .../qemuxml2xmlout-hyperv-off.xml | 14 +- .../qemuxml2xmlout-hyperv-panic.xml | 17 +- tests/qemuxml2xmloutdata/qemuxml2xmlout-hyperv.xml | 17 +- .../qemuxml2xmlout-input-usbmouse.xml | 23 ++- .../qemuxml2xmlout-input-usbtablet.xml | 23 ++- .../qemuxml2xmlout-intel-iommu-machine.xml | 17 +- .../qemuxml2xmlout-intel-iommu.xml | 17 +- .../qemuxml2xmlout-interface-driver.xml | 21 +- .../qemuxml2xmlout-interface-server.xml | 33 ++- .../qemuxml2xmlout-iothreads-disk-virtio-ccw.xml | 7 +- .../qemuxml2xmlout-iothreads-disk.xml | 21 +- .../qemuxml2xmlout-iothreads-ids-partial.xml | 19 +- .../qemuxml2xmlout-iothreads-ids.xml | 19 +- .../qemuxml2xmlout-iothreads-virtio-scsi-ccw.xml | 8 +- .../qemuxml2xmlout-iothreads-virtio-scsi-pci.xml | 22 +- .../qemuxml2xmlout-iothreads.xml | 19 +- .../qemuxml2xmlout-kvm-features-off.xml | 14 +- .../qemuxml2xmlout-kvm-features.xml | 17 +- .../qemuxml2xmloutdata/qemuxml2xmlout-kvmclock.xml | 17 +- tests/qemuxml2xmloutdata/qemuxml2xmlout-lease.xml | 17 +- .../qemuxml2xmlout-machine-core-off.xml | 19 +- .../qemuxml2xmlout-machine-core-on.xml | 19 +- ...t-machine-loadparm-multiple-disks-nets-s390.xml | 5 + .../qemuxml2xmlout-memory-hotplug-dimm.xml | 18 +- .../qemuxml2xmlout-memory-hotplug-nonuma.xml | 14 +- .../qemuxml2xmlout-memory-hotplug.xml | 16 +- .../qemuxml2xmlout-memorybacking-set.xml | 14 +- .../qemuxml2xmlout-memorybacking-unset.xml | 14 +- .../qemuxml2xmlout-memtune-unlimited.xml | 16 +- .../qemuxml2xmloutdata/qemuxml2xmlout-memtune.xml | 16 +- .../qemuxml2xmlout-metadata-duplicate.xml | 16 +- .../qemuxml2xmloutdata/qemuxml2xmlout-metadata.xml | 16 +- .../qemuxml2xmloutdata/qemuxml2xmlout-migrate.xml | 19 +- .../qemuxml2xmloutdata/qemuxml2xmlout-minimal.xml | 16 +- .../qemuxml2xmlout-misc-acpi.xml | 19 +- .../qemuxml2xmlout-misc-disable-s3.xml | 19 +- .../qemuxml2xmlout-misc-disable-suspends.xml | 19 +- .../qemuxml2xmlout-misc-enable-s4.xml | 19 +- .../qemuxml2xmlout-misc-no-reboot.xml | 19 +- .../qemuxml2xmlout-misc-uuid.xml | 19 +- .../qemuxml2xmlout-net-bandwidth.xml | 27 ++- .../qemuxml2xmlout-net-bandwidth2.xml | 25 ++- .../qemuxml2xmlout-net-coalesce.xml | 22 +- .../qemuxml2xmlout-net-eth-hostip.xml | 20 +- .../qemuxml2xmlout-net-eth-ifname.xml | 20 +- .../qemuxml2xmloutdata/qemuxml2xmlout-net-eth.xml | 20 +- .../qemuxml2xmlout-net-hostdev-vfio.xml | 17 +- .../qemuxml2xmlout-net-hostdev.xml | 17 +- .../qemuxml2xmlout-net-midonet.xml | 17 +- .../qemuxml2xmloutdata/qemuxml2xmlout-net-mtu.xml | 22 +- .../qemuxml2xmlout-net-openvswitch.xml | 17 +- .../qemuxml2xmloutdata/qemuxml2xmlout-net-udp.xml | 17 +- .../qemuxml2xmloutdata/qemuxml2xmlout-net-user.xml | 20 +- .../qemuxml2xmlout-net-vhostuser.xml | 22 +- .../qemuxml2xmlout-net-virtio-device.xml | 17 +- .../qemuxml2xmlout-net-virtio-disable-offloads.xml | 17 +- ...qemuxml2xmlout-net-virtio-network-portgroup.xml | 19 +- .../qemuxml2xmlout-net-virtio-rxtxqueuesize.xml | 17 +- .../qemuxml2xmlout-net-virtio.xml | 20 +- .../qemuxml2xmlout-nographics-vga.xml | 19 +- .../qemuxml2xmlout-nosharepages.xml | 19 +- ...emuxml2xmlout-numad-auto-memory-vcpu-cpuset.xml | 16 +- ...ad-auto-memory-vcpu-no-cpuset-and-placement.xml | 16 +- .../qemuxml2xmlout-numad-auto-vcpu-no-numatune.xml | 16 +- ...emuxml2xmlout-numad-static-vcpu-no-numatune.xml | 16 +- .../qemuxml2xmlout-numatune-auto-prefer.xml | 14 +- .../qemuxml2xmlout-numatune-memnode-no-memory.xml | 14 +- .../qemuxml2xmlout-numatune-memnode.xml | 14 +- .../qemuxml2xmlout-panic-double.xml | 17 +- .../qemuxml2xmlout-panic-isa.xml | 20 +- .../qemuxml2xmlout-panic-no-address.xml | 20 +- .../qemuxml2xmlout-panic-pseries.xml | 8 +- tests/qemuxml2xmloutdata/qemuxml2xmlout-panic.xml | 20 +- .../qemuxml2xmlout-pci-autoadd-addr.xml | 24 ++- .../qemuxml2xmlout-pci-autoadd-idx.xml | 25 ++- .../qemuxml2xmlout-pci-autofill-addr.xml | 17 +- .../qemuxml2xmlout-pci-bridge-many-disks.xml | 125 +++++++++++- .../qemuxml2xmlout-pci-bridge.xml | 51 ++++- .../qemuxml2xmlout-pci-expander-bus.xml | 52 ++++- .../qemuxml2xmloutdata/qemuxml2xmlout-pci-many.xml | 45 ++++- .../qemuxml2xmloutdata/qemuxml2xmlout-pci-rom.xml | 20 +- .../qemuxml2xmlout-pci-serial-dev-chardev.xml | 18 +- .../qemuxml2xmlout-pcie-expander-bus.xml | 85 +++++++- ...qemuxml2xmlout-pcie-root-port-model-generic.xml | 20 +- ...qemuxml2xmlout-pcie-root-port-model-ioh3420.xml | 19 +- .../qemuxml2xmlout-pcie-root-port.xml | 21 +- .../qemuxml2xmlout-pcie-root.xml | 17 +- .../qemuxml2xmlout-pcie-switch-downstream-port.xml | 29 ++- .../qemuxml2xmlout-pcie-switch-upstream-port.xml | 23 ++- .../qemuxml2xmlout-pcihole64-gib.xml | 11 +- .../qemuxml2xmlout-pcihole64-none.xml | 11 +- .../qemuxml2xmlout-pcihole64-q35.xml | 16 +- .../qemuxml2xmlout-pcihole64.xml | 11 +- .../qemuxml2xmlout-pmu-feature-off.xml | 17 +- .../qemuxml2xmlout-pmu-feature.xml | 17 +- .../qemuxml2xmlout-ppc64-usb-controller-legacy.xml | 3 + .../qemuxml2xmlout-ppc64-usb-controller.xml | 3 + .../qemuxml2xmlout-pseries-cpu-compat-power9.xml | 8 +- .../qemuxml2xmlout-pseries-cpu-compat.xml | 8 +- .../qemuxml2xmlout-pseries-cpu-exact.xml | 8 +- .../qemuxml2xmlout-pseries-hostdevs-1.xml | 14 +- .../qemuxml2xmlout-pseries-hostdevs-2.xml | 14 +- .../qemuxml2xmlout-pseries-hostdevs-3.xml | 13 +- .../qemuxml2xmlout-pseries-many-buses-1.xml | 11 +- .../qemuxml2xmlout-pseries-many-buses-2.xml | 11 +- .../qemuxml2xmlout-pseries-many-devices.xml | 42 +++- .../qemuxml2xmlout-pseries-nvram.xml | 6 +- .../qemuxml2xmlout-pseries-panic-missing.xml | 8 +- .../qemuxml2xmlout-pseries-panic-no-address.xml | 8 +- .../qemuxml2xmlout-pseries-phb-default-missing.xml | 11 +- .../qemuxml2xmlout-pseries-phb-numa-node.xml | 12 +- .../qemuxml2xmlout-pseries-phb-simple.xml | 11 +- .../qemuxml2xmlout-pv-spinlock-disabled.xml | 14 +- .../qemuxml2xmlout-pv-spinlock-enabled.xml | 14 +- .../qemuxml2xmlout-q35-default-devices-only.xml | 18 +- .../qemuxml2xmlout-q35-multifunction.xml | 33 ++- .../qemuxml2xmlout-q35-pci-force-address.xml | 26 ++- .../qemuxml2xmlout-q35-pcie-autoadd.xml | 41 +++- .../qemuxml2xmloutdata/qemuxml2xmlout-q35-pcie.xml | 42 +++- .../qemuxml2xmlout-q35-usb2-multi.xml | 33 ++- .../qemuxml2xmlout-q35-usb2-reorder.xml | 33 ++- .../qemuxml2xmloutdata/qemuxml2xmlout-q35-usb2.xml | 25 ++- .../qemuxml2xmlout-q35-virt-manager-basic.xml | 33 ++- .../qemuxml2xmlout-q35-virtio-pci.xml | 42 +++- tests/qemuxml2xmloutdata/qemuxml2xmlout-q35.xml | 23 ++- .../qemuxml2xmlout-qemu-ns-no-env.xml | 19 +- .../qemuxml2xmlout-reboot-timeout-disabled.xml | 17 +- .../qemuxml2xmlout-reboot-timeout-enabled.xml | 17 +- .../qemuxml2xmlout-restore-v2.xml | 19 +- .../qemuxml2xmlout-s390-defaultconsole.xml | 9 +- .../qemuxml2xmlout-s390-panic-missing.xml | 3 + .../qemuxml2xmlout-s390-panic-no-address.xml | 3 + .../qemuxml2xmlout-s390-panic.xml | 3 + .../qemuxml2xmlout-seclabel-dac-none.xml | 16 +- .../qemuxml2xmlout-seclabel-device-multiple.xml | 16 +- .../qemuxml2xmlout-seclabel-dynamic-baselabel.xml | 16 +- .../qemuxml2xmlout-seclabel-dynamic-labelskip.xml | 16 +- ...emuxml2xmlout-seclabel-dynamic-none-relabel.xml | 18 +- .../qemuxml2xmlout-seclabel-dynamic-none.xml | 16 +- .../qemuxml2xmlout-seclabel-dynamic-override.xml | 17 +- .../qemuxml2xmlout-seclabel-dynamic-relabel.xml | 16 +- .../qemuxml2xmlout-seclabel-none.xml | 16 +- .../qemuxml2xmlout-seclabel-static-labelskip.xml | 16 +- .../qemuxml2xmlout-seclabel-static.xml | 16 +- .../qemuxml2xmlout-serial-spiceport-nospice.xml | 18 +- .../qemuxml2xmlout-serial-spiceport.xml | 23 ++- .../qemuxml2xmlout-serial-target-port-auto.xml | 20 +- .../qemuxml2xmlout-serial-tcp-tlsx509-chardev.xml | 19 +- .../qemuxml2xmlout-shmem-plain-doorbell.xml | 25 ++- tests/qemuxml2xmloutdata/qemuxml2xmlout-shmem.xml | 25 ++- .../qemuxml2xmlout-smartcard-controller.xml | 19 +- .../qemuxml2xmlout-smartcard-host-certificates.xml | 19 +- .../qemuxml2xmlout-smartcard-host.xml | 19 +- ...muxml2xmlout-smartcard-passthrough-spicevmc.xml | 19 +- .../qemuxml2xmlout-smartcard-passthrough-tcp.xml | 19 +- .../qemuxml2xmlout-smbios-multiple-type2.xml | 16 +- tests/qemuxml2xmloutdata/qemuxml2xmlout-smbios.xml | 16 +- tests/qemuxml2xmloutdata/qemuxml2xmlout-smp.xml | 19 +- .../qemuxml2xmlout-sound-device.xml | 34 +++- tests/qemuxml2xmloutdata/qemuxml2xmlout-sound.xml | 29 ++- .../qemuxml2xmlout-tap-vhost-incorrect.xml | 20 +- .../qemuxml2xmlout-tap-vhost.xml | 21 +- .../qemuxml2xmlout-tpm-passthrough.xml | 15 +- .../qemuxml2xmlout-usb-controller-default-q35.xml | 18 +- .../qemuxml2xmlout-usb-controller-explicit-q35.xml | 18 +- .../qemuxml2xmlout-usb-controller.xml | 14 +- .../qemuxml2xmlout-usb-ich9-ehci-addr.xml | 25 ++- .../qemuxml2xmloutdata/qemuxml2xmlout-usb-none.xml | 17 +- .../qemuxml2xmlout-usb-piix3-controller.xml | 14 +- .../qemuxml2xmlout-usb-port-missing.xml | 17 +- .../qemuxml2xmlout-usb-redir-filter-version.xml | 16 +- .../qemuxml2xmlout-usb-redir-filter.xml | 19 +- .../qemuxml2xmlout-usb-redir.xml | 19 +- .../qemuxml2xmlout-vcpu-placement-static.xml | 17 +- .../qemuxml2xmlout-vhost_queues.xml | 21 +- ...qemuxml2xmlout-video-device-pciaddr-default.xml | 19 +- .../qemuxml2xmlout-video-qxl-heads.xml | 19 +- .../qemuxml2xmlout-video-qxl-noheads.xml | 17 +- .../qemuxml2xmlout-video-virtio-gpu-device.xml | 17 +- .../qemuxml2xmlout-video-virtio-gpu-secondary.xml | 16 +- .../qemuxml2xmlout-video-virtio-gpu-spice-gl.xml | 17 +- .../qemuxml2xmlout-video-virtio-gpu-virgl.xml | 17 +- .../qemuxml2xmlout-virtio-input-passthrough.xml | 15 +- .../qemuxml2xmlout-virtio-input.xml | 17 +- .../qemuxml2xmlout-virtio-lun.xml | 19 +- .../qemuxml2xmlout-virtio-rng-egd.xml | 15 +- .../qemuxml2xmlout-virtio-rng-random.xml | 15 +- .../qemuxml2xmloutdata/qemuxml2xmlout-watchdog.xml | 23 ++- tests/qemuxml2xmltest.c | 63 +++++- 499 files changed, 7768 insertions(+), 1683 deletions(-) -- 2.13.5

4 13

[libvirt] [PATCH v2] docs, rng: Adjust storage pool name grammar checks
by John Ferlan 05 Oct '17

05 Oct '17

https://bugzilla.redhat.com/show_bug.cgi?id=1475250 It's possible to define and start a pool with a '.' in the name; however, when trying to add a volume to a domain using the storage pool source with a '.' in the storage pool name, the domain RNG validation fails because RNG uses 'genericName' which does not allow a '.' in the name. Domain XML def parsing has a virXMLValidateAgainstSchema which generates the error. The Storage Pool XML def parsing has no call to virXMLValidateAgainstSchema. The only Storage Pool name validation occurs in virStoragePoolDefParseXML to ensure the name doesn't have a '/' in it and in storagePoolDefineXML to call virXMLCheckIllegalChars using the same parameter "\n" as qemuDomainDefineXMLFlags would check after the RNG check could be succesful. In order to resolve this, create a poolName definition in storagecommon.rng that will mimic the domain name regex that disallows a newline character, but add the "/" in the exclude list. Then modify the pool and volume source name definitions to key off that poolName. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- v1: https://www.redhat.com/archives/libvir-list/2017-September/msg01037.html Change only to add '/' before the newline in poolName docs/schemas/domaincommon.rng | 2 +- docs/schemas/storagecommon.rng | 8 ++++++++ docs/schemas/storagepool.rng | 4 ++-- 3 files changed, 11 insertions(+), 3 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index bac371ea3..89515564f 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -1674,7 +1674,7 @@ <optional> <element name="source"> <attribute name="pool"> - <ref name="genericName"/> + <ref name="poolName"/> </attribute> <attribute name="volume"> <ref name="volName"/> diff --git a/docs/schemas/storagecommon.rng b/docs/schemas/storagecommon.rng index 717f3c603..edee1b084 100644 --- a/docs/schemas/storagecommon.rng +++ b/docs/schemas/storagecommon.rng @@ -6,6 +6,14 @@  + <define name="poolName"> + <data type="string"> +  + <param name="pattern">[^/ +]+</param> + </data> + </define> + <define name='encryption'> <element name='encryption'> <attribute name='format'> diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng index f0117bd69..52b2044be 100644 --- a/docs/schemas/storagepool.rng +++ b/docs/schemas/storagepool.rng @@ -209,7 +209,7 @@ <interleave> <optional> <element name='name'> - <ref name='genericName'/> + <ref name='poolName'/> </element> </optional> <optional> @@ -223,7 +223,7 @@ <define name='commonmetadata'> <interleave> <element name='name'> - <ref name='genericName'/> + <ref name='poolName'/> </element> <optional> <element name='uuid'> -- 2.13.6

2 1

[libvirt] [PATCH] spec: Enable qemu driver on s390x on RHEL/CentOS
by Jiri Denemark 05 Oct '17

05 Oct '17

Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 48f193f0c4..e053f05f1c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -35,7 +35,7 @@ %define with_qemu_tcg 0 %define qemu_kvm_arches x86_64 %if 0%{?rhel} >= 7 - %define qemu_kvm_arches x86_64 %{power64} aarch64 + %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x %endif %endif -- 2.14.2

2 1

[libvirt] [PATCH 0/7] qemu: refactor disk startup handling (blockdev-add saga)
by Peter Krempa 05 Oct '17

05 Oct '17

This is a collection of patches which refactor and fix disk startup code which are part of my work on the blockdev-add feature. Peter Krempa (7): qemu: process: document parameters for startup preparing functions qemu: migration: Extract flags for starting VM into a variable qemu: process: Pass flags to qemuProcessPrepareHost qemu: domain: Document and export qemuDomainCheckDiskStartupPolicy qemu: process: Move 'volume' translation to domain prepare stage qemu: process: Move TLS setup for storage source to qemuProcessPrepareDomainStorage qemu: process: move disk presence checking to host setup function src/qemu/qemu_domain.c | 90 ++++++++---------------------------------- src/qemu/qemu_domain.h | 13 +++---- src/qemu/qemu_migration.c | 12 +++--- src/qemu/qemu_process.c | 99 ++++++++++++++++++++++++++++++++++++++++------- src/qemu/qemu_process.h | 2 +- 5 files changed, 117 insertions(+), 99 deletions(-) -- 2.14.1

2 18

[libvirt] [PATCH 0/7] Fix reversed stats/QoS for macvtap
by Michal Privoznik 05 Oct '17

05 Oct '17

This is initiated by: https://bugzilla.redhat.com/show_bug.cgi?id=1497410 Long story short, in some cases host and domain are on the same side of RX/TX stats/QoS. Michal Privoznik (7): lxc: Drop useless ifdef __linux__ qemuDomainInterfaceStats: Check for the actual type of interface conf: Introduce virDomainNetFindByName src: Use virDomainNetFindByName virNetDevTapInterfaceStats: Allow caller to not swap the statistics QoS: Set classes and filters in proper direction libvirt-domain: Document interface stats POV src/conf/domain_conf.c | 31 ++++++++++--- src/conf/domain_conf.h | 38 +++++++++++++++- src/libvirt-domain.c | 4 +- src/libvirt_private.syms | 1 + src/libxl/libxl_driver.c | 23 +++++----- src/lxc/lxc_driver.c | 38 ++++++---------- src/lxc/lxc_process.c | 3 +- src/network/bridge_driver.c | 2 +- src/openvz/openvz_driver.c | 23 +++++----- src/qemu/qemu_command.c | 3 +- src/qemu/qemu_driver.c | 41 +++++++++-------- src/qemu/qemu_hotplug.c | 6 ++- src/test/test_driver.c | 28 +++--------- src/util/virnetdevbandwidth.c | 43 ++++++++++++------ src/util/virnetdevbandwidth.h | 3 +- src/util/virnetdevtap.c | 99 ++++++++++++++++++++++++++++-------------- src/util/virnetdevtap.h | 3 +- src/xen/xen_hypervisor.c | 2 +- tests/virnetdevbandwidthtest.c | 2 +- 19 files changed, 236 insertions(+), 157 deletions(-) -- 2.13.5

2 17

[libvirt] [PATCH] tests: Fix build with clang
by Jiri Denemark 05 Oct '17

05 Oct '17

clang doesn't like mode_t type as an argument to va_arg(): error: second argument to 'va_arg' is of promotable type 'mode_t' (aka 'unsigned short'); this va_arg has undefined behavior because arguments will be promoted to 'int' mode = va_arg(ap, mode_t); ^~~~~~ Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- Pushed as a build-breaker. tests/virfilewrapper.c | 2 +- tests/virusbmock.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/virfilewrapper.c b/tests/virfilewrapper.c index 1d1d182708..3fd7f7aa8f 100644 --- a/tests/virfilewrapper.c +++ b/tests/virfilewrapper.c @@ -267,7 +267,7 @@ int open(const char *path, int flags, ...) */ if (flags & O_CREAT) { va_start(ap, flags); - mode = va_arg(ap, mode_t); + mode = (mode_t) va_arg(ap, int); va_end(ap); } diff --git a/tests/virusbmock.c b/tests/virusbmock.c index f430a2edad..12083e2362 100644 --- a/tests/virusbmock.c +++ b/tests/virusbmock.c @@ -101,7 +101,7 @@ int open(const char *pathname, int flags, ...) */ if (flags & O_CREAT) { va_start(ap, flags); - mode = va_arg(ap, mode_t); + mode = (mode_t) va_arg(ap, int); va_end(ap); } -- 2.14.2

1 0

[libvirt] [PATCH v6 0/2] Add support for qcow2 cache
by Liu Qing 04 Oct '17

04 Oct '17

Qcow2 small IO random write performance will drop dramatically if the l2 cache table could not cover the whole disk. This will be a lot of l2 cache table RW operations if cache miss happens frequently. This patch exports the qcow2 driver parameter l2-cache-size/refcount-cache-size, first added in Qemu 2.2, and cache-clean-interval, first added in Qemu 2.5, in libvirt. change since v4: removed unnecessary cache error check Liu Qing (2): conf, docs: Add qcow2 cache configuration support qemu: add capability checking for qcow2 cache configuration docs/formatdomain.html.in | 41 +++++++++ docs/schemas/domaincommon.rng | 35 ++++++++ src/conf/domain_conf.c | 97 ++++++++++++++++++++-- src/qemu/qemu_capabilities.c | 11 +++ src/qemu/qemu_capabilities.h | 5 ++ src/qemu/qemu_command.c | 33 ++++++++ src/qemu/qemu_driver.c | 5 ++ src/util/virstoragefile.c | 3 + src/util/virstoragefile.h | 6 ++ tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 3 + .../caps_2.6.0-gicv2.aarch64.xml | 3 + .../caps_2.6.0-gicv3.aarch64.xml | 3 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64le.xml | 3 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 3 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 3 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 3 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 3 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 3 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml | 3 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 3 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 3 + .../qemuxml2argv-disk-drive-qcow2-cache.args | 28 +++++++ .../qemuxml2argv-disk-drive-qcow2-cache.xml | 43 ++++++++++ tests/qemuxml2argvtest.c | 4 + .../qemuxml2xmlout-disk-drive-qcow2-cache.xml | 43 ++++++++++ tests/qemuxml2xmltest.c | 1 + 26 files changed, 384 insertions(+), 7 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-qcow2-cache.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-qcow2-cache.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-qcow2-cache.xml -- 1.8.3.1

3 9

[libvirt] Release of libvirt-3.8.0
by Daniel Veillard 04 Oct '17

04 Oct '17

I tagged the tree and pushed the release earlier today, signed tarball and rpms should be available at the usual place: ftp://libvirt.org/libvirt/ I also pushed the associated 3.8.0 for the python bindings which can be found in the python subdir: ftp://libvirt.org/libvirt/ This is a balanced release with new features especially for Qemu/KVM, a reasonable set of improvement and bugs fixes: New features: ------------- - qemu: Added support for cold-(un)plug of watchdog devices - qemu: Added support for setting IP address os usernet interfaces - qemu: Added support for Veritas Hyperscale (VxHS) block devices - storage: Added new events for pool-build and pool-delete Improvements: ------------- - qemu: Set DAC permissions properly for spice rendernode When a rendernode path is set for SPICE GL on qemu:///system, we now correctly set DAC permissions on the device at VM startup. This is the last remaining hurdle to let SPICE GL work for qemu:///system without any external host changes. - nodedev: Add switchdev offload query to NIC capabilities Allow querying the NIC interface capabilities for the availability of switchdev offloading (also known as kernel-forward-plane-offload). - New CPU models for AMD and Intel AMD EPYC and Intel Skylake-Server CPU models were added together with their features - Improve long waiting when saving a domain While waiting for a write to disk to be finished, e.g. during save, even simple operations like virsh list would be blocking due to domain lock. This is now resolved by unlocking the domain in places where it is not needed. * Bug fixes: ------------ - Proper units are now used in virsh manpage for dom(mem)stats Previously the documentation used multiples of 1000, but now it is fixed to use multiples of 1024. - qemu: Fix error reporting when disk attachment fails There was a possibility for the actual error to be overridden or cleared during the rollback. - qemu: Fix assignment of graphics ports after daemon restart This could be seen with newer kernels that have bug regarding SO_REUSEADDR. After libvirtd was restarted it could assign already used address to new guests which would make them fail to start. This is fixed by marking used ports unavailable when reconnecting to running QEMU domains. - Fix message decoding which was causing a very strange bug When parsing an RPC message with file descriptors was interrupted and had to restart, the offset of the payload was calculated badly causing strange issues like not being able to find a domain that was not requested. thanks everybody who contributed to this release with bug reports, patches, reviews, documentation, etc ... Enjoy the release ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

1 0

[libvirt] [PATCH] storage: Fix incorrect parenthesis placement
by Pavel Hrdina 04 Oct '17

04 Oct '17

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1498528 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- Pushed under trivial rule. src/storage/storage_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c index b94b3f397c..b23b6dd1d1 100644 --- a/src/storage/storage_util.c +++ b/src/storage/storage_util.c @@ -1843,7 +1843,7 @@ virStorageBackendUpdateVolInfo(virStorageVolDefPtr vol, withBlockVolFormat, VIR_STORAGE_VOL_OPEN_DEFAULT | VIR_STORAGE_VOL_OPEN_NOERROR, - readflags) < 0)) + readflags)) < 0) return ret; return 0; -- 2.13.6

1 0

[libvirt] [PATCH v2 0/2] Add multiqueue support for virtio-blk
by Lin Ma 04 Oct '17

04 Oct '17

The multiqueue for virtio-blk was introduced since qemu 2.7.0. These patches supported it and update test data for it. v1 -> v2: Follow Ján Tomko's suggestion: * move qemu_capabilities.{ch} to patch 1/2. * use virStrToLong_uip instead of virStrToLong_ui. * move virtio disk check code from formatter to virDomainDiskDefValidate. not sure if it's the right place because Ján suggests to qemuDomain*DefValidate. * if qemu doesn't have num-queues support, report error instead of doing nothing. Lin Ma (2): qemucapstest: Update test data for 'num-queues' property of virtio-blk qemu: Support multiqueue virtio-blk docs/formatdomain.html.in | 6 +++- docs/schemas/domaincommon.rng | 5 ++++ src/conf/domain_conf.c | 18 ++++++++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 7 +++++ src/qemu/qemu_domain.c | 24 +++++++++++++++ src/qemu/qemu_domain.h | 3 ++ tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + .../qemuxml2argv-disk-virtio-drive-queues.args | 24 +++++++++++++++ .../qemuxml2argv-disk-virtio-drive-queues.xml | 34 ++++++++++++++++++++++ tests/qemuxml2argvtest.c | 2 ++ .../qemuxml2xmlout-disk-virtio-drive-queues.xml | 34 ++++++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 23 files changed, 170 insertions(+), 1 deletion(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-drive-queues.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-virtio-drive-queues.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-virtio-drive-queues.xml -- 2.9.2

2 4

[libvirt] [PATCH 0/2] qemu: command: Clean up disk command line generators (blockdev-add saga)
by Peter Krempa 04 Oct '17

04 Oct '17

Some cleanups to the command line generator so that it's easier to splice in the new blockdev-add stuff. Peter Krempa (2): qemu: command: Separate validation from command line building for -drive qemu: command: Move PPC fdc check to domain validation src/qemu/qemu_command.c | 295 ++++++++++++++++++++++++++---------------------- src/qemu/qemu_process.c | 11 +- 2 files changed, 171 insertions(+), 135 deletions(-) -- 2.14.1

2 3

[libvirt] [PATCH 0/3] Couple of <interface/> improvements
by Michal Privoznik 04 Oct '17

04 Oct '17

https://bugzilla.redhat.com/show_bug.cgi?id=1343919 Michal Privoznik (3): qemuParseCommandLineNet: Make more readable virmacaddr: Track if MAC address is autogenerated virDomainNetFindIdx: Ignore auto generated MAC addresses src/conf/domain_conf.c | 45 +++++++++++++++++++++++++++++++++---------- src/qemu/qemu_parse_command.c | 32 ++++++++++++------------------ src/util/virmacaddr.c | 5 +++++ src/util/virmacaddr.h | 2 ++ tests/bhyveargv2xmlmock.c | 1 + tests/bhyvexml2argvmock.c | 1 + 6 files changed, 56 insertions(+), 30 deletions(-) -- 2.13.5

3 11

[libvirt] [PATCH v4 00/15] Use secret objects to pass iSCSI passwords
by John Ferlan 04 Oct '17

04 Oct '17

v3: https://www.redhat.com/archives/libvir-list/2017-September/msg00881.html Difference with v3: Add patch 3 to perform virStorageSourceCopy for qemu and storage source private data. Adjust the move encinfo from private disk to private disk src to handle the Copy for the @encinfo too Repeated from cover of v3: v2: https://www.redhat.com/archives/libvir-list/2017-September/msg00466.html Changes since v2: * Former Patch 1 & 2 were pushed * New Patch 1 is former Patches 3 and parts of 4 combined appropriately -> Allow <auth> under <disk> or <source> - keep track of where it was found so that format prints in the right place -> Cleaned up the tests and new xml/args files * Patch 2 is part of the former patch 6 - just the new _virStorageSource * Patch 3 is new - to introduced an allocator for domain_conf to create a _virStorageSource * Patch 4 is new - as stated found that the @diskPriv->encinfo wasn't cleaned up properly * Patch 5 is the rest of the former patch 6 * Patch 6 is the former patch 7 with some minor adjustments to allow <encryption> to follow <auth> and be both child of <disk> and <source> * Patch 7 is the former patch 10 with minor change to perform free of encinfo properly (e.g. from patch 4) * Patch 8 is former patch 5 and 9 combined * Patch 9 is new - to use the virStorageSource for iscsisrc instead of just three fields we wanted * Patch 10 is new to alter the existing hostdevPriv to use diskSrcPriv * Patch 11 is new to remove the hostdevPriv as it's no longer necesary * Patch 12 is new to split up a change in qemuBuildSCSIiSCSIHostdevDrvStr from the last patch * Patch 13 is the former patch 13 * Patch 14 is altered to accomodate the hostdev usage if virStorageSource for iscsisrc->src instead of that hack that was there before. John Ferlan (15): conf: Add/Allow parsing the auth in the disk source qemu: Introduce privateData for _virStorageSource qemu: Introduce qemuDomainStorageSourceCopy conf: Introduce virDomainDiskStorageSourceNew qemu: Add missing encinfo cleanup qemu: Relocate qemuDomainSecretInfoPtr from disk private conf: Add/Allow parsing the encryption in the disk source qemu: Move encinfo from private disk to private disk src docs: Add news article regarding auth/encryption placement conf,qemu: Replace iscsisrc fields with virStorageSourcePtr qemu: Use private disksrc for iscsi instead of private hostdev qemu: Remove private hostdev qemu: Refactor qemuBuildSCSIiSCSIHostdevDrvStr slightly qemu: Get capabilities to use iscsi password-secret argument qemu: Use secret objects to pass iSCSI passwords docs/formatdomain.html.in | 82 ++++--- docs/news.xml | 13 ++ docs/schemas/domaincommon.rng | 48 +++- src/conf/domain_conf.c | 255 ++++++++++++++++----- src/conf/domain_conf.h | 10 +- src/lxc/lxc_native.c | 2 +- src/qemu/qemu_block.c | 64 +++++- src/qemu/qemu_blockjob.c | 2 +- src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_command.c | 84 +++++-- src/qemu/qemu_command.h | 3 +- src/qemu/qemu_domain.c | 163 +++++++++---- src/qemu/qemu_domain.h | 37 ++- src/qemu/qemu_driver.c | 8 +- src/qemu/qemu_hotplug.c | 71 +++++- src/qemu/qemu_parse_command.c | 4 +- src/util/virstoragefile.c | 2 + src/util/virstoragefile.h | 5 + src/vbox/vbox_common.c | 2 +- src/xenconfig/xen_common.c | 2 +- src/xenconfig/xen_sxpr.c | 2 +- src/xenconfig/xen_xl.c | 2 +- .../qemuargv2xml-disk-drive-network-rbd-auth.xml | 6 +- tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64le.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + ...xml2argv-disk-drive-network-iscsi-auth-AES.args | 41 ++++ ...uxml2argv-disk-drive-network-iscsi-auth-AES.xml | 43 ++++ ...ml2argv-disk-drive-network-source-auth-both.xml | 51 +++++ ...emuxml2argv-disk-drive-network-source-auth.args | 32 +++ ...qemuxml2argv-disk-drive-network-source-auth.xml | 45 ++++ ...ml2argv-hostdev-scsi-virtio-iscsi-auth-AES.args | 45 ++++ ...xml2argv-hostdev-scsi-virtio-iscsi-auth-AES.xml | 48 ++++ .../qemuxml2argv-luks-disks-source-both.xml | 40 ++++ .../qemuxml2argv-luks-disks-source.args | 62 +++++ .../qemuxml2argv-luks-disks-source.xml | 81 +++++++ tests/qemuxml2argvtest.c | 14 ++ ...muxml2xmlout-disk-drive-network-source-auth.xml | 49 ++++ .../qemuxml2xmlout-luks-disks-source.xml | 84 +++++++ .../qemuxml2xmlout-luks-disks.xml | 46 +++- tests/qemuxml2xmltest.c | 2 + tests/virhostdevtest.c | 2 +- tests/virstoragetest.c | 6 + 46 files changed, 1346 insertions(+), 220 deletions(-) create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-AES.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth-AES.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-source-auth-both.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-source-auth.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-source-auth.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth-AES.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth-AES.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-luks-disks-source-both.xml create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-luks-disks-source.args create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-luks-disks-source.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-source-auth.xml create mode 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-luks-disks-source.xml mode change 120000 => 100644 tests/qemuxml2xmloutdata/qemuxml2xmlout-luks-disks.xml -- 2.13.5

1 16

[libvirt] [PATCH] tests: Do not ignore mode parameter in mocked open()
by Jiri Denemark 04 Oct '17

04 Oct '17

From: Luyao Huang <lhuang(a)redhat.com> This is normally not an issue since the tests which use mocked open() do not create files. But once coverage build is enabled, gcov_open will use O_CREATE and real_open will read random data rather than the actual mode argument. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- tests/virfilewrapper.c | 13 ++++++++++++- tests/virusbmock.c | 15 ++++++++++++++- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/tests/virfilewrapper.c b/tests/virfilewrapper.c index fede7b2e89..1d1d182708 100644 --- a/tests/virfilewrapper.c +++ b/tests/virfilewrapper.c @@ -257,10 +257,21 @@ int open(const char *path, int flags, ...) { int ret = -1; char *newpath = NULL; + va_list ap; + mode_t mode = 0; PATH_OVERRIDE(newpath, path); - ret = real_open(newpath, flags); + /* The mode argument is mandatory when O_CREAT is set in flags, + * otherwise the argument is ignored. + */ + if (flags & O_CREAT) { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); + } + + ret = real_open(newpath, flags, mode); VIR_FREE(newpath); diff --git a/tests/virusbmock.c b/tests/virusbmock.c index 8d60664944..f430a2edad 100644 --- a/tests/virusbmock.c +++ b/tests/virusbmock.c @@ -87,13 +87,26 @@ int open(const char *pathname, int flags, ...) { char *path; int ret; + va_list ap; + mode_t mode = 0; init_syms(); path = get_fake_path(pathname); if (!path) return -1; - ret = realopen(path, flags); + + /* The mode argument is mandatory when O_CREAT is set in flags, + * otherwise the argument is ignored. + */ + if (flags & O_CREAT) { + va_start(ap, flags); + mode = va_arg(ap, mode_t); + va_end(ap); + } + + ret = realopen(path, flags, mode); + VIR_FREE(path); return ret; } -- 2.14.2

3 2

[libvirt] [PATCH] util: Free a pointer in virPolkitCheckAuth
by Kothapally Madhu Pavan 04 Oct '17

04 Oct '17

Free DBusMessage pointer in virPolkitCheckAuth Signed-off-by: Kothapally Madhu Pavan <kmp(a)linux.vnet.ibm.com> --- src/util/virpolkit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virpolkit.c b/src/util/virpolkit.c index c735ca9..4559431 100644 --- a/src/util/virpolkit.c +++ b/src/util/virpolkit.c @@ -138,6 +138,7 @@ int virPolkitCheckAuth(const char *actionid, cleanup: virStringListFreeCount(retdetails, nretdetails); + virDBusMessageUnref(reply); return ret; } -- 1.8.3.1

2 1

[libvirt] [PATCH] Post-release version bump to 3.9.0
by Peter Krempa 04 Oct '17

04 Oct '17

--- Pushed. configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index d817975a5..4f420cf8d 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [3.8.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] +AC_INIT([libvirt], [3.9.0], [libvir-list(a)redhat.com] [], [http://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/news.xml b/docs/news.xml index 222cc03ea..72e15567c 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -33,6 +33,14 @@ --> <libvirt> + <release version="v3.9.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v3.8.0" date="2017-10-04"> <section title="New features"> <change> -- 2.14.1

1 0

[libvirt] [PATCH alt] conf: Allow user define their own alias
by Michal Privoznik 03 Oct '17

03 Oct '17

https://bugzilla.redhat.com/show_bug.cgi?id=1434451 It comes handy for management application to be able to have a per-device label so that it can uniquely identify devices it cares about. The advantage of this approach is that we don't have to generate aliases at define time (non trivial amount of work and problems). The only thing we do is parse the user supplied tag and format it back. For instance: <disk type='block' device='disk'> <driver name='qemu' type='raw'/> <source dev='/dev/HostVG/QEMUGuest1'/> <target dev='hda' bus='ide'/> <alias user='myDisk0'/> <address type='drive' controller='0' bus='0' target='0' unit='0'/> </disk> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- An alternative approach to: https://www.redhat.com/archives/libvir-list/2017-September/msg00765.html Honestly, I prefer this one as it's simpler and we don't have to care about devices changing their aliases on cold plug. I mean, on cold (un-)plug we'd have to regenerate the aliases so it might be hard to track certain device. But with this approach, it's no problem. Also, I'm not completely convinced about the name of @user attribute. So I'm open for suggestions. docs/schemas/domaincommon.rng | 13 +++++++--- src/conf/device_conf.c | 1 + src/conf/device_conf.h | 1 + src/conf/domain_conf.c | 20 ++++++++++----- tests/genericxml2xmlindata/generic-user-alias.xml | 31 +++++++++++++++++++++++ tests/genericxml2xmltest.c | 2 ++ 6 files changed, 59 insertions(+), 9 deletions(-) create mode 100644 tests/genericxml2xmlindata/generic-user-alias.xml diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index bac371ea3..69c121ce9 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -5864,9 +5864,16 @@ </define> <define name='alias'> <element name='alias'> - <attribute name='name'> - <ref name='aliasName'/> - </attribute> + <optional> + <attribute name='name'> + <ref name='aliasName'/> + </attribute> + </optional> + <optional> + <attribute name='user'> + <ref name='aliasName'/> + </attribute> + </optional> </element> <empty/> </define> diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index d69f94fad..ced5db123 100644 --- a/src/conf/device_conf.c +++ b/src/conf/device_conf.c @@ -57,6 +57,7 @@ void virDomainDeviceInfoClear(virDomainDeviceInfoPtr info) { VIR_FREE(info->alias); + VIR_FREE(info->user); memset(&info->addr, 0, sizeof(info->addr)); info->type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE; VIR_FREE(info->romfile); diff --git a/src/conf/device_conf.h b/src/conf/device_conf.h index f87d6f1fc..08a9e57e3 100644 --- a/src/conf/device_conf.h +++ b/src/conf/device_conf.h @@ -135,6 +135,7 @@ typedef struct _virDomainDeviceInfo virDomainDeviceInfo; typedef virDomainDeviceInfo *virDomainDeviceInfoPtr; struct _virDomainDeviceInfo { char *alias; + char *user; /* user defined ID for the device */ int type; /* virDomainDeviceAddressType */ union { virPCIDeviceAddress pci; diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 87192eb2d..885825226 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -5756,6 +5756,8 @@ virDomainDeviceInfoFormat(virBufferPtr buf, virDomainDeviceInfoPtr info, unsigned int flags) { + bool formatAlias = info->alias && !(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE); + if ((flags & VIR_DOMAIN_DEF_FORMAT_ALLOW_BOOT) && info->bootIndex) { virBufferAsprintf(buf, "<boot order='%u'", info->bootIndex); @@ -5764,9 +5766,13 @@ virDomainDeviceInfoFormat(virBufferPtr buf, virBufferAddLit(buf, "/>\n"); } - if (info->alias && - !(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)) { - virBufferAsprintf(buf, "<alias name='%s'/>\n", info->alias); + if (formatAlias || info->user) { + virBufferAddLit(buf, "<alias"); + if (formatAlias) + virBufferAsprintf(buf, " name='%s'", info->alias); + if (info->user) + virBufferAsprintf(buf, " user='%s'", info->user); + virBufferAddLit(buf, "/>\n"); } if (info->mastertype == VIR_DOMAIN_CONTROLLER_MASTER_USB) { @@ -6327,7 +6333,6 @@ virDomainDeviceInfoParseXML(xmlNodePtr node, while (cur != NULL) { if (cur->type == XML_ELEMENT_NODE) { if (alias == NULL && - !(flags & VIR_DOMAIN_DEF_PARSE_INACTIVE) && virXMLNodeNameEqual(cur, "alias")) { alias = cur; } else if (address == NULL && @@ -6349,8 +6354,11 @@ virDomainDeviceInfoParseXML(xmlNodePtr node, cur = cur->next; } - if (alias) - info->alias = virXMLPropString(alias, "name"); + if (alias) { + if (!(flags & VIR_DOMAIN_DEF_PARSE_INACTIVE)) + info->alias = virXMLPropString(alias, "name"); + info->user = virXMLPropString(alias, "user"); + } if (master) { info->mastertype = VIR_DOMAIN_CONTROLLER_MASTER_USB; diff --git a/tests/genericxml2xmlindata/generic-user-alias.xml b/tests/genericxml2xmlindata/generic-user-alias.xml new file mode 100644 index 000000000..025924442 --- /dev/null +++ b/tests/genericxml2xmlindata/generic-user-alias.xml @@ -0,0 +1,31 @@ +<domain type='qemu'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-i686</emulator> + <disk type='block' device='disk'> + <driver name='qemu' type='raw'/> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='hda' bus='ide'/> + <alias user='myDisk0'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='usb' index='0'> + <alias user='myController0'/> + </controller> + <controller type='ide' index='0'/> + <controller type='pci' index='0' model='pci-root'/> + <memballoon model='none'/> + </devices> +</domain> diff --git a/tests/genericxml2xmltest.c b/tests/genericxml2xmltest.c index 0377a05e9..63a62f6a5 100644 --- a/tests/genericxml2xmltest.c +++ b/tests/genericxml2xmltest.c @@ -130,6 +130,8 @@ mymain(void) DO_TEST_FULL("chardev-reconnect-invalid-mode", 0, false, TEST_COMPARE_DOM_XML2XML_RESULT_FAIL_PARSE); + DO_TEST("user-alias"); + virObjectUnref(caps); virObjectUnref(xmlopt); -- 2.13.5

4 15

[libvirt] [PATCH] spec: Delay supported_platform check
by Jiri Denemark 03 Oct '17

03 Oct '17

Building RPM should only be allowed on a supported platform, but unpacking the source and applying all patches can be done anywhere. Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- libvirt.spec.in | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index a3bd77f8a4..48f193f0c4 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -1091,10 +1091,6 @@ Libvirt plugin for NSS for translating domain names into IP addresses. %prep -%if ! %{supported_platform} -echo "This RPM requires either Fedora >= 20 or RHEL >= 6" -exit 1 -%endif %setup -q @@ -1135,6 +1131,11 @@ rm -f $PATCHLIST rm -rf .git %build +%if ! %{supported_platform} +echo "This RPM requires either Fedora >= 20 or RHEL >= 6" +exit 1 +%endif + %if %{with_xen} %define arg_xen --with-xen %else -- 2.14.2

3 2

[libvirt] [PATCH 0/3] Hyper-V driver fixes
by Ladi Prosek 03 Oct '17

03 Oct '17

Fixes a couple of minor issues in the Hyper-V driver found by code inspection. Ladi Prosek (3): hyperv: Fix hypervInitConnection error reporting hyperv: Escape WQL queries hyperv: Map Limit to max_memory and VirtualQuantity to cur_balloon src/hyperv/hyperv_driver.c | 104 ++++++++++++++++++++++----------------------- src/hyperv/hyperv_wmi.c | 3 +- src/util/virbuffer.c | 18 ++++++++ src/util/virbuffer.h | 3 ++ 4 files changed, 75 insertions(+), 53 deletions(-) -- 2.13.5

2 5

[libvirt] [libvirt-jenkins-ci PATCH 00/18] Ansible all the things!
by Andrea Bolognani 03 Oct '17

03 Oct '17

See patch 18 for information about the purpose and scope of these changes. Andrea Bolognani (18): ansible: Add initial support ansible: Add initial support for building projects ansible: Add libosinfo project ansible: Add libvirt project ansible: Add libvirt-cim project ansible: Add libvirt-glib project ansible: Add libvirt-go project ansible: Add libvirt-go-xml project ansible: Add libvirt-perl project ansible: Add libvirt-python project ansible: Add libvirt-sandbox project ansible: Add libvirt-tck project ansible: Add osinfo-db project ansible: Add osinfo-db-tools project ansible: Add virt-manager project ansible: Add virt-viewer project ansible: Install and configure Jenkins agent ansible: Add documentation ansible/.gitignore | 3 + ansible/Makefile | 12 ++ ansible/README.markdown | 71 +++++++ ansible/ansible.cfg | 9 + ansible/bootstrap.yml | 17 ++ ansible/group_vars/all/main.yml | 18 ++ ansible/host_vars/libvirt-centos-6/main.yml | 10 + ansible/host_vars/libvirt-centos-6/vault.yml | 10 + ansible/host_vars/libvirt-centos-7/main.yml | 19 ++ ansible/host_vars/libvirt-centos-7/vault.yml | 10 + ansible/host_vars/libvirt-debian-8/main.yml | 17 ++ ansible/host_vars/libvirt-debian-8/vault.yml | 10 + ansible/host_vars/libvirt-debian-9/main.yml | 19 ++ ansible/host_vars/libvirt-debian-9/vault.yml | 10 + ansible/host_vars/libvirt-fedora-25/main.yml | 20 ++ ansible/host_vars/libvirt-fedora-25/vault.yml | 10 + ansible/host_vars/libvirt-fedora-26/main.yml | 20 ++ ansible/host_vars/libvirt-fedora-26/vault.yml | 10 + ansible/host_vars/libvirt-fedora-rawhide/main.yml | 20 ++ ansible/host_vars/libvirt-fedora-rawhide/vault.yml | 10 + ansible/host_vars/libvirt-freebsd-11/main.yml | 25 +++ ansible/host_vars/libvirt-freebsd-11/vault.yml | 10 + ansible/host_vars/libvirt-ubuntu-12/main.yml | 7 + ansible/host_vars/libvirt-ubuntu-12/vault.yml | 8 + ansible/host_vars/libvirt-ubuntu-14/main.yml | 14 ++ ansible/host_vars/libvirt-ubuntu-14/vault.yml | 8 + ansible/host_vars/libvirt-ubuntu-16/main.yml | 18 ++ ansible/host_vars/libvirt-ubuntu-16/vault.yml | 8 + ansible/inventory | 8 + ansible/mappings/commands.yml | 77 +++++++ ansible/mappings/libraries.yml | 228 +++++++++++++++++++++ ansible/mappings/misc.yml | 13 ++ ansible/mappings/perl.yml | 112 ++++++++++ ansible/mappings/python.yml | 35 ++++ ansible/site.yml | 38 ++++ ansible/tasks/base.yml | 77 +++++++ ansible/tasks/bootstrap.yml | 22 ++ ansible/tasks/build.yml | 223 ++++++++++++++++++++ ansible/tasks/compat.yml | 16 ++ ansible/tasks/facts.yml | 14 ++ ansible/tasks/jenkins.yml | 59 ++++++ ansible/tasks/packages.yml | 22 ++ ansible/templates/jenkins.service.j2 | 14 ++ ansible/vars/base/CentOS-6.yml | 13 ++ ansible/vars/base/CentOS-7.yml | 13 ++ ansible/vars/base/Debian-8.yml | 14 ++ ansible/vars/base/Debian-9.yml | 14 ++ ansible/vars/base/Fedora-25.yml | 15 ++ ansible/vars/base/Fedora-26.yml | 15 ++ ansible/vars/base/Fedora-Rawhide.yml | 15 ++ ansible/vars/base/FreeBSD-11.yml | 11 + ansible/vars/base/Ubuntu-12.yml | 13 ++ ansible/vars/base/Ubuntu-14.yml | 13 ++ ansible/vars/base/Ubuntu-16.yml | 14 ++ ansible/vars/jenkins/CentOS-6.yml | 3 + ansible/vars/jenkins/CentOS-7.yml | 3 + ansible/vars/jenkins/Debian-8.yml | 3 + ansible/vars/jenkins/Debian-9.yml | 3 + ansible/vars/jenkins/Fedora-25.yml | 3 + ansible/vars/jenkins/Fedora-26.yml | 3 + ansible/vars/jenkins/Fedora-Rawhide.yml | 3 + ansible/vars/jenkins/FreeBSD-11.yml | 3 + ansible/vars/jenkins/Ubuntu-12.yml | 3 + ansible/vars/jenkins/Ubuntu-14.yml | 3 + ansible/vars/jenkins/Ubuntu-16.yml | 3 + ansible/vars/libosinfo/CentOS-7.yml | 19 ++ ansible/vars/libosinfo/Debian-8.yml | 19 ++ ansible/vars/libosinfo/Debian-9.yml | 19 ++ ansible/vars/libosinfo/Fedora-25.yml | 19 ++ ansible/vars/libosinfo/Fedora-26.yml | 19 ++ ansible/vars/libosinfo/Fedora-Rawhide.yml | 19 ++ ansible/vars/libosinfo/FreeBSD-11.yml | 19 ++ ansible/vars/libosinfo/Ubuntu-14.yml | 19 ++ ansible/vars/libosinfo/Ubuntu-16.yml | 19 ++ ansible/vars/libvirt-cim/CentOS-6.yml | 11 + ansible/vars/libvirt-cim/CentOS-7.yml | 11 + ansible/vars/libvirt-cim/Fedora-25.yml | 11 + ansible/vars/libvirt-cim/Fedora-26.yml | 11 + ansible/vars/libvirt-cim/Fedora-Rawhide.yml | 11 + ansible/vars/libvirt-glib/CentOS-7.yml | 16 ++ ansible/vars/libvirt-glib/Debian-8.yml | 16 ++ ansible/vars/libvirt-glib/Debian-9.yml | 16 ++ ansible/vars/libvirt-glib/Fedora-25.yml | 16 ++ ansible/vars/libvirt-glib/Fedora-26.yml | 16 ++ ansible/vars/libvirt-glib/Fedora-Rawhide.yml | 16 ++ ansible/vars/libvirt-glib/FreeBSD-11.yml | 16 ++ ansible/vars/libvirt-glib/Ubuntu-16.yml | 16 ++ ansible/vars/libvirt-go-xml/CentOS-7.yml | 3 + ansible/vars/libvirt-go-xml/Debian-8.yml | 3 + ansible/vars/libvirt-go-xml/Debian-9.yml | 3 + ansible/vars/libvirt-go-xml/Fedora-25.yml | 3 + ansible/vars/libvirt-go-xml/Fedora-26.yml | 3 + ansible/vars/libvirt-go-xml/Fedora-Rawhide.yml | 3 + ansible/vars/libvirt-go-xml/FreeBSD-11.yml | 3 + ansible/vars/libvirt-go-xml/Ubuntu-16.yml | 3 + ansible/vars/libvirt-go/CentOS-7.yml | 7 + ansible/vars/libvirt-go/Debian-8.yml | 7 + ansible/vars/libvirt-go/Debian-9.yml | 7 + ansible/vars/libvirt-go/Fedora-25.yml | 7 + ansible/vars/libvirt-go/Fedora-26.yml | 7 + ansible/vars/libvirt-go/Fedora-Rawhide.yml | 7 + ansible/vars/libvirt-go/FreeBSD-11.yml | 6 + ansible/vars/libvirt-go/Ubuntu-16.yml | 7 + ansible/vars/libvirt-perl/CentOS-6.yml | 7 + ansible/vars/libvirt-perl/CentOS-7.yml | 8 + ansible/vars/libvirt-perl/Debian-8.yml | 7 + ansible/vars/libvirt-perl/Debian-9.yml | 7 + ansible/vars/libvirt-perl/Fedora-25.yml | 8 + ansible/vars/libvirt-perl/Fedora-26.yml | 8 + ansible/vars/libvirt-perl/Fedora-Rawhide.yml | 8 + ansible/vars/libvirt-perl/FreeBSD-11.yml | 8 + ansible/vars/libvirt-perl/Ubuntu-14.yml | 6 + ansible/vars/libvirt-perl/Ubuntu-16.yml | 7 + ansible/vars/libvirt-python/CentOS-6.yml | 8 + ansible/vars/libvirt-python/CentOS-7.yml | 8 + ansible/vars/libvirt-python/Debian-8.yml | 8 + ansible/vars/libvirt-python/Debian-9.yml | 8 + ansible/vars/libvirt-python/Fedora-25.yml | 11 + ansible/vars/libvirt-python/Fedora-26.yml | 11 + ansible/vars/libvirt-python/Fedora-Rawhide.yml | 11 + ansible/vars/libvirt-python/FreeBSD-11.yml | 7 + ansible/vars/libvirt-python/Ubuntu-14.yml | 8 + ansible/vars/libvirt-python/Ubuntu-16.yml | 8 + ansible/vars/libvirt-sandbox/CentOS-7.yml | 25 +++ ansible/vars/libvirt-sandbox/Debian-9.yml | 22 ++ ansible/vars/libvirt-sandbox/Fedora-25.yml | 26 +++ ansible/vars/libvirt-sandbox/Fedora-26.yml | 26 +++ ansible/vars/libvirt-sandbox/Fedora-Rawhide.yml | 26 +++ ansible/vars/libvirt-sandbox/Ubuntu-16.yml | 22 ++ ansible/vars/libvirt-tck/Debian-8.yml | 22 ++ ansible/vars/libvirt-tck/Debian-9.yml | 22 ++ ansible/vars/libvirt-tck/Fedora-25.yml | 22 ++ ansible/vars/libvirt-tck/Fedora-26.yml | 22 ++ ansible/vars/libvirt-tck/Fedora-Rawhide.yml | 22 ++ ansible/vars/libvirt-tck/FreeBSD-11.yml | 20 ++ ansible/vars/libvirt-tck/Ubuntu-14.yml | 21 ++ ansible/vars/libvirt-tck/Ubuntu-16.yml | 22 ++ ansible/vars/libvirt/CentOS-6.yml | 119 +++++++++++ ansible/vars/libvirt/CentOS-7.yml | 121 +++++++++++ ansible/vars/libvirt/Debian-8.yml | 124 +++++++++++ ansible/vars/libvirt/Debian-9.yml | 126 ++++++++++++ ansible/vars/libvirt/Fedora-25.yml | 125 +++++++++++ ansible/vars/libvirt/Fedora-26.yml | 124 +++++++++++ ansible/vars/libvirt/Fedora-Rawhide.yml | 148 +++++++++++++ ansible/vars/libvirt/FreeBSD-11.yml | 98 +++++++++ ansible/vars/libvirt/Ubuntu-12.yml | 122 +++++++++++ ansible/vars/libvirt/Ubuntu-14.yml | 125 +++++++++++ ansible/vars/libvirt/Ubuntu-16.yml | 128 ++++++++++++ ansible/vars/osinfo-db-tools/CentOS-7.yml | 8 + ansible/vars/osinfo-db-tools/Debian-8.yml | 8 + ansible/vars/osinfo-db-tools/Debian-9.yml | 8 + ansible/vars/osinfo-db-tools/Fedora-25.yml | 8 + ansible/vars/osinfo-db-tools/Fedora-26.yml | 8 + ansible/vars/osinfo-db-tools/Fedora-Rawhide.yml | 8 + ansible/vars/osinfo-db-tools/FreeBSD-11.yml | 8 + ansible/vars/osinfo-db-tools/Ubuntu-14.yml | 8 + ansible/vars/osinfo-db-tools/Ubuntu-16.yml | 8 + ansible/vars/osinfo-db/CentOS-7.yml | 7 + ansible/vars/osinfo-db/Debian-9.yml | 7 + ansible/vars/osinfo-db/Fedora-25.yml | 7 + ansible/vars/osinfo-db/Fedora-26.yml | 7 + ansible/vars/osinfo-db/Fedora-Rawhide.yml | 7 + ansible/vars/osinfo-db/FreeBSD-11.yml | 7 + ansible/vars/virt-manager/CentOS-7.yml | 12 ++ ansible/vars/virt-manager/Debian-8.yml | 12 ++ ansible/vars/virt-manager/Debian-9.yml | 12 ++ ansible/vars/virt-manager/Fedora-25.yml | 12 ++ ansible/vars/virt-manager/Fedora-26.yml | 12 ++ ansible/vars/virt-manager/Fedora-Rawhide.yml | 12 ++ ansible/vars/virt-manager/FreeBSD-11.yml | 11 + ansible/vars/virt-manager/Ubuntu-14.yml | 12 ++ ansible/vars/virt-manager/Ubuntu-16.yml | 12 ++ ansible/vars/virt-viewer/CentOS-7.yml | 20 ++ ansible/vars/virt-viewer/Debian-8.yml | 18 ++ ansible/vars/virt-viewer/Debian-9.yml | 20 ++ ansible/vars/virt-viewer/Fedora-25.yml | 20 ++ ansible/vars/virt-viewer/Fedora-26.yml | 20 ++ ansible/vars/virt-viewer/Fedora-Rawhide.yml | 20 ++ ansible/vars/virt-viewer/FreeBSD-11.yml | 18 ++ ansible/vars/virt-viewer/Ubuntu-14.yml | 16 ++ ansible/vars/virt-viewer/Ubuntu-16.yml | 18 ++ 181 files changed, 4230 insertions(+) create mode 100644 ansible/.gitignore create mode 100644 ansible/Makefile create mode 100644 ansible/README.markdown create mode 100644 ansible/ansible.cfg create mode 100644 ansible/bootstrap.yml create mode 100644 ansible/group_vars/all/main.yml create mode 100644 ansible/host_vars/libvirt-centos-6/main.yml create mode 100644 ansible/host_vars/libvirt-centos-6/vault.yml create mode 100644 ansible/host_vars/libvirt-centos-7/main.yml create mode 100644 ansible/host_vars/libvirt-centos-7/vault.yml create mode 100644 ansible/host_vars/libvirt-debian-8/main.yml create mode 100644 ansible/host_vars/libvirt-debian-8/vault.yml create mode 100644 ansible/host_vars/libvirt-debian-9/main.yml create mode 100644 ansible/host_vars/libvirt-debian-9/vault.yml create mode 100644 ansible/host_vars/libvirt-fedora-25/main.yml create mode 100644 ansible/host_vars/libvirt-fedora-25/vault.yml create mode 100644 ansible/host_vars/libvirt-fedora-26/main.yml create mode 100644 ansible/host_vars/libvirt-fedora-26/vault.yml create mode 100644 ansible/host_vars/libvirt-fedora-rawhide/main.yml create mode 100644 ansible/host_vars/libvirt-fedora-rawhide/vault.yml create mode 100644 ansible/host_vars/libvirt-freebsd-11/main.yml create mode 100644 ansible/host_vars/libvirt-freebsd-11/vault.yml create mode 100644 ansible/host_vars/libvirt-ubuntu-12/main.yml create mode 100644 ansible/host_vars/libvirt-ubuntu-12/vault.yml create mode 100644 ansible/host_vars/libvirt-ubuntu-14/main.yml create mode 100644 ansible/host_vars/libvirt-ubuntu-14/vault.yml create mode 100644 ansible/host_vars/libvirt-ubuntu-16/main.yml create mode 100644 ansible/host_vars/libvirt-ubuntu-16/vault.yml create mode 100644 ansible/inventory create mode 100644 ansible/mappings/commands.yml create mode 100644 ansible/mappings/libraries.yml create mode 100644 ansible/mappings/misc.yml create mode 100644 ansible/mappings/perl.yml create mode 100644 ansible/mappings/python.yml create mode 100644 ansible/site.yml create mode 100644 ansible/tasks/base.yml create mode 100644 ansible/tasks/bootstrap.yml create mode 100644 ansible/tasks/build.yml create mode 100644 ansible/tasks/compat.yml create mode 100644 ansible/tasks/facts.yml create mode 100644 ansible/tasks/jenkins.yml create mode 100644 ansible/tasks/packages.yml create mode 100644 ansible/templates/jenkins.service.j2 create mode 100644 ansible/vars/base/CentOS-6.yml create mode 100644 ansible/vars/base/CentOS-7.yml create mode 100644 ansible/vars/base/Debian-8.yml create mode 100644 ansible/vars/base/Debian-9.yml create mode 100644 ansible/vars/base/Fedora-25.yml create mode 100644 ansible/vars/base/Fedora-26.yml create mode 100644 ansible/vars/base/Fedora-Rawhide.yml create mode 100644 ansible/vars/base/FreeBSD-11.yml create mode 100644 ansible/vars/base/Ubuntu-12.yml create mode 100644 ansible/vars/base/Ubuntu-14.yml create mode 100644 ansible/vars/base/Ubuntu-16.yml create mode 100644 ansible/vars/jenkins/CentOS-6.yml create mode 100644 ansible/vars/jenkins/CentOS-7.yml create mode 100644 ansible/vars/jenkins/Debian-8.yml create mode 100644 ansible/vars/jenkins/Debian-9.yml create mode 100644 ansible/vars/jenkins/Fedora-25.yml create mode 100644 ansible/vars/jenkins/Fedora-26.yml create mode 100644 ansible/vars/jenkins/Fedora-Rawhide.yml create mode 100644 ansible/vars/jenkins/FreeBSD-11.yml create mode 100644 ansible/vars/jenkins/Ubuntu-12.yml create mode 100644 ansible/vars/jenkins/Ubuntu-14.yml create mode 100644 ansible/vars/jenkins/Ubuntu-16.yml create mode 100644 ansible/vars/libosinfo/CentOS-7.yml create mode 100644 ansible/vars/libosinfo/Debian-8.yml create mode 100644 ansible/vars/libosinfo/Debian-9.yml create mode 100644 ansible/vars/libosinfo/Fedora-25.yml create mode 100644 ansible/vars/libosinfo/Fedora-26.yml create mode 100644 ansible/vars/libosinfo/Fedora-Rawhide.yml create mode 100644 ansible/vars/libosinfo/FreeBSD-11.yml create mode 100644 ansible/vars/libosinfo/Ubuntu-14.yml create mode 100644 ansible/vars/libosinfo/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt-cim/CentOS-6.yml create mode 100644 ansible/vars/libvirt-cim/CentOS-7.yml create mode 100644 ansible/vars/libvirt-cim/Fedora-25.yml create mode 100644 ansible/vars/libvirt-cim/Fedora-26.yml create mode 100644 ansible/vars/libvirt-cim/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-glib/CentOS-7.yml create mode 100644 ansible/vars/libvirt-glib/Debian-8.yml create mode 100644 ansible/vars/libvirt-glib/Debian-9.yml create mode 100644 ansible/vars/libvirt-glib/Fedora-25.yml create mode 100644 ansible/vars/libvirt-glib/Fedora-26.yml create mode 100644 ansible/vars/libvirt-glib/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-glib/FreeBSD-11.yml create mode 100644 ansible/vars/libvirt-glib/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt-go-xml/CentOS-7.yml create mode 100644 ansible/vars/libvirt-go-xml/Debian-8.yml create mode 100644 ansible/vars/libvirt-go-xml/Debian-9.yml create mode 100644 ansible/vars/libvirt-go-xml/Fedora-25.yml create mode 100644 ansible/vars/libvirt-go-xml/Fedora-26.yml create mode 100644 ansible/vars/libvirt-go-xml/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-go-xml/FreeBSD-11.yml create mode 100644 ansible/vars/libvirt-go-xml/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt-go/CentOS-7.yml create mode 100644 ansible/vars/libvirt-go/Debian-8.yml create mode 100644 ansible/vars/libvirt-go/Debian-9.yml create mode 100644 ansible/vars/libvirt-go/Fedora-25.yml create mode 100644 ansible/vars/libvirt-go/Fedora-26.yml create mode 100644 ansible/vars/libvirt-go/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-go/FreeBSD-11.yml create mode 100644 ansible/vars/libvirt-go/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt-perl/CentOS-6.yml create mode 100644 ansible/vars/libvirt-perl/CentOS-7.yml create mode 100644 ansible/vars/libvirt-perl/Debian-8.yml create mode 100644 ansible/vars/libvirt-perl/Debian-9.yml create mode 100644 ansible/vars/libvirt-perl/Fedora-25.yml create mode 100644 ansible/vars/libvirt-perl/Fedora-26.yml create mode 100644 ansible/vars/libvirt-perl/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-perl/FreeBSD-11.yml create mode 100644 ansible/vars/libvirt-perl/Ubuntu-14.yml create mode 100644 ansible/vars/libvirt-perl/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt-python/CentOS-6.yml create mode 100644 ansible/vars/libvirt-python/CentOS-7.yml create mode 100644 ansible/vars/libvirt-python/Debian-8.yml create mode 100644 ansible/vars/libvirt-python/Debian-9.yml create mode 100644 ansible/vars/libvirt-python/Fedora-25.yml create mode 100644 ansible/vars/libvirt-python/Fedora-26.yml create mode 100644 ansible/vars/libvirt-python/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-python/FreeBSD-11.yml create mode 100644 ansible/vars/libvirt-python/Ubuntu-14.yml create mode 100644 ansible/vars/libvirt-python/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt-sandbox/CentOS-7.yml create mode 100644 ansible/vars/libvirt-sandbox/Debian-9.yml create mode 100644 ansible/vars/libvirt-sandbox/Fedora-25.yml create mode 100644 ansible/vars/libvirt-sandbox/Fedora-26.yml create mode 100644 ansible/vars/libvirt-sandbox/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-sandbox/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt-tck/Debian-8.yml create mode 100644 ansible/vars/libvirt-tck/Debian-9.yml create mode 100644 ansible/vars/libvirt-tck/Fedora-25.yml create mode 100644 ansible/vars/libvirt-tck/Fedora-26.yml create mode 100644 ansible/vars/libvirt-tck/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt-tck/FreeBSD-11.yml create mode 100644 ansible/vars/libvirt-tck/Ubuntu-14.yml create mode 100644 ansible/vars/libvirt-tck/Ubuntu-16.yml create mode 100644 ansible/vars/libvirt/CentOS-6.yml create mode 100644 ansible/vars/libvirt/CentOS-7.yml create mode 100644 ansible/vars/libvirt/Debian-8.yml create mode 100644 ansible/vars/libvirt/Debian-9.yml create mode 100644 ansible/vars/libvirt/Fedora-25.yml create mode 100644 ansible/vars/libvirt/Fedora-26.yml create mode 100644 ansible/vars/libvirt/Fedora-Rawhide.yml create mode 100644 ansible/vars/libvirt/FreeBSD-11.yml create mode 100644 ansible/vars/libvirt/Ubuntu-12.yml create mode 100644 ansible/vars/libvirt/Ubuntu-14.yml create mode 100644 ansible/vars/libvirt/Ubuntu-16.yml create mode 100644 ansible/vars/osinfo-db-tools/CentOS-7.yml create mode 100644 ansible/vars/osinfo-db-tools/Debian-8.yml create mode 100644 ansible/vars/osinfo-db-tools/Debian-9.yml create mode 100644 ansible/vars/osinfo-db-tools/Fedora-25.yml create mode 100644 ansible/vars/osinfo-db-tools/Fedora-26.yml create mode 100644 ansible/vars/osinfo-db-tools/Fedora-Rawhide.yml create mode 100644 ansible/vars/osinfo-db-tools/FreeBSD-11.yml create mode 100644 ansible/vars/osinfo-db-tools/Ubuntu-14.yml create mode 100644 ansible/vars/osinfo-db-tools/Ubuntu-16.yml create mode 100644 ansible/vars/osinfo-db/CentOS-7.yml create mode 100644 ansible/vars/osinfo-db/Debian-9.yml create mode 100644 ansible/vars/osinfo-db/Fedora-25.yml create mode 100644 ansible/vars/osinfo-db/Fedora-26.yml create mode 100644 ansible/vars/osinfo-db/Fedora-Rawhide.yml create mode 100644 ansible/vars/osinfo-db/FreeBSD-11.yml create mode 100644 ansible/vars/virt-manager/CentOS-7.yml create mode 100644 ansible/vars/virt-manager/Debian-8.yml create mode 100644 ansible/vars/virt-manager/Debian-9.yml create mode 100644 ansible/vars/virt-manager/Fedora-25.yml create mode 100644 ansible/vars/virt-manager/Fedora-26.yml create mode 100644 ansible/vars/virt-manager/Fedora-Rawhide.yml create mode 100644 ansible/vars/virt-manager/FreeBSD-11.yml create mode 100644 ansible/vars/virt-manager/Ubuntu-14.yml create mode 100644 ansible/vars/virt-manager/Ubuntu-16.yml create mode 100644 ansible/vars/virt-viewer/CentOS-7.yml create mode 100644 ansible/vars/virt-viewer/Debian-8.yml create mode 100644 ansible/vars/virt-viewer/Debian-9.yml create mode 100644 ansible/vars/virt-viewer/Fedora-25.yml create mode 100644 ansible/vars/virt-viewer/Fedora-26.yml create mode 100644 ansible/vars/virt-viewer/Fedora-Rawhide.yml create mode 100644 ansible/vars/virt-viewer/FreeBSD-11.yml create mode 100644 ansible/vars/virt-viewer/Ubuntu-14.yml create mode 100644 ansible/vars/virt-viewer/Ubuntu-16.yml -- 2.13.6

2 26