- Devel - libvirt List Archives

[libvirt] [PATCH 0/2] test: Implement virConnectListAllNodeDevices
by Cole Robinson 06 Mar '18

06 Mar '18

First patch is prep work to teach generic nodedev code not to access host info for the test driver, which is needed to give correct results for patch 2 Cole Robinson (2): conf: nodedev: Don't refresh host caps in testdriver test: Implement virConnectListAllNodeDevices src/conf/node_device_conf.c | 3 +++ src/conf/node_device_conf.h | 1 + src/test/test_driver.c | 15 +++++++++++++++ 3 files changed, 19 insertions(+) -- 2.14.3

3 7

[libvirt] [PATCH 0/7] tests: qemu: Do proper status XML testing
by Peter Krempa 06 Mar '18

06 Mar '18

The 'fake' status XML testing we were doing until now was terrible and would not catch most of the problems. Also the code was too complicated. This adds a way simpler approach which actually works. (for the small price of adding a lot of test data lines) Peter Krempa (7): tests: qemuxml2xml: Rename testInfoFree to testInfoClear tests: qemuxml2xml: Remove testing with allowed format detection tests: qemuxml2xml: Add proper domain status XML testing tests: qemuxml2xml: Remove fake status XML testing tests: util: Remove callback from testCompareDomXML2XMLFiles tests: qemuxml2xml: Add modern example of status XML to the test tests: qemuxml2xml: Add status XML with outgoing migration with NBD tests/Makefile.am | 1 + tests/genericxml2xmltest.c | 2 +- tests/lxcxml2xmltest.c | 2 +- tests/qemustatusxml2xmldata/blockjob-mirror-in.xml | 96 +++++ .../qemustatusxml2xmldata/blockjob-mirror-out.xml | 96 +++++ .../qemustatusxml2xmldata/migration-out-nbd-in.xml | 449 +++++++++++++++++++++ .../migration-out-nbd-out.xml | 449 +++++++++++++++++++++ tests/qemustatusxml2xmldata/modern-in.xml | 443 ++++++++++++++++++++ tests/qemustatusxml2xmldata/modern-out.xml | 443 ++++++++++++++++++++ tests/qemustatusxml2xmldata/vcpus-multi-in.xml | 343 ++++++++++++++++ tests/qemustatusxml2xmldata/vcpus-multi-out.xml | 343 ++++++++++++++++ .../qemuxml2argvdata/disk-drive-detect-zeroes.xml | 2 +- tests/qemuxml2argvdata/hugepages-memaccess.xml | 1 + tests/qemuxml2argvdata/hugepages-memaccess2.xml | 1 + tests/qemuxml2argvdata/hugepages-pages4.xml | 1 + tests/qemuxml2argvdata/hugepages-pages5.xml | 1 + tests/qemuxml2argvdata/hugepages-pages6.xml | 1 + .../memory-hotplug-nvdimm-access.xml | 1 + .../memory-hotplug-nvdimm-label.xml | 1 + tests/qemuxml2argvdata/memory-hotplug-nvdimm.xml | 1 + .../serial-tcp-tlsx509-chardev-notls.xml | 1 + .../aarch64-aavmf-virtio-mmio.xml | 1 + .../aarch64-virtio-pci-default.xml | 1 + .../aarch64-virtio-pci-manual-addresses.xml | 1 + tests/qemuxml2xmloutdata/autoindex.xml | 1 + tests/qemuxml2xmloutdata/balloon-device-auto.xml | 1 + tests/qemuxml2xmloutdata/balloon-device-period.xml | 1 + .../bios-nvram-os-interleave.xml | 1 + tests/qemuxml2xmloutdata/bios-nvram.xml | 1 + tests/qemuxml2xmloutdata/blkiotune-device.xml | 1 + tests/qemuxml2xmloutdata/blkiotune.xml | 1 + .../boot-menu-disable-with-timeout.xml | 1 + tests/qemuxml2xmloutdata/boot-menu-disable.xml | 1 + .../boot-menu-enable-with-timeout.xml | 1 + tests/qemuxml2xmloutdata/boot-multi.xml | 1 + tests/qemuxml2xmloutdata/boot-order.xml | 2 + tests/qemuxml2xmloutdata/channel-guestfwd.xml | 1 + tests/qemuxml2xmloutdata/channel-virtio-auto.xml | 1 + .../channel-virtio-state-active.xml | 1 + .../channel-virtio-state-inactive.xml | 1 + tests/qemuxml2xmloutdata/channel-virtio.xml | 1 + tests/qemuxml2xmloutdata/clock-catchup.xml | 1 + tests/qemuxml2xmloutdata/console-compat-auto.xml | 1 + tests/qemuxml2xmloutdata/console-virtio-many.xml | 1 + tests/qemuxml2xmloutdata/console-virtio.xml | 1 + .../cpu-host-passthrough-features.xml | 1 + tests/qemuxml2xmloutdata/cputune-iothreads.xml | 1 + .../cputune-iothreadsched-zeropriority.xml | 1 + tests/qemuxml2xmloutdata/cputune-iothreadsched.xml | 1 + tests/qemuxml2xmloutdata/cputune-zero-shares.xml | 1 + tests/qemuxml2xmloutdata/cputune.xml | 1 + .../qemuxml2xmloutdata/disk-drive-copy-on-read.xml | 2 +- tests/qemuxml2xmloutdata/disk-drive-discard.xml | 2 +- tests/qemuxml2xmloutdata/disk-mirror-active.xml | 5 + tests/qemuxml2xmloutdata/disk-mirror-inactive.xml | 4 + .../disk-mirror-old-inactive.xml | 4 + tests/qemuxml2xmloutdata/disk-mirror-old.xml | 7 +- tests/qemuxml2xmloutdata/disk-scsi-device-auto.xml | 2 + tests/qemuxml2xmloutdata/disk-scsi-device.xml | 2 + tests/qemuxml2xmloutdata/disk-scsi-disk-vpd.xml | 2 + .../disk-scsi-lun-passthrough-sgio.xml | 2 + tests/qemuxml2xmloutdata/disk-scsi-megasas.xml | 2 + tests/qemuxml2xmloutdata/disk-scsi-mptsas1068.xml | 2 + tests/qemuxml2xmloutdata/disk-scsi-virtio-scsi.xml | 2 + tests/qemuxml2xmloutdata/disk-scsi-vscsi.xml | 2 + tests/qemuxml2xmloutdata/disk-serial.xml | 3 + tests/qemuxml2xmloutdata/disk-source-pool-mode.xml | 4 + tests/qemuxml2xmloutdata/disk-source-pool.xml | 2 + tests/qemuxml2xmloutdata/disk-usb-device.xml | 2 + .../disk-virtio-scsi-cmd_per_lun.xml | 1 + .../disk-virtio-scsi-ioeventfd.xml | 1 + .../disk-virtio-scsi-max_sectors.xml | 1 + .../disk-virtio-scsi-num_queues.xml | 1 + .../qemuxml2xmloutdata/graphics-listen-network.xml | 1 + .../graphics-listen-network2.xml | 1 + .../graphics-spice-compression.xml | 1 + .../qemuxml2xmloutdata/graphics-spice-qxl-vga.xml | 1 + tests/qemuxml2xmloutdata/graphics-spice.xml | 1 + .../hostdev-scsi-autogen-address.xml | 1 + .../qemuxml2xmloutdata/hostdev-scsi-large-unit.xml | 1 + .../hostdev-scsi-lsi-iscsi-auth.xml | 1 + .../qemuxml2xmloutdata/hostdev-scsi-lsi-iscsi.xml | 1 + tests/qemuxml2xmloutdata/hostdev-scsi-lsi.xml | 1 + tests/qemuxml2xmloutdata/hostdev-scsi-rawio.xml | 1 + tests/qemuxml2xmloutdata/hostdev-scsi-readonly.xml | 1 + tests/qemuxml2xmloutdata/hostdev-scsi-sgio.xml | 1 + .../qemuxml2xmloutdata/hostdev-scsi-shareable.xml | 1 + .../hostdev-scsi-vhost-scsi-ccw.xml | 1 + .../hostdev-scsi-vhost-scsi-pci.xml | 1 + .../hostdev-scsi-virtio-iscsi-auth.xml | 1 + .../hostdev-scsi-virtio-iscsi.xml | 1 + .../hostdev-scsi-virtio-scsi.xml | 1 + tests/qemuxml2xmloutdata/hostdev-vfio.xml | 1 + tests/qemuxml2xmloutdata/hugepages-pages.xml | 1 + tests/qemuxml2xmloutdata/hugepages-pages2.xml | 1 + tests/qemuxml2xmloutdata/hugepages-pages3.xml | 1 + tests/qemuxml2xmloutdata/hugepages-shared.xml | 1 + tests/qemuxml2xmloutdata/hugepages.xml | 1 + tests/qemuxml2xmloutdata/lease.xml | 2 + .../machine-loadparm-multiple-disks-nets-s390.xml | 2 + tests/qemuxml2xmloutdata/memory-hotplug-dimm.xml | 1 + tests/qemuxml2xmloutdata/memory-hotplug.xml | 1 + tests/qemuxml2xmloutdata/memtune-unlimited.xml | 1 + tests/qemuxml2xmloutdata/memtune.xml | 1 + tests/qemuxml2xmloutdata/metadata-duplicate.xml | 1 + tests/qemuxml2xmloutdata/metadata.xml | 1 + tests/qemuxml2xmloutdata/minimal.xml | 1 + tests/qemuxml2xmloutdata/net-hostdev-vfio.xml | 1 + tests/qemuxml2xmloutdata/net-hostdev.xml | 1 + tests/qemuxml2xmloutdata/net-midonet.xml | 1 + tests/qemuxml2xmloutdata/net-openvswitch.xml | 1 + tests/qemuxml2xmloutdata/net-udp.xml | 1 + tests/qemuxml2xmloutdata/net-virtio-device.xml | 1 + .../net-virtio-disable-offloads.xml | 1 + .../net-virtio-network-portgroup.xml | 1 + .../net-virtio-rxtxqueuesize.xml | 1 + .../numad-auto-memory-vcpu-cpuset.xml | 1 + ...ad-auto-memory-vcpu-no-cpuset-and-placement.xml | 1 + .../numad-auto-vcpu-no-numatune.xml | 1 + .../numad-static-vcpu-no-numatune.xml | 1 + tests/qemuxml2xmloutdata/panic-isa.xml | 1 + tests/qemuxml2xmloutdata/panic-no-address.xml | 1 + tests/qemuxml2xmloutdata/panic.xml | 1 + tests/qemuxml2xmloutdata/pci-rom.xml | 1 + .../qemuxml2xmloutdata/pci-serial-dev-chardev.xml | 1 + tests/qemuxml2xmloutdata/pcie-expander-bus.xml | 1 + tests/qemuxml2xmloutdata/pcie-root-port.xml | 1 + .../pcie-switch-downstream-port.xml | 1 + .../pcie-switch-upstream-port.xml | 1 + tests/qemuxml2xmloutdata/pcihole64-q35.xml | 1 + tests/qemuxml2xmloutdata/q35-pcie-autoadd.xml | 1 + tests/qemuxml2xmloutdata/q35-pcie.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2-multi.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2-reorder.xml | 1 + tests/qemuxml2xmloutdata/q35-usb2.xml | 1 + tests/qemuxml2xmloutdata/q35-virtio-pci.xml | 1 + tests/qemuxml2xmloutdata/q35.xml | 1 + tests/qemuxml2xmloutdata/seclabel-dac-none.xml | 1 + .../seclabel-device-multiple.xml | 1 + .../seclabel-dynamic-baselabel.xml | 1 + .../seclabel-dynamic-labelskip.xml | 1 + tests/qemuxml2xmloutdata/seclabel-dynamic-none.xml | 1 + .../seclabel-dynamic-override.xml | 2 + .../seclabel-dynamic-relabel.xml | 1 + tests/qemuxml2xmloutdata/seclabel-none.xml | 1 + .../seclabel-static-labelskip.xml | 1 + tests/qemuxml2xmloutdata/seclabel-static.xml | 1 + .../serial-spiceport-nospice.xml | 1 + tests/qemuxml2xmloutdata/serial-spiceport.xml | 1 + .../qemuxml2xmloutdata/serial-target-port-auto.xml | 1 + .../serial-tcp-tlsx509-chardev.xml | 1 + tests/qemuxml2xmloutdata/smbios-multiple-type2.xml | 1 + tests/qemuxml2xmloutdata/smbios.xml | 1 + tests/qemuxml2xmloutdata/sound-device.xml | 1 + tests/qemuxml2xmloutdata/video-qxl-heads.xml | 1 + tests/qemuxml2xmloutdata/video-qxl-noheads.xml | 1 + tests/qemuxml2xmloutdata/vmcoreinfo.xml | 1 + tests/qemuxml2xmltest.c | 283 ++++--------- tests/testutils.c | 8 +- tests/testutils.h | 5 - 160 files changed, 2926 insertions(+), 221 deletions(-) create mode 100644 tests/qemustatusxml2xmldata/blockjob-mirror-in.xml create mode 100644 tests/qemustatusxml2xmldata/blockjob-mirror-out.xml create mode 100644 tests/qemustatusxml2xmldata/migration-out-nbd-in.xml create mode 100644 tests/qemustatusxml2xmldata/migration-out-nbd-out.xml create mode 100644 tests/qemustatusxml2xmldata/modern-in.xml create mode 100644 tests/qemustatusxml2xmldata/modern-out.xml create mode 100644 tests/qemustatusxml2xmldata/vcpus-multi-in.xml create mode 100644 tests/qemustatusxml2xmldata/vcpus-multi-out.xml -- 2.16.2

2 12

[libvirt] [PATCH 0/4] Use and prefer change-vnc-password command
by John Ferlan 06 Mar '18

06 Mar '18

While investigating something else - 'change' QMP command for the cdrom/floppy code, I noted the QMP schema lists the change command as being deprecated for use with cdrom/floppy and changing the VNC password. Further digging found that the existing set_password QMP command would make the same call to change the password (qemu API vnc_display_password) as long as "keep" was defined for connected (which must be true for VNC). So altered the code to use the newer command if available. John Ferlan (4): qemu: Alter current VNC set password to be legacy qemu: Clean up formatting in virQEMUCapsCommands qemu: Add change-vnc-password capability qemu: Add support for change-vnc-password src/qemu/qemu_capabilities.c | 8 +++-- src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_hotplug.c | 12 ++++++-- src/qemu/qemu_monitor.c | 21 +++++++++++-- src/qemu/qemu_monitor.h | 2 ++ src/qemu/qemu_monitor_json.c | 34 ++++++++++++++++++++-- src/qemu/qemu_monitor_json.h | 2 ++ tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 1 + .../caps_2.10.0-gicv2.aarch64.xml | 1 + .../caps_2.10.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 1 + .../caps_2.6.0-gicv2.aarch64.xml | 1 + .../caps_2.6.0-gicv3.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 1 + tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 1 + tests/qemumonitorjsontest.c | 2 ++ 34 files changed, 98 insertions(+), 10 deletions(-) -- 2.13.6

2 6

[libvirt] [PATCH 0/7] Some stylistic cleanups
by Ján Tomko 06 Mar '18

06 Mar '18

Ján Tomko (7): maint: use parentheses after if nwfilter: remove pointless assignment openvz: pass sizeof to snprintf virsh-edit: remove unreachable break remote: remove unused label virsh: use logical or for boolean values Simplify some conditions src/conf/domain_conf.c | 2 +- src/nwfilter/nwfilter_gentech_driver.c | 1 - src/openvz/openvz_driver.c | 3 +-- src/qemu/qemu_domain.c | 2 +- src/qemu/qemu_migration.c | 2 +- src/remote/remote_driver.c | 3 +-- tools/virsh-domain.c | 2 +- tools/virsh-edit.c | 1 - 8 files changed, 6 insertions(+), 10 deletions(-) -- 2.16.1

3 15

[libvirt] [PATCH perl 0/2] Fix missing methods in Perl binding
by Daniel P. Berrangé 06 Mar '18

06 Mar '18

Daniel P. Berrangé (2): Add missing define_nwfilter and define_secret APIs Fix docs for Sys::Virt::NWFilter undefine method Changes | 3 ++- lib/Sys/Virt.pm | 32 ++++++++++++++++++++++++++++++++ lib/Sys/Virt/NWFilter.pm | 6 ++---- 3 files changed, 36 insertions(+), 5 deletions(-) -- 2.14.3

2 5

[libvirt] [tck PATCH v3 0/2] new NetworkHelper function get_network_ip()
by Laine Stump 06 Mar '18

06 Mar '18

New for V3: added in the NetAddr::IP dependency to Build.PL, and added a prequel patch that removes all tabs from that file. Laine Stump (2): Remove tab characters from Build.PL new NetworkHelper function get_network_ip() Build.PL | 105 +++++++++++++++++++------------------ lib/Sys/Virt/TCK/NetworkHelpers.pm | 22 ++++++++ 2 files changed, 75 insertions(+), 52 deletions(-) -- 2.14.3

2 4

[libvirt] [Question]Libvirt doesn't care about qemu monitor event if fail to destroy qemu process
by Wuzongyong (Euler Dept) 06 Mar '18

06 Mar '18

Hi, We unregister qemu monitor after sending QEMU_PROCESS_EVENT_MONITOR_EOF to workerPool: static void qemuProcessHandleMonitorEOF(qemuMonitorPtr mon, virDomainObjPtr vm, void *opaque) { virQEMUDriverPtr driver = opaque; qemuDomainObjPrivatePtr priv; struct qemuProcessEvent *processEvent; ... processEvent->eventType = QEMU_PROCESS_EVENT_MONITOR_EOF; processEvent->vm = vm; virObjectRef(vm); if (virThreadPoolSendJob(driver->workerPool, 0, processEvent) < 0) { ignore_value(virObjectUnref(vm)); VIR_FREE(processEvent); goto cleanup; } /* We don't want this EOF handler to be called over and over while the * thread is waiting for a job. */ qemuMonitorUnregister(mon); ... } Then we handle QEMU_PROCESS_EVENT_MONITOR_EOF in processMonitorEOFEvent function: static void processMonitorEOFEvent(virQEMUDriverPtr driver, virDomainObjPtr vm) { ... if (qemuProcessBeginStopJob(driver, vm, QEMU_JOB_DESTROY, true) < 0) return; ... } Here, libvirt will show that the vm state is running all the time if qemuProcessBeginStopJob return -1 even though qemu may terminate or be killed later. So, may be we should re-register the monitor when qemuProcessBeginStopJob failed? Thanks, Zongyong Wu

3 10

[libvirt] [PATCH] tests: force use of "NORMAL" TLS priority in test suite
by Daniel P. Berrangé 06 Mar '18

06 Mar '18

When generating certificates we rely on GNUTLS' built-in default setup for the ciphers used in the certs. We then currently run with the distro specific TLS priority setup which can be much stronger, to the extent that the certificates we generate are considered untrustworthy. We don't care about the quality of the ciphers we use in the test suite, so just force the priority to "NORMAL" which should ensure our certs are accepted by GNUTLS. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- tests/virnettlscontexttest.c | 4 ++-- tests/virnettlssessiontest.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/virnettlscontexttest.c b/tests/virnettlscontexttest.c index 089c10e964..86647f3014 100644 --- a/tests/virnettlscontexttest.c +++ b/tests/virnettlscontexttest.c @@ -72,7 +72,7 @@ static int testTLSContextInit(const void *opaque) data->crt, KEYFILE, NULL, - NULL, + "NORMAL", true, true); } else { @@ -80,7 +80,7 @@ static int testTLSContextInit(const void *opaque) NULL, data->crt, KEYFILE, - NULL, + "NORMAL", true, true); } diff --git a/tests/virnettlssessiontest.c b/tests/virnettlssessiontest.c index 6d639e5b16..7e85607181 100644 --- a/tests/virnettlssessiontest.c +++ b/tests/virnettlssessiontest.c @@ -113,7 +113,7 @@ static int testTLSSessionInit(const void *opaque) data->servercrt, KEYFILE, data->wildcards, - NULL, + "NORMAL", false, true); @@ -121,7 +121,7 @@ static int testTLSSessionInit(const void *opaque) NULL, data->clientcrt, KEYFILE, - NULL, + "NORMAL", false, true); -- 2.14.3

1 1

[libvirt] [tck PATCH v2 0/4] set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test
by Laine Stump 06 Mar '18

06 Mar '18

We've recently discovered two separate bugs that caused libvirt's "DHCP Snooping" feature to not work: https://bugzilla.redhat.com/show_bug.cgi?id=1529338 - libvirt regression https://bugzilla.redhat.com/show_bug.cgi?id=1547237 - libpcap regression Since we didn't have any test suite covering that code, we had the embarrassment of learning of it from someone else's QE (RHV/oVirt QE at Red Hat). This series adds the necessary stuff to the test domain config of libvirt-tck's "no-ip-spoofing" test to exercise the DHCPSnoop thread. (There may be a much better way of dealing with a hash-inside-a-hash; I am an imbecile at perl, and arrived at this code by trial, error, and google searches). Laine Stump (4): nwfilter tests: auto-add test appliance ssh key to known_hosts on host new NetworkHelper function get_network_ip() set CTRL_IP_LEARNING and DHCPSERVER in filter during no-ip-spoofing test nwfilter tests: remove all hardcoded references to 192.168.122 network lib/Sys/Virt/TCK.pm | 11 ++++++++--- lib/Sys/Virt/TCK/DomainBuilder.pm | 8 +++++++- lib/Sys/Virt/TCK/NetworkHelpers.pm | 22 ++++++++++++++++++++++ scripts/nwfilter/210-no-mac-spoofing.t | 12 ++++++++---- scripts/nwfilter/220-no-ip-spoofing.t | 26 +++++++++++++++++++++----- scripts/nwfilter/230-no-mac-broadcast.t | 11 ++++++++--- scripts/nwfilter/240-no-arp-spoofing.t | 22 ++++++++++++++++------ 7 files changed, 90 insertions(+), 22 deletions(-) -- 2.14.3

2 12

[libvirt] [PATCH] qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive
by Erik Skultety 06 Mar '18

06 Mar '18

Fix this common typo and assign a value rather than implicitly type-casted comparison result. Introduced by commit b6a264e855. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- Pushed under the trivial rule. src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 96454c17c..9e715e7a0 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7919,7 +7919,7 @@ qemuDomainUpdateDeviceLive(virDomainObjPtr vm, break; case VIR_DOMAIN_DEVICE_GRAPHICS: - if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics) >= 0)) { + if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics)) >= 0) { oldDev.data.graphics = vm->def->graphics[idx]; if (virDomainDefCompatibleDevice(vm->def, dev, &oldDev) < 0) return -1; -- 2.13.6

2 1

[libvirt] [RFC PATCH v3 0/9] Add optional pSeries features
by Andrea Bolognani 06 Mar '18

06 Mar '18

Applies cleanly on top of 6722a32444db6335f2104e67d873199c76e5701e. Some of the patches are fairly big because of all the capabilities data being added and the subsequent test suite churn: I'm sending a redacted version to the list, the rest of the code can be grabbed from https://github.com/andreabolognani/libvirt/tree/pseries-caps RFC because the relevant QMP command has not been merged into QEMU yet. And there's still no documentation. Changes from [RFC v2]: * use qom-list-properties to probe availability; * test all features with a single XML file. Changes from [RFC v1]: * don't nest features inside a <pseries/> element; * implement all optional features. [RFC v2] https://www.redhat.com/archives/libvir-list/2018-February/msg00310.html [RFC v1] https://www.redhat.com/archives/libvir-list/2018-January/msg00779.html Andrea Bolognani (9): tests: Add capabilities data for QEMU 2.12 qemu: Add capability for qom-list-properties qemu: Prefer qom-list-properties to device-list-properties qemu: Add capabilities for optional pSeries features tests: Rename pseries-features-hpt test qemu: Implement the HTM pSeries feature qemu: Implement the SBBC pSeries feature qemu: Implement the CFPC pSeries feature qemu: Implement the IBS pSeries feature docs/schemas/domaincommon.rng | 30 + src/conf/domain_conf.c | 74 + src/conf/domain_conf.h | 15 + src/libvirt_private.syms | 2 + src/qemu/qemu_capabilities.c | 30 +- src/qemu/qemu_capabilities.h | 7 + src/qemu/qemu_command.c | 165 + src/qemu/qemu_domain.c | 28 + src/qemu/qemu_monitor.c | 5 +- src/qemu/qemu_monitor.h | 1 + src/qemu/qemu_monitor_json.c | 13 +- src/qemu/qemu_monitor_json.h | 3 +- .../qemucapabilitiesdata/caps_1.2.2.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_1.2.2.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_1.3.1.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_1.3.1.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_1.4.2.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_1.4.2.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_1.5.3.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_1.5.3.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_1.6.0.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_1.6.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_1.7.0.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_1.7.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.1.1.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_2.1.1.x86_64.xml | 2 +- .../caps_2.10.0-gicv2.aarch64.replies | 24 +- .../caps_2.10.0-gicv2.aarch64.xml | 2 +- .../caps_2.10.0-gicv3.aarch64.replies | 24 +- .../caps_2.10.0-gicv3.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.10.0.ppc64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.10.0.s390x.replies | 26 +- tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml | 2 +- .../caps_2.10.0.x86_64.replies | 30 +- tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml | 2 +- ...4.replies => caps_2.12.0-gicv2.aarch64.replies} | 3257 ++++++---- ...2.aarch64.xml => caps_2.12.0-gicv2.aarch64.xml} | 24 +- ...4.replies => caps_2.12.0-gicv3.aarch64.replies} | 3261 ++++++---- ...3.aarch64.xml => caps_2.12.0-gicv3.aarch64.xml} | 24 +- ...0.0.ppc64.replies => caps_2.12.0.ppc64.replies} | 6211 +++++++++++--------- ...caps_2.10.0.ppc64.xml => caps_2.12.0.ppc64.xml} | 991 ++-- ...0.x86_64.replies => caps_2.12.0.x86_64.replies} | 5393 ++++++++++------- ...ps_2.10.0.x86_64.xml => caps_2.12.0.x86_64.xml} | 455 +- .../qemucapabilitiesdata/caps_2.4.0.x86_64.replies | 20 +- tests/qemucapabilitiesdata/caps_2.4.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.5.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.5.0.x86_64.xml | 2 +- .../caps_2.6.0-gicv2.aarch64.replies | 24 +- .../caps_2.6.0-gicv2.aarch64.xml | 2 +- .../caps_2.6.0-gicv3.aarch64.replies | 24 +- .../caps_2.6.0-gicv3.aarch64.xml | 2 +- .../qemucapabilitiesdata/caps_2.6.0.ppc64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.6.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.6.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.7.0.s390x.replies | 22 +- tests/qemucapabilitiesdata/caps_2.7.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.7.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.7.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.8.0.s390x.replies | 26 +- tests/qemucapabilitiesdata/caps_2.8.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.8.0.x86_64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.8.0.x86_64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.ppc64.replies | 22 +- tests/qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.s390x.replies | 26 +- tests/qemucapabilitiesdata/caps_2.9.0.s390x.xml | 2 +- .../qemucapabilitiesdata/caps_2.9.0.x86_64.replies | 30 +- tests/qemucapabilitiesdata/caps_2.9.0.x86_64.xml | 2 +- tests/qemucapabilitiestest.c | 4 + .../pseries-features-invalid-machine.xml | 4 + ...ies-features-hpt.args => pseries-features.args} | 3 +- ...eries-features-hpt.xml => pseries-features.xml} | 4 + tests/qemuxml2argvtest.c | 8 +- tests/qemuxml2xmloutdata/pseries-features-hpt.xml | 1 - tests/qemuxml2xmloutdata/pseries-features.xml | 1 + tests/qemuxml2xmltest.c | 6 +- 78 files changed, 12668 insertions(+), 7972 deletions(-) copy tests/qemucapabilitiesdata/{caps_2.10.0-gicv2.aarch64.replies => caps_2.12.0-gicv2.aarch64.replies} (93%) copy tests/qemucapabilitiesdata/{caps_2.10.0-gicv2.aarch64.xml => caps_2.12.0-gicv2.aarch64.xml} (95%) copy tests/qemucapabilitiesdata/{caps_2.10.0-gicv2.aarch64.replies => caps_2.12.0-gicv3.aarch64.replies} (93%) copy tests/qemucapabilitiesdata/{caps_2.10.0-gicv3.aarch64.xml => caps_2.12.0-gicv3.aarch64.xml} (95%) copy tests/qemucapabilitiesdata/{caps_2.10.0.ppc64.replies => caps_2.12.0.ppc64.replies} (87%) copy tests/qemucapabilitiesdata/{caps_2.10.0.ppc64.xml => caps_2.12.0.ppc64.xml} (54%) copy tests/qemucapabilitiesdata/{caps_2.10.0.x86_64.replies => caps_2.12.0.x86_64.replies} (90%) copy tests/qemucapabilitiesdata/{caps_2.10.0.x86_64.xml => caps_2.12.0.x86_64.xml} (83%) rename tests/qemuxml2argvdata/{pseries-features-hpt.args => pseries-features.args} (78%) rename tests/qemuxml2argvdata/{pseries-features-hpt.xml => pseries-features.xml} (88%) delete mode 120000 tests/qemuxml2xmloutdata/pseries-features-hpt.xml create mode 120000 tests/qemuxml2xmloutdata/pseries-features.xml -- 2.14.3

2 12

[libvirt] fseeko broken by Fedora rawhide glibc / git master (ie future 2.28)
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

Fedora rawhide has just upgraded to the latest glibc git master snapshot, of what will become the 2.28 release, and this has exposed bugs in gnulib's fseeko.c implementation (and probably more macros) besides. The issue starts are line 50: http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/fseeko.c#n50 #if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ Historically the _IO_ftrylockfile symbol has been defined unconditionally in glibc, by /usr/include/libio.h, which is pulled in unconditionally from /usr/include/stdio.h The libio.h header was deprecated in 2.27 release and is removed in git master for future 2.28. Thus the _IO_ftrylockfile symbol has gone away. https://sourceware.org/ml/libc-announce/2018/msg00000.html "The nonstandard header files <libio.h> and <_G_config.h> are deprecated and will be removed in a future release. Software that is still using either header should be updated to use standard <stdio.h> interfaces instead. libio.h was originally the header for a set of supported GNU extensions, but they have not been maintained as such in many years, they are now standing in the way of improvements to stdio, and we don't think there are any remaining external users. _G_config.h was never intended for public use, but predates the bits convention." We then fail the __GNU_LIBRARY__ test too, because modern glibc defines that to a value of '6', not '1'. For added fun __GNU_LIBRARY__ is considered deprecated too, with recommendation to use other symbols like __GLIBC__ and __GLIBC_MINOR__ /* This macro indicates that the installed library is the GNU C Library. For historic reasons the value now is 6 and this will stay from now on. The use of this variable is deprecated. Use __GLIBC__ and __GLIBC_MINOR__ now (see below) when you want to test for a specific GNU C library version and use the values in <gnu/lib-names.h> to get the sonames of the shared libraries. * #define __GNU_LIBRARY__ 6 I hit failure on fseeko.c, but many other files in gnulib test on _IO_ftrylockfile so I presume they are all broken. I'm curious why we're trying to replace fseeko impl at all, since I would expect the modern glibc impl to be suitable to use as-is. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

2 4

[libvirt] [PATCH] cfg.mak: ignore trailing whitespace in gnulib local patches
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

The diff files in gnulib/local may well contain trailing whitespace. They are simply diff's of gnulib code which should not be modified to follow libvirt style rules. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a build fix cfg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cfg.mk b/cfg.mk index 22de11ce43..bc8088d7c0 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1224,7 +1224,7 @@ exclude_file_name_regexp--sc_require_config_h_first = \ ^(examples/|tools/virsh-edit\.c$$) exclude_file_name_regexp--sc_trailing_blank = \ - /qemuhelpdata/|/sysinfodata/.*\.data|/virhostcpudata/.*\.cpuinfo$$ + /qemuhelpdata/|/sysinfodata/.*\.data|/virhostcpudata/.*\.cpuinfo|^gnulib/local/.*/.*diff$$ exclude_file_name_regexp--sc_unmarked_diagnostics = \ ^(docs/apibuild.py|tests/virt-aa-helper-test|docs/js/.*\.js)$$ -- 2.14.3

1 0

[libvirt] [PATCH] gnulib: temporary hacks to deal with glibc libio.h removal
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

GLibc deprecated libio.h in 2.27 and has removed it in current code that will become 2.28. The latter is now in Fedora rawhide and this change breaks gnulib which mistakenly still relies on these ancient symbols. Add a local hack for gnulib until a proper fix is available upstream. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as a CI build fix gnulib/local/lib/fflush.c.diff | 33 +++++++++++++++++++++++++++++++++ gnulib/local/lib/fpurge.c.diff | 13 +++++++++++++ gnulib/local/lib/freading.c.diff | 13 +++++++++++++ gnulib/local/lib/fseeko.c.diff | 22 ++++++++++++++++++++++ 4 files changed, 81 insertions(+) create mode 100644 gnulib/local/lib/fflush.c.diff create mode 100644 gnulib/local/lib/fpurge.c.diff create mode 100644 gnulib/local/lib/freading.c.diff create mode 100644 gnulib/local/lib/fseeko.c.diff diff --git a/gnulib/local/lib/fflush.c.diff b/gnulib/local/lib/fflush.c.diff new file mode 100644 index 0000000000..fa0e2431bd --- /dev/null +++ b/gnulib/local/lib/fflush.c.diff @@ -0,0 +1,33 @@ +diff --git a/lib/fflush.c b/lib/fflush.c +index 983ade0ff..5f617305a 100644 +--- a/lib/fflush.c ++++ b/lib/fflush.c +@@ -32,8 +32,8 @@ + + #undef fflush + +- +-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ ++#define _IO_IN_BACKUP 0x100 ++#if defined _IO_ftrylockfile || __GNU_LIBRARY__ /* GNU libc, BeOS, Haiku, Linux libc5 */ + + /* Clear the stream's ungetc buffer, preserving the value of ftello (fp). */ + static void +@@ -72,7 +72,7 @@ clear_ungetc_buffer (FILE *fp) + + #endif + +-#if ! (defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */) ++#if ! (defined _IO_ftrylockfile || __GNU_LIBRARY__ /* GNU libc, BeOS, Haiku, Linux libc5 */) + + # if (defined __sferror || defined __DragonFly__ || defined __ANDROID__) && defined __SNPT + /* FreeBSD, NetBSD, OpenBSD, DragonFly, Mac OS X, Cygwin, Minix 3, Android */ +@@ -148,7 +148,7 @@ rpl_fflush (FILE *stream) + if (stream == NULL || ! freading (stream)) + return fflush (stream); + +-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ ++#if defined _IO_ftrylockfile || __GNU_LIBRARY__ /* GNU libc, BeOS, Haiku, Linux libc5 */ + + clear_ungetc_buffer_preserving_position (stream); + diff --git a/gnulib/local/lib/fpurge.c.diff b/gnulib/local/lib/fpurge.c.diff new file mode 100644 index 0000000000..1fd87d8bfa --- /dev/null +++ b/gnulib/local/lib/fpurge.c.diff @@ -0,0 +1,13 @@ +diff --git a/lib/fpurge.c b/lib/fpurge.c +index b1d417c7a..75cf34ca2 100644 +--- a/lib/fpurge.c ++++ b/lib/fpurge.c +@@ -62,7 +62,7 @@ fpurge (FILE *fp) + /* Most systems provide FILE as a struct and the necessary bitmask in + <stdio.h>, because they need it for implementing getc() and putc() as + fast macros. */ +-# if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ ++# if defined _IO_ftrylockfile || __GNU_LIBRARY__ /* GNU libc, BeOS, Haiku, Linux libc5 */ + fp->_IO_read_end = fp->_IO_read_ptr; + fp->_IO_write_ptr = fp->_IO_write_base; + /* Avoid memory leak when there is an active ungetc buffer. */ diff --git a/gnulib/local/lib/freading.c.diff b/gnulib/local/lib/freading.c.diff new file mode 100644 index 0000000000..c51e34dd6a --- /dev/null +++ b/gnulib/local/lib/freading.c.diff @@ -0,0 +1,13 @@ +diff --git a/lib/freading.c b/lib/freading.c +index 73c28acdd..b1c397016 100644 +--- a/lib/freading.c ++++ b/lib/freading.c +@@ -31,7 +31,7 @@ freading (FILE *fp) + /* Most systems provide FILE as a struct and the necessary bitmask in + <stdio.h>, because they need it for implementing getc() and putc() as + fast macros. */ +-# if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ ++# if defined _IO_ftrylockfile || __GNU_LIBRARY__ /* GNU libc, BeOS, Haiku, Linux libc5 */ + return ((fp->_flags & _IO_NO_WRITES) != 0 + || ((fp->_flags & (_IO_NO_READS | _IO_CURRENTLY_PUTTING)) == 0 + && fp->_IO_read_base != NULL)); diff --git a/gnulib/local/lib/fseeko.c.diff b/gnulib/local/lib/fseeko.c.diff new file mode 100644 index 0000000000..b2c061fc97 --- /dev/null +++ b/gnulib/local/lib/fseeko.c.diff @@ -0,0 +1,22 @@ +diff --git a/lib/fseeko.c b/lib/fseeko.c +index 0101ab55f..542241bb2 100644 +--- a/lib/fseeko.c ++++ b/lib/fseeko.c +@@ -47,7 +47,7 @@ fseeko (FILE *fp, off_t offset, int whence) + #endif + + /* These tests are based on fpurge.c. */ +-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ ++#if defined _IO_ftrylockfile || __GNU_LIBRARY__ /* GNU libc, BeOS, Haiku, Linux libc5 */ + if (fp->_IO_read_end == fp->_IO_read_ptr + && fp->_IO_write_ptr == fp->_IO_write_base + && fp->_IO_save_base == NULL) +@@ -123,7 +123,7 @@ fseeko (FILE *fp, off_t offset, int whence) + return -1; + } + +-#if defined _IO_ftrylockfile || __GNU_LIBRARY__ == 1 /* GNU libc, BeOS, Haiku, Linux libc5 */ ++#if defined _IO_ftrylockfile || __GNU_LIBRARY__ /* GNU libc, BeOS, Haiku, Linux libc5 */ + fp->_flags &= ~_IO_EOF_SEEN; + fp->_offset = pos; + #elif defined __sferror || defined __DragonFly__ || defined __ANDROID__ -- 2.14.3

1 0

[libvirt] [PATCH] gnulib: update to latest upstream changeset
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as trivial rule .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 7e7c5c7952..0404c9ae28 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 7e7c5c7952b7de1e33c8eba891cc425d5d8d7803 +Subproject commit 0404c9ae2845cbf93d71b295b67d6c8bd39382d8 -- 2.14.3

1 0

[libvirt] [PATCH 00/17] Split up the src/Makefile.am even more
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

This is a continuation of my previous work to split src/Makefile.am This series does all the other non-virt drivers and utility code directories. This is about as far as I'm intending to take it for now. This is for post-freeze obviously :) Daniel P. Berrangé (17): make: split interface driver build rules into interface/Makefile.inc.am make: split network driver build rules into network/Makefile.inc.am make: split nwfilter driver build rules into nwfilter/Makefile.inc.am make: split nodedev driver build rules into node_device/Makefile.inc.am make: split secret driver build rules into secret/Makefile.inc.am make: split storage driver build rules into storage/Makefile.inc.am make: split remote driver & daemon build rules into remote/Makefile.inc.am make: split XML conf build rules into conf/Makefile.inc.am make: split CPU build rules into cpu/Makefile.inc.am make: split security driver build rules into security/Makefile.inc.am make: split access driver build rules into access/Makefile.inc.am make: split logging daemon build rules into logging/Makefile.inc.am make: split lock daemon build rules into locking/Makefile.inc.am make: split admin driver build rules into admin/Makefile.inc.am make: split RPC build rules into rpc/Makefile.inc.am make: split util build rules into util/Makefile.inc.am make: split vmx driver build rules into vmx/Makefile.inc.am src/Makefile.am | 1993 +-------------------------------------- src/access/Makefile.inc.am | 148 +++ src/admin/Makefile.inc.am | 50 + src/conf/Makefile.inc.am | 163 ++++ src/cpu/Makefile.inc.am | 24 + src/interface/Makefile.inc.am | 42 + src/locking/Makefile.inc.am | 321 +++++++ src/logging/Makefile.inc.am | 155 +++ src/network/Makefile.inc.am | 106 +++ src/node_device/Makefile.inc.am | 65 ++ src/nwfilter/Makefile.inc.am | 42 + src/remote/Makefile.inc.am | 342 +++++++ src/rpc/Makefile.inc.am | 147 +++ src/secret/Makefile.inc.am | 38 + src/security/Makefile.inc.am | 80 ++ src/storage/Makefile.inc.am | 323 +++++++ src/util/Makefile.inc.am | 325 +++++++ src/vmx/Makefile.inc.am | 22 + 18 files changed, 2435 insertions(+), 1951 deletions(-) create mode 100644 src/access/Makefile.inc.am create mode 100644 src/admin/Makefile.inc.am create mode 100644 src/conf/Makefile.inc.am create mode 100644 src/cpu/Makefile.inc.am create mode 100644 src/interface/Makefile.inc.am create mode 100644 src/locking/Makefile.inc.am create mode 100644 src/logging/Makefile.inc.am create mode 100644 src/network/Makefile.inc.am create mode 100644 src/node_device/Makefile.inc.am create mode 100644 src/nwfilter/Makefile.inc.am create mode 100644 src/remote/Makefile.inc.am create mode 100644 src/rpc/Makefile.inc.am create mode 100644 src/secret/Makefile.inc.am create mode 100644 src/security/Makefile.inc.am create mode 100644 src/storage/Makefile.inc.am create mode 100644 src/util/Makefile.inc.am create mode 100644 src/vmx/Makefile.inc.am -- 2.14.3

2 18

[libvirt] [PATCH v6 00/11] qemu: Validate PCI controller options
by Andrea Bolognani 05 Mar '18

05 Mar '18

Applies cleanly on top of 11819aee65b8ea71860526f529d86ab646b9cd1f. Patches 2/11 and 4/11 are the only ones missing R-bs, everything else hasn't been significantly altered since the previous respin. Changes from [v5]: * patch 1 has been pushed; * add virReportController*() functions to cut down on redundant error reporting, as suggested by laine; * report index and modelName along with model in error messages. Changes from [v4]: * patch 1/12 is new; * use virReportEnumRangeError(), as suggested by laine. Changes from [v3]: * don't introduce new test cases that won't be able to provide full test coverage anyway, as suggested by laine. Changes from [v2]: * replace the old implementation bit by bit using a clever trick suggested by pkrempa; * don't move QEMU capability validation; * add a default: label to all switch statements as recommended by danpb. Changes from [v1]: * error out instead of silently accept invalid options; * shave quite a lot of yaks. [v5] https://www.redhat.com/archives/libvir-list/2018-March/msg00096.html [v4] https://www.redhat.com/archives/libvir-list/2018-February/msg01232.html [v3] https://www.redhat.com/archives/libvir-list/2018-February/msg00996.html [v2] https://www.redhat.com/archives/libvir-list/2018-February/msg00813.html [v1] https://www.redhat.com/archives/libvir-list/2018-February/msg00244.html Andrea Bolognani (11): qemu: Create new qemuDomainDeviceDefValidateControllerPCI() qemu: Validate PCI controller options (modelName) qemu: Validate PCI controller options (index) qemu: Validate PCI controller options (targetIndex) qemu: Validate PCI controller options (pcihole64) qemu: Validate PCI controller options (busNr) qemu: Validate PCI controller options (numaNode) qemu: Validate PCI controller options (chassisNr) qemu: Validate PCI controller options (chassis and port) qemu: Validate PCI controllers (QEMU capabilities) qemu: Remove old qemuDomainDeviceDefValidateControllerPCI() src/qemu/qemu_domain.c | 540 +++++++++++++++++-------- tests/qemuxml2argvdata/pcie-expander-bus.xml | 3 - tests/qemuxml2xmloutdata/pcie-expander-bus.xml | 4 +- 3 files changed, 382 insertions(+), 165 deletions(-) -- 2.14.3

1 11

[libvirt] [PATCH] make sure libvirt is linked first
by Jan Palus 05 Mar '18

05 Mar '18

so it's not affected by flags that might be passed in $(*_LIBS) like -L/usr/lib which might result in linking against system library and requiring incorrect version of private symbols --- src/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 3bf2da5..cb6ee84 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1456,10 +1456,11 @@ libvirt_driver_nwfilter_impl_la_CFLAGS = \ $(AM_CFLAGS) libvirt_driver_nwfilter_impl_la_LDFLAGS = $(AM_LDFLAGS) libvirt_driver_nwfilter_impl_la_LIBADD = \ + libvirt.la \ $(LIBPCAP_LIBS) \ $(LIBNL_LIBS) \ - $(DBUS_LIBS) -libvirt_driver_nwfilter_impl_la_LIBADD += libvirt.la ../gnulib/lib/libgnu.la + $(DBUS_LIBS) \ + ../gnulib/lib/libgnu.la libvirt_driver_nwfilter_impl_la_SOURCES = $(NWFILTER_DRIVER_SOURCES) endif WITH_NWFILTER -- 2.16.2

3 7

[libvirt] [PATCH python] Post-release version bump to 4.2.0
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as trivial change setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 63da8c5..c40908b 100755 --- a/setup.py +++ b/setup.py @@ -334,7 +334,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '4.1.0', + version = '4.2.0', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list(a)redhat.com', -- 2.14.3

1 0

[libvirt] [PATCH] Post-release version bump to 4.2.0
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- Pushed as trivial fix configure.ac | 2 +- docs/news.xml | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 5e720d1b76..970a695ad1 100644 --- a/configure.ac +++ b/configure.ac @@ -16,7 +16,7 @@ dnl You should have received a copy of the GNU Lesser General Public dnl License along with this library. If not, see dnl <http://www.gnu.org/licenses/>. -AC_INIT([libvirt], [4.1.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] +AC_INIT([libvirt], [4.2.0], [libvir-list(a)redhat.com] [], [https://libvirt.org] AC_CONFIG_SRCDIR([src/libvirt.c]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_HEADERS([config.h]) diff --git a/docs/news.xml b/docs/news.xml index e4d61d1d7f..4da692b269 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -33,6 +33,14 @@ --> <libvirt> + <release version="v4.2.0" date="unreleased"> + <section title="New features"> + </section> + <section title="Improvements"> + </section> + <section title="Bug fixes"> + </section> + </release> <release version="v4.1.0" date="2018-03-05"> <section title="New features"> <change> -- 2.14.3

1 0

Re: [libvirt] [Libvirt-ci] Build failed in Jenkins: libvirt-master-mingw » libvirt-fedora-rawhide #1863
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

On Mon, Mar 05, 2018 at 02:28:37PM +0000, ci(a)centos.org wrote: > See <https://ci.centos.org/job/libvirt-master-mingw/systems=libvirt-fedora-rawhi…> > > Changes: > > [jtomko] conf: set postParseFailed even without ALLOW_POST_PARSE_FAIL > > [berrange] travis: force install of python2 into $PATH on macOS > > ------------------------------------------ > ../../libtool: line 3227: 17288 Segmentation fault (core dumped) $MV "${write_libobj}T" "$write_libobj" > ../../libtool: line 3780: 17291 Segmentation fault (core dumped) $RM $removelist > /bin/sh: line 2: 17297 Segmentation fault (core dumped) mv -f $depbase.Tpo $depbase.Plo > make[3]: *** [Makefile:2392: poll.lo] Error 139 > make[3]: *** Waiting for unfinished jobs.... Ignore this - the build host is in middle of a huge dnf update. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|

1 0

[libvirt] [PATCH] travis: force install of python2 into $PATH on macOS
by Daniel P. Berrangé 05 Mar '18

05 Mar '18

The homebrew formula's ignored Python PEP-0394 recommendations and changed the plain python binary in /usr/local/bin to point to Python 3 instead of Python 2. Python 2 is not even installed into a location that is in $PATH by default anymore. The homebrew packages print a message to stderr claiming to provide a way to fix this [quote] This formula installs a python2 executable to /usr/local/opt/python@2/bin If you wish to have this formula's python executable in your PATH then add the following to ~/.bash_profile: export PATH="/usr/local/opt/python@2/libexec/bin:$PATH" [/quote] When trying to update $PATH are suggested we find out this message is a lie and /usr/local/opt/python@2 does not even exist, instead Python seems to end up in /usr/local/Cellar/python(a)2/2.7.14_1 Rather than hardcoding this version specific directory in our travis config, we change to run "brew link --force python@2", to make it create symlinks in /usr/local/bin for the python2 binary. The original change triggering this problem was https://github.com/Homebrew/homebrew-core/pull/24604#issue-171653084 There are countless bug reports against homebrew-core that are closed without fixes, so it seems they are determined to ignore the Python PEP 0394 recommendations on this. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 44f680ad07..699e4bf33a 100644 --- a/.travis.yml +++ b/.travis.yml @@ -97,7 +97,7 @@ env: - VIR_TEST_DEBUG=1 before_install: - - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && brew install rpcgen yajl xz; fi + - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update && brew upgrade && brew install rpcgen yajl xz && brew link --force python@2 ; fi before_script: - ./autogen.sh --prefix=$(pwd)/install-root -- 2.14.3

2 1

[libvirt] update keycodemapdb submodule for 4.1.0 release
by Jim Fehlig 05 Mar '18

05 Mar '18

I mistakenly dropped keycodemapdb commit 6b3d716e from our libvirt 4.1.0 builds only to stumble across the failures in py3 environments that are fixed by that commit. Should the submodule be updated for the 4.1.0 release? Regards, Jim

5 7

[libvirt] [PATCH 0/2] Fix crash from live attach of device (for 4.1.0)
by John Ferlan 05 Mar '18

05 Mar '18

Fix is in patch 1/2 - if virDomainDefCompatibleDevice is called with a NULL @oldDev, then call to virDomainDeviceGetInfo would fail rather spectacularly. Patch 2 extends the similar fix/adjustment from the update path to the add path for the cdrom/floppy since the add path since it's possible to use attach device as well as update device. John Ferlan (2): conf: Fix crash in virDomainDefCompatibleDevice qemu: Call virDomainDefCompatibleDevice when live add cdrom/floppy src/conf/domain_conf.c | 5 ++++- src/qemu/qemu_hotplug.c | 8 ++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) -- 2.13.6

2 4

[libvirt] [PATCH] virtlockd: acquire locks on re-exec
by Jim Fehlig 05 Mar '18

05 Mar '18

Locks held by virtlockd are dropped on re-exec. virtlockd 94306 POSIX 5.4G WRITE 0 0 0 /tmp/test.qcow2 virtlockd 94306 POSIX 5B WRITE 0 0 0 /run/virtlockd.pid virtlockd 94306 POSIX 5B WRITE 0 0 0 /run/virtlockd.pid Acquire locks in PostExecRestart code path. Signed-off-by: Jim Fehlig <jfehlig(a)suse.com> --- The CLOEXEC flag is set in virLockSpaceNewPostExecRestart(), so I assume it is fine to call virFileLock() here as well. src/util/virlockspace.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/util/virlockspace.c b/src/util/virlockspace.c index 41af0cdb6..420878b0a 100644 --- a/src/util/virlockspace.c +++ b/src/util/virlockspace.c @@ -337,6 +337,7 @@ virLockSpacePtr virLockSpaceNewPostExecRestart(virJSONValuePtr object) virJSONValuePtr owners; size_t j; ssize_t m; + bool shared = false; if (VIR_ALLOC(res) < 0) goto error; @@ -389,6 +390,21 @@ virLockSpacePtr virLockSpaceNewPostExecRestart(virJSONValuePtr object) goto error; } + shared = !!(res->flags & VIR_LOCK_SPACE_ACQUIRE_SHARED); + if (virFileLock(res->fd, shared, 0, 1, false) < 0) { + if (errno == EACCES || errno == EAGAIN) { + virReportError(VIR_ERR_RESOURCE_BUSY, + _("Lockspace resource '%s' is locked"), + res->name); + } else { + virReportSystemError(errno, + _("Unable to acquire lock on '%s'"), + res->path); + } + virLockSpaceResourceFree(res); + goto error; + } + if (!(owners = virJSONValueObjectGet(child, "owners"))) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Missing resource owners in JSON document")); -- 2.16.2

3 5