- Devel - libvirt List Archives

[libvirt] [PATCH 0/3] Fix examples/ under mingw
by Eric Blake 09 Jan '19

09 Jan '19

My recent patch to make all of the examples work independently of gnulib worked fine on Linux, but failed on mingw: https://travis-ci.org/libvirt/libvirt/jobs/476898635 The whole point of gnulib is to work around portability pitfalls so we don't have to bend over backwards thinking about it in our code; and it would be possible to fix this bug by linking the problematic example binaries against gnulib after all. But since the examples are still small and self-contained enough that using manual workarounds wasn't too daunting, that's the approach I took here. I'm pushing this series as a build-breaker fix in a couple of hours, or sooner if I get a review. Eric Blake (3): examples: Work around mingw printf() weakness examples: Work around lack of mingw sigaction() examples: Work around lack of mingw localtime_r() cfg.mk | 2 +- examples/admin/client_info.c | 6 +++++- examples/admin/list_clients.c | 6 +++++- examples/domtop/domtop.c | 13 ++++++------- examples/object-events/event-test.c | 16 +++++++--------- 5 files changed, 24 insertions(+), 19 deletions(-) -- 2.20.1

4 10

[libvirt] [PATCH] qemu: Use ULL instead of uint64_t for RDMA GID event
by Michal Privoznik 09 Jan '19

09 Jan '19

In the previous commit we are using uint64_t for storing subnet prefix and interface id that qemu reports in RDMA_GID_STATUS_CHANGED event. We also report them in some debug messages. This poses a problem because uint64_t can be UL or ULL depending on the host architecture and hence we wouldn't know which format to use. Switch to ULL which is big enough and doesn't suffer from the issue. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under build breaker and trivial rules. src/qemu/qemu_monitor.c | 6 +++--- src/qemu/qemu_monitor.h | 12 +++++++----- src/qemu/qemu_process.c | 6 +++--- 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 419ea66a6a..7ce5bd668e 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1688,11 +1688,11 @@ int qemuMonitorEmitRdmaGidStatusChanged(qemuMonitorPtr mon, const char *netdev, bool gid_status, - uint64_t subnet_prefix, - uint64_t interface_id) + unsigned long long subnet_prefix, + unsigned long long interface_id) { int ret = -1; - VIR_DEBUG("netdev=%s, gid_status=%d, subnet_prefix=0x%lx, interface_id=0x%lx", + VIR_DEBUG("netdev=%s, gid_status=%d, subnet_prefix=0x%llx, interface_id=0x%llx", netdev, gid_status, subnet_prefix, interface_id); QEMU_MONITOR_CALLBACK(mon, ret, domainRdmaGidStatusChanged, mon->vm, diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 93804233db..8fcac8850f 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -294,8 +294,8 @@ typedef int (*qemuMonitorDomainRdmaGidStatusChangedCallback)(qemuMonitorPtr mon, virDomainObjPtr vm, const char *netdev, bool gid_status, - uint64_t subnet_prefix, - uint64_t interface_id, + unsigned long long subnet_prefix, + unsigned long long interface_id, void *opaque); typedef struct _qemuMonitorCallbacks qemuMonitorCallbacks; @@ -466,9 +466,11 @@ int qemuMonitorEmitPRManagerStatusChanged(qemuMonitorPtr mon, const char *prManager, bool connected); -int qemuMonitorEmitRdmaGidStatusChanged(qemuMonitorPtr mon, const char *netdev, - bool gid_status, uint64_t subnet_prefix, - uint64_t interface_id); +int qemuMonitorEmitRdmaGidStatusChanged(qemuMonitorPtr mon, + const char *netdev, + bool gid_status, + unsigned long long subnet_prefix, + unsigned long long interface_id); int qemuMonitorStartCPUs(qemuMonitorPtr mon); int qemuMonitorStopCPUs(qemuMonitorPtr mon); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 83a054663f..aad6c12552 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1720,8 +1720,8 @@ qemuProcessHandleRdmaGidStatusChanged(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm, const char *netdev, bool gid_status, - uint64_t subnet_prefix, - uint64_t interface_id, + unsigned long long subnet_prefix, + unsigned long long interface_id, void *opaque) { virQEMUDriverPtr driver = opaque; @@ -1731,7 +1731,7 @@ qemuProcessHandleRdmaGidStatusChanged(qemuMonitorPtr mon ATTRIBUTE_UNUSED, virObjectLock(vm); - VIR_DEBUG("netdev=%s,gid_status=%d,subnet_prefix=0x%lx,interface_id=0x%lx", + VIR_DEBUG("netdev=%s,gid_status=%d,subnet_prefix=0x%llx,interface_id=0x%llx", netdev, gid_status, subnet_prefix, interface_id); if (VIR_ALLOC(info) < 0 || -- 2.19.2

1 0

[libvirt] [PATCH 0/2] Fix build on FreeBSD
by Ján Tomko 09 Jan '19

09 Jan '19

The recent gnulib update pulled in a commit that broke the build of examples on FreeBSD Ján Tomko (2): examples: add spaces after #include examples: include config.h examples/admin/client_close.c | 10 ++++++---- examples/admin/client_info.c | 13 +++++++------ examples/admin/client_limits.c | 8 +++++--- examples/admin/list_clients.c | 10 ++++++---- examples/admin/list_servers.c | 8 +++++--- examples/admin/logging.c | 17 +++++++++-------- examples/admin/threadpool_params.c | 8 +++++--- examples/dommigrate/dommigrate.c | 2 ++ examples/hellolibvirt/hellolibvirt.c | 2 ++ examples/openauth/openauth.c | 2 ++ examples/rename/rename.c | 2 ++ 11 files changed, 51 insertions(+), 31 deletions(-) -- 2.16.4

4 6

[libvirt] [PATCH v3 RESEND] qemu: Process RDMA GID state change event
by Yuval Shaia 09 Jan '19

09 Jan '19

This event is emitted on the monitor when a GID table in pvrdma device is modified and the change needs to be propagate to the backend RDMA device's GID table. The control over the RDMA device's GID table is done by updating the device's Ethernet function addresses. Usually the first GID entry is determine by the MAC address, the second by the first IPv6 address and the third by the IPv4 address. Other entries can be added by adding more IP addresses. The opposite is the same, i.e. whenever an address is removed, the corresponding GID entry is removed. The process is done by the network and RDMA stacks. Whenever an address is added the ib_core driver is notified and calls the device driver's add_gid function which in turn update the device. To support this in pvrdma device we need to hook into the create_bind and destroy_bind HW commands triggered by pvrdma driver in guest. Whenever a changed is made to the pvrdma device's GID table a special QMP messages is sent to be processed by libvirt to update the address of the backend Ethernet device. Signed-off-by: Yuval Shaia <yuval.shaia(a)oracle.com> --- (fixing mail subject from v2 to v3, rest is the same) Hi, Corresponding qemu commit was merged to master as part of the following patch-set: https://www.mail-archive.com/qemu-devel@nongnu.org/msg583387.html Appreciate if this patch can be reviewed and merged as well. Thanks, Yuval v1 -> v2: * Address all comments from Michal Privoznik v2 -> v3: * Remove static initialization in processRdmaGidStatusChangedEvent --- src/qemu/qemu_domain.c | 3 +++ src/qemu/qemu_domain.h | 1 + src/qemu/qemu_driver.c | 44 ++++++++++++++++++++++++++++++ src/qemu/qemu_monitor.c | 27 +++++++++++++++++++ src/qemu/qemu_monitor.h | 27 +++++++++++++++++++ src/qemu/qemu_monitor_json.c | 36 +++++++++++++++++++++++++ src/qemu/qemu_process.c | 52 ++++++++++++++++++++++++++++++++++++ 7 files changed, 190 insertions(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index ba3fff607a..8da54c7ee9 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -13479,6 +13479,9 @@ qemuProcessEventFree(struct qemuProcessEvent *event) case QEMU_PROCESS_EVENT_GUESTPANIC: qemuMonitorEventPanicInfoFree(event->data); break; + case QEMU_PROCESS_EVENT_RDMA_GID_STATUS_CHANGED: + qemuMonitorEventRdmaGidStatusFree(event->data); + break; case QEMU_PROCESS_EVENT_WATCHDOG: case QEMU_PROCESS_EVENT_DEVICE_DELETED: case QEMU_PROCESS_EVENT_NIC_RX_FILTER_CHANGED: diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 80bd4bde91..64bceb9a98 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -487,6 +487,7 @@ typedef enum { QEMU_PROCESS_EVENT_BLOCK_JOB, QEMU_PROCESS_EVENT_MONITOR_EOF, QEMU_PROCESS_EVENT_PR_DISCONNECT, + QEMU_PROCESS_EVENT_RDMA_GID_STATUS_CHANGED, QEMU_PROCESS_EVENT_LAST } qemuProcessEventType; diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index a52e2495d5..5c6ab3c0ea 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -4788,6 +4788,47 @@ processPRDisconnectEvent(virDomainObjPtr vm) } +static void +processRdmaGidStatusChangedEvent(virDomainObjPtr vm, + qemuMonitorRdmaGidStatusChangedPrivatePtr info) +{ + unsigned int prefix_len; + virSocketAddr addr; + int rc; + + if (!virDomainObjIsActive(vm)) + return; + + VIR_DEBUG("netdev=%s,gid_status=%d,subnet_prefix=0x%llx,interface_id=0x%llx", + info->netdev, info->gid_status, info->subnet_prefix, + info->interface_id); + + if (info->subnet_prefix) { + prefix_len = 64; + uint32_t ipv6[4]; + memcpy(&ipv6[0], &info->subnet_prefix, sizeof(info->subnet_prefix)); + memcpy(&ipv6[2], &info->interface_id, sizeof(info->interface_id)); + virSocketAddrSetIPv6AddrNetOrder(&addr, ipv6); + } else { + prefix_len = 24; + virSocketAddrSetIPv4AddrNetOrder(&addr, info->interface_id >> 32); + } + + if (info->gid_status) { + VIR_DEBUG("Adding %s to %s", virSocketAddrFormat(&addr), info->netdev); + rc = virNetDevIPAddrAdd(info->netdev, &addr, NULL, prefix_len); + } else { + VIR_DEBUG("Removing %s from %s", virSocketAddrFormat(&addr), + info->netdev); + rc = virNetDevIPAddrDel(info->netdev, &addr, prefix_len); + } + + if (rc < 0) + VIR_WARN("Fail to update address %s to %s", virSocketAddrFormat(&addr), + info->netdev); +} + + static void qemuProcessEventHandler(void *data, void *opaque) { struct qemuProcessEvent *processEvent = data; @@ -4828,6 +4869,9 @@ static void qemuProcessEventHandler(void *data, void *opaque) case QEMU_PROCESS_EVENT_PR_DISCONNECT: processPRDisconnectEvent(vm); break; + case QEMU_PROCESS_EVENT_RDMA_GID_STATUS_CHANGED: + processRdmaGidStatusChangedEvent(vm, processEvent->data); + break; case QEMU_PROCESS_EVENT_LAST: break; } diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 7f7013e115..4bf71dbf8c 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1686,6 +1686,22 @@ qemuMonitorEmitPRManagerStatusChanged(qemuMonitorPtr mon, } +int +qemuMonitorEmitRdmaGidStatusChanged(qemuMonitorPtr mon, const char *netdev, + bool gid_status, uint64_t subnet_prefix, + uint64_t interface_id) +{ + int ret = -1; + VIR_DEBUG("netdev=%s,gid_status=%d,subnet_prefix=0x%lx,interface_id=0x%lx", + netdev, gid_status, subnet_prefix, interface_id); + + QEMU_MONITOR_CALLBACK(mon, ret, domainRdmaGidStatusChanged, mon->vm, netdev, + gid_status, subnet_prefix, interface_id); + + return ret; +} + + int qemuMonitorSetCapabilities(qemuMonitorPtr mon) { @@ -4298,6 +4314,17 @@ qemuMonitorEventPanicInfoFree(qemuMonitorEventPanicInfoPtr info) } +void +qemuMonitorEventRdmaGidStatusFree(qemuMonitorRdmaGidStatusChangedPrivatePtr info) +{ + if (!info) + return; + + VIR_FREE(info->netdev); + VIR_FREE(info); +} + + int qemuMonitorSetWatchdogAction(qemuMonitorPtr mon, const char *action) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 48b142a4f4..b639a0a9d2 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -109,8 +109,22 @@ struct _qemuMonitorEventPanicInfo { } data; }; + +typedef struct _qemuMonitorRdmaGidStatusChangedPrivate qemuMonitorRdmaGidStatusChangedPrivate; +typedef qemuMonitorRdmaGidStatusChangedPrivate *qemuMonitorRdmaGidStatusChangedPrivatePtr; +struct _qemuMonitorRdmaGidStatusChangedPrivate { + virObject parent; + + char *netdev; + bool gid_status; + unsigned long long subnet_prefix; + unsigned long long interface_id; +}; + + char *qemuMonitorGuestPanicEventInfoFormatMsg(qemuMonitorEventPanicInfoPtr info); void qemuMonitorEventPanicInfoFree(qemuMonitorEventPanicInfoPtr info); +void qemuMonitorEventRdmaGidStatusFree(qemuMonitorRdmaGidStatusChangedPrivatePtr info); typedef void (*qemuMonitorDestroyCallback)(qemuMonitorPtr mon, virDomainObjPtr vm, @@ -281,6 +295,14 @@ typedef int (*qemuMonitorDomainPRManagerStatusChangedCallback)(qemuMonitorPtr mo bool connected, void *opaque); +typedef int (*qemuMonitorDomainRdmaGidStatusChangedCallback)(qemuMonitorPtr mon, + virDomainObjPtr vm, + const char *netdev, + bool gid_status, + uint64_t subnet_prefix, + uint64_t interface_id, + void *opaque); + typedef struct _qemuMonitorCallbacks qemuMonitorCallbacks; typedef qemuMonitorCallbacks *qemuMonitorCallbacksPtr; struct _qemuMonitorCallbacks { @@ -314,6 +336,7 @@ struct _qemuMonitorCallbacks { qemuMonitorDomainBlockThresholdCallback domainBlockThreshold; qemuMonitorDomainDumpCompletedCallback domainDumpCompleted; qemuMonitorDomainPRManagerStatusChangedCallback domainPRManagerStatusChanged; + qemuMonitorDomainRdmaGidStatusChangedCallback domainRdmaGidStatusChanged; }; char *qemuMonitorEscapeArg(const char *in); @@ -448,6 +471,10 @@ int qemuMonitorEmitPRManagerStatusChanged(qemuMonitorPtr mon, const char *prManager, bool connected); +int qemuMonitorEmitRdmaGidStatusChanged(qemuMonitorPtr mon, const char *netdev, + bool gid_status, uint64_t subnet_prefix, + uint64_t interface_id); + int qemuMonitorStartCPUs(qemuMonitorPtr mon); int qemuMonitorStopCPUs(qemuMonitorPtr mon); diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 3de298c9e2..8df9b426ba 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -91,6 +91,7 @@ static void qemuMonitorJSONHandleAcpiOstInfo(qemuMonitorPtr mon, virJSONValuePtr static void qemuMonitorJSONHandleBlockThreshold(qemuMonitorPtr mon, virJSONValuePtr data); static void qemuMonitorJSONHandleDumpCompleted(qemuMonitorPtr mon, virJSONValuePtr data); static void qemuMonitorJSONHandlePRManagerStatusChanged(qemuMonitorPtr mon, virJSONValuePtr data); +static void qemuMonitorJSONHandleRdmaGidStatusChanged(qemuMonitorPtr mon, virJSONValuePtr data); typedef struct { const char *type; @@ -114,6 +115,7 @@ static qemuEventHandler eventHandlers[] = { { "NIC_RX_FILTER_CHANGED", qemuMonitorJSONHandleNicRxFilterChanged, }, { "POWERDOWN", qemuMonitorJSONHandlePowerdown, }, { "PR_MANAGER_STATUS_CHANGED", qemuMonitorJSONHandlePRManagerStatusChanged, }, + { "RDMA_GID_STATUS_CHANGED", qemuMonitorJSONHandleRdmaGidStatusChanged, }, { "RESET", qemuMonitorJSONHandleReset, }, { "RESUME", qemuMonitorJSONHandleResume, }, { "RTC_CHANGE", qemuMonitorJSONHandleRTCChange, }, @@ -1351,6 +1353,40 @@ static void qemuMonitorJSONHandlePRManagerStatusChanged(qemuMonitorPtr mon, } +static void qemuMonitorJSONHandleRdmaGidStatusChanged(qemuMonitorPtr mon, + virJSONValuePtr data) +{ + const char *netdev; + bool gid_status; + unsigned long long subnet_prefix, interface_id; + + if (!(netdev = virJSONValueObjectGetString(data, "netdev"))) { + VIR_WARN("missing netdev in GID_STATUS_CHANGED event"); + return; + } + + if (virJSONValueObjectGetBoolean(data, "gid-status", &gid_status)) { + VIR_WARN("missing gid-status in GID_STATUS_CHANGED event"); + return; + } + + if (virJSONValueObjectGetNumberUlong(data, "subnet-prefix", + &subnet_prefix)) { + VIR_WARN("missing subnet-prefix in GID_STATUS_CHANGED event"); + return; + } + + if (virJSONValueObjectGetNumberUlong(data, "interface-id", + &interface_id)) { + VIR_WARN("missing interface-id in GID_STATUS_CHANGED event"); + return; + } + + qemuMonitorEmitRdmaGidStatusChanged(mon, netdev, gid_status, subnet_prefix, + interface_id); +} + + int qemuMonitorJSONHumanCommandWithFd(qemuMonitorPtr mon, const char *cmd_str, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9cf971808c..6cf0ace5cf 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1703,6 +1703,57 @@ qemuProcessHandlePRManagerStatusChanged(qemuMonitorPtr mon ATTRIBUTE_UNUSED, } +static int +qemuProcessHandleRdmaGidStatusChanged(qemuMonitorPtr mon ATTRIBUTE_UNUSED, + virDomainObjPtr vm, const char *netdev, + bool gid_status, uint64_t subnet_prefix, + uint64_t interface_id, void *opaque) +{ + virQEMUDriverPtr driver = opaque; + struct qemuProcessEvent *processEvent = NULL; + qemuMonitorRdmaGidStatusChangedPrivatePtr rdmaGitStatusChangedPriv = NULL; + int ret = -1; + + virObjectLock(vm); + + VIR_DEBUG("netdev=%s,gid_status=%d,subnet_prefix=0x%lx,interface_id=0x%lx", + netdev, gid_status, subnet_prefix, interface_id); + + if (VIR_ALLOC(rdmaGitStatusChangedPriv) < 0) + goto out_unlock; + + if (VIR_STRDUP(rdmaGitStatusChangedPriv->netdev, netdev) < 0) + goto out_free; + + rdmaGitStatusChangedPriv->gid_status = gid_status; + rdmaGitStatusChangedPriv->subnet_prefix = subnet_prefix; + rdmaGitStatusChangedPriv->interface_id = interface_id; + + if (VIR_ALLOC(processEvent) < 0) + goto out_free; + + processEvent->eventType = QEMU_PROCESS_EVENT_RDMA_GID_STATUS_CHANGED; + processEvent->vm = virObjectRef(vm); + processEvent->data = rdmaGitStatusChangedPriv; + + if (virThreadPoolSendJob(driver->workerPool, 0, processEvent) < 0) { + qemuProcessEventFree(processEvent); + virObjectUnref(vm); + goto out_free; + } + + ret = 0; + goto out_unlock; + + out_free: + qemuMonitorEventRdmaGidStatusFree(rdmaGitStatusChangedPriv); + + out_unlock: + virObjectUnlock(vm); + return ret; +} + + static qemuMonitorCallbacks monitorCallbacks = { .eofNotify = qemuProcessHandleMonitorEOF, .errorNotify = qemuProcessHandleMonitorError, @@ -1732,6 +1783,7 @@ static qemuMonitorCallbacks monitorCallbacks = { .domainBlockThreshold = qemuProcessHandleBlockThreshold, .domainDumpCompleted = qemuProcessHandleDumpCompleted, .domainPRManagerStatusChanged = qemuProcessHandlePRManagerStatusChanged, + .domainRdmaGidStatusChanged = qemuProcessHandleRdmaGidStatusChanged, }; static void -- 2.17.2

2 3

[libvirt] [PATCH v2 0/2] Makefile.am cleanups
by Eric Blake 08 Jan '19

08 Jan '19

Since v1: - push patch 1, 2 that had successful reviews - new patch 1 - rewrite old patch 3 to remove all use of gnulib from examples/, rather than being partitioned based on what uses config.h (in part by reverting Jan's recent patch that added config.h everywhere) Eric Blake (2): examples: Drop event-test.c dependency on gnulib <verify.h> examples: Avoid gnulib, have standalone examples examples/Makefile.am | 5 ++--- examples/admin/client_close.c | 2 -- examples/admin/client_info.c | 3 +-- examples/admin/client_limits.c | 2 -- examples/admin/list_clients.c | 2 -- examples/admin/list_servers.c | 2 -- examples/admin/logging.c | 2 -- examples/admin/threadpool_params.c | 2 -- examples/dommigrate/dommigrate.c | 2 -- examples/domsuspend/suspend.c | 2 -- examples/domtop/domtop.c | 2 -- examples/hellolibvirt/hellolibvirt.c | 2 -- examples/object-events/event-test.c | 12 ++++++++---- examples/openauth/openauth.c | 2 -- examples/rename/rename.c | 2 -- 15 files changed, 11 insertions(+), 33 deletions(-) -- 2.20.1

3 5

[libvirt] [PATCH 0/2] syntax-check: Fix unmarked_diagnostics on FreeBSD
by Andrea Bolognani 08 Jan '19

08 Jan '19

... and fix some issues in the process. Andrea Bolognani (2): src: Fix a few unmarked_diagnostics issues syntax-check: Simplify and fix unmarked_diagnostics cfg.mk | 4 ++-- src/libxl/libxl_driver.c | 8 ++++---- src/openvz/openvz_driver.c | 4 ++-- src/qemu/qemu_agent.c | 2 +- src/qemu/qemu_domain.c | 2 +- src/vbox/vbox_snapshot_conf.c | 2 +- 6 files changed, 11 insertions(+), 11 deletions(-) -- 2.20.1

3 4

[libvirt] [dbus PATCH] util: fix virtDBusUtilDecodeUUID
by Pavel Hrdina 08 Jan '19

08 Jan '19

This function is supposed to convert ASCII character into its hex representation, however the current implementation was wrong because the first comparison would be false for all printable characters. In most cases it worked but for example '$' which is 0x24 in HEX would be incorrectly converted to 0x2[ which is obviously wrong. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1647823 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/util.c b/src/util.c index 9e11285..103bb29 100644 --- a/src/util.c +++ b/src/util.c @@ -182,11 +182,12 @@ virtDBusUtilDecodeUUID(const gchar *uuid) } static guchar -virtDBusUtilNumToHexchar(const guchar c) +virtDBusUtilNumToHexchar(const guchar n) { + guchar c = n & 0x0f; if (c < 10) return '0' + c; - return 'a' + (c & 0x0f) - 10; + return 'a' + c - 10; } static guchar -- 2.20.1

2 1

[libvirt] [PATCH] maint: Fix build with older automake
by Eric Blake 08 Jan '19

08 Jan '19

In a VPATH build, <config.h> is in the builddir, but it includes <config-post.h> from the top source directory; hence, we need to keep the -I(top_srcdir) directive that was accidentally removed from commit 7a879323 (the problem is not visible in an in-tree build). Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing as a build-breaker fix. gnulib/lib/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnulib/lib/Makefile.am b/gnulib/lib/Makefile.am index 601f74073c..5669551afb 100644 --- a/gnulib/lib/Makefile.am +++ b/gnulib/lib/Makefile.am @@ -26,3 +26,5 @@ SUFFIXES = noinst_LTLIBRARIES = include gnulib.mk + +AM_CPPFLAGS = -I$(top_srcdir) -- 2.20.1

1 0

[libvirt] [PATCH 0/3] Makefile.am cleanups
by Eric Blake 07 Jan '19

07 Jan '19

I noticed from IRC that Travis has been failing builds since our Jan 1 update of gnulib. I'm not sure what changed in the gnulib files to trip up clang, and I'm not really set up to test that this fixes the problem seen by Travis (it works locally for me using gcc - but gcc wasn't seeing the failure), but the ideas in the patch make sense. So, unless there is an easy way to make Travis run on candidate patches, I'll wait for a review rather than pushing this as a build-breaker. Eric Blake (3): maint: Drop unused GETTEXT_CPPFLAGS variable maint: Prefer AM_CPPFLAGS over INCLUDES maint: Avoid -Ignulib on standalone examples examples/Makefile.am | 8 +++++++- gnulib/lib/Makefile.am | 2 -- gnulib/tests/Makefile.am | 2 -- src/Makefile.am | 6 +++--- tests/Makefile.am | 6 +++--- tools/Makefile.am | 4 ++-- 6 files changed, 15 insertions(+), 13 deletions(-) -- 2.20.1

2 8

[libvirt] [PATCH] util: Fix the default log output to 'journald' when running under systemd
by Erik Skultety 07 Jan '19

07 Jan '19

Essentially, bring back the old behaviour as of commit eba36a38 which was later changed by commit ae06048bf5d. Even though all the stderr messages will eventually end up in the journal, we're not making use of the fields journald provides. https://bugzilla.redhat.com/show_bug.cgi?id=1592644 Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- src/util/virlog.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index cb6901d9bf..3ee58c5db6 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -223,11 +223,17 @@ virLogSetDefaultOutputToFile(const char *filename, bool privileged) int virLogSetDefaultOutput(const char *filename, bool godaemon, bool privileged) { - if (!godaemon) + bool have_journald = access("/run/systemd/journal/socket", W_OK) >= 0; + + if (godaemon) { + if (have_journald) + return virLogSetDefaultOutputToJournald(); + } else { + if (!isatty(STDIN_FILENO) && have_journald) + return virLogSetDefaultOutputToJournald(); + return virLogSetDefaultOutputToStderr(); - - if (access("/run/systemd/journal/socket", W_OK) >= 0) - return virLogSetDefaultOutputToJournald(); + } return virLogSetDefaultOutputToFile(filename, privileged); } -- 2.20.1

2 1

[libvirt] [PATCH 00/19] implement cgroups v2 devices support
by Pavel Hrdina 07 Jan '19

07 Jan '19

In cgroups v2 there is no devices controller, BPF should be used instead. Patches 3 - 12 will be squashed into single commit and they need to be compiled together, I've separated them to make review easier. Pavel Hrdina (19): util: introduce virbpf helpers vircgroup: introduce virCgroupV2DevicesAvailable vircgroup: introduce virCgroupV2DeviceLoadProg vircgroup: introduce virCgroupV2DeviceAttachProg vircgroup: introduce virCgroupV2DeviceDetectProg vircgroup: introduce virCgroupV2DeviceCreateProg vircgroup: introduce virCgroupV2DeviceReallocMap vircgroup: introduce virCgroupV2DevicePrepareProg vircgroup: introduce virCgroupV2DeviceRemoveProg vircgroup: introduce virCgroupV2DeviceGetPerms vircgroup: introduce virCgroupV2DeviceGetKey vircgroup: introduce virCgroupV2AllowDevice vircgroup: introduce virCgroupV2DenyDevice vircgroup: introduce virCgroupV2AllowAllDevices vircgroup: introduce virCgroupV2DenyAllDevices vircgroup: workaround devices in hybrid mode vircgroupv2: detech BPF program before removing cgroup vircgroupv2: use dummy process to workaround kernel bug with systemd vircgroupmock: mock virBPFQueryProg include/libvirt/virterror.h | 1 + src/Makefile.am | 1 + src/libvirt_private.syms | 17 + src/lxc/lxc_cgroup.c | 1 + src/qemu/qemu_cgroup.c | 6 +- src/util/Makefile.inc.am | 2 + src/util/virbpf.c | 263 ++++++++++++ src/util/virbpf.h | 249 ++++++++++++ src/util/vircgroup.c | 18 +- src/util/vircgroup.h | 1 + src/util/vircgroupbackend.h | 3 +- src/util/vircgrouppriv.h | 12 + src/util/vircgroupv1.c | 9 +- src/util/vircgroupv2.c | 638 +++++++++++++++++++++++++++++- src/util/virerror.c | 1 + src/util/virsystemd.c | 2 +- src/util/virsystemd.h | 2 + tests/vircgroupdata/hybrid.parsed | 2 +- tests/vircgroupmock.c | 11 + tests/vircgrouptest.c | 4 +- 20 files changed, 1233 insertions(+), 10 deletions(-) create mode 100644 src/util/virbpf.c create mode 100644 src/util/virbpf.h -- 2.20.1

2 20

[libvirt] [PATCH 0/3] Rebase LXC network definition to support version 3.0
by Julio Faracco 07 Jan '19

07 Jan '19

The series propose a new way to define NICs inside LXC native. It is needed because LXC version 3.X uses indexes to define NICs and the current algorithm is not able to support them. At least, if you consider settings defined using a random logic. Julio Faracco (3): lxc: refactoring LXC network definition with a sparse array. tests: Change legacy network configs to version 3.0 with indexes. tests: Include a random network testcase to test indexes. src/lxc/lxc_native.c | 191 ++++++++++++------ .../lxcconf2xml-ethernet-v3.config | 16 +- .../lxcconf2xml-fstab-v3.config | 10 +- .../lxcconf2xml-macvlannetwork-v3.config | 10 +- .../lxcconf2xml-miscnetwork-v3.config | 38 ++-- .../lxcconf2xml-physnetwork-v3.config | 14 +- .../lxcconf2xml-randomnetwork-v3.config | 21 ++ .../lxcconf2xml-randomnetwork.xml | 45 +++++ .../lxcconf2xml-simple-v3.config | 18 +- .../lxcconf2xml-vlannetwork-v3.config | 10 +- tests/lxcconf2xmltest.c | 1 + 11 files changed, 249 insertions(+), 125 deletions(-) create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-randomnetwork-v3.config create mode 100644 tests/lxcconf2xmldata/lxcconf2xml-randomnetwork.xml -- 2.19.1

2 4

[libvirt] [PATCH 0/2] News update for libvirt-5.0
by Han Han 07 Jan '19

07 Jan '19

Han Han (2): news: Add support for "stibp" x86_64 feature news: Add support for postcopy-requests migration statistics docs/news.xml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) -- 2.20.1

2 3

[libvirt] [jenkins-ci PATCH 0/2] Stop building Go projects on CentOS 7
by Andrea Bolognani 07 Jan '19

07 Jan '19

Found while creating a new CentOS 7 guest from scratch using lcitool. See the commit messages for more details. Andrea Bolognani (2): Stop building Go projects on CentOS 7 guests: Don't prepare CentOS 7 for Go projects guests/host_vars/libvirt-centos-7/main.yml | 2 -- guests/playbooks/build/projects/libvirt-go-xml.yml | 13 ++++++++++++- guests/playbooks/build/projects/libvirt-go.yml | 13 ++++++++++++- projects/libvirt-go-xml.yaml | 9 ++++++++- projects/libvirt-go.yaml | 9 ++++++++- 5 files changed, 40 insertions(+), 6 deletions(-) -- 2.19.2

3 5

[libvirt] [PATCH] lxc: allow empty path in URI for historical compatibility
by Daniel P. Berrangé 07 Jan '19

07 Jan '19

The use of 'lxc://' was mistakenly broken in: commit 4c8574c85c554e68de0d8bf9b85727954a5bea91 Author: Daniel P. Berrangé <berrange(a)redhat.com> Date: Wed Mar 28 12:49:29 2018 +0100 driver: ensure NULL URI isn't passed to drivers with whitelisted URIs Allow it again for historical compatibility. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/lxc/lxc_driver.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index de045c80bb..df15a0da50 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -140,7 +140,8 @@ static virDrvOpenStatus lxcConnectOpen(virConnectPtr conn, virCheckFlags(VIR_CONNECT_RO, VIR_DRV_OPEN_ERROR); /* If path isn't '/' then they typoed, tell them correct path */ - if (STRNEQ(conn->uri->path, "/") && + if (STRNEQ(conn->uri->path, "") && + STRNEQ(conn->uri->path, "/") && STRNEQ(conn->uri->path, "/system")) { virReportError(VIR_ERR_INTERNAL_ERROR, _("Unexpected LXC URI path '%s', try lxc:///system"), -- 2.19.2

2 1

[libvirt] [GSoC] Update ideas page
by Michal Prívozník 07 Jan '19

07 Jan '19

Dear list, Google announced another round of GSoC [1]. The organization applications can be filled mid January next year (~1.5 month to go). Please update our Ideas page [2] if you have any idea for student projects (you do not have to mentor it if you don't feel like it). Similarly, if you want to mentor certain idea and there is no mentor assigned yet, do not hesitate to add yourself there. Michal 1: https://developers.google.com/open-source/gsoc/timeline 2: https://wiki.libvirt.org/page/Google_Summer_of_Code_Ideas

2 1

[libvirt] [RFC PATCH] maint: let MIN/MAX evaluate only once, on modern compilers
by Eric Blake 04 Jan '19

04 Jan '19

We might as well take advantage of gcc's extensions for a safer MIN()/MAX() macro. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- RFC because we could also try to fall back to older gcc's typeof(a)_a=(a) when the newer __auto_type _a=(a) is not present, and because I don't know how to properly probe for __auto_type and/or typeof support in clang (I know that clang added __auto_type in 2015, per https://reviews.llvm.org/D12686) I also don't know if we have officially stated that we require gcc/clang (because of attribute((cleanup)), which really cannot be emulated without extensions), or if we still try to allow compilation with other compilers; if we have, I don't know if we have declared a minimum compiler version that we demand (qemu has recently demanded gcc 4.8 or clang 3.4 [branded 5.1 on Apple]). src/util/virutil.h | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/util/virutil.h b/src/util/virutil.h index 908d8920ec..364e354bcb 100644 --- a/src/util/virutil.h +++ b/src/util/virutil.h @@ -28,10 +28,26 @@ # include <sys/types.h> # ifndef MIN -# define MIN(a, b) ((a) < (b) ? (a) : (b)) +# if __GNUC_PREREQ(4, 9) +# define MIN(a, b) ({ \ + __auto_type _a = (a); \ + __auto_type _b = (b); \ + _a < _b ? _a : _b; \ + }) +# else +# define MIN(a, b) ((a) < (b) ? (a) : (b)) +# endif # endif # ifndef MAX -# define MAX(a, b) ((a) > (b) ? (a) : (b)) +# if __GNUC_PREREQ(4, 9) +# define MAX(a, b) ({ \ + __auto_type _a = (a); \ + __auto_type _b = (b); \ + _a > _b ? _a : _b; \ + }) +# else +# define MAX(a, b) ((a) > (b) ? (a) : (b)) +# endif # endif -- 2.20.1

3 4

[libvirt] [PATCH] maint: cfg.mk typo fix
by Eric Blake 04 Jan '19

04 Jan '19

Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing as trivial. cfg.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cfg.mk b/cfg.mk index 90ec8dfc60..e00213b7dd 100644 --- a/cfg.mk +++ b/cfg.mk @@ -1066,7 +1066,7 @@ sc_prohibit_backslash_alignment: # Some syntax rules pertaining to the usage of cleanup macros # implementing GNU C's cleanup attribute -# Rule to ensure that varibales declared using a cleanup macro are +# Rule to ensure that variables declared using a cleanup macro are # always initialized. sc_require_attribute_cleanup_initialization: @prohibit='VIR_AUTO((FREE|PTR)$.+$|CLOSE) *[^=]+;' \ -- 2.20.1

1 0

[libvirt] [PATCH RFC] qemu: caps: invalidate kvm capable qemu binaries on every restart
by Nikolay Shirokovskiy 04 Jan '19

04 Jan '19

If qemu binary exposes kvm then caps depends heavily on host state. We are already check explicitly some host features - kernel version, microcode version, nested flag state. This won't nesserily help if somebody change CPU on host. Let's instead invalidate such caps on every daemon restart. This makes kernel version and microcode version check excessive but nested flag is still need to be checked. Cache invalidating on restart is archived by keeping list of binaries that whose caps cache was validated at least once. If binary in not yet validated and supports kvm then we need to invalidate it's caps cache. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- If the patch will be accepted then I'll send a patch which removes mentioned excessive checks also. src/qemu/qemu_capabilities.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 51bf97b..649aba2 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -3264,6 +3264,7 @@ struct _virQEMUCapsCachePriv { virArch hostArch; unsigned int microcodeVersion; char *kernelVersion; + virHashTablePtr validated; /* cache whether /dev/kvm is usable as runUid:runGuid */ virTristateBool kvmUsable; @@ -3280,6 +3281,7 @@ virQEMUCapsCachePrivFree(void *privData) VIR_FREE(priv->libDir); VIR_FREE(priv->kernelVersion); + virHashFree(priv->validated); VIR_FREE(priv); } @@ -3952,10 +3954,19 @@ virQEMUCapsIsValid(void *data, bool kvmUsable; struct stat sb; bool kvmSupportsNesting; + bool validated = true; if (!qemuCaps->binary) return true; + if (!virHashLookup(priv->validated, qemuCaps->binary)) { + validated = false; + + /* If we fail to remember this binary is validated it is not problem, + * it will be validated again next time once again */ + virHashAddEntry(priv->validated, qemuCaps->binary, (void*)1); + } + if (qemuCaps->libvirtCtime != virGetSelfLastChanged() || qemuCaps->libvirtVersion != LIBVIR_VERSION_NUMBER) { VIR_DEBUG("Outdated capabilities for '%s': libvirt changed " @@ -4011,6 +4022,12 @@ virQEMUCapsIsValid(void *data, } if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_KVM)) { + if (!validated) { + VIR_DEBUG("Capabilities for QEMU that supports KVM need to be " + "updated after daemon restart"); + return false; + } + if (priv->microcodeVersion != qemuCaps->microcodeVersion) { VIR_DEBUG("Outdated capabilities for '%s': microcode version " "changed (%u vs %u)", @@ -4809,6 +4826,9 @@ virQEMUCapsCacheNew(const char *libDir, if (VIR_STRDUP(priv->libDir, libDir) < 0) goto error; + if (!(priv->validated = virHashCreate(1, NULL))) + goto error; + priv->hostArch = virArchFromHost(); priv->runUid = runUid; -- 1.8.3.1

2 1

[libvirt] [PATCH] docs: schemas: Decouple the virtio options from each other
by Erik Skultety 04 Jan '19

04 Jan '19

Currently, all of the VirtioOptions are under a single <optional> element, however, neither our parser/formatter or QEMU driver requires the presence of all the options if only a single one from the set has been specified, so fix it and silence the schema validator. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- docs/schemas/domaincommon.rng | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index 6518aff73a..aa50eac424 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -5498,6 +5498,8 @@ <attribute name="iommu"> <ref name="virOnOff"/> </attribute> + </optional> + <optional> <attribute name="ats"> <ref name="virOnOff"/> </attribute> -- 2.20.1

2 1

[libvirt] [PATCH] maint: update gnulib
by Eric Blake 03 Jan '19

03 Jan '19

In particular, this incorporates Roman's patches to allow 'make syntax-check' to work on BSD with its exec argv limitations that previously failed when trying to grep the large number of files present in libvirt. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Really just two changes since the new year copyright update, but posting for review to make sure this works on BSD boxes. * .gnulib 4652c7b...7216e3e (2): > maint.mk: Replace grep with $(GREP) > maint.mk: Split long argument lists .gnulib | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gnulib b/.gnulib index 4652c7bafa..7216e3e8d9 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit 4652c7bafa60332145f1e05a7de5f48e1bc56226 +Subproject commit 7216e3e8d9f914d216fb10abf7dbeafa6570eb87 -- 2.20.1

2 1

[libvirt] [PATCH] Remove even more Author(s): lines from source files
by Michal Privoznik 03 Jan '19

03 Jan '19

In 600462834f4ec1955a9a4 we've tried to remove Author(s): lines from comments at the beginning of our source files. Well, in some files while we removed the "Author" line we did not remove the actual list of authors. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- examples/dommigrate/dommigrate.c | 2 -- src/conf/interface_conf.c | 1 - src/conf/interface_conf.h | 1 - src/libvirt.c | 2 -- src/test/test_driver.c | 2 -- src/test/test_driver.h | 2 -- src/util/virbuffer.c | 2 -- src/util/virbuffer.h | 2 -- src/util/virconf.c | 2 -- src/util/virconf.h | 2 -- src/util/virthreadpool.h | 2 -- src/util/virxml.c | 2 -- src/util/virxml.h | 2 -- tests/testutils.c | 2 -- tests/testutils.h | 2 -- tools/virsh-completer.h | 3 --- tools/virsh-domain-monitor.c | 5 ----- tools/virsh-domain-monitor.h | 5 ----- tools/virsh-domain.c | 5 ----- tools/virsh-domain.h | 5 ----- tools/virsh-edit.c | 2 -- tools/virsh-host.c | 5 ----- tools/virsh-host.h | 5 ----- tools/virsh-interface.c | 5 ----- tools/virsh-interface.h | 5 ----- tools/virsh-network.c | 5 ----- tools/virsh-network.h | 5 ----- tools/virsh-nodedev.c | 5 ----- tools/virsh-nodedev.h | 5 ----- tools/virsh-nwfilter.c | 5 ----- tools/virsh-nwfilter.h | 5 ----- tools/virsh-pool.c | 5 ----- tools/virsh-pool.h | 5 ----- tools/virsh-secret.c | 5 ----- tools/virsh-secret.h | 5 ----- tools/virsh-snapshot.c | 5 ----- tools/virsh-snapshot.h | 5 ----- tools/virsh-volume.c | 5 ----- tools/virsh-volume.h | 5 ----- tools/virsh.c | 4 ---- tools/virsh.h | 4 ---- tools/virt-admin-completer.c | 3 --- tools/virt-admin-completer.h | 3 --- tools/virt-admin.h | 2 -- tools/virt-login-shell.c | 2 -- tools/vsh.c | 4 ---- tools/vsh.h | 4 ---- 47 files changed, 169 deletions(-) diff --git a/examples/dommigrate/dommigrate.c b/examples/dommigrate/dommigrate.c index 3fd078d55d..1b6072d138 100644 --- a/examples/dommigrate/dommigrate.c +++ b/examples/dommigrate/dommigrate.c @@ -18,8 +18,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Sahid Orentino Ferdjaoui <sahid.ferdjaoui(a)cloudwatt.com> */ #include <stdio.h> diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c index c4d2e1b9ab..c5360c8900 100644 --- a/src/conf/interface_conf.c +++ b/src/conf/interface_conf.c @@ -16,7 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * Laine Stump <laine(a)redhat.com> */ #include <config.h> diff --git a/src/conf/interface_conf.h b/src/conf/interface_conf.h index 24d0acd323..fb7bf932f1 100644 --- a/src/conf/interface_conf.h +++ b/src/conf/interface_conf.h @@ -16,7 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * Laine Stump <laine(a)redhat.com> */ #ifndef LIBVIRT_INTERFACE_CONF_H diff --git a/src/libvirt.c b/src/libvirt.c index 7c379495ad..cc1c3c6ea1 100644 --- a/src/libvirt.c +++ b/src/libvirt.c @@ -17,8 +17,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> */ #include <config.h> diff --git a/src/test/test_driver.c b/src/test/test_driver.c index b76f0b718e..1d81772a46 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -17,8 +17,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Berrange <berrange(a)redhat.com> */ #include <config.h> diff --git a/src/test/test_driver.h b/src/test/test_driver.h index 7201a40a52..ff7803da7f 100644 --- a/src/test/test_driver.h +++ b/src/test/test_driver.h @@ -17,8 +17,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Berrange <berrange(a)redhat.com> */ #ifndef LIBVIRT_TEST_DRIVER_H diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c index 8a2108f2f2..95c0dd1b96 100644 --- a/src/util/virbuffer.c +++ b/src/util/virbuffer.c @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> */ #include <config.h> diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h index 4b8111de8e..c3703710b7 100644 --- a/src/util/virbuffer.h +++ b/src/util/virbuffer.h @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> */ #ifndef LIBVIRT_VIRBUFFER_H diff --git a/src/util/virconf.c b/src/util/virconf.c index 88a869517e..4497972b1c 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> */ #include <config.h> diff --git a/src/util/virconf.h b/src/util/virconf.h index 411b8d669b..961a5338d4 100644 --- a/src/util/virconf.h +++ b/src/util/virconf.h @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> */ #ifndef LIBVIRT_VIRCONF_H diff --git a/src/util/virthreadpool.h b/src/util/virthreadpool.h index e3ff36998d..461682b01a 100644 --- a/src/util/virthreadpool.h +++ b/src/util/virthreadpool.h @@ -17,8 +17,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * Hu Tao <hutao(a)cn.fujitsu.com> - * Daniel P. Berrange <berrange(a)redhat.com> */ #ifndef LIBVIRT_VIRTHREADPOOL_H diff --git a/src/util/virxml.c b/src/util/virxml.c index 3ed44e9036..8eb201fddf 100644 --- a/src/util/virxml.c +++ b/src/util/virxml.c @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> */ #include <config.h> diff --git a/src/util/virxml.h b/src/util/virxml.h index 8d4ab0a427..23a4da1b7e 100644 --- a/src/util/virxml.h +++ b/src/util/virxml.h @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> */ #ifndef LIBVIRT_VIRXML_H diff --git a/tests/testutils.c b/tests/testutils.c index 4fe95bda8b..d2219ad21e 100644 --- a/tests/testutils.c +++ b/tests/testutils.c @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Karel Zak <kzak(a)redhat.com> */ #include <config.h> diff --git a/tests/testutils.h b/tests/testutils.h index 11d99a74b8..658f9053ad 100644 --- a/tests/testutils.h +++ b/tests/testutils.h @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Karel Zak <kzak(a)redhat.com> */ #ifndef LIBVIRT_TESTUTILS_H diff --git a/tools/virsh-completer.h b/tools/virsh-completer.h index 4069d976b8..4563fd76ac 100644 --- a/tools/virsh-completer.h +++ b/tools/virsh-completer.h @@ -16,9 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Michal Privoznik <mprivozn(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_COMPLETER_H diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 06e7fec7be..c692cc5128 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-domain-monitor.h b/tools/virsh-domain-monitor.h index d641df4c13..d24e0bbd40 100644 --- a/tools/virsh-domain-monitor.h +++ b/tools/virsh-domain-monitor.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_DOMAIN_MONITOR_H diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 24f78520de..e63fc028b9 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-domain.h b/tools/virsh-domain.h index 71d7902fee..119d4422a1 100644 --- a/tools/virsh-domain.h +++ b/tools/virsh-domain.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_DOMAIN_H diff --git a/tools/virsh-edit.c b/tools/virsh-edit.c index d97794fed3..5091ac74b7 100644 --- a/tools/virsh-edit.c +++ b/tools/virsh-edit.c @@ -39,8 +39,6 @@ * - everything else is taken as success * For example: * #define EDIT_DEFINE (dom_edited = virDomainDefineXML(ctl->conn, doc_edited)) - * - * Michal Privoznik <mprivozn(a)redhat.com> */ #ifndef EDIT_GET_XML diff --git a/tools/virsh-host.c b/tools/virsh-host.c index b7f86bdd91..be3c2cf1cb 100644 --- a/tools/virsh-host.c +++ b/tools/virsh-host.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-host.h b/tools/virsh-host.h index cdec9ae920..395e39cd57 100644 --- a/tools/virsh-host.h +++ b/tools/virsh-host.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_HOST_H diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index 1eb1a27ac7..7e84ee3c52 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #define VIRSH_COMMON_OPT_INTERFACE(cflags) \ diff --git a/tools/virsh-interface.h b/tools/virsh-interface.h index 03e6ec28a5..e110e3a8e2 100644 --- a/tools/virsh-interface.h +++ b/tools/virsh-interface.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_INTERFACE_H diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 440b23d8a8..a30b4f4389 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-network.h b/tools/virsh-network.h index 2aeb894484..0fff4b7748 100644 --- a/tools/virsh-network.h +++ b/tools/virsh-network.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_NETWORK_H diff --git a/tools/virsh-nodedev.c b/tools/virsh-nodedev.c index e6f963ea66..9da3ad2e19 100644 --- a/tools/virsh-nodedev.c +++ b/tools/virsh-nodedev.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-nodedev.h b/tools/virsh-nodedev.h index 8be21d1b17..e58eedf6ea 100644 --- a/tools/virsh-nodedev.h +++ b/tools/virsh-nodedev.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_NODEDEV_H diff --git a/tools/virsh-nwfilter.c b/tools/virsh-nwfilter.c index b680ea082c..952fb2f391 100644 --- a/tools/virsh-nwfilter.c +++ b/tools/virsh-nwfilter.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-nwfilter.h b/tools/virsh-nwfilter.h index 14292424fa..2ac9bdff7f 100644 --- a/tools/virsh-nwfilter.h +++ b/tools/virsh-nwfilter.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_NWFILTER_H diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index 75ec572af2..70ca39bd3d 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-pool.h b/tools/virsh-pool.h index c6edfa5541..458e843d3c 100644 --- a/tools/virsh-pool.h +++ b/tools/virsh-pool.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_POOL_H diff --git a/tools/virsh-secret.c b/tools/virsh-secret.c index 87239ff60b..30bdec2657 100644 --- a/tools/virsh-secret.c +++ b/tools/virsh-secret.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-secret.h b/tools/virsh-secret.h index 03b7a6a16c..71271f7c80 100644 --- a/tools/virsh-secret.h +++ b/tools/virsh-secret.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_SECRET_H diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index 73861957ba..e3d4cda0fc 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-snapshot.h b/tools/virsh-snapshot.h index e999a9bb7b..c9e706ded6 100644 --- a/tools/virsh-snapshot.h +++ b/tools/virsh-snapshot.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_SNAPSHOT_H diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 6cd989446e..7294d6f045 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virsh-volume.h b/tools/virsh-volume.h index ce4ee8a490..66cf9cfa54 100644 --- a/tools/virsh-volume.h +++ b/tools/virsh-volume.h @@ -16,11 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> - * */ #ifndef LIBVIRT_VIRSH_VOLUME_H diff --git a/tools/virsh.c b/tools/virsh.c index 8428e539f6..b41304a888 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -16,10 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> */ #include <config.h> diff --git a/tools/virsh.h b/tools/virsh.h index dcf98c773b..254ce3289e 100644 --- a/tools/virsh.h +++ b/tools/virsh.h @@ -16,10 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> */ #ifndef LIBVIRT_VIRSH_H diff --git a/tools/virt-admin-completer.c b/tools/virt-admin-completer.c index 2cd471f32c..e0e36f9756 100644 --- a/tools/virt-admin-completer.c +++ b/tools/virt-admin-completer.c @@ -16,9 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Michal Privoznik <mprivozn(a)redhat.com> - * */ #include <config.h> diff --git a/tools/virt-admin-completer.h b/tools/virt-admin-completer.h index 5358276daf..a0b09f1ec9 100644 --- a/tools/virt-admin-completer.h +++ b/tools/virt-admin-completer.h @@ -16,9 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Michal Privoznik <mprivozn(a)redhat.com> - * */ #ifndef LIBVIRT_VIRT_ADMIN_COMPLETER_H diff --git a/tools/virt-admin.h b/tools/virt-admin.h index de5a65ebdc..a58bb7bef2 100644 --- a/tools/virt-admin.h +++ b/tools/virt-admin.h @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Erik Skultety <eskultet(a)redhat.com> */ #ifndef LIBVIRT_VIRT_ADMIN_H diff --git a/tools/virt-login-shell.c b/tools/virt-login-shell.c index d0b1e1e368..ee5c04f9c2 100644 --- a/tools/virt-login-shell.c +++ b/tools/virt-login-shell.c @@ -16,8 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Walsh <dwalsh(a)redhat.com> */ #include <config.h> diff --git a/tools/vsh.c b/tools/vsh.c index de887a9e76..610de4495b 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -16,10 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> */ #include <config.h> diff --git a/tools/vsh.h b/tools/vsh.h index d5f15622f8..68fbe0a1f2 100644 --- a/tools/vsh.h +++ b/tools/vsh.h @@ -16,10 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library. If not, see * <http://www.gnu.org/licenses/>. - * - * Daniel Veillard <veillard(a)redhat.com> - * Karel Zak <kzak(a)redhat.com> - * Daniel P. Berrange <berrange(a)redhat.com> */ #ifndef LIBVIRT_VSH_H -- 2.19.2

2 1

[libvirt] [PATCH 0/3] Allow adding mountOpts to the storage pool mount command
by John Ferlan 03 Jan '19

03 Jan '19

Modify the generation of the command line to allow usage of a new XML pool source directory "mount_opts" in order to allow (for instance) starting an NFS pool with specific mount options. John Ferlan (3): storage: Add mount options attribute for pool source dir element storage: Add mountOpts to the storage pool mount command line virsh: Add source-mount-opts for pool commands docs/formatstorage.html.in | 8 ++++++++ docs/schemas/storagepool.rng | 5 +++++ src/conf/storage_conf.c | 12 +++++++++-- src/conf/storage_conf.h | 3 +++ src/storage/storage_util.c | 4 ++++ .../pool-netfs-mountopts.argv | 1 + tests/storagepoolxml2argvtest.c | 1 + .../pool-netfs-mountopts.xml | 20 +++++++++++++++++++ .../pool-netfs-mountopts.xml | 20 +++++++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + tools/virsh-pool.c | 15 +++++++++++--- tools/virsh.pod | 5 +++++ 12 files changed, 90 insertions(+), 5 deletions(-) create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-mountopts.argv create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-mountopts.xml create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-mountopts.xml -- 2.17.2

2 5

[libvirt] configuration support to allow devices into cgroup devices devices.list inside libvirt_lxc container
by Mohan R 02 Jan '19

02 Jan '19

Hi, I was having trouble with losetup inside libvirt_lxc container. Then I found that <mknod state="on"> will provide CAP_MKNOD capability. Even after enabling CAP_MKNOD in my container, I was not able to do 'losetup' because cgroup's device.list for my container dont have 'rwm' flags for loop devices ('b 7:* rwm' in /sys/fs/cgroup/devices/machine.slice/machine- lxc*.scope/user/*/c1.session/devices.list) Currently I have to manually do echo "b 7:* rwm" into /sys/fs/cgroup/devices/machine.slice/machine-lxc*.scope/devices.allow file before I login into the container in order to use loop devices. It will be useful if we have a way to do this through domain xml rather than manually doing it like what I'm doing now. I looked into rng files, but I'm not able to find a way to define 'b 7:* rwm' in xml. I just want to check with the devs if this is possible already. Otherwise I'll file one improvement bug. I think lxc already have a way to do this through lxc.cgroup.devices.allow Thanks, Mohan R

2 1

[libvirt] configuration support to allow devices into cgroup devices device.list inside libvirt_lxc container
by Mohan R 29 Dec '18

29 Dec '18

Hi, I was having trouble with losetup inside libvirt_lxc container. Then I found that <mknod state="on"> will provide CAP_MKNOD capability. Even after enabling CAP_MKNOD in my container, I was not able to do 'losetup' because cgroup's device.list for my container dont have 'rwm' flags for loop devices ('b 7:* rwm' in /sys/fs/cgroup/devices/machine.slice/machine- lxc*.scope/user/*/c1.session/devices.list) Currently I have to manually do echo "b 7:* rwm" into /sys/fs/cgroup/devices/machine.slice/machine-lxc*.scope/device.allow file before I login into the container in order to use loop devices. It will be useful if we have a way to do this through domain xml rather than manually doing it like what I'm doing now. I looked into rng files, but I'm not able to find a way to define 'b 7:* rwm' in xml. I just want to check with the devs if this is possible already. Otherwise I'll file one improvement bug. I think lxc already have a way to do this through lxc.cgroup.devices.allow Thanks, Mohan R

1 0