- Devel - libvirt List Archives

[libvirt] [PATCH 0/9] rpc: make client streams multi-thread safer
by Nikolay Shirokovskiy 11 Feb '19

11 Feb '19

Nikolay Shirokovskiy (9): rpc: fix race on stream abort/finish and server side abort rpc: use single function to send stream messages rpc: remove unused virNetClientSendNoReply rpc: fix propagation of errors from server rpc: add mising locking in virNetClientStreamRecvHole rpc: client: incapsulate error checks rpc: client: don't set incomingEOF on errors rpc: client stream: dispose private data on stream dispose rpc: client: stream: fix multi thread abort/finish src/datatypes.c | 2 + src/datatypes.h | 1 + src/libvirt_remote.syms | 6 +- src/remote/remote_driver.c | 27 ++------ src/rpc/gendispatch.pl | 3 +- src/rpc/virnetclient.c | 146 ++++++++++++++++++++++--------------------- src/rpc/virnetclient.h | 6 +- src/rpc/virnetclientstream.c | 110 ++++++++++++++++++++++++-------- src/rpc/virnetclientstream.h | 17 ++++- 9 files changed, 188 insertions(+), 130 deletions(-) -- 1.8.3.1

2 14

[libvirt] [PATCH 0/8] qemu: Add support for setting post-copy migration bandwidth
by Jiri Denemark 09 Feb '19

09 Feb '19

This series adds a new VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY typed parameter for virDomainMigrate3 and virDomainMigrateToURI3 for setting maximum post-copy migration bandwidth. In case the initial VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY value turns out to be suboptimal a new VIR_DOMAIN_MIGRATE_MAX_SPEED_POSTCOPY flag for virDomainMigrateSetMaxSpeed and virDomainMigrateGetMaxSpeed may be used to set/get the maximum post-copy migration bandwidth while migration is already running. Jiri Denemark (8): qemu: Use C99 initializers for qemuMigrationParamsTPMap qemu: Add optional unit to qemuMigrationParamsTPMapItem qemu: Rework qemuDomainMigrateSetMaxSpeed qemu: Make migration params usable outside migration Public API for post-copy migration bandwidth qemu: Implement VIR_MIGRATE_PARAM_BANDWIDTH_POSTCOPY qemu: Implement VIR_DOMAIN_MIGRATE_MAX_SPEED_POSTCOPY flag virsh: Add support for setting post-copy migration bandwidth include/libvirt/libvirt-domain.h | 15 ++++ src/libvirt-domain.c | 11 ++- src/qemu/qemu_driver.c | 118 +++++++++++++++++++++++------- src/qemu/qemu_migration.h | 1 + src/qemu/qemu_migration_params.c | 122 +++++++++++++++++++++++-------- src/qemu/qemu_migration_params.h | 10 +++ tools/virsh-domain.c | 33 ++++++++- tools/virsh.pod | 15 +++- 8 files changed, 260 insertions(+), 65 deletions(-) -- 2.20.1

3 19

[libvirt] [PATCH 0/2] A couple of capabilities related adjustments
by John Ferlan 08 Feb '19

08 Feb '19

Peeling the onion in my series to update the QEMU capabilites replies: https://www.redhat.com/archives/libvir-list/2019-January/msg00793.html resulted in consideration of a possible alternative to how the SEV capability checking "works". As it turns out, the initial changes "massaged" the .replies output to add a "fake" reply on an Intel CPU for what amounts to AMD specific output. This naturally resulted in a "problem" when the next batch of a capabilites was created and there was no sev output, so an adjustment was made to limit what was tested to one capabilities version. Since there isn't separate Intel/AMD x86_64 output, the first patch in the series will alter the return for virQEMUCapsProbeQMPSEVCapabilities so that 0 would "change" into 1 for the mocked environment and allow the sev-guest bit to be set which allows QEMU_CAPS_SEV_GUEST to be set for any x86_64 arch environment. This only affects how qemuxml2argvtest handles generation of DO_TEST_CAPS_LATEST for launch-security-sev. The XML generated isn't modified, nor is the reply output data since that's separate. The key is the "0" return meaning a GenericError which is assumed to be returned when compiled-in support for SEV isn't there, but *could* be if the underlying hardware arch supported it. For the test purpose we have, that doesn't matter unless someone wants to go through the trouble of separating the caps*.replies files into "Intel" and "AMD" specific output. So yes a "workaround" of sorts, but nonetheless an alternative to the current static checking of what's been deemed incorrect reply data. The second somewhat unrelated patch is fallout of the review discussion about having a consistent process. I suspect it's a "starting point" from which we can evolve to create a consistent/repeatable process to create caps*.replies. John Ferlan (2): tests: Add mocking for qemuMonitorJSONGetSEVCapabilities tests: Document procedure to build QEMU for *.replies generation tests/qemucapabilitiestest.c | 34 ++++++++++++- tests/qemucapsprobemock.c | 50 +++++++++++++++++++ ...=> launch-security-sev.x86_64-latest.args} | 0 tests/qemuxml2argvtest.c | 2 +- 4 files changed, 83 insertions(+), 3 deletions(-) rename tests/qemuxml2argvdata/{launch-security-sev.x86_64-2.12.0.args => launch-security-sev.x86_64-latest.args} (100%) -- 2.20.1

4 8

[libvirt] [PATCH] docs: storage: owner/group default to libvirtd UID/GID
by Cole Robinson 08 Feb '19

08 Feb '19

Commit fafcc818f changed the docs to say that when creating a pool directory or file volume with no owner/group specified, they will be inherited from the parent directory. This isn't correct now and doesn't seem to have ever been correct In reality default owner/group is whatever UID/GID libvirtd is running as Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/formatstorage.html.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/formatstorage.html.in b/docs/formatstorage.html.in index 6ebd23549f..968651330f 100644 --- a/docs/formatstorage.html.in +++ b/docs/formatstorage.html.in @@ -478,8 +478,8 @@ The <code>owner</code> element contains the numeric user ID. The <code>group</code> element contains the numeric group ID. If <code>owner</code> or <code>group</code> aren't specified when - creating a directory, the values are inherited from the parent - directory. The <code>label</code> element contains the MAC (eg SELinux) + creating a directory, the UID and GID of the libvirtd process are used. + The <code>label</code> element contains the MAC (eg SELinux) label string. <span class="since">Since 0.4.1</span> For running directory or filesystem based pools, these fields @@ -776,8 +776,8 @@ The <code>owner</code> element contains the numeric user ID. The <code>group</code> element contains the numeric group ID. If <code>owner</code> or <code>group</code> aren't specified when - creating a supported volume, the values are inherited from the parent - directory. The <code>label</code> element contains the MAC (eg SELinux) + creating a supported volume, the UID and GID of the libvirtd process + are used. The <code>label</code> element contains the MAC (eg SELinux) label string. For existing directory or filesystem based volumes, these fields will be filled with the values used by the existing file. -- 2.20.1

2 1

[libvirt] [PATCH 0/3] qemu: Add support for parallel migration
by Jiri Denemark 08 Feb '19

08 Feb '19

This series adds a new VIR_MIGRATE_PARALLEL flag for migration APIs which will ask the hypervisor to use multiple parallel connections for migrating a domain. The number of parallel connections can be set using VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS typed parameter. Jiri Denemark (3): Public API for parallel migration qemu: Add support for parallel migration virsh: Add options for parallel migration include/libvirt/libvirt-domain.h | 14 ++++++++++++++ src/qemu/qemu_migration.c | 9 ++++++--- src/qemu/qemu_migration.h | 5 ++++- src/qemu/qemu_migration_params.c | 18 ++++++++++++++++++ src/qemu/qemu_migration_params.h | 2 ++ tools/virsh-domain.c | 19 +++++++++++++++++++ tools/virsh.pod | 7 +++++++ 7 files changed, 70 insertions(+), 4 deletions(-) -- 2.20.1

2 4

[libvirt] [PATCH 0/9] qemu: Make qemu_domain more organized and consistent
by Andrea Bolognani 08 Feb '19

08 Feb '19

A while ago I was looking at the code and got annoyed by the lack of consistency, both internal and external. This series addresses most of it. Andrea Bolognani (9): qemu: Remove redundant condition qemu: Use more specific prefixes qemu: Move functions around qemu: Add arch parameter to qemuDomainMachine*() qemu: Add arch checks to qemuDomainMachine*() qemu: Remove useless ARCH_IS_X86() call qemu: Make most qemuDomainMachine*() functions static qemu: Move qemuDomainSupportsPCI() to qemu_domain qemu: Unify style for qemuDomain*() src/qemu/qemu_capabilities.c | 10 +- src/qemu/qemu_domain.c | 250 +++++++++++++++++++++------------ src/qemu/qemu_domain.h | 29 ++-- src/qemu/qemu_domain_address.c | 22 --- 4 files changed, 175 insertions(+), 136 deletions(-) -- 2.20.1

2 10

[libvirt] [PATCH] util: Use a semicolon for all VIR_DEFINE_AUTOPTR_FUNC
by John Ferlan 08 Feb '19

08 Feb '19

For consistency, let's use the semicolon for all definitions. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- As discussed in the other series - src/qemu/qemu_migration_params.h | 2 +- src/util/virauthconfig.h | 2 +- src/util/virbitmap.h | 2 +- src/util/virbuffer.c | 2 +- src/util/virbuffer.h | 2 +- src/util/vircommand.h | 2 +- src/util/virerror.h | 2 +- src/util/virfile.h | 2 +- src/util/virfirewall.h | 2 +- src/util/virhash.h | 2 +- src/util/virjson.h | 2 +- src/util/virmacaddr.h | 2 +- src/util/virmdev.h | 4 ++-- src/util/virnetdev.c | 2 +- src/util/virnetdev.h | 2 +- src/util/virnetdevip.h | 4 ++-- src/util/virnetdevvlan.h | 2 +- src/util/virnetlink.c | 2 +- src/util/virnetlink.h | 2 +- src/util/virpci.h | 6 +++--- src/util/virperf.h | 2 +- src/util/virscsi.c | 2 +- src/util/virscsi.h | 2 +- src/util/virscsivhost.h | 2 +- src/util/virsocketaddr.h | 2 +- src/util/virstring.h | 2 +- src/util/virusb.h | 2 +- 27 files changed, 31 insertions(+), 31 deletions(-) diff --git a/src/qemu/qemu_migration_params.h b/src/qemu/qemu_migration_params.h index 2460684a00..233ebe772b 100644 --- a/src/qemu/qemu_migration_params.h +++ b/src/qemu/qemu_migration_params.h @@ -90,7 +90,7 @@ qemuMigrationParamsNew(void); void qemuMigrationParamsFree(qemuMigrationParamsPtr migParams); -VIR_DEFINE_AUTOPTR_FUNC(qemuMigrationParams, qemuMigrationParamsFree) +VIR_DEFINE_AUTOPTR_FUNC(qemuMigrationParams, qemuMigrationParamsFree); int qemuMigrationParamsApply(virQEMUDriverPtr driver, diff --git a/src/util/virauthconfig.h b/src/util/virauthconfig.h index 93bb434616..603ef89d25 100644 --- a/src/util/virauthconfig.h +++ b/src/util/virauthconfig.h @@ -41,6 +41,6 @@ int virAuthConfigLookup(virAuthConfigPtr auth, const char *credname, const char **value); -VIR_DEFINE_AUTOPTR_FUNC(virAuthConfig, virAuthConfigFree) +VIR_DEFINE_AUTOPTR_FUNC(virAuthConfig, virAuthConfigFree); #endif /* LIBVIRT_VIRAUTHCONFIG_H */ diff --git a/src/util/virbitmap.h b/src/util/virbitmap.h index dfb30b3bc8..c54e203971 100644 --- a/src/util/virbitmap.h +++ b/src/util/virbitmap.h @@ -154,6 +154,6 @@ void virBitmapSubtract(virBitmapPtr a, virBitmapPtr b) void virBitmapShrink(virBitmapPtr map, size_t b); -VIR_DEFINE_AUTOPTR_FUNC(virBitmap, virBitmapFree) +VIR_DEFINE_AUTOPTR_FUNC(virBitmap, virBitmapFree); #endif /* LIBVIRT_VIRBITMAP_H */ diff --git a/src/util/virbuffer.c b/src/util/virbuffer.c index 95c0dd1b96..01d71f1b59 100644 --- a/src/util/virbuffer.c +++ b/src/util/virbuffer.c @@ -661,7 +661,7 @@ virBufferEscapePairFree(virBufferEscapePairPtr pair) VIR_FREE(pair); } -VIR_DEFINE_AUTOPTR_FUNC(virBufferEscapePair, virBufferEscapePairFree) +VIR_DEFINE_AUTOPTR_FUNC(virBufferEscapePair, virBufferEscapePairFree); /** diff --git a/src/util/virbuffer.h b/src/util/virbuffer.h index c3703710b7..8bf6bee644 100644 --- a/src/util/virbuffer.h +++ b/src/util/virbuffer.h @@ -119,6 +119,6 @@ int virBufferGetIndent(const virBuffer *buf, bool dynamic); void virBufferTrim(virBufferPtr buf, const char *trim, int len); void virBufferAddStr(virBufferPtr buf, const char *str); -VIR_DEFINE_AUTOPTR_FUNC(virBuffer, virBufferFreeAndReset) +VIR_DEFINE_AUTOPTR_FUNC(virBuffer, virBufferFreeAndReset); #endif /* LIBVIRT_VIRBUFFER_H */ diff --git a/src/util/vircommand.h b/src/util/vircommand.h index dbf5041890..99849051f8 100644 --- a/src/util/vircommand.h +++ b/src/util/vircommand.h @@ -219,6 +219,6 @@ int virCommandRunNul(virCommandPtr cmd, virCommandRunNulFunc func, void *data); -VIR_DEFINE_AUTOPTR_FUNC(virCommand, virCommandFree) +VIR_DEFINE_AUTOPTR_FUNC(virCommand, virCommandFree); #endif /* LIBVIRT_VIRCOMMAND_H */ diff --git a/src/util/virerror.h b/src/util/virerror.h index d9d3109a4c..213bc3f606 100644 --- a/src/util/virerror.h +++ b/src/util/virerror.h @@ -206,6 +206,6 @@ bool virLastErrorIsSystemErrno(int errnum); void virErrorPreserveLast(virErrorPtr *saveerr); void virErrorRestore(virErrorPtr *savederr); -VIR_DEFINE_AUTOPTR_FUNC(virError, virFreeError) +VIR_DEFINE_AUTOPTR_FUNC(virError, virFreeError); #endif /* LIBVIRT_VIRERROR_H */ diff --git a/src/util/virfile.h b/src/util/virfile.h index 65432da13a..be612af770 100644 --- a/src/util/virfile.h +++ b/src/util/virfile.h @@ -383,7 +383,7 @@ int virFileInData(int fd, int *inData, long long *length); -VIR_DEFINE_AUTOPTR_FUNC(virFileWrapperFd, virFileWrapperFdFree) +VIR_DEFINE_AUTOPTR_FUNC(virFileWrapperFd, virFileWrapperFdFree); int virFileGetXAttr(const char *path, const char *name, diff --git a/src/util/virfirewall.h b/src/util/virfirewall.h index 2a6fc30eb7..e3ad1adb6b 100644 --- a/src/util/virfirewall.h +++ b/src/util/virfirewall.h @@ -115,6 +115,6 @@ int virFirewallApply(virFirewallPtr firewall); void virFirewallSetLockOverride(bool avoid); -VIR_DEFINE_AUTOPTR_FUNC(virFirewall, virFirewallFree) +VIR_DEFINE_AUTOPTR_FUNC(virFirewall, virFirewallFree); #endif /* LIBVIRT_VIRFIREWALL_H */ diff --git a/src/util/virhash.h b/src/util/virhash.h index 0c849561f8..2df1a5d12a 100644 --- a/src/util/virhash.h +++ b/src/util/virhash.h @@ -197,6 +197,6 @@ void *virHashSearch(const virHashTable *table, virHashSearcher iter, /* Convenience for when VIR_FREE(value) is sufficient as a data freer. */ void virHashValueFree(void *value, const void *name); -VIR_DEFINE_AUTOPTR_FUNC(virHashTable, virHashFree) +VIR_DEFINE_AUTOPTR_FUNC(virHashTable, virHashFree); #endif /* LIBVIRT_VIRHASH_H */ diff --git a/src/util/virjson.h b/src/util/virjson.h index d815e60de9..3dee103aba 100644 --- a/src/util/virjson.h +++ b/src/util/virjson.h @@ -158,6 +158,6 @@ char *virJSONStringReformat(const char *jsonstr, bool pretty); virJSONValuePtr virJSONValueObjectDeflatten(virJSONValuePtr json); -VIR_DEFINE_AUTOPTR_FUNC(virJSONValue, virJSONValueFree) +VIR_DEFINE_AUTOPTR_FUNC(virJSONValue, virJSONValueFree); #endif /* LIBVIRT_VIRJSON_H */ diff --git a/src/util/virmacaddr.h b/src/util/virmacaddr.h index 3999de3421..1deaf087e0 100644 --- a/src/util/virmacaddr.h +++ b/src/util/virmacaddr.h @@ -64,6 +64,6 @@ bool virMacAddrIsMulticast(const virMacAddr *addr); bool virMacAddrIsBroadcastRaw(const unsigned char s[VIR_MAC_BUFLEN]); void virMacAddrFree(virMacAddrPtr addr); -VIR_DEFINE_AUTOPTR_FUNC(virMacAddr, virMacAddrFree) +VIR_DEFINE_AUTOPTR_FUNC(virMacAddr, virMacAddrFree); #endif /* LIBVIRT_VIRMACADDR_H */ diff --git a/src/util/virmdev.h b/src/util/virmdev.h index aafc8b9317..d787d354e4 100644 --- a/src/util/virmdev.h +++ b/src/util/virmdev.h @@ -137,7 +137,7 @@ int virMediatedDeviceTypeReadAttrs(const char *sysfspath, virMediatedDeviceTypePtr *type); -VIR_DEFINE_AUTOPTR_FUNC(virMediatedDevice, virMediatedDeviceFree) -VIR_DEFINE_AUTOPTR_FUNC(virMediatedDeviceType, virMediatedDeviceTypeFree) +VIR_DEFINE_AUTOPTR_FUNC(virMediatedDevice, virMediatedDeviceFree); +VIR_DEFINE_AUTOPTR_FUNC(virMediatedDeviceType, virMediatedDeviceTypeFree); #endif /* LIBVIRT_VIRMDEV_H */ diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 50947b302b..aeb9caab2a 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -121,7 +121,7 @@ virNetDevMcastEntryFree(virNetDevMcastEntryPtr entry) VIR_FREE(entry); } -VIR_DEFINE_AUTOPTR_FUNC(virNetDevMcastEntry, virNetDevMcastEntryFree) +VIR_DEFINE_AUTOPTR_FUNC(virNetDevMcastEntry, virNetDevMcastEntryFree); typedef struct _virNetDevMcastList virNetDevMcastList; typedef virNetDevMcastList *virNetDevMcastListPtr; diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h index 3982097cdf..6f6094eebe 100644 --- a/src/util/virnetdev.h +++ b/src/util/virnetdev.h @@ -311,6 +311,6 @@ int virNetDevSysfsFile(char **pf_sysfs_device_link, int virNetDevRunEthernetScript(const char *ifname, const char *script) ATTRIBUTE_NOINLINE; -VIR_DEFINE_AUTOPTR_FUNC(virNetDevRxFilter, virNetDevRxFilterFree) +VIR_DEFINE_AUTOPTR_FUNC(virNetDevRxFilter, virNetDevRxFilterFree); #endif /* LIBVIRT_VIRNETDEV_H */ diff --git a/src/util/virnetdevip.h b/src/util/virnetdevip.h index 1ecb4eae01..376ac32c47 100644 --- a/src/util/virnetdevip.h +++ b/src/util/virnetdevip.h @@ -94,7 +94,7 @@ void virNetDevIPInfoClear(virNetDevIPInfoPtr ip); int virNetDevIPInfoAddToDev(const char *ifname, virNetDevIPInfo const *ipInfo); -VIR_DEFINE_AUTOPTR_FUNC(virNetDevIPAddr, virNetDevIPAddrFree) -VIR_DEFINE_AUTOPTR_FUNC(virNetDevIPRoute, virNetDevIPRouteFree) +VIR_DEFINE_AUTOPTR_FUNC(virNetDevIPAddr, virNetDevIPAddrFree); +VIR_DEFINE_AUTOPTR_FUNC(virNetDevIPRoute, virNetDevIPRouteFree); #endif /* LIBVIRT_VIRNETDEVIP_H */ diff --git a/src/util/virnetdevvlan.h b/src/util/virnetdevvlan.h index 8fe3a4dfa7..2a13759550 100644 --- a/src/util/virnetdevvlan.h +++ b/src/util/virnetdevvlan.h @@ -48,6 +48,6 @@ void virNetDevVlanFree(virNetDevVlanPtr vlan); int virNetDevVlanEqual(const virNetDevVlan *a, const virNetDevVlan *b); int virNetDevVlanCopy(virNetDevVlanPtr dst, const virNetDevVlan *src); -VIR_DEFINE_AUTOPTR_FUNC(virNetDevVlan, virNetDevVlanFree) +VIR_DEFINE_AUTOPTR_FUNC(virNetDevVlan, virNetDevVlanFree); #endif /* LIBVIRT_VIRNETDEVVLAN_H */ diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 62066a33d2..1d8467e643 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -63,7 +63,7 @@ typedef struct nl_handle virNetlinkHandle; typedef struct nl_sock virNetlinkHandle; # endif -VIR_DEFINE_AUTOPTR_FUNC(virNetlinkHandle, virNetlinkFree) +VIR_DEFINE_AUTOPTR_FUNC(virNetlinkHandle, virNetlinkFree); typedef struct _virNetlinkEventSrvPrivate virNetlinkEventSrvPrivate; typedef virNetlinkEventSrvPrivate *virNetlinkEventSrvPrivatePtr; diff --git a/src/util/virnetlink.h b/src/util/virnetlink.h index 37442be44c..9dd7b3c3ed 100644 --- a/src/util/virnetlink.h +++ b/src/util/virnetlink.h @@ -37,7 +37,7 @@ # endif typedef struct nl_msg virNetlinkMsg; -VIR_DEFINE_AUTOPTR_FUNC(virNetlinkMsg, nlmsg_free) +VIR_DEFINE_AUTOPTR_FUNC(virNetlinkMsg, nlmsg_free); # else diff --git a/src/util/virpci.h b/src/util/virpci.h index 0b35228e3d..c8fc1e8bf6 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -271,8 +271,8 @@ ssize_t virPCIGetMdevTypes(const char *sysfspath, void virPCIDeviceAddressFree(virPCIDeviceAddressPtr address); -VIR_DEFINE_AUTOPTR_FUNC(virPCIDevice, virPCIDeviceFree) -VIR_DEFINE_AUTOPTR_FUNC(virPCIDeviceAddress, virPCIDeviceAddressFree) -VIR_DEFINE_AUTOPTR_FUNC(virPCIEDeviceInfo, virPCIEDeviceInfoFree) +VIR_DEFINE_AUTOPTR_FUNC(virPCIDevice, virPCIDeviceFree); +VIR_DEFINE_AUTOPTR_FUNC(virPCIDeviceAddress, virPCIDeviceAddressFree); +VIR_DEFINE_AUTOPTR_FUNC(virPCIEDeviceInfo, virPCIEDeviceInfoFree); #endif /* LIBVIRT_VIRPCI_H */ diff --git a/src/util/virperf.h b/src/util/virperf.h index 0d026e80c2..3cd26563b4 100644 --- a/src/util/virperf.h +++ b/src/util/virperf.h @@ -82,6 +82,6 @@ int virPerfReadEvent(virPerfPtr perf, virPerfEventType type, uint64_t *value); -VIR_DEFINE_AUTOPTR_FUNC(virPerf, virPerfFree) +VIR_DEFINE_AUTOPTR_FUNC(virPerf, virPerfFree); #endif /* LIBVIRT_VIRPERF_H */ diff --git a/src/util/virscsi.c b/src/util/virscsi.c index 715064d669..b27831f0b3 100644 --- a/src/util/virscsi.c +++ b/src/util/virscsi.c @@ -248,7 +248,7 @@ virSCSIDeviceUsedByInfoFree(virUsedByInfoPtr used_by) VIR_FREE(used_by->domname); VIR_FREE(used_by); } -VIR_DEFINE_AUTOPTR_FUNC(virUsedByInfo, virSCSIDeviceUsedByInfoFree) +VIR_DEFINE_AUTOPTR_FUNC(virUsedByInfo, virSCSIDeviceUsedByInfoFree); void virSCSIDeviceFree(virSCSIDevicePtr dev) diff --git a/src/util/virscsi.h b/src/util/virscsi.h index fd5986d2c0..70e113b486 100644 --- a/src/util/virscsi.h +++ b/src/util/virscsi.h @@ -93,6 +93,6 @@ void virSCSIDeviceListDel(virSCSIDeviceListPtr list, virSCSIDevicePtr virSCSIDeviceListFind(virSCSIDeviceListPtr list, virSCSIDevicePtr dev); -VIR_DEFINE_AUTOPTR_FUNC(virSCSIDevice, virSCSIDeviceFree) +VIR_DEFINE_AUTOPTR_FUNC(virSCSIDevice, virSCSIDeviceFree); #endif /* LIBVIRT_VIRSCSI_H */ diff --git a/src/util/virscsivhost.h b/src/util/virscsivhost.h index 5440db16b2..d28773482c 100644 --- a/src/util/virscsivhost.h +++ b/src/util/virscsivhost.h @@ -61,6 +61,6 @@ void virSCSIVHostDeviceGetUsedBy(virSCSIVHostDevicePtr dev, void virSCSIVHostDeviceFree(virSCSIVHostDevicePtr dev); int virSCSIVHostOpenVhostSCSI(int *vhostfd) ATTRIBUTE_NOINLINE; -VIR_DEFINE_AUTOPTR_FUNC(virSCSIVHostDevice, virSCSIVHostDeviceFree) +VIR_DEFINE_AUTOPTR_FUNC(virSCSIVHostDevice, virSCSIVHostDeviceFree); #endif /* LIBVIRT_VIRSCSIVHOST_H */ diff --git a/src/util/virsocketaddr.h b/src/util/virsocketaddr.h index 64bcbb36dc..f6caa4fcf5 100644 --- a/src/util/virsocketaddr.h +++ b/src/util/virsocketaddr.h @@ -160,6 +160,6 @@ int virSocketAddrPTRDomain(const virSocketAddr *addr, void virSocketAddrFree(virSocketAddrPtr addr); -VIR_DEFINE_AUTOPTR_FUNC(virSocketAddr, virSocketAddrFree) +VIR_DEFINE_AUTOPTR_FUNC(virSocketAddr, virSocketAddrFree); #endif /* LIBVIRT_VIRSOCKETADDR_H */ diff --git a/src/util/virstring.h b/src/util/virstring.h index 42848e62b1..aef82471c2 100644 --- a/src/util/virstring.h +++ b/src/util/virstring.h @@ -307,6 +307,6 @@ int virStringParsePort(const char *str, unsigned int *port) ATTRIBUTE_NONNULL(2) ATTRIBUTE_RETURN_CHECK; -VIR_DEFINE_AUTOPTR_FUNC(virString, virStringListFree) +VIR_DEFINE_AUTOPTR_FUNC(virString, virStringListFree); #endif /* LIBVIRT_VIRSTRING_H */ diff --git a/src/util/virusb.h b/src/util/virusb.h index e589a45310..6ed71606d4 100644 --- a/src/util/virusb.h +++ b/src/util/virusb.h @@ -96,6 +96,6 @@ void virUSBDeviceListDel(virUSBDeviceListPtr list, virUSBDevicePtr virUSBDeviceListFind(virUSBDeviceListPtr list, virUSBDevicePtr dev); -VIR_DEFINE_AUTOPTR_FUNC(virUSBDevice, virUSBDeviceFree) +VIR_DEFINE_AUTOPTR_FUNC(virUSBDevice, virUSBDeviceFree); #endif /* LIBVIRT_VIRUSB_H */ -- 2.20.1

2 1

[libvirt] [PATCH] docs: Update the AMD SEV's spec URL
by Erik Skultety 08 Feb '19

08 Feb '19

Luckily, the new URL still points to the same location, the only change is in the document name where an escaped space (%20) was replaced by an underscore. Signed-off-by: Erik Skultety <eskultet(a)redhat.com> --- docs/formatdomain.html.in | 4 ++-- docs/formatdomaincaps.html.in | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 7f07bb7f55..2ae5006849 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -8785,8 +8785,8 @@ qemu-kvm -net nic,model=? /dev/null different entity using a different key the encrypted guests data will be incorrectly decrypted, leading to unintelligible data. - For more information see various input parameters and its format see the SEV API spec - <a href="https://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf"> https://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf </a> + For more information see various input parameters and its format see the + <a href="https://support.amd.com/TechDocs/55766_SEV-KM_API_Specification.pdf">SEV API spec</a> <span class="since">Since 4.4.0</span> </p> <pre> diff --git a/docs/formatdomaincaps.html.in b/docs/formatdomaincaps.html.in index cafd9abbdf..ba48daab2d 100644 --- a/docs/formatdomaincaps.html.in +++ b/docs/formatdomaincaps.html.in @@ -481,7 +481,7 @@ <p> For more details on SEV feature see: - <a href="https://support.amd.com/TechDocs/55766_SEV-KM%20API_Specification.pdf"> + <a href="https://support.amd.com/TechDocs/55766_SEV-KM_API_Specification.pdf"> SEV API spec</a> and <a href="http://amd-dev.wpengine.netdna-cdn.com/wordpress/media/2013/12/AMD_Memory_E…"> SEV White Paper</a> </p> -- 2.20.1

2 1

Re: [libvirt] [Qemu-devel] [PATCH v3 16/17] qmp: Deprecate query-events in favor of query-qmp-schema
by Eric Blake 08 Feb '19

08 Feb '19

Adding libvirt in cc On 2/6/19 12:17 PM, Markus Armbruster wrote: > query-events doesn't reflect compile-time configuration. Instead of > fixing that, deprecate the command in favor of query-qmp-schema. > > Signed-off-by: Markus Armbruster <armbru(a)redhat.com> > --- > monitor.c | 5 +++++ > qapi/misc.json | 7 +++++-- > qemu-deprecated.texi | 5 +++++ > 3 files changed, 15 insertions(+), 2 deletions(-) Libvirt uses query-events; we'll need to patch libvirt to start relying on query-qmp-schema before this deprecation cycle can complete (although I'm in favor of making the change). > > diff --git a/monitor.c b/monitor.c > index eeec289aae..9f27621ed1 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -1099,6 +1099,11 @@ CommandInfoList *qmp_query_commands(Error **errp) > > EventInfoList *qmp_query_events(Error **errp) > { > + /* > + * TODO This deprecated command is the only user of > + * QAPIEvent_str() and QAPIEvent_lookup[]. When the command goes, > + * they should go, too. > + */ > EventInfoList *info, *ev_list = NULL; > QAPIEvent e; > > diff --git a/qapi/misc.json b/qapi/misc.json > index 82f9147353..98f59f828a 100644 > --- a/qapi/misc.json > +++ b/qapi/misc.json > @@ -318,12 +318,15 @@ > ## > # @query-events: > # > -# Return a list of supported QMP events by this server > +# Return information on QMP events. > # > -# Returns: A list of @EventInfo for all supported events > +# Returns: A list of @EventInfo. > # > # Since: 1.2.0 > # > +# Note: This command is deprecated, because its output doesn't reflect > +# compile-time configuration. Use query-qmp-schema instead. > +# > # Example: > # > # -> { "execute": "query-events" } > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 9cc20b365c..3288e102d6 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -103,6 +103,11 @@ Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See > documentation of ``query-hotpluggable-cpus'' for additional > details. > > +@subsection query-events (since 4.0) > + > +The ``query-events'' command has been superseded by the more powerful > +and accurate ``query-qmp-schema'' command. > + > @section Human Monitor Protocol (HMP) commands > > @subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since 3.1) > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org

3 3

[libvirt] [PATCH v2 00/32] qemu: add support for 'device_id' of SCSI disks (blockdev-add saga)
by Peter Krempa 08 Feb '19

08 Feb '19

Now that qemu has commited the patches this contains real caps data and also fixes few merge conflicts with patches pushed upstream. Peter Krempa (32): tests: qemucaps: Make fake 'microcodeVersion' depend on filename instead of length qemu: capabilities: Probe caps for 'scsi-hd' instead of 'scsi-disk' qemu: capabilities: Probe caps for 'ide-hd' instead of 'ide-drive' tests: qemuxml: Add a common test file for the 'virtio-scsi' controller tests: qemu: Remove 'disk-scsi-virtio-scsi' test tests: qemuxml: Merge 'num-queues' variant of 'virtio-scsi' test into the common file tests: qemuxml: Merge 'cmd_per_lun' variant of 'virtio-scsi' test into the common file tests: qemuxml: Merge 'max_sectors' variant of 'virtio-scsi' test into the common file tests: qemuxml: Merge 'ioeventfd' variant of 'virtio-scsi' test into the common file tests: qemuxml2argv: Use real caps when auto-generating SCSI controller type tests: qemuxml2argv: Remove testing of post startup change to 'cachemode' for shared disks tests: qemuxml2argv: Remove the 'after startup XML' testing machinery tests: qemuxml2argv: Move cases from 'disk-shared-locking' into 'disk-shared' tests: qemu: Rename 'disk-scsi-device' to 'disk-scsi' tests: qemuxml2argv: Modernize 'disk-scsi' test tests: qemu: Merge 'disk-scsi-megasas' test into 'disk-scsi' tests: qemu: Merge 'disk-scsi-mptsas1068' test into 'disk-scsi' tests: qemu: Merge 'disk-scsi-mptsas1068' test into 'disk-scsi' tests: qemuxml2argv: Use 1.5.3 version for very old state in 'disk-cache' tests: qemuxml2argv: Modernize virtio-scsi iothread tests tests: qemuxml2argv: Remove 'disk-virtio-scsi-ccw' test qemu: caps: Always assume presence of 'scsi-hd' and 'scsi-cd' device qemu: caps: Always assume presence of 'ide-hd' and 'ide-cd' devices qemu: command: Use correct type for switch in qemuBuildDiskDeviceStr tests: qemuxml2argv: Add CDROM disks for all untested buses qemu: Forbid cdroms on virtio bus qemu: command: Drop formatting of 'media=cdrom' from -drive tests: qemuxml2argv: Add a 'serial' value for a SCSI disk test: qemucaps: Update caps with scsi 'device_id' property qemu: caps: Introduce capability for 'device_id' property of 'scsi-disk' qemu: Use the 'device_id' property of SCSI disks to avoid regressing qemu: caps: Add lockout for -blockdev if QEMU_CAPS_SCSI_DISK_DEVICE_ID is not present src/qemu/qemu_capabilities.c | 13 +- src/qemu/qemu_capabilities.h | 5 +- src/qemu/qemu_command.c | 78 +- src/qemu/qemu_domain.c | 8 + tests/Makefile.am | 1 - .../caps_1.5.3.x86_64.replies | 4 +- .../caps_1.5.3.x86_64.xml | 4 +- .../caps_1.6.0.x86_64.replies | 4 +- .../caps_1.6.0.x86_64.xml | 4 +- .../caps_1.7.0.x86_64.replies | 4 +- .../caps_1.7.0.x86_64.xml | 4 +- .../caps_2.1.1.x86_64.replies | 4 +- .../caps_2.1.1.x86_64.xml | 4 +- .../caps_2.10.0.aarch64.replies | 4 +- .../caps_2.10.0.aarch64.xml | 4 +- .../caps_2.10.0.ppc64.replies | 4 +- .../caps_2.10.0.ppc64.xml | 4 +- .../caps_2.10.0.s390x.replies | 4 +- .../caps_2.10.0.s390x.xml | 3 +- .../caps_2.10.0.x86_64.replies | 4 +- .../caps_2.10.0.x86_64.xml | 4 +- .../caps_2.11.0.s390x.replies | 4 +- .../caps_2.11.0.s390x.xml | 3 +- .../caps_2.11.0.x86_64.replies | 4 +- .../caps_2.11.0.x86_64.xml | 4 +- .../caps_2.12.0.aarch64.replies | 4 +- .../caps_2.12.0.aarch64.xml | 4 +- .../caps_2.12.0.ppc64.replies | 4 +- .../caps_2.12.0.ppc64.xml | 4 +- .../caps_2.12.0.s390x.replies | 4 +- .../caps_2.12.0.s390x.xml | 3 +- .../caps_2.12.0.x86_64.replies | 4 +- .../caps_2.12.0.x86_64.xml | 4 +- .../caps_2.4.0.x86_64.replies | 4 +- .../caps_2.4.0.x86_64.xml | 4 +- .../caps_2.5.0.x86_64.replies | 4 +- .../caps_2.5.0.x86_64.xml | 4 +- .../caps_2.6.0.aarch64.replies | 4 +- .../caps_2.6.0.aarch64.xml | 4 +- .../caps_2.6.0.ppc64.replies | 4 +- .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 4 +- .../caps_2.6.0.x86_64.replies | 4 +- .../caps_2.6.0.x86_64.xml | 4 +- .../caps_2.7.0.s390x.replies | 4 +- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 3 +- .../caps_2.7.0.x86_64.replies | 4 +- .../caps_2.7.0.x86_64.xml | 4 +- .../caps_2.8.0.s390x.replies | 4 +- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 3 +- .../caps_2.8.0.x86_64.replies | 4 +- .../caps_2.8.0.x86_64.xml | 4 +- .../caps_2.9.0.ppc64.replies | 4 +- .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 4 +- .../caps_2.9.0.s390x.replies | 4 +- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 3 +- .../caps_2.9.0.x86_64.replies | 4 +- .../caps_2.9.0.x86_64.xml | 4 +- .../caps_3.0.0.ppc64.replies | 4 +- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 4 +- .../caps_3.0.0.riscv32.replies | 4 +- .../caps_3.0.0.riscv32.xml | 1 - .../caps_3.0.0.riscv64.replies | 4 +- .../caps_3.0.0.riscv64.xml | 1 - .../caps_3.0.0.s390x.replies | 4 +- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 3 +- .../caps_3.0.0.x86_64.replies | 4 +- .../caps_3.0.0.x86_64.xml | 4 +- .../caps_3.1.0.ppc64.replies | 4 +- .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 4 +- .../caps_3.1.0.x86_64.replies | 4 +- .../caps_3.1.0.x86_64.xml | 4 +- .../caps_4.0.0.riscv32.replies | 4 +- .../caps_4.0.0.riscv32.xml | 2 - .../caps_4.0.0.riscv64.replies | 4 +- .../caps_4.0.0.riscv64.xml | 2 - .../caps_4.0.0.x86_64.replies | 2300 +++++++++-------- .../caps_4.0.0.x86_64.xml | 34 +- tests/qemucapabilitiestest.c | 17 +- .../aarch64-virtio-pci-manual-addresses.args | 4 +- tests/qemuxml2argvdata/autoindex.args | 2 +- .../qemuxml2argvdata/balloon-device-auto.args | 3 +- .../balloon-device-deflate-off.args | 3 +- .../balloon-device-deflate.args | 3 +- .../balloon-device-period.args | 3 +- tests/qemuxml2argvdata/balloon-device.args | 3 +- tests/qemuxml2argvdata/bios-nvram-secure.args | 4 +- tests/qemuxml2argvdata/bios-nvram.args | 3 +- tests/qemuxml2argvdata/bios.args | 3 +- .../blkdeviotune-group-num.args | 5 +- .../blkdeviotune-max-length.args | 5 +- tests/qemuxml2argvdata/blkdeviotune-max.args | 5 +- tests/qemuxml2argvdata/blkiotune-device.args | 3 +- tests/qemuxml2argvdata/blkiotune.args | 3 +- tests/qemuxml2argvdata/boot-cdrom.args | 6 +- tests/qemuxml2argvdata/boot-complex.args | 10 +- tests/qemuxml2argvdata/boot-floppy.args | 2 +- .../boot-menu-disable-drive.args | 6 +- tests/qemuxml2argvdata/boot-menu-disable.args | 6 +- .../boot-menu-enable-with-timeout.args | 6 +- tests/qemuxml2argvdata/boot-menu-enable.args | 6 +- tests/qemuxml2argvdata/boot-multi.args | 6 +- tests/qemuxml2argvdata/boot-network.args | 2 +- tests/qemuxml2argvdata/boot-order.args | 8 +- tests/qemuxml2argvdata/boot-strict.args | 10 +- tests/qemuxml2argvdata/channel-guestfwd.args | 3 +- tests/qemuxml2argvdata/channel-spicevmc.args | 3 +- .../qemuxml2argvdata/channel-virtio-auto.args | 3 +- .../channel-virtio-autoadd.args | 3 +- .../channel-virtio-autoassign.args | 3 +- .../channel-virtio-default.args | 3 +- .../channel-virtio-state.args | 3 +- .../qemuxml2argvdata/channel-virtio-unix.args | 3 +- tests/qemuxml2argvdata/channel-virtio.args | 3 +- tests/qemuxml2argvdata/clock-catchup.args | 3 +- tests/qemuxml2argvdata/clock-france.args | 3 +- tests/qemuxml2argvdata/clock-hpet-off.args | 3 +- .../clock-localtime-basis-localtime.args | 3 +- tests/qemuxml2argvdata/clock-localtime.args | 3 +- tests/qemuxml2argvdata/clock-utc.args | 3 +- tests/qemuxml2argvdata/clock-variable.args | 3 +- .../qemuxml2argvdata/console-compat-auto.args | 3 +- .../console-compat-chardev.args | 3 +- tests/qemuxml2argvdata/console-compat.args | 3 +- .../qemuxml2argvdata/console-virtio-many.args | 3 +- tests/qemuxml2argvdata/console-virtio.args | 3 +- tests/qemuxml2argvdata/controller-order.args | 4 +- .../controller-virtio-scsi.x86_64-latest.args | 50 + .../controller-virtio-scsi.xml | 61 + .../cpu-host-passthrough-features.args | 3 +- .../qemuxml2argvdata/cputune-zero-shares.args | 3 +- tests/qemuxml2argvdata/cputune.args | 3 +- tests/qemuxml2argvdata/debug-threads.args | 3 +- tests/qemuxml2argvdata/disk-aio.args | 7 +- tests/qemuxml2argvdata/disk-boot-cdrom.args | 7 +- tests/qemuxml2argvdata/disk-boot-disk.args | 7 +- ...ache.args => disk-cache.x86_64-1.5.3.args} | 16 +- .../disk-cache.x86_64-latest.args | 4 +- .../disk-cdrom-bus-other.x86_64-latest.args | 37 + .../qemuxml2argvdata/disk-cdrom-bus-other.xml | 47 + .../qemuxml2argvdata/disk-cdrom-network.args | 17 +- tests/qemuxml2argvdata/disk-cdrom-tray.args | 9 +- tests/qemuxml2argvdata/disk-cdrom.args | 16 +- tests/qemuxml2argvdata/disk-copy_on_read.args | 5 +- .../qemuxml2argvdata/disk-detect-zeroes.args | 5 +- tests/qemuxml2argvdata/disk-discard.args | 5 +- tests/qemuxml2argvdata/disk-error-policy.args | 7 +- tests/qemuxml2argvdata/disk-floppy-tray.args | 3 +- tests/qemuxml2argvdata/disk-floppy.args | 3 +- tests/qemuxml2argvdata/disk-fmt-qcow.args | 7 +- tests/qemuxml2argvdata/disk-geometry.args | 4 +- tests/qemuxml2argvdata/disk-ioeventfd.args | 5 +- tests/qemuxml2argvdata/disk-iscsi.args | 3 +- .../disk-network-sheepdog.args | 3 +- tests/qemuxml2argvdata/disk-no-boot.args | 8 +- tests/qemuxml2argvdata/disk-order.args | 7 +- .../qemuxml2argvdata/disk-readonly-disk.args | 8 +- tests/qemuxml2argvdata/disk-sata-device.args | 2 +- ...> disk-scsi-device-auto.x86_64-1.5.3.args} | 11 +- .../disk-scsi-device-auto.x86_64-latest.args | 36 + tests/qemuxml2argvdata/disk-scsi-device.args | 30 - .../disk-scsi-disk-vpd-build-error.xml | 2 +- tests/qemuxml2argvdata/disk-scsi-megasas.args | 31 - tests/qemuxml2argvdata/disk-scsi-megasas.xml | 35 - .../disk-scsi-mptsas1068.args | 31 - .../qemuxml2argvdata/disk-scsi-mptsas1068.xml | 36 - .../disk-scsi-virtio-scsi.args | 31 - .../disk-scsi-virtio-scsi.xml | 35 - tests/qemuxml2argvdata/disk-scsi-vscsi.args | 31 - tests/qemuxml2argvdata/disk-scsi-vscsi.xml | 35 - .../disk-scsi.x86_64-latest.args | 49 + .../{disk-scsi-device.xml => disk-scsi.xml} | 20 + tests/qemuxml2argvdata/disk-serial.args | 6 +- .../qemuxml2argvdata/disk-shared-locking.args | 34 - .../qemuxml2argvdata/disk-shared-locking.xml | 42 - tests/qemuxml2argvdata/disk-shared.args | 31 - .../disk-shared.x86_64-2.12.0.args | 9 +- .../disk-shared.x86_64-latest.args | 10 +- tests/qemuxml2argvdata/disk-shared.xml | 14 + tests/qemuxml2argvdata/disk-snapshot.args | 9 +- .../disk-source-pool-mode.args | 15 +- tests/qemuxml2argvdata/disk-source-pool.args | 11 +- .../disk-usb-device-removable.args | 3 +- tests/qemuxml2argvdata/disk-usb-device.args | 3 +- .../disk-virtio-scsi-ccw.args | 29 - .../qemuxml2argvdata/disk-virtio-scsi-ccw.xml | 31 - .../disk-virtio-scsi-cmd_per_lun.args | 28 - .../disk-virtio-scsi-cmd_per_lun.xml | 31 - .../disk-virtio-scsi-ioeventfd.args | 28 - .../disk-virtio-scsi-ioeventfd.xml | 31 - .../disk-virtio-scsi-max_sectors.args | 28 - .../disk-virtio-scsi-max_sectors.xml | 31 - .../disk-virtio-scsi-num_queues.args | 28 - .../disk-virtio-scsi-num_queues.xml | 31 - tests/qemuxml2argvdata/disk-virtio.args | 7 +- tests/qemuxml2argvdata/event_idx.args | 5 +- tests/qemuxml2argvdata/fips-enabled.args | 3 +- tests/qemuxml2argvdata/fs9p.args | 3 +- .../graphics-egl-headless.args | 3 +- .../graphics-sdl-fullscreen.args | 3 +- tests/qemuxml2argvdata/graphics-sdl.args | 3 +- .../graphics-spice-agent-file-xfer.args | 3 +- .../graphics-spice-agentmouse.args | 3 +- .../graphics-spice-compression.args | 3 +- .../graphics-spice-egl-headless.args | 3 +- .../graphics-spice-qxl-vga.args | 3 +- .../qemuxml2argvdata/graphics-spice-sasl.args | 3 +- .../graphics-spice-timeout.args | 5 +- tests/qemuxml2argvdata/graphics-spice.args | 3 +- .../graphics-vnc-auto-socket-cfg.args | 3 +- .../graphics-vnc-egl-headless.args | 3 +- .../graphics-vnc-no-listen-attr.args | 3 +- .../qemuxml2argvdata/graphics-vnc-policy.args | 3 +- .../graphics-vnc-remove-generated-socket.args | 3 +- tests/qemuxml2argvdata/graphics-vnc-sasl.args | 3 +- tests/qemuxml2argvdata/graphics-vnc.args | 3 +- .../hostdev-pci-address-device.args | 3 +- .../qemuxml2argvdata/hostdev-pci-address.args | 3 +- .../hostdev-scsi-lsi-iscsi-auth.args | 3 +- .../hostdev-scsi-lsi-iscsi.args | 3 +- tests/qemuxml2argvdata/hostdev-scsi-lsi.args | 3 +- .../hostdev-scsi-readonly.args | 3 +- .../hostdev-scsi-vhost-scsi-pci.args | 3 +- .../hostdev-scsi-virtio-iscsi-auth.args | 3 +- .../hostdev-scsi-virtio-iscsi.args | 3 +- .../hostdev-scsi-virtio-scsi.args | 3 +- .../hostdev-usb-address-device-boot.args | 2 +- .../hostdev-usb-address-device.args | 3 +- .../qemuxml2argvdata/hostdev-usb-address.args | 3 +- .../hostdev-vfio-multidomain.args | 3 +- tests/qemuxml2argvdata/hostdev-vfio.args | 3 +- .../qemuxml2argvdata/hugepages-memaccess.args | 3 +- .../hugepages-memaccess2.args | 3 +- tests/qemuxml2argvdata/hugepages-shared.args | 3 +- .../qemuxml2argvdata/input-usbmouse-addr.args | 3 +- tests/qemuxml2argvdata/input-usbmouse.args | 3 +- tests/qemuxml2argvdata/input-usbtablet.args | 3 +- tests/qemuxml2argvdata/iothreads-disk.args | 3 +- .../iothreads-ids-partial.args | 3 +- tests/qemuxml2argvdata/iothreads-ids.args | 3 +- ...threads-virtio-scsi-ccw.s390x-latest.args} | 20 +- ...hreads-virtio-scsi-pci.x86_64-latest.args} | 23 +- tests/qemuxml2argvdata/iothreads.args | 3 +- tests/qemuxml2argvdata/kvm-pit-delay.args | 3 +- tests/qemuxml2argvdata/kvm-pit-discard.args | 3 +- tests/qemuxml2argvdata/machine-aliases1.args | 3 +- tests/qemuxml2argvdata/machine-aliases2.args | 3 +- tests/qemuxml2argvdata/machine-core-off.args | 3 +- tests/qemuxml2argvdata/machine-core-on.args | 3 +- tests/qemuxml2argvdata/machine-smm-opt.args | 4 +- .../qemuxml2argvdata/machine-vmport-opt.args | 3 +- tests/qemuxml2argvdata/master-key.args | 3 +- .../memory-hotplug-dimm-addr.args | 3 +- .../qemuxml2argvdata/memory-hotplug-dimm.args | 3 +- tests/qemuxml2argvdata/memory-hotplug.args | 3 +- tests/qemuxml2argvdata/memtune-unlimited.args | 3 +- tests/qemuxml2argvdata/memtune.args | 3 +- tests/qemuxml2argvdata/migrate.args | 3 +- .../minimal-msg-timestamp.args | 3 +- tests/qemuxml2argvdata/minimal-sandbox.args | 3 +- tests/qemuxml2argvdata/minimal.args | 3 +- tests/qemuxml2argvdata/misc-acpi.args | 3 +- tests/qemuxml2argvdata/misc-disable-s3.args | 3 +- .../misc-disable-suspends.args | 3 +- tests/qemuxml2argvdata/misc-enable-s4.args | 3 +- tests/qemuxml2argvdata/misc-no-reboot.args | 3 +- tests/qemuxml2argvdata/misc-uuid.args | 3 +- tests/qemuxml2argvdata/monitor-json.args | 3 +- .../multifunction-pci-device.args | 2 +- tests/qemuxml2argvdata/name-escape.args | 3 +- tests/qemuxml2argvdata/net-client.args | 3 +- tests/qemuxml2argvdata/net-eth-hostip.args | 3 +- tests/qemuxml2argvdata/net-eth-ifname.args | 3 +- tests/qemuxml2argvdata/net-eth-names.args | 3 +- tests/qemuxml2argvdata/net-eth.args | 3 +- .../net-hostdev-bootorder.args | 3 +- .../net-hostdev-multidomain.args | 3 +- .../net-hostdev-vfio-multidomain.args | 3 +- tests/qemuxml2argvdata/net-hostdev-vfio.args | 3 +- tests/qemuxml2argvdata/net-hostdev.args | 3 +- tests/qemuxml2argvdata/net-mcast.args | 3 +- tests/qemuxml2argvdata/net-server.args | 3 +- tests/qemuxml2argvdata/net-udp.args | 3 +- tests/qemuxml2argvdata/net-user-addr.args | 3 +- tests/qemuxml2argvdata/net-user.args | 3 +- .../net-vhostuser-multiq.args | 3 +- tests/qemuxml2argvdata/net-virtio-device.args | 3 +- .../net-virtio-disable-offloads.args | 3 +- tests/qemuxml2argvdata/net-virtio-netdev.args | 3 +- .../net-virtio-rxtxqueuesize.args | 3 +- tests/qemuxml2argvdata/net-virtio.args | 3 +- tests/qemuxml2argvdata/nosharepages.args | 3 +- .../numad-auto-memory-vcpu-cpuset.args | 3 +- ...o-memory-vcpu-no-cpuset-and-placement.args | 3 +- .../numad-auto-vcpu-static-numatune.args | 3 +- .../numad-static-memory-auto-vcpu.args | 3 +- tests/qemuxml2argvdata/numad.args | 3 +- .../numatune-auto-nodeset-invalid.args | 3 +- tests/qemuxml2argvdata/numatune-memory.args | 3 +- tests/qemuxml2argvdata/panic-no-address.args | 3 +- tests/qemuxml2argvdata/panic.args | 3 +- .../parallel-parport-chardev.args | 3 +- .../parallel-tcp-chardev.args | 3 +- tests/qemuxml2argvdata/pci-autoadd-addr.args | 4 +- tests/qemuxml2argvdata/pci-autoadd-idx.args | 4 +- tests/qemuxml2argvdata/pci-autofill-addr.args | 4 +- tests/qemuxml2argvdata/pci-autofill-addr.xml | 2 +- tests/qemuxml2argvdata/pci-bridge.args | 4 +- tests/qemuxml2argvdata/pci-many.args | 4 +- tests/qemuxml2argvdata/pci-rom.args | 3 +- .../pci-serial-dev-chardev.args | 3 +- tests/qemuxml2argvdata/pcie-expander-bus.args | 2 +- tests/qemuxml2argvdata/pcie-root-port.args | 2 +- .../pcie-switch-downstream-port.args | 2 +- .../pcie-switch-upstream-port.args | 2 +- tests/qemuxml2argvdata/pcihole64-q35.args | 2 +- .../pseries-vio-user-assigned.args | 4 +- tests/qemuxml2argvdata/pseries-vio.args | 4 +- tests/qemuxml2argvdata/q35-usb2-multi.args | 2 +- tests/qemuxml2argvdata/q35-usb2-reorder.args | 2 +- tests/qemuxml2argvdata/q35-usb2.args | 2 +- tests/qemuxml2argvdata/q35.args | 2 +- tests/qemuxml2argvdata/qemu-ns-alt.args | 3 +- .../qemu-ns-commandline-ns0.args | 3 +- .../qemu-ns-commandline-ns1.args | 3 +- .../qemuxml2argvdata/qemu-ns-commandline.args | 3 +- .../qemu-ns-domain-commandline-ns0.args | 3 +- .../qemu-ns-domain-commandline.args | 3 +- .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 3 +- tests/qemuxml2argvdata/qemu-ns-no-env.args | 3 +- tests/qemuxml2argvdata/qemu-ns.args | 3 +- tests/qemuxml2argvdata/restore-v2-fd.args | 3 +- tests/qemuxml2argvdata/restore-v2.args | 3 +- tests/qemuxml2argvdata/seclabel-dac-none.args | 3 +- .../seclabel-dynamic-baselabel.args | 3 +- .../seclabel-dynamic-labelskip.args | 3 +- .../seclabel-dynamic-override.args | 5 +- .../seclabel-dynamic-relabel.args | 3 +- tests/qemuxml2argvdata/seclabel-dynamic.args | 3 +- tests/qemuxml2argvdata/seclabel-none.args | 3 +- .../seclabel-static-labelskip.args | 3 +- .../seclabel-static-relabel.args | 3 +- tests/qemuxml2argvdata/seclabel-static.args | 3 +- .../serial-dev-chardev-iobase.args | 3 +- .../qemuxml2argvdata/serial-dev-chardev.args | 3 +- .../qemuxml2argvdata/serial-file-chardev.args | 3 +- tests/qemuxml2argvdata/serial-file-log.args | 3 +- .../qemuxml2argvdata/serial-many-chardev.args | 3 +- .../qemuxml2argvdata/serial-pty-chardev.args | 3 +- .../serial-spiceport-nospice.args | 3 +- tests/qemuxml2argvdata/serial-spiceport.args | 3 +- .../qemuxml2argvdata/serial-tcp-chardev.args | 3 +- .../serial-tcp-telnet-chardev.args | 3 +- .../serial-tcp-tlsx509-chardev-notls.args | 3 +- .../serial-tcp-tlsx509-chardev-verify.args | 3 +- .../serial-tcp-tlsx509-chardev.args | 3 +- .../serial-tcp-tlsx509-secret-chardev.args | 3 +- .../qemuxml2argvdata/serial-udp-chardev.args | 3 +- tests/qemuxml2argvdata/serial-vc-chardev.args | 3 +- tests/qemuxml2argvdata/smbios.args | 3 +- tests/qemuxml2argvdata/smp.args | 3 +- tests/qemuxml2argvdata/sound-device.args | 3 +- tests/qemuxml2argvdata/sound.args | 3 +- tests/qemuxml2argvdata/user-aliases.args | 4 +- .../video-device-pciaddr-default.args | 3 +- tests/qemuxml2argvdata/video-none-device.args | 3 +- .../video-qxl-device-vgamem.args | 3 +- tests/qemuxml2argvdata/video-qxl-device.args | 3 +- tests/qemuxml2argvdata/video-qxl-heads.args | 3 +- .../qemuxml2argvdata/video-qxl-nodevice.args | 3 +- tests/qemuxml2argvdata/video-qxl-noheads.args | 3 +- .../video-qxl-sec-device-vgamem.args | 3 +- .../video-qxl-sec-device.args | 3 +- .../video-vga-device-vgamem.args | 3 +- tests/qemuxml2argvdata/video-vga-device.args | 3 +- .../qemuxml2argvdata/video-vga-nodevice.args | 3 +- .../qemuxml2argvdata/video-vga-qxl-heads.args | 3 +- .../video-virtio-gpu-device.args | 3 +- .../video-virtio-gpu-sdl-gl.args | 3 +- .../video-virtio-gpu-spice-gl.args | 3 +- .../video-virtio-gpu-virgl.args | 3 +- tests/qemuxml2argvdata/video-virtio-vga.args | 3 +- tests/qemuxml2argvdata/vmcoreinfo.args | 3 +- tests/qemuxml2argvdata/watchdog-device.args | 3 +- tests/qemuxml2argvdata/watchdog-dump.args | 3 +- .../qemuxml2argvdata/watchdog-injectnmi.args | 3 +- tests/qemuxml2argvdata/watchdog.args | 3 +- tests/qemuxml2argvtest.c | 115 +- .../qemuxml2startupxmloutdata/disk-shared.xml | 56 - .../controller-virtio-scsi.xml | 76 + ...rtio-scsi.xml => disk-cdrom-bus-other.xml} | 44 +- .../qemuxml2xmloutdata/disk-scsi-megasas.xml | 45 - .../disk-scsi-mptsas1068.xml | 46 - tests/qemuxml2xmloutdata/disk-scsi-vscsi.xml | 45 - .../{disk-scsi-device.xml => disk-scsi.xml} | 31 +- .../disk-virtio-scsi-cmd_per_lun.xml | 37 - .../disk-virtio-scsi-ioeventfd.xml | 37 - .../disk-virtio-scsi-max_sectors.xml | 37 - .../disk-virtio-scsi-num_queues.xml | 37 - .../qemuxml2xmloutdata/pci-autofill-addr.xml | 2 +- tests/qemuxml2xmltest.c | 28 +- 400 files changed, 2312 insertions(+), 3114 deletions(-) create mode 100644 tests/qemuxml2argvdata/controller-virtio-scsi.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/controller-virtio-scsi.xml rename tests/qemuxml2argvdata/{disk-cache.args => disk-cache.x86_64-1.5.3.args} (72%) create mode 100644 tests/qemuxml2argvdata/disk-cdrom-bus-other.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/disk-cdrom-bus-other.xml rename tests/qemuxml2argvdata/{disk-scsi-device-auto.args => disk-scsi-device-auto.x86_64-1.5.3.args} (69%) create mode 100644 tests/qemuxml2argvdata/disk-scsi-device-auto.x86_64-latest.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-device.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-megasas.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-megasas.xml delete mode 100644 tests/qemuxml2argvdata/disk-scsi-mptsas1068.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-mptsas1068.xml delete mode 100644 tests/qemuxml2argvdata/disk-scsi-virtio-scsi.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-virtio-scsi.xml delete mode 100644 tests/qemuxml2argvdata/disk-scsi-vscsi.args delete mode 100644 tests/qemuxml2argvdata/disk-scsi-vscsi.xml create mode 100644 tests/qemuxml2argvdata/disk-scsi.x86_64-latest.args rename tests/qemuxml2argvdata/{disk-scsi-device.xml => disk-scsi.xml} (58%) delete mode 100644 tests/qemuxml2argvdata/disk-shared-locking.args delete mode 100644 tests/qemuxml2argvdata/disk-shared-locking.xml delete mode 100644 tests/qemuxml2argvdata/disk-shared.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-ccw.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-ccw.xml delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-cmd_per_lun.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-cmd_per_lun.xml delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-ioeventfd.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-ioeventfd.xml delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-max_sectors.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-max_sectors.xml delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-num_queues.args delete mode 100644 tests/qemuxml2argvdata/disk-virtio-scsi-num_queues.xml rename tests/qemuxml2argvdata/{iothreads-virtio-scsi-ccw.args => iothreads-virtio-scsi-ccw.s390x-latest.args} (58%) rename tests/qemuxml2argvdata/{iothreads-virtio-scsi-pci.args => iothreads-virtio-scsi-pci.x86_64-latest.args} (56%) delete mode 100644 tests/qemuxml2startupxmloutdata/disk-shared.xml create mode 100644 tests/qemuxml2xmloutdata/controller-virtio-scsi.xml rename tests/qemuxml2xmloutdata/{disk-scsi-virtio-scsi.xml => disk-cdrom-bus-other.xml} (54%) delete mode 100644 tests/qemuxml2xmloutdata/disk-scsi-megasas.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-scsi-mptsas1068.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-scsi-vscsi.xml rename tests/qemuxml2xmloutdata/{disk-scsi-device.xml => disk-scsi.xml} (57%) delete mode 100644 tests/qemuxml2xmloutdata/disk-virtio-scsi-cmd_per_lun.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-virtio-scsi-ioeventfd.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-virtio-scsi-max_sectors.xml delete mode 100644 tests/qemuxml2xmloutdata/disk-virtio-scsi-num_queues.xml -- 2.20.1

2 66

[libvirt] [PATCH 00/10] qemu: Probe events from 'query-qmp-schema'
by Peter Krempa 07 Feb '19

07 Feb '19

This applies on top of: [libvirt] [PATCH v2 00/32] qemu: add support for 'device_id' of SCSI disks (blockdev-add saga) https://www.redhat.com/archives/libvir-list/2019-February/msg00098.html The last patch does _not_ fix the numbering, please see the commit message of 10/10. Peter Krempa (10): qemu: caps: Always assume QEMU_CAPS_BALLOON_EVENT qemu: Clean up usage of qemuDomainUpdateCurrentMemorySize qemu: caps: Always assume QEMU_CAPS_SEAMLESS_MIGRATION tests: qemuhotplug: Remove unused test macro DO_TEST_DETACH_EVENT tests: qemuhotplug: Use DEVICE_DELETED event in all hotunplug tests tests: qemuhotplug: Remove leftovers for non-event testing qemu: caps: Always assume QEMU_CAPS_DEVICE_DEL_EVENT qemu: caps: Always assume QEMU_CAPS_DEVICE_TRAY_MOVED qemu: caps: Probe events from 'query-qmp-schema' rather than 'query-events' qemu: caps: Don't call 'query-events' when we probe them from QMP schema src/qemu/qemu_capabilities.c | 16 +- src/qemu/qemu_capabilities.h | 8 +- src/qemu/qemu_command.c | 10 +- src/qemu/qemu_domain.c | 57 +------- src/qemu/qemu_domain.h | 3 +- src/qemu/qemu_driver.c | 23 +-- src/qemu/qemu_hotplug.c | 15 +- src/qemu/qemu_migration.c | 3 +- src/qemu/qemu_process.c | 3 - .../caps_1.5.3.x86_64.xml | 4 - .../caps_1.6.0.x86_64.xml | 4 - .../caps_1.7.0.x86_64.xml | 4 - .../caps_2.1.1.x86_64.xml | 4 - .../caps_2.10.0.aarch64.replies | 122 ---------------- .../caps_2.10.0.aarch64.xml | 4 - .../caps_2.10.0.ppc64.replies | 122 ---------------- .../caps_2.10.0.ppc64.xml | 4 - .../caps_2.10.0.s390x.replies | 122 ---------------- .../caps_2.10.0.s390x.xml | 4 - .../caps_2.10.0.x86_64.replies | 122 ---------------- .../caps_2.10.0.x86_64.xml | 4 - .../caps_2.11.0.s390x.replies | 122 ---------------- .../caps_2.11.0.s390x.xml | 4 - .../caps_2.11.0.x86_64.replies | 122 ---------------- .../caps_2.11.0.x86_64.xml | 4 - .../caps_2.12.0.aarch64.replies | 128 ---------------- .../caps_2.12.0.aarch64.xml | 4 - .../caps_2.12.0.ppc64.replies | 128 ---------------- .../caps_2.12.0.ppc64.xml | 4 - .../caps_2.12.0.s390x.replies | 128 ---------------- .../caps_2.12.0.s390x.xml | 4 - .../caps_2.12.0.x86_64.replies | 128 ---------------- .../caps_2.12.0.x86_64.xml | 4 - .../caps_2.4.0.x86_64.xml | 4 - .../caps_2.5.0.x86_64.replies | 116 --------------- .../caps_2.5.0.x86_64.xml | 4 - .../caps_2.6.0.aarch64.replies | 122 ---------------- .../caps_2.6.0.aarch64.xml | 4 - .../caps_2.6.0.ppc64.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.6.0.ppc64.xml | 4 - .../caps_2.6.0.x86_64.replies | 122 ---------------- .../caps_2.6.0.x86_64.xml | 4 - .../caps_2.7.0.s390x.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.7.0.s390x.xml | 4 - .../caps_2.7.0.x86_64.replies | 122 ---------------- .../caps_2.7.0.x86_64.xml | 4 - .../caps_2.8.0.s390x.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.8.0.s390x.xml | 4 - .../caps_2.8.0.x86_64.replies | 122 ---------------- .../caps_2.8.0.x86_64.xml | 4 - .../caps_2.9.0.ppc64.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.9.0.ppc64.xml | 4 - .../caps_2.9.0.s390x.replies | 122 ---------------- .../qemucapabilitiesdata/caps_2.9.0.s390x.xml | 4 - .../caps_2.9.0.x86_64.replies | 122 ---------------- .../caps_2.9.0.x86_64.xml | 4 - .../caps_3.0.0.ppc64.replies | 131 ----------------- .../qemucapabilitiesdata/caps_3.0.0.ppc64.xml | 4 - .../caps_3.0.0.riscv32.replies | 134 ----------------- .../caps_3.0.0.riscv32.xml | 4 - .../caps_3.0.0.riscv64.replies | 134 ----------------- .../caps_3.0.0.riscv64.xml | 4 - .../caps_3.0.0.s390x.replies | 134 ----------------- .../qemucapabilitiesdata/caps_3.0.0.s390x.xml | 4 - .../caps_3.0.0.x86_64.replies | 134 ----------------- .../caps_3.0.0.x86_64.xml | 4 - .../caps_3.1.0.ppc64.replies | 137 ------------------ .../qemucapabilitiesdata/caps_3.1.0.ppc64.xml | 4 - .../caps_3.1.0.x86_64.replies | 137 ------------------ .../caps_3.1.0.x86_64.xml | 4 - .../caps_4.0.0.riscv32.replies | 137 ------------------ .../caps_4.0.0.riscv32.xml | 4 - .../caps_4.0.0.riscv64.replies | 137 ------------------ .../caps_4.0.0.riscv64.xml | 4 - .../caps_4.0.0.x86_64.replies | 137 ------------------ .../caps_4.0.0.x86_64.xml | 4 - tests/qemuhotplugtest.c | 79 +++------- tests/qemuxml2argvdata/channel-spicevmc.args | 2 +- tests/qemuxml2argvdata/controller-order.args | 3 +- .../graphics-spice-agent-file-xfer.args | 3 +- .../graphics-spice-agentmouse.args | 2 +- .../graphics-spice-auto-socket-cfg.args | 3 +- .../graphics-spice-auto-socket.args | 3 +- .../graphics-spice-compression.args | 3 +- .../graphics-spice-egl-headless.args | 2 +- .../graphics-spice-no-args.args | 2 +- .../graphics-spice-qxl-vga.args | 2 +- .../qemuxml2argvdata/graphics-spice-sasl.args | 2 +- .../graphics-spice-socket.args | 2 +- .../graphics-spice-timeout.args | 2 +- .../graphics-spice-usb-redir.args | 2 +- tests/qemuxml2argvdata/graphics-spice.args | 2 +- tests/qemuxml2argvdata/name-escape.args | 2 +- .../q35-virt-manager-basic.args | 2 +- tests/qemuxml2argvdata/serial-spiceport.args | 3 +- .../video-virtio-gpu-spice-gl.args | 2 +- 96 files changed, 80 insertions(+), 4257 deletions(-) -- 2.20.1

3 23

[libvirt] [PATCH v1 1/1] qemu_process.c: add CAP_IPC_LOCK when using libcap-ng
by Daniel Henrique Barboza 07 Feb '19

07 Feb '19

QEMU virtual machines with PCI passthrough of certain devices, such as the NVIDIA Tesla V100 GPU, requires allocation of an amount of memory pages that can break KVM limits. When that happens, the KVM module checks if the process is IPC_LOCK capable and, in case it doesn't, it refuses to allocate the mem pages, causing the guest to misbehave. When Libvirt is compiled to use libcap-ng support, the resulting QEMU guest Libvirt creates does not have CAP_IPC_LOCK, hurting guests that are doing PCI passthrough and that requires extra memory to work. This patch addresses this issue by checking whether we're running with libcap-ng support (WITH_CAPNG) and if the guest is using PCI passthrough with the VFIO driver. If those conditions are met, allow CAP_IPC_LOCK capability to the QEMU process. Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com> --- src/libvirt_private.syms | 1 + src/qemu/qemu_process.c | 34 ++++++++++++++++++++++++++++++++++ src/util/virhostdev.c | 2 +- src/util/virhostdev.h | 4 ++++ 4 files changed, 40 insertions(+), 1 deletion(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 6b401aa5e0..b7384a67a8 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1992,6 +1992,7 @@ virHostCPUStatsAssign; # util/virhostdev.h virHostdevFindUSBDevice; +virHostdevGetPCIHostDeviceList; virHostdevIsMdevDevice; virHostdevIsSCSIDevice; virHostdevManagerGetDefault; diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 0583eb03f2..24aef5904f 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -4997,6 +4997,38 @@ qemuProcessSetupRawIO(virQEMUDriverPtr driver, } +static void +qemuProcessSetupVFIOCaps(virDomainObjPtr vm ATTRIBUTE_UNUSED, + virCommandPtr cmd ATTRIBUTE_UNUSED) +{ +#if WITH_CAPNG + virPCIDeviceListPtr pcidevs = NULL; + bool has_vfio = false; + size_t i; + + pcidevs = virHostdevGetPCIHostDeviceList(vm->def->hostdevs, + vm->def->nhostdevs); + if (!pcidevs) + return; + + for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) { + virPCIDevicePtr pci = virPCIDeviceListGet(pcidevs, i); + if (virPCIDeviceGetStubDriver(pci) == VIR_PCI_STUB_DRIVER_VFIO) { + has_vfio = true; + break; + } + } + + if (has_vfio) { + VIR_DEBUG("Adding CAP_IPC_LOCK to QEMU process"); + virCommandAllowCap(cmd, CAP_IPC_LOCK); + } + + virObjectUnref(pcidevs); +#endif +} + + static int qemuProcessSetupBalloon(virQEMUDriverPtr driver, virDomainObjPtr vm, @@ -6569,6 +6601,8 @@ qemuProcessLaunch(virConnectPtr conn, if (qemuProcessSetupRawIO(driver, vm, cmd) < 0) goto cleanup; + qemuProcessSetupVFIOCaps(vm, cmd); + virCommandSetPreExecHook(cmd, qemuProcessHook, &hookData); virCommandSetMaxProcesses(cmd, cfg->maxProcesses); virCommandSetMaxFiles(cmd, cfg->maxFiles); diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c index 6be395cdda..ee389a1729 100644 --- a/src/util/virhostdev.c +++ b/src/util/virhostdev.c @@ -218,7 +218,7 @@ virHostdevManagerGetDefault(void) return virObjectRef(manager); } -static virPCIDeviceListPtr +virPCIDeviceListPtr virHostdevGetPCIHostDeviceList(virDomainHostdevDefPtr *hostdevs, int nhostdevs) { virPCIDeviceListPtr pcidevs; diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h index 7263f320a2..9235581242 100644 --- a/src/util/virhostdev.h +++ b/src/util/virhostdev.h @@ -57,6 +57,10 @@ struct _virHostdevManager { }; virHostdevManagerPtr virHostdevManagerGetDefault(void); +virPCIDeviceListPtr +virHostdevGetPCIHostDeviceList(virDomainHostdevDefPtr *hostdevs, + int nhostdevs) + ATTRIBUTE_NONNULL(1); int virHostdevPreparePCIDevices(virHostdevManagerPtr hostdev_mgr, const char *drv_name, -- 2.20.1

3 5

[libvirt] [PATCH 0/3] bhyve: implement MSRs ignore unknown writes feature
by Roman Bogorodskiy 07 Feb '19

07 Feb '19

Roman Bogorodskiy (3): conf: introduce 'msrs' feature bhyve: implement MSRs ignore unknown writes feature news: document bhyve msrs feature docs/drvbhyve.html.in | 16 +++++++++ docs/formatdomain.html.in | 1 + docs/news.xml | 11 ++++++ docs/schemas/domaincommon.rng | 14 ++++++++ src/bhyve/bhyve_command.c | 4 +++ src/conf/domain_conf.c | 33 +++++++++++++++++ src/conf/domain_conf.h | 8 +++++ src/qemu/qemu_domain.c | 1 + .../bhyvexml2argvdata/bhyvexml2argv-msrs.args | 10 ++++++ .../bhyvexml2argv-msrs.ldargs | 3 ++ .../bhyvexml2argvdata/bhyvexml2argv-msrs.xml | 26 ++++++++++++++ tests/bhyvexml2argvtest.c | 1 + .../bhyvexml2xmlout-msrs.xml | 36 +++++++++++++++++++ tests/bhyvexml2xmltest.c | 1 + 14 files changed, 165 insertions(+) create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-msrs.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-msrs.xml -- 2.20.1

3 8

[libvirt] [PATCH] virinitctl: Provide a stub list of init fifos for non-Linux
by Michal Privoznik 07 Feb '19

07 Feb '19

The virInitctlFifos list is exported, but lacks definition for non-Linux and/or non-BSD case. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under build breaker rule. src/util/virinitctl.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/util/virinitctl.c b/src/util/virinitctl.c index bbcbbb483d..6966e8a3e9 100644 --- a/src/util/virinitctl.c +++ b/src/util/virinitctl.c @@ -184,6 +184,11 @@ virInitctlSetRunLevel(const char *fifo, return ret; } #else +/* On non-Linux and non-BSD there are no known inits */ +const char *virInitctlFifos[] = { + NULL +}; + int virInitctlSetRunLevel(const char *fifo ATTRIBUTE_UNUSED, virInitctlRunLevel level ATTRIBUTE_UNUSED) { -- 2.19.2

1 0

[libvirt] [PATCH 0/4] qemu: clean up qemuDomainBlockJobAbort/Pivot (blockdev-add saga)
by Peter Krempa 07 Feb '19

07 Feb '19

Peter Krempa (4): qemu: Always save status XML in qemuDomainBlockJobAbort qemu: Move shareable disk check for block copy qemu: Remove unused 'cfg' qemuDomainBlockPivot qemu: Use data in qemuBlockJobDataPtr instead of re-generating job name src/qemu/qemu_driver.c | 46 +++++++++++++++--------------------------- 1 file changed, 16 insertions(+), 30 deletions(-) -- 2.20.1

2 8

[libvirt] [PATCH 0/5] Couple of LXC fixes
by Michal Privoznik 07 Feb '19

07 Feb '19

*** BLURB HERE *** Michal Prívozník (5): lxc: Use correct job type for destroying a domain vircgroup: Try harder to kill cgroup lxc: Restore seclabels after the container is killed virinitctl: Expose fifo paths and allow caller to chose one lxc: Don't reboot host on virDomainReboot src/libvirt_private.syms | 1 + src/lxc/lxc_domain.c | 77 ++++++++++++++++++++++++++++++++++++++++ src/lxc/lxc_domain.h | 4 +++ src/lxc/lxc_driver.c | 19 ++-------- src/lxc/lxc_process.c | 22 ++++++------ src/util/vircgroup.c | 15 ++++---- src/util/virinitctl.c | 66 +++++++++++++++++++++------------- src/util/virinitctl.h | 6 +++- 8 files changed, 152 insertions(+), 58 deletions(-) -- 2.19.2

3 12

[libvirt] [PATCH] conf: Remove iothreads restriction in virDomainDefCheckABIStabilityFlags
by Jie Wang 06 Feb '19

06 Feb '19

The number of iothreads is not part of the vm state sent during migration, nor exposed to the guest ABI, so this restriction is a mistaken in libvirt. Let's remove that bit of code. Signed-off-by: Jie Wang <wangjie88(a)huawei.com> --- src/conf/domain_conf.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ae8fb5a501..ac4eeaec5e 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22927,14 +22927,6 @@ virDomainDefCheckABIStabilityFlags(virDomainDefPtr src, if (!virDomainDefVcpuCheckAbiStability(src, dst)) goto error; - if (src->niothreadids != dst->niothreadids) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Target domain iothreads count %zu does not " - "match source %zu"), - dst->niothreadids, src->niothreadids); - goto error; - } - if (src->os.type != dst->os.type) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Target domain OS type %s does not match source %s"), -- 2.16.2.windows.1

2 1

[libvirt] [PATCH] storage: fix volume perms when it is not specified.
by Julio Faracco 06 Feb '19

06 Feb '19

This commit adds permissions inheritance to volume from main pool when it is not explicitly added by command or XML definition. It permissions are defined into XML, they should be respected. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=677242 Signed-off-by: Julio Faracco <jcfaracco(a)gmail.com> --- src/storage/storage_driver.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index 4a13e90481..5961d35f26 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1850,6 +1850,16 @@ storageVolCreateXML(virStoragePoolPtr pool, goto cleanup; } + /* Inherit perms and mode from pool when they are not defined. */ + if (voldef->target.perms->uid == (uid_t)-1) + voldef->target.perms->uid = def->target.perms.uid; + + if (voldef->target.perms->gid == (gid_t)-1) + voldef->target.perms->gid = def->target.perms.gid; + + if (voldef->target.perms->mode == (mode_t)-1) + voldef->target.perms->mode = def->target.perms.mode; + if (virStorageVolCreateXMLEnsureACL(pool->conn, def, voldef) < 0) goto cleanup; -- 2.19.1

3 2

[libvirt] [libvirt-glib] gconfig: Add gvir_config_storage_vol_target_set_features
by Christophe Fergeau 06 Feb '19

06 Feb '19

Only one feature is supported at the moment, 'lazy refcount' Signed-off-by: Christophe Fergeau <cfergeau(a)redhat.com> --- .../libvirt-gconfig-storage-vol-target.c | 14 ++++++++++++++ .../libvirt-gconfig-storage-vol-target.h | 6 ++++++ libvirt-gconfig/libvirt-gconfig.sym | 6 ++++++ libvirt-gconfig/tests/test-domain-create.c | 1 + 4 files changed, 27 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c index 751c950c..300d3927 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.c @@ -109,3 +109,17 @@ void gvir_config_storage_vol_target_set_compat(GVirConfigStorageVolTarget *targe gvir_config_object_set_node_content(GVIR_CONFIG_OBJECT(target), "compat", compat); } + +void gvir_config_storage_vol_target_set_features(GVirConfigStorageVolTarget *target, + guint64 features) +{ + g_return_if_fail(GVIR_CONFIG_IS_STORAGE_VOL_TARGET(target)); + g_return_if_fail((features & ~GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT) == 0); + + if ((features & GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT) != 0) { + GVirConfigObject *features_node; + features_node = gvir_config_object_replace_child(GVIR_CONFIG_OBJECT(target), "features"); + gvir_config_object_set_node_content(features_node, "lazy_refcount", ""); + g_object_unref(features_node); + } +} diff --git a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h index 2030e734..f1b50035 100644 --- a/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h +++ b/libvirt-gconfig/libvirt-gconfig-storage-vol-target.h @@ -69,6 +69,12 @@ void gvir_config_storage_vol_target_set_format(GVirConfigStorageVolTarget *targe const char *format); void gvir_config_storage_vol_target_set_permissions(GVirConfigStorageVolTarget *target, GVirConfigStoragePermissions *perms); +typedef enum { + GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT = 1 << 0 +} GVirConfigStorageVolTargetFeatures; + +void gvir_config_storage_vol_target_set_features(GVirConfigStorageVolTarget *target, + guint64 features); G_END_DECLS diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index ee5bf8ad..2d7486ea 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -779,4 +779,10 @@ global: gvir_config_domain_set_custom_xml_ns_children; } LIBVIRT_GCONFIG_0.2.4; +LIBVIRT_GCONFIG_2.0.1 { +global: + gvir_config_storage_vol_target_features_get_type; + gvir_config_storage_vol_target_set_features; +} LIBVIRT_GCONFIG_2.0.0; + # .... define new API here using predicted next version number .... diff --git a/libvirt-gconfig/tests/test-domain-create.c b/libvirt-gconfig/tests/test-domain-create.c index 79c242f4..f8fd6d51 100644 --- a/libvirt-gconfig/tests/test-domain-create.c +++ b/libvirt-gconfig/tests/test-domain-create.c @@ -498,6 +498,7 @@ int main(int argc, char **argv) gvir_config_storage_vol_target_set_format(vol_target, "qcow2"); gvir_config_storage_vol_target_set_permissions(vol_target, perms); gvir_config_storage_vol_target_set_compat(vol_target, "1.1"); + gvir_config_storage_vol_target_set_features(vol_target, GVIR_CONFIG_STORAGE_VOL_TARGET_FEATURE_LAZY_REFCOUNT); g_object_unref(G_OBJECT(perms)); gvir_config_storage_vol_set_target(vol, vol_target); g_object_unref(G_OBJECT(vol_target)); -- 2.20.1

2 1

[libvirt] [PATCH 00/18] qemu: virtio-{non-}transitional support
by Cole Robinson 06 Feb '19

06 Feb '19

This series adds support for virtio-transitional and virtio-non-transitional qemu devices. qemu patches, queued for qemu 4.0.0: https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg00923.html Previous libvirt discussion around this: https://www.redhat.com/archives/libvir-list/2018-August/msg01073.html Previous incomplete RFC here: https://www.redhat.com/archives/libvir-list/2019-January/msg00346.html Long story short we need to expose these options so apps have a usable way to support rhel6 + virtio + q35. This series exposes the new devices as model= values. This required adding new model= attributes for several devices. Here's the breakdown. 'standard names' here means the model names virtio, virtio-transitional, and virtio-non-transitional * Simply extended: virtio-rng: extend existing <rng model=X> to handle standard names vhost-vsock: extend existing <vsock model=X> to handle standard names virtio-memballoon: extend existings <memballoon model=X> to handle standard names virtio-net: extend existing qemu <model type=X> handling to support standard names * Extended with caveats: virtio-serial: extend <controller type='virtio-serial'> to handle existing model=X attribute, with standard names virtio-scsi: extend <controller type='scsi' model=X> to handle the additional names virtio-transitional and virtio-non-transitional. model= already supports virtio-scsi here which is a departure from just model='virtio' which most others use, but I chose to not extend that pattern and stick with the names the other devices are using vhost-scsi: extend <hostdev model=X> handling for the protocol=vhost case, to accept standard names. I stuck with standard names over using vhost-transitional or similar, for consistency with other devices. * New XML elements virtio-blk: add new <disk model=X/> attribute with standard names virtio-fs: add new <filesystem model=X> attribute with standard names virtio-input-host: add new <input model=X> attribute with standard names At the end is an extension to domaincapabilities to report the disk bus model values. Until domaincapabilities is fully fleshed out with support for all the above devices, apps can use that disk model check to assume transitional devices are available for all of the above. Cole Robinson (18): tests: Add capabilities data for QEMU 4.0.0 x86_64 conf: Add <disk model='virtio-{non-}transitional'/> qemu: Support disk model=virtio-{non-}transitional conf: Add virDomainNetHasVirtioModel qemu: Support interface model=virtio-{non-}transitional conf: Add <hostdev model='virtio-{non-}transitional'/> qemu: Support hostdev model=virtio-{non-}transitional qemu: Support rng model=virtio-{non-}transitional conf: Add <filesystem model='virtio-{non-}transitional'/> qemu: Support filesystem model=virtio-{non-}transitional qemu: Move memballoon validation out of command.c qemu: Support memballoon model=virtio-{non-}transitional qemu: Support vsock model=virtio-{non-}transitional conf: Add <input model='virtio-{non-}transitional'/> qemu: Support input model=virtio-{non-}transitional qemu: Support scsi controller model=virtio-{non-}transitional qemu: Support virtio-serial controller model=virtio-{non-}transitional qemu: domcaps: Report disk <enum name="model"> docs/formatdomain.html.in | 39 +- docs/schemas/domaincommon.rng | 60 +- src/conf/domain_capabilities.c | 1 + src/conf/domain_capabilities.h | 1 + src/conf/domain_conf.c | 216 +- src/conf/domain_conf.h | 68 +- src/libvirt_private.syms | 5 + src/libxl/libxl_conf.c | 2 + src/qemu/qemu_capabilities.c | 55 + src/qemu/qemu_capabilities.h | 28 + src/qemu/qemu_command.c | 219 +- src/qemu/qemu_domain.c | 47 +- src/qemu/qemu_domain_address.c | 69 +- src/qemu/qemu_driver.c | 9 +- src/qemu/qemu_hotplug.c | 2 +- src/qemu/qemu_interface.c | 8 +- src/qemu/qemu_process.c | 3 +- src/security/virt-aa-helper.c | 2 +- src/vbox/vbox_common.c | 2 + src/vmx/vmx.c | 4 +- .../bhyve_basic.x86_64.xml | 1 + .../bhyve_fbuf.x86_64.xml | 1 + .../bhyve_uefi.x86_64.xml | 1 + tests/domaincapsschemadata/full.xml | 6 + .../domaincapsschemadata/libxl-xenfv-usb.xml | 1 + .../domaincapsschemadata/libxl-xenpv-usb.xml | 1 + .../qemu_1.7.0.x86_64.xml | 1 + .../qemu_2.12.0-virt.aarch64.xml | 1 + .../qemu_2.12.0.ppc64.xml | 1 + .../qemu_2.12.0.s390x.xml | 1 + .../qemu_2.12.0.x86_64.xml | 1 + .../qemu_2.6.0-virt.aarch64.xml | 1 + .../qemu_2.6.0.aarch64.xml | 1 + .../domaincapsschemadata/qemu_2.6.0.ppc64.xml | 1 + .../qemu_2.6.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.7.0.s390x.xml | 1 + .../qemu_2.8.0-tcg.x86_64.xml | 1 + .../domaincapsschemadata/qemu_2.8.0.s390x.xml | 1 + .../qemu_2.8.0.x86_64.xml | 1 + .../qemu_2.9.0-q35.x86_64.xml | 1 + .../qemu_2.9.0-tcg.x86_64.xml | 1 + .../qemu_2.9.0.x86_64.xml | 1 + .../domaincapsschemadata/qemu_3.0.0.s390x.xml | 1 + .../qemu_4.0.0.x86_64.xml | 153 + tests/domaincapstest.c | 4 + .../caps_4.0.0.x86_64.replies | 23180 ++++++++++++++++ .../caps_4.0.0.x86_64.xml | 1404 + tests/qemucapabilitiestest.c | 1 + .../virtio-non-transitional.x86_64-3.1.0.args | 63 + ...virtio-non-transitional.x86_64-latest.args | 62 + .../virtio-non-transitional.xml | 40 + .../virtio-transitional.x86_64-3.1.0.args | 50 + .../virtio-transitional.x86_64-latest.args | 52 + .../qemuxml2argvdata/virtio-transitional.xml | 40 + tests/qemuxml2argvmock.c | 2 +- tests/qemuxml2argvtest.c | 6 + .../virtio-non-transitional.xml | 121 + .../virtio-transitional.xml | 80 + tests/qemuxml2xmltest.c | 17 + 59 files changed, 26031 insertions(+), 112 deletions(-) create mode 100644 tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml create mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.x86_64.replies create mode 100644 tests/qemucapabilitiesdata/caps_4.0.0.x86_64.xml create mode 100644 tests/qemuxml2argvdata/virtio-non-transitional.x86_64-3.1.0.args create mode 100644 tests/qemuxml2argvdata/virtio-non-transitional.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-non-transitional.xml create mode 100644 tests/qemuxml2argvdata/virtio-transitional.x86_64-3.1.0.args create mode 100644 tests/qemuxml2argvdata/virtio-transitional.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-transitional.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-non-transitional.xml create mode 100644 tests/qemuxml2xmloutdata/virtio-transitional.xml -- 2.20.1

4 80

[libvirt] exposing host-passthrough in virt-manager ui? (was: Re: [virt-tools-list] small suggestion)
by Cole Robinson 06 Feb '19

06 Feb '19

On 2/6/19 10:57 AM, Pavel Hrdina wrote: > On Wed, Feb 06, 2019 at 10:20:38AM -0500, Cole Robinson wrote: >> On 2/5/19 6:19 PM, Hetz Ben Hamo wrote: >>> Is it possible to add in the virt-manager the "host-passthrough" to the >>> CPU models please? >>> >> >> You can type 'host-passthrough' into the field and it will work. The reason >> we don't advertise it is because it's considered to have some mild >> supportability issues with libvirt. For the vast majority of use cases >> though it's completely fine > > Maybe we can reconsider this decision, the only thing that would not > work is live migration to destination with different CPU and we can > have a warning/info about it in the UI. > > Possibly we could allow to set 'host-passthrough' as the default guest > CPU in virt-manager config. > Nowadays with host-model being much smarter, is there much functional difference between host-model and host-passthrough? I don't really know the answer. > Most workstation/desktop users of virt-manager probably doesn't care > about live migration and it would copy the host CPU as closely as > possible. Since we allow to manually type in 'host-passthrough' I > personally don't see any reason why it cannot be selectable. > The problem I see is that host-passthrough sets the libvirt 'taint' flag on the VM. While it doesn't have any real impact on end users generally I took that to mean 'you are doing something that is unsupported'. I don't personally don't have strong feelings against it but I've just followed the advice I've been given here. Things have changed quite a bit in the cpu config space in the past few years so maybe things are different. changing subject and ccing libvir-list for wider audience Thanks, Cole

2 3

[libvirt] [PATCH] dosc: schema: fix usb source address device attribute format
by Nikolay Shirokovskiy 06 Feb '19

06 Feb '19

Device attribute does not have dotted "portAddr" format. Instead it has single number format described but "usbAddr" which corresponds to device parsing code in virDomainHostdevSubsysUSBDefParseXML. Looks like [1] mistakenly changed device format for hostdev devices. And [2] copy-n-paste this for hostdev network interfaces. [1] 31710a53 Modify USB port to be defined as a port path [2] 3b1c191f conf: parse/format type='hostdev' network interfaces Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- docs/schemas/domaincommon.rng | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index aa50eac..8c8d87e 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -2765,7 +2765,7 @@ <ref name="usbAddr"/> </attribute> <attribute name="device"> - <ref name="usbPort"/> + <ref name="usbAddr"/> </attribute> </group> </choice> @@ -4709,7 +4709,7 @@ <ref name="usbAddr"/> </attribute> <attribute name="device"> - <ref name="usbPort"/> + <ref name="usbAddr"/> </attribute> </element> </define> -- 1.8.3.1

3 3

[libvirt] running Libvirt from source code, IPC_LOCK and VFIO
by Daniel Henrique Barboza 06 Feb '19

06 Feb '19

Hi, I'm facing a strange behavior when running Libvirt from source code, latest upstream, on an Ubuntu 18.04.1 LTS Power 9 server. My QEMU guest - which is using VFIO and GPU passthrough - breaks on boot when trying to allocate a DMA window inside KVM. Debugging the code, I've found out that the problem is related to the process not having CAP_IPC_LOCK - at least from the host kernel perspective. This is strange because: - the same VM running directly from QEMU command line works - the same VM running in the system Libvirt (v4.0.0, Ubuntu version) also works What am I missing? My understanding on Linux process is that a process running as root should inherit the same capabilities of the user, which includes CAP_IPC_LOCK. Running Libvirt from source code should grant ipc_lock to it ... right? Any help is appreciated. I can provide more details (VM XML for example) if necessary. Thanks!

6 15

[libvirt] [jenkins-ci PATCH] Add support for cross compiling libvirt via Debian
by Daniel P. Berrangé 05 Feb '19

05 Feb '19

Debian's filesystem layout has a nice advantage over Fedora which is that it can install non-native RPMs in the main root filesystem. It is thus possible to prepare an x86_64 filesystem containing -dev packages for a foreign architecture, along with a GCC cross compiler. QEMU has used this technique to facilitate developer build testing of non-x86 architectures, since few people have access to physical hardware for most of these architectures. For the same reason it would be helpful to libvirt developers. This docker file allows creation of containers buildenv-cross-$ARCH for arm64, armel, armhf, mips, mipsel, mips64el, ppc64el, s390x, based off Debian 9, in which libvirt can be cross-compiled. Debian can support further architectures, but only by using the unstable 'sid' repos. This does not enable use of 'sid' but it could be added fairly easily at a later date if desired. Most of the other architectures are fairly old & obscure, the main interesting exception being riscv64. If qemu-user emulators are registered with the kernel binfmt, then it is theoretically possible to run "make check" tool, though this has not been tested. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- .gitignore | 1 + cross-build/arch-config.csv | 8 +++ cross-build/buildenv-cross.docker.in | 96 ++++++++++++++++++++++++++++ 3 files changed, 105 insertions(+) create mode 100644 cross-build/arch-config.csv create mode 100644 cross-build/buildenv-cross.docker.in diff --git a/.gitignore b/.gitignore index b25c15b..4884352 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ *~ +cross-build/*docker diff --git a/cross-build/arch-config.csv b/cross-build/arch-config.csv new file mode 100644 index 0000000..36fcb5f --- /dev/null +++ b/cross-build/arch-config.csv @@ -0,0 +1,8 @@ +arm64,crossbuild-essential-arm64,aarch64-linux-gnu +armel,crossbuild-essential-armel,arm-linux-gnueabi +armhf,crossbuild-essential-armhf,arm-linux-gnueabihf +mips64el,gcc-mips64el-linux-gnuabi64,mips64el-linux-gnuabi64 +mips,gcc-mips-linux-gnu,mips-linux-gnu +mipsel,gcc-mipsel-linux-gnu,mipsel-linux-gnu +ppc64el,crossbuild-essential-ppc64el,powerpc64le-linux-gnu +s390x,gcc-multilib-s390x-linux-gnu,s390x-linux-gnu diff --git a/cross-build/buildenv-cross.docker.in b/cross-build/buildenv-cross.docker.in new file mode 100644 index 0000000..97a9e69 --- /dev/null +++ b/cross-build/buildenv-cross.docker.in @@ -0,0 +1,96 @@ +# +# ::ARCH:: cross-compiler target +# +FROM debian:stretch-slim + +# Grab the updated list of packages +RUN apt update && apt dist-upgrade -yy + +# First some common native binaries. Any program that the +# build will execute needs to have a native binary package +# installed. We don't want to rely on qemu-user emulation +# for executing non-native binaries as that is slow & flaky +RUN DEBIAN_FRONTEND=noninteractive \ + apt-get install -y --no-install-recommends \ + git \ + build-essential \ + ca-certificates \ + libtool\ + autoconf \ + automake \ + python3 \ + xsltproc \ + parted \ + radvd \ + qemu-system-common \ + dwarves \ + libxml2-utils \ + dnsmasq-base \ + openssh-client \ + netcat-openbsd \ + ebtables \ + iptables \ + sheepdog \ + qemu-utils \ + qemu-system-x86 \ + pkg-config + + +# Add the ::ARCH:: architecture +RUN dpkg --add-architecture ::ARCH:: + + +# Grab the freshly updated list of packages +RUN apt update + + +# Pull in the native package for the cross-compiler +RUN DEBIAN_FRONTEND=noninteractive \ + apt-get install -y --no-install-recommends \ + ::COMPILER:: + +# Finally pull in the foreign architecture library +# packages that we're going to link against. Everything +# here should be a -dev package. Binaries belong earlier +RUN DEBIAN_FRONTEND=noninteractive \ + apt-get install -y --no-install-recommends \ + libxml2-dev:::ARCH:: \ + libncurses5-dev:::ARCH:: \ + libreadline-dev:::ARCH:: \ + zlib1g-dev:::ARCH:: \ + libgcrypt20-dev:::ARCH:: \ + libgnutls28-dev:::ARCH:: \ + libavahi-client-dev:::ARCH:: \ + libsasl2-dev:::ARCH:: \ + libparted-dev:::ARCH:: \ + libdevmapper-dev:::ARCH:: \ + uuid-dev:::ARCH:: \ + libudev-dev:::ARCH:: \ + libpciaccess-dev:::ARCH:: \ + libpolkit-gobject-1-dev:::ARCH:: \ + libcap-ng-dev:::ARCH:: \ + libnl-3-dev:::ARCH:: \ + libnl-route-3-dev:::ARCH:: \ + libyajl-dev:::ARCH:: \ + libpcap0.8-dev:::ARCH:: \ + libsanlock-dev:::ARCH:: \ + libaudit-dev:::ARCH:: \ + libselinux1-dev:::ARCH:: \ + libapparmor-dev:::ARCH:: \ + libdbus-1-dev:::ARCH:: \ + librbd-dev:::ARCH:: \ + librados-dev:::ARCH:: \ + libfuse-dev:::ARCH:: \ + libssh2-1-dev:::ARCH:: \ + libcurl4-gnutls-dev:::ARCH:: \ + libacl1-dev:::ARCH:: \ + libiscsi-dev:::ARCH:: \ + xfslibs-dev:::ARCH:: \ + libssh-dev:::ARCH:: \ + libgnutls28-dev:::ARCH:: + +# Tell libvirt which architecture we want to target +ENV LIBVIRT_CONFIGURE_OPTS "--host=::ABI:: --build=x86_64-linux-gnu --target=::ABI::" + +# Tell pkg-config where to find the non-native .pc files +ENV PKG_CONFIG_LIBDIR=/usr/lib/::ABI::/pkgconfig -- 2.20.1

2 2

[libvirt] [PULL 00/14] Ui 20190205 patches
by Gerd Hoffmann 05 Feb '19

05 Feb '19

The following changes since commit 773c4a6228fd910556cee2d477ee56c591a30000: test-filter-mirror: pass UNIX domain socket through fd (2019-02-04 16:03:20 +0000) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-20190205-pull-request for you to fetch changes up to 19c1b9fd3dd5955893c0d3c187a4180313e9a0f1: keymap: fix keyup mappings (2019-02-05 10:45:44 +0100) ---------------------------------------------------------------- ui: add kbd stats tracker. ui: gtk scroll fixes. ui: egl cursor scale fix. ui: more sdl1 cleanup. ---------------------------------------------------------------- Brendan Shanks (1): ui/cocoa.m: Fix macOS 10.14 deprecation warnings Chen Zhang (1): ui/egl-helpers: Augment parameter list of egl_texture_blend() to convey scales of viewport Gerd Hoffmann (8): kbd-state: add keyboard state tracker sdl2: remove sdl2_reset_keys() function kbd-state: use state tracker for sdl2 sdl2: use only QKeyCode in sdl2_process_key() kbd-state: use state tracker for gtk kbd-state: use state tracker for vnc keymap: pass full keyboard state to keysym2scancode keymap: fix keyup mappings Sergio Lopez (2): ui: don't send any event if delta_y == 0 ui: listen for GDK_SMOOTH_SCROLL events Thomas Huth (2): Remove deprecated -no-frame option ui/sdl_keysym: Remove obsolete SDL1.2 related code include/sysemu/sysemu.h | 1 - include/ui/egl-helpers.h | 2 +- include/ui/gtk.h | 2 + include/ui/kbd-state.h | 101 +++++++++++++++++ include/ui/sdl2.h | 3 +- ui/keymaps.h | 3 +- ui/sdl_keysym.h | 278 ----------------------------------------------- ui/vnc.h | 5 +- ui/curses.c | 2 +- ui/egl-headless.c | 3 +- ui/egl-helpers.c | 9 +- ui/gtk-egl.c | 3 +- ui/gtk.c | 43 ++------ ui/kbd-state.c | 130 ++++++++++++++++++++++ ui/keymaps.c | 55 ++++++---- ui/sdl2-input.c | 50 +-------- ui/sdl2.c | 12 +- ui/spice-display.c | 2 +- ui/vnc.c | 119 ++++++-------------- vl.c | 23 +--- qemu-deprecated.texi | 6 - qemu-options.hx | 11 -- ui/Makefile.objs | 2 +- ui/cocoa.m | 28 ++++- 24 files changed, 360 insertions(+), 533 deletions(-) create mode 100644 include/ui/kbd-state.h delete mode 100644 ui/sdl_keysym.h create mode 100644 ui/kbd-state.c -- 2.9.3

2 15