- Devel - libvirt List Archives

[libvirt] [PATCH] util: skip RDMA detection for non-PCI network devices
by Pavel Hrdina 08 Mar '19

08 Mar '19

Only PCI devices have '/sys/class/net/<ifname>/device/resource' so we need to skip this check for all other network devices. Without this patch and RDMA enabled libvirt will not detect any network device that doesn't have the path above which includes 'lo', 'virbr', 'tun', etc. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1639258 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/virnetdev.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index aeb9caab2a..699f2a0acb 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -2914,8 +2914,14 @@ virNetDevRDMAFeature(const char *ifname, if (virAsprintf(&eth_devpath, SYSFS_NET_DIR "%s/device/resource", ifname) < 0) goto cleanup; - if (!virFileExists(eth_devpath)) + + /* If /sys/class/net/<ifname>/device/resource doesn't exist it is not a PCI + * device and therefore it will not have RDMA. */ + if (!virFileExists(eth_devpath)) { + ret = 0; goto cleanup; + } + if (virFileReadAll(eth_devpath, RESOURCE_FILE_LEN, &eth_res_buf) < 0) goto cleanup; -- 2.20.1

2 1

[libvirt] [PATCH] conf: fix title and description for virDomainSetMetadata API
by Pavel Hrdina 08 Mar '19

08 Mar '19

If we pass XML to virDomainDefineXML API with these two elements: ... <title></title> <description></description> ... libvirt correctly ignores these two elements and they will not appear in the parsed XML. However, if we use virDomainSetMetadata API and with "" as value for title or description we will end up with the parsed XML that contains these empty elements. Let's fix the behavior of this API to behave the same as virDomainDefineXML. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1518042 Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/conf/domain_conf.c | 6 +++--- tests/metadatatest.c | 23 ++++++++++++++++------- 2 files changed, 19 insertions(+), 10 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 477deb777e..2fba58e5c4 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -30363,7 +30363,7 @@ virDomainDefSetMetadata(virDomainDefPtr def, xmlDocPtr doc = NULL; xmlNodePtr old; xmlNodePtr new = NULL; - char *tmp; + char *tmp = NULL; int ret = -1; if (type >= VIR_DOMAIN_METADATA_LAST) { @@ -30374,7 +30374,7 @@ virDomainDefSetMetadata(virDomainDefPtr def, switch ((virDomainMetadataType) type) { case VIR_DOMAIN_METADATA_DESCRIPTION: - if (VIR_STRDUP(tmp, metadata) < 0) + if (STRNEQ_NULLABLE(metadata, "") && VIR_STRDUP(tmp, metadata) < 0) goto cleanup; VIR_FREE(def->description); @@ -30382,7 +30382,7 @@ virDomainDefSetMetadata(virDomainDefPtr def, break; case VIR_DOMAIN_METADATA_TITLE: - if (VIR_STRDUP(tmp, metadata) < 0) + if (STRNEQ_NULLABLE(metadata, "") && VIR_STRDUP(tmp, metadata) < 0) goto cleanup; VIR_FREE(def->title); diff --git a/tests/metadatatest.c b/tests/metadatatest.c index 786c62e623..a9080b32d7 100644 --- a/tests/metadatatest.c +++ b/tests/metadatatest.c @@ -167,6 +167,7 @@ struct metadataTest { virDomainPtr dom; const char *data; + const char *expect; int type; bool fail; }; @@ -232,7 +233,7 @@ testTextMetadata(const void *data) actual = virDomainGetMetadata(test->dom, test->type, NULL, 0); - if (STRNEQ_NULLABLE(test->data, actual)) { + if (STRNEQ_NULLABLE(test->expect, actual)) { virReportError(VIR_ERR_INTERNAL_ERROR, "expected metadata doesn't match actual: " "expected:'%s'\ngot: '%s'", @@ -248,10 +249,11 @@ testTextMetadata(const void *data) return ret; } -#define TEST_TEXT_METADATA(INDEX, TYPE, DATA, FAIL) \ +#define TEST_TEXT_METADATA(INDEX, TYPE, DATA, EXPECT, FAIL) \ do { \ test.type = VIR_DOMAIN_METADATA_ ## TYPE; \ test.data = DATA; \ + test.expect = EXPECT; \ test.fail = FAIL; \ \ if (virTestRun("text metadata: " #TYPE " " INDEX " ", \ @@ -259,9 +261,16 @@ testTextMetadata(const void *data) ret = EXIT_FAILURE; \ } while (0) -#define TEST_TITLE(INDEX, DATA) TEST_TEXT_METADATA(INDEX, TITLE, DATA, false) -#define TEST_TITLE_FAIL(INDEX, DATA) TEST_TEXT_METADATA(INDEX, TITLE, DATA, true) -#define TEST_DESCR(INDEX, DATA) TEST_TEXT_METADATA(INDEX, DESCRIPTION, DATA, false) +#define TEST_TITLE(INDEX, DATA) \ + TEST_TEXT_METADATA(INDEX, TITLE, DATA, DATA, false) +#define TEST_TITLE_EXPECT(INDEX, DATA, EXPECT) \ + TEST_TEXT_METADATA(INDEX, TITLE, DATA, EXPECT, false) +#define TEST_TITLE_FAIL(INDEX, DATA) \ + TEST_TEXT_METADATA(INDEX, TITLE, DATA, DATA, true) +#define TEST_DESCR(INDEX, DATA) \ + TEST_TEXT_METADATA(INDEX, DESCRIPTION, DATA, DATA, false) +#define TEST_DESCR_EXPECT(INDEX, DATA, EXPECT) \ + TEST_TEXT_METADATA(INDEX, DESCRIPTION, DATA, EXPECT, false) static int mymain(void) @@ -290,7 +299,7 @@ mymain(void) TEST_TITLE("2", NULL); TEST_TITLE("3", "blah"); TEST_TITLE_FAIL("4", "qwe\nrt"); - TEST_TITLE("5", ""); + TEST_TITLE_EXPECT("5", "", NULL); TEST_TITLE_FAIL("6", "qwert\n"); TEST_TITLE_FAIL("7", "\n"); @@ -298,7 +307,7 @@ mymain(void) TEST_DESCR("2", NULL); TEST_DESCR("3", "qwert"); TEST_DESCR("4", "\n"); - TEST_DESCR("5", ""); + TEST_DESCR_EXPECT("5", "", NULL); virDomainFree(test.dom); virConnectClose(test.conn); -- 2.20.1

2 1

[libvirt] [PATCH] qemu: Fix query-cpus-fast target architecture detection
by Boris Fiuczynski 08 Mar '19

08 Mar '19

From: Viktor Mihajlovski <mihajlov(a)linux.ibm.com> Since qemu 2.13 reports the target architecture in a property called 'target' additionally to the property 'arch', that has been used in qemu 2.12 in the response data of 'query-cpus-fast'. Libvirts monitor code prefers the 'target' property over 'arch'. At least for s390(x), target is reported as 's390x' while arch is 's390'. In a later step a comparison is performed against 's390' which fails for qemu 2.13 and later. In consequence the architecture specific data for s390 won't be extracted from the returned data, leading to incorrect values being reported by virsh domstats --vcpu. Changing to check explicitly for 's390' and 's390x'. Signed-off-by: Viktor Mihajlovski <mihajlov(a)linux.ibm.com> Reviewed-by: Bjoern Walk <bwalk(a)linux.ibm.com> Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> --- src/qemu/qemu_monitor_json.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index cf474eb6c8..0236323a51 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -1772,7 +1772,7 @@ qemuMonitorJSONExtractCPUInfo(virJSONValuePtr data, goto cleanup; /* process optional architecture-specific data */ - if (STREQ_NULLABLE(arch, "s390")) + if (STREQ_NULLABLE(arch, "s390") || STREQ_NULLABLE(arch, "s390x")) qemuMonitorJSONExtractCPUS390Info(entry, cpus + i); } -- 2.17.0

2 3

[libvirt] [PATCH] news: document virtio-{non-}transitional feature
by Cole Robinson 08 Mar '19

08 Mar '19

Signed-off-by: Cole Robinson <crobinso(a)redhat.com> --- docs/news.xml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index f58c30ee22..81466c3d55 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -47,6 +47,25 @@ virConnectGetStoragePoolCapabilites API. </description> </change> + <change> + <summary> + qemu: Support virtio-{non-}transitional device models + </summary> + <description> + <code>virtio-transitional</code> and + <code>virtio-non-transitional</code> <code>model</code> values + were added to the QEMU driver for the following devices: + <code>disk</code>, <code>interface</code>, <code>filesystem</code>, + <code>rng</code>, <code>vsock</code>, <code>memballoon</code>, + <code>controller</code> type <code>scsi</code>, + <code>controller</code> type <code>virtio-serial</code>, + <code>input</code> bus <code>virtio</code> + type <code>passthrough</code>, + <code>hostdev</code> type <code>scsi_host</code>. These new + models can be used to give fine grained control over what + virtio device version is presented to the guest. + </description> + </change> </section> <section title="Improvements"> </section> -- 2.20.1

2 1

[libvirt] [PATCH v2] tools/virt-host-validate: Fix IOMMU check on s390x
by Thomas Huth 08 Mar '19

08 Mar '19

When running virt-host-validate on an s390x host, the tool currently warns that it is "Unknown if this platform has IOMMU support". We can use the common check for entries in /sys/kernel/iommu_groups here, too, but it only makes sense to check it if there are also PCI devices available. It's also common on s390x that there are no PCI devices assigned to the LPAR, and in that case there is no need for the PCI-related IOMMU, so without PCI devices we should simply skip this test. Signed-off-by: Thomas Huth <thuth(a)redhat.com> --- v2: - Use virDirOpen() + virDirRead() instead of stat() - this should hopefully work now as expected. tools/virt-host-validate-common.c | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/tools/virt-host-validate-common.c b/tools/virt-host-validate-common.c index 73e3bdb..e27b558 100644 --- a/tools/virt-host-validate-common.c +++ b/tools/virt-host-validate-common.c @@ -337,7 +337,12 @@ int virHostValidateIOMMU(const char *hvname, virBitmapPtr flags; struct stat sb; const char *bootarg = NULL; - bool isAMD = false, isIntel = false, isPPC = false; + bool isAMD = false, isIntel = false; + virArch arch = virArchFromHost(); + struct dirent *dent; + DIR *dir; + int rc; + flags = virHostValidateGetCPUFlags(); if (flags && virBitmapIsBitSet(flags, VIR_HOST_VALIDATE_CPU_FLAG_VMX)) @@ -347,8 +352,6 @@ int virHostValidateIOMMU(const char *hvname, virBitmapFree(flags); - isPPC = ARCH_IS_PPC64(virArchFromHost()); - if (isIntel) { virHostMsgCheck(hvname, "%s", _("for device assignment IOMMU support")); if (access("/sys/firmware/acpi/tables/DMAR", F_OK) == 0) { @@ -373,8 +376,17 @@ int virHostValidateIOMMU(const char *hvname, "hardware platform"); return -1; } - } else if (isPPC) { + } else if (ARCH_IS_PPC64(arch)) { /* Empty Block */ + } else if (ARCH_IS_S390(arch)) { + /* On s390x, we skip the IOMMU check if there are no PCI devices + * (which is quite usual on s390x) */ + if (!virDirOpen(&dir, "/sys/bus/pci/devices")) + return 0; + rc = virDirRead(dir, &dent, NULL); + VIR_DIR_CLOSE(dir); + if (rc <= 0) + return 0; } else { virHostMsgFail(level, "Unknown if this platform has IOMMU support"); @@ -391,7 +403,7 @@ int virHostValidateIOMMU(const char *hvname, virHostMsgCheck(hvname, "%s", _("if IOMMU is enabled by kernel")); if (sb.st_nlink <= 2) { - if (!isPPC) + if (bootarg) virHostMsgFail(level, "IOMMU appears to be disabled in kernel. " "Add %s to kernel cmdline arguments", bootarg); -- 1.8.3.1

4 5

[libvirt] [PATCH] snapshots: Trivial doc improvements
by Eric Blake 08 Mar '19

08 Mar '19

Fix an incorrect @xmlDesc comment, as well as adding more details about which XML element should be root. Signed-off-by: Eric Blake <eblake(a)redhat.com> --- Pushing this one as trivial; noticed it while working on Jan's suggestion of a new API for bulk dumpxml/redefine. src/libvirt-domain-snapshot.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c index a647a500d6..11d84289f8 100644 --- a/src/libvirt-domain-snapshot.c +++ b/src/libvirt-domain-snapshot.c @@ -98,11 +98,11 @@ virDomainSnapshotGetConnect(virDomainSnapshotPtr snapshot) /** * virDomainSnapshotCreateXML: * @domain: a domain object - * @xmlDesc: string containing an XML description of the domain + * @xmlDesc: string containing an XML description of the domain snapshot * @flags: bitwise-OR of virDomainSnapshotCreateFlags * * Creates a new snapshot of a domain based on the snapshot xml - * contained in xmlDesc. + * contained in xmlDesc, with a top-level element <domainsnapshot>. * * If @flags is 0, the domain can be active, in which case the * snapshot will be a full system snapshot (capturing both disk state, @@ -247,7 +247,8 @@ virDomainSnapshotCreateXML(virDomainPtr domain, * @snapshot: a domain snapshot object * @flags: bitwise-OR of supported virDomainSnapshotXMLFlags * - * Provide an XML description of the domain snapshot. + * Provide an XML description of the domain snapshot, with a top-level + * element of <domainsnapshot>. * * No security-sensitive data will be included unless @flags contains * VIR_DOMAIN_SNAPSHOT_XML_SECURE; this flag is rejected on read-only -- 2.20.1

1 0

[libvirt] [PATCH v3 00/18] bulk snapshot list/redefine (incremental backup saga)
by Eric Blake 07 Mar '19

07 Mar '19

While looking at my work on incremental backups, Nir raised a good point: if we want to recreate a set of known checkpoints on one machine that will be taking over a domain from another machine, my initial proposal required making multiple API calls to list the XML for each checkpoint on the source, and then more API calls to redefine each checkpoint on the destination; it also had the drawback that the list has to be presented in topological order (the API won't let you define a child checkpoint if the parent is not defined first). He asked if I could instead add bulk APIs, for getting the XML for all checkpoints at once, and then for redefining all checkpoints at once. Since my checkpoint code borrows heavily from concepts in the snapshot code, I chose to tackle the problem by starting with this series, which does the same thing for snapshots as what I plan to do for checkpoints. That is, since this patch series adds virDomainGetXMLDesc(, VIR_DOMAIN_XML_SNAPSHOTS) and virDomainSnapshotCreateXML(, VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE_LIST), the checkpoint series will add virDOmainGetXMLDesc(, VIR_DOMAIN_XML_CHECKPOINTS) and virDomainCheckpointCreateXML(, VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE_LIST) with very similar code. Also available at: https://repo.or.cz/libvirt/ericb.git/shortlog/refs/tags/snapshot-bulk-v3 Changes since v2: - address lots of comments from John - split and rearrange some patches - incorporate remaining patches from my series fixing --redefine bugs - rebase to master 001/18:[down] 'qemu: Refactor snapshot check for _LIVE vs. _REDEFINE' 002/18:[down] 'snapshot: Rework virDomainSnapshotState enum' 003/18:[down] 'qemu: Use virDomainSnapshotState for switch statements' 004/18:[0017] [FC] 'snapshot: Give virDomainSnapshotDefFormat its own flags' 005/18:[0003] [FC] 'snapshot: Refactor virDomainSnapshotDefFormat' 006/18:[0029] [FC] 'snapshot: Add virDomainSnapshotObjListFormat' 007/18:[down] 'domain: Add struct for future domain format parameters' 008/18:[down] 'snapshot: Avoid latent use-after-free when cleaning snapshots' 009/18:[0071] [FC] 'domain: Expand virDomainDefFormatInternal with snapshots' 010/18:[down] 'snapshot: Split out virDomainSnapshotRedefineValidate helper' 011/18:[down] 'snapshot: Add virDomainSnapshotObjListParse' 012/18:[0005] [FC] 'domain: Add VIR_DOMAIN_XML_SNAPSHOTS flag' 013/18:[0002] [FC] 'snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE_LIST flag' 014/18:[0018] [FC] 'virsh: Expose bulk snapshot dumpxml/redefine' 015/18:[0010] [FC] 'test: Implement bulk snapshot operations' 016/18:[down] 'qemu: Factor out qemuDomainSnapshotValidate() helper' 017/18:[down] 'qemu: Const-correct snapshot directory name' 018/18:[0033] [FC] 'qemu: Implement bulk snapshot operations' Eric Blake (18): qemu: Refactor snapshot check for _LIVE vs. _REDEFINE snapshot: Rework virDomainSnapshotState enum qemu: Use virDomainSnapshotState for switch statements snapshot: Give virDomainSnapshotDefFormat its own flags snapshot: Refactor virDomainSnapshotDefFormat snapshot: Add virDomainSnapshotObjListFormat domain: Add struct for future domain format parameters snapshot: Avoid latent use-after-free when cleaning snapshots domain: Expand virDomainDefFormatInternal with snapshots snapshot: Split out virDomainSnapshotRedefineValidate helper snapshot: Add virDomainSnapshotObjListParse domain: Add VIR_DOMAIN_XML_SNAPSHOTS flag snapshot: Add VIR_DOMAIN_SNAPSHOT_CREATE_REDEFINE_LIST flag virsh: Expose bulk snapshot dumpxml/redefine test: Implement bulk snapshot operations qemu: Factor out qemuDomainSnapshotValidate() helper qemu: Const-correct snapshot directory name qemu: Implement bulk snapshot operations include/libvirt/libvirt-domain-snapshot.h | 3 + include/libvirt/libvirt-domain.h | 1 + src/conf/domain_conf.h | 21 +- src/conf/snapshot_conf.h | 47 +- src/qemu/qemu_domain.h | 2 +- src/conf/domain_conf.c | 69 ++- src/conf/snapshot_conf.c | 513 ++++++++++++++++------ src/esx/esx_driver.c | 1 - src/libvirt-domain-snapshot.c | 23 +- src/libvirt-domain.c | 8 +- src/libvirt_private.syms | 3 + src/network/bridge_driver.c | 2 +- src/qemu/qemu_domain.c | 47 +- src/qemu/qemu_driver.c | 234 ++++++---- src/test/test_driver.c | 52 ++- src/vbox/vbox_common.c | 13 +- src/vz/vz_driver.c | 3 +- tests/domainsnapshotxml2xmltest.c | 16 +- tools/virsh-domain.c | 7 + tools/virsh-snapshot.c | 14 + tools/virsh.pod | 18 +- 21 files changed, 790 insertions(+), 307 deletions(-) -- 2.20.1

3 38

[libvirt] [PATCH] LXC containers don't stopped under some conditions
by Maxim Kozin 07 Mar '19

07 Mar '19

LXC containers can be started, but time to time can't be stopped. 1) virsh shutdown with option "--mode initctl" always stop container, but virsh report error: "Container does not provide an initctl pipe" In container present /dev/initctl 2) virsh shutdown with option "--mode signal" never stop lxc container, at least for centos 7.5/7.6 In container log: systemd: Received SIGTERM. systemd: Reexecuting. systemd: systemd 219 running in system mode. (+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 -SECCOMP +BLKID +ELFUTILS +KMOD +IDN) systemd: Detected virtualization lxc-libvirt. systemd: Detected architecture x86-64. 3) virsh shutdown without option "--mode" can stop lxc container, but in 2 cases: - cointainer not under heavy load - in gdb when perform step-by-setp debug But most often not, with simptoms as with --mode signal. Patch tested only with host centos 7.6 and guests centos 7.5/7.6 Short comments to patch. lxcDomainShutdownFlags() return rc=0 and container begin stopped. We not go to endjob label, but later we pass check: if (rc == 0 && (flags == 0 || (flags & VIR_DOMAIN_SHUTDOWN_SIGNAL))) { And trying next shutdown method with sigterm to PID 1. If container heavy loaded, it not stopped. IF not or if you wait in gdb, then first method succefully perform shutdown. Signed-off-by: Maxim Kozin <kolomaxes(a)gmail.com> --- src/lxc/lxc_driver.c | 40 ++++++++++++++++++---------------------- 1 file changed, 18 insertions(+), 22 deletions(-) diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index b1ef221..760f9f8 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -3269,7 +3269,7 @@ lxcDomainShutdownFlags(virDomainPtr dom, virLXCDomainObjPrivatePtr priv; virDomainObjPtr vm; int ret = -1; - int rc; + int rc = -1; virCheckFlags(VIR_DOMAIN_SHUTDOWN_INITCTL | VIR_DOMAIN_SHUTDOWN_SIGNAL, -1); @@ -3298,19 +3298,17 @@ lxcDomainShutdownFlags(virDomainPtr dom, (flags & VIR_DOMAIN_SHUTDOWN_INITCTL)) { int command = VIR_INITCTL_RUNLEVEL_POWEROFF; - if ((rc = virLXCDomainSetRunlevel(vm, command)) < 0) - goto endjob; - if (rc == 0 && flags != 0 && - ((flags & ~VIR_DOMAIN_SHUTDOWN_INITCTL) == 0)) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("Container does not provide an initctl pipe")); - goto endjob; + if ((rc = virLXCDomainSetRunlevel(vm, command)) < 0) { + if (flags != 0 && + (flags & VIR_DOMAIN_SHUTDOWN_INITCTL)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("Container does not provide an initctl pipe")); + goto endjob; + } } - } else { - rc = 0; } - if (rc == 0 && + if (rc < 0 && (flags == 0 || (flags & VIR_DOMAIN_SHUTDOWN_SIGNAL))) { if (kill(priv->initpid, SIGTERM) < 0 && @@ -3347,7 +3345,7 @@ lxcDomainReboot(virDomainPtr dom, virLXCDomainObjPrivatePtr priv; virDomainObjPtr vm; int ret = -1; - int rc; + int rc = -1; virCheckFlags(VIR_DOMAIN_REBOOT_INITCTL | VIR_DOMAIN_REBOOT_SIGNAL, -1); @@ -3376,19 +3374,17 @@ lxcDomainReboot(virDomainPtr dom, (flags & VIR_DOMAIN_REBOOT_INITCTL)) { int command = VIR_INITCTL_RUNLEVEL_REBOOT; - if ((rc = virLXCDomainSetRunlevel(vm, command)) < 0) - goto endjob; - if (rc == 0 && flags != 0 && - ((flags & ~VIR_DOMAIN_SHUTDOWN_INITCTL) == 0)) { - virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", - _("Container does not provide an initctl pipe")); - goto endjob; + if ((rc = virLXCDomainSetRunlevel(vm, command)) < 0) { + if (flags != 0 && + (flags & VIR_DOMAIN_REBOOT_INITCTL)) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("Container does not provide an initctl pipe")); + goto endjob; + } } - } else { - rc = 0; } - if (rc == 0 && + if (rc < 0 && (flags == 0 || (flags & VIR_DOMAIN_REBOOT_SIGNAL))) { if (kill(priv->initpid, SIGHUP) < 0 && -- 1.8.3.1

2 1

[libvirt] [PATCH] conf: Remove unnecessary @ctxt check in virSecurityLabelDefsParseXML
by John Ferlan 07 Mar '19

07 Mar '19

Failure would have occurred before in callers other virXPath calls. Found by Coverity due to commit 66a508d2 using VIR_XPATH_NODE_AUTORESTORE to access @ctxt before the if condition. Signed-off-by: John Ferlan <jferlan(a)redhat.com> --- src/conf/domain_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index eb660f5764..dc57b23084 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -8516,8 +8516,7 @@ virSecurityLabelDefsParseXML(virDomainDefPtr def, virCapsHostPtr host = &caps->host; VIR_AUTOFREE(xmlNodePtr *) list = NULL; - /* Check args and save context */ - if (def == NULL || ctxt == NULL) + if (def == NULL) return 0; /* Allocate a security labels based on XML */ -- 2.20.1

2 1

[libvirt] [PATCH 0/7] util: Further tweaks to virstring
by Andrea Bolognani 07 Mar '19

07 Mar '19

Some changes where suggested during review of https://www.redhat.com/archives/libvir-list/2019-March/msg00342.html and some weren't :) Andrea Bolognani (7): util: Make virStringHasCaseSuffix() return bool util: Make virStringStripSuffix() return bool util: Make virStringMatchesNameSuffix() return bool util: Tweak virStringHasSuffix() util: Tweak virStringHasCaseSuffix() util: Tweak virStringMatchesNameSuffix() util: Tweak virStringMatchesNameSuffix() some more src/util/virstring.c | 40 +++++++++++++++++++++++++--------------- src/util/virstring.h | 14 +++++++------- tests/testutilsqemu.c | 2 +- 3 files changed, 33 insertions(+), 23 deletions(-) -- 2.20.1

2 12

[libvirt] [PATCH] numa: warn if numa 'mem' option or default RAM splitting between nodes is used.
by Igor Mammedov 07 Mar '19

07 Mar '19

Ammend -numa option docs and print warnings if 'mem' option or default RAM splitting between nodes is used. It's intended to discourage users from using configuration that allows only to fake NUMA on guest side while leading to reduced performance of the guest due to inability to properly configure VM's RAM on the host. In NUMA case, it's recommended to always explicitly configure guest RAM using -numa node,memdev={backend-id} option. Signed-off-by: Igor Mammedov <imammedo(a)redhat.com> --- numa.c | 5 +++++ qemu-options.hx | 12 ++++++++---- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/numa.c b/numa.c index 3875e1e..c6c2a6f 100644 --- a/numa.c +++ b/numa.c @@ -121,6 +121,8 @@ static void parse_numa_node(MachineState *ms, NumaNodeOptions *node, if (node->has_mem) { numa_info[nodenr].node_mem = node->mem; + warn_report("Parameter -numa node,mem is obsolete," + " use -numa node,memdev instead"); } if (node->has_memdev) { Object *o; @@ -407,6 +409,9 @@ void numa_complete_configuration(MachineState *ms) if (i == nb_numa_nodes) { assert(mc->numa_auto_assign_ram); mc->numa_auto_assign_ram(mc, numa_info, nb_numa_nodes, ram_size); + warn_report("Default splitting of RAM between nodes is obsolete," + " Use '-numa node,memdev' to explictly define RAM" + " allocation per node"); } numa_total = 0; diff --git a/qemu-options.hx b/qemu-options.hx index 1cf9aac..033e311 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -206,10 +206,14 @@ For example: -numa cpu,node-id=0,socket-id=0 -numa cpu,node-id=1,socket-id=1 @end example -@samp{mem} assigns a given RAM amount to a node. @samp{memdev} -assigns RAM from a given memory backend device to a node. If -@samp{mem} and @samp{memdev} are omitted in all nodes, RAM is -split equally between them. +@samp{memdev} assigns RAM from a given memory backend device to a node. + +Legacy options/behaviour: @samp{mem} assigns a given RAM amount to a node. +If @samp{mem} and @samp{memdev} are omitted in all nodes, RAM is split equally +between them. Option @samp{mem} and default RAM splitting are obsolete as they +do not provide means to manage RAM on host side and only allow QEMU to fake +NUMA support which in practice could degrade VM performance. +It's advised to always explicitly configure NUMA RAM using @samp{memdev} option. @samp{mem} and @samp{memdev} are mutually exclusive. Furthermore, if one node uses @samp{memdev}, all of them have to use it. -- 2.7.4

3 7

[libvirt] [PATCH] cpu: Don't access invalid memory in virCPUx86Translate
by Michal Privoznik 07 Mar '19

07 Mar '19

Problem is that if there are no signatures for a CPU, then we still allocate cpu->signatures (even though with size 0). Later, we access cpu->signatures[0] if cpu->signatures is not NULL. Invalid read of size 4 at 0x5F439D7: virCPUx86Translate (cpu_x86.c:2930) by 0x5F3C239: virCPUTranslate (cpu.c:927) by 0x57CE7A1: qemuProcessUpdateGuestCPU (qemu_process.c:5870) ... Address 0xf752d40 is 0 bytes after a block of size 0 alloc'd at 0x4C30EC6: calloc (vg_replace_malloc.c:711) by 0x5DBDE4E: virAllocN (viralloc.c:190) by 0x5F3E4FA: x86ModelCopySignatures (cpu_x86.c:990) by 0x5F3E60F: x86ModelCopy (cpu_x86.c:1008) by 0x5F3E7CB: x86ModelFromCPU (cpu_x86.c:1068) by 0x5F4397E: virCPUx86Translate (cpu_x86.c:2922) by 0x5F3C239: virCPUTranslate (cpu.c:927) by 0x57CE7A1: qemuProcessUpdateGuestCPU (qemu_process.c:5870) ... Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/cpu/cpu_x86.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c index 92941d1287..c8697819ab 100644 --- a/src/cpu/cpu_x86.c +++ b/src/cpu/cpu_x86.c @@ -987,6 +987,9 @@ x86ModelCopySignatures(virCPUx86ModelPtr dst, { size_t i; + if (src->nsignatures == 0) + return 0; + if (VIR_ALLOC_N(dst->signatures, src->nsignatures) < 0) return -1; @@ -2926,7 +2929,7 @@ virCPUx86Translate(virCPUDefPtr cpu, virCPUx86DataAddCPUIDInt(&model->data, &model->vendor->cpuid) < 0) goto cleanup; - if (model->signatures && + if (model->nsignatures && x86DataAddSignature(&model->data, model->signatures[0]) < 0) goto cleanup; -- 2.19.2

3 2

[libvirt] [PATCH 0/2] ui: support for authorization control on TLS connections
by Daniel P. Berrangé 07 Mar '19

07 Mar '19

This series provides the VNC parts of the authorization control series previously posted as: v1: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg04482.html v2: https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg05727.html v3: https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg01639.html v4: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg04319.html The core authz framework is now merged & these patches have all had positive review. Thus these VNC parts are ready to go into the VNC maintainer's tree, should the maintainer consider them acceptable. Note the 2nd patch is modifying the HMP, but I considered it part of ui/vnc, since that's the only bit of QEMU which ever used these HMP commands, and it has a dependancy on the first patch merging first. Daniel P. Berrangé (2): vnc: allow specifying a custom authorization object name monitor: deprecate acl_show, acl_reset, acl_policy, acl_add, acl_remove monitor.c | 23 ++++++++++++++++++ qemu-deprecated.texi | 11 +++++++++ qemu-options.hx | 35 ++++++++++++++++++-------- ui/vnc.c | 58 +++++++++++++++++++++++++++++++++++++------- 4 files changed, 108 insertions(+), 19 deletions(-) -- 2.20.1

2 5

[libvirt] [PATCH 0/8] qemu: separate out deprecated capabilities
by Ján Tomko 07 Mar '19

07 Mar '19

Ján Tomko (8): DO NOT PUSH: allow skipping selected lines in group-qemu-caps.pl Introduce virQEMUCapsDeprecated array Split out virQEMUCapsSetFromNodes Use virQEMUCapsSetFromNodes where possible qemustatusxml2xmltests: remove deprecated qemu capabilities virQEMUCapsSetFromNodes: Skip setting deprecated flags Delete deprecated qemu capabilities from the enum DO NOT PUSH: fix capabilities grouping src/qemu/qemu_capabilities.c | 452 +++++++++--------- src/qemu/qemu_capabilities.h | 305 ++++-------- src/qemu/qemu_domain.c | 16 +- tests/group-qemu-caps.pl | 21 + tests/qemucaps2xmltest.c | 17 +- .../blockjob-mirror-in.xml | 1 - .../disk-secinfo-upgrade-out.xml | 51 -- .../migration-in-params-in.xml | 53 -- .../migration-out-nbd-out.xml | 51 -- .../migration-out-nbd-tls-in.xml | 51 -- .../migration-out-params-in.xml | 53 -- tests/qemustatusxml2xmldata/modern-in.xml | 51 -- .../qemustatusxml2xmldata/vcpus-multi-in.xml | 1 - 13 files changed, 339 insertions(+), 784 deletions(-) -- 2.19.2

4 19

[libvirt] [PATCH 0/4] implement cgroups v2 cpuset controller support
by Pavel Hrdina 07 Mar '19

07 Mar '19

Pavel Hrdina (4): util: implement virCgroupV2(Set|Get)CpusetMems util: implement virCgroupV2(Set|Get)CpusetMemoryMigrate util: implement virCgroupV2(Set|Get)CpusetCpus util: enable cgroups v2 cpuset controller for threads src/util/vircgroupv2.c | 74 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 74 insertions(+) -- 2.20.1

2 5

[libvirt] [PATCH] docs: remove Google+ link from page footer
by Daniel P. Berrangé 07 Mar '19

07 Mar '19

Google is shutting down Google+, with no replacement, in the very near future so we are loosing the Libvirt community group there. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/page.xsl | 1 - 1 file changed, 1 deletion(-) diff --git a/docs/page.xsl b/docs/page.xsl index c1804eab34..4698e2789e 100644 --- a/docs/page.xsl +++ b/docs/page.xsl @@ -175,7 +175,6 @@ <h3>Community</h3> <ul> <li><a href="https://twitter.com/hashtag/libvirt">twitter</a></li> - <li><a href="https://plus.google.com/communities/109522598353007505282">google+</a></li> <li><a href="http://stackoverflow.com/questions/tagged/libvirt">stackoverflow</a></li> <li><a href="http://serverfault.com/questions/tagged/libvirt">serverfault</a></li> </ul> -- 2.20.1

4 4

[libvirt] [PATCH] tests: use VIR_AUTOUNREF in storagepoolcapstest
by Pavel Hrdina 07 Mar '19

07 Mar '19

Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- tests/storagepoolcapstest.c | 31 +++++++++++-------------------- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/tests/storagepoolcapstest.c b/tests/storagepoolcapstest.c index f8b560c2f0..518a5fdfe7 100644 --- a/tests/storagepoolcapstest.c +++ b/tests/storagepoolcapstest.c @@ -54,30 +54,26 @@ test_virStoragePoolCapsFormat(const void *opaque) struct test_virStoragePoolCapsFormatData *data = (struct test_virStoragePoolCapsFormatData *) opaque; virCapsPtr driverCaps = data->driverCaps; - virStoragePoolCapsPtr poolCaps = NULL; - int ret = -1; + VIR_AUTOUNREF(virStoragePoolCapsPtr) poolCaps = NULL; VIR_AUTOFREE(char *) path = NULL; VIR_AUTOFREE(char *) poolCapsXML = NULL; if (!(poolCaps = virStoragePoolCapsNew(driverCaps))) - goto cleanup; + return -1; if (virAsprintf(&path, "%s/storagepoolcapsschemadata/poolcaps-%s.xml", - abs_srcdir, data->filename) < 0) - goto cleanup; + abs_srcdir, data->filename) < 0) { + return -1; + } if (!(poolCapsXML = virStoragePoolCapsFormat(poolCaps))) - goto cleanup; + return -1; if (virTestCompareToFile(poolCapsXML, path) < 0) - goto cleanup; + return -1; - ret = 0; - - cleanup: - virObjectUnref(poolCaps); - return ret; + return 0; } @@ -85,8 +81,8 @@ static int mymain(void) { int ret = 0; - virCapsPtr fullCaps = NULL; - virCapsPtr fsCaps = NULL; + VIR_AUTOUNREF(virCapsPtr) fullCaps = NULL; + VIR_AUTOUNREF(virCapsPtr) fsCaps = NULL; #define DO_TEST(Filename, DriverCaps) \ do { \ @@ -98,8 +94,7 @@ mymain(void) if (!(fullCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false)) || !(fsCaps = virCapabilitiesNew(VIR_ARCH_NONE, false, false))) { - ret = -1; - goto cleanup; + return -1; } test_virCapabilitiesAddFullStoragePool(fullCaps); @@ -108,10 +103,6 @@ mymain(void) DO_TEST("full", fullCaps); DO_TEST("fs", fsCaps); - cleanup: - virObjectUnref(fullCaps); - virObjectUnref(fsCaps); - return ret; } -- 2.20.1

2 1

[libvirt] [PATCH 0/3] Define XDG variables for hypervisor domains
by Erik Skultety 07 Mar '19

07 Mar '19

So, according to this report [1], Mesa enabled on-disk cache for its shaders which it tries to create either under XDG_CACHE_HOME/mesa_shader_cache or under HOME/.cache/mesa_shader_cache. Since libvirt doesn't set XDGs and HOME is only passed iff the QEMU process isn't run with SUID, Mesa will default to the home directory specified in /etc/passwd. Because of this, Mesa will fail to create the cache and QEMU refuses to start the VM (interestingly enough, Intel reports the problem too, but Mesa disables the cache and the VM starts). This series proposes usage of XDG variables to fix the problem by pointing XDG variables to hypervisor specific directory under libvirt's libDir. Additionally, HOME is also enforced for all VM processes and points to the base hypervisor libDir directory. To illustrate this further: system qemu: HOME=/var/lib/libvirt/qemu/domain-5-f-live \ XDG_DATA_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.local/share \ XDG_CACHE_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.cache \ XDG_CONFIG_HOME=/var/lib/libvirt/qemu/domain-5-f-live/.config \ session qemu: HOME=/home/eskultet/.config/libvirt/qemu/lib/domain-4-f-live \ XDG_DATA_HOME=/home/eskultet/.config/libvirt/qemu/lib/domain-4-f-live/.local/share \ XDG_CACHE_HOME=/home/eskultet/.config/libvirt/qemu/lib/domain-4-f-live/.cache \ XDG_CONFIG_HOME=/home/eskultet/.config/libvirt/qemu/lib/domain-4-f-live/.config \ [1] https://bugzilla.redhat.com/show_bug.cgi?id=1659484 Erik Skultety (3): qemu: command: Introduce virCommandAddEnvXDG helper qemu: Introduce qemuCommandEnvSetup helper qemu: command: Override HOME variable for QEMU processes src/libvirt_private.syms | 1 + src/qemu/qemu_command.c | 26 ++++++++++++++++++- src/qemu/qemu_command.h | 3 +++ src/util/vircommand.c | 21 +++++++++++++++ src/util/vircommand.h | 2 ++ .../aarch64-aavmf-virtio-mmio.args | 5 +++- tests/qemuxml2argvdata/aarch64-acpi-uefi.args | 5 +++- .../aarch64-cpu-passthrough.args | 5 +++- tests/qemuxml2argvdata/aarch64-gic-host.args | 5 +++- .../aarch64-gic-none-tcg.args | 5 +++- tests/qemuxml2argvdata/aarch64-gic-v2.args | 5 +++- tests/qemuxml2argvdata/aarch64-gic-v3.args | 5 +++- .../aarch64-kvm-32-on-64.args | 5 +++- .../aarch64-noacpi-nouefi.args | 5 +++- .../qemuxml2argvdata/aarch64-noacpi-uefi.args | 5 +++- .../qemuxml2argvdata/aarch64-pci-serial.args | 5 +++- .../aarch64-traditional-pci.args | 5 +++- .../aarch64-usb-controller-nec-xhci.args | 5 +++- .../aarch64-usb-controller-qemu-xhci.args | 5 +++- .../aarch64-video-default.args | 5 +++- .../aarch64-video-virtio-gpu-pci.args | 5 +++- .../aarch64-virt-2.6-virtio-pci-default.args | 5 +++- .../aarch64-virt-default-nic.args | 5 +++- .../aarch64-virt-headless.aarch64-latest.args | 5 +++- .../qemuxml2argvdata/aarch64-virt-virtio.args | 5 +++- .../aarch64-virtio-pci-default.args | 5 +++- .../aarch64-virtio-pci-manual-addresses.args | 5 +++- tests/qemuxml2argvdata/acpi-table.args | 5 +++- .../arm-vexpressa9-basic.args | 5 +++- .../arm-vexpressa9-nodevs.args | 5 +++- .../arm-vexpressa9-virtio.args | 5 +++- tests/qemuxml2argvdata/arm-virt-virtio.args | 5 +++- tests/qemuxml2argvdata/autoindex.args | 5 +++- .../qemuxml2argvdata/balloon-ccw-deflate.args | 5 +++- .../qemuxml2argvdata/balloon-device-auto.args | 5 +++- .../balloon-device-deflate-off.args | 5 +++- .../balloon-device-deflate.args | 5 +++- .../balloon-device-period.args | 5 +++- tests/qemuxml2argvdata/balloon-device.args | 5 +++- .../balloon-mmio-deflate.args | 5 +++- tests/qemuxml2argvdata/bios-nvram-secure.args | 5 +++- tests/qemuxml2argvdata/bios-nvram.args | 5 +++- tests/qemuxml2argvdata/bios.args | 5 +++- .../blkdeviotune-group-num.args | 5 +++- .../blkdeviotune-max-length.args | 5 +++- tests/qemuxml2argvdata/blkdeviotune-max.args | 5 +++- tests/qemuxml2argvdata/blkiotune-device.args | 5 +++- tests/qemuxml2argvdata/blkiotune.args | 5 +++- tests/qemuxml2argvdata/boot-cdrom.args | 5 +++- tests/qemuxml2argvdata/boot-complex.args | 5 +++- tests/qemuxml2argvdata/boot-floppy-q35.args | 5 +++- tests/qemuxml2argvdata/boot-floppy.args | 5 +++- .../boot-menu-disable-drive.args | 5 +++- tests/qemuxml2argvdata/boot-menu-disable.args | 5 +++- .../boot-menu-enable-with-timeout.args | 5 +++- tests/qemuxml2argvdata/boot-menu-enable.args | 5 +++- tests/qemuxml2argvdata/boot-multi.args | 5 +++- tests/qemuxml2argvdata/boot-network.args | 5 +++- tests/qemuxml2argvdata/boot-order.args | 5 +++- tests/qemuxml2argvdata/boot-strict.args | 5 +++- tests/qemuxml2argvdata/channel-guestfwd.args | 5 +++- tests/qemuxml2argvdata/channel-spicevmc.args | 5 +++- .../channel-unix-guestfwd.x86_64-2.5.0.args | 5 +++- .../channel-unix-guestfwd.x86_64-latest.args | 5 +++- .../qemuxml2argvdata/channel-virtio-auto.args | 5 +++- .../channel-virtio-autoadd.args | 5 +++- .../channel-virtio-autoassign.args | 5 +++- .../channel-virtio-default.args | 5 +++- .../channel-virtio-state.args | 5 +++- .../qemuxml2argvdata/channel-virtio-unix.args | 5 +++- tests/qemuxml2argvdata/channel-virtio.args | 5 +++- tests/qemuxml2argvdata/chardev-reconnect.args | 5 +++- tests/qemuxml2argvdata/clock-catchup.args | 5 +++- tests/qemuxml2argvdata/clock-france.args | 5 +++- tests/qemuxml2argvdata/clock-hpet-off.args | 5 +++- .../clock-localtime-basis-localtime.args | 5 +++- tests/qemuxml2argvdata/clock-localtime.args | 5 +++- .../clock-timer-hyperv-rtc.args | 5 +++- tests/qemuxml2argvdata/clock-utc.args | 5 +++- tests/qemuxml2argvdata/clock-variable.args | 5 +++- .../qemuxml2argvdata/console-compat-auto.args | 5 +++- .../console-compat-chardev.args | 5 +++- tests/qemuxml2argvdata/console-compat.args | 5 +++- tests/qemuxml2argvdata/console-sclp.args | 5 +++- .../qemuxml2argvdata/console-virtio-ccw.args | 5 +++- .../qemuxml2argvdata/console-virtio-many.args | 5 +++- .../qemuxml2argvdata/console-virtio-s390.args | 5 +++- .../console-virtio-unix.x86_64-2.5.0.args | 5 +++- .../console-virtio-unix.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/console-virtio.args | 5 +++- tests/qemuxml2argvdata/controller-order.args | 5 +++- .../controller-virtio-scsi.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/cpu-Haswell-noTSX.args | 5 +++- tests/qemuxml2argvdata/cpu-Haswell.args | 5 +++- tests/qemuxml2argvdata/cpu-Haswell2.args | 5 +++- tests/qemuxml2argvdata/cpu-Haswell3.args | 5 +++- tests/qemuxml2argvdata/cpu-cache-disable.args | 5 +++- .../qemuxml2argvdata/cpu-cache-disable2.args | 5 +++- .../qemuxml2argvdata/cpu-cache-disable3.args | 5 +++- .../cpu-cache-emulate-l3.args | 5 +++- .../cpu-cache-passthrough.args | 5 +++- .../cpu-cache-passthrough2.args | 5 +++- .../cpu-check-default-none.args | 5 +++- .../cpu-check-default-none2.args | 5 +++- .../cpu-check-default-partial.args | 5 +++- .../cpu-check-default-partial2.args | 5 +++- tests/qemuxml2argvdata/cpu-check-none.args | 5 +++- tests/qemuxml2argvdata/cpu-eoi-disabled.args | 5 +++- tests/qemuxml2argvdata/cpu-eoi-enabled.args | 5 +++- tests/qemuxml2argvdata/cpu-exact1.args | 5 +++- .../cpu-exact2-nofallback.args | 5 +++- tests/qemuxml2argvdata/cpu-exact2.args | 5 +++- tests/qemuxml2argvdata/cpu-fallback.args | 5 +++- tests/qemuxml2argvdata/cpu-host-kvmclock.args | 5 +++- .../qemuxml2argvdata/cpu-host-model-cmt.args | 5 +++- .../cpu-host-model-fallback.args | 5 +++- .../cpu-host-model-vendor.args | 5 +++- tests/qemuxml2argvdata/cpu-host-model.args | 5 +++- .../cpu-host-passthrough-features.args | 5 +++- .../cpu-host-passthrough.args | 5 +++- .../qemuxml2argvdata/cpu-hotplug-startup.args | 5 +++- tests/qemuxml2argvdata/cpu-kvmclock.args | 5 +++- tests/qemuxml2argvdata/cpu-minimum1.args | 5 +++- tests/qemuxml2argvdata/cpu-minimum2.args | 5 +++- tests/qemuxml2argvdata/cpu-numa-disjoint.args | 5 +++- .../qemuxml2argvdata/cpu-numa-memshared.args | 5 +++- .../cpu-numa-no-memory-element.args | 5 +++- tests/qemuxml2argvdata/cpu-numa1.args | 5 +++- tests/qemuxml2argvdata/cpu-numa2.args | 5 +++- tests/qemuxml2argvdata/cpu-s390-features.args | 5 +++- tests/qemuxml2argvdata/cpu-s390-zEC12.args | 5 +++- tests/qemuxml2argvdata/cpu-strict1.args | 5 +++- tests/qemuxml2argvdata/cpu-topology1.args | 5 +++- tests/qemuxml2argvdata/cpu-topology2.args | 5 +++- tests/qemuxml2argvdata/cpu-topology3.args | 5 +++- tests/qemuxml2argvdata/cpu-tsc-frequency.args | 5 +++- tests/qemuxml2argvdata/cputune-numatune.args | 5 +++- .../qemuxml2argvdata/cputune-zero-shares.args | 5 +++- tests/qemuxml2argvdata/cputune.args | 5 +++- tests/qemuxml2argvdata/debug-threads.args | 5 +++- .../default-kvm-host-arch.args | 5 +++- .../default-qemu-host-arch.args | 5 +++- tests/qemuxml2argvdata/disk-aio.args | 5 +++- .../disk-aio.x86_64-2.12.0.args | 5 +++- .../disk-aio.x86_64-latest.args | 5 +++- ...-backing-chains-noindex.x86_64-2.12.0.args | 5 +++- ...-backing-chains-noindex.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-blockio.args | 5 +++- tests/qemuxml2argvdata/disk-boot-cdrom.args | 5 +++- tests/qemuxml2argvdata/disk-boot-disk.args | 5 +++- .../disk-cache.x86_64-1.5.3.args | 5 +++- .../disk-cache.x86_64-2.12.0.args | 5 +++- .../disk-cache.x86_64-2.6.0.args | 5 +++- .../disk-cache.x86_64-2.7.0.args | 5 +++- .../disk-cache.x86_64-latest.args | 5 +++- .../disk-cdrom-bus-other.x86_64-latest.args | 5 +++- .../qemuxml2argvdata/disk-cdrom-network.args | 5 +++- .../disk-cdrom-network.x86_64-2.12.0.args | 5 +++- .../disk-cdrom-network.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-cdrom-tray.args | 5 +++- .../disk-cdrom-tray.x86_64-2.12.0.args | 5 +++- .../disk-cdrom-tray.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-cdrom.args | 5 +++- .../disk-cdrom.x86_64-2.12.0.args | 5 +++- .../disk-cdrom.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-copy_on_read.args | 5 +++- .../disk-copy_on_read.x86_64-2.12.0.args | 5 +++- .../disk-copy_on_read.x86_64-latest.args | 5 +++- .../qemuxml2argvdata/disk-detect-zeroes.args | 5 +++- .../disk-detect-zeroes.x86_64-2.12.0.args | 5 +++- .../disk-detect-zeroes.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-discard.args | 5 +++- tests/qemuxml2argvdata/disk-error-policy.args | 5 +++- .../disk-error-policy.x86_64-2.12.0.args | 5 +++- .../disk-error-policy.x86_64-latest.args | 5 +++- .../disk-floppy-q35-2_11.x86_64-2.12.0.args | 5 +++- .../disk-floppy-q35-2_11.x86_64-latest.args | 5 +++- .../disk-floppy-q35-2_9.x86_64-2.12.0.args | 5 +++- .../disk-floppy-q35-2_9.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-floppy-tray.args | 5 +++- tests/qemuxml2argvdata/disk-floppy.args | 5 +++- .../disk-floppy.x86_64-2.12.0.args | 5 +++- .../disk-floppy.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-fmt-qcow.args | 5 +++- tests/qemuxml2argvdata/disk-geometry.args | 5 +++- ...sk-hostdev-scsi-virtio-iscsi-auth-AES.args | 5 +++- tests/qemuxml2argvdata/disk-ide-split.args | 5 +++- tests/qemuxml2argvdata/disk-ide-wwn.args | 5 +++- tests/qemuxml2argvdata/disk-ioeventfd.args | 5 +++- tests/qemuxml2argvdata/disk-iscsi.args | 5 +++- .../disk-network-gluster.args | 5 +++- .../disk-network-gluster.x86_64-2.12.0.args | 5 +++- .../disk-network-gluster.x86_64-latest.args | 5 +++- .../disk-network-iscsi-modern.args | 5 +++- .../qemuxml2argvdata/disk-network-iscsi.args | 5 +++- .../disk-network-iscsi.x86_64-2.12.0.args | 5 +++- .../disk-network-iscsi.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-network-nbd.args | 5 +++- .../disk-network-nbd.x86_64-2.12.0.args | 5 +++- .../disk-network-nbd.x86_64-latest.args | 5 +++- .../disk-network-rbd.x86_64-2.12.0.args | 5 +++- .../disk-network-rbd.x86_64-2.5.0.args | 5 +++- .../disk-network-rbd.x86_64-latest.args | 5 +++- .../disk-network-sheepdog.args | 5 +++- .../disk-network-sheepdog.x86_64-2.12.0.args | 5 +++- .../disk-network-sheepdog.x86_64-latest.args | 5 +++- .../disk-network-source-auth.args | 5 +++- ...isk-network-source-auth.x86_64-2.12.0.args | 5 +++- ...isk-network-source-auth.x86_64-latest.args | 5 +++- .../disk-network-tlsx509.args | 5 +++- .../disk-network-tlsx509.x86_64-2.12.0.args | 5 +++- .../disk-network-tlsx509.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-network-vxhs.args | 5 +++- tests/qemuxml2argvdata/disk-no-boot.args | 5 +++- tests/qemuxml2argvdata/disk-order.args | 5 +++- .../qemuxml2argvdata/disk-readonly-disk.args | 5 +++- .../disk-readonly-disk.x86_64-2.12.0.args | 5 +++- .../disk-readonly-disk.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-sata-device.args | 5 +++- .../disk-scsi-device-auto.x86_64-1.5.3.args | 5 +++- .../disk-scsi-device-auto.x86_64-latest.args | 5 +++- .../disk-scsi-disk-split.args | 5 +++- .../qemuxml2argvdata/disk-scsi-disk-vpd.args | 5 +++- .../qemuxml2argvdata/disk-scsi-disk-wwn.args | 5 +++- .../disk-scsi-lun-passthrough.args | 5 +++- .../disk-scsi.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-serial.args | 5 +++- .../disk-shared.x86_64-2.12.0.args | 5 +++- .../disk-shared.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-snapshot.args | 5 +++- .../disk-source-pool-mode.args | 5 +++- tests/qemuxml2argvdata/disk-source-pool.args | 5 +++- .../disk-usb-device-removable.args | 5 +++- tests/qemuxml2argvdata/disk-usb-device.args | 5 +++- .../disk-virtio-ccw-many.args | 5 +++- tests/qemuxml2argvdata/disk-virtio-ccw.args | 5 +++- .../qemuxml2argvdata/disk-virtio-queues.args | 5 +++- .../disk-virtio-s390-zpci.args | 5 +++- tests/qemuxml2argvdata/disk-virtio-s390.args | 5 +++- ...irtio-scsi-reservations.x86_64-2.12.0.args | 5 +++- ...irtio-scsi-reservations.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/disk-virtio.args | 5 +++- .../encrypted-disk-usage.args | 5 +++- tests/qemuxml2argvdata/encrypted-disk.args | 5 +++- tests/qemuxml2argvdata/eoi-disabled.args | 5 +++- tests/qemuxml2argvdata/eoi-enabled.args | 5 +++- tests/qemuxml2argvdata/event_idx.args | 5 +++- .../fd-memory-no-numa-topology.args | 5 +++- .../fd-memory-numa-topology.args | 5 +++- .../fd-memory-numa-topology2.args | 5 +++- .../fd-memory-numa-topology3.args | 5 +++- tests/qemuxml2argvdata/fips-enabled.args | 5 +++- tests/qemuxml2argvdata/floppy-drive-fat.args | 5 +++- .../floppy-drive-fat.x86_64-2.12.0.args | 5 +++- .../floppy-drive-fat.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/fs9p-ccw.args | 5 +++- tests/qemuxml2argvdata/fs9p.args | 5 +++- .../genid-auto.x86_64-latest.args | 5 +++- .../qemuxml2argvdata/genid.x86_64-latest.args | 5 +++- ...egl-headless-rendernode.x86_64-latest.args | 5 +++- .../graphics-egl-headless.args | 5 +++- .../graphics-egl-headless.x86_64-latest.args | 5 +++- .../graphics-sdl-fullscreen.args | 5 +++- tests/qemuxml2argvdata/graphics-sdl.args | 5 +++- .../graphics-spice-agent-file-xfer.args | 5 +++- .../graphics-spice-agentmouse.args | 5 +++- .../graphics-spice-auto-socket-cfg.args | 5 +++- .../graphics-spice-auto-socket.args | 5 +++- .../graphics-spice-compression.args | 5 +++- .../graphics-spice-egl-headless.args | 5 +++- ...pice-gl-auto-rendernode.x86_64-latest.args | 5 +++- .../graphics-spice-no-args.args | 5 +++- .../graphics-spice-qxl-vga.args | 5 +++- .../qemuxml2argvdata/graphics-spice-sasl.args | 5 +++- .../graphics-spice-socket.args | 5 +++- .../graphics-spice-timeout.args | 5 +++- .../graphics-spice-usb-redir.args | 5 +++- tests/qemuxml2argvdata/graphics-spice.args | 5 +++- .../graphics-vnc-auto-socket-cfg.args | 5 +++- .../graphics-vnc-auto-socket.args | 5 +++- .../graphics-vnc-egl-headless.args | 5 +++- .../graphics-vnc-no-listen-attr.args | 5 +++- tests/qemuxml2argvdata/graphics-vnc-none.args | 5 +++- .../qemuxml2argvdata/graphics-vnc-policy.args | 5 +++- .../graphics-vnc-remove-generated-socket.args | 5 +++- tests/qemuxml2argvdata/graphics-vnc-sasl.args | 5 +++- .../graphics-vnc-socket-new-cmdline.args | 5 +++- .../qemuxml2argvdata/graphics-vnc-socket.args | 5 +++- ...graphics-vnc-tls-secret.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/graphics-vnc-tls.args | 5 +++- .../graphics-vnc-tls.x86_64-2.4.0.args | 5 +++- .../graphics-vnc-tls.x86_64-latest.args | 5 +++- .../graphics-vnc-websocket.args | 5 +++- tests/qemuxml2argvdata/graphics-vnc.args | 5 +++- ...play-spice-egl-headless.x86_64-latest.args | 5 +++- ...ev-display-spice-opengl.x86_64-latest.args | 5 +++- ...isplay-vnc-egl-headless.x86_64-latest.args | 5 +++- ...ostdev-mdev-display-vnc.x86_64-latest.args | 5 +++- .../hostdev-mdev-precreated.args | 5 +++- .../hostdev-pci-address-device.args | 5 +++- .../qemuxml2argvdata/hostdev-pci-address.args | 5 +++- .../hostdev-scsi-lsi-iscsi-auth.args | 5 +++- .../hostdev-scsi-lsi-iscsi.args | 5 +++- tests/qemuxml2argvdata/hostdev-scsi-lsi.args | 5 +++- .../hostdev-scsi-readonly.args | 5 +++- .../hostdev-scsi-vhost-scsi-ccw.args | 5 +++- .../hostdev-scsi-vhost-scsi-pci.args | 5 +++- .../hostdev-scsi-vhost-scsi-pcie.args | 5 +++- .../hostdev-scsi-virtio-iscsi-auth.args | 5 +++- .../hostdev-scsi-virtio-iscsi.args | 5 +++- .../hostdev-scsi-virtio-scsi.args | 5 +++- .../hostdev-subsys-mdev-vfio-ccw.args | 5 +++- .../hostdev-usb-address-device-boot.args | 5 +++- .../hostdev-usb-address-device.args | 5 +++- .../qemuxml2argvdata/hostdev-usb-address.args | 5 +++- .../hostdev-vfio-multidomain.args | 5 +++- .../hostdev-vfio-zpci-autogenerate.args | 5 +++- .../hostdev-vfio-zpci-boundaries.args | 5 +++- .../hostdev-vfio-zpci-multidomain-many.args | 5 +++- tests/qemuxml2argvdata/hostdev-vfio-zpci.args | 5 +++- tests/qemuxml2argvdata/hostdev-vfio.args | 5 +++- tests/qemuxml2argvdata/hotplug-base.args | 5 +++- .../hugepages-default-2M.args | 5 +++- .../hugepages-default-system-size.args | 5 +++- tests/qemuxml2argvdata/hugepages-default.args | 5 +++- .../qemuxml2argvdata/hugepages-memaccess.args | 5 +++- .../hugepages-memaccess2.args | 5 +++- tests/qemuxml2argvdata/hugepages-nodeset.args | 5 +++- .../hugepages-numa-default-2M.args | 5 +++- .../hugepages-numa-default-dimm.args | 5 +++- .../hugepages-numa-default.args | 5 +++- .../hugepages-numa-nodeset-part.args | 5 +++- .../hugepages-numa-nodeset.args | 5 +++- .../hugepages-nvdimm.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/hugepages-shared.args | 5 +++- tests/qemuxml2argvdata/hyperv-off.args | 5 +++- tests/qemuxml2argvdata/hyperv-panic.args | 5 +++- tests/qemuxml2argvdata/hyperv.args | 5 +++- .../qemuxml2argvdata/input-usbmouse-addr.args | 5 +++- tests/qemuxml2argvdata/input-usbmouse.args | 5 +++- tests/qemuxml2argvdata/input-usbtablet.args | 5 +++- tests/qemuxml2argvdata/input-virtio-ccw.args | 5 +++- .../intel-iommu-caching-mode.args | 5 +++- .../intel-iommu-device-iotlb.args | 5 +++- tests/qemuxml2argvdata/intel-iommu-eim.args | 5 +++- .../qemuxml2argvdata/intel-iommu-machine.args | 5 +++- tests/qemuxml2argvdata/intel-iommu.args | 5 +++- .../iothreads-disk-virtio-ccw.args | 5 +++- tests/qemuxml2argvdata/iothreads-disk.args | 5 +++- .../iothreads-ids-partial.args | 5 +++- tests/qemuxml2argvdata/iothreads-ids.args | 5 +++- ...othreads-virtio-scsi-ccw.s390x-latest.args | 5 +++- ...threads-virtio-scsi-pci.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/iothreads.args | 5 +++- tests/qemuxml2argvdata/kvm-features-off.args | 5 +++- tests/qemuxml2argvdata/kvm-features.args | 5 +++- tests/qemuxml2argvdata/kvm-pit-delay.args | 5 +++- tests/qemuxml2argvdata/kvm-pit-discard.args | 5 +++- .../kvmclock+eoi-disabled.args | 5 +++- tests/qemuxml2argvdata/kvmclock.args | 5 +++- .../launch-security-sev.x86_64-2.12.0.args | 5 +++- .../luks-disks-source-qcow2.args | 5 +++- tests/qemuxml2argvdata/luks-disks-source.args | 5 +++- tests/qemuxml2argvdata/luks-disks.args | 5 +++- .../mach-virt-console-virtio.args | 5 +++- .../mach-virt-serial-native.args | 5 +++- .../mach-virt-serial-pci.args | 5 +++- .../mach-virt-serial-usb.args | 5 +++- .../machine-aeskeywrap-off-cap.args | 5 +++- .../machine-aeskeywrap-off-caps.args | 5 +++- .../machine-aeskeywrap-on-cap.args | 5 +++- .../machine-aeskeywrap-on-caps.args | 5 +++- tests/qemuxml2argvdata/machine-aliases1.args | 5 +++- tests/qemuxml2argvdata/machine-aliases2.args | 5 +++- tests/qemuxml2argvdata/machine-core-off.args | 5 +++- tests/qemuxml2argvdata/machine-core-on.args | 5 +++- .../machine-deakeywrap-off-cap.args | 5 +++- .../machine-deakeywrap-off-caps.args | 5 +++- .../machine-deakeywrap-on-cap.args | 5 +++- .../machine-deakeywrap-on-caps.args | 5 +++- .../machine-keywrap-none-caps.args | 5 +++- .../machine-keywrap-none.args | 5 +++- ...ine-loadparm-multiple-disks-nets-s390.args | 5 +++- .../machine-loadparm-net-s390.args | 5 +++- .../machine-loadparm-s390.args | 5 +++- tests/qemuxml2argvdata/machine-smm-opt.args | 5 +++- .../qemuxml2argvdata/machine-vmport-opt.args | 5 +++- tests/qemuxml2argvdata/master-key.args | 5 +++- .../memfd-memory-numa.x86_64-latest.args | 5 +++- .../memory-hotplug-dimm-addr.args | 5 +++- .../qemuxml2argvdata/memory-hotplug-dimm.args | 5 +++- ...y-hotplug-nvdimm-access.x86_64-latest.args | 5 +++- ...ry-hotplug-nvdimm-align.x86_64-latest.args | 5 +++- ...ry-hotplug-nvdimm-label.x86_64-latest.args | 5 +++- ...ory-hotplug-nvdimm-pmem.x86_64-latest.args | 5 +++- ...hotplug-nvdimm-readonly.x86_64-latest.args | 5 +++- .../memory-hotplug-nvdimm.x86_64-latest.args | 5 +++- .../memory-hotplug-ppc64-nonuma.args | 5 +++- tests/qemuxml2argvdata/memory-hotplug.args | 5 +++- tests/qemuxml2argvdata/memtune-unlimited.args | 5 +++- tests/qemuxml2argvdata/memtune.args | 5 +++- .../migrate-numa-unaligned.args | 5 +++- tests/qemuxml2argvdata/migrate.args | 5 +++- .../minimal-msg-timestamp.args | 5 +++- tests/qemuxml2argvdata/minimal-sandbox.args | 5 +++- tests/qemuxml2argvdata/minimal.args | 5 +++- tests/qemuxml2argvdata/misc-acpi.args | 5 +++- tests/qemuxml2argvdata/misc-disable-s3.args | 5 +++- .../misc-disable-suspends.args | 5 +++- tests/qemuxml2argvdata/misc-enable-s4.args | 5 +++- tests/qemuxml2argvdata/misc-no-reboot.args | 5 +++- tests/qemuxml2argvdata/misc-uuid.args | 5 +++- tests/qemuxml2argvdata/mlock-off.args | 5 +++- tests/qemuxml2argvdata/mlock-on.args | 5 +++- tests/qemuxml2argvdata/mlock-unsupported.args | 5 +++- tests/qemuxml2argvdata/monitor-json.args | 5 +++- .../multifunction-pci-device.args | 5 +++- tests/qemuxml2argvdata/name-escape.args | 5 +++- tests/qemuxml2argvdata/net-client.args | 5 +++- tests/qemuxml2argvdata/net-eth-hostip.args | 5 +++- tests/qemuxml2argvdata/net-eth-ifname.args | 5 +++- tests/qemuxml2argvdata/net-eth-names.args | 5 +++- tests/qemuxml2argvdata/net-eth.args | 5 +++- .../net-hostdev-bootorder.args | 5 +++- .../net-hostdev-multidomain.args | 5 +++- .../net-hostdev-vfio-multidomain.args | 5 +++- tests/qemuxml2argvdata/net-hostdev-vfio.args | 5 +++- tests/qemuxml2argvdata/net-hostdev.args | 5 +++- tests/qemuxml2argvdata/net-mcast.args | 5 +++- tests/qemuxml2argvdata/net-server.args | 5 +++- tests/qemuxml2argvdata/net-udp.args | 5 +++- tests/qemuxml2argvdata/net-user-addr.args | 5 +++- tests/qemuxml2argvdata/net-user.args | 5 +++- .../net-vhostuser-multiq.args | 5 +++- tests/qemuxml2argvdata/net-vhostuser.args | 5 +++- .../net-vhostuser.x86_64-2.5.0.args | 5 +++- .../net-vhostuser.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/net-virtio-ccw.args | 5 +++- tests/qemuxml2argvdata/net-virtio-device.args | 5 +++- .../net-virtio-disable-offloads.args | 5 +++- tests/qemuxml2argvdata/net-virtio-netdev.args | 5 +++- .../net-virtio-rxtxqueuesize.args | 5 +++- tests/qemuxml2argvdata/net-virtio-s390.args | 5 +++- tests/qemuxml2argvdata/net-virtio.args | 5 +++- tests/qemuxml2argvdata/nosharepages.args | 5 +++- .../numad-auto-memory-vcpu-cpuset.args | 5 +++- ...o-memory-vcpu-no-cpuset-and-placement.args | 5 +++- .../numad-auto-vcpu-static-numatune.args | 5 +++- .../numad-static-memory-auto-vcpu.args | 5 +++- tests/qemuxml2argvdata/numad.args | 5 +++- .../numatune-auto-nodeset-invalid.args | 5 +++- .../numatune-auto-prefer.args | 5 +++- .../qemuxml2argvdata/numatune-distances.args | 5 +++- .../numatune-memnode-no-memory.args | 5 +++- tests/qemuxml2argvdata/numatune-memnode.args | 5 +++- tests/qemuxml2argvdata/numatune-memory.args | 5 +++- .../qemuxml2argvdata/pages-dimm-discard.args | 5 +++- .../pages-discard-hugepages.args | 5 +++- tests/qemuxml2argvdata/pages-discard.args | 5 +++- tests/qemuxml2argvdata/panic-double.args | 5 +++- tests/qemuxml2argvdata/panic-no-address.args | 5 +++- tests/qemuxml2argvdata/panic.args | 5 +++- .../parallel-parport-chardev.args | 5 +++- .../parallel-tcp-chardev.args | 5 +++- .../parallel-unix-chardev.x86_64-2.5.0.args | 5 +++- .../parallel-unix-chardev.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/pci-autoadd-addr.args | 5 +++- tests/qemuxml2argvdata/pci-autoadd-idx.args | 5 +++- tests/qemuxml2argvdata/pci-autofill-addr.args | 5 +++- .../pci-bridge-many-disks.args | 5 +++- tests/qemuxml2argvdata/pci-bridge.args | 5 +++- tests/qemuxml2argvdata/pci-expander-bus.args | 5 +++- tests/qemuxml2argvdata/pci-many.args | 5 +++- tests/qemuxml2argvdata/pci-rom-disabled.args | 5 +++- tests/qemuxml2argvdata/pci-rom.args | 5 +++- .../pci-serial-dev-chardev.args | 5 +++- tests/qemuxml2argvdata/pcie-expander-bus.args | 5 +++- .../pcie-root-port-model-generic.args | 5 +++- .../pcie-root-port-model-ioh3420.args | 5 +++- tests/qemuxml2argvdata/pcie-root-port.args | 5 +++- tests/qemuxml2argvdata/pcie-root.args | 5 +++- .../pcie-switch-downstream-port.args | 5 +++- .../pcie-switch-upstream-port.args | 5 +++- tests/qemuxml2argvdata/pcihole64-q35.args | 5 +++- tests/qemuxml2argvdata/pcihole64.args | 5 +++- tests/qemuxml2argvdata/pmu-feature-off.args | 5 +++- tests/qemuxml2argvdata/pmu-feature.args | 5 +++- tests/qemuxml2argvdata/ppc-dtb.args | 5 +++- .../ppc64-pseries-headless.ppc64-latest.args | 5 +++- .../ppc64-usb-controller-legacy.args | 5 +++- .../ppc64-usb-controller-qemu-xhci.args | 5 +++- .../ppc64-usb-controller.args | 5 +++- tests/qemuxml2argvdata/ppce500-serial.args | 5 +++- tests/qemuxml2argvdata/pseries-basic.args | 5 +++- .../pseries-console-virtio.args | 5 +++- .../pseries-cpu-compat-power9.args | 5 +++- .../qemuxml2argvdata/pseries-cpu-compat.args | 5 +++- tests/qemuxml2argvdata/pseries-cpu-exact.args | 5 +++- tests/qemuxml2argvdata/pseries-cpu-le.args | 5 +++- tests/qemuxml2argvdata/pseries-features.args | 5 +++- .../qemuxml2argvdata/pseries-hostdevs-1.args | 5 +++- .../qemuxml2argvdata/pseries-hostdevs-2.args | 5 +++- .../qemuxml2argvdata/pseries-hostdevs-3.args | 5 +++- .../pseries-machine-max-cpu-compat.args | 5 +++- .../pseries-many-buses-1.args | 5 +++- .../pseries-many-buses-2.args | 5 +++- .../pseries-many-devices.args | 5 +++- tests/qemuxml2argvdata/pseries-nvram.args | 5 +++- .../pseries-panic-missing.args | 5 +++- .../pseries-panic-no-address.args | 5 +++- .../pseries-phb-default-missing.args | 5 +++- .../pseries-phb-numa-node.args | 5 +++- .../qemuxml2argvdata/pseries-phb-simple.args | 5 +++- .../pseries-serial-native.args | 5 +++- .../qemuxml2argvdata/pseries-serial-pci.args | 5 +++- .../qemuxml2argvdata/pseries-serial-usb.args | 5 +++- .../qemuxml2argvdata/pseries-usb-default.args | 5 +++- tests/qemuxml2argvdata/pseries-usb-kbd.args | 5 +++- tests/qemuxml2argvdata/pseries-usb-multi.args | 5 +++- .../pseries-vio-user-assigned.args | 5 +++- tests/qemuxml2argvdata/pseries-vio.args | 5 +++- .../pv-spinlock-disabled.args | 5 +++- .../qemuxml2argvdata/pv-spinlock-enabled.args | 5 +++- tests/qemuxml2argvdata/q35-acpi-nouefi.args | 5 +++- tests/qemuxml2argvdata/q35-acpi-uefi.args | 5 +++- .../q35-default-devices-only.args | 5 +++- tests/qemuxml2argvdata/q35-multifunction.args | 5 +++- tests/qemuxml2argvdata/q35-noacpi-nouefi.args | 5 +++- .../q35-pci-force-address.args | 5 +++- tests/qemuxml2argvdata/q35-pcie-autoadd.args | 5 +++- tests/qemuxml2argvdata/q35-pcie.args | 5 +++- .../q35-pm-disable-fallback.args | 5 +++- tests/qemuxml2argvdata/q35-pm-disable.args | 5 +++- tests/qemuxml2argvdata/q35-usb2-multi.args | 5 +++- tests/qemuxml2argvdata/q35-usb2-reorder.args | 5 +++- tests/qemuxml2argvdata/q35-usb2.args | 5 +++- .../q35-virt-manager-basic.args | 5 +++- tests/qemuxml2argvdata/q35-virtio-pci.args | 5 +++- tests/qemuxml2argvdata/q35.args | 5 +++- tests/qemuxml2argvdata/qemu-ns-alt.args | 5 +++- .../qemu-ns-commandline-ns0.args | 5 +++- .../qemu-ns-commandline-ns1.args | 5 +++- .../qemuxml2argvdata/qemu-ns-commandline.args | 5 +++- .../qemu-ns-domain-commandline-ns0.args | 5 +++- .../qemu-ns-domain-commandline.args | 5 +++- .../qemuxml2argvdata/qemu-ns-domain-ns0.args | 5 +++- tests/qemuxml2argvdata/qemu-ns-no-env.args | 5 +++- tests/qemuxml2argvdata/qemu-ns.args | 5 +++- .../reboot-timeout-disabled.args | 5 +++- .../reboot-timeout-enabled.args | 5 +++- tests/qemuxml2argvdata/restore-v2-fd.args | 5 +++- tests/qemuxml2argvdata/restore-v2.args | 5 +++- .../riscv64-virt-headless.riscv64-latest.args | 5 +++- tests/qemuxml2argvdata/riscv64-virt-pci.args | 5 +++- tests/qemuxml2argvdata/riscv64-virt.args | 5 +++- .../s390-allow-bogus-usb-controller.args | 5 +++- .../s390-allow-bogus-usb-none.args | 5 +++- .../qemuxml2argvdata/s390-panic-missing.args | 5 +++- .../s390-panic-no-address.args | 5 +++- tests/qemuxml2argvdata/s390-serial-2.args | 5 +++- .../qemuxml2argvdata/s390-serial-console.args | 5 +++- tests/qemuxml2argvdata/s390-serial.args | 5 +++- .../s390x-ccw-headless.s390x-latest.args | 5 +++- tests/qemuxml2argvdata/seclabel-dac-none.args | 5 +++- .../seclabel-dynamic-baselabel.args | 5 +++- .../seclabel-dynamic-labelskip.args | 5 +++- .../seclabel-dynamic-override.args | 5 +++- .../seclabel-dynamic-relabel.args | 5 +++- tests/qemuxml2argvdata/seclabel-dynamic.args | 5 +++- tests/qemuxml2argvdata/seclabel-none.args | 5 +++- .../seclabel-static-labelskip.args | 5 +++- .../seclabel-static-relabel.args | 5 +++- tests/qemuxml2argvdata/seclabel-static.args | 5 +++- .../serial-dev-chardev-iobase.args | 5 +++- .../qemuxml2argvdata/serial-dev-chardev.args | 5 +++- .../qemuxml2argvdata/serial-file-chardev.args | 5 +++- tests/qemuxml2argvdata/serial-file-log.args | 5 +++- .../qemuxml2argvdata/serial-many-chardev.args | 5 +++- .../qemuxml2argvdata/serial-pty-chardev.args | 5 +++- .../serial-spiceport-nospice.args | 5 +++- tests/qemuxml2argvdata/serial-spiceport.args | 5 +++- .../qemuxml2argvdata/serial-tcp-chardev.args | 5 +++- .../serial-tcp-telnet-chardev.args | 5 +++- .../serial-tcp-tlsx509-chardev-notls.args | 5 +++- .../serial-tcp-tlsx509-chardev-verify.args | 5 +++- .../serial-tcp-tlsx509-chardev.args | 5 +++- .../serial-tcp-tlsx509-secret-chardev.args | 5 +++- .../qemuxml2argvdata/serial-udp-chardev.args | 5 +++- .../qemuxml2argvdata/serial-unix-chardev.args | 5 +++- .../serial-unix-chardev.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/serial-vc-chardev.args | 5 +++- .../shmem-plain-doorbell.args | 5 +++- tests/qemuxml2argvdata/shmem.args | 5 +++- .../smartcard-controller.args | 5 +++- .../smartcard-host-certificates-database.args | 5 +++- .../smartcard-host-certificates.args | 5 +++- tests/qemuxml2argvdata/smartcard-host.args | 5 +++- .../smartcard-passthrough-spicevmc.args | 5 +++- .../smartcard-passthrough-tcp.args | 5 +++- ...artcard-passthrough-unix.x86_64-2.5.0.args | 5 +++- ...rtcard-passthrough-unix.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/smbios.args | 5 +++- tests/qemuxml2argvdata/smp.args | 5 +++- tests/qemuxml2argvdata/sound-device.args | 5 +++- tests/qemuxml2argvdata/sound.args | 5 +++- .../tpm-emulator-tpm2.x86_64-latest.args | 5 +++- .../tpm-emulator.x86_64-latest.args | 5 +++- .../qemuxml2argvdata/tpm-passthrough-crb.args | 5 +++- tests/qemuxml2argvdata/tpm-passthrough.args | 5 +++- .../tseg-explicit-size.x86_64-latest.args | 5 +++- .../usb-controller-default-q35.args | 5 +++- .../usb-controller-explicit-q35.args | 5 +++- .../usb-controller-qemu-xhci.args | 5 +++- .../qemuxml2argvdata/usb-controller-xhci.args | 5 +++- tests/qemuxml2argvdata/usb-controller.args | 5 +++- .../usb-hub-autoadd-deluxe.args | 5 +++- tests/qemuxml2argvdata/usb-hub-autoadd.args | 5 +++- tests/qemuxml2argvdata/usb-hub.args | 5 +++- .../qemuxml2argvdata/usb-ich9-autoassign.args | 5 +++- .../qemuxml2argvdata/usb-ich9-companion.args | 5 +++- .../qemuxml2argvdata/usb-ich9-ehci-addr.args | 5 +++- .../qemuxml2argvdata/usb-long-port-path.args | 5 +++- tests/qemuxml2argvdata/usb-none.args | 5 +++- .../usb-piix3-controller.args | 5 +++- .../qemuxml2argvdata/usb-port-autoassign.args | 5 +++- tests/qemuxml2argvdata/usb-port-missing.args | 5 +++- tests/qemuxml2argvdata/usb-ports.args | 5 +++- tests/qemuxml2argvdata/usb-redir-boot.args | 5 +++- .../usb-redir-filter-version.args | 5 +++- tests/qemuxml2argvdata/usb-redir-filter.args | 5 +++- .../usb-redir-unix.x86_64-2.5.0.args | 5 +++- .../usb-redir-unix.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/usb-redir.args | 5 +++- .../qemuxml2argvdata/usb-xhci-autoassign.args | 5 +++- tests/qemuxml2argvdata/usb1-usb2.args | 5 +++- tests/qemuxml2argvdata/user-aliases-usb.args | 5 +++- tests/qemuxml2argvdata/user-aliases.args | 5 +++- .../vcpu-placement-static.args | 5 +++- .../vhost-vsock-auto.x86_64-latest.args | 5 +++- .../vhost-vsock-ccw-auto.s390x-latest.args | 5 +++- .../vhost-vsock-ccw.s390x-latest.args | 5 +++- .../vhost-vsock.x86_64-latest.args | 5 +++- .../video-device-pciaddr-default.args | 5 +++- tests/qemuxml2argvdata/video-none-device.args | 5 +++- .../video-qxl-device-vgamem.args | 5 +++- ...video-qxl-device-vram64.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/video-qxl-device.args | 5 +++- tests/qemuxml2argvdata/video-qxl-heads.args | 5 +++- .../qemuxml2argvdata/video-qxl-nodevice.args | 5 +++- tests/qemuxml2argvdata/video-qxl-noheads.args | 5 +++- .../video-qxl-sec-device-vgamem.args | 5 +++- ...o-qxl-sec-device-vram64.x86_64-latest.args | 5 +++- .../video-qxl-sec-device.args | 5 +++- .../video-vga-device-vgamem.args | 5 +++- tests/qemuxml2argvdata/video-vga-device.args | 5 +++- .../qemuxml2argvdata/video-vga-nodevice.args | 5 +++- .../qemuxml2argvdata/video-vga-qxl-heads.args | 5 +++- .../video-virtio-gpu-ccw.args | 5 +++- .../video-virtio-gpu-device.args | 5 +++- .../video-virtio-gpu-sdl-gl.args | 5 +++- .../video-virtio-gpu-secondary.args | 5 +++- .../video-virtio-gpu-spice-gl.args | 5 +++- .../video-virtio-gpu-virgl.args | 5 +++- tests/qemuxml2argvdata/video-virtio-vga.args | 5 +++- .../virtio-input-passthrough.args | 5 +++- tests/qemuxml2argvdata/virtio-input.args | 5 +++- tests/qemuxml2argvdata/virtio-lun.args | 5 +++- .../virtio-non-transitional.x86_64-3.1.0.args | 5 +++- ...virtio-non-transitional.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/virtio-options.args | 5 +++- tests/qemuxml2argvdata/virtio-rng-ccw.args | 5 +++- .../qemuxml2argvdata/virtio-rng-default.args | 5 +++- .../virtio-rng-egd-unix.x86_64-2.5.0.args | 5 +++- .../virtio-rng-egd-unix.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/virtio-rng-egd.args | 5 +++- .../qemuxml2argvdata/virtio-rng-multiple.args | 5 +++- tests/qemuxml2argvdata/virtio-rng-random.args | 5 +++- .../virtio-transitional.x86_64-3.1.0.args | 5 +++- .../virtio-transitional.x86_64-latest.args | 5 +++- tests/qemuxml2argvdata/vmcoreinfo.args | 5 +++- tests/qemuxml2argvdata/watchdog-device.args | 5 +++- tests/qemuxml2argvdata/watchdog-diag288.args | 5 +++- tests/qemuxml2argvdata/watchdog-dump.args | 5 +++- .../qemuxml2argvdata/watchdog-injectnmi.args | 5 +++- tests/qemuxml2argvdata/watchdog.args | 5 +++- tests/qemuxml2argvdata/x86-kvm-32-on-64.args | 5 +++- .../x86_64-pc-headless.x86_64-latest.args | 5 +++- .../x86_64-q35-headless.x86_64-latest.args | 5 +++- 688 files changed, 2784 insertions(+), 684 deletions(-) -- 2.20.1

2 7

[libvirt] [PATCH 0/3] storage pool capabilities fixes
by Pavel Hrdina 07 Mar '19

07 Mar '19

Pavel Hrdina (3): tests: use virTestCompareToFile in storagepoolcapstest tests: invert the return logic in storagepoolcapstest caps: drop requiredSourceElements from storage pool capabilities docs/formatstoragecaps.html.in | 7 -- src/conf/storage_conf.c | 25 +------ .../storagepoolcapsschemadata/poolcaps-fs.xml | 67 ------------------- .../poolcaps-full.xml | 67 ------------------- tests/storagepoolcapstest.c | 17 ++--- 5 files changed, 7 insertions(+), 176 deletions(-) -- 2.20.1

2 7

[libvirt] [PATCH 0/5] util: Move some functions from virfile to virstring
by Andrea Bolognani 07 Mar '19

07 Mar '19

Andrea Bolognani (5): util: Rename virFileHasSuffix() to virStringHasCaseSuffix() util: Rename virFileStripSuffix() to virStringStripSuffix() util: Rename virFileMatchesNameSuffix() to virStringMatchesNameSuffix() util: Add virStringHasSuffix() Use virStringHasSuffix() where possible src/conf/virdomainobjlist.c | 2 +- src/conf/virnetworkobj.c | 4 +- src/conf/virnwfilterbindingobjlist.c | 2 +- src/conf/virnwfilterobj.c | 2 +- src/conf/virsecretobj.c | 4 +- src/conf/virstorageobj.c | 6 +-- src/esx/esx_driver.c | 2 +- src/esx/esx_storage_backend_vmfs.c | 4 +- src/libvirt_private.syms | 7 ++-- src/util/virfile.c | 48 ---------------------- src/util/virfile.h | 10 ----- src/util/virstoragefile.c | 2 +- src/util/virstring.c | 60 ++++++++++++++++++++++++++++ src/util/virstring.h | 10 +++++ src/vmware/vmware_conf.c | 2 +- src/vmx/vmx.c | 12 +++--- tests/testutils.c | 4 +- tests/testutilsqemu.c | 2 +- tests/virschematest.c | 4 +- tools/nss/libvirt_nss.c | 4 +- 20 files changed, 102 insertions(+), 89 deletions(-) -- 2.20.1

2 10

[libvirt] [PATCH] Drop some useless comparisons and checks
by Michal Privoznik 07 Mar '19

07 Mar '19

In these cases the check that is removed has been done a few lines above already (as can even be seen in the context). Drop them. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- examples/dommigrate/dommigrate.c | 3 +-- src/conf/nwfilter_conf.c | 4 +--- src/qemu/qemu_command.c | 3 +-- src/qemu/qemu_hotplug.c | 20 +++++++++----------- src/util/virresctrl.c | 2 +- tools/virsh-snapshot.c | 5 ++--- 6 files changed, 15 insertions(+), 22 deletions(-) diff --git a/examples/dommigrate/dommigrate.c b/examples/dommigrate/dommigrate.c index 1b6072d138..60cfb3fb83 100644 --- a/examples/dommigrate/dommigrate.c +++ b/examples/dommigrate/dommigrate.c @@ -37,51 +37,50 @@ int main(int argc, char *argv[]) { char *src_uri, *dst_uri, *domname; int ret = 0; virConnectPtr conn = NULL; virDomainPtr dom = NULL; if (argc < 4) { ret = usage(argv[0], 1); goto out; } src_uri = argv[1]; dst_uri = argv[2]; domname = argv[3]; printf("Attempting to connect to the source hypervisor...\n"); conn = virConnectOpenAuth(src_uri, virConnectAuthPtrDefault, 0); if (!conn) { ret = 1; fprintf(stderr, "No connection to the source hypervisor: %s.\n", virGetLastErrorMessage()); goto out; } printf("Attempting to retrieve domain %s...\n", domname); dom = virDomainLookupByName(conn, domname); if (!dom) { fprintf(stderr, "Failed to find domain %s.\n", domname); goto cleanup; } printf("Attempting to migrate %s to %s...\n", domname, dst_uri); if ((ret = virDomainMigrateToURI(dom, dst_uri, VIR_MIGRATE_PEER2PEER, NULL, 0)) != 0) { fprintf(stderr, "Failed to migrate domain %s.\n", domname); goto cleanup; } printf("Migration finished with success.\n"); cleanup: if (dom != NULL) virDomainFree(dom); - if (conn != NULL) - virConnectClose(conn); + virConnectClose(conn); out: return ret; } diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 7cad3ccc57..3f28c7b451 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -2610,128 +2610,126 @@ static virNWFilterDefPtr virNWFilterDefParseXML(xmlXPathContextPtr ctxt) { virNWFilterDefPtr ret; xmlNodePtr curr = ctxt->node; char *uuid = NULL; char *chain = NULL; char *chain_pri_s = NULL; virNWFilterEntryPtr entry; int chain_priority; const char *name_prefix; if (VIR_ALLOC(ret) < 0) return NULL; ret->name = virXPathString("string(./@name)", ctxt); if (!ret->name) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("filter has no name")); goto cleanup; } chain_pri_s = virXPathString("string(./@priority)", ctxt); if (chain_pri_s) { if (virStrToLong_i(chain_pri_s, NULL, 10, &chain_priority) < 0) { virReportError(VIR_ERR_INVALID_ARG, _("Could not parse chain priority '%s'"), chain_pri_s); goto cleanup; } if (chain_priority < NWFILTER_MIN_FILTER_PRIORITY || chain_priority > NWFILTER_MAX_FILTER_PRIORITY) { virReportError(VIR_ERR_INVALID_ARG, _("Priority '%d' is outside valid " "range of [%d,%d]"), chain_priority, NWFILTER_MIN_FILTER_PRIORITY, NWFILTER_MAX_FILTER_PRIORITY); goto cleanup; } } chain = virXPathString("string(./@chain)", ctxt); if (chain) { name_prefix = virNWFilterIsAllowedChain(chain); if (name_prefix == NULL) goto cleanup; ret->chainsuffix = chain; if (chain_pri_s) { ret->chainPriority = chain_priority; } else { /* assign default priority if none can be found via lookup */ - if (!name_prefix || - intMapGetByString(chain_priorities, name_prefix, 0, - &ret->chainPriority) < 0) { + if (intMapGetByString(chain_priorities, name_prefix, 0, &ret->chainPriority) < 0) { /* assign default chain priority */ ret->chainPriority = (NWFILTER_MAX_FILTER_PRIORITY + NWFILTER_MIN_FILTER_PRIORITY) / 2; } } chain = NULL; } else { if (VIR_STRDUP(ret->chainsuffix, virNWFilterChainSuffixTypeToString(VIR_NWFILTER_CHAINSUFFIX_ROOT)) < 0) goto cleanup; } uuid = virXPathString("string(./uuid)", ctxt); ret->uuid_specified = (uuid != NULL); if (uuid == NULL) { if (virUUIDGenerate(ret->uuid) < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("unable to generate uuid")); goto cleanup; } } else { if (virUUIDParse(uuid, ret->uuid) < 0) { virReportError(VIR_ERR_XML_ERROR, "%s", _("malformed uuid element")); goto cleanup; } VIR_FREE(uuid); } curr = curr->children; while (curr != NULL) { if (curr->type == XML_ELEMENT_NODE) { if (VIR_ALLOC(entry) < 0) goto cleanup; if (virXMLNodeNameEqual(curr, "rule")) { if (!(entry->rule = virNWFilterRuleParse(curr))) { virNWFilterEntryFree(entry); goto cleanup; } } else if (virXMLNodeNameEqual(curr, "filterref")) { if (!(entry->include = virNWFilterIncludeParse(curr))) { virNWFilterEntryFree(entry); goto cleanup; } } if (entry->rule || entry->include) { if (VIR_APPEND_ELEMENT_COPY(ret->filterEntries, ret->nentries, entry) < 0) { virNWFilterEntryFree(entry); goto cleanup; } } else { virNWFilterEntryFree(entry); } } curr = curr->next; } VIR_FREE(chain); VIR_FREE(chain_pri_s); return ret; cleanup: virNWFilterDefFree(ret); VIR_FREE(chain); VIR_FREE(uuid); VIR_FREE(chain_pri_s); return NULL; } diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 74f34af292..ee70444bd4 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4201,31 +4201,30 @@ static int qemuBuildNVRAMCommandLine(virCommandPtr cmd, const virDomainDef *def, virQEMUCapsPtr qemuCaps) { if (!def->nvram) return 0; if (qemuDomainIsPSeries(def)) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_NVRAM)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("nvram device is not supported by " "this QEMU binary")); return -1; } char *optstr; virCommandAddArg(cmd, "-global"); optstr = qemuBuildNVRAMDevStr(def->nvram); if (!optstr) return -1; - if (optstr) - virCommandAddArg(cmd, optstr); + virCommandAddArg(cmd, optstr); VIR_FREE(optstr); } else { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("nvram device is only supported for PPC64")); return -1; } return 0; } diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 00dbff6b2a..19b7e6e8ea 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -3502,52 +3502,50 @@ static int qemuDomainChangeNetBridge(virDomainObjPtr vm, virDomainNetDefPtr olddev, virDomainNetDefPtr newdev) { int ret = -1; const char *oldbridge = virDomainNetGetActualBridgeName(olddev); const char *newbridge = virDomainNetGetActualBridgeName(newdev); if (!oldbridge || !newbridge) { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Missing bridge name")); goto cleanup; } VIR_DEBUG("Change bridge for interface %s: %s -> %s", olddev->ifname, oldbridge, newbridge); if (virNetDevExists(newbridge) != 1) { virReportError(VIR_ERR_OPERATION_FAILED, _("bridge %s doesn't exist"), newbridge); goto cleanup; } - if (oldbridge) { - ret = virNetDevBridgeRemovePort(oldbridge, olddev->ifname); - virDomainAuditNet(vm, olddev, NULL, "detach", ret == 0); - if (ret < 0) { - /* warn but continue - possibly the old network - * had been destroyed and reconstructed, leaving the - * tap device orphaned. - */ - VIR_WARN("Unable to detach device %s from bridge %s", - olddev->ifname, oldbridge); - } + ret = virNetDevBridgeRemovePort(oldbridge, olddev->ifname); + virDomainAuditNet(vm, olddev, NULL, "detach", ret == 0); + if (ret < 0) { + /* warn but continue - possibly the old network + * had been destroyed and reconstructed, leaving the + * tap device orphaned. + */ + VIR_WARN("Unable to detach device %s from bridge %s", + olddev->ifname, oldbridge); } ret = virNetDevBridgeAddPort(newbridge, olddev->ifname); virDomainAuditNet(vm, NULL, newdev, "attach", ret == 0); if (ret < 0) { ret = virNetDevBridgeAddPort(oldbridge, olddev->ifname); virDomainAuditNet(vm, NULL, olddev, "attach", ret == 0); if (ret < 0) { virReportError(VIR_ERR_OPERATION_FAILED, _("unable to recover former state by adding port " "to bridge %s"), oldbridge); } goto cleanup; } /* caller will replace entire olddev with newdev in domain nets list */ ret = 0; cleanup: return ret; } diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c index 97891b2f8f..0857d4e882 100644 --- a/src/util/virresctrl.c +++ b/src/util/virresctrl.c @@ -2111,57 +2111,57 @@ static int virResctrlAllocMemoryBandwidth(virResctrlInfoPtr resctrl, virResctrlAllocPtr alloc, virResctrlAllocPtr free) { size_t i; virResctrlAllocMemBWPtr mem_bw_alloc = alloc->mem_bw; virResctrlAllocMemBWPtr mem_bw_free = free->mem_bw; virResctrlInfoMemBWPtr mem_bw_info = resctrl->membw_info; if (!mem_bw_alloc) return 0; - if (mem_bw_alloc && !mem_bw_info) { + if (!mem_bw_info) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("RDT Memory Bandwidth allocation unsupported")); return -1; } for (i = 0; i < mem_bw_alloc->nbandwidths; i++) { if (!mem_bw_alloc->bandwidths[i]) continue; if (*(mem_bw_alloc->bandwidths[i]) % mem_bw_info->bandwidth_granularity) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Memory Bandwidth allocation of size " "%u is not divisible by granularity %u"), *(mem_bw_alloc->bandwidths[i]), mem_bw_info->bandwidth_granularity); return -1; } if (*(mem_bw_alloc->bandwidths[i]) < mem_bw_info->min_bandwidth) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Memory Bandwidth allocation of size " "%u is smaller than the minimum " "allowed allocation %u"), *(mem_bw_alloc->bandwidths[i]), mem_bw_info->min_bandwidth); return -1; } if (i > mem_bw_info->max_id) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("bandwidth controller id %zd does not " "exist, max controller id %u"), i, mem_bw_info->max_id); return -1; } if (*(mem_bw_alloc->bandwidths[i]) > *(mem_bw_free->bandwidths[i])) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("Not enough room for allocation of %u%% " "bandwidth on node %zd, available bandwidth %u%%"), *(mem_bw_alloc->bandwidths[i]), i, *(mem_bw_free->bandwidths[i])); return -1; } } return 0; } diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c index e38ebb1f28..025321c58e 100644 --- a/tools/virsh-snapshot.c +++ b/tools/virsh-snapshot.c @@ -1046,323 +1046,322 @@ static virshSnapshotListPtr virshSnapshotListCollect(vshControl *ctl, virDomainPtr dom, virDomainSnapshotPtr from, unsigned int orig_flags, bool tree) { size_t i; char **names = NULL; int count = -1; bool descendants = false; bool roots = false; virDomainSnapshotPtr *snaps; virshSnapshotListPtr snaplist = vshMalloc(ctl, sizeof(*snaplist)); virshSnapshotListPtr ret = NULL; const char *fromname = NULL; int start_index = -1; int deleted = 0; bool filter_fallback = false; unsigned int flags = orig_flags; virshControlPtr priv = ctl->privData; /* Try the interface available in 0.9.13 and newer. */ if (!priv->useSnapshotOld) { if (from) count = virDomainSnapshotListAllChildren(from, &snaps, flags); else count = virDomainListAllSnapshots(dom, &snaps, flags); /* If we failed because of flags added in 1.0.1, we can do * fallback filtering. */ if (count < 0 && last_error->code == VIR_ERR_INVALID_ARG && flags & (VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS | VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION)) { flags &= ~(VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS | VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION); vshResetLibvirtError(); filter_fallback = true; if (from) count = virDomainSnapshotListAllChildren(from, &snaps, flags); else count = virDomainListAllSnapshots(dom, &snaps, flags); } } if (count >= 0) { /* When mixing --from and --tree, we also want a copy of from * in the list, but with no parent for that one entry. */ snaplist->snaps = vshCalloc(ctl, count + (tree && from), sizeof(*snaplist->snaps)); snaplist->nsnaps = count; for (i = 0; i < count; i++) snaplist->snaps[i].snap = snaps[i]; VIR_FREE(snaps); if (tree) { for (i = 0; i < count; i++) { if (virshGetSnapshotParent(ctl, snaplist->snaps[i].snap, &snaplist->snaps[i].parent) < 0) goto cleanup; } if (from) { snaplist->snaps[snaplist->nsnaps++].snap = from; virDomainSnapshotRef(from); } } goto success; } /* Assume that if we got this far, then the --no-leaves and * --no-metadata flags were not supported. Disable groups that * have no impact. */ /* XXX should we emulate --no-leaves? */ if (flags & VIR_DOMAIN_SNAPSHOT_LIST_NO_LEAVES && flags & VIR_DOMAIN_SNAPSHOT_LIST_LEAVES) flags &= ~(VIR_DOMAIN_SNAPSHOT_LIST_NO_LEAVES | VIR_DOMAIN_SNAPSHOT_LIST_LEAVES); if (flags & VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA && flags & VIR_DOMAIN_SNAPSHOT_LIST_METADATA) flags &= ~(VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA | VIR_DOMAIN_SNAPSHOT_LIST_METADATA); if (flags & VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA) { /* We can emulate --no-metadata if --metadata was supported, * since it was an all-or-none attribute on old servers. */ count = virDomainSnapshotNum(dom, VIR_DOMAIN_SNAPSHOT_LIST_METADATA); if (count < 0) goto cleanup; if (count > 0) return snaplist; flags &= ~VIR_DOMAIN_SNAPSHOT_LIST_NO_METADATA; } if (flags & (VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS | VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION)) { flags &= ~(VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS | VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION); filter_fallback = true; } /* This uses the interfaces available in 0.8.0-0.9.6 * (virDomainSnapshotListNames, global list only) and in * 0.9.7-0.9.12 (addition of virDomainSnapshotListChildrenNames * for child listing, and new flags), as follows, with [*] by the * combinations that need parent info (either for filtering * purposes or for the resulting tree listing): * old new * list global as-is global as-is * list --roots *global + filter global + flags * list --from *global + filter child as-is * list --from --descendants *global + filter child + flags * list --tree *global as-is *global as-is * list --tree --from *global + filter *child + flags * * Additionally, when --tree and --from are both used, from is * added to the final list as the only element without a parent. * Otherwise, --from does not appear in the final list. */ if (from) { fromname = virDomainSnapshotGetName(from); if (!fromname) { vshError(ctl, "%s", _("Could not get snapshot name")); goto cleanup; } descendants = (flags & VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS) || tree; if (tree) flags |= VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS; /* Determine if we can use the new child listing API. */ if (priv->useSnapshotOld || ((count = virDomainSnapshotNumChildren(from, flags)) < 0 && last_error->code == VIR_ERR_NO_SUPPORT)) { /* We can emulate --from. */ /* XXX can we also emulate --leaves? */ vshResetLibvirtError(); priv->useSnapshotOld = true; flags &= ~VIR_DOMAIN_SNAPSHOT_LIST_DESCENDANTS; goto global; } if (tree && count >= 0) count++; } else { global: /* Global listing (including fallback when --from failed with * child listing). */ count = virDomainSnapshotNum(dom, flags); /* Fall back to simulation if --roots was unsupported. */ /* XXX can we also emulate --leaves? */ if (!from && count < 0 && last_error->code == VIR_ERR_INVALID_ARG && (flags & VIR_DOMAIN_SNAPSHOT_LIST_ROOTS)) { vshResetLibvirtError(); roots = true; flags &= ~VIR_DOMAIN_SNAPSHOT_LIST_ROOTS; count = virDomainSnapshotNum(dom, flags); } } if (count < 0) { if (!last_error) vshError(ctl, _("failed to collect snapshot list")); goto cleanup; } if (!count) goto success; names = vshCalloc(ctl, sizeof(*names), count); /* Now that we have a count, collect the list. */ if (from && !priv->useSnapshotOld) { if (tree) { - if (count) - count = virDomainSnapshotListChildrenNames(from, names + 1, - count - 1, flags); + count = virDomainSnapshotListChildrenNames(from, names + 1, + count - 1, flags); if (count >= 0) { count++; names[0] = vshStrdup(ctl, fromname); } } else { count = virDomainSnapshotListChildrenNames(from, names, count, flags); } } else { count = virDomainSnapshotListNames(dom, names, count, flags); } if (count < 0) goto cleanup; snaplist->snaps = vshCalloc(ctl, sizeof(*snaplist->snaps), count); snaplist->nsnaps = count; for (i = 0; i < count; i++) { snaplist->snaps[i].snap = virDomainSnapshotLookupByName(dom, names[i], 0); if (!snaplist->snaps[i].snap) goto cleanup; } /* Collect parents when needed. With the new API, --tree and * --from together put from as the first element without a parent; * with the old API we still need to do a post-process filtering * based on all parent information. */ if (tree || (from && priv->useSnapshotOld) || roots) { for (i = (from && !priv->useSnapshotOld); i < count; i++) { if (from && priv->useSnapshotOld && STREQ(names[i], fromname)) { start_index = i; if (tree) continue; } if (virshGetSnapshotParent(ctl, snaplist->snaps[i].snap, &snaplist->snaps[i].parent) < 0) goto cleanup; if ((from && ((tree && !snaplist->snaps[i].parent) || (!descendants && STRNEQ_NULLABLE(fromname, snaplist->snaps[i].parent)))) || (roots && snaplist->snaps[i].parent)) { virshDomainSnapshotFree(snaplist->snaps[i].snap); snaplist->snaps[i].snap = NULL; VIR_FREE(snaplist->snaps[i].parent); deleted++; } } } if (tree) goto success; if (priv->useSnapshotOld && descendants) { bool changed = false; bool remaining = false; /* Make multiple passes over the list - first pass finds * direct children and NULLs out all roots and from, remaining * passes NULL out any undecided entry whose parent is not * still in list. We mark known descendants by clearing * snaps[i].parents. Sorry, this is O(n^3) - hope your * hierarchy isn't huge. XXX Is it worth making O(n^2 log n) * by using qsort and bsearch? */ if (start_index < 0) { vshError(ctl, _("snapshot %s disappeared from list"), fromname); goto cleanup; } for (i = 0; i < count; i++) { if (i == start_index || !snaplist->snaps[i].parent) { VIR_FREE(names[i]); virshDomainSnapshotFree(snaplist->snaps[i].snap); snaplist->snaps[i].snap = NULL; VIR_FREE(snaplist->snaps[i].parent); deleted++; } else if (STREQ(snaplist->snaps[i].parent, fromname)) { VIR_FREE(snaplist->snaps[i].parent); changed = true; } else { remaining = true; } } if (!changed) { ret = vshMalloc(ctl, sizeof(*snaplist)); goto cleanup; } while (changed && remaining) { changed = remaining = false; for (i = 0; i < count; i++) { bool found_parent = false; size_t j; if (!names[i] || !snaplist->snaps[i].parent) continue; for (j = 0; j < count; j++) { if (!names[j] || i == j) continue; if (STREQ(snaplist->snaps[i].parent, names[j])) { found_parent = true; if (!snaplist->snaps[j].parent) VIR_FREE(snaplist->snaps[i].parent); else remaining = true; break; } } if (!found_parent) { changed = true; VIR_FREE(names[i]); virshDomainSnapshotFree(snaplist->snaps[i].snap); snaplist->snaps[i].snap = NULL; VIR_FREE(snaplist->snaps[i].parent); deleted++; } } } } success: if (filter_fallback) { /* Older API didn't filter on status or location, but the * information is available in domain XML. */ if (!(orig_flags & VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS)) orig_flags |= VIR_DOMAIN_SNAPSHOT_FILTERS_STATUS; if (!(orig_flags & VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION)) orig_flags |= VIR_DOMAIN_SNAPSHOT_FILTERS_LOCATION; for (i = 0; i < snaplist->nsnaps; i++) { switch (virshSnapshotFilter(ctl, snaplist->snaps[i].snap, orig_flags)) { case 1: break; case 0: virshDomainSnapshotFree(snaplist->snaps[i].snap); snaplist->snaps[i].snap = NULL; VIR_FREE(snaplist->snaps[i].parent); deleted++; break; default: goto cleanup; } } } qsort(snaplist->snaps, snaplist->nsnaps, sizeof(*snaplist->snaps), virshSnapSorter); snaplist->nsnaps -= deleted; VIR_STEAL_PTR(ret, snaplist); cleanup: virshSnapshotListFree(snaplist); if (names && count > 0) for (i = 0; i < count; i++) VIR_FREE(names[i]); VIR_FREE(names); return ret; } -- 2.19.2

2 1

[libvirt] [PATCH 00/10] domcaps: use virTristateBool
by Cole Robinson 06 Mar '19

06 Mar '19

Extending domaincapabilities with new XML schema is currently a bit of a maintenance pain. Consider the case of adding a new enum for listing <sound> models. I want to output this info for the qemu driver. Internally in the domaincapabilities plumbing, whether a <device> is supported= is tracked with boolean true/false. If I extend that pattern for <sound> devices and fill in data for the qemu driver, the other domcaps implementations will now automatically output a new XML element: <sound supported='no'> Now, for bhyve I can 'git grep' confirm that it doesn't have any <sound> support, but for xen/libxl it _is_ supported. So if I don't fill in accurate support in the xen driver, I've just made their domcaps report blatantly incorrect info. Ideally I would make these <sound> changes and the other drivers output would _not_ change. xen output would now be incomplete, but not obviously wrong, which is easier on me the developer, and safer for the API consumer. This moves domcaps plumbing in that direction. It switches most internal 'supported' fields to virTristateBool so we can track an ABSENT state and map that to outputting no XML. Explicit supported='no' values are filled in where needed to ensure existing driver XML doesn't change. cpu and sev supported= values are left unconverted, but they require semi-special handling anyways so aren't really affected by the problem I laid out above. Cole Robinson (10): tests: domcaps: Add a default 'empty' test tests: domcaps: Remove unused typedef tests: domcaps: Remove 'full' test conf: domcaps: Add single line formatting macro conf: domcaps: use virTristateBool for 'supported' qemu: domcaps: fill in explicit supported BOOL_NO libxl: domcaps: fill in explicit supported BOOL_NO bhyve: domcaps: fill in explicit supported BOOL_NO schemas: domcaps: Make more elements optional conf: domcaps: Don't output XML on tristate ABSENT docs/schemas/domaincaps.rng | 20 +++++-- src/bhyve/bhyve_capabilities.c | 20 +++++-- src/conf/domain_capabilities.c | 26 ++++++---- src/conf/domain_capabilities.h | 20 +++---- src/libxl/libxl_capabilities.c | 18 ++++--- src/qemu/qemu_capabilities.c | 26 ++++++---- tests/domaincapsschemadata/empty.xml | 16 ++++++ tests/domaincapstest.c | 78 ++-------------------------- 8 files changed, 103 insertions(+), 121 deletions(-) create mode 100644 tests/domaincapsschemadata/empty.xml -- 2.20.1

2 12

[libvirt] [PATCH v2 00/17] Add support to list Storage Driver backend capabilities
by John Ferlan 06 Mar '19

06 Mar '19

v1: https://www.redhat.com/archives/libvir-list/2019-January/msg00479.html Changes since v1: * The first 4 patches were already R-by'd and pushed. * From v1, rework patch 5 & 6 into what now is patches 8 & 9. The format of the output for what results in the output for the connectGetCapabilities (virConnectGetCapabilities). * From v1, drop patch 7 * In v2, patches 1-7 are new as a result of work done for patches 10-17. patches 1-5 were posted upstream, but left unreviewed: https://www.redhat.com/archives/libvir-list/2019-February/msg00333.html These essentially ensure the volOptions and poolOptions don't list or use something unexpected per documentation. The doc patch is a simple update to add some missing text and fix an entry * Patches 10-17 are new to implement the ability to get/format the Storage Driver backend capabilities via: storageConnectGetStoragePoolCapabilities virConnectGetStoragePoolCapabilities similar to how virConnectGetDomainCapabilities returns domain specific output. The output is essentially what is provided in the poolOptions and volOptions from storage_conf as valid values for format type fields for pool and/or volume as well as an enumerated list for the required source elements for creation. Whether the latter is useful or not was not clear, but since it is something that can cause a creation error when missing, I figured it'd be useful. The new virsh command follows then domcapabilities nomenclature. John Ferlan (17): conf: Remove volOptions for VIR_STORAGE_POOL_SHEEPDOG conf: Remove volOptions for VIR_STORAGE_POOL_RBD conf: Remove volOptions for VIR_STORAGE_POOL_SCSI conf: Remove volOptions for VIR_STORAGE_POOL_ISCSI[_DIRECT] conf: Remove volOptions for VIR_STORAGE_POOL_MPATH conf: Remove defaultFormat from VIR_STORAGE_POOL_ZFS docs: Fix a few storage.html.in typos conf: Introduce storage pool functions into capabilities storage: Process storage pool capabilities docs: Add schema for storage pool capabilities conf: Add storage pool capability formatting tests: Introduce storage pool capabilites test docs: Add description for Storage Pool Capabilities libvirt: Introduce virConnectGetStoragePoolCapabilities storage: Introduce storageConnectGetStoragePoolCapabilities virsh: Expose virConnectGetStoragePoolCapabilities docs: Add news article docs/docs.html.in | 1 + docs/format.html.in | 1 + docs/formatstoragecaps.html.in | 108 +++++++ docs/index.html.in | 1 + docs/news.xml | 12 + docs/schemas/storagepoolcaps.rng | 88 ++++++ docs/storage.html.in | 8 +- include/libvirt/libvirt-storage.h | 4 + libvirt.spec.in | 1 + mingw-libvirt.spec.in | 2 + src/conf/Makefile.inc.am | 2 + src/conf/capabilities.c | 74 +++++ src/conf/capabilities.h | 15 + src/conf/storage_capabilities.c | 135 +++++++++ src/conf/storage_capabilities.h | 41 +++ src/conf/storage_conf.c | 131 +++++++-- src/conf/storage_conf.h | 7 + src/conf/virstorageobj.h | 5 + src/driver-storage.h | 5 + src/libvirt-storage.c | 40 +++ src/libvirt_private.syms | 8 + src/libvirt_public.syms | 5 + src/remote/remote_driver.c | 1 + src/remote/remote_protocol.x | 15 +- src/remote_protocol-structs | 7 + src/storage/storage_backend.c | 16 ++ src/storage/storage_backend.h | 3 + src/storage/storage_driver.c | 44 +++ tests/Makefile.am | 7 + .../storagepoolcapsschemadata/poolcaps-fs.xml | 268 ++++++++++++++++++ .../poolcaps-full.xml | 268 ++++++++++++++++++ tests/storagepoolcapstest.c | 124 ++++++++ tests/storagevolxml2xmlout/vol-sheepdog.xml | 1 - tests/virschematest.c | 1 + tools/virsh-pool.c | 42 +++ tools/virsh.pod | 7 + 36 files changed, 1473 insertions(+), 25 deletions(-) create mode 100644 docs/formatstoragecaps.html.in create mode 100644 docs/schemas/storagepoolcaps.rng create mode 100644 src/conf/storage_capabilities.c create mode 100644 src/conf/storage_capabilities.h create mode 100644 tests/storagepoolcapsschemadata/poolcaps-fs.xml create mode 100644 tests/storagepoolcapsschemadata/poolcaps-full.xml create mode 100644 tests/storagepoolcapstest.c -- 2.20.1

3 24

[libvirt] lxc container stopped not each time
by mxs kolo 06 Mar '19

06 Mar '19

Hi all. I download ftp://libvirt.org/libvirt/libvirt-5.1.0.tar.xz and build rpms with lxc support. LXC containers can be started, but time to time can't be stopped. With option --mode initctl containers always stopped, but virsh reported error: "Container does not provide an initctl pipe" Inside container present /dev/initctl: # ls -la /dev/initctl lrwxrwxrwx 1 root root 25 Mar 5 18:40 /dev/initctl -> /run/systemd/initctl/fifo With option --mode signal, centos 7.5/7.6 systemd not stopped and rebooted, in containers log: systemd: Received SIGTERM. systemd: Reexecuting. systemd: systemd 219 running in system mode. (+PAM +AUDIT +SELINUX +IMA -APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 -SECCOMP +BLKID +ELFUTILS +KMOD +IDN) systemd: Detected virtualization lxc-libvirt. systemd: Detected architecture x86-64. Runlevel inside container before and after - is 5. Without option --mode container can stop, mostly when you in gdb step-by-step debug. But most often not, with simptoms as with --mode signal. Patch in attachment fix problem for my environment. Tested only with host centos 7.6 and guests centos 7.5/7.6 Short comments on patch. lxcDomainShutdownFlags() return rc 0 and container begin stopped. We not go to endjob label, but later we pass check: if (rc == 0 && (flags == 0 || (flags & VIR_DOMAIN_SHUTDOWN_SIGNAL))) { and trying next shutdown method with sigterm to pid1. If container heavy loaded (or waiting in gdb for input), it not stopped. But if container small, first method with initctl stop container before second method would be call b.r. Maxim Kozin

2 1

[libvirt] [PATCH 00/23] conf: domain: Buffer and XPath handling refactors
by Peter Krempa 06 Mar '19

06 Mar '19

Peter Krempa (23): util: xml: Enforce return value check from virXMLFormatElement conf: Use virXMLFormatElement in virDomainControllerDriverFormat conf: Use virXMLFormatElement in virDomainControllerDefFormat conf: Refactor virDomainMemballoonDefFormat conf: Refactor virDomainWatchdogDefFormat conf: Refactor virDomainPanicDefFormat conf: Refactor formatting of 'driver' in virDomainRNGDefFormat conf: Refactor virDomainInputDefFormat conf: Refactor virDomainHubDefFormat conf: Split out formatting of 'blkiotune' from virDomainDefFormatInternal conf: Split out domain features formatting from virDomainDefFormatInternal conf: Refactor control flow in virDomainDefFormatFeatures conf: Rename temp buffers in virDomainDefFormatFeatures conf: Remove impossible error in virDomainDefFormatFeatures conf: Simplify lifecycle of temp buffers in virDomainDefFormatFeatures conf: Avoid extra set of temp buffers in virDomainDefFormatFeatures conf: Avoid extra scope when formatting 'smm' feature conf: Avoid formatting empty <capabilities> element conf: Refactor formating of 'capabilities' features conf: Use virXMLFormatElement in virDomainDefFormatFeatures conf: domain: Use VIR_AUTOCLEAN(virBuffer) where appropriate conf: Move XPath context node in descendants of virSysinfoParseXML conf: domain: Use VIR_XPATH_NODE_AUTORESTORE where appropriate src/conf/domain_conf.c | 1184 +++++++---------- src/util/virxml.h | 3 +- .../lxcconf2xmldata/lxcconf2xml-blkiotune.xml | 3 +- .../lxcconf2xml-cpusettune.xml | 3 +- tests/lxcconf2xmldata/lxcconf2xml-cputune.xml | 3 +- tests/lxcconf2xmldata/lxcconf2xml-idmap.xml | 3 +- .../lxcconf2xml-macvlannetwork.xml | 3 +- tests/lxcconf2xmldata/lxcconf2xml-memtune.xml | 3 +- .../lxcconf2xml-miscnetwork.xml | 3 +- .../lxcconf2xml-nonenetwork.xml | 3 +- .../lxcconf2xmldata/lxcconf2xml-nonetwork.xml | 3 +- .../lxcconf2xml-physnetwork.xml | 3 +- .../lxcconf2xml-vlannetwork.xml | 3 +- 13 files changed, 485 insertions(+), 735 deletions(-) -- 2.20.1

2 46