- Devel - libvirt List Archives

[libvirt] [PATCH v3 0/5] tools: console: fixes and improvments
by Nikolay Shirokovskiy 05 Apr '19

05 Apr '19

Diff from v2[1] - split first patch further into 2 [1] https://www.redhat.com/archives/libvir-list/2019-March/msg00812.html Nikolay Shirokovskiy (5): tools: console: make console virLockableObject tools: console: cleanup console on errors in main thread tools: console: add missing locks in callbacks tools: console: check if console was shutdown in callbacks tools: console: pass stream/fd errors to user tools/virsh-console.c | 224 ++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 171 insertions(+), 53 deletions(-) -- 1.8.3.1

2 13

[libvirt] [PATCH v2 00/29] conf: refactor virStorageSource parsing and formatting (blockdev-add saga)
by Peter Krempa 05 Apr '19

05 Apr '19

Most patches were changed too substantially to warrant keeping the Rb's. Peter Krempa (29): conf: Format seclabels for <backingStore> conf: Remove @seclabels from virDomainStorageSourceFormat conf: Merge virDomainDiskSourceFormatInternal into virDomainDiskSourceFormat conf: Export virDomainDiskSourceFormat tests: qemuxml2xml: Use virdeterministichashmock.so tests: qemustatusxml2xml: Add another disk to migration-out-nbd-tls case tests: qemustatusxml2xml: Add separate output for migration-out-nbd-tls qemu: domain: Modify <migrationSource> to look like <disk> conf: Unexport virDomainStorageSourceFormat conf: Simplify control flow in virDomainDiskSourceFormat conf: Avoid temporary variable in virDomainDiskBackingStoreFormat conf: Use virXMLFormatElement in virDomainDiskBackingStoreFormat conf: Merge virDomainStorageSourceFormat into virDomainDiskSourceFormat conf: Document virDomainDiskSourceFormat conf: Replace virDomainDiskSourceParse by virDomainStorageSourceParse conf: introduce virDomainStorageSourceParseBase conf: Use virDomainStorageSourceParseBase in virDomainDiskBackingStoreParse conf: Document virDomainStorageSourceParse conf: Modify arguments passed to virDomainDiskBackingStoreFormat conf: Allow convenient lookup of <source> in virDomainStorageSourceParse qemu: Use VIR_AUTOFREE in qemuDomainObjPrivateXMLParseJobNBDSource qemu: Remove cleanup in qemuDomainObjPrivateXMLParseJobNBDSource qemu: Use virDomainStorageSourceParseBase in qemuDomainObjPrivateXMLParseJobNBDSource qemu: Parse NBD storage source private data by virDomainStorageSourceParse conf: use virXMLFormatElement in virDomainDiskDefFormatMirror conf: Pass 'flags' to virDomainDiskSourceFormat in virDomainDiskDefFormatMirror conf: Refactor virDomainDiskDefMirrorParse conf: Parse and format 'backingStore' for disk <mirror> conf: Add 'index' attribute for <disk><mirror><source> docs/schemas/domaincommon.rng | 1 + src/conf/domain_conf.c | 345 ++++++------- src/conf/domain_conf.h | 19 +- src/conf/snapshot_conf.c | 4 +- src/libvirt_private.syms | 3 +- src/qemu/qemu_domain.c | 82 +-- tests/qemublocktest.c | 4 +- .../blockjob-mirror-in.xml | 13 + .../migration-out-nbd-tls-in.xml | 27 +- .../migration-out-nbd-tls-out.xml | 488 +++++++++++++++++- .../qemuxml2argvdata/disk-backing-chains.xml | 6 +- tests/qemuxml2argvdata/disk-mirror.xml | 8 +- .../disk-backing-chains-active.xml | 6 +- .../disk-backing-chains-inactive.xml | 6 +- .../qemuxml2xmloutdata/disk-mirror-active.xml | 8 +- tests/qemuxml2xmltest.c | 3 +- tests/virstoragetest.c | 2 +- 17 files changed, 769 insertions(+), 256 deletions(-) mode change 120000 => 100644 tests/qemustatusxml2xmldata/migration-out-nbd-tls-out.xml -- 2.20.1

3 63

[libvirt] [PATCH 0/6] Some '#pragma once' conversions
by Cole Robinson 04 Apr '19

04 Apr '19

danpb added a BiteSizedTask for '#pragma once' conversions https://wiki.libvirt.org/page/BiteSizedTasks#Switch_headers_to_use_.23pragm… We don't currently have any usage in the code. Turns out we need some syntax check tweaks to make things happy. This series fixes those, and adds a few conversion examples. Tested on Fedora30 and freebsd12.0 with nodedev hal driver build Cole Robinson (6): build-aux: header-ifdef: Fix typos build-aux: header-ifdef: Handle #pragma once node_device_driver.h: Use #pragma once node_device_udev.h: Use #pragma once node_device_hal.h: Use #pragma once vircgrouppriv.h: Use #pragma once build-aux/header-ifdef.pl | 11 ++++++++--- src/node_device/node_device_driver.h | 21 +++++++++------------ src/node_device/node_device_hal.h | 5 +---- src/node_device/node_device_udev.h | 13 +++++-------- src/util/vircgrouppriv.h | 9 +++------ 5 files changed, 26 insertions(+), 33 deletions(-) -- 2.21.0

2 7

[libvirt] [PATCH v2] tests: Avoid writing into $HOME during virsh-snapshot
by Eric Blake 04 Apr '19

04 Apr '19

In a constrained CI environment, where it is intentional that attempts to write outside the current directory will fail, virsh-snapshot was failing: @@ -1,2 +1,3 @@ error: invalid argument: parent s3 for snapshot s2 not found error: marker +error: Failed to create '/home/travis/.cache/libvirt/virsh': Permission denied FAIL virsh-snapshot (exit status: 1) But we've already solved the problem in virsh-uriprecedence: tell virsh to use XDG locations pointing to somewhere we can write rather than its default of falling back to $HOME with the test being at risk of breaking due to the user's environment and/or unacceptably altering the user's normal cache. Hoist that solution into test-lib.sh, so that all scripts can use it as needed. While at it, fix a latent typo where XDG_RUNTIME_HOME was set to a literal relative directory name "XDG_CACHE_HOME" (the typo did not affect virsh-uriprecedence, but could matter to other clients). Fixes: 280a2b41 Fixes: 398de147 Reported-by: Daniel P. Berrangé <berrange(a)redhat.com> Signed-off-by: Eric Blake <eblake(a)redhat.com> --- in v2: - fix typo in XDG_RUNTIME_HOME [Andrea] - fix 'make distcheck' by using actual per-test tempdir (tests/lv-TEST.XXX/) rather than tests/ as the XDG root [Andrea] tests/test-lib.sh | 13 +++++++++++++ tests/virsh-snapshot | 2 ++ tests/virsh-uriprecedence | 12 +----------- 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/tests/test-lib.sh b/tests/test-lib.sh index 49e8d22095..ef5a47b565 100644 --- a/tests/test-lib.sh +++ b/tests/test-lib.sh @@ -222,6 +222,19 @@ mkfifo_or_skip_() fi } +# Create mock XDG files/directories to avoid permission problems. +# As it points inside $test_dir_, it is automatically cleaned. +mock_xdg_() +{ + export XDG_CONFIG_HOME="$t_/.config" + export XDG_CACHE_HOME="$t_/.cache" + export XDG_RUNTIME_HOME="$XDG_CACHE_HOME" + + mkdir -p "$XDG_CONFIG_HOME/libvirt" "$XDG_CONFIG_HOME/virsh" + mkdir -p "$XDG_CACHE_HOME/libvirt" "$XDG_CACHE_HOME/virsh" + mkdir -p "$XDG_RUNTIME_HOME/libvirt" "$XDG_RUNTIME_HOME/virsh" +} + test_dir_=$(pwd) this_test_() { echo "./$0" | sed 's,.*/,,'; } diff --git a/tests/virsh-snapshot b/tests/virsh-snapshot index fb8a99dd43..cb498cf54e 100755 --- a/tests/virsh-snapshot +++ b/tests/virsh-snapshot @@ -26,6 +26,8 @@ fi fail=0 +mock_xdg_ || framework_failure + # The test driver loses states between restarts, so we perform a script # with some convenient markers for later post-processing of output. $abs_top_builddir/tools/virsh --connect test:///default >out 2>err ' diff --git a/tests/virsh-uriprecedence b/tests/virsh-uriprecedence index 564e3dc42c..fd6ce108c0 100755 --- a/tests/virsh-uriprecedence +++ b/tests/virsh-uriprecedence @@ -11,17 +11,7 @@ virsh_cmd="$virsh_bin" counter=0 ret=0 -cleanup_() { rm -rf "$tmphome"; } - -# Create all mock files/directories to avoid permission problems -tmphome="$PWD/tmp_home" -export XDG_CONFIG_HOME="$tmphome/.config" -export XDG_CACHE_HOME="$tmphome/.cache" -export XDG_RUNTIME_HOME="XDG_CACHE_HOME" - -mkdir -p "$XDG_CONFIG_HOME/libvirt" "$XDG_CONFIG_HOME/virsh" -mkdir -p "$XDG_CACHE_HOME/libvirt" "$XDG_CACHE_HOME/virsh" -mkdir -p "$XDG_RUNTIME_HOME/libvirt" "$XDG_RUNTIME_HOME/virsh" +mock_xdg_ || framework_failure is_uri_good() { -- 2.20.1

2 1

[libvirt] [PATCH] network: drop back compat code loading actual bridge name
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

The actual network def was updated to save the bridge name back in 1.2.11: commit a3609121799d44898a3e0d0bf92b755e55e7b418 Author: Laine Stump <laine(a)laine.org> Date: Fri Nov 21 12:20:37 2014 -0500 network: save bridge name in ActualNetDef when actualType==network too The chance that someone is running libvirt < 1.2.11 and wants todo a live upgrade to 5.3.0 without a host reboot is essentially zero. We can thus reasonably drop the back compat code now. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- src/network/bridge_driver.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 6f88adf3b7..0c65c48b1a 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4812,17 +4812,6 @@ networkNotifyActualDevice(virNetworkPtr net, goto error; } - /* if we're restarting libvirtd after an upgrade from a version - * that didn't save bridge name in actualNetDef for - * actualType==network, we need to copy it in so that it will be - * available in all cases - */ - if (actualType == VIR_DOMAIN_NET_TYPE_NETWORK && - !iface->data.network.actual->data.bridge.brname && - (VIR_STRDUP(iface->data.network.actual->data.bridge.brname, - netdef->bridge) < 0)) - goto error; - /* see if we're connected to the correct bridge */ if (netdef->bridge) { bool useOVS = false; -- 2.20.1

2 1

[libvirt] Reproducible VM start bug which affects libvirt 5.1.0 and 5.2.0
by Frank Schreuder 04 Apr '19

04 Apr '19

Hello, I am currently running into a reproducible libvirt bug which affects libvirt 5.1.0 and 5.2.0. There seem to be a racecondition in the nwfilter-define and virsh start commands. Several times a day I'm not able to start a VM anymore with the following error message: error: Failed to start domain test error: internal error: Failed to apply firewall rules /sbin/iptables -w -I FORWARD 1 -j libvirt-in: iptables v1.6.0: Couldn't load target `libvirt-in':No such file or directory To fix this issue I have to restart libvirt. Some iptable chains are missing, which is probably caused by a nwfilter-define operation. I'm able to reproduce this bug within 2 hours by running 2 loops. One loop is defining nwfilters and the second loop is destroying and starting multiple VMs. I found an entry in the changelog of libvirt 5.1.0, which seems related to this bug: Create private chains for virtual network firewall rules Historically firewall rules for virtual networks were added straight into the base chains. This works but has a number of bugs and design limitations. To address them, libvirt now puts firewall rules into its own chains. Note that with this change the filter, nat and mangle tables are required for both IPv4 and IPv6. So far I am not able to reproduce this bug on libvirt 5.0.0. Is there any information I can provide to the mailinglist to help debug and/or fix this bug? I am also willing to test patches. With kind regards, Frank Schreuder

2 3

[libvirt] [PATCH v3 00/36] network: refactor to decouple virt drivers from network driver
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

An update to v1: https://www.redhat.com/archives/libvir-list/2018-December/msg00681.html v2: https://www.redhat.com/archives/libvir-list/2019-February/msg01581.html Currently the network driver registers a set of callbacks with the virt driver in order to handle allocating/releasing network ports associated with guest NICs. This series introduces a virNetworkPortPtr object and associated XML that describes a network port. The virt drivers now call public APIs associated with this new object to create/delete ports for guest NICs. Changed in v3: - Remove unused API symbol - Fix dist of test data files Changed in v2: - Fix many bugs related to upgrades with running VMs - Convert over bandwidth controls to the new APIs - Handle reconnecting VIFs to bridges during startup - Much much more that I can't remember Daniel P. Berrangé (36): network: restrict usage of port management APIs network: pass a virNetworkPtr to port management APIs conf: simplify link from hostdev back to network device network: add missing bandwidth limits for bridge forward type network: use 'bridge' as actual type instead of 'network' util: add helper method for re-attaching a tap device to a bridge network: use virNetDevTapReattachBridge API virt drivers: don't handle type=network after resolving actual network type network: move re-attach of bridge device out of network driver network: move fixup for domain actual net def out of network driver network: unconditionally merge port profiles conf: don't pass interface type into virNetDevBandwidthParse conf: introduce virNetworkPortDefPtr struct and XML support network: stop passing virDomainNetDefPtr into bandwidth functions network: make networkLogAllocation independent of domain conf util: add API for copying virtual port profile data conf: add APIs to convert virDomainNetDef to virNetworkPortDef network: convert networkAllocateActualDevice to virNetworkPortDef network: convert networkNotifyActualDevice to virNetworkPortDef network: convert networkReleaseActualDevice to virNetworkPortDef network: convert hook script to take a network port XML network: remove the virDomainNetBandwidthChangeAllowed callback network: introduce networkAllocatePort network: introduce networkNotifyPort network: introduce networkReleasePort network: introduce networkUpdatePortBandwidth network: add public APIs for network port object access: add permissions for network port objects remote: add support for new network port APIs virsh: add support for network port APIs conf: support recording ports against virNetworkObjPtr network: add implementation of network port APIs lxc, libxl: notify network driver of NICs during reconnect lxc, libxl: save domain status after reconnect conf: record a portid against the domain conf conf: switch over to use network port APIs for virt drivers docs/formatdomain.html.in | 8 + docs/hooks.html.in | 24 +- docs/schemas/domaincommon.rng | 5 + include/libvirt/libvirt-network.h | 122 ++ include/libvirt/virterror.h | 3 + src/access/genpolkit.pl | 2 +- src/access/viraccessdriver.h | 6 + src/access/viraccessdrivernop.c | 11 + src/access/viraccessdriverpolkit.c | 26 + src/access/viraccessdriverstack.c | 25 + src/access/viraccessmanager.c | 16 + src/access/viraccessmanager.h | 6 + src/access/viraccessperm.c | 6 + src/access/viraccessperm.h | 44 + src/conf/Makefile.inc.am | 2 + src/conf/domain_conf.c | 557 ++++++- src/conf/domain_conf.h | 63 +- src/conf/netdev_bandwidth_conf.c | 22 +- src/conf/netdev_bandwidth_conf.h | 2 +- src/conf/network_conf.c | 4 +- src/conf/virnetworkobj.c | 303 ++++ src/conf/virnetworkobj.h | 34 + src/conf/virnetworkportdef.c | 514 +++++++ src/conf/virnetworkportdef.h | 112 ++ src/datatypes.c | 60 + src/datatypes.h | 41 + src/driver-network.h | 41 + src/libvirt-network.c | 444 ++++++ src/libvirt_private.syms | 25 +- src/libvirt_public.syms | 12 + src/libxl/libxl_conf.c | 21 +- src/libxl/libxl_domain.c | 28 +- src/libxl/libxl_driver.c | 60 +- src/lxc/lxc_driver.c | 37 +- src/lxc/lxc_process.c | 56 +- src/network/bridge_driver.c | 1364 +++++++++-------- src/qemu/qemu_command.c | 11 +- src/qemu/qemu_domain_address.c | 4 +- src/qemu/qemu_driver.c | 10 +- src/qemu/qemu_hotplug.c | 84 +- src/qemu/qemu_hotplug.h | 2 +- src/qemu/qemu_interface.c | 12 +- src/qemu/qemu_process.c | 32 +- src/remote/remote_daemon_dispatch.c | 73 + src/remote/remote_driver.c | 69 + src/remote/remote_protocol.x | 124 +- src/remote_protocol-structs | 69 + src/rpc/gendispatch.pl | 18 +- src/util/virerror.c | 9 + src/util/virhook.c | 4 +- src/util/virhook.h | 4 +- src/util/virhostdev.c | 17 +- src/util/virnetdevtap.c | 69 + src/util/virnetdevtap.h | 12 + src/util/virnetdevvportprofile.c | 16 + src/util/virnetdevvportprofile.h | 2 + tests/Makefile.am | 7 + .../net-virtio-network-portgroup.xml | 6 +- tests/virnetdevbandwidthtest.c | 2 +- .../plug-bridge-mactbl.xml | 9 + .../virnetworkportxml2xmldata/plug-bridge.xml | 12 + .../virnetworkportxml2xmldata/plug-direct.xml | 12 + .../plug-hostdev-pci.xml | 12 + tests/virnetworkportxml2xmldata/plug-none.xml | 8 + tests/virnetworkportxml2xmltest.c | 104 ++ tools/virsh-completer.c | 50 + tools/virsh-completer.h | 4 + tools/virsh-network.c | 399 ++++- tools/virsh-network.h | 5 + 69 files changed, 4526 insertions(+), 851 deletions(-) create mode 100644 src/conf/virnetworkportdef.c create mode 100644 src/conf/virnetworkportdef.h create mode 100644 tests/virnetworkportxml2xmldata/plug-bridge-mactbl.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-bridge.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-direct.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-hostdev-pci.xml create mode 100644 tests/virnetworkportxml2xmldata/plug-none.xml create mode 100644 tests/virnetworkportxml2xmltest.c -- 2.20.1

4 94

[libvirt] [PATCH] docs: stop advertizing FTP or HTTP for downloads of libvirt
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

On the modern internet it is not credible to continue to advertize software downloads over unencrypted connections. Even if users could theoretically use GPG to verify the signatures, not all our downloads and signed and few people know how to correctly verify signatures. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/downloads.html.in | 61 ++++++++++++++---------------------------- 1 file changed, 20 insertions(+), 41 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 657cd6a6f8..0722469eb9 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -27,8 +27,7 @@ <tr> <td>libvirt</td> <td> - <a href="ftp://libvirt.org/libvirt/">ftp</a> - <a href="https://libvirt.org/sources/">https</a> + <a href="https://libvirt.org/sources/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt.git;a=summary">libvirt</a> @@ -48,8 +47,7 @@ <tr> <td>C#</td> <td> - <a href="ftp://libvirt.org/libvirt/csharp/">ftp</a> - <a href="https://libvirt.org/sources/csharp/">https</a> + <a href="https://libvirt.org/sources/csharp/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-csharp.git;a=summary">libvirt</a> @@ -63,8 +61,7 @@ <tr> <td>Go</td> <td> - <a href="ftp://libvirt.org/libvirt/go/">ftp</a> - <a href="https://libvirt.org/sources/go/">https</a> + <a href="https://libvirt.org/sources/go/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-go.git;a=summary">libvirt</a> @@ -80,8 +77,7 @@ <tr> <td>Java</td> <td> - <a href="ftp://libvirt.org/libvirt/java/">ftp</a> - <a href="https://libvirt.org/sources/java/">https</a> + <a href="https://libvirt.org/sources/java/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-java.git;a=summary">libvirt</a> @@ -95,8 +91,7 @@ <tr> <td>OCaml</td> <td> - <a href="ftp://libvirt.org/libvirt/ocaml/">ftp</a> - <a href="https://libvirt.org/sources/ocaml/">https</a> + <a href="https://libvirt.org/sources/ocaml/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-ocaml.git;a=summary">libvirt</a> @@ -127,8 +122,7 @@ <tr> <td>PHP</td> <td> - <a href="ftp://libvirt.org/libvirt/php/">ftp</a> - <a href="https://libvirt.org/sources/php/">https</a> + <a href="https://libvirt.org/sources/php/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-php.git;a=summary">libvirt</a> @@ -142,8 +136,7 @@ <tr> <td>Python</td> <td> - <a href="ftp://libvirt.org/libvirt/python/">ftp</a> - <a href="https://libvirt.org/sources/python/">https</a> + <a href="https://libvirt.org/sources/python/">libvirt</a> <a href="https://pypi.python.org/pypi/libvirt-python">pypi</a> </td> <td> @@ -158,8 +151,7 @@ <tr> <td>Ruby</td> <td> - <a href="ftp://libvirt.org/libvirt/ruby/">ftp</a> - <a href="https://libvirt.org/sources/ruby/">https</a> + <a href="https://libvirt.org/sources/ruby/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=ruby-libvirt.git;a=summary">libvirt</a> @@ -173,8 +165,7 @@ <tr> <td>Rust</td> <td> - <a href="ftp://libvirt.org/libvirt/rust/">ftp</a> - <a href="https://libvirt.org/sources/rust/">https</a> + <a href="https://libvirt.org/sources/rust/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-rust.git;a=summary">libvirt</a> @@ -191,8 +182,7 @@ <tr> <td>GLib / GConfig / GObject</td> <td> - <a href="ftp://libvirt.org/libvirt/glib/">ftp</a> - <a href="https://libvirt.org/sources/glib/">https</a> + <a href="https://libvirt.org/sources/glib/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-glib.git;a=summary">libvirt</a> @@ -206,8 +196,7 @@ <tr> <td>Go XML</td> <td> - <a href="ftp://libvirt.org/libvirt/go/">ftp</a> - <a href="https://libvirt.org/sources/go/">https</a> + <a href="https://libvirt.org/sources/go/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-go-xml.git;a=summary">libvirt</a> @@ -223,8 +212,7 @@ <tr> <td>D-Bus</td> <td> - <a href="ftp://libvirt.org/libvirt/dbus/">ftp</a> - <a href="https://libvirt.org/sources/dbus/">https</a> + <a href="https://libvirt.org/sources/dbus/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-dbus.git;a=summary">libvirt</a> @@ -238,8 +226,7 @@ <tr> <td>Console Proxy</td> <td> - <a href="ftp://libvirt.org/libvirt/consoleproxy/">ftp</a> - <a href="https://libvirt.org/sources/consoleproxy/">https</a> + <a href="https://libvirt.org/sources/consoleproxy/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-console-proxy.git;a=summary">libvirt</a> @@ -253,8 +240,7 @@ <tr> <td>CIM provider</td> <td> - <a href="ftp://libvirt.org/libvirt/CIM/">ftp</a> - <a href="https://libvirt.org/sources/CIM/">https</a> + <a href="https://libvirt.org/sources/CIM/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-cim.git;a=summary">libvirt</a> @@ -268,8 +254,7 @@ <tr> <td>CIM utils</td> <td> - <a href="ftp://libvirt.org/libvirt/CIM/">ftp</a> - <a href="https://libvirt.org/sources/CIM/">https</a> + <a href="https://libvirt.org/sources/CIM/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libcmpiutil.git;a=summary">libvirt</a> @@ -283,8 +268,7 @@ <tr> <td>SNMP</td> <td> - <a href="ftp://libvirt.org/libvirt/snmp/">ftp</a> - <a href="https://libvirt.org/sources/snmp/">https</a> + <a href="https://libvirt.org/sources/snmp/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-snmp.git;a=summary">libvirt</a> @@ -298,8 +282,7 @@ <tr> <td>Application Sandbox</td> <td> - <a href="ftp://libvirt.org/libvirt/sandbox/">ftp</a> - <a href="https://libvirt.org/sources/sandbox/">https</a> + <a href="https://libvirt.org/sources/sandbox/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-sandbox.git;a=summary">libvirt</a> @@ -316,8 +299,7 @@ <tr> <td>TCK</td> <td> - <a href="ftp://libvirt.org/libvirt/tck/">ftp</a> - <a href="https://libvirt.org/sources/tck/">https</a> + <a href="https://libvirt.org/sources/tck/">libvirt</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-tck.git;a=summary">libvirt</a> @@ -422,14 +404,11 @@ <p> Most modules have releases made available for download on the project - site, via FTP, HTTP or HTTPS. Some modules are instead made available - at alternative locations, for example, the Perl binding is made - available only on CPAN. + site via HTTPS. Some modules are instead made available at alternative + locations, for example, the Perl binding is made available only on CPAN. </p> <ul> - <li><a href="ftp://libvirt.org/libvirt/">libvirt.org FTP server</a></li> - <li><a href="https://libvirt.org/sources/">libvirt.org HTTP server</a></li> <li><a href="https://libvirt.org/sources/">libvirt.org HTTPS server</a></li> </ul> -- 2.20.1

2 3

[libvirt] [jenkins-ci PATCH] lcitool: include gdb, strace, lsof & netstat by default
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

When debugging why tests fail it is important to have commonly used tools like gdb, strace, lsof and netstat available. Note that although the entry for FreeBSD is blank for strace and net-tools, the truss (strace equiv) and netstat tools will be present as they are part of the FreeBSD base install. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 14 ++++++++++++++ guests/vars/projects/base.yml | 4 ++++ 2 files changed, 18 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 92681c2..50f07fa 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -164,6 +164,9 @@ mappings: default: gcc FreeBSD: + gdb: + default: gdb + gettext: default: gettext @@ -425,6 +428,9 @@ mappings: rpm: libxslt-devel cross-policy-deb: foreign + lsof: + default: lsof + lvm2: default: lvm2 FreeBSD: @@ -601,6 +607,10 @@ mappings: rpm: netcf-devel cross-policy-deb: skip + net-tools: + default: net-tools + FreeBSD: + numad: default: numad FreeBSD: @@ -868,6 +878,10 @@ mappings: rpm: spice-gtk3-devel cross-policy-deb: foreign + strace: + default: strace + FreeBSD: + sudo: default: sudo diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index 49d4d2e..b3d1d47 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -9,16 +9,20 @@ packages: - chrony - cppi - gcc + - gdb - gettext - git - glibc - libtool - libtoolize + - lsof + - net-tools - make - patch - perl - pkg-config - rpmbuild - screen + - strace - sudo - vim -- 2.19.2

2 1

[libvirt] [python PATCH] rpm: use new python macros for build/install rules
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

The new %py{2,3}_{build,install} macros ensure that the right compiler and linker flags are used when building python modules. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- libvirt-python.spec.in | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 5bcf1eb..8dd261f 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -119,19 +119,35 @@ exit 1 %endif %if %{with_python2} +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8 +%py2_build +%else CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py build %endif +%endif %if %{with_python3} +%if 0%{?fedora} >= 29 || 0%{?rhel} >= 8 +%py3_build +%else CFLAGS="$RPM_OPT_FLAGS" %{__python3} setup.py build %endif +%endif %install %if %{with_python2} +%if 0%{?fedora} || 0%{?rhel} >= 8 +%py2_install +%else %{__python2} setup.py install --skip-build --root=%{buildroot} %endif +%endif %if %{with_python3} +%if 0%{?fedora} || 0%{?rhel} >= 8 +%py3_install +%else %{__python3} setup.py install --skip-build --root=%{buildroot} %endif +%endif %check %if %{with_python2} -- 2.20.1

2 2

[libvirt] [PATCH] docs: update Perl download to point to modern CPAN site
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

The search.cpan.org site is a transparent redirect to metacpan.org these days, so we should just point directly to the new site. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/downloads.html.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/downloads.html.in b/docs/downloads.html.in index 0722469eb9..e84455ca04 100644 --- a/docs/downloads.html.in +++ b/docs/downloads.html.in @@ -105,7 +105,7 @@ <tr> <td>Perl (Sys::Virt)</td> <td> - <a href="http://search.cpan.org/dist/Sys-Virt/">cpan</a> + <a href="https://metacpan.org/release/Sys-Virt/">cpan</a> </td> <td> <a href="https://libvirt.org/git/?p=libvirt-perl.git;a=summary">libvirt</a> @@ -115,7 +115,7 @@ <a href="https://github.com/libvirt/libvirt-perl">github</a> </td> <td> - <a href="http://search.cpan.org/dist/Sys-Virt/">api ref</a> + <a href="https://metacpan.org/release/Sys-Virt/">api ref</a> <a href="https://libvirt.org/git/?p=libvirt-perl.git;a=blob;f=Changes;hb=HEAD">changes</a> </td> </tr> -- 2.20.1

2 1

[libvirt] [jenkins-ci PATCH] Ensure ca-certificates are installed
by Daniel P. Berrangé 04 Apr '19

04 Apr '19

On Red Hat variant distros ca-certificates gets pulled in automatically by other packages we require. This doesn't happen on Debian and so any use of https URIs fails. This prevents git from cloning submodules over https. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- guests/vars/mappings.yml | 4 ++++ guests/vars/projects/base.yml | 1 + 2 files changed, 5 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index 50f07fa..b369c0a 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -99,6 +99,10 @@ mappings: bash-completion: default: bash-completion + ca-certificates: + default: ca-certificates + FreeBSD: + ccache: default: ccache CentOS: diff --git a/guests/vars/projects/base.yml b/guests/vars/projects/base.yml index b3d1d47..a7e572b 100644 --- a/guests/vars/projects/base.yml +++ b/guests/vars/projects/base.yml @@ -5,6 +5,7 @@ packages: - autopoint - bash - bash-completion + - ca-certificates - ccache - chrony - cppi -- 2.19.2

2 1

[libvirt] [PATCH libvirt-python v3] Implement virDomainGetStateParams API
by Bjoern Walk 04 Apr '19

04 Apr '19

From: Marc Hartmayer <mhartmay(a)linux.ibm.com> This patch adds the Python binding for the virDomainGetStateParams API. The Python side can be generated automatically, the C side cannot. Reviewed-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com> Signed-off-by: Marc Hartmayer <mhartmay(a)linux.ibm.com> Signed-off-by: Bjoern Walk <bwalk(a)linux.ibm.com> --- generator.py | 1 + libvirt-override-api.xml | 6 +++++ libvirt-override.c | 48 ++++++++++++++++++++++++++++++++++++++++ 3 files changed, 55 insertions(+) diff --git a/generator.py b/generator.py index ffa3ce56..005be502 100755 --- a/generator.py +++ b/generator.py @@ -496,6 +496,7 @@ skip_impl = ( 'virConnectBaselineHypervisorCPU', 'virDomainGetLaunchSecurityInfo', 'virNodeGetSEVInfo', + 'virDomainGetStateParams', ) lxc_skip_impl = ( diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index 7f578e01..fab62447 100644 --- a/libvirt-override-api.xml +++ b/libvirt-override-api.xml @@ -754,5 +754,11 @@ <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/> <arg name='flags' type='int' info='unused, always pass 0'/> </function> + <function name='virDomainGetStateParams' file='python'> + <info>Extract domain state and additional information (if available).</info> + <arg name='dom' type='virDomainPtr' info='pointer to the domain'/> + <arg name='flags' type='unsigned int' info='extra flags; not used yet, so callers should always pass 0'/> + <return type='char *' info="dictionary of state data"/> + </function> </symbols> </api> diff --git a/libvirt-override.c b/libvirt-override.c index c5e2908c..e96a35a0 100644 --- a/libvirt-override.c +++ b/libvirt-override.c @@ -9946,6 +9946,51 @@ libvirt_virNodeGetSEVInfo(PyObject *self ATTRIBUTE_UNUSED, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(5, 3, 0) +static PyObject * +libvirt_virDomainGetStateParams(PyObject *self ATTRIBUTE_UNUSED, + PyObject *args) +{ + PyObject *py_retval = VIR_PY_NONE; + PyObject *pyobj_domain; + virDomainPtr domain; + int state; + int reason; + virTypedParameterPtr params = NULL; + int nparams = 0; + unsigned int flags; + int c_retval; + + if (!PyArg_ParseTuple(args, (char *)"OI:virDomainGetStateParams", + &pyobj_domain, &flags)) + return NULL; + domain = (virDomainPtr) PyvirDomain_Get(pyobj_domain); + + LIBVIRT_BEGIN_ALLOW_THREADS; + c_retval = virDomainGetStateParams(domain, &state, &reason, &params, + &nparams, flags); + LIBVIRT_END_ALLOW_THREADS; + + if (c_retval < 0) + goto error; + + if ((py_retval = PyTuple_New(3)) == NULL) + goto error; + + VIR_PY_TUPLE_SET_GOTO(py_retval, 0, libvirt_intWrap(state), error); + VIR_PY_TUPLE_SET_GOTO(py_retval, 1, libvirt_intWrap(reason), error); + VIR_PY_TUPLE_SET_GOTO(py_retval, 2, getPyVirTypedParameter(params, nparams), error); + + return py_retval; + +error: + Py_XDECREF(py_retval); + virTypedParamsFree(params, nparams); + return VIR_PY_NONE; +} +#endif /* LIBVIR_CHECK_VERSION(5, 2, 0) */ + + /************************************************************************ * * * The registration stuff * @@ -10192,6 +10237,9 @@ static PyMethodDef libvirtMethods[] = { {(char *) "virDomainGetLaunchSecurityInfo", libvirt_virDomainGetLaunchSecurityInfo, METH_VARARGS, NULL}, {(char *) "virNodeGetSEVInfo", libvirt_virNodeGetSEVInfo, METH_VARARGS, NULL}, #endif /* LIBVIR_CHECK_VERSION(4, 5, 0) */ +#if LIBVIR_CHECK_VERSION(5, 3, 0) + {(char *) "virDomainGetStateParams", libvirt_virDomainGetStateParams, METH_VARARGS, NULL}, +#endif /* LIBVIR_CHECK_VERSION(5, 3, 0) */ {NULL, NULL, 0, NULL} }; -- 2.19.1

1 0

[libvirt] [PATCH v2 0/3] qemu: don't duplicate suspended events and state changes
by Nikolay Shirokovskiy 03 Apr '19

03 Apr '19

Patches 1 and 2 are already Reviewed-by: John. Patch 3 needs Peter comments. Diff from v1: ============ - minor rebase changes - minor changes according to review [1] PATCH v1 : https://www.redhat.com/archives/libvir-list/2018-October/msg00591.html Nikolay Shirokovskiy (3): qemu: Pass stop reason from qemuProcessStopCPUs to stop handler qemu: Map suspended state reason to suspended event detail qemu: Don't duplicate suspend events and state changes src/qemu/qemu_domain.c | 34 ++++++++++++++++++++++++++++++++++ src/qemu/qemu_domain.h | 7 +++++++ src/qemu/qemu_driver.c | 26 +++----------------------- src/qemu/qemu_migration.c | 42 ++++++------------------------------------ src/qemu/qemu_migration.h | 4 ---- src/qemu/qemu_process.c | 38 +++++++++++++++++++++++++------------- 6 files changed, 75 insertions(+), 76 deletions(-) -- 1.8.3.1

3 6

[libvirt] [PATCH 0/3] vir*ObjListAddLocked(): Produce better error message than 'Duplicate key'
by Michal Privoznik 03 Apr '19

03 Apr '19

*** BLURB HERE *** Michal Prívozník (3): DO NOT APPLY: Simple reproducer for virDomainObjListRemove virDomainObjListAddLocked: Produce better error message than 'Duplicate key' virNWFilterBindingObjListAddLocked: Produce better error message than 'Duplicate key' src/conf/virdomainobjlist.c | 36 +++++++++++++++++----------- src/conf/virnwfilterbindingobjlist.c | 29 +++++++++++++--------- 2 files changed, 40 insertions(+), 25 deletions(-) -- 2.19.2

2 6

[libvirt] [PATCH 0/4] qemu: Use PCI by default on RISC-V
by Andrea Bolognani 03 Apr '19

03 Apr '19

Now that the patches necessary to enable pcie-root-port usage on RISC-V have been merged into QEMU, we can go ahead and start using PCI by default on such guests when appropriate. The full series, with patch 3/4 in its unabridged form, can be obtained from https://github.com/andreabolognani/libvirt/tree/riscv-pci-by-default Andrea Bolognani (4): qemu: Require PCIe Root Port for PCI by default on ARM virt qemu: Unify address assignment for virt guests tests: Refresh capabilities for QEMU 4.0.0 on RISC-V news: Document PCI by default on RISC-V docs/news.xml | 12 + src/qemu/qemu_domain_address.c | 45 +- .../caps_4.0.0.riscv32.replies | 3864 ++++++++-------- .../caps_4.0.0.riscv32.xml | 19 +- .../caps_4.0.0.riscv64.replies | 3876 +++++++++-------- .../caps_4.0.0.riscv64.xml | 19 +- .../riscv64-virt-headless.riscv64-latest.args | 20 +- 7 files changed, 4206 insertions(+), 3649 deletions(-) -- 2.20.1

2 5

[libvirt] [PATCH] virsh.pod: Improve native configuration format doc
by Han Han 03 Apr '19

03 Apr '19

Add native guest format of BSD hypervisor and VMware/ESX. Quote native guest format of domxml-from-native for domxml-to-native. Signed-off-by: Han Han <hhan(a)redhat.com> --- tools/virsh.pod | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/tools/virsh.pod b/tools/virsh.pod index a0fe949c55..b3819b9414 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -1607,21 +1607,17 @@ Convert the file I<config> in the native guest configuration format named by I<format> to a domain XML format. For QEMU/KVM hypervisor, the I<format> argument must be B<qemu-argv>. For Xen hypervisor, the I<format> argument may be B<xen-xm>, B<xen-xl>, or B<xen-sxpr>. For -LXC hypervisor, the I<format> argument must be B<lxc-tools>. +LXC hypervisor, the I<format> argument must be B<lxc-tools>. For +VMware/ESX hypervisor, the I<format> argument must be B<vmware-vmx>. +For the BSD hypervisor, the I<format> argument must be B<bhyve-argv>. =item B<domxml-to-native> I<format> { [I<--xml>] I<xml> | I<--domain> I<domain-name-or-id-or-uuid> } Convert the file I<xml> into domain XML format or convert an existing I<--domain> to the native guest configuration format named by I<format>. -The I<xml> and I<--domain> arguments are mutually exclusive. - -For the QEMU/KVM hypervisor, the I<format> argument must be B<qemu-argv>. - -For the Xen hypervisor, the I<format> argument may be B<xen-xm>, B<xen-xl>, -or B<xen-sxpr>. - -For the LXC hypervisor, the I<format> argument must be B<lxc-tools>. +The I<xml> and I<--domain> arguments are mutually exclusive. For the types +of I<format> argument, refer to B<domxml-from-native>. =item B<dump> I<domain> I<corefilepath> [I<--bypass-cache>] { [I<--live>] | [I<--crash>] | [I<--reset>] } [I<--verbose>] [I<--memory-only>] -- 2.20.1

2 1

[libvirt] [PATCH] qemu_hotplug: Remove virQEMUDriverPtr arguments
by Suyang Chen 03 Apr '19

03 Apr '19

Since commit 2e6ecba1bcac, the pointer to the qemu driver is saved in domain object's private data and hence does not have to be passed as yet another parameter if domain object is already one of them. This just changed qemuDomainChangeDiskLive and qemuDomainChangeEjectableMedia functions Signed-off-by: Suyang Chen <dawson0xff(a)gmail.com> --- src/qemu/qemu_driver.c | 5 ++--- src/qemu/qemu_hotplug.c | 29 ++++++++++++++--------------- src/qemu/qemu_hotplug.h | 3 +-- 3 files changed, 17 insertions(+), 20 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b27c6ce98e..5d064030e9 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -8100,7 +8100,6 @@ qemuDomainDetachDeviceLive(virDomainObjPtr vm, static int qemuDomainChangeDiskLive(virDomainObjPtr vm, virDomainDeviceDefPtr dev, - virQEMUDriverPtr driver, bool force) { virDomainDiskDefPtr disk = dev->data.disk; @@ -8136,7 +8135,7 @@ qemuDomainChangeDiskLive(virDomainObjPtr vm, goto cleanup; } - if (qemuDomainChangeEjectableMedia(driver, vm, orig_disk, + if (qemuDomainChangeEjectableMedia(vm, orig_disk, dev->data.disk->src, force) < 0) goto cleanup; @@ -8165,7 +8164,7 @@ qemuDomainUpdateDeviceLive(virDomainObjPtr vm, switch ((virDomainDeviceType)dev->type) { case VIR_DOMAIN_DEVICE_DISK: qemuDomainObjCheckDiskTaint(driver, vm, dev->data.disk, NULL); - ret = qemuDomainChangeDiskLive(vm, dev, driver, force); + ret = qemuDomainChangeDiskLive(vm, dev, force); break; case VIR_DOMAIN_DEVICE_GRAPHICS: diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c index 41d60277d1..4bcec0e982 100644 --- a/src/qemu/qemu_hotplug.c +++ b/src/qemu/qemu_hotplug.c @@ -844,14 +844,13 @@ qemuDomainChangeMediaBlockdev(virQEMUDriverPtr driver, * Returns 0 on success, -1 on error and reports libvirt error */ int -qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, - virDomainObjPtr vm, +qemuDomainChangeEjectableMedia(virDomainObjPtr vm, virDomainDiskDefPtr disk, virStorageSourcePtr newsrc, bool force) { - virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver); qemuDomainObjPrivatePtr priv = vm->privateData; + virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(priv->driver); virStorageSourcePtr oldsrc = disk->src; bool sharedAdded = false; int ret = -1; @@ -862,27 +861,27 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, if (virDomainDiskTranslateSourcePool(disk) < 0) goto cleanup; - if (qemuAddSharedDisk(driver, disk, vm->def->name) < 0) + if (qemuAddSharedDisk(priv->driver, disk, vm->def->name) < 0) goto cleanup; sharedAdded = true; - if (qemuDomainDetermineDiskChain(driver, vm, disk, NULL, true) < 0) + if (qemuDomainDetermineDiskChain(priv->driver, vm, disk, NULL, true) < 0) goto cleanup; if (qemuDomainPrepareDiskSource(disk, priv, cfg) < 0) goto cleanup; - if (qemuHotplugPrepareDiskSourceAccess(driver, vm, newsrc, false) < 0) + if (qemuHotplugPrepareDiskSourceAccess(priv->driver, vm, newsrc, false) < 0) goto cleanup; - if (qemuHotplugAttachManagedPR(driver, vm, newsrc, QEMU_ASYNC_JOB_NONE) < 0) + if (qemuHotplugAttachManagedPR(priv->driver, vm, newsrc, QEMU_ASYNC_JOB_NONE) < 0) goto cleanup; if (virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_BLOCKDEV)) - rc = qemuDomainChangeMediaBlockdev(driver, vm, disk, oldsrc, newsrc, force); + rc = qemuDomainChangeMediaBlockdev(priv->driver, vm, disk, oldsrc, newsrc, force); else - rc = qemuDomainChangeMediaLegacy(driver, vm, disk, newsrc, force); + rc = qemuDomainChangeMediaLegacy(priv->driver, vm, disk, newsrc, force); virDomainAuditDisk(vm, oldsrc, newsrc, "update", rc >= 0); @@ -891,8 +890,8 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, /* remove the old source from shared device list */ disk->src = oldsrc; - ignore_value(qemuRemoveSharedDisk(driver, disk, vm->def->name)); - ignore_value(qemuHotplugPrepareDiskSourceAccess(driver, vm, oldsrc, true)); + ignore_value(qemuRemoveSharedDisk(priv->driver, disk, vm->def->name)); + ignore_value(qemuHotplugPrepareDiskSourceAccess(priv->driver, vm, oldsrc, true)); /* media was changed, so we can remove the old media definition now */ virObjectUnref(oldsrc); @@ -905,13 +904,13 @@ qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, /* undo changes to the new disk */ if (ret < 0) { if (sharedAdded) - ignore_value(qemuRemoveSharedDisk(driver, disk, vm->def->name)); + ignore_value(qemuRemoveSharedDisk(priv->driver, disk, vm->def->name)); - ignore_value(qemuHotplugPrepareDiskSourceAccess(driver, vm, newsrc, true)); + ignore_value(qemuHotplugPrepareDiskSourceAccess(priv->driver, vm, newsrc, true)); } /* remove PR manager object if unneeded */ - ignore_value(qemuHotplugRemoveManagedPR(driver, vm, QEMU_ASYNC_JOB_NONE)); + ignore_value(qemuHotplugRemoveManagedPR(priv->driver, vm, QEMU_ASYNC_JOB_NONE)); /* revert old image do the disk definition */ if (oldsrc) @@ -1315,7 +1314,7 @@ qemuDomainAttachDeviceDiskLive(virQEMUDriverPtr driver, if ((disk->device == VIR_DOMAIN_DISK_DEVICE_CDROM || disk->device == VIR_DOMAIN_DISK_DEVICE_FLOPPY) && (orig_disk = virDomainDiskFindByBusAndDst(vm->def, disk->bus, disk->dst))) { - if (qemuDomainChangeEjectableMedia(driver, vm, orig_disk, + if (qemuDomainChangeEjectableMedia(vm, orig_disk, disk->src, false) < 0) return -1; diff --git a/src/qemu/qemu_hotplug.h b/src/qemu/qemu_hotplug.h index 7ac03b7810..a60df36f74 100644 --- a/src/qemu/qemu_hotplug.h +++ b/src/qemu/qemu_hotplug.h @@ -26,8 +26,7 @@ # include "qemu_domain.h" # include "domain_conf.h" -int qemuDomainChangeEjectableMedia(virQEMUDriverPtr driver, - virDomainObjPtr vm, +int qemuDomainChangeEjectableMedia(virDomainObjPtr vm, virDomainDiskDefPtr disk, virStorageSourcePtr newsrc, bool force); -- 2.20.1

2 1

[libvirt] CfP VHPC19: HPC Virtualization-Containers: Paper due May 1, 2019 (extended)
by VHPC 19 03 Apr '19

03 Apr '19

==================================================================== CALL FOR PAPERS 14th Workshop on Virtualization in High-Performance Cloud Computing (VHPC '19) held in conjunction with the International Supercomputing Conference - High Performance, June 16-20, 2019, Frankfurt, Germany. (Springer LNCS Proceedings) ==================================================================== Date: June 20, 2019 Workshop URL: http://vhpc.org Paper Submission Deadline: May 1, 2019 (extended) Springer LNCS, rolling abstract submission Abstract/Paper Submission Link: https://edas.info/newPaper.php?c=25685 Call for Papers Containers and virtualization technologies constitute key enabling factors for flexible resource management in modern data centers, and particularly in cloud environments. Cloud providers need to manage complex infrastructures in a seamless fashion to support the highly dynamic and heterogeneous workloads and hosted applications customers deploy. Similarly, HPC environments have been increasingly adopting techniques that enable flexible management of vast computing and networking resources, close to marginal provisioning cost, which is unprecedented in the history of scientific and commercial computing. Various virtualization-containerization technologies contribute to the overall picture in different ways: machine virtualization, with its capability to enable consolidation of multiple underutilized servers with heterogeneous software and operating systems (OSes), and its capability to live-migrate a fully operating virtual machine (VM) with a very short downtime, enables novel and dynamic ways to manage physical servers; OS-level virtualization (i.e., containerization), with its capability to isolate multiple user-space environments and to allow for their coexistence within the same OS kernel, promises to provide many of the advantages of machine virtualization with high levels of responsiveness and performance; lastly, unikernels provide for many virtualization benefits with a minimized OS/library surface. I/O Virtualization in turn allows physical network interfaces to take traffic from multiple VMs or containers; network virtualization, with its capability to create logical network overlays that are independent of the underlying physical topology is furthermore enabling virtualization of HPC infrastructures. Publication Accepted papers will be published in a Springer LNCS proceedings volume. Topics of Interest The VHPC program committee solicits original, high-quality submissions related to virtualization across the entire software stack with a special focus on the intersection of HPC, containers-virtualization and the cloud. Major Topics: - HPC on Containers and VMs - Containerized applications with OS-level virtualization - Lightweight applications with Unikernels - HP-as-a-Service each major topic encompassing design/architecture, management, performance management, modeling and configuration/tooling: Design / Architecture: - Containers and OS-level virtualization (LXC, Docker, rkt, Singularity, Shifter, i.a.) - Hypervisor support for heterogeneous resources (GPUs, co-processors, FPGAs, etc.) - Hypervisor extensions to mitigate side-channel attacks ([micro-]architectural timing attacks, privilege escalation) - VM & Container trust and security models - Multi-environment coupling, system software supporting in-situ analysis with HPC simulation - Cloud reliability, fault-tolerance and high-availability - Energy-efficient and power-aware virtualization - Containers inside VMs with hypervisor isolation - Virtualization support for emerging memory technologies - Lightweight/specialized operating systems in conjunction with virtual machines - Hypervisor support for heterogeneous resources (GPUs, co-processors, FPGAs, etc.) - Novel unikernels and use cases for virtualized HPC environments - ARM-based hypervisors, ARM virtualization extensions Management: - Container and VM management for HPC and cloud environments - HPC services integration, services to support HPC - Service and on-demand scheduling & resource management - Dedicated workload management with VMs or containers - Workflow coupling with VMs and containers - Unikernel, lightweight VM application management - Environments and tools for operating containerized environments (batch, orchestration) - Novel models for non-HPC workload provisioning on HPC resources Performance Measurements and Modeling: - Performance improvements for or driven by unikernels - Optimizations of virtual machine monitor platforms and hypervisors - Scalability analysis of VMs and/or containers at large scale - Performance measurement, modeling and monitoring of virtualized/cloud workloads - Virtualization in supercomputing environments, HPC clusters, HPC in the cloud Configuration / Tooling: - Tool support for unikernels: configuration/build environments, debuggers, profilers - Job scheduling/control/policy and container placement in virtualized environments - Operating MPI in containers/VMs and Unikernels - Software defined networks and network virtualization - GPU virtualization operationalization The Workshop on Virtualization in High-Performance Cloud Computing (VHPC) aims to bring together researchers and industrial practitioners facing the challenges posed by virtualization in order to foster discussion, collaboration, mutual exchange of knowledge and experience, enabling research to ultimately provide novel solutions for virtualized computing systems of tomorrow. The workshop will be one day in length, composed of 20 min paper presentations, each followed by 10 min discussion sections, plus lightning talks that are limited to 5 minutes. Presentations may be accompanied by interactive demonstrations. Important Dates May 1, 2019 - Abstract/Paper extended submission deadline (Springer LNCS) May 20, 2019 - Acceptance notification June 20th, 2019 - Workshop Day July 10th, 2019 - Camera-ready version due Chair Michael Alexander (chair), University of Vienna, Austria Anastassios Nanos (co-chair), SunLight.io, UK Andrew Younge (co-chair), Sandia National Laboratories Program committee Stergios Anastasiadis, University of Ioannina, Greece Jakob Blomer, CERN, Europe Eduardo César, Universidad Autonoma de Barcelona, Spain Taylor Childers, Argonne National Laboratory, USA Stephen Crago, USC ISI, USA Tommaso Cucinotta, St. Anna School of Advanced Studies, Italy Christoffer Dall, Columbia University, USA François Diakhaté, CEA, France Patrick Dreher, MIT, USA Kyle Hale, Northwestern University, USA Bob Killen, University of Michigan, USA Brian Kocoloski, Washington University, USA John Lange, University of Pittsburgh, USA Giuseppe Lettieri, University of Pisa, Italy Qing Liu, Oak Ridge National Laboratory, USA Nikos Parlavantzas, IRISA, France Kevin Pedretti, Sandia National Laboratories, USA Amer Qouneh, Western New England University, USA Carlos Reaño, Queen’s University Belfast, UK Borja Sotomayor, University of Chicago, USA Jonathan Sparks, Cray, USA Joe Stubbs, Texas Advanced Computing Center, USA Anata Tiwari, San Diego Supercomputer Center, USA Kurt Tutschku, Blekinge Institute of Technology, Sweden John Walters, USC ISI, USA Yasuhiro Watashiba, Osaka University, Japan Chao-Tung Yang, Tunghai University, Taiwan Na Zhang, VMware, USA Paper Submission-Publication Papers submitted to the workshop will be reviewed by at least two members of the program committee and external reviewers. Submissions should include abstract, keywords, the e-mail address of the corresponding author, and must not exceed 10 pages, including tables and figures at a main font size no smaller than 11 point. Submission of a paper should be regarded as a commitment that, should the paper be accepted, at least one of the authors will register and attend the conference to present the work. Accepted papers will be published in a Springer LNCS volume. The format must be according to the Springer LNCS Style. Initial submissions are in PDF; authors of accepted papers will be requested to provide source files. Format Guidelines: ftp://ftp.springernature.com/cs-proceeding/llncs/llncs2e.zip Abstract, Paper Submission Link: https://edas.info/newPaper.php?c=25685 Lightning Talks Lightning Talks are non-paper track, synoptical in nature and are strictly limited to 5 minutes. They can be used to gain early feedback on ongoing research, for demonstrations, to present research results, early research ideas, perspectives and positions of interest to the community. Submit abstract via the main submission link. General Information The workshop is one day in length and will be held in conjunction with the International Supercomputing Conference - High Performance (ISC) 2019, June 16-20, Frankfurt, Germany.

1 0

[libvirt] Release of libvirt-5.2.0
by Daniel Veillard 03 Apr '19

03 Apr '19

It's out, a bit late but the signed tarball and rpms are at the usual place and it's tagged in git: ftp://libvirt.org/libvirt/ I also pushed the python bindings, with only a single patch since 5.1.0 at: ftp://libvirt.org/libvirt/python/ Note that it's a release with rather large changes, new features and removal of some deprecated init scripts, and as usual a large amount of improvement and bug fixes: New features: - Add Storage Pool Capabilities output Add support to list an enumerated list of supported Storage Pools via the virConnectGetCapabilities API when connected via a Storage Driver. Add support to get a more detailed list XML output Storage Pool Capabilities vis the virConnectGetStoragePoolCapabilites API. - qemu: Support virtio-{non-}transitional device models virtio-transitional and virtio-non-transitional model values were added to the QEMU driver for the following devices: disk, interface, filesystem, rng, vsock, memballoon, controller type scsi, controller type virtio-serial, input bus virtio type passthrough, hostdev type scsi_host. These new models can be used to give fine grained control over what virtio device version is presented to the guest. - qemu: Enable firmware autoselection Libvirt allows users to provide loader path for some time now. However, this puts some burden on users because they need to know what firmware meets their requirements. Now that QEMU ships firmware description files this burden can be moved onto libvirt. It is as easy as setting the firmware attribute in the os element (accepted values are bios and efi). Moreover, libvirt automatically enables domain features needed for firmware it chooses. - snapshots: Add support for topological listings A new flag VIR_DOMAIN_SNAPSHOT_LIST_TOPOLOGICAL is available for the various snapshot listing APIs such as virDomainListAllSnapshots(). For drivers that support the flag, the listed snapshots are guaranteed to be sorted such that parents occur before children. - Xen: Add support for max grant frames setting Add support for Xen's max_grant_frames setting by adding a new xenbus controller type with a maxGrantFrames attribute. E.g. <controller type='xenbus' maxGrantFrames='64'/> - qemu: Add support for parallel migration With QEMU 4.0.0 libvirt can enable parallel migration which causes the memory pages to be processed in parallel by several threads and sent to the destination host using several connections at the same time. This may increase migration speed in case a single thread is unable to saturate the network link. Removed features: - Drop support for Upstart and "Red Hat" init scripts Not a single one of the platforms we target still uses Upstart, and the Upstart project itself has been abandoned for several years now; the same is true for the "Red Hat" (really System V) init scripts, since RHEL 7 and later releases use systemd. Improvements: - Report class information for PCI node device capability. - Split setup of IPv4 and IPv6 top level chain The requirement resulting from private chains improvement done in v5.1.0 was refined so that only tables from corresponding IP version are required. This means that if a network doesn't have IPv6 enabled then those tables are not required. - Don't default to building the QEMU driver Historically, the QEMU driver has been special in that it was enabled by default, with the option to explicitly opt-out of it; starting now, we're enabling it opportunistically if we detect that all requirements are available, just like we do with other drivers. Bug fixes: - virt-host-validate: Fix IOMMU check on s390x - qemu: Allow creating pSeries guests with graphics and no USB mouse It's now possible to prevent libvirt from automatically adding a USB mouse to pSeries guests by including a USB tablet in the input XML: doing so is desiderable as using a tablet results in a much better user experience when working with GUIs. - qemu: Set $HOME and XGD variables for qemu:///system guests This avoids files being accidentally created under / or the guests not being able to start because they lack the necessary permissions to write to that location. Thanks everybody for your contributions for this release, be it with bug reports, patches, reviews, documentation, etc... Enjoy the release ! Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

3 3

[libvirt] [perl PATCH] rpm: remove BuildRoot setting
by Daniel P. Berrangé 03 Apr '19

03 Apr '19

This is obsolete and removed from all Fedora RPMs Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- perl-Sys-Virt.spec.PL | 1 - 1 file changed, 1 deletion(-) Pushed as a trivial sync back from Fedora dist-git diff --git a/perl-Sys-Virt.spec.PL b/perl-Sys-Virt.spec.PL index b489a41..5623fe5 100644 --- a/perl-Sys-Virt.spec.PL +++ b/perl-Sys-Virt.spec.PL @@ -33,7 +33,6 @@ Summary: Represent and manage a libvirt hypervisor connection License: GPLv2+ or Artistic URL: https://metacpan.org/release/Sys-Virt Source0: https://cpan.metacpan.org/authors/id/D/DA/DANBERR/Sys-Virt-v%{version}.tar.… -BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) # Build BuildRequires: coreutils BuildRequires: findutils -- 2.20.1

1 0

[libvirt] [PATCH 0/5] util: Remove some obsolete and dead code
by Peter Krempa 03 Apr '19

03 Apr '19

Peter Krempa (5): util: Remove virPipeReadUntilEOF vmx: Remove unused variable in virVMXParseConfig vmx: Refactor number parsing in virVMXParseConfig rpc: ssh: Use virStrToLong_i instead of virParseNumber util: Remove virParseNumber src/libvirt_private.syms | 2 - src/rpc/virnetlibsshsession.c | 6 +- src/util/virutil.c | 113 ---------------------------------- src/util/virutil.h | 4 -- src/vmx/vmx.c | 62 ++++++------------- 5 files changed, 23 insertions(+), 164 deletions(-) -- 2.20.1

2 10

[libvirt] [PATCH] mingw: Bump minimum supported Fedora version to 28
by Andrea Bolognani 03 Apr '19

03 Apr '19

Should have been part of 2569ba133822, but clearly wasn't. Signed-off-by: Andrea Bolognani <abologna(a)redhat.com> --- mingw-libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index bea822fd73..8756a56a23 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -3,7 +3,7 @@ # This spec file assumes you are building on a Fedora version # that's still supported by the vendor. It may work on other distros # or versions, but no effort will be made to ensure that going forward. -%define min_fedora 26 +%define min_fedora 28 %if 0%{?fedora} && 0%{?fedora} >= %{min_fedora} %define supported_platform 1 -- 2.20.1

2 2

[libvirt] deadlock in remoteDispatchDomainUndefine vs daemonStreamHandleAbort
by Christian Ehrhardt 03 Apr '19

03 Apr '19

Hi, I happened to analyze a bug [1] report I got from a friend and for quite a while it was rather elusive. But I now finally got it reproducible [2] enough to share it with the community. The TL;DR of what I see is: - an automation with python-libvirt gets a SIGINT - cleanup runs destroy and further undefine - the guest closes FDs due to SIGINT and/or destroy which triggers daemonStreamHandleAbort - those two fight over the lock There I get libvirtd into a deadlock which ends up with all threads dead [4] and two of them fighting [3] (details) in particular. The to related stacks summarized are like: daemonStreamHandleWrite (failing to write) -> daemonStreamHandleAbort (closing things and cleaning up) -> ... virChrdevFDStreamCloseCb virMutexLock(&priv->devs->lock); # there is code meant to avoid such issues emitting "Unable to close" if a lock is held # but the log doesn't show this triggering with debug enabled #10 seems triggered via an "undefine" call remoteDispatchDomainUndefine ... -> virChrdevFree ... -> virFDStreamSetInternalCloseCb -> virObjectLock(virFDStreamDataPtr fdst) -> virMutexLock(&obj->lock); # closing all streams of a guest (requiring the same locks) While that already feels quite close I struggle to see where exactly we'd want to fix it. But finally having a repro-script [2] I hope that someone else here might be able to help me with that. After all it is a race - on my s390x system it triggers usually <5 tries, while on x86 I have needed up to 18 runs of the test to hang. Given different system configs it might be better or worse for you. FYI we hit this with libvirt 4.0 initially but libvirt 5.0 was just the same. I haven't built 5.1 or a recent master, but the commits since 5.0 didn't mention any issue that seems related. OTOH I'm willing and able to build and try suggestions if anyone comes up with ideas. [1]: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1822096 [2]: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1822096/+attachment/… [3]: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1822096/comments/3 [4]: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1822096/comments/17 -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

2 4

[libvirt] [PATCH] mingw: unconditionally enable libssh2 in RPM
by Daniel P. Berrangé 03 Apr '19

03 Apr '19

The libssh2 support in libvirt is not solely for phyp, it is used by the remote driver too. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- mingw-libvirt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/mingw-libvirt.spec.in b/mingw-libvirt.spec.in index 9983a5013f..913aaa8751 100644 --- a/mingw-libvirt.spec.in +++ b/mingw-libvirt.spec.in @@ -85,10 +85,8 @@ BuildRequires: gettext-devel BuildRequires: libtool %endif -%if %{with_phyp} BuildRequires: mingw32-libssh2 BuildRequires: mingw64-libssh2 -%endif %if %{with_esx} BuildRequires: mingw32-curl BuildRequires: mingw64-curl -- 2.20.1

2 1