- Devel - libvirt List Archives

[libvirt] [python PATCH] Allow virConnect.getDomainCapabilities() to have no arguments
by Michal Privoznik 29 Apr '19

29 Apr '19

Our C API allows no values to be passed (well, it accepts all NULLs). There's no reason that python binding should require all arguments. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- libvirt-override-api.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libvirt-override-api.xml b/libvirt-override-api.xml index 7f578e0..53b15c5 100644 --- a/libvirt-override-api.xml +++ b/libvirt-override-api.xml @@ -754,5 +754,15 @@ <arg name='conn' type='virConnectPtr' info='pointer to hypervisor connection'/> <arg name='flags' type='int' info='unused, always pass 0'/> </function> + <function name='virConnectGetDomainCapabilities' file='libvirt-domain' module='libvirt-domain'> + <info>Query domain capabilities</info> + <return type='char *' info='NULL in case of error or an XML string defining the capabilities.'/> + <arg name='conn' type='virConnectPtr' info='pointer to the hypervisor connection'/> + <arg name='emulatorbin' type='const char *' info='optional path to emulator'/> + <arg name='arch' type='const char *' info='optional domain architecture'/> + <arg name='machine' type='const char *' info='optional machine type'/> + <arg name='virttype' type='const char *' info='optional virtualization type'/> + <arg name='flags' type='int' info='unused, always pass 0'/> + </function> </symbols> </api> -- 2.21.0

2 1

[libvirt] [PATCH] CONF: bug, release 'alloc' object in cleanup
by Wang Huaqiang 29 Apr '19

29 Apr '19

In case error happens before 'alloc' is transferred to 'resctrl', the 'alloc' object should be released. Signed-off-by: Wang Huaqiang <huaqiang.wang(a)intel.com> --- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 6331424..7d20276 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -19396,6 +19396,7 @@ virDomainCachetuneDefParse(virDomainDefPtr def, ret = 0; cleanup: + virObjectUnref(alloc); virDomainResctrlDefFree(resctrl); return ret; } @@ -19597,6 +19598,7 @@ virDomainMemorytuneDefParse(virDomainDefPtr def, ret = 0; cleanup: + virObjectUnref(alloc); virDomainResctrlDefFree(resctrl); return ret; } -- 2.7.4

3 2

[libvirt] [PATCH 0/4] Couple of almost trivial disk cold-/hot-plug fixes
by Michal Privoznik 29 Apr '19

29 Apr '19

*** BLURB HERE *** Michal Prívozník (4): src: Check for virDomainDiskInsert() retval properly qemuDomainAttachDeviceLiveAndConfig: Don't overwrite @ret qemu: On attach to live XML check for user alias collision only live XML qemu: Check for user alias collisions in coldplug src/libxl/libxl_driver.c | 2 +- src/lxc/lxc_driver.c | 2 +- src/qemu/qemu_driver.c | 32 ++++++++++++++++++-------------- 3 files changed, 20 insertions(+), 16 deletions(-) -- 2.21.0

3 10

[libvirt] [PATCH] qemu: Add entry for balloon stats stat-htlb-pgalloc and stat-htlb-pgfail
by Han Han 28 Apr '19

28 Apr '19

Qemu added reporting of virtio balloon new statistics stat-htlb-pgalloc and stat-htlb-pgfail since qemu-3.0 commit b7b12644297. The value of stat-htlb-pgalloc represents the number of successful hugetlb page allocations while stat-htlb-pgfail represents the number of failed ones. Add this statistics reporting to libvirt. Signed-off-by: Han Han <hhan(a)redhat.com> --- include/libvirt/libvirt-domain.h | 14 +++++++++++++- src/libvirt-domain.c | 5 ++++- src/qemu/qemu_driver.c | 2 ++ src/qemu/qemu_monitor_json.c | 5 +++++ tools/virsh-domain-monitor.c | 4 ++++ tools/virsh.pod | 2 ++ 6 files changed, 30 insertions(+), 2 deletions(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 7d36820b5a..192d25c1db 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -636,11 +636,23 @@ typedef enum { */ VIR_DOMAIN_MEMORY_STAT_DISK_CACHES = 10, + /* + * The amount of successful hugetlb(Huge Page Tables) allocations via + * virtio balloon. + */ + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC = 11, + + /* + * The amount of failed hugetlb(Huge Page Tables) allocations via + * virtio balloon. + */ + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL = 12, + /* * The number of statistics supported by this version of the interface. * To add new statistics, add them to the enum and increase this value. */ - VIR_DOMAIN_MEMORY_STAT_NR = 11, + VIR_DOMAIN_MEMORY_STAT_NR = 13, # ifdef VIR_ENUM_SENTINELS VIR_DOMAIN_MEMORY_STAT_LAST = VIR_DOMAIN_MEMORY_STAT_NR diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index 80284a99f0..a95690e8a4 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -5734,7 +5734,10 @@ virDomainGetInterfaceParameters(virDomainPtr domain, * VIR_DOMAIN_MEMORY_STAT_DISK_CACHES * Memory that can be reclaimed without additional I/O, typically disk * caches (in kb). - * + * VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC + * The amount of successful hugetlb(Huge Page Tables) allocations + * VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL + * The amount of failed hugetlb(Huge Page Tables) allocations * Returns: The number of stats provided or -1 in case of failure. */ int diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index f48d9256e4..2d849beac8 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20245,6 +20245,8 @@ qemuDomainGetStatsBalloon(virQEMUDriverPtr driver, STORE_MEM_RECORD(LAST_UPDATE, "last-update") STORE_MEM_RECORD(USABLE, "usable") STORE_MEM_RECORD(DISK_CACHES, "disk_caches") + STORE_MEM_RECORD(HUGETLB_PGALLOC, "hugetlb_pgalloc") + STORE_MEM_RECORD(HUGETLB_PGFAIL, "hugetlb_pgfail") } #undef STORE_MEM_RECORD diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index 908967f46c..5e3df5e759 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -2150,6 +2150,11 @@ int qemuMonitorJSONGetMemoryStats(qemuMonitorPtr mon, VIR_DOMAIN_MEMORY_STAT_LAST_UPDATE, 1); GET_BALLOON_STATS(statsdata, "stat-disk-caches", VIR_DOMAIN_MEMORY_STAT_DISK_CACHES, 1024); + GET_BALLOON_STATS(statsdata, "stat-htlb-pgalloc", + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC, 1); + GET_BALLOON_STATS(statsdata, "stat-htlb-pgfail", + VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL, 1); + ret = got; cleanup: virJSONValueFree(cmd); diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index d87475f6f6..0092a9786e 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -376,6 +376,10 @@ cmdDomMemStat(vshControl *ctl, const vshCmd *cmd) vshPrint(ctl, "last_update %llu\n", stats[i].val); if (stats[i].tag == VIR_DOMAIN_MEMORY_STAT_DISK_CACHES) vshPrint(ctl, "disk_caches %llu\n", stats[i].val); + if (stats[i].tag == VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGALLOC) + vshPrint(ctl, "hugetlb_pgalloc %llu\n", stats[i].val); + if (stats[i].tag == VIR_DOMAIN_MEMORY_STAT_HUGETLB_PGFAIL) + vshPrint(ctl, "hugetlb_pgfail %llu\n", stats[i].val); } ret = true; diff --git a/tools/virsh.pod b/tools/virsh.pod index afc1684db0..ef27c527d6 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -938,6 +938,8 @@ without causing host swapping (in KiB) last-update - Timestamp of the last update of statistics (in seconds) disk_caches - The amount of memory that can be reclaimed without additional I/O, typically disk caches (in KiB) + hugetlb_pgalloc - The number of successful huge page table allocations + hugetlb_pgfail - The number of failed huge page table allocations For QEMU/KVM with a memory balloon, setting the optional I<--period> to a value larger than 0 in seconds will allow the balloon driver to return -- 2.20.1

1 0

[libvirt] Plans for next release
by Daniel Veillard 26 Apr '19

26 Apr '19

I think we need to enter freeze soon if we want to release mid next week if we do so tomorrow, then we can push rc2 on Monday and have a release around May first. Any problem with that plan ? thanks, Daniel -- Daniel Veillard | Red Hat Developers Tools http://developer.redhat.com/ veillard(a)redhat.com | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | virtualization library http://libvirt.org/

2 1

[libvirt] [PATCH] storage: escape ipv6 for ceph mon hosts to librados
by Yi Li 26 Apr '19

26 Apr '19

Hosts for rbd are ceph monitor daemons. These have fixed IP addresses, so they are often referenced by IP rather than hostname for convenience, or to avoid relying on DNS. Using IPv4 addresses as the host name works already, but IPv6 addresses require rbd-specific escaping because the colon is used as an option separator in the string passed to librados. Escape these colons, and enclose the IPv6 address in square brackets so it is distinguished from the port, which is currently mandatory. Signed-off-by: Yi Li <yili(a)winhong.com> --- docs/schemas/storagepool.rng | 5 ++++- src/storage/storage_backend_rbd.c | 13 ++++++++++--- tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml | 13 +++++++++++++ tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml | 16 ++++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 5 files changed, 44 insertions(+), 4 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng index 3ca8e79..976a02b 100644 --- a/docs/schemas/storagepool.rng +++ b/docs/schemas/storagepool.rng @@ -305,7 +305,10 @@ <oneOrMore> <element name='host'> <attribute name='name'> - <text/> + <choice> + <ref name="dnsName"/> + <ref name="ipAddr"/> + </choice> </attribute> <optional> <attribute name='port'> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index f8c968e..3056563 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -268,9 +268,16 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRBDStatePtr ptr, source->hosts[i].name); } else if (source->hosts[i].name != NULL && source->hosts[i].port) { - virBufferAsprintf(&mon_host, "%s:%d,", - source->hosts[i].name, - source->hosts[i].port); + /* assume host containing : is ipv6 */ + if (strchr(source->hosts[i].name, ':')) { + virBufferAsprintf(&mon_host, "[%s]:%d,", + source->hosts[i].name, + source->hosts[i].port); + } else { + virBufferAsprintf(&mon_host, "%s:%d,", + source->hosts[i].name, + source->hosts[i].port); + } } else { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("received malformed monitor, check the XML definition")); diff --git a/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml new file mode 100644 index 0000000..0744b33 --- /dev/null +++ b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml @@ -0,0 +1,13 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <source> + <name>rbd</name> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <auth username='admin' type='ceph'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml new file mode 100644 index 0000000..cc2a379 --- /dev/null +++ b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml @@ -0,0 +1,16 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <capacity unit='bytes'>0</capacity> + <allocation unit='bytes'>0</allocation> + <available unit='bytes'>0</available> + <source> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <name>rbd</name> + <auth type='ceph' username='admin'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c index 2ae514f..b6f4cb4 100644 --- a/tests/storagepoolxml2xmltest.c +++ b/tests/storagepoolxml2xmltest.c @@ -95,6 +95,7 @@ mymain(void) DO_TEST("pool-zfs-sourcedev"); DO_TEST("pool-rbd"); #ifdef WITH_STORAGE_RBD + DO_TEST("pool-rbd-ipv6"); DO_TEST("pool-rbd-refresh-volume-allocation"); DO_TEST("pool-rbd-ns-configopts"); #endif -- 2.7.5

2 1

[libvirt] [PATCH] virsh: Put a new line char after <alias/> in attach-disk
by Michal Privoznik 26 Apr '19

26 Apr '19

Each attribute is on its own line. We forgot to add new line character for <alias/> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- Pushed under trivial rule. tools/virsh-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index da57d96d1a..82140feb57 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -683,7 +683,7 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd) virBufferAsprintf(&buf, "<serial>%s</serial>\n", serial); if (alias) - virBufferAsprintf(&buf, "<alias name='%s'/>", alias); + virBufferAsprintf(&buf, "<alias name='%s'/>\n", alias); if (wwn) virBufferAsprintf(&buf, "<wwn>%s</wwn>\n", wwn); -- 2.21.0

1 0

[libvirt] [PATCH 0/2] Couple of interface type fixes
by Michal Privoznik 26 Apr '19

26 Apr '19

See the following link for more info: https://www.redhat.com/archives/libvir-list/2019-April/msg01412.html Be aware that these are very hackish and I don't like them. There's still one problem - virsh domiftune still doesn't work, as in it doesn't set floor on the network bridge because the code expects interface type of network but it sees type bridge. Michal Prívozník (2): conf: Parse bandwidth.floor for interface type='bridge' too qemu: Relax interface type change check when changing an interface src/conf/domain_conf.c | 7 ++++--- src/qemu/qemu_hotplug.c | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) -- 2.21.0

1 2

[libvirt] RFC: Introducing Memory Bandwidth Monitoring (MBM)
by Huaqiang,Wang 26 Apr '19

26 Apr '19

RFC: Introducing Memory Bandwidth Monitoring (MBM) ================================================== Kernel has removed the interfaces of getting memory bandwidth utilization interfaces from `perf` sub-module, refer to https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id…. Afterwards, kernel implements the `resctrl` sub-module and provides the alternative interfaces to allocate/monitor resource of cache/memory bandwidth. The cache monitoring based on `resctr` interface is already implemented, this RFC is to raise discussion on implement the memory bandwidth monitoring functionality. Very similar to the way of implementing 'cache monitoring', to support memory bandwidth monitoring, it could be considered in three aspects: * Identifying the host capability for MBM * Creating MBM groups * Reporting the result of the monitoring Identify the host capability of MBM ----------------------------------- Host MBM feature coud be identified through the standard way of enumerating host capability, such as command `virsh capability <domain>`. A host with MBM, the result of command above may contain following lines:: <capabilities> <host> … <cache> <bank id='0' level='3' type='both' size='15' unit='MiB' cpus='0-5'> <control granularity='768' min='1536' unit='KiB' type='both' maxAllocs='4'/> </bank> <monitor level='3' reuseThreshold='270336' maxMonitors='176'> <feature name='llc_occupancy'/> </monitor> </cache> <memory_bandwidth> <node id='0' cpus='0-5'> <control granularity='10' min ='10' maxAllocs='4'/> </node> <node id='1' cpus='6-11'> <control granularity='10' min ='10' maxAllocs='4'/> </node> + <monitor maxMonitors='176'> + <feature name='mbm_total_bytes'/> + <feature name='mbm_local_bytes'/> + </monitor> </memory_bandwidth> </host> </capabilities> The <monitor> element under <memory_bandwidth> indicates a memory bandwidth monitor exists, and the property 'maxMonitors' tells how many monitors could be generated, which is shared with cache monitor. The feature list inside the <monitor> element indicates MBM feature set. Create the MBM group -------------------- It is supported to create multiple monitors to a vm instance and each monitor is capable to track the memory bandwidth utilization accumulatively in bytes for specific vCPUs. To create a memory bandwidth monitor for specific vCPUs, for example create 2 memory bandwidth monitors, one is tracking the memory BW usage for vCPU0 and another is for vCPU 0-4, then you can set the request for two monitors in following way by editing the domain XML file:: <cputune> <memorytune vcpus='0-4'> <node id='0' bandwidth='20'/> <node id='1' bandwidth='30'/> + <monitor vcpus='0-4'/> + <monitor vcpus='0'/> </memorytune> </cputune> Report the result of monitor ---------------------------- The statistical results of memory bandwidth monitors could be demonstrated through command `virsh domstat <doman>` in following arrangement. virsh domstats <domain>:: ... memory.bw.monitor.count=<total number of MBM monitors> memory.bw.monitor.<monitor index>.name=<resctrl group name for this monitor> memory.bw.monitor.<monitor index>.vcpus=<vcpu set list monitored by this monitor> memory.bw.monitor.<monitor index>.controller.count=<memory controller number> memory.bw.monitor.<monitor index>.controller.<index>.local.bytes=<bytes> memory.bw.monitor.<monitor index>.controller.<index>.total.bytes=<bytes> ...

1 0

[libvirt] [PATCH] Handle copying bitmaps to larger data buffers
by Allen, John 25 Apr '19

25 Apr '19

If a bitmap of a shorter length than the data buffer is passed to virBitmapToDataBuf, it will read off the end of the bitmap and copy junk into the returned buffer. Add a check to only copy the length of the bitmap to the buffer. The problem can be observed after setting a vcpu affinity using the vcpupin command on a system with a large number of cores: # virsh vcpupin example_domain 0 0 # virsh vcpupin example_domain 0 VCPU CPU Affinity --------------------------- 0 0,192,197-198,202 Signed-off-by: John Allen <john.allen(a)amd.com> --- diff --git a/src/util/virbitmap.c b/src/util/virbitmap.c index d074f29e54..021174cbb3 100644 --- a/src/util/virbitmap.c +++ b/src/util/virbitmap.c @@ -824,11 +824,15 @@ virBitmapToDataBuf(virBitmapPtr bitmap, unsigned char *bytes, size_t len) { + size_t nbytes = bitmap->map_len * (VIR_BITMAP_BITS_PER_UNIT / CHAR_BIT); unsigned long *l; size_t i, j; memset(bytes, 0, len); + /* If bitmap and buffer differ in size, only fill to the smaller length */ + len = MIN(len, nbytes); + /* htole64 is not provided by gnulib, so we do the conversion by hand */ l = bitmap->map; for (i = j = 0; i < len; i++, j++) {

3 3

[libvirt] [PATCH] cpu_map: Add support for cldemote CPU feature
by Jiri Denemark 25 Apr '19

25 Apr '19

Added in QEMU by v2.12.0-481-g0da0fb0628 (released in 3.0). Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com> --- src/cpu_map/x86_features.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/cpu_map/x86_features.xml b/src/cpu_map/x86_features.xml index 02431bea29..efcc10b1ae 100644 --- a/src/cpu_map/x86_features.xml +++ b/src/cpu_map/x86_features.xml @@ -310,6 +310,9 @@ <feature name='la57'> <cpuid eax_in='0x07' ecx_in='0x00' ecx='0x00010000'/> </feature> + <feature name='cldemote'> + <cpuid eax_in='0x07' ecx_in='0x00' ecx='0x02000000'/> + </feature> <feature name='avx512-4vnniw'> <cpuid eax_in='0x07' ecx_in='0x00' edx='0x00000004'/> -- 2.21.0

2 1

[libvirt] [PATCH v4 0/3] Don't pm suspend guest if it's unable to wake up
by Daniel Henrique Barboza 25 Apr '19

25 Apr '19

changes from v3: - patch 3 removed. We no longer consider PM_WAKEUP_SUPPORT a cap. It is confusing to have a 'runtime cap' that can't be resolved inside qemu_capabilities.c. The suspend operation isn't time critical per se, and a call to QMP each time 'virsh dompmsuspend' is executed is not dreadful to the user experience. More information and discussion can be found at [1]. - due to the change above, patch 4 now executes the query-current-machine QMP call (if the running QEMU instance supports it) during qemuDomainPMSuspendForDuration to check if the guest has wakeup support. - previous patch link: [1] https://www.redhat.com/archives/libvir-list/2019-April/msg00767.html Daniel Henrique Barboza (2): qemu_capabilities: Add QEMU_CAPS_QUERY_CURRENT_MACHINE qemuDomainPMSuspendForDuration: check for wake-up support Michal Prívozník (1): qemu_monitor: Introduce handler for 'query-current-machine' command src/qemu/qemu_capabilities.c | 2 + src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_driver.c | 54 +++++++++++++++++++ src/qemu/qemu_monitor.c | 10 ++++ src/qemu/qemu_monitor.h | 9 ++++ src/qemu/qemu_monitor_json.c | 50 +++++++++++++++++ src/qemu/qemu_monitor_json.h | 5 ++ .../caps_4.0.0.riscv32.xml | 1 + .../caps_4.0.0.riscv64.xml | 1 + .../caps_4.0.0.x86_64.xml | 1 + 10 files changed, 134 insertions(+) -- 2.20.1

2 7

[libvirt] [PATCH] vircgroup: no need to ifdef virCgroupFree
by Pavel Hrdina 25 Apr '19

25 Apr '19

virCgroup struct is always defined and the free function is not calling anything that would require OS supporting cgroups. This fixes an issue if we try to start a VM with QEMU binary that doesn't support QXL. The start operation will fail in qemuProcessStartValidateVideo() which will set correct error message, but later in one of the cleanup paths we will call qemuDomainObjPrivateDataClear() which always calls virCgroupFree() and that will fail on OS that doesn't support cgroups and it will set a new error which will be eventually reported to user. Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com> --- src/util/vircgroup.c | 62 +++++++++++++++++++------------------------- 1 file changed, 27 insertions(+), 35 deletions(-) diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 4238d7014b..f58e336404 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -1279,33 +1279,6 @@ virCgroupNewIgnoreError(void) } -/** - * virCgroupFree: - * - * @group: The group structure to free - */ -void -virCgroupFree(virCgroupPtr *group) -{ - size_t i; - - if (*group == NULL) - return; - - for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { - VIR_FREE((*group)->legacy[i].mountPoint); - VIR_FREE((*group)->legacy[i].linkPoint); - VIR_FREE((*group)->legacy[i].placement); - } - - VIR_FREE((*group)->unified.mountPoint); - VIR_FREE((*group)->unified.placement); - - VIR_FREE((*group)->path); - VIR_FREE(*group); -} - - /** * virCgroupHasController: query whether a cgroup controller is present * @@ -2917,14 +2890,6 @@ virCgroupNewIgnoreError(void) } -void -virCgroupFree(virCgroupPtr *group ATTRIBUTE_UNUSED) -{ - virReportSystemError(ENXIO, "%s", - _("Control groups not supported on this platform")); -} - - bool virCgroupHasController(virCgroupPtr cgroup ATTRIBUTE_UNUSED, int controller ATTRIBUTE_UNUSED) @@ -3565,6 +3530,33 @@ virCgroupControllerAvailable(int controller ATTRIBUTE_UNUSED) #endif /* !__linux__ */ +/** + * virCgroupFree: + * + * @group: The group structure to free + */ +void +virCgroupFree(virCgroupPtr *group) +{ + size_t i; + + if (*group == NULL) + return; + + for (i = 0; i < VIR_CGROUP_CONTROLLER_LAST; i++) { + VIR_FREE((*group)->legacy[i].mountPoint); + VIR_FREE((*group)->legacy[i].linkPoint); + VIR_FREE((*group)->legacy[i].placement); + } + + VIR_FREE((*group)->unified.mountPoint); + VIR_FREE((*group)->unified.placement); + + VIR_FREE((*group)->path); + VIR_FREE(*group); +} + + int virCgroupDelThread(virCgroupPtr cgroup, virCgroupThreadName nameval, -- 2.20.1

2 1

[libvirt] [PATCH] storage: escape ipv6 for ceph mon hosts to librados
by winhong-yili 25 Apr '19

25 Apr '19

Hosts for rbd are ceph monitor daemons. These have fixed IP addresses, so they are often referenced by IP rather than hostname for convenience, or to avoid relying on DNS. Using IPv4 addresses as the host name works already, but IPv6 addresses require rbd-specific escaping because the colon is used as an option separator in the string passed to librados. Escape these colons, and enclose the IPv6 address in square brackets so it is distinguished from the port, which is currently mandatory. Signed-off-by: Yi Li <yili(a)winhong.com> --- docs/schemas/storagepool.rng | 5 ++++- src/storage/storage_backend_rbd.c | 13 ++++++++++--- tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml | 13 +++++++++++++ tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml | 16 ++++++++++++++++ tests/storagepoolxml2xmltest.c | 1 + 5 files changed, 44 insertions(+), 4 deletions(-) create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng index 3ca8e79..976a02b 100644 --- a/docs/schemas/storagepool.rng +++ b/docs/schemas/storagepool.rng @@ -305,7 +305,10 @@ <oneOrMore> <element name='host'> <attribute name='name'> - <text/> + <choice> + <ref name="dnsName"/> + <ref name="ipAddr"/> + </choice> </attribute> <optional> <attribute name='port'> diff --git a/src/storage/storage_backend_rbd.c b/src/storage/storage_backend_rbd.c index f8c968e..3056563 100644 --- a/src/storage/storage_backend_rbd.c +++ b/src/storage/storage_backend_rbd.c @@ -268,9 +268,16 @@ virStorageBackendRBDOpenRADOSConn(virStorageBackendRBDStatePtr ptr, source->hosts[i].name); } else if (source->hosts[i].name != NULL && source->hosts[i].port) { - virBufferAsprintf(&mon_host, "%s:%d,", - source->hosts[i].name, - source->hosts[i].port); + /* assume host containing : is ipv6 */ + if (strchr(source->hosts[i].name, ':')) { + virBufferAsprintf(&mon_host, "[%s]:%d,", + source->hosts[i].name, + source->hosts[i].port); + } else { + virBufferAsprintf(&mon_host, "%s:%d,", + source->hosts[i].name, + source->hosts[i].port); + } } else { virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("received malformed monitor, check the XML definition")); diff --git a/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml new file mode 100644 index 0000000..0744b33 --- /dev/null +++ b/tests/storagepoolxml2xmlin/pool-rbd-ipv6.xml @@ -0,0 +1,13 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <source> + <name>rbd</name> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <auth username='admin' type='ceph'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml new file mode 100644 index 0000000..cc2a379 --- /dev/null +++ b/tests/storagepoolxml2xmlout/pool-rbd-ipv6.xml @@ -0,0 +1,16 @@ +<pool type='rbd'> + <name>ceph</name> + <uuid>47c1faee-0207-e741-f5ae-d9b019b98fe2</uuid> + <capacity unit='bytes'>0</capacity> + <allocation unit='bytes'>0</allocation> + <available unit='bytes'>0</available> + <source> + <host name='localhost' port='6789'/> + <host name='localhost' port='6790'/> + <host name='2205::192:168:205:141' port='6789'/> + <name>rbd</name> + <auth type='ceph' username='admin'> + <secret uuid='2ec115d7-3a88-3ceb-bc12-0ac909a6fd87'/> + </auth> + </source> +</pool> diff --git a/tests/storagepoolxml2xmltest.c b/tests/storagepoolxml2xmltest.c index 2ae514f..b6f4cb4 100644 --- a/tests/storagepoolxml2xmltest.c +++ b/tests/storagepoolxml2xmltest.c @@ -95,6 +95,7 @@ mymain(void) DO_TEST("pool-zfs-sourcedev"); DO_TEST("pool-rbd"); #ifdef WITH_STORAGE_RBD + DO_TEST("pool-rbd-ipv6"); DO_TEST("pool-rbd-refresh-volume-allocation"); DO_TEST("pool-rbd-ns-configopts"); #endif -- 2.7.5

1 0

[libvirt] [PATCH] conf: add cpu check attribute to ABI check
by Nikolay Shirokovskiy 24 Apr '19

24 Apr '19

Different check values is not ABI compatible. For example if on migration we change 'full' to 'partial' then guest cpu on destination can be different. Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy(a)virtuozzo.com> --- src/conf/cpu_conf.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index 33c8b99..bd2beab 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -894,6 +894,13 @@ virCPUDefIsEqual(virCPUDefPtr src, goto cleanup; } + if (src->check != dst->check) { + MISMATCH(_("Target CPU check %s does not match source %s"), + virCPUCheckTypeToString(dst->check), + virCPUCheckTypeToString(src->check)); + goto cleanup; + } + if (src->arch != dst->arch) { MISMATCH(_("Target CPU arch %s does not match source %s"), virArchToString(dst->arch), -- 1.8.3.1

2 1

[libvirt] JVM crashes during GC
by Sachin Soman 24 Apr '19

24 Apr '19

Hi, Could you tell me if the following is some known issue? While performing the following simple test, I see my JVM crashing (consistently): 1. Open a connection to an ESXi driver/host (passing ConnectAuthDefault instance). 2. Close the connection. 3. Invoke GC When GC is triggered, at some point, some unallocated native memory is being tried to release. That's failing. The error thrown is: java(78745,0x70000241e000) malloc: *** error for object 0x7fd5df561390: pointer being freed was not allocated *** set a breakpoint in malloc_error_break to debug Frames from core dump: frame #0: 0x00007fff5b274b66 libsystem_kernel.dylib`__pthread_kill + 10 frame #1: 0x00007fff5b43f080 libsystem_pthread.dylib`pthread_kill + 333 frame #2: 0x00007fff5b1d01ae libsystem_c.dylib`abort + 127 frame #3: 0x00007fff5b2ce8a6 libsystem_malloc.dylib`free + 521 frame #4: 0x00000001127f43a7 frame #5: 0x00000001127e3ffd frame #6: 0x00000001127e3ffd frame #7: 0x00000001127e3ffd frame #8: 0x00000001127e3ffd frame #9: 0x00000001127e4042 frame #10: 0x00000001127e3ffd frame #11: 0x00000001127e3ffd frame #12: 0x00000001127dc4e7 frame #13: 0x000000010c0e235e libjvm.dylib`JavaCalls::call_helper(JavaValue*, methodHandle*, JavaCallArguments*, Thread*) + 1710 frame #14: 0x000000010c0e2b02 libjvm.dylib`JavaCalls::call_virtual(JavaValue*, KlassHandle, Symbol*, Symbol*, JavaCallArguments*, Thread*) + 356 frame #15: 0x000000010c0e2cae libjvm.dylib`JavaCalls::call_virtual(JavaValue*, Handle, KlassHandle, Symbol*, Symbol*, Thread*) + 74 frame #16: 0x000000010c1208ee libjvm.dylib`thread_entry(JavaThread*, Thread*) + 124 frame #17: 0x000000010c33e84d libjvm.dylib`JavaThread::thread_main_inner() + 155 frame #18: 0x000000010c33ff12 libjvm.dylib`JavaThread::run() + 448 frame #19: 0x000000010c26058a libjvm.dylib`java_start(Thread*) + 246 frame #20: 0x00007fff5b43c661 libsystem_pthread.dylib`_pthread_body + 340 frame #21: 0x00007fff5b43c50d libsystem_pthread.dylib`_pthread_start + 377 frame #22: 0x00007fff5b43bbf9 libsystem_pthread.dylib`thread_start + 13 I have installed Libvirt 5.2.0. Java bindings libvirt-java 0.5.1 JNA 4.0.0 Tested Java environments: Oracle Java 8 and OpenJDK 8 on MAC, OpenJDK 11 on Ubuntu 16 Thanks & Regards Sachin Soman

3 11

[libvirt] [PATCH] networkStartNetworkVirtual: Don't overwrite error in 'err5'
by Michal Privoznik 23 Apr '19

23 Apr '19

If there's an error when setting up QoS on a bridge the control jumps over to 'err5' label. Here, the virNetDevBandwidthClear() is called to clear out any partially set QoS. This function can also report an error which would overwrite the actual error that caused us jumping here. 🤦 Use virErrorPreserveLast() to preserve the original error. Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com> --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index ce4f4890f1..77206b4584 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2493,6 +2493,7 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, return 0; err5: + virErrorPreserveLast(&save_err); if (def->bandwidth) virNetDevBandwidthClear(def->bridge); -- 2.21.0

2 3

[libvirt] [PATCH 0/3] Emit event on lease attach/detach
by Michal Privoznik 23 Apr '19

23 Apr '19

Unfortunately, we can't emit VIR_DOMAIN_EVENT_ID_DEVICE_ADDED or VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event because that carries device alias within itself and leases don't have one. Michal Prívozník (3): qemuDomainAttachDeviceLive: Rework event emitting Introduce VIR_DOMAIN_EVENT_ID_LEASE_CHANGE qemu: Emit event on lease attach/detach examples/object-events/event-test.c | 34 +++++++++++ include/libvirt/libvirt-domain.h | 33 +++++++++++ src/conf/domain_event.c | 89 +++++++++++++++++++++++++++++ src/conf/domain_event.h | 12 ++++ src/libvirt_private.syms | 2 + src/qemu/qemu_driver.c | 43 +++++++------- src/qemu/qemu_hotplug.c | 7 +++ src/remote/remote_daemon_dispatch.c | 40 +++++++++++++ src/remote/remote_driver.c | 32 +++++++++++ src/remote/remote_protocol.x | 16 +++++- src/remote_protocol-structs | 8 +++ tools/virsh-domain.c | 31 ++++++++++ 12 files changed, 325 insertions(+), 22 deletions(-) -- 2.21.0

3 7

[libvirt] [PATCH v1] network: Convert to virErrorRestore/virErrorPreserveLast
by Syed Humaid 23 Apr '19

23 Apr '19

Replaced usage of virSaveLastError and virSetError/virFreeError with virErrorPreserveLast and virErrorRestore respectively. Signed-off-by: Syed Humaid <syedhumaidbinharoon(a)gmail.com> --- src/network/bridge_driver.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index f824b8b4f3..dc21ac642c 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -2495,7 +2495,7 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err4: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); dnsmasqPid = virNetworkObjGetDnsmasqPid(obj); if (dnsmasqPid > 0) { @@ -2505,18 +2505,18 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err3: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); ignore_value(virNetDevSetOnline(def->bridge, 0)); err2: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); if (def->forward.type != VIR_NETWORK_FORWARD_OPEN) networkRemoveFirewallRules(def); err1: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); if (macTapIfName) { VIR_FORCE_CLOSE(tapfd); @@ -2528,13 +2528,10 @@ networkStartNetworkVirtual(virNetworkDriverStatePtr driver, err0: if (!save_err) - save_err = virSaveLastError(); + virErrorPreserveLast(&save_err); ignore_value(virNetDevBridgeDelete(def->bridge)); - if (save_err) { - virSetError(save_err); - virFreeError(save_err); - } + virErrorRestore(&save_err); /* coverity[leaked_handle] - 'tapfd' is not leaked */ return -1; } -- 2.20.1

2 1

[libvirt] [PATCH 0/3] Couple of mem leak fixes
by Michal Privoznik 23 Apr '19

23 Apr '19

*** BLURB HERE *** Michal Prívozník (3): qemucaps2xmltest: Don't leak @binary libxlDriverConfigDispose: Free @configBaseDir too vmx: Free @firmware in virVMXParseConfig src/libxl/libxl_conf.c | 1 + src/vmx/vmx.c | 1 + tests/qemucaps2xmltest.c | 3 +-- 3 files changed, 3 insertions(+), 2 deletions(-) -- 2.21.0

3 6

[libvirt] [PATCH 0/3] qemu: monitor: detect more snapshot errors
by Cole Robinson 23 Apr '19

23 Apr '19

qemu in Fedora 30 rejects migration if the VM has nested VMX configured. This means managedsave and snapshots are rejected too. Unfortunately the scraping we need to resort to with the text monitor snapshot commands is not detecting that 'savevm' actually failed, so the snapshot appears to succeed. https://bugzilla.redhat.com/show_bug.cgi?id=1697997 qemu 4.0.0 will add an 'Error: ' prefix to most hmp command errors (qemu commit 66363e9a43f), let's use that to detect error as well Cole Robinson (3): qemu: monitor: cleanup loadvm error handling qemu: monitor cleanup delvm error handling qemu: monitor: check for common 'Error: ' string src/qemu/qemu_monitor_text.c | 39 ++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 19 deletions(-) -- 2.21.0

2 4

[libvirt] New Feature: Intel MKTME Support
by Carvalho, Larkins L 23 Apr '19

23 Apr '19

Hello Team, Greetings. We want to add Intel MKTME support to the Libvirt. Intel MKTME is a capability to encrypt entirety of physical memory of a system similar to AMD SEV. Please let us know what are the expectations from us to initiate the design and development of the feature. Regards, Larkins Carvalho Intel Corporation

5 15

[libvirt] [PATCH] news: add note about optional "Removed features" section
by Daniel P. Berrangé 18 Apr '19

18 Apr '19

Most releases don't need a "Removed features" section so don't include it in the template by default, but leave a reminder in case it is relevant. Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com> --- docs/news.xml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index b4926dd906..5346a25132 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -30,6 +30,12 @@ </section> </release> + If relevant for a given release, add a section for removed + features too + + <section title="Removed features"> + </section> + --> <libvirt> -- 2.20.1

2 1

[libvirt] [PATCH v3 0/2] qemu: Honor memory mode='strict'
by Michal Privoznik 18 Apr '19

18 Apr '19

v3 of: diff to v2: - Not calling qemuSetupCpusetMems() in qemuProcessLaunch - Dropping qemuSetupCpusetMems() Michal Prívozník (2): qemu: Set up EMULATOR thread and cpuset.mems before exec()-ing qemu qemu_cgroup: Remove unused qemuSetupCpusetMems src/qemu/qemu_cgroup.c | 35 ----------------------------------- src/qemu/qemu_cgroup.h | 1 - src/qemu/qemu_process.c | 8 ++++---- 3 files changed, 4 insertions(+), 40 deletions(-) -- 2.21.0

2 3

[libvirt] [PATCH 0/4] qemu_hotplug: Check for duplicate drive addresses
by Michal Privoznik 18 Apr '19

18 Apr '19

This is an alternative approach to: https://www.redhat.com/archives/libvir-list/2019-March/msg01111.html which caused regression to which a proposed fix is here: https://www.redhat.com/archives/libvir-list/2019-April/msg00756.html One of the selling points was that having this check in virDomainDefCompatibleDevice() will fix the problem across all drivers. Well, turns out, some drivers don't care (e.g. lxc) and some have a different workflow and thus don't need that check. Michal Prívozník (4): conf: Expose virDomainSCSIDriveAddressIsUsed qemuhotplugtest: Don't plug a SCSI disk at unit 7 qemu_hotplug: Check for duplicate drive addresses Revert "domain_conf: check device address before attach" src/conf/domain_conf.c | 11 +---------- src/conf/domain_conf.h | 4 ++++ src/libvirt_private.syms | 1 + src/qemu/qemu_hotplug.c | 6 ++++++ tests/qemuhotplugtest.c | 2 +- .../qemuhotplug-disk-scsi-2.xml | 2 +- ...-base-without-scsi-controller-live+disk-scsi-2.xml | 4 ++-- 7 files changed, 16 insertions(+), 14 deletions(-) -- 2.21.0

3 10